Home | Search | chromium - Builders
Login

Builder Android WebView O NetworkService (dbg) Build 431 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision28d424ea311f180535b9a5aceb6facfc61c9b59e
Got Revision28d424ea311f180535b9a5aceb6facfc61c9b59e

Execution:

Steps and Logfiles:

Show:
  1. ( 330 ms ) setup_build
    running recipe: "chromium"
  2. ( 225 ms ) report builders
     
    running tester 'Android WebView O NetworkService (dbg)' on master 'chromium.android.fyi'
  3. ( 52 secs ) bot_update
    [60GB/295GB used (20%)]
  4. ( 594 ms ) swarming.py --version
    0.14
  5. ( 13 secs ) gclient runhooks
  6. ( 665 ms ) read test spec (chromium.android.fyi.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.android.fyi.json
  7. ( 459 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  8. ( 3 secs ) clean local files
  9. ( 266 ms ) tree truth steps
  10. ( 450 ms ) build directory
  11. ( 435 ms ) find isolated tests
  12. ( 7 mins 12 secs ) webview_cts_tests on Android device Pixel 2
    Run on OS: 'Android'
    Max pending time: 0:04:39.650499 (shard #2)
    Max shard duration: 0:03:53.544778 (shard #1)
    Min shard duration: 0:02:28.605573 (shard #2)
    Total tests: n/a
     
  13. ( 219 ms ) Tests statistics
     
    Stats
    Total shards: 3
    Total runtime: 0:08:19.209461
     
  14. ( 245 ms ) test_report

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "gce-trusty-e833d7b0-us-west1-c-4rk0" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544168119892232, "id": "8927816085474370784", "project": "chromium", "tags": ["builder:Android WebView O NetworkService (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/28d424ea311f180535b9a5aceb6facfc61c9b59e", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm64 Builder (dbg)", "parent_buildnumber:34445", "scheduler_invocation_id:9093246147659426320", "scheduler_job_id:chromium/Android WebView O NetworkService (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android WebView O NetworkService (dbg)" setup_build
buildnumber 431 setup_build
mastername "chromium.android.fyi" setup_build
parent_buildername "Android arm64 Builder (dbg)" setup_build
parent_got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" setup_build
parent_got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" setup_build
parent_got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" setup_build
parent_got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" setup_build
parent_got_revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" setup_build
parent_got_revision_cp "refs/heads/master@{#614622}" setup_build
parent_got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" setup_build
parent_got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" setup_build
parent_got_v8_revision_cp "refs/heads/7.3.56@{#1}" setup_build
parent_got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25919}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" setup_build
swarm_hashes {"android_webview_unittests": "c76fc31e78d0c32c0043ca67b75cca231487e679", "angle_unittests": "0e9cfd035c59b0b26c527ef7d1763c01a51e44eb", "base_unittests": "1a1435f590992a8530eb3bb179a164b50b2e4bc5", "blink_common_unittests": "c5ec6d90a917c312e5a5f122bda72028a80aed38", "blink_heap_unittests": "b1b327ee437a51bb91c56b03698085a9ca68fe5a", "blink_platform_unittests": "6a81410efd093d6f73b2305800cd9d635853a9ac", "boringssl_crypto_tests": "2cacbf668613d43636077f9041cc29668a4b8ec8", "boringssl_ssl_tests": "f971a6eced170e7992b84dbc466ed6d45dda3fde", "breakpad_unittests": "0b2793b9218551e4007692d0963e7064e9e3d92f", "cacheinvalidation_unittests": "2d123bdc69bc3d4002db0d7d686ce843ee3e3c23", "capture_unittests": "7f06f0859327b76e3660b89d18cef5fac35f2c39", "cast_unittests": "28d6763f8a5893ea5aab331deff3a67885878747", "cc_unittests": "e01e2d92b426bcbe931951f9f8c818676f1525be", "chrome_public_test_apk": "27a3c0622835136d71eb7521456584bf0c339637", "chrome_public_test_vr_apk": "b30abbbbc5f5dc6c74b38b01baa894d9bf6dce94", "components_browsertests": "ad7640588cdd734c7cf3840b9f46e1b914ec7546", "components_unittests": "0983daa6c6d1df333cffa69928534653c34bb187", "content_browsertests": "20100ac5242af089929b6266dbd9d67ccf2b2923", "content_shell_test_apk": "1432fdfacf19f574f7dec51f8a3420dd8449d923", "content_unittests": "dad31bef2e1eb0edc8600b6d580ebd66f939afe1", "crypto_unittests": "6c5835d4b3a529dd0e0a247405391f2735588bc3", "device_unittests": "f1f4d958744e2da328cc9582a3d61fee613fd070", "display_unittests": "5930508f797ecdfea16c0e51d2b13ea59438edf6", "events_unittests": "28499016fae37c910e38a16338536ef22c580d28", "gcm_unit_tests": "9d3b40120ab643138f4c2275fe2a46b77177d865", "gfx_unittests": "989b74b8ce37b568945886beaa8f3e4ff6ba50a1", "gin_unittests": "6e3340310730dd461f6609765f38cac77ff42677", "gl_tests": "820402583b398e5f296bb768f6c2db66d60963f9", "gl_unittests": "f3e7445df3f2e83594ce8657c2ae36f2d8d73682", "google_apis_unittests": "bddcfc90fa80d04729034107e5edbdfa470f6b05", "gpu_unittests": "d177ac2635959300a83891084abd75952a38aa4a", "ipc_tests": "44ed8763c4f1498840c37848deb22c6db6f233ba", "jingle_unittests": "824f501ff21c2985393faa9798b94d398fcd7ac9", "latency_unittests": "2af071a8a1b6c7cc999a4f8879fa3aba274fcbad", "libjingle_xmpp_unittests": "df4d355d80d241500c9d8d7d71a3aae21ebcd8bb", "media_blink_unittests": "88b26d0ba9d3f7e40fa4b41ef4f79f43e6bee5e0", "media_service_unittests": "6309f55812a77a218dfb3f6e811c64f403084367", "media_unittests": "5ebb4a0e8d8538fb66a7f78ff746fc41cf57e60f", "midi_unittests": "d2a20724caca1a77ce3cd8cb8c6b90a3d87101ac", "mojo_test_apk": "27b9625ed39070277b1d98640ac7eaf949622795", "mojo_unittests": "2327b5b007cd42815b194ac4d50fc543a3d8aec6", "monochrome_public_test_ar_apk": "8e73eaed23755f53ad92c27b2188bd88d0ed5789", "net_unittests": "6c1293f6802d3f861f21ff64c83c31997cd3b62c", "sandbox_linux_unittests": "3e7be3f298bd0b250a7d0fbe09bf6694c36cd3e0", "services_unittests": "cb7cdae893effc4332cbd3a26383c24e87dd79de", "shell_dialogs_unittests": "9ab4fdbd4b5ba9bf89b1424950562c7c18f842bb", "skia_unittests": "767783dea81c48646b3e7fc995cd44f18cdae12c", "sql_unittests": "ba8575f360cb793864b6353a4248fbc91fd7287c", "storage_unittests": "f783047b6dbb5c10c1c7199f34cf88de831dbe19", "ui_android_unittests": "a0eb45f9ce021e213de3ce8ed3bab5157bb120b8", "ui_base_unittests": "f86f85b97ac563bd019de49f77e9d0cb4ed5e7bc", "ui_touch_selection_unittests": "32565cc99c51908fc3bed2b94b68cdb8d077c9e3", "unit_tests": "735d2312ff9ce79c180ed175c5ad3044c888e854", "url_unittests": "b1b1741b0259662f34ea5edeaaec1f9f0c42382b", "viz_unittests": "f593e1ade28ddd009260e39a0526f44f9d3cf145", "vr_android_unittests": "9d088b6c42c1e085b9bf03feff78fb6f141f0e17", "vr_common_unittests": "4f3fe9cc40e9422e0611b48785d0727499ecdef9", "vr_pixeltests": "22e460bd43d2f93d75330eea882961eed2f04ee6", "webkit_unit_tests": "d66e58b1ce7c6210de10298cdc79a9820a5ec705", "webview_cts_tests": "e45eb93354d323d06d8c3e3e6623231827935a79", "webview_instrumentation_test_apk": "bd612af24842599d84e44b4e61158a8b44b25031", "wtf_unittests": "196c5889cd077eae1832a8e259ce7cdbde690d71"} setup_build
got_angle_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update
got_buildtools_revision "7d88270de197ebe8b439ab5eb57a4a2a0bb810e0" bot_update
got_dawn_revision "0f50114b3c6849238eedf95236137d614fed4be2" bot_update
got_nacl_revision "8e13fe5e85640b063aefcb88a3ccb52abf6e28e8" bot_update
got_revision "28d424ea311f180535b9a5aceb6facfc61c9b59e" bot_update
got_revision_cp "refs/heads/master@{#614622}" bot_update
got_swarming_client_revision "0e3e1c4dc4e79f25a5b58fcbc135dc93183c0c54" bot_update
got_v8_revision "fd3bdfdac02db5d3ab67b707cfe9ca814947d18e" bot_update
got_v8_revision_cp "refs/heads/7.3.56@{#1}" bot_update
got_webrtc_revision "18f0c3c038fc45be6951301a3c2726e6810565d3" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25919}" bot_update
swarm_hashes {} find isolated tests

Blamelist:

  1. Alan Cutter (alancutterohnoyoudont@chromium.org)
  2. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  3. Kinuko Yasuda (kinukoohnoyoudont@chromium.org)
  4. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  5. Li Lin (llinohnoyoudont@chromium.org)
  6. Joel Hockey (joelhockeyohnoyoudont@chromium.org)
  7. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  8. Sam McNally (sammcohnoyoudont@chromium.org)
  9. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  10. Adam Rice (riceaohnoyoudont@chromium.org)
  11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Friday, 07-Dec-18 07:35:19 UTC
Start Friday, 07-Dec-18 07:36:07 UTC
End Friday, 07-Dec-18 07:44:54 UTC
Pending 47 secs
Execution 8 mins 46 secs

All Changes:

  1. Revert "Timer notification UI improvement:"

    Changed by Alan Cutter - alancutterohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:18:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 28d424ea311f180535b9a5aceb6facfc61c9b59e

    Comments

    Revert "Timer notification UI improvement:"
    
    This reverts commit d710a7b3ef59302c00c2e3fe1b00c788310801c6.
    
    Reason for revert: Broke compile:
    https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/59395
    ../../chromeos/services/assistant/assistant_manager_service_impl.cc:33:10: fatal error: 'libassistant/shared/internal_api/alarm_timer_types.h' file not found
    #include "libassistant/shared/internal_api/alarm_timer_types.h"
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Original change's description:
    > Timer notification UI improvement:
    > 
    > * Add timer deeplinks for:
    >   - Stop timer
    >   - Add time to timer
    > * Add "add 1 min to timer" button to timer notification.
    > 
    > Using a feature flag to guard the usage of the deeplink as
    > AlarmTimerManager is not fully available yet.
    > 
    > Bug: b:119116816
    > Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    > Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    > Commit-Queue: Li Lin <llin@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#614618}
    
    TBR=xiyuan@chromium.org,dcheng@chromium.org,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org,llin@chromium.org
    
    Change-Id: I8ece5ad7361e379880921e2abc55085d1de6cd88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: b:119116816
    Reviewed-on: https://chromium-review.googlesource.com/c/1367081
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614622}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  2. Report PreviewsEligibilityReason as offline when device is offline

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:11:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01c4f97005f6f162b3df6953b8f2a4efce338ec1

    Comments

    Report PreviewsEligibilityReason as offline when device is offline
    
    Currently, if the device is offline, PreviewsEligibilityReason
    records the reason for not showing previews as network quality
    unavailable.
    
    This CL changes it to record the reason as device offline.
    Network quality unavailable reason is now used for only the cases where
    NQE (network quality estimator) reports ECT as Unknown.
    
    Bug: 912725
    Change-Id: I0af0977770e2123f6ccd0317f8ebbfaed1aac9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/1366835
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614621}

    Changed files

    • components/previews/content/previews_decider_impl.cc
    • components/previews/content/previews_decider_impl_unittest.cc
    • components/previews/core/previews_black_list.h
    • components/previews/core/previews_logger.cc
    • tools/metrics/histograms/enums.xml
  3. Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused

    Changed by Kinuko Yasuda - kinukoohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 06:09:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1eb8373104f00c0ca44780a28d621dd6cf2f603

    Comments

    Remove RenderFrameHostImpl::subresource_loader_factories_bundle_ which is unused
    
    This field was added before to keep the copy of the bundle around in
    RFHI but not really used any more.
    
    Bug: N/A
    Change-Id: Ib007ee7dc941b980bab3ad92a1de016ad14d155c
    Reviewed-on: https://chromium-review.googlesource.com/c/1365052
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614620}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl.h
  4. Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e595fa693a4ef17b348340dbb64cf039c765e9c7

    Comments

    Roll src-internal 10e8db47197f..3e90e0805dd5 (6 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/10e8db47197f..3e90e0805dd5
    
    
    Created with:
      gclient setdep -r src-internal@3e90e0805dd5
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ia59b4d7347cb4c123f7e30d889f30af08e8b39f8
    Reviewed-on: https://chromium-review.googlesource.com/c/1367115
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614619}

    Changed files

    • DEPS
  5. Timer notification UI improvement:

    Changed by Li Lin - llinohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d710a7b3ef59302c00c2e3fe1b00c788310801c6

    Comments

    Timer notification UI improvement:
    
    * Add timer deeplinks for:
      - Stop timer
      - Add time to timer
    * Add "add 1 min to timer" button to timer notification.
    
    Using a feature flag to guard the usage of the deeplink as
    AlarmTimerManager is not fully available yet.
    
    Bug: b:119116816
    Change-Id: Ib9b28abecece1bb4fc60b88f367900f6f08f2efe
    Reviewed-on: https://chromium-review.googlesource.com/c/1340786
    Commit-Queue: Li Lin <llin@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614618}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc
    • chromeos/chromeos_strings.grd
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/fake_assistant_manager_service_impl.cc
    • chromeos/services/assistant/fake_assistant_manager_service_impl.h
    • chromeos/services/assistant/public/features.cc
    • chromeos/services/assistant/public/features.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/test_support/mock_assistant.h
  6. Crostini: migrate persisted paths from Downloads to MyFiles

    Changed by Joel Hockey - joelhockeyohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:38:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa7bc76e086df2f9428a2d583546f84f81c59d16

    Comments

    Crostini: migrate persisted paths from Downloads to MyFiles
    
    When MyFiles is enabled, check persisted paths in prefs
    and convert paths as needed.
    
    Bug: 911946
    Change-Id: I3931d196f89f31fa2ae95f7e02f9241b25d23524
    Reviewed-on: https://chromium-review.googlesource.com/c/1366458
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614617}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_share_path.cc
    • chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
    • chrome/browser/chromeos/file_manager/path_util.cc
    • chrome/browser/chromeos/file_manager/path_util.h
    • chrome/browser/chromeos/file_manager/path_util_unittest.cc
  7. Update V8 to version 7.3.56.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:30:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a61841709892ab7b5fc112c935f62851a2d3831e

    Comments

    Update V8 to version 7.3.56.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/2192eb7f..fd3bdfda
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I21cf598a516538376f34825912d8dd575a2ce058
    Reviewed-on: https://chromium-review.googlesource.com/c/1367111
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614616}

    Changed files

    • DEPS
  8. Add support for returning URLs from SelectFileDialogs.

    Changed by Sam McNally - sammcohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53fe68888c1b3e844195142b6ddba163bab85cd9

    Comments

    Add support for returning URLs from SelectFileDialogs.
    
    On ChromeOS, filesystem provider-provided files should be accessed via
    an externalfile URL. Further, hosted gdocs should be redirected to their
    URLs. Currently, this is handled within Browser.
    
    Add a |url| field to SelectedFileInfo to allow communicating these
    values from the dialog to Browser to avoid needing to leak this into
    Browser. Migrate this special-casing into the existing handling of
    SelectFileDialog results on ChromeOS, populating the |url| there.
    
    Bug: 843881
    Change-Id: I9808cdbf38fb4da26b99c8a45f8bda4fd0bee9a7
    Reviewed-on: https://chromium-review.googlesource.com/c/1360812
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614615}

    Changed files

    • chrome/browser/chromeos/extensions/file_manager/private_api_util.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.cc
    • chrome/browser/chromeos/fileapi/external_file_url_util.h
    • chrome/browser/ui/browser.cc
    • ui/file_manager/integration_tests/file_manager/file_dialog.js
    • ui/shell_dialogs/BUILD.gn
    • ui/shell_dialogs/selected_file_info.cc
    • ui/shell_dialogs/selected_file_info.h
  9. Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:10:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b87d9e9516460c683b698bb569d85ed8a9fd7348

    Comments

    Roll src/native_client 17af1e818981..8e13fe5e8564 (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/17af1e818981..8e13fe5e8564
    
    
    git log 17af1e818981..8e13fe5e8564 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jchinlee@chromium.org Surface lxml for use via vpython.
    
    
    Created with:
      gclient setdep -r src/native_client@8e13fe5e8564
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:912379
    TBR=mseaborn@chromium.org
    
    Change-Id: I53ddc48b5935ca8ea3f5bd8a44d39a43341edb2a
    Reviewed-on: https://chromium-review.googlesource.com/c/1366881
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614614}

    Changed files

    • DEPS
  10. Remove EncodingStreams runtime flag

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 05:10:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fbb267e716151d87e9bb0a394935f6944515700

    Comments

    Remove EncodingStreams runtime flag
    
    TextEncoderStream and TextDecoderStream have shipped. The flag is no
    longer needed. Remove it.
    
    BUG=898158
    
    Change-Id: Ie08d787509f075715b084c7d5e55ad7b2a0e2fb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1364934
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614613}

    Changed files

    • third_party/blink/renderer/modules/encoding/text_decoder_stream.idl
    • third_party/blink/renderer/modules/encoding/text_encoder_stream.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  11. Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 07-Dec-18 05:06:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c653611523cbca009b53d250a568e95aacf9c29

    Comments

    Roll src/third_party/angle 132d15c217e0..c3e3731cd3b2 (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/132d15c217e0..c3e3731cd3b2
    
    
    git log 132d15c217e0..c3e3731cd3b2 --date=short --no-merges --format='%ad %ae %s'
    2018-12-07 jmadill@chromium.org Give every validation error a constant.
    2018-12-06 syoussefi@chromium.org Vulkan: Add dynamic vertex buffers to graph
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c3e3731cd3b2
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Iaed9b0cae0e3386ca9836bc3caaf112c87dd8d17
    Reviewed-on: https://chromium-review.googlesource.com/c/1367169
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#614612}

    Changed files

    • DEPS