Home | Search | chromium - Builders
Login

Builder Android WebView O (dbg) Build 3037 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionc87b6f34e85ea9955986fbca7869b98b449dddf5
Got Revisionc87b6f34e85ea9955986fbca7869b98b449dddf5

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Giovanni Ortuño Urquidi (ortunoohnoyoudont@chromium.org)
  2. Wenzhao Zang (wzangohnoyoudont@chromium.org)
  3. Tetsui Ohkubo (tetsuiohnoyoudont@chromium.org)
  4. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  5. Aleks Totic (atoticohnoyoudont@chromium.org)
  6. Sunny Sachanandani (sunnypsohnoyoudont@chromium.org)
  7. Adam Rice (riceaohnoyoudont@chromium.org)
  8. Joel Einbinder (einbinderohnoyoudont@chromium.org)
  9. Andrew Xu (andrewxuohnoyoudont@chromium.org)
  10. Trent Apted (taptedohnoyoudont@chromium.org)
  11. Xiaohan Wang (xhwangohnoyoudont@chromium.org)
  12. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  13. Koji Ishii (kojiiohnoyoudont@chromium.org)
  14. Andrew Grieve (agrieveohnoyoudont@chromium.org)
  15. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. Albert J. Wong (ajwongohnoyoudont@chromium.org)
  17. Zhuoyu Qian (zhuoyu.qianohnoyoudont@samsung.com)
  18. Ryan (rsleeviohnoyoudont@chromium.org)
  19. Tarun Bansal (tbansalohnoyoudont@chromium.org)
  20. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create Tuesday, 16-Oct-18 06:01:55 UTC
Start Tuesday, 16-Oct-18 06:02:11 UTC
End Tuesday, 16-Oct-18 06:57:21 UTC
Pending 15 secs
Execution 55 mins 10 secs

All Changes:

  1. bluetooth: Implement TrayBluetoothHelperExperimental::GetBluetoothState

    Changed by Giovanni Ortuño Urquidi - ortunoohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:44:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c87b6f34e85ea9955986fbca7869b98b449dddf5

    Comments

    bluetooth: Implement TrayBluetoothHelperExperimental::GetBluetoothState
    
    Implements GetBluetoothState() by using the new BluetoothSystem mojo
    interface.
    
    Bug: 882346
    Change-Id: I75f11b9de33c98e2913aeb08a1e5e085532e803d
    Reviewed-on: https://chromium-review.googlesource.com/c/1272957
    Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599854}

    Changed files

    • ash/manifest.json
    • ash/shell.cc
    • ash/system/bluetooth/tray_bluetooth_helper_experimental.cc
    • ash/system/bluetooth/tray_bluetooth_helper_experimental.h
    • content/public/app/mojo/content_browser_manifest.json
  2. cros: Hide Discover OOBE screen for public sessions

    Changed by Wenzhao Zang - wzangohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:44:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed95e624b7279a87a1eff8d7b69e3cb559dfd533

    Comments

    cros: Hide Discover OOBE screen for public sessions
    
    Bug: 895031
    Change-Id: Icec3aea6c9459252edf5a68ff88d9e747cffa174
    Reviewed-on: https://chromium-review.googlesource.com/c/1281165
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599853}

    Changed files

    • chrome/browser/chromeos/login/wizard_controller.cc
  3. NewMessageListView: Implement removing animation.

    Changed by Tetsui Ohkubo - tetsuiohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:42:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e587b05b305c16185a373102acd9f0f9c3a930c0

    Comments

    NewMessageListView: Implement removing animation.
    
    This CL adds animation to NewMessageListView when notifications are
    removed.
    
    Video: http://shortn/_hXnIGaYesF
    
    UnifiedMessageListView will replace MessageListView. It's behind a flag:
    --enable-features=NewMessageListView
    
    Design doc: go/chrome-popup-refactoring
    
    TEST=UnifiedMessageListViewTest.RemovingNotificationAnimation
    BUG=769219
    
    Change-Id: I06c909acb227f9bfa484083dca36a95d79ece7f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1280087
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599852}

    Changed files

    • ash/system/message_center/new_unified_message_center_view.cc
    • ash/system/message_center/new_unified_message_center_view_unittest.cc
    • ash/system/message_center/unified_message_list_view.cc
    • ash/system/message_center/unified_message_list_view.h
    • ash/system/message_center/unified_message_list_view_unittest.cc
  4. Move telemetry_unittests from cros VM fyi bot to CQ bot.

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:41:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f0c13c716d21f1ef1460372bb99eb4e196fc53f

    Comments

    Move telemetry_unittests from cros VM fyi bot to CQ bot.
    
    Bug: 876494
    Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a
    Reviewed-on: https://chromium-review.googlesource.com/c/1281230
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599851}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
  5. [LayoutNG] Label failing tests with correct bug number

    Changed by Aleks Totic - atoticohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:40:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b57995bd484f196c0b8249909c4b4c5ae0eef395

    Comments

    [LayoutNG] Label failing tests with correct bug number
    
    Labeling all the failures caused by #889721, "no fragment, no outline" as such.
    
    I've also triaged rest of outline failures. I'd like to rebaseline, these
    are minor inline layout pixel differences:
    
    paint/invalidation/outline/focus-layers.html
    paint/invalidation/outline/focus-ring-on-inline-continuation-move.html
    paint/invalidation/outline/inline-outline-repaint-2.html
    paint/invalidation/outline/outline-containing-image-in-non-standard-mode.html
    
    I've also investigated
    paint/invalidation/outline/inline-focus.html
    This seems to be a real case of too much invalidation.
    
    Bug: 889721
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iba888ea769e54433ca1272d475baefd078bf6a12
    Reviewed-on: https://chromium-review.googlesource.com/c/1281915
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599850}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  6. Remove WaitSyncTokenCHROMIUM command

    Changed by Sunny Sachanandani - sunnypsohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:39:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c19106d109d4d36871c11bfb5a683d222583dd15

    Comments

    Remove WaitSyncTokenCHROMIUM command
    
    After migrating InProcessCommandBuffer to use GPU scheduler, most tasks
    are scheduled after their sync token dependencies are satisifed (see
    crrev.com/c/1157874).
    
    The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer
    for pepper, which specifies a sync token, and waits while handling the
    message.
    
    Change ReturnFrontBuffer to contain the sync token, and use it to
    specify the dependency to the scheduler.
    
    Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are
    specified as task metadata in all cases.
    
    Make other cleanups such as removing unnecessary sync token tests, and
    make sure the sync token code paths are not used where unsupported by
    using NOTREACHED.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272
    Bug: 778753
    Reviewed-on: https://chromium-review.googlesource.com/c/1168155
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599849}

    Changed files

    • android_webview/browser/deferred_gpu_command_service.cc
    • android_webview/browser/deferred_gpu_command_service.h
    • gpu/BUILD.gn
    • gpu/command_buffer/build_gles2_cmd_buffer.py
    • gpu/command_buffer/build_raster_cmd_buffer.py
    • gpu/command_buffer/client/client_test_helper.h
    • gpu/command_buffer/client/gles2_cmd_helper_autogen.h
    • gpu/command_buffer/client/gles2_implementation.cc
    • gpu/command_buffer/client/gles2_implementation_unittest.cc
    • gpu/command_buffer/client/gpu_control.h
    • gpu/command_buffer/client/raster_cmd_helper_autogen.h
    • gpu/command_buffer/client/raster_implementation.cc
    • gpu/command_buffer/client/raster_implementation_unittest.cc
    • gpu/command_buffer/common/gles2_cmd_format_autogen.h
    • gpu/command_buffer/common/gles2_cmd_format_test_autogen.h
    • gpu/command_buffer/common/gles2_cmd_ids_autogen.h
    • gpu/command_buffer/common/raster_cmd_format_autogen.h
    • gpu/command_buffer/common/raster_cmd_format_test_autogen.h
    • gpu/command_buffer/common/raster_cmd_ids_autogen.h
    • gpu/command_buffer/service/command_buffer_direct.cc
    • gpu/command_buffer/service/command_buffer_direct.h
    • gpu/command_buffer/service/decoder_client.h
    • gpu/command_buffer/service/gles2_cmd_decoder.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
    • gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h
    • gpu/command_buffer/service/memory_program_cache_unittest.cc
    • gpu/command_buffer/service/passthrough_program_cache_unittest.cc
    • gpu/command_buffer/service/program_manager_unittest.cc
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_unittest.cc
    • gpu/command_buffer/service/raster_decoder_unittest_base.cc
    • gpu/command_buffer/service/raster_decoder_unittest_base.h
    • gpu/command_buffer/tests/decoder_perftest.cc
    • gpu/command_buffer/tests/fuzzer_main.cc
    • gpu/command_buffer/tests/gl_fence_sync_unittest.cc
    • gpu/command_buffer/tests/gl_manager.cc
    • gpu/command_buffer/tests/gl_manager.h
    • gpu/gles2_conform_support/egl/context.cc
    • gpu/gles2_conform_support/egl/context.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl.h
    • gpu/ipc/client/gpu_channel_host.cc
    • gpu/ipc/command_buffer_task_executor.h
    • gpu/ipc/common/gpu_messages.h
    • gpu/ipc/gpu_in_process_thread_service.cc
    • gpu/ipc/gpu_in_process_thread_service.h
    • gpu/ipc/in_process_command_buffer.cc
    • gpu/ipc/in_process_command_buffer.h
    • gpu/ipc/service/command_buffer_stub.cc
    • gpu/ipc/service/command_buffer_stub.h
    • gpu/ipc/service/gles2_command_buffer_stub.cc
    • gpu/ipc/service/gles2_command_buffer_stub.h
    • gpu/ipc/service/gpu_channel.cc
    • gpu/ipc/service/raster_command_buffer_stub.cc
    • gpu/ipc/service/raster_command_buffer_stub.h
    • gpu/ipc/service/webgpu_command_buffer_stub.cc
    • gpu/ipc/service/webgpu_command_buffer_stub.h
    • ppapi/proxy/ppapi_command_buffer_proxy.cc
    • ppapi/proxy/ppapi_command_buffer_proxy.h
  7. Remove crash expectations for release-handle-crash.html

    Changed by Adam Rice - riceaohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:28:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57f2f7c7f2d9224eb6d00c32f0e8b9ff16be5579

    Comments

    Remove crash expectations for release-handle-crash.html
    
    http/tests/fetch/chromium/release-handle-crash.html no longer crashes
    since https://chromium-review.googlesource.com/c/1278613 landed. Remove
    the flaky expectations.
    
    BUG=893015
    
    Change-Id: I79738c8d44e001a3fad05fdbe11d687d895a3dae
    Reviewed-on: https://chromium-review.googlesource.com/c/1280074
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599848}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  8. DevTools: Accessibility.enable and disable protocol methods

    Changed by Joel Einbinder - einbinderohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:24:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24961c1e56a96647603b685311558605386f335f

    Comments

    DevTools: Accessibility.enable and disable protocol methods
    
    This will allow for new methods that operate on AXNodeIds, like
    Accessibility.click and Accessibility.focus. It also allows multiple
    calls to getFullAXTree to be compared.
    
    Bug: 887173
    Change-Id: Iaaf103bced9c5dbc9dd04306c2562044f50dfd2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1237526
    Commit-Queue: Joel Einbinder <einbinder@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599847}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/devtools/agents-enable-disable-expected.txt
    • third_party/blink/renderer/core/inspector/browser_protocol.pdl
    • third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.cc
    • third_party/blink/renderer/modules/accessibility/inspector_accessibility_agent.h
    • third_party/blink/renderer/modules/modules_initializer.cc
  9. Fixing bug of display orientation setting

    Changed by Andrew Xu - andrewxuohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:17:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 099f614af4cacb6f0df4dd07865db0001a6c7e3b

    Comments

    Fixing bug of display orientation setting
    
    (1) Modified code so that tablet
    mode updating will enable/disable display
    orientation in setting page.
    
    (2) Code refactoring: move all of methods
    related with display information in
    SystemInfoApi::SystemInfoEventRouter to
    DisplayInfoProvider and its subclasses.
    
    In the previous code, tablet mode's change
    will not affect display orientation when
    setting page has already shown. As result,
    when opening setting page then changing
    laptop to tablet mode, user is still able
    to modify display orientation. After
    investigation, the bug reason is that in
    ChromeOS change in tablet mode will not
    trigger OnDisplayChanged event.
    
    Bug: 889625
    Change-Id: Ic526ec54e6c01cd14a0d4a7e883774b9fafed268
    Reviewed-on: https://chromium-review.googlesource.com/c/1264544
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Reviewed-by: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599846}

    Changed files

    • chrome/browser/extensions/api/system_display/system_display_chromeos_apitest.cc
    • chrome/browser/extensions/system_display/display_info_provider_chromeos.cc
    • chrome/browser/extensions/system_display/display_info_provider_chromeos.h
    • chrome/test/BUILD.gn
    • chrome/test/data/extensions/api_test/system_display_chromeos/background.js
    • chrome/test/data/extensions/api_test/system_display_chromeos/manifest.json
    • extensions/browser/api/system_display/display_info_provider.cc
    • extensions/browser/api/system_display/display_info_provider.h
    • extensions/browser/api/system_info/system_info_api.cc
  10. FilesApp: Closure compile background/.../volume_manager_unittest

    Changed by Trent Apted - taptedohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:15:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fc0f5ddb59e2445813dec1a8e6887413bfdd508

    Comments

    FilesApp: Closure compile background/.../volume_manager_unittest
    
    Related apps under ui/file_manager all use background_base.js, which
    instantiates a VolumeManagerFactory. VolumeManagerFactory,
    BackgroundBase, their tests, and things they depend on should all move
    to //ui/file_manager/base/*.
    
    Capturing deps by Closure-compiling makes things easier to move.
    Start with volume_manager_unittest.js. Break its dependency on the
    files app `unittest_util.js` (which shouldn't move) by splitting out
    some test utility functions to ui/file_manager/base/js/mock_chrome.js.
    
    Bug: 879035, 860355
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ieab83e90607da78cf06352ecce73c0f8d62a2838
    Reviewed-on: https://chromium-review.googlesource.com/c/1278622
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599845}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_jstest.cc
    • ui/file_manager/BUILD.gn
    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/mock_chrome.js
    • ui/file_manager/file_manager/background/js/BUILD.gn
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.js
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
  11. media: Add more trace events in CdmAdapter

    Changed by Xiaohan Wang - xhwangohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:10:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision def776e75cfc3b34930e83402a7bb2c186bc4eb2

    Comments

    media: Add more trace events in CdmAdapter
    
    Add TRACE_EVENTs for all methods that call into the CDM so that we can
    monitor CDM's performance more closely.
    
    Bug: 879970
    Test: Manually tested and checked traces.
    Change-Id: I61c063ad656b852463195b2cea93f91aee8d91ba
    Reviewed-on: https://chromium-review.googlesource.com/c/1281042
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599844}

    Changed files

    • media/cdm/cdm_adapter.cc
  12. Remove refs to ViewHostMsg_ResizeOrRepaint_ACK.

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:08:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14024492ea214611e6855a87f954f54fb1735d8b

    Comments

    Remove refs to ViewHostMsg_ResizeOrRepaint_ACK.
    
    This message does not exist anymore and there does not seem to be
    an equivalent replacement. Codepaths with referencing ResizeOrRepaint
    seem to be dead.
    
    Deleting.
    
    Bug: 545684
    Change-Id: Icbec543f3eadbdd440d2dd58c8fb4e33f6d69770
    Reviewed-on: https://chromium-review.googlesource.com/c/1241134
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599843}

    Changed files

    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_impl.h
    • tools/metrics/histograms/histograms.xml
  13. [auto] Update FlagExpectations for LayoutNG

    Changed by Koji Ishii - kojiiohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:06:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f15e924577b681222502cd87d0d1c56dfe9aa83b

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    10554 10556 10564 10575 10580 10588 10595 10601 10603 10605
    10607 10608 10616 10618 10622 10625 10628 10637 10644 10651
    10654 10657 10667 10674 10680
    
    12 lines were removed and 7 lines were deflaked by consecutive
    results since 106188888888.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ic4b22c7ca4477780993bc371558828f4c8ab8c64
    Reviewed-on: https://chromium-review.googlesource.com/c/1278448
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599842}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  14. resource_sizes.py: Track estimated install size for Android Go

    Changed by Andrew Grieve - agrieveohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 04:02:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a26785b1f53840100e4a4005f7440dac4f201ca

    Comments

    resource_sizes.py: Track estimated install size for Android Go
    
    This metric is the same as the normal install size, but applies a
    different dex multiplier.
    
    Change-Id: I82e20c1086eea30ea91474b1c5096061fb38d1fd
    Reviewed-on: https://chromium-review.googlesource.com/c/1281054
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599841}

    Changed files

    • build/android/resource_sizes.py
  15. Roll src/third_party/angle bbd532d164f0..a1ac3fe80647 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 16-Oct-18 04:01:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44d2ad9ca918c88a02b77ec0788dceb1189facb1

    Comments

    Roll src/third_party/angle bbd532d164f0..a1ac3fe80647 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/bbd532d164f0..a1ac3fe80647
    
    
    git log bbd532d164f0..a1ac3fe80647 --date=short --no-merges --format='%ad %ae %s'
    2018-10-16 jiawei.shao@intel.com ES31: Support textureGather[Offset] on int/uint formats on D3D11
    
    
    Created with:
      gclient setdep -r src/third_party/angle@a1ac3fe80647
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=geofflang@chromium.org
    
    Change-Id: I78829226c924ce9ea7cd7d82b450c39bc33801e1
    Reviewed-on: https://chromium-review.googlesource.com/c/1282344
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599840}

    Changed files

    • DEPS
  16. Remove RenderWidgetHostView::OnMessageReceived.

    Changed by Albert J. Wong - ajwongohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 03:51:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 64523f8521431a8779b01b1e2183e8187681b386

    Comments

    Remove RenderWidgetHostView::OnMessageReceived.
    
    After this change, RenderWidgetHost *never* forwards an IPC message on
    to another object. This removes one whole method of implicit virtual
    dispatch making the code more traceable.
    
    ... yay!
    
    Bug: 419087
    Change-Id: Ia81e46814b3bcc3f6bd57ed992d2c0621c5d4ab5
    Reviewed-on: https://chromium-review.googlesource.com/c/1282022
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Albert J. Wong <ajwong@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599839}

    Changed files

    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_impl.h
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
  17. Use ContainsValue() instead of std::find() in content/

    Changed by Zhuoyu Qian - zhuoyu.qianohnoyoudont@samsung.com
    Changed at Tuesday, 16-Oct-18 03:48:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39a909a56716bc7285dd53e9f4a3e97458fff807

    Comments

    Use ContainsValue() instead of std::find() in content/
    
    BUG=561800
    
    Change-Id: Ia074881a22e83873ff26249ea056ad9c6365fe14
    Reviewed-on: https://chromium-review.googlesource.com/c/1248141
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#599838}

    Changed files

    • content/browser/appcache/appcache_update_job_unittest.cc
    • content/browser/browsing_data/clear_site_data_handler_browsertest.cc
    • content/browser/media/capture/audio_mirroring_manager.cc
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/browser/snapshot_browsertest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/webui/url_data_manager.cc
    • content/common/content_security_policy/content_security_policy_unittest.cc
    • content/common/font_cache_dispatcher_win.cc
    • content/common/plugin_list.cc
    • content/renderer/categorized_worker_pool.cc
    • content/renderer/media/midi/midi_message_filter.cc
    • content/renderer/media/stream/media_stream_audio_deliverer.h
    • content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
    • content/renderer/media/stream/media_stream_constraints_util_sets.h
    • content/renderer/media/stream/media_stream_video_source.cc
    • content/renderer/media/stream/media_stream_video_track.cc
    • content/renderer/media/stream/secure_display_link_tracker.h
    • content/renderer/media/stream/user_media_processor.cc
    • content/renderer/media/webrtc/rtc_video_decoder_adapter.cc
    • content/renderer/media/webrtc/webrtc_audio_sink.cc
    • content/test/mock_clipboard_host.cc
    • content/test/web_contents_observer_sanity_checker.cc
  18. Enable LegacySymantecPKI deprecation in Finch JSON

    Changed by Ryan - rsleeviohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 03:42:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78700a26e4165d39196febe9bdcdb46e8a1547f5

    Comments

    Enable LegacySymantecPKI deprecation in Finch JSON
    
    This is already enabled by default in source, but
    this updates the JSON to match the Finch config.
    
    Bug: 881930
    Change-Id: I26f637447141730e24f0a2e2c4d84b05f2cba2fa
    Reviewed-on: https://chromium-review.googlesource.com/c/1278621
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599837}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  19. Correctly record if clicked anchor element contains image or not

    Changed by Tarun Bansal - tbansalohnoyoudont@chromium.org
    Changed at Tuesday, 16-Oct-18 03:39:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61fc2f0a5a2283f886c36327005ae5f7cbb27667

    Comments

    Correctly record if clicked anchor element contains image or not
    
    Currently, when an anchor element is clicked, we record if it
    contains image or not based on only the properties of the clicked element.
    
    This CL changes the logic to also look at other anchor elements
    in the page that point to the same HREF. If any of
    the other anchor element in the page point to the same
    href as the clicked href, and contains image,
    then we record that the clicked anchor element also contains image.
    
    Bug: 871521
    Change-Id: Ia21133e023596128e62621551931ad054fda98e3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278468
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599836}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor_browsertest.cc
    • chrome/test/data/navigation_predictor/anchors_same_href.html
  20. Roll src/third_party/pdfium 7c39bf7b87f8..1929d6e1d44e (16 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Tuesday, 16-Oct-18 03:36:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5817b2f8c0d0e184e78bebb8b343688154df5856

    Comments

    Roll src/third_party/pdfium 7c39bf7b87f8..1929d6e1d44e (16 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/7c39bf7b87f8..1929d6e1d44e
    
    
    git log 7c39bf7b87f8..1929d6e1d44e --date=short --no-merges --format='%ad %ae %s'
    2018-10-15 thestig@chromium.org Split pdfium_embeddertests sources.
    2018-10-15 thestig@chromium.org Move fx_skia_device_unittest.cpp to pdfium_embeddertests.
    2018-10-15 thestig@chromium.org Split pdfium_unittests sources.
    2018-10-15 thestig@chromium.org Split public/ headers into their own source_set.
    2018-10-15 thestig@chromium.org Restrict fxcrt's visibility to third_party.
    2018-10-15 tsepez@chromium.org Clone dict before iteration in CJS_Document::get_info
    2018-10-15 xlou@chromium.org Use CropBox instead of ArtBox or TrimBox
    2018-10-15 tsepez@chromium.org Convert %s -> %ls for wide string error format.
    2018-10-15 thestig@chromium.org Make core/ pass gn check.
    2018-10-15 thestig@chromium.org Use more UnownedPtr in CPDF_FormControl.
    2018-10-15 thestig@chromium.org Move CPDF_ModuleMgr methods into cpdf_modulemgr.cpp.
    2018-10-15 thestig@chromium.org Make ":pdfium" pass gn check.
    2018-10-15 tsepez@chromium.org Stop shadowing codec memory size with CCodec_ProgressiveDecoder::m_SrcSize
    2018-10-15 thestig@chromium.org Make fxjs/ pass gn check.
    2018-10-15 thestig@chromium.org Make fpdfsdk/ pass gn check.
    2018-10-15 thestig@chromium.org Make xfa/ pass gn check.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@1929d6e1d44e
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:895152,chromium:409670,chromium:895009
    TBR=dsinclair@chromium.org
    
    Change-Id: I95c8a745294172817f98cc2e21f0110bd5b978cf
    Reviewed-on: https://chromium-review.googlesource.com/c/1282322
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599835}

    Changed files

    • DEPS