Home | Search | chromium - Builders
Login

Builder Android WebView O (dbg) Build 3029 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisiona0453191e73498f2306d6be9e5ace0685721c4c8
Got Revisiona0453191e73498f2306d6be9e5ace0685721c4c8

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Ben Pastene (bpasteneohnoyoudont@chromium.org)
  2. Scott Violet (skyohnoyoudont@chromium.org)
  3. tzik (tzikohnoyoudont@chromium.org)
  4. Jialiu Lin (jialiulohnoyoudont@chromium.org)
  5. Katie Dillon (kdillonohnoyoudont@chromium.org)
  6. Avi Drissman (aviohnoyoudont@chromium.org)
  7. Mikel Astiz (mastizohnoyoudont@chromium.org)
  8. Nicolas Capens (capnohnoyoudont@chromium.org)
  9. Mikel Astiz (mastizohnoyoudont@chromium.org)
  10. Aaron Krajeski (aaronhkohnoyoudont@google.com)
  11. Shik Chen (shikohnoyoudont@chromium.org)
  12. Scott Violet (skyohnoyoudont@chromium.org)
  13. Roger Tawa (rogertaohnoyoudont@chromium.org)
  14. Daniel Cheng (dchengohnoyoudont@chromium.org)
  15. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  16. Sky Malice (skymohnoyoudont@google.com)
  17. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  18. Ken Rockot (rockotohnoyoudont@chromium.org)
  19. Hiroshi Ichikawa (ichikawaohnoyoudont@chromium.org)

Timing:

Create Monday, 15-Oct-18 18:54:13 UTC
Start Monday, 15-Oct-18 18:55:02 UTC
End Monday, 15-Oct-18 19:50:11 UTC
Pending 49 secs
Execution 55 mins 8 secs

All Changes:

  1. Revert "Automated Commit: LKGM 11160.0.0 for chromeos."

    Changed by Ben Pastene - bpasteneohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:40:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0453191e73498f2306d6be9e5ace0685721c4c8

    Comments

    Revert "Automated Commit: LKGM 11160.0.0 for chromeos."
    
    This reverts commit e767fb512b33241e477b8d10cd99a20de83e8039.
    
    Reason for revert: crbug.com/895337
    
    Original change's description:
    > Automated Commit: LKGM 11160.0.0 for chromeos.
    > 
    > BUG=762641
    > TBR=achuith@google.com
    > 
    > Change-Id: I20f03272b5b8fffca13ebaafac94237c2668ef51
    > Reviewed-on: https://chromium-review.googlesource.com/c/1280144
    > Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    > Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/master@{#599586}
    
    TBR=achuith@chromium.org,3su6n15k.default@developer.gserviceaccount.com
    
    Change-Id: I269fc123a9171afdf0b5077948f7d46b2a226bbd
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 762641
    Reviewed-on: https://chromium-review.googlesource.com/c/1281052
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599668}

    Changed files

    • chromeos/CHROMEOS_LKGM
  2. cast: make CastTouchEventGateTest remove pre-target handler

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5ac534604659120a7a70780497b1227882aabc22

    Comments

    cast: make CastTouchEventGateTest remove pre-target handler
    
    CastTouchEventGateTest adds a pre-target handler, but it never removes it.
    I'm going to add some DCHECKs to ensure there are no pre-target handlers when
    an object is destroyed, so this needs to be fixed.
    
    BUG=867035
    TEST=none
    
    Change-Id: I2b3804ba9a96288d209958af7c8703e99732d32b
    Reviewed-on: https://chromium-review.googlesource.com/c/1281044
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599667}

    Changed files

    • chromecast/graphics/cast_touch_event_gate_test.cc
  3. Use noexcept consistently on NGExclusionSpaceInternal

    Changed by tzik - tzikohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:39:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 37ffc539e3816630200eb3cb64c3d1eadbbb1158

    Comments

    Use noexcept consistently on NGExclusionSpaceInternal
    
    The move ctor of NGExclusionSpaceInternal has `noexcept` keyword on its
    declaration, but doesn't have it on its definition. That causes a
    compile error on the C++17 mode build.
    This CL adds `noexcept` to the definition too. Plus, adds `noexcept` to
    move assignment for the consistency.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16f7f69f6d0a7f513659f57f131aee1e4d7414af
    Reviewed-on: https://chromium-review.googlesource.com/c/1280083
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599666}

    Changed files

    • third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.cc
    • third_party/blink/renderer/core/layout/ng/exclusions/ng_exclusion_space.h
  4. Enable password protection for incognito profile

    Changed by Jialiu Lin - jialiulohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:38:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1738d0f26d1fc9b1808d414b6375435e6eb43a87

    Comments

    Enable password protection for incognito profile
    
    Since many people may be using incognito to browse "sketchy" sites,
    we'd like to detect sync password reuse in incognito profile.
    Meanwhile, this CL also makes sure Chrome don't leak any browsing
    history related data to the original profile.
    
    More specifically, for incognito profile:
    1. Chrome will send PhishGuard password reuse ping to SB backend:
       -Anonymous ping, same behavior as in regular profile.
    2. show model warning if the returned verdict is PHISHING or LOW_REPUTATION
       -same behavior as in regular profile.
    3. Chrome will NOT cache verdicts
    4. Chrome will NOT show the change password card in chrome://settings
    5. Chrome will NOT set user at-risk.
    
    Change-Id: Iac0a7872d79438e8204b8fc24eba6d8d1201e606
    Bug: 893715
    Reviewed-on: https://chromium-review.googlesource.com/c/1277815
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Daniel Rubery <drubery@chromium.org>
    Commit-Queue: Jialiu Lin <jialiul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599665}

    Changed files

    • chrome/browser/safe_browsing/chrome_password_protection_service.cc
    • chrome/browser/safe_browsing/chrome_password_protection_service.h
    • chrome/browser/safe_browsing/chrome_password_protection_service_browsertest.cc
    • chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
    • components/safe_browsing/password_protection/password_protection_service.cc
    • components/safe_browsing/password_protection/password_protection_service_unittest.cc
    • components/safe_browsing/proto/csd.proto
    • components/safe_browsing/web_ui/safe_browsing_ui.cc
  5. Worker transferable perf tests.

    Changed by Katie Dillon - kdillonohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:38:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8f897a469ec7f6f5daee2c9e1bb62daacba44a79

    Comments

    Worker transferable perf tests.
    
    Adding perf tests for transferable data. Measures sending transferable
    data to a worker from the main thread, from the main thread to a worker,
    and the roundtrip time. Transferable data for this test is an image
    represented as an array buffer.
    
    Change-Id: Ie9f05a5301398b2f11677a2a57c985992b64541a
    Reviewed-on: https://chromium-review.googlesource.com/c/1275365
    Reviewed-by: Shubhie Panicker <panicker@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Katie Dillon <kdillon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599664}

    Changed files

    • third_party/blink/perf_tests/bindings/resources/worker-transferable-perf-test.js
    • third_party/blink/perf_tests/bindings/resources/worker-transferable.js
    • third_party/blink/perf_tests/bindings/worker-transferable-from-worker.html
    • third_party/blink/perf_tests/bindings/worker-transferable-roundtrip.html
    • third_party/blink/perf_tests/bindings/worker-transferable-to-worker.html
  6. Switch to the MacViews version of the cert viewer.

    Changed by Avi Drissman - aviohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:36:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2de299c3687beea1fa182bf4faa43f1ec33da8f6

    Comments

    Switch to the MacViews version of the cert viewer.
    
    There was a Cocoa and MacViews version with a common superclass;
    this removes the Cocoa version and folds the superclass into the
    MacViews subclass which is the only one that remains.
    
    This also reverts 027233cd43df4596af6b3ba501a15090f1284c05 as
    that hack was only needed while we linked against the 10.10 SDK
    and we no longer do so.
    
    BUG=891699
    
    Change-Id: Iefdd30268f1e0b52ee1ecd71bdb252e5b8b5c631
    Reviewed-on: https://chromium-review.googlesource.com/c/1277578
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599663}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/certificate_viewer_mac.h
    • chrome/browser/ui/certificate_viewer_mac.mm
    • chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.h
    • chrome/browser/ui/cocoa/certificate_viewer_mac_cocoa.mm
    • chrome/browser/ui/views/certificate_viewer_mac_browsertest.mm
    • chrome/browser/ui/views/certificate_viewer_mac_views.mm
    • chrome/test/BUILD.gn
  7. Add extension/app settings to pseudo-USS

    Changed by Mikel Astiz - mastizohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62f7ba65d7479865d4cc5386be1b7f179046962e

    Comments

    Add extension/app settings to pseudo-USS
    
    These are the first two pseudo-USS types outside the UI thread, which
    requires some extra plumbing. Around 100 LoC must be invested to add
    support for a variant of the controller that allows construction and
    destruction of bridge and processor in the model thread.
    
    In addition, pseudo-USS relies on a directory-like storage
    implemented with ModelTypeStore, which needs some quirks to be
    supported outside the UI thread: namely, the store factory must be
    allowed to run on any thread, and the destruction sequence must be
    refcounted, in particular for ModelTypeStoreBackend, since the
    destruction order across backend sequences is not deterministic.
    
    Bug: 870624
    Change-Id: I6dbe210277e75f7662a2b744031595c90beb1c62
    Reviewed-on: https://chromium-review.googlesource.com/c/1278639
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599662}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/sync/chrome_sync_client.cc
    • chrome/browser/sync/glue/extension_setting_model_type_controller.cc
    • chrome/browser/sync/glue/extension_setting_model_type_controller.h
    • chrome/browser/sync/test/integration/two_client_extension_settings_and_app_settings_sync_test.cc
    • components/sync/BUILD.gn
    • components/sync/driver/non_ui_syncable_service_based_model_type_controller.cc
    • components/sync/driver/non_ui_syncable_service_based_model_type_controller.h
    • components/sync/driver/sync_driver_switches.cc
    • components/sync/driver/sync_driver_switches.h
    • components/sync/driver/syncable_service_based_model_type_controller.h
    • components/sync/model/model_type_store_service.h
    • components/sync/model/model_type_store_test_util.cc
    • components/sync/model/test_model_type_store_service.h
    • components/sync/model_impl/blocking_model_type_store_impl.cc
    • components/sync/model_impl/blocking_model_type_store_impl.h
    • components/sync/model_impl/model_type_store_backend.cc
    • components/sync/model_impl/model_type_store_backend.h
    • components/sync/model_impl/model_type_store_backend_unittest.cc
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync/model_impl/model_type_store_service_impl.cc
    • components/sync/model_impl/model_type_store_service_impl.h
    • components/sync/model_impl/syncable_service_based_bridge.cc
    • components/sync/model_impl/syncable_service_based_bridge.h
  8. Roll SwiftShader 810f3db..71e256c

    Changed by Nicolas Capens - capnohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:32:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision daae6a73823f0df2c87bac97d930ccb6e28d44ba

    Comments

    Roll SwiftShader 810f3db..71e256c
    
    https://swiftshader.googlesource.com/SwiftShader.git/+log/810f3db..71e256c
    
    BUG=chromium:881334
    
    TBR=kbr@chromium.org
    
    TEST=bots
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    Change-Id: Iae687a76f335d7514dcddcb5c5db07f2fa9f6928
    Signed-off-by: Nicolas Capens <capn@chromium.org>
    Reviewed-on: https://chromium-review.googlesource.com/c/1280785
    Reviewed-by: Alexis H├ętu <sugoi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599661}

    Changed files

    • DEPS
    • tools/roll_swiftshader.py
  9. Reassign TODOs related to SESSIONS cleanup

    Changed by Mikel Astiz - mastizohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:30:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 93db1962c916209e28859d4d63b9f128eea770c8

    Comments

    Reassign TODOs related to SESSIONS cleanup
    
    A newly filed bug will be used to track code cleanup.
    
    Bug: 895455
    Change-Id: If38fcc9311b441e68b43970a0baee8375750e3cd
    Reviewed-on: https://chromium-review.googlesource.com/c/1280673
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599660}

    Changed files

    • components/sync/driver/sync_api_component_factory.h
    • components/sync/driver/sync_client.h
    • components/sync/model/sync_data.h
    • components/sync_sessions/abstract_sessions_sync_manager.h
  10. Add metrics for offscreen canvas

    Changed by Aaron Krajeski - aaronhkohnoyoudont@google.com
    Changed at Monday, 15-Oct-18 17:27:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b65449a26d80058c6a2933321bcd8e0463794f07

    Comments

    Add metrics for offscreen canvas
    
    Bug: 894043
    Change-Id: Idcfd3f4d430c7bce4c13448c80996128ca831f72
    Reviewed-on: https://chromium-review.googlesource.com/c/1265815
    Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599659}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.cc
    • tools/metrics/histograms/histograms.xml
  11. [Video Capture, Chrome OS] Wait until vivid is detected in ChromeOS VM

    Changed by Shik Chen - shikohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:22:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62d2bd99255082967be127282cd2ecc0ce5fcc7e

    Comments

    [Video Capture, Chrome OS] Wait until vivid is detected in ChromeOS VM
    
    BUG=chromium:881300,chromium:852302
    TEST=Pass capture_unittests with/without vivid enabled on amd64-generic
         VM, and verify vivid is used when it's enabled.
    TEST=Pass capture_unittests on teemo (a Chromebox), and verify it
         doesn't wait for camera.
    
    Change-Id: I2a11a848639eba426daa4db2f8d22b90c01e08b9
    Reviewed-on: https://chromium-review.googlesource.com/c/1260806
    Reviewed-by: Ricky Liang <jcliang@chromium.org>
    Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    Commit-Queue: Shik Chen <shik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599658}

    Changed files

    • media/capture/video/chromeos/camera_hal_delegate.cc
    • media/capture/video/chromeos/camera_hal_delegate.h
  12. events: minor cleanup/restructuring of EventDispatcher/EventTarget

    Changed by Scott Violet - skyohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:21:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e718d58556b8bbc2a8dbb9fbf69373404877ed7e

    Comments

    events: minor cleanup/restructuring of EventDispatcher/EventTarget
    
    In chasing a bug I decided to restructure things slightly, including adding
    some CHECKs. I don't expect this to impact anything.
    
    BUG=867035
    TEST=none
    
    Change-Id: I86bf2d672d886a3944607bbba053e79769d43351
    Reviewed-on: https://chromium-review.googlesource.com/c/1278814
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599657}

    Changed files

    • ui/events/event_dispatcher.cc
    • ui/events/event_dispatcher.h
    • ui/events/event_target.cc
  13. Add credential provider unit tests run on the buildbots.

    Changed by Roger Tawa - rogertaohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ba8218bfb5dec7140b62acf40e91ab0188ec3608

    Comments

    Add credential provider unit tests run on the buildbots.
    
    Fix up the tests so that they run correctly with base::LaunchUnitTests().
    Add the unit test exe to the buildbot configs.
    
    Bug: 789588
    Change-Id: Ib0ccf2bf965071e6afe2638db1fe3e565799c3e4
    Reviewed-on: https://chromium-review.googlesource.com/c/1274456
    Commit-Queue: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Owen Min <zmin@chromium.org>
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599656}

    Changed files

    • chrome/credential_provider/gaiacp/dllmain.cc
    • chrome/credential_provider/gaiacp/gaia_credential_provider_module.cc
    • chrome/credential_provider/gaiacp/gaia_credential_provider_module.h
    • chrome/credential_provider/gaiacp/gcp_utils_unittests.cc
    • chrome/credential_provider/test/BUILD.gn
    • chrome/credential_provider/test/gcp_test_main.cc
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
  14. Use Dispatcher::OnRenderThreadStarted to register extensions::SafeBuiltins

    Changed by Daniel Cheng - dchengohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 17:14:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0fc33c1a942b0d7e6e51d5212e373e2f25e98c61

    Comments

    Use Dispatcher::OnRenderThreadStarted to register extensions::SafeBuiltins
    
    Change-Id: I82bca85f027b47e538fb4ceb1893cbdcf23352d6
    Reviewed-on: https://chromium-review.googlesource.com/c/1279957
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599655}

    Changed files

    • chrome/renderer/extensions/chrome_extensions_renderer_client.cc
    • extensions/renderer/dispatcher.cc
    • extensions/renderer/dispatcher.h
    • extensions/shell/renderer/shell_extensions_renderer_client.cc
  15. Roll src/third_party/skia c6a17104ad68..11dd1ab3b9e9 (10 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Monday, 15-Oct-18 17:11:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6389198436427ef5331f355e3e182f87e72180c4

    Comments

    Roll src/third_party/skia c6a17104ad68..11dd1ab3b9e9 (10 commits)
    
    https://skia.googlesource.com/skia.git/+log/c6a17104ad68..11dd1ab3b9e9
    
    
    git log c6a17104ad68..11dd1ab3b9e9 --date=short --no-merges --format='%ad %ae %s'
    2018-10-15 jvanverth@google.com Check for legit bounds in SkTriangulateSimplePolygon
    2018-10-15 bsalomon@google.com Abort DRAW_IMAGE_SET in SkPicturePlayback if count is negative
    2018-10-15 reed@google.com removed unused LEGACY_VULKAN_INTERFACE
    2018-10-15 reed@google.com remove unused SK_LEGACY_SRGB_GAMUT code
    2018-10-15 bsalomon@google.com Outset texture coordinates similarly to positions in GrTextureOp
    2018-10-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5378e14284e6..a2d15d1a268c (1 commits)
    2018-10-15 kjlubick@google.com Remove nvpr from CanvasKit
    2018-10-15 bsalomon@google.com Make TextureOp request vertex space for meshes at once.
    2018-10-15 reed@google.com remove dead code from SK_SUPPORT_LEGACY_THREADED_DAA_BUGS
    2018-10-15 mtklein@google.com String -> const char* where possbile
    
    
    Created with:
      gclient setdep -r src/third_party/skia@11dd1ab3b9e9
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=egdaniel@chromium.org
    
    Change-Id: I18618c3cc981302bcef5dfaf5f6306bfb172a769
    Reviewed-on: https://chromium-review.googlesource.com/c/1280412
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599654}

    Changed files

    • DEPS
  16. [Feed] Replace feature hack workaround with clang-format off

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Monday, 15-Oct-18 16:55:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56ebd19dd25b7dc7238cfe722f771933a9052eb9

    Comments

    [Feed] Replace feature hack workaround with clang-format off
    
    Bug: 866123
    Change-Id: I4483a80d0c81f1634c5867f62a22c43af355d162
    Reviewed-on: https://chromium-review.googlesource.com/c/1277812
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Sky Malice <skym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599653}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/feed/FeedRefreshTaskTest.java
  17. Update Lifecycle intead of forcing ComputedStyle in test.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 16:55:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e71535afffce7c464035b33e527790f0e972cbd4

    Comments

    Update Lifecycle intead of forcing ComputedStyle in test.
    
    EnsureComputedStyle is meant to be used on elements not rendered, but
    queried for ComputedStyle like in getComputedStyle. Update the lifecycle
    before getting the ComputedStyle in this media controls test instead.
    
    Change-Id: I7024c7d02f0603097f5b912ced953c14aef7342d
    Reviewed-on: https://chromium-review.googlesource.com/c/1280723
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599652}

    Changed files

    • third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
  18. [views] Fix NativeViewHost crash

    Changed by Ken Rockot - rockotohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 16:27:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 459031f72d8fd7bf2c60bb6a7d220a5621f77e19

    Comments

    [views] Fix NativeViewHost crash
    
    NativeViewHost does not safely handle the case where it is added and
    then removed from a view hierarchy without ever being added to a
    Widget. Instead it crashes. This CL fixes the crash.
    
    Bug: None
    Change-Id: Ib25f754386b6512973861c4603c1f1a91a0cdb1a
    Reviewed-on: https://chromium-review.googlesource.com/c/1277687
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599651}

    Changed files

    • ui/views/controls/native/native_view_host.cc
  19. Correct clean up condition in -resetWebStateWithSessionStorage:.

    Changed by Hiroshi Ichikawa - ichikawaohnoyoudont@chromium.org
    Changed at Monday, 15-Oct-18 16:26:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd22b04d317073f5329dccce9c9bcd896ea9f262

    Comments

    Correct clean up condition in -resetWebStateWithSessionStorage:.
    
    Originally all clean up was conditioned on
    _webState->GetView().superview == self, which looks wrong. So I removed
    the condition except for [_webState->GetView() removeFromSuperview].
    
    It may not cause any issues in practice, though.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I2ce98cc4b568c6b450d20c5193f5eaebad7cde96
    Reviewed-on: https://chromium-review.googlesource.com/c/1280088
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: John Wu <jzw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599650}

    Changed files

    • ios/web_view/internal/cwv_web_view.mm