Home | Search | chromium - Builders
Login

Builder Android WebView O (dbg) Build 3015 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisioneca9fd593b12dc8111ac2d779ba42df78e872371
Got Revisioneca9fd593b12dc8111ac2d779ba42df78e872371

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Marcin Wiacek (marcinohnoyoudont@mwiacek.com)

Timing:

Create Monday, 15-Oct-18 00:51:49 UTC
Start Monday, 15-Oct-18 00:52:40 UTC
End Monday, 15-Oct-18 01:50:33 UTC
Pending 50 secs
Execution 57 mins 52 secs

All Changes:

  1. Update @IntDef related code inside chrome/android/preferences/website

    Changed by Marcin Wiacek - marcinohnoyoudont@mwiacek.com
    Changed at Sunday, 14-Oct-18 22:24:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eca9fd593b12dc8111ac2d779ba42df78e872371

    Comments

    Update @IntDef related code inside chrome/android/preferences/website
    
    1. for these @IntDef, which are indexing tables - adding info, which tables should be updated after updating @IntDef value (change after https://crbug.com/616321) + removing info about dynamically created tables (which don't have to be updated).
    2. making @IntDef comments more consistent.
    3. adding few JavaDoc links.
    4. replacing Int[] and String[] mappings with switch
    
    All changes are helping in ensuring that all updates for @IntDef will be done in this way, that mappings will not be broken and values will correctly filled.
    
    5. making CONTENT_TYPES private inside PermissionInfo and ContentSettingException.
    
    Good practice for making tables immutable.
    
    Change-Id: I313ed930e74fd1b7dd48ed7ec47ac2f42f8ca6f3
    Reviewed-on: https://chromium-review.googlesource.com/c/1262797
    Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    Commit-Queue: Marcin WiÄ…cek <marcin@mwiacek.com>
    Cr-Commit-Position: refs/heads/master@{#599546}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingException.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/PermissionInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java