Home | Search | chromium - Builders
Login

Builder Android WebView M (dbg) Build 3207 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision1454ad1f261d1089f2ac20cdc6e7e3d2562d731c
Got Revision1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

Execution:

Steps and Logfiles:

Show:
  1. ( 236 ms ) setup_build
    running recipe: "chromium"
  2. ( 153 ms ) report builders
     
    running tester 'Android WebView M (dbg)' on master 'chromium.android'
  3. ( 3 mins 23 secs ) bot_update
    [96GB/442GB used (21%)]
  4. ( 0 ) ensure_goma
    • - no logs -
  5. ( 281 ms ) ensure_goma.ensure_installed
  6. ( 606 ms ) swarming.py --version
    0.13
  7. ( 17 secs ) gclient runhooks
  8. ( 1 secs ) get compile targets for scripts
  9. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/s/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  10. ( 327 ms ) lookup builder GN args
     
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = true
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/s/w/ir/cache/goma/client"
  11. ( 2 secs ) clean local files
  12. ( 602 ms ) tree truth steps
  13. ( 1 secs ) build directory
  14. ( 10 mins 53 secs ) extract build
  15. ( 1 secs ) explain extract build
  16. ( 713 ms ) create adb symlink
  17. ( 508 ms ) spawn_logcat_monitor
  18. ( 377 ms ) spawn_device_monitor
  19. ( 474 ms ) authorize_adb_devices
  20. ( 2 secs ) device_recovery
  21. ( 1 mins 41 secs ) provision_devices
  22. ( 2 secs ) device_status
    Online devices: 1
  23. ( 0 ) test_pre_run
    • - no logs -
  24. ( 2 mins 27 secs ) system_webview_shell_layout_test_apk
  25. ( 2 secs ) system_webview_shell_layout_test_apk: generate result details
  26. ( 151 ms ) Report system_webview_shell_layout_test_apk results
  27. ( 20 secs ) Upload to test-results [system_webview_shell_layout_test_apk]
  28. ( 2 mins 39 secs ) webview_ui_test_app_test_apk
  29. ( 1 secs ) webview_ui_test_app_test_apk: generate result details
  30. ( 172 ms ) Report webview_ui_test_app_test_apk results
  31. ( 1 secs ) Upload to test-results [webview_ui_test_app_test_apk]
  32. ( 539 ms ) get version
  33. ( 2 secs ) install SystemWebView.apk
  34. ( 10 mins 41 secs ) Run CTS
  35. ( 1 secs ) CTS: generate result details
  36. ( 163 ms ) Report WebView CTS: M results
  37. ( 1 secs ) Upload to test-results [Run CTS]
  38. ( 352 ms ) shutdown_device_monitor
  39. ( 539 ms ) logcat_dump
  40. ( 3 secs ) gsutil upload
  41. ( 5 secs ) stack_tool_with_logcat_dump
  42. ( 614 ms ) stack_tool_for_tombstones
  43. ( 175 ms ) test_report
  44. ( 1 mins 50 secs ) generate breakpad symbols for libchrome.so
  45. ( 1 mins 47 secs ) generate breakpad symbols for libwebviewchromium.so
  46. ( 398 ms ) symbolized breakpad crashes
  47. ( 484 ms ) rmtree /b/s/w/ir/tmp/rt/symbolseM7nZ9
  48. ( 0 ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "build37-b1" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539348941914735, "id": "8932869359841319632", "project": "chromium", "tags": ["builder:Android WebView M (dbg)", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/1454ad1f261d1089f2ac20cdc6e7e3d2562d731c", "gitiles_ref:refs/heads/master", "parent_buildername:Android arm Builder (dbg)", "parent_buildnumber:37877", "scheduler_invocation_id:9098299421963173680", "scheduler_job_id:chromium/Android WebView M (dbg)", "user_agent:luci-scheduler", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android WebView M (dbg)" setup_build
buildnumber 3207 setup_build
mastername "chromium.android" setup_build
parent_buildername "Android arm Builder (dbg)" setup_build
parent_got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" setup_build
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" setup_build
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" setup_build
parent_got_revision "1454ad1f261d1089f2ac20cdc6e7e3d2562d731c" setup_build
parent_got_revision_cp "refs/heads/master@{#599172}" setup_build
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" setup_build
parent_got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" setup_build
parent_got_v8_revision_cp "refs/heads/7.1.302@{#1}" setup_build
parent_got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" setup_build
parent_got_webrtc_revision_cp "refs/heads/master@{#25136}" setup_build
parent_mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
revision "1454ad1f261d1089f2ac20cdc6e7e3d2562d731c" setup_build
swarm_hashes {"android_webview_unittests": "e88db320d5a44729ebf92bc6076bd428974d584f", "angle_unittests": "80fd5744ed069fe5901e959a73efc1888b6501a3", "base_unittests": "f86c0b3d7f56393987e6de940fa5142f24261907", "blink_common_unittests": "dd5208607bd4c0c0d46d181d751a13b5d2af6054", "blink_heap_unittests": "39840f96437ab1332ef39da00202e14867220beb", "blink_platform_unittests": "d3ab5e23c3111b4bbca89e4e3560bf0c148734e1", "boringssl_crypto_tests": "ca9b28d6dc9c3b815c997d75fab4bdbfb7c9a8df", "boringssl_ssl_tests": "359a69b402d9605abefa787ee2e1d91242d7002d", "breakpad_unittests": "5134e43c0682165819b7fe3e9d30015d30354d23", "cacheinvalidation_unittests": "7148ff5d4795e9bc9198edd70c11ac1887810200", "capture_unittests": "f62eea9df2dd3fcdc1ecbbad6263f512d36cd146", "cast_unittests": "49108c2793dee69c527dd6fd3452477a195db6e8", "cc_unittests": "712b326b66ffa717b8576c3eb81baaeb89e47368", "chrome_public_test_apk": "1d0cbece10a8782904f55be9ebd6e01b34172a2a", "chrome_public_test_vr_apk": "23445bbcdde6334bd0f3b8a50f88c2085a071d78", "chrome_sync_shell_test_apk": "94c0d01bc0a58f10be764340bdeefbfc5f40a823", "components_browsertests": "e360e452ae38648734d093c2140f4401a072556f", "components_unittests": "5fe1cb83d559b9d0014de04f900c69732f35a00b", "content_browsertests": "e4fdb8377ff0b474119c9650c3ee56502a2a748a", "content_shell_test_apk": "0ebe675b0b07766107b9855e056e80c4aa7e8464", "content_unittests": "8d29790ebaccee398d85424da6dbc7f461c526f9", "crypto_unittests": "f9fca71955d0119590fe558bd00f12f0ece70b0f", "device_unittests": "b2ac8b9a7f3468c52b20d4b7b7a011637238d7ab", "display_unittests": "821442188c586c55a9f6aa84ec4a51940f1f1755", "events_unittests": "b25bbcba8eb48c1a784585e70025b1508518775d", "gcm_unit_tests": "a3e76bdba87235a63c37ff1b0a6c530396696862", "gfx_unittests": "61462c4a4dd196b979886baff6bf2dbbf35015e8", "gin_unittests": "a0879eae1569349b90eaa06d8152a809a3356653", "gl_tests": "bd8de5c96aa8dfaf2b1ccd59a0e54831f861f67d", "gl_unittests": "cdfdc2808b33ce6e01ec56f9256fce0ce71797c2", "google_apis_unittests": "466394ace94c4e5c051b59cedf11f5a31316cf07", "gpu_unittests": "94bff53516d72f04e9bd3b2bd91c282e1e3cca4d", "ipc_tests": "b02f2efdd40e28ef3e5ef0ad84cafb6ab2a7e027", "jingle_unittests": "19981fad409b4f9dd94d7e999a2a914b2fb2ce5a", "latency_unittests": "d31022fe8e462fc0b872dd6e6d72afbe71808a34", "libjingle_xmpp_unittests": "3cf90026a95ca48fe14b03534df72cc649594f28", "media_blink_unittests": "63ee3364bbcad648f5cf0283eb8233bd91d4f2da", "media_service_unittests": "5edd32e9695a89e8747db7fd377fd38306d94582", "media_unittests": "5e51e5349bfc8a7a2caf0528724039e85edda680", "midi_unittests": "251ab862ce0b4a858ae2185ea187e98a6dd01733", "mojo_test_apk": "05a1348a5077208cc513f9cd911cb21401b43726", "mojo_unittests": "acaefe5b1a937d18a67e414126f98f42ba1d8f27", "net_unittests": "1c5c273791c8dbb6c732891d38e8da178087f0c4", "sandbox_linux_unittests": "75f5d769dd4aec8f32a0a923f41e65165582aeb6", "services_unittests": "d952ffd83022e8f39413b522c1ee151a45bb05c6", "shell_dialogs_unittests": "521266f241c0dde747309ff15f503133d3e71af5", "skia_unittests": "0ff8893f527ddea25fc286077d060d95c69e7b54", "sql_unittests": "3ef426e5fb274ae9acd75a3879dd127fe8c3ba19", "storage_unittests": "0ce46f3f3249175e24aef858c6ad8469f34407da", "ui_android_unittests": "23f028d29497c32d0cf0fd63b94ee2571dc77484", "ui_base_unittests": "230bb19afb29373cbda9ffa2c310597ac5d0d67f", "ui_touch_selection_unittests": "7cff8bc3ce1db653783887cef52a29cb1987256c", "unit_tests": "3df142e192dc607ad841b3263c46cb8935b3c3c8", "url_unittests": "e223a04013841748caaeff2ae9b08f07aa82eac1", "viz_unittests": "213aa32cb03004d5b791daf5471f33ac34af1ca8", "vr_common_unittests": "151f49b38df13bf205517b9da77ea3b4ff4ecd4d", "vr_pixeltests": "f0bddd5b0992d0469bda3bf3c20aafb1c585cfac", "webkit_layout_tests_exparchive": "d4aa68f300c4bc5a01dc3d2065e7920145b7b4db", "webkit_unit_tests": "394e87a5caeaa90ae76a0b0ce4b33923be68dc6b", "webview_cts_tests": "a1ddd14cfbf080bddcab5bc1d4eedac3d46fc519", "webview_instrumentation_test_apk": "f29e6370a63ae0b1bce58298dab7430fc232e0d1", "wtf_unittests": "a4ed526e1030972f6a1a799828cc4902661af4e9"} setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "1454ad1f261d1089f2ac20cdc6e7e3d2562d731c" bot_update
got_revision_cp "refs/heads/master@{#599172}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update

Blamelist:

  1. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  2. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  3. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  4. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  5. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  6. Scott Wu (scottwuohnoyoudont@chromium.org)
  7. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
  8. Scott Wu (scottwuohnoyoudont@chromium.org)
  9. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  10. Jordan Demeulenaere (jdemeulenaereohnoyoudont@google.com)
  11. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  12. Kurt Horimoto (kkhorimotoohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 12:55:41 UTC
Start Friday, 12-Oct-18 12:56:04 UTC
End Friday, 12-Oct-18 13:34:19 UTC
Pending 22 secs
Execution 38 mins 14 secs

All Changes:

  1. Add Picture-in-picture specific window resizer.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 11:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

    Comments

    Add Picture-in-picture specific window resizer.

Currently, this does essentially nothing apart from providing basic
resizing and moving functionality. In a follow-up CL, we can add
snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
like the virtual keyboard.

Bug: 841886
Bug: b/115291749
Test: Able to move and resize an Android PIP window.
Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
Reviewed-on: https://chromium-review.googlesource.com/c/1219428
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599172}

    Changed files

    • ash/BUILD.gn
    • ash/wm/pip/pip_window_resizer.cc
    • ash/wm/pip/pip_window_resizer.h
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_window_resizer.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc

  2. Run layout to avoid stale layout during SetIsInert()

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:26:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b

    Comments

    Run layout to avoid stale layout during SetIsInert()

Speculative fix for crbug.com/789094

Bug: 789094
Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
Reviewed-on: https://chromium-review.googlesource.com/c/823582
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599171}

    Changed files

    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc

  3. Remove MediaStreamRegistry.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:20:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7422130d3da18b70d4cc81951feda2ab615edef9

    Comments

    Remove MediaStreamRegistry.

This class is useless now that URL.createObjectURL(MediaStream) has
been removed from the Web platform.

Bug: 591719
Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
Reviewed-on: https://chromium-review.googlesource.com/c/1221320
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599170}

    Changed files

    • chrome/renderer/extensions/cast_streaming_native_handler.cc
    • chrome/renderer/extensions/cast_streaming_native_handler.h
    • chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
    • content/public/renderer/media_stream_utils.cc
    • content/renderer/media/web_media_element_source_utils.cc
    • content/renderer/render_frame_impl.cc
    • content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/web/web_media_stream_registry.h
    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/core/html/media/html_media_element.h
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
    • third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
    • third_party/blink/renderer/modules/mediastream/BUILD.gn
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
    • third_party/blink/renderer/modules/mediastream/media_stream.h
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.h

  4. Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d

    Comments

    Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
binji@chromium.org:
  external/wpt/wasm
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
Reviewed-on: https://chromium-review.googlesource.com/c/1278537
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599169}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
    • third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt

  5. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"

This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.

Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.

Original change's description:
> Revert "Remove IDC_SHOW_SYNC_SETUP"
> 
> This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
> 
> Reason for revert: Still needed for http://crbug.com/888776
> 
> Original change's description:
> > Remove IDC_SHOW_SYNC_SETUP
> > 
> > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
> > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
> > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
> > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
> > 
> > Bug: 870239
> > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
> > Reviewed-on: https://chromium-review.googlesource.com/1236263
> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#593138}
> 
> TBR=sky@chromium.org,msarda@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 870239
> Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
> Reviewed-on: https://chromium-review.googlesource.com/1245381
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#594261}

TBR=sky@chromium.org,msarda@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 870239
Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
Reviewed-on: https://chromium-review.googlesource.com/c/1278745
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc

  6. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
Reviewed-on: https://chromium-review.googlesource.com/c/1278670
Commit-Queue: Scott Wu <scottwu@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm

  7. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods

Add an optional callback to proxy override methods introduced in change
https://chromium-review.googlesource.com/c/chromium/src/+/1148384

This adds an optional callback developers can use to know when the
changes have been made to the network settings, since the methods are
not synchronous with the UI thread.

Bug: 851995
Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
Reviewed-on: https://chromium-review.googlesource.com/c/1258770
Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc

  8. Move password suggestion logic into components.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9a4429e3b49acb3be07a11697d3d9680f08e616

    Comments

    Move password suggestion logic into components.

Bug: 865114
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
Reviewed-on: https://chromium-review.googlesource.com/c/1264455
Reviewed-by: John Wu <jzw@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Scott Wu <scottwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599165}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_suggestion_helper.h
    • components/password_manager/ios/password_suggestion_helper.mm
    • ios/chrome/browser/passwords/password_controller.mm

  9. [css-properties-values-api] Multi-value StylePropertyMap.set.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d84303e41153ea9cb0f6475b6bb9e430666022a2

    Comments

    [css-properties-values-api] Multi-value StylePropertyMap.set.

This adds support for setting multiple values with TypedOM for list-valued
custom properties. For example, for a property --x with syntax <length>+,
it will now be possible to do:

  element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));

This is done by producing a CSSVariableReferenceValue holding tokens
equivalent to the incoming CSSStyleValues, provided that those values
match the grammar of the custom property.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
Reviewed-on: https://chromium-review.googlesource.com/c/1270963
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599164}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/css_syntax_descriptor.h
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc

  10. [Autofill Assistant] Make various improvements to the UI.

    Changed by Jordan Demeulenaere - jdemeulenaereohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 10:29:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e83ced5f800af6a60da52d8a183776b002c7b54

    Comments

    [Autofill Assistant] Make various improvements to the UI.

Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png
Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png

Binary-Size: Increase is due to adding new bottom bar background.
Bug: 806868
Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81
Reviewed-on: https://chromium-review.googlesource.com/c/1273518
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599163}

    Changed files

    • chrome/android/BUILD.gn
    • chrome/android/java/res_autofill_assistant/drawable-hdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-mdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable-xxxhdpi/autofill_assistant_bottombar_bg.9.png
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml
    • chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_pressed.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_chip.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
    • chrome/android/java/res_autofill_assistant/values-v17/styles.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java

  11. Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 10:26:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31904c2ab872bb48841916acaa8dd9fad167589e

    Comments

    Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2


git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock
2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version


Created with:
  gclient setdep -r src/third_party/chromite@03ec3c699be2

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d
Reviewed-on: https://chromium-review.googlesource.com/c/1278706
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599162}

    Changed files

    • DEPS

  12. [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.

    Changed by Kurt Horimoto - kkhorimotoohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61701cc0ee389e0dae437516d9b8edad2f874b18

    Comments

    [iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.

Now that the scroll proxy's contentInset is not guaranteed to be zero,
we need to check against the contentInset instead of CGPointZero.

Bug: 894617
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46
Reviewed-on: https://chromium-review.googlesource.com/c/1277674
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599161}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm