Builder Android WebView M (dbg)
Build 3207
Results:
Success
Trigger Info:
| Project | chromium |
| Revision | 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c |
| Got Revision | 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c |
Execution:
- Source: Task 40812a5993798010
- Bot: build37-b1
- Recipe: chromium
Steps and Logfiles:
Show:-
( 106751 days 23 hrs ) Failed to fetch step information from LogDogLog stream has no annotation entries
- - no logs -
Build Properties:
| Name | Value | Source |
|---|
Blamelist:
- Eliot Courtney (edcourtney@google.com)
- Rune Lillesveen (futhark@chromium.org)
- Guido Urdaneta (guidou@chromium.org)
- Chromium WPT Sync (blink-w3c-test-autoroller@chromium.org)
- Mihai Sardarescu (msarda@chromium.org)
- Scott Wu (scottwu@chromium.org)
- Laís Minchillo (laisminchillo@chromium.org)
- Scott Wu (scottwu@chromium.org)
- Anders Hartvoll Ruud (andruud@chromium.org)
- Jordan Demeulenaere (jdemeulenaere@google.com)
- chromium-autoroll (chromium-autoroll@skia-public.iam.gserviceaccount.com)
- Kurt Horimoto (kkhorimoto@chromium.org)
Timing:
| Create | Friday, 12-Oct-18 12:55:41 UTC |
| Start | Friday, 12-Oct-18 12:56:04 UTC |
| End | Friday, 12-Oct-18 13:34:19 UTC |
| Pending | 22 secs |
| Execution | 38 mins 14 secs |
All Changes:
-
Add Picture-in-picture specific window resizer.
Changed by Eliot Courtney - edcourtney@google.com Changed at Friday, 12-Oct-18 11:38:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c Comments
Add Picture-in-picture specific window resizer. Currently, this does essentially nothing apart from providing basic resizing and moving functionality. In a follow-up CL, we can add snap-to-edge, swipe-to-dismiss, and interaction with system ui regions like the virtual keyboard. Bug: 841886 Bug: b/115291749 Test: Able to move and resize an Android PIP window. Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749 Reviewed-on: https://chromium-review.googlesource.com/c/1219428 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#599172}
Changed files
- ash/BUILD.gn
- ash/wm/pip/pip_window_resizer.cc
- ash/wm/pip/pip_window_resizer.h
- ash/wm/pip/pip_window_resizer_unittest.cc
- ash/wm/workspace/workspace_window_resizer.cc
- components/exo/client_controlled_shell_surface.cc
- components/exo/client_controlled_shell_surface_unittest.cc
-
Run layout to avoid stale layout during SetIsInert()
Changed by Rune Lillesveen - futhark@chromium.org Changed at Friday, 12-Oct-18 11:26:19 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b Comments
Run layout to avoid stale layout during SetIsInert() Speculative fix for crbug.com/789094 Bug: 789094 Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc Reviewed-on: https://chromium-review.googlesource.com/c/823582 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#599171}
Changed files
- third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
- third_party/blink/renderer/core/html/html_dialog_element.cc
-
Remove MediaStreamRegistry.
Changed by Guido Urdaneta - guidou@chromium.org Changed at Friday, 12-Oct-18 11:20:26 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 7422130d3da18b70d4cc81951feda2ab615edef9 Comments
Remove MediaStreamRegistry. This class is useless now that URL.createObjectURL(MediaStream) has been removed from the Web platform. Bug: 591719 Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367 Reviewed-on: https://chromium-review.googlesource.com/c/1221320 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#599170}
Changed files
- chrome/renderer/extensions/cast_streaming_native_handler.cc
- chrome/renderer/extensions/cast_streaming_native_handler.h
- chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
- content/public/renderer/media_stream_utils.cc
- content/renderer/media/web_media_element_source_utils.cc
- content/renderer/render_frame_impl.cc
- content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
- third_party/blink/public/BUILD.gn
- third_party/blink/public/web/web_media_stream_registry.h
- third_party/blink/renderer/core/html/media/html_media_element.cc
- third_party/blink/renderer/core/html/media/html_media_element.h
- third_party/blink/renderer/modules/exported/BUILD.gn
- third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
- third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
- third_party/blink/renderer/modules/mediastream/BUILD.gn
- third_party/blink/renderer/modules/mediastream/media_stream.cc
- third_party/blink/renderer/modules/mediastream/media_stream.h
- third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
- third_party/blink/renderer/modules/mediastream/media_stream_registry.h
-
Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0
Changed by Chromium WPT Sync - blink-w3c-test-autoroller@chromium.org Changed at Friday, 12-Oct-18 10:49:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d Comments
Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0 Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566 Reviewed-on: https://chromium-review.googlesource.com/c/1278537 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#599169}
Changed files
- third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
- third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
- third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
- third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
- third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
- third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
- third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
-
Reland "Remove IDC_SHOW_SYNC_SETUP"
Changed by Mihai Sardarescu - msarda@chromium.org Changed at Friday, 12-Oct-18 10:48:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 290bc882fa0022afd17118d11949266c86fa631b Comments
Reland "Remove IDC_SHOW_SYNC_SETUP" This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b. Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL. Original change's description: > Revert "Remove IDC_SHOW_SYNC_SETUP" > > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424. > > Reason for revert: Still needed for http://crbug.com/888776 > > Original change's description: > > Remove IDC_SHOW_SYNC_SETUP > > > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing. > > > > Bug: 870239 > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402 > > Reviewed-on: https://chromium-review.googlesource.com/1236263 > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#593138} > > TBR=sky@chromium.org,msarda@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 870239 > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338 > Reviewed-on: https://chromium-review.googlesource.com/1245381 > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594261} TBR=sky@chromium.org,msarda@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870239 Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe Reviewed-on: https://chromium-review.googlesource.com/c/1278745 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#599168}
Changed files
- chrome/app/chrome_command_ids.h
- chrome/browser/ui/browser_command_controller.cc
- chrome/browser/ui/browser_command_controller_unittest.cc
- chrome/browser/ui/toolbar/app_menu_model.cc
-
Rename PasswordControllerHelper to PasswordFormHelper
Changed by Scott Wu - scottwu@chromium.org Changed at Friday, 12-Oct-18 10:44:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 830919bab9ae548252386c0e0b2bb97b4a22152e Comments
Rename PasswordControllerHelper to PasswordFormHelper Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587 Reviewed-on: https://chromium-review.googlesource.com/c/1278670 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599167}
Changed files
- components/password_manager/ios/BUILD.gn
- components/password_manager/ios/password_form_helper.h
- components/password_manager/ios/password_form_helper.mm
- components/password_manager/ios/password_form_helper_unittest.mm
- components/password_manager/ios/password_suggestion_helper.h
- ios/chrome/browser/passwords/password_controller.h
- ios/chrome/browser/passwords/password_controller.mm
- ios/chrome/browser/passwords/password_controller_unittest.mm
- ios/web_view/internal/passwords/cwv_password_controller.mm
-
[aw] Add callback to proxy override methods
Changed by Laís Minchillo - laisminchillo@chromium.org Changed at Friday, 12-Oct-18 10:36:11 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2 Comments
[aw] Add callback to proxy override methods Add an optional callback to proxy override methods introduced in change https://chromium-review.googlesource.com/c/chromium/src/+/1148384 This adds an optional callback developers can use to know when the changes have been made to the network settings, since the methods are not synchronous with the UI thread. Bug: 851995 Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217 Reviewed-on: https://chromium-review.googlesource.com/c/1258770 Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#599166}
Changed files
- android_webview/browser/aw_contents_statics.cc
- android_webview/browser/net/aw_url_request_context_getter.cc
- android_webview/browser/net/aw_url_request_context_getter.h
- android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
- android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
- android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
- android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
- android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
- net/proxy_resolution/proxy_config_service_android.cc
- net/proxy_resolution/proxy_config_service_android.h
- net/proxy_resolution/proxy_config_service_android_unittest.cc
-
Move password suggestion logic into components.
Changed by Scott Wu - scottwu@chromium.org Changed at Friday, 12-Oct-18 10:34:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b9a4429e3b49acb3be07a11697d3d9680f08e616 Comments
Move password suggestion logic into components. Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc Reviewed-on: https://chromium-review.googlesource.com/c/1264455 Reviewed-by: John Wu <jzw@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Scott Wu <scottwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599165}
Changed files
- components/password_manager/ios/BUILD.gn
- components/password_manager/ios/password_suggestion_helper.h
- components/password_manager/ios/password_suggestion_helper.mm
- ios/chrome/browser/passwords/password_controller.mm
-
[css-properties-values-api] Multi-value StylePropertyMap.set.
Changed by Anders Hartvoll Ruud - andruud@chromium.org Changed at Friday, 12-Oct-18 10:33:59 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d84303e41153ea9cb0f6475b6bb9e430666022a2 Comments
[css-properties-values-api] Multi-value StylePropertyMap.set. This adds support for setting multiple values with TypedOM for list-valued custom properties. For example, for a property --x with syntax <length>+, it will now be possible to do: element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2)); This is done by producing a CSSVariableReferenceValue holding tokens equivalent to the incoming CSSStyleValues, provided that those values match the grammar of the custom property. R=chrishtr@chromium.org Bug: 641877 Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb Reviewed-on: https://chromium-review.googlesource.com/c/1270963 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599164}Changed files
- third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
- third_party/blink/renderer/core/css/css_syntax_descriptor.h
- third_party/blink/renderer/core/css/cssom/style_property_map.cc
-
[Autofill Assistant] Make various improvements to the UI.
Changed by Jordan Demeulenaere - jdemeulenaere@google.com Changed at Friday, 12-Oct-18 10:29:47 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5e83ced5f800af6a60da52d8a183776b002c7b54 Comments
[Autofill Assistant] Make various improvements to the UI. Screenshot before: https://screenshot.googleplex.com/5zbTV7W40Rh.png Screenshot after: https://screenshot.googleplex.com/59OsupD4J5o.png Binary-Size: Increase is due to adding new bottom bar background. Bug: 806868 Change-Id: Ie6863f6922eca210f3e823c22318cd6bd323be81 Reviewed-on: https://chromium-review.googlesource.com/c/1273518 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#599163}
Changed files
- chrome/android/BUILD.gn
- chrome/android/java/res_autofill_assistant/drawable-hdpi/autofill_assistant_bottombar_bg.9.png
- chrome/android/java/res_autofill_assistant/drawable-mdpi/autofill_assistant_bottombar_bg.9.png
- chrome/android/java/res_autofill_assistant/drawable-xhdpi/autofill_assistant_bottombar_bg.9.png
- chrome/android/java/res_autofill_assistant/drawable-xxhdpi/autofill_assistant_bottombar_bg.9.png
- chrome/android/java/res_autofill_assistant/drawable-xxxhdpi/autofill_assistant_bottombar_bg.9.png
- chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg.xml
- chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_normal.xml
- chrome/android/java/res_autofill_assistant/drawable/autofill_assistant_chip_bg_pressed.xml
- chrome/android/java/res_autofill_assistant/layout/autofill_assistant_chip.xml
- chrome/android/java/res_autofill_assistant/layout/autofill_assistant_sheet.xml
- chrome/android/java/res_autofill_assistant/values-v17/styles.xml
- chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
-
Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits)
Changed by chromium-autoroll - chromium-autoroll@skia-public.iam.gserviceaccount.com Changed at Friday, 12-Oct-18 10:26:02 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 31904c2ab872bb48841916acaa8dd9fad167589e Comments
Roll src/third_party/chromite e2727ef6f5dc..03ec3c699be2 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/e2727ef6f5dc..03ec3c699be2 git log e2727ef6f5dc..03ec3c699be2 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 vapier@chromium.org cros_portage_upgrade_unittest: convert to mock 2018-10-12 vapier@chromium.org gsutil: add wrapper script for our pinned version Created with: gclient setdep -r src/third_party/chromite@03ec3c699be2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9f381f438b01450da63805d85cec801baa22ec4d Reviewed-on: https://chromium-review.googlesource.com/c/1278706 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599162}
Changed files
- DEPS
-
[iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|.
Changed by Kurt Horimoto - kkhorimoto@chromium.org Changed at Friday, 12-Oct-18 10:24:10 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 61701cc0ee389e0dae437516d9b8edad2f874b18 Comments
[iOS] Fix BVC's |-isTabScrolledToTopForBubblePresenter:|. Now that the scroll proxy's contentInset is not guaranteed to be zero, we need to check against the contentInset instead of CGPointZero. Bug: 894617 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5ba5131c969a4584879be905a92f0736a34d7f46 Reviewed-on: https://chromium-review.googlesource.com/c/1277674 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599161}
Changed files
- ios/chrome/browser/ui/browser_view_controller.mm
