Home | Search | chromium - Builders
Login

Builder Android Release (Nexus 5X) Build 9096 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision31322898bc81e2e07e3d9f89aa051a60c5f93215
Got Revision31322898bc81e2e07e3d9f89aa051a60c5f93215

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. David Roger (drogerohnoyoudont@chromium.org)
  2. Peter Kasting (pkastingohnoyoudont@chromium.org)

Timing:

Create Saturday, 11-Aug-18 06:44:30 UTC
Start Saturday, 11-Aug-18 06:44:33 UTC
End Saturday, 11-Aug-18 07:07:00 UTC
Pending 3 secs
Execution 22 mins 27 secs

All Changes:

  1. [Settings] UserEvents depends on history and passphrase

    Changed by David Roger - drogerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 06:43:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31322898bc81e2e07e3d9f89aa051a60c5f93215

    Comments

    [Settings] UserEvents depends on history and passphrase
    
    This is a reland of:
    https://chromium-review.googlesource.com/1170202
    
    which was reverted because of missing svg icon.
    
    The user events UI toggle should be grayed out and turned off
    when there is a passphrase or when history sync is disabled.
    Note that this is purely a UI change: the internal sync datatype
    is not really turned off in that case, and we assume that the Sync
    engines will correctly stop syncing user events in these cases,
    even if the preference is still ON.
    
    Bug: 865522, 865537
    Change-Id: I745f048b3ca301231f57c04b82d0d9d82a6f3b90
    Reviewed-on: https://chromium-review.googlesource.com/1170825
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: David Roger <droger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582433}

    Changed files

    • chrome/browser/resources/settings/people_page/sync_browser_proxy.js
    • chrome/browser/resources/settings/people_page/sync_page.html
    • chrome/browser/resources/settings/people_page/sync_page.js
    • chrome/test/data/webui/settings/people_page_sync_page_test.js
  2. Revert "Change the history state throttle interval from 60 to 120 Hz."

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 05:51:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5823b44aa85c3e803530cc77e9bd7429d523c575

    Comments

    Revert "Change the history state throttle interval from 60 to 120 Hz."
    
    This reverts commit 8e4127dd506c501cd3f51d91dc22a3dfa8f5f1ca.
    
    Reason for revert: Part 1 of trying to revert the history throttling changes, to see if https://bugs.chromium.org/p/chromium/issues/detail?id=870861 improves.
    
    Original change's description:
    > Change the history state throttle interval from 60 to 120 Hz.
    > 
    > This is a bit more lenient and may enable some callers, including a flaky test,
    > to get (more of) what they need. The test's root problem seems to be data races
    > (see issue 847326), however.
    > 
    > Bug: 870861
    > Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c
    > Reviewed-on: https://chromium-review.googlesource.com/1171825
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Commit-Queue: Chris Palmer <palmer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582415}
    
    TBR=palmer@chromium.org,dcheng@chromium.org,kinuko@chromium.org
    
    Change-Id: I9fb7b5b0f8ebff8b6d6c5a772745cfd2c10ef51a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 870861
    Reviewed-on: https://chromium-review.googlesource.com/1171708
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582432}

    Changed files

    • third_party/blink/renderer/core/frame/history.cc