Home | Search | chromium - Builders
Login

Builder Android Release (Nexus 5X) Build 12694 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision9d5ca99f28add2c0b844511a2416d1f555726c9b
Got Revision9d5ca99f28add2c0b844511a2416d1f555726c9b

Execution:

Steps and Logfiles:

Show:
  1. ( 398 ms ) setup_build
    running recipe: "chromium"
  2. ( 340 ms ) report builders
     
    running builder/tester 'Android Release (Nexus 5X)' on master 'chromium.gpu'
  3. ( 52 secs ) bot_update
    [110GB/295GB used (37%)]
  4. ( 806 ms ) swarming.py --version
    0.13
  5. ( 12 secs ) gclient runhooks
  6. ( 521 ms ) read test spec (chromium.gpu.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.json
  7. ( 4 secs ) clean local files
  8. ( 2 secs ) tree truth steps
  9. ( 755 ms ) lookup GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 36 secs ) generate_build_files
  11. ( 54 mins 5 secs ) compile
  12. ( 32 secs ) compile confirm no-op
  13. ( 31 secs ) isolate tests
  14. ( 661 ms ) find isolated tests
  15. ( 2 mins 9 secs ) wait for tasks
  16. ( 1 secs ) hardware_accelerated_feature_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:14.592169
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  17. ( 1 secs ) depth_capture_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:54.937803
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  18. ( 2 mins 1 secs ) wait for tasks (2)
  19. ( 1 secs ) info_collection_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:46.293994
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 1 secs ) maps_pixel_test on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:36.951626
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 1 secs ) screenshot_sync_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:21.610796
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 1 secs ) context_lost_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:27.485895
    Total tests: 10
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 954 ms ) wait for tasks (3)
  24. ( 1 secs ) gpu_process_launch_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:40.927704
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 2 mins 1 secs ) wait for tasks (4)
  26. ( 1 secs ) trace_test on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:26.796487
    Total tests: 40
    * Passed: 20 (20 expected, 0 unexpected)
    * Skipped: 20 (20 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 6 mins 2 secs ) wait for tasks (5)
  28. ( 1 secs ) pixel_test on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:12:26.076771
    Total tests: 51
    * Passed: 37 (37 expected, 0 unexpected)
    * Skipped: 14 (14 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 39 secs ) webgl_conformance_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:13:35.314787 (shard #2)
    Min shard duration: 0:06:17.338702 (shard #4)
    Total tests: 932
    * Passed: 923 (923 expected, 0 unexpected)
    * Skipped: 9 (9 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 336 ms ) Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 1:25:18.383400
     
  31. ( 354 ms ) test_report

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm236-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542162303794916, "id": "8929919336094739040", "project": "chromium", "tags": ["builder:Android Release (Nexus 5X)", "buildset:commit/git/9d5ca99f28add2c0b844511a2416d1f555726c9b", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/9d5ca99f28add2c0b844511a2416d1f555726c9b", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095349398375197280", "scheduler_job_id:chromium/Android Release (Nexus 5X)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android Release (Nexus 5X)" setup_build
buildnumber 12694 setup_build
mastername "chromium.gpu" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "9d5ca99f28add2c0b844511a2416d1f555726c9b" setup_build
got_angle_revision "d1a55e393e65601ba26e2d76bd46a12fc6bc4e3e" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "597e1587b4bfc7bf89895c7c879ae58b649da3c5" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "9d5ca99f28add2c0b844511a2416d1f555726c9b" bot_update
got_revision_cp "refs/heads/master@{#607874}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "dd90e943fb1fb45baaafb93e5055f60d6c94348e" bot_update
got_v8_revision_cp "refs/heads/7.2.320@{#1}" bot_update
got_webrtc_revision "6dbf0e43a5ff4768fea849de829c84e5470d544b" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25628}" bot_update
swarm_hashes_refs/heads/master(at){#607874}_without_patch {"telemetry_gpu_integration_test": "bdb1eb53487c04ec16ea8c48bdb930eee88e058d"} isolate tests
swarm_hashes {"telemetry_gpu_integration_test": "bdb1eb53487c04ec16ea8c48bdb930eee88e058d"} find isolated tests

Blamelist:

  1. Victor Miura (vmiuraohnoyoudont@chromium.org)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. Michael Lippautz (mlippautzohnoyoudont@chromium.org)
  4. David Black (dmblackohnoyoudont@google.com)
  5. Lei Zhang (thestigohnoyoudont@chromium.org)
  6. Yuichiro Hanada (yhanadaohnoyoudont@chromium.org)
  7. Sadrul Habib Chowdhury (sadrulohnoyoudont@chromium.org)
  8. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  9. Mei Liang (meiliangohnoyoudont@chromium.org)
  10. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  11. Quan Nguyen (qnnguyenohnoyoudont@chromium.org)
  12. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  13. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  14. yiyix (yiyixohnoyoudont@chromium.org)
  15. Hiroshige Hayashizaki (hiroshigeohnoyoudont@chromium.org)
  16. Rakina Zata Amni (rakinaohnoyoudont@chromium.org)
  17. chromium-internal-autoroll (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  18. Jinsuk Kim (jinsukkimohnoyoudont@chromium.org)
  19. Nikunj Bhagat (nikunjbohnoyoudont@chromium.org)
  20. Eric Roman (eromanohnoyoudont@chromium.org)
  21. Sammie Quon (sammiequonohnoyoudont@google.com)
  22. Hector Carmona (hcarmonaohnoyoudont@chromium.org)
  23. Theresa (twellingtonohnoyoudont@chromium.org)
  24. Akihiro Ota (akihirootaohnoyoudont@chromium.org)
  25. Stephen Chenney (schenneyohnoyoudont@chromium.org)
  26. Kent Tamura (tkentohnoyoudont@chromium.org)
  27. Toni Barzic (tbarzicohnoyoudont@chromium.org)
  28. Yutaka Hirano (yhiranoohnoyoudont@chromium.org)
  29. Thoren Paulson (thorenohnoyoudont@chromium.org)
  30. Jia (jiamengohnoyoudont@chromium.org)
  31. Eric Roman (eromanohnoyoudont@chromium.org)
  32. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  33. Luciano Pacheco (lucmultohnoyoudont@chromium.org)
  34. Nigel Tao (nigeltaoohnoyoudont@chromium.org)

Timing:

Create Wednesday, 14-Nov-18 02:25:03 UTC
Start Wednesday, 14-Nov-18 02:25:06 UTC
End Wednesday, 14-Nov-18 03:36:58 UTC
Pending 2 secs
Execution 1 hrs 11 mins

All Changes:

  1. Remove old *_scroll_200_layer_grid rendering stories.

    Changed by Victor Miura - vmiuraohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d5ca99f28add2c0b844511a2416d1f555726c9b

    Comments

    Remove old *_scroll_200_layer_grid rendering stories.
    
    These stories are superceded by newer stories such as
    infinite_scroll_root_n_layers_99 and css_opacity_plus_n_layers_99.
    
    Now that we have had overlapping data from the new stories for some
    time, the old stories can be removed.
    
    BUG=878951
    
    Change-Id: Idb146ed7d9f5420bac1d5217e86c6547a772efe5
    Reviewed-on: https://chromium-review.googlesource.com/c/1334929
    Commit-Queue: Victor Miura <vmiura@chromium.org>
    Reviewed-by: Annie Sullivan <sullivan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607874}

    Changed files

    • tools/perf/page_sets/rendering/tough_compositor_cases.py
  2. Roll src/third_party/pdfium f768692bdef0..f28410e9eb26 (16 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:22:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 83f03e20f711be2eefa401ebf3dd4035976e5264

    Comments

    Roll src/third_party/pdfium f768692bdef0..f28410e9eb26 (16 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/f768692bdef0..f28410e9eb26
    
    
    git log f768692bdef0..f28410e9eb26 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 tsepez@chromium.org Use {{include}} directive in more tests.
    2018-11-14 tsepez@chromium.org Introduce {{include}} directive for PDF file fixup.
    2018-11-14 tsepez@chromium.org Add CPDF_IndirectObjectHolder::New<T>()
    2018-11-13 thestig@chromium.org Add more tests for transfer function creation and usage.
    2018-11-12 tsepez@chromium.org Test pushbutton specific field properties.
    2018-11-10 thestig@chromium.org Roll tools/clang/ 3041f30dd..31f2d265b (4 commits)
    2018-11-10 thestig@chromium.org Roll build/ a09219387..81ffd0040 (178 commits)
    2018-11-10 thestig@chromium.org Roll buildtools/ 2dff9c9c7..fdce2ad26 (2 commits)
    2018-11-10 thestig@chromium.org Roll DEPS for catapult to 5d509166
    2018-11-10 thestig@chromium.org Roll third_party/googletest/src/ d52663267..2e68926a9 (68 commits)
    2018-11-10 thestig@chromium.org Roll third_party/instrumented_libraries/ 323cf3219..a959e4f0c (4 commits)
    2018-11-10 thestig@chromium.org Roll third_party/zlib/ dcf1d0f8c..dde5ce526 (6 commits)
    2018-11-10 thestig@chromium.org Roll third_party/depot_tools/ 71e3be7a5..ddbeac1c0 (78 commits; 12 trivial rolls)
    2018-11-10 thestig@chromium.org Roll third_party/icu/ c56c67199..45f655f2f (11 commits)
    2018-11-10 thestig@chromium.org Roll third_party/skia/ fa7df23d8..36b85be49 (158 commits; 11 trivial rolls)
    2018-11-10 thestig@chromium.org Roll third_party/freetype/src/ f56830ed4..fb0d66d04 (20 commits)
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@f28410e9eb26
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I532bd42f0153e67d50628395705ccd33a1350831
    Reviewed-on: https://chromium-review.googlesource.com/c/1334572
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607873}

    Changed files

    • DEPS
  3. [heap] Fix GC forbidden scopes for mixin construction

    Changed by Michael Lippautz - mlippautzohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:20:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac99379aadb42b81baec1c5c3c1b44b9851a0ac7

    Comments

    [heap] Fix GC forbidden scopes for mixin construction
    
    Mixin construction relies on the fact that no garbage collection can be
    triggered.
    
    When moving to the new MakeGarbageCollected bottleneck the hook for
    mixin construction was dropped. This restores previous behavior.
    
    In a followup GarabgeCollectedMixin::operator new() should be inlined in
    the construct trait, creating the invariant that all operator new()
    methods are deleted for Oilpan.
    
    Bug: 904546, 757708
    Change-Id: I47e672f1cb3035d8a4bea72d90bfceb2a31c5d89
    Reviewed-on: https://chromium-review.googlesource.com/c/1333761
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607872}

    Changed files

    • third_party/blink/renderer/platform/heap/heap.h
    • third_party/blink/renderer/platform/heap/heap_test.cc
  4. Revise Assistant strings for Related Info.

    Changed by David Black - dmblackohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 02:20:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91af083690ca920d3d9dbef765b2f0eebdbd7dd0

    Comments

    Revise Assistant strings for Related Info.
    
    Per request, modifying Assistant strings for Related Info. These
    strings occur in Chrome Settings and Assistant OOBE.
    
    See bug for screenshots.
    
    Bug: b:119503388
    Change-Id: I9219c59dceac4207061e978efe68633f89d7034b
    Reviewed-on: https://chromium-review.googlesource.com/c/1334279
    Reviewed-by: Ken Rockot <rockot@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#607871}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/app/settings_strings.grdp
  5. Sort flag descriptions.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:19:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a318aff84d336a795b51456383b8e830594a2a4

    Comments

    Sort flag descriptions.
    
    Move some out of place flag descriptions to the right sections.
    
    Change-Id: I61569c122d8b5c93adcad002661a13fc33dcd14a
    Reviewed-on: https://chromium-review.googlesource.com/c/1330893
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607870}

    Changed files

    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
  6. Reland: Disable Android IMEs according to given ImeInfo.

    Changed by Yuichiro Hanada - yhanadaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:19:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e3199eebf9f6278aa9ce8914b9315f6de041471b

    Comments

    Reland: Disable Android IMEs according to given ImeInfo.
    
    The original CL is crrev.com/c/1331294 and it was reverted due to
    MSan failure. The failure should be fixed by adding initialization for
    |is_removing_imm_entry_|.
    
    Android IMEs can be disabled in Android side by using 'ime' command.
    This CL ensures that disabled IMEs are also disabled in Chrome OS's
    InputMethodManager.
    
    Bug: b/119274469
    Change-Id: I4f9067cabf96fcb28d594a72856df1e34d469114
    Reviewed-on: https://chromium-review.googlesource.com/c/1334672
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607869}

    Changed files

    • chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.cc
    • chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service.h
  7. cc: Make sure a CompletionEvent is always signaled.

    Changed by Sadrul Habib Chowdhury - sadrulohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:18:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02d11389962b1a683fe21f2e0bbb5ff4e75bf271

    Comments

    cc: Make sure a CompletionEvent is always signaled.
    
    It looks like there is a CompletionEvent that is never getting signaled
    from the compositor thread, and the main-thread stays blocked on it.
    This causes a fair number of hangs in the renderers (~30% of all hangs
    or crashes in cc/ code in stable channel on Windows). Try using a
    ScopedCompletionEvent to make sure all CompletionEvents are always
    signaled, and see if that helps.
    
    BUG=622080
    
    Change-Id: Ic25089f0e4f671182b18c1b44e278196eeb040c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1332726
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607868}

    Changed files

    • cc/trees/proxy_impl.cc
    • cc/trees/proxy_impl.h
  8. Roll src/third_party/catapult 6d64a5e5e40b..6ce627d2b73d (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:18:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 536b73ebdf0e46c85bf316c9955b2742ec03b502

    Comments

    Roll src/third_party/catapult 6d64a5e5e40b..6ce627d2b73d (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/6d64a5e5e40b..6ce627d2b73d
    
    
    git log 6d64a5e5e40b..6ce627d2b73d --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 benjhayden@chromium.org Add place-holder for v2spa.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@6ce627d2b73d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: Ib7d97fbe1d8d8c99104429375797b359ca00350d
    Reviewed-on: https://chromium-review.googlesource.com/c/1334587
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607867}

    Changed files

    • DEPS
  9. Follow up on histograms added in CL:1313550

    Changed by Mei Liang - meiliangohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:17:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e45f8be19fdb67b95053e3667ef83837d52e5a36

    Comments

    Follow up on histograms added in CL:1313550
    
    This CL updates the histogram metadata.
    
    Bug: 890502
    Change-Id: I20fa1f69a3b7fc720fc314d2be98bff6fd175415
    Reviewed-on: https://chromium-review.googlesource.com/c/1333781
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607866}

    Changed files

    • tools/metrics/histograms/histograms.xml
  10. Update V8 to version 7.2.320.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:17:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0fe1eeb424e7372ad6b171e969e195d043416b50

    Comments

    Update V8 to version 7.2.320.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/9d32daac..dd90e943
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Iaa8537cab02e312ed8ee99a20c6bc64ed446c2b3
    Reviewed-on: https://chromium-review.googlesource.com/c/1334562
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607865}

    Changed files

    • DEPS
  11. cros: Fix long emails messing up Remove User button placement

    Changed by Quan Nguyen - qnnguyenohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96f5ccc36864e1cf5867211d7d0eea29fa2d7c80

    Comments

    cros: Fix long emails messing up Remove User button placement
    
    The email label now uses the same layout rule as the user name label, which
    fixes the same bug, but for long emails rather than long user names.
    
    Bug: 902362
    Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405
    Reviewed-on: https://chromium-review.googlesource.com/c/1334827
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607864}

    Changed files

    • ash/login/ui/login_bubble.cc
    • ash/login/ui/login_bubble_unittest.cc
  12. Roll src/third_party/skia 9d958b54af30..6c242459120d (5 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:16:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6aac239b9d6eb64f7dd7ee9806b17ee7cd9a9e1

    Comments

    Roll src/third_party/skia 9d958b54af30..6c242459120d (5 commits)
    
    https://skia.googlesource.com/skia.git/+log/9d958b54af30..6c242459120d
    
    
    git log 9d958b54af30..6c242459120d --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 brianosman@google.com Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS from Skia's Chromium GN
    2018-11-13 scroggo@google.com Remove unused SkPath::unique()
    2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ed398b46847..b3c4d88a647a (1 commits)
    2018-11-13 scroggo@google.com Build custom empty SkFontMgr for Android Framework
    2018-11-13 jvanverth@google.com Avoid overflow in bufferOffset calculations
    
    
    Created with:
      gclient setdep -r src/third_party/skia@6c242459120d
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:b/118742766
    TBR=rmistry@chromium.org
    
    Change-Id: Ife94330d4007392c300980f4c387e0fd8267bcb7
    Reviewed-on: https://chromium-review.googlesource.com/c/1334249
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607863}

    Changed files

    • DEPS
  13. Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:15:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 36d98fc346b8506fb91139149e605c6d7b57bc80

    Comments

    Roll src/third_party/angle f9143725470b..d1a55e393e65 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65
    
    
    git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s'
    2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@d1a55e393e65
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:822310
    TBR=cwallez@chromium.org
    
    Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02
    Reviewed-on: https://chromium-review.googlesource.com/c/1334570
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607862}

    Changed files

    • DEPS
  14. FrameMetrics: Track the skipped frame rate during scrolling event only

    Changed by yiyix - yiyixohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:15:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08e71a98c5f020c4af56d2a092512bb87742c1db

    Comments

    FrameMetrics: Track the skipped frame rate during scrolling event only
    
    Skipped Frame tracker used to record every frame produced at all times.
    With that approach, it's hard to study the correlation between the user
    actions and the skipped frame rate. In this patch, we only track the
    skipped frame rate during scrolling events. More user actions will be
    added in the future cls.
    
    Design doc on skipped frame tracker:
    https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg
    
    Videos on how it used to work:
    https://drive.google.com/open?id=1S5fnq8VrqvUIYFZjvIi4GNA3ekIdggG0
    
    Bug: 894149
    
    Change-Id: I02441cb5c9f551cc80b51ea1dcbafa3c492cb5ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1334103
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607861}

    Changed files

    • cc/trees/layer_tree_host_impl.cc
    • ui/latency/skipped_frame_tracker_unittest.cc
  15. Implement FetchClientSettingsObject::GetHttpsState()

    Changed by Hiroshige Hayashizaki - hiroshigeohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:14:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2de0f9a45dc3e898f5c784f1054667d662c5e10

    Comments

    Implement FetchClientSettingsObject::GetHttpsState()
    
    Previously, FetchClientSettingsObjectImpl
    - Is used as WorkerFetchContext's FetchClientSettingsObject,
    - Implements GetHttpsState(), and
    - Is used for checking mixed contents on workers.
    
    Issue 880027 will introduce outsideSettings WorkerFetchContext
    which will have FetchClientSettingsObjectSnapshot as its
    FetchClientSettingsObject [1].
    
    Therefore, this CL switches
    - WorkerFetchContext's FetchClientSettingsObject and
    - MixedContentChecker::IsMixedContent()
    to use FetchClientSettingsObject (not ...Impl), and
    implements GetHttpsState() in FetchClientSettingsObject
    and FetchClientSettingsObjectSnapshot.
    
    This CL shouldn't change the behavior at this time, because
    WorkerFetchContext's FetchClientSettingsObject is still
    a FetchClientSettingsObjectImpl object, and thus mixed content
    checks is done using already-implemented
    FetchClientSettingsObjectImpl::GetHttpsState().
    
    The code path added in this CL will be used in [2].
    
    [1] https://chromium-review.googlesource.com/1328043
    [2] https://chromium-review.googlesource.com/1328164
    
    Bug: 880027
    Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5
    Reviewed-on: https://chromium-review.googlesource.com/c/1328162
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607860}

    Changed files

    • third_party/blink/renderer/core/execution_context/execution_context.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.cc
    • third_party/blink/renderer/core/loader/mixed_content_checker.h
    • third_party/blink/renderer/core/loader/worker_fetch_context.cc
    • third_party/blink/renderer/core/loader/worker_fetch_context.h
    • third_party/blink/renderer/core/script/fetch_client_settings_object_impl.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.cc
    • third_party/blink/renderer/platform/loader/fetch/fetch_client_settings_object_snapshot.h
    • third_party/blink/renderer/platform/loader/fetch/fetch_context.cc
    • third_party/blink/renderer/platform/loader/testing/mock_fetch_context.h
  16. Don't try sending request to another frame in a navigated/deleted WebContents

    Changed by Rakina Zata Amni - rakinaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:14:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 161961235715f25c10ba1148de76a4d0ef1310c4

    Comments

    Don't try sending request to another frame in a navigated/deleted WebContents
    
    In WebContents destructor, |find_request_manager_| is not reset but
    FrameTreeNode destructor is trigerred, eventually causing calls to
    FindRequestManager::SendFindRequest that will try to send a find request
    to another frame in the same WebContents, which results in a crash.
    
    There are also other cases where the WebContents is navigated away,
    the window is closed, etc. where we also try sending to another frame
    within that WebContents, even though we won't need it. This CL fixes
    the crash, and the root cause will be explored and fixed in another CL.
    
    Bug: 884679
    Change-Id: I229f38a663d50b6a5e8e167ac0d483f9826a7f0b
    Reviewed-on: https://chromium-review.googlesource.com/c/1242728
    Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607859}

    Changed files

    • content/browser/find_request_manager.cc
    • content/browser/web_contents/web_contents_impl.cc
  17. Roll src-internal 9e9db70e8858..def2885f901d (3 commits)

    Changed by chromium-internal-autoroll - chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:13:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 178a9d33bdba14b622e75e8f88307ef5cd453fee

    Comments

    Roll src-internal 9e9db70e8858..def2885f901d (3 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e9db70e8858..def2885f901d
    
    
    Created with:
      gclient setdep -r src-internal@def2885f901d
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I09159c00b4e8c4709792f921e2c0d0feebf1c541
    Reviewed-on: https://chromium-review.googlesource.com/c/1334571
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607858}

    Changed files

    • DEPS
  18. Reland "Android: TabThemeColorHelper"

    Changed by Jinsuk Kim - jinsukkimohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:12:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b097e53b2592b8e1ac68ca811bca5dc2e665ec79

    Comments

    Reland "Android: TabThemeColorHelper"
    
    Android CFI tests exposed a missing null check in one of the tests.
    Relanding https://crrev.com/c/1304038 after fixing it.
    
    TBR=tedchoc@chromium.org
    
    Bug: 877878
    
    This reverts commit 7d0fbfd8b6d57ccbd94d78d66288485c07c2819e.
    
    Change-Id: I75c560af86cd0f92b4b5eded5896c884fb7181ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1334667
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607857}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabThemeColorHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/TabThemeTest.java
  19. AutofillManager reset shouldn't cause the metrics to be dropped

    Changed by Nikunj Bhagat - nikunjbohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:11:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feb4f0d0edb3027d6b1be034aafa38f5fcea8cc0

    Comments

    AutofillManager reset shouldn't cause the metrics to be dropped
    
    Bug: 904953
    Change-Id: I763d48881143645102fdaf5d85cb2ab812e8b8c0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334327
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607856}

    Changed files

    • components/autofill/core/browser/autofill_manager.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • components/autofill/core/browser/test_autofill_manager.cc
  20. Bypass the proxy implicitly for "loopback" (on Windows only).

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:11:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7aeea3a2da27e2bf566cf11e75f960124061c79c

    Comments

    Bypass the proxy implicitly for "loopback" (on Windows only).
    
    Bug: 904889
    Change-Id: I52e5b4cc2bff0cff0b1c7d6ec55d26b01924c288
    Reviewed-on: https://chromium-review.googlesource.com/c/1333906
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607855}

    Changed files

    • net/proxy_resolution/proxy_bypass_rules.cc
    • net/proxy_resolution/proxy_bypass_rules_unittest.cc
  21. cros: Readd fingerprint_progress_arc tests.

    Changed by Sammie Quon - sammiequonohnoyoudont@google.com
    Changed at Wednesday, 14-Nov-18 02:10:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 912b4b95d420f4c0b7793e4df2c89e99f310177d

    Comments

    cros: Readd fingerprint_progress_arc tests.
    
    They were deleted when fingerprint_progress_arc.js was moved from
    settings to cr_elements.
    
    Test: browser_tests CrElementsFingerprintProgressArcTest.*
    Bug: 894285
    Change-Id: I66419456bb00b30b348dcfad1c663237b41e2412
    Reviewed-on: https://chromium-review.googlesource.com/c/1332767
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607854}

    Changed files

    • chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
    • chrome/test/data/webui/cr_elements/cr_fingerprint_progress_arc_tests.js
    • testing/buildbot/filters/webui_polymer2_browser_tests.filter
  22. Navi: Pre-select first email provider to have a default.

    Changed by Hector Carmona - hcarmonaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:10:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b954e406f3886d861a064f9b78c5068e54d57d8

    Comments

    Navi: Pre-select first email provider to have a default.
    
    Bug: 901210, 900377
    Change-Id: I928f6cdb1a8251131afbe2e95afe1cbca39703ea
    Reviewed-on: https://chromium-review.googlesource.com/c/1332696
    Commit-Queue: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607853}

    Changed files

    • chrome/browser/resources/welcome/onboarding_welcome/email/email_chooser.js
    • chrome/browser/resources/welcome/onboarding_welcome/email/nux_email_proxy.js
    • chrome/test/data/webui/welcome/email_chooser_test.js
  23. Create chrome/android/...toolbar/top/ package and move relevant classes

    Changed by Theresa - twellingtonohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:09:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14e947faf5835845739b942dd68c4f5ab4d7a3f5

    Comments

    Create chrome/android/...toolbar/top/ package and move relevant classes
    
    Create a new package for top toolbar classes and move relevant classes.
    
    BUG=904998
    
    Change-Id: Ia9233913f04ec77f31c592f5a033ea18a5fccbf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1334416
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607852}

    Changed files

    • chrome/android/java/res/layout/control_container.xml
    • chrome/android/java/res/layout/custom_tabs_control_container.xml
    • chrome/android/java/res/layout/custom_tabs_toolbar.xml
    • chrome/android/java/res/layout/toolbar_phone.xml
    • chrome/android/java/res/layout/toolbar_tablet.xml
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarTablet.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/status/StatusViewCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivityLocationBarLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/KeyboardNavigationListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/TabCountProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ActionModeController.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbar.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/CustomTabToolbarAnimationDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/Toolbar.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarActionModeCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarControlContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTablet.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ViewShiftingActionBarDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityIncognitoTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/LocationBarModelTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/top/BrandColorTest.java
  24. Refactor Layout Test to use testharness.js

    Changed by Akihiro Ota - akihirootaohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:09:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94e56daf5e42ac077da521f14ebafd18eb3d41bf

    Comments

    Refactor Layout Test to use testharness.js
    
    Clean up aria-setsize-posinset.html Layout Test to use testharness
    and be more human-readable. Larger goal is to more thoroughly test
    the aria-posinset and aria-setSize attributes, especially in
    ambiguous cases.
    
    Change-Id: I950d45ceda2bbeb3fb10423812a13380b0da3ef4
    Reviewed-on: https://chromium-review.googlesource.com/c/1332412
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607851}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/aria-setsize-posinset-expected.txt
    • third_party/WebKit/LayoutTests/accessibility/aria-setsize-posinset.html
  25. Rename DeferCommits to DeferMainFrameUpdate

    Changed by Stephen Chenney - schenneyohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:08:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d3f5ce70242b52d5132cd4a45264ad3d4770540

    Comments

    Rename DeferCommits to DeferMainFrameUpdate
    
    This is in preparation for patches to avoid white flash on navigation,
    when we will be introducing a DeferCommits that only defers commits,
    not the document lifecycle. Renaming this DeferMainFrameUpdate makes
    it clearer that we are deferring everything in this case.
    
    This is a pure mechanical rename: DeferCommits -> DeferMainFrameUpdate and
    defer_commits -> defer_main_frame_update. No functionality changes.
    
    Added TODO in various places where we need to reintroduce the idea of
    a deferred commit without a deferred main frame update.
    
    See this design doc:
    https://docs.google.com/document/d/1Q-fq62PPeoz2EUygi1xzTdJwIgLwK6zP12_klO3wVXQ/edit#
    
    R=vmpstr@chromium.org, pdr@chromium.org
    BUG=805798
    
    Change-Id: I48c3b6c230f99e8a96c023a8c88f97de03f110af
    Reviewed-on: https://chromium-review.googlesource.com/c/1330799
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Reviewed-by: Khushal <khushalsagar@chromium.org>
    Commit-Queue: Stephen Chenney <schenney@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607850}

    Changed files

    • cc/scheduler/scheduler.cc
    • cc/scheduler/scheduler.h
    • cc/scheduler/scheduler_state_machine.cc
    • cc/scheduler/scheduler_state_machine.h
    • cc/scheduler/scheduler_state_machine_unittest.cc
    • cc/scheduler/scheduler_unittest.cc
    • cc/test/fake_proxy.h
    • cc/test/layer_tree_test.cc
    • cc/test/layer_tree_test.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host.h
    • cc/trees/layer_tree_host_unittest.cc
    • cc/trees/layer_tree_host_unittest_context.cc
    • cc/trees/proxy.h
    • cc/trees/proxy_impl.cc
    • cc/trees/proxy_impl.h
    • cc/trees/proxy_main.cc
    • cc/trees/proxy_main.h
    • cc/trees/single_thread_proxy.cc
    • cc/trees/single_thread_proxy.h
    • content/browser/renderer_host/compositor_impl_android.cc
    • content/renderer/gpu/layer_tree_view.cc
    • content/renderer/gpu/layer_tree_view.h
    • third_party/blink/public/platform/web_layer_tree_view.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/frame/document_loading_rendering_test.cc
    • third_party/blink/renderer/core/testing/sim/sim_compositor.cc
    • third_party/blink/renderer/core/testing/sim/sim_compositor.h
    • ui/compositor/compositor.h
    • ui/compositor/compositor_lock.cc
    • ui/compositor/compositor_lock.h
  26. entries-api: Make webkitRelativePath interoperable

    Changed by Kent Tamura - tkentohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:08:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d7a74576663b031696ca917057a67491d7b1230

    Comments

    entries-api: Make webkitRelativePath interoperable
    
    This CL makes webkitRelativePath IDL attribute behavior same as Edge,
    Firefox, and Safari.  It returns relative path from the parent of the
    selected directory.
    
    * chrome/browser/file_select_helper.cc
    * chrome/browser/file_select_helper.h
      Record a FilePath with which we started enumeration, and path it to
      FileSelectListener.
    
    * android_webview/browser/aw_web_contents_delegate.cc
    * chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    * content/browser/web_contents/web_contents_impl_browsertest.cc
    * content/renderer/pepper/pepper_file_chooser_host_unittest.cc
    * content/test/content_browser_test_utils_internal.cc
      Pass an empty FilePath to FileSelectListener.
    
    * content/browser/frame_host/render_frame_host_impl.cc
    * content/public/browser/file_select_listener.h
    * third_party/blink/public/mojom/choosers/file_chooser.mojom
    * third_party/blink/renderer/core/html/forms/file_chooser.h
    * third_party/blink/renderer/core/html/forms/file_chooser.cc
      Pass a FilePath to FileInputType through FileSelectListener and mojo.
    
    * third_party/blink/renderer/core/html/forms/file_input_type.cc
      Compute webkitRelativePath with the passed FilePath, instead of a
      common ancestor.
    
    * third_party/WebKit/LayoutTests/fast/forms/resources/mock-file-chooser.js
      Support FileChooserResult.base_directory
    
    
    Change-Id: I4c9f03b053b5a9230e954dcd216439d8c5c54d0b
    Bug: 124187
    Reviewed-on: https://chromium-review.googlesource.com/c/1325579
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607849}

    Changed files

    • android_webview/browser/aw_web_contents_delegate.cc
    • chrome/browser/file_select_helper.cc
    • chrome/browser/file_select_helper.h
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/web_contents/web_contents_impl_browsertest.cc
    • content/public/browser/file_select_listener.h
    • content/renderer/pepper/pepper_file_chooser_host_unittest.cc
    • content/test/content_browser_test_utils_internal.cc
    • third_party/WebKit/LayoutTests/fast/forms/file/file-input-webkitdirectory-click-expected.txt
    • third_party/WebKit/LayoutTests/fast/forms/file/file-input-webkitdirectory-key-enter-expected.txt
    • third_party/WebKit/LayoutTests/fast/forms/file/file-input-webkitdirectory-key-enter-prevent-keypress-expected.txt
    • third_party/WebKit/LayoutTests/fast/forms/file/file-input-webkitdirectory-key-space-expected.txt
    • third_party/WebKit/LayoutTests/fast/forms/file/file-webkitRelativePath.html
    • third_party/WebKit/LayoutTests/fast/forms/resources/mock-file-chooser.js
    • third_party/blink/public/mojom/choosers/file_chooser.mojom
    • third_party/blink/renderer/core/html/forms/file_chooser.cc
    • third_party/blink/renderer/core/html/forms/file_chooser.h
    • third_party/blink/renderer/core/html/forms/file_input_type.cc
    • third_party/blink/renderer/core/html/forms/file_input_type.h
    • third_party/blink/renderer/core/html/forms/file_input_type_test.cc
    • third_party/blink/renderer/core/html/forms/html_input_element_test.cc
    • third_party/blink/renderer/core/html/forms/mock_file_chooser.h
    • third_party/blink/renderer/core/page/chrome_client_impl_test.cc
  27. Hide mobile data toggle when SIM is absent

    Changed by Toni Barzic - tbarzicohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:06:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 853620cce2b7d138699cc8ce8e667c99ab3f6ca3

    Comments

    Hide mobile data toggle when SIM is absent
    
    BUG=888738
    
    Change-Id: I4567bf4218621fa607bd86a43420bba8d4e4bcaa
    Reviewed-on: https://chromium-review.googlesource.com/c/1328045
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607848}

    Changed files

    • ash/system/network/network_list.cc
  28. [CORS] Be strict on request's Content-Type

    Changed by Yutaka Hirano - yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f0e8b3b1358acc67de6d1701feb01535b8c59b9

    Comments

    [CORS] Be strict on request's Content-Type
    
    Following the corresponding spec change:
    https://github.com/whatwg/fetch/pull/829
    
    Bug: 902681
    Change-Id: If0da598ada489417c34926935acdd3cfff519aa7
    Reviewed-on: https://chromium-review.googlesource.com/c/1329815
    Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607847}

    Changed files

    • services/network/public/cpp/cors/cors.cc
    • services/network/public/cpp/cors/cors_unittest.cc
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/cors/cors-safelisted-request-header.any.worker-expected.txt
  29. Respect pref_locale in GetApplicationLocale on Android.

    Changed by Thoren Paulson - thorenohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24f56e3a9c0304f4e56e7f54c5d6352ea499840b

    Comments

    Respect pref_locale in GetApplicationLocale on Android.
    
    Before, the system default would always be picked regardless of the
    value passed in on Android.
    
    Bug: internal b/117627257
    Test: repro
    Change-Id: I5004e11fbc94d3c82ac9c61557735665ced79539
    Reviewed-on: https://chromium-review.googlesource.com/c/1332719
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Thoren Paulson <thoren@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607846}

    Changed files

    • ui/base/l10n/l10n_util.cc
  30. [On-device adaptive brightness] Log data errors.

    Changed by Jia - jiamengohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:05:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca8751008f55a55f8aeacf9e425dc2390aaa42ac

    Comments

    [On-device adaptive brightness] Log data errors.
    
    This cl logs the following errors that could possibly occur
    * Negative ALS values
    * Brightness percent that's outide the expected range [0,100].
    
    Bug: 881215
    Change-Id: I381c887cd95a9d4be99a02f2a34711655f847394
    Reviewed-on: https://chromium-review.googlesource.com/c/1333169
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607845}

    Changed files

    • chrome/browser/chromeos/power/auto_screen_brightness/als_reader_impl.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/brightness_monitor_impl.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/utils.cc
    • chrome/browser/chromeos/power/auto_screen_brightness/utils.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  31. Fix some incorrect ifdef guards.

    Changed by Eric Roman - eromanohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:04:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d44cc641dc51276c93c2ca686dbf858b26892407

    Comments

    Fix some incorrect ifdef guards.
    
    Change-Id: If3b95de0bdf66c10a435be0b76d4162cd40adbee
    Reviewed-on: https://chromium-review.googlesource.com/c/1334647
    Reviewed-by: Matt Mueller <mattm@chromium.org>
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607844}

    Changed files

    • net/proxy_resolution/dhcp_pac_file_adapter_fetcher_win.h
    • net/proxy_resolution/dhcp_pac_file_fetcher.h
    • net/proxy_resolution/dhcp_pac_file_fetcher_factory.h
    • net/proxy_resolution/dhcp_pac_file_fetcher_win.h
    • net/proxy_resolution/mock_pac_file_fetcher.h
    • net/proxy_resolution/pac_file_data.h
    • net/proxy_resolution/pac_file_decider.h
    • net/proxy_resolution/pac_file_fetcher.h
    • net/proxy_resolution/pac_file_fetcher_impl.h
  32. Roll src/third_party/webrtc 428a160dd6bd..6dbf0e43a5ff (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 14-Nov-18 02:04:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51abfce67acaf737946a8041471dcc9a690fed45

    Comments

    Roll src/third_party/webrtc 428a160dd6bd..6dbf0e43a5ff (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/428a160dd6bd..6dbf0e43a5ff
    
    
    git log 428a160dd6bd..6dbf0e43a5ff --date=short --no-merges --format='%ad %ae %s'
    2018-11-13 danilchap@webrtc.org Remove all aliases to rtc::Thread
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@6dbf0e43a5ff
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ic198e0804f6f8a14f0e584ef0d5c2907a75abfca
    Reviewed-on: https://chromium-review.googlesource.com/c/1334568
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#607843}

    Changed files

    • DEPS
  33. Files app: Fix test stepper with async load of test functions

    Changed by Luciano Pacheco - lucmultohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:03:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f770283367ccbd002dafe0079f571a4fa7151a3

    Comments

    Files app: Fix test stepper with async load of test functions
    
    After crrev.com/c/1322340 which changed test functions to be lazy
    loaded (asynchronously), running tests in step-by-step mode wasn't
    working if tried to step after Files app background page was put to
    sleep for inactivity.
    
    There were 2 issues:
    
    1. The logic was relying on a global state window.IN_TEST which gets
    lost when extension goes to sleep.
    
    2 Any queued response was replied with sendResponse(true), which was
    skipping the execution of the test function that it requested to run.
    
    This CL fixes both of these issues by doing:
    
    1. Instead of relying on window.IN_TEST, it checks if test functions
    are loaded with: "test.util.executeTestMessage !== null", if so runs
    the requested function, otherwise en-queues the request and async-loads
    the test functions.
    
    2. Change to en-queue both the request and the sendResponse to be able
    to run the requested functions once the test functions are fully
    loaded.
    
    This new design, made |enableTesting| and |ensureLoaded_| routines not
    necessary anymore and they were removed.
    
    Test: Manually run tests with the flags: --ui-test-action-timeout=100000
    --enable-file-manager-step-by-step-tests  --remote-debugging-port=9222
    and waited all extensions to disappear before issuing a step. Also
    triggered MSAN and ASAN bots in addition to normal bots.
    
    Bug: 903669
    Change-Id: Ia66f7ce7cd920a7a815340119591ff5ff957603c
    Reviewed-on: https://chromium-review.googlesource.com/c/1333177
    Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607842}

    Changed files

    • ui/file_manager/file_manager/background/js/test_util_base.js
    • ui/file_manager/integration_tests/remote_call.js
  34. Remove obsolete AppRegistry.GetApps method

    Changed by Nigel Tao - nigeltaoohnoyoudont@chromium.org
    Changed at Wednesday, 14-Nov-18 02:03:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7774f1d9bdc685e3102afdc6101b86d925f0b629

    Comments

    Remove obsolete AppRegistry.GetApps method
    
    Bug: 826982
    Change-Id: I19e9c4af2f3e53952d8ff8d697a43509d23eb809
    Reviewed-on: https://chromium-review.googlesource.com/c/1334668
    Commit-Queue: Nigel Tao <nigeltao@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607841}

    Changed files

    • chrome/services/app_service/app_registry/app_registry.cc
    • chrome/services/app_service/app_registry/app_registry.h
    • chrome/services/app_service/app_registry/app_registry_unittest.cc
    • chrome/services/app_service/public/mojom/app_registry.mojom