Home | Search | chromium - Builders
Login

Builder Android FYI Release (Nexus 9) Build 10066 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisione02c93aa236dd55c50eafd019f865e192192ac34
Got Revisione02c93aa236dd55c50eafd019f865e192192ac34

Execution:

Steps and Logfiles:

Show:
  1. ( 318 ms ) setup_build
    running recipe: "chromium"
  2. ( 340 ms ) report builders
     
    running builder/tester 'Android FYI Release (Nexus 9)' on master 'chromium.gpu.fyi'
  3. ( 52 secs ) bot_update
    [103GB/295GB used (34%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 12 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  7. ( 4 secs ) clean local files
  8. ( 301 ms ) tree truth steps
  9. ( 721 ms ) lookup GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    strip_debug_info = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 36 secs ) generate_build_files
  11. ( 17 mins 7 secs ) compile
  12. ( 11 secs ) isolate tests
  13. ( 668 ms ) find isolated tests
  14. ( 1 secs ) wait for tasks
  15. ( 1 secs ) gl_unittests on Android device Nexus 9
    Run on OS: 'Android'
    Shard duration: 42s
  16. ( 3 secs ) angle_unittests on Android device Nexus 9
    Run on OS: 'Android'
    Shard duration: 0:03:11.463338
  17. ( 1 secs ) angle_perftests on Android device Nexus 9
    Run on OS: 'Android'
    Shard duration: 0:01:01.265294
    Total tests: n/a
     
  18. ( 2 mins 9 secs ) wait for tasks (2)
  19. ( 1 secs ) gl_tests on Android device Nexus 9
    Run on OS: 'Android'
    Shard duration: 0:02:16.123207
  20. ( 1 secs ) depth_capture_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 36s
    Shard duration: 0:01:21.544979
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 2 mins 1 secs ) wait for tasks (3)
  22. ( 1 secs ) context_lost_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 33s
    Shard duration: 0:03:48.975254
    Total tests: 10
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 3 secs ) gpu_unittests on Android device Nexus 9
    Run on OS: 'Android'
    Shard duration: 0:02:50.239092
  24. ( 993 ms ) wait for tasks (4)
  25. ( 1 secs ) hardware_accelerated_feature_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:03:31.101157
    Shard duration: 0:01:14.741335
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 2 mins 1 secs ) wait for tasks (5)
  27. ( 1 secs ) gpu_process_launch_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:02:34.105785
    Shard duration: 0:03:37.987481
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 1 secs ) maps_pixel_test on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:05:03.004698
    Shard duration: 0:01:42.490080
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 secs ) info_collection_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:04:22.478810
    Shard duration: 0:01:26.469831
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 4 mins 1 secs ) wait for tasks (6)
  31. ( 1 secs ) screenshot_sync_tests on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:07:00.864642
    Shard duration: 0:02:46.754879
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 4 mins 1 secs ) wait for tasks (7)
  33. ( 1 secs ) trace_test on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:09:24.606343
    Shard duration: 0:04:52.810954
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 2 mins 1 secs ) wait for tasks (8)
  35. ( 1 secs ) pixel_test on Android device Nexus 9
    Run on OS: 'Android'
    Pending time: 0:06:26.357713
    Shard duration: 0:09:34.694430
    Total tests: 48
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 13 (13 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 4 mins 50 secs ) webgl_conformance_tests on Android device Nexus 9
    Run on OS: 'Android'
    Max pending time: 0:16:18.955641 (shard #5)
    Max shard duration: 0:06:08.422533 (shard #2)
    Min shard duration: 0:04:36.927627 (shard #4)
    Total tests: 932
    * Passed: 926 (926 expected, 0 unexpected)
    * Skipped: 6 (6 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 348 ms ) Tests statistics
     
    Stats
    Total shards: 20
    Total runtime: 1:06:35.091143
     
  38. ( 419 ms ) test_report
  39. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm570-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541783591770813, "id": "8930316444434706688", "project": "chromium", "tags": ["builder:Android FYI Release (Nexus 9)", "buildset:commit/git/e02c93aa236dd55c50eafd019f865e192192ac34", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/e02c93aa236dd55c50eafd019f865e192192ac34", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095746506669879520", "scheduler_job_id:chromium/Android FYI Release (Nexus 9)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android FYI Release (Nexus 9)" setup_build
buildnumber 10066 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "e02c93aa236dd55c50eafd019f865e192192ac34" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "e02c93aa236dd55c50eafd019f865e192192ac34" bot_update
got_revision_cp "refs/heads/master@{#606875}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes_refs/heads/master(at){#606875}_without_patch {"angle_perftests": "2b255855e40a63e48a0c8a3c90b3b454bf863766", "angle_unittests": "67e15d0dcaa7cc95f9115641974ded3fc5e96dbd", "gl_tests": "d7be08d6a390c9fc90e80cf849a23da04aaf3670", "gl_unittests": "58ad04138a3456dae565e12127488a9a6bb44b10", "gpu_unittests": "3efbdec8d22114ce01ba00ad145d82e0ccb1e64b", "telemetry_gpu_integration_test": "679081851fb7f397b32b84d4e57f9001ea02f6eb"} isolate tests
swarm_hashes {"angle_perftests": "2b255855e40a63e48a0c8a3c90b3b454bf863766", "angle_unittests": "67e15d0dcaa7cc95f9115641974ded3fc5e96dbd", "gl_tests": "d7be08d6a390c9fc90e80cf849a23da04aaf3670", "gl_unittests": "58ad04138a3456dae565e12127488a9a6bb44b10", "gpu_unittests": "3efbdec8d22114ce01ba00ad145d82e0ccb1e64b", "telemetry_gpu_integration_test": "679081851fb7f397b32b84d4e57f9001ea02f6eb"} find isolated tests

Blamelist:

  1. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  2. Philip Rogers (pdrohnoyoudont@chromium.org)
  3. Sky Malice (skymohnoyoudont@google.com)
  4. Scott Graham (scottmgohnoyoudont@chromium.org)
  5. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  6. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  7. David Jean (djeanohnoyoudont@google.com)
  8. Lei Zhang (thestigohnoyoudont@chromium.org)
  9. Yi Su (mrsuyiohnoyoudont@chromium.org)
  10. David 'Digit' Turner (digitohnoyoudont@google.com)
  11. James Hawkins (jhawkinsohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:13:11 UTC
Start Friday, 09-Nov-18 17:13:14 UTC
End Friday, 09-Nov-18 17:56:04 UTC
Pending 2 secs
Execution 42 mins 50 secs

All Changes:

  1. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  2. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of painting a transient
    paint controller is created and each GraphicsLayer's cc::Layer is
    inserted as a foreign layer into the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  3. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  4. fuchsia: Update sdk build job link in docs

    Changed by Scott Graham - scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  5. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  6. [Autofill Assistant] Integrate Payment Request.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56a06fd5e79c627d247ce9976c217ea14a17c9c5

    Comments

    [Autofill Assistant] Integrate Payment Request.
    
    This patch is the first step to integrate the payment request UI into
    the autofill assistant sheet.
    
    The patch has and leaves a few rough edges but we'll deal with that
    piece by piece. In particular, the dismiss logic needs to be handled
    differently, so does the error view logic.
    
    Note: The DimmingDialog is reverted to package default visibility since
    the dependency from autofill assistant is removed here.
    
    Bug: 806868
    Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1324451
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606870}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java
  7. [ios] plug in manual fallback for credit card and address

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec464d0a7b2ab771c1c7642a3568de17f4904b29

    Comments

    [ios] plug in manual fallback for credit card and address
    
    Bug: 845472
    Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c
    Reviewed-on: https://chromium-review.googlesource.com/c/1319594
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606869}

    Changed files

    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm
  8. Fix a typo in bisect-builds.py.

    Changed by Lei Zhang - thestigohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:46:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c8c6f7ecd6a1927225c2257544c6d370441854f

    Comments

    Fix a typo in bisect-builds.py.
    
    Windows archives extract out into a directory called chrome-win. There
    is no chrome-winp directory.
    
    TBR=robertocn@chromium.org
    
    Change-Id: Ia5ee2725e107f32c44105ca396e28a4c0a06844c
    Reviewed-on: https://chromium-review.googlesource.com/c/1313731
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606868}

    Changed files

    • tools/bisect-builds.py
  9. Remove JavaScript const/let/lambda presubmit check for iOS9.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:44:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a81bed5026f4a47ed9a0b690b0a950260f6e3e06

    Comments

    Remove JavaScript const/let/lambda presubmit check for iOS9.
    
    iOS9 is not supported by Chrome iOS and iGSA anymore, the presubmit check
    for risky ES6 grammar(const/let/lambda) can be removed now.
    
    Change-Id: I5a35d54097dbd215393aaba78868107befdc93b6
    Reviewed-on: https://chromium-review.googlesource.com/c/1329249
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606867}

    Changed files

    • PRESUBMIT.py
    • PRESUBMIT_test.py
  10. Android: Fix resource extraction from splits for Hebrew and others.

    Changed by David 'Digit' Turner - digitohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:32:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77b7b35987d9420138ebc3fcb7d24d786bf5549c

    Comments

    Android: Fix resource extraction from splits for Hebrew and others.
    
    This CL fixes a bug in the logic used to locate locale .pak files
    inside bundle splits. The reason for the bug is that bundletool
    wants to use deprecated language names (i.e. 'iw' instead of 'he')
    to store asset files.
    
    As an example, for Hebrew, Chrome was looking at:
    
      assets/locales#lang_he/he.pak
    
    While the file was really stored under:
    
      assets/locales#lang_iw/he.pak
    
    The CL fixes the issue for Hebrew, Yiddish and Indonesian and
    Filipino.
    
    BUG=902915
    R=benmason@chromium.org, tiborg@chromium.org, yfriedman@chromium.org, twellington@chromium.org
    
    Change-Id: I420158c30ba33c6203495af9453877722271e104
    Reviewed-on: https://chromium-review.googlesource.com/c/1327203
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606866}

    Changed files

    • ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java
    • ui/android/java/src/org/chromium/ui/resources/ResourceExtractor.java
    • ui/android/junit/src/org/chromium/ui/base/LocalizationUtilsTest.java
  11. Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.

    Changed by James Hawkins - jhawkinsohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7bfd5bb2031d217d0e0f87240b4ce16705abb3d

    Comments

    Proximity Auth: Remove kMultiDeviceApi flagging from ProxAuthWebuiHandler.
    
    R=hansberry@chromium.org
    
    Bug: 899324
    Test: none
    Change-Id: Iac6aacb1b40608d261d6c13b12fd37bfd6b0df8f
    Reviewed-on: https://chromium-review.googlesource.com/c/1325393
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606865}

    Changed files

    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_ui.h
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.h