Home | Search | chromium - Builders
Login

Builder Android FYI Release (Nexus 6P) Build 9699 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision92aa96594173109bc330bb2eab84d8e61bd7ee5e
Got Revision92aa96594173109bc330bb2eab84d8e61bd7ee5e

Execution:

Steps and Logfiles:

Show:
  1. ( 322 ms ) setup_build
    running recipe: "chromium"
  2. ( 343 ms ) report builders
     
    running builder/tester 'Android FYI Release (Nexus 6P)' on master 'chromium.gpu.fyi'
  3. ( 54 secs ) bot_update
    [103GB/295GB used (34%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 13 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  7. ( 5 secs ) clean local files
  8. ( 386 ms ) tree truth steps
  9. ( 796 ms ) lookup GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    strip_debug_info = true
    symbol_level = 1
    target_cpu = "arm64"
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 38 secs ) generate_build_files
  11. ( 10 mins 14 secs ) compile
  12. ( 12 secs ) isolate tests
  13. ( 693 ms ) find isolated tests
  14. ( 1 secs ) wait for tasks
  15. ( 1 secs ) gl_unittests on Android device Nexus 6P
    Run on OS: 'Android'
    Shard duration: 40s
  16. ( 1 secs ) angle_perftests on Android device Nexus 6P
    Run on OS: 'Android'
    Shard duration: 0:01:14.957725
    Total tests: n/a
     
  17. ( 2 secs ) angle_end2end_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Max shard duration: 0:01:50.270239 (shard #0)
    Min shard duration: 0:01:11.663647 (shard #2)
  18. ( 3 secs ) angle_unittests on Android device Nexus 6P
    Run on OS: 'Android'
    Shard duration: 0:04:04.879287
  19. ( 3 secs ) gpu_unittests on Android device Nexus 6P
    Run on OS: 'Android'
    Shard duration: 0:03:27.836147
  20. ( 32 secs ) wait for tasks (2)
  21. ( 1 secs ) gl_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 17s
    Shard duration: 0:01:05.995986
  22. ( 3 mins 39 secs ) wait for tasks (3)
  23. ( 2 secs ) hardware_accelerated_feature_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:01:43.396507
    Shard duration: 0:01:59.062837
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 secs ) depth_capture_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 0:03:04.920232
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 2 mins 1 secs ) wait for tasks (4)
  26. ( 1 secs ) info_collection_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:03:42.649878
    Shard duration: 0:01:34.376146
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 1 secs ) maps_pixel_test on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:03:54.289333
    Shard duration: 0:02:23.221723
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 1 secs ) gpu_process_launch_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 19s
    Shard duration: 0:05:04.456310
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 secs ) context_lost_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 0:05:41.537515
    Total tests: 10
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 2 mins 1 secs ) wait for tasks (5)
  31. ( 1 secs ) screenshot_sync_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:04:06.528034
    Shard duration: 0:04:25.541477
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  32. ( 2 mins 1 secs ) wait for tasks (6)
  33. ( 2 secs ) trace_test on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:05:41.053006
    Shard duration: 0:04:38.895352
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 4 mins 1 secs ) wait for tasks (7)
  35. ( 1 secs ) pixel_test on Android device Nexus 6P
    Run on OS: 'Android'
    Pending time: 0:03:59.842189
    Shard duration: 0:10:42.644958
    Total tests: 48
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 13 (13 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  36. ( 5 mins 40 secs ) webgl_conformance_tests on Android device Nexus 6P
    Run on OS: 'Android'
    Max pending time: 0:14:05.811490 (shard #5)
    Max shard duration: 0:11:07.612334 (shard #2)
    Min shard duration: 0:04:36.116500 (shard #4)
    Total tests: 932
    * Passed: 925 (925 expected, 0 unexpected)
    * Skipped: 7 (7 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  37. ( 348 ms ) Tests statistics
     
    Stats
    Total shards: 24
    Total runtime: 1:31:45.178469
     
  38. ( 441 ms ) test_report
  39. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm569-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541784037524276, "id": "8930315977027768640", "project": "chromium", "tags": ["builder:Android FYI Release (Nexus 6P)", "buildset:commit/git/92aa96594173109bc330bb2eab84d8e61bd7ee5e", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/92aa96594173109bc330bb2eab84d8e61bd7ee5e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095746039143210064", "scheduler_job_id:chromium/Android FYI Release (Nexus 6P)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android FYI Release (Nexus 6P)" setup_build
buildnumber 9699 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "92aa96594173109bc330bb2eab84d8e61bd7ee5e" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "92aa96594173109bc330bb2eab84d8e61bd7ee5e" bot_update
got_revision_cp "refs/heads/master@{#606878}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "31b2546b348e864539ade15897eac971b3c0e402" bot_update
got_v8_revision_cp "refs/heads/7.2.286@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes_refs/heads/master(at){#606878}_without_patch {"angle_end2end_tests": "ff63430524e4dbabc1cb4b8eb3b4ce4b20864e54", "angle_perftests": "2b255855e40a63e48a0c8a3c90b3b454bf863766", "angle_unittests": "67e15d0dcaa7cc95f9115641974ded3fc5e96dbd", "gl_tests": "a7b53205c60aa11b8999243c5202fb73dd0cdd7f", "gl_unittests": "58ad04138a3456dae565e12127488a9a6bb44b10", "gpu_unittests": "3efbdec8d22114ce01ba00ad145d82e0ccb1e64b", "telemetry_gpu_integration_test": "c93ef2b2448c08869755296528c2cde936d29d19"} isolate tests
swarm_hashes {"angle_end2end_tests": "ff63430524e4dbabc1cb4b8eb3b4ce4b20864e54", "angle_perftests": "2b255855e40a63e48a0c8a3c90b3b454bf863766", "angle_unittests": "67e15d0dcaa7cc95f9115641974ded3fc5e96dbd", "gl_tests": "a7b53205c60aa11b8999243c5202fb73dd0cdd7f", "gl_unittests": "58ad04138a3456dae565e12127488a9a6bb44b10", "gpu_unittests": "3efbdec8d22114ce01ba00ad145d82e0ccb1e64b", "telemetry_gpu_integration_test": "c93ef2b2448c08869755296528c2cde936d29d19"} find isolated tests

Blamelist:

  1. Denis Bessonov (dbessonovohnoyoudont@yandex-team.ru)
  2. Steve Kobes (skobesohnoyoudont@chromium.org)
  3. Lily Chen (chlilyohnoyoudont@chromium.org)
  4. Tatiana Buldina (buldinaohnoyoudont@chromium.org)
  5. Philip Rogers (pdrohnoyoudont@chromium.org)
  6. Sky Malice (skymohnoyoudont@google.com)
  7. Scott Graham (scottmgohnoyoudont@chromium.org)
  8. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  9. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  10. David Jean (djeanohnoyoudont@google.com)

Timing:

Create Friday, 09-Nov-18 17:20:37 UTC
Start Friday, 09-Nov-18 17:20:38 UTC
End Friday, 09-Nov-18 17:55:37 UTC
Pending 1 secs
Execution 34 mins 59 secs

All Changes:

  1. Out-of-line default constructor of WebRange.

    Changed by Denis Bessonov - dbessonovohnoyoudont@yandex-team.ru
    Changed at Friday, 09-Nov-18 17:19:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 92aa96594173109bc330bb2eab84d8e61bd7ee5e

    Comments

    Out-of-line default constructor of WebRange.
    
    WebRange default constructor is both inline and BLINK_EXPORT.
    Using WebRange() in different blink modules (for example,
    blink_core and blink_controller) results in duplicate symbols
    during linking.
    
    This CL out-of-lines this constructor to ensure that exported
    constructor has only one implementation.
    
    Bug: 903712
    Change-Id: Ifdc947c4d0001a4be7404950a6a1639bc9877372
    Reviewed-on: https://chromium-review.googlesource.com/c/1328964
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606878}

    Changed files

    • third_party/blink/public/web/web_range.h
    • third_party/blink/renderer/core/exported/web_range.cc
  2. Add and report LayoutStability.JankScore UKM.

    Changed by Steve Kobes - skobesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:14:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 162f0b1678e9c6b559ee7931f910cff372d9e5e2

    Comments

    Add and report LayoutStability.JankScore UKM.
    
    We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank
    score reporting at session end for tabs that start or become hidden,
    but avoid extra reporting of other metrics by checking was_hidden_.
    
    The OnFinalLayoutStabilityUpdate hook is removed in favor of passing
    PageRenderData to existing hooks through PageLoadExtraInfo.  This lets
    the observer decide when to report.
    
    UKM collection review doc: go/lsukmrev
    
    Bug: 581518
    Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1299917
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606877}

    Changed files

    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • tools/metrics/ukm/ukm.xml
  3. Add reprioritization to SSLConnectJobs

    Changed by Lily Chen - chlilyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a9302e29c7625fd7cdc65f374fc7f00550c21aa

    Comments

    Add reprioritization to SSLConnectJobs
    
    This change allows the priority of an SSLConnectJob to be changed. If
    the reprioritization occurs while the job is establishing its underlying
    connection, the priority change is also passed down to the lower-level
    socket pool.
    
    Bug: 166689
    Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327423
    Commit-Queue: Lily Chen <chlily@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606876}

    Changed files

    • net/socket/socket_test_util.cc
    • net/socket/socket_test_util.h
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/ssl_client_socket_pool.h
    • net/socket/ssl_client_socket_pool_unittest.cc
  4. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py
  5. [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed

    Changed by Philip Rogers - pdrohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f5a1bd0249536b05ba2d3b45f175e742d1a6a47

    Comments

    [BlinkGenPropertyTrees] Stop incorrect clearing of property tree changed
    
    PaintPropertyTreeNode::Changed is used for in-layer raster invalidation,
    and cc damage for both SPV2 and BGPT. https://crrev.com/606472 failed
    to account for the case when non-transient paint controllers in
    GraphicsLayers would clear property tree changed values before the
    values could be used for damage.
    
    As a reminder, with BlinkGenPropertyTrees, each GraphicsLayer keeps a
    non-transient paint controller, and at the end of painting a transient
    paint controller is created and each GraphicsLayer's cc::Layer is
    inserted as a foreign layer into the transient paint controller.
    
    This patch changes BGPT to clear all property tree changed bits after
    damage has been calculated in PaintArtifactCompositor. It is implemented
    with a recursive walk of the GraphicsLayer tree.
    
    Bug: 899628
    Change-Id: Ibc7d65d6ab8875508b9c3dd18ab6db1230bf1308
    Reviewed-on: https://chromium-review.googlesource.com/c/1327804
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606874}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
    • third_party/blink/renderer/core/exported/web_layer_test.cc
    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_artifact.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.cc
    • third_party/blink/renderer/platform/graphics/paint/paint_controller.h
    • third_party/blink/renderer/platform/graphics/paint/paint_property_node.h
  6. [Feed] When rescheduling, just set period to 1 day instead of going to

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:02:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1dc99fe0bd2792457e4cc526e945df228ec47234

    Comments

    [Feed] When rescheduling, just set period to 1 day instead of going to
    native.
    
    Bug: 901331
    Change-Id: I65b3d748cb96669fa78a712552f82a44873debf3
    Reviewed-on: https://chromium-review.googlesource.com/c/1315929
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606873}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedScheduler.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedSchedulerBridge.java
  7. fuchsia: Update sdk build job link in docs

    Changed by Scott Graham - scottmgohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e05b6f1c53bf3cfa376b672b70ed83643274b56

    Comments

    fuchsia: Update sdk build job link in docs
    
    Change-Id: I203f142ee84ecefeb36adaf9da175404f75194eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1329506
    Commit-Queue: Scott Graham <scottmg@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606872}

    Changed files

    • docs/fuchsia_sdk_updates.md
  8. Retire PerformanceNavigationTiming2 runtime enabled flag.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:56:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48519d5c39fc3533942f8107cce3df766e1d45b2

    Comments

    Retire PerformanceNavigationTiming2 runtime enabled flag.
    
    Feature first shipped in M57.
    
    BUG=611276
    
    Change-Id: Ib4b514df4f72b29333b534e6978ea8fa3dea5128
    Reviewed-on: https://chromium-review.googlesource.com/c/1323628
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606871}

    Changed files

    • third_party/blink/renderer/core/timing/performance_navigation_timing.idl
    • third_party/blink/renderer/core/timing/window_performance.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  9. [Autofill Assistant] Integrate Payment Request.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 16:54:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56a06fd5e79c627d247ce9976c217ea14a17c9c5

    Comments

    [Autofill Assistant] Integrate Payment Request.
    
    This patch is the first step to integrate the payment request UI into
    the autofill assistant sheet.
    
    The patch has and leaves a few rough edges but we'll deal with that
    piece by piece. In particular, the dismiss logic needs to be handled
    differently, so does the error view logic.
    
    Note: The DimmingDialog is reverted to package default visibility since
    the dependency from autofill assistant is removed here.
    
    Bug: 806868
    Change-Id: I25b83b804e13bbdec5d2a1688dd01cd085615b38
    Reviewed-on: https://chromium-review.googlesource.com/c/1324451
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606870}

    Changed files

    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request.xml
    • chrome/android/java/res_autofill_assistant/layout/autofill_assistant_payment_request_bottom_bar.xml
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/BottomBarAnimations.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ui/DimmingDialog.java
  10. [ios] plug in manual fallback for credit card and address

    Changed by David Jean - djeanohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 16:50:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec464d0a7b2ab771c1c7642a3568de17f4904b29

    Comments

    [ios] plug in manual fallback for credit card and address
    
    Bug: 845472
    Change-Id: Ie26e9022b60612b5ef90c7e9b2bde4202e6e745c
    Reviewed-on: https://chromium-review.googlesource.com/c/1319594
    Commit-Queue: David Jean <djean@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606869}

    Changed files

    • ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/fallback_coordinator.mm
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.h
    • ios/chrome/browser/ui/autofill/manual_fill/manual_fill_accessory_view_controller.mm