Home | Search | chromium - Builders
Login

Builder Android FYI Release (Nexus 6) Build 13566 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision60b47f98f87e0f3689826e4342fab09b7a35ed5e
Got Revision60b47f98f87e0f3689826e4342fab09b7a35ed5e

Execution:

Steps and Logfiles:

Show:
  1. ( 302 ms ) setup_build
    running recipe: "chromium"
  2. ( 335 ms ) report builders
     
    running builder/tester 'Android FYI Release (Nexus 6)' on master 'chromium.gpu.fyi'
  3. ( 58 secs ) bot_update
    [92GB/295GB used (31%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 12 secs ) gclient runhooks
  6. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  7. ( 4 secs ) clean local files
  8. ( 577 ms ) tree truth steps
  9. ( 704 ms ) lookup GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    strip_debug_info = true
    symbol_level = 1
    target_os = "android"
    use_goma = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 11 secs ) generate_build_files
  11. ( 8 mins 23 secs ) compile
  12. ( 6 secs ) isolate tests
  13. ( 679 ms ) find isolated tests
  14. ( 944 ms ) wait for tasks
  15. ( 3 secs ) angle_unittests on Android device Nexus 6
    Run on OS: 'Android'
    Shard duration: 0:02:21.515443
  16. ( 1 secs ) gl_tests on Android device Nexus 6
    Run on OS: 'Android'
    Shard duration: 55s
  17. ( 1 secs ) gl_unittests on Android device Nexus 6
    Run on OS: 'Android'
    Shard duration: 27s
  18. ( 1 mins 4 secs ) wait for tasks (2)
  19. ( 1 secs ) depth_capture_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 12s
    Shard duration: 0:01:12.666518
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  20. ( 1 secs ) hardware_accelerated_feature_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 21s
    Shard duration: 0:01:09.582002
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  21. ( 1 mins 5 secs ) wait for tasks (3)
  22. ( 1 secs ) maps_pixel_test on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 54s
    Shard duration: 0:01:42.380613
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 3 secs ) gpu_unittests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 13s
    Shard duration: 0:02:32.734727
  24. ( 1 secs ) info_collection_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 43s
    Shard duration: 0:01:07.162321
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 2 mins 1 secs ) wait for tasks (4)
  26. ( 1 secs ) gpu_process_launch_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 15s
    Shard duration: 0:03:10.517364
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 2 mins 1 secs ) wait for tasks (5)
  28. ( 1 secs ) context_lost_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 14s
    Shard duration: 0:06:22.969521
    Total tests: 10
    * Passed: 7 (7 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 secs ) screenshot_sync_tests on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 0:01:38.742110
    Shard duration: 0:03:25.745898
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 1 secs ) trace_test on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 0:01:57.899902
    Shard duration: 0:04:21.387580
    Total tests: 36
    * Passed: 18 (18 expected, 0 unexpected)
    * Skipped: 18 (18 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 4 mins 1 secs ) wait for tasks (6)
  32. ( 2 secs ) pixel_test on Android device Nexus 6
    Run on OS: 'Android'
    Pending time: 0:01:31.343697
    Shard duration: 0:09:29.629452
    Total tests: 48
    * Passed: 35 (35 expected, 0 unexpected)
    * Skipped: 13 (13 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  33. ( 2 mins 44 secs ) webgl_conformance_tests on Android device Nexus 6
    Run on OS: 'Android'
    Max pending time: 0:06:35.116772 (shard #5)
    Max shard duration: 0:07:17.275939 (shard #2)
    Min shard duration: 0:05:08.147915 (shard #4)
    Total tests: 932
    * Passed: 924 (924 expected, 0 unexpected)
    * Skipped: 8 (8 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  34. ( 346 ms ) Tests statistics
     
    Stats
    Total shards: 19
    Total runtime: 1:13:33.321422
     
  35. ( 414 ms ) test_report

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm568-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541784883823749, "id": "8930315089618176256", "project": "chromium", "tags": ["builder:Android FYI Release (Nexus 6)", "buildset:commit/git/60b47f98f87e0f3689826e4342fab09b7a35ed5e", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/60b47f98f87e0f3689826e4342fab09b7a35ed5e", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095745151645101328", "scheduler_job_id:chromium/Android FYI Release (Nexus 6)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android FYI Release (Nexus 6)" setup_build
buildnumber 13566 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "60b47f98f87e0f3689826e4342fab09b7a35ed5e" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "60b47f98f87e0f3689826e4342fab09b7a35ed5e" bot_update
got_revision_cp "refs/heads/master@{#606886}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update
swarm_hashes_refs/heads/master(at){#606886}_without_patch {"angle_unittests": "2ca53a29042c2456c43fa547fe67531c4fc7de17", "gl_tests": "5acac6da396c606bb462e57ae43cd0620dc8228e", "gl_unittests": "7b474a4ba03af0f70bf74e5e0e4d445e79208056", "gpu_unittests": "17d8388b9cffa11e12791a7a977659c6b86d2c2b", "telemetry_gpu_integration_test": "501173847a49e539de1f7f4892edb3cea5376c80"} isolate tests
swarm_hashes {"angle_unittests": "2ca53a29042c2456c43fa547fe67531c4fc7de17", "gl_tests": "5acac6da396c606bb462e57ae43cd0620dc8228e", "gl_unittests": "7b474a4ba03af0f70bf74e5e0e4d445e79208056", "gpu_unittests": "17d8388b9cffa11e12791a7a977659c6b86d2c2b", "telemetry_gpu_integration_test": "501173847a49e539de1f7f4892edb3cea5376c80"} find isolated tests

Blamelist:

  1. Sky Malice (skymohnoyoudont@google.com)
  2. chromium-autoroll (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  3. Hayato Ito (hayatoohnoyoudont@chromium.org)
  4. Mathias Carlen (mcarlenohnoyoudont@chromium.org)
  5. Lan Wei (lanweiohnoyoudont@chromium.org)
  6. Becky Zhou (huayinzohnoyoudont@chromium.org)
  7. Hirokazu Honda (hirohohnoyoudont@chromium.org)
  8. v8-ci-autoroll-builder (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  9. Denis Bessonov (dbessonovohnoyoudont@yandex-team.ru)
  10. Steve Kobes (skobesohnoyoudont@chromium.org)
  11. Lily Chen (chlilyohnoyoudont@chromium.org)
  12. Tatiana Buldina (buldinaohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 17:34:43 UTC
Start Friday, 09-Nov-18 17:34:48 UTC
End Friday, 09-Nov-18 17:59:57 UTC
Pending 4 secs
Execution 25 mins 9 secs

All Changes:

  1. [Feed] Check loadUrlParams for null, fallback to opening online.

    Changed by Sky Malice - skymohnoyoudont@google.com
    Changed at Friday, 09-Nov-18 17:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 60b47f98f87e0f3689826e4342fab09b7a35ed5e

    Comments

    [Feed] Check loadUrlParams for null, fallback to opening online.
    
    Bug: 901179
    Change-Id: Ieb3a421a7930ddc0014f7ef57b6a8f6d89dc3615
    Reviewed-on: https://chromium-review.googlesource.com/c/1315358
    Commit-Queue: Sky Malice <skym@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606886}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedLoggingBridge.java
    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/action/FeedActionHandler.java
    • chrome/android/junit/src/org/chromium/chrome/browser/feed/action/FeedActionHandlerTest.java
    • chrome/browser/android/feed/feed_logging_bridge.cc
    • chrome/browser/android/feed/feed_logging_bridge.h
  2. Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)

    Changed by chromium-autoroll - chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:32:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0475284ad58e36e9950059000bb7ec3556bb31bb

    Comments

    Roll src/third_party/perfetto cf90797ef05a..5fc6c2c52e7b (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/cf90797ef05a..5fc6c2c52e7b
    
    
    git log cf90797ef05a..5fc6c2c52e7b --date=short --no-merges --format='%ad %ae %s'
    2018-11-09 lalitm@google.com Merge "trace_processor: allow integers to be compared against doubles"
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@5fc6c2c52e7b
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: Ifd53d09565e264f09c1deffb23f8adfce3a34958
    Reviewed-on: https://chromium-review.googlesource.com/c/1329505
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606885}

    Changed files

    • DEPS
  3. Fix a bug in https://crrev.com/c/1272937, where event.target can be still null

    Changed by Hayato Ito - hayatoohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:31:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ed9605b4c99774d8865dbd190e13c9fe5c2d03a

    Comments

    Fix a bug in https://crrev.com/c/1272937, where event.target can be still null
    
    Fix a bug in the previous CL, https://crrev.com/c/1272937, where event.target
    can be null when GetElement() returns nullptr.
    
    Bug: 892970, 893449, 902287
    Change-Id: I7a08227d39117c2dc90fe720f0d6ffd62d9b2ea6
    Reviewed-on: https://chromium-review.googlesource.com/c/1322177
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606884}

    Changed files

    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  4. [Autofill Assistant] Handle payment request dismiss.

    Changed by Mathias Carlen - mcarlenohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:30:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3fe32fc147390a01e54fbd7c54e62ca3a3b8ad4

    Comments

    [Autofill Assistant] Handle payment request dismiss.
    
    Before this patch the payment request UI did not properly handle cancel
    and back button.
    
    This patch notifies the Autofill Assistant controller to shut down
    gracefully with a 'give up' message whenever the payment request UI has
    been canceled.
    
    Bug: 806868
    Change-Id: Ie3d83bf48a2004f0a6a72763c4b509b3db023ff9
    Reviewed-on: https://chromium-review.googlesource.com/c/1326499
    Commit-Queue: Mathias Carlen <mcarlen@chromium.org>
    Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606883}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantPaymentRequest.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiController.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/AutofillAssistantUiDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill_assistant/ui/PaymentRequestUI.java
    • components/autofill_assistant_strings.grdp
  5. Add action_sequence in testdriver

    Changed by Lan Wei - lanweiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:28:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 687313c56366619151285b4d87847b61e6547cbc

    Comments

    Add action_sequence in testdriver
    
    After we expose test_driver.Actions API to web users, we add their
    implementation in our testdriver file, and fix the wpt tests of
    Actions API.
    
    Bug: 893480
    Change-Id: Ib02c0223208eeb2cc30c2ca35b98d5fc938baa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/1289119
    Commit-Queue: Lan Wei <lanwei@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606882}

    Changed files

    • content/common/input/actions_parser.cc
    • content/common/input/actions_parser.h
    • content/common/input/actions_parser_unittest.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/elementPosition.html
    • third_party/WebKit/LayoutTests/external/wpt/infrastructure/testdriver/actions/eventOrder.html
    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_pointermove.html
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver-actions.js
    • third_party/WebKit/LayoutTests/external/wpt/resources/testdriver.js
    • third_party/WebKit/LayoutTests/external/wpt_automation/pointerevents/pointerevent_pointermove-manual-automation.js
    • third_party/WebKit/LayoutTests/resources/testdriver-vendor.js
    • third_party/WebKit/LayoutTests/resources/testdriver.js
  6. [Feed] Fix Feed NTP not clickable when hardware keyboard is connected

    Changed by Becky Zhou - huayinzohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:25:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision acb2df40a36d52ef4649dc82d779b8b024112358

    Comments

    [Feed] Fix Feed NTP not clickable when hardware keyboard is connected
    
    Bug: 891877
    Change-Id: I8c0cae6ad80f290580975983cb2d2f4f6286509b
    Reviewed-on: https://chromium-review.googlesource.com/c/1325082
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606881}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
  7. Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"

    Changed by Hirokazu Honda - hirohohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:21:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 341861b66e4ad99689c9842cdb723cf7429d3157

    Comments

    Reland "media/gpu/VEA unittest: Test DMABuf-backed input buffers"
    
    This adds the command line option, --natvie_input, that VEA unittest passes
    DMABuf-backed video frame to VEA.
    DMABufs are obtained by gbm though NativePixmap. To create NativePixmap on
    Chrome OS, it needs to set up Ozone environment properly. Therefore, this change
    also makes VEA unittest dependent on Ozone.
    
    BUG=chromium:895230
    TEST=VEA unittest on eve w/wo --native_input
    TBR=posciak@chromium.org
    
    Change-Id: I2998f0695813e5e1b77ae2136140eebc385636bf
    Reviewed-on: https://chromium-review.googlesource.com/c/1329121
    Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606880}

    Changed files

    • media/gpu/BUILD.gn
    • media/gpu/test/generic_dmabuf_video_frame_mapper.cc
    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/texture_ref.cc
    • media/gpu/test/texture_ref.h
    • media/gpu/test/video_encode_accelerator_unittest_helpers.cc
    • media/gpu/test/video_encode_accelerator_unittest_helpers.h
    • media/gpu/test/video_frame_mapper_factory.cc
    • media/gpu/test/video_frame_mapper_factory.h
    • media/gpu/test/video_frame_validator.cc
    • media/gpu/test/video_frame_validator.h
    • media/gpu/video_decode_accelerator_unittest.cc
    • media/gpu/video_encode_accelerator_unittest.cc
  8. Update V8 to version 7.2.287.

    Changed by v8-ci-autoroll-builder - v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Friday, 09-Nov-18 17:21:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7625aefbe45933a2dc896bd154fbfe3663b3480

    Comments

    Update V8 to version 7.2.287.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/31b2546b..f6ed3c5d
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ida402fad2dfa8556ea7ae1c22d42058bfb90fa6f
    Reviewed-on: https://chromium-review.googlesource.com/c/1329301
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#606879}

    Changed files

    • DEPS
  9. Out-of-line default constructor of WebRange.

    Changed by Denis Bessonov - dbessonovohnoyoudont@yandex-team.ru
    Changed at Friday, 09-Nov-18 17:19:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 92aa96594173109bc330bb2eab84d8e61bd7ee5e

    Comments

    Out-of-line default constructor of WebRange.
    
    WebRange default constructor is both inline and BLINK_EXPORT.
    Using WebRange() in different blink modules (for example,
    blink_core and blink_controller) results in duplicate symbols
    during linking.
    
    This CL out-of-lines this constructor to ensure that exported
    constructor has only one implementation.
    
    Bug: 903712
    Change-Id: Ifdc947c4d0001a4be7404950a6a1639bc9877372
    Reviewed-on: https://chromium-review.googlesource.com/c/1328964
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606878}

    Changed files

    • third_party/blink/public/web/web_range.h
    • third_party/blink/renderer/core/exported/web_range.cc
  10. Add and report LayoutStability.JankScore UKM.

    Changed by Steve Kobes - skobesohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:14:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 162f0b1678e9c6b559ee7931f910cff372d9e5e2

    Comments

    Add and report LayoutStability.JankScore UKM.
    
    We prolong the lifetime of UkmPageLoadMetricsObserver to permit jank
    score reporting at session end for tabs that start or become hidden,
    but avoid extra reporting of other metrics by checking was_hidden_.
    
    The OnFinalLayoutStabilityUpdate hook is removed in favor of passing
    PageRenderData to existing hooks through PageLoadExtraInfo.  This lets
    the observer decide when to report.
    
    UKM collection review doc: go/lsukmrev
    
    Bug: 581518
    Change-Id: I2983dff155872f3080474e09df784d20b3cb08d3
    Reviewed-on: https://chromium-review.googlesource.com/c/1299917
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606877}

    Changed files

    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • tools/metrics/ukm/ukm.xml
  11. Add reprioritization to SSLConnectJobs

    Changed by Lily Chen - chlilyohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:13:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a9302e29c7625fd7cdc65f374fc7f00550c21aa

    Comments

    Add reprioritization to SSLConnectJobs
    
    This change allows the priority of an SSLConnectJob to be changed. If
    the reprioritization occurs while the job is establishing its underlying
    connection, the priority change is also passed down to the lower-level
    socket pool.
    
    Bug: 166689
    Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a
    Reviewed-on: https://chromium-review.googlesource.com/c/1327423
    Commit-Queue: Lily Chen <chlily@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606876}

    Changed files

    • net/socket/socket_test_util.cc
    • net/socket/socket_test_util.h
    • net/socket/ssl_client_socket_pool.cc
    • net/socket/ssl_client_socket_pool.h
    • net/socket/ssl_client_socket_pool_unittest.cc
  12. [ChromeDriver] Add tests names where Chrome retried to start to logs

    Changed by Tatiana Buldina - buldinaohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 17:10:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e02c93aa236dd55c50eafd019f865e192192ac34

    Comments

    [ChromeDriver] Add tests names where Chrome retried to start to logs
    
    Change-Id: I6d2cf48b16562f60e35b2d499bfbbe25c12533c1
    Reviewed-on: https://chromium-review.googlesource.com/c/1327168
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606875}

    Changed files

    • chrome/test/chromedriver/client/chromedriver.py
    • chrome/test/chromedriver/test/run_py_tests.py