Builder Android FYI Release (Nexus 5X) Build 6353
Results:
Success
Trigger Info:
Project | chromium |
Revision | 3e44f3be427bb7222e8e20640e261d620478e8bc |
Got Revision | 3e44f3be427bb7222e8e20640e261d620478e8bc |
Execution:
- Source: Task 3ea914d9cc07ec10
- Bot: swarm1098-c4
Steps and Logfiles:
Show:-
- - no logs -
-
( 1 secs ) read test spec (chromium.gpu.fyi.json)path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
-
- - no logs -
-
- - no logs -
-
- - no logs -
-
( 1 secs ) [trigger] hardware_accelerated_feature_tests on Android device Nexus 5XRun on OS: 'Android'
-
( 3 mins 20 secs ) angle_end2end_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:03:31.622100
-
( 42 secs ) gpu_unittests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:04:17.384910
-
( 1 secs ) angle_perftests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:01:28.100310Total tests: n/a
-
( 1 secs ) context_lost_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:03:32.237930Total tests: 8* Passed: 5 (5 expected, 0 unexpected)* Skipped: 3 (3 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) depth_capture_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:01:57.156390Total tests: 3* Passed: 3 (3 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) gpu_process_launch_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:03:28.466000Total tests: 15* Passed: 15 (15 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) hardware_accelerated_feature_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:01:46.294700Total tests: 2* Passed: 2 (2 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) info_collection_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:02:13.434980Total tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) maps_pixel_test on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:02:10.826450Total tests: 1* Passed: 1 (1 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 45 secs ) pixel_test on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:05:18.537370Total tests: 46* Passed: 36 (36 expected, 0 unexpected)* Skipped: 10 (10 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) screenshot_sync_tests on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:03:09.746940Total tests: 4* Passed: 4 (4 expected, 0 unexpected)* Skipped: 0 (0 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 1 secs ) trace_test on Android device Nexus 5XRun on OS: 'Android'Shard duration: 0:03:32.791370Total tests: 34* Passed: 17 (17 expected, 0 unexpected)* Skipped: 17 (17 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
-
( 7 mins 20 secs ) webgl_conformance_tests on Android device Nexus 5XRun on OS: 'Android'Max shard duration: 0:12:38.218150 (shard #2)Min shard duration: 0:05:13.213570 (shard #4)Total tests: 922* Passed: 913 (913 expected, 0 unexpected)* Skipped: 9 (9 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- shard #0 isolated out
- shard #0 (441.5 sec)
- shard #1 isolated out
- shard #1 (485.6 sec)
- shard #2 isolated out
- shard #2 (723.8 sec)
- shard #3 isolated out
- shard #3 (296.1 sec)
- shard #4 isolated out
- shard #4 (279.1 sec)
- shard #5 isolated out
- shard #5 (284.8 sec)
Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "swarm1098-c4" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531428687809180, "id": "8941174348210260816", "project": "chromium", "tags": ["builder:Android FYI Release (Nexus 5X)", "buildset:commit/git/3e44f3be427bb7222e8e20640e261d620478e8bc", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/3e44f3be427bb7222e8e20640e261d620478e8bc", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106604410354990880", "scheduler_job_id:chromium/Android FYI Release (Nexus 5X)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "Android FYI Release (Nexus 5X)" | setup_build |
buildnumber | 6353 | setup_build |
mastername | "chromium.gpu.fyi" | setup_build |
path_config | "generic" | setup_build |
recipe | "chromium" | setup_build |
repository | "https://chromium.googlesource.com/chromium/src.git" | setup_build |
revision | "3e44f3be427bb7222e8e20640e261d620478e8bc" | setup_build |
got_angle_revision | "1617e69e3883e77f8ae05680576d08d905fcc70f" | bot_update |
got_buildtools_revision | "0dd5c6f980d22be96b728155249df2da355989d9" | bot_update |
got_nacl_revision | "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" | bot_update |
got_revision | "3e44f3be427bb7222e8e20640e261d620478e8bc" | bot_update |
got_revision_cp | "refs/heads/master@{#574711}" | bot_update |
got_swarming_client_revision | "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" | bot_update |
got_v8_revision | "8b17db68f75a95d69debfa85b70aea3ec0766aaf" | bot_update |
got_v8_revision_cp | "refs/heads/6.9.352@{#1}" | bot_update |
got_webrtc_revision | "895617fa9bc36c240b37d47402cdb341ecadf994" | bot_update |
got_webrtc_revision_cp | "refs/heads/master@{#23955}" | bot_update |
swarm_hashes_refs/heads/master(at){#574711}_without_patch | {"angle_end2end_tests": "27caa0242db95cf4f702b00beff7057fb0e77cde", "angle_perftests": "b21064abe9b1aed4e63cc6313472bc0f18fb056b", "gpu_unittests": "c33759f86f934c05418107e43ac1a83b48b00915", "telemetry_gpu_integration_test": "33bc3ddd0ff18499c84135c4197c2aaabe3ff820"} | isolate tests |
swarm_hashes | {"angle_end2end_tests": "27caa0242db95cf4f702b00beff7057fb0e77cde", "angle_perftests": "b21064abe9b1aed4e63cc6313472bc0f18fb056b", "gpu_unittests": "c33759f86f934c05418107e43ac1a83b48b00915", "telemetry_gpu_integration_test": "33bc3ddd0ff18499c84135c4197c2aaabe3ff820"} | find isolated tests |
Blamelist:
- Nicolas Pena (npmohnoyoudont@chromium.org)
- Karan Bhatia (karandeepbohnoyoudont@chromium.org)
- Jared Saul (jsaulohnoyoudont@google.com)
- Peter Kvitek (kvitekpohnoyoudont@chromium.org)
- Nate Chapin (japhetohnoyoudont@chromium.org)
- John Abd-El-Malek (jamohnoyoudont@chromium.org)
- Will Harris (wfhohnoyoudont@chromium.org)
- Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
- Tibor Goldschwendt (tiborgohnoyoudont@chromium.org)
- Yiming Zhou (uwyimingohnoyoudont@google.com)
- Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
Timing:
Create | Thursday, 12-Jul-18 20:51:27 UTC |
Start | Thursday, 12-Jul-18 20:51:33 UTC |
End | Thursday, 12-Jul-18 21:29:41 UTC |
Pending | 5 secs |
Execution | 38 mins 7 secs |
All Changes:
-
Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds
Changed by Nicolas Pena - npmohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:49:00 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3e44f3be427bb7222e8e20640e261d620478e8bc Comments
Use UMA_HISTOGRAM_TIMES or saturated_cast to report milliseconds This CL changes Blink code from using Count(delta.InMilliseconds()) to: * UMA_HISTOGRAM_TIMES where possible. * Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible. * Otherwise, saturated_cast. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e Reviewed-on: https://chromium-review.googlesource.com/1134083 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#574711}
Changed files
- third_party/blink/renderer/core/editing/spellcheck/spell_check_requester.cc
- third_party/blink/renderer/core/html/media/autoplay_uma_helper.cc
- third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
- third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_metrics.cc
- third_party/blink/renderer/modules/notifications/notification_image_loader.cc
- third_party/blink/renderer/platform/heap/heap_stats_collector.cc
- third_party/blink/renderer/platform/heap/heap_stats_collector.h
- third_party/blink/renderer/platform/heap/heap_stats_collector_test.cc
- third_party/blink/renderer/platform/heap/thread_state.cc
- third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
-
Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.
Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:47:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359 Comments
Change RulesMonitorService::HasRegisteredRuleset to take an extension_id. This CL changes RulesMonitorService::HasRegisteredRuleset to take an extension_id instead of an extension pointer. BUG=None Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f Reviewed-on: https://chromium-review.googlesource.com/1134519 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574710}
Changed files
- extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
- extensions/browser/api/declarative_net_request/rules_monitor_service.cc
- extensions/browser/api/declarative_net_request/rules_monitor_service.h
-
[Autofill] Log metric for whether card upload cardholder name was edited
Changed by Jared Saul - jsaulohnoyoudont@google.com Changed at Thursday, 12-Jul-18 20:40:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98 Comments
[Autofill] Log metric for whether card upload cardholder name was edited Bug: 848955 Change-Id: I8febd9c3471b58b962d3706eede4be506b092044 Reviewed-on: https://chromium-review.googlesource.com/1134089 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#574709}
Changed files
- chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
- chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
- components/autofill/core/browser/autofill_metrics.cc
- components/autofill/core/browser/autofill_metrics.h
- tools/metrics/histograms/histograms.xml
-
Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)
Changed by Peter Kvitek - kvitekpohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:37:18 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dcd804265b610b002db7023e6c180bd12e1e29bb Comments
Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III) Browser flags that are required for BeginFrameControl are now set only for compositor specific tests thus preventing virtual time flakyness. Reinstate VirtualTimeErrorLoop test since this change fixes its flakiness. Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1 Reviewed-on: https://chromium-review.googlesource.com/1133711 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574708}
Changed files
- headless/test/DEPS
- headless/test/data/protocol/emulation/compositor-basic-raf-expected.txt
- headless/test/data/protocol/emulation/compositor-basic-raf.js
- headless/test/data/protocol/emulation/compositor-css-animation-test-expected.txt
- headless/test/data/protocol/emulation/compositor-css-animation-test.js
- headless/test/data/protocol/emulation/compositor-image-animation-test-expected.txt
- headless/test/data/protocol/emulation/compositor-image-animation-test.js
- headless/test/data/protocol/emulation/resources/animated_square.gif
- headless/test/data/protocol/emulation/resources/compositor-basic-raf.html
- headless/test/data/protocol/emulation/resources/compositor-css-animation.html
- headless/test/data/protocol/emulation/resources/compositor-image-animation.html
- headless/test/headless_protocol_browsertest.cc
-
Clone service worker objects to nested workers
Changed by Nate Chapin - japhetohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:36:49 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 62cb57146b83dcd0b2b2add48c4cfe02b3d770b9 Comments
Clone service worker objects to nested workers Bug: 31666 Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8 Reviewed-on: https://chromium-review.googlesource.com/1130101 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#574707}
Changed files
- content/renderer/loader/web_worker_fetch_context_impl.cc
- content/renderer/loader/web_worker_fetch_context_impl.h
- content/renderer/render_frame_impl.cc
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https-expected.txt
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https.html
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-iframe.html
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-parent-worker.js
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested_load_worker.js
- third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-iframe.https.html
-
Stop using ResourceContext::GetHostResolver().
Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:32:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ed5e651e10cd158bf786b33c0dcd77d714244d2e Comments
Stop using ResourceContext::GetHostResolver(). ResourceContext is deprecated, and after r567879 it returns nullptr when network service is enabled. Instead get the HostResolver from the URLRequestContext. Also remove ResourceContext::GetHostResolver() as it's no longer used. Bug: 853696 Change-Id: Ic09dac09f14e4aaf0e20dd990246cc51ae35e933 Reviewed-on: https://chromium-review.googlesource.com/1135366 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#574706}
Changed files
- android_webview/browser/aw_resource_context.cc
- android_webview/browser/aw_resource_context.h
- chrome/browser/profiles/profile_io_data.cc
- chrome/browser/profiles/profile_io_data.h
- chromecast/browser/cast_browser_context.cc
- content/browser/renderer_host/p2p/socket_dispatcher_host.cc
- content/browser/renderer_host/p2p/socket_dispatcher_host.h
- content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
- content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h
- content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
- content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
- content/browser/renderer_host/render_process_host_impl.cc
- content/public/browser/resource_context.h
- content/public/test/mock_resource_context.cc
- content/public/test/mock_resource_context.h
- content/shell/browser/shell_browser_context.cc
- content/shell/browser/shell_browser_context.h
- content/shell/browser/shell_url_request_context_getter.cc
- content/shell/browser/shell_url_request_context_getter.h
- extensions/browser/api/dns/dns_api.cc
- extensions/browser/api/dns/dns_api.h
- extensions/browser/api/dns/host_resolver_wrapper.cc
- extensions/browser/api/dns/host_resolver_wrapper.h
- extensions/browser/api/socket/socket_api.cc
- extensions/browser/api/socket/socket_api.h
- headless/lib/browser/headless_browser_context_impl.cc
- webrunner/browser/webrunner_browser_context.cc
-
Update Flash plugin metadata versions to latest version.
Changed by Will Harris - wfhohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:31:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e233c1d178562ac6171d190f1e4d9ec9a94ac11e Comments
Update Flash plugin metadata versions to latest version. https://helpx.adobe.com/security/products/flash-player/apsb18-24.html BUG=412078 TBR=jschuh@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69 Reviewed-on: https://chromium-review.googlesource.com/1135713 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#574705}
Changed files
- chrome/browser/resources/plugin_metadata/plugins_linux.json
- chrome/browser/resources/plugin_metadata/plugins_mac.json
- chrome/browser/resources/plugin_metadata/plugins_win.json
-
Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32
Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:29:51 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e40e820481f52c0cc29b1841542b4e24465909bd Comments
Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32 Using wpt-import in Chromium a7edd65b959ed3edbb808bd0bd2c914e5a92cfff. With Chromium commits locally applied on WPT: a9045946af "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI TBR=foolip No-Export: true Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616 Reviewed-on: https://chromium-review.googlesource.com/1135585 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574704}
Changed files
- third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
- third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.html
- third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker.js
-
Android: Do not generate R.java from android_apk AndroidManifest.xml
Changed by Tibor Goldschwendt - tiborgohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:29:21 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 01020f3bca281b6de9bd9deacbe849cbc1255cfa Comments
Android: Do not generate R.java from android_apk AndroidManifest.xml In order to implement synchronized proguarding we cannot have multiple R class with the same package. Thus, prevent creation of R files with manifest's package when creating APKs. Bug: 862696 Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c Reviewed-on: https://chromium-review.googlesource.com/1134414 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#574703}
Changed files
- build/android/gyp/compile_resources.py
- build/android/gyp/util/resource_utils.py
-
Record when a user presses Enter on a web page.
Changed by Yiming Zhou - uwyimingohnoyoudont@google.com Changed at Thursday, 12-Jul-18 20:28:09 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fb5a18d97233f6a11c4606fa3b085d2b7ba0ff11 Comments
Record when a user presses Enter on a web page. This change adds a feature that allows the Action Recorder Extension to detect when a user presses the Enter key on a page, and records this action. Pressing the Enter key is a common action that a user invokes to submit a form. Bug: 855284 Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b Reviewed-on: https://chromium-review.googlesource.com/1135523 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574702}
Changed files
- components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
- components/test/data/autofill/automated_integration/action_recorder_extension/content/panel.js
-
Reset listener properties after provisional load
Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 20:25:25 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8afd07cc1159e077da359175edefd419a090fb7d Comments
Reset listener properties after provisional load When provisional load is committed in FrameLoader and the corresponding frame is a LocalRoot, the EventListenerProperties are reset to none for touch and wheel listeners. This update is then propagate through render widget and LayterTreeHost to the browser and the CC correspondingly. However, if the local root is provisional the call is dropped in ChromeClientImpl. This would include all cross-process navigations which end up in a provisional frame. This change will make sure the initial updates for EventListenerProperties for a local root are sent after WebLocalFrameClient is notified about committing provisional load. Bug: 850994 Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c Reviewed-on: https://chromium-review.googlesource.com/1126329 Commit-Queue: Ehsan Karamad <ekaramad@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574701}
Changed files
- content/browser/renderer_host/input/input_router_impl.h
- content/browser/renderer_host/render_widget_host_browsertest.cc
- third_party/blink/renderer/core/exported/local_frame_client_impl.cc
- third_party/blink/renderer/core/loader/frame_loader.cc