Home | Search | chromium - Builders

Builder Android FYI Release (NVIDIA Shield TV) Build 8385 Canonical Ubuntu



Trigger Info:

Got Revision167121ea09987452572723a78b2d8987b770b751


Steps and Logfiles:

  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:



  1. Robert Ma (robertmaohnoyoudont@chromium.org)
  2. Dmitry Gozman (dgozmanohnoyoudont@chromium.org)
  3. Marc Treib (treibohnoyoudont@chromium.org)


Create Friday, 12-Oct-18 14:03:05 UTC
Start Friday, 12-Oct-18 14:03:07 UTC
End Friday, 12-Oct-18 14:28:04 UTC
Pending 2 secs
Execution 24 mins 56 secs

All Changes:

  1. [WPT import] Add a flag to upload but not submit CL

    Changed by Robert Ma - robertmaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:49:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 167121ea09987452572723a78b2d8987b770b751


    [WPT import] Add a flag to upload but not submit CL
    We used to have only one flag, --auto-update, which controls both
    uploading and landing the import CL. This makes testing new setup of the
    bot (i.e. LUCI in this case) hard.
    This change adds one more flag, --auto-upload, to exercise more steps
    (namely uploading and rebaselining), which will be used on the
    experimental LUCI builder.
    Bug: 790503
    Change-Id: I4ce07fc9ddf15a34c9cb25ba4723d250cad26977
    Reviewed-on: https://chromium-review.googlesource.com/c/1277587
    Commit-Queue: Robert Ma <robertma@chromium.org>
    Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599197}

    Changed files

    • third_party/blink/tools/blinkpy/w3c/test_importer.py
  2. Restore FrameLoadRequest::HrefTranslate

    Changed by Dmitry Gozman - dgozmanohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision 703e2b8a5b805ecd4fba4bffb76095125330cec4


    Restore FrameLoadRequest::HrefTranslate
    This was accidentaly removed as part of FrameLoadRequest cleanup.
    Bug: none
    Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
    Reviewed-on: https://chromium-review.googlesource.com/c/1278290
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599196}

    Changed files

    • third_party/blink/renderer/core/html/html_anchor_element.cc
    • third_party/blink/renderer/core/loader/frame_load_request.h
  3. ProfileSyncService cleanup: Remove platform_sync_allowed_provider_

    Changed by Marc Treib - treibohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 13:42:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Revision f0d63432c51741e6dc0bf48f0b84e4afb63f887f


    ProfileSyncService cleanup: Remove platform_sync_allowed_provider_
    ProfileSyncService::platform_sync_allowed_provider_ was a callback that
    returned whether Android's "Master Sync" toggle is enabled, and so Sync
    shouldn't start up. However, PSS didn't know when the value changed, so
    the callback was kinda useless, and PSS could easily get into an
    inconsistent state (where there is a disable reason, but Sync is still
    running). Things were working out in practice only because the Android
    UI code also called RequestStart/Stop as necessary.
    So, since PSS needs change notifications anyway, let's make that
    explicit: This CL replaces the callback by a bool, which can be set
    Bug: 867901
    Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
    Reviewed-on: https://chromium-review.googlesource.com/c/1269870
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599195}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java
    • chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java
    • chrome/browser/sync/profile_sync_service_android.cc
    • chrome/browser/sync/profile_sync_service_android.h
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h