Home | Search | chromium - Builders
Login

Builder Android FYI Release (NVIDIA Shield TV) Build 4818 Canonical Ubuntu

Results:

Failure webgl_conformance_tests on Android device NVIDIA Shield

Trigger Info:

Projectchromium
Revisionb96ae12ef5fa70c2389e5b23da5a924eb4dff359
Got Revisionb96ae12ef5fa70c2389e5b23da5a924eb4dff359

Execution:

Steps and Logfiles:

Show:
  1. ( 283 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 53 secs ) bot_update
    [67GB/295GB used (22%)]
  4. ( 0 ) ensure_goma
  5. ( 780 ms ) swarming.py --version
    0.13
  6. ( 11 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 4 secs ) clean local files
  9. ( 4 secs ) tree truth steps
  10. ( 28 secs ) generate_build_files
  11. ( 7 mins 52 secs ) compile
  12. ( 20 secs ) isolate tests
  13. ( 649 ms ) find isolated tests
  14. ( 0 ) test_pre_run
  15. ( 3 mins 29 secs ) angle_end2end_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 16s
    Shard duration: 0:03:27.639120
  16. ( 3 secs ) angle_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 20s
    Shard duration: 0:02:32.161610
  17. ( 1 secs ) gl_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 20s
    Shard duration: 0:01:04.337440
  18. ( 1 secs ) gl_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 36s
    Shard duration: 28s
  19. ( 9 mins 39 secs ) gpu_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:10:58.330840
    Shard duration: 0:02:36.647070
  20. ( 2 secs ) angle_perftests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:10:57.229320
    Shard duration: 56s
    Total tests: n/a
     
  21. ( 1 secs ) context_lost_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:10:55.995050
    Shard duration: 0:02:26.901300
    Total tests: 8
    * Passed: 5 (5 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 1 secs ) depth_capture_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:10:55.222380
    Shard duration: 0:01:34.032820
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 1 mins 1 secs ) gpu_process_launch_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:11:56.168060
    Shard duration: 0:02:58.283630
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 secs ) hardware_accelerated_feature_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:11:58.917340
    Shard duration: 0:01:29.248750
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 1 secs ) info_collection_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:12:35.168470
    Shard duration: 0:01:19.624470
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 15 secs ) maps_pixel_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:13:25.569270
    Shard duration: 0:01:46.805680
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 3 mins 13 secs ) pixel_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:13:33.529780
    Shard duration: 0:04:51.654520
    Total tests: 46
    * Passed: 36 (36 expected, 0 unexpected)
    * Skipped: 10 (10 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 2 secs ) screenshot_sync_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:13:32.350700
    Shard duration: 0:02:17.953080
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 secs ) trace_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:13:58.737840
    Shard duration: 0:03:05.358160
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 5 mins 44 secs ) webgl_conformance_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Max pending time: 0:19:36.725900 (shard #5)
    Max shard duration: 0:05:07.340050 (shard #2)
    Min shard duration: 0:01:31.755770 (shard #0)
    Total tests: 770
    * Passed: 765 (765 expected, 0 unexpected)
    * Skipped: 5 (5 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 328 ms ) Tests statistics
     
    Stats
    Total shards: 21
    Total runtime: 0:50:34.633802
     
  32. ( 340 ms ) test_report
  33. ( 1 ms ) Failure reason

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm571-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531428514131360, "id": "8941174530324689856", "project": "chromium", "tags": ["builder:Android FYI Release (NVIDIA Shield TV)", "buildset:commit/git/b96ae12ef5fa70c2389e5b23da5a924eb4dff359", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/b96ae12ef5fa70c2389e5b23da5a924eb4dff359", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106604592850138464", "scheduler_job_id:chromium/Android FYI Release (NVIDIA Shield TV)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android FYI Release (NVIDIA Shield TV)" setup_build
buildnumber 4818 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "b96ae12ef5fa70c2389e5b23da5a924eb4dff359" setup_build
got_angle_revision "1617e69e3883e77f8ae05680576d08d905fcc70f" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "b96ae12ef5fa70c2389e5b23da5a924eb4dff359" bot_update
got_revision_cp "refs/heads/master@{#574710}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "895617fa9bc36c240b37d47402cdb341ecadf994" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23955}" bot_update
swarm_hashes_refs/heads/master(at){#574710}_without_patch {"angle_end2end_tests": "e5dd73f9a367a9bca9c3f34f817d9cba77445e66", "angle_perftests": "955757e31f9c877c10235eee6bcf632a47a3d765", "angle_unittests": "aa1ab3b8ce551229d694c053706f101897750c93", "gl_tests": "2d7686c985bd170b0538dceadf45f08f5bf8838e", "gl_unittests": "6762d8178a15a1b94144b67fe045283dd5a27d24", "gpu_unittests": "89e73eb28d59bf4a0a36f7548d18c06591aae82c", "telemetry_gpu_integration_test": "b6da1799db1394376252c23f7369c42995f075c5"} isolate tests
swarm_hashes {"angle_end2end_tests": "e5dd73f9a367a9bca9c3f34f817d9cba77445e66", "angle_perftests": "955757e31f9c877c10235eee6bcf632a47a3d765", "angle_unittests": "aa1ab3b8ce551229d694c053706f101897750c93", "gl_tests": "2d7686c985bd170b0538dceadf45f08f5bf8838e", "gl_unittests": "6762d8178a15a1b94144b67fe045283dd5a27d24", "gpu_unittests": "89e73eb28d59bf4a0a36f7548d18c06591aae82c", "telemetry_gpu_integration_test": "b6da1799db1394376252c23f7369c42995f075c5"} find isolated tests

Blamelist:

  1. Karan Bhatia (karandeepbohnoyoudont@chromium.org)
  2. Jared Saul (jsaulohnoyoudont@google.com)
  3. Peter Kvitek (kvitekpohnoyoudont@chromium.org)
  4. Nate Chapin (japhetohnoyoudont@chromium.org)
  5. John Abd-El-Malek (jamohnoyoudont@chromium.org)
  6. Will Harris (wfhohnoyoudont@chromium.org)
  7. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  8. Tibor Goldschwendt (tiborgohnoyoudont@chromium.org)
  9. Yiming Zhou (uwyimingohnoyoudont@google.com)
  10. Ehsan Karamad (ekaramadohnoyoudont@chromium.org)
  11. Robbie McElrath (rmcelrathohnoyoudont@chromium.org)
  12. erikchen (erikchenohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 20:48:34 UTC
Start Thursday, 12-Jul-18 20:48:38 UTC
End Thursday, 12-Jul-18 21:24:15 UTC
Pending 4 secs
Execution 35 mins 37 secs

All Changes:

  1. Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.

    Changed by Karan Bhatia - karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b96ae12ef5fa70c2389e5b23da5a924eb4dff359

    Comments

    Change RulesMonitorService::HasRegisteredRuleset to take an extension_id.
    
    This CL changes RulesMonitorService::HasRegisteredRuleset to take an
    extension_id instead of an extension pointer.
    
    BUG=None
    
    Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f
    Reviewed-on: https://chromium-review.googlesource.com/1134519
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574710}

    Changed files

    • extensions/browser/api/declarative_net_request/declarative_net_request_api.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.h
  2. [Autofill] Log metric for whether card upload cardholder name was edited

    Changed by Jared Saul - jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:40:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1447fae2e377e748f4ddb532a99f6c5ba7319c98

    Comments

    [Autofill] Log metric for whether card upload cardholder name was edited
    
    Bug: 848955
    Change-Id: I8febd9c3471b58b962d3706eede4be506b092044
    Reviewed-on: https://chromium-review.googlesource.com/1134089
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574709}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/histograms.xml
  3. Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)

    Changed by Peter Kvitek - kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:37:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcd804265b610b002db7023e6c180bd12e1e29bb

    Comments

    Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. (III)
    
    Browser flags that are required for BeginFrameControl are now set only
    for compositor specific tests thus preventing virtual time flakyness.
    
    Reinstate VirtualTimeErrorLoop test since this change fixes its
    flakiness.
    
    Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1
    Reviewed-on: https://chromium-review.googlesource.com/1133711
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574708}

    Changed files

    • headless/test/DEPS
    • headless/test/data/protocol/emulation/compositor-basic-raf-expected.txt
    • headless/test/data/protocol/emulation/compositor-basic-raf.js
    • headless/test/data/protocol/emulation/compositor-css-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-css-animation-test.js
    • headless/test/data/protocol/emulation/compositor-image-animation-test-expected.txt
    • headless/test/data/protocol/emulation/compositor-image-animation-test.js
    • headless/test/data/protocol/emulation/resources/animated_square.gif
    • headless/test/data/protocol/emulation/resources/compositor-basic-raf.html
    • headless/test/data/protocol/emulation/resources/compositor-css-animation.html
    • headless/test/data/protocol/emulation/resources/compositor-image-animation.html
    • headless/test/headless_protocol_browsertest.cc
  4. Clone service worker objects to nested workers

    Changed by Nate Chapin - japhetohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:36:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62cb57146b83dcd0b2b2add48c4cfe02b3d770b9

    Comments

    Clone service worker objects to nested workers
    
    Bug: 31666
    Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8
    Reviewed-on: https://chromium-review.googlesource.com/1130101
    Commit-Queue: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574707}

    Changed files

    • content/renderer/loader/web_worker_fetch_context_impl.cc
    • content/renderer/loader/web_worker_fetch_context_impl.h
    • content/renderer/render_frame_impl.cc
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/claim-worker-fetch.https.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-iframe.html
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/claim-nested-worker-fetch-parent-worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/nested_load_worker.js
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/worker-interception-iframe.https.html
  5. Stop using ResourceContext::GetHostResolver().

    Changed by John Abd-El-Malek - jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:32:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed5e651e10cd158bf786b33c0dcd77d714244d2e

    Comments

    Stop using ResourceContext::GetHostResolver().
    
    ResourceContext is deprecated, and after r567879 it returns nullptr when network service is enabled.
    
    Instead get the HostResolver from the URLRequestContext. Also remove ResourceContext::GetHostResolver() as it's no longer used.
    
    Bug: 853696
    Change-Id: Ic09dac09f14e4aaf0e20dd990246cc51ae35e933
    Reviewed-on: https://chromium-review.googlesource.com/1135366
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574706}

    Changed files

    • android_webview/browser/aw_resource_context.cc
    • android_webview/browser/aw_resource_context.h
    • chrome/browser/profiles/profile_io_data.cc
    • chrome/browser/profiles/profile_io_data.h
    • chromecast/browser/cast_browser_context.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.cc
    • content/browser/renderer_host/p2p/socket_dispatcher_host.h
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_host_resolver_message_filter.h
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc
    • content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.h
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/public/browser/resource_context.h
    • content/public/test/mock_resource_context.cc
    • content/public/test/mock_resource_context.h
    • content/shell/browser/shell_browser_context.cc
    • content/shell/browser/shell_browser_context.h
    • content/shell/browser/shell_url_request_context_getter.cc
    • content/shell/browser/shell_url_request_context_getter.h
    • extensions/browser/api/dns/dns_api.cc
    • extensions/browser/api/dns/dns_api.h
    • extensions/browser/api/dns/host_resolver_wrapper.cc
    • extensions/browser/api/dns/host_resolver_wrapper.h
    • extensions/browser/api/socket/socket_api.cc
    • extensions/browser/api/socket/socket_api.h
    • headless/lib/browser/headless_browser_context_impl.cc
    • webrunner/browser/webrunner_browser_context.cc
  6. Update Flash plugin metadata versions to latest version.

    Changed by Will Harris - wfhohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e233c1d178562ac6171d190f1e4d9ec9a94ac11e

    Comments

    Update Flash plugin metadata versions to latest version.
    
    https://helpx.adobe.com/security/products/flash-player/apsb18-24.html
    
    BUG=412078
    TBR=jschuh@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69
    Reviewed-on: https://chromium-review.googlesource.com/1135713
    Commit-Queue: Will Harris <wfh@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574705}

    Changed files

    • chrome/browser/resources/plugin_metadata/plugins_linux.json
    • chrome/browser/resources/plugin_metadata/plugins_mac.json
    • chrome/browser/resources/plugin_metadata/plugins_win.json
  7. Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e40e820481f52c0cc29b1841542b4e24465909bd

    Comments

    Import wpt@df05bcb7c5c82e300805d7c11121453ec4036e32
    
    Using wpt-import in Chromium a7edd65b959ed3edbb808bd0bd2c914e5a92cfff.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    jsbell@chromium.org, mek@chromium.org:
      external/wpt/FileAPI
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616
    Reviewed-on: https://chromium-review.googlesource.com/1135585
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574704}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.html
    • third_party/WebKit/LayoutTests/external/wpt/FileAPI/idlharness.worker.js
  8. Android: Do not generate R.java from android_apk AndroidManifest.xml

    Changed by Tibor Goldschwendt - tiborgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:29:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01020f3bca281b6de9bd9deacbe849cbc1255cfa

    Comments

    Android: Do not generate R.java from android_apk AndroidManifest.xml
    
    In order to implement synchronized proguarding we cannot have multiple
    R class with the same package. Thus, prevent creation of R files with
    manifest's package when creating APKs.
    
    Bug: 862696
    Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c
    Reviewed-on: https://chromium-review.googlesource.com/1134414
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574703}

    Changed files

    • build/android/gyp/compile_resources.py
    • build/android/gyp/util/resource_utils.py
  9. Record when a user presses Enter on a web page.

    Changed by Yiming Zhou - uwyimingohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 20:28:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb5a18d97233f6a11c4606fa3b085d2b7ba0ff11

    Comments

    Record when a user presses Enter on a web page.
    
    This change adds a feature that allows the Action Recorder Extension to
    detect when a user presses the Enter key on a page, and records this
    action. Pressing the Enter key is a common action that a user invokes to
    submit a form.
    
    Bug: 855284
    Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b
    Reviewed-on: https://chromium-review.googlesource.com/1135523
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574702}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/panel.js
  10. Reset listener properties after provisional load

    Changed by Ehsan Karamad - ekaramadohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:25:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8afd07cc1159e077da359175edefd419a090fb7d

    Comments

    Reset listener properties after provisional load
    
    When provisional load is committed in FrameLoader and the corresponding
    frame is a LocalRoot, the EventListenerProperties are reset to none for
    touch and wheel listeners. This update is then propagate through render
    widget and LayterTreeHost to the browser and the CC correspondingly.
    
    However, if the local root is provisional the call is dropped in
    ChromeClientImpl. This would include all cross-process navigations which
    end up in a provisional frame.
    
    This change will make sure the initial updates for
    EventListenerProperties for a local root are sent after
    WebLocalFrameClient is notified about committing provisional load.
    
    Bug: 850994
    Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c
    Reviewed-on: https://chromium-review.googlesource.com/1126329
    Commit-Queue: Ehsan Karamad <ekaramad@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574701}

    Changed files

    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/render_widget_host_browsertest.cc
    • third_party/blink/renderer/core/exported/local_frame_client_impl.cc
    • third_party/blink/renderer/core/loader/frame_loader.cc
  11. Migrate PrivetTrafficDetector to use NetworkConnectionTracker.

    Changed by Robbie McElrath - rmcelrathohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:20:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b78521765f33993e81dfba771127fe9d5eb4add

    Comments

    Migrate PrivetTrafficDetector to use NetworkConnectionTracker.
    
    This migrates PrivetTrafficDetector from using
    net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
    works with the network service enabled.
    
    Bug: 859134
    Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581
    Reviewed-on: https://chromium-review.googlesource.com/1123681
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574700}

    Changed files

    • chrome/browser/printing/cloud_print/privet_traffic_detector.cc
    • chrome/browser/printing/cloud_print/privet_traffic_detector.h
  12. Remove assertion from DetachToOwnWindow on macOS 10.10.

    Changed by erikchen - erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 20:16:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b20bb048913985eae71b480db2a2017173ef73a2

    Comments

    Remove assertion from DetachToOwnWindow on macOS 10.10.
    
    On macOS 10.10, AppKit appears to use the test's generated events to
    asynchronously reactivate the first window. There's no way to tell when this
    asynchronous reactivation will happen, so just avoid checking the assertion in
    the test. This problem appears constrained to how we generate test events, and
    not to the actual behavior of Chrome.
    
    Bug: 862859
    Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063
    Reviewed-on: https://chromium-review.googlesource.com/1135305
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574699}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc