Home | Search | chromium - Builders
Login

Builder Android FYI Release (NVIDIA Shield TV) Build 4809 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf448a241361b03dd2b6fd21ab052774e1074fdf1
Got Revisionf448a241361b03dd2b6fd21ab052774e1074fdf1

Execution:

Steps and Logfiles:

Show:
  1. ( 279 ms ) setup_build
    running recipe: "chromium"
  2. ( 1 secs ) remove .cipd
  3. ( 50 secs ) bot_update
    [67GB/295GB used (22%)]
  4. ( 0 ) ensure_goma
  5. ( 767 ms ) swarming.py --version
    0.13
  6. ( 11 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.gpu.fyi.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.gpu.fyi.json
  8. ( 4 secs ) clean local files
  9. ( 2 secs ) tree truth steps
  10. ( 27 secs ) generate_build_files
  11. ( 3 mins 43 secs ) compile
  12. ( 19 secs ) isolate tests
  13. ( 667 ms ) find isolated tests
  14. ( 0 ) test_pre_run
  15. ( 2 secs ) angle_end2end_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Shard duration: 0:03:29.823620
  16. ( 3 secs ) angle_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Shard duration: 0:02:58.554010
  17. ( 1 secs ) gl_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Shard duration: 0:01:11.019630
  18. ( 1 secs ) gl_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Shard duration: 31s
  19. ( 3 secs ) gpu_unittests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Shard duration: 0:02:45.689150
  20. ( 28 secs ) angle_perftests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 13s
    Shard duration: 57s
    Total tests: n/a
     
  21. ( 1 mins 41 secs ) context_lost_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 20s
    Shard duration: 0:02:29.427180
    Total tests: 8
    * Passed: 5 (5 expected, 0 unexpected)
    * Skipped: 3 (3 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  22. ( 1 secs ) depth_capture_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 26s
    Shard duration: 0:01:46.992140
    Total tests: 3
    * Passed: 3 (3 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 47 secs ) gpu_process_launch_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 25s
    Shard duration: 0:03:17.325260
    Total tests: 15
    * Passed: 15 (15 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 secs ) hardware_accelerated_feature_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 26s
    Shard duration: 0:01:45.878640
    Total tests: 2
    * Passed: 2 (2 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  25. ( 1 secs ) info_collection_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 37s
    Shard duration: 0:01:37.759740
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  26. ( 9 secs ) maps_pixel_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:02:03.464860
    Shard duration: 0:01:53.528370
    Total tests: 1
    * Passed: 1 (1 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 3 mins 12 secs ) pixel_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:02:17.536950
    Shard duration: 0:04:51.408060
    Total tests: 46
    * Passed: 36 (36 expected, 0 unexpected)
    * Skipped: 10 (10 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  28. ( 1 secs ) screenshot_sync_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:02:16.854670
    Shard duration: 0:02:14.055460
    Total tests: 4
    * Passed: 4 (4 expected, 0 unexpected)
    * Skipped: 0 (0 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 secs ) trace_test on Android device NVIDIA Shield
    Run on OS: 'Android'
    Pending time: 0:03:06.947560
    Shard duration: 0:03:07.574000
    Total tests: 34
    * Passed: 17 (17 expected, 0 unexpected)
    * Skipped: 17 (17 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 4 mins 29 secs ) webgl_conformance_tests on Android device NVIDIA Shield
    Run on OS: 'Android'
    Max pending time: 0:07:12.569840 (shard #5)
    Max shard duration: 0:05:05.079700 (shard #2)
    Min shard duration: 0:03:45.295200 (shard #3)
    Total tests: 922
    * Passed: 917 (917 expected, 0 unexpected)
    * Skipped: 5 (5 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  31. ( 326 ms ) Tests statistics
     
    Stats
    Total shards: 21
    Total runtime: 0:56:42.604640
     
  32. ( 386 ms ) test_report
  33. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm571-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531412100357160, "id": "8941191741414218320", "project": "chromium", "tags": ["builder:Android FYI Release (NVIDIA Shield TV)", "buildset:commit/git/f448a241361b03dd2b6fd21ab052774e1074fdf1", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f448a241361b03dd2b6fd21ab052774e1074fdf1", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106621803965762080", "scheduler_job_id:chromium/Android FYI Release (NVIDIA Shield TV)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android FYI Release (NVIDIA Shield TV)" setup_build
buildnumber 4809 setup_build
mastername "chromium.gpu.fyi" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f448a241361b03dd2b6fd21ab052774e1074fdf1" setup_build
got_angle_revision "9ff9c7732a8731cac249127ee68f1f5f02d8eb63" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "f448a241361b03dd2b6fd21ab052774e1074fdf1" bot_update
got_revision_cp "refs/heads/master@{#574585}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
swarm_hashes_refs/heads/master(at){#574585}_without_patch {"angle_end2end_tests": "2d0257715d2dd4ac19fdf488cd70fc6e2ae4f5a4", "angle_perftests": "9ac55a6550a5704d882dd56820d61eadfda8668f", "angle_unittests": "a49458c138b9606563738df61e5befc8127a165d", "gl_tests": "87607816b8274cac65258608661a750918ce6cd8", "gl_unittests": "33fba9530d63018381b867c328b6bca0474ea247", "gpu_unittests": "0a698f3c1d09547d4d92e8c3dbaad57c69f77331", "telemetry_gpu_integration_test": "adece230fd137374de801c827a92ad053b8d2c8a"} isolate tests
swarm_hashes {"angle_end2end_tests": "2d0257715d2dd4ac19fdf488cd70fc6e2ae4f5a4", "angle_perftests": "9ac55a6550a5704d882dd56820d61eadfda8668f", "angle_unittests": "a49458c138b9606563738df61e5befc8127a165d", "gl_tests": "87607816b8274cac65258608661a750918ce6cd8", "gl_unittests": "33fba9530d63018381b867c328b6bca0474ea247", "gpu_unittests": "0a698f3c1d09547d4d92e8c3dbaad57c69f77331", "telemetry_gpu_integration_test": "adece230fd137374de801c827a92ad053b8d2c8a"} find isolated tests

Blamelist:

  1. Peter Kasting (pkastingohnoyoudont@chromium.org)
  2. Fabio Tirelo (ftireloohnoyoudont@chromium.org)
  3. Devlin Cronin (rdevlin.croninohnoyoudont@chromium.org)
  4. Chris Lu (thegreenfrogohnoyoudont@chromium.org)
  5. Dave Tapuska (dtapuskaohnoyoudont@chromium.org)
  6. Peter Wen (wnwenohnoyoudont@chromium.org)
  7. Xida Chen (xidachenohnoyoudont@chromium.org)
  8. Daniel Bratell (bratellohnoyoudont@opera.com)
  9. Danyao Wang (danyaoohnoyoudont@chromium.org)
  10. Stephen Lanham (slanohnoyoudont@google.com)
  11. Sujie Zhu (sujiezhuohnoyoudont@google.com)

Timing:

Create Thursday, 12-Jul-18 16:15:00 UTC
Start Thursday, 12-Jul-18 16:15:06 UTC
End Thursday, 12-Jul-18 16:33:50 UTC
Pending 6 secs
Execution 18 mins 43 secs

All Changes:

  1. Remove NewTabButton::GetVisibleBounds().

    Changed by Peter Kasting - pkastingohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f448a241361b03dd2b6fd21ab052774e1074fdf1

    Comments

    Remove NewTabButton::GetVisibleBounds().
    
    This was a computed by constructing the border path and computing the bounding
    box.  However, it was only used for the ink drop, and ink drops are only used in
    newer material mode, where the border path is a square.
    
    Instead, we can use GetContentsBounds(), as long as those are actually
    positioned correctly.  The new tab button has empty space at the top, which is
    included (by the tabstrip) in its size and accounted for when doing painting and
    hittesting.  By adding an empty top border of this thickness, a lot of this code
    can be simplified.  (Further simplifications are coming in a subsequent CL.)
    
    Bug: none
    Change-Id: I431c6100d45b7f92a0ab1c9ed9f81f8fab436ebe
    Reviewed-on: https://chromium-review.googlesource.com/1134399
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574585}

    Changed files

    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/new_tab_button.h
    • chrome/browser/ui/views/tabs/tab_strip.cc
  2. [AF] Use views::Separator in the Autofill dropdown

    Changed by Fabio Tirelo - ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:13:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ff6fb086724fb3cd20409d3e72065bbd4a84abd

    Comments

    [AF] Use views::Separator in the Autofill dropdown
    
    This is a follow-up of crrev.com/c/1131680 and replace a custom view
    to simulate a separator with a views::Separator view.
    
    Change-Id: I0dc1db9c31039ce0959fa4aa4d37e4e99745a2d1
    Reviewed-on: https://chromium-review.googlesource.com/1133328
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574584}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  3. [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests

    Changed by Devlin Cronin - rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:11:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b35e9edf0aed36764ee35db8ed9e66466bb18249

    Comments

    [Extensions Cleanup] Clean up ScriptingPermissionsModifier unittests
    
    Remove a redundant URLPatternSet comparison method from
    ScriptingPermissionsModifier unittests, instead leveraging the
    string comparison and gmock utilities. These are slightly less code
    and offer better failure messages.
    
    Bug: None
    
    Change-Id: Ic8b99f0c9294658d6bdd16738f179a2e352eb408
    Reviewed-on: https://chromium-review.googlesource.com/1134496
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574583}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
  4. [ios] Set favicon fallback style for UI Refresh for ReadingList

    Changed by Chris Lu - thegreenfrogohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:05:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eeff01fbfa506b55fc9f1c0126c618a788015a4

    Comments

    [ios] Set favicon fallback style for UI Refresh for ReadingList
    
    - Sets the fallback monogram and background colors to a constant color.
    
    Collections flag off screenshot: https://drive.google.com/file/d/10fYA9oHwx_o3cGWXBSR5P4qXKIPDTcfm/view?usp=sharing
    Collections flag on screenshot: https://drive.google.com/file/d/1WtAYb-fPE6QdR4rIpcWxuZtLjGr7iPNQ/view?usp=sharing
    
    Bug: 851390
    
    Change-Id: I7d67a4129263b2deed52eb7603b3f84aa8b8a201
    Reviewed-on: https://chromium-review.googlesource.com/1125271
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574582}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
  5. Enable StaleWhileRevalidate in experimental features.

    Changed by Dave Tapuska - dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc2f58c6417a00888317b79f40fd904b1f6628b

    Comments

    Enable StaleWhileRevalidate in experimental features.
    
    To gather some stability enable it for experimental features before
    we do the origin trial.
    
    BUG=348877
    
    Change-Id: I7598f35ac87b719305c6efa98c37de2eec8031a4
    Reviewed-on: https://chromium-review.googlesource.com/1134883
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574581}

    Changed files

    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  6. Android: Default to full instead of fast

    Changed by Peter Wen - wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:04:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c98d04f201c356e8c4e811f3a43afa5c264750c

    Comments

    Android: Default to full instead of fast
    
    Switch from --full being optional to --fast being optional. Quite a few
    users of generate_gradle.py have found it unintuitive to have red
    underlines by default.
    
    Bug: 620034
    Change-Id: I24a19e16ed21baa19bde97bb2f3077430a73d148
    Reviewed-on: https://chromium-review.googlesource.com/1134882
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574580}

    Changed files

    • build/android/gradle/generate_gradle.py
  7. [Code health] Disable TouchActionBrowserTests on Debug and *San bots

    Changed by Xida Chen - xidachenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:02:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da109c8fd1b66a54c514b3012c29ebb232c113e9

    Comments

    [Code health] Disable TouchActionBrowserTests on Debug and *San bots
    
    These tests are flaky on Debug builds and *San bots. These tests sends
    synthetic gesture event and measure scroll offset. It should be fine
    without coverages on Debug and *San builds.
    
    TBR=sahel@chromium.org, tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
    Reviewed-on: https://chromium-review.googlesource.com/1135195
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574579}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  8. [jumbo] Deduplicate a time constant in autofill code

    Changed by Daniel Bratell - bratellohnoyoudont@opera.com
    Changed at Thursday, 12-Jul-18 16:01:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a742e15951f4e95d609b6628fc486a88b4fe0df

    Comments

    [jumbo] Deduplicate a time constant in autofill code
    
    Two different bubbles needed the same time constant and when
    they got copies of the constant that broke certain jumbo
    builds. This merges the constants to a single constant.
    
    It also changes type to base::TimeDelta which is the actual
    type needed and since the addition of constexpr can be used
    in global constants.
    
    Bug: 852904,862397
    Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
    Reviewed-on: https://chromium-review.googlesource.com/1134998
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574578}

    Changed files

    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/popup_constants.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
  9. Revert "[Nav Experiment] Add a wait after restore session."

    Changed by Danyao Wang - danyaoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:01:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e33b9da8d371a25857c422d277115441c629ce5

    Comments

    Revert "[Nav Experiment] Add a wait after restore session."
    
    This reverts commit bcae87b0c7618e2fc61f78a073cf5589fe9679bd.
    
    Reason for revert: This didn't actually fix the problem and
    I didn't catch it due to a mistake in testing. The real
    problem is that the restore_session request started in 
    WKBasedNavigationManager::Restore() was not run, because
    |_containerView| is not yet initiated in the new CWVWebView.
    
    Original change's description:
    > [Nav Experiment] Add a wait after restore session.
    > 
    > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    > enabled. A better approach would be to turn this test into a
    > programmatic test so both navigation managers implementations are
    > tested, but web::features symbols are not exposed in ios/web_view.
    > 
    > Bug: 862714
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    > Reviewed-on: https://chromium-review.googlesource.com/1134046
    > Reviewed-by: Eugene But <eugenebut@chromium.org>
    > Commit-Queue: Danyao Wang <danyao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574367}
    
    TBR=eugenebut@chromium.org,danyao@chromium.org
    
    Change-Id: Ia9d2d127e18264fbf69786c58b71706e0b34ead5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1135346
    Reviewed-by: Danyao Wang <danyao@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574577}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  10. [Chromecast] Use MobileScoller on Cast Android builds.

    Changed by Stephen Lanham - slanohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:00:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef77d4afc3b73eb7fc96dff1908164994b4a82

    Comments

    [Chromecast] Use MobileScoller on Cast Android builds.
    
    This class was renamed from Scroller here: crrev.com/c/1087641. Update the
    conditionals so that Scroller is only used on non-Android Cast builds,
    and MobileScroller is used on Android Cast builds.
    
    Bug: internal b/111287588
    Test: Compiles
    
    Change-Id: I19dc01e1339016e3db2ab3b7d81a95efc5c6a0f3
    Reviewed-on: https://chromium-review.googlesource.com/1133761
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574576}

    Changed files

    • ui/events/gestures/blink/web_gesture_curve_impl.cc
  11. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type

    Changed by Sujie Zhu - sujiezhuohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 15:56:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdb64db76a187df14e07aa31daccedb1813ffb8e

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reuse, we change the bool variable to an enum to represent the type of the imported credit card.
    
    Since the ImportCreditCard is not always called in the ImportFormData, so we reset the imported_credit_card_record_type in ImportFormData so that every time we try to import from form, the imported_credit_card_record_type is reset. Also, to test the reset, we use ImportFormData instead of directly using ImportCreditCard in the unittest.
    
    In this CL, we add unittest for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I01191cb8a9d0a3bf954874e6c8beb62d3b02c1ea
    Reviewed-on: https://chromium-review.googlesource.com/1134388
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574575}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc