Builder Android FYI 64 dEQP Vk Release (Pixel 2) Build 19712
Results:
Success
Trigger Info:
Project | chromium |
Revision | 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13 |
Got Revision | 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13 |
Execution:
- Source: Task 40818a7ffc7f9410
- Bot: swarm2420-c4
Steps and Logfiles:
Show:-
( 106751 days 23 hrs ) Failed to fetch step information from LogDogLog stream has no annotation entries
- - no logs -
Build Properties:
Name | Value | Source |
---|
Blamelist:
- Tanja Gornak (melandoryohnoyoudont@chromium.org)
Timing:
Create | Friday, 12-Oct-18 14:40:43 UTC |
Start | Friday, 12-Oct-18 14:40:48 UTC |
End | Friday, 12-Oct-18 14:43:25 UTC |
Pending | 4 secs |
Execution | 2 mins 36 secs |
All Changes:
-
[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering.
Changed by Tanja Gornak - melandoryohnoyoudont@chromium.org Changed at Friday, 12-Oct-18 14:39:54 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 5c8b5d95aa88a6898b52ed9ad9843d4c0ba4ff13 Comments
[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. * The service shouldn't unregister from the topics, when handler the Handler is unregistering from topic (as stated in the documentation for for UnregisterHandler). * Sync shouldn't unregister on browser shutdown TBR=gab@chromium.org, pavely@chromium.org Bug: 894752, 801985 Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76 Reviewed-on: https://chromium-review.googlesource.com/c/1277908 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#599206}
Changed files
- chrome/browser/prefs/browser_prefs.cc
- components/invalidation/impl/BUILD.gn
- components/invalidation/impl/fcm_fake_invalidator.cc
- components/invalidation/impl/fcm_invalidation_listener.cc
- components/invalidation/impl/fcm_invalidation_listener.h
- components/invalidation/impl/fcm_invalidation_service.cc
- components/invalidation/impl/fcm_invalidation_service.h
- components/invalidation/impl/fcm_invalidation_service_unittest.cc
- components/invalidation/impl/invalidator_registrar.cc
- components/invalidation/impl/invalidator_registrar.h
- components/invalidation/impl/invalidator_registrar_with_memory.cc
- components/invalidation/impl/invalidator_registrar_with_memory.h
- components/invalidation/public/invalidation_util.h
- components/sync/driver/glue/sync_backend_host_impl.cc