Home | Search | chromium - Builders
Login

Builder Android Cronet Builder Build 54526 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf947cd08cce8175e8486d9543713a16589d47589
Got Revisionf947cd08cce8175e8486d9543713a16589d47589

Execution:

Steps and Logfiles:

Show:
  1. ( 313 ms ) setup_build
    running recipe: "chromium"
  2. ( 219 ms ) report builders
     
    running builder 'Android Cronet Builder' on master 'chromium.android'
  3. ( 25 secs ) bot_update
    [81GB/295GB used (27%)]
  4. ( 1 secs ) swarming.py --version
    0.13
  5. ( 2 secs ) clobber
  6. ( 11 secs ) gclient runhooks
  7. ( 1 secs ) read test spec (chromium.android.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.android.json
  8. ( 3 secs ) clean local files
  9. ( 84 ms ) tree truth steps
  10. ( 486 ms ) lookup GN args
     
    Count of GN args (23) exceeds limit (15), presented in logs instead
  11. ( 12 secs ) generate_build_files
  12. ( 3 mins 18 secs ) compile

Build Properties:

NameValueSource
$build/goma {"jobs": 150} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm377-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1541786847771466, "id": "8930313030270045040", "project": "chromium", "tags": ["builder:Android Cronet Builder", "buildset:commit/git/f947cd08cce8175e8486d9543713a16589d47589", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/f947cd08cce8175e8486d9543713a16589d47589", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095743092649697184", "scheduler_job_id:chromium/Android Cronet Builder", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android Cronet Builder" setup_build
buildnumber 54526 setup_build
mastername "chromium.android" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "f947cd08cce8175e8486d9543713a16589d47589" setup_build
got_angle_revision "5d2dfa46c05c8c661304922ce1e1e7d7b045a342" bot_update
got_buildtools_revision "13a00f110ef910a25763346d6538b60f12845656" bot_update
got_dawn_revision "2960ec33667a11bb4445dfe8154aef133c741afe" bot_update
got_nacl_revision "99673869a3cd8731d924bd32fa486feebfdc6c4f" bot_update
got_revision "f947cd08cce8175e8486d9543713a16589d47589" bot_update
got_revision_cp "refs/heads/master@{#606898}" bot_update
got_swarming_client_revision "f78187ab77127de42555afe0ad410bebde6ac6a5" bot_update
got_v8_revision "f6ed3c5d7eb73112326476d681f0f79d40fc1e0e" bot_update
got_v8_revision_cp "refs/heads/7.2.287@{#1}" bot_update
got_webrtc_revision "e769ed90c3599a131166d5a61625c1b64318fb91" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25544}" bot_update

Blamelist:

  1. Yi Su (mrsuyiohnoyoudont@chromium.org)

Timing:

Create Friday, 09-Nov-18 18:07:27 UTC
Start Friday, 09-Nov-18 18:07:30 UTC
End Friday, 09-Nov-18 18:12:22 UTC
Pending 2 secs
Execution 4 mins 52 secs

All Changes:

  1. Let SearchEngineTabHelper extend FaviconDriverObserver to update the favicon in TemplateURLService.

    Changed by Yi Su - mrsuyiohnoyoudont@chromium.org
    Changed at Friday, 09-Nov-18 18:02:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f947cd08cce8175e8486d9543713a16589d47589

    Comments

    Let SearchEngineTabHelper extend FaviconDriverObserver to update the favicon in TemplateURLService.
    
    This CL let iOS SearchEngineTabHelper extend FaviconDriverObserver so that
    it has equivalent functionality as the SearchEngineTabHelper in
    /chrome/browser/ui/search_engines.
    
    Bug: 433824
    Change-Id: If49d1b46d90b2250c2b378d77d9e3cea5cdd96a5
    Reviewed-on: https://chromium-review.googlesource.com/c/1329171
    Commit-Queue: Yi Su <mrsuyi@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#606898}

    Changed files

    • ios/chrome/browser/search_engines/BUILD.gn
    • ios/chrome/browser/search_engines/search_engine_tab_helper.h
    • ios/chrome/browser/search_engines/search_engine_tab_helper.mm
    • ios/chrome/browser/search_engines/search_engine_tab_helper_unittest.mm
    • ios/chrome/browser/tabs/tab_helper_util.mm