Home | Search | chromium - Builders
Login

Builder Android CFI Build 3261 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisiond1df3c494cc8dc1ef26ec3514b74b27c3047a4db
Got Revisiond1df3c494cc8dc1ef26ec3514b74b27c3047a4db

Execution:

Steps and Logfiles:

Show:
  1. ( 364 ms ) setup_build
    running recipe: "chromium"
  2. ( 777 ms ) report builders
     
    running builder/tester 'Android CFI' on master 'chromium.memory'
  3. ( 5 mins 15 secs ) bot_update
    [102GB/295GB used (34%)]
  4. ( 2 secs ) swarming.py --version
    0.13
  5. ( 40 secs ) gclient runhooks
  6. ( 922 ms ) read test spec (chromium.memory.json)
    path: /b/swarming/w/ir/cache/builder/src/testing/buildbot/chromium.memory.json
  7. ( 3 mins 57 secs ) clean local files
  8. ( 1 secs ) tree truth steps
  9. ( 529 ms ) lookup GN args
     
    dcheck_always_on = true
    ffmpeg_branding = "Chrome"
    is_cfi = true
    is_component_build = false
    is_debug = false
    proprietary_codecs = true
    strip_absolute_paths_from_debug_symbols = true
    target_os = "android"
    use_cfi_cast = true
    use_cfi_diag = true
    use_goma = true
    use_thin_lto = true
    goma_dir = "/b/swarming/w/ir/cache/goma/client"
  10. ( 36 secs ) generate_build_files
  11. ( 1 hrs 20 mins ) compile
  12. ( 3 secs ) compile confirm no-op
    This should have been a no-op, but it wasn't.
  13. ( 2 mins 9 secs ) isolate tests
  14. ( 395 ms ) find isolated tests
  15. ( 17 secs ) android_webview_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:02.708371
  16. ( 5 secs ) angle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:19.582585
  17. ( 4 secs ) base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:59.590781
  18. ( 2 secs ) blink_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  19. ( 17 secs ) blink_heap_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:41.482778
  20. ( 48 secs ) blink_platform_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:28.778419
  21. ( 2 secs ) boringssl_crypto_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:35.569876
  22. ( 2 secs ) boringssl_ssl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  23. ( 2 secs ) breakpad_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 25s
  24. ( 2 secs ) cacheinvalidation_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  25. ( 2 secs ) capture_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:24.862408
  26. ( 2 secs ) cast_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:36.932003
  27. ( 4 secs ) cc_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:24.275312
  28. ( 5 mins 25 secs ) chrome_sync_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:09:20.299660
  29. ( 2 secs ) components_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:15.690632
  30. ( 2 secs ) perfetto_content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:33.178239
  31. ( 2 secs ) crypto_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  32. ( 2 secs ) device_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:26.765290
  33. ( 2 secs ) display_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 40s
  34. ( 2 secs ) events_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 51s
  35. ( 2 secs ) gcm_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:08.715065
  36. ( 4 secs ) gfx_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:03:25.111130
  37. ( 2 secs ) gin_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 55s
  38. ( 2 secs ) gl_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:19.311048
  39. ( 2 secs ) gl_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  40. ( 2 secs ) google_apis_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:52.859309
  41. ( 4 secs ) gpu_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:47.384536
  42. ( 2 secs ) ipc_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 45s
  43. ( 2 secs ) jingle_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:03.191640
  44. ( 2 secs ) latency_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 42s
  45. ( 2 secs ) libjingle_xmpp_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 53s
  46. ( 3 secs ) media_blink_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:16.959645
  47. ( 2 secs ) media_service_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 46s
  48. ( 6 secs ) media_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:05:48.367603
  49. ( 2 secs ) midi_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  50. ( 2 secs ) mojo_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:02:30.195994
  51. ( 2 secs ) mojo_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:58.965729
  52. ( 2 secs ) sandbox_linux_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 39s
  53. ( 4 secs ) services_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:04:58.413792
  54. ( 2 secs ) shell_dialogs_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  55. ( 1 secs ) skia_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 43s
  56. ( 2 secs ) sql_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 47s
  57. ( 2 secs ) storage_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:40.140980
  58. ( 2 secs ) ui_android_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 42s
  59. ( 2 secs ) ui_base_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:13.371451
  60. ( 2 secs ) ui_touch_selection_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 40s
  61. ( 2 secs ) url_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 41s
  62. ( 2 secs ) viz_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:21.842116
  63. ( 2 secs ) vr_common_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:52.304188
  64. ( 2 secs ) vr_pixeltests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 0:01:58.791496
  65. ( 2 secs ) wtf_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Shard duration: 48s
  66. ( 2 mins 11 secs ) chrome_public_test_vr_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:13:55.578747 (shard #1)
    Min shard duration: 0:13:17.690548 (shard #0)
  67. ( 1 mins 22 secs ) webkit_unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:15:14.177273 (shard #0)
    Min shard duration: 0:13:33.608949 (shard #1)
  68. ( 3 secs ) content_shell_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:09:54.988892 (shard #1)
    Min shard duration: 0:09:25.576353 (shard #0)
  69. ( 6 secs ) content_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:06:42.243264 (shard #0)
    Min shard duration: 0:06:29.603275 (shard #2)
  70. ( 30 secs ) net_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:13:40.064746 (shard #1)
    Min shard duration: 0:12:15.572799 (shard #2)
  71. ( 12 secs ) components_unittests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:08:45.704546 (shard #3)
    Min shard duration: 0:08:18.438692 (shard #1)
  72. ( 9 secs ) webview_instrumentation_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:12:02.788367 (shard #2)
    Min shard duration: 0:09:49.976689 (shard #3)
  73. ( 4 mins 52 secs ) content_browsertests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:21:21.146963 (shard #1)
    Min shard duration: 0:15:13.908412 (shard #8)
  74. ( 5 secs ) unit_tests on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:12:05.647906 (shard #8)
    Min shard duration: 0:09:18.176158 (shard #5)
  75. ( 40 secs ) chrome_public_test_apk on Android device Nexus 5X
    Run on OS: 'Android'
    Max shard duration: 0:21:48.604107 (shard #17)
    Min shard duration: 0:12:31.393475 (shard #10)
  76. ( 254 ms ) Tests statistics
     
    Stats
    Total shards: 114
    Total runtime: 14:53:32.538953
     
  77. ( 688 ms ) test_report
  78. ( 1 ms ) recipe result

Build Properties:

NameValueSource
$build/goma {"jobs": 500} setup_build
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm786-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1539347599837847, "id": "8932870767111845184", "project": "chromium", "tags": ["builder:Android CFI", "buildset:commit/git/d1df3c494cc8dc1ef26ec3514b74b27c3047a4db", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/d1df3c494cc8dc1ef26ec3514b74b27c3047a4db", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9098300829390309136", "scheduler_job_id:chromium/Android CFI", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "Android CFI" setup_build
buildnumber 3261 setup_build
mastername "chromium.memory" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "d1df3c494cc8dc1ef26ec3514b74b27c3047a4db" setup_build
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" bot_update
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" bot_update
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" bot_update
got_revision "d1df3c494cc8dc1ef26ec3514b74b27c3047a4db" bot_update
got_revision_cp "refs/heads/master@{#599182}" bot_update
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" bot_update
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" bot_update
got_v8_revision_cp "refs/heads/7.1.302@{#1}" bot_update
got_webrtc_revision "28d200c24624f0f2ce3013e33effc4ffc123cc2c" bot_update
got_webrtc_revision_cp "refs/heads/master@{#25136}" bot_update
swarm_hashes_refs/heads/master(at){#599182}_without_patch {"android_webview_unittests": "39681140055e51b1bb3919b33d664fbac4ef9758", "angle_unittests": "4c1a5efd702d261dba84b1a86fe1720ee9fb2986", "base_unittests": "d4a56ec383de3e075891bdb466e539be0ebc1ec5", "blink_common_unittests": "a974380977c69ada551f53a86e1780aa4964c011", "blink_heap_unittests": "eb9e45e90b8075851663881afe7661e7820d81f5", "blink_platform_unittests": "e4dff3e60dd44b240a86f1fa38b684d0cf16c0c6", "boringssl_crypto_tests": "94817dc6688f5ac33345dc25cfa7046b19010f5c", "boringssl_ssl_tests": "e43b227bebb8a302fbb268699b2120320f20aff5", "breakpad_unittests": "f05a7bca4fb9da851cfb9a6d7c3d9eb730f145b5", "cacheinvalidation_unittests": "378f03775fdeaf681d41ce661e88532ecf32f2bb", "capture_unittests": "808c2a91d4ecdc5754acb7fdfd7ae2d3449177a1", "cast_unittests": "9d77f650ae6d884477306f8746413ee5149ca7a4", "cc_unittests": "6aab0c2f61261e953e07197636a22ae24a50b9d1", "chrome_public_test_apk": "39bbfc3c81bab8f21bae1e3ac9c9b76c6019a89a", "chrome_public_test_vr_apk": "6094444eb6de0ad227e403e0e9d380eb61d25d43", "chrome_sync_shell_test_apk": "a2e2de5d1b8c1b9f1cdebd1ffea5a494a08e138a", "components_browsertests": "42ba931230bb3fbd25823326fd52b67a5c27590f", "components_unittests": "874f03b6fb6417ef15639efbd3eb5e220e5983d3", "content_browsertests": "bd2ae5cbb80b4816e7606feb29fefa88c5a61f6c", "content_shell_test_apk": "fb34c1a92e8a4e5445cdce2b48eceea35e7b4d7d", "content_unittests": "ff9c566431ad217eac25c87ccba2b22dfa85d82e", "crypto_unittests": "ad487b72d6e4a8533298f819f40a8032d7d6a67d", "device_unittests": "01fea4409fa16ff601bf1eb3837835413adeacfc", "display_unittests": "c609c745c251f50546261d537989e8d461450afd", "events_unittests": "a7663a581828e6b46c37e1ffe56ac296d51c4f8b", "gcm_unit_tests": "beb877294ad00d5d551ec56eb6898fd85663fa6d", "gfx_unittests": "179138453bdb3743943c36151e2d698927554f44", "gin_unittests": "82b14c7f0fb8688ea9f604023633969eb8f84101", "gl_tests": "37bbf77ddc537a521f7f61f4ca22aae55a0f8a6a", "gl_unittests": "5d9289f40dde41ca97a87f9f8d6837f78e24504b", "google_apis_unittests": "7d404eb91e21becd7ac9c972e290fae71102080b", "gpu_unittests": "831c12e49c25eb05052934e05c607b161e4b2100", "ipc_tests": "97c458dd49a7d47157060125a8ed82676c93f5d1", "jingle_unittests": "3f6ae896de4436d3468fa6f70c87fbe6d762ef89", "latency_unittests": "dc6e179384a6012733c7b110fb2c411ec1d7e651", "libjingle_xmpp_unittests": "2cbdaa365d53fe11ef03179cd782ab8dc9adfda8", "media_blink_unittests": "057fdc82544ef797d24ced4c2a42eb164a57d5f5", "media_service_unittests": "e08b7234f065044cea024b67ff2cd9feda996550", "media_unittests": "52dc4f511ecc60ef82ea38c5d6f0da7be170a253", "midi_unittests": "5a663dd7ca579a002ca28757952aee326eb6817c", "mojo_test_apk": "c7f0cb5c915078bf88c6c2a88767f90c0fa9e079", "mojo_unittests": "fd04373f4d8de0bad0719ba47ec29d6665adee77", "net_unittests": "5beab5f11aecff799a908fbca42e8f71e91f6db9", "sandbox_linux_unittests": "6f0099cf790918bc726b34e6f75759c1ead3893e", "services_unittests": "a2d2acce80a36ae34e15633a4f2017fa8be9cbbe", "shell_dialogs_unittests": "3623716b50c58df897810c4a6ca971e7d33e4783", "skia_unittests": "8acb740c716605fad6eaeb459d2e70579d66055c", "sql_unittests": "85bc0bdf42aab8b86fc1fdb6b03539ca2ff58b0e", "storage_unittests": "6070ce6080699207030b20bac21333583a16e538", "ui_android_unittests": "1a048b1d7e029ea3c939e83f1fd7f241430325c7", "ui_base_unittests": "dcd338eef38636f2592cd73a9efc8ac5ca828491", "ui_touch_selection_unittests": "bc0662c6351f728166abc179ab7435d65ecfe57a", "unit_tests": "49da7bc11317330237df7986850c9a3f82a8d285", "url_unittests": "af63f01ea98b4cd3023ff20ce4bd6687333da011", "viz_unittests": "823abcdef575600d35a6da6b61271d7aebf94015", "vr_common_unittests": "4144a6c05b70e48d7483a74a1ca9691ca41fb627", "vr_pixeltests": "18f286a7abf9445801caf4423135582992208fcd", "webkit_unit_tests": "66436ccacea43581e9c1933e26290e04afa22393", "webview_instrumentation_test_apk": "7b683a586a5486458b0d0b8c8e8432874ad0bbbd", "wtf_unittests": "9dc59efe32a7cce46eac9add2eb440a95d58763f"} isolate tests
swarm_hashes {"android_webview_unittests": "39681140055e51b1bb3919b33d664fbac4ef9758", "angle_unittests": "4c1a5efd702d261dba84b1a86fe1720ee9fb2986", "base_unittests": "d4a56ec383de3e075891bdb466e539be0ebc1ec5", "blink_common_unittests": "a974380977c69ada551f53a86e1780aa4964c011", "blink_heap_unittests": "eb9e45e90b8075851663881afe7661e7820d81f5", "blink_platform_unittests": "e4dff3e60dd44b240a86f1fa38b684d0cf16c0c6", "boringssl_crypto_tests": "94817dc6688f5ac33345dc25cfa7046b19010f5c", "boringssl_ssl_tests": "e43b227bebb8a302fbb268699b2120320f20aff5", "breakpad_unittests": "f05a7bca4fb9da851cfb9a6d7c3d9eb730f145b5", "cacheinvalidation_unittests": "378f03775fdeaf681d41ce661e88532ecf32f2bb", "capture_unittests": "808c2a91d4ecdc5754acb7fdfd7ae2d3449177a1", "cast_unittests": "9d77f650ae6d884477306f8746413ee5149ca7a4", "cc_unittests": "6aab0c2f61261e953e07197636a22ae24a50b9d1", "chrome_public_test_apk": "39bbfc3c81bab8f21bae1e3ac9c9b76c6019a89a", "chrome_public_test_vr_apk": "6094444eb6de0ad227e403e0e9d380eb61d25d43", "chrome_sync_shell_test_apk": "a2e2de5d1b8c1b9f1cdebd1ffea5a494a08e138a", "components_browsertests": "42ba931230bb3fbd25823326fd52b67a5c27590f", "components_unittests": "874f03b6fb6417ef15639efbd3eb5e220e5983d3", "content_browsertests": "bd2ae5cbb80b4816e7606feb29fefa88c5a61f6c", "content_shell_test_apk": "fb34c1a92e8a4e5445cdce2b48eceea35e7b4d7d", "content_unittests": "ff9c566431ad217eac25c87ccba2b22dfa85d82e", "crypto_unittests": "ad487b72d6e4a8533298f819f40a8032d7d6a67d", "device_unittests": "01fea4409fa16ff601bf1eb3837835413adeacfc", "display_unittests": "c609c745c251f50546261d537989e8d461450afd", "events_unittests": "a7663a581828e6b46c37e1ffe56ac296d51c4f8b", "gcm_unit_tests": "beb877294ad00d5d551ec56eb6898fd85663fa6d", "gfx_unittests": "179138453bdb3743943c36151e2d698927554f44", "gin_unittests": "82b14c7f0fb8688ea9f604023633969eb8f84101", "gl_tests": "37bbf77ddc537a521f7f61f4ca22aae55a0f8a6a", "gl_unittests": "5d9289f40dde41ca97a87f9f8d6837f78e24504b", "google_apis_unittests": "7d404eb91e21becd7ac9c972e290fae71102080b", "gpu_unittests": "831c12e49c25eb05052934e05c607b161e4b2100", "ipc_tests": "97c458dd49a7d47157060125a8ed82676c93f5d1", "jingle_unittests": "3f6ae896de4436d3468fa6f70c87fbe6d762ef89", "latency_unittests": "dc6e179384a6012733c7b110fb2c411ec1d7e651", "libjingle_xmpp_unittests": "2cbdaa365d53fe11ef03179cd782ab8dc9adfda8", "media_blink_unittests": "057fdc82544ef797d24ced4c2a42eb164a57d5f5", "media_service_unittests": "e08b7234f065044cea024b67ff2cd9feda996550", "media_unittests": "52dc4f511ecc60ef82ea38c5d6f0da7be170a253", "midi_unittests": "5a663dd7ca579a002ca28757952aee326eb6817c", "mojo_test_apk": "c7f0cb5c915078bf88c6c2a88767f90c0fa9e079", "mojo_unittests": "fd04373f4d8de0bad0719ba47ec29d6665adee77", "net_unittests": "5beab5f11aecff799a908fbca42e8f71e91f6db9", "sandbox_linux_unittests": "6f0099cf790918bc726b34e6f75759c1ead3893e", "services_unittests": "a2d2acce80a36ae34e15633a4f2017fa8be9cbbe", "shell_dialogs_unittests": "3623716b50c58df897810c4a6ca971e7d33e4783", "skia_unittests": "8acb740c716605fad6eaeb459d2e70579d66055c", "sql_unittests": "85bc0bdf42aab8b86fc1fdb6b03539ca2ff58b0e", "storage_unittests": "6070ce6080699207030b20bac21333583a16e538", "ui_android_unittests": "1a048b1d7e029ea3c939e83f1fd7f241430325c7", "ui_base_unittests": "dcd338eef38636f2592cd73a9efc8ac5ca828491", "ui_touch_selection_unittests": "bc0662c6351f728166abc179ab7435d65ecfe57a", "unit_tests": "49da7bc11317330237df7986850c9a3f82a8d285", "url_unittests": "af63f01ea98b4cd3023ff20ce4bd6687333da011", "viz_unittests": "823abcdef575600d35a6da6b61271d7aebf94015", "vr_common_unittests": "4144a6c05b70e48d7483a74a1ca9691ca41fb627", "vr_pixeltests": "18f286a7abf9445801caf4423135582992208fcd", "webkit_unit_tests": "66436ccacea43581e9c1933e26290e04afa22393", "webview_instrumentation_test_apk": "7b683a586a5486458b0d0b8c8e8432874ad0bbbd", "wtf_unittests": "9dc59efe32a7cce46eac9add2eb440a95d58763f"} find isolated tests

Blamelist:

  1. David Davidović (davidovicohnoyoudont@google.com)
  2. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  3. Florent Castelli (orphisohnoyoudont@chromium.org)
  4. Florent Castelli (orphisohnoyoudont@chromium.org)
  5. Colin Blundell (blundellohnoyoudont@chromium.org)
  6. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)
  7. Camille Lamy (clamyohnoyoudont@chromium.org)
  8. stkhapugin@chromium.org (stkhapuginohnoyoudont@chromium.org)
  9. Nico Weber (thakisohnoyoudont@chromium.org)
  10. Sergio Villar Senin (svillarohnoyoudont@igalia.com)
  11. Eliot Courtney (edcourtneyohnoyoudont@google.com)
  12. Rune Lillesveen (futharkohnoyoudont@chromium.org)
  13. Guido Urdaneta (guidouohnoyoudont@chromium.org)
  14. Chromium WPT Sync (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  15. Mihai Sardarescu (msardaohnoyoudont@chromium.org)
  16. Scott Wu (scottwuohnoyoudont@chromium.org)
  17. Laís Minchillo (laisminchilloohnoyoudont@chromium.org)
  18. Scott Wu (scottwuohnoyoudont@chromium.org)
  19. Anders Hartvoll Ruud (andruudohnoyoudont@chromium.org)

Timing:

Create Friday, 12-Oct-18 12:33:19 UTC
Start Friday, 12-Oct-18 12:34:07 UTC
End Friday, 12-Oct-18 14:33:17 UTC
Pending 48 secs
Execution 1 hrs 59 mins

All Changes:

  1. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by David Davidović - davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an integration test helper file for encryption-related tasks and modify
    > FakeServer and LoopbackServer to allow easier modification of persistent
    > entities such as Nigori. Add passphrase-related functionality to
    > ProfileSyncServiceHarness to give tests better control over how and when
    > passphrase-based encryption is enabled.
    >
    > The test uses a gray-box approach, where it tests the client at the
    > ProfileSyncService granularity, but injects and inspects entities on the (fake)
    > server to ensure that encryption is performed properly. This is necessary
    > because, when it comes to encryption, we are not interested merely in that it
    > does not hinder existing functionality (e.g. two clients are syncing data
    > properly in the presence of a custom passphrase), but also that it provides the
    > expected security to the user. For this reason, we use our knowledge of the
    > encryption architecture internals to ensure that the data committed to the
    > server is encrypted in the expected way.
    >
    > Bug: 894148
    > Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
    > Reviewed-on: https://chromium-review.googlesource.com/c/1274205
    > Commit-Queue: David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  2. Don't update style for focusability when render-blocking.

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  3. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is available, e.g on
    > preload.
    > 
    > The ClassicPendingScript now only sends one "finished" callback, from
    > ScriptResource. This callback is either when the streaming completes,
    > or when there is no streaming and the ClassicPendingScript has told
    > the ScriptResource that it doesn't intend to start streaming. In the
    > long run, we want all scripts to go through the streaming interface,
    > and we want ScriptResource to control when streaming starts, so the
    > "no more streaming" call will disappear -- however it is necessary to
    > maintain the current behaviour, and be able to control it with a
    > runtime flag.
    > 
    > Bug: chromium:865098
    > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
    > Reviewed-on: https://chromium-review.googlesource.com/c/1181430
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
    > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    > Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  4. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by Florent Castelli - orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  5. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides one such problematic case: it
    constructs and directly exposes these dependencies, which are then
    broadly used by a set of tests that consume this utility class.
    Converting all these tests in one go is not practical.
    
    This CL adds an alternate IdentityTestEnvironment constructor that
    takes in the dependencies and constructs IdentityManager via those
    passed-in dependencies. To enable this constructor, the CL also
    encapsulates the fact that IdentityTestEnvironment otherwise obtains
    these dependencies from an internal object within the current
    IdentityTestEnvironment constructor.  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  6. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  7. Create NavigationRequest from LoadURLParams

    Changed by Camille Lamy - clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
  8. Rename FaviconViewNew to FaviconView.

    Changed by stkhapugin@chromium.org - stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:48:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0363f71cf67554f24b21b299db6f9fcd11a33bf3

    Comments

    Rename FaviconViewNew to FaviconView.
    
    Since FaviconView name is not used anymore, it makes sense now.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I0549111a1ade2f8cc61664d1de07160c8687b6de
    Reviewed-on: https://chromium-review.googlesource.com/c/1278807
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599175}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
    • ios/chrome/common/favicon/favicon_view.h
    • ios/chrome/common/favicon/favicon_view.mm
    • ios/chrome/content_widget_extension/most_visited_tile_view.h
    • ios/chrome/content_widget_extension/most_visited_tile_view.mm
  9. win: Update deterministic build whitelist.

    Changed by Nico Weber - thakisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:47:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f097036d16ea6c259ef01ddd6967895ca5a28d04

    Comments

    win: Update deterministic build whitelist.
    
    symbol_level=1 builds seem to work now and the bot builds with it, so the
    entries for crashpad_snapshot_test_image_reader and
    crashpad_snapshot_test_image_reader_module.dll are no longer needed.
    
    mini_installer.exe now has a corresponding .pdb that's also non-deterministic
    (since the exe itself isn't, the pdb can't be), so add an entry for that.
    
    TBR=erikchen
    
    Bug: 330260
    Change-Id: Ic1cde1f5a52a953d74285e4bd6a02e74c70e75b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1278306
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599174}

    Changed files

    • tools/determinism/deterministic_build_whitelist.pyl
  10. Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

    Changed by Sergio Villar Senin - svillarohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 11:46:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 557d4cfd2336cc35f91ec95bb9ef4b1290e6d491

    Comments

    Convert chrome/browser/signin/signin_global_error.cc to IdentityManager
    
    It was using SigninManagerBase API to get the primary (authenticated)
    account id. It's now using the IdentityManager API.
    
    Bug: 890792
    Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
    Reviewed-on: https://chromium-review.googlesource.com/c/1276965
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599173}

    Changed files

    • chrome/browser/signin/signin_global_error.cc
  11. Add Picture-in-picture specific window resizer.

    Changed by Eliot Courtney - edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 11:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

    Comments

    Add Picture-in-picture specific window resizer.
    
    Currently, this does essentially nothing apart from providing basic
    resizing and moving functionality. In a follow-up CL, we can add
    snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
    like the virtual keyboard.
    
    Bug: 841886
    Bug: b/115291749
    Test: Able to move and resize an Android PIP window.
    Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
    Reviewed-on: https://chromium-review.googlesource.com/c/1219428
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599172}

    Changed files

    • ash/BUILD.gn
    • ash/wm/pip/pip_window_resizer.cc
    • ash/wm/pip/pip_window_resizer.h
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_window_resizer.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  12. Run layout to avoid stale layout during SetIsInert()

    Changed by Rune Lillesveen - futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:26:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b

    Comments

    Run layout to avoid stale layout during SetIsInert()
    
    Speculative fix for crbug.com/789094
    
    Bug: 789094
    Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/823582
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599171}

    Changed files

    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
  13. Remove MediaStreamRegistry.

    Changed by Guido Urdaneta - guidouohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:20:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7422130d3da18b70d4cc81951feda2ab615edef9

    Comments

    Remove MediaStreamRegistry.
    
    This class is useless now that URL.createObjectURL(MediaStream) has
    been removed from the Web platform.
    
    Bug: 591719
    Change-Id: I4a56bd8c0cbb86dacab8dafa6acb807509a86367
    Reviewed-on: https://chromium-review.googlesource.com/c/1221320
    Reviewed-by: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599170}

    Changed files

    • chrome/renderer/extensions/cast_streaming_native_handler.cc
    • chrome/renderer/extensions/cast_streaming_native_handler.h
    • chrome/renderer/resources/extensions/cast_streaming_receiver_session_custom_bindings.js
    • content/public/renderer/media_stream_utils.cc
    • content/renderer/media/web_media_element_source_utils.cc
    • content/renderer/render_frame_impl.cc
    • content/shell/renderer/layout_test/test_media_stream_renderer_factory.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/web/web_media_stream_registry.h
    • third_party/blink/renderer/core/html/media/html_media_element.cc
    • third_party/blink/renderer/core/html/media/html_media_element.h
    • third_party/blink/renderer/modules/exported/BUILD.gn
    • third_party/blink/renderer/modules/exported/web_media_stream_registry.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
    • third_party/blink/renderer/modules/mediacapturefromelement/html_media_element_capture.cc
    • third_party/blink/renderer/modules/mediastream/BUILD.gn
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
    • third_party/blink/renderer/modules/mediastream/media_stream.h
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_registry.h
  14. Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0

    Changed by Chromium WPT Sync - blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:49:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68550e484d7eecf6bd1d39fca300644ab2c21f5d

    Comments

    Import wpt@a69af5481cdd976c9696f97d9c6547ac87ba83d0
    
    Using wpt-import in Chromium afc97ac06f5d3677c1016d1530c1e196844e2432.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25973
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    binji@chromium.org:
      external/wpt/wasm
    jsbell@chromium.org:
      external/wpt/resources
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: I02e2714a05f60a13999e2efa76ad5039324ed566
    Reviewed-on: https://chromium-review.googlesource.com/c/1278537
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599169}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST_5.json
    • third_party/WebKit/LayoutTests/external/wpt/css/geometry/interfaces-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/interfaces_exclude=Node-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/resources/idlharness.js
    • third_party/WebKit/LayoutTests/external/wpt/shape-detection/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.js
    • third_party/WebKit/LayoutTests/external/wpt/wasm/jsapi/idlharness.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/wasm/resources/load_wasm.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/idlharness.https.window-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/idlharness.https.window-expected.txt
  15. Reland "Remove IDC_SHOW_SYNC_SETUP"

    Changed by Mihai Sardarescu - msardaohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:48:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 290bc882fa0022afd17118d11949266c86fa631b

    Comments

    Reland "Remove IDC_SHOW_SYNC_SETUP"
    
    This reverts commit 2ec520568c51bcd167a1ed24baa3a6f45023f02b.
    
    Reason for revert: This original CL was reverted as in emergency for M70 as it was in the CL dependency chain for the signin allowed pref CL.
    
    Original change's description:
    > Revert "Remove IDC_SHOW_SYNC_SETUP"
    > 
    > This reverts commit eafee2dc30fa6fdb34e07c664fd858a361cb5424.
    > 
    > Reason for revert: Still needed for http://crbug.com/888776
    > 
    > Original change's description:
    > > Remove IDC_SHOW_SYNC_SETUP
    > > 
    > > IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This
    > > CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up
    > > the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP
    > > and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing.
    > > 
    > > Bug: 870239
    > > Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402
    > > Reviewed-on: https://chromium-review.googlesource.com/1236263
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#593138}
    > 
    > TBR=sky@chromium.org,msarda@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: 870239
    > Change-Id: I50cd0042f2630dca0bafe4540c2c32411acf0338
    > Reviewed-on: https://chromium-review.googlesource.com/1245381
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594261}
    
    TBR=sky@chromium.org,msarda@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 870239
    Change-Id: Icde4e75988dd24b5bb2add35be055177708c7bfe
    Reviewed-on: https://chromium-review.googlesource.com/c/1278745
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599168}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/browser/ui/browser_command_controller.cc
    • chrome/browser/ui/browser_command_controller_unittest.cc
    • chrome/browser/ui/toolbar/app_menu_model.cc
  16. Rename PasswordControllerHelper to PasswordFormHelper

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:44:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 830919bab9ae548252386c0e0b2bb97b4a22152e

    Comments

    Rename PasswordControllerHelper to PasswordFormHelper
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: If08aa34d7c17e9f5a6dabb818669012275443587
    Reviewed-on: https://chromium-review.googlesource.com/c/1278670
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599167}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_form_helper.h
    • components/password_manager/ios/password_form_helper.mm
    • components/password_manager/ios/password_form_helper_unittest.mm
    • components/password_manager/ios/password_suggestion_helper.h
    • ios/chrome/browser/passwords/password_controller.h
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
    • ios/web_view/internal/passwords/cwv_password_controller.mm
  17. [aw] Add callback to proxy override methods

    Changed by Laís Minchillo - laisminchilloohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:36:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e2dd9b16afe9c2808aaa11566aa54fa854282db2

    Comments

    [aw] Add callback to proxy override methods
    
    Add an optional callback to proxy override methods introduced in change
    https://chromium-review.googlesource.com/c/chromium/src/+/1148384
    
    This adds an optional callback developers can use to know when the
    changes have been made to the network settings, since the methods are
    not synchronous with the UI thread.
    
    Bug: 851995
    Change-Id: I08dc7cc87c57d213b67774d3391562ca07fd0217
    Reviewed-on: https://chromium-review.googlesource.com/c/1258770
    Commit-Queue: Laís Minchillo <laisminchillo@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599166}

    Changed files

    • android_webview/browser/aw_contents_statics.cc
    • android_webview/browser/net/aw_url_request_context_getter.cc
    • android_webview/browser/net/aw_url_request_context_getter.h
    • android_webview/glue/java/src/com/android/webview/chromium/SharedStatics.java
    • android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/StaticsBoundaryInterface.java
    • android_webview/support_library/boundary_interfaces/src/org/chromium/support_lib_boundary/util/Features.java
    • android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java
    • net/proxy_resolution/proxy_config_service_android.cc
    • net/proxy_resolution/proxy_config_service_android.h
    • net/proxy_resolution/proxy_config_service_android_unittest.cc
  18. Move password suggestion logic into components.

    Changed by Scott Wu - scottwuohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b9a4429e3b49acb3be07a11697d3d9680f08e616

    Comments

    Move password suggestion logic into components.
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Ibf5ee92330172532dff87f9752d301a134ec49fc
    Reviewed-on: https://chromium-review.googlesource.com/c/1264455
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599165}

    Changed files

    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/password_suggestion_helper.h
    • components/password_manager/ios/password_suggestion_helper.mm
    • ios/chrome/browser/passwords/password_controller.mm
  19. [css-properties-values-api] Multi-value StylePropertyMap.set.

    Changed by Anders Hartvoll Ruud - andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 10:33:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d84303e41153ea9cb0f6475b6bb9e430666022a2

    Comments

    [css-properties-values-api] Multi-value StylePropertyMap.set.
    
    This adds support for setting multiple values with TypedOM for list-valued
    custom properties. For example, for a property --x with syntax <length>+,
    it will now be possible to do:
    
      element.attributeStyleMap.set('--x', CSS.px(1), CSS.px(2));
    
    This is done by producing a CSSVariableReferenceValue holding tokens
    equivalent to the incoming CSSStyleValues, provided that those values
    match the grammar of the custom property.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: Ic28497edbbea894a9c09b840dcb6c8fb825d99bb
    Reviewed-on: https://chromium-review.googlesource.com/c/1270963
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599164}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/css_syntax_descriptor.h
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc