Home | Search | chromium - Builders
Login

Builder ASan Release (32-bit x86 with V8-ARM) Build 33569 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revision0720b0228d5da8605132b93c3c5c989e5d3b8db1
Got Revision0720b0228d5da8605132b93c3c5c989e5d3b8db1

Execution:

Steps and Logfiles:

Show:
  1. ( 343 ms ) setup_build
    running recipe: "chromium"
  2. ( 465 ms ) remove .cipd
  3. ( 44 secs ) bot_update
    [56GB/295GB used (18%)]
  4. ( 0 ) ensure_goma
  5. ( 904 ms ) swarming.py --version
    0.13
  6. ( 4 secs ) clobber
  7. ( 23 secs ) gclient runhooks
  8. ( 25 secs ) generate_build_files
  9. ( 749 ms ) clang_revision
  10. ( 6 mins 27 secs ) compile
  11. ( 466 ms ) create staging_dir
  12. ( 865 ms ) Copy sancov
  13. ( 1 secs ) filter build_dir
  14. ( 3 mins 46 secs ) zipping
  15. ( 30 secs ) gsutil upload

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "/b/swarming/w/ir/cache", "temp_dir": "/b/swarming/w/ir/tmp/rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm1976-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.chromium.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1531414441628320, "id": "8941189286413754992", "project": "chromium", "tags": ["builder:ASan Release (32-bit x86 with V8-ARM)", "buildset:commit/git/0720b0228d5da8605132b93c3c5c989e5d3b8db1", "buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/0720b0228d5da8605132b93c3c5c989e5d3b8db1", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9106619348653189904", "scheduler_job_id:chromium/ASan Release (32-bit x86 with V8-ARM)", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "ASan Release (32-bit x86 with V8-ARM)" setup_build
buildnumber 33569 setup_build
mastername "chromium.lkgr" setup_build
path_config "generic" setup_build
recipe "chromium" setup_build
repository "https://chromium.googlesource.com/chromium/src.git" setup_build
revision "0720b0228d5da8605132b93c3c5c989e5d3b8db1" setup_build
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" bot_update
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" bot_update
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" bot_update
got_revision "0720b0228d5da8605132b93c3c5c989e5d3b8db1" bot_update
got_revision_cp "refs/heads/master@{#574603}" bot_update
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" bot_update
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" bot_update
got_v8_revision_cp "refs/heads/6.9.352@{#1}" bot_update
got_webrtc_revision "58c79f66dd3afef0ec2d77053e44f26b998b84b1" bot_update
got_webrtc_revision_cp "refs/heads/master@{#23950}" bot_update
got_clang_revision "336424-1" clang_revision

Blamelist:

  1. Colin Blundell (blundellohnoyoudont@chromium.org)
  2. Jun Cai (juncaiohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:54:01 UTC
Start Thursday, 12-Jul-18 16:54:07 UTC
End Thursday, 12-Jul-18 17:07:57 UTC
Pending 6 secs
Execution 13 mins 50 secs

All Changes:

  1. Revert "Have Device Service observe MessageLoop destruction"

    Changed by Colin Blundell - blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which will mean doing the plumbing that the below CL was looking to avoid. This is all sad-making, but c'est la vie.
    
    Bug: 856771, 794105
    
    Original change's description:
    > Have Device Service observe MessageLoop destruction
    >
    > The Device Service needs to clean up parts of its internal state as part
    > of browser shutdown. However, it also needs to run on the UI thread,
    > and embedded services that run on the UI thread are not guaranteed to
    > be destroyed as part of browser shutdown (tasks to destroy these
    > services are posted from the IO thread by
    > ServiceManagerConnectionImpl::ShutDownOnIOThread, but the UI thread is
    > typically shut down before these posted tasks are run).
    >
    > To solve this issue we discussed adding plumbing wherein embedded
    > services could inform //content that they wanted to be notified when
    > shutdown was occurring on the main thread. However, on investigation
    > this plumbing would be painful to implement: it is only
    > EmbeddedInstanceManager that has direct information of these service
    > instances, and that object lives far away from //content's
    > ServiceManagerContext, the object that knows when shutdown is occurring
    > on the main thread.
    >
    > This CL takes an alternative approach of having the Device Service
    > implementation observe the destruction of its MessageLoop. I have
    > verified that the observation is triggered on shutdown of Chrome.
    >
    > Bug: 794105
    > Change-Id: I3b383871679d42f544812be4bcb13c872cf276ff
    > Reviewed-on: https://chromium-review.googlesource.com/1099245
    > Commit-Queue: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  2. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc