Home | Search | chromium - Builders
Login

Builder ASan Debug (32-bit x86 with V8-ARM) Build 34939 Canonical Ubuntu

Results:

Success

Trigger Info:

Projectchromium
Revisionf3aba7f968ecb147e59a5460bd168e6085425848
Got Revisionf3aba7f968ecb147e59a5460bd168e6085425848

Execution:

Steps and Logfiles:

Show:
  1. ( 106751 days 23 hrs ) Failed to fetch step information from LogDog
    Log stream has no annotation entries

Build Properties:

NameValueSource

Blamelist:

  1. Jun Cai (juncaiohnoyoudont@chromium.org)

Timing:

Create Thursday, 12-Jul-18 16:53:33 UTC
Start Thursday, 12-Jul-18 16:53:36 UTC
End Thursday, 12-Jul-18 17:04:29 UTC
Pending 2 secs
Execution 10 mins 53 secs

All Changes:

  1. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by Jun Cai - juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc