Builder linux32_sde Build 8934295020879765648
Results:
Success
Trigger Info:
Project | boringssl |
Revision | 5b33effa7206b77e542a4ad6ec570aa27ed83518 |
Got Revision | 5b33effa7206b77e542a4ad6ec570aa27ed83518 |
Execution:
- Source: Task 4030203c282d6310
- Bot: gce-trusty-e833d7b0-us-east1-b-njhj
Steps and Logfiles:
Show:Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "gce-trusty-e833d7b0-us-east1-b-njhj" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.boringssl.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1537989325598581, "id": "8934295020879765648", "project": "boringssl", "tags": ["builder:linux32_sde", "buildset:commit/git/5b33effa7206b77e542a4ad6ec570aa27ed83518", "buildset:commit/gitiles/boringssl.googlesource.com/boringssl/+/5b33effa7206b77e542a4ad6ec570aa27ed83518", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9099725083034646688", "scheduler_job_id:boringssl/linux32_sde", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "linux32_sde" | setup_build |
path_config | "generic" | setup_build |
recipe | "boringssl" | setup_build |
repository | "https://boringssl.googlesource.com/boringssl.git" | setup_build |
revision | "5b33effa7206b77e542a4ad6ec570aa27ed83518" | setup_build |
got_revision | "5b33effa7206b77e542a4ad6ec570aa27ed83518" | bot_update |
Blamelist:
- David Benjamin (davidbenohnoyoudont@google.com)
Timing:
Create | Wednesday, 26-Sep-18 19:15:25 UTC |
Start | Wednesday, 26-Sep-18 19:15:28 UTC |
End | Wednesday, 26-Sep-18 19:27:02 UTC |
Pending | 2 secs |
Execution | 11 mins 34 secs |
All Changes:
-
Rename OPENSSL_NO_THREADS, part 1.
Changed by David Benjamin - davidbenohnoyoudont@google.com Changed at Wednesday, 26-Sep-18 19:10:02 UTC Repository https://boringssl.googlesource.com/boringssl Branch Revision 5b33effa7206b77e542a4ad6ec570aa27ed83518 Comments
Rename OPENSSL_NO_THREADS, part 1. BoringSSL depends on the platform's locking APIs to make internal global state thread-safe, including the PRNG. On some single-threaded embedded platforms, locking APIs may not exist, so this dependency may be disabled with a build flag. Doing so means the consumer promises the library will never be used in any multi-threaded address space. It causes BoringSSL to be globally thread-unsafe. Setting it inappropriately will subtly and unpredictably corrupt memory and leak secret keys. Unfortunately, folks sometimes misinterpreted OPENSSL_NO_THREADS as skipping an internal thread pool or disabling an optionally extra-thread-safe mode. This is not and has never been the case. Rename it to OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED to clarify what this option does. Update-Note: As a first step, this CL makes both OPENSSL_NO_THREADS and OPENSSL_NO_THREADS_CORRUPT_MEMORY_AND_LEAK_SECRETS_IF_THREADED work. A later CL will remove the old name, so migrate callers after or at the same time as picking up this CL. Change-Id: Ibe4964ae43eb7a52f08fd966fccb330c0cc11a8c Reviewed-on: https://boringssl-review.googlesource.com/32084 Commit-Queue: David Benjamin <davidben@google.com> CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org> Reviewed-by: Adam Langley <agl@google.com>
Changed files
- crypto/internal.h
- crypto/pool/pool_test.cc
- crypto/rand_extra/rand_test.cc
- crypto/refcount_test.cc
- crypto/rsa_extra/rsa_test.cc
- crypto/thread_none.c
- crypto/thread_test.cc
- include/openssl/base.h
- include/openssl/thread.h
- ssl/ssl_test.cc