Builder linux32_sde Build 8929400078710071984
Results:
Success
Trigger Info:
Project | boringssl |
Revision | 293d9ee4e837d122a28cd992e37779a5de48dc7f |
Got Revision | 293d9ee4e837d122a28cd992e37779a5de48dc7f |
Execution:
- Source: Task 41465f051ed30810
- Bot: gce-trusty-e833d7b0-us-west1-b-p57l
Steps and Logfiles:
Show:Build Properties:
Name | Value | Source |
---|---|---|
$recipe_engine/path | {"cache_dir": "/b/s/w/ir/cache", "temp_dir": "/b/s/w/ir/tmp/rt"} | setup_build |
$recipe_engine/runtime | {"is_experimental": false, "is_luci": true} | setup_build |
bot_id | "gce-trusty-e833d7b0-us-west1-b-p57l" | setup_build |
branch | "refs/heads/master" | setup_build |
buildbucket | {"build": {"bucket": "luci.boringssl.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542657506226176, "id": "8929400078710071984", "project": "boringssl", "tags": ["builder:linux32_sde", "buildset:commit/git/293d9ee4e837d122a28cd992e37779a5de48dc7f", "buildset:commit/gitiles/boringssl.googlesource.com/boringssl/+/293d9ee4e837d122a28cd992e37779a5de48dc7f", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9094830140916378048", "scheduler_job_id:boringssl/linux32_sde", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} | setup_build |
buildername | "linux32_sde" | setup_build |
path_config | "generic" | setup_build |
recipe | "boringssl" | setup_build |
repository | "https://boringssl.googlesource.com/boringssl.git" | setup_build |
revision | "293d9ee4e837d122a28cd992e37779a5de48dc7f" | setup_build |
got_revision | "293d9ee4e837d122a28cd992e37779a5de48dc7f" | bot_update |
Blamelist:
- David Benjamin (davidbenohnoyoudont@google.com)
Timing:
Create | Monday, 19-Nov-18 19:58:26 UTC |
Start | Monday, 19-Nov-18 19:58:59 UTC |
End | Monday, 19-Nov-18 20:10:25 UTC |
Pending | 33 secs |
Execution | 11 mins 26 secs |
All Changes:
-
Support execute-only memory for AArch64 assembly.
Changed by David Benjamin - davidbenohnoyoudont@google.com Changed at Monday, 19-Nov-18 19:58:15 UTC Repository https://boringssl.googlesource.com/boringssl Branch Revision 293d9ee4e837d122a28cd992e37779a5de48dc7f Comments
Support execute-only memory for AArch64 assembly. Put data in .rodata and, rather than adr, use the combination of adrp :pg_hi21: and add :lo12:. Unfortunately, iOS uses different syntax, so we must add more transforms to arm-xlate.pl. Tested manually by: 1. Use Android NDK r19-beta1 2. Follow usual instructions to configure CMake for aarch64, but pass -DCMAKE_EXE_LINKER_FLAGS="-fuse-ld=lld -Wl,-execute-only". 3. Build. Confirm with readelf -l tool/bssl that .text is not marked readable. 4. Push the test binaries onto a Pixel 3. Test normally and with --cpu={none,neon,crypto}. I had to pass --gtest_filter=-*Thread* to crypto_test. There appears to be an issue with some runtime function that's unrelated to our assembly. No measurable performance difference. Going forward, to support this, we will need to apply similar changes to all other AArch64 assembly. This is relatively straightforward, but may be a little finicky for dual-AArch32/AArch64 files (aesv8-armx.pl). Update-Note: Assembly syntax is a mess. There's a decent chance some assembler will get offend. Change-Id: Ib59b921d4cce76584320fefd23e6bb7ebd4847eb Reviewed-on: https://boringssl-review.googlesource.com/c/33245 Reviewed-by: Adam Langley <agl@google.com> Commit-Queue: David Benjamin <davidben@google.com>
Changed files
- crypto/chacha/asm/chacha-armv8.pl
- crypto/fipsmodule/aes/asm/aesv8-armx.pl
- crypto/fipsmodule/sha/asm/sha1-armv8.pl
- crypto/fipsmodule/sha/asm/sha512-armv8.pl
- crypto/perlasm/arm-xlate.pl