Home | Search | boringssl - Builders
Login

Builder win64_vs2017 Build 8930012199679350720 Microsoft Windows

Overview

Success

Input

Revision 8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44

Infra

Steps and Logs

Show:
  1. ( 628 ms ) setup_build

    running recipe: “boringssl”

  2. ( 16 secs ) bot_update

    [19GB/299GB used (6%)]

  3. ( 1 mins 43 secs ) gclient runhooks
  4. ( 152 ms ) clean
  5. ( 157 ms ) mkdir
  6. ( 20 secs ) cmake
  7. ( 35 secs ) ninja
  8. ( 750 ms ) check filenames
  9. ( 41 secs ) unit tests
  10. ( 47 secs ) ssl tests
  11. ( 216 ms ) taskkill mspdbsrv
  12. ( 0 ) recipe result

Timing

Create Tuesday, 13-Nov-18 01:49:02 UTC
Start Tuesday, 13-Nov-18 01:49:15 UTC
End Tuesday, 13-Nov-18 01:54:51 UTC
Pending 13 secs
Execution 5 mins 35 secs

Tags

KeyValue
buildset commit/git/8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44
scheduler_invocation_id 9095442262045297712
scheduler_job_id boringssl/win64_vs2017
user_agent luci-scheduler

Input Properties

NameValue
$recipe_engine/runtime { "is_experimental": false, "is_luci": true }
branch "refs/heads/master"
buildbucket { "build": { "bucket": "luci.boringssl.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542073742179576, "id": "8930012199679350720", "project": "boringssl", "tags": [ "builder:win64_vs2017", "buildset:commit/git/8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44", "buildset:commit/gitiles/boringssl.googlesource.com/boringssl/+/8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095442262045297712", "scheduler_job_id:boringssl/win64_vs2017", "user_agent:luci-scheduler" ] }, "hostname": "cr-buildbucket.appspot.com" }
buildername "win64_vs2017"
repository "https://boringssl.googlesource.com/boringssl.git"
revision "8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44"

Output Properties

NameValue
$recipe_engine/path { "cache_dir": "C:\\b\\s\\w\\ir\\cache", "temp_dir": "C:\\b\\s\\w\\ir\\tmp\\rt" }
$recipe_engine/runtime { "is_experimental": false, "is_luci": true }
bot_id "win10-727f49a0-us-west1-c-xmng"
branch "refs/heads/master"
buildbucket { "build": { "bucket": "luci.boringssl.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1542073742179576, "id": "8930012199679350720", "project": "boringssl", "tags": [ "builder:win64_vs2017", "buildset:commit/git/8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44", "buildset:commit/gitiles/boringssl.googlesource.com/boringssl/+/8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9095442262045297712", "scheduler_job_id:boringssl/win64_vs2017", "user_agent:luci-scheduler" ] }, "hostname": "cr-buildbucket.appspot.com" }
buildername "win64_vs2017"
got_revision "8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44"
path_config "generic"
recipe "boringssl"
repository "https://boringssl.googlesource.com/boringssl.git"
revision "8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44"

All Changes

  1. Optimize EC_GFp_mont_method's cmp_x_coordinate.

    Changed by David Benjamin - davidbenohnoyoudont@google.com
    Changed at Tuesday, 13-Nov-18 01:48:21 UTC
    Repository https://boringssl.googlesource.com/boringssl
    Branch
    Revision 8618f2bfe0f9e83127e5a3f9238ba5fe2268ae44

    Comments

    Optimize EC_GFp_mont_method's cmp_x_coordinate.
    
    For simplicity, punt order > field or width mismatches. Analogous
    optimizations are possible, but the generic path works fine and no
    commonly-used curve looks hits those cases.
    
    Before:
    Did 5888 ECDSA P-384 verify operations in 3094535us (1902.7 ops/sec)
    After [+6.7%]:
    Did 6107 ECDSA P-384 verify operations in 3007515us (2030.6 ops/sec)
    
    Also we can fill in p - order generically and avoid extra copies of some
    constants.
    
    Change-Id: I38e1b6d51b28ed4f8cb74697b00a4f0fbc5efc3c
    Reviewed-on: https://boringssl-review.googlesource.com/c/33068
    Commit-Queue: David Benjamin <davidben@google.com>
    CQ-Verified: CQ bot account: commit-bot@chromium.org <commit-bot@chromium.org>
    Reviewed-by: Adam Langley <agl@google.com>
    

    Changed files

    • crypto/fipsmodule/ec/ec.c
    • crypto/fipsmodule/ec/ec_montgomery.c
    • crypto/fipsmodule/ec/internal.h
    • crypto/fipsmodule/ec/p256-x86_64.c
    • third_party/fiat/p256.c