Home | Search | angle - Builders
Login

Builder win-clang-x86-rel Build 928 Microsoft Windows

Results:

Success

Trigger Info:

Projectangle
Revisionc3e3731cd3b2a3044f1bdec906c8557cc3edae77
Got Revisionc3e3731cd3b2a3044f1bdec906c8557cc3edae77

Execution:

Steps and Logfiles:

Show:
  1. ( 251 ms ) setup_build
    running recipe: "angle"
  2. ( 17 secs ) bot_update
    [26GB/299GB used (8%)]
  3. ( 3 secs ) gclient runhooks
  4. ( 1 secs ) gn gen
  5. ( 28 secs ) compile with ninja

Build Properties:

NameValueSource
$recipe_engine/path {"cache_dir": "C:\\b\\swarming\\w\\ir\\cache", "temp_dir": "C:\\b\\swarming\\w\\ir\\tmp\\rt"} setup_build
$recipe_engine/runtime {"is_experimental": false, "is_luci": true} setup_build
bot_id "swarm2367-c4" setup_build
branch "refs/heads/master" setup_build
buildbucket {"build": {"bucket": "luci.angle.ci", "created_by": "user:luci-scheduler@appspot.gserviceaccount.com", "created_ts": 1544150658017110, "id": "8927834395577357840", "project": "angle", "tags": ["builder:win-clang-x86-rel", "buildset:commit/git/c3e3731cd3b2a3044f1bdec906c8557cc3edae77", "buildset:commit/gitiles/chromium.googlesource.com/angle/angle/+/c3e3731cd3b2a3044f1bdec906c8557cc3edae77", "gitiles_ref:refs/heads/master", "scheduler_invocation_id:9093264457673873328", "scheduler_job_id:angle/win-clang-x86-rel", "user_agent:luci-scheduler"]}, "hostname": "cr-buildbucket.appspot.com"} setup_build
buildername "win-clang-x86-rel" setup_build
buildnumber 928 setup_build
clang true setup_build
debug false setup_build
path_config "generic" setup_build
recipe "angle" setup_build
repository "https://chromium.googlesource.com/angle/angle.git" setup_build
revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" setup_build
target_cpu "x86" setup_build
got_revision "c3e3731cd3b2a3044f1bdec906c8557cc3edae77" bot_update

Blamelist:

  1. Jamie Madill (jmadillohnoyoudont@chromium.org)

Timing:

Create Friday, 07-Dec-18 02:44:18 UTC
Start Friday, 07-Dec-18 02:44:45 UTC
End Friday, 07-Dec-18 02:47:20 UTC
Pending 27 secs
Execution 2 mins 35 secs

All Changes:

  1. Give every validation error a constant.

    Changed by Jamie Madill - jmadillohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 02:43:52 UTC
    Repository https://chromium.googlesource.com/angle/angle
    Branch
    Revision c3e3731cd3b2a3044f1bdec906c8557cc3edae77

    Comments

    Give every validation error a constant.
    
    Makes the code more consistent and organized.
    
    Also reduces binary size by about 4k.
    
    Also refactors validation for GetBufferPointerv.
    
    Bug: angleproject:2957
    Change-Id: Ib076ce936193e9840eef2499bf815489cdb48479
    Reviewed-on: https://chromium-review.googlesource.com/c/1350489
    Commit-Queue: Jamie Madill <jmadill@chromium.org>
    Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
    

    Changed files

    • src/libANGLE/ErrorStrings.h
    • src/libANGLE/validationES.cpp
    • src/libANGLE/validationES2.cpp
    • src/libANGLE/validationES3.cpp
    • src/libANGLE/validationES31.cpp