Home | Search
Login

Builder daisy-tot-chromium-pfq-informational Build #18970 Canonical Ubuntu

Results:

build successful exception slave lost exception BuildPackages

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 50 mins 22 secs ) steps
    running steps via annotated script
    exception
    slave
    lost
  2. ( 11 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "cros/cbuildbot"
  6. ( 5 secs ) bot_update
    bot_update
    [425GB/3281GB used (12%)]
  7. ( 3 ms ) ensure_goma
    ensure_goma
  8. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  9. ( 48 mins 59 secs ) cbuildbot_launch [daisy-tot-chromium-pfq-informational]
    cbuildbot_launch [daisy-tot-chromium-pfq-informational]
  10. ( 25 secs ) CleanBuildRoot
    CleanBuildRoot
  11. ( 3 mins 54 secs ) InitialCheckout
    InitialCheckout
    Branch: master
  12. ( 7 secs ) DepotToolsEnsureBootstrap
    DepotToolsEnsureBootstrap
  13. ( 7 secs ) Cbuildbot
    Cbuildbot
  14. ( 4 ms ) BuildStart
    BuildStart
    database: prod, build_id: 2483332
  15. ( 10 secs ) CleanUp
    CleanUp
  16. ( 1 mins 32 secs ) Sync
    Sync
  17. ( 4 ms ) BuildStart : [PREVIOUSLY PROCESSED]
    BuildStart : [PREVIOUSLY PROCESSED]
  18. ( 3 ms ) CleanUp : [PREVIOUSLY PROCESSED]
    CleanUp : [PREVIOUSLY PROCESSED]
  19. ( 3 ms ) Sync : [PREVIOUSLY PROCESSED]
    Sync : [PREVIOUSLY PROCESSED]
  20. ( 7 secs ) BuildReexecutionFinished
    BuildReexecutionFinished
    config['important']=False
  21. ( 4 ms ) ConfigDump
    ConfigDump
  22. ( 3 ms ) Uprev : [SKIPPED]
    Uprev : [SKIPPED]
  23. ( 4 mins 39 secs ) InitSDK
    InitSDK
    155
  24. ( 4 ms ) RegenPortageCache : [SKIPPED]
    RegenPortageCache : [SKIPPED]
  25. ( 7 mins 50 secs ) SetupBoard
    SetupBoard
  26. ( 3 mins 56 secs ) SyncChrome
    SyncChrome
    revision ee2a9e659d31fe969bf3198495cd12674f31f46b
  27. ( 2 ms ) UprevAndroid
    UprevAndroid
  28. ( 35 secs ) AndroidMetadata
    AndroidMetadata
    tag N/A
    branch N/A
  29. ( 4 ms ) BinhostTest : [SKIPPED]
    BinhostTest : [SKIPPED]
  30. ( 3 ms ) BranchUtilTest : [SKIPPED]
    BranchUtilTest : [SKIPPED]
  31. ( 25 mins 31 secs ) BuildPackages
    BuildPackages

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"code":404,"status":"bad_status"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromiumos/bb/chromiumos.chromium/daisy-tot-chromium-pfq-informational/18970/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromiumos.chromium/daisy-tot-chromium-pfq-informational/18970" Annotation(LogDog Bootstrap)
logdog_project "chromiumos" Annotation(LogDog Bootstrap)
build_data_dir "/b/rr/tmp_UBnT9" Annotation(steps)
build_id "buildbot/chromiumos.chromium/daisy-tot-chromium-pfq-informational/18970" Annotation(steps)
builder_id "master.chromiumos.chromium:daisy-tot-chromium-pfq-informational" Annotation(steps)
blamelist ["afakhry@chromium.org","allenvic@chromium.org","avi@chromium.org","bsalomon@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","crystallambert@chromium.org","cwallez@chromium.org","ellyjones@chromium.org","govind@chromium.org","jhawkins@chromium.org","jlebel@chromium.org","joone.hur@intel.com","junov@chromium.org","lgrey@chromium.org","lukasza@chromium.org","mmenke@chromium.org","mstensho@chromium.org","oysteine@chromium.org","sammiequon@google.com","tandrii@chromium.org","tommycli@chromium.org","twellington@chromium.org","vollick@chromium.org","weidongg@chromium.org","wez@chromium.org","xiaochengh@chromium.org","zhongyi@chromium.org"] Build
branch "master" Build
buildnumber 18970 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1523899342 Build
revision "ee2a9e659d31fe969bf3198495cd12674f31f46b" Build
slavename "build251-m2" BuildSlave
buildername "daisy-tot-chromium-pfq-informational" Builder
cbb_config "daisy-tot-chromium-pfq-informational" Builder
git_revision "ee2a9e659d31fe969bf3198495cd12674f31f46b" Change
scheduler "chromium_cros" Scheduler
buildbotURL "http://build.chromium.org/p/chromiumos.chromium/" master.cfg
mastername "chromiumos.chromium" master.cfg
workdir "/b/build/slave/daisy-tot-chromium-pfq-informational" slave

Blamelist:

  1. (oysteineohnoyoudont@chromium.org)
  2. (afakhryohnoyoudont@chromium.org)
  3. (jhawkinsohnoyoudont@chromium.org)
  4. (bsalomonohnoyoudont@chromium.org)
  5. (weidonggohnoyoudont@chromium.org)
  6. (jlebelohnoyoudont@chromium.org)
  7. (tommycliohnoyoudont@chromium.org)
  8. (lukaszaohnoyoudont@chromium.org)
  9. (govindohnoyoudont@chromium.org)
  10. (mstenshoohnoyoudont@chromium.org)
  11. (mmenkeohnoyoudont@chromium.org)
  12. (ellyjonesohnoyoudont@chromium.org)
  13. (aviohnoyoudont@chromium.org)
  14. (aviohnoyoudont@chromium.org)
  15. (wezohnoyoudont@chromium.org)
  16. (crystallambertohnoyoudont@chromium.org)
  17. (vollickohnoyoudont@chromium.org)
  18. (sammiequonohnoyoudont@google.com)
  19. (lgreyohnoyoudont@chromium.org)
  20. (joone.hurohnoyoudont@intel.com)
  21. (junovohnoyoudont@chromium.org)
  22. (allenvicohnoyoudont@chromium.org)
  23. (cwallezohnoyoudont@chromium.org)
  24. (cwallezohnoyoudont@chromium.org)
  25. (twellingtonohnoyoudont@chromium.org)
  26. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  27. (zhongyiohnoyoudont@chromium.org)
  28. (tandriiohnoyoudont@chromium.org)
  29. (allenvicohnoyoudont@chromium.org)
  30. (xiaochenghohnoyoudont@chromium.org)
  31. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)

Timing:

Create N/A
Start Monday, 16-Apr-18 18:43:49 UTC
End Monday, 16-Apr-18 19:34:12 UTC
Pending N/A
Execution 50 mins 22 secs

All Changes:

  1. Add a Mojo-based transportation layer for Perfetto

    Changed by oysteineohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:21:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4df8a2dd8f3b875773af061c1cbdcc519d19b283

    Comments

    Add a Mojo-based transportation layer for Perfetto
    
    This adds a base layer that individual logging protocols (like tracing)
    can use to send their data to Perfetto, using Mojo messaging and
    shared memory.
    
    First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270
    
    A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808
    
    The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit
    
    R=primiano@chromium.org,skyostil@chromium.org
    
    Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552
    Reviewed-on: https://chromium-review.googlesource.com/980578
    Reviewed-by: oysteine <oysteine@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: oysteine <oysteine@google.com>
    Cr-Commit-Position: refs/heads/master@{#551019}

    Changed files

    • DEPS
    • services/tracing/BUILD.gn
    • services/tracing/DEPS
    • services/tracing/manifest.json
    • services/tracing/perfetto/perfetto_integration_unittest.cc
    • services/tracing/perfetto/perfetto_service.cc
    • services/tracing/perfetto/perfetto_service.h
    • services/tracing/perfetto/producer_host.cc
    • services/tracing/perfetto/producer_host.h
    • services/tracing/public/cpp/BUILD.gn
    • services/tracing/public/cpp/perfetto/producer_client.cc
    • services/tracing/public/cpp/perfetto/producer_client.h
    • services/tracing/public/cpp/perfetto/shared_memory.cc
    • services/tracing/public/cpp/perfetto/shared_memory.h
    • services/tracing/public/cpp/perfetto/task_runner.cc
    • services/tracing/public/cpp/perfetto/task_runner.h
    • services/tracing/public/cpp/tracing_features.cc
    • services/tracing/public/cpp/tracing_features.h
    • services/tracing/public/mojom/BUILD.gn
    • services/tracing/public/mojom/perfetto_service.mojom
  2. Revert "Fix extensions badges and decorations positions"

    Changed by afakhryohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:25:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 71a2cc1b3292d9b4c5128da2db008e843e3b608c

    Comments

    Revert "Fix extensions badges and decorations positions"
    
    This reverts commit 94f048689670a751702fdd2e3c0b56e403d38964.
    
    Reason for revert: This doesn't work for PWAs, I will reland with a better fix so that it can be merged as a single CL.
    
    Original change's description:
    > Fix extensions badges and decorations positions
    > 
    > The extensions browser actions badges and decorations should
    > be positioned at the corners of the icon area, rather than the
    > corners of the full button's area (i.e. ignoring t
    ...skip...
    eue: Ahmed Fakhry <afakhry@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#550855}
    
    TBR=thestig@chromium.org,rdevlin.cronin@chromium.org,afakhry@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 831946
    Change-Id: I718ab6842d4bf55f5f1cf6f833e3638974c2fea8
    Reviewed-on: https://chromium-review.googlesource.com/1012734
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551020}

    Changed files

    • chrome/browser/ui/extensions/icon_with_badge_image_source.cc
    • chrome/browser/ui/extensions/icon_with_badge_image_source.h
  3. components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.

    Changed by jhawkinsohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:29:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0a774c419063fd86a2bbabe2cec0790eff7faf8

    Comments

    components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.
    
    R=hansberry@chromium.org
    
    Bug: 829039
    Test: none
    Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007
    Reviewed-on: https://chromium-review.googlesource.com/1012981
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551021}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
    • chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
    • chromeos/components/proximity_auth/messenger_impl_unittest.cc
    • chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
    • chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
    • chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
    • chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • components/cryptauth/connection.cc
    • components/cryptauth/connection.h
    • components/cryptauth/connection_unittest.cc
    • components/cryptauth/cryptauth_test_util.h
    • components/cryptauth/device_to_device_authenticator_unittest.cc
    • components/cryptauth/fake_connection.cc
    • components/cryptauth/fake_connection.h
    • components/cryptauth/remote_device.cc
    • components/cryptauth/remote_device.h
    • components/cryptauth/remote_device_loader.cc
    • components/cryptauth/remote_device_loader_unittest.cc
  4. Reland "Use new Skia GPU read/write pixel code paths"

    Changed by bsalomonohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 613f554306490882f0f3050f5d068f23dc050b08

    Comments

    Reland "Use new Skia GPU read/write pixel code paths"
    
    This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.
    
    Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.
    
    Original change's description:
    > Revert "Use new Skia GPU read/write pixel code paths"
    > 
    > This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
    > 
    > Reason for revert: 
    > 
    > It looks like this change:
    > 
    > slowed down the file___static_top_25_weather.html rasterize_
    ...skip...
    ommit-Position: refs/heads/master@{#545787}
    
    TBR=bsalomon@chromium.org,robertphillips@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 825594, 825585
    Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
    Reviewed-on: https://chromium-review.googlesource.com/1014140
    Reviewed-by: Brian Salomon <bsalomon@chromium.org>
    Reviewed-by: Robert Phillips <robertphillips@google.com>
    Commit-Queue: Brian Salomon <bsalomon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551022}

    Changed files

    • skia/config/SkUserConfig.h
  5. Fix app icon issue after long press in folder

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:36:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0088115194c7b314d154103bea63f95cb8acdadf

    Comments

    Fix app icon issue after long press in folder
    
    Background:
    Long press on app icon in folder will enlarge the icon, but release will
    not reset it. The long press gesture event is not handled by
    AppListItemView, thus passed to AppsGridView which handles it. The
    gesture end event will thus be sent to AppsGridView directly without
    going through AppListItemView. This is caused by go/cgcl/987293
    
    Change:
    Only handle the scroll begin event in AppsGridView if in folder instead
    of all gesture events.
    
    BUG=830982
    
    Change-Id: I2ca5bddaf22cd198d6e9cca5ee5f04c9798153e8
    Reviewed-on: https://chromium-review.googlesource.com/1008906
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551023}

    Changed files

    • ui/app_list/views/apps_grid_view.cc
  6. [iOS] Removing client secret

    Changed by jlebelohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:36:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9aeb35ea7faf7d028828a5690d20a9e1c3d2e6b2

    Comments

    [iOS] Removing client secret
    
    Client secret is not use on Chrome iOS, and the API is removed from SSO.
    Related to crrev.com/c/975127 and crrev.com/i/480972.
    
    Bug: 516021
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: If590ae3db2959b2146b6d27a606745ef749050ec
    Reviewed-on: https://chromium-review.googlesource.com/973229
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551024}

    Changed files

    • components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.h
    • components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm
    • components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
    • components/signin/ios/browser/profile_oauth2_token_service_ios_provider.h
    • components/signin/ios/browser/profile_oauth2_token_service_ios_provider.mm
    • ios/chrome/browser/signin/constants.h
    • ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.h
    • ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm
    • ios/public/provider/chrome/browser/signin/chrome_identity_service.h
    • ios/public/provider/chrome/browser/signin/chrome_identity_service.mm
    • ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
    • ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
    • ios/web_view/internal/signin/web_view_profile_oauth2_token_service_ios_provider_impl.h
    • ios/web_view/internal/signin/web_view_profile_oauth2_token_service_ios_provider_impl.mm
    • ios/web_view/public/cwv_authentication_controller_delegate.h
  7. Omnibox UI Experiments: Steady State Elision - Reelide on blur tests

    Changed by tommycliohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:39:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 30b157e0735ca9f189614d3989a41547cce6b35e

    Comments

    Omnibox UI Experiments: Steady State Elision - Reelide on blur tests
    
    When the URL is un-elided, and then the Omnibox is blurred:
    
     a) If the text has not been edited, re-elide the URL.
     b) If the text has been edited, leave the complete edited text as-is.
    
    This CL adds two tests - one for each scenario.
    
    Bug: 797354
    Change-Id: Ia70cf4357218e3b8f043be73716f067d7b287fd4
    Reviewed-on: https://chromium-review.googlesource.com/1012778
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551025}

    Changed files

    • chrome/browser/ui/views/omnibox/omnibox_view_views.h
    • chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
  8. Add UMA for recording what happens when attempting to take a spare RPH.

    Changed by lukaszaohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:41:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4e9ecbd123820408f9d923bdf29ac370c116cdf

    Comments

    Add UMA for recording what happens when attempting to take a spare RPH.
    
    The new UMA should help evaluate how often the spare is missing (e.g.
    because of low process limit on low-memory devices), mismatched (e.g.
    when simultaneously navigating in 2 profiles) or taken.  The spare can
    only help improve performance of cross-site navigations if it is
    actually taken.
    
    Bug: 808114
    Change-Id: Ic37cacf014de73f9adefc0407e60b4cfa246028b
    Reviewed-on: https://chromium-review.googlesource.com/1012510
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551026}

    Changed files

    • content/browser/renderer_host/render_process_host_impl.cc
    • content/browser/renderer_host/render_process_host_impl.h
    • content/browser/renderer_host/render_process_host_unittest.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  9. Updating XTBs based on .GRDs from branch master

    Changed by govindohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:45:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a30912ab9f65855ef13ae0000e61778658171016

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=cmasso@chromium.org
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: Ib455f27786c09a9439a68f6a376584efdc8c9209
    Reviewed-on: https://chromium-review.googlesource.com/1014288
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551027}

    Changed files

    • ash/components/strings/ash_components_strings_am.xtb
    • ash/components/strings/ash_components_strings_ar.xtb
    • ash/components/strings/ash_components_strings_bg.xtb
    • ash/components/strings/ash_components_strings_ca.xtb
    • ash/components/strings/ash_components_strings_cs.xtb
    • ash/components/strings/ash_components_strings_da.xtb
    • ash/components/strings/ash_components_strings_de.xtb
    • ash/components/strings/ash_components_strings_el.xtb
    • ash/components/strings/ash_components_strings_en-GB.xtb
    • ash/components/strings/ash_components_strings_es-419.xtb
    • ash/components/strings/ash_components_strings_es.xtb
    • ash/components/strings/ash_components_strings_et.xtb
    • ash/components/strings/ash_components_strings_fa.xtb
    • ash/components/strings/ash_components_strings_fi.xtb
    • ash/components/strings/ash_components_strings_fil.xtb
    • ash/components/strings/ash_components_strings_fr.xtb
    • ash/components/strings/ash_components_strings_gu.xtb
    • ash/components/strings/ash_components_strings_hi.xtb
    • ash/components/strings/ash_components_strings_hr.xtb
    • ash/components/strings/ash_components_strings_hu.xtb
    • ash/components/strings/ash_components_strings_id.xtb
    • ash/components/strings/ash_components_strings_it.xtb
    • ash/components/strings/ash_components_strings_iw.xtb
    • ash/components/strings/ash_components_strings_ja.xtb
    • ash/components/strings/ash_components_strings_kn.xtb
    • ash/components/strings/ash_components_strings_ko.xtb
    • ash/components/strings/ash_components_strings_lt.xtb
    • ash/components/strings/ash_components_strings_lv.xtb
    • ash/components/strings/ash_components_strings_ml.xtb
    • ash/components/strings/ash_components_strings_mr.xtb
    • ash/components/strings/ash_components_strings_ms.xtb
    • ash/components/strings/ash_components_strings_nl.xtb
    • ash/components/strings/ash_components_strings_no.xtb
    • ash/components/strings/ash_components_strings_pl.xtb
    • ash/components/strings/ash_components_strings_pt-BR.xtb
    • ash/components/strings/ash_components_strings_pt-PT.xtb
    • ash/components/strings/ash_components_strings_ro.xtb
    • ash/components/strings/ash_components_strings_ru.xtb
    • ash/components/strings/ash_components_strings_sk.xtb
    • ash/components/strings/ash_components_strings_sl.xtb
    • ash/components/strings/ash_components_strings_sr.xtb
    • ash/components/strings/ash_components_strings_sv.xtb
    • ash/components/strings/ash_components_strings_sw.xtb
    • ash/components/strings/ash_components_strings_ta.xtb
    • ash/components/strings/ash_components_strings_th.xtb
    • ash/components/strings/ash_components_strings_tr.xtb
    • ash/components/strings/ash_components_strings_uk.xtb
    • ash/components/strings/ash_components_strings_vi.xtb
    • ash/components/strings/ash_components_strings_zh-CN.xtb
    • ash/components/strings/ash_components_strings_zh-TW.xtb
    • ash/strings/ash_strings_da.xtb
    • ash/strings/ash_strings_de.xtb
    • ash/strings/ash_strings_et.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fr.xtb
    • ash/strings/ash_strings_iw.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_ms.xtb
    • ash/strings/ash_strings_nl.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_zh-TW.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_no.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sl.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_sw.xtb
    • chrome/app/resources/chromium_strings_ar.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_de.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_et.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_kn.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • remoting/resources/remoting_strings_ar.xtb
    • remoting/resources/remoting_strings_fr.xtb
    • remoting/resources/remoting_strings_kn.xtb
    • remoting/resources/remoting_strings_ml.xtb
    • remoting/resources/remoting_strings_pl.xtb
    • remoting/resources/remoting_strings_ro.xtb
    • remoting/resources/remoting_strings_zh-TW.xtb
    • ui/accessibility/extensions/strings/accessibility_extensions_strings_ar.xtb
    • ui/accessibility/extensions/strings/accessibility_extensions_strings_de.xtb
    • ui/chromeos/translations/ui_chromeos_strings_de.xtb
    • ui/strings/translations/ui_strings_gu.xtb
  10. [LayoutNG] Remove PositionWithBfcOffset().

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:51:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd94276585379a03ce84bca68af3bee64669a111

    Comments

    [LayoutNG] Remove PositionWithBfcOffset().
    
    There's no need to position pending floats at this point, since there
    should be none. Added a DCHECK. If a child knows its BFC offset, it has
    no reason to leave behind pending floats.
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
    Change-Id: I288b0cbd0ce43e422eddfe331dc02a5ee3afd6a8
    Reviewed-on: https://chromium-review.googlesource.com/1013486
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551028}

    Changed files

    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.h
  11. Restructure UnescapeURLWithAdjustmentsImpl().

    Changed by mmenkeohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:55:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6e8dbd1dd7d1fd3232f3f0c40eb3c133ea58966c

    Comments

    Restructure UnescapeURLWithAdjustmentsImpl().
    
    In particular, unescape entire unicode characters at once, and then
    compare against unescape blacklists, rather than the other way around,
    to simplify code and avoid the tree structure of the old code. This
    will also allow the method to use icu's code point classification
    logic, at some point in the future.
    
    Also separate out comparing against the character blacklist and UTF-8
    character decoding into separate methods, and add a few more test cases
    to unittest.
    
    The method itself should behave exactly the same as before.
    
    Bug: 824715
    Change-Id: I5311f25bfda4132b122ec4a079740adf093099a3
    Reviewed-on: https://chromium-review.googlesource.com/998014
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Matt Giuca <mgiuca@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551029}

    Changed files

    • net/base/escape.cc
    • net/base/escape.h
    • net/base/escape_unittest.cc
  12. macviews: use mac-y focus rings

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:59:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1af8d3ffcdec96999a970c108b85586bb6f65746

    Comments

    macviews: use mac-y focus rings
    
    This change:
    1) Uses the system focus ring color even when SecondaryUiMd is enabled
    2) Moves focus ring thickness and inset out to PlatformStyle
    3) Adds Mac overrides of the default values
    
    Bug: 832306
    Change-Id: I6c18d9d0431dc411a5cb95f9c0639e41f4aa1127
    Reviewed-on: https://chromium-review.googlesource.com/1012163
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551030}

    Changed files

    • ui/native_theme/native_theme_mac.mm
    • ui/views/controls/focus_ring.cc
    • ui/views/style/platform_style.cc
    • ui/views/style/platform_style.h
    • ui/views/style/platform_style_mac.mm
  13. Always load managed preferences from under the stable bundle ID.

    Changed by aviohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:00:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e21e0b54de518d58507a2c8492a131607696690

    Comments

    Always load managed preferences from under the stable bundle ID.
    
    BUG=831577
    
    Change-Id: Iaee76e352162b0afcbe61b9ee62c5db5ef9adc7f
    Reviewed-on: https://chromium-review.googlesource.com/1008544
    Reviewed-by: Georges Khalil <georgesak@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551031}

    Changed files

    • chrome/browser/policy/chrome_browser_policy_connector.cc
  14. Revert "Add a Mojo-based transportation layer for Perfetto"

    Changed by aviohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:01:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4614ed637fd4a2d3a3bea22fe9591fe3d66e43d

    Comments

    Revert "Add a Mojo-based transportation layer for Perfetto"
    
    This reverts commit 4df8a2dd8f3b875773af061c1cbdcc519d19b283.
    
    Reason for revert:
    Tests are broken on Ozone Linux
    https://ci.chromium.org/buildbot/chromium.linux/Ozone%20Linux/6600
    
    PerfettoIntegrationTest.PacketsEndToEndProducerFirst
    PerfettoIntegrationTest.TracingRestarted
    PerfettoIntegrationTest.PacketsEndToEndConsumerFirst
    
    Original change's description:
    > Add a Mojo-based transportation layer for Perfetto
    > 
    > This adds a base layer tha
    ...skip...
    omium.org>
    > Commit-Queue: oysteine <oysteine@google.com>
    > Cr-Commit-Position: refs/heads/master@{#551019}
    
    TBR=dcheng@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org
    
    Change-Id: Id212b8af28bd08276b6d0ccf48e59063bd7179de
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1013343
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551032}

    Changed files

    • DEPS
    • services/tracing/BUILD.gn
    • services/tracing/DEPS
    • services/tracing/manifest.json
    • services/tracing/perfetto/perfetto_integration_unittest.cc
    • services/tracing/perfetto/perfetto_service.cc
    • services/tracing/perfetto/perfetto_service.h
    • services/tracing/perfetto/producer_host.cc
    • services/tracing/perfetto/producer_host.h
    • services/tracing/public/cpp/BUILD.gn
    • services/tracing/public/cpp/perfetto/producer_client.cc
    • services/tracing/public/cpp/perfetto/producer_client.h
    • services/tracing/public/cpp/perfetto/shared_memory.cc
    • services/tracing/public/cpp/perfetto/shared_memory.h
    • services/tracing/public/cpp/perfetto/task_runner.cc
    • services/tracing/public/cpp/perfetto/task_runner.h
    • services/tracing/public/cpp/tracing_features.cc
    • services/tracing/public/cpp/tracing_features.h
    • services/tracing/public/mojom/BUILD.gn
    • services/tracing/public/mojom/perfetto_service.mojom
  15. Promote KeepAliveRegistry logging and DCHECKs to CHECKs.

    Changed by wezohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:03:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f88261bfd678f85d68744a9744970286cb69cf4

    Comments

    Promote KeepAliveRegistry logging and DCHECKs to CHECKs.
    
    - Enable CHECK against registration of new keep-alives during shutdown.
    - Promote some DLOG() checks to DCHECKs to make issues more visible.
    
    Bug: 720078
    Change-Id: I11e24a8de0ec5ab9e0a71f776d4b7149bb847ad2
    Reviewed-on: https://chromium-review.googlesource.com/1013394
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551033}

    Changed files

    • components/keep_alive_registry/keep_alive_registry.cc
    • components/keep_alive_registry/keep_alive_registry.h
  16. [Extension Doc]Performance Documentation

    Changed by crystallambertohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:03:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49bed1767c7ee9b91c8c3e7e217dd78bcdf4bb11

    Comments

    [Extension Doc]Performance Documentation
    
    This article serves as a central location for best practices
    to write a high performance extension.
    
    Bug: none
    Change-Id: Ie458a57b48dd0213e9effca9b69dd7a67910227e
    Reviewed-on: https://chromium-review.googlesource.com/821690
    Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551034}

    Changed files

    • chrome/common/extensions/docs/static/images/best_practices/lighthouse.gif
    • chrome/common/extensions/docs/templates/articles/performance.html
    • chrome/common/extensions/docs/templates/json/chrome_sidenav.json
    • chrome/common/extensions/docs/templates/public/extensions/performance.html
  17. [vr] Ensure unticked transitions complete

    Changed by vollickohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:05:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18a5665becb7cce9c10461631036bc847d76db45

    Comments

    [vr] Ensure unticked transitions complete
    
    If a transition was enqueued but not serviced and, much later, another
    transition is enqueued, it should transition from the final value of
    the earlier transition.
    
    Bug: 832650,830592
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
    Change-Id: I751c5d26101bfa197818ccd2f72188513ed044f2
    Reviewed-on: https://chromium-review.googlesource.com/1014008
    Commit-Queue: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551035}

    Changed files

    • chrome/browser/vr/animation.cc
    • chrome/browser/vr/animation_unittest.cc
    • chrome/browser/vr/elements/ui_element.cc
    • chrome/browser/vr/ui_scene_creator.cc
  18. Reland "splitview: Grab app for splitscreen only happen on long press."

    Changed by sammiequonohnoyoudont@google.com
    Changed at Monday, 16-Apr-18 18:06:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb3b55242a600d4b334e6f90d798c24541bc4941

    Comments

    Reland "splitview: Grab app for splitscreen only happen on long press."
    
    This is a reland of b9d68c49a3140aa0ae429b742d29329fab54eef5
    Left the previously disabled test disabled in the reland. Will fix in a
    seperate cl.
    
    TBR=oshima@chromium.org
    
    Original change's description:
    > splitview: Grab app for splitscreen only happen on long press.
    >
    > The indicators and the item enlarging only happen after long press, or
    > if the item has been dragged.
    >
    > This is preparation for fling to dismiss. It also remo
    ...skip...
    googlesource.com/996528
    > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    > Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#550884}
    
    Bug: 817863
    Change-Id: I0d6b255a89e69443af2e6509a0769622c8f64fb3
    Reviewed-on: https://chromium-review.googlesource.com/1012735
    Reviewed-by: Sammie Quon <sammiequon@chromium.org>
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551036}

    Changed files

    • ash/wm/overview/overview_window_drag_controller.cc
    • ash/wm/overview/overview_window_drag_controller.h
    • ash/wm/overview/window_selector.cc
    • ash/wm/overview/window_selector.h
    • ash/wm/overview/window_selector_item.cc
    • ash/wm/overview/window_selector_item.h
    • ash/wm/overview/window_selector_unittest.cc
  19. MacView: Use system icons for bookmark bar folders

    Changed by lgreyohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:10:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31adef92e414f5855cd9def5d176968af4c5c587

    Comments

    MacView: Use system icons for bookmark bar folders
    
    Cocoa browser's logic for deciding whether to use the light (dark mode)
    or regular icon requires converting the theme frame color to an NSColor
    in NSCalibratedWhiteColorSpace and checking against an empirical
    threshold.
    
    To keep things in Views-land and maintain the same interface, this
    change uses the light icon iff color_utils::IsDark returns false
    for the given text color.
    
    In practice, I will venture that anywhere this disagrees with Cocoa
    is a borderline case anyway.
    
    Bug: 792610
    Change-Id: I57b1c0cb90cf06fce4a8a3f31806dedd86791ebc
    Reviewed-on: https://chromium-review.googlesource.com/1012966
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551037}

    Changed files

    • chrome/browser/ui/bookmarks/bookmark_utils.cc
    • chrome/browser/ui/bookmarks/bookmark_utils.h
  20. Add "//services/network/public/mojom" to components/download/downloader/in_progress as dep

    Changed by joone.hurohnoyoudont@intel.com
    Changed at Monday, 16-Apr-18 18:11:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 106948b19ba937059d52de2ea10a7f7859ae1829

    Comments

    Add "//services/network/public/mojom" to components/download/downloader/in_progress as dep
    
    This CL fixes the below build error:
    In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.cc:5:
    In file included from ../../components/download/downloader/in_progress/in_progress_cache_impl.h:15:
    In file included from ../../components/download/downloader/in_progress/download_entry.h:11:
    In file included from ../../components/download/public/common/download_url_parameters
    ...skip...
    :
    ../../services/network/public/cpp/data_element.h:24:10: fatal error: 'services/network/public/mojom/chunked_data_pipe_getter.mojom.h' file not found
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    
    Bug: None
    Change-Id: I5ed108749c6d8287d91400b4324927cd58e5cd6a
    Reviewed-on: https://chromium-review.googlesource.com/1013230
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Joone Hur <joone.hur@intel.com>
    Cr-Commit-Position: refs/heads/master@{#551038}

    Changed files

    • components/download/downloader/in_progress/BUILD.gn
  21. Reset all GrContext state on Android in ScopedGpuRaster

    Changed by junovohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:11:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6ba537636e228d4144e92734fd8ced6001fd206

    Comments

    Reset all GrContext state on Android in ScopedGpuRaster
    
    This fixes rendering glitches in pages with videos in them
    on Android WebView.  I do not yet understand why the GL state
    is being changed without going through the gpu command buffer,
    but this seems to be happening with Android WebView on pages
    that have video elements.  This is a quick fix to resolve
    A release-blocking regression.  Further investigation
    will be a part of follow-up work: crbug.com/832810
    
    BUG=826636
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9b620ffcf74fd674d53a2eadc6efc932e9505d8
    Reviewed-on: https://chromium-review.googlesource.com/1012517
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551039}

    Changed files

    • cc/raster/scoped_gpu_raster.cc
  22. Add Native Network File Share to metrics

    Changed by allenvicohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:12:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea11e5eabdf35e9e402ee189db2a6a4f9e423421

    Comments

    Add Native Network File Share to metrics
    
    Adds "Native Network File Share (SMB)" as the name for "@smb" provider id in metrics.
    
    Bug: chromium:757625
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Ic99300e66d9e0007a8946661a4a24a4cfc9d1b4c
    Reviewed-on: https://chromium-review.googlesource.com/1011242
    Reviewed-by: Steve McKay <smckay@chromium.org>
    Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
    Commit-Queue: Allen Vicencio <allenvic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551040}

    Changed files

    • ui/file_manager/file_manager/common/js/metrics_events.js
  23. MILO: Remove tryserver.chromium.angle

    Changed by cwallezohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:16:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 850a66dcb9fc55024e97a01a8ccab7b43530c854

    Comments

    MILO: Remove tryserver.chromium.angle
    
    After the LUCI migration it is superseeded by angle.try.
    Also update the link that's shown in the MILO console.
    
    BUG=chromium:815092
    
    Change-Id: I6c2dde882ee01e117cfac6695ac9773092a6b09c
    Reviewed-on: https://chromium-review.googlesource.com/1014172
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551041}

    Changed files

    • infra/config/global/luci-milo.cfg
  24. MILO: Remove GPU FYI Windows side by side view.

    Changed by cwallezohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82a61bb9c6788e9402840ea38392689e22eababd

    Comments

    MILO: Remove GPU FYI Windows side by side view.
    
    BUG=chromium:815092
    
    Change-Id: I31ba1343a53f3e0ca13442f24f6332d130fddf43
    Reviewed-on: https://chromium-review.googlesource.com/1013858
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Corentin Wallez <cwallez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551042}

    Changed files

    • infra/config/global/luci-milo.cfg
  25. Account for margin in native page snapshot

    Changed by twellingtonohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:22:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f02cbd18e4f016fe589d1ae3373a58b2ead5da58

    Comments

    Account for margin in native page snapshot
    
    Use the native page's margin to translate the canvas used to capture the
    bitmap used in the tab switcher.
    
    Without explicitly considering margin, the snapshot is actually shorter
    than the tab content, causing the content to "jump" when entering and
    exiting the tab switcher.
    
    BUG=832588
    
    Change-Id: Ifdd871369341877c80214fbe767a602ee1f80d23
    Reviewed-on: https://chromium-review.googlesource.com/1013132
    Reviewed-by: Changwan Ryu <changwan@chromium.org>
    Commit-Queue: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551043}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java
  26. Roll src/third_party/chromite/ d88eaf531..82e2ac9a2 (1 commit)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Monday, 16-Apr-18 18:22:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15719eaa28fa0ddd15395962af7e26d7e7975a8c

    Comments

    Roll src/third_party/chromite/ d88eaf531..82e2ac9a2 (1 commit)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/d88eaf5315d4..82e2ac9a251e
    
    $ git log d88eaf531..82e2ac9a2 --date=short --no-merges --format='%ad %ae %s'
    2018-02-07 yhong lib/portage_util: Remove unused method.
    
    Created with:
      roll-dep src/third_party/chromite
    BUG=chromium:795449
    
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesour
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I67bdb12c05e5d242da7c0f3e3e8a1ddf1ea21d80
    Reviewed-on: https://chromium-review.googlesource.com/1014195
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#551044}

    Changed files

    • DEPS
  27. Change MockQuicData::AddRead() and MockQuicData::AddWrite() to take explicit IoMode.

    Changed by zhongyiohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:23:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32f2fd0ea3e1eb2ad9ac5b1e5ac22b1a150e01e7

    Comments

    Change MockQuicData::AddRead() and MockQuicData::AddWrite() to take explicit IoMode.
    
    - Change the API for MockQuicData::AddRead() and MockQuicData::AddWrite() to always take explicit IoMode.
    - Deprecate the following methods as those are confusing to consume:
    MockQuicData::AddSynchronousRead() and MockQuicData::AddAsyncWrite().
    
    Bug: 832803
    Change-Id: Ie2dc096820988c47c8a75082ce2baacd1d32c3ae
    Reviewed-on: https://chromium-review.googlesource.com/1012700
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551045}

    Changed files

    • net/http/http_proxy_client_socket_wrapper_unittest.cc
    • net/http/http_stream_factory_impl_job_controller_unittest.cc
    • net/quic/chromium/mock_quic_data.cc
    • net/quic/chromium/mock_quic_data.h
    • net/quic/chromium/quic_chromium_client_session_test.cc
    • net/quic/chromium/quic_network_transaction_unittest.cc
    • net/quic/chromium/quic_proxy_client_socket_unittest.cc
    • net/quic/chromium/quic_stream_factory_test.cc
  28. Remove no longer defined experimental builder from cq.cfg.

    Changed by tandriiohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:25:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e774610bf2cc343a74fd344c0fef60ea0b3c28

    Comments

    Remove no longer defined experimental builder from cq.cfg.
    
    TBR=ehmaldonado@chromium.org
    
    No-Try: True
    Change-Id: Icab6f6d500a10a48b1916901b638b9ff929128bf
    Reviewed-on: https://chromium-review.googlesource.com/1014341
    Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551046}

    Changed files

    • infra/config/branch/cq.cfg
  29. Return success in WriteFile when writing from an empty buffer.

    Changed by allenvicohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:25:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51e5467dfaa14b2e9b969f2afd6cf91d06e58c1

    Comments

    Return success in WriteFile when writing from an empty buffer.
    
    Changes WriteFile to return without calling D-Bus when attempting to write from an empty buffer.
    
    Bug: chromium:757625
    Change-Id: I386a571347ccf84785147ae91edea515b84a507a
    Reviewed-on: https://chromium-review.googlesource.com/1005776
    Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
    Commit-Queue: Allen Vicencio <allenvic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551047}

    Changed files

    • chrome/browser/chromeos/smb_client/smb_file_system.cc
  30. [LayoutNG] Extract LayoutBR::PositionForCaretOffset/CaretOffsetFromPosition from LayoutText code

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 18:27:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50cdaa5f548ae58583e66a44cb6580b50a21f3d5

    Comments

    [LayoutNG] Extract LayoutBR::PositionForCaretOffset/CaretOffsetFromPosition from LayoutText code
    
    LayoutText has two NG utility functions PositionForCaretOffset() and
    OffsetForCaretPosition() with type-based branching code.
    
    This patch extracts the LayoutBR handling into LayoutBR overrides for
    better code health.
    
    Change-Id: Ieca60f177c68944a74cfc30fe6bdc444012eca6e
    Reviewed-on: https://chromium-review.googlesource.com/1011629
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551048}

    Changed files

    • third_party/blink/renderer/core/layout/layout_br.cc
    • third_party/blink/renderer/core/layout/layout_br.h
    • third_party/blink/renderer/core/layout/layout_text.cc
  31. Roll src/third_party/catapult/ dc1e62593..037198303 (1 commit)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Monday, 16-Apr-18 18:29:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee2a9e659d31fe969bf3198495cd12674f31f46b

    Comments

    Roll src/third_party/catapult/ dc1e62593..037198303 (1 commit)
    
    https://chromium.googlesource.com/catapult.git/+log/dc1e62593e6c..0371983030f2
    
    $ git log dc1e62593..037198303 --date=short --no-merges --format='%ad %ae %s'
    2018-04-16 simonhatch Dashboard - Refactor /migrate_test_names
    
    Created with:
      roll-dep src/third_party/catapult
    
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/
    ...skip...
     sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=sullivan@chromium.org
    
    Change-Id: I184b1b4db929d388bf7c291d204484f4aff30a15
    Reviewed-on: https://chromium-review.googlesource.com/1014197
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#551049}

    Changed files

    • DEPS