Home | Search
Login

Builder amd64-generic-tot-chromium-pfq-informational Build #16045 Canonical Ubuntu

Results:

build successful

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 40 mins ) steps
    running steps via annotated script
  2. ( 11 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "cros/cbuildbot"
  6. ( 6 secs ) bot_update
    bot_update
    [460GB/3281GB used (14%)]
  7. ( 3 ms ) ensure_goma
    ensure_goma
  8. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  9. ( 1 hrs 39 mins ) cbuildbot_launch [amd64-generic-tot-chromium-pfq-informational]
    cbuildbot_launch [amd64-generic-tot-chromium-pfq-informational]
  10. ( 25 secs ) CleanBuildRoot
    CleanBuildRoot
  11. ( 4 mins 34 secs ) InitialCheckout
    InitialCheckout
    Branch: master
  12. ( 6 secs ) DepotToolsEnsureBootstrap
    DepotToolsEnsureBootstrap
  13. ( 8 secs ) Cbuildbot
    Cbuildbot
  14. ( 4 ms ) BuildStart
    BuildStart
    database: prod, build_id: 2482969
  15. ( 11 secs ) CleanUp
    CleanUp
  16. ( 1 mins 31 secs ) Sync
    Sync
  17. ( 4 ms ) BuildStart : [PREVIOUSLY PROCESSED]
    BuildStart : [PREVIOUSLY PROCESSED]
  18. ( 3 ms ) CleanUp : [PREVIOUSLY PROCESSED]
    CleanUp : [PREVIOUSLY PROCESSED]
  19. ( 3 ms ) Sync : [PREVIOUSLY PROCESSED]
    Sync : [PREVIOUSLY PROCESSED]
  20. ( 6 secs ) BuildReexecutionFinished
    BuildReexecutionFinished
    config['important']=False
  21. ( 1 ms ) ConfigDump
    ConfigDump
  22. ( 1 ms ) Uprev : [SKIPPED]
    Uprev : [SKIPPED]
  23. ( 4 mins 32 secs ) InitSDK
    InitSDK
    155
  24. ( 3 ms ) RegenPortageCache : [SKIPPED]
    RegenPortageCache : [SKIPPED]
  25. ( 5 mins 23 secs ) SetupBoard
    SetupBoard
  26. ( 3 mins 42 secs ) SyncChrome
    SyncChrome
    revision 9aeb35ea7faf7d028828a5690d20a9e1c3d2e6b2
  27. ( 4 ms ) UprevAndroid
    UprevAndroid
  28. ( 32 secs ) AndroidMetadata
    AndroidMetadata
    tag N/A
    branch N/A
  29. ( 3 ms ) BinhostTest : [SKIPPED]
    BinhostTest : [SKIPPED]
  30. ( 3 ms ) BranchUtilTest : [SKIPPED]
    BranchUtilTest : [SKIPPED]
  31. ( 31 mins 30 secs ) BuildPackages
    BuildPackages
  32. ( 10 mins 12 secs ) BuildImage
    BuildImage
  33. ( 4 ms ) UnitTest : [SKIPPED]
    UnitTest : [SKIPPED]
  34. ( 4 mins 11 secs ) DebugInfoTest
    DebugInfoTest
  35. ( 4 ms ) SimpleChromeArtifacts : [SKIPPED]
    SimpleChromeArtifacts : [SKIPPED]
  36. ( 3 ms ) SignerTest : [SKIPPED]
    SignerTest : [SKIPPED]
  37. ( 3 ms ) Signing : [SKIPPED]
    Signing : [SKIPPED]
  38. ( 3 ms ) Paygen : [SKIPPED]
    Paygen : [SKIPPED]
  39. ( 3 ms ) ImageTest : [SKIPPED]
    ImageTest : [SKIPPED]
  40. ( 3 ms ) UploadPrebuilts : [SKIPPED]
    UploadPrebuilts : [SKIPPED]
  41. ( 3 ms ) DevInstallerPrebuilts : [SKIPPED]
    DevInstallerPrebuilts : [SKIPPED]
  42. ( 2 mins 57 secs ) CPEExport
    CPEExport
  43. ( 4 ms ) UploadTestArtifacts
    UploadTestArtifacts
  44. ( 3 ms ) Archive
    Archive
  45. ( 18 mins 8 secs ) VMTest (attempt 1)
    VMTest (attempt 1)
  46. ( 1 ms ) DownloadAndroidDebugSymbols
    DownloadAndroidDebugSymbols
  47. ( 8 mins 7 secs ) DebugSymbols
    DebugSymbols
  48. ( 2 mins 14 secs ) Report
    Report
  49. ( 34 secs ) CleanupChroot
    CleanupChroot
  50. ( 2 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"code":404,"status":"bad_status"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromiumos/bb/chromiumos.chromium/amd64-generic-tot-chromium-pfq-informational/16045/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromiumos.chromium/amd64-generic-tot-chromium-pfq-informational/16045" Annotation(LogDog Bootstrap)
logdog_project "chromiumos" Annotation(LogDog Bootstrap)
artifact_link "gs://chromeos-image-archive/amd64-generic-tot-chromium-pfq-informational/R68-10588.0.0-b2482969" Annotation(Report)
build_data_dir "/b/rr/tmp_L6G_k" Annotation(steps)
build_id "buildbot/chromiumos.chromium/amd64-generic-tot-chromium-pfq-informational/16045" Annotation(steps)
builder_id "master.chromiumos.chromium:amd64-generic-tot-chromium-pfq-informational" Annotation(steps)
blamelist ["afakhry@chromium.org","ahaas@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","asimjour@chromium.org","bauerb@chromium.org","beccahughes@chromium.org","blink-w3c-test-autoroller@chromium.org","brunokim@chromium.org","bsalomon@chromium.org","bsazonov@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","csharrison@chromium.org","dgozman@chromium.org","dtseng@chromium.org","emaxx@chromium.org","eyaich@google.com","fdoray@chromium.org","fhorschig@chromium.org","finnur@chromium.org","ftirelo@chromium.org","futhark@chromium.org","jbroman@chromium.org","jhawkins@chromium.org","jlebel@chromium.org","junov@chromium.org","liyuqian@google.com","ljusten@chromium.org","mahmadi@chromium.org","mastiz@chromium.org","mcasas@chromium.org","mlamouri@chromium.org","mostynb@vewd.com","oysteine@chromium.org","pfeldman@chromium.org","rdevlin.cronin@chromium.org","rouslan@chromium.org","rsorokin@chromium.org","rtoy@chromium.org","siggi@chromium.org","thestig@chromium.org","tschumann@chromium.org","v8-autoroll@chromium.org","vollick@chromium.org","weidongg@chromium.org","zmin@chromium.org"] Build
branch "master" Build
buildnumber 16045 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1523894362 Build
revision "9aeb35ea7faf7d028828a5690d20a9e1c3d2e6b2" Build
slavename "build250-m2" BuildSlave
buildername "amd64-generic-tot-chromium-pfq-informational" Builder
cbb_config "amd64-generic-tot-chromium-pfq-informational" Builder
git_revision "9aeb35ea7faf7d028828a5690d20a9e1c3d2e6b2" Change
scheduler "chromium_cros" Scheduler
buildbotURL "http://build.chromium.org/p/chromiumos.chromium/" master.cfg
mastername "chromiumos.chromium" master.cfg
workdir "/b/build/slave/amd64-generic-tot-chromium-pfq-informational" slave

Blamelist:

  1. (fdorayohnoyoudont@chromium.org)
  2. (rsorokinohnoyoudont@chromium.org)
  3. (rsorokinohnoyoudont@chromium.org)
  4. (mastizohnoyoudont@chromium.org)
  5. (dtsengohnoyoudont@chromium.org)
  6. (thestigohnoyoudont@chromium.org)
  7. (junovohnoyoudont@chromium.org)
  8. (v8-autorollohnoyoudont@chromium.org)
  9. (jbromanohnoyoudont@chromium.org)
  10. (rdevlin.croninohnoyoudont@chromium.org)
  11. (ljustenohnoyoudont@chromium.org)
  12. (tschumannohnoyoudont@chromium.org)
  13. (fhorschigohnoyoudont@chromium.org)
  14. (finnurohnoyoudont@chromium.org)
  15. (rouslanohnoyoudont@chromium.org)
  16. (siggiohnoyoudont@chromium.org)
  17. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  18. (csharrisonohnoyoudont@chromium.org)
  19. (eyaichohnoyoudont@google.com)
  20. (ftireloohnoyoudont@chromium.org)
  21. (zminohnoyoudont@chromium.org)
  22. (mlamouriohnoyoudont@chromium.org)
  23. (emaxxohnoyoudont@chromium.org)
  24. (zminohnoyoudont@chromium.org)
  25. (liyuqianohnoyoudont@google.com)
  26. (csharrisonohnoyoudont@chromium.org)
  27. (rsorokinohnoyoudont@chromium.org)
  28. (bauerbohnoyoudont@chromium.org)
  29. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  30. (ahaasohnoyoudont@chromium.org)
  31. (brunokimohnoyoudont@chromium.org)
  32. (bsazonovohnoyoudont@chromium.org)
  33. (mostynbohnoyoudont@vewd.com)
  34. (mcasasohnoyoudont@chromium.org)
  35. (bauerbohnoyoudont@chromium.org)
  36. (asimjourohnoyoudont@chromium.org)
  37. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  38. (vollickohnoyoudont@chromium.org)
  39. (futharkohnoyoudont@chromium.org)
  40. (dgozmanohnoyoudont@chromium.org)
  41. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  42. (mahmadiohnoyoudont@chromium.org)
  43. (rtoyohnoyoudont@chromium.org)
  44. (jhawkinsohnoyoudont@chromium.org)
  45. (pfeldmanohnoyoudont@chromium.org)
  46. (beccahughesohnoyoudont@chromium.org)
  47. (oysteineohnoyoudont@chromium.org)
  48. (afakhryohnoyoudont@chromium.org)
  49. (jhawkinsohnoyoudont@chromium.org)
  50. (bsalomonohnoyoudont@chromium.org)
  51. (weidonggohnoyoudont@chromium.org)
  52. (jlebelohnoyoudont@chromium.org)

Timing:

Create N/A
Start Monday, 16-Apr-18 17:39:45 UTC
End Monday, 16-Apr-18 19:20:21 UTC
Pending N/A
Execution 1 hrs 40 mins

All Changes:

  1. Test that first non-empty paint doesn't depend on BACKGROUND tasks.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 15:57:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e84bea563809e2ef7c2ffbfdbbf83a68e9c09e0

    Comments

    Test that first non-empty paint doesn't depend on BACKGROUND tasks.
    
    TaskPriority::BACKGROUND tasks can take "an arbitrarily long time to
    complete".
    https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h?l=26&rcl=19a69a1389844f51c474efa446e3f22dd1fb36a8
    
    We have plan to restrict more aggressively when they can run. To make
    sure that this doesn't introduce unwanted performance regressions,
    we need to make sure that there is no need to run
    TaskPriority::BACKGROUND tasks to respond to user actions.
    
    This CL adds a browser test to verify that the first
    non-empty paint can happen when no TaskPriority::BACKGROUND tasks
    are allowed to run.
    
    Bug: 831835
    Change-Id: I4c5d4f1056d823a6c36aa1504e2508d1bc1c58b6
    Reviewed-on: https://chromium-review.googlesource.com/1008640
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550973}

    Changed files

    • chrome/browser/no_background_tasks_browsertest.cc
    • chrome/test/BUILD.gn
  2. Add test for Active Directory join error card

    Changed by rsorokinohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 15:57:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99a8d795549e363a355f3b0e090d2aad761b58d3

    Comments

    Add test for Active Directory join error card
    
    Checks that correct error card is shown (Active Directory one). Also checks
    that hitting retry shows Active Directory screen again.
    
    BUG=chromium:829361,chromium:809914
    TEST=EnterpriseEnrollmentTest.TestActiveDirectoryEnrollment_ErrorCard
    
    Change-Id: I5eb6aa289828954c5837934ab34fb119f15bcdc6
    Reviewed-on: https://chromium-review.googlesource.com/998272
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550974}

    Changed files

    • chrome/browser/chromeos/login/enrollment/enrollment_screen.h
    • chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
  3. Remove profile info cache for Active Directory profiles

    Changed by rsorokinohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 15:58:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ead4d71fd68c2dbd4a8cc599dc9e002730f93c0

    Comments

    Remove profile info cache for Active Directory profiles
    
    BUG=chromium:810167
    
    Change-Id: I030f296e0cf1379d65f9dfba759163896f4319b5
    Reviewed-on: https://chromium-review.googlesource.com/928721
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550975}

    Changed files

    • chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc
    • chrome/browser/profiles/profile_attributes_storage.h
    • chrome/browser/profiles/profile_attributes_storage_unittest.cc
    • chrome/browser/profiles/profile_info_cache.cc
    • chrome/browser/profiles/profile_info_cache.h
    • chrome/browser/profiles/profile_info_cache_unittest.cc
    • chrome/browser/profiles/profile_list_desktop_unittest.cc
    • chrome/browser/profiles/profile_manager.cc
    • chrome/browser/profiles/profile_manager_unittest.cc
    • chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc
    • chrome/browser/profiles/profile_window_browsertest.cc
  4. Adopt OnceCallback for OnSyncStarting()

    Changed by mastizohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 15:59:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b789651af177bb85f4f5b0e01bbafe636ed8259a

    Comments

    Adopt OnceCallback for OnSyncStarting()
    
    The callback must be called at most once, so let's migrate away from
    deprecated APIs and adopt base::OnceCallback.
    
    Bug: 681921
    Change-Id: I2cc0fb6b75771b4a203584154178a1a897a305b8
    Reviewed-on: https://chromium-review.googlesource.com/1012063
    Reviewed-by: Jan Krcal <jkrcal@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550976}

    Changed files

    • components/sync/base/bind_to_task_runner.h
    • components/sync/driver/model_type_controller.cc
    • components/sync/driver/model_type_controller_unittest.cc
    • components/sync/model/fake_model_type_change_processor.cc
    • components/sync/model/fake_model_type_change_processor.h
    • components/sync/model/mock_model_type_change_processor.cc
    • components/sync/model/mock_model_type_change_processor.h
    • components/sync/model/model_type_change_processor.h
    • components/sync/model/model_type_sync_bridge.cc
    • components/sync/model/model_type_sync_bridge.h
    • components/sync/model/model_type_sync_bridge_unittest.cc
    • components/sync/model_impl/client_tag_based_model_type_processor.cc
    • components/sync/model_impl/client_tag_based_model_type_processor.h
    • components/sync/user_events/user_event_sync_bridge.cc
    • components/sync/user_events/user_event_sync_bridge.h
  5. Reland "Enable ChromeVox ARC support for all apps"

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:00:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea9f6b4cdc03cb153cd04b1c5cff3b7375374228

    Comments

    Reland "Enable ChromeVox ARC support for all apps"
    
    This reverts commit fe043a760a3ab9311baeb4cf036854137b73aa60.
    
    Reason for revert: re-enabling for m68
    
    Original change's description:
    > Revert "Enable ChromeVox ARC support for all apps"
    > 
    > This reverts commit bea322523f6dafc4a8ed689faada2346c021a008.
    > 
    > Reason for revert: various apps breaking e.g. scrolling
    > 
    > Original change's description:
    > > Enable ChromeVox ARC support for all apps
    > > 
    > > Change-Id: I130db573fcc2ccbda3ce58c9d2bac845218a
    ...skip...
    ue: David Tseng <dtseng@chromium.org>
    > Reviewed-by: David Tseng <dtseng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#547379}
    
    TBR=dtseng@chromium.org,yawano@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I8f7ba6cfe4d59df80309a49499c754768645d453
    Reviewed-on: https://chromium-review.googlesource.com/1014016
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550977}

    Changed files

    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
  6. Remove __LP64__ checks in Mac code.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:00:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f14106ad3f47a31ee58eb9d481b3a00375c60c11

    Comments

    Remove __LP64__ checks in Mac code.
    
    Mac builds have been 64-bit only for years now.
    
    Change-Id: Id11a687ef54488239afcbfa6d44e415d5d2f7528
    Reviewed-on: https://chromium-review.googlesource.com/1013082
    Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550978}

    Changed files

    • base/message_loop/message_pump_mac.mm
    • chrome/common/mac/cfbundle_blocker.mm
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/renderer/renderer_main_platform_delegate_mac.mm
    • skia/ext/skia_utils_mac.h
    • ui/gfx/image/image_skia_util_mac.h
  7. Fix alpha-unpremultiply overflow in WebGL+toDataURL

    Changed by junovohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:01:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcffdac67a98797ffadf4aa14ce979ceffbb8f53

    Comments

    Fix alpha-unpremultiply overflow in WebGL+toDataURL
    
    This change fixes a regression that was introduced in
    https://chromium-review.googlesource.com/c/chromium/src/+/780279
    Fixing the issue by switching sensitive use cases back to using
    SkImage::readPixels for safely performing the unpremul conversion
    
    BUG=826878
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: Ie4bc9ced4d7175ab308529f7dd7119f93378e34c
    Reviewed-on: https://chromium-review.googlesource.com/1003320
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550979}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/webgl/canvas-toDataURL-premul-overflow-expected.html
    • third_party/WebKit/LayoutTests/fast/webgl/canvas-toDataURL-premul-overflow.html
    • third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
    • third_party/WebKit/LayoutTests/platform/mac-retina/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
    • third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
    • third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.txt
    • third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip.html
    • third_party/blink/renderer/platform/graphics/image_data_buffer.cc
  8. Update V8 to version 6.8.11.

    Changed by v8-autorollohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:01:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 16d017e2a5ddb80a0fe1b03d68e356e5a6e9171b

    Comments

    Update V8 to version 6.8.11.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/05254515..a7328562
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
    
    Change-Id: I1caae9638c8b92541ef86cb9a619f760ebbf0b39
    Reviewed-on: https://chromium-review.googlesource.com/1013752
    Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
    Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550980}

    Changed files

    • DEPS
  9. [extensions] Make ManifestHandler::Keys return a span into static data instead of allocating a vector.

    Changed by jbromanohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:02:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 16cdbd08d4bc9f96291d06447254a58e3c7f5f22

    Comments

    [extensions] Make ManifestHandler::Keys return a span into static data instead of allocating a vector.
    
    Shows up as a signficant fraction of time in content::ContentMainRunnerImpl::Initialize.
    
    Change-Id: I56308465e0bd8c1e58018d21263f8e9710ca66dc
    Reviewed-on: https://chromium-review.googlesource.com/1011367
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550981}

    Changed files

    • chrome/common/extensions/api/commands/commands_handler.cc
    • chrome/common/extensions/api/commands/commands_handler.h
    • chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc
    • chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h
    • chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc
    • chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.h
    • chrome/common/extensions/api/input_ime/input_components_handler.cc
    • chrome/common/extensions/api/input_ime/input_components_handler.h
    • chrome/common/extensions/api/omnibox/omnibox_handler.cc
    • chrome/common/extensions/api/omnibox/omnibox_handler.h
    • chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc
    • chrome/common/extensions/api/speech/tts_engine_manifest_handler.h
    • chrome/common/extensions/api/spellcheck/spellcheck_handler.cc
    • chrome/common/extensions/api/spellcheck/spellcheck_handler.h
    • chrome/common/extensions/api/storage/storage_schema_manifest_handler.cc
    • chrome/common/extensions/api/storage/storage_schema_manifest_handler.h
    • chrome/common/extensions/api/system_indicator/system_indicator_handler.cc
    • chrome/common/extensions/api/system_indicator/system_indicator_handler.h
    • chrome/common/extensions/api/url_handlers/url_handlers_parser.cc
    • chrome/common/extensions/api/url_handlers/url_handlers_parser.h
    • chrome/common/extensions/chrome_manifest_url_handlers.cc
    • chrome/common/extensions/chrome_manifest_url_handlers.h
    • chrome/common/extensions/manifest_handlers/app_icon_color_info.cc
    • chrome/common/extensions/manifest_handlers/app_icon_color_info.h
    • chrome/common/extensions/manifest_handlers/app_launch_info.cc
    • chrome/common/extensions/manifest_handlers/app_launch_info.h
    • chrome/common/extensions/manifest_handlers/app_theme_color_info.cc
    • chrome/common/extensions/manifest_handlers/app_theme_color_info.h
    • chrome/common/extensions/manifest_handlers/extension_action_handler.cc
    • chrome/common/extensions/manifest_handlers/extension_action_handler.h
    • chrome/common/extensions/manifest_handlers/linked_app_icons.cc
    • chrome/common/extensions/manifest_handlers/linked_app_icons.h
    • chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
    • chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h
    • chrome/common/extensions/manifest_handlers/settings_overrides_handler.cc
    • chrome/common/extensions/manifest_handlers/settings_overrides_handler.h
    • chrome/common/extensions/manifest_handlers/theme_handler.cc
    • chrome/common/extensions/manifest_handlers/theme_handler.h
    • chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
    • chrome/common/extensions/manifest_handlers/ui_overrides_handler.h
    • extensions/common/api/bluetooth/bluetooth_manifest_handler.cc
    • extensions/common/api/bluetooth/bluetooth_manifest_handler.h
    • extensions/common/api/declarative/declarative_manifest_handler.cc
    • extensions/common/api/declarative/declarative_manifest_handler.h
    • extensions/common/api/declarative_net_request/dnr_manifest_handler.cc
    • extensions/common/api/declarative_net_request/dnr_manifest_handler.h
    • extensions/common/api/printer_provider/usb_printer_manifest_handler.cc
    • extensions/common/api/printer_provider/usb_printer_manifest_handler.h
    • extensions/common/api/sockets/sockets_manifest_handler.cc
    • extensions/common/api/sockets/sockets_manifest_handler.h
    • extensions/common/manifest_handler.cc
    • extensions/common/manifest_handler.h
    • extensions/common/manifest_handler_unittest.cc
    • extensions/common/manifest_handlers/action_handlers_handler.cc
    • extensions/common/manifest_handlers/action_handlers_handler.h
    • extensions/common/manifest_handlers/app_isolation_info.cc
    • extensions/common/manifest_handlers/app_isolation_info.h
    • extensions/common/manifest_handlers/automation.cc
    • extensions/common/manifest_handlers/automation.h
    • extensions/common/manifest_handlers/background_info.cc
    • extensions/common/manifest_handlers/background_info.h
    • extensions/common/manifest_handlers/content_capabilities_handler.cc
    • extensions/common/manifest_handlers/content_capabilities_handler.h
    • extensions/common/manifest_handlers/content_scripts_handler.cc
    • extensions/common/manifest_handlers/content_scripts_handler.h
    • extensions/common/manifest_handlers/csp_info.cc
    • extensions/common/manifest_handlers/csp_info.h
    • extensions/common/manifest_handlers/default_locale_handler.cc
    • extensions/common/manifest_handlers/default_locale_handler.h
    • extensions/common/manifest_handlers/externally_connectable.cc
    • extensions/common/manifest_handlers/externally_connectable.h
    • extensions/common/manifest_handlers/file_handler_info.cc
    • extensions/common/manifest_handlers/file_handler_info.h
    • extensions/common/manifest_handlers/icons_handler.cc
    • extensions/common/manifest_handlers/icons_handler.h
    • extensions/common/manifest_handlers/incognito_info.cc
    • extensions/common/manifest_handlers/incognito_info.h
    • extensions/common/manifest_handlers/kiosk_mode_info.cc
    • extensions/common/manifest_handlers/kiosk_mode_info.h
    • extensions/common/manifest_handlers/mime_types_handler.cc
    • extensions/common/manifest_handlers/mime_types_handler.h
    • extensions/common/manifest_handlers/nacl_modules_handler.cc
    • extensions/common/manifest_handlers/nacl_modules_handler.h
    • extensions/common/manifest_handlers/oauth2_manifest_handler.cc
    • extensions/common/manifest_handlers/oauth2_manifest_handler.h
    • extensions/common/manifest_handlers/offline_enabled_info.cc
    • extensions/common/manifest_handlers/offline_enabled_info.h
    • extensions/common/manifest_handlers/options_page_info.cc
    • extensions/common/manifest_handlers/options_page_info.h
    • extensions/common/manifest_handlers/requirements_info.cc
    • extensions/common/manifest_handlers/requirements_info.h
    • extensions/common/manifest_handlers/sandboxed_page_info.cc
    • extensions/common/manifest_handlers/sandboxed_page_info.h
    • extensions/common/manifest_handlers/shared_module_info.cc
    • extensions/common/manifest_handlers/shared_module_info.h
    • extensions/common/manifest_handlers/web_accessible_resources_info.cc
    • extensions/common/manifest_handlers/web_accessible_resources_info.h
    • extensions/common/manifest_handlers/webview_info.cc
    • extensions/common/manifest_handlers/webview_info.h
    • extensions/common/manifest_url_handlers.cc
    • extensions/common/manifest_url_handlers.h
  10. [Extensions] Add ExtensionBuilder::SetBackgroundPage()

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:02:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e45791c333e37d708f566cefa072cdea77116778

    Comments

    [Extensions] Add ExtensionBuilder::SetBackgroundPage()
    
    Setting a background page is a pretty common operation in test
    extensions. Bake it into ExtensionBuilder.
    
    Use it in a small smattering of places, and add a unittest.
    
    Bug: 832958
    Change-Id: Iaa3464dfa183f990fb579d289f99271983344983
    Reviewed-on: https://chromium-review.googlesource.com/1013128
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550982}

    Changed files

    • chrome/renderer/extensions/extension_hooks_delegate_unittest.cc
    • extensions/browser/lazy_background_task_queue_unittest.cc
    • extensions/browser/runtime_data_unittest.cc
    • extensions/common/extension_builder.cc
    • extensions/common/extension_builder.h
    • extensions/common/extension_builder_unittest.cc
  11. Clean up VariableExpander

    Changed by ljustenohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:07:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ead3110f47a6112c5bb20c08dbe16c1e66446788

    Comments

    Clean up VariableExpander
    
    Removes unnecessary SetVariable method (can use constructor). Documents usage.
    
    BUG=chromium:829279
    TEST=Tryjobs
    
    Change-Id: I44ac2f93cd65fcd2e36814c659956fbdb0dc8277
    Reviewed-on: https://chromium-review.googlesource.com/1013937
    Reviewed-by: Dan Erat <derat@chromium.org>
    Commit-Queue: Lutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550983}

    Changed files

    • chrome/browser/chromeos/policy/active_directory_policy_manager.cc
    • chromeos/tools/variable_expander.cc
    • chromeos/tools/variable_expander.h
    • chromeos/tools/variable_expander_unittest.cc
  12. Reland: Keep poll intervals in prefs.

    Changed by tschumannohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:13:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90c716c882f40d47716c04d2263202df03228312

    Comments

    Reland: Keep poll intervals in prefs.
    
    Cause for breakage: Side effect in DCHECK() which wasn't exercised on trybots
    (apparently they have all DCHECKs enabled)
    
    Without persisting them, server-side provided intervals are less efficient on
    platforms with relatively short app lifetime.
    
    This also allows lower poll intervals for latency-sensitive use cases in cases
    when our notifications are not reliable enough (yet).
    
    Bug: 832019
    Change-Id: Ifcd55edcbb9fb17583caac847f6c110024a83e19
    Reviewed-on: https://chromium-review.googlesource.com/1013457
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Tim Schumann <tschumann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550984}

    Changed files

    • chrome/browser/sync/test/integration/sync_client_command_test.cc
    • chrome/test/BUILD.gn
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service_unittest.cc
    • components/suggestions/suggestions_service_impl_unittest.cc
    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/sync_service_base.cc
    • components/sync/driver/sync_service_utils_unittest.cc
    • components/sync/engine/cycle/sync_cycle_snapshot.cc
    • components/sync/engine/cycle/sync_cycle_snapshot.h
    • components/sync/engine/cycle/sync_cycle_snapshot_unittest.cc
    • components/sync/engine/engine_components_factory.h
    • components/sync/engine/engine_components_factory_impl.cc
    • components/sync/engine/engine_components_factory_impl.h
    • components/sync/engine/sync_engine.h
    • components/sync/engine/sync_manager.h
    • components/sync/engine/test_engine_components_factory.cc
    • components/sync/engine/test_engine_components_factory.h
    • components/sync/engine_impl/cycle/sync_cycle.cc
    • components/sync/engine_impl/cycle/sync_cycle_context.cc
    • components/sync/engine_impl/cycle/sync_cycle_context.h
    • components/sync/engine_impl/js_sync_manager_observer_unittest.cc
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/engine_impl/sync_scheduler_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl_unittest.cc
    • components/sync/engine_impl/syncer_proto_util.cc
    • components/sync/engine_impl/syncer_unittest.cc
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  13. Move and rename KeyboardAccessory

    Changed by fhorschigohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:14:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c7d603a43c408436b3d2d160276cf93dc34e836c

    Comments

    Move and rename KeyboardAccessory
    
    Please note that this move changes ownership of the accessory which is
    intended but not absolutely necessary.
    
    This move/rename serves several purposes beyond that:
    1) The accessory becomes an own component living in a separate package.
    2) All currently public functions should be accessed through the
      controller of the component and therefore be package-visible soon.
    3) It reduces size and confusion of the CL that wires the old view to
      the new controller.
    4) The name maps to its new role in go/android-accessory-for-manual-ui
    
    Bug: 828832
    Change-Id: Id54ce3db25c7e37bd6572e28aa8625b0e6868b9d
    Reviewed-on: https://chromium-review.googlesource.com/1012062
    Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550985}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
    • chrome/android/java_sources.gni
  14. Win Native Notifications: Add UMA for getSettings call.

    Changed by finnurohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:14:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a54940fa5f5ee07f1119b97e17499a8b35577c2

    Comments

    Win Native Notifications: Add UMA for getSettings call.
    
    Bug: 734095
    Change-Id: I3a7e869ca908e53436ff3e78f43f13af1dccedce
    Reviewed-on: https://chromium-review.googlesource.com/998032
    Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Xi Cheng <chengx@chromium.org>
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550986}

    Changed files

    • chrome/browser/notifications/notification_platform_bridge_win.cc
    • chrome/browser/notifications/notification_platform_bridge_win_metrics.cc
    • chrome/browser/notifications/notification_platform_bridge_win_metrics.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  15. [PH][Desktop] Block unsecure pages.

    Changed by rouslanohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:15:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99a348cf6378c095c86cb6dfc717b0453ab9e222

    Comments

    [PH][Desktop] Block unsecure pages.
    
    Before this patch, a payment handler page could be unsecure.
    
    This patch checks for the following conditions:
    - Unsecure origin.
    - Non-cryptographic scheme.
    - Invalid certificate.
    - Flagged in safe browsing database.
    If any of these conditions are hit, Chrome aborts payment by closing the
    payment handler page and showing an error message.
    
    After this patch, if a payment handler page is detected to be unsecure,
    Chrome closes the payment handler page and shows an error message.
    
    Bug: 828431
    Change-Id: Ifdc5a3e3ebf9c511f21aa03dee2d8d3230ac8b88
    Reviewed-on: https://chromium-review.googlesource.com/1012451
    Reviewed-by: anthonyvd <anthonyvd@chromium.org>
    Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550987}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.cc
    • chrome/browser/ui/views/payments/payment_handler_web_flow_view_controller.h
  16. Fix a process handle usage race in resource coordinator render probe.

    Changed by siggiohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:16:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb95666dc91287342eeaeb0bc82c032de379f0db

    Comments

    Fix a process handle usage race in resource coordinator render probe.
    
    The GetHandle function of RenderProcessHost returned a
    base::ProcessHandle, which cannot be passed around to other
    threads because the caller does not have ownership. This
    lead to handle abuse problems on Windows if the RPH goes
    away as the handle is being bounced around.
    This CL replaces the GetHandle function of RPH with a
    GetProcess function, which returns a const base::Process&.
    This in turn allows callers to duplicate the underlying
    base::Process, and the duplicate can then be safely bounced
    around to other threads.
    
    Bug: 821453
    Change-Id: I7d9956c3ab92352d99ccea70fde3f2013aa66d33
    Reviewed-on: https://chromium-review.googlesource.com/998213
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550988}

    Changed files

    • chrome/browser/android/tab_android.cc
    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chromeos/power/renderer_freezer.cc
    • chrome/browser/extensions/api/processes/processes_api.cc
    • chrome/browser/media/webrtc/webrtc_video_display_perf_browsertest.cc
    • chrome/browser/memory_details.cc
    • chrome/browser/metrics/process_memory_metrics_emitter.cc
    • chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
    • chrome/browser/performance_monitor/performance_monitor.cc
    • chrome/browser/prerender/prerender_contents.cc
    • chrome/browser/profiling_host/profiling_test_driver.cc
    • chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
    • chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
    • chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc
    • chrome/browser/spellchecker/spellcheck_service.cc
    • chrome/browser/task_manager/providers/render_process_host_task_provider.cc
    • chrome/browser/task_manager/providers/web_contents/renderer_task.cc
    • chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc
    • chrome/browser/ui/views/hung_renderer_view.cc
    • chrome/browser/ui/webui/memory_internals_ui.cc
    • components/crash/content/browser/crash_dump_observer_android.cc
    • components/heap_profiling/client_connection_manager.cc
    • content/browser/accessibility/captioning_controller.cc
    • content/browser/devtools/protocol/tracing_handler.cc
    • content/browser/frame_host/frame_tree_node_blame_context.cc
    • content/browser/memory/memory_coordinator_impl.cc
    • content/browser/memory/memory_coordinator_impl_unittest.cc
    • content/browser/renderer_host/pepper/pepper_file_io_host.cc
    • content/browser/renderer_host/render_process_host_impl.cc
    • content/browser/renderer_host/render_process_host_impl.h
    • content/browser/service_worker/service_worker_internals_ui.cc
    • content/browser/tracing/memory_instrumentation_browsertest.cc
    • content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc
    • content/public/browser/render_process_host.h
    • content/public/test/mock_render_process_host.cc
    • content/public/test/mock_render_process_host.h
    • content/shell/browser/layout_test/blink_test_controller.cc
    • extensions/browser/guest_view/web_view/web_view_guest.cc
    • extensions/browser/user_script_loader.cc
  17. Roll src/third_party/angle/ 152152618..20fa8d5cf (3 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Monday, 16-Apr-18 16:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1df5f316669bac548623cafd8b59c85f03ac63c

    Comments

    Roll src/third_party/angle/ 152152618..20fa8d5cf (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/152152618edf..20fa8d5cfe9e
    
    $ git log 152152618..20fa8d5cf --date=short --no-merges --format='%ad %ae %s'
    2018-04-15 jmadill Vulkan: Implement cube map texture sampling.
    2018-04-12 jiawei.shao Store shader information in ShaderMap in class Program and Compiler
    2018-03-19 oetuaho Store invariant declarations in variable metadata
    
    Created with:
      roll-dep src/third_party/angle
    
    
    The AutoR
    ...skip...
    ;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: Ided9c2c111013257fe41c34a7d74455f8c511a10
    Reviewed-on: https://chromium-review.googlesource.com/1014007
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#550989}

    Changed files

    • DEPS
  18. [subresource_filter] Introduce the rule_parser

    Changed by csharrisonohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:19:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6712a6ef834e3493ef53aed1f06587e74475c11

    Comments

    [subresource_filter] Introduce the rule_parser
    
    Bug: 833419
    Change-Id: I9b1d6f3b7b5c9229443b71f41d422d78be40ba8d
    Reviewed-on: https://chromium-review.googlesource.com/1014026
    Reviewed-by: Josh Karlin <jkarlin@chromium.org>
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550990}

    Changed files

    • components/subresource_filter/tools/BUILD.gn
    • components/subresource_filter/tools/rule_parser/BUILD.gn
    • components/subresource_filter/tools/rule_parser/rule.cc
    • components/subresource_filter/tools/rule_parser/rule.h
    • components/subresource_filter/tools/rule_parser/rule_options.h
    • components/subresource_filter/tools/rule_parser/rule_parser.cc
    • components/subresource_filter/tools/rule_parser/rule_parser.h
    • components/subresource_filter/tools/rule_parser/rule_parser_unittest.cc
    • components/subresource_filter/tools/rule_parser/rule_unittest.cc
  19. Adding new macbook airs to the luci configs

    Changed by eyaichohnoyoudont@google.com
    Changed at Monday, 16-Apr-18 16:19:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 45af85552c4bc1d674081a642167253c2e81a6f6

    Comments

    Adding new macbook airs to the luci configs
    
    Bug: 779634
    Change-Id: Iba3bed868177e7caa31714573c10eaae1a0571c1
    Reviewed-on: https://chromium-review.googlesource.com/1012200
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550991}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
  20. Revert "[af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled"

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:20:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f23f73bc7d1e81bdb97a9ec00c3cb3f074c4dab8

    Comments

    Revert "[af] Run AutofillInteractiveTest with AutofillExpandedPopupViews enabled"
    
    This reverts commit c3991fe1a8c3a8d8805d645e29e7f8af58ac366a.
    
    Reason for revert: Several tests became flaky on ChromeOS
     - crbug.com/c/833176
     - crbug.com/c/833237
     - crbug.com/c/833219
     - crbug.com/c/833127
     - crbug.com/c/833030
    
    This is not the first time a test becomes flaky on ChromeOS for the same reason: it hangs while waiting in SendKeyToPopupAndWait(). Giving such an issue has been there for a long time, I thin
    ...skip...
    Stade <estade@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#550759}
    
    TBR=rogerm@chromium.org,estade@chromium.org,tmartino@chromium.org,ftirelo@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 768881
    Change-Id: I157dcf789abfa57ad924a24967ab3ed83e48145c
    Reviewed-on: https://chromium-review.googlesource.com/1014141
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550992}

    Changed files

    • chrome/browser/autofill/autofill_interactive_uitest.cc
  21. Set timestamp of cloud policy in Enterprise reporting extension API.

    Changed by zminohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:20:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a4ca485c5152a2aab3d476a0ded31ee86a49c50

    Comments

    Set timestamp of cloud policy in Enterprise reporting extension API.
    
    Set the timestamp of last fetch time of MachineLevelUserCloudPolicy
    if it's enabled.
    
    Bug: 832907
    Change-Id: I80084e82932479b7e2ee29474f069c685d96f063
    Reviewed-on: https://chromium-review.googlesource.com/1013044
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Marc-André Decoste <mad@chromium.org>
    Commit-Queue: Owen Min <zmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550993}

    Changed files

    • chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
    • chrome/browser/policy/chrome_browser_policy_connector.cc
    • chrome/browser/policy/chrome_browser_policy_connector.h
  22. Allow base::DoNothing inside Blink.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:21:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feb613fce3f09303ed5b86e211e4f1c96f61fa16

    Comments

    Allow base::DoNothing inside Blink.
    
    Bug: None
    Change-Id: I98eeaff0d8de99074c6c3823bfcbe6a16ce0506b
    Reviewed-on: https://chromium-review.googlesource.com/1012109
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550994}

    Changed files

    • third_party/blink/tools/audit_non_blink_usage.py
  23. Make update URL optional for ExtensionInstallForcelist policy

    Changed by emaxxohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:23:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eaac2ff8f223413939db4b8f73eeb2010fbb6a6c

    Comments

    Make update URL optional for ExtensionInstallForcelist policy
    
    Don't require the "update" URL to be specified for the
    extension force installation policy. It should default to the
    Web Store URL.
    
    BUG=chromium:747944
    TEST=unit and browser tests
    
    Change-Id: I1dcf028573af5260f15a1dc92608192bd6a554a2
    Reviewed-on: https://chromium-review.googlesource.com/1008183
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550995}

    Changed files

    • chrome/browser/extensions/policy_handlers.cc
    • chrome/browser/extensions/policy_handlers_unittest.cc
    • chrome/browser/policy/policy_browsertest.cc
    • components/policy/resources/policy_templates.json
  24. Publish metrics for MachineLevelUserCloudPolicy cache age.

    Changed by zminohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:23:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078d283cc439cbb2d4816ca85d4f4256b298ab29

    Comments

    Publish metrics for MachineLevelUserCloudPolicy cache age.
    
    Bug: 812641
    Change-Id: Iea73bd9ead16bbda3e8a10576072f5b968d9ad35
    Reviewed-on: https://chromium-review.googlesource.com/1013079
    Reviewed-by: Jesse Doherty <jwd@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Commit-Queue: Owen Min <zmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550996}

    Changed files

    • components/policy/core/common/cloud/cloud_policy_service.cc
    • tools/metrics/histograms/histograms.xml
  25. Add SK_SUPPORT_LEGACY_THREADED_DAA_BUGS

    Changed by liyuqianohnoyoudont@google.com
    Changed at Monday, 16-Apr-18 16:24:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5069f8e5d080c7b39454fdf6d63786589f2c35f6

    Comments

    Add SK_SUPPORT_LEGACY_THREADED_DAA_BUGS
    
    Change-Id: I41d086b4f3754d08c1cb8952a9f0da35cd170a43
    Reviewed-on: https://chromium-review.googlesource.com/1013609
    Reviewed-by: Leon Scroggins <scroggo@chromium.org>
    Commit-Queue: Yuqian Li <liyuqian@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550997}

    Changed files

    • skia/config/SkUserConfig.h
  26. Don't access ThrottlingURLLoader after calls to |forwarding_client_|

    Changed by csharrisonohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:25:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5adb57729a62738e98a6d6bdb797c1a4e678daca

    Comments

    Don't access ThrottlingURLLoader after calls to |forwarding_client_|
    
    The contract for |forwarding_client_| is that the implementation is
    free to delete the loader synchronously after calling any of its
    methods.
    
    There is one case where we reach into |this| after doing so, which this
    CL fixes.
    
    Bug: 833292
    Change-Id: Ic5e41649da9e692407f0433a72d2d784f174497b
    Reviewed-on: https://chromium-review.googlesource.com/1014024
    Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550998}

    Changed files

    • content/common/throttling_url_loader.cc
    • content/common/throttling_url_loader_unittest.cc
  27. AuthPolicyCredentialsManager: Create kerberos dir

    Changed by rsorokinohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:26:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bb381fb0a01947402d38973ce197f21e2dc5e44

    Comments

    AuthPolicyCredentialsManager: Create kerberos dir
    
    Create directory for credentials cache and krb5.conf
    Fixing regression was introduced in CL:974108.
    
    BUG=815158
    TEST=manual
    
    Change-Id: I9ec9ce411de25df504e165c1b1a025e5878c3ae7
    Reviewed-on: https://chromium-review.googlesource.com/1013921
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#550999}

    Changed files

    • chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
  28. Check for offline pages before extracting the publisher URL header.

    Changed by bauerbohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:27:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2859256fa4846e8670df0ada8a2a8e961ce41c93

    Comments

    Check for offline pages before extracting the publisher URL header.
    
    Offline page loads don't have headers attached to the navigation
    handle, which would otherwise cause a DCHECK / crash when trying to
    read the header.
    
    Bug: 829323
    Change-Id: I04118b7a80816f65b42e1d2be78a56f61c1a1cb1
    Reviewed-on: https://chromium-review.googlesource.com/1012025
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Reviewed-by: Dmitry Titov <dimich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551000}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/TrustedCdnPublisherUrlTest.java
    • chrome/browser/android/tab_android.cc
  29. Import wpt@84e7972a0518fb57f39740143d4b63e79b14e9f4

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:27:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec5cb40ce109285c1bd1b956f1d5757710565aee

    Comments

    Import wpt@84e7972a0518fb57f39740143d4b63e79b14e9f4
    
    Using wpt-import in Chromium 9702d1ea11b6bd4077f8066239cfa5bffc1f0d90.
    With Chromium commits locally applied on WPT:
    303956b6ed "Enable WPT tests for the Generic Sensor classes"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15651
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExp
    ...skip...
    lan@chromium.org, mathp@chromium.org:
      external/wpt/payment-request
    yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
      external/wpt/fetch
    
    TBR=raphael.kubo.da.costa@intel.com
    
    No-Export: true
    Change-Id: Ia9bd9207a039d0f67f40fc1febb6dc002b0ad4e8
    Reviewed-on: https://chromium-review.googlesource.com/1013753
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551001}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/scheme-about.any-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/scheme-about.any.js
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/basic/scheme-about.any.worker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/headers/header-values-normalize.html
    • third_party/WebKit/LayoutTests/external/wpt/fetch/api/headers/header-values.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/change-shipping-option-select-last-manual.https.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/payment-request-show-method.https.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/show-method-optional-promise-rejects-manual.https.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/show-method-optional-promise-resolves-manual.https.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/show-method-postmessage-iframe.html
    • third_party/WebKit/LayoutTests/external/wpt/payment-request/show-method-postmessage-manual.https.html
    • third_party/WebKit/LayoutTests/external/wpt/xhr/send-content-type-charset-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/xhr/send-content-type-charset.htm
  30. [wasm] Fix wasm_downgrade_test

    Changed by ahaasohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:28:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision baace4d952592e8f49d42657b2649cd6d7f504ae

    Comments

    [wasm] Fix wasm_downgrade_test
    
    The wasm_downgrade_test uses special testing functions which allow to
    serialize and deserialize a WebAssembly module. The deserialization
    function takes a DOMArrayBuffer as parameter, converts it into a String,
    and then uses the String to create a SerializedScriptValue. However,
    if the length of the DOMArrayBuffer is not even, one byte gets lost
    in the conversion to a String. With this CL we create the
    SerializedScriptValue directly from the DOMArrayBuffer, and thereby
    
    ...skip...
    the conversion to a String was hiding another bug
    which I'm currently fixing in V8. As soon as the fix in V8 rolled to
    Chrome, we can continue with this CL.
    
    R=binji@chromium.org, pkasting@chromium.org
    
    Change-Id: I65b35676b764cd3d64c437b331510897b032b33b
    Reviewed-on: https://chromium-review.googlesource.com/1006962
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Reviewed-by: Ben Smith <binji@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551002}

    Changed files

    • third_party/blink/renderer/core/testing/internals.cc
  31. Remove switch gating USM account support.

    Changed by brunokimohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:28:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4de5d3e64b5f4b678343ec2083ef5066f2d7e5e9

    Comments

    Remove switch gating USM account support.
    
    This switch is not useful for controlling feature launch. The rollout of
    USM accounts itself will be gradual and staged, so we can respond to any
    issues that arise on Chrome in future versions.
    
    Bug: 826299
    Change-Id: Ib18935f38584d0ad6fb19aee10c769993a95b89a
    Reviewed-on: https://chromium-review.googlesource.com/1012242
    Commit-Queue: Bruno Kim Medeiros Cesar <brunokim@chromium.org>
    Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551003}

    Changed files

    • components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerFacade.java
    • components/signin/core/browser/android/junit/src/org/chromium/components/signin/test/AccountManagerFacadeTest.java
  32. [Unity][Android] Update layout for the sign-in screen

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:37:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f2a4f0aefbef0cb1969b02698ed04d241940e33

    Comments

    [Unity][Android] Update layout for the sign-in screen
    
    This CL makes several changes to the layout of the streamlined sign-in
    screen:
    1. Hide secondary TextView in the account picker widget if there's
       no full name available for the account. This includes changing IDs of
       TextViews, replacing RelativeLayout with two LinearLayouts and some
       changes in SigninFragmentBase code. See https://crrev.com/c/1010484
       for similar changes in AccountPickerDialogFragment.
    2. Revise text style for TextViews in SigninView: replace BlackHint2
       with BlackBody. These two styles are identical, but used in different
       contexts.
    3. Reorder some XML attributes to match AS ordering (it follows
       start-top-end-bottom ordering).
    
    Bug: 814728
    Change-Id: I4a974e3e9360aaa3468f7410315ed8af8cfcdfe4
    Reviewed-on: https://chromium-review.googlesource.com/1012841
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551004}

    Changed files

    • chrome/android/java/res/layout/signin_view.xml
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninFragmentBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninView.java
  33. [jumbo] avoid 'declaration shadows a variable' warnings

    Changed by mostynbohnoyoudont@vewd.com
    Changed at Monday, 16-Apr-18 16:38:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6558385bba1d80b80f641f9b73cfb214d1e771a8

    Comments

    [jumbo] avoid 'declaration shadows a variable' warnings
    
    CL https://chromium-review.googlesource.com/c/chromium/src/+/1008824 added
    two consts inside SessionStorageDataMap::GetOptions() that shadow existing
    consts and generate warnigs in jumbo builds.  These consts were only
    used once each, so we may as well just use the values directly.
    
    TBR=dmurph@chromium.org
    
    Bug: 716490
    Change-Id: I09505a9df50ef6d3cc2bc002254027cd791cdcdf
    Reviewed-on: https://chromium-review.googlesource.com/1013458
    Reviewed-by: Daniel Bratell <bratell@opera.com>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#551005}

    Changed files

    • content/browser/dom_storage/session_storage_data_map.cc
  34. VaVDA: Move BlitSurface to |decoder_thread_task_runner_|

    Changed by mcasasohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:39:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 051ec184287440813ad2ae4f515f6d99a16e764d

    Comments

    VaVDA: Move BlitSurface to |decoder_thread_task_runner_|
    
    This CL moves the call to VaapiPicture::DownloadFromSurface,
    which in turn calls VaapiWrapper::BlitSurface(), to be executed
    in the decoder thread of VaVDA. This considerable offloads the
    Gpu main thread for more urgent tasks, and anyway the said
    decoder thread is idle most of the time (seen in chrome:trace),
    so utilizing it more doesn't impact the overall performance but
    increases responsiveness.
    
    This Chrome:tracing details shows the change (
    ...skip...
    rybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Icc4af2ef96141cebf95ac8fbb89c6e386e194a30
    Reviewed-on: https://chromium-review.googlesource.com/947341
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551006}

    Changed files

    • media/gpu/vaapi/vaapi_picture_native_pixmap.cc
    • media/gpu/vaapi/vaapi_picture_tfp.cc
    • media/gpu/vaapi/vaapi_video_decode_accelerator.cc
    • media/gpu/vaapi/vaapi_video_decode_accelerator.h
    • media/gpu/video_decode_accelerator_unittest.cc
  35. Replace @UseMethodParam annotation with generator classes.

    Changed by bauerbohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:39:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a6a54b3a2b90ff125fc7d9da2c151979ced46120

    Comments

    Replace @UseMethodParam annotation with generator classes.
    
    Change-Id: I839b4f520300b17e3ba22cf0ea62d2a03b376c5e
    Reviewed-on: https://chromium-review.googlesource.com/760419
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551007}

    Changed files

    • android_webview/tools/system_webview_shell/page_cycler/src/org/chromium/webview_shell/page_cycler/PageCyclerTest.java
    • base/BUILD.gn
    • base/android/proguard/chromium_apk.flags
    • base/test/android/javatests/src/org/chromium/base/test/params/MethodParamAnnotationRule.java
    • base/test/android/javatests/src/org/chromium/base/test/params/MethodParamRule.java
    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterAnnotations.java
    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterProvider.java
    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterSet.java
    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterizedRunner.java
    • base/test/android/javatests/src/org/chromium/base/test/params/ParameterizedRunnerDelegateFactory.java
    • base/test/android/junit/src/org/chromium/base/test/params/ExampleParameterizedTest.java
    • base/test/android/junit/src/org/chromium/base/test/params/ParameterizedRunnerDelegateFactoryTest.java
    • base/test/android/junit/src/org/chromium/base/test/params/ParameterizedRunnerTest.java
    • base/test/android/junit/src/org/chromium/base/test/params/ParameterizedTestNameTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
  36. Add name to hosted_ui quad

    Changed by asimjourohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:42:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53ee48359a4b2684b1970abc0d2a9ffcd62d7fc

    Comments

    Add name to hosted_ui quad
    
    This will make it easier to write tests and send events directly
    to the dialog.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib9a25666a213e1279a6491bd61331b4e7c8321e4
    Reviewed-on: https://chromium-review.googlesource.com/1012917
    Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
    Reviewed-by: Yash Malik <ymalik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551008}

    Changed files

    • chrome/browser/vr/elements/ui_element_name.cc
    • chrome/browser/vr/elements/ui_element_name.h
    • chrome/browser/vr/ui_scene_creator.cc
  37. Roll src/third_party/catapult/ ac39bc379..dc1e62593 (2 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Monday, 16-Apr-18 16:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b578253a4ded3129aeba6147ebb98fe7e355af0

    Comments

    Roll src/third_party/catapult/ ac39bc379..dc1e62593 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/ac39bc379194..dc1e62593e6c
    
    $ git log ac39bc379..dc1e62593 --date=short --no-merges --format='%ad %ae %s'
    2018-04-16 simonhatch Dashboard - Remove code/command_line from TestMetadata.
    2018-04-16 simonhatch Dashboard - Remove debug log statement.
    
    Created with:
      roll-dep src/third_party/catapult
    
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the
    ...skip...
     sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=sullivan@chromium.org
    
    Change-Id: I7bd186e0b22267e61c73b1e0b0cbcaf1377a22a3
    Reviewed-on: https://chromium-review.googlesource.com/1012731
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#551009}

    Changed files

    • DEPS
  38. [vr] Fix shadow offsets

    Changed by vollickohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:43:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a9741a3c07624404f14c5f32175335109d83e48c

    Comments

    [vr] Fix shadow offsets
    
    Gives the omnibox a soft shadow.
    
    Bug: 833375
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
    Change-Id: I17b9bbf4fdd2d8830e0157ddfd6b9ef57008ecb2
    Reviewed-on: https://chromium-review.googlesource.com/1014010
    Commit-Queue: Christopher Grant <cjgrant@chromium.org>
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551010}

    Changed files

    • chrome/browser/vr/ui_scene_creator.cc
  39. [Squad] Allow CustomStyleForLayoutObject() in reattach recalc.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c342738138a4b1ae2e53a6f25c7e5e8892006eb

    Comments

    [Squad] Allow CustomStyleForLayoutObject() in reattach recalc.
    
    We did not allow recalculating style for reattachment as part of
    RecalcStyle when we had custom style hooks because some elements had
    CustomStyleForLayoutObject() methods which depended on parent layout
    objects. This is no longer true, so we can now always recalc style for
    re-attachment. That means we'll also need to call custom style hooks
    WillRecalcStyle/DidRecalcStyle for re-attacment styles as well.
    
    Bug: 813057
    Change-Id: I403c30e0f9f6934bd96d3da84488a6b3c489a50e
    Reviewed-on: https://chromium-review.googlesource.com/925702
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551011}

    Changed files

    • third_party/blink/renderer/core/dom/element.cc
  40. Onion-soupify blink leak detector

    Changed by dgozmanohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 16:55:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90c5a2575c6780b648e65233449d7bfe8780a7fd

    Comments

    Onion-soupify blink leak detector
    
    - Expose LeakDetector interface in render process, remove unneeded plumbing.
    - Switch from IPCs to Mojo in layout test runner.
    - Move implementation to controller.
    - Migrate inspector usage to browser.
    - Merged two methods of LeakDetector into a single one.
    - Fixed leaks in existing tests.
    
    Needs a followup to not register fetchers in leak detector,
    but instead have a collection in ResourceFetcher.
    
    Change-Id: Iba0ffc95de5b8beb27409b4eb51435c5e1397951
    Reviewed-on: https://chromium-review.googlesource.com/999170
    Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
    Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551012}

    Changed files

    • chrome/renderer/autofill/page_passwords_analyser_browsertest.cc
    • chrome/renderer/autofill/password_autofill_agent_browsertest.cc
    • components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
    • content/browser/DEPS
    • content/browser/devtools/protocol/memory_handler.cc
    • content/browser/devtools/protocol/memory_handler.h
    • content/browser/devtools/protocol_config.json
    • content/public/app/mojo/content_renderer_manifest.json
    • content/public/test/render_view_test.cc
    • content/public/test/render_view_test.h
    • content/shell/BUILD.gn
    • content/shell/browser/layout_test/blink_test_controller.cc
    • content/shell/browser/layout_test/blink_test_controller.h
    • content/shell/browser/layout_test/leak_detector.cc
    • content/shell/browser/layout_test/leak_detector.h
    • content/shell/common/leak_detection_result.h
    • content/shell/common/shell_messages.h
    • content/shell/renderer/layout_test/blink_test_runner.cc
    • content/shell/renderer/layout_test/blink_test_runner.h
    • content/shell/renderer/layout_test/leak_detector.cc
    • content/shell/renderer/layout_test/leak_detector.h
    • content/shell/test_runner/web_frame_test_client.cc
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/leak_detector/OWNERS
    • third_party/blink/public/mojom/leak_detector/leak_detector.mojom
    • third_party/blink/public/web/web_leak_detector.h
    • third_party/blink/renderer/controller/BUILD.gn
    • third_party/blink/renderer/controller/blink_initializer.cc
    • third_party/blink/renderer/controller/blink_initializer.h
    • third_party/blink/renderer/controller/blink_leak_detector.cc
    • third_party/blink/renderer/controller/blink_leak_detector.h
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/core_initializer.h
    • third_party/blink/renderer/core/css/css_default_style_sheets.h
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/inspector/InspectorMemoryAgent.cpp
    • third_party/blink/renderer/core/inspector/InspectorMemoryAgent.h
    • third_party/blink/renderer/core/inspector/inspector_protocol_config.json
    • third_party/blink/renderer/core/leak_detector/BUILD.gn
    • third_party/blink/renderer/core/leak_detector/README.md
    • third_party/blink/renderer/core/leak_detector/blink_leak_detector.h
    • third_party/blink/renderer/core/leak_detector/blink_leak_detector_client.h
    • third_party/blink/renderer/core/leak_detector/web_leak_detector.cc
    • third_party/blink/renderer/core/loader/frame_fetch_context.cc
    • third_party/blink/renderer/modules/modules_initializer.cc
  41. Roll src/third_party/chromite/ c90ccbc26..d88eaf531 (1 commit)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Monday, 16-Apr-18 16:58:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b3eb773cd8b17c9aa4f37190d30d1040242d18c0

    Comments

    Roll src/third_party/chromite/ c90ccbc26..d88eaf531 (1 commit)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/c90ccbc26d04..d88eaf5315d4
    
    $ git log c90ccbc26..d88eaf531 --date=short --no-merges --format='%ad %ae %s'
    2018-04-15 cmtice [release builders] Disable CFI on caroline & terra.
    
    Created with:
      roll-dep src/third_party/chromite
    BUG=chromium:830321
    
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://sk
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I9289723920afdf2dda519c0cb1c750efadc2f29f
    Reviewed-on: https://chromium-review.googlesource.com/1014175
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#551013}

    Changed files

    • DEPS
  42. Removes the old ios/chrome/browser/prefs/pref_observer_bridge.h

    Changed by mahmadiohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:09:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69bb77c1d2aec5d08e20921e2d11d1b0d22facca

    Comments

    Removes the old ios/chrome/browser/prefs/pref_observer_bridge.h
    
    This is a follow up CL to crrev.com/c/1011102. It removes the old header
    file that was kept around in order to avoid breaking ios downstream.
    
    TBR=pkl@
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: I53034903eeae0bfcae20cf048fd6ced845e02e06
    Reviewed-on: https://chromium-review.googlesource.com/1014188
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551014}

    Changed files

    • ios/chrome/browser/prefs/BUILD.gn
    • ios/chrome/browser/prefs/pref_observer_bridge.h
  43. Rename file cone.* to cone_effect.*

    Changed by rtoyohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:15:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bf6c8d4e1e7ea2bb938527cf0d7281ec0651d61f

    Comments

    Rename file cone.* to cone_effect.*
    
    The class is named ConeEffect but the file was cone.h and cone.cc.
    Rename the files to cone_effect.h and cone_effect.cc
    
    Fix a blink style issue in cone_effects.cc too.
    
    Bug: 832708
    Change-Id: I5acd880ba61cd1597c10e488aa318e939ac1c321
    Reviewed-on: https://chromium-review.googlesource.com/1011455
    Reviewed-by: Hongchan Choi <hongchan@chromium.org>
    Commit-Queue: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551015}

    Changed files

    • third_party/blink/renderer/modules/webaudio/panner_node.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/audio/cone_effect.cc
    • third_party/blink/renderer/platform/audio/cone_effect.h
  44. ash Login screen: Fix a regression with SmartLock login.

    Changed by jhawkinsohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:16:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3bc4da52338572d88e2e608068ee6e6f483faa0

    Comments

    ash Login screen: Fix a regression with SmartLock login.
    
    In previous implementations of the login screen, a user with SmartLock
    enabled could press return with an empty password field in order to
    authenticate. This behavior appears to not have been carried over in the
    newer Views implementation.
    
    The fix is to special case the auth attempt and divert the attempt to
    the SmartLock flow in the case where the user has tap-to-unlock and the
    password field is empty.
    
    R=xiyuan@chromium.org
    
    Bug: 818400
    Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled
    Change-Id: I1ecaba0d285fd43b231ca8028c19b0682f073b77
    Reviewed-on: https://chromium-review.googlesource.com/1013398
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551016}

    Changed files

    • ash/login/ui/login_auth_user_view.cc
    • ash/login/ui/login_auth_user_view_unittest.cc
  45. Generate de-facto DEPS for platform/ subfolders to be able to visualize and reason about them.

    Changed by pfeldmanohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:18:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a060a3f35448263c295ceaea0c9055d0cd511726

    Comments

    Generate de-facto DEPS for platform/ subfolders to be able to visualize and reason about them.
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I7aa90dcc7026df4c14950b5f0aee21134fe9ddb0
    Reviewed-on: https://chromium-review.googlesource.com/1013335
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551017}

    Changed files

    • third_party/blink/renderer/platform/animation/DEPS
    • third_party/blink/renderer/platform/audio/DEPS
    • third_party/blink/renderer/platform/bindings/DEPS
    • third_party/blink/renderer/platform/blob/DEPS
    • third_party/blink/renderer/platform/clipboard/DEPS
    • third_party/blink/renderer/platform/feature_policy/DEPS
    • third_party/blink/renderer/platform/fonts/DEPS
    • third_party/blink/renderer/platform/geometry/DEPS
    • third_party/blink/renderer/platform/graphics/DEPS
    • third_party/blink/renderer/platform/heap/DEPS
    • third_party/blink/renderer/platform/image-decoders/DEPS
    • third_party/blink/renderer/platform/image-encoders/DEPS
    • third_party/blink/renderer/platform/instrumentation/DEPS
    • third_party/blink/renderer/platform/json/DEPS
    • third_party/blink/renderer/platform/loader/DEPS
    • third_party/blink/renderer/platform/mac/DEPS
    • third_party/blink/renderer/platform/media/DEPS
    • third_party/blink/renderer/platform/mediastream/DEPS
    • third_party/blink/renderer/platform/mhtml/DEPS
    • third_party/blink/renderer/platform/mojo/DEPS
    • third_party/blink/renderer/platform/network/DEPS
    • third_party/blink/renderer/platform/peerconnection/DEPS
    • third_party/blink/renderer/platform/plugins/DEPS
    • third_party/blink/renderer/platform/probe/DEPS
    • third_party/blink/renderer/platform/scheduler/DEPS
    • third_party/blink/renderer/platform/scroll/DEPS
    • third_party/blink/renderer/platform/speech/DEPS
    • third_party/blink/renderer/platform/testing/DEPS
    • third_party/blink/renderer/platform/text/DEPS
    • third_party/blink/renderer/platform/threading/DEPS
    • third_party/blink/renderer/platform/transforms/DEPS
    • third_party/blink/renderer/platform/weborigin/DEPS
  46. Autoplay: Allow autoplay in extension iframes

    Changed by beccahughesohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:19:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79adc2fa9d165278cb54e61ad5f2c356fe96ce62

    Comments

    Autoplay: Allow autoplay in extension iframes
    
    If an extension has an <iframe> it should be allowed to autoplay.
    
    BUG=821284
    
    Change-Id: I1e11cbdef6a81acf5ea3e6d3dcaadc8c13464c16
    Reviewed-on: https://chromium-review.googlesource.com/962803
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551018}

    Changed files

    • chrome/browser/extensions/autoplay_browsertest.cc
    • chrome/browser/extensions/chrome_extension_web_contents_observer.cc
    • chrome/browser/extensions/chrome_extension_web_contents_observer.h
    • chrome/browser/extensions/extension_webkit_preferences.cc
    • chrome/test/data/extensions/autoplay_hosted_app/main.html
    • chrome/test/data/extensions/autoplay_hosted_app/main.js
    • chrome/test/data/extensions/autoplay_iframe/frame.html
    • chrome/test/data/extensions/autoplay_iframe/frame.js
    • chrome/test/data/extensions/autoplay_iframe/main.html
    • chrome/test/data/extensions/autoplay_iframe/main.js
    • chrome/test/data/extensions/autoplay_iframe/manifest.json
    • testing/buildbot/filters/mash.browser_tests.filter
    • third_party/blink/public/platform/autoplay.mojom
    • third_party/blink/renderer/core/html/media/autoplay_policy.cc
    • third_party/blink/renderer/core/html/media/autoplay_policy.h
  47. Add a Mojo-based transportation layer for Perfetto

    Changed by oysteineohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:21:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4df8a2dd8f3b875773af061c1cbdcc519d19b283

    Comments

    Add a Mojo-based transportation layer for Perfetto
    
    This adds a base layer that individual logging protocols (like tracing)
    can use to send their data to Perfetto, using Mojo messaging and
    shared memory.
    
    First CL of several, after this comes the Chrome tracing layer: https://chromium-review.googlesource.com/c/chromium/src/+/981270
    
    A preview of the full integration can be seen here: https://chromium-review.googlesource.com/c/chromium/src/+/852808
    
    The design doc for the integration: https://docs.google.com/document/d/1a8lvN3zYWEyAsBjtuRRsy0fWOWdUdbw6bGnKLBscGdw/edit
    
    R=primiano@chromium.org,skyostil@chromium.org
    
    Change-Id: Ie1db5745ebffdcf1e2d74e2f6b12395f447c8552
    Reviewed-on: https://chromium-review.googlesource.com/980578
    Reviewed-by: oysteine <oysteine@google.com>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Primiano Tucci <primiano@chromium.org>
    Commit-Queue: oysteine <oysteine@google.com>
    Cr-Commit-Position: refs/heads/master@{#551019}

    Changed files

    • DEPS
    • services/tracing/BUILD.gn
    • services/tracing/DEPS
    • services/tracing/manifest.json
    • services/tracing/perfetto/perfetto_integration_unittest.cc
    • services/tracing/perfetto/perfetto_service.cc
    • services/tracing/perfetto/perfetto_service.h
    • services/tracing/perfetto/producer_host.cc
    • services/tracing/perfetto/producer_host.h
    • services/tracing/public/cpp/BUILD.gn
    • services/tracing/public/cpp/perfetto/producer_client.cc
    • services/tracing/public/cpp/perfetto/producer_client.h
    • services/tracing/public/cpp/perfetto/shared_memory.cc
    • services/tracing/public/cpp/perfetto/shared_memory.h
    • services/tracing/public/cpp/perfetto/task_runner.cc
    • services/tracing/public/cpp/perfetto/task_runner.h
    • services/tracing/public/cpp/tracing_features.cc
    • services/tracing/public/cpp/tracing_features.h
    • services/tracing/public/mojom/BUILD.gn
    • services/tracing/public/mojom/perfetto_service.mojom
  48. Revert "Fix extensions badges and decorations positions"

    Changed by afakhryohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:25:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 71a2cc1b3292d9b4c5128da2db008e843e3b608c

    Comments

    Revert "Fix extensions badges and decorations positions"
    
    This reverts commit 94f048689670a751702fdd2e3c0b56e403d38964.
    
    Reason for revert: This doesn't work for PWAs, I will reland with a better fix so that it can be merged as a single CL.
    
    Original change's description:
    > Fix extensions badges and decorations positions
    > 
    > The extensions browser actions badges and decorations should
    > be positioned at the corners of the icon area, rather than the
    > corners of the full button's area (i.e. ignoring t
    ...skip...
    eue: Ahmed Fakhry <afakhry@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#550855}
    
    TBR=thestig@chromium.org,rdevlin.cronin@chromium.org,afakhry@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 831946
    Change-Id: I718ab6842d4bf55f5f1cf6f833e3638974c2fea8
    Reviewed-on: https://chromium-review.googlesource.com/1012734
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551020}

    Changed files

    • chrome/browser/ui/extensions/icon_with_badge_image_source.cc
    • chrome/browser/ui/extensions/icon_with_badge_image_source.h
  49. components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.

    Changed by jhawkinsohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:29:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0a774c419063fd86a2bbabe2cec0790eff7faf8

    Comments

    components/cryptauth: Remove unused bluetooth_address field from RemoteDevice.
    
    R=hansberry@chromium.org
    
    Bug: 829039
    Test: none
    Change-Id: I4216ffa94963a3f2bfdab08b73dd135fd78f4007
    Reviewed-on: https://chromium-review.googlesource.com/1012981
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551021}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
    • chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
    • chromeos/components/proximity_auth/messenger_impl_unittest.cc
    • chromeos/components/proximity_auth/proximity_auth_system_unittest.cc
    • chromeos/components/proximity_auth/proximity_monitor_impl_unittest.cc
    • chromeos/components/proximity_auth/remote_device_life_cycle_impl.cc
    • chromeos/components/proximity_auth/remote_device_life_cycle_impl_unittest.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • components/cryptauth/connection.cc
    • components/cryptauth/connection.h
    • components/cryptauth/connection_unittest.cc
    • components/cryptauth/cryptauth_test_util.h
    • components/cryptauth/device_to_device_authenticator_unittest.cc
    • components/cryptauth/fake_connection.cc
    • components/cryptauth/fake_connection.h
    • components/cryptauth/remote_device.cc
    • components/cryptauth/remote_device.h
    • components/cryptauth/remote_device_loader.cc
    • components/cryptauth/remote_device_loader_unittest.cc
  50. Reland "Use new Skia GPU read/write pixel code paths"

    Changed by bsalomonohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 613f554306490882f0f3050f5d068f23dc050b08

    Comments

    Reland "Use new Skia GPU read/write pixel code paths"
    
    This reverts commit 56044665258df106f9c5dd353ed9662cab28aefd.
    
    Reason for revert: Fast paths for premul/unpremul RGBA added to new code paths to accelerate get/putImageData.
    
    Original change's description:
    > Revert "Use new Skia GPU read/write pixel code paths"
    > 
    > This reverts commit f17c70fe460c6841913bb61f68bb8e89f16e663f.
    > 
    > Reason for revert: 
    > 
    > It looks like this change:
    > 
    > slowed down the file___static_top_25_weather.html rasterize_
    ...skip...
    ommit-Position: refs/heads/master@{#545787}
    
    TBR=bsalomon@chromium.org,robertphillips@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 825594, 825585
    Change-Id: I82434eebb65257cf6a92225c2c862fe22aecf093
    Reviewed-on: https://chromium-review.googlesource.com/1014140
    Reviewed-by: Brian Salomon <bsalomon@chromium.org>
    Reviewed-by: Robert Phillips <robertphillips@google.com>
    Commit-Queue: Brian Salomon <bsalomon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551022}

    Changed files

    • skia/config/SkUserConfig.h
  51. Fix app icon issue after long press in folder

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:36:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0088115194c7b314d154103bea63f95cb8acdadf

    Comments

    Fix app icon issue after long press in folder
    
    Background:
    Long press on app icon in folder will enlarge the icon, but release will
    not reset it. The long press gesture event is not handled by
    AppListItemView, thus passed to AppsGridView which handles it. The
    gesture end event will thus be sent to AppsGridView directly without
    going through AppListItemView. This is caused by go/cgcl/987293
    
    Change:
    Only handle the scroll begin event in AppsGridView if in folder instead
    of all gesture events.
    
    BUG=830982
    
    Change-Id: I2ca5bddaf22cd198d6e9cca5ee5f04c9798153e8
    Reviewed-on: https://chromium-review.googlesource.com/1008906
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551023}

    Changed files

    • ui/app_list/views/apps_grid_view.cc
  52. [iOS] Removing client secret

    Changed by jlebelohnoyoudont@chromium.org
    Changed at Monday, 16-Apr-18 17:36:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9aeb35ea7faf7d028828a5690d20a9e1c3d2e6b2

    Comments

    [iOS] Removing client secret
    
    Client secret is not use on Chrome iOS, and the API is removed from SSO.
    Related to crrev.com/c/975127 and crrev.com/i/480972.
    
    Bug: 516021
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: If590ae3db2959b2146b6d27a606745ef749050ec
    Reviewed-on: https://chromium-review.googlesource.com/973229
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551024}

    Changed files

    • components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.h
    • components/signin/ios/browser/fake_profile_oauth2_token_service_ios_provider.mm
    • components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.mm
    • components/signin/ios/browser/profile_oauth2_token_service_ios_provider.h
    • components/signin/ios/browser/profile_oauth2_token_service_ios_provider.mm
    • ios/chrome/browser/signin/constants.h
    • ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.h
    • ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm
    • ios/public/provider/chrome/browser/signin/chrome_identity_service.h
    • ios/public/provider/chrome/browser/signin/chrome_identity_service.mm
    • ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
    • ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm
    • ios/web_view/internal/signin/web_view_profile_oauth2_token_service_ios_provider_impl.h
    • ios/web_view/internal/signin/web_view_profile_oauth2_token_service_ios_provider_impl.mm
    • ios/web_view/public/cwv_authentication_controller_delegate.h