Home | Search
Login

Builder WebKit Mac10.11 (retina) Build #20475 Apple OSX

Results:

build successful

Trigger Info:

Got Revision1e54f71ef43dee5f77d71aa53a626d1292ee637b

Execution:

Steps and Logfiles:

Show:
  1. ( 15 mins 34 secs ) steps
    running steps via annotated script
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 47 secs ) bot_update
    bot_update
    [79GB/465GB used (16%)]
  8. ( 1 ms ) ensure_goma
    ensure_goma
  9. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  10. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.10.2
  11. ( 1 ms ) ensure_installed
    ensure_installed
  12. ( 9 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 1 ms ) read test spec (chromium.webkit.json)
    read test spec (chromium.webkit.json)
    path: /b/c/b/mac/src/testing/buildbot/chromium.webkit.json
  15. ( 1 ms ) build directory
    build directory
  16. ( 13 secs ) extract build
    extract build
  17. ( 4 ms ) find isolated tests
    find isolated tests
  18. ( 3 ms ) test_pre_run
    test_pre_run
  19. ( 4 ms ) test_pre_run.[trigger] webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.12.6
    test_pre_run.[trigger] webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
  20. ( 12 mins 33 secs ) webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.12.6
    webkit_layout_tests on ATI GPU on Mac Retina on Mac-10.12.6
    Run on OS: 'Mac-10.12.6'
    Max shard duration: 0:09:08.296900 (shard #5)
    Total tests: 74441
    * Passed: 59959 (59863 expected, 96 unexpected)
    * Skipped: 13011 (13011 expected, 0 unexpected)
    * Failed: 1428 (1428 expected, 0 unexpected)
    * Flaky: 43 (43 expected, 0 unexpected)
     
  21. ( 1 mins ) Upload to test-results [webkit_layout_tests on ATI GPU on Mac Retina]
    Upload to test-results [webkit_layout_tests on ATI GPU on Mac Retina]
  22. ( 11 secs ) archive_webkit_tests_results
    archive_webkit_tests_results
  23. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.webkit/WebKit_Mac10.11__retina_/20475/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.webkit/WebKit_Mac10.11__retina_/20475" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "64e5ed2abd8a4cc77d3647e4b245db57a8c42ae5" Annotation(bot_update)
got_buildtools_revision null Annotation(bot_update)
got_nacl_revision "d52121fcfeda7666d69d9df4b9d7a17bac3b61ac" Annotation(bot_update)
got_revision "1e54f71ef43dee5f77d71aa53a626d1292ee637b" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#542667}" Annotation(bot_update)
got_swarming_client_revision null Annotation(bot_update)
got_v8_revision "10c5b8fc3b4b29a50d79ffba9b9ed0bc72bdc782" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.7.41@{#1}" Annotation(bot_update)
got_webrtc_revision "15fb915917f7a4c49f856d280c147d1177a59738" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#22389}" Annotation(bot_update)
swarm_hashes {"webkit_layout_tests_exparchive":"36e6e29b023a432f7bf13c184fd78d7db51a1d96"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpPdJvE_" Annotation(steps)
build_id "buildbot/chromium.webkit/WebKit Mac10.11 (retina)/20475" Annotation(steps)
builder_id "master.chromium.webkit:WebKit Mac10.11 (retina)" Annotation(steps)
blamelist ["atotic@chromium.org","chrishtr@chromium.org","lambroslambrou@chromium.org"] Build
branch "master" Build
buildnumber 20475 Build
project "chromium" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1520901996 Build
revision "1e54f71ef43dee5f77d71aa53a626d1292ee637b" Build
slavename "build51-b1" BuildSlave
buildername "WebKit Mac10.11 (retina)" Builder
git_revision "1e54f71ef43dee5f77d71aa53a626d1292ee637b" Change
parent_buildername "WebKit Mac Builder" ParentBuild
parent_buildnumber 236354 ParentBuild
parent_got_angle_revision "64e5ed2abd8a4cc77d3647e4b245db57a8c42ae5" ParentBuild
parent_got_buildtools_revision null ParentBuild
parent_got_nacl_revision "d52121fcfeda7666d69d9df4b9d7a17bac3b61ac" ParentBuild
parent_got_revision "1e54f71ef43dee5f77d71aa53a626d1292ee637b" ParentBuild
parent_got_revision_cp "refs/heads/master@{#542667}" ParentBuild
parent_got_swarming_client_revision null ParentBuild
parent_got_v8_revision "10c5b8fc3b4b29a50d79ffba9b9ed0bc72bdc782" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.7.41@{#1}" ParentBuild
parent_got_webrtc_revision "15fb915917f7a4c49f856d280c147d1177a59738" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#22389}" ParentBuild
parent_mastername "chromium.webkit" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.webkit/" master.cfg
mastername "chromium.webkit" master.cfg
workdir "/b/build/slave/WebKit_Mac10_11__retina_" slave

Blamelist:

  1. (atoticohnoyoudont@chromium.org)
  2. (chrishtrohnoyoudont@chromium.org)
  3. (lambroslambrouohnoyoudont@chromium.org)
  4. (chrishtrohnoyoudont@chromium.org)

Timing:

Create N/A
Start Tuesday, 13-Mar-18 00:54:28 UTC
End Tuesday, 13-Mar-18 01:10:02 UTC
Pending N/A
Execution 15 mins 34 secs

All Changes:

  1. [LayoutNG] Fix stale style on a fragment after paint invalidation

    Changed by atoticohnoyoudont@chromium.org
    Changed at Tuesday, 13-Mar-18 00:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe3d571e7612763137a9e0d36c23fe921426af4d

    Comments

    [LayoutNG] Fix stale style on a fragment after paint invalidation
    
    This makes ~50 additional tests to pass, and 3 to fail.
    
    Paint invalidation can cause styles on a NGPhysicalFragment to
    get out of sync with LayoutObject styles.
    
    There were two ways to fix this, I found a) to be cleaner for now.
    
    a) Make PhysicalFragments fetch style from LayoutObject
    Tricky part here is that :first-line and overflow:ellipsis get
    special styles.
    
    b) Rebuild PhysicalFragment tree with a shallow clonewithstyle
    I was una
    ...skip...
    nux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: Ia11f8288b8f45423762c870a43615707d6a0cc93
    Reviewed-on: https://chromium-review.googlesource.com/956552
    Commit-Queue: Aleks Totic <atotic@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542664}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.cc
    • third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item.h
    • third_party/WebKit/Source/core/layout/ng/inline/ng_inline_node.cc
    • third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.cc
    • third_party/WebKit/Source/core/layout/ng/inline/ng_physical_text_fragment.h
    • third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.cc
    • third_party/WebKit/Source/core/layout/ng/inline/ng_text_fragment_builder.h
    • third_party/WebKit/Source/core/layout/ng/ng_base_fragment_builder.cc
    • third_party/WebKit/Source/core/layout/ng/ng_base_fragment_builder.h
    • third_party/WebKit/Source/core/layout/ng/ng_physical_container_fragment.cc
    • third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.cc
    • third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
    • third_party/WebKit/Source/core/layout/ng/ng_style_variant.h
    • third_party/WebKit/Source/core/paint/ng/ng_box_fragment_painter.cc
    • third_party/WebKit/Source/core/paint/ng/ng_fragment_painter.cc
  2. Devirtualize ScrollableArea::UsesCompositedScrolling.

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Tuesday, 13-Mar-18 00:23:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3341c5a4883f580df6e4ae0138ca4b514b8ff2bc

    Comments

    Devirtualize ScrollableArea::UsesCompositedScrolling.
    
    This method is called in various hot code paths, in particular
    in ObjectPaintInvalidator.
    
    Bug: 818709
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I6eaf1acadc5ac5721c7e42c900964bcc31fee769
    Reviewed-on: https://chromium-review.googlesource.com/959155
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542665}

    Changed files

    • third_party/WebKit/Source/core/frame/LocalFrameView.cpp
    • third_party/WebKit/Source/core/frame/LocalFrameView.h
    • third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
    • third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
    • third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
    • third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
    • third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
    • third_party/WebKit/Source/platform/scroll/ScrollableArea.h
  3. [remoting host] Add unittest for capturing at 30FPS.

    Changed by lambroslambrouohnoyoudont@chromium.org
    Changed at Tuesday, 13-Mar-18 00:24:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f018c9b26cd58e0438c6f28bfcaa8245fdb69fa8

    Comments

    [remoting host] Add unittest for capturing at 30FPS.
    
    This adds a unittest for the bug fixed in
    http://crrev.com/65f6394de68d8e96184234f5b7c8bf1e80f699f1
    
    This updates the scheduler and unittests to use a mock clock
    implementation from TestMockTimeTaskRunner, instead of just
    mocking the current time directly.
    
    Bug: 816727
    Change-Id: I194af8e65bae70f0af3a202e0bbb7653059abcaf
    Reviewed-on: https://chromium-review.googlesource.com/947575
    Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542666}

    Changed files

    • remoting/protocol/webrtc_frame_scheduler_simple.cc
    • remoting/protocol/webrtc_frame_scheduler_simple.h
    • remoting/protocol/webrtc_frame_scheduler_unittest.cc
  4. [PE] Don't call CompositedScrollsWithRespectTo during raster invalidation

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Tuesday, 13-Mar-18 00:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e54f71ef43dee5f77d71aa53a626d1292ee637b

    Comments

    [PE] Don't call CompositedScrollsWithRespectTo during raster invalidation
    
    It is redundant with the call to UsesCompositedScrolling just below, and
    is equivalent to UsesCompositedScrolling + object != paint_invalidation_container.
    UsesCompositedScrolling calls two methods plus a virtual, so may be slow.
    
    Bug: 818709
    
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: Iab617e3941563ac1994e5732359cf691442a2b7e
    Reviewed-on: https://chromium-review.googlesource.com/959444
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542667}

    Changed files

    • third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp