Home | Search
Login

Builder WebKit Linux Trusty MSAN Build #8855

Results:

failed webkit_layout_tests

Trigger Info:

Got Revision4f9d9e774d5d41a5d8073b156348eee4bde25753

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 14 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 3 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 3 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 3 ms ) remove .cipd
    remove .cipd
  9. ( 3 mins 7 secs ) bot_update
    bot_update
    [61GB/492GB used (12%)]
  10. ( 3 ms ) ensure_goma
    ensure_goma
  11. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 33 secs ) gclient runhooks
    gclient runhooks
  14. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 4 ms ) read test spec (chromium.webkit.json)
    read test spec (chromium.webkit.json)
    path: /b/c/b/linux_layout/src/testing/buildbot/chromium.webkit.json
  16. ( 3 ms ) clean isolated files
    clean isolated files
  17. ( 31 secs ) generate_build_files
    generate_build_files
  18. ( 4 ms ) clang_revision
    clang_revision
  19. ( 1 ms ) preprocess_for_goma
    preprocess_for_goma
  20. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  21. ( 7 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  22. ( 1 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  23. ( 15 mins 18 secs ) compile
    compile
  24. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  25. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  26. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  27. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  28. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  29. ( 23 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  30. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  31. ( 3 ms ) remove_build_metadata
    remove_build_metadata
  32. ( 2 mins 36 secs ) isolate webkit_layout_tests_exparchive
    isolate webkit_layout_tests_exparchive
  33. ( 6 ms ) find isolated tests
    find isolated tests
  34. ( 3 ms ) test_pre_run
    test_pre_run
  35. ( 5 secs ) test_pre_run.[trigger] webkit_layout_tests
    test_pre_run.[trigger] webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
  36. ( 44 mins 47 secs ) webkit_layout_tests
    webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:42:35.771390 (shard #5)
    Min shard duration: 0:27:59.904180 (shard #19)
    Total tests: 79566
    * Passed: 67712 (67671 expected, 41 unexpected)
    * Skipped: 11645 (11645 expected, 0 unexpected)
    * Failed: 164 (156 expected, >>>8 unexpected<<<)
    * Flaky: 45 (45 expected, 0 unexpected)
     
    Unexpected Failures:
    * external/wpt/generic-sensor/idlharness.https.window.html
    * external/wpt/mediacapture-fromelement/idlharness.html
    * external/wpt/payment-request/idlharness.https.window.html
    * external/wpt/webusb/idlharness.https.any.html
    * fast/webgl/texImage-imageBitmap-from-video-resize.html
    * http/tests/devtools/elements/styles-4/styles-live-locations-leak.js
    * http/tests/devtools/network/network-blocked-reason.js
    * inspector-protocol/css/reattach-after-editing-styles.js
     
  37. ( 5 mins 51 secs ) Upload to test-results [webkit_layout_tests]
    Upload to test-results [webkit_layout_tests]
  38. ( 6 secs ) archive_webkit_tests_results
    archive_webkit_tests_results
  39. ( 5 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 20
    Total runtime: 11:26:12.851822
     
  40. ( 4 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/8855/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/8855" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "4f9d9e774d5d41a5d8073b156348eee4bde25753" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574684}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23952}" Annotation(bot_update)
got_clang_revision "336424-1" Annotation(clang_revision)
swarm_hashes {"webkit_layout_tests_exparchive":"e4997c1eb934f0517ad236a772b3f29c560233e2"} Annotation(find isolated tests)
swarm_hashes_refs/heads/master(at){#574684}_without_patch {"webkit_layout_tests_exparchive":"e4997c1eb934f0517ad236a772b3f29c560233e2"} Annotation(isolate webkit_layout_tests_exparchive)
build_data_dir "/b/rr/tmpiE5wfl" Annotation(steps)
build_id "buildbot/chromium.webkit/WebKit Linux Trusty MSAN/8855" Annotation(steps)
builder_id "master.chromium.webkit:WebKit Linux Trusty MSAN" Annotation(steps)
blamelist ["acondor@chromium.org","aee@chromium.org","amaralp@chromium.org","bsazonov@chromium.org","chelu@chromium.org","chfremer@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","dgozman@chromium.org","dmurph@chromium.org","erikchen@chromium.org","ftirelo@chromium.org","fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","iclelland@chromium.org","kbr@chromium.org","kmilka@chromium.org","kpaulhamus@chromium.org","luoe@chromium.org","mthiesse@chromium.org","ntfschr@chromium.org","palmer@chromium.org","perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","pnoland@google.com","qinmin@chromium.org","scottchen@chromium.org","sergeyu@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","thestig@chromium.org","tigero@google.com","weidongg@chromium.org","wez@chromium.org","xiaochengh@chromium.org"] Build
branch "master" Build
buildnumber 8855 Build
project "chromium" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531421543 Build
revision "4f9d9e774d5d41a5d8073b156348eee4bde25753" Build
slavename "slave161-c1" BuildSlave
buildername "WebKit Linux Trusty MSAN" Builder
git_revision "4f9d9e774d5d41a5d8073b156348eee4bde25753" Change
scheduler "global_scheduler" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.webkit/" master.cfg
mastername "chromium.webkit" master.cfg
workdir "/b/build/slave/WebKit_Linux_Trusty_MSAN" slave

Blamelist:

  1. (dgozmanohnoyoudont@chromium.org)
  2. (pnolandohnoyoudont@google.com)
  3. (qinminohnoyoudont@chromium.org)
  4. (weidonggohnoyoudont@chromium.org)
  5. (xiaochenghohnoyoudont@chromium.org)
  6. (tigeroohnoyoudont@google.com)
  7. (palmerohnoyoudont@chromium.org)
  8. (chfremerohnoyoudont@chromium.org)
  9. (amaralpohnoyoudont@chromium.org)
  10. (scottchenohnoyoudont@chromium.org)
  11. (thestigohnoyoudont@chromium.org)
  12. (dgozmanohnoyoudont@chromium.org)
  13. (mthiesseohnoyoudont@chromium.org)
  14. (ntfschrohnoyoudont@chromium.org)
  15. (luoeohnoyoudont@chromium.org)
  16. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  17. (kmilkaohnoyoudont@chromium.org)
  18. (kbrohnoyoudont@chromium.org)
  19. (scottchenohnoyoudont@chromium.org)
  20. (cheluohnoyoudont@chromium.org)
  21. (thestigohnoyoudont@chromium.org)
  22. (bsazonovohnoyoudont@chromium.org)
  23. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  24. (dmurphohnoyoudont@chromium.org)
  25. (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  26. (kbrohnoyoudont@chromium.org)
  27. (ftireloohnoyoudont@chromium.org)
  28. (iclellandohnoyoudont@chromium.org)
  29. (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  30. (kpaulhamusohnoyoudont@chromium.org)
  31. (acondorohnoyoudont@chromium.org)
  32. (wezohnoyoudont@chromium.org)
  33. (aeeohnoyoudont@chromium.org)
  34. (erikchenohnoyoudont@chromium.org)
  35. (sergeyuohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 19:54:51 UTC
End Thursday, 12-Jul-18 21:09:37 UTC
Pending N/A
Execution 1 hrs 14 mins

All Changes:

  1. FrameLoader: move CancelParsing and CheckCompleted earlier

    Changed by dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:50:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae5ca38f28d3e136c7def1fe7444afed1db7ea9a

    Comments

    FrameLoader: move CancelParsing and CheckCompleted earlier
    
    This way we do it before creating new provisional loader, which
    will help in the future when there would be no provisional loader.
    
    Added Document::Abort method which encapsulates CancelParsing
    and CheckCompleted and also does not issue undesired DidFinishNavigation.
    
    Bug: 831155
    Change-Id: Ica5d968508d7aed7bb07125702ceeaeb6f389497
    Reviewed-on: https://chromium-review.googlesource.com/1119262
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574650}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-detach-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/loading/onreadystatechange-window-stop.html
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/dom/document.h
    • third_party/blink/renderer/core/loader/frame_loader.cc
  2. Check against null frame_ in GetCanonicalUrlForSharing

    Changed by pnolandohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:50:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd341220c263993037559e62938d54d5cf091a2c

    Comments

    Check against null frame_ in GetCanonicalUrlForSharing
    
    Bug: 852350
    Change-Id: Ib6c4cc79572d3dad22f663ec61a20bc54f5d7a8f
    Reviewed-on: https://chromium-review.googlesource.com/1117847
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574651}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
  3. Always prompt user if opening a download thru extensions with debugger permission

    Changed by qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:55:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a4a89a53791a508896b388b0d818644834c0d6d

    Comments

    Always prompt user if opening a download thru extensions with debugger permission
    
    The user gesture can be faked, so we shouldn't trust it
    
    BUG=854455
    
    Change-Id: Ib42911a77d3f519554a5b9a4c1464ec50e79f268
    Reviewed-on: https://chromium-review.googlesource.com/1135525
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574652}

    Changed files

    • chrome/browser/extensions/api/downloads/downloads_api.cc
  4. Introduce GetAppShortcutGlobalQueryItems mojo method

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:56:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f70dc791c0f421c6ac340019a9721df97af0da8d

    Comments

    Introduce GetAppShortcutGlobalQueryItems mojo method
    
    The original solution passing all available app shortcuts metadata to
    Chrome has large latency because getting icons is expensive. This CL
    proposes a new API that passes query and maxResults to Android, and
    searching & results num throttling is done in Android as well.
    Android side change is in ag/4432308.
    
    Bug: 842947
    Test: manual test, latency is controlled in tens milliseconds
    
    Change-Id: I48c168ffd56826c10a4b6d5befb995a087f4a0b2
    Reviewed-on: https://chromium-review.googlesource.com/1117893
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Reviewed-by: Qiang Xu <warx@google.com>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574653}

    Changed files

    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.cc
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider.h
    • chrome/browser/ui/app_list/search/arc/arc_app_shortcuts_search_provider_unittest.cc
    • chrome/browser/ui/app_list/search/search_controller_factory.cc
    • components/arc/common/app.mojom
    • components/arc/test/fake_app_instance.cc
    • components/arc/test/fake_app_instance.h
  5. Convert two crash layout tests to use testharness

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0279bf752fc5d6e5f0df324190ab72d7bc831010

    Comments

    Convert two crash layout tests to use testharness
    
    The following two layout tests are crash tests and don't need text dump:
    - fast/text/editing-text-crash.html
    - fast/text/text-iterator-crash.html
    
    This patch converts them with testharness for better code health.
    
    Change-Id: I528a681bb6a17e2fb9f6122d6ec42f9722a575df
    Reviewed-on: https://chromium-review.googlesource.com/1134594
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574654}

    Changed files

    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/editing-text-crash.html
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash-expected.txt
    • third_party/WebKit/LayoutTests/fast/text/text-iterator-crash.html
  6. Groups small symbols at the file level

    Changed by tigeroohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:57:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b84bff2c5ba0511930b78e6d864bfb8ef0bb03

    Comments

    Groups small symbols at the file level
    
    Previously, symbols below min_symbol_size were all placed in an
    "(Other)" file entry at the root of the tree. Now, they are placed
    inside their original file entry but grouped together based on type.
    This ensures byte counts are always accurate, even past the root node.
    This is also the only blocker before we can remove the old UI.
    
    Additionally made some changes to improve first-load performance by
    starting tree building as soon as possible.
    
    Bug: 860303
    Change-Id: I02daee8994d9b7b236837b78585ac8a9c3297125
    Reviewed-on: https://chromium-review.googlesource.com/1135193
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574655}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/start-worker.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  7. Change DECHECKs to CHECKs in `base::RingBuffer`.

    Changed by palmerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:58:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 940e9a3140b1e0b636f185ff65f20226e997d897

    Comments

    Change DECHECKs to CHECKs in `base::RingBuffer`.
    
    Better safe than sorry!
    
    In the process, do some micro-optimization to make the CHECKs as cheap as
    possible.
    
    Bug: 817982
    Change-Id: I2c45d7e773199a12ce4ae34b4a750ac2b66cb7c2
    Reviewed-on: https://chromium-review.googlesource.com/1134486
    Reviewed-by: danakj <danakj@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574656}

    Changed files

    • base/containers/ring_buffer.h
  8. [Video Capture] Abstract out V4L2 API calls to an interface

    Changed by chfremerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 18:59:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbf002c655a394a5235cef285a40059f8d32d678

    Comments

    [Video Capture] Abstract out V4L2 API calls to an interface
    
    This CL abstracts V4L2 API calls made from Chromium's video capture
    implementation on Linux out to an interface. This is to enable testability of
    the code that makes such calls without requiring heavy-weight solutions such
    as attaching actual hardware or kernel-level emulators.
    
    This CL is a pure refactoring and has no intended function change.
    
    This CL is part of a series, see Design Doc at
    https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing
    
    Test: capture_unittests with physical camera attached
    Bug: 768887
    Change-Id: I9208f4a61731c8dc5827c1f5f5ef31d078520270
    Reviewed-on: https://chromium-review.googlesource.com/1120856
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: Christian Fremerey <chfremer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574657}

    Changed files

    • media/capture/BUILD.gn
    • media/capture/video/linux/v4l2_capture_delegate.cc
    • media/capture/video/linux/v4l2_capture_delegate.h
    • media/capture/video/linux/v4l2_capture_delegate_unittest.cc
    • media/capture/video/linux/v4l2_capture_device.h
    • media/capture/video/linux/v4l2_capture_device_impl.cc
    • media/capture/video/linux/v4l2_capture_device_impl.h
    • media/capture/video/linux/video_capture_device_chromeos.cc
    • media/capture/video/linux/video_capture_device_chromeos.h
    • media/capture/video/linux/video_capture_device_factory_linux.cc
    • media/capture/video/linux/video_capture_device_factory_linux.h
    • media/capture/video/linux/video_capture_device_linux.cc
    • media/capture/video/linux/video_capture_device_linux.h
  9. Making a menu button component

    Changed by amaralpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:03:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c59b348ffef08cfdca20701f4f54236f9e6e295

    Comments

    Making a menu button component
    
    Pulling the menu button out of the bottom toolbar component into its
    own class.
    
    Bug: 862863
    
    
    Change-Id: Icb2230259d7f1d3ac2f47f3b8ee33e659579ca96
    Reviewed-on: https://chromium-review.googlesource.com/1132423
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574658}

    Changed files

    • chrome/android/java/res/layout/menu_button.xml
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarMediator.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarViewBinder.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/MenuButton.java
    • chrome/android/java_sources.gni
  10. Settings: fix cups printer search field logic.

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:05:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1fa8446eb300966ba4c7c4e6c02e9f9f86fedc

    Comments

    Settings: fix cups printer search field logic.
    
    An earlier CL (1088163) broke the logic for drop-down search fields in
    CUPS add/edit printer dialog, by setting the searchTerm_ property to the
    wrong value. This CL fixes that issue.
    
    The aforementioned CL also accidentally notifies the parent of the input
    value too often, which is also fixed in this CL.
    
    Tests are added to prevent both regressions in the future.
    
    Bug: 860475
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3949c01edacc53b5aa0f8b6b25ef57b3acb00577
    Reviewed-on: https://chromium-review.googlesource.com/1132238
    Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574659}

    Changed files

    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
    • chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.js
    • chrome/test/data/webui/settings/cups_printer_page_tests.js
  11. Update PDFExtensionTest test expectation.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be8ff3e12884ec3188e5fb909b31a62b9412d808

    Comments

    Update PDFExtensionTest test expectation.
    
    After https://pdfium-review.googlesource.com/35432 got rolled into
    Chromium in r570889, a previously failing test case now started passing.
    
    BUG=860757
    
    Change-Id: I998a0ea8a91770bb27d92491a12ac0816f535054
    Reviewed-on: https://chromium-review.googlesource.com/1132633
    Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574660}

    Changed files

    • chrome/browser/pdf/pdf_extension_test.cc
  12. Restore some checks in FrameLoader::CommitNavigation

    Changed by dgozmanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:06:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd7f8b8a57712e9a2b2deb2a10282dea99bdb5eb

    Comments

    Restore some checks in FrameLoader::CommitNavigation
    
    These were dropped when separating StartNavigation from
    CommitNavigation. It's reasonable that we cannot be in StopAllLoaders
    or similar unless there is a nested message loop.
    
    See test for an example how print() triggers this stack:
    ...<message loop running here, dispatched CommitNavigation>...
    IPC::SyncChannel::Send()
    content::RenderThreadImpl::Send()
    printing::PrintRenderFrameHelper::RequestPrintPreview()
    content::RenderFrameImpl::ScriptedPrint(
    ...skip...
    ach()
    blink::HTMLPlugInElement::DisconnectContentFrame()
    blink::ChildFrameDisconnector::DisconnectCollectedFrameOwners()
    blink::ContainerNode::WillRemoveChild()
    blink::ContainerNode::RemoveChild()
    ...<JavaScript>...
    
    Bug: 860208, 853487, 862088
    Change-Id: Ieb3f0330828f0a031a97d08cdc1ba7de8a3f0edc
    Reviewed-on: https://chromium-review.googlesource.com/1130223
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574661}

    Changed files

    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing-expected.txt
    • third_party/WebKit/LayoutTests/fast/loader/detach-while-printing.html
    • third_party/blink/renderer/core/loader/frame_loader.cc
  13. Fix VR watchlist

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7bec5b1769172d3b2722182969d5c1ed618bc42

    Comments

    Fix VR watchlist
    
    Broken in https://chromium-review.googlesource.com/c/chromium/src/+/1134091/9/WATCHLISTS.
    
    Change-Id: Id84c46bb2f52d397975e1c3797a182b2becf9c07
    Reviewed-on: https://chromium-review.googlesource.com/1135115
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574662}

    Changed files

    • WATCHLISTS
  14. AW: trace events for WindowAndroid verification issues

    Changed by ntfschrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:10:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f50fc4d425345286e65488344fd85981bef36c94

    Comments

    AW: trace events for WindowAndroid verification issues
    
    No change to logic.
    
    This adds trace events inside AwContents to track WindowAndroid-related
    class verification errors. Specifically, this should illustrate the
    following verification errors:
    
     * WindowAndroid verification errors should cause activityFromContext to
       take longer than necessary.
     * ActivityWindowAndroid fails verification (because its superclass
       WindowAndroid fails verification), causing its constructor to take
       longer than necessary.
    
    R=torne@chromium.org
    
    Bug: 855796
    Test: tools/perf/run_benchmark system_health.webview_startup --browser android-webview-google
    Change-Id: I6633496fd672300216dfa6425910d19a7ae9e3da
    Reviewed-on: https://chromium-review.googlesource.com/1132479
    Reviewed-by: Richard Coles <torne@chromium.org>
    Commit-Queue: Nate Fischer <ntfschr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574663}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
  15. DevTools: clicking clear on input should focus

    Changed by luoeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:11:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cdc1f3d342363df455d02fde8bc04d44f5331e5e

    Comments

    DevTools: clicking clear on input should focus
    
    The act of clicking the 'x' clear button blurs focus. This CL ensures
    the input focuses afterwards.
    
    Bug: 831059
    Change-Id: I848296c0981873cd878f5aaaead9654809811349
    Reviewed-on: https://chromium-review.googlesource.com/1134577
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574664}

    Changed files

    • third_party/blink/renderer/devtools/front_end/ui/Toolbar.js
  16. Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 521effcf577f74a61bd5d6a35074ed2e3d20abd0

    Comments

    Roll src/third_party/skia 56a426a516d0..5551a94b9e0f (15 commits)
    
    https://skia.googlesource.com/skia.git/+log/56a426a516d0..5551a94b9e0f
    
    
    git log 56a426a516d0..5551a94b9e0f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 mtklein@chromium.org update color management for color shaders
    2018-07-12 brianosman@google.com Update SRGBReadWritePixelsTest again, to only test opaque colors
    2018-07-12 fmalita@chromium.org PathKit/WASM tweaks
    2018-07-12 mtklein@chromium.org update mode color filter col
    ...skip...
    sty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I31983fe5eb6e60f68f6b46ed52741dd82999eb78
    Reviewed-on: https://chromium-review.googlesource.com/1135209
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574665}

    Changed files

    • DEPS
  17. [NTP] Add Google Photos option for custom backgrounds

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:13:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d87ed83235c1f5505f58b0d51923dfe11db9faae

    Comments

    [NTP] Add Google Photos option for custom backgrounds
    
    Allow users to select one of their photos from Google Photos and set it
    as the NTP background image. Currently only supports users who are
    already signed in to their Google account.
    
    Bug: 848012
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idef07f3cd107199a8e308fc883c96b9a8da37b1e
    Reviewed-on: https://chromium-review.googlesource.com/1130100
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574666}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
    • chrome/browser/resources/local_ntp/custom_backgrounds.js
    • chrome/browser/resources/local_ntp/local_ntp.html
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/test/data/local_ntp/local_ntp_browsertest.html
  18. Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:14:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32b92d2bc9ae9c12e01f7879de715843ac849ae8

    Comments

    Update GPU pixel wrangling graphs for macOS 10.13.5 upgrade.
    
    Tbr: ynovikov@chromium.org
    Bug: 856799
    Change-Id: I6d7265037477715df7ca7e31290ef88f7ad4f668
    Reviewed-on: https://chromium-review.googlesource.com/1135657
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574667}

    Changed files

    • docs/gpu/pixel_wrangling.md
  19. Settings: fix sync-account-controls banner overflowing border-radius.

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66d0e64aa958612d6b9cf38b9b8409925487458b

    Comments

    Settings: fix sync-account-controls banner overflowing border-radius.
    
    Bug: 860265
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie85c25b7b777463569f4d3b4f01f8a8e524c84f5
    Reviewed-on: https://chromium-review.googlesource.com/1133977
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574668}

    Changed files

    • chrome/browser/resources/settings/people_page/people_page.html
    • chrome/browser/resources/settings/people_page/sync_account_control.html
  20. Add bad IPC message check at the browser.

    Changed by cheluohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f9ecec290e797566bdbbe41459d68a4045e29b5e

    Comments

    Add bad IPC message check at the browser.
    
    Add bad IPC message check to UpdateAnchorElementMetrics. The browser
    will kill the renderer process when it receives a bad message.
    
    Bug: 850624
    Change-Id: I750b6d54e556ddc659cb693844922234b9e845ce
    Reviewed-on: https://chromium-review.googlesource.com/1128259
    Commit-Queue: Lu Chen <chelu@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574669}

    Changed files

    • chrome/browser/navigation_predictor/navigation_predictor.cc
    • chrome/browser/navigation_predictor/navigation_predictor.h
    • chrome/browser/navigation_predictor/navigation_predictor_unittest.cc
    • tools/metrics/histograms/histograms.xml
  21. Move PDFiumEngine doc/form/loading members into PDFiumDocument.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:16:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 94754366872ddaafeb4ec141f971ee47d3350c59

    Comments

    Move PDFiumEngine doc/form/loading members into PDFiumDocument.
    
    Change-Id: I11c1ecff9305a75f66c3de5443fde4d0423163d2
    Reviewed-on: https://chromium-review.googlesource.com/1112498
    Reviewed-by: dsinclair <dsinclair@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574670}

    Changed files

    • pdf/BUILD.gn
    • pdf/pdfium/pdfium_document.cc
    • pdf/pdfium/pdfium_document.h
    • pdf/pdfium/pdfium_engine.cc
    • pdf/pdfium/pdfium_engine.h
  22. [Unity][Android] Update string for payments sync datatype

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:17:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab5e146619a4ce43dd36939245a2b6a9a254ef90

    Comments

    [Unity][Android] Update string for payments sync datatype
    
    This CL changes the string used for payments in
    'Sync and Google services' preferences screen.
    
    Bug: 814728
    Change-Id: Ib1932ef94ad6f6b90efa5a59e0ef0500775b9496
    Reviewed-on: https://chromium-review.googlesource.com/1135321
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574671}

    Changed files

    • chrome/android/java/res/xml/sync_customization_preferences.xml
    • chrome/android/java/strings/android_chrome_strings.grd
  23. Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0113967ab2dcdc45364c7cfa35fd095856d7ede5

    Comments

    Roll src/third_party/chromite 3973c26575e2..ca73efa2232f (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/3973c26575e2..ca73efa2232f
    
    
    git log 3973c26575e2..ca73efa2232f --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 stevenjb@chromium.org deploy_chrome: Always prompt to remove rootfs verification
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@ca73efa2232f
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I910679c20d35bb32e7f9e089bdde8a437a37961c
    Reviewed-on: https://chromium-review.googlesource.com/1135208
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574672}

    Changed files

    • DEPS
  24. [SessionStorage] Always delete Session Storage database on Android

    Changed by dmurphohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:18:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

    Comments

    [SessionStorage] Always delete Session Storage database on Android
    
    Android doesn't have session restore code run, and this code is what
    cleaned up old session storage namespaces from previous browser runs.
    
    So on Android, the session storage context will delete the database
    on startup.
    
    R=mek@chromium.org
    
    Bug: 860030
    Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
    Reviewed-on: https://chromium-review.googlesource.com/1125260
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574673}

    Changed files

    • content/browser/dom_storage/dom_storage_context_wrapper.cc
    • content/browser/dom_storage/session_storage_context_mojo.cc
    • content/browser/dom_storage/session_storage_context_mojo.h
    • content/browser/dom_storage/session_storage_context_mojo_unittest.cc
  25. Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)

    Changed by perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b6920828c5fa9f72dce1b84c9ae95711ae037e5

    Comments

    Roll src/third_party/perfetto f37ffaf9b1a1..2af75f76f0e6 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/f37ffaf9b1a1..2af75f76f0e6
    
    
    git log f37ffaf9b1a1..2af75f76f0e6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 michaschwab@google.com Merge "Improve Context Architecture, add "isOnCanvas" method"
    2018-07-12 michaschwab@google.com Improve Context Architecture, add "isOnCanvas" method
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@2af75f76f0e
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I4222bc49a1619c3cc2972a496dd5e7e961d03363
    Reviewed-on: https://chromium-review.googlesource.com/1135213
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574674}

    Changed files

    • DEPS
  26. Complete upgrade of Retina Macs to 10.13.5.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:21:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43d34bd136540d0ff14ed70bfc2a69019338595d

    Comments

    Complete upgrade of Retina Macs to 10.13.5.
    
    Turn off the multi-dimension trigger script.
    
    Fix the configuration of "Optional Mac Retina Release (AMD)"; a
    mistake was made in the earlier CL beginning the upgrade, and the jobs
    didn't auto-migrate from 10.12.6 to 10.13.5.
    
    Bug: 856799
    Tbr: ynovikov@chromium.org
    Change-Id: Ifcceed16154c47ffaa5b682149780bc53f4a101b
    Reviewed-on: https://chromium-review.googlesource.com/1135651
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574675}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/chromium.gpu.json
    • testing/buildbot/waterfalls.pyl
  27. Reland: [af] Adjust dropdown so it doesn't look so close to the input element

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:22:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03daf4e42f99ef9329ec05fc186c1936ffa718a9

    Comments

    Reland: [af] Adjust dropdown so it doesn't look so close to the input element
    
    This relands commit f1c12e6, which was reverted by commit c71c2c1.
    
    The reason for the revert was a crash introduced by c53515c, and
    reverting that commit was very hard due to merge conflicts.
    
    Bug: 847980
    Change-Id: Ib1b6931d3ac697e78c27a6cbcc7e082f0da4b6ef
    Reviewed-on: https://chromium-review.googlesource.com/1135446
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574676}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  28. Clean up feature policy flags.

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:32:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 77533434f64cde2813381a26cce2247a62070a21

    Comments

    Clean up feature policy flags.
    
    This fixes the default feature list, ensuring that features only appear
    in it if they are actually enabled with the correct runtime feature
    flags. Even if they are shipped as 'stable', they can still be disabled,
    and should not be parsed in that case, or appear in the output of
    document.policy.allowedFeatures().
    
    Bug: 862601
    Change-Id: I207a17818ed6696e9d029b86adcf42e4b58b6516
    Reviewed-on: https://chromium-review.googlesource.com/1133307
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574677}

    Changed files

    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  29. Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71

    Changed by fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 19:34:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0708b273b84747404d79725f8be67c90f3047079

    Comments

    Roll Fuchsia SDK from cf3c39f9e29d to 64ef9c9bec71
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: I44aa919993e7873807987396622c8fcb0bf2a17f
    Reviewed-on: https://chromium-review.googlesource.com/1135632
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574678}

    Changed files

    • build/fuchsia/sdk.sha1
  30. Disable flaky SitePerProcessHitTestBrowserTest

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:35:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e031a4fd51a2eefc216a0f80f4bb139e1812b6c

    Comments

    Disable flaky SitePerProcessHitTestBrowserTest
    
    [OverlapSurfaceHitTestTest]
    
    TBR=sunxd@chromium.org
    
    Bug: 833380
    Change-Id: I7991db84dd9201e59089f08a536bcab00b23d379
    Reviewed-on: https://chromium-review.googlesource.com/1135648
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574679}

    Changed files

    • content/browser/site_per_process_hit_test_browsertest.cc
  31. VR: Update textures only if dirty

    Changed by acondorohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:38:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7b520e5b526c4e1ed0a2344a79e42eb6fcf5c298

    Comments

    VR: Update textures only if dirty
    
    This prevents from performing unnecessary context switches.
    
    Bug: 861799
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5da0e41dda9edb0243c9bbc9c944bdc2cdfaaf39
    Reviewed-on: https://chromium-review.googlesource.com/1133298
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574680}

    Changed files

    • chrome/browser/android/vr/vr_shell_gl.cc
    • chrome/browser/vr/elements/textured_element.cc
    • chrome/browser/vr/elements/textured_element.h
    • chrome/browser/vr/elements/ui_element.cc
    • chrome/browser/vr/elements/ui_element.h
    • chrome/browser/vr/test/ui_test.cc
    • chrome/browser/vr/ui.cc
    • chrome/browser/vr/ui.h
    • chrome/browser/vr/ui_scene.cc
    • chrome/browser/vr/ui_scene.h
  32. Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().

    Changed by wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:42:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 291f0a739f2c952d402f76d3750b9a2340269c18

    Comments

    Fix race-condition in SchedulerSingleThreadTaskRunnerManager::Start().
    
    SchedulerSingleThreadTaskRunnerManager allows SingleThreadTaskRunners to
    be created and tasks posted to them before the worker threads are
    actually started. The call to Start() the required workers was calling
    both Start() and WakeUp() on each of them, the latter being unnecessary
    since if a worker needs to process work then it must already have been
    woken, when the work was PostTask()d into it.
    
    Besides removing an unnecessary wake-up, this resolves a subtle race-
    condition between wake-up and a potential worker clean-up (see bug).
    
    Bug: 862582
    Change-Id: I9c4246cec4b1bda6d728e5e1656bb2c5ca7c0f0a
    Reviewed-on: https://chromium-review.googlesource.com/1133279
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574681}

    Changed files

    • base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
  33. WebUI: update text to use primary/secondary colors for style refresh

    Changed by aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ceaa55ab4070c9fc1bce4a599d62362576b1322

    Comments

    WebUI: update text to use primary/secondary colors for style refresh
    
    Bug: 849857
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia64cd1565af8f50a4af8b5c08f82d9a13df00acf
    Reviewed-on: https://chromium-review.googlesource.com/1133959
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574682}

    Changed files

    • chrome/browser/resources/md_downloads/item.html
    • chrome/browser/resources/md_extensions/detail_view.html
    • chrome/browser/resources/md_extensions/error_page.html
    • chrome/browser/resources/md_extensions/manager.html
    • chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
    • chrome/browser/resources/settings/device_page/storage.html
    • chrome/browser/resources/settings/internet_page/network_summary_item.html
    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/people_page/setup_pin_dialog.html
    • chrome/browser/resources/settings/settings_page/settings_subpage_search.html
    • chrome/browser/resources/settings/settings_shared_css.html
    • chrome/browser/resources/settings/site_settings/zoom_levels.html
    • ui/webui/resources/cr_elements/chromeos/network/cr_network_list_item.html
    • ui/webui/resources/cr_elements/paper_tabs_style_css.html
  34. Add high water mark in background profiling triggers for memlog.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3483cb3aa6a9343b22e8ec39e81cb2fc864970a3

    Comments

    Add high water mark in background profiling triggers for memlog.
    
    Previously, a memlog report would be uploaded if a fixed threshold was exceeded.
    After that point, the timer frequency would be reduced to prevent too many
    reports from being uploaded.
    
    In this CL, we use a fixed, higher frequency timer to check memory usage. We
    upload an initial report if the fixed thresholds are exceeded, and then upload
    more reports each time the high water mark is exceeded by a significant amount.
    This allows us to catch higher-velocity memory leaks, that might otherwise cause
    the process to be killed before a report would be uploaded with the previous
    mechanism.
    
    Change-Id: I706314810d962c51e4126157363f44ce64868721
    Reviewed-on: https://chromium-review.googlesource.com/1132099
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574683}

    Changed files

    • chrome/browser/profiling_host/background_profiling_triggers.cc
    • chrome/browser/profiling_host/background_profiling_triggers.h
    • chrome/browser/profiling_host/background_profiling_triggers_unittest.cc
  35. [Fuchsia] Remove package detection in base::PathProviderFuchsia()

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 19:48:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f9d9e774d5d41a5d8073b156348eee4bde25753

    Comments

    [Fuchsia] Remove package detection in base::PathProviderFuchsia()
    
    Previously PathProvider was trying to detect if it's packaged or not.
    That logic is no longer needed because we can assume that all binaries
    produced in chromium are packaged.
    
    Change-Id: I963afac5342d44b8d8188c07ffb927d6b4fac271
    Reviewed-on: https://chromium-review.googlesource.com/1134586
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574684}

    Changed files

    • base/base_paths_fuchsia.cc