Home | Search
Login

Builder WebKit Linux Trusty MSAN Build #10441

Results:

build successful

Trigger Info:

Got Revision9729f6efb4bae858cc91b281091f2df86433da8a

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 17 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 3 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) report builders
    report builders
     
    running builder/tester 'WebKit Linux Trusty MSAN' on master 'chromium.webkit'
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 3 mins 27 secs ) bot_update
    bot_update
    [63GB/492GB used (12%)]
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 34 secs ) gclient runhooks
    gclient runhooks
  13. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 4 ms ) read test spec (chromium.webkit.json)
    read test spec (chromium.webkit.json)
    path: /b/c/b/linux_layout/src/testing/buildbot/chromium.webkit.json
  15. ( 3 ms ) clean isolated files
    clean isolated files
  16. ( 3 ms ) lookup GN args
    lookup GN args
     
    is_component_build = false
    is_debug = false
    is_msan = true
    msan_track_origins = 2
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    use_prebuilt_instrumented_libraries = true
    goma_dir = "/b/c/goma_cache/client"
  17. ( 32 secs ) generate_build_files
    generate_build_files
  18. ( 4 ms ) clang_revision
    clang_revision
  19. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  20. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  21. ( 7 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  22. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  23. ( 10 mins 48 secs ) compile
    compile
  24. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  25. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  26. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  27. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  28. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  29. ( 23 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  30. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  31. ( 1 mins 54 secs ) isolate webkit_layout_tests_exparchive
    isolate webkit_layout_tests_exparchive
  32. ( 4 ms ) find isolated tests
    find isolated tests
  33. ( 3 ms ) test_pre_run
    test_pre_run
  34. ( 9 secs ) test_pre_run.[trigger] webkit_layout_tests
    test_pre_run.[trigger] webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
  35. ( 52 mins 55 secs ) webkit_layout_tests
    webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max pending time: 10s (shard #6)
    Max shard duration: 0:50:32.391273 (shard #5)
    Min shard duration: 0:30:17.131309 (shard #3)
    Total tests: 87454
    * Passed: 75296 (75270 expected, 26 unexpected)
    * Skipped: 11844 (11844 expected, 0 unexpected)
    * Failed: 241 (241 expected, 0 unexpected)
    * Flaky: 73 (73 expected, 0 unexpected)
     
  36. ( 4 mins 55 secs ) Upload to test-results [webkit_layout_tests]
    Upload to test-results [webkit_layout_tests]
  37. ( 5 secs ) archive results for webkit_layout_tests
    archive results for webkit_layout_tests
  38. ( 5 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 20
    Total runtime: 13:08:34.208898
     
  39. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/10441/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/10441" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" Annotation(bot_update)
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" Annotation(bot_update)
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" Annotation(bot_update)
got_revision "9729f6efb4bae858cc91b281091f2df86433da8a" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#599183}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.1.302@{#1}" Annotation(bot_update)
got_webrtc_revision "55d1af14751ad10e0cae741240f013ea67039f45" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25138}" Annotation(bot_update)
got_clang_revision "344066-1" Annotation(clang_revision)
swarm_hashes {"webkit_layout_tests_exparchive":"9b2ea801cd5ef7475e7c6a88f58f778695370e0a"} Annotation(find isolated tests)
swarm_hashes_refs/heads/master(at){#599183}_without_patch {"webkit_layout_tests_exparchive":"9b2ea801cd5ef7475e7c6a88f58f778695370e0a"} Annotation(isolate webkit_layout_tests_exparchive)
build_data_dir "/b/rr/tmp3m0oGY" Annotation(steps)
build_id "buildbot/chromium.webkit/WebKit Linux Trusty MSAN/10441" Annotation(steps)
builder_id "master.chromium.webkit:WebKit Linux Trusty MSAN" Annotation(steps)
blamelist ["andruud@chromium.org","blundell@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","clamy@chromium.org","davidovic@google.com","edcourtney@google.com","futhark@chromium.org","orphis@chromium.org","stkhapugin@chromium.org","svillar@igalia.com","thakis@chromium.org"] Build
branch "master" Build
buildnumber 10441 Build
project "chromium" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1539343650 Build
revision "9729f6efb4bae858cc91b281091f2df86433da8a" Build
slavename "slave161-c1" BuildSlave
buildername "WebKit Linux Trusty MSAN" Builder
git_revision "9729f6efb4bae858cc91b281091f2df86433da8a" Change
scheduler "global_scheduler" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.webkit/" master.cfg
mastername "chromium.webkit" master.cfg
workdir "/b/build/slave/WebKit_Linux_Trusty_MSAN" slave

Blamelist:

  1. (futharkohnoyoudont@chromium.org)
  2. (edcourtneyohnoyoudont@google.com)
  3. (svillarohnoyoudont@igalia.com)
  4. (thakisohnoyoudont@chromium.org)
  5. (stkhapuginohnoyoudont@chromium.org)
  6. (clamyohnoyoudont@chromium.org)
  7. (andruudohnoyoudont@chromium.org)
  8. (blundellohnoyoudont@chromium.org)
  9. (orphisohnoyoudont@chromium.org)
  10. (orphisohnoyoudont@chromium.org)
  11. (futharkohnoyoudont@chromium.org)
  12. (davidovicohnoyoudont@google.com)
  13. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)

Timing:

Create N/A
Start Friday, 12-Oct-18 12:38:02 UTC
End Friday, 12-Oct-18 13:55:19 UTC
Pending N/A
Execution 1 hrs 17 mins

All Changes:

  1. Run layout to avoid stale layout during SetIsInert()

    Changed by futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:26:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fe6fcbb2751d80b3a9c41b734d1d1c16e93d46b

    Comments

    Run layout to avoid stale layout during SetIsInert()
    
    Speculative fix for crbug.com/789094
    
    Bug: 789094
    Change-Id: I1ea9215d049d84b4117f8836754f467c3d8ec9bc
    Reviewed-on: https://chromium-review.googlesource.com/c/823582
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599171}

    Changed files

    • third_party/WebKit/LayoutTests/html/dialog/dialog-show-modal-inert-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
  2. Add Picture-in-picture specific window resizer.

    Changed by edcourtneyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 11:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1454ad1f261d1089f2ac20cdc6e7e3d2562d731c

    Comments

    Add Picture-in-picture specific window resizer.
    
    Currently, this does essentially nothing apart from providing basic
    resizing and moving functionality. In a follow-up CL, we can add
    snap-to-edge, swipe-to-dismiss, and interaction with system ui regions
    like the virtual keyboard.
    
    Bug: 841886
    Bug: b/115291749
    Test: Able to move and resize an Android PIP window.
    Change-Id: Iaecc43154fd38dc5f9d3b83549e97dc44a89d749
    Reviewed-on: https://chromium-review.googlesource.com/c/1219428
    Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599172}

    Changed files

    • ash/BUILD.gn
    • ash/wm/pip/pip_window_resizer.cc
    • ash/wm/pip/pip_window_resizer.h
    • ash/wm/pip/pip_window_resizer_unittest.cc
    • ash/wm/workspace/workspace_window_resizer.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface_unittest.cc
  3. Convert chrome/browser/signin/signin_global_error.cc to IdentityManager

    Changed by svillarohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 11:46:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 557d4cfd2336cc35f91ec95bb9ef4b1290e6d491

    Comments

    Convert chrome/browser/signin/signin_global_error.cc to IdentityManager
    
    It was using SigninManagerBase API to get the primary (authenticated)
    account id. It's now using the IdentityManager API.
    
    Bug: 890792
    Change-Id: Ia8cdd8e491f29256af2c015a9127b0766e81b99e
    Reviewed-on: https://chromium-review.googlesource.com/c/1276965
    Commit-Queue: Sergio Villar <svillar@igalia.com>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599173}

    Changed files

    • chrome/browser/signin/signin_global_error.cc
  4. win: Update deterministic build whitelist.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:47:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f097036d16ea6c259ef01ddd6967895ca5a28d04

    Comments

    win: Update deterministic build whitelist.
    
    symbol_level=1 builds seem to work now and the bot builds with it, so the
    entries for crashpad_snapshot_test_image_reader and
    crashpad_snapshot_test_image_reader_module.dll are no longer needed.
    
    mini_installer.exe now has a corresponding .pdb that's also non-deterministic
    (since the exe itself isn't, the pdb can't be), so add an entry for that.
    
    TBR=erikchen
    
    Bug: 330260
    Change-Id: Ic1cde1f5a52a953d74285e4bd6a02e74c70e75b5
    Reviewed-on: https://chromium-review.googlesource.com/c/1278306
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599174}

    Changed files

    • tools/determinism/deterministic_build_whitelist.pyl
  5. Rename FaviconViewNew to FaviconView.

    Changed by stkhapuginohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:48:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0363f71cf67554f24b21b299db6f9fcd11a33bf3

    Comments

    Rename FaviconViewNew to FaviconView.
    
    Since FaviconView name is not used anymore, it makes sense now.
    
    Bug: none
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I0549111a1ade2f8cc61664d1de07160c8687b6de
    Reviewed-on: https://chromium-review.googlesource.com/c/1278807
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599175}

    Changed files

    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_cell.mm
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_cell.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
    • ios/chrome/common/favicon/favicon_view.h
    • ios/chrome/common/favicon/favicon_view.mm
    • ios/chrome/content_widget_extension/most_visited_tile_view.h
    • ios/chrome/content_widget_extension/most_visited_tile_view.mm
  6. Create NavigationRequest from LoadURLParams

    Changed by clamyohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 11:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5193caa162249e66ecec99fbf1e94fd38557b672

    Comments

    Create NavigationRequest from LoadURLParams
    
    This CL allows to create the NavigationRequest directly from
    LoadURLParams for new navigations.
    
    Bug: 803859
    Change-Id: Ic0f3f368ade86fe57bb549ae6c1d5711f1b58d0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1097407
    Commit-Queue: Camille Lamy <clamy@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599176}

    Changed files

    • content/browser/frame_host/navigation_controller_impl.cc
    • content/browser/frame_host/navigation_controller_impl.h
    • content/browser/frame_host/navigation_entry_impl.cc
    • content/browser/frame_host/navigation_request.cc
    • content/browser/frame_host/navigation_request.h
    • content/browser/frame_host/navigator_impl.cc
    • content/browser/frame_host/render_frame_host_manager_unittest.cc
  7. [css-properties-values-api] Support StylePropertyMap.append.

    Changed by andruudohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:05:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84056b7e0dee6cb71b889254c2f33c0b338002fb

    Comments

    [css-properties-values-api] Support StylePropertyMap.append.
    
    This CL makes it possible to append values to list-valued properties.
    
    To do this, we must produce a CSSStyleValueVector which holds the final
    value produced by the append (i.e. the concatenation of the existing
    values and the incoming values). Then (like for StylePropertyMap.set),
    a CSSVariableReferenceValue with equivalent tokens is created from that
    vector.
    
    Bonus: Fix names of some tests to make it easier to read the output.
    
    R=chrishtr@chromium.org
    
    Bug: 641877
    Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
    Reviewed-on: https://chromium-review.googlesource.com/c/1270967
    Commit-Queue: Anders Ruud <andruud@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599177}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-properties-values-api/typedom.tentative.html
    • third_party/blink/renderer/core/css/cssom/style_property_map.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.cc
    • third_party/blink/renderer/core/css/cssom/style_property_map_read_only.h
  8. Enable IdentityTestEnvironment to take in IdentityManager's dependencies

    Changed by blundellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:09:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b64e54c9a221efad82a4a60956cd3b58ac371059

    Comments

    Enable IdentityTestEnvironment to take in IdentityManager's dependencies
    
    Currently, IdentityTestEnvironment internally constructs all the
    dependencies of IdentityManager as well as the IdentityManager object
    itself. This behavior is nice for hiding the fact that IdentityManager
    has these dependencies from consumers, but doesn't allow for
    usage of IdentityTestEnviroment in incremental conversion of tests that
    have broad direct usage of these dependencies. Concretely,
    profile_sync_test_util.h provides 
    ...skip...
    .  It also moves ownership of
    IdentityManager from that internal object to IdentityTestEnvironment
    itself so that it can be created/owned independent of that internal
    object.
    
    A followup CL will use this new constructor.
    
    Bug: 886599
    Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
    Reviewed-on: https://chromium-review.googlesource.com/c/1273298
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599178}

    Changed files

    • services/identity/public/cpp/identity_test_environment.cc
    • services/identity/public/cpp/identity_test_environment.h
  9. Revert "Make DriveFS opt-out in FilesApp tests."

    Changed by orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:11:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70d0138d92d063b4d3032ffae54c950cf7c13f41

    Comments

    Revert "Make DriveFS opt-out in FilesApp tests."
    
    This reverts commit e9c79d562d8d3b789cca95b6909aa600a1dd39d2.
    
    Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
    Bug: 894799
    
    Original change's description:
    > Make DriveFS opt-out in FilesApp tests.
    > 
    > Bug: 891197
    > Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    > Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    > Reviewed-by: Noel Gordon <noel@chromium.org>
    > Commit-Queue: Sam McNally <sammc@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599117}
    
    TBR=noel@chromium.org,sammc@chromium.org
    
    Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 891197
    Reviewed-on: https://chromium-review.googlesource.com/c/1278757
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599179}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  10. Revert "[blink] Control ScriptStreamer with ScriptResource"

    Changed by orphisohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7590d68012b9cf52c14e3f44e019ea36ecc2d9e

    Comments

    Revert "[blink] Control ScriptStreamer with ScriptResource"
    
    This reverts commit 7bd9163502462762e58d8010577dbf36aeef6c13.
    
    Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
    Bug: 894792, 894795
    
    Original change's description:
    > [blink] Control ScriptStreamer with ScriptResource
    > 
    > Move the ScriptStreamer control logic from ClassicPendingScript to
    > ScriptResource. In the future, this will allow us to start streaming
    > a ScriptResource before the ClassicPendingScript is 
    ...skip...
    refs/heads/master@{#599148}
    
    TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org
    
    Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:865098
    Reviewed-on: https://chromium-review.googlesource.com/c/1278758
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599180}

    Changed files

    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt
    • third_party/blink/renderer/bindings/core/v8/script_streamer.cc
    • third_party/blink/renderer/bindings/core/v8/script_streamer.h
    • third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
    • third_party/blink/renderer/bindings/core/v8/v8_script_runner_test.cc
    • third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • third_party/blink/renderer/core/loader/document_loader.cc
    • third_party/blink/renderer/core/loader/modulescript/document_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/module_script_loader_test.cc
    • third_party/blink/renderer/core/loader/modulescript/worker_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/modulescript/worklet_module_script_fetcher.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.cc
    • third_party/blink/renderer/core/loader/resource/script_resource.h
    • third_party/blink/renderer/core/script/classic_pending_script.cc
    • third_party/blink/renderer/core/script/classic_pending_script.h
    • third_party/blink/renderer/core/script/document_write_intervention.cc
    • third_party/blink/renderer/core/script/pending_script.h
    • third_party/blink/renderer/platform/loader/fetch/resource.cc
    • third_party/blink/renderer/platform/loader/fetch/resource.h
    • tools/metrics/histograms/enums.xml
  11. Don't update style for focusability when render-blocking.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 12:16:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 369b6fca37d5b416775fd7fafdbc6bde78a18bf8

    Comments

    Don't update style for focusability when render-blocking.
    
    WebNode::IsFocusable() updated style and layout tree, without ignoring
    pending stylesheets, which meant generating a display:none placeholder
    style for the root node. Instead, early return from IsFocusable() when
    we are blocking rendering.
    
    Bug: 521692
    
    Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
    Reviewed-on: https://chromium-review.googlesource.com/c/1245787
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599181}

    Changed files

    • third_party/blink/renderer/core/exported/web_node.cc
    • third_party/blink/renderer/core/exported/web_node_test.cc
  12. Reland "[sync::test] Add single client integration test for custom passphrase"

    Changed by davidovicohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 12:18:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1df3c494cc8dc1ef26ec3514b74b27c3047a4db

    Comments

    Reland "[sync::test] Add single client integration test for custom passphrase"
    
    This is a reland of 475bfe9da1df9ab55685e0a9ce1a62d8e50536f1. Fixed test
    failures which happened because some DCHECKs had side effects.
    
    Original change's description:
    > [sync::test] Add single client integration test for custom passphrase
    >
    > Add a Sync integration test which exercises custom passphrase flows, including
    > the handling and proper functioning of the newly added key derivation method
    > (scrypt).
    >
    > Add an i
    ...skip...
     David Davidović <davidovic@google.com>
    > Reviewed-by: vitaliii <vitaliii@chromium.org>
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598912}
    
    Bug: 894148
    Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
    Reviewed-on: https://chromium-review.googlesource.com/c/1278790
    Commit-Queue: David Davidović <davidovic@google.com>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: vitaliii <vitaliii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599182}

    Changed files

    • chrome/browser/sync/test/integration/bookmarks_helper.cc
    • chrome/browser/sync/test/integration/bookmarks_helper.h
    • chrome/browser/sync/test/integration/encryption_helper.cc
    • chrome/browser/sync/test/integration/encryption_helper.h
    • chrome/browser/sync/test/integration/profile_sync_service_harness.cc
    • chrome/browser/sync/test/integration/profile_sync_service_harness.h
    • chrome/browser/sync/test/integration/single_client_custom_passphrase_sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.cc
    • chrome/browser/sync/test/integration/sync_test.h
    • chrome/test/BUILD.gn
    • components/sync/engine_impl/loopback_server/loopback_server.cc
    • components/sync/engine_impl/loopback_server/loopback_server.h
    • components/sync/test/fake_server/fake_server.cc
    • components/sync/test/fake_server/fake_server.h
  13. Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 12:35:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9729f6efb4bae858cc91b281091f2df86433da8a

    Comments

    Roll src/third_party/webrtc 28d200c24624..55d1af14751a (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a
    
    
    git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
    2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@55d1af14751a
    
    The AutoRoll server is located here: https://auto
    ...skip...
    ary.
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
    Reviewed-on: https://chromium-review.googlesource.com/c/1278709
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599183}

    Changed files

    • DEPS