Home | Search
Login

Builder WebKit Linux Trusty MSAN Build #10437

Results:

build successful

Trigger Info:

Got Revisiond6d014a7e5ef0d330fef991ab82343f02e71b6f8

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 30 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 3 ms ) report builders
    report builders
     
    running builder/tester 'WebKit Linux Trusty MSAN' on master 'chromium.webkit'
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 3 mins 32 secs ) bot_update
    bot_update
    [63GB/492GB used (12%)]
  9. ( 3 ms ) ensure_goma
    ensure_goma
  10. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 33 secs ) gclient runhooks
    gclient runhooks
  13. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 4 ms ) read test spec (chromium.webkit.json)
    read test spec (chromium.webkit.json)
    path: /b/c/b/linux_layout/src/testing/buildbot/chromium.webkit.json
  15. ( 3 ms ) clean isolated files
    clean isolated files
  16. ( 3 ms ) lookup GN args
    lookup GN args
     
    is_component_build = false
    is_debug = false
    is_msan = true
    msan_track_origins = 2
    strip_absolute_paths_from_debug_symbols = true
    use_goma = true
    use_prebuilt_instrumented_libraries = true
    goma_dir = "/b/c/goma_cache/client"
  17. ( 32 secs ) generate_build_files
    generate_build_files
  18. ( 4 ms ) clang_revision
    clang_revision
  19. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  20. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  21. ( 7 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  22. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  23. ( 24 mins 42 secs ) compile
    compile
  24. ( 3 ms ) compile confirm no-op
    compile confirm no-op
  25. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  26. ( 4 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  27. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  28. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  29. ( 16 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  30. ( 6 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  31. ( 1 mins 56 secs ) isolate webkit_layout_tests_exparchive
    isolate webkit_layout_tests_exparchive
  32. ( 4 ms ) find isolated tests
    find isolated tests
  33. ( 3 ms ) test_pre_run
    test_pre_run
  34. ( 6 secs ) test_pre_run.[trigger] webkit_layout_tests
    test_pre_run.[trigger] webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
  35. ( 49 mins 41 secs ) webkit_layout_tests
    webkit_layout_tests
    Run on OS: 'Ubuntu-14.04'
    Max shard duration: 0:47:24.150936 (shard #9)
    Min shard duration: 0:28:41.418006 (shard #3)
    Total tests: 87452
    * Passed: 75296 (75269 expected, 27 unexpected)
    * Skipped: 11844 (11844 expected, 0 unexpected)
    * Failed: 240 (240 expected, 0 unexpected)
    * Flaky: 72 (72 expected, 0 unexpected)
     
  36. ( 7 mins 15 secs ) Upload to test-results [webkit_layout_tests]
    Upload to test-results [webkit_layout_tests]
  37. ( 7 secs ) archive results for webkit_layout_tests
    archive results for webkit_layout_tests
  38. ( 5 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 20
    Total runtime: 12:54:35.790193
     
  39. ( 4 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/10437/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.webkit/WebKit_Linux_Trusty_MSAN/10437" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "671809e62e807eb0f890a5d53eee1f8cb5fb825e" Annotation(bot_update)
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" Annotation(bot_update)
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" Annotation(bot_update)
got_revision "d6d014a7e5ef0d330fef991ab82343f02e71b6f8" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#599127}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "f70aaa8ab2e8815505a6145c745e50d8328cd28c" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.1.302@{#1}" Annotation(bot_update)
got_webrtc_revision "a54daf162facb9fe30bcc3e05bd21c1597076157" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#25135}" Annotation(bot_update)
got_clang_revision "344066-1" Annotation(clang_revision)
swarm_hashes {"webkit_layout_tests_exparchive":"aa6aafcc13063ef3d3e1f6f339f15bb17527eacd"} Annotation(find isolated tests)
swarm_hashes_refs/heads/master(at){#599127}_without_patch {"webkit_layout_tests_exparchive":"aa6aafcc13063ef3d3e1f6f339f15bb17527eacd"} Annotation(isolate webkit_layout_tests_exparchive)
build_data_dir "/b/rr/tmp_uNpDJ" Annotation(steps)
build_id "buildbot/chromium.webkit/WebKit Linux Trusty MSAN/10437" Annotation(steps)
builder_id "master.chromium.webkit:WebKit Linux Trusty MSAN" Annotation(steps)
blamelist ["acourbot@chromium.org","ccameron@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","grunell@chromium.org","jochen@chromium.org","jzw@chromium.org","momohatt10@gmail.com","msisov@igalia.com","noel@chromium.org","patricialor@chromium.org","rajendrant@chromium.org","sammc@chromium.org","tapted@chromium.org","yiyix@chromium.org","yukiy@google.com"] Build
branch "master" Build
buildnumber 10437 Build
project "chromium" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1539324570 Build
revision "d6d014a7e5ef0d330fef991ab82343f02e71b6f8" Build
slavename "slave161-c1" BuildSlave
buildername "WebKit Linux Trusty MSAN" Builder
git_revision "d6d014a7e5ef0d330fef991ab82343f02e71b6f8" Change
scheduler "global_scheduler" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.webkit/" master.cfg
mastername "chromium.webkit" master.cfg
workdir "/b/build/slave/WebKit_Linux_Trusty_MSAN" slave

Blamelist:

  1. (yukiyohnoyoudont@google.com)
  2. (patricialorohnoyoudont@chromium.org)
  3. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  4. (rajendrantohnoyoudont@chromium.org)
  5. (yukiyohnoyoudont@google.com)
  6. (taptedohnoyoudont@chromium.org)
  7. (acourbotohnoyoudont@chromium.org)
  8. (sammcohnoyoudont@chromium.org)
  9. (taptedohnoyoudont@chromium.org)
  10. (ccameronohnoyoudont@chromium.org)
  11. (msisovohnoyoudont@igalia.com)
  12. (yiyixohnoyoudont@chromium.org)
  13. (jochenohnoyoudont@chromium.org)
  14. (grunellohnoyoudont@chromium.org)
  15. (jzwohnoyoudont@chromium.org)
  16. (noelohnoyoudont@chromium.org)
  17. (momohatt10ohnoyoudont@gmail.com)
  18. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)

Timing:

Create N/A
Start Friday, 12-Oct-18 07:19:55 UTC
End Friday, 12-Oct-18 08:50:12 UTC
Pending N/A
Execution 1 hrs 30 mins

All Changes:

  1. Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()

    Changed by yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:08:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f93617e5eb9f06935b07002223f33d164f517909

    Comments

    Create v8::HandleScope in JSBasedEventListener::GetSourceLocation()
    
    This is the bug fixing for previous CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/1253317
    
    v8::HandleScope was not named.
    
    Bug: 894069
    Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533
    Reviewed-on: https://chromium-review.googlesource.com/c/1278548
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599110}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  2. Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."

    Changed by patricialorohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:10:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2893ee9102687d16f2f65fa96651d8bd1fdab7

    Comments

    Revert "[Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering."
    
    This reverts commit 86da6573944f302cf9df04d59a7e35bba895d059.
    
    Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1)
      https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29
    
    Findit found culprit 598844 with 75% confidence, so reverting this to try and fix.
    
    Original change's description:
    > [Tango->FCM] Do not per
    ...skip...
    >
    > Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#598844}
    
    TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org
    
    Change-Id: I70fa87c3476925814408665644acb23c3c1f1614
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 801985, 876274, 894715
    Reviewed-on: https://chromium-review.googlesource.com/c/1278273
    Reviewed-by: Patti <patricialor@chromium.org>
    Commit-Queue: Patti <patricialor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599111}

    Changed files

    • chrome/browser/prefs/browser_prefs.cc
    • components/invalidation/impl/BUILD.gn
    • components/invalidation/impl/fcm_fake_invalidator.cc
    • components/invalidation/impl/fcm_invalidation_listener.cc
    • components/invalidation/impl/fcm_invalidation_listener.h
    • components/invalidation/impl/fcm_invalidation_service.cc
    • components/invalidation/impl/fcm_invalidation_service.h
    • components/invalidation/impl/fcm_invalidation_service_unittest.cc
    • components/invalidation/impl/invalidator_registrar.cc
    • components/invalidation/impl/invalidator_registrar.h
    • components/invalidation/impl/invalidator_registrar_with_memory.cc
    • components/invalidation/impl/invalidator_registrar_with_memory.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
  3. Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 06:12:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 028fceebebe0743ddd7bb16dc8b753ae0f41a3f2

    Comments

    Roll src/third_party/chromite 89e4bf93b1a1..e2727ef6f5dc (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc
    
    
    git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s'
    2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error.
    2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS
    2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock
    
    
    Created with:
      gclient setdep -r
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453
    Reviewed-on: https://chromium-review.googlesource.com/c/1278301
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599112}

    Changed files

    • DEPS
  4. Remove service name and refactor data use update to metrics service

    Changed by rajendrantohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:24:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dce70a031f697342a52b900211aa0ba7eceab082

    Comments

    Remove service name and refactor data use update to metrics service
    
    This CL does a bunch of steps to make the servicification easy to do.
    1. Removes the usage of ServiceName in data_use_measurement
    2. Refactors the data use update to metrics service to not take service
    name and instead send if the data use is from metrics component.
    3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(),
    ChromeDataUseMeasurement is introduced that does the posting to UI thread
    (from io_thread.cc). This he
    ...skip...
     CDUA classes are removed, and
    ChromeDataUseMeasurement can be there without dependency.
    
    Bug: 808498
    Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48
    Reviewed-on: https://chromium-review.googlesource.com/c/1272256
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Roger Tawa <rogerta@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599113}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
    • chrome/browser/data_use_measurement/chrome_data_use_ascriber.h
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.cc
    • chrome/browser/data_use_measurement/chrome_data_use_measurement.h
    • chrome/browser/io_thread.cc
    • chrome/browser/io_thread.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/data_use_measurement/core/BUILD.gn
    • components/data_use_measurement/core/DEPS
    • components/data_use_measurement/core/data_use_ascriber.cc
    • components/data_use_measurement/core/data_use_ascriber.h
    • components/data_use_measurement/core/data_use_measurement.cc
    • components/data_use_measurement/core/data_use_measurement.h
    • components/data_use_measurement/core/data_use_measurement_unittest.cc
    • components/data_use_measurement/core/data_use_network_delegate.cc
    • components/data_use_measurement/core/data_use_network_delegate.h
    • components/data_use_measurement/core/data_use_network_delegate_unittest.cc
    • components/data_use_measurement/core/data_use_user_data.cc
    • components/data_use_measurement/core/data_use_user_data.h
    • components/domain_reliability/uploader.cc
    • components/domain_reliability/uploader.h
    • components/metrics/data_use_tracker.cc
    • components/metrics/data_use_tracker.h
    • components/metrics/data_use_tracker_unittest.cc
    • components/metrics/metrics_service.cc
    • components/metrics/metrics_service.h
    • components/metrics/reporting_service.cc
    • components/metrics/reporting_service.h
    • google_apis/gaia/gaia_auth_util.cc
    • google_apis/gaia/gaia_auth_util.h
    • google_apis/gaia/gaia_oauth_client.cc
    • google_apis/gaia/oauth2_api_call_flow.cc
    • tools/metrics/histograms/histograms.xml
  5. Rename scopes and context in JSBasedEventListener::handleEvent()

    Changed by yukiyohnoyoudont@google.com
    Changed at Friday, 12-Oct-18 06:29:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7d87839234fceb435e01ca49cf72096ef6691599

    Comments

    Rename scopes and context in JSBasedEventListener::handleEvent()
    
    This CL renames some ambiguous name of scope and context in
    JSBasedEventListener::handleEvent().
    
    Split from another one:
    https://chromium-review.googlesource.com/c/chromium/src/+/1270300
    
    Bug: 872138
    Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608
    Reviewed-on: https://chromium-review.googlesource.com/c/1277135
    Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
    Commit-Queue: Yuki Yamada <yukiy@google.com>
    Cr-Commit-Position: refs/heads/master@{#599114}

    Changed files

    • third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc
  6. Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js

    Changed by taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:29:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1c3184cbbf9ddeb41ba405c34066f10a3fe37e4

    Comments

    Files App: Move reportPromise,waitUntil to //ui/file_manager/base/js/test_error_reporting.js
    
    These functions are currently in file_manager/file_manager/common/js/unittest_util.js
    which has a lot of files-app specific stuff that media apps shouldn't
    depend on.
    
     - Move MockAPIEvent to the only unittest (in gallery) that uses it.
     - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js
     - Updates the remaining handcrafted foo_unittest.html files in the files app
       * combination sed-script and manual edit.
    
    Bug: 879035
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1
    Reviewed-on: https://chromium-review.googlesource.com/c/1275545
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599115}

    Changed files

    • ui/file_manager/base/js/BUILD.gn
    • ui/file_manager/base/js/test_error_reporting.js
    • ui/file_manager/file_manager/background/js/device_handler_unittest.html
    • ui/file_manager/file_manager/background/js/duplicate_finder_unittest.html
    • ui/file_manager/file_manager/background/js/file_operation_manager_unittest.html
    • ui/file_manager/file_manager/background/js/import_history_unittest.html
    • ui/file_manager/file_manager/background/js/media_import_handler_unittest.html
    • ui/file_manager/file_manager/background/js/media_scanner_unittest.html
    • ui/file_manager/file_manager/background/js/task_queue_unittest.html
    • ui/file_manager/file_manager/background/js/volume_manager_unittest.html
    • ui/file_manager/file_manager/common/js/BUILD.gn
    • ui/file_manager/file_manager/common/js/metrics_unittest.html
    • ui/file_manager/file_manager/common/js/unittest_util.js
    • ui/file_manager/file_manager/foreground/elements/files_tooltip_unittest.html
    • ui/file_manager/file_manager/foreground/js/BUILD.gn
    • ui/file_manager/file_manager/foreground/js/actions_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/file_tasks_unittest.html
    • ui/file_manager/file_manager/foreground/js/import_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.html
    • ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js
    • ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/file_system_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_item_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/metadata_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/multi_metadata_provider_unittest.html
    • ui/file_manager/file_manager/foreground/js/metadata/thumbnail_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/providers_model_unittest.html
    • ui/file_manager/file_manager/foreground/js/spinner_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/task_controller_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html
    • ui/file_manager/file_manager/foreground/js/ui/file_tap_handler_unittest.html
    • ui/file_manager/gallery/js/BUILD.gn
    • ui/file_manager/gallery/js/entry_list_watcher_unittest.js
    • ui/file_manager/gallery/js/image_editor/BUILD.gn
    • ui/file_manager/image_loader/BUILD.gn
  7. media/gpu/v4l2: use actual number of planes in ioctls

    Changed by acourbotohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec52397f2ea0fb8ac322378d229f1a454edf972

    Comments

    media/gpu/v4l2: use actual number of planes in ioctls
    
    The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that
    makes it fail if the number of planes of the passed v4l2_buffer does not
    exactly match the number of planes of the currently set format. This CL
    implements a workaround by first running a VIDIOC_G_FMT ioctl in
    AllocateBuffers(), and then passing the returned number of planes to the
    buffer constructor so the correct value can be passed to
    VIDIOC_QUERYBUF.
    
    And since we have this value, we also use it in VIDIOC_DQBUF.
    
    BUG=893661
    TEST=Checked that VDA unittest was passing on hana (Tegra devices have
    another bug that is fixed in the next CL).
    
    Change-Id: I830334de1cf322302fd476ac5535313ebc65900d
    Reviewed-on: https://chromium-review.googlesource.com/c/1275726
    Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599116}

    Changed files

    • media/gpu/v4l2/v4l2_device.cc
    • media/gpu/v4l2/v4l2_device.h
  8. Make DriveFS opt-out in FilesApp tests.

    Changed by sammcohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:33:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9c79d562d8d3b789cca95b6909aa600a1dd39d2

    Comments

    Make DriveFS opt-out in FilesApp tests.
    
    Bug: 891197
    Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
    Reviewed-on: https://chromium-review.googlesource.com/c/1277133
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599117}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
  9. Migrate base::AtomicFlag to std::atomic

    Changed by taptedohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d64bfc8e330fea105de74137e6e176763dc546a4

    Comments

    Migrate base::AtomicFlag to std::atomic
    
    atomicops.h uses `volatile` which inhibits some compiler optimisations
    without contributing to threading correctness.
    
    Define AtomicFlag::IsSet() in the header, rather than out-of-line.
    Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver
    in base_perftests are up to 70% greater.
    
    Bug: 891536
    Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d
    Reviewed-on: https://chromium-review.googlesource.com/c/1278425
    Commit-Queue: Trent Apted <tapted@chromium.org>
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599118}

    Changed files

    • base/synchronization/atomic_flag.cc
    • base/synchronization/atomic_flag.h
  10. RemoteMacViews: Make fullscreen mode not crash

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:34:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 800a927eb503828f5cf6f489739e1a6efc444429

    Comments

    RemoteMacViews: Make fullscreen mode not crash
    
    Fix a few places where we would dereference a BridgedNativeWidgetImpl
    which is null when out-of-process. This doesn't guarantee correct
    behavior, but avoids a crash.
    
    Make WebContentsNSViewBridge::Show resize the web contents view and
    also all of its children.
    
    Bug: 859152
    Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342
    Reviewed-on: https://chromium-review.googlesource.com/c/1278533
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599119}

    Changed files

    • chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_views.mm
    • content/browser/web_contents/web_contents_ns_view_bridge.mm
  11. [ozone/wayland] Fix kiosk mode.

    Changed by msisovohnoyoudont@igalia.com
    Changed at Friday, 12-Oct-18 06:36:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f154daab631433d3d9706af7f3512aa6b196e52f

    Comments

    [ozone/wayland] Fix kiosk mode.
    
    This CL fixes a fullscreen state changes before the surface is
    activated.
    
    That is, Wayland may ignore fullscreen changes before the surface
    is activated. Thus, store a pending state, and once the surface
    is activated, trigger the change.
    
    Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a
    Bug: 843018
    Reviewed-on: https://chromium-review.googlesource.com/c/1275885
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#599120}

    Changed files

    • ui/ozone/platform/wayland/wayland_window.cc
    • ui/ozone/platform/wayland/wayland_window.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  12. GPU_Tests: Remove expectations after rebaseline

    Changed by yiyixohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c30443b0e8a01efd448efc72829fb96584f0db0

    Comments

    GPU_Tests: Remove expectations after rebaseline
    
    Bug: 879379
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1
    Reviewed-on: https://chromium-review.googlesource.com/c/1277953
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599121}

    Changed files

    • content/test/gpu/gpu_tests/pixel_expectations.py
  13. Remove the round-robin list for third-party additions

    Changed by jochenohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:51:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13767a51fd778bba049621a733ac7fbe6221922b

    Comments

    Remove the round-robin list for third-party additions
    
    Instead, require an email to opensource-licensing@ again until we
    figured out the new process.
    
    R=jam@chromium.org
    
    Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c
    Reviewed-on: https://chromium-review.googlesource.com/c/1275846
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599122}

    Changed files

    • docs/adding_to_third_party.md
    • third_party/OWNERS
  14. Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"

    Changed by grunellohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 06:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7bb43df173039894cf46c8b3476913f0f20ae6d1

    Comments

    Revert "[Video Capture, Test] Make tests requiring real webcam fail if it's not found"
    
    This reverts commit dfeab488cdc95233b19b9edeedef3d0b7581b17e.
    
    Reason for revert: Tests fail on Chromium WebRTC bots. Example: https://ci.chromium.org/buildbot/chromium.webrtc/Mac%20Tester/84091
    
    Original change's description:
    > [Video Capture, Test] Make tests requiring real webcam fail if it's not found
    > 
    > Use prefix "UsingRealWebcam_" for names of tests that require real webcam and
    > add checking whether webca
    ...skip...
    
    > Reviewed-by: Ben Pastene <bpastene@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599097}
    
    TBR=bpastene@chromium.org,chfremer@chromium.org,keiichiw@chromium.org
    
    Change-Id: I282dc00ffad2ff6614e7dfab1a9404da85cf032a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 893494
    Reviewed-on: https://chromium-review.googlesource.com/c/1278272
    Reviewed-by: Henrik Grunell <grunell@chromium.org>
    Commit-Queue: Henrik Grunell <grunell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599123}

    Changed files

    • media/capture/video/video_capture_device_unittest.cc
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  15. Clarify |stopSyncAndClearIdentity| with additional comment.

    Changed by jzwohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:03:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3255a4ba5a80b407cc61864a85c469842894f469

    Comments

    Clarify |stopSyncAndClearIdentity| with additional comment.
    
    Namely, it is OK to call it multiple times.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I7348628de6e39ca50461c25db7343cd46b5f069a
    Reviewed-on: https://chromium-review.googlesource.com/c/1278061
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599124}

    Changed files

    • ios/web_view/public/cwv_sync_controller.h
  16. Add Quick View audio load test

    Changed by noelohnoyoudont@chromium.org
    Changed at Friday, 12-Oct-18 07:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae2fcf0ef323eb487edced1ab876a090b3f9ce1e

    Comments

    Add Quick View audio load test
    
    Now we have the QuickView <webview> infra to detect the 'loaded' state
    of the <webview> content, add a <file-safe-media> audio test, and also
    check the <webview> renders its content on a transparent black body.
    
    This test exposed an issue in Blink node code. When the modal <dialog>
    is calling showModal(), its flat tree distribution can be out-of-date,
    causing a DCHECK crash when testing if the Quick View <dialog> element
    contains sibling <iframe id="command-dispatcher">
    ...skip...
    dal-shadow-sibling-frame-crash.html
    
    [1] Known crash reports already exist: issue 789094 issue 804047.
    
    test: browser_tests --gtest_filter="QuickView*openQuickViewAudio"
    Bug: 891150, 789094, 804047
    Change-Id: I714585272fc775c157f6d0bd97143af27bf2b961
    Reviewed-on: https://chromium-review.googlesource.com/c/1264138
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599125}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash-expected.txt
    • third_party/WebKit/LayoutTests/html/dialog/showmodal-shadow-sibling-frame-crash.html
    • third_party/blink/renderer/core/html/html_dialog_element.cc
    • ui/file_manager/integration_tests/file_manager/quick_view.js
  17. [ServiceWorker] Add WPT tests to check request header for update

    Changed by momohatt10ohnoyoudont@gmail.com
    Changed at Friday, 12-Oct-18 07:05:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4512662655ea5694ebba6c13055e99c9a0b2d096

    Comments

    [ServiceWorker] Add WPT tests to check request header for update
    
    Spec requires that during the update of service workers, request headers
    for fetching main scripts should include "Service-Worker" field, while
    that for fetching importScripts() resources should not.
    This patch adds WPT tests to validate this behavior.
    
    Change-Id: I24949fd0b375f6b811a73ce24aae87a4ea7c234f
    Reviewed-on: https://chromium-review.googlesource.com/c/1267297
    Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599126}

    Changed files

    • AUTHORS
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/service-worker-header.py
    • third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/service-worker-header.https.html
  18. Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Friday, 12-Oct-18 07:17:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6d014a7e5ef0d330fef991ab82343f02e71b6f8

    Comments

    Roll src-internal aebffd21b13f..7781cb9daa22 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aebffd21b13f..7781cb9daa22
    
    
    Created with:
      gclient setdep -r src-internal@7781cb9daa22
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: Ib8911116b9b81a6503414f98f9988cd10a39144e
    Reviewed-on: https://chromium-review.googlesource.com/c/1278303
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#599127}

    Changed files

    • DEPS