Home | Search
Login

Builder win-10-perf Build #138 Microsoft Windows

Results:

Failure

Trigger Info:

Got Revision62892558b716d1560264e42929e2be01ead07e71

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 30 mins ) steps
    running steps via annotated script
  2. ( 15 secs ) update_scripts
    update_scripts
  3. ( 2 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 5 secs ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 2 mins 3 secs ) bot_update
    bot_update
    [77GB/349GB used (22%)]
  9. ( 1 ms ) ensure_goma
    ensure_goma
  10. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 25 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\win_10_perf\src\testing\buildbot\chromium.perf.json
  15. ( 1 ms ) build directory
    build directory
  16. ( 1 mins 57 secs ) extract build
    extract build
  17. ( 1 ms ) find isolated tests
    find isolated tests
  18. ( 1 ms ) test_pre_run
    test_pre_run
  19. ( 1 ms ) test_pre_run.[trigger] components_perftests on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] components_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  20. ( 7 secs ) test_pre_run.[trigger] media_perftests on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] media_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  21. ( 2 mins 6 secs ) test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  22. ( 1 ms ) test_pre_run.[trigger] views_perftests on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] views_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  23. ( 9 secs ) components_perftests on Intel GPU on Windows on Windows-10
    components_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Pending time: 53s
    Shard duration: 53s
    Total tests: n/a
     
  24. ( 5 secs ) media_perftests on Intel GPU on Windows on Windows-10
    media_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Pending time: 0:01:44.470580
    Shard duration: 31s
    Total tests: n/a
     
  25. ( 1 hrs 22 mins ) performance_test_suite on Intel GPU on Windows on Windows-10
    performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 0:01:51.014490 (shard #0)
    Max shard duration: 1:06:22.042890 (shard #25)
    Min shard duration: 0:18:21.730880 (shard #2)
    Total tests: 1034
    * Passed: 984 (984 expected, 0 unexpected)
    * Skipped: 49 (49 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 1 (0 expected, >>>1 unexpected<<<)
     
    Unexpected Flakes:
    * loading.desktop/Kenh14_warm
     
  26. ( 7 secs ) Upload to test-results [performance_test_suite on Intel GPU on Windows]
    Upload to test-results [performance_test_suite on Intel GPU on Windows]
  27. ( 3 ms ) views_perftests on Intel GPU on Windows on Windows-10
    views_perftests on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Pending time: 0:42:24.063070
    Shard duration: 22s
    Total tests: n/a
     
  28. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 29
    Total runtime: 21:54:09.512001
     
  29. ( 1 ms ) process_dumps
    process_dumps
  30. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/win-10-perf/138/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/win-10-perf/138" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "077cd858b2d4ca7632a585a27846fd6db1752969" Annotation(bot_update)
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" Annotation(bot_update)
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" Annotation(bot_update)
got_revision "62892558b716d1560264e42929e2be01ead07e71" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#582378}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.0.193@{#2}" Annotation(bot_update)
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24263}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"70dc4844a5471f716072e9bd2213fad2d99943ad","command_buffer_perftests":"c8ff77f58e011c1ef7a8c612657840d6752493dd","components_perftests":"f8467cbc0e021c0b2ee7c104d3c7a33e20c4caea","load_library_perf_tests":"d67ff68ddacdeabebcaff9cc5723eea299df414d","media_perftests":"da073dd06598ea99651995e13ee0039201d98b65","performance_test_suite":"1904aedcc946dcb7bf840a0bd37e9d38d87869b5","views_perftests":"9bf46f364ce981c3d8d039c22a52f9809be6d9f3"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmpym17mv" Annotation(steps)
build_id "buildbot/chromium.perf/win-10-perf/138" Annotation(steps)
builder_id "master.chromium.perf:win-10-perf" Annotation(steps)
blamelist ["avi@chromium.org","ccameron@chromium.org","donnd@chromium.org","enne@chromium.org","erikchen@chromium.org","eroman@chromium.org","gab@chromium.org","hgrandinetti@chromium.org","imcheng@chromium.org","johnchen@chromium.org","jsbell@chromium.org","martinkr@google.com","nzolghadr@chromium.org","pkasting@chromium.org","raphael.kubo.da.costa@intel.com","skare@chromium.org","sky@chromium.org","smaier@chromium.org","uwyiming@google.com","weidongg@chromium.org","wnwen@chromium.org","xiaoyinh@chromium.org","yuweih@chromium.org"] Build
branch "master" Build
buildnumber 138 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1533959899 Build
revision "62892558b716d1560264e42929e2be01ead07e71" Build
slavename "vm3-m1" BuildSlave
buildername "win-10-perf" Builder
git_revision "62892558b716d1560264e42929e2be01ead07e71" Change
parent_buildername "Win x64 Builder Perf" ParentBuild
parent_buildnumber 34710 ParentBuild
parent_got_angle_revision "077cd858b2d4ca7632a585a27846fd6db1752969" ParentBuild
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" ParentBuild
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" ParentBuild
parent_got_revision "62892558b716d1560264e42929e2be01ead07e71" ParentBuild
parent_got_revision_cp "refs/heads/master@{#582378}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" ParentBuild
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/win-10-perf" slave

Blamelist:

  1. (nzolghadrohnoyoudont@chromium.org)
  2. (enneohnoyoudont@chromium.org)
  3. (pkastingohnoyoudont@chromium.org)
  4. (jsbellohnoyoudont@chromium.org)
  5. (hgrandinettiohnoyoudont@chromium.org)
  6. (johnchenohnoyoudont@chromium.org)
  7. (smaierohnoyoudont@chromium.org)
  8. (uwyimingohnoyoudont@google.com)
  9. (raphael.kubo.da.costaohnoyoudont@intel.com)
  10. (weidonggohnoyoudont@chromium.org)
  11. (yuweihohnoyoudont@chromium.org)
  12. (pkastingohnoyoudont@chromium.org)
  13. (aviohnoyoudont@chromium.org)
  14. (enneohnoyoudont@chromium.org)
  15. (pkastingohnoyoudont@chromium.org)
  16. (wnwenohnoyoudont@chromium.org)
  17. (martinkrohnoyoudont@google.com)
  18. (imchengohnoyoudont@chromium.org)
  19. (skyohnoyoudont@chromium.org)
  20. (skareohnoyoudont@chromium.org)
  21. (xiaoyinhohnoyoudont@chromium.org)
  22. (gabohnoyoudont@chromium.org)
  23. (erikchenohnoyoudont@chromium.org)
  24. (eromanohnoyoudont@chromium.org)
  25. (donndohnoyoudont@chromium.org)
  26. (ccameronohnoyoudont@chromium.org)

Timing:

Create N/A
Start Saturday, 11-Aug-18 05:33:37 UTC
End Saturday, 11-Aug-18 07:04:26 UTC
Pending N/A
Execution 1 hrs 30 mins

All Changes:

  1. Remove has_received_pointer_over state in PEM

    Changed by nzolghadrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:08:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0791976d2925f80203afb4a3248033c7a3a6e2de

    Comments

    Remove has_received_pointer_over state in PEM
    
    We used to store whether the target of pointerevent
    has recieved pointerover event or not to handle this
    correctly when capture gets active or lost. But since
    then the spec has change which made this state
    unnecessary.
    
    Change-Id: I98eed286b47463d2e103495ec66750d01e3fe58b
    Reviewed-on: https://chromium-review.googlesource.com/1169918
    Reviewed-by: Ella Ge <eirage@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582354}

    Changed files

    • third_party/blink/renderer/core/input/pointer_event_manager.cc
    • third_party/blink/renderer/core/input/pointer_event_manager.h
  2. Handle avoid_stencil_buffers workaround in OOP-R

    Changed by enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa0603bbbdbe385af7d7a4654fa8ef1796b262a0

    Comments

    Handle avoid_stencil_buffers workaround in OOP-R
    
    This could be handled in Skia, but there's already a context option for
    it, so just forward the workaround setting to that.
    
    Bug: 829614
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Iaeb625ea327b814d07854dd81eb0458598a0c137
    Reviewed-on: https://chromium-review.googlesource.com/1169771
    Commit-Queue: enne <enne@chromium.org>
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582353}

    Changed files

    • gpu/command_buffer/service/raster_decoder_context_state.cc
  3. Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c86f4a25a967715e1b357d2519a3b5fa75606fa5

    Comments

    Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"
    
    This reverts commit 3963b98df61fe488ddbd007ac5933cf62beff0df.
    
    Reason for revert: Consistent failures in ProfileWindowWebUIBrowserTest.UserManagerFocusSingleProfile, see e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/36834
    
    Original change's description:
    > cros: In OOBE, turn off scrolling if the screen fits in the container
    > 
    > Bug: 855546
    > Change-Id: I065c2bbd1e3db69dca3f8b18d
    ...skip...
    g>
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582312}
    
    TBR=alemate@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Icd9a6648582e8c49bcdbd4bd79d844745d54c2a9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 855546
    Reviewed-on: https://chromium-review.googlesource.com/1171703
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582355}

    Changed files

    • ui/login/display_manager.js
  4. Web Locks API: Update spec/explainer/idl links

    Changed by jsbellohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision beaa8766c0bea15820663d2881ad782c0c99eddb

    Comments

    Web Locks API: Update spec/explainer/idl links
    
    Spec work has moved into the WICG repository, so update links:
    
    Explainer: https://github.com/WICG/web-locks/
    Spec: https://wicg.github.io/web-locks/
    
    Bug: 161072
    Change-Id: I450beb25d8a7c9c0a80b06b7e84d7ac8db3cece1
    Reviewed-on: https://chromium-review.googlesource.com/1171213
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582356}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/web-locks/META.yml
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/README.md
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/acquire.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/clientids.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/frames.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/held.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/ifAvailable.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces-serviceworker.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/lock-attributes.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-exclusive.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-mixed.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-shared.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/non-secure-context.tentative.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/opaque-origin.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-empty.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-order.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/resource-names.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/secure-context.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/signal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/steal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/workers.tentative.https.html
    • third_party/blink/renderer/modules/locks/lock.idl
    • third_party/blink/renderer/modules/locks/lock_info.idl
    • third_party/blink/renderer/modules/locks/lock_manager.idl
    • third_party/blink/renderer/modules/locks/lock_manager_snapshot.idl
    • third_party/blink/renderer/modules/locks/lock_options.idl
    • third_party/blink/renderer/modules/locks/navigator_locks.idl
    • third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
  5. Fix search for next time limit start.

    Changed by hgrandinettiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:28:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1765353f3e592cc34c422b6146c0f4b5c1dd0dee

    Comments

    Fix search for next time limit start.
    
    In some situations the next Time Window Limit was not calculated correctly, this
    caused the TimeLimitController to recalculate the time limit constantly.
    
    Bug: 873228
    Change-Id: I6b88792aa6849774778d85d8dea2695192acc172
    Reviewed-on: https://chromium-review.googlesource.com/1171114
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#582359}

    Changed files

    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor.cc
    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor_unittest.cc
  6. [ChromeDriver] Fix location of browser snapshots

    Changed by johnchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46fa89282e8f5cbffee0c90f32dc3d1d998edc54

    Comments

    [ChromeDriver] Fix location of browser snapshots
    
    TBR=crouleau@chromium.org
    
    Change-Id: Id77c7546989bed6f3fdb269abdc2bc2e976ca4cd
    Reviewed-on: https://chromium-review.googlesource.com/1171679
    Reviewed-by: John Chen <johnchen@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582357}

    Changed files

    • chrome/test/chromedriver/archive.py
  7. Reland "Android: moving MediaUrlResolver tasks to thread pool"

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9102edc99321bd860523f03cfd63aa153738c9a

    Comments

    Reland "Android: moving MediaUrlResolver tasks to thread pool"
    
    This reverts commit 108f9e6cb07bdf3327b8b62e3ad43703b854662d.
    
    Reason for revert: Just re landing now that gerrit is OK
    
    Original change's description:
    > Revert "Android: moving MediaUrlResolver tasks to thread pool"
    > 
    > This reverts commit d20f6cb34484fbd5e7ca2c651974d71c62e2f4d0.
    > 
    > Reason for revert:Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questi
    ...skip...
     https://chromium-review.googlesource.com/1169854
    > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    
    TBR=mlamouri@chromium.org,tandrii@chromium.org,smaier@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 869907
    Change-Id: I31b02f5b543f2fdb8b0b089f241d79ceb720a626
    Reviewed-on: https://chromium-review.googlesource.com/1171702
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582358}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
    • chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
  8. Add iframe support to the Captured Sites Automation Framework.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:35:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02345664549dc8febb3ed7c839ea98573cd709e8

    Comments

    Add iframe support to the Captured Sites Automation Framework.
    
    This change allows the Captured Sites Automation Framework to replay
    interactions on iframes. As part of this change, I switched the
    automation framework to trigger the autofill popup by clicking on an
    input field instead of pressing the 'DOWN' key, which does not work in
    automation on some iframes.
    
    Also included in this change is a fix I made to address the issue that
    calling 'ASSERT' inside a test function does not abort the test.
    
    Change-Id: I15b30f878f04cb3ee2935879c2da4c474442ab27
    Reviewed-on: https://chromium-review.googlesource.com/1161603
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582360}

    Changed files

    • chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc
    • chrome/browser/autofill/autofill_uitest.cc
    • chrome/browser/autofill/autofill_uitest.h
    • chrome/browser/autofill/captured_sites_test_utils.cc
    • chrome/browser/autofill/captured_sites_test_utils.h
    • chrome/test/data/autofill/captured_sites/amazon.test
    • chrome/test/data/autofill/captured_sites/apple.test
    • chrome/test/data/autofill/captured_sites/ebay.test
    • chrome/test/data/autofill/captured_sites/walmart.test
    • chrome/test/data/autofill/captured_sites/zappos.test
  9. ScopedMockClockOverride: Include <memory>

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Friday, 10-Aug-18 22:35:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51d6da99705952697ed233f6cf9e63e06438ca5d

    Comments

    ScopedMockClockOverride: Include <memory>
    
    IWYU: std::unique_ptr needs <memory>. This fixes the libstdc++ build:
    
        In file included from ../../base/test/scoped_mock_clock_override.cc:5:0:
        ../../base/test/scoped_mock_clock_override.h:39:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
           std::unique_ptr<base::subtle::ScopedTimeClockOverrides> time_clock_overrides_;
                ^~~~~~~~~~
    
    Bug: 818294
    Change-Id: I3b92e51f2565b42869cf2400dd4d3654e112f0fb
    Reviewed-on: https://chromium-review.googlesource.com/1170837
    Reviewed-by: Charlie Andrews <charliea@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#582361}

    Changed files

    • base/test/scoped_mock_clock_override.h
  10. Fix suggestion chip too long issue

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:41:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e448af80c5ba070e15aa387564fc8708fab6edf8

    Comments

    Fix suggestion chip too long issue
    
    Changes:
    Make the suggestion chip text length no longer than 192dip.
    
    Bug: 872948
    Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9
    Reviewed-on: https://chromium-review.googlesource.com/1171676
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582362}

    Changed files

    • ash/app_list/views/suggestion_chip_view.cc
  11. [CRD iOS] Using the new audio playback logic

    Changed by yuweihohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e640c47e6cb75a8385ebba2e2aa31aeba732bf

    Comments

    [CRD iOS] Using the new audio playback logic
    
    This CL finishes up the rest of the work of refactoring the audio
    playback logic on iOS.
    
    Bug: 868088
    Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d
    Reviewed-on: https://chromium-review.googlesource.com/1166339
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582365}

    Changed files

    • remoting/client/audio/BUILD.gn
    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/ios/session/remoting_client.mm
  12. Diable a flaky test on CrOS for the same reason as others on this bug.

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8ac232aec054638f6bfd13c783ef7d7d32e48d6

    Comments

    Diable a flaky test on CrOS for the same reason as others on this bug.
    
    Bug: 870732
    Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171738
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582364}

    Changed files

    • chrome/browser/password_manager/password_manager_browsertest.cc
  13. Never show shortcuts in contextual menus on the Mac.

    Changed by aviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c50480db92fe1220814910400ace4683a4d438a

    Comments

    Never show shortcuts in contextual menus on the Mac.
    
    This is platform convention.
    
    BUG=869564
    TEST=as in bug
    
    Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe
    Reviewed-on: https://chromium-review.googlesource.com/1164307
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582363}

    Changed files

    • ui/base/cocoa/menu_controller.mm
  14. cc: Increase layer tree test timeout for CFI

    Changed by enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:44:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3df98f1195e5772ddbb2e369527e7fa3a920ce9

    Comments

    cc: Increase layer tree test timeout for CFI
    
    Also, generally increase the timeout for layer tree tests.  Most things
    don't need this, however the GL versions of pixel tests end up spending
    quite a bit of time to compile shaders.  When run in parallel, this
    only exacerbates the problem and tests can time out.  Be more generous
    so that folks stop turning off these tests.
    
    Bug: 872733
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88
    Reviewed-on: https://chromium-review.googlesource.com/1171377
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: enne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582367}

    Changed files

    • cc/test/layer_tree_test.cc
  15. Disable failing test (FLAKY_ has no meaning)

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b6a32c22de15bea00ed58fa55fdeafdb91767f6

    Comments

    Disable failing test (FLAKY_ has no meaning)
    
    Bug: 871812
    Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171681
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582366}

    Changed files

    • third_party/blink/renderer/core/css/font_face_cache_test.cc
  16. Android: Update Android Studio canary version

    Changed by wnwenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:45:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31634c4f1eae7d2fbac13a7542a0c939417d62f4

    Comments

    Android: Update Android Studio canary version
    
    Bug: 620034
    Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b
    Reviewed-on: https://chromium-review.googlesource.com/1169425
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582368}

    Changed files

    • build/android/gradle/root.jinja
  17. fido/mac: look up credential IDs before proceeding with GetAssertion requests

    Changed by martinkrohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4ac527a4777da75ba6c44ed4a7e1837ed92693d

    Comments

    fido/mac: look up credential IDs before proceeding with GetAssertion requests
    
    This changes the GetAssertion operation for the Touch ID authenticator
    to locate credential IDs in the keychain at the beginning of the
    request. If no matching credential exists, the user is not prompted for
    a fingerprint. A method to locate a credential by ID is extracted from
    the existing code and moved into the Keychain class.
    
    This is done in anticipation of adding the WebAuthn UI. With the new UI,
    GetAssertion requests will only be sent to the Touch ID authenticator,
    if we know a matching credential ID to exist in the keychain.
    
    Bug: 871370
    
    Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b
    Reviewed-on: https://chromium-review.googlesource.com/1163927
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582369}

    Changed files

    • device/fido/mac/get_assertion_operation.h
    • device/fido/mac/get_assertion_operation.mm
    • device/fido/mac/keychain.h
    • device/fido/mac/keychain.mm
    • device/fido/mac/operation_base.h
  18. [Cast discovery] Reset device lister on ForceDiscovery / user gesture.

    Changed by imchengohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:47:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 485629bea392f67ff70fcbed5007f2f91b171737

    Comments

    [Cast discovery] Reset device lister on ForceDiscovery / user gesture.
    
    We've seen cases where Cast discovery code fails to pick up services
    from the ServiceDiscoveryDeviceLister, whereas chrome://inspect
    (CastDeviceProvider) is able to do so. Since Cast discovery's
    ServiceDiscoveryDeviceLister is only created once and is long-lived,
    this suggests it has gone into a bad state after a prolonged period.
    Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister,
    which gets created/destroyed when 
    ...skip...
    iceLister
    and kick off the discovery using the new object, and to clear the set
    of services in the cache. This puts DnsSdDeviceLister in a clean state
    which will the current set of services to get through to the Cast
    discovery code.
    
    Bug: 850770
    Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463
    Reviewed-on: https://chromium-review.googlesource.com/1166022
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582371}

    Changed files

    • chrome/browser/extensions/api/mdns/mdns_api.cc
    • chrome/browser/extensions/api/mdns/mdns_apitest.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc
    • chrome/browser/media/router/test/mock_dns_sd_registry.h
  19. assistant: fix unitialized read

    Changed by skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 492cb6c0acd8a7714cd8d298d8d8bd83e65edc5d

    Comments

    assistant: fix unitialized read
    
    VisibilityChanged() tests the is_visible_ member before it's been set to any
    value.
    
    BUG=none
    TEST=none
    TBR=xiaohuic@chromium.org
    
    Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2
    Reviewed-on: https://chromium-review.googlesource.com/1171553
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582370}

    Changed files

    • ash/assistant/ui/main_stage/assistant_progress_indicator.h
  20. [omnibox/drive] Updates for /v1beta -> /v1 api migration.

    Changed by skareohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cf7e0b53900f489bcfb7bd7db7b356cfb31d2e5

    Comments

    [omnibox/drive] Updates for /v1beta -> /v1 api migration.
    
    -Use originalURL if provided to dedupe against history.
    -Fix "typo" for corpus restrict request param (I missed it was renamed).
    -Sanitize title, provide default match data.
    
    Bug: 873290
    Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3
    Reviewed-on: https://chromium-review.googlesource.com/1171550
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Travis Skare <skare@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582372}

    Changed files

    • components/omnibox/browser/document_provider.cc
    • components/omnibox/browser/document_suggestions_service.cc
  21. cros: Add common fingerprint images in ui/chromeos/resources.

    Changed by xiaoyinhohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ccd841a0bbf56f3ddc4ebfbf2430404da75a86f

    Comments

    cros: Add common fingerprint images in ui/chromeos/resources.
    
    This will be used by both oobe and settings.
    
    Bug: 873229
    Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5
    Reviewed-on: https://chromium-review.googlesource.com/1171243
    Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582374}

    Changed files

    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_100_percent/fingerprint/tick.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_200_percent/fingerprint/tick.png
    • ui/chromeos/resources/ui_chromeos_resources.grd
  22. [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz

    Changed by gabohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bf388aef924443453385373971d022f03652981

    Comments

    [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz
    
    https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs
    will be empty after this CL
    
    TBR=fdoray@chromium.org
    
    Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49
    Reviewed-on: https://chromium-review.googlesource.com/1171108
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582373}

    Changed files

    • WATCHLISTS
    • base/task/task_scheduler/task_scheduler.h
  23. Increase DevTools SystemInfoGPU timeout for Windows.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c9cf51bc70b424ce8d9849d24c115a7f6930772

    Comments

    Increase DevTools SystemInfoGPU timeout for Windows.
    
    Before this CL, DevTools would crash the browser if it did not get a response in
    5 seconds. This timeout is too low for Windows. On Catapult perf tests on
    Windows, it takes ~3 seconds for the GPU process to respond on average, and
    sometimes it takes more than 5 seconds.
    
    Bug: 873112
    Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213
    Reviewed-on: https://chromium-review.googlesource.com/1170584
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582375}

    Changed files

    • content/browser/devtools/protocol/system_info_handler.cc
  24. Fix a typo in documentation.

    Changed by eromanohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3c53b6d5652202ab79edad721a4a04fb0ccb79

    Comments

    Fix a typo in documentation.
    
    Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6
    Reviewed-on: https://chromium-review.googlesource.com/1169693
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582376}

    Changed files

    • mojo/public/cpp/bindings/callback_helpers.h
  25. [TTS] Remove unused DEPS file.

    Changed by donndohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:57:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54b3b3f4c92fac9a597039d7026120e4769a5d4

    Comments

    [TTS] Remove unused DEPS file.
    
    Change-Id: I100542f77eb1ebebf28db6c716733467be61c209
    Reviewed-on: https://chromium-review.googlesource.com/1168503
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582377}

    Changed files

    • components/contextual_search/browser/DEPS
  26. CATransactionGPUCoordinator: Re-enable and make lifetime explicit

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:10:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62892558b716d1560264e42929e2be01ead07e71

    Comments

    CATransactionGPUCoordinator: Re-enable and make lifetime explicit
    
    Disalbing the CATransactionGPUCoordinator caused memory corruption bugs
    to go away.
    
    Fix two potential bugs:
    
    1.  Don't post tasks (and potentially change the reference count) inside
        CATransactionGPUCoordinator's constructor. Do this in a separate
        explicit Init function.
    
    1a. Move this initialization to the end of GpuProcessHost:Init (instead
        of being at the beginning of the constructor).
    
    2.  Make CATransactionCoordinator 
    ...skip...
    actionGPUCoordinator). This fixes a bug
        whereby at shutdown, destroying not-yet-executed posted tasks caused
        the CATransactionGPUCoordinator to be destroyed while the
        CATransactionCoordinator still had a raw pointer to it.
    
    Bug: 871430
    Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75
    Reviewed-on: https://chromium-review.googlesource.com/1171657
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582378}

    Changed files

    • content/browser/gpu/ca_transaction_gpu_coordinator.cc
    • content/browser/gpu/ca_transaction_gpu_coordinator.h
    • content/browser/gpu/gpu_process_host.cc
    • ui/accelerated_widget_mac/ca_transaction_observer.h
    • ui/accelerated_widget_mac/ca_transaction_observer.mm