Home | Search
Login

Builder mac-10_13_laptop_high_end-perf Build #773 Apple OSX

Results:

failed performance_test_suite on ATI GPU on Mac

Trigger Info:

Got Revision4c172804c44cf480776c1acfb741e756bbf7cb1e

Execution:

Steps and Logfiles:

Show:
  1. ( 2 hrs 18 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 mins 33 secs ) bot_update
    bot_update
    [119GB/232GB used (51%)]
  8. ( 1 ms ) ensure_goma
    ensure_goma
  9. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  10. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  11. ( 1 ms ) ensure_installed
    ensure_installed
  12. ( 22 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/mac_10_13_laptop_high_end_perf/src/testing/buildbot/chromium.perf.json
  15. ( 1 ms ) build directory
    build directory
  16. ( 1 mins 6 secs ) extract build
    extract build
  17. ( 1 ms ) find isolated tests
    find isolated tests
  18. ( 1 ms ) test_pre_run
    test_pre_run
  19. ( 1 ms ) test_pre_run.[trigger] media_perftests on ATI GPU on Mac
    test_pre_run.[trigger] media_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
  20. ( 5 secs ) test_pre_run.[trigger] net_perftests on ATI GPU on Mac
    test_pre_run.[trigger] net_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
  21. ( 1 ms ) test_pre_run.[trigger] views_perftests on ATI GPU on Mac
    test_pre_run.[trigger] views_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
  22. ( 45 secs ) test_pre_run.[trigger] performance_test_suite on ATI GPU on Mac
    test_pre_run.[trigger] performance_test_suite on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
  23. ( 3 ms ) media_perftests on ATI GPU on Mac
    media_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
    Pending time: 13s
    Shard duration: 17s
    Total tests: n/a
     
  24. ( 5 secs ) net_perftests on ATI GPU on Mac
    net_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
    Shard duration: 0:02:01.754430
    Total tests: n/a
     
  25. ( 3 ms ) views_perftests on ATI GPU on Mac
    views_perftests on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
    Pending time: 27s
    Shard duration: 7s
    Total tests: n/a
     
  26. ( 2 hrs 13 mins ) performance_test_suite on ATI GPU on Mac
    performance_test_suite on ATI GPU on Mac
    Run on OS: 'Mac-10.13'
    Max pending time: 0:01:00.354940 (shard #6)
    Max shard duration: 0:29:25.180660 (shard #17)
    Min shard duration: 0:16:26.901910 (shard #1)
    Total tests: 695
    * Passed: 673 (673 expected, 0 unexpected)
    * Skipped: 20 (20 expected, 0 unexpected)
    * Failed: 1 (0 expected, >>>1 unexpected<<<)
    * Flaky: 1 (0 expected, >>>1 unexpected<<<)
     
    Unexpected Failures:
    * rendering.desktop/youtube_pinch_2018
     
    Unexpected Flakes:
    * loading.desktop/Vietnamnet_warm
     
  27. ( 1 ms ) Upload to test-results [performance_test_suite on ATI GPU on Mac]
    Upload to test-results [performance_test_suite on ATI GPU on Mac]
  28. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 19
    Total runtime: 6:03:34.367306
     
  29. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/mac-10_13_laptop_high_end-perf/773/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/mac-10_13_laptop_high_end-perf/773" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" Annotation(bot_update)
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" Annotation(bot_update)
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" Annotation(bot_update)
got_revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#582425}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.0.193@{#2}" Annotation(bot_update)
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24263}" Annotation(bot_update)
swarm_hashes {"load_library_perf_tests":"7831e6e69ec17fb6a35f56197c9f9a6a3d4f6aed","media_perftests":"a7230c8390f07f760f4f2552068abe8e315df804","net_perftests":"08159c39d517f83c9dc6348e072d0fbe566bc8d8","performance_browser_tests":"89e0f9f69ca5d93264cb4b7134afbf36a423e0b0","performance_test_suite":"67086bb8fda3a60005702e13c9e8acdfa6819b5e","views_perftests":"af83423bff8b37423ed3f6fd8457ced922d5c2f9"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpPHdXaM" Annotation(steps)
build_id "buildbot/chromium.perf/mac-10_13_laptop_high_end-perf/773" Annotation(steps)
builder_id "master.chromium.perf:mac-10_13_laptop_high_end-perf" Annotation(steps)
blamelist ["chrome-release-bot@chromium.org","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","joenotcharles@chromium.org","kainino@chromium.org","martiniss@chromium.org","mattcary@chromium.org","mukai@chromium.org","nednguyen@google.com","palmer@chromium.org","piman@chromium.org","pkasting@chromium.org","romax@chromium.org","siyua@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","sky@chromium.org","wez@chromium.org"] Build
branch "master" Build
buildnumber 773 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1533951499 Build
revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" Build
slavename "vm313-m1" BuildSlave
buildername "mac-10_13_laptop_high_end-perf" Builder
git_revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" Change
parent_buildername "Mac Builder Perf" ParentBuild
parent_buildnumber 34757 ParentBuild
parent_got_angle_revision "ea926a362b7748679d72bd56780d29c2ff20fd27" ParentBuild
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" ParentBuild
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" ParentBuild
parent_got_revision "4c172804c44cf480776c1acfb741e756bbf7cb1e" ParentBuild
parent_got_revision_cp "refs/heads/master@{#582425}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" ParentBuild
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/mac-10_13_laptop_high_end-perf" slave

Blamelist:

  1. (mukaiohnoyoudont@chromium.org)
  2. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. (mattcaryohnoyoudont@chromium.org)
  4. (skyohnoyoudont@chromium.org)
  5. (pimanohnoyoudont@chromium.org)
  6. (siyuaohnoyoudont@chromium.org)
  7. (kaininoohnoyoudont@chromium.org)
  8. (palmerohnoyoudont@chromium.org)
  9. (joenotcharlesohnoyoudont@chromium.org)
  10. (martinissohnoyoudont@chromium.org)
  11. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  12. (pkastingohnoyoudont@chromium.org)
  13. (wezohnoyoudont@chromium.org)
  14. (nednguyenohnoyoudont@google.com)
  15. (pkastingohnoyoudont@chromium.org)
  16. (romaxohnoyoudont@chromium.org)
  17. (pkastingohnoyoudont@chromium.org)
  18. (chrome-release-botohnoyoudont@chromium.org)

Timing:

Create N/A
Start Saturday, 11-Aug-18 03:54:06 UTC
End Saturday, 11-Aug-18 06:12:39 UTC
Pending N/A
Execution 2 hrs 18 mins

All Changes:

  1. refine window finder for mash

    Changed by mukaiohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c0f9aa861fdb9bc534829d3f764e2100cfff71c

    Comments

    refine window finder for mash
    
    Previously window_finder_chromeos (for mash) looks through the
    list of the toplevel browser windows, but it is too simple and
    doesn't work well on several cases.
    
    This CL moves the window finding code to ash, and let WindowTree
    notify the list of windows at the cursor to the client upon
    window moving.
    
    BUG=867074
    TEST=ash_unittests
    
    Change-Id: Ib44ad1a927a31c50cc108eee92ddba4d9bd918ee
    Reviewed-on: https://chromium-review.googlesource.com/1159346
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582410}

    Changed files

    • ash/BUILD.gn
    • ash/wm/window_finder.cc
    • ash/wm/window_finder.h
    • ash/wm/window_finder_unittest.cc
    • ash/ws/window_service_delegate_impl.cc
    • ash/ws/window_service_delegate_impl.h
    • ash/ws/window_service_delegate_impl_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/tabs/DEPS
    • chrome/browser/ui/views/tabs/tab_drag_controller.cc
    • chrome/browser/ui/views/tabs/window_finder.cc
    • chrome/browser/ui/views/tabs/window_finder.h
    • chrome/browser/ui/views/tabs/window_finder_chromeos.cc
    • content/renderer/mus/renderer_window_tree_client.cc
    • content/renderer/mus/renderer_window_tree_client.h
    • services/ui/public/interfaces/window_tree.mojom
    • services/ui/ws2/BUILD.gn
    • services/ui/ws2/test_change_tracker.cc
    • services/ui/ws2/test_change_tracker.h
    • services/ui/ws2/test_window_tree_client.cc
    • services/ui/ws2/test_window_tree_client.h
    • services/ui/ws2/topmost_window_observer.cc
    • services/ui/ws2/topmost_window_observer.h
    • services/ui/ws2/window_service_delegate.cc
    • services/ui/ws2/window_service_delegate.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • ui/aura/BUILD.gn
    • ui/aura/mus/topmost_window_tracker.cc
    • ui/aura/mus/topmost_window_tracker.h
    • ui/aura/mus/window_tree_client.cc
    • ui/aura/mus/window_tree_client.h
    • ui/aura/test/mus/test_window_tree.cc
    • ui/aura/test/mus/test_window_tree.h
  2. Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)

    Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:08:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bb07ab082388ed8e0590614162bc1cc9f756bdb

    Comments

    Roll src/third_party/depot_tools 284b5e0c60ac..6a4e31b4882f (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/284b5e0c60ac..6a4e31b4882f
    
    
    git log 284b5e0c60ac..6a4e31b4882f --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 ehmaldonado@chromium.org gclient_scm: Add option to specify the branch the patch is based on.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@6a4e31b4882f
    
    The AutoRoll server is located here: https://depot-tools-chromium-rol
    ...skip...
     the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:870279
    TBR=agable@chromium.org
    
    Change-Id: I4563fb1540b017267659c6d67ca8dcbf6f3feb8f
    Reviewed-on: https://chromium-review.googlesource.com/1171443
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582408}

    Changed files

    • DEPS
  3. Orderfile: renable misordered symbol threshold in check_orderfile.py.

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:09:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdba7075443440ec9b67631bc351866397558f0e

    Comments

    Orderfile: renable misordered symbol threshold in check_orderfile.py.
    
    Bug: 873380
    Change-Id: Iaa194b57f57985a6bc851a2b826555a6d087a57c
    Reviewed-on: https://chromium-review.googlesource.com/1171234
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582409}

    Changed files

    • tools/cygprofile/check_orderfile.py
    • tools/cygprofile/check_orderfile_unittest.py
  4. chromeos: add SingleProcessMash mode

    Changed by skyohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b092ae622b9ab3856d64d3eca543e4ecb243be77

    Comments

    chromeos: add SingleProcessMash mode
    
    This makes Ash create an Env if passed SingleProcessMash. In addition this
    makes all window creation go through a factory that ensures the right env is
    supplied.
    
    See https://docs.google.com/document/d/11ha_KioDdXe4iZS2AML1foKnCJlNKm7Q1hFr6VW8dV4/edit
    for more details.
    
    This also adds the feature to ui/base.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: Ica3c433627222f0e076dddaf19b1ab09168cebeb
    Reviewed-on: https://chromium-review.googlesource.com/1168282
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582411}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/app_launch_unittest.cc
    • ash/ash_service_unittest.cc
    • ash/components/fast_ink/fast_ink_view.cc
    • ash/display/cursor_window_controller.cc
    • ash/display/display_manager_unittest.cc
    • ash/display/display_util.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/mouse_cursor_event_filter_unittest.cc
    • ash/display/root_window_transformers_unittest.cc
    • ash/display/screen_ash.cc
    • ash/display/screen_position_controller_unittest.cc
    • ash/display/unified_mouse_warp_controller_unittest.cc
    • ash/display/window_tree_host_manager_unittest.cc
    • ash/drag_drop/drag_drop_tracker.cc
    • ash/events/event_rewriter_controller.cc
    • ash/extended_desktop_unittest.cc
    • ash/frame/detached_title_area_renderer.cc
    • ash/frame/header_view.cc
    • ash/host/DEPS
    • ash/host/ash_window_tree_host.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/keyboard/test_keyboard_ui.cc
    • ash/magnifier/docked_magnifier_controller.cc
    • ash/magnifier/magnification_controller_unittest.cc
    • ash/metrics/desktop_task_switch_metric_recorder_unittest.cc
    • ash/public/cpp/frame_border_hit_test.cc
    • ash/root_window_controller.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell.h
    • ash/shell_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/system/message_center/arc/arc_notification_view_unittest.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.cc
    • ash/system/message_center/arc/mock_arc_notification_surface.h
    • ash/system/night_light/night_light_controller.cc
    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/system/tray/tray_background_view.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/test/ui_controls_factory_ash.cc
    • ash/utility/screenshot_controller_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • ash/wayland/wayland_server_controller.h
    • ash/window_factory.cc
    • ash/window_factory.h
    • ash/window_user_data_unittest.cc
    • ash/wm/ash_focus_rules_unittest.cc
    • ash/wm/cursor_manager_chromeos.cc
    • ash/wm/drag_window_controller.cc
    • ash/wm/drag_window_resizer_unittest.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/native_cursor_manager_ash_classic.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/stacking_controller_unittest.cc
    • ash/wm/system_gesture_event_filter_unittest.cc
    • ash/wm/system_modal_container_layout_manager_unittest.cc
    • ash/wm/top_level_window_factory.cc
    • ash/wm/toplevel_window_event_handler.cc
    • ash/wm/toplevel_window_event_handler_unittest.cc
    • ash/wm/video_detector.cc
    • ash/wm/window_dimmer.cc
    • ash/wm/window_dimmer_unittest.cc
    • ash/wm/workspace/workspace_event_handler_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • ash/wm/workspace/workspace_window_resizer_unittest.cc
    • ash/wm/workspace_controller_unittest.cc
    • ash/ws/window_service_owner.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • ui/aura/env.cc
    • ui/aura/env.h
    • ui/aura/test/test_windows.cc
    • ui/aura/test/test_windows.h
    • ui/aura/window.cc
    • ui/aura/window.h
    • ui/aura/window_tree_host_platform.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
  5. Send SharedImage IPC with multi-flush

    Changed by pimanohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:14:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14ff32c26823fa7aff03d2d74790d04acdfb59ab

    Comments

    Send SharedImage IPC with multi-flush
    
    This generalizes the FlushParams to contain sync tokens + IPC::Message instead
    of ad-hoc fields transformed into Messages on the receiving side. This allows
    any Message (that doesn't have handles) to be included into the list, and
    simplifies the service-side handling.
    Existing AsyncFlush and DestroyTransferBuffer messages are now serialized
    client-side, and CreateSharedImage/DestroySharedImage are converted to this
    mechanism, to avoid extra IPCs per tile.
    
    Bug: 8
    ...skip...
    ots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib11298c03e249f49aec8e710a3db4195aea33e81
    Reviewed-on: https://chromium-review.googlesource.com/1168731
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582412}

    Changed files

    • gpu/command_buffer/common/command_buffer.h
    • gpu/ipc/client/command_buffer_proxy_impl.cc
    • gpu/ipc/client/command_buffer_proxy_impl_unittest.cc
    • gpu/ipc/client/gpu_channel_host.cc
    • gpu/ipc/client/gpu_channel_host.h
    • gpu/ipc/client/shared_image_interface_proxy.cc
    • gpu/ipc/common/BUILD.gn
    • gpu/ipc/common/flush_params.cc
    • gpu/ipc/common/flush_params.h
    • gpu/ipc/common/gpu_messages.h
    • gpu/ipc/common/gpu_param_traits_macros.h
    • gpu/ipc/service/gpu_channel.cc
    • gpu/ipc/service/shared_image_stub.cc
    • gpu/ipc/service/shared_image_stub.h
  6. Add Main Prompts for Card Migration Flow

    Changed by siyuaohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:24:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fec3aebc5358345210d473c0ec36fef86ba5937

    Comments

    Add Main Prompts for Card Migration Flow
    
    This is the 1st CL adding view skeleton.
    
    For project details please refer to go/ib-paradise.
    
    Bug: 852904
    Change-Id: Icc10a2598bb15659a6478fc2dbf2734094111494
    Reviewed-on: https://chromium-review.googlesource.com/1149514
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#582413}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_dialog.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_dialog_controller_impl.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_factory.h
    • chrome/browser/ui/autofill/local_card_migration_dialog_state.h
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_dialog_view.h
    • chrome/browser/ui/views/harmony/chrome_layout_provider.cc
    • chrome/browser/ui/views/harmony/chrome_layout_provider.h
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/ui/local_card_migration_dialog_controller.h
    • components/autofill_strings.grdp
    • components/resources/autofill_scaled_resources.grdp
    • components/resources/default_100_percent/autofill/migration_header.png
    • components/resources/default_200_percent/autofill/migration_header.png
    • components/resources/default_300_percent/autofill/migration_header.png
  7. Normalize rendering_desktop.json, rendering_mobile.json

    Changed by kaininoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 074cecb79d9d30ec9f2bf6b5b10edb6cd77a8b4f

    Comments

    Normalize rendering_desktop.json, rendering_mobile.json
    
    This is needed because re-recording archives (using record_wpr)
    causes these files to get re-alphabetized automatically.
    This commit lets us re-record an archive without producing an
    unreadable diff.
    
    Doing this also removes the duplicate key
    "androidpolice_mobile_sync_scroll_2018" from rendering_mobile.json.
    
    Tangentially, also delete the unused archive
    rendering_mobile_007.wprgo.sha1.
    
    Bug: 872551, 867368
    Change-Id: Ib15c9c0a8600e7fa510a146ad896aa92e4f9de45
    Reviewed-on: https://chromium-review.googlesource.com/1171677
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582414}

    Changed files

    • tools/perf/page_sets/data/rendering_desktop.json
    • tools/perf/page_sets/data/rendering_mobile.json
    • tools/perf/page_sets/data/rendering_mobile_007.wprgo.sha1
  8. Change the history state throttle interval from 60 to 120 Hz.

    Changed by palmerohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:26:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e4127dd506c501cd3f51d91dc22a3dfa8f5f1ca

    Comments

    Change the history state throttle interval from 60 to 120 Hz.
    
    This is a bit more lenient and may enable some callers, including a flaky test,
    to get (more of) what they need. The test's root problem seems to be data races
    (see issue 847326), however.
    
    Bug: 870861
    Change-Id: I249e9f06fa9a9a9f3b74e53cf2ef3f34b0c2371c
    Reviewed-on: https://chromium-review.googlesource.com/1171825
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582415}

    Changed files

    • third_party/blink/renderer/core/frame/history.cc
  9. Mojo: Add ArrayTraits for std::unordered_set

    Changed by joenotcharlesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:31:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 576c7e134e5ce40b4ef09482600d9bd51f52d152

    Comments

    Mojo: Add ArrayTraits for std::unordered_set
    
    This is required to typemap chrome_cleaner::PUPData.
    
    R=rockot
    
    Bug: 830892
    Change-Id: I42e29dbd928c1bd9064ba9a75a37493461209b7e
    Reviewed-on: https://chromium-review.googlesource.com/1171736
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582416}

    Changed files

    • mojo/public/cpp/bindings/array_traits_stl.h
  10. Bump tablet tester execution timeout

    Changed by martinissohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:49:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 711748ea30b592183f2d37f54091dda9f4fee9c2

    Comments

    Bump tablet tester execution timeout
    
    They seem to need longer timeout for now. Hopefully will be temporary.
    
    TBR=bpastene
    
    Bug: 853248
    Change-Id: I6665013085631c69e6d78fe1f43f195e12d3295c
    Reviewed-on: https://chromium-review.googlesource.com/1171909
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582420}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  11. Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 01:40:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51acd92215e6b735f2c0f80119f7ca51c031f797

    Comments

    Roll src/third_party/skia 4eac21fee047..f3ca1c6abb07 (18 commits)
    
    https://skia.googlesource.com/skia.git/+log/4eac21fee047..f3ca1c6abb07
    
    
    git log 4eac21fee047..f3ca1c6abb07 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 brucewang@google.com Implement FreeType COLR/CPAL support.
    2018-08-10 timliang@google.com fixed the size in bytes of vec3s to match Metal standard in Metal gpu backend
    2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-08-10 timliang@google.com 
    ...skip...
    rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=djsollen@chromium.org
    
    Change-Id: I5274deea227ad59efbb4157cf2401fcc016ae264
    Reviewed-on: https://chromium-review.googlesource.com/1171445
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582417}

    Changed files

    • DEPS
  12. Disable flaky tests.

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e064bc93ae45308ecc1b6fa886808ad20bd2225f

    Comments

    Disable flaky tests.
    
    Bug: 622387, 871692
    Change-Id: Ie03b640422b120d903ca56bf9f0650a1ffc23065
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171852
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582419}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
    • chrome/test/data/webui/extensions/cr_extensions_browsertest.js
    • chrome/test/data/webui/settings/cr_settings_browsertest.js
  13. Clean up some Ozone build files not to assume use of evdev.

    Changed by wezohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:51:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d6032964619538763f8ce4a782093f74b86ed49

    Comments

    Clean up some Ozone build files not to assume use of evdev.
    
    Bug: 808287
    Change-Id: Ic699462759818049666babb0587939e4ca687643
    Reviewed-on: https://chromium-review.googlesource.com/1167555
    Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    Reviewed-by: Michael Spang <spang@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582421}

    Changed files

    • ui/events/BUILD.gn
    • ui/events/ozone/BUILD.gn
    • ui/events/ozone/keyboard/event_auto_repeat_handler.cc
    • ui/events/ozone/keyboard/event_auto_repeat_handler.h
    • ui/ozone/platform/wayland/wayland_window_unittest.cc
  14. Always put Telemetry tests at the end to avoid starving fast tests

    Changed by nednguyenohnoyoudont@google.com
    Changed at Saturday, 11-Aug-18 02:02:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c2eb4f79024d096aa0363c946b1eb9a733283ed

    Comments

    Always put Telemetry tests at the end to avoid starving fast tests
    
    This also add this check to PRESUBMIT perf_json_config_validator script
    
    Bug: 873389
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I16fd762e567d5a41d75a221456e12e14a03f0b85
    Reviewed-on: https://chromium-review.googlesource.com/1171578
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#582422}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_json_config_validator.py
  15. Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 02:05:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0a0f0be53c7c705076cac5dfc933dc85650e435

    Comments

    Revert "[Mac] Add Offset to TextSuggestionsTouchBarController Text Selection"
    
    This reverts commit 1e3c17435eea13b5ba5d2794985655aa221091d1.
    
    Reason for revert: Breaks Mac tests, see e.g. https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477492727648/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.11/0/logs/TextSuggestionsTouchBarControllerTest.Offset/0
    
    Original change's description:
    > [Mac] Add Offset to TextSuggestionsTouchBarController Text Selection
    > 
    > W
    ...skip...
    hromium.org>
    > Reviewed-by: Sarah Chan <spqchan@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582205}
    
    TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com
    
    Change-Id: If0acdd0494b5270c4b4e221e16b8e901ce2cacc3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 717553
    Reviewed-on: https://chromium-review.googlesource.com/1171704
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582423}

    Changed files

    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.h
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller.mm
    • chrome/browser/ui/cocoa/touchbar/text_suggestions_touch_bar_controller_browsertest.mm
    • content/browser/frame_host/render_widget_host_view_guest.cc
    • content/browser/frame_host/render_widget_host_view_guest.h
    • content/browser/renderer_host/render_widget_host_delegate.h
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/public/browser/render_widget_host_view.h
    • content/public/browser/web_contents_observer.h
  16. [Offline Pages] Implement live page sharing.

    Changed by romaxohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 01:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 514ffca0bacb2fce140defae3a4ae3dcab37bfa0

    Comments

    [Offline Pages] Implement live page sharing.
    
    Implement live page sharing:
    - Adding a new temporary client namespace for the usage of live page
      sharing, which has a limit of one page per url and expiration period
      as one hour.
    - Adding saveAndSharePage in OfflinePageUtils, implementing the workflow
      of save page, get page and share page.
    
    Bug: 870895
    Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246
    Reviewed-on: https://chromium-review.googlesource.com/1162827
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Yafei Duan <romax@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582418}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/GetPagesByNamespaceForLivePageSharingCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/SavePageAndShareCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
    • chrome/android/java_sources.gni
    • components/offline_pages/core/client_namespace_constants.cc
    • components/offline_pages/core/client_namespace_constants.h
    • components/offline_pages/core/client_policy_controller.cc
    • components/offline_pages/core/client_policy_controller_unittest.cc
    • components/offline_pages/core/model/offline_page_model_utils.cc
    • tools/metrics/histograms/enums.xml
  17. Revert "Make //content layer default to --site-per-process mode on desktop."

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 02:23:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2595d82ddfcf666d41d33e1ce881e52401d31454

    Comments

    Revert "Make //content layer default to --site-per-process mode on desktop."
    
    This reverts commit 3b8db25cc597a642ee4b7cbaf2655c631353a799.
    
    Reason for revert: Checking to see whether this caused https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8938549477343009904/+/steps/content_browsertests_on_Intel_GPU_on_Mac_on_Mac-10.12.6/0/logs/WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings/0 and similar.
    
    Original change's description:
    > Make //content layer def
    ...skip...
     Cr-Commit-Position: refs/heads/master@{#582223}
    
    TBR=thakis@chromium.org,boliu@chromium.org,skyostil@chromium.org,alexmos@chromium.org,slan@chromium.org,lukasza@chromium.org
    
    Change-Id: Ieca3a36422b0f90dccc0040eeece799523c954e0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 856734
    Reviewed-on: https://chromium-review.googlesource.com/1171705
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582424}

    Changed files

    • android_webview/browser/aw_content_browser_client.cc
    • android_webview/browser/aw_content_browser_client.h
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/browser/cast_content_browser_client.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/isolated_origin_browsertest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • content/shell/browser/layout_test/layout_test_content_browser_client.cc
    • content/shell/browser/layout_test/layout_test_content_browser_client.h
    • headless/lib/browser/headless_content_browser_client.cc
    • headless/lib/browser/headless_content_browser_client.h
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/client.v8.chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
  18. Updating trunk VERSION from 3519.0 to 3520.0

    Changed by chrome-release-botohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 03:08:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c172804c44cf480776c1acfb741e756bbf7cb1e

    Comments

    Updating trunk VERSION from 3519.0 to 3520.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I4cabb60493cd431bb673a5459e1283c615c6c0ec
    Reviewed-on: https://chromium-review.googlesource.com/1171982
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582425}

    Changed files

    • chrome/VERSION