Home | Search
Login

Builder linux-perf Build #480

Results:

build successful

Trigger Info:

Got Revision49040ae795592d3b0c6a5b03533565caeb9ae266

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 43 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 1 ms ) remove .cipd
    remove .cipd
  9. ( 2 mins 1 secs ) bot_update
    bot_update
    [125GB/492GB used (25%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 2 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 26 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/linux_perf/src/testing/buildbot/chromium.perf.json
  16. ( 1 ms ) build directory
    build directory
  17. ( 4 mins 13 secs ) extract build
    extract build
  18. ( 1 ms ) find isolated tests
    find isolated tests
  19. ( 1 ms ) test_pre_run
    test_pre_run
  20. ( 1 ms ) test_pre_run.[trigger] load_library_perf_tests on NVIDIA GPU on Linux
    test_pre_run.[trigger] load_library_perf_tests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
  21. ( 5 secs ) test_pre_run.[trigger] media_perftests on NVIDIA GPU on Linux
    test_pre_run.[trigger] media_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
  22. ( 1 ms ) test_pre_run.[trigger] net_perftests on NVIDIA GPU on Linux
    test_pre_run.[trigger] net_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
  23. ( 41 secs ) test_pre_run.[trigger] performance_test_suite on NVIDIA GPU on Linux
    test_pre_run.[trigger] performance_test_suite on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
  24. ( 1 ms ) test_pre_run.[trigger] tracing_perftests on NVIDIA GPU on Linux
    test_pre_run.[trigger] tracing_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
  25. ( 2 ms ) load_library_perf_tests on NVIDIA GPU on Linux
    load_library_perf_tests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
    Pending time: 22s
    Shard duration: 6s
    Total tests: n/a
     
  26. ( 2 ms ) media_perftests on NVIDIA GPU on Linux
    media_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
    Pending time: 28s
    Shard duration: 14s
    Total tests: n/a
     
  27. ( 1 mins 30 secs ) net_perftests on NVIDIA GPU on Linux
    net_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
    Pending time: 41s
    Shard duration: 0:01:24.390830
    Total tests: n/a
     
  28. ( 1 hrs 33 mins ) performance_test_suite on NVIDIA GPU on Linux
    performance_test_suite on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
    Max pending time: 0:01:50.583160 (shard #0)
    Max shard duration: 1:01:48.673370 (shard #23)
    Min shard duration: 0:39:30.208880 (shard #10)
    Total tests: 1032
    * Passed: 988 (988 expected, 0 unexpected)
    * Skipped: 44 (44 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 ms ) Upload to test-results [performance_test_suite on NVIDIA GPU on Linux]
    Upload to test-results [performance_test_suite on NVIDIA GPU on Linux]
  30. ( 2 secs ) tracing_perftests on NVIDIA GPU on Linux
    tracing_perftests on NVIDIA GPU on Linux
    Run on OS: 'Ubuntu-14.04'
    Pending time: 0:50:19.921980
    Shard duration: 7s
    Total tests: n/a
     
  31. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 30
    Total runtime: 22:03:50.816976
     
  32. ( 1 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/linux-perf/480/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/linux-perf/480" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "49040ae795592d3b0c6a5b03533565caeb9ae266" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574621}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23952}" Annotation(bot_update)
swarm_hashes {"load_library_perf_tests":"9cf2a04657bbe0fc3ab8f013632cfd8f6856bbeb","media_perftests":"4389fd13bfa7f15c411ac88632f73dbc8830fb4a","net_perftests":"fcba648b3bf6d4ffb4c26fc594314a82feecd639","performance_test_suite":"6a56146022bbf5f1af33c17d91d5697c0f9ace94","tracing_perftests":"37b7477bdde129a625326347875db4a8eafd71b0"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmp4C_5y5" Annotation(steps)
build_id "buildbot/chromium.perf/linux-perf/480" Annotation(steps)
builder_id "master.chromium.perf:linux-perf" Annotation(steps)
blamelist ["alexilin@chromium.org","blundell@chromium.org","carlosil@chromium.org","dgrogan@chromium.org","digit@google.com","dmblack@google.com","etiennep@chromium.org","eugenebut@google.com","huayinz@chromium.org","iclelland@chromium.org","juncai@chromium.org","junov@chromium.org","kmilka@chromium.org","kpaulhamus@chromium.org","kvitekp@chromium.org","lazyboy@chromium.org","nburris@google.com","offenwanger@chromium.org","peconn@chromium.org","pkl@chromium.org","rayankans@chromium.org","reed@google.com","sergeyu@chromium.org","tangltom@chromium.org","tbansal@chromium.org","thakis@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","wnwen@chromium.org"] Build
branch "master" Build
buildnumber 480 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531417520 Build
revision "49040ae795592d3b0c6a5b03533565caeb9ae266" Build
slavename "slave69-c1" BuildSlave
buildername "linux-perf" Builder
git_revision "49040ae795592d3b0c6a5b03533565caeb9ae266" Change
parent_buildername "Linux Builder Perf" ParentBuild
parent_buildnumber 26889 ParentBuild
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "49040ae795592d3b0c6a5b03533565caeb9ae266" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574621}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" ParentBuild
parent_got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23952}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/linux-perf" slave

Blamelist:

  1. (peconnohnoyoudont@chromium.org)
  2. (reedohnoyoudont@google.com)
  3. (rayankansohnoyoudont@chromium.org)
  4. (nburrisohnoyoudont@google.com)
  5. (dgroganohnoyoudont@chromium.org)
  6. (huayinzohnoyoudont@chromium.org)
  7. (thakisohnoyoudont@chromium.org)
  8. (sergeyuohnoyoudont@chromium.org)
  9. (eugenebutohnoyoudont@google.com)
  10. (kpaulhamusohnoyoudont@chromium.org)
  11. (etiennepohnoyoudont@chromium.org)
  12. (juncaiohnoyoudont@chromium.org)
  13. (tangltomohnoyoudont@chromium.org)
  14. (blundellohnoyoudont@chromium.org)
  15. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  16. (lazyboyohnoyoudont@chromium.org)
  17. (wnwenohnoyoudont@chromium.org)
  18. (digitohnoyoudont@google.com)
  19. (alexilinohnoyoudont@chromium.org)
  20. (offenwangerohnoyoudont@chromium.org)
  21. (kmilkaohnoyoudont@chromium.org)
  22. (rayankansohnoyoudont@chromium.org)
  23. (tbansalohnoyoudont@chromium.org)
  24. (kvitekpohnoyoudont@chromium.org)
  25. (junovohnoyoudont@chromium.org)
  26. (iclellandohnoyoudont@chromium.org)
  27. (pklohnoyoudont@chromium.org)
  28. (dmblackohnoyoudont@google.com)
  29. (carlosilohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 19:21:34 UTC
End Thursday, 12-Jul-18 21:04:56 UTC
Pending N/A
Execution 1 hrs 43 mins

All Changes:

  1. 🤝 Add flag to force showing TWA disclosure.

    Changed by peconnohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 967fc76c423a5e86fc2e04b4655aa463d2ae7c12

    Comments

    🤝 Add flag to force showing TWA disclosure.
    
    Add a flag to force showing the disclosure for developer convenience.
    Also trigger even when there isn't an active tab yet.
    
    Bug: 813100
    Change-Id: I3ccd820d58f82040723a8f8a72097262ba374b82
    Reviewed-on: https://chromium-review.googlesource.com/1116922
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Commit-Queue: Peter Conn <peconn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574591}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java
    • chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityDisclosure.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
  2. suppress until skia roll

    Changed by reedohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:30:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dcf8a49d5e3d2440dfc3f8e3126fa266fd25a33b

    Comments

    suppress until skia roll
    
    Bug: 863042
    Change-Id: I97a48047d0b6546055c255538fc31ddcc0a07078
    Reviewed-on: https://chromium-review.googlesource.com/1135288
    Commit-Queue: Mike Reed <reed@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574592}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  3. [Background Fetch] Add DB corruption handler to data manager observer.

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:31:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 96544636e959581575b9c4f1ac2ecd1c5f40296d

    Comments

    [Background Fetch] Add DB corruption handler to data manager observer.
    
    Bug: 850512
    Change-Id: Iddd2773f63fd7aa0368e980a347c1bef4312f23d
    Reviewed-on: https://chromium-review.googlesource.com/1128839
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574593}

    Changed files

    • content/browser/background_fetch/background_fetch_context.cc
    • content/browser/background_fetch/background_fetch_context.h
    • content/browser/background_fetch/background_fetch_data_manager.cc
    • content/browser/background_fetch/background_fetch_data_manager.h
    • content/browser/background_fetch/background_fetch_data_manager_observer.h
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_test_data_manager.cc
    • content/browser/background_fetch/storage/database_task.cc
    • content/browser/background_fetch/storage/database_task.h
    • content/browser/background_fetch/storage/delete_registration_task.cc
    • content/browser/background_fetch/storage/get_settled_fetches_task.cc
    • content/browser/background_fetch/storage/mark_registration_for_deletion_task.cc
    • content/browser/background_fetch/storage/start_next_pending_request_task.cc
  4. Settings WebUI: Fix extensions url on cleanup result page

    Changed by nburrisohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:33:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7cde465a809facc9ecb61350aaa5c504a36d9174

    Comments

    Settings WebUI: Fix extensions url on cleanup result page
    
    The cleaner success string now has HTML in it, and the JS i18n
    function strips it off. i18nAdvanced allows us to let the <a> through to
    the string, but the way the cleanup result page works is it simply sets
    the card text variable ("title") to the result message string. This
    would result in the raw string (with HTML) getting displayed, so the
    title variable needs to also be set to be the inner-h-t-m-l.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8ea98e9868f83fc14a674841072cc2915c7b4a48
    Reviewed-on: https://chromium-review.googlesource.com/1134191
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: proberge <proberge@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574594}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  5. [css-tables] Make table's max-content honor captions' min-content

    Changed by dgroganohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:34:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dff5931455e0302289a3cc9027fd3f98cfe22fca

    Comments

    [css-tables] Make table's max-content honor captions' min-content
    
    Table's min-content already honored it.
    
    We'd apparently never been bitten before by tables occasionally having
    min-content > max-content. A new DCHECK in LayoutNG exposed it.
    
    Bug: 857185
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I49009a4988fbf38c1bf745a4f028e4e8b050804b
    Reviewed-on: https://chromium-review.googlesource.com/1121251
    Commit-Queue: David Grogan <dgrogan@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574595}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/table/caption-min-greater-than-max-crash.html
    • third_party/WebKit/LayoutTests/fast/table/spans-min-greater-than-max-crash.html
    • third_party/blink/renderer/core/layout/layout_table.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  6. [Feed] Scroll and focus handling for the FeedNewTabPage

    Changed by huayinzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:36:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54d1975f16b7efae2408a1428fbde7207556a29

    Comments

    [Feed] Scroll and focus handling for the FeedNewTabPage
    
    + Implement NewTabPageLayout.ScrollDelegate to the FeedNewTabPage
    + Refactor snap scroll logic to a new class to make it reusable
    + Add top padding for the FeedNewTabPage to display correctly on tablet
    + Fix a small bug that search box is not enabled after auto snap scroll
    
    Bug: 860028, 860032, 862470
    Change-Id: I5bda9696a4515281378c1effe47b6ad47fdd4c49
    Reviewed-on: https://chromium-review.googlesource.com/1133594
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Becky Zhou <huayinz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574597}

    Changed files

    • chrome/android/feed/core/java/src/org/chromium/chrome/browser/feed/FeedNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/SnapScrollHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGroupTest.java
  7. Remove most android-specific hard_timeout and shard overrides.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:35:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a64d6771d8b24f079f24e41ebaf14f672747084

    Comments

    Remove most android-specific hard_timeout and shard overrides.
    
    These were added during android swarming bring-up.  We shouldn't use
    per-bot exceptions for this.
    
    Also remove a random sharding setting for base_unittests on ToTMac
    that doesn't look necessary.
    
    Bug: 843511
    Change-Id: Ia20771786f1b4106cd86d24d446e0a66f319dbff
    Reviewed-on: https://chromium-review.googlesource.com/1134531
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574596}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.swarm.json
    • testing/buildbot/test_suite_exceptions.pyl
  8. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  9. Add testDownloadWhileBrowsing EG test.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.
    
    After tapping Download this test opens a separate tabs and loads the URL
    there. Then closes the tab and waits for the download completion.
    
    Bug: 854232
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
    Reviewed-on: https://chromium-review.googlesource.com/1111916
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h
  10. Mark window-focus-self as flaky on Win10

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10
    
    Tbr: tkent@chromium.org
    Bug: 863067
    Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
    Reviewed-on: https://chromium-review.googlesource.com/1135433
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  11. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.
    
    AutofillProfileEnabled was added as a preference setting in 1127344.
    This CL creates a policy flag for AutofillProfileEnabled that can
    overwrite the user preference.
    
    Bug: 860526
    Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
    Reviewed-on: https://chromium-review.googlesource.com/1127463
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Reviewed-by: Drew Wilson <atwilson@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  12. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc
  13. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  14. Revert "Have Device Service observe MessageLoop destruction"

    Changed by blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which w
    ...skip...
    @chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  15. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae26c020606a88289e746e446999dd9c101019d

    Comments

    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365
    
    
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    
    The AutoRoll server is located here: https://webrtc
    ...skip...
    rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  16. [Extensions] Remove linked_ptr usage from extension_messages.cc

    Changed by lazyboyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:59:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision abb887f1fe0523ed4ab633530a3a55fd3e479731

    Comments

    [Extensions] Remove linked_ptr usage from extension_messages.cc
    
    This CL also makes ExtensionMsg_Load_Params non-copyable. There
    shouldn't be any behavior change in this CL.
    
    Bug: 556939
    Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
    Reviewed-on: https://chromium-review.googlesource.com/1132572
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574606}

    Changed files

    • extensions/browser/renderer_startup_helper.cc
    • extensions/common/extension_messages.cc
    • extensions/common/extension_messages.h
    • extensions/common/extension_messages_unittest.cc
  17. Android: Fix jinja template deps

    Changed by wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:05:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 001fc64fc2945bb7b18e6ffb20b6048c007ac6b8

    Comments

    Android: Fix jinja template deps
    
    Temporarily add missing deps to the depfile. Will no longer be necessary
    once all downstream targets are fixed.
    
    Bug: 843562
    Change-Id: Id797ea032a6a3818dac6013dcacb6f68baef2b6b
    Reviewed-on: https://chromium-review.googlesource.com/1134884
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574607}

    Changed files

    • build/android/gyp/jinja_template.py
  18. android: Update bundletool binary to 0.5.0

    Changed by digitohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc6d74d7b8c120d3d8d90ab8c68c5285e384a7f8

    Comments

    android: Update bundletool binary to 0.5.0
    
    This release contains a bugfix required to generate Android
    app bundle APKs archives that can be installed on all devices.
    
    For more context, see:
    https://buganizer.corp.google.com/issues/110777526
    
    BUG=846633,820459
    R=agrieve@chromium.org, bensmason@chromium.org, yfriedman@chromium.org
    
    Change-Id: Ic71445f49a4548c8610f5d18598cdd3d3d5692c4
    Reviewed-on: https://chromium-review.googlesource.com/1135127
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574608}

    Changed files

    • DEPS
    • build/android/gyp/bundletool.py
    • third_party/android_build_tools/bundletool/README.chromium
  19. Allow WritableSharedMemoryRegion to Unsafe conversion

    Changed by alexilinohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:08:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecfbde9b593ca7f497375f56da8d076eb29772fa

    Comments

    Allow WritableSharedMemoryRegion to Unsafe conversion
    
    This CL adds a new ConvertToUnsafe() method to the WritableSharedMemoryRegion
    class. This new method is similar to ConvertToReadOnly() in structure. The
    conversion does not modify an underlying platform handle (except it closes a
    read-only handle on POSIX) but changes region's type.
    
    Bug: 795291
    Change-Id: Ie0a6b4c9850c0e223ee9299655f9bfd6c79c383b
    Reviewed-on: https://chromium-review.googlesource.com/985981
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574610}

    Changed files

    • base/memory/platform_shared_memory_region.h
    • base/memory/platform_shared_memory_region_android.cc
    • base/memory/platform_shared_memory_region_fuchsia.cc
    • base/memory/platform_shared_memory_region_mac.cc
    • base/memory/platform_shared_memory_region_posix.cc
    • base/memory/platform_shared_memory_region_unittest.cc
    • base/memory/platform_shared_memory_region_win.cc
    • base/memory/writable_shared_memory_region.cc
    • base/memory/writable_shared_memory_region.h
  20. Modify XRSession so that session geometry is only sent when it changes

    Changed by offenwangerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a32f749ecae1923fda1485aa423b8e46dafddcf

    Comments

    Modify XRSession so that session geometry is only sent when it changes
    
    Making it so that instead of receiving geometry every frame, ar_core
    only gets geometry (frame size and rotation) when it changes. This saves
    some processing every frame, and allows the GetFrameData interface to be
    made uniform for AR and VR.
    
    Bug: 856259,846521
    Change-Id: I5828f57e1292f932c68148ac1e6b898f966b8d00
    Reviewed-on: https://chromium-review.googlesource.com/1115776
    Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574611}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • device/vr/vr_device_base.cc
    • device/vr/vr_device_base.h
    • device/vr/vr_display_impl.cc
    • device/vr/vr_display_impl.h
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h
  21. [NTP] Anchor custom backgrounds to the center of the window

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06072d0984b80b680e26ed0f498911ef35800af2

    Comments

    [NTP] Anchor custom backgrounds to the center of the window
    
    Bug: 862789
    Change-Id: Ia23e75d07d738e02571010aaf9cbd0a1bc486060
    Reviewed-on: https://chromium-review.googlesource.com/1134435
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574612}

    Changed files

    • chrome/renderer/searchbox/searchbox_extension.cc
  22. [Background Fetch] Deserialize icon from metadata on browser restart.

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0f9d40078cf7c016aeefb8a0aba4c498ed86aba

    Comments

    [Background Fetch] Deserialize icon from metadata on browser restart.
    
    Bug: 855789
    Change-Id: Ida29d5cbf111838c9bf8bc2639dddf7509169199
    Reviewed-on: https://chromium-review.googlesource.com/1128965
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574609}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  23. Deflake resource loading hints and previews browsertest

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:14:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a875a2ea21d8a321295a11440c80af01bcf7fa86

    Comments

    Deflake resource loading hints and previews browsertest
    
    Attempt to deflake resource loading hints and previews
    browsertest by waiting for hints to be processed.
    
    Currently, the hints are processed on the background thread,
    and so may not be processed immediately.
    
    Log from the failed Linux test bots seem to indicate that
    the hints are not processed in time.
    See http://shortn/_IjBGHDP2Rp
    
    Bug: 789542,831838
    Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
    Reviewed-on: https://chromium-review.googlesource.com/1134598
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574613}

    Changed files

    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  24. Separated harness and target page base urls.

    Changed by kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2eb30bfc9ba51a4ac3a4f28bf2c728c3252620d

    Comments

    Separated harness and target page base urls.
    
    Change-Id: Ie6b2097fd8c03b486c2cab8ec3357a8c55907e92
    Reviewed-on: https://chromium-review.googlesource.com/1134498
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574615}

    Changed files

    • headless/test/data/protocol/inspector-protocol-test.html
    • headless/test/headless_protocol_browsertest.cc
    • third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
  25. Refactor canvas code to centralize CanvasResourceProvider ownership

    Changed by junovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8b8872f2080130c2b5bdf026f32f46aad7598da

    Comments

    Refactor canvas code to centralize CanvasResourceProvider ownership
    
    With this change, CanvasResourceProvider is always owned
    by CanvasResourceHost, except for a a few special case that use
    ephemeral resource providers.  This is a step towards unifying
    canvas and OffscreenCanvas presentation code paths.
    
    BUG=788439
    TBR=fserb@chromium.org, zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
    Reviewed-on: https://chromium-review.googlesource.com/1134182
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574614}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
    • third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  26. Finish renaming "whitelist" to "allowlist".

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:17:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a27b817c70dec1ea68f4ea4b8711697ca694fb62

    Comments

    Finish renaming "whitelist" to "allowlist".
    
    Bug: 822317
    Change-Id: I155df06759c529dbd3183530c4722be3c4e0feb1
    Reviewed-on: https://chromium-review.googlesource.com/1133308
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574616}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/feature_policy/feature_policy.h
  27. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn
  28. Removes Assistant horizontal page.

    Changed by dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  29. Changed committed-interstitials flag from switch to feature.

    Changed by carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml