Home | Search
Login

Builder Win 7 Perf Build #3403 Microsoft Windows

Results:

exception steps failed components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1 failed load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1 failed media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1 exception performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1

Trigger Info:

Got Revision40871382b071cef2d3ec5f3884b5722eab3596d8

Execution:

Steps and Logfiles:

Show:
  1. ( 5 hrs 50 mins ) steps
    running steps via annotated script
  2. ( 33 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) report builders
    report builders
     
    running tester 'Win 7 Perf' on master 'chromium.perf'
  7. ( 1 ms ) taskkill
    taskkill
  8. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  9. ( 2 mins 37 secs ) bot_update
    bot_update
    [79GB/349GB used (22%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 21 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_7_Perf\src\testing\buildbot\chromium.perf.json
  16. ( 1 ms ) build directory
    build directory
  17. ( 2 mins 4 secs ) extract build
    extract build
  18. ( 1 ms ) read GN args
    read GN args
     
    is_chrome_branded = true
    is_debug = false
    is_official_build = true
    strip_absolute_paths_from_debug_symbols = true
    target_cpu = "x86"
    use_goma = true
    goma_dir = "C:\\b\\c\\goma_cache\\client"
  19. ( 1 ms ) find isolated tests
    find isolated tests
  20. ( 1 ms ) test_pre_run
    test_pre_run
  21. ( 8 secs ) test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  22. ( 5 secs ) test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  23. ( 21 secs ) test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  24. ( 15 secs ) test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  25. ( 1 hrs 59 mins ) components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    TEST RESULTS WERE INVALID
  26. ( 1 mins 2 secs ) load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    TEST RESULTS WERE INVALID
  27. ( 2 ms ) media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    TEST RESULTS WERE INVALID
  28. ( 3 hrs 42 mins ) performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:12:41.096252 (shard #3)
    Max shard duration: 5:19:32.039292 (shard #3)
    Min shard duration: 0:57:44.810542 (shard #2)
    Total tests: 496
    * Passed: 441 (441 expected, 0 unexpected)
    * Skipped: 55 (55 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 ms ) Upload to test-results [performance_test_suite on (102b) GPU on Windows]
    Upload to test-results [performance_test_suite on (102b) GPU on Windows]
  30. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 4
    Total runtime: 15:58:15.927000
     
  31. ( 1 ms ) process_dumps
    process_dumps
  32. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_7_Perf/3403/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_7_Perf/3403" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "c3bef3e7b0280aa367187921fdecf059796e7b65" Annotation(bot_update)
got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" Annotation(bot_update)
got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" Annotation(bot_update)
got_revision "40871382b071cef2d3ec5f3884b5722eab3596d8" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#596271}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "573561bf18181e6a08b8db00576dcb8adc969800" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.1.226@{#1}" Annotation(bot_update)
got_webrtc_revision "f9d38f2e4e5d87f3a1be0711b385d9809c9281f8" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24952}" Annotation(bot_update)
swarm_hashes {"components_perftests":"1be646545ed2a07c220c31f48e429074b92e57d1","load_library_perf_tests":"1671a2ef337d9103bdd1460da7dad6354403e23c","media_perftests":"f279762d2aeee2b018ea65fee6aed88f0daad5c5","performance_test_suite":"748d1edb9584b4f4080604a38a6a49186f85cf26"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmpkcn86b" Annotation(steps)
build_id "buildbot/chromium.perf/Win 7 Perf/3403" Annotation(steps)
builder_id "master.chromium.perf:Win 7 Perf" Annotation(steps)
blamelist ["acondor@chromium.org","alph@chromium.org","baileyberro@chromium.org","braveyao@chromium.org","bsazonov@chromium.org","buldina@chromium.org","cbiesinger@chromium.org","chiniforooshan@chromium.org","chromium-autoroll@skia-public.iam.gserviceaccount.com","chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com","dfried@chromium.org","edchin@chromium.org","erikchen@chromium.org","estevenson@chromium.org","etiennep@chromium.org","fsamuel@chromium.org","ftirelo@chromium.org","geofflang@chromium.org","gmx@chromium.org","guidou@chromium.org","hans@chromium.org","hansberry@chromium.org","hcarmona@chromium.org","jinho.bang@samsung.com","johnidel@chromium.org","katie@chromium.org","kojii@chromium.org","lindsayw@google.com","martiniss@chromium.org","mastiz@chromium.org","mdjones@chromium.org","meilinw@google.com","mharanczyk@opera.com","nednguyen@google.com","orphis@chromium.org","ossu@chromium.org","palmer@chromium.org","petewil@chromium.org","pkasting@chromium.org","qinmin@chromium.org","rayankans@chromium.org","rbpotter@chromium.org","reillyg@google.com","rmcelrath@chromium.org","robertma@chromium.org","sdefresne@chromium.org","smcgruer@chromium.org","sorin@chromium.org","sunxd@chromium.org","syoussefi@chromium.org","tbansal@chromium.org","thakis@chromium.org","timidger@google.com","torne@google.com","tzik@chromium.org","wangxianzhu@chromium.org","wfh@chromium.org","wzang@chromium.org","yeonwoo.jo.92@gmail.com","yvesg@google.com"] Build
branch "master" Build
buildnumber 3403 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1538582754 Build
revision "40871382b071cef2d3ec5f3884b5722eab3596d8" Build
slavename "vm4-m1" BuildSlave
buildername "Win 7 Perf" Builder
git_revision "40871382b071cef2d3ec5f3884b5722eab3596d8" Change
parent_buildername "Win Builder Perf" ParentBuild
parent_buildnumber 48605 ParentBuild
parent_got_angle_revision "c3bef3e7b0280aa367187921fdecf059796e7b65" ParentBuild
parent_got_buildtools_revision "2dff9c9c74e9d732e6fe57c84ef7fd044cc45d96" ParentBuild
parent_got_nacl_revision "2ebbdab4bfb1ed9dfe52ce756b34829207dbe25f" ParentBuild
parent_got_revision "40871382b071cef2d3ec5f3884b5722eab3596d8" ParentBuild
parent_got_revision_cp "refs/heads/master@{#596271}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "573561bf18181e6a08b8db00576dcb8adc969800" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.1.226@{#1}" ParentBuild
parent_got_webrtc_revision "f9d38f2e4e5d87f3a1be0711b385d9809c9281f8" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24952}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_7_Perf" slave

Blamelist:

  1. (acondorohnoyoudont@chromium.org)
  2. (smcgruerohnoyoudont@chromium.org)
  3. (ossuohnoyoudont@chromium.org)
  4. (sunxdohnoyoudont@chromium.org)
  5. (sdefresneohnoyoudont@chromium.org)
  6. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  7. (lindsaywohnoyoudont@google.com)
  8. (bsazonovohnoyoudont@chromium.org)
  9. (jinho.bangohnoyoudont@samsung.com)
  10. (geofflangohnoyoudont@chromium.org)
  11. (estevensonohnoyoudont@chromium.org)
  12. (syoussefiohnoyoudont@chromium.org)
  13. (thakisohnoyoudont@chromium.org)
  14. (tbansalohnoyoudont@chromium.org)
  15. (orphisohnoyoudont@chromium.org)
  16. (hansohnoyoudont@chromium.org)
  17. (kojiiohnoyoudont@chromium.org)
  18. (orphisohnoyoudont@chromium.org)
  19. (smcgruerohnoyoudont@chromium.org)
  20. (orphisohnoyoudont@chromium.org)
  21. (edchinohnoyoudont@chromium.org)
  22. (guidouohnoyoudont@chromium.org)
  23. (edchinohnoyoudont@chromium.org)
  24. (nednguyenohnoyoudont@google.com)
  25. (johnidelohnoyoudont@chromium.org)
  26. (chiniforooshanohnoyoudont@chromium.org)
  27. (sorinohnoyoudont@chromium.org)
  28. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  29. (thakisohnoyoudont@chromium.org)
  30. (timidgerohnoyoudont@google.com)
  31. (baileyberroohnoyoudont@chromium.org)
  32. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  33. (tzikohnoyoudont@chromium.org)
  34. (hansberryohnoyoudont@chromium.org)
  35. (petewilohnoyoudont@chromium.org)
  36. (rayankansohnoyoudont@chromium.org)
  37. (yeonwoo.jo.92ohnoyoudont@gmail.com)
  38. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  39. (rayankansohnoyoudont@chromium.org)
  40. (meilinwohnoyoudont@google.com)
  41. (qinminohnoyoudont@chromium.org)
  42. (rayankansohnoyoudont@chromium.org)
  43. (braveyaoohnoyoudont@chromium.org)
  44. (katieohnoyoudont@chromium.org)
  45. (wfhohnoyoudont@chromium.org)
  46. (cbiesingerohnoyoudont@chromium.org)
  47. (dfriedohnoyoudont@chromium.org)
  48. (pkastingohnoyoudont@chromium.org)
  49. (ftireloohnoyoudont@chromium.org)
  50. (etiennepohnoyoudont@chromium.org)
  51. (hcarmonaohnoyoudont@chromium.org)
  52. (martinissohnoyoudont@chromium.org)
  53. (cbiesingerohnoyoudont@chromium.org)
  54. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  55. (erikchenohnoyoudont@chromium.org)
  56. (yvesgohnoyoudont@google.com)
  57. (cbiesingerohnoyoudont@chromium.org)
  58. (wzangohnoyoudont@chromium.org)
  59. (kojiiohnoyoudont@chromium.org)
  60. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  61. (buldinaohnoyoudont@chromium.org)
  62. (gmxohnoyoudont@chromium.org)
  63. (reillygohnoyoudont@google.com)
  64. (erikchenohnoyoudont@chromium.org)
  65. (robertmaohnoyoudont@chromium.org)
  66. (rmcelrathohnoyoudont@chromium.org)
  67. (chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com)
  68. (torneohnoyoudont@google.com)
  69. (wzangohnoyoudont@chromium.org)
  70. (palmerohnoyoudont@chromium.org)
  71. (erikchenohnoyoudont@chromium.org)
  72. (mastizohnoyoudont@chromium.org)
  73. (erikchenohnoyoudont@chromium.org)
  74. (fsamuelohnoyoudont@chromium.org)
  75. (chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com)
  76. (mdjonesohnoyoudont@chromium.org)
  77. (rbpotterohnoyoudont@chromium.org)
  78. (alphohnoyoudont@chromium.org)
  79. (wangxianzhuohnoyoudont@chromium.org)
  80. (bsazonovohnoyoudont@chromium.org)
  81. (mharanczykohnoyoudont@opera.com)

Timing:

Create N/A
Start Wednesday, 03-Oct-18 22:30:12 UTC
End Thursday, 04-Oct-18 04:20:59 UTC
Pending N/A
Execution 5 hrs 50 mins

All Changes:

  1. Revert "VR: Remove bottom margin from NTP"

    Changed by acondorohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:34:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eaffa5c85632b028cbf3bf660967feccee5285c

    Comments

    Revert "VR: Remove bottom margin from NTP"
    
    This reverts commit 31783d1f676795dd837807d56ce9d38d6fd9d6aa.
    
    Reason for revert: Crash when opening a new tab.
    
    Original change's description:
    > VR: Remove bottom margin from NTP
    > 
    > Bug: 884803
    > Change-Id: I20378649418949c2d00097ff8ca204972c54b2ab
    > Reviewed-on: https://chromium-review.googlesource.com/1240169
    > Reviewed-by: Theresa <twellington@chromium.org>
    > Reviewed-by: Matthew Jones <mdjones@chromium.org>
    > Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#595884}
    
    TBR=twellington@chromium.org,mdjones@chromium.org,acondor@chromium.org
    
    Change-Id: Ifef474e5c9183a32934a1eeb401c2a5e7e3e505f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 884803
    Reviewed-on: https://chromium-review.googlesource.com/c/1258299
    Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596224}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
  2. [Sheriff] Disable TwoClientDictionarySyncTest.Limit on win dbg + asan

    Changed by smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:44:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 746f0fd72aaa18424b374e27c8fa99ed68d494fc

    Comments

    [Sheriff] Disable TwoClientDictionarySyncTest.Limit on win dbg + asan
    
    This test has been flake-crashing on these bots.
    
    TBR=mamir@chromium.org
    
    Bug: 889505
    Change-Id: If527913f0e15f4d298b81c578d17a762f573be0e
    Reviewed-on: https://chromium-review.googlesource.com/c/1258966
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596230}

    Changed files

    • chrome/browser/sync/test/integration/two_client_dictionary_sync_test.cc
  3. APM in Audio Service: Add field trial configuration

    Changed by ossuohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:47:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d693b570ceda0ff3b4da78784e64f20804ca2e26

    Comments

    APM in Audio Service: Add field trial configuration
    
    Bug: 874784
    Change-Id: I63e6185605e25bf009de8b319f72a9fd459672c9
    Reviewed-on: https://chromium-review.googlesource.com/c/1257915
    Reviewed-by: Brian White <bcwhite@chromium.org>
    Reviewed-by: Olga Sharonova <olka@chromium.org>
    Commit-Queue: Oskar Sundbom <ossu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596231}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  4. Update MainThreadScrollingReason histogram enum

    Changed by sunxdohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:43:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 48f5f716bb4afde1221284da07a4bafc1d4c020a

    Comments

    Update MainThreadScrollingReason histogram enum
    
    The newly added MainThreadScrollingReasons: kWheelEventHandlerRegion and
    kTouchEventHandlerRegion cannot be displayed correctly on UMA. This CL
    updates the histogram enum in order to fix this bug.
    
    Bug: 861754
    Change-Id: Ibd165ffe477cbc405d047bc820c77056d730ec6e
    Reviewed-on: https://chromium-review.googlesource.com/c/1257549
    Commit-Queue: Xianda Sun <sunxd@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596228}

    Changed files

    • tools/metrics/histograms/enums.xml
  5. Remove direct uses of TestingFunctionFactory

    Changed by sdefresneohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:40:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31920083e9c0c953e9d9286f208ff995129a25a3

    Comments

    Remove direct uses of TestingFunctionFactory
    
    Replace them with uses of TestingFactory which is based
    on base::Callback<> instead of function pointers.
    
    This converts uses in /chrome/browser/sync.
    
    This CL was uploaded by git cl split.
    
    R=tschumann@chromium.org
    
    Bug: 809610
    Change-Id: If489e869a7f9143528ef89411b1a8d7c6e24b79b
    Reviewed-on: https://chromium-review.googlesource.com/c/1245729
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596227}

    Changed files

    • chrome/browser/sync/test/integration/sync_test.cc
  6. Roll src/third_party/skia 5b2bc879189c..55aea84baa53 (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 15:36:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2435dfd027b63a9ddc44d1804e0ca8f3c9f9eb64

    Comments

    Roll src/third_party/skia 5b2bc879189c..55aea84baa53 (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/5b2bc879189c..55aea84baa53
    
    
    git log 5b2bc879189c..55aea84baa53 --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 egdaniel@google.com Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN."
    2018-10-03 borenet@google.com [infra] Also run install_go_deps.sh during go_deps asset creation
    
    
    Created with:
      gclient setdep -r src/third_party/skia@55
    ...skip...
    y:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:862144
    TBR=mtklein@chromium.org
    
    Change-Id: Iec08865684a554ae2af371c287ec4fce3c7a3885
    Reviewed-on: https://chromium-review.googlesource.com/c/1258875
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596226}

    Changed files

    • DEPS
  7. Fix ios12-beta-simulator bot.

    Changed by lindsaywohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 15:53:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a8d2ee4de06b86ee072bcf5702e5e078115866d9

    Comments

    Fix ios12-beta-simulator bot.
    
    Bug: 852504
    Change-Id: I8599be996f3a556228e4abeda0aedff57b3b49b4
    Reviewed-on: https://chromium-review.googlesource.com/c/1258290
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596233}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
  8. [Unity][Android] Don't enable checkboxes if sync is disabled

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:54:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c50da9c252308db395f6550a74dad96d78f3145e

    Comments

    [Unity][Android] Don't enable checkboxes if sync is disabled
    
    This CL reimplements SyncAndServicesPreferences.updateDataTypeState to
    unify configuration of checkboxes. It resolves the issue when all
    checkboxes become enabled even though requirements for some data types
    aren't met.
    
    Bug: 889015
    Change-Id: If9cffded02ce163edd33eaeeba73ddd244b9ce89
    Reviewed-on: https://chromium-review.googlesource.com/c/1258007
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596234}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SyncAndServicesPreferences.java
  9. Reland "PaymentRequest: Fix a memory leak in retry()"

    Changed by jinho.bangohnoyoudont@samsung.com
    Changed at Wednesday, 03-Oct-18 15:52:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49fa224f51d2c28e1dacf3b6de16bb0b9503af7c

    Comments

    Reland "PaymentRequest: Fix a memory leak in retry()"
    
    Reason for revert:
    A crash occurs because two animations runs in the same time.
    In the current implementation, the ViewStack class seems to be able to
    run only one animation per one time. So, before one animation finishes,
    if another animation runs, it might cause a crash.
    
    The ShowInitialPaymentSheet() doesn't make animation internally but the
    GoBackToPaymentSheet() do. So, after retry() calls, if shipping address
    or contact editor runs, it might
    ...skip...
    
    > Reviewed-on: https://chromium-review.googlesource.com/1255082
    > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
    > Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    > Cr-Commit-Position: refs/heads/master@{#595644}
    
    Bug: 861704
    Change-Id: I5ab64423697aa11de97bf68ec9d9f262d7676bb5
    Reviewed-on: https://chromium-review.googlesource.com/c/1258813
    Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
    Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#596232}

    Changed files

    • chrome/browser/ui/views/payments/contact_info_editor_view_controller_browsertest.cc
    • chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
    • chrome/browser/ui/views/payments/payment_request_browsertest_base.h
    • chrome/browser/ui/views/payments/payment_request_dialog_view.cc
    • chrome/browser/ui/views/payments/payment_request_dialog_view.h
    • chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc
    • chrome/browser/ui/views/payments/view_stack.cc
    • chrome/browser/ui/views/payments/view_stack.h
  10. Fix use_static_angle build flag and require a flag to use ANGLE.

    Changed by geofflangohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:56:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 70019b573ffe4286555c2b340a341f6ff064b915

    Comments

    Fix use_static_angle build flag and require a flag to use ANGLE.
    
    ui/gl initialization is now in a sub library, move the dependencies.
    
    Require a flag to use ANGLE on Android, this allows ANGLE and the native
    driver to both work with a given build so we can test on the bots.
    
    BUG=726002
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I2d3e0c4e844dca9e72c363f07e011c710e1a9f57
    Reviewed-on: https://chromium-review.googlesource.com/c/1244078
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596236}

    Changed files

    • ui/gl/BUILD.gn
    • ui/gl/init/BUILD.gn
    • ui/gl/init/gl_initializer_android.cc
  11. Android: Update d8 to 1.2.48.

    Changed by estevensonohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:06:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bf9f06ecd6399fec7931fa6b6af02d6261c10600

    Comments

    Android: Update d8 to 1.2.48.
    
    Includes fix for supporting asserts and invalid locals information.
    
    Bug: 843307
    Change-Id: Iec4ecb2981e8c895e728127179d3b0eb54f09b14
    Reviewed-on: https://chromium-review.googlesource.com/c/1258963
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596239}

    Changed files

    • DEPS
    • third_party/r8/README.chromium
    • third_party/r8/cipd.yaml
  12. Implement blob cache for passthrough program cache

    Changed by syoussefiohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 15:58:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 42f33356f2cfde6ef4cd1f669bb217480d21e72c

    Comments

    Implement blob cache for passthrough program cache
    
    Prior to this commit, the passthrough program cache used
    EGL_ANGLE_program_cache_control to store binary programs in angle's
    cache.  With support for EGL_ANDROID_blob_cache added to angle, this
    role is reversed, i.e. the blob cache lives in the application (chrome),
    with the implementation (angle) storing additional data through
    callbacks.
    
    Bug: angleproject:2516
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I62d5c484580d953013d00e31300285be6b9442ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1251325
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596237}

    Changed files

    • gpu/BUILD.gn
    • gpu/command_buffer/service/context_group.h
    • gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
    • gpu/command_buffer/service/memory_program_cache.cc
    • gpu/command_buffer/service/passthrough_program_cache.cc
    • gpu/command_buffer/service/passthrough_program_cache.h
    • gpu/command_buffer/service/passthrough_program_cache_unittest.cc
    • gpu/command_buffer/service/program_cache.cc
    • gpu/command_buffer/service/program_cache.h
    • gpu/ipc/service/gpu_channel_manager.cc
    • ui/gl/angle_platform_impl.cc
    • ui/gl/angle_platform_impl.h
    • ui/gl/egl_bindings_autogen_mock.cc
    • ui/gl/egl_bindings_autogen_mock.h
    • ui/gl/generate_bindings.py
    • ui/gl/gl_bindings_api_autogen_egl.h
    • ui/gl/gl_bindings_autogen_egl.cc
    • ui/gl/gl_bindings_autogen_egl.h
    • ui/gl/gl_mock_autogen_egl.h
  13. Remove the mac_views_browser gn variable.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:02:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0f410894a4fae428a9bb2319f3095dc477b7094

    Comments

    Remove the mac_views_browser gn variable.
    
    It's now redundant with is_mac.
    
    The biggest use of it was that it set the buildflag MAC_VIEWS_BROWSER,
    but I removed all references to that in the last few days:
    https://cs.chromium.org/chromium/src/ui/base/BUILD.gn?q=%5CbMAC_VIEWS_BROWSER+case:yes
    
    Bug: 832676
    Change-Id: I9bd74e26a35ddb4dfec786e4b0a6ada24366c951
    Reviewed-on: https://chromium-review.googlesource.com/c/1258295
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596238}

    Changed files

    • chrome/app/theme/theme_resources.grd
    • chrome/browser/ui/views/browser_dialogs_views.cc
    • chrome/common/features.gni
    • chrome/test/BUILD.gn
    • ui/base/BUILD.gn
    • ui/base/ui_features.gni
  14. Skip cookie check for origins when sending client hints

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:14:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0c1fc317df31881810430d0acd5907b5bd0130e

    Comments

    Skip cookie check for origins when sending client hints
    
    Skip cookie check for origins when sending client hints.
    The cookie check was initially added when there was plan to
    allow 3rd party origins to request client hints.
    Since client hints are now
    restricted to only first party origins, and client hints are
    already disabled for origins that do not have JavaScript permissions,
    this cookie check is considered redundant. Note that cookie check is not
    required by the fetch or client hints spec either.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I080fa5257abba15724559a39b4b73ac4f2e12e3e
    Bug: 891370
    Reviewed-on: https://chromium-review.googlesource.com/c/1253215
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596243}

    Changed files

    • chrome/browser/client_hints/client_hints.cc
    • chrome/browser/client_hints/client_hints.h
    • chrome/browser/client_hints/client_hints_browsertest.cc
    • chrome/browser/client_hints/client_hints_observer.cc
    • chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  15. Remove test expectations for RTCPeerConnection-setRemoteDescription

    Changed by orphisohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:15:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61db177155a65fc322dc41f9d4fe022530a72f8c

    Comments

    Remove test expectations for RTCPeerConnection-setRemoteDescription
    
    Update the test outputs accordingly too.
    
    Change-Id: I644199d912c71df0ce2db7dd3292d00ce5a120ec
    Reviewed-on: https://chromium-review.googlesource.com/c/1256971
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596245}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt
  16. Fix -Wdefaulted-function-deleted warning

    Changed by hansohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:09:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 187565cbaabc2d2b503fb278f0caac664b6d58eb

    Comments

    Fix -Wdefaulted-function-deleted warning
    
    ../../cc/paint/solid_color_analyzer.cc:155:5: warning: explicitly defaulted
    default constructor is implicitly deleted [-Wdefaulted-function-deleted]
        Frame() = default;
        ^
    ../../cc/paint/solid_color_analyzer.cc:161:38: note: default constructor of
    'Frame' is implicitly deleted because field 'iter' has no default constructor
        PaintOpBuffer::CompositeIterator iter;
                                         ^
    
    Bug: 890307
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I9e4cb20394a603e43e3a62264189da29f01da20a
    Reviewed-on: https://chromium-review.googlesource.com/c/1256827
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596240}

    Changed files

    • cc/paint/solid_color_analyzer.cc
  17. [LayoutNG] Change to FullPaintInvalidation on all objects from Subtree FullPaintInvalidation

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:17:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1880a97b3a2021e3848e3d791b31836ed3c64f45

    Comments

    [LayoutNG] Change to FullPaintInvalidation on all objects from Subtree FullPaintInvalidation
    
    LayoutNG used to apply Subtree paint invalidation for new
    NGPaintFragment, because fragments are always replaced with
    new ones. With recent changes to reuse NGPaintFragment, we
    can start exploring to do less paint invalidations.
    
    This patch changes Subtree to FullPaintInvalidation on all
    objects. There might be cases where we can do even less, but
    this change:
    * paint/invalidation test results match better to
    ...skip...
    roved by 18%, though
    fixed-and-many-layers-scroll regresed by 5.6%.
    
    Bug: 714962
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5b0db240c3d9f84ffb7f02d0f7bd7d0aa9b82296
    Reviewed-on: https://chromium-review.googlesource.com/c/1250821
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596246}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/sub-pixel/repaint-subpixel-layer-in-subpixel-composited-layer-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/background/background-resize-height-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/block-no-inflow-children-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/bugzilla-3509-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/bugzilla-5699-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/bugzilla-6278-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/bugzilla-7235-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/clip/clipped-relative-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/clip/replaced-clipped-positioned-not-wrong-incremental-repainting-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/containing-block-added-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/containing-block-added-individual-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/containing-block-removed-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/containing-block-removed-individual-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/iframe-inside-squashed-layer-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/invalidations-with-large-negative-margin-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/remove-squashed-layer-plus-move-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/compositing/repaint-via-layout-offset-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/crbug-371640-3-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/remove-inline-block-descendant-of-flex-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/flexbox/repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/float-move-during-layout-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/gradients-em-stops-repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/image/percent-size-image-resize-container-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/inline-reflow-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/line-flow-with-floats-2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/line-flow-with-floats-8-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/lines-with-layout-delta-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/list-marker-2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/clipped-overflow-visible-subtree-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/float-overflow-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/float-overflow-right-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/overflow/line-overflow-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/absolute-margin-change-repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/containing-block-position-change-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/inline-relative-positioned-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/layout-state-relative-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/layoutstate-invalid-invalidation-inline-relative-positioned-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/positioned-document-element-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/positioned-great-grandparent-change-location-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/position/positioned-list-offset-change-repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/push-block-with-first-line-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/quotes-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/reflection/reflection-with-rotation-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/remove-inline-after-layout-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/repaint-descandant-on-ancestor-layer-move-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/resize-iframe-text-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/fixed-after-scroll-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/fixed-child-of-transformed-move-after-scroll-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/layout-state-scrolloffset-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/layout-state-scrolloffset2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/layout-state-scrolloffset3-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/line-in-scrolled-clipped-block-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/overflow-move-after-scroll-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/overflow-scroll-body-appear-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/overflow-scroll-delete-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/scroll/resize-scrollable-iframe-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selected-replaced-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/selection-clear-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/subtree-root-skipped-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/absolute-sized-content-with-resources-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/add-outline-property-on-root-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/object-sizing-no-width-height-change-content-box-size-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-deep-shadow-tree-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-image-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-inner-svg-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-shadow-tree-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-shadow-tree-content-with-symbol-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-use-on-symbol-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/relative-sized-use-without-attributes-on-symbol-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/remove-outline-property-on-root-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/scrolling-embedded-svg-file-image-repaint-problem-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/svg/svg-image-change-content-size-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/resize-table-repaint-percent-size-cell-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/resize-table-repaint-vertical-align-cell-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/resize-table-row-repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/table/table-collapsed-border-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/text-append-dirty-lines-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/text-match-document-change-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/transform/invalidation-with-scale-transform-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/transform/transform-layout-repaint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/vertical-align-length1-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/vertical-align-length2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/vertical-align1-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/vertical-align2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-no-layout-change2-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-vertical-writing-mode-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment.h
  18. Remove and fix non-spec compliant WebRTC tests

    Changed by orphisohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:15:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59fe4497c6255e18f24978d87724a8702979617c

    Comments

    Remove and fix non-spec compliant WebRTC tests
    
    Bug: 803494
    Change-Id: Ic9efe4adba6909f6af3dbcf90d64debeef216480
    Reviewed-on: https://chromium-review.googlesource.com/c/1257786
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596244}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-encodings-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-encodings.html
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpParameters-helper.js
    • third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCRtpReceiver-getParameters.html
    • third_party/WebKit/LayoutTests/virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpParameters-encodings-expected.txt
  19. [Sheriff] Mark fast/dom/inline-event-attributes-release.html flaky

    Changed by smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:12:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 439b35f5806bc2b9e3d4a77d0af379d85693525f

    Comments

    [Sheriff] Mark fast/dom/inline-event-attributes-release.html flaky
    
    Test is flaky-failing on win7, with no obvious recent change to be
    reverted.
    
    Bug: 891510
    Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690
    
    TBR=mlippautz@chromium.org
    
    Change-Id: Ie77d5cf168bcf363dd994414249ea4f803907690
    Reviewed-on: https://chromium-review.googlesource.com/c/1258962
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596241}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  20. Remove overloads of SetCodecPreferences()

    Changed by orphisohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:14:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae431b9208a9a7aa00b0f158c35631a4493f4a99

    Comments

    Remove overloads of SetCodecPreferences()
    
    The base function is changing to return an RTCError, so we need to stop
    overriding the old function.
    
    Bug: 891556
    Change-Id: Id9d1a90732a07fa3877f5ce50824d920bacf2777
    Reviewed-on: https://chromium-review.googlesource.com/c/1257860
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596242}

    Changed files

    • content/renderer/media/webrtc/mock_peer_connection_impl.cc
    • content/renderer/media/webrtc/mock_peer_connection_impl.h
    • content/renderer/media/webrtc/transceiver_state_surfacer.cc
    • content/renderer/media/webrtc/transceiver_state_surfacer.h
  21. [ios] Fix snapshot frame

    Changed by edchinohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:18:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ffb820eef85cc7727d4cce5abc1d99c1d21fdae

    Comments

    [ios] Fix snapshot frame
    
    When using the WKWebView snapshot API, the specified frame should be in
    the coordinate space of the web view rather than the BVC.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Idc5f28745085e36891d77a4005e10f4d3bfd66c5
    Reviewed-on: https://chromium-review.googlesource.com/c/1257828
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596248}

    Changed files

    • ios/chrome/browser/snapshots/snapshot_generator.mm
  22. Include ended tracks when cloning MediaStreams.

    Changed by guidouohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:17:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b33058c7dc94ae14c629b1d8895782408cbf4301

    Comments

    Include ended tracks when cloning MediaStreams.
    
    This CL also covers the MediaStream constructor.
    In addition, tests are moved to WPT.
    
    Bug: 770908
    Change-Id: I6db9a86e9ee839efc2b04b00ae8fc57f07d852c3
    Reviewed-on: https://chromium-review.googlesource.com/c/1256796
    Commit-Queue: Guido Urdaneta <guidou@chromium.org>
    Reviewed-by: Harald Alvestrand <hta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596247}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-clone.https.html
    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-idl.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStream-idl.https.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-clone.html
    • third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamConstructor.html
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
  23. [ios] Remove old LRU Snapshot Cache flag

    Changed by edchinohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:25:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b77920056309e820a5a6faed6fc055a0d5b9b6f4

    Comments

    [ios] Remove old LRU Snapshot Cache flag
    
    Bug: 751553
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: Iaa724ae915ccb81347a7f82c41de47f64697eeee
    Reviewed-on: https://chromium-review.googlesource.com/c/1257791
    Reviewed-by: edchin <edchin@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596249}

    Changed files

    • ios/chrome/browser/experimental_flags.h
    • ios/chrome/browser/experimental_flags.mm
  24. Remove measurements that are no longer used by any benchmark

    Changed by nednguyenohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 16:40:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c034b8d8e1e5a29693aa463e2568551fe9537303

    Comments

    Remove measurements that are no longer used by any benchmark
    
    Bug: 891705
    Change-Id: Ied9506803dd2dd09a0bcfbff73274cc96d014715
    Reviewed-on: https://chromium-review.googlesource.com/c/1258965
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#596252}

    Changed files

    • tools/perf/measurements/draw_properties.py
    • tools/perf/measurements/image_decoding.py
    • tools/perf/measurements/page_cycler.js
    • tools/perf/measurements/task_execution_time.py
    • tools/perf/measurements/task_execution_time_unittest.py
    • tools/perf/measurements/v8_gc_times.py
    • tools/perf/measurements/v8_gc_times_unittest.py
  25. Rename PageLoadMetricsTestWaiter::AddCompleteResourceExpectation

    Changed by johnidelohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:33:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04f0a9e5df9bf11d9bc3c6a375c0c7438eb64d86

    Comments

    Rename PageLoadMetricsTestWaiter::AddCompleteResourceExpectation
    
    The current name "AddCompleteResourcesExpectation" is deceiving. This
    does not check that exactly a certain number of resources completed, but
    that at some point, that number of resources had been completed. E.g. an
    expectation for 3 resources will wait correctly, even if 10 resources
    actually completed. Rename using minimum to match rest of expectation
    conventions in file.
    
    Change-Id: Ie9edaccf106d8f7c131c1caaa257ebeab32a0459
    Reviewed-on: https://chromium-review.googlesource.com/c/1258297
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Commit-Queue: John Delaney <johnidel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596250}

    Changed files

    • chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_test_waiter.cc
    • chrome/browser/page_load_metrics/page_load_metrics_test_waiter.h
  26. Telemetry: Migrate smoothness benchmarks

    Changed by chiniforooshanohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 14:50:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5cf2125afa9adeeda1b9eb8b9e75d5cc666d6870

    Comments

    Telemetry: Migrate smoothness benchmarks
    
    We would like to deprecate smoothness metrics and replace them with
    equivalent TBMv2 rendering metrics. To prevent those changes from
    breaking benchmarks that use legacy smoothness metrics, this CL chanes
    those benchmarks to compute both legacy and equivalent TBMv2 metrics.
    After the transition is complete, we can just compute TBMv2 ones.
    
    Bug: 890757
    Change-Id: I95203ec76a09be2273e4f71fe3e372e1ff04cc6d
    Reviewed-on: https://chromium-review.googlesource.com/c/1258213
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596210}

    Changed files

    • tools/perf/measurements/rendering.py
    • tools/perf/measurements/rendering_unittest.py
    • tools/perf/measurements/rendering_util.py
    • tools/perf/measurements/smoothness.py
  27. Revert "mac: Re-enable PageInfoBubbleViewsMacTest."

    Changed by sorinohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:35:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e40eec4780155bc720fbad6105dd34be76ae786

    Comments

    Revert "mac: Re-enable PageInfoBubbleViewsMacTest."
    
    This reverts commit 23d3d5377ffc0e4b654c893e7bcd0d629443372d.
    
    Reason for revert: It breaks tests on https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests such as
    
    failures:
    PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/1
    PageInfoBubbleViewsMacTest.NoCrashOnFullScreenToggle/0
    
    10.12 is affected too:
    
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15611
    
    Original change's description:
    > ma
    ...skip...
    Fong-Jones <ellyjones@chromium.org>
    > Commit-Queue: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#596204}
    
    TBR=ellyjones@chromium.org,thakis@chromium.org
    
    Change-Id: Ied439ffdb5cce7d708c250251d74a8d2c9b98631
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 845389
    Reviewed-on: https://chromium-review.googlesource.com/c/1259143
    Reviewed-by: Sorin Jianu <sorin@chromium.org>
    Commit-Queue: Sorin Jianu <sorin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596251}

    Changed files

    • chrome/browser/ui/cocoa/page_info/page_info_bubble_views_mac_browsertest.mm
    • chrome/test/BUILD.gn
  28. Roll src-internal b21e4a509d0c..457799c2a3af (2 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 16:57:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db8d2af8af232b7d18add8fa23c974cbb53b2174

    Comments

    Roll src-internal b21e4a509d0c..457799c2a3af (2 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b21e4a509d0c..457799c2a3af
    
    
    Created with:
      gclient setdep -r src-internal@457799c2a3af
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=mmoss@chromium.org
    
    Change-Id: I6043e013c86dfec50f98d36480a9d718c36c77c7
    Reviewed-on: https://chromium-review.googlesource.com/1257716
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596256}

    Changed files

    • DEPS
  29. Prefer const char* over unneeded std::string in a few tests.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:49:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 66c81ad8517faf7d5b6baaaa64ee8ad470523231

    Comments

    Prefer const char* over unneeded std::string in a few tests.
    
    Removes 69 exit time destructors. Since it's test-only this isn't
    very important, but since it also simplifies the code and needs fewer
    string conversions at runtime, might as well do it.
    
    Bug: 101600
    Change-Id: I7474cbcf77fdbb35f350dbfdfee1ed597cadbe50
    Reviewed-on: https://chromium-review.googlesource.com/1258301
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596253}

    Changed files

    • third_party/blink/renderer/platform/fonts/orientation_iterator_test.cc
    • third_party/blink/renderer/platform/fonts/script_run_iterator_test.cc
    • third_party/blink/renderer/platform/fonts/small_caps_iterator_test.cc
  30. Use version 3 for DisableExtensions not 2

    Changed by timidgerohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 16:50:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a78043deb1840d45ef6a4ee262ad0fc3b223709

    Comments

    Use version 3 for DisableExtensions not 2
    
    We already shipped a chrome version with version 2 exposed, so the
    Chrome Cleanup Tool will try to use this method when it doesn't exist
    unless we bump the minimum version.
    
    Change-Id: I6c0bf1209da85ea54f4e7d2d365d64ac8a98ba66
    Bug: 889568
    Reviewed-on: https://chromium-review.googlesource.com/1258296
    Commit-Queue: Preston Carpenter <timidger@google.com>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Joe Mason <joenotcharles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596254}

    Changed files

    • components/chrome_cleaner/public/interfaces/chrome_prompt.mojom
  31. Add dropdown to select authentication method for Smb Share

    Changed by baileyberroohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:57:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 877850b330762b3cc3e7be95648f722722f6ea93

    Comments

    Add dropdown to select authentication method for Smb Share
    
    - Adds a dropdown to select authentication method that is only visible
    to chromad users.
    - This change has no effect on non-chromad users
    - The KerberosAuthentication_ boolean will be passed to
    SmbService::Mount in a following CL
    
    Bug: chromium:853803
    Change-Id: Icc9ec65a4eb0ae20e90088f2767c7fda17578a0a
    Reviewed-on: https://chromium-review.googlesource.com/1191923
    Commit-Queue: Bailey Berro <baileyberro@chromium.org>
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596257}

    Changed files

    • chrome/app/settings_strings.grdp
    • chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
    • chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/smb_shares_page_tests.js
  32. Roll src/third_party/webrtc d136b2884e0d..f9d38f2e4e5d (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 16:56:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2056611ca7d81b33c020955fa8d9463784e264a

    Comments

    Roll src/third_party/webrtc d136b2884e0d..f9d38f2e4e5d (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d136b2884e0d..f9d38f2e4e5d
    
    
    git log d136b2884e0d..f9d38f2e4e5d --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 hans@chromium.org Fix -Wdefaulted-function-deleted warning in StreamPrioKey
    2018-10-03 saza@webrtc.org Replace leftover usage of old AEC interfaces
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@f9d38f2e4e5d
    
    The AutoRoll server is located here: https://autor
    ...skip...
    YBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:890307
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I4c21e96c13d25cbcf65df39270276bac705b9cf2
    Reviewed-on: https://chromium-review.googlesource.com/1257718
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596255}

    Changed files

    • DEPS
  33. Add CORE_EXPORT to LayoutNGMixin explicit instantiations

    Changed by tzikohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 16:58:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9644c5ccf8bbdb86e607805bb0568c1a794e3d1

    Comments

    Add CORE_EXPORT to LayoutNGMixin explicit instantiations
    
    This adds the explicit instantiation declarations of LayoutNGMixin, and
    adds the CORE_EXPORT to the instantiation definitions, so that it's not
    instantiated in the test binaries, and is instantiated in the libcore
    with the proper visibility.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: If51cda70ab619b178ca53c1fcbad8019fafc3c0b
    Reviewed-on: https://chromium-review.googlesource.com/1258806
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596258}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.h
  34. CryptAuthDeviceManager: correctly migrate old SoftwareFeature prefs.

    Changed by hansberryohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:13:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7a68aaef311d65588fcda5407c351dcb0d6a2c8

    Comments

    CryptAuthDeviceManager: correctly migrate old SoftwareFeature prefs.
    
    When SoftwareFeatures were changed to be stored in prefs as strings
    instead of as ints [1], CryptAuthDeviceManagerImpl failed to also
    migrate old int prefs to the new string representation when the prefs
    were desrialized. This caused all devices migrating from M69 to a newer
    release to believe none of their synced devices had any
    SoftwareFeatures until another sync occurred.
    
    1) https://chromium-review.googlesource.com/c/chromium/src/+/1145588
    
    Bug: 888031
    Change-Id: Icd666106d6ebd4db5620cfab0dac459ef67df23e
    Reviewed-on: https://chromium-review.googlesource.com/1258515
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596263}

    Changed files

    • components/cryptauth/cryptauth_device_manager_impl.cc
    • components/cryptauth/cryptauth_device_manager_impl_unittest.cc
  35. [EoS] Add the "X-google-Chrome-Experiment-Tag" header when needed.

    Changed by petewilohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:03:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63a9c85e9745097a79e9e434ab46acd411e1c39c

    Comments

    [EoS] Add the "X-google-Chrome-Experiment-Tag" header when needed.
    
    When a finch experiment sets the override country for an instance
    of chrome, pass along that override country in the request headers
    to the server to get the catalog.
    
    Add logging
    
    
    Add experiment flag
    
    Change-Id: I16f94892c3fa9445af2290fd1c62d5c11be11374
    Reviewed-on: https://chromium-review.googlesource.com/1258058
    Reviewed-by: Justin DeWitt <dewittj@chromium.org>
    Commit-Queue: Peter Williamson <petewil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596259}

    Changed files

    • chrome/browser/android/explore_sites/explore_sites_fetcher.cc
    • chrome/browser/android/explore_sites/explore_sites_fetcher_unittest.cc
  36. Display formatted origin at top of download notification when provided

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:07:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c8d1ba73724b172b4a1d3d7edf80536d3e87fed

    Comments

    Display formatted origin at top of download notification when provided
    
    The origin will be set if provided to the OfflineItem a non-incognito profile.
    screenshot: https://lh3.googleusercontent.com/-BCLL-YuqB28/W6j_XbF542I/AAAAAAAABLA/Mq7jMbOdDdAPPZh-rfFVbDx7JIfLTKlEACL0BGAYYCw/h261/2018-09-24.png
    
    Bug: 774612
    Change-Id: I34aa8fa51195443a242e4bd6e068d2d408737fbb
    Reviewed-on: https://chromium-review.googlesource.com/1240304
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596260}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationService2Test.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService2.java
    • chrome/browser/background_fetch/background_fetch_browsertest.cc
    • chrome/browser/background_fetch/background_fetch_delegate_impl.cc
  37. Use base::EraseIf() instead of erase(std::remove_if()) in content/

    Changed by yeonwoo.jo.92ohnoyoudont@gmail.com
    Changed at Wednesday, 03-Oct-18 17:10:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 095a273ae893a11528a2a19dbf23dbbdd1e0d8e8

    Comments

    Use base::EraseIf() instead of erase(std::remove_if()) in content/
    
    This patch simplifies conditions around the code in content/.
    
    Bug: 875665
    Change-Id: I52e639adce40a86e20304ee64c52d3b399c39841
    Reviewed-on: https://chromium-review.googlesource.com/1215147
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#596261}

    Changed files

    • AUTHORS
    • content/browser/media/media_internals.cc
    • content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
    • content/browser/renderer_host/media/media_devices_manager.cc
    • content/browser/webrtc/webrtc_depth_capture_browsertest.cc
    • content/browser/webrtc/webrtc_webcam_browsertest.cc
    • content/renderer/media/audio/audio_renderer_sink_cache_impl.cc
    • content/renderer/media/webrtc/webrtc_audio_renderer.cc
    • content/test/web_contents_observer_sanity_checker.cc
  38. Roll src/third_party/skia 55aea84baa53..49fdd7ad1875 (6 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 17:14:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e3fda3318564ac6316ee6ffe0356acc943059ad

    Comments

    Roll src/third_party/skia 55aea84baa53..49fdd7ad1875 (6 commits)
    
    https://skia.googlesource.com/skia.git/+log/55aea84baa53..49fdd7ad1875
    
    
    git log 55aea84baa53..49fdd7ad1875 --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 jvanverth@google.com Bundle shared SkImage_Gpu methods.
    2018-10-03 caryclark@google.com fix bookmaker nightly
    2018-10-03 reed@google.com play with animated gif
    2018-10-03 bsalomon@google.com Remove unused macro SK_DONT_DROP_UNNECESSARY_AA_IN_TEXTURE_OP
    2018-10-03 skia-recre
    ...skip...
    ts_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    TBR=mtklein@chromium.org
    
    Change-Id: Id35569ef3781394f4c5f08697ceb040fb8866b25
    Reviewed-on: https://chromium-review.googlesource.com/1257717
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596264}

    Changed files

    • DEPS
  39. Include origin in background fetch desktop download notifications

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:11:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ec6816b0fd871e2561f2e57ce29cc2741e68a227

    Comments

    Include origin in background fetch desktop download notifications
    
    The origin will be displayed in the status section of the notification.
    Very long origins will be elided to display the eTLD+1.
    
    Screenshots:
    https://lh3.googleusercontent.com/-eFfCFlWJf3Y/W7NlhkLY07I/AAAAAAAABMw/_RhaEe6jlnM1X-xXfsIoZ7uyJOnfd6JngCL0BGAYYCw/h48/desktoporigin1.png
    https://lh3.googleusercontent.com/-TiCAYHS9hfg/W7Nlep2HgkI/AAAAAAAABMk/cG6uFKK8sBcc8P-cmy9HtqEZHTp_2S2hgCL0BGAYYCw/h50/desktoporiginevil.png
    
    Bug: 774612
    Change-Id: Iacd874b5fd03f3e6e37c204e9df9e4cbaba67435
    Reviewed-on: https://chromium-review.googlesource.com/1256943
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596262}

    Changed files

    • chrome/browser/download/download_ui_model.cc
    • chrome/browser/download/download_ui_model.h
    • chrome/browser/download/offline_item_model.cc
    • chrome/browser/download/offline_item_model.h
    • chrome/browser/ui/views/download/download_item_view.cc
    • chrome/browser/ui/views/download/download_item_view.h
  40. Enable "Turn on/off night mode" query on Assistant.

    Changed by meilinwohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 17:22:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e3ba8f504fb9a4e64cd1b254df290f583e098b2

    Comments

    Enable "Turn on/off night mode" query on Assistant.
    
    Add SetNightLightEnabled function in mojom::DeviceActions.
    Call this function in assistant_manager_service_impl.cc to
    enable/disable Night Light mode when query comes.
    
    Test: local compile and manually test.
    Bug: b:112698292
    Change-Id: Id4ae0ed07fc2bc1197c0b702fd14c46284d1ba33
    Reviewed-on: https://chromium-review.googlesource.com/1256216
    Commit-Queue: Meilin Wang <meilinw@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596266}

    Changed files

    • chrome/browser/ui/ash/assistant/device_actions.cc
    • chrome/browser/ui/ash/assistant/device_actions.h
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/public/mojom/assistant.mojom
    • chromeos/services/assistant/service_unittest.cc
  41. Add static method to allow creating global SystemNetworkContextManager on demand

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:28:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8caab1dc729f94fe62d1ba3b5bb9ffecf03f57be

    Comments

    Add static method to allow creating global SystemNetworkContextManager on demand
    
    When running network service without launching full browser process,
    ChromeContentBrowserClient::OnNetworkServiceCreated() will be called
    without g_browser_process. This CL allows us to create
    SystemNetworkContextManager on demand and services depending on the
    network service can call SystemNetworkContextManager::GetInstance()
    to access it.
    
    BUG=866028
    
    Change-Id: I9a557921e1bb164ecd62c766dd698137498c0a47
    Reviewed-on: https://chromium-review.googlesource.com/1256207
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596269}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/browser_process_impl.h
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_feature_list_creator.h
    • chrome/browser/net/system_network_context_manager.cc
    • chrome/browser/net/system_network_context_manager.h
  42. Add a flag to OfflineItem for showing the origin in notifications.

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:20:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 117f07a4f90f4169a43320158279b870f93a7d46

    Comments

    Add a flag to OfflineItem for showing the origin in notifications.
    
    Background Fetch notifications should always show the origin in the
    notification. In order to not break the behavior of other download
    notifications, a flag was added to OfflineItem to show the origin.
    
    Bug: 774612
    Change-Id: I2f08e7e7d71a6520d02443a0961733d173242372
    Reviewed-on: https://chromium-review.googlesource.com/1259011
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596265}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService2.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUpdate.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier2.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationService2Test.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService2.java
    • chrome/browser/background_fetch/background_fetch_delegate_impl.cc
    • chrome/browser/download/offline_item_model.cc
    • components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/OfflineItem.java
    • components/offline_items_collection/core/android/java/src/org/chromium/components/offline_items_collection/bridges/OfflineItemBridge.java
    • components/offline_items_collection/core/android/offline_item_bridge.cc
    • components/offline_items_collection/core/offline_item.cc
    • components/offline_items_collection/core/offline_item.h
    • components/offline_items_collection/core/test_support/offline_item_test_support.cc
  43. [desktopCapture] stop capture when screen is locked.

    Changed by braveyaoohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:37:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab81ed65a4d788b68cccfa6c25817864bf9c9a50

    Comments

    [desktopCapture] stop capture when screen is locked.
    
    To support the implementation of getDisplayMedia() API in chromium, it's
    required to stop screensharing when screen is locked on desktop platforms.
    
    This cl is to add an interface to observe the screen lock event into
    content/browser and let VideoCaptureManager stop desktopCapture sessions
    on screenlock event.
    
    Note: It's done on Win/OSX/CrOS at present. Still tring to find a solid
    way on Linux.
    
    Bug: 887585
    Change-Id: Ibe65d51c68e07f632a851f22d2ba6777a527204d
    Reviewed-on: https://chromium-review.googlesource.com/1241160
    Reviewed-by: Christian Fremerey <chfremer@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Weiyong Yao <braveyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596273}

    Changed files

    • chrome/browser/chromeos/chrome_browser_main_chromeos.cc
    • content/browser/BUILD.gn
    • content/browser/DEPS
    • content/browser/browser_main_loop.cc
    • content/browser/browser_main_loop.h
    • content/browser/renderer_host/media/media_devices_dispatcher_host.cc
    • content/browser/renderer_host/media/media_devices_manager.cc
    • content/browser/renderer_host/media/media_stream_manager.cc
    • content/browser/renderer_host/media/video_capture_manager.cc
    • content/browser/renderer_host/media/video_capture_manager.h
    • content/browser/renderer_host/media/video_capture_manager_unittest.cc
    • content/browser/screenlock_monitor/OWNERS
    • content/browser/screenlock_monitor/screenlock_monitor.cc
    • content/browser/screenlock_monitor/screenlock_monitor.h
    • content/browser/screenlock_monitor/screenlock_monitor_device_source.cc
    • content/browser/screenlock_monitor/screenlock_monitor_device_source.h
    • content/browser/screenlock_monitor/screenlock_monitor_device_source_chromeos.cc
    • content/browser/screenlock_monitor/screenlock_monitor_device_source_mac.mm
    • content/browser/screenlock_monitor/screenlock_monitor_device_source_win.cc
    • content/browser/screenlock_monitor/screenlock_monitor_source.cc
    • content/browser/screenlock_monitor/screenlock_monitor_source.h
    • content/browser/screenlock_monitor/screenlock_monitor_unittest.cc
    • content/public/browser/BUILD.gn
    • content/public/browser/screenlock_observer.h
    • content/public/common/media_stream_request.cc
    • content/public/common/media_stream_request.h
    • content/test/BUILD.gn
  44. Chrome can pick ARC++ tree depending on source_id.

    Changed by katieohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:39:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae9ffb0b21833eb464b9acd4c6c614dc94290b1

    Comments

    Chrome can pick ARC++ tree depending on source_id.
    
    This will allow us to pass more AccessibilityNodeInfoDatas even
    if they belong to different windows, which is part of the upgrade
    path planned for mapping ARC++ windows to Chrome OS.
    See go/a11y-arc++-window-mapping > Upgrade path for more.
    
    Bug: 891483
    Change-Id: Ic7a1654691cec6d4229898d7d7aaeb3947953234
    Reviewed-on: https://chromium-review.googlesource.com/1258207
    Commit-Queue: Katie Dektar <katie@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Reviewed-by: Yuki Awano <yawano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596276}

    Changed files

    • chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc.cc
    • chrome/browser/chromeos/arc/accessibility/ax_tree_source_arc_unittest.cc
  45. Update Flash plugin metadata versions to latest version.

    Changed by wfhohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:40:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6abf66cbaae667d7b95b5b74a0a0034c7a6830e6

    Comments

    Update Flash plugin metadata versions to latest version.
    
    https://helpx.adobe.com/security/products/flash-player/apsb18-31.html
    
    BUG=412078
    TBR=jschuh@chromium.org
    
    Change-Id: If664b6a520360177c8cdfd25dd0025eaf8664ec3
    Reviewed-on: https://chromium-review.googlesource.com/1259204
    Reviewed-by: Will Harris <wfh@chromium.org>
    Commit-Queue: Will Harris <wfh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596277}

    Changed files

    • chrome/browser/resources/plugin_metadata/plugins_linux.json
    • chrome/browser/resources/plugin_metadata/plugins_mac.json
    • chrome/browser/resources/plugin_metadata/plugins_win.json
  46. Add paint and parser benchmarks for layoutng

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:31:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef5063ca49f180e80fd154b761fc72deb41da4a9

    Comments

    Add paint and parser benchmarks for layoutng
    
    With names "blink_perf.parser_layout_ng" and "blink_perf.paint_layout_ng"
    
    This is useful for running manually and a precondition for running the
    paint test suite on the bot.
    
    R=eae@chromium.org, kojii@chromium.org
    
    Change-Id: I6437113221a591e2c244efe0f8780b6e29923be7
    Reviewed-on: https://chromium-review.googlesource.com/1259122
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596270}

    Changed files

    • tools/perf/contrib/blink_layoutng_perf/blink_layoutng_perf.py
  47. Consolidate font adjustment into PlatformFontWin.

    Changed by dfriedohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:39:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8abd68396d3599abe18fa5797ec6dff2f8f68fad

    Comments

    Consolidate font adjustment into PlatformFontWin.
    
    Also fixes a bug where tooltips in Hindi and other languages that use
    custom font sizes would revert when the window DPI changes.
    
    Bug: 888788
    Change-Id: I490a425d7bf142ef385462837680dfb34f5ff544
    Reviewed-on: https://chromium-review.googlesource.com/1250211
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Commit-Queue: Dana Fried <dfried@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596275}

    Changed files

    • chrome/browser/chrome_browser_main_win.cc
    • ui/base/BUILD.gn
    • ui/base/l10n/l10n_util_win.cc
    • ui/base/l10n/l10n_util_win.h
    • ui/base/l10n/l10n_util_win_unittest.cc
    • ui/display/win/dpi.cc
    • ui/display/win/dpi.h
    • ui/gfx/platform_font_win.cc
    • ui/gfx/platform_font_win.h
    • ui/gfx/platform_font_win_unittest.cc
    • ui/views/corewm/tooltip_win.cc
    • ui/views/corewm/tooltip_win.h
  48. Remove pre-refresh code in browser frame.

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:41:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f33d9eb9f73c344a1636291d8a3a05eae0e4df07

    Comments

    Remove pre-refresh code in browser frame.
    
    Bug: none
    Change-Id: I1968359861e40606e6c7336ad7a80371224da76e
    Reviewed-on: https://chromium-review.googlesource.com/1255632
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596278}

    Changed files

    • chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc
    • chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_browsertest.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
    • chrome/browser/ui/views/frame/browser_root_view.cc
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/frame/browser_view_unittest.cc
    • chrome/browser/ui/views/frame/glass_browser_frame_view.cc
    • chrome/browser/ui/views/frame/glass_browser_frame_view.h
    • chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
    • chrome/browser/ui/views/frame/opaque_browser_frame_view.h
    • chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
    • chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h
    • chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
    • chrome/browser/ui/views/status_bubble_views.cc
    • chrome/browser/ui/views/status_bubble_views.h
  49. [Autofill Settings] Hide 'Add' button when Autofill toggle is disabled

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:37:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1cef206244b29575391e471c2a11a052d993bcbb

    Comments

    [Autofill Settings] Hide 'Add' button when Autofill toggle is disabled
    
    Screenshots can be found in the bug.
    
    Bug: 891369
    Change-Id: I206d89a1118cad0f65c17ba3cafee81998e3198c
    Reviewed-on: https://chromium-review.googlesource.com/1258046
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596272}

    Changed files

    • chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
    • chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
    • chrome/test/data/webui/settings/autofill_section_test.js
    • chrome/test/data/webui/settings/payments_section_test.js
  50. [TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:38:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b798e975c6cdb02dee93bdaf184276ad21d4be9

    Comments

    [TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks.
    
    This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api/braille_display_private.
    
    This CL was created by replacing calls to AssertBlockingAllowed()
    with instantiations of ScopedBlockingCall(MAY_BLOCK).
    I kindly ask the reviewer to make sure of the following:
      - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
        If this is not the case, ScopedBlockingCall should be instantiated
        
    ...skip...
     the entirety of the blocking operation
        previously asserted against by the AssertBlockingAllowed().
    
    This CL was uploaded by git cl split.
    
    R=aboxhall@chromium.org
    
    Bug: 874080
    Change-Id: I3f749884b51d34136fff66d253ef71e2be34a335
    Reviewed-on: https://chromium-review.googlesource.com/1191233
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596274}

    Changed files

    • chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc
  51. Navi: Update NUX Google Apps Icons to be higher resolution.

    Changed by hcarmonaohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:26:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbd8eb77522398bd1ac80e4b1ed09c060a47c6e6

    Comments

    Navi: Update NUX Google Apps Icons to be higher resolution.
    
    Bug: 874118
    Change-Id: Id5e57c2667e1b7c1b8f11a132a51c1ecc377a444
    Reviewed-on: https://chromium-review.googlesource.com/1246153
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Hector Carmona <hcarmona@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596268}

    Changed files

    • chrome/browser/browser_resources.grd
    • chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/chrome_store_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/gmail_24dp_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/maps_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/maps_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/maps_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/news_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/news_24dp_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/news_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/translate_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/translate_24dp_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/translate_2x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/youtube_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/youtube_24dp_1x.png
    • chrome/browser/resources/welcome/onboarding_welcome/images/youtube_2x.png
    • chrome/browser/ui/webui/welcome/nux/google_apps_handler.cc
  52. Revert "rebaseline_cl.py: Set step_name when retrieving results"

    Changed by martinissohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:26:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8a45f3a11bdc7dd332b8d00c8a99f0e0da01dbf

    Comments

    Revert "rebaseline_cl.py: Set step_name when retrieving results"
    
    This reverts commit cc86e6e56f06e78bea4f366c3200388bff7e263a.
    
    Reason for revert: https://crbug.com/891729, didn't account for strange step names.
    
    Original change's description:
    > rebaseline_cl.py: Set step_name when retrieving results
    > 
    > Layout test results are now uploaded into a directory indicating which
    > step name they were run as. This is to allow for without patch runs to
    > be recorded for analytics. This CL changes rebaselin
    ...skip...
    @chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#595949}
    
    TBR=qyearsley@chromium.org,dpranke@chromium.org,martiniss@chromium.org,robertma@chromium.org
    
    Change-Id: Ib5a73d70e234f73312bb32db7189ea9cdd43c185
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 882946, 891729
    Reviewed-on: https://chromium-review.googlesource.com/1259282
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596267}

    Changed files

    • third_party/blink/tools/blinkpy/common/net/buildbot.py
    • third_party/blink/tools/blinkpy/common/net/buildbot_unittest.py
    • third_party/blink/tools/blinkpy/tool/commands/rebaseline_cl.py
    • third_party/blink/tools/blinkpy/tool/commands/rebaseline_cl_unittest.py
    • third_party/blink/tools/blinkpy/web_tests/try_flag_unittest.py
  53. Add a LayoutNG version of the loading.{desktop,mobile} benchmarks

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:46:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 737b0a6f527f871e7e5a4a5889887f5534e9f61a

    Comments

    Add a LayoutNG version of the loading.{desktop,mobile} benchmarks
    
    R=eae@chromium.org, kojii@chromium.org
    
    Change-Id: I78bda450dd122b256495b33489dc8bfb7b39fb15
    Reviewed-on: https://chromium-review.googlesource.com/1259125
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596279}

    Changed files

    • tools/perf/contrib/blink_layoutng_perf/loading_layout_ng.py
  54. Roll src/third_party/angle c3bef3e7b028..c2116cd3af9f (1 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 17:48:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76a489a4f5e674887b06c9c959054d7c6ce36b6b

    Comments

    Roll src/third_party/angle c3bef3e7b028..c2116cd3af9f (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/c3bef3e7b028..c2116cd3af9f
    
    
    git log c3bef3e7b028..c2116cd3af9f --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 jmadill@chromium.org Vulkan: Update pipeline barrier interface.
    
    
    Created with:
      gclient setdep -r src/third_party/angle@c2116cd3af9f
    
    The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll
    
    Documentation for the AutoRoller is 
    ...skip...
    s_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: Idcd29fe0d40b4bcdde37947b2b0d10523a79dd31
    Reviewed-on: https://chromium-review.googlesource.com/1259104
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596281}

    Changed files

    • DEPS
  55. Fix paste without style on macOS.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:48:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa42ff1dce7ed21b555f67cb4f046aa9f5aa5344

    Comments

    Fix paste without style on macOS.
    
    NSViews in Views need to implement pasteAndMatchStyle:.
    
    The IDS_PASTE_MATCH_STYLE_MAC main menu item had the wrong key equivalent.
    
    Bug: 882166
    Change-Id: I0ba029afddaab8e155d5cfadaccadf2c231a3e79
    Reviewed-on: https://chromium-review.googlesource.com/1255864
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596280}

    Changed files

    • chrome/browser/ui/cocoa/main_menu_builder.mm
    • ui/views_bridge_mac/bridged_content_view.mm
  56. [webrtc] Add missing header in client code.

    Changed by yvesgohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 17:49:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49b8448a3740504d371c302bef14e50c3c228519

    Comments

    [webrtc] Add missing header in client code.
    
    We were relying on brittle transitive #include.
    
    Bug: webrtc:8311
    Change-Id: Ib67aef5ebead73cc7b9783c1bbc48fb53c332f3e
    Reviewed-on: https://chromium-review.googlesource.com/1258912
    Commit-Queue: Florent Castelli <orphis@chromium.org>
    Reviewed-by: Florent Castelli <orphis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596282}

    Changed files

    • content/renderer/media/webrtc/media_stream_remote_video_source.cc
  57. Run two more layoutng benchmarks on linux-perf-fyi

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 17:50:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa11ee7025b6716a83324b2b6238c8fcf0c86653

    Comments

    Run two more layoutng benchmarks on linux-perf-fyi
    
    Added in https://crrev.com/c/1259122 and https://crrev.com/c/1259125
    
    Change-Id: I7122d66620dd04ba3f14036177a180bd4a26315d
    Reviewed-on: https://chromium-review.googlesource.com/1259162
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Chong Zhang <chongz@chromium.org>
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596283}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  58. cros: Remove unnecessary timer in LockScreen

    Changed by wzangohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:01:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a27c0fc2a2ee6d7fad437ff892302727b4de339

    Comments

    cros: Remove unnecessary timer in LockScreen
    
    The timer was added for the fear that the wallpaper animation
    completion is never received. In fact, it's guaranteed to be received.
    
    In case there's a decoder issue (more info in the bug) that wallpaper
    decoding takes more than 5 sec:
    
    1) If keeping the timer, the user pods will be shown on top of the
       white boot splash screen, which looks buggy.
    2) If removing the timer, the user pods will show together with the
       wallpaper. The boot experience feels slow but still smooth.
    
    So IMO the best solution is to remove the timer as well as trying to
    fix the decoder issue.
    
    Bug: 890935
    Change-Id: I685a0065acae99ebccd2734dcebd9dce2f563dbb
    Reviewed-on: https://chromium-review.googlesource.com/1255903
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596284}

    Changed files

    • ash/login/ui/lock_screen.cc
    • ash/login/ui/lock_screen.h
    • ash/login/ui/login_keyboard_test_base.cc
  59. [LayoutNG] Mark LayoutNGMixin functions as final when possible

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:13:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a2a07e4a46d9fe8a9c1c14af2bf30d601d99304

    Comments

    [LayoutNG] Mark LayoutNGMixin functions as final when possible
    
    Some override functions in LayoutNGMixin are not to be
    overridden further. This patch marks them as 'final' so that
    calling them from inside of LayoutNGMixin or its subclasses
    can make non-virtual calls.
    
    No behavior changes.
    
    Bug: 635619
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I97e65d70cbe34b6757ab129c62e37bdaddcda72e
    Reviewed-on: https://chromium-review.googlesource.com/1258664
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596285}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_mixin.h
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_item.h
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
  60. Roll src/third_party/webrtc f9d38f2e4e5d..7988589e4858 (4 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 18:19:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 83ec345b50628f0b21fbc277b7c338f8b006ad6b

    Comments

    Roll src/third_party/webrtc f9d38f2e4e5d..7988589e4858 (4 commits)
    
    https://webrtc.googlesource.com/src.git/+log/f9d38f2e4e5d..7988589e4858
    
    
    git log f9d38f2e4e5d..7988589e4858 --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 benwright@webrtc.org Add missing headers to new objective-c API.
    2018-10-03 steveanton@webrtc.org Add jeroendb@ and shampson@ as media/sctp/ OWNERS
    2018-10-03 peah@webrtc.org Hooked up the control of the adaptive AGC2 mode in audioproc_f
    2018-10-03 danilchap@webrtc.org S
    ...skip...
    TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I8527696381db4210640cea3564b271995dadb30a
    Reviewed-on: https://chromium-review.googlesource.com/1257721
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596289}

    Changed files

    • DEPS
  61. [ChromeDriver] Add negative filter for specific os and version

    Changed by buldinaohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:15:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a977d165c51e530de072b45caadf796e7b692a82

    Comments

    [ChromeDriver] Add negative filter for specific os and version
    
    Bug: chromedriver:1408
    Change-Id: Ia317f5e00e2b55092c2423f836eb5d04debfedb2
    Reviewed-on: https://chromium-review.googlesource.com/1258086
    Reviewed-by: John Chen <johnchen@chromium.org>
    Commit-Queue: Tatiana Buldina <buldina@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596286}

    Changed files

    • chrome/test/chromedriver/test/run_py_tests.py
  62. tcmalloc: Add generic.total_physical_bytes property to MallocExtension

    Changed by gmxohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:15:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d467a6a943d7af4f63bea2c350e1cad1dac05489

    Comments

    tcmalloc: Add generic.total_physical_bytes property to MallocExtension
    
    Original CL:
    
    - https://codereview.chromium.org/1410353005
    
      Add generic.total_physical_bytes property to MallocExtension
    
      The actual physical memory usage of tcmalloc cannot be obtained by
      GetNumericProperty. This accounts for the current_allocated_bytes,
      fragmentation and malloc metadata, and excludes the unmapped memory
      regions. This helps the user to understand how much memory is actually
      being used for the allocati
    ...skip...
     in
      CL: www.crrev.com/10499004.
    
      This is to be used by malloc dump provider for tracing.
    
      BUG=546491
      Committed: https://crrev.com/0752ec9c6adf641985db1a3a224bf9b8e32e4ac8
      Cr-Commit-Position: refs/heads/master@{#357155}
    
    BUG=724399,b:70905156
    
    Change-Id: I68ae586aacf2f2c1ab09721716b9093d402d649c
    Reviewed-on: https://chromium-review.googlesource.com/1130803
    Reviewed-by: Will Harris <wfh@chromium.org>
    Commit-Queue: Gabriel Marin <gmx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596287}

    Changed files

    • third_party/tcmalloc/chromium/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/chromium/src/tcmalloc.cc
  63. Use network::mojom::CookieManager in SiteDataCountingHelper tests

    Changed by reillygohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 18:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9417920fac8d8dba55cf1c4a5b6b31759a369172

    Comments

    Use network::mojom::CookieManager in SiteDataCountingHelper tests
    
    This is a follow-up to r556547 and updates the unit tests for
    SiteDataCountingHelper to use the network::mojom::CookieManager
    interface.
    
    Bug: 823297
    Change-Id: I41914390a0efc33e5ee9a2fdeca628ff1a1c5f84
    Reviewed-on: https://chromium-review.googlesource.com/1258246
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Commit-Queue: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596292}

    Changed files

    • chrome/browser/browsing_data/counters/site_data_counting_helper_unittest.cc
  64. macOS: Treat cmd + '+' as cmd + '1' on Czech keyboard layouts.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:17:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc6dc8cb9e1587adacdabdb6ebe75070c9def92

    Comments

    macOS: Treat cmd + '+' as cmd + '1' on Czech keyboard layouts.
    
    This results in more intuitive behavior of Chrome with respect to tab switching
    shortcuts.
    
    Bug: 889424
    Change-Id: I1ccba5141a3ddbfd2391d2d40e0d5884b50a382f
    Reviewed-on: https://chromium-review.googlesource.com/1259244
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596288}

    Changed files

    • chrome/browser/ui/cocoa/nsmenuitem_additions.h
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
  65. [WPT export] Set git user in tmp WPT checkout

    Changed by robertmaohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:19:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34af3640d1d6aaf1030fbc972848628e2a3e6f24

    Comments

    [WPT export] Set git user in tmp WPT checkout
    
    Builders don't (and shouldn't) have global git user name/email
    configured, and the recipe only configures git user in the Chromium
    checkout (the recipe doesn't know about the tmp WPT checkout). When git
    user cannot be found (neither in the repo or globally), `git commit`
    will fail. (Previously, we didn't notice the issue on BuildBot because
    the bot had some leftover global configurations from an earlier version
    of the recipe.)
    
    To make sure we always have
    ...skip...
    y because GitHub
    allows committers to be different from the uploader.
    
    Besides, remove an unnecessary pair of quotes in a format string for
    `git show`; we don't use shell to start subprocesses so spaces don't
    need to be quoted.
    
    Bug: 803111
    Change-Id: Ife020c8a18120ff607b8802c32cf9539bf6a36c9
    Reviewed-on: https://chromium-review.googlesource.com/1258977
    Commit-Queue: Robert Ma <robertma@chromium.org>
    Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596290}

    Changed files

    • third_party/blink/tools/blinkpy/w3c/chromium_commit.py
    • third_party/blink/tools/blinkpy/w3c/common.py
    • third_party/blink/tools/blinkpy/w3c/local_wpt.py
    • third_party/blink/tools/blinkpy/w3c/local_wpt_unittest.py
    • third_party/blink/tools/blinkpy/w3c/test_exporter_unittest.py
  66. Migrate WaitForNetworkCallbackHelper to NetworkConnectionTracker

    Changed by rmcelrathohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:24:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc2a716c2459cae47dfb1916b55e3c7bb6417c2c

    Comments

    Migrate WaitForNetworkCallbackHelper to NetworkConnectionTracker
    
    This migrates WaitForNetworkCallbackHelper from NetworkChangeNotifier
    to NetworkConnectionTracker, which works with the network service
    enabled.
    
    Bug: 887056
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I70cc4863630ffbbd808ed91f5b4cee7dcc003296
    Reviewed-on: https://chromium-review.googlesource.com/1239261
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596291}

    Changed files

    • components/signin/ios/DEPS
    • components/signin/ios/browser/wait_for_network_callback_helper.cc
    • components/signin/ios/browser/wait_for_network_callback_helper.h
    • components/signin/ios/browser/wait_for_network_callback_helper_unittest.cc
    • ios/chrome/browser/signin/ios_chrome_signin_client.mm
    • ios/web_view/internal/signin/ios_web_view_signin_client.mm
  67. Roll src/third_party/skia 49fdd7ad1875..f1709049243e (2 commits)

    Changed by chromium-autorollohnoyoudont@skia-public.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 18:35:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0e65690d8dc687c69874f1d012a9f39f31d0e026

    Comments

    Roll src/third_party/skia 49fdd7ad1875..f1709049243e (2 commits)
    
    https://skia.googlesource.com/skia.git/+log/49fdd7ad1875..f1709049243e
    
    
    git log 49fdd7ad1875..f1709049243e --date=short --no-merges --format='%ad %ae %s'
    2018-10-03 bsalomon@google.com Move integer rect checks from GrRenderTarget::drawTexture to GrTextureOp
    2018-10-03 mtklein@google.com Revert "Reland "Always include public/include headers for vulkan and just guard src files with SK_VULKAN.""
    
    
    Created with:
      gclient setdep -r src/thi
    ...skip...
    try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    
    BUG=chromium:862144
    TBR=mtklein@chromium.org
    
    Change-Id: I072cdf9b67cfb8174017bb2c145d4c0d2ec94976
    Reviewed-on: https://chromium-review.googlesource.com/1259263
    Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596294}

    Changed files

    • DEPS
  68. Test workaround for bug with split APK handling on O.

    Changed by torneohnoyoudont@google.com
    Changed at Wednesday, 03-Oct-18 18:34:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d39760b5491c756a7272df122ad280b2da9f07d

    Comments

    Test workaround for bug with split APK handling on O.
    
    Android O's WebView zygote code doesn't handle split APKs correctly when
    preloading the code for the current WebView implementation, creating an
    incorrect entry in the Java classloader cache. This causes a crash when
    the renderer process initializes, since it tries to load the native
    library into two different classloaders as a result, which is not
    permitted.
    
    We're hoping to work around this using reflection to correct the cache
    entry during the 
    ...skip...
    e
    reflection but not actually change anything - if the reflection fails
    due to a framework change, it will catch the exception instead of
    crashing, and simply record that in a static variable which can later be
    logged with UMA.
    
    Bug: 891452
    Change-Id: I41dabb9c4cb4151676229a07abd37c803dbc3967
    Reviewed-on: https://chromium-review.googlesource.com/1255388
    Commit-Queue: Richard Coles <torne@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596293}

    Changed files

    • android_webview/glue/BUILD.gn
    • android_webview/glue/java/src/com/android/webview/chromium/SplitApkWorkaround.java
    • android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
  69. cros: Skip UserSessionManager::UpdateEasyUnlockKeys when using PIN

    Changed by wzangohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:35:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f26b3a8d7e32ee9b257dd5819344aa4e3ee3534c

    Comments

    cros: Skip UserSessionManager::UpdateEasyUnlockKeys when using PIN
    
    Bug: 850250
    Change-Id: I1a7af66367665bcb1577b5c6efc3f2e5d2748113
    Reviewed-on: https://chromium-review.googlesource.com/1171801
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596295}

    Changed files

    • chrome/browser/chromeos/login/session/user_session_manager.cc
  70. Enable only 1 `PartitionAllocZeroFill` optimization.

    Changed by palmerohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:44:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ae88d9a2b7f3ef8b6c0cc263ed484838bdabf48

    Comments

    Enable only 1 `PartitionAllocZeroFill` optimization.
    
    `SlowPathAlloc` has 3 tactics for getting new memory. Of these, only the 1st
    (calling `PartitionDirectMap`) seems to most obviously get a fresh, zeroed page
    from the OS. I think it is safe to optimize in that branch. It might be safe on
    some platforms to optimize in the other 2 branches, but it's less obviously
    safe, and we've had trouble on at least macOS. This CL enables the 1st branch
    but turns off the optimization in the 2nd 2 branches.
    
    Bug: 890752
    Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel
    Change-Id: Ibd9ff599ba78aeab47c2369c472af71a4f71d600
    Reviewed-on: https://chromium-review.googlesource.com/1256211
    Reviewed-by: Albert J. Wong <ajwong@chromium.org>
    Commit-Queue: Chris Palmer <palmer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596297}

    Changed files

    • base/allocator/partition_allocator/partition_bucket.cc
    • base/allocator/partition_allocator/partition_root_base.h
  71. Add DCHECK to main menu builder.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:48:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e8f10472b7f5618c5f31d696b49fdeb0067053c

    Comments

    Add DCHECK to main menu builder.
    
    The shift modifier is *almost* always incorrect to use for menu items -- it is
    instead appropriate to apply the shift modifier directly to the keyEquivalent.
    
    Bug: 882166
    Change-Id: I6507a2a8981241cb1b80a8737213c5ac45fdab2e
    Reviewed-on: https://chromium-review.googlesource.com/1259362
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596299}

    Changed files

    • chrome/browser/ui/cocoa/main_menu_builder.h
  72. Add feature toggles to tune leveldb performance

    Changed by mastizohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:40:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d40bd88ea1758551b06d1c6cf8b15d0791a51616

    Comments

    Add feature toggles to tune leveldb performance
    
    We've seen an increase in Memory.Browser.PrivateMemoryFootprint that is
    suspected to be caused by leveldb use for sync purposes, which is more
    common the more datatypes are migrated to USS.
    
    In order to tune leveldb's memory usage and confirm that recent
    regressions are caused by sync, various feature toggles are introduced.
    By default, there is no behavioral differences.
    
    Bug: 887068
    Change-Id: Idada6be78a39db7ef04ee582ca01b8ed0c427838
    Reviewed-on: https://chromium-review.googlesource.com/1257912
    Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596296}

    Changed files

    • components/sync/model_impl/model_type_store_backend.cc
  73. Fix vietnamese layout to correctly handle cmd + 1.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:46:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe60fb8d3235aa1d3c9f3660e1aa53ec5dbc2527

    Comments

    Fix vietnamese layout to correctly handle cmd + 1.
    
    In vietnamese layout, cmd + [vkeycode=18] does not print any characters. This
    should still be correctly interpretted as a hotkey for cmd + '1'.
    
    Previously, the logic for cr_firesForKeyEvent would early exit when
    charactersIgnoringModifiers had 0 length. Subsequent logic would use characters
    in place of charactersIgnoringModifiers. This CL moves the latter logic before
    the former logic so that if charactersIgnoringModifiers has 0 length, we'll
    instead check characters.
    
    Change-Id: I3fcc45579c7697ca843ef3472fa294fa2da02262
    Bug: 889424
    Reviewed-on: https://chromium-review.googlesource.com/1259342
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596298}

    Changed files

    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
  74. Surface Synchronization: Throttle child synchronization events

    Changed by fsamuelohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:49:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f96f0ea3b55efe11726a463a08e34cee8de57686

    Comments

    Surface Synchronization: Throttle child synchronization events
    
    This CL enables throttling of child synchronization events. In a child-
    initiated synchronization, the child's frame will likely activate
    before the dependent parent's CompositorFrame arrives. Upon activation,
    the child will see that the new surface does not cause any damage to the
    display (because it's not embedded by any parent yet) and calls the
    draw callback immediately, thereby sending back a DidReceiveCompositorFrameAck
    to the clien
    ...skip...
    s are pointless.
    
    This CL throttles DidReceiveCompositorFrameAck of the child on child-initiated
    synchronization events until the parent references the child.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I62416d87f8d871b32f4caad565cff515a9c55445
    Bug: 672962, 879207
    Reviewed-on: https://chromium-review.googlesource.com/1236931
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596300}

    Changed files

    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
    • components/viz/service/frame_sinks/surface_synchronization_unittest.cc
    • components/viz/service/surfaces/surface.cc
    • components/viz/service/surfaces/surface.h
    • components/viz/service/surfaces/surface_dependency_tracker.cc
    • components/viz/service/surfaces/surface_dependency_tracker.h
    • components/viz/service/surfaces/surface_manager.cc
    • components/viz/service/surfaces/surface_manager.h
  75. Roll src-internal 457799c2a3af..5cc52fbcc765 (1 commits)

    Changed by chromium-internal-autorollohnoyoudont@skia-corp.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 03-Oct-18 18:50:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1be7946fa4229eb13ebd355e48fd3e33e3f3bd2

    Comments

    Roll src-internal 457799c2a3af..5cc52fbcc765 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/457799c2a3af..5cc52fbcc765
    
    
    Created with:
      gclient setdep -r src-internal@5cc52fbcc765
    
    The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:891734
    TBR=mmoss@chromium.org
    
    Change-Id: I2531849fbfae321612a79fb6828ea363a93ed5ae
    Reviewed-on: https://chromium-review.googlesource.com/1259262
    Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#596301}

    Changed files

    • DEPS
  76. Fix incognito tab titles on tablet

    Changed by mdjonesohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:52:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c99cbb2ff700e8e8b57be3019e07ce98a856dd55

    Comments

    Fix incognito tab titles on tablet
    
    This patch adds a check for tablet in the logic that decides whether
    a light or dark title is used.
    
    Bug: 891666
    Change-Id: I6f05aa06ef01cd67a1f58a12e6f7436debe74e6b
    Reviewed-on: https://chromium-review.googlesource.com/1259285
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Commit-Queue: Matthew Jones <mdjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596303}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java
  77. Print Preview Refresh: Add tests

    Changed by rbpotterohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:51:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56f8dfd096c2dda28b939332369c53923f617841

    Comments

    Print Preview Refresh: Add tests
    
    Adding/modifying tests to cover some newly tweaked behaviors and a
    recent regression:
    (1) Destinations dialog correctly does not close if escape is pressed
    while in the search box if there is any text, but does close if there
    is no text.
    (2) Copies setting correctly stays valid for an empty input, and the
    input is reset to the default value if blurred. However, if an invalid
    value is explictly entered, the setting does not stay valid or reset
    to the default value when
    ...skip...
     tests. The new interactive test for
    number-settings-section validates the reset/no reset on blur behavior.
    The additions to the SetCopies test verify that the setting value is
    correctly set/not set for the various cases.
    
    Bug: None
    Change-Id: If7e3461c525c9cf057ac9404d5bf5da5da03e9f2
    Reviewed-on: https://chromium-review.googlesource.com/1252339
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596302}

    Changed files

    • chrome/test/data/webui/print_preview/destination_dialog_interactive_test.js
    • chrome/test/data/webui/print_preview/number_settings_section_interactive_test.js
    • chrome/test/data/webui/print_preview/number_settings_section_test.js
    • chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js
    • chrome/test/data/webui/print_preview/print_preview_test_utils.js
    • chrome/test/data/webui/print_preview/settings_section_test.js
    • testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
  78. [sampling heap profiler] Fix accounting for the very first allocation on a thread.

    Changed by alphohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:55:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f823e9e727a40f637a177771ade64b4c2784f425

    Comments

    [sampling heap profiler] Fix accounting for the very first allocation on a thread.
    
    The sampler used to always record the very first allocation on each thread
    because the accumulator is initialized with zero. The patch makes such
    allocations be treates as all the others.
    
    BUG=803276
    
    Change-Id: I3eeec1e069ecc640e6c9756f707dfc336d16e159
    Reviewed-on: https://chromium-review.googlesource.com/1257597
    Commit-Queue: Alexei Filippov <alph@chromium.org>
    Reviewed-by: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596306}

    Changed files

    • base/sampling_heap_profiler/poisson_allocation_sampler.cc
  79. [BGPT] Generate effect node for rotated clip and force render surface

    Changed by wangxianzhuohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:53:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 491d10976dc99e58b57857916ea4ecaadeecee37

    Comments

    [BGPT] Generate effect node for rotated clip and force render surface
    
    Cc requires that a rectangular clip is 2d-axis-aligned with the render
    surface to correctly apply the clip. When we find that a rectangular
    clip is not 2d-axis-aligned with the render surface, we should create
    an effect node and let it create a render surface.
    
    Bug: 890919
    Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6f7b462d5506949d1571c60231e066d27b9a238d
    Reviewed-on: https://chromium-review.googlesource.com/1244104
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596304}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-clip-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-clip-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-clip.html
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-effect-interleave-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-effect-interleave-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-effect-interleave.html
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-z-order-interleave-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-z-order-interleave-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip-z-order-interleave.html
    • third_party/WebKit/LayoutTests/compositing/overflow/rotate-then-clip.html
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/overflow/rotate-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/overflow/rotate-then-clip-effect-interleave-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/overflow/rotate-then-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/overflow/rotate-then-clip-z-order-interleave-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/compositing/overflow/rotate-then-clip-z-order-interleave-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-clip-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-effect-interleave-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-z-order-interleave-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/rotate-then-clip-z-order-interleave-expected.txt
    • third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.cc
    • third_party/blink/renderer/platform/graphics/compositing/property_tree_manager.h
    • third_party/blink/renderer/platform/transforms/transformation_matrix.cc
    • third_party/blink/renderer/platform/transforms/transformation_matrix.h
  80. [Android] Remove explicit tinting of downloads icon

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Wednesday, 03-Oct-18 18:54:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078327509321c024778e46af8a62a76af6c31532

    Comments

    [Android] Remove explicit tinting of downloads icon
    
    This CL fixes the color of the Download icon in the three-dots menu. The
    appearance of this icon was broken by https://crrev.com/c/1245786.
    Apparently, a color filter set on drawable by AppMenuPropertiesDelegate
    overrides ImageView.setImageTintList used by ImageViewCompat on API 21+.
    Fortunately, there's no need to manually tint the drawable, because
    AppCompatImageButton for the Download icon is always tinted. This CL
    removes the manual tinting of the drawable.
    
    Bug: 891645
    Change-Id: I9eb9f326445e044a77fa8802b6816e5bc16e0993
    Reviewed-on: https://chromium-review.googlesource.com/1258987
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596305}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
  81. Override manifest handler registry in ManifestHandlerPerfTest.

    Changed by mharanczykohnoyoudont@opera.com
    Changed at Wednesday, 03-Oct-18 17:35:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40871382b071cef2d3ec5f3884b5722eab3596d8

    Comments

    Override manifest handler registry in ManifestHandlerPerfTest.
    
    MANUAL_CommonMeasureFinalization and MANUAL_CommonInitialize tests
    reseted global registry on exit without initializing it again causing
    random test flakes on tests that operated on manifests that happen to
    run after those two tests (they passed on retry).
    
    Change-Id: I2b4297d33441c72d9cdd099106abad68921c2f6a
    Reviewed-on: https://chromium-review.googlesource.com/1259046
    Commit-Queue: Marek Haranczyk <mharanczyk@opera.com>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596271}

    Changed files

    • extensions/common/manifest_handler_perf_test.cc