Home | Search
Login

Builder Win 7 Perf Build #2885 Microsoft Windows

Results:

build successful

Trigger Info:

Got Revision03427d53dc8e88fbde543f6115708a98c2b9b1f0

Execution:

Steps and Logfiles:

Show:
  1. ( 4 hrs 42 mins ) steps
    running steps via annotated script
  2. ( 17 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 2 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 2 mins 32 secs ) bot_update
    bot_update
    [80GB/349GB used (22%)]
  9. ( 1 ms ) ensure_goma
    ensure_goma
  10. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 23 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_7_Perf\src\testing\buildbot\chromium.perf.json
  15. ( 7 secs ) build directory
    build directory
  16. ( 2 mins 40 secs ) extract build
    extract build
  17. ( 1 ms ) find isolated tests
    find isolated tests
  18. ( 1 ms ) test_pre_run
    test_pre_run
  19. ( 1 ms ) test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  20. ( 7 secs ) test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  21. ( 2 ms ) test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  22. ( 15 secs ) test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  23. ( 1 mins 19 secs ) components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 31s
    Shard duration: 0:01:02.410860
    Total tests: n/a
     
  24. ( 21 secs ) load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:33.115580
    Shard duration: 20s
    Total tests: n/a
     
  25. ( 39 secs ) media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:52.304760
    Shard duration: 35s
    Total tests: n/a
     
  26. ( 4 hrs 32 mins ) performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:02:41.728230 (shard #2)
    Max shard duration: 4:19:51.074180 (shard #1)
    Min shard duration: 3:44:16.279820 (shard #3)
    Total tests: 1034
    * Passed: 944 (944 expected, 0 unexpected)
    * Skipped: 90 (90 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  27. ( 1 ms ) Upload to test-results [performance_test_suite on (102b) GPU on Windows]
    Upload to test-results [performance_test_suite on (102b) GPU on Windows]
  28. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 8
    Total runtime: 19:44:25.386000
     
  29. ( 1 ms ) process_dumps
    process_dumps
  30. ( 1 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_7_Perf/2885/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_7_Perf/2885" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "077cd858b2d4ca7632a585a27846fd6db1752969" Annotation(bot_update)
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" Annotation(bot_update)
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" Annotation(bot_update)
got_revision "03427d53dc8e88fbde543f6115708a98c2b9b1f0" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#582401}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.0.193@{#2}" Annotation(bot_update)
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24263}" Annotation(bot_update)
swarm_hashes {"components_perftests":"9388e936f382665f9cb1433f0a221df0f057c340","load_library_perf_tests":"643c0d9204a730cf3cd937827287b12981c42e52","media_perftests":"6bdb273224fe3cbfdc19598fdcb8577e56ffadd5","performance_test_suite":"81c90ed75e7250bea6834c54223954b1763a55e1"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmpm_0xv4" Annotation(steps)
build_id "buildbot/chromium.perf/Win 7 Perf/2885" Annotation(steps)
builder_id "master.chromium.perf:Win 7 Perf" Annotation(steps)
blamelist ["alemate@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","avi@chromium.org","blink-w3c-test-autoroller@chromium.org","bsazonov@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","cbiesinger@chromium.org","ccameron@chromium.org","chasej@chromium.org","chengx@chromium.org","chili@chromium.org","chrishtr@chromium.org","cliffordcheng@chromium.org","ctzsm@chromium.org","dalecurtis@chromium.org","dewittj@chromium.org","dmblack@google.com","dmurph@chromium.org","donnd@chromium.org","eae@chromium.org","eirage@chromium.org","ekaramad@chromium.org","enne@chromium.org","erikchen@chromium.org","eroman@chromium.org","estade@chromium.org","etienneb@chromium.org","fdoray@chromium.org","gab@chromium.org","govind@chromium.org","hgrandinetti@chromium.org","imcheng@chromium.org","jam@chromium.org","jamescook@chromium.org","jdiggs@igalia.com","jkrcal@chromium.org","joenotcharles@chromium.org","johnchen@chromium.org","jonmann@chromium.org","jsbell@chromium.org","kainino@chromium.org","kbr@chromium.org","keishi@chromium.org","kristipark@chromium.org","lasoren@chromium.org","lethalantidote@chromium.org","lukasza@chromium.org","manasverma@google.com","manucornet@chromium.org","marinaciocea@chromium.org","martiniss@chromium.org","martinkr@google.com","masonfreed@google.com","mcnee@chromium.org","mdjones@chromium.org","mmenke@chromium.org","mmoroz@chromium.org","mpearson@chromium.org","mthiesse@chromium.org","nharper@chromium.org","nzolghadr@chromium.org","pbos@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","petewil@chromium.org","pkasting@chromium.org","pkl@chromium.org","qnnguyen@chromium.org","raphael.kubo.da.costa@intel.com","rdaum@chromium.org","rsleevi@chromium.org","sandersd@chromium.org","sebmarchand@chromium.org","shyamsundarp@chromium.org","skare@chromium.org","sky@chromium.org","smaier@chromium.org","sunnyps@chromium.org","tbansal@chromium.org","thegreenfrog@chromium.org","thestig@chromium.org","tikuta@chromium.org","updowndota@chromium.org","uwyiming@google.com","vakh@chromium.org","vollick@chromium.org","wangxianzhu@chromium.org","weidongg@chromium.org","wez@chromium.org","wnwen@chromium.org","wychen@chromium.org","xiaoyinh@chromium.org","xunjieli@chromium.org","yoshiki@chromium.org","yuweih@chromium.org","zmo@chromium.org"] Build
branch "master" Build
buildnumber 2885 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1533931705 Build
revision "03427d53dc8e88fbde543f6115708a98c2b9b1f0" Build
slavename "vm4-m1" BuildSlave
buildername "Win 7 Perf" Builder
git_revision "03427d53dc8e88fbde543f6115708a98c2b9b1f0" Change
parent_buildername "Win Builder Perf" ParentBuild
parent_buildnumber 34734 ParentBuild
parent_got_angle_revision "077cd858b2d4ca7632a585a27846fd6db1752969" ParentBuild
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" ParentBuild
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" ParentBuild
parent_got_revision "03427d53dc8e88fbde543f6115708a98c2b9b1f0" ParentBuild
parent_got_revision_cp "refs/heads/master@{#582401}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" ParentBuild
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_7_Perf" slave

Blamelist:

  1. (lukaszaohnoyoudont@chromium.org)
  2. (mcneeohnoyoudont@chromium.org)
  3. (sandersdohnoyoudont@chromium.org)
  4. (vollickohnoyoudont@chromium.org)
  5. (alemateohnoyoudont@chromium.org)
  6. (tbansalohnoyoudont@chromium.org)
  7. (yoshikiohnoyoudont@chromium.org)
  8. (pbosohnoyoudont@chromium.org)
  9. (jkrcalohnoyoudont@chromium.org)
  10. (manasvermaohnoyoudont@google.com)
  11. (wangxianzhuohnoyoudont@chromium.org)
  12. (ctzsmohnoyoudont@chromium.org)
  13. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  14. (fdorayohnoyoudont@chromium.org)
  15. (nharperohnoyoudont@chromium.org)
  16. (marinacioceaohnoyoudont@chromium.org)
  17. (kbrohnoyoudont@chromium.org)
  18. (sunnypsohnoyoudont@chromium.org)
  19. (skyohnoyoudont@chromium.org)
  20. (rdaumohnoyoudont@chromium.org)
  21. (alemateohnoyoudont@chromium.org)
  22. (qnnguyenohnoyoudont@chromium.org)
  23. (eirageohnoyoudont@chromium.org)
  24. (keishiohnoyoudont@chromium.org)
  25. (dmblackohnoyoudont@google.com)
  26. (wezohnoyoudont@chromium.org)
  27. (mpearsonohnoyoudont@chromium.org)
  28. (mthiesseohnoyoudont@chromium.org)
  29. (cliffordchengohnoyoudont@chromium.org)
  30. (etiennebohnoyoudont@chromium.org)
  31. (vakhohnoyoudont@chromium.org)
  32. (xunjieliohnoyoudont@chromium.org)
  33. (fdorayohnoyoudont@chromium.org)
  34. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  35. (erikchenohnoyoudont@chromium.org)
  36. (skyohnoyoudont@chromium.org)
  37. (yoshikiohnoyoudont@chromium.org)
  38. (mpearsonohnoyoudont@chromium.org)
  39. (kaininoohnoyoudont@chromium.org)
  40. (jamohnoyoudont@chromium.org)
  41. (manasvermaohnoyoudont@google.com)
  42. (rsleeviohnoyoudont@chromium.org)
  43. (jamescookohnoyoudont@chromium.org)
  44. (chasejohnoyoudont@chromium.org)
  45. (jonmannohnoyoudont@chromium.org)
  46. (estadeohnoyoudont@chromium.org)
  47. (dmurphohnoyoudont@chromium.org)
  48. (updowndotaohnoyoudont@chromium.org)
  49. (chrishtrohnoyoudont@chromium.org)
  50. (ekaramadohnoyoudont@chromium.org)
  51. (jdiggsohnoyoudont@igalia.com)
  52. (joenotcharlesohnoyoudont@chromium.org)
  53. (ekaramadohnoyoudont@chromium.org)
  54. (lethalantidoteohnoyoudont@chromium.org)
  55. (cbiesingerohnoyoudont@chromium.org)
  56. (wezohnoyoudont@chromium.org)
  57. (pklohnoyoudont@chromium.org)
  58. (lasorenohnoyoudont@chromium.org)
  59. (shyamsundarpohnoyoudont@chromium.org)
  60. (estadeohnoyoudont@chromium.org)
  61. (martinissohnoyoudont@chromium.org)
  62. (mmenkeohnoyoudont@chromium.org)
  63. (mmorozohnoyoudont@chromium.org)
  64. (jsbellohnoyoudont@chromium.org)
  65. (nzolghadrohnoyoudont@chromium.org)
  66. (smaierohnoyoudont@chromium.org)
  67. (enneohnoyoudont@chromium.org)
  68. (pkastingohnoyoudont@chromium.org)
  69. (smaierohnoyoudont@chromium.org)
  70. (johnchenohnoyoudont@chromium.org)
  71. (hgrandinettiohnoyoudont@chromium.org)
  72. (yuweihohnoyoudont@chromium.org)
  73. (raphael.kubo.da.costaohnoyoudont@intel.com)
  74. (skyohnoyoudont@chromium.org)
  75. (aviohnoyoudont@chromium.org)
  76. (pkastingohnoyoudont@chromium.org)
  77. (pkastingohnoyoudont@chromium.org)
  78. (weidonggohnoyoudont@chromium.org)
  79. (enneohnoyoudont@chromium.org)
  80. (imchengohnoyoudont@chromium.org)
  81. (skareohnoyoudont@chromium.org)
  82. (martinkrohnoyoudont@google.com)
  83. (gabohnoyoudont@chromium.org)
  84. (erikchenohnoyoudont@chromium.org)
  85. (xiaoyinhohnoyoudont@chromium.org)
  86. (eromanohnoyoudont@chromium.org)
  87. (uwyimingohnoyoudont@google.com)
  88. (donndohnoyoudont@chromium.org)
  89. (masonfreedohnoyoudont@google.com)
  90. (chengxohnoyoudont@chromium.org)
  91. (ccameronohnoyoudont@chromium.org)
  92. (wnwenohnoyoudont@chromium.org)
  93. (tikutaohnoyoudont@chromium.org)
  94. (kristiparkohnoyoudont@chromium.org)
  95. (wychenohnoyoudont@chromium.org)
  96. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  97. (thegreenfrogohnoyoudont@chromium.org)
  98. (dewittjohnoyoudont@chromium.org)
  99. (thestigohnoyoudont@chromium.org)
  100. (bsazonovohnoyoudont@chromium.org)
  101. (petewilohnoyoudont@chromium.org)
  102. (martinissohnoyoudont@chromium.org)
  103. (kbrohnoyoudont@chromium.org)
  104. (mdjonesohnoyoudont@chromium.org)
  105. (chiliohnoyoudont@chromium.org)
  106. (manucornetohnoyoudont@chromium.org)
  107. (sebmarchandohnoyoudont@chromium.org)
  108. (govindohnoyoudont@chromium.org)
  109. (zmoohnoyoudont@chromium.org)
  110. (dalecurtisohnoyoudont@chromium.org)
  111. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  112. (eaeohnoyoudont@chromium.org)

Timing:

Create N/A
Start Saturday, 11-Aug-18 00:59:30 UTC
End Saturday, 11-Aug-18 05:42:01 UTC
Pending N/A
Execution 4 hrs 42 mins

All Changes:

  1. Avoid leaking NavigationRequest when committing an error page.

    Changed by lukaszaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:37:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 087c060668f8d534355ebebbd04fb6abc70e6898

    Comments

    Avoid leaking NavigationRequest when committing an error page.
    
    Sometimes the commit IPC really is for |navigation_request_| even when
    the URL checks at the top of RFHI::TakeNavigationHandleForCommit
    indicate a mismatched URL.  Examples of when this can happen are XFO
    checks (see https://crbug.com/870815) and CSP/frame-ancestors checks
    (see https://crbug.com/759184).
    
    Before this CL, in the cases above |navigation_request_| would be
    leaked.  This CL fixes the leak.
    
    Bug: 872803
    Cq-Include-Trybots: luc
    ...skip...
    ry:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.perf:obbs_fyi
    Change-Id: Ia09f355e69f182479386b3deeea1f7f0c8996813
    Reviewed-on: https://chromium-review.googlesource.com/1169865
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582289}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_impl_browsertest.cc
  2. Remove tabindex from the GuestViewContainer element.

    Changed by mcneeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:44:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4caaa081a11650f79f34786d5a8ff1c923ed626f

    Comments

    Remove tabindex from the GuestViewContainer element.
    
    A tabindex of -1 on the GuestViewContainer element allows it to be
    focusable but not reachable via sequential keyboard navigation.
    
    There does not appear to be any further need for the GuestViewContainer
    element itself to be focusable given that we override the focus method.
    Previously, we had a focus event listener on the GuestViewContainer
    element in order to propagate the focus to the internal element which
    would explain why this was needed.
    
    See
    https://crrev.com/6476573b7d9099b04002736d90a078550c8651eb
    https://crrev.com/53ba951bb6ed4df0998240520fed9d00a7ffff67
    
    Bug: 231664, 803274
    Change-Id: If6ffb6f7282db86a1a7ab9e856785e6f51d79a80
    Reviewed-on: https://chromium-review.googlesource.com/1170988
    Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    Commit-Queue: Kevin McNee <mcnee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582294}

    Changed files

    • extensions/renderer/resources/guest_view/guest_view_container.js
  3. Add RTCVideoDecoderAdapter, which can use any media::VideoDecoder.

    Changed by sandersdohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:43:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee4a42360880ea5aff0e7154e356e60be7708ebd

    Comments

    Add RTCVideoDecoderAdapter, which can use any media::VideoDecoder.
    
    This is the main body of code required to support MojoVideoDecoder for
    hardware decode of WebRTC streams. It tries to be as similar as possible
    to RTCVideoDecoder so that a transition can be managed slowly.
    
    The implementation actually supports any media::VideoDecoder, in
    particular FFmpegVideoDecoder works well for testing.
    
    Bug: 857111
    Change-Id: I0a4dc37a0a133b4c112a55a215aba8058cca598b
    Reviewed-on: https://chromium-review.googlesource.com/1117837
    Commit-Queue: Dan Sanders <sandersd@chromium.org>
    Reviewed-by: Henrik Boström <hbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582291}

    Changed files

    • content/renderer/BUILD.gn
    • content/renderer/media/webrtc/rtc_video_decoder_adapter.cc
    • content/renderer/media/webrtc/rtc_video_decoder_adapter.h
    • content/renderer/media/webrtc/rtc_video_decoder_adapter_unittest.cc
    • content/test/BUILD.gn
  4. [vr] Disable WillNotFailOnNonAsciiURLs

    Changed by vollickohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:54:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a2ce72e4384ec85ce4730dad11aa59469272060e

    Comments

    [vr] Disable WillNotFailOnNonAsciiURLs
    
    This will currently not pass with new versions of HarfBuzz.
    
    Bug: 731894
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ib5ae456bf44bfdedd6a0edf36b54dbbf12bae18a
    Reviewed-on: https://chromium-review.googlesource.com/1169774
    Commit-Queue: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582298}

    Changed files

    • chrome/browser/vr/elements/url_text_unittest.cc
  5. Chrome OS OOBE: Use Google Sans for OOBE buttons and titles.

    Changed by alemateohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:43:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa5bd50aab4ff15f393a152cb02e8bb0ec113531

    Comments

    Chrome OS OOBE: Use Google Sans for OOBE buttons and titles.
    
    Bug: 828996,868093
    Change-Id: Ic1dd75cc142bd22b2b9edc31bd5b90abe150e081
    Reviewed-on: https://chromium-review.googlesource.com/1170430
    Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582292}

    Changed files

    • chrome/browser/resources/chromeos/login/oobe_buttons.html
    • chrome/browser/resources/chromeos/login/oobe_dialog.css
    • chrome/browser/resources/chromeos/login/oobe_dialog.html
    • chrome/browser/resources/chromeos/login/oobe_fonts.css
    • chrome/browser/resources/chromeos/login/oobe_reset_confirmation_overlay.css
    • chrome/browser/resources/chromeos/login/oobe_screen.css
    • chrome/browser/resources/chromeos/login/oobe_text_buttons.css
    • chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css
    • chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
  6. NQE servicification of client hints

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:45:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5ac5335452b7f3f5f88837c9dfabda46d51e4795

    Comments

    NQE servicification of client hints
    
    Use network quality tracker instead of network quality estimator (NQE)
    to obtain network quality when attaching network quality
    client hints for main frame resources.
    
    Network quality tracker can provide network service when network
    service is enabled as well as when network service is disabled.
    
    Change-Id: Iafa641ecb487bb00aecc0d3f1a18cfcdabba3de8
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1170568
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582296}

    Changed files

    • chrome/browser/client_hints/client_hints.cc
    • chrome/browser/client_hints/client_hints_browsertest.cc
  7. Add a setting of lock screen notifications

    Changed by yoshikiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:44:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7162372f108a4f7d18602e4abe1a861446c20509

    Comments

    Add a setting of lock screen notifications
    
    This CL adds the setting to select the following mode of the lock
    screen notification to the Chrome OS setting.
    - Hide: don't show notifications on the lock screen
      (default, same as the current behavior)
    - Show: show notifications on the lock screen
    - Hide Sensitive: show notifications, but hide sensitive contents
      (with a flag to disable this, since this may not launch at the same time)
    
    PRD: go/notification-on-lock-screen
    
    Bug: b/111391270
    Change-Id: Ieba42369923472ecef02eac85df9e9009df3ad84
    Reviewed-on: https://chromium-review.googlesource.com/1165723
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Sammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582293}

    Changed files

    • ash/ash_strings.grd
    • ash/message_center/ash_message_center_lock_screen_controller.cc
    • ash/message_center/message_center_controller.cc
    • ash/message_center/message_center_controller.h
    • ash/message_center/message_center_view_unittest.cc
    • ash/public/cpp/ash_features.cc
    • ash/public/cpp/ash_features.h
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/shell.cc
    • chrome/browser/chromeos/preferences.cc
    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • chrome/browser/resources/settings/people_page/lock_screen.html
    • chrome/browser/resources/settings/people_page/lock_screen.js
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/browser/ui/webui/settings/md_settings_ui.cc
  8. Remove IsSecondaryUiMaterial() method.

    Changed by pbosohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:45:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d46a82308a0f4b5546f9d081a2f9ee46f72e893c

    Comments

    Remove IsSecondaryUiMaterial() method.
    
    All calls to this function have been removed and it's no longer in use.
    
    Bug: chromium:867557
    Change-Id: I8334510e9fe4b685c7c724f7e35f098435c24bb6
    Reviewed-on: https://chromium-review.googlesource.com/1170991
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Peter Boström <pbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582295}

    Changed files

    • ui/base/material_design/material_design_controller.cc
    • ui/base/material_design/material_design_controller.h
  9. [AF] Fix client tag and storage key for the wallet data USS bridge

    Changed by jkrcalohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:46:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bb8985ee5c80d40e256d34a0d13f8f4e5ae2067

    Comments

    [AF] Fix client tag and storage key for the wallet data USS bridge
    
    This CL adapts GetClientTag() to what integration tests use.
    
    Change-Id: Ie2fbc9c5fd193d0a3635b231e58de7fdf94b3077
    Reviewed-on: https://chromium-review.googlesource.com/1171222
    Commit-Queue: Jan Krcal <jkrcal@chromium.org>
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582297}

    Changed files

    • components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc
    • components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
  10. [Autofill] Adding metrics for the Manage Cards bubble.

    Changed by manasvermaohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 20:07:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e3fc21174cab8ded22cc77a7358a1f37aa905080

    Comments

    [Autofill] Adding metrics for the Manage Cards bubble.
    
    Metrics for the Manage Cards view, which appears when the user clicks on the credit card icon after saving a card locally.
    
    bug: 855186
    Change-Id: I036b16bc4a5a4f48115212263909e49371e9778f
    Reviewed-on: https://chromium-review.googlesource.com/1162900
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Commit-Queue: Manas Verma <manasverma@google.com>
    Cr-Commit-Position: refs/heads/master@{#582304}

    Changed files

    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
    • chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
    • components/autofill/core/browser/autofill_metrics.cc
    • components/autofill/core/browser/autofill_metrics.h
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml
  11. [PE] Allow blending for svg root etc.

    Changed by wangxianzhuohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:55:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a5a0362ca70fe20e8473f1dc720c86f3eb1bc36

    Comments

    [PE] Allow blending for svg root etc.
    
    Bug: 872437
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Idb0d69320ddfa2dcfe02e493cd117573618459d5
    Reviewed-on: https://chromium-review.googlesource.com/1169624
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582299}

    Changed files

    • third_party/WebKit/LayoutTests/css3/blending/svg-blend-not-allowed-expected.html
    • third_party/WebKit/LayoutTests/css3/blending/svg-blend-not-allowed.html
    • third_party/WebKit/LayoutTests/css3/blending/svg-blend-tspan-expected.html
    • third_party/WebKit/LayoutTests/css3/blending/svg-blend-tspan.html
    • third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-svg-foreign-object-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-svg-foreign-object.html
    • third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-svg-root-ref.html
    • third_party/WebKit/LayoutTests/external/wpt/svg/render/reftests/blending-svg-root.html
    • third_party/blink/renderer/core/layout/layout_object.h
    • third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
  12. [Printing] Remove extra |askUserForSettingsReply()| call

    Changed by ctzsmohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:58:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f433642fc86f496c48a3a25b3e57146d3c8edf87

    Comments

    [Printing] Remove extra |askUserForSettingsReply()| call
    
    After we migrated native side callback to |OnceCallback|, it exposed
    that we sometimes call |askUserForSettingsReply()| more than once. The
    |DCHECK(callback_)| in |PrintingContextAndroid::AskUserForSettingsReply|
    was violated.
    
    Since |Printingcontext.askUserForSettings()| will call
    |askUserForSettingsReply()| for sure, we don't need to call it in
    other places.
    
    This CL removes a call site of |askUserForSettingsReply| in
    |PrintingControllerImpl|.
    
    Bug: 863297
    Change-Id: If1c34a4a89acaca461074231ab1bef8edef9baae
    Reviewed-on: https://chromium-review.googlesource.com/1161604
    Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
    Reviewed-by: Changwan Ryu <changwan@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582301}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java
    • printing/android/java/src/org/chromium/printing/PrintingContext.java
    • printing/android/java/src/org/chromium/printing/PrintingContextInterface.java
    • printing/android/java/src/org/chromium/printing/PrintingControllerImpl.java
  13. Roll src/third_party/angle 04c084dd3cf4..077cd858b2d4 (1 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 19:42:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8526d438cd1c5293ad60c0df8c84aefefd719996

    Comments

    Roll src/third_party/angle 04c084dd3cf4..077cd858b2d4 (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/04c084dd3cf4..077cd858b2d4
    
    
    git log 04c084dd3cf4..077cd858b2d4 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 theoking@google.com Vulkan: Introduce Command Buffer Perf Test
    
    
    Created with:
      gclient setdep -r src/third_party/angle@077cd858b2d4
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://sk
    ...skip...
    luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: Ie4d97da1f754b092c895391c9215b052d2005e30
    Reviewed-on: https://chromium-review.googlesource.com/1171164
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582290}

    Changed files

    • DEPS
  14. Record BrowserOpenTabs and BrowserWindowDisplay histograms after startup temperature evaluation.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:04:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ef0a41ad3805c6d83c21eb1edce4e2459cb7e8f

    Comments

    Record BrowserOpenTabs and BrowserWindowDisplay histograms after startup temperature evaluation.
    
    Previously, these histograms were recorded prior to startup
    temperature evaluation, which caused almost (*) no data to be
    recorded in temperature-suffixed histograms. With this CL,
    the values are stored in global variable and recorded to
    appropriate histograms after the startup temperature is
    evaluated.
    
    (*) Most of the time, the browser window is displayed
        before startup temperature evaluation. Howev
    ...skip...
    temperature-suffixed
        BrowserWindowDisplay histograms. With this CL, any
        browser window display that happens after normal
        startup won't be recorded to an histogram.
    
    Bug: 580207, 589118
    Change-Id: I8419df6f42df64f60be0858462159a276d17557e
    Reviewed-on: https://chromium-review.googlesource.com/1167470
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582302}

    Changed files

    • chrome/browser/metrics/startup_metrics_browsertest.cc
    • components/startup_metric_utils/browser/startup_metric_utils.cc
  15. Add enterpise policy to control SSLConfig.client_cert_pooling_policy

    Changed by nharperohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:57:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 598b280c5f47a8fc4d6a6a71b2fd8337026a8240

    Comments

    Add enterpise policy to control SSLConfig.client_cert_pooling_policy
    
    Bug: 855690
    Change-Id: I19d0b1ca0770c9016b0197bf435cf47affe49a94
    Reviewed-on: https://chromium-review.googlesource.com/1159840
    Commit-Queue: Nick Harper <nharper@chromium.org>
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582300}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/browser/ssl/ssl_config_service_manager_pref.cc
    • chrome/browser/ssl/ssl_config_service_manager_pref_unittest.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/test/data/policy/policy_test_cases.json
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  16. Update audio service field trial experiment names.

    Changed by marinacioceaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:16:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5677b53118e4ab55b850b82cc812dd0ff7db9e74

    Comments

    Update audio service field trial experiment names.
    
    Update names to match latest finch beta config names.
    
    Bug: 832666
    Change-Id: Ic108cf7f545fd174209d0b2eee517999c7875b43
    Reviewed-on: https://chromium-review.googlesource.com/1171223
    Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
    Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582306}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  17. Temporarily disable GPU info collection using NVML.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:16:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 47fecb1157b2be1c690e427674b8428113c45475

    Comments

    Temporarily disable GPU info collection using NVML.
    
    There are many crashes seen on Chrome Canary inside nvml.dll, so until
    a pattern can be found and a workaround proposed, stop calling into it.
    
    Bug: 693090, 873095
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I0204273fb88ba8b61799916d98c843f0068ccadc
    Tbr: zmo@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1171376
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582307}

    Changed files

    • gpu/config/nvml_info.cc
  18. Enable Windows NV12 overlays on waterfall

    Changed by sunnypsohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:13:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2be1f9128c9cf8876bc88b1cb9c946af6b235ea8

    Comments

    Enable Windows NV12 overlays on waterfall
    
    We plan on shipping this via a finch experiment to Canary/Dev soon, and then
    enable it by default if we don't encounter major issues. This should only affect
    the DirectComposition pixel tests since we force-enable overlays for those
    tests. Other tests don't exercise DirectComposition code because those code
    paths are disabled unless the hardware supports it.
    
    Bug: 869677
    Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a
    Reviewed-on: https://chromium-review.googlesource.com/1170385
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582305}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  19. exo: pass in Envs when creating aura::Windows

    Changed by skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:07:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 13de50d7deff3e0f2d0682a05441656c81f6a8eb

    Comments

    exo: pass in Envs when creating aura::Windows
    
    As part of the mash work we're going to have multiple aura::Envs at the same
    time. Code that may run in Ash now gets the Env from aura::Window, rather than
    using Env's static GetInstance(). This patch converts exo to remember the
    Env so that it can get the right one.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: I5fd1c6120868b3847ccd68a063039eec5b54a3b6
    Reviewed-on: https://chromium-review.googlesource.com/1169590
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582303}

    Changed files

    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/system/message_center/arc/arc_notification_content_view_unittest.cc
    • ash/wayland/wayland_server_controller.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • components/exo/buffer.cc
    • components/exo/shell_surface.cc
    • components/exo/surface.cc
    • components/exo/surface_tree_host.cc
    • components/exo/surface_unittest.cc
    • components/exo/test/exo_test_base.cc
    • components/exo/test/exo_test_helper.cc
    • components/exo/wayland/clients/test/wayland_client_test.cc
    • components/exo/wm_helper.cc
    • components/exo/wm_helper.h
  20. [chromecast] Fullscreen magnficiation for cast.

    Changed by rdaumohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:17:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32c5dea9e50054eb4388b0e365ad22b5cca5734a

    Comments

    [chromecast] Fullscreen magnficiation for cast.
    
      * Port of Ash's MagnificationController to cast. First patchset is
        the original source, with changes/removals for cast in patchset 2.
      * Enabled via triple-tap when that is enabled.
      * Two-finger pan & pinch-to-zoom.
    
    Bug: internal b/110532452
    Test: manual
    Change-Id: Ia346fcc6d4ff70aaa0236f1d976c3b0de13a0f86
    Reviewed-on: https://chromium-review.googlesource.com/1170987
    Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
    Commit-Queue: Ryan Daum <rdaum@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582308}

    Changed files

    • chromecast/browser/accessibility/accessibility_manager.cc
    • chromecast/graphics/BUILD.gn
    • chromecast/graphics/accessibility/fullscreen_magnification_controller.cc
    • chromecast/graphics/accessibility/fullscreen_magnification_controller.h
  21. Chrome OS: implement parametrized strings for Sync Consent screen

    Changed by alemateohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:17:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision feed35d8457a9d0651562b4a5cff0dffb1c0d54f

    Comments

    Chrome OS: implement parametrized strings for Sync Consent screen
    
    This CL adds I18nBehavior.i18nRecursive and uses it for parametrized strings in
    Chrome OS Sync Consent screen.
    
    Bug: 822889
    Change-Id: I0ca8c3b7a45ee1cea8a80a0e8ace388e958709c4
    Reviewed-on: https://chromium-review.googlesource.com/1166464
    Commit-Queue: Alexander Alekseev <alemate@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582309}

    Changed files

    • chrome/browser/resources/chromeos/login/sync_consent.html
    • ui/webui/resources/js/i18n_behavior.js
  22. cros: In OOBE, turn off scrolling if the screen fits in the container

    Changed by qnnguyenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:19:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3963b98df61fe488ddbd007ac5933cf62beff0df

    Comments

    cros: In OOBE, turn off scrolling if the screen fits in the container
    
    Bug: 855546
    Change-Id: I065c2bbd1e3db69dca3f8b18d40ce5beb09f9abd
    Reviewed-on: https://chromium-review.googlesource.com/1162715
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582312}

    Changed files

    • ui/login/display_manager.js
  23. Fix underline thickness on Android

    Changed by eirageohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61206b2ccc0825957b54826e3574bb4c447abe68

    Comments

    Fix underline thickness on Android
    
    On Android, we want the underline thickness to follow with device scale
    as other app. (And also 1px is two thick since mobile has larger pixel
    density) Thus, we need to apply the zoom level to the text underline
    thickness.
    
    Bug: 870203
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I98080028c59837b69742101a2239df7f9b8dc43c
    Reviewed-on: https://chromium-review.googlesource.com/1162518
    Reviewed-by: Yoichi Osato <yoichio@chromium.org>
    Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582311}

    Changed files

    • third_party/WebKit/LayoutTests/ImageFirstTests
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/markers/markers-zoomed-expected.png
    • third_party/WebKit/LayoutTests/paint/markers/markers-zoomed.html
    • third_party/WebKit/LayoutTests/platform/linux/paint/markers/markers-zoomed-expected.png
    • third_party/WebKit/LayoutTests/platform/mac/paint/markers/markers-zoomed-expected.png
    • third_party/WebKit/LayoutTests/platform/win/paint/markers/markers-zoomed-expected.png
    • third_party/blink/renderer/core/paint/document_marker_painter.cc
  24. Oilpan: Add Unit Tests in HeapCompaction for IncrementalMarking

    Changed by keishiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:21:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0787194dfc3ab53eca729e1f5bc326661a4a43c3

    Comments

    Oilpan: Add Unit Tests in HeapCompaction for IncrementalMarking
    
    This CLs added 3 unit tests in HeapCompaction for IncrementalMarking.
    One of tests checks that slots is collected if the slot content is nullptr of inline buffer.
    Another case checks whether compaction is correctly working if collected slot is dropped references.
    Moreover, we check whether compaction is correctly working if collected slot is destructed by mutator.
    
    Bug: 864425
    Change-Id: I3038c9a6e2607f3ed81a5f438a1ab415fa96df9a
    Reviewed-on: https://chromium-review.googlesource.com/1152750
    Commit-Queue: Keishi Hattori <keishi@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582313}

    Changed files

    • third_party/blink/renderer/platform/heap/heap_compact.cc
    • third_party/blink/renderer/platform/heap/heap_compact.h
    • third_party/blink/renderer/platform/heap/incremental_marking_test.cc
  25. Focus on correct view.

    Changed by dmblackohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 20:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fa7cc2e42404e2c671d225bbc4a66e0fa2b2ebb

    Comments

    Focus on correct view.
    
    Which view we should focus on depends on which UI mode we are in.
    
    Bug: b:112443502
    Change-Id: I2ba63f401f0f8a900971b9c2cef7ce22cff67e4f
    Reviewed-on: https://chromium-review.googlesource.com/1171142
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#582310}

    Changed files

    • ash/assistant/ui/assistant_container_view.cc
  26. Remove QuitCurrent*() calls from //services.

    Changed by wezohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:31:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bfc08a1dd13f2106073151a9a1f6c4c077d3bcde

    Comments

    Remove QuitCurrent*() calls from //services.
    
    This addresses flaky DCHECKs in ServiceManagerTests and LifecycleTests,
    triggered by mixing of RunLoop::QuitClosure() with the calls to the
    old RunLoop::QuitCurrent*Deprecated() APIs.
    
    Change-Id: Ieb510aa1501f9d46ac606d66a3556744fd0f95da
    Reviewed-on: https://chromium-review.googlesource.com/1170355
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582316}

    Changed files

    • mash/runner/main.cc
    • services/service_manager/public/cpp/service_context.cc
    • services/service_manager/public/cpp/service_runner.cc
    • services/service_manager/standalone/context.cc
    • services/service_manager/standalone/context.h
    • services/service_manager/tests/connect/connect_test_package.cc
    • services/service_manager/tests/lifecycle/app_client.cc
    • services/service_manager/tests/lifecycle/package.cc
    • services/service_manager/tests/lifecycle/parent.cc
    • services/service_manager/tests/service_manager/embedder.cc
  27. Extend Expiration Dates of InMemory Timing Histograms

    Changed by mpearsonohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7c3730ffbbe625a91c222b1ed6af348bdd7b904

    Comments

    Extend Expiration Dates of InMemory Timing Histograms
    
    Having these histograms is an important reminder that, on many platforms,
    these things take on the order of hundreds of milliseconds shortly after
    startup, likely making slow slower as a user is trying to interact with
    it.
    
    Bug: 871495
    Change-Id: Iab792bb11446a8258865562937b8f8b9b81fe4a1
    Reviewed-on: https://chromium-review.googlesource.com/1170132
    Commit-Queue: Mark Pearson <mpearson@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Siddhartha S <ssid@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582314}

    Changed files

    • tools/metrics/histograms/histograms.xml
  28. Ignore EAGAIN reading timerfd in message_pump_android.

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:24:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c36083d762cfc04d161e605c29bb95229a0bb7e

    Comments

    Ignore EAGAIN reading timerfd in message_pump_android.
    
    EAGAIN should only happen when no timer has expired, but the function
    should only be called when a timer expires. And yet, very rarely during
    tests, we error with EAGAIN. I have no theories as to why this is
    happening. Possibly a platform bug.
    
    Ignoring EAGAIN should be safe, we only read the timer to clear it so
    that we don't keep getting called back. If it's already cleared then
    we're fine too.
    
    Bug: 872044
    Change-Id: I6eb29ab99402d90140bd5b89a26df2aa5e53b1c6
    Reviewed-on: https://chromium-review.googlesource.com/1168154
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582315}

    Changed files

    • base/message_loop/message_pump_android.cc
  29. Add a pixel-by-pixel comparison tests as discussed before.

    Changed by cliffordchengohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:34:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a6e8d7e7506867727125fa16164c9a82025fd64

    Comments

    Add a pixel-by-pixel comparison tests as discussed before.
    
    1. The test uses a video with only 2 different frames. The first frame
    of the video is a blue/pink color frame and the rest are a yellow frame
    to avoid any possible error because of image compression.
    
    2. The test loads a page, starts playing the video and trigger PiP.
    The PiP window is set to a specific size and then a screenshort is
    grabbed.
    
    Change-Id: I63e0ede4013dbeee688770cca06ac673ed6003b3
    Reviewed-on: https://chromium-review.googlesource.com/1137533
    Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582317}

    Changed files

    • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
    • chrome/test/data/media/picture-in-picture/pixel_test.html
    • chrome/test/data/media/picture-in-picture/pixel_test_video.webm
  30. Add system stats to navigation category in slow-reports

    Changed by etiennebohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:39:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 657073af9e82fa2400eb4f384207b555f66d83ea

    Comments

    Add system stats to navigation category in slow-reports
    
    This CL is activating the "system_stats" category for the navigation
    slow-reports.
    
    The idea is to collect more system wide information to determine the
    cause of janks. We believe many janks are related to system wide
    properties not visible without system wide metrics.
    
    R=fdoray,oysteine
    
    Bug: 872900
    Change-Id: I2151616b07b79997b20243181eb31c5270c4ee68
    Reviewed-on: https://chromium-review.googlesource.com/1171109
    Reviewed-by: oysteine <oysteine@chromium.org>
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582319}

    Changed files

    • content/browser/tracing/background_tracing_manager_impl.cc
  31. Remove safe_browsing_db from the WATCHLIST

    Changed by vakhohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:42:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a6088d5e92c7fd0ed853ef0767dd9b1d270c39a

    Comments

    Remove safe_browsing_db from the WATCHLIST
    since that path has been removed and folded into safe_browsing
    
    Change-Id: I9a81174f82bb39bcd43183b180e6250eff833167
    Reviewed-on: https://chromium-review.googlesource.com/1171163
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Commit-Queue: Jialiu Lin <jialiul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582321}

    Changed files

    • WATCHLISTS
  32. Revert "Revert "Migrate gcm to network service's socket APIs""

    Changed by xunjieliohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:37:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f3d96a7bfc7cbb6a4614325241f0b2bbc198ae2

    Comments

    Revert "Revert "Migrate gcm to network service's socket APIs""
    
    This reverts commit 838e1b1949af36aec49042cd1df6d55396d0957b.
    
    Reason for revert: Reland after fix
    
    Mojo doesn't allow dropping response callbacks (see
    https://groups.google.com/a/chromium.org/forum/#!topic/services-dev/zSNh16-tkaA
    for discussion). The fix is to modify
    ProxyResolvingSocketFactory::CreateProxyResolvingSocket to always invoke
    the response callback even when the underlying socket is destroyed.
    This CL also adds a regression 
    ...skip...
    imulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ie9fdb93f965bbcf534253aaabe436c4de5f0666d
    Reviewed-on: https://chromium-review.googlesource.com/1169345
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582318}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
    • chrome/browser/gcm/gcm_profile_service_factory.cc
    • chrome/browser/gcm/gcm_profile_service_unittest.cc
    • components/gcm_driver/BUILD.gn
    • components/gcm_driver/DEPS
    • components/gcm_driver/fake_gcm_client.cc
    • components/gcm_driver/fake_gcm_client.h
    • components/gcm_driver/gcm_client.h
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_client_impl.h
    • components/gcm_driver/gcm_client_impl_unittest.cc
    • components/gcm_driver/gcm_desktop_utils.cc
    • components/gcm_driver/gcm_desktop_utils.h
    • components/gcm_driver/gcm_driver_desktop.cc
    • components/gcm_driver/gcm_driver_desktop.h
    • components/gcm_driver/gcm_driver_desktop_unittest.cc
    • components/gcm_driver/gcm_profile_service.cc
    • components/gcm_driver/gcm_profile_service.h
    • components/gcm_driver/instance_id/BUILD.gn
    • google_apis/gcm/BUILD.gn
    • google_apis/gcm/DEPS
    • google_apis/gcm/base/socket_stream.cc
    • google_apis/gcm/base/socket_stream.h
    • google_apis/gcm/base/socket_stream_unittest.cc
    • google_apis/gcm/engine/connection_factory.h
    • google_apis/gcm/engine/connection_factory_impl.cc
    • google_apis/gcm/engine/connection_factory_impl.h
    • google_apis/gcm/engine/connection_factory_impl_unittest.cc
    • google_apis/gcm/engine/connection_handler.h
    • google_apis/gcm/engine/connection_handler_impl.cc
    • google_apis/gcm/engine/connection_handler_impl.h
    • google_apis/gcm/engine/connection_handler_impl_unittest.cc
    • google_apis/gcm/engine/fake_connection_factory.cc
    • google_apis/gcm/engine/fake_connection_handler.cc
    • google_apis/gcm/engine/fake_connection_handler.h
    • google_apis/gcm/tools/mcs_probe.cc
    • ios/chrome/browser/application_context_impl.cc
    • ios/chrome/browser/gcm/ios_chrome_gcm_profile_service_factory.cc
    • ios/web/browser_state.mm
    • ios/web/public/browser_state.h
    • ios/web_view/internal/sync/web_view_gcm_profile_service_factory.mm
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_impl.h
    • services/network/proxy_resolving_socket_mojo.cc
    • services/network/proxy_resolving_socket_mojo.h
    • services/network/proxy_resolving_socket_mojo_unittest.cc
    • services/network/public/mojom/proxy_resolving_socket.mojom
  33. CHECK that clipboard is only use on whitelisted threads.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:47:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f4fc85731cec0ff4491dfd0f550ec953191785d

    Comments

    CHECK that clipboard is only use on whitelisted threads.
    
    Previously, using the clipboard on a non-whitelisted thread triggered
    a DumpWithoutCrashing + NOTREACHED. If a developer introduced code that
    used the clipboard on an incorrect thread, they were not warned
    immediately unless they had DCHECKs enabled. The issue could only be
    noticed once an official version of Chrome started generating crash
    reports via DumpWithoutCrashing (e.g. https://crbug.com/872737). This
    CL replaces the DumpWithoutCrashing + NOTREACHED with a CHECK to
    ensure that developers can't miss the issue.
    
    Bug: 872737
    Change-Id: I5de2c1498245604fc94ca29c35518cc0c9531b0f
    Reviewed-on: https://chromium-review.googlesource.com/1170595
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582323}

    Changed files

    • ui/base/clipboard/clipboard.cc
  34. Import wpt@848ceffad26e92d47ffe790ed8b650906b2c2343

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:41:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 115c7b0108cb2e43502a0bbd6a8fd3950c9a81f8

    Comments

    Import wpt@848ceffad26e92d47ffe790ed8b650906b2c2343
    
    Using wpt-import in Chromium 21c70dad5bd1417a9fb858c7298ff3bcbe297419.
    With Chromium commits locally applied on WPT:
    7dad0f1723 "Added new Sec-Metadata Web Platform Tests."
    b883f43214 "[LayoutNG] Propagate abspos inline container"
    0cca86c622 "[Background Fetch] Reject BackgroundFetchUpdateEvent::UpdateUI if called again"
    0f9021aac9 "[LayoutNG] Flip for writing mode when calculating inline bounding box."
    
    
    Build: https://ci.chromium.org/buildbot/chro
    ...skip...
    ding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    NOAUTOREVERT=true
    TBR=lukebjerring
    
    No-Export: true
    Change-Id: Ide77f40071e045eb5e1b3574920b5e62e88256c7
    Reviewed-on: https://chromium-review.googlesource.com/1171214
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582320}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/dom/nodes/DOMImplementation-createDocument-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElement.html
    • third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElementNS-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createElementNS.js
  35. Implement native event observer for Windows.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:48:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5c6237c82cf6fd41b61890bf8439782399c8042

    Comments

    Implement native event observer for Windows.
    
    This CL adds a new MessagePumpForUI::Observer class, which can be used to get
    notifications pre and post MSG dispatch.
    
    Change-Id: I16b0df6d30b41f04f124d4b64d850c278f2c10d9
    Reviewed-on: https://chromium-review.googlesource.com/1166164
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582324}

    Changed files

    • base/message_loop/message_loop_current.cc
    • base/message_loop/message_loop_current.h
    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
    • content/browser/scheduler/responsiveness/native_event_observer.cc
    • content/browser/scheduler/responsiveness/native_event_observer.h
    • content/browser/scheduler/responsiveness/native_event_observer_browsertest_win.cc
    • content/test/BUILD.gn
  36. ash: enforce that all Widgets have a context/parent when created

    Changed by skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:47:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 786483cac1c90efd081159a9843e96aee5d32cbf

    Comments

    ash: enforce that all Widgets have a context/parent when created
    
    This will be important for SingleProcessMash as the context/parent is
    needed to properly create the NativeWidgetDelegate. In particular
    NativeWidgetAura's constructor takes an Env that comes from either the
    context or parent. We need to ensure code in Ash sets that properly so that
    the right Env is used.
    
    BUG=847992
    TEST=covered by tests
    
    Change-Id: I2876ac862e00c4f03a7c328230db372f5d74a005
    Reviewed-on: https://chromium-review.googlesource.com/1171204
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582322}

    Changed files

    • ash/accelerators/accelerator_controller_unittest.cc
    • ash/assistant/ui/assistant_container_view.cc
    • ash/components/shortcut_viewer/DEPS
    • ash/components/shortcut_viewer/shortcut_viewer_application.cc
    • ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
    • ash/components/shortcut_viewer/views/keyboard_shortcut_view.h
    • ash/components/shortcut_viewer/views/keyboard_shortcut_view_unittest.cc
    • ash/display/shared_display_edge_indicator.cc
    • ash/drag_drop/drag_drop_controller_unittest.cc
    • ash/drag_drop/drag_drop_interactive_uitest.cc
    • ash/drag_drop/drag_image_view.cc
    • ash/extended_desktop_unittest.cc
    • ash/focus_cycler_unittest.cc
    • ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc
    • ash/frame/caption_buttons/frame_size_button_unittest.cc
    • ash/keyboard/arc/arc_input_method_surface_manager_unittest.cc
    • ash/message_center/message_center_view_unittest.cc
    • ash/message_center/message_list_view_unittest.cc
    • ash/root_window_controller_unittest.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_widget_unittest.cc
    • ash/shell_unittest.cc
    • ash/test/ash_test_helper_unittest.cc
    • ash/test/ash_test_views_delegate.cc
    • ash/test/ash_test_views_delegate.h
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • ash/wm/lock_layout_manager_unittest.cc
    • ash/wm/overview/cleanup_animation_observer_unittest.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/splitview/split_view_controller_unittest.cc
    • ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc
    • ash/wm/test_child_modal_parent.cc
    • ash/wm/test_child_modal_parent.h
    • ash/wm/window_modality_controller_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • chrome/browser/ui/ash/accessibility/ax_tree_source_aura_unittest.cc
    • chrome/browser/ui/ash/ksv/DEPS
    • chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc
    • chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
    • chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
    • chrome/test/base/browser_with_test_window_test.cc
  37. Create a separate flag for inline reply on lock screen

    Changed by yoshikiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:49:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 14acb978669ed24653f2b290134c828d6a0a0800

    Comments

    Create a separate flag for inline reply on lock screen
    
    Inline reply on lock screen is not launched at the same time as
    the lock screen notifications. So this CL creates a separate feature
    flag for inline reply.
    
    Bug: b/111391270
    
    Change-Id: I585beba17b3a491ce495f1d6c35ce46b2a6b6686
    Reviewed-on: https://chromium-review.googlesource.com/1166617
    Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582325}

    Changed files

    • ash/public/cpp/ash_features.cc
    • ash/public/cpp/ash_features.h
    • chrome/browser/chromeos/input_method/input_method_manager_impl.cc
  38. Add csharp@ as owner and Extend Expiration Date of EngineTypes Histograms

    Changed by mpearsonohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:00:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dab9c033fb5b47c1e6e334e5d95a402668895719

    Comments

    Add csharp@ as owner and Extend Expiration Date of EngineTypes Histograms
    
    These histograms are used, both within Chrome and within Google, in the
    effort to identify and fight unwanted software and malware.
    
    As such, I'm giving them a longer expiration date: two years.
    
    Bug: 871482
    Change-Id: I320976f7a18dfa3c5c0d6bb6c3bf05ddfec8e5b4
    Reviewed-on: https://chromium-review.googlesource.com/1166197
    Reviewed-by: Chris Sharp <csharp@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Mark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582329}

    Changed files

    • tools/metrics/histograms/histograms.xml
  39. Remove qualcomm from ToughWebglPage skipped_gpus

    Changed by kaininoohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:50:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1236a1623e8f1eb638e33d3d145739fe1ca081d4

    Comments

    Remove qualcomm from ToughWebglPage skipped_gpus
    
    Historically, we haven't been running these WebGL perf tests
    on our Android perf bots (which are all Qualcomm devices).
    This change should hopefully allow us to start tracking WebGL
    perf on mobile.
    
    Bug: 867368
    Change-Id: I8e409d649f6238094928dfdac4cc6f7d2c444ca5
    Reviewed-on: https://chromium-review.googlesource.com/1170032
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Kai Ninomiya <kainino@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582326}

    Changed files

    • tools/perf/page_sets/rendering/tough_webgl_cases.py
  40. Enable some more passing browser tests with network service.

    Changed by jamohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 20:58:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c999b6344a3a2d1bd8dbdd09f83d4499453d336

    Comments

    Enable some more passing browser tests with network service.
    
    Bug: 797292, 859594
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Id4e90f0ebdf5ac172b12c92d80b54348125bc883
    Reviewed-on: https://chromium-review.googlesource.com/1171556
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582328}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  41. [Autofill] Updating strings for Save Card Sign-in Promo

    Changed by manasvermaohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 20:54:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ad5c66907292930c378b882c1634fad9b2b29eb

    Comments

    [Autofill] Updating strings for Save Card Sign-in Promo
    
    Before: https://screenshot.googleplex.com/5YhNTQYuHV1
    After: https://screenshot.googleplex.com/thg0VSMKzNX
    
    
    Bug: 855186
    Change-Id: I64b1ca9452330a847512c45220bda9173e1a1ac1
    Reviewed-on: https://chromium-review.googlesource.com/1170141
    Commit-Queue: Manas Verma <manasverma@google.com>
    Reviewed-by: Evan Stade <estade@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582327}

    Changed files

    • chrome/browser/ui/views/autofill/save_card_manage_cards_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_sign_in_promo_bubble_views.cc
    • components/autofill_strings.grdp
    • components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE.png.sha1
    • components/autofill_strings_grdp/IDS_AUTOFILL_SIGNIN_PROMO_MESSAGE_DICE_DISABLED.png.sha1
    • components/autofill_strings_grdp/IDS_AUTOFILL_SYNC_PROMO_MESSAGE.png.sha1
  42. No longer explicitly initialize a CertVerifier in Cronet

    Changed by rsleeviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:02:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d77f2b5485304ef6f4a8b6bba175fbb801da011

    Comments

    No longer explicitly initialize a CertVerifier in Cronet
    
    Support for file-based persistence was removed in r571588,
    so its no longer necessary for Cronet to explicitly create
    a CertVerifier to guarantee it is a CachingCertVerifier.
    
    Bug: 590875
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I23e9e6db12225a7474ce589d9333595729108f1c
    Reviewed-on: https://chromium-review.googlesource.com/1169822
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582330}

    Changed files

    • components/cronet/url_request_context_config.cc
  43. chromeos: Use Screen::GetDisplayForNewWindows in chrome/browser

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:17:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7363ebc06d042af169ab640f33a3d4b985546000

    Comments

    chromeos: Use Screen::GetDisplayForNewWindows in chrome/browser
    
    display::Screen (and ScreenMus) now has the display for new windows,
    so we can use that when making new browser windows under both mash
    and classic ash. Likewise, we can use display::Screen (as ScreenAsh)
    for new windows inside of ash.
    
    This lets me remove ShellStateClient, a different mechanism that
    accomplishes the same goal in a less general way.
    
    Leave ash::ShellState for now. I will clean that up in a separate CL.
    
    TBR=tsepez@chromium.org
    
    Bug: 764009
    Test: existing browser_tests for browser frame/size
    Change-Id: I5c255dc2bf8fdd48f519f148d29aca3d37e7ae73
    Reviewed-on: https://chromium-review.googlesource.com/1168197
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582336}

    Changed files

    • ash/display/screen_ash.cc
    • ash/display/screen_ash.h
    • ash/mojo_interface_factory.cc
    • ash/public/interfaces/BUILD.gn
    • ash/public/interfaces/shell_state.mojom
    • ash/shell_state.cc
    • ash/shell_state.h
    • ash/shell_state_unittest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
    • chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.h
    • chrome/browser/ui/ash/launcher/crostini_app_display.cc
    • chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
    • chrome/browser/ui/ash/shell_state_client.cc
    • chrome/browser/ui/ash/shell_state_client.h
    • chrome/browser/ui/ash/shell_state_client_unittest.cc
    • chrome/browser/ui/window_sizer/window_sizer.cc
    • chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc
    • chrome/test/BUILD.gn
    • ui/display/screen.cc
    • ui/display/screen.h
    • ui/views/mus/screen_mus.cc
    • ui/views/mus/screen_mus.h
  44. Update watchlist for chasej

    Changed by chasejohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:07:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfcd02b9e85ff1aedd636cd9c3dd73fa7cb2612c

    Comments

    Update watchlist for chasej
    
    Remove chasej from background_sync and tweak inclusions for
    origin_trials.
    
    Change-Id: Ie3f19642c491d791f5681ca92e15b34002b51d2e
    Reviewed-on: https://chromium-review.googlesource.com/1171563
    Reviewed-by: Ian Clelland <iclelland@chromium.org>
    Commit-Queue: Jason Chase <chasej@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582332}

    Changed files

    • WATCHLISTS
  45. Add a function to ServiceWorkerContextWrapper which starts a service worker and keeps it alive indefinitely.

    Changed by jonmannohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:05:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b528b403f16d6a2e3f86605ce9974ae63b7d9cad

    Comments

    Add a function to ServiceWorkerContextWrapper which starts a service worker and keeps it alive indefinitely.
    
    This is only for use in ChromeOS for the Android Web Messages native integration.
    
    Change-Id: Id2357f54078c12db0ad25cd9fe0622d57e34a064
    Bug: 850823
    Reviewed-on: https://chromium-review.googlesource.com/1119580
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Commit-Queue: Jon Mann <jonmann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582331}

    Changed files

    • chrome/browser/chrome_service_worker_browsertest.cc
    • content/browser/service_worker/embedded_worker_instance.cc
    • content/browser/service_worker/embedded_worker_registry.cc
    • content/browser/service_worker/embedded_worker_registry.h
    • content/browser/service_worker/embedded_worker_test_helper.cc
    • content/browser/service_worker/service_worker_context_wrapper.cc
    • content/browser/service_worker/service_worker_context_wrapper.h
    • content/browser/service_worker/service_worker_metrics.cc
    • content/browser/service_worker/service_worker_metrics.h
    • content/browser/service_worker/service_worker_version.cc
    • content/common/service_worker/service_worker.mojom
    • content/public/browser/service_worker_context.h
    • content/public/test/fake_service_worker_context.cc
    • content/public/test/fake_service_worker_context.h
    • content/renderer/service_worker/service_worker_context_client.cc
    • content/renderer/service_worker/service_worker_context_client.h
    • tools/metrics/histograms/histograms.xml
  46. Ash: Port two browser frame tests to Ash.

    Changed by estadeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:14:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d30a68227a635fb7ab0f3a98f7280ed0ce189503

    Comments

    Ash: Port two browser frame tests to Ash.
    
    One of them lives on in browser because the Ash version trips a dcheck
    when run in classic Ash mode.
    
    Bug: 854704
    Change-Id: I7822cc088c255b8c16c91cb1b5304c5e2b974115
    Reviewed-on: https://chromium-review.googlesource.com/1170127
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582333}

    Changed files

    • ash/frame/non_client_frame_view_ash.h
    • ash/frame/non_client_frame_view_ash_unittest.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • testing/buildbot/filters/mash.browser_tests.filter
  47. [DOMStorage] blink::CachedStorageArea for onion souping

    Changed by dmurphohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:16:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1571d750d7217703d89c44562678eddde611ad50

    Comments

    [DOMStorage] blink::CachedStorageArea for onion souping
    
    As part of onion souping domstorage this adds a couple of new classes
    to blink more or less duplicating the content equivalents:
    
    CachedStorageArea matches content::LocalStorageCachedArea (with some
    minor API changes, in particular around how it acquires a mojom
    StorageArea). Also has improved test coverage compared to the content
    version.
    
    MockStorageArea is very similar to content::MockLevelDBWrapper (with
    the difference that it doesn't implement StoragePartitionService since
    it doesn't need to with the changed API of CachedStorageArea).
    
    Bug: 781870
    Change-Id: Ic64b3bf307fe275d9287669743f186c8470847bb
    Reviewed-on: https://chromium-review.googlesource.com/1166218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582334}

    Changed files

    • third_party/blink/public/mojom/dom_storage/storage_area.mojom
    • third_party/blink/renderer/modules/DEPS
    • third_party/blink/renderer/modules/storage/BUILD.gn
    • third_party/blink/renderer/modules/storage/cached_storage_area.cc
    • third_party/blink/renderer/modules/storage/cached_storage_area.h
    • third_party/blink/renderer/modules/storage/cached_storage_area_test.cc
    • third_party/blink/renderer/modules/storage/testing/fake_area_source.h
    • third_party/blink/renderer/modules/storage/testing/mock_storage_area.cc
    • third_party/blink/renderer/modules/storage/testing/mock_storage_area.h
  48. Remove obsolete dcheck in Assistant service

    Changed by updowndotaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07f5eb56f751c2ab177a66471742d3f10ee41bf8

    Comments

    Remove obsolete dcheck in Assistant service
    
    Bug: b/112447220
    Test: Manual Test
    Change-Id: Idcab08aca234f9f5528529aedb71fbbbdfa29d1d
    Reviewed-on: https://chromium-review.googlesource.com/1171551
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582335}

    Changed files

    • chromeos/services/assistant/service.cc
  49. [PE] Stop dirtying compositing inputs on any layout for the root PaintLayer.

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:17:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46520ae13478333fe882e79041b667e5a3112796

    Comments

    [PE] Stop dirtying compositing inputs on any layout for the root PaintLayer.
    
    Instead, dirty them on particular PaintLayers only when their layout changed.
    
    Bug: 410867
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Idf7664b869b1e7205e68adc075bcf828f279cffb
    Reviewed-on: https://chromium-review.googlesource.com/1168142
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582337}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
  50. Move BrowserPluginSpecific tests out of web_view_browsertest.cc

    Changed by ekaramadohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:39:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8eb68052e037952a13565c5545ca3fdc9dbac2b9

    Comments

    Move BrowserPluginSpecific tests out of web_view_browsertest.cc
    
    The WebViewBrowserPluginSpecificTest class includes tests which use a
    BrowserPluign-based GuestView. Since all GuestViews except MimeHandlerViewGuest
    are now based on cross-process frames, these tests should not be implemented as
    WebViewGuest tests anymore.
    
    This CL introduces a new chrome browser test target for such
    BrowserPluginSpecific tests where the tests instantiate a MimeHandlerViewGuest
    instead of a <webview>.
    
    Ideally, the tests should have lived with the rest of MimeHandlerViewTests in
    extension layer; however, due to chrome layer dependencies it is not possible.
    
    Bug: 659750, 533069, 330264, 870604
    Change-Id: Ica252a60e94bad47cabbff8b9275b8f9fb05d7ae
    Reviewed-on: https://chromium-review.googlesource.com/1168734
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Reviewed-by: James MacLean <wjmaclean@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582345}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/extensions/api_test/mime_handler_view/index.js
  51. Implement support for new blockquote, caption, and paragraph ARIA roles

    Changed by jdiggsohnoyoudont@igalia.com
    Changed at Friday, 10-Aug-18 21:29:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6712c441cd35a71cdc79aff0d61eb817723b49a3

    Comments

    Implement support for new blockquote, caption, and paragraph ARIA roles
    
    These three roles are part of reaching role parity with HTML5. As such,
    they should be exposed via platform accessibility APIs in the same way
    as their native host language counterparts. Thus just add them to the
    map of ARIA roles to internal roles.
    
    Bug: 849650
    Change-Id: I9a513e187a5beccd57fc5c7306929b0fd194b6dd
    Reviewed-on: https://chromium-review.googlesource.com/1169476
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582340}

    Changed files

    • content/browser/accessibility/browser_accessibility_cocoa.mm
    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/aria/aria-blockquote-expected-android.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-mac.txt
    • content/test/data/accessibility/aria/aria-blockquote-expected-win.txt
    • content/test/data/accessibility/aria/aria-blockquote.html
    • content/test/data/accessibility/aria/aria-caption-expected-android.txt
    • content/test/data/accessibility/aria/aria-caption-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-caption-expected-mac.txt
    • content/test/data/accessibility/aria/aria-caption-expected-win.txt
    • content/test/data/accessibility/aria/aria-caption.html
    • content/test/data/accessibility/aria/aria-paragraph-expected-android.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-auralinux.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-mac.txt
    • content/test/data/accessibility/aria/aria-paragraph-expected-win.txt
    • content/test/data/accessibility/aria/aria-paragraph.html
    • content/test/data/accessibility/html/blockquote-expected-auralinux.txt
    • content/test/data/accessibility/html/caption-expected-auralinux.txt
    • content/test/data/accessibility/html/p-expected-auralinux.txt
    • third_party/blink/renderer/modules/accessibility/ax_object.cc
  52. Make ExecutionMode pretty-printer available for CHECK outside tests

    Changed by joenotcharlesohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:34:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da2cbfa6d74f34482c227e4715bc0b03c3298f01

    Comments

    Make ExecutionMode pretty-printer available for CHECK outside tests
    
    R=proberge
    
    Bug: 872748
    Change-Id: I42ae9acf6bd189ef45543ddfa15521262c56b95f
    Reviewed-on: https://chromium-review.googlesource.com/1171549
    Reviewed-by: proberge <proberge@chromium.org>
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582343}

    Changed files

    • chrome/chrome_cleaner/logging/BUILD.gn
    • chrome/chrome_cleaner/settings/BUILD.gn
    • chrome/chrome_cleaner/test/BUILD.gn
    • chrome/test/BUILD.gn
    • components/chrome_cleaner/public/constants/BUILD.gn
    • components/chrome_cleaner/public/constants/constants.cc
    • components/chrome_cleaner/public/constants/constants.h
    • components/chrome_cleaner/public/constants/constants_test_support.cc
  53. WATCHLISTS entry for GuestView

    Changed by ekaramadohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:32:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c20cee27cd645da5b90c992546aa2cb8ae52d8d1

    Comments

    WATCHLISTS entry for GuestView
    
    Adding an entry 'guest_view' for all GuestView related files.
    
    Subscribing myself, wjmaclean@, and mcnee@ to the list.
    
    Bug: None
    Change-Id: I7751b3cb6d8b3163cdc7f1a11342a56a9cd2849b
    Reviewed-on: https://chromium-review.googlesource.com/1171215
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582341}

    Changed files

    • WATCHLISTS
  54. Adds use of SurfaceLayerBridge into WebMediaPlayerMS.

    Changed by lethalantidoteohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:41:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6e258a17c67e59b03924353b6485f4e36ca612e

    Comments

    Adds use of SurfaceLayerBridge into WebMediaPlayerMS.
    
    This CL allows for WebMediaPlayerMS to create a SurfaceLayerBridge and
    interface with it in order to use a Surface for video playback.
    
    Bug: 746182
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I39174499a7e659eeeef13a81f8f5679d5f73425a
    Reviewed-on: https://chromium-review.googlesource.com/1087587
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582346}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/renderer/media/media_factory.cc
    • content/renderer/media/media_factory.h
    • content/renderer/media/stream/webmediaplayer_ms.cc
    • content/renderer/media/stream/webmediaplayer_ms.h
    • content/renderer/media/stream/webmediaplayer_ms_compositor.h
    • content/renderer/media/stream/webmediaplayer_ms_unittest.cc
    • media/base/media_switches.cc
    • media/base/media_switches.h
    • media/blink/webmediaplayer_impl.h
    • media/blink/webmediaplayer_params.cc
    • media/blink/webmediaplayer_params.h
    • tools/metrics/histograms/enums.xml
  55. [layoutng] Store borders on fragments as well

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:29:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3584222f068fd6c16e2203b8c845945b3aba8f05

    Comments

    [layoutng] Store borders on fragments as well
    
    This avoids recomputing them later.
    
    Also, changes RunOldLayout to use legacy layout to
    compute border/padding to store on the fragment,
    which seems more correct.
    
    R=eae@chromium.org
    
    Bug: 635619
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Id659d7c92eae81431d8e75a26ac3973421afc3d0
    Reviewed-on: https://chromium-review.googlesource.com/1169634
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582339}

    Changed files

    • third_party/blink/renderer/core/layout/ng/layout_ng_block_flow.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_box_fragment.h
    • third_party/blink/renderer/core/layout/ng/ng_column_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_flex_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_fragment_builder.cc
    • third_party/blink/renderer/core/layout/ng/ng_fragment_builder.h
    • third_party/blink/renderer/core/layout/ng/ng_page_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment.h
  56. Disable debug fission under Fuchsia.

    Changed by wezohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:39:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f273ccbde526a7402e715821163d8349627bf56

    Comments

    Disable debug fission under Fuchsia.
    
    The symbolization in the Fuchsia runner scripts is not set up to work
    with debug information partly split from the binary.
    
    Bug: 777008
    Change-Id: Iedaf4fe56cc8092af21acfd0d244304982a6035c
    Reviewed-on: https://chromium-review.googlesource.com/1170440
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582344}

    Changed files

    • build/config/compiler/BUILD.gn
  57. Removed ExternalURLTabUsageRecorderTestCase

    Changed by pklohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:32:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f7fafa75c2080ef3a234472c8926be2ade8b04b

    Comments

    Removed ExternalURLTabUsageRecorderTestCase
    
    Removed ExternalURLTabUsageRecorderTestCase since it contains only one
    disabled Earl Grey test. After some evaluation of the intention of the
    test, it is not clear what purpose it serves/served or whether the code
    being tested isn't already covered by unit tests.
    
    Bug: 852341
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I988f4fc5512b40f331db565af2424e03b5c23b79
    Reviewed-on: https://chromium-review.googlesource.com/1171365
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582342}

    Changed files

    • ios/chrome/browser/metrics/BUILD.gn
    • ios/chrome/browser/metrics/external_url_tab_usage_recorder_egtest.mm
    • ios/chrome/test/earl_grey/BUILD.gn
  58. Uprev env version for rtanalytics-light to 5.0.

    Changed by lasorenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:43:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bc2ecee4a37ac2fbe251c595b8403048319a5c79

    Comments

    Uprev env version for rtanalytics-light to 5.0.
    
    This is to reflect non-forwards / non-backwards compatible changes to
    the interface between rtanalytics_main and librtanalytics.so due to the
    changes to incorporate the use of the Mojo IPC-based video capture
    service.
    
    Bug: 871884
    Change-Id: I97c92be7143609026d34e824b29f524e1f386f11
    Reviewed-on: https://chromium-review.googlesource.com/1165824
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Luke Sorenson <lasoren@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582348}

    Changed files

    • chrome/browser/component_updater/cros_component_installer_chromeos.cc
  59. [Chromecast] Backwards compatible AudioFocus

    Changed by shyamsundarpohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:43:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ccd3df3bec6871edb3531a8a239f5a44a5bb4290

    Comments

    [Chromecast] Backwards compatible AudioFocus
    
    Creating an abstraction called CastAudioFocusRequest to handle backwards
    compatibility of AudioFocus methods in AudioManager.
    
    Merge-With: eureka-internal/191659
    Bug: 112064938
    Test: junit test
    Change-Id: I914cec6a6bd2179f02ab5fd6959fcf3157b3e637
    Reviewed-on: https://chromium-review.googlesource.com/1165884
    Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
    Commit-Queue: Shyamsundar Parthasarathy <shyamsundarp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582347}

    Changed files

    • chromecast/browser/android/BUILD.gn
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastAudioFocusRequest.java
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastAudioManager.java
    • chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastAudioFocusRequestTest.java
    • chromecast/browser/android/junit/src/org/chromium/chromecast/shell/CastAudioManagerTest.java
  60. Browser Themes: always paint an opaque BG color behind toolbar images

    Changed by estadeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:51:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eeddc1fcb0a7897d31eadfddfbf621ce9e9bdaf2

    Comments

    Browser Themes: always paint an opaque BG color behind toolbar images
    
    for both the active tab and the toolbar. This matches the bookmarks
    bar, i.e. PaintBackgroundAttachedMode.
    
    Bug: 866974
    Change-Id: I3a86d2330bf09903f74359e433a4165e3e4d3e8e
    Reviewed-on: https://chromium-review.googlesource.com/1171216
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582350}

    Changed files

    • chrome/browser/ui/views/tabs/tab.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
  61. Revert "[ChromeDriver] Fix path for old Chromium snapshots"

    Changed by martinissohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5e8bf6941f0fb31103ad926e86729d45b276e01

    Comments

    Revert "[ChromeDriver] Fix path for old Chromium snapshots"
    
    This reverts commit 306be5bf43aee024bf3e91bd2fd3414020ecdb3b.
    
    Reason for revert: GS bucket names have been fixed
    
    Original change's description:
    > [ChromeDriver] Fix path for old Chromium snapshots
    > 
    > Chromium snapshots before revision 579575 are still archived using
    > the old directory name.
    > 
    > TBR=crouleau@chromium.org
    > 
    > Change-Id: I4cc1e9ca51af9f8f21e22214af2110a6d8be8fe7
    > Reviewed-on: https://chromium-review.googlesource.com/115
    ...skip...
    n@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#579802}
    
    TBR=crouleau@chromium.org,johnchen@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I093548f1d0ef02a37ffd8d3d2fe66f7222234e1b
    Reviewed-on: https://chromium-review.googlesource.com/1171426
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582338}

    Changed files

    • chrome/test/chromedriver/archive.py
  62. Make cert transparency histogram work with the NetworkService.

    Changed by mmenkeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:47:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9cad56fca85981a14b10d32acd4e7039d0d368d

    Comments

    Make cert transparency histogram work with the NetworkService.
    
    In particular, move Net.CertificateTransparency.MainFrameValidSCTCount
    from ResourceDispatcherHost to NavigationURLLoaderImpl.
    
    Bug: 859364
    Change-Id: I2258fc36af30b64b76eb7c5bc2c1f9851bb0f1be
    Reviewed-on: https://chromium-review.googlesource.com/1168093
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582349}

    Changed files

    • content/browser/loader/navigation_url_loader_impl.cc
    • content/browser/loader/resource_dispatcher_host_impl.cc
  63. Update build instructions to recommend using autoninja instead of ninja.

    Changed by mmorozohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:55:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5b31fcd43e0d557a4a641c434aecb760a6a4419

    Comments

    Update build instructions to recommend using autoninja instead of ninja.
    
    Change-Id: I327542d2ec81be8d3d4240a82f7121c27c4994b3
    Reviewed-on: https://chromium-review.googlesource.com/1169427
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Max Moroz <mmoroz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582351}

    Changed files

    • docs/accessibility/chromevox_on_desktop_linux.md
    • docs/accessibility/tests.md
    • docs/android_build_instructions.md
    • docs/code_coverage.md
    • docs/fuchsia_build_instructions.md
    • docs/how_to_add_your_feature_flag.md
    • docs/linux_build_instructions.md
    • docs/mac_build_instructions.md
    • docs/testing/layout_tests.md
    • docs/windows_build_instructions.md
  64. Web Locks API: Update spec/explainer/idl links

    Changed by jsbellohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision beaa8766c0bea15820663d2881ad782c0c99eddb

    Comments

    Web Locks API: Update spec/explainer/idl links
    
    Spec work has moved into the WICG repository, so update links:
    
    Explainer: https://github.com/WICG/web-locks/
    Spec: https://wicg.github.io/web-locks/
    
    Bug: 161072
    Change-Id: I450beb25d8a7c9c0a80b06b7e84d7ac8db3cece1
    Reviewed-on: https://chromium-review.googlesource.com/1171213
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582356}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/web-locks/META.yml
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/README.md
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/acquire.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/clientids.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/frames.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/held.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/ifAvailable.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/interfaces-serviceworker.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/lock-attributes.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-exclusive.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-mixed.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/mode-shared.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/non-secure-context.tentative.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/opaque-origin.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-empty.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query-order.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/query.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/resource-names.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/secure-context.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/signal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/steal.tentative.https.html
    • third_party/WebKit/LayoutTests/external/wpt/web-locks/workers.tentative.https.html
    • third_party/blink/renderer/modules/locks/lock.idl
    • third_party/blink/renderer/modules/locks/lock_info.idl
    • third_party/blink/renderer/modules/locks/lock_manager.idl
    • third_party/blink/renderer/modules/locks/lock_manager_snapshot.idl
    • third_party/blink/renderer/modules/locks/lock_options.idl
    • third_party/blink/renderer/modules/locks/navigator_locks.idl
    • third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
  65. Remove has_received_pointer_over state in PEM

    Changed by nzolghadrohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:08:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0791976d2925f80203afb4a3248033c7a3a6e2de

    Comments

    Remove has_received_pointer_over state in PEM
    
    We used to store whether the target of pointerevent
    has recieved pointerover event or not to handle this
    correctly when capture gets active or lost. But since
    then the spec has change which made this state
    unnecessary.
    
    Change-Id: I98eed286b47463d2e103495ec66750d01e3fe58b
    Reviewed-on: https://chromium-review.googlesource.com/1169918
    Reviewed-by: Ella Ge <eirage@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582354}

    Changed files

    • third_party/blink/renderer/core/input/pointer_event_manager.cc
    • third_party/blink/renderer/core/input/pointer_event_manager.h
  66. Reland "Android: moving FileEnumWorkerTask to thread pool"

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 21:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1b5ee020fc4770291e328a91652f948f6b53206

    Comments

    Reland "Android: moving FileEnumWorkerTask to thread pool"
    
    This reverts commit c2af33f66d4079e4306fb698828d6d9d6d4fbe95.
    
    Reason for revert: Just re landing now that gerrit is OK
    
    Original change's description:
    > Revert "Android: moving FileEnumWorkerTask to thread pool"
    >
    > This reverts commit 5eb802f9e1b7c765f77ec4a61f7f448731c36811.
    >
    > Reason for revert: Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questions, plea
    ...skip...
    i Shyshkalov <tandrii@chromium.org>
    
    TBR=finnur@chromium.org,tandrii@chromium.org,smaier@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    TBR=Gerrit reland
    
    Bug: 869907
    Change-Id: I4e07a7d43ae7f0af01a248f4c41d42699d041f30
    Reviewed-on: https://chromium-review.googlesource.com/1171427
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582352}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerCategoryView.java
  67. Handle avoid_stencil_buffers workaround in OOP-R

    Changed by enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa0603bbbdbe385af7d7a4654fa8ef1796b262a0

    Comments

    Handle avoid_stencil_buffers workaround in OOP-R
    
    This could be handled in Skia, but there's already a context option for
    it, so just forward the workaround setting to that.
    
    Bug: 829614
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Iaeb625ea327b814d07854dd81eb0458598a0c137
    Reviewed-on: https://chromium-review.googlesource.com/1169771
    Commit-Queue: enne <enne@chromium.org>
    Reviewed-by: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582353}

    Changed files

    • gpu/command_buffer/service/raster_decoder_context_state.cc
  68. Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c86f4a25a967715e1b357d2519a3b5fa75606fa5

    Comments

    Revert "cros: In OOBE, turn off scrolling if the screen fits in the container"
    
    This reverts commit 3963b98df61fe488ddbd007ac5933cf62beff0df.
    
    Reason for revert: Consistent failures in ProfileWindowWebUIBrowserTest.UserManagerFocusSingleProfile, see e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/36834
    
    Original change's description:
    > cros: In OOBE, turn off scrolling if the screen fits in the container
    > 
    > Bug: 855546
    > Change-Id: I065c2bbd1e3db69dca3f8b18d
    ...skip...
    g>
    > Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582312}
    
    TBR=alemate@chromium.org,jdufault@chromium.org,qnnguyen@chromium.org
    
    Change-Id: Icd9a6648582e8c49bcdbd4bd79d844745d54c2a9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 855546
    Reviewed-on: https://chromium-review.googlesource.com/1171703
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582355}

    Changed files

    • ui/login/display_manager.js
  69. Reland "Android: moving MediaUrlResolver tasks to thread pool"

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e9102edc99321bd860523f03cfd63aa153738c9a

    Comments

    Reland "Android: moving MediaUrlResolver tasks to thread pool"
    
    This reverts commit 108f9e6cb07bdf3327b8b62e3ad43703b854662d.
    
    Reason for revert: Just re landing now that gerrit is OK
    
    Original change's description:
    > Revert "Android: moving MediaUrlResolver tasks to thread pool"
    > 
    > This reverts commit d20f6cb34484fbd5e7ca2c651974d71c62e2f4d0.
    > 
    > Reason for revert:Due to Gerrit outage http://crbug.com/872722, we are reverting this CL. Please, re-land it after all clear is given. If you have questi
    ...skip...
     https://chromium-review.googlesource.com/1169854
    > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    
    TBR=mlamouri@chromium.org,tandrii@chromium.org,smaier@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 869907
    Change-Id: I31b02f5b543f2fdb8b0b089f241d79ceb720a626
    Reviewed-on: https://chromium-review.googlesource.com/1171702
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Reviewed-by: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582358}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/DefaultMediaRouteController.java
    • chrome/android/junit/src/org/chromium/chrome/browser/media/remote/MediaUrlResolverTest.java
  70. [ChromeDriver] Fix location of browser snapshots

    Changed by johnchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46fa89282e8f5cbffee0c90f32dc3d1d998edc54

    Comments

    [ChromeDriver] Fix location of browser snapshots
    
    TBR=crouleau@chromium.org
    
    Change-Id: Id77c7546989bed6f3fdb269abdc2bc2e976ca4cd
    Reviewed-on: https://chromium-review.googlesource.com/1171679
    Reviewed-by: John Chen <johnchen@chromium.org>
    Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
    Commit-Queue: John Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582357}

    Changed files

    • chrome/test/chromedriver/archive.py
  71. Fix search for next time limit start.

    Changed by hgrandinettiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:28:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1765353f3e592cc34c422b6146c0f4b5c1dd0dee

    Comments

    Fix search for next time limit start.
    
    In some situations the next Time Window Limit was not calculated correctly, this
    caused the TimeLimitController to recalculate the time limit constantly.
    
    Bug: 873228
    Change-Id: I6b88792aa6849774778d85d8dea2695192acc172
    Reviewed-on: https://chromium-review.googlesource.com/1171114
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#582359}

    Changed files

    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor.cc
    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor_unittest.cc
  72. [CRD iOS] Using the new audio playback logic

    Changed by yuweihohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e640c47e6cb75a8385ebba2e2aa31aeba732bf

    Comments

    [CRD iOS] Using the new audio playback logic
    
    This CL finishes up the rest of the work of refactoring the audio
    playback logic on iOS.
    
    Bug: 868088
    Change-Id: Iac4c240a8f98a1212bf65c056546f2f3ad14dd2d
    Reviewed-on: https://chromium-review.googlesource.com/1166339
    Commit-Queue: Yuwei Huang <yuweih@chromium.org>
    Reviewed-by: Joe Downing <joedow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582365}

    Changed files

    • remoting/client/audio/BUILD.gn
    • remoting/client/audio/audio_playback_stream.cc
    • remoting/client/audio/audio_playback_stream.h
    • remoting/ios/session/remoting_client.mm
  73. ScopedMockClockOverride: Include <memory>

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Friday, 10-Aug-18 22:35:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 51d6da99705952697ed233f6cf9e63e06438ca5d

    Comments

    ScopedMockClockOverride: Include <memory>
    
    IWYU: std::unique_ptr needs <memory>. This fixes the libstdc++ build:
    
        In file included from ../../base/test/scoped_mock_clock_override.cc:5:0:
        ../../base/test/scoped_mock_clock_override.h:39:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type
           std::unique_ptr<base::subtle::ScopedTimeClockOverrides> time_clock_overrides_;
                ^~~~~~~~~~
    
    Bug: 818294
    Change-Id: I3b92e51f2565b42869cf2400dd4d3654e112f0fb
    Reviewed-on: https://chromium-review.googlesource.com/1170837
    Reviewed-by: Charlie Andrews <charliea@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#582361}

    Changed files

    • base/test/scoped_mock_clock_override.h
  74. assistant: fix unitialized read

    Changed by skyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:46:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 492cb6c0acd8a7714cd8d298d8d8bd83e65edc5d

    Comments

    assistant: fix unitialized read
    
    VisibilityChanged() tests the is_visible_ member before it's been set to any
    value.
    
    BUG=none
    TEST=none
    TBR=xiaohuic@chromium.org
    
    Change-Id: Ic2e95e1f5e615f1621431ab0bd2b8126bcfb87d2
    Reviewed-on: https://chromium-review.googlesource.com/1171553
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582370}

    Changed files

    • ash/assistant/ui/main_stage/assistant_progress_indicator.h
  75. Never show shortcuts in contextual menus on the Mac.

    Changed by aviohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c50480db92fe1220814910400ace4683a4d438a

    Comments

    Never show shortcuts in contextual menus on the Mac.
    
    This is platform convention.
    
    BUG=869564
    TEST=as in bug
    
    Change-Id: I3a4dbec12c5047219f255694eb4251405422e8fe
    Reviewed-on: https://chromium-review.googlesource.com/1164307
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582363}

    Changed files

    • ui/base/cocoa/menu_controller.mm
  76. Disable failing test (FLAKY_ has no meaning)

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:43:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b6a32c22de15bea00ed58fa55fdeafdb91767f6

    Comments

    Disable failing test (FLAKY_ has no meaning)
    
    Bug: 871812
    Change-Id: I0e4ee3e6539a6e4fa6c48495782a75a74a71dbc3
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171681
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582366}

    Changed files

    • third_party/blink/renderer/core/css/font_face_cache_test.cc
  77. Diable a flaky test on CrOS for the same reason as others on this bug.

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:42:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8ac232aec054638f6bfd13c783ef7d7d32e48d6

    Comments

    Diable a flaky test on CrOS for the same reason as others on this bug.
    
    Bug: 870732
    Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7
    TBR: mgiuca
    Reviewed-on: https://chromium-review.googlesource.com/1171738
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582364}

    Changed files

    • chrome/browser/password_manager/password_manager_browsertest.cc
  78. Fix suggestion chip too long issue

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:41:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e448af80c5ba070e15aa387564fc8708fab6edf8

    Comments

    Fix suggestion chip too long issue
    
    Changes:
    Make the suggestion chip text length no longer than 192dip.
    
    Bug: 872948
    Change-Id: I54bc24cfc5b0ecf50d05e8312413e72ca14276e9
    Reviewed-on: https://chromium-review.googlesource.com/1171676
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582362}

    Changed files

    • ash/app_list/views/suggestion_chip_view.cc
  79. cc: Increase layer tree test timeout for CFI

    Changed by enneohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:44:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3df98f1195e5772ddbb2e369527e7fa3a920ce9

    Comments

    cc: Increase layer tree test timeout for CFI
    
    Also, generally increase the timeout for layer tree tests.  Most things
    don't need this, however the GL versions of pixel tests end up spending
    quite a bit of time to compile shaders.  When run in parallel, this
    only exacerbates the problem and tests can time out.  Be more generous
    so that folks stop turning off these tests.
    
    Bug: 872733
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I7c08212d454bf0d9ae6ea445fcb46b48b73aea88
    Reviewed-on: https://chromium-review.googlesource.com/1171377
    Reviewed-by: weiliangc <weiliangc@chromium.org>
    Commit-Queue: enne <enne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582367}

    Changed files

    • cc/test/layer_tree_test.cc
  80. [Cast discovery] Reset device lister on ForceDiscovery / user gesture.

    Changed by imchengohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:47:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 485629bea392f67ff70fcbed5007f2f91b171737

    Comments

    [Cast discovery] Reset device lister on ForceDiscovery / user gesture.
    
    We've seen cases where Cast discovery code fails to pick up services
    from the ServiceDiscoveryDeviceLister, whereas chrome://inspect
    (CastDeviceProvider) is able to do so. Since Cast discovery's
    ServiceDiscoveryDeviceLister is only created once and is long-lived,
    this suggests it has gone into a bad state after a prolonged period.
    Compared to the CastDeviceProvider's ServiceDiscoveryDeviceLister,
    which gets created/destroyed when 
    ...skip...
    iceLister
    and kick off the discovery using the new object, and to clear the set
    of services in the cache. This puts DnsSdDeviceLister in a clean state
    which will the current set of services to get through to the Cast
    discovery code.
    
    Bug: 850770
    Change-Id: I3183e9d80f1a4a047b607fe5f844cdfc892f1463
    Reviewed-on: https://chromium-review.googlesource.com/1166022
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Reviewed-by: mark a. foltz <mfoltz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582371}

    Changed files

    • chrome/browser/extensions/api/mdns/mdns_api.cc
    • chrome/browser/extensions/api/mdns/mdns_apitest.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc
    • chrome/browser/media/router/discovery/mdns/cast_media_sink_service_unittest.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_device_lister.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.cc
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry.h
    • chrome/browser/media/router/discovery/mdns/dns_sd_registry_unittest.cc
    • chrome/browser/media/router/test/mock_dns_sd_registry.h
  81. [omnibox/drive] Updates for /v1beta -> /v1 api migration.

    Changed by skareohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cf7e0b53900f489bcfb7bd7db7b356cfb31d2e5

    Comments

    [omnibox/drive] Updates for /v1beta -> /v1 api migration.
    
    -Use originalURL if provided to dedupe against history.
    -Fix "typo" for corpus restrict request param (I missed it was renamed).
    -Sanitize title, provide default match data.
    
    Bug: 873290
    Change-Id: Idc2d0dd92a6afedc7086c283fe85bb4257a800d3
    Reviewed-on: https://chromium-review.googlesource.com/1171550
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Travis Skare <skare@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582372}

    Changed files

    • components/omnibox/browser/document_provider.cc
    • components/omnibox/browser/document_suggestions_service.cc
  82. fido/mac: look up credential IDs before proceeding with GetAssertion requests

    Changed by martinkrohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:46:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4ac527a4777da75ba6c44ed4a7e1837ed92693d

    Comments

    fido/mac: look up credential IDs before proceeding with GetAssertion requests
    
    This changes the GetAssertion operation for the Touch ID authenticator
    to locate credential IDs in the keychain at the beginning of the
    request. If no matching credential exists, the user is not prompted for
    a fingerprint. A method to locate a credential by ID is extracted from
    the existing code and moved into the Keychain class.
    
    This is done in anticipation of adding the WebAuthn UI. With the new UI,
    GetAssertion requests will only be sent to the Touch ID authenticator,
    if we know a matching credential ID to exist in the keychain.
    
    Bug: 871370
    
    Change-Id: Ie5e4916df2a68bc0e9d7552322d6b993069ce95b
    Reviewed-on: https://chromium-review.googlesource.com/1163927
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582369}

    Changed files

    • device/fido/mac/get_assertion_operation.h
    • device/fido/mac/get_assertion_operation.mm
    • device/fido/mac/keychain.h
    • device/fido/mac/keychain.mm
    • device/fido/mac/operation_base.h
  83. [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz

    Changed by gabohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:48:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bf388aef924443453385373971d022f03652981

    Comments

    [TaskScheduler] Cleanup all remaining base/task_scheduler references for realz
    
    https://cs.chromium.org/search/?q=%22base/task_scheduler%22&sq=package:chromium&type=cs
    will be empty after this CL
    
    TBR=fdoray@chromium.org
    
    Change-Id: I636ff813e461379acfb2822f58034cdd756e7d49
    Reviewed-on: https://chromium-review.googlesource.com/1171108
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582373}

    Changed files

    • WATCHLISTS
    • base/task/task_scheduler/task_scheduler.h
  84. Increase DevTools SystemInfoGPU timeout for Windows.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:55:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c9cf51bc70b424ce8d9849d24c115a7f6930772

    Comments

    Increase DevTools SystemInfoGPU timeout for Windows.
    
    Before this CL, DevTools would crash the browser if it did not get a response in
    5 seconds. This timeout is too low for Windows. On Catapult perf tests on
    Windows, it takes ~3 seconds for the GPU process to respond on average, and
    sometimes it takes more than 5 seconds.
    
    Bug: 873112
    Change-Id: I67ee82a1a75df0ba9e1b483a58c66c56a8bf2213
    Reviewed-on: https://chromium-review.googlesource.com/1170584
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582375}

    Changed files

    • content/browser/devtools/protocol/system_info_handler.cc
  85. cros: Add common fingerprint images in ui/chromeos/resources.

    Changed by xiaoyinhohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ccd841a0bbf56f3ddc4ebfbf2430404da75a86f

    Comments

    cros: Add common fingerprint images in ui/chromeos/resources.
    
    This will be used by both oobe and settings.
    
    Bug: 873229
    Change-Id: I1bb3ff8e9666e967ff5445d68085801d009894d5
    Reviewed-on: https://chromium-review.googlesource.com/1171243
    Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582374}

    Changed files

    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_100_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_100_percent/fingerprint/tick.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint.png
    • ui/chromeos/resources/default_200_percent/fingerprint/fingerprint_scanner.png
    • ui/chromeos/resources/default_200_percent/fingerprint/tick.png
    • ui/chromeos/resources/ui_chromeos_resources.grd
  86. Fix a typo in documentation.

    Changed by eromanohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:56:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c3c53b6d5652202ab79edad721a4a04fb0ccb79

    Comments

    Fix a typo in documentation.
    
    Change-Id: Ibbde1b31fdeade51caf0cb70fefbe915bd7a9af6
    Reviewed-on: https://chromium-review.googlesource.com/1169693
    Commit-Queue: Eric Roman <eroman@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582376}

    Changed files

    • mojo/public/cpp/bindings/callback_helpers.h
  87. Add iframe support to the Captured Sites Automation Framework.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 22:35:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 02345664549dc8febb3ed7c839ea98573cd709e8

    Comments

    Add iframe support to the Captured Sites Automation Framework.
    
    This change allows the Captured Sites Automation Framework to replay
    interactions on iframes. As part of this change, I switched the
    automation framework to trigger the autofill popup by clicking on an
    input field instead of pressing the 'DOWN' key, which does not work in
    automation on some iframes.
    
    Also included in this change is a fix I made to address the issue that
    calling 'ASSERT' inside a test function does not abort the test.
    
    Change-Id: I15b30f878f04cb3ee2935879c2da4c474442ab27
    Reviewed-on: https://chromium-review.googlesource.com/1161603
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582360}

    Changed files

    • chrome/browser/autofill/autofill_captured_sites_interactive_uitest.cc
    • chrome/browser/autofill/autofill_uitest.cc
    • chrome/browser/autofill/autofill_uitest.h
    • chrome/browser/autofill/captured_sites_test_utils.cc
    • chrome/browser/autofill/captured_sites_test_utils.h
    • chrome/test/data/autofill/captured_sites/amazon.test
    • chrome/test/data/autofill/captured_sites/apple.test
    • chrome/test/data/autofill/captured_sites/ebay.test
    • chrome/test/data/autofill/captured_sites/walmart.test
    • chrome/test/data/autofill/captured_sites/zappos.test
  88. [TTS] Remove unused DEPS file.

    Changed by donndohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:57:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b54b3b3f4c92fac9a597039d7026120e4769a5d4

    Comments

    [TTS] Remove unused DEPS file.
    
    Change-Id: I100542f77eb1ebebf28db6c716733467be61c209
    Reviewed-on: https://chromium-review.googlesource.com/1168503
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Donn Denman <donnd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582377}

    Changed files

    • components/contextual_search/browser/DEPS
  89. Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().

    Changed by masonfreedohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 23:14:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95e719856c142dd807b287f535e3a597c3112e5e

    Comments

    Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().
    
    Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and
    dereferencing it. To better document the fact that these calls (properly, in most cases)
    assume the layout object contains style, they should be replaced with calls to the StyleRef()
    function, which dereferences the pointer.
    
    Bug: 872508
    Change-Id: Id6a04871c12a2c09d1029ca5aa04ae49099f7fd0
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1171144
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: Mason Freed <masonfreed@google.com>
    Cr-Commit-Position: refs/heads/master@{#582380}

    Changed files

    • third_party/blink/renderer/core/paint/block_painter.cc
    • third_party/blink/renderer/core/paint/box_painter.cc
    • third_party/blink/renderer/core/paint/collapsed_border_painter.cc
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
    • third_party/blink/renderer/core/paint/css_mask_painter.cc
    • third_party/blink/renderer/core/paint/details_marker_painter.cc
    • third_party/blink/renderer/core/paint/fieldset_painter.cc
    • third_party/blink/renderer/core/paint/file_upload_control_painter.cc
    • third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
    • third_party/blink/renderer/core/paint/inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/link_highlight_impl.cc
    • third_party/blink/renderer/core/paint/list_marker_painter.cc
    • third_party/blink/renderer/core/paint/multi_column_set_painter.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/replaced_painter.cc
    • third_party/blink/renderer/core/paint/root_inline_box_painter.cc
    • third_party/blink/renderer/core/paint/scrollable_area_painter.cc
    • third_party/blink/renderer/core/paint/svg_image_painter.cc
    • third_party/blink/renderer/core/paint/svg_inline_text_box_painter.cc
    • third_party/blink/renderer/core/paint/svg_model_object_painter.cc
    • third_party/blink/renderer/core/paint/svg_shape_painter.cc
    • third_party/blink/renderer/core/paint/table_cell_painter.cc
    • third_party/blink/renderer/core/paint/table_painter.cc
    • third_party/blink/renderer/core/paint/view_painter.cc
  90. Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used

    Changed by chengxohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:13:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fea7ed541cd675d0ac5d17b2f8fcd6ac82edcffc

    Comments

    Retire SampleOrderingSpec::PRESERVE_ORDER as it's not used
    
    Since SampleOrderingSpec::MAY_SHUFFLE is the only one used in production
    code, there is no need to specify the SampleOrderingSpec parameter hence
    SampleOrderingSpec enum is also retired.
    
    Bug: 851163
    Change-Id: Ie9bf7c39d036db55b1533c4fe3b3f3293a2a8dbf
    Reviewed-on: https://chromium-review.googlesource.com/1171584
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Reviewed-by: Mike Wittman <wittman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582379}

    Changed files

    • chrome/common/thread_profiler.cc
    • components/metrics/call_stack_profile_builder.cc
    • components/metrics/call_stack_profile_builder_unittest.cc
    • components/metrics/call_stack_profile_params.h
    • components/metrics/call_stack_profile_proto_encoder.cc
    • components/metrics/call_stack_profile_proto_encoder.h
    • components/metrics/call_stack_profile_proto_encoder_unittest.cc
  91. CATransactionGPUCoordinator: Re-enable and make lifetime explicit

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:10:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62892558b716d1560264e42929e2be01ead07e71

    Comments

    CATransactionGPUCoordinator: Re-enable and make lifetime explicit
    
    Disalbing the CATransactionGPUCoordinator caused memory corruption bugs
    to go away.
    
    Fix two potential bugs:
    
    1.  Don't post tasks (and potentially change the reference count) inside
        CATransactionGPUCoordinator's constructor. Do this in a separate
        explicit Init function.
    
    1a. Move this initialization to the end of GpuProcessHost:Init (instead
        of being at the beginning of the constructor).
    
    2.  Make CATransactionCoordinator 
    ...skip...
    actionGPUCoordinator). This fixes a bug
        whereby at shutdown, destroying not-yet-executed posted tasks caused
        the CATransactionGPUCoordinator to be destroyed while the
        CATransactionCoordinator still had a raw pointer to it.
    
    Bug: 871430
    Change-Id: Ie144071cce9ce48e0187cdaf1fcf32df7b62ed75
    Reviewed-on: https://chromium-review.googlesource.com/1171657
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582378}

    Changed files

    • content/browser/gpu/ca_transaction_gpu_coordinator.cc
    • content/browser/gpu/ca_transaction_gpu_coordinator.h
    • content/browser/gpu/gpu_process_host.cc
    • ui/accelerated_widget_mac/ca_transaction_observer.h
    • ui/accelerated_widget_mac/ca_transaction_observer.mm
  92. Android: Update Android Studio canary version

    Changed by wnwenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 22:45:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31634c4f1eae7d2fbac13a7542a0c939417d62f4

    Comments

    Android: Update Android Studio canary version
    
    Bug: 620034
    Change-Id: I33a4437e3fe54f9b7d7ce234a823d4bb05c2046b
    Reviewed-on: https://chromium-review.googlesource.com/1169425
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582368}

    Changed files

    • build/android/gradle/root.jinja
  93. Increase shards for android buildbot

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:26:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 091a32d416d74d48bcaec9693c0ae2589bc2b986

    Comments

    Increase shards for android buildbot
    
    I increased shards for some tests took time on
    https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel/59189
    
    Bug: 868114
    Change-Id: I9ae5c80e0fe641f8946e0d00d8a322721d2de079
    Reviewed-on: https://chromium-review.googlesource.com/1170922
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582381}

    Changed files

    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/test_suites.pyl
  94. [NTP] Fix arrow navigation order of the restore default options

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:37:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c77a5b154fdb9105958e026f285742b8cef125

    Comments

    [NTP] Fix arrow navigation order of the restore default options
    
    The "Restore default shortcuts" and "Restore default background" options
    are swapped when navigating with arrow keys.
    
    Bug: 872978
    Change-Id: I6078a6fb0a004a81e321a39f08e1f024bf53e9e1
    Reviewed-on: https://chromium-review.googlesource.com/1170195
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582386}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.js
  95. Fix misspelling "existance"

    Changed by wychenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:31:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fec2acecd6a5c82ae15b48fca7d1aa14de1650f4

    Comments

    Fix misspelling "existance"
    
    third_party/ is excluded, except for third_party/WebKit and
    third_party/blink.
    
    This is uncovered by:
    https://chromium-swarm.appspot.com/task?id=3f2afb7b4290f910
    
    Bug: None
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ie17ea50e7f6aba3538acb488df92b4926b52f4c4
    Reviewed-on: https://chromium-review.googlesource.com/1170441
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582384}

    Changed files

    • .gn
    • cc/layers/texture_layer_impl.h
    • cc/trees/layer_tree_settings.h
    • components/metrics/persistent_system_profile.h
    • ios/chrome/browser/ui/browser_view_controller.mm
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure.html
    • third_party/WebKit/LayoutTests/external/wpt/user-timing/measure_navigation_timing.html
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/extensions/multiple-extensions.js
    • third_party/WebKit/LayoutTests/jquery/resources/test/unit/traversing.js
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_posix.cc
    • third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_file_system_win.cc
    • third_party/blink/renderer/modules/xr/xr_device.cc
    • tools/chrome_proxy/webdriver/protocol_fuzz.py
  96. Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 23:29:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision afe7c7414699ca66dbf49b162ab2c49083889a4d

    Comments

    Roll src/third_party/pdfium e1a7e8589a8c..f36a4644b828 (7 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e1a7e8589a8c..f36a4644b828
    
    
    git log e1a7e8589a8c..f36a4644b828 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 rharrison@chromium.org Remove direct calls to time
    2018-08-10 rharrison@chromium.org Add proxy for syscall time
    2018-08-10 tsepez@chromium.org Remove |typedef struct| in favor of just |struct|.
    2018-08-10 tsepez@chromium.org Consolidate const_casts<> in FXFT_Get_Name_
    ...skip...
    should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:871848
    TBR=dsinclair@chromium.org
    
    Change-Id: I22721ff61265f49fddd6ffc647ef37cc2f70bc0c
    Reviewed-on: https://chromium-review.googlesource.com/1171442
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582382}

    Changed files

    • DEPS
  97. [ios] Add accessibility identifier for "show history" cell in Recent Tabs

    Changed by thegreenfrogohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:30:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bef755ef86d5e4e225a5f70a58858a9078e095f

    Comments

    [ios] Add accessibility identifier for "show history" cell in Recent Tabs
    
    Change-Id: Ib6bcee51114a9fcb05aacd9079d52b65356e18d2
    Reviewed-on: https://chromium-review.googlesource.com/1171680
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582383}

    Changed files

    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.h
    • ios/chrome/browser/ui/ntp/recent_tabs/recent_tabs_constants.mm
    • ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.h
    • ios/chrome/browser/ui/table_view/cells/table_view_accessory_item.mm
  98. [Explore Sites] Create a keyed service.

    Changed by dewittjohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:32:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40f76ee9d98b9b20c8fd7997786fa11e4352cee8

    Comments

    [Explore Sites] Create a keyed service.
    
    This will host the ExploreSites datastore as well as the downloader.
    
    BUG=867488
    
    Change-Id: Ifff84b6c8316033929ccbd52c32c2f175af117c8
    Reviewed-on: https://chromium-review.googlesource.com/1169588
    Reviewed-by: Cathy Li <chili@chromium.org>
    Commit-Queue: Justin DeWitt <dewittj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582385}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/android/explore_sites/explore_sites_service.h
    • chrome/browser/android/explore_sites/explore_sites_service_factory.cc
    • chrome/browser/android/explore_sites/explore_sites_service_factory.h
    • chrome/browser/android/explore_sites/explore_sites_service_impl.cc
    • chrome/browser/android/explore_sites/explore_sites_service_impl.h
  99. Remove is_ready variables in PdfCompositorImplTest.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2ae2bec992432aafcbcb760f7efe56aaa423f90

    Comments

    Remove is_ready variables in PdfCompositorImplTest.
    
    Change-Id: I3c0930f22e7ff3ff72611bfb70415b3e122f398e
    Reviewed-on: https://chromium-review.googlesource.com/1171378
    Reviewed-by: Wei Li <weili@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582387}

    Changed files

    • components/services/pdf_compositor/pdf_compositor_impl_unittest.cc
  100. [Unity][Android] Update margins in sign-in and consent bump screens

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:41:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fff9a68b5bd9965a4690f5d21104529adad34afc

    Comments

    [Unity][Android] Update margins in sign-in and consent bump screens
    
    This CL updates the layout of the streamlined sign-in screen and the
    consent bump screen to accommodate last changes to mocks.
    
    Bug: 814728
    Change-Id: If8f2cdaf39ba175ca60584f9015a4b2ccaf23217
    Reviewed-on: https://chromium-review.googlesource.com/1171226
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582388}

    Changed files

    • chrome/android/java/res/layout/consent_bump_more_options_view.xml
    • chrome/android/java/res/layout/signin_view.xml
    • chrome/android/java/res/values/dimens.xml
  101. Fix crash that can occur when sharing temporary offline pages

    Changed by petewilohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:52:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9603793bf71d4fcce938bb0481dee2448cb5dc27

    Comments

    Fix crash that can occur when sharing temporary offline pages
    
    Sometimes when sharing temporary offline pages, we fail to create the
    content URI.  If we do, fall back to sharing by URL with the URL of the page.
    
    Bug: 871697
    Change-Id: Ie2e895fd708fdf4e5e992ebc2317ee49fd5bcee3
    Reviewed-on: https://chromium-review.googlesource.com/1168587
    Reviewed-by: Yafei Duan <romax@chromium.org>
    Commit-Queue: Peter Williamson <petewil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582389}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
  102. Add debug chromium bots

    Changed by martinissohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 23:58:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2db4180229db1c343018f96400d97944534b7a77

    Comments

    Add debug chromium bots
    
    These are mirrors of the existing release bots
    
    Bug: 867725
    Change-Id: I6f59d04a82103572e801273e294534e822d3e03d
    Reviewed-on: https://chromium-review.googlesource.com/1159172
    Commit-Queue: Stephen Martinis <martiniss@chromium.org>
    Reviewed-by: Nodir Turakulov <nodir@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582390}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  103. Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:01:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c7862cb6e7b0be134f2373e3dae5af8d0f6dc64

    Comments

    Run WebGL 2.0 tests on passthrough cmd decoder on Linux/Intel.
    
    It looks like an oversight that they weren't run on this configuration
    previously.
    
    Tbr: geofflang@chromium.org
    Bug: 872302
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I77e4e175a449cea70254dcc3bab8ea3686fc74d9
    Reviewed-on: https://chromium-review.googlesource.com/1168464
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582392}

    Changed files

    • testing/buildbot/chromium.gpu.fyi.json
    • testing/buildbot/waterfalls.pyl
  104. Fix new tab animation from tab switcher in Duet

    Changed by mdjonesohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:00:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9226b58bb77c84fd444da9d423199356bea96673

    Comments

    Fix new tab animation from tab switcher in Duet
    
    This patch changes the container that the new tab animation runs in
    when Duet is enabled. The container changes position from running on
    top of the toolbars to running beneath them (since the bottom toolbar
    is a persistent fixture). This would negatively impact the top toolbar
    if there were still icons there (since the top toolbar has an
    appearance animation to compensate for the tab appearing on top of
    it). However, since there are no icons, it is not an issue.
    
    Bug: 852012
    Change-Id: I19422b70844f3fd45e7d9318a3c9c9768b407991
    Reviewed-on: https://chromium-review.googlesource.com/1171819
    Commit-Queue: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582391}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayoutBase.java
  105. [Offline pages]: Fix css class so we apply download image correctly

    Changed by chiliohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:07:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d37e211bd2d980098fadcec0151bb533af6cc360

    Comments

    [Offline pages]: Fix css class so we apply download image correctly
    
    Bug: 873124
    Change-Id: I5f5f5af481e9f8e31a1dab141b9b4dac93acc121
    Reviewed-on: https://chromium-review.googlesource.com/1171742
    Reviewed-by: Peter Williamson <petewil@chromium.org>
    Commit-Queue: Cathy Li <chili@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582396}

    Changed files

    • components/neterror/resources/neterror.css
  106. Add a new type of shelf status/indicator for "active" status

    Changed by manucornetohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b12dd997dd70b06c806c89e16cbf1302eacbd972

    Comments

    Add a new type of shelf status/indicator for "active" status
    
    This will allow us to differentiate between "running" and "active".
    The logic to set this properly depending on status will come in a
    separate CL.
    
    Note that no shelf item is ever marked as STATUS_ACTIVE yet, so
    this CL has no effect on behavior.
    
    Bug: 805612
    Change-Id: I50f985d66659bd35e2b59ab19a898ae5a3634179
    Reviewed-on: https://chromium-review.googlesource.com/1170394
    Commit-Queue: Manu Cornet <manucornet@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582393}

    Changed files

    • ash/public/cpp/shelf_struct_mojom_traits.h
    • ash/public/cpp/shelf_types.h
    • ash/public/interfaces/shelf.mojom
    • ash/shelf/shelf_button.cc
    • ash/shelf/shelf_button.h
    • ash/shelf/shelf_view.cc
  107. Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json

    Changed by sebmarchandohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:04:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fad3162e6ad14ef32cacf0e2e05e474d91041d87

    Comments

    Add the PageAlmostIdleAndLocalDB experiment to fieldtrial_testing_config.json
    
    This moves the PageAlmostIdle and SiteCharacteristicsDatabase features to their
    own experiment so they can easily be shipped to Beta only.
    
    Change-Id: I56c65e4ffb8b389b502a8c03d661ca2c26a66abe
    Reviewed-on: https://chromium-review.googlesource.com/1168107
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582394}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  108. Updating XTBs based on .GRDs from branch master

    Changed by govindohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:05:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af94e466a77ac86e5f795780749c07bb886ebf60

    Comments

    Updating XTBs based on .GRDs from branch master
    
    R=amineer@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I5429bacaf530263c0fe78c4403624d6773d12866
    Reviewed-on: https://chromium-review.googlesource.com/1171858
    Reviewed-by: Krishna Govind <govind@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582395}

    Changed files

    • ash/components/strings/ash_components_strings_mr.xtb
    • ash/strings/ash_strings_ar.xtb
    • ash/strings/ash_strings_bn.xtb
    • ash/strings/ash_strings_es-419.xtb
    • ash/strings/ash_strings_fa.xtb
    • ash/strings/ash_strings_fi.xtb
    • ash/strings/ash_strings_fil.xtb
    • ash/strings/ash_strings_gu.xtb
    • ash/strings/ash_strings_hu.xtb
    • ash/strings/ash_strings_ja.xtb
    • ash/strings/ash_strings_kn.xtb
    • ash/strings/ash_strings_ko.xtb
    • ash/strings/ash_strings_lt.xtb
    • ash/strings/ash_strings_ml.xtb
    • ash/strings/ash_strings_mr.xtb
    • ash/strings/ash_strings_ru.xtb
    • ash/strings/ash_strings_ta.xtb
    • ash/strings/ash_strings_th.xtb
    • ash/strings/ash_strings_tr.xtb
    • ash/strings/ash_strings_vi.xtb
    • ash/strings/ash_strings_zh-CN.xtb
    • ash/strings/ash_strings_zh-TW.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_es-419.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_fil.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_hu.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ja.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ko.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_lt.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_ru.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_th.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_tr.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_vi.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-CN.xtb
    • chrome/android/java/strings/translations/android_chrome_strings_zh-TW.xtb
    • chrome/app/resources/chromium_strings_ar.xtb
    • chrome/app/resources/generated_resources_am.xtb
    • chrome/app/resources/generated_resources_ar.xtb
    • chrome/app/resources/generated_resources_bg.xtb
    • chrome/app/resources/generated_resources_bn.xtb
    • chrome/app/resources/generated_resources_ca.xtb
    • chrome/app/resources/generated_resources_cs.xtb
    • chrome/app/resources/generated_resources_da.xtb
    • chrome/app/resources/generated_resources_de.xtb
    • chrome/app/resources/generated_resources_el.xtb
    • chrome/app/resources/generated_resources_en-GB.xtb
    • chrome/app/resources/generated_resources_es-419.xtb
    • chrome/app/resources/generated_resources_es.xtb
    • chrome/app/resources/generated_resources_et.xtb
    • chrome/app/resources/generated_resources_fa.xtb
    • chrome/app/resources/generated_resources_fi.xtb
    • chrome/app/resources/generated_resources_fil.xtb
    • chrome/app/resources/generated_resources_fr.xtb
    • chrome/app/resources/generated_resources_gu.xtb
    • chrome/app/resources/generated_resources_hi.xtb
    • chrome/app/resources/generated_resources_hr.xtb
    • chrome/app/resources/generated_resources_hu.xtb
    • chrome/app/resources/generated_resources_id.xtb
    • chrome/app/resources/generated_resources_it.xtb
    • chrome/app/resources/generated_resources_iw.xtb
    • chrome/app/resources/generated_resources_ja.xtb
    • chrome/app/resources/generated_resources_kn.xtb
    • chrome/app/resources/generated_resources_ko.xtb
    • chrome/app/resources/generated_resources_lt.xtb
    • chrome/app/resources/generated_resources_lv.xtb
    • chrome/app/resources/generated_resources_ml.xtb
    • chrome/app/resources/generated_resources_mr.xtb
    • chrome/app/resources/generated_resources_ms.xtb
    • chrome/app/resources/generated_resources_nl.xtb
    • chrome/app/resources/generated_resources_no.xtb
    • chrome/app/resources/generated_resources_pl.xtb
    • chrome/app/resources/generated_resources_pt-BR.xtb
    • chrome/app/resources/generated_resources_pt-PT.xtb
    • chrome/app/resources/generated_resources_ro.xtb
    • chrome/app/resources/generated_resources_ru.xtb
    • chrome/app/resources/generated_resources_sk.xtb
    • chrome/app/resources/generated_resources_sl.xtb
    • chrome/app/resources/generated_resources_sr.xtb
    • chrome/app/resources/generated_resources_sv.xtb
    • chrome/app/resources/generated_resources_sw.xtb
    • chrome/app/resources/generated_resources_ta.xtb
    • chrome/app/resources/generated_resources_te.xtb
    • chrome/app/resources/generated_resources_th.xtb
    • chrome/app/resources/generated_resources_tr.xtb
    • chrome/app/resources/generated_resources_uk.xtb
    • chrome/app/resources/generated_resources_vi.xtb
    • chrome/app/resources/generated_resources_zh-CN.xtb
    • chrome/app/resources/generated_resources_zh-TW.xtb
    • chrome/app/resources/google_chrome_strings_ar.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_es-419.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_fil.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_gu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_hu.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ja.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_kn.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ko.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_lt.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ml.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_mr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ru.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_ta.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_th.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_tr.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_vi.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-CN.xtb
    • chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_zh-TW.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_bn.xtb
    • chrome/browser/resources/chromeos/select_to_speak/strings/select_to_speak_strings_fa.xtb
    • components/policy/resources/policy_templates_am.xtb
    • components/policy/resources/policy_templates_ar.xtb
    • components/policy/resources/policy_templates_bg.xtb
    • components/policy/resources/policy_templates_bn.xtb
    • components/policy/resources/policy_templates_ca.xtb
    • components/policy/resources/policy_templates_cs.xtb
    • components/policy/resources/policy_templates_da.xtb
    • components/policy/resources/policy_templates_de.xtb
    • components/policy/resources/policy_templates_el.xtb
    • components/policy/resources/policy_templates_en-GB.xtb
    • components/policy/resources/policy_templates_es-419.xtb
    • components/policy/resources/policy_templates_es.xtb
    • components/policy/resources/policy_templates_et.xtb
    • components/policy/resources/policy_templates_fa.xtb
    • components/policy/resources/policy_templates_fi.xtb
    • components/policy/resources/policy_templates_fil.xtb
    • components/policy/resources/policy_templates_fr.xtb
    • components/policy/resources/policy_templates_gu.xtb
    • components/policy/resources/policy_templates_hi.xtb
    • components/policy/resources/policy_templates_hr.xtb
    • components/policy/resources/policy_templates_hu.xtb
    • components/policy/resources/policy_templates_id.xtb
    • components/policy/resources/policy_templates_it.xtb
    • components/policy/resources/policy_templates_iw.xtb
    • components/policy/resources/policy_templates_ja.xtb
    • components/policy/resources/policy_templates_kn.xtb
    • components/policy/resources/policy_templates_ko.xtb
    • components/policy/resources/policy_templates_lt.xtb
    • components/policy/resources/policy_templates_lv.xtb
    • components/policy/resources/policy_templates_ml.xtb
    • components/policy/resources/policy_templates_mr.xtb
    • components/policy/resources/policy_templates_ms.xtb
    • components/policy/resources/policy_templates_nl.xtb
    • components/policy/resources/policy_templates_no.xtb
    • components/policy/resources/policy_templates_pl.xtb
    • components/policy/resources/policy_templates_pt-BR.xtb
    • components/policy/resources/policy_templates_pt-PT.xtb
    • components/policy/resources/policy_templates_ro.xtb
    • components/policy/resources/policy_templates_ru.xtb
    • components/policy/resources/policy_templates_sk.xtb
    • components/policy/resources/policy_templates_sl.xtb
    • components/policy/resources/policy_templates_sr.xtb
    • components/policy/resources/policy_templates_sv.xtb
    • components/policy/resources/policy_templates_sw.xtb
    • components/policy/resources/policy_templates_ta.xtb
    • components/policy/resources/policy_templates_te.xtb
    • components/policy/resources/policy_templates_th.xtb
    • components/policy/resources/policy_templates_tr.xtb
    • components/policy/resources/policy_templates_uk.xtb
    • components/policy/resources/policy_templates_vi.xtb
    • components/policy/resources/policy_templates_zh-CN.xtb
    • components/policy/resources/policy_templates_zh-TW.xtb
    • components/strings/components_strings_am.xtb
    • components/strings/components_strings_ar.xtb
    • components/strings/components_strings_bg.xtb
    • components/strings/components_strings_bn.xtb
    • components/strings/components_strings_ca.xtb
    • components/strings/components_strings_cs.xtb
    • components/strings/components_strings_da.xtb
    • components/strings/components_strings_de.xtb
    • components/strings/components_strings_el.xtb
    • components/strings/components_strings_en-GB.xtb
    • components/strings/components_strings_es-419.xtb
    • components/strings/components_strings_es.xtb
    • components/strings/components_strings_et.xtb
    • components/strings/components_strings_fa.xtb
    • components/strings/components_strings_fi.xtb
    • components/strings/components_strings_fil.xtb
    • components/strings/components_strings_fr.xtb
    • components/strings/components_strings_gu.xtb
    • components/strings/components_strings_hi.xtb
    • components/strings/components_strings_hr.xtb
    • components/strings/components_strings_hu.xtb
    • components/strings/components_strings_id.xtb
    • components/strings/components_strings_it.xtb
    • components/strings/components_strings_iw.xtb
    • components/strings/components_strings_ja.xtb
    • components/strings/components_strings_kn.xtb
    • components/strings/components_strings_ko.xtb
    • components/strings/components_strings_lt.xtb
    • components/strings/components_strings_lv.xtb
    • components/strings/components_strings_ml.xtb
    • components/strings/components_strings_mr.xtb
    • components/strings/components_strings_ms.xtb
    • components/strings/components_strings_nl.xtb
    • components/strings/components_strings_no.xtb
    • components/strings/components_strings_pl.xtb
    • components/strings/components_strings_pt-BR.xtb
    • components/strings/components_strings_pt-PT.xtb
    • components/strings/components_strings_ro.xtb
    • components/strings/components_strings_ru.xtb
    • components/strings/components_strings_sk.xtb
    • components/strings/components_strings_sl.xtb
    • components/strings/components_strings_sr.xtb
    • components/strings/components_strings_sv.xtb
    • components/strings/components_strings_sw.xtb
    • components/strings/components_strings_ta.xtb
    • components/strings/components_strings_te.xtb
    • components/strings/components_strings_th.xtb
    • components/strings/components_strings_tr.xtb
    • components/strings/components_strings_uk.xtb
    • components/strings/components_strings_vi.xtb
    • components/strings/components_strings_zh-CN.xtb
    • components/strings/components_strings_zh-TW.xtb
    • content/app/strings/translations/content_strings_es.xtb
    • content/app/strings/translations/content_strings_fi.xtb
    • content/app/strings/translations/content_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_chromium_strings_zh-TW.xtb
    • ios/chrome/app/strings/resources/ios_google_chrome_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_am.xtb
    • ios/chrome/app/strings/resources/ios_strings_ar.xtb
    • ios/chrome/app/strings/resources/ios_strings_bg.xtb
    • ios/chrome/app/strings/resources/ios_strings_bn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ca.xtb
    • ios/chrome/app/strings/resources/ios_strings_cs.xtb
    • ios/chrome/app/strings/resources/ios_strings_da.xtb
    • ios/chrome/app/strings/resources/ios_strings_de.xtb
    • ios/chrome/app/strings/resources/ios_strings_el.xtb
    • ios/chrome/app/strings/resources/ios_strings_en-GB.xtb
    • ios/chrome/app/strings/resources/ios_strings_es-419.xtb
    • ios/chrome/app/strings/resources/ios_strings_es.xtb
    • ios/chrome/app/strings/resources/ios_strings_et.xtb
    • ios/chrome/app/strings/resources/ios_strings_fa.xtb
    • ios/chrome/app/strings/resources/ios_strings_fi.xtb
    • ios/chrome/app/strings/resources/ios_strings_fil.xtb
    • ios/chrome/app/strings/resources/ios_strings_fr.xtb
    • ios/chrome/app/strings/resources/ios_strings_gu.xtb
    • ios/chrome/app/strings/resources/ios_strings_hi.xtb
    • ios/chrome/app/strings/resources/ios_strings_hr.xtb
    • ios/chrome/app/strings/resources/ios_strings_hu.xtb
    • ios/chrome/app/strings/resources/ios_strings_id.xtb
    • ios/chrome/app/strings/resources/ios_strings_it.xtb
    • ios/chrome/app/strings/resources/ios_strings_iw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ja.xtb
    • ios/chrome/app/strings/resources/ios_strings_kn.xtb
    • ios/chrome/app/strings/resources/ios_strings_ko.xtb
    • ios/chrome/app/strings/resources/ios_strings_lt.xtb
    • ios/chrome/app/strings/resources/ios_strings_lv.xtb
    • ios/chrome/app/strings/resources/ios_strings_ml.xtb
    • ios/chrome/app/strings/resources/ios_strings_mr.xtb
    • ios/chrome/app/strings/resources/ios_strings_ms.xtb
    • ios/chrome/app/strings/resources/ios_strings_nl.xtb
    • ios/chrome/app/strings/resources/ios_strings_no.xtb
    • ios/chrome/app/strings/resources/ios_strings_pl.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-BR.xtb
    • ios/chrome/app/strings/resources/ios_strings_pt-PT.xtb
    • ios/chrome/app/strings/resources/ios_strings_ro.xtb
    • ios/chrome/app/strings/resources/ios_strings_ru.xtb
    • ios/chrome/app/strings/resources/ios_strings_sk.xtb
    • ios/chrome/app/strings/resources/ios_strings_sl.xtb
    • ios/chrome/app/strings/resources/ios_strings_sr.xtb
    • ios/chrome/app/strings/resources/ios_strings_sv.xtb
    • ios/chrome/app/strings/resources/ios_strings_sw.xtb
    • ios/chrome/app/strings/resources/ios_strings_ta.xtb
    • ios/chrome/app/strings/resources/ios_strings_te.xtb
    • ios/chrome/app/strings/resources/ios_strings_th.xtb
    • ios/chrome/app/strings/resources/ios_strings_tr.xtb
    • ios/chrome/app/strings/resources/ios_strings_uk.xtb
    • ios/chrome/app/strings/resources/ios_strings_vi.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-CN.xtb
    • ios/chrome/app/strings/resources/ios_strings_zh-TW.xtb
  109. Reduce telemetry based isolate size

    Changed by zmoohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:19:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1715e3f972fe31826c3aaa4eaef20d0aeb7794c6

    Comments

    Reduce telemetry based isolate size
    
    Excluding some large size data in third_party/catapult/ that are not needed
    in running the telemetry tests.
    
    R=kbr@chromium.org,nednguyen@chromium.org
    
    Change-Id: I10a1968b5a9b02415f5d7f66b33a247d64791578
    Bug: 872521
    Reviewed-on: https://chromium-review.googlesource.com/1166261
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Zhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582397}

    Changed files

    • chrome/test/BUILD.gn
    • tools/perf/chrome_telemetry_build/BUILD.gn
  110. Speculative fix for GSA crashes with MediaCodec callback API.

    Changed by dalecurtisohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:32:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7feecd556d5bb5fe3bd419703709c5ce38942123

    Comments

    Speculative fix for GSA crashes with MediaCodec callback API.
    
    Prevents any calls into the native bridge once release() has been
    called on MediaCodecBridge. I've also reordered some member
    variables of the bridge to match their lifetime.
    
    BUG=873094
    TEST=none
    
    Change-Id: Iccf648275bac2d466ce62c5e4e792f9a088b09a0
    Reviewed-on: https://chromium-review.googlesource.com/1171836
    Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582398}

    Changed files

    • media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
    • media/base/android/media_codec_bridge_impl.cc
    • media/base/android/media_codec_bridge_impl.h
  111. Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Saturday, 11-Aug-18 00:34:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24be12346d5a4ec8ebcc2c0615add14d150496e7

    Comments

    Roll src/third_party/catapult 5a4110982f31..21cd5a309631 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5a4110982f31..21cd5a309631
    
    
    git log 5a4110982f31..21cd5a309631 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 dtu@chromium.org [pinpoint] Ignore comparison_magnitude == 'None' for reruns.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@21cd5a309631
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here
    ...skip...
    u_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:873331
    TBR=sullivan@chromium.org
    
    Change-Id: Ie322f1501b9f5411006fd4d603edf90941097a93
    Reviewed-on: https://chromium-review.googlesource.com/1171404
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582399}

    Changed files

    • DEPS
  112. Roll HarfBuzz to 1.8.7

    Changed by eaeohnoyoudont@chromium.org
    Changed at Saturday, 11-Aug-18 00:35:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 03427d53dc8e88fbde543f6115708a98c2b9b1f0

    Comments

    Roll HarfBuzz to 1.8.7
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/2b76767bf572364d3d647cdd139f2044a7ad06b2..b6fdcf4f8bd09e065c767939125861c9dc8ff18f
    
    Tbr: drott@chromium.org
    Change-Id: Ie65cb46846224bd90ffa86517a946c44f321f2c7
    Reviewed-on: https://chromium-review.googlesource.com/1170170
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582401}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/README.chromium