Home | Search
Login

Builder Win 7 Perf Build #2744 Microsoft Windows

Results:

failed performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1

Trigger Info:

Got Revisionf59c5558bcae3a45e08edc99450f00242e5e7ce0

Execution:

Steps and Logfiles:

Show:
  1. ( 4 hrs 51 mins ) steps
    running steps via annotated script
  2. ( 16 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  9. ( 1 ms ) remove .cipd
    remove .cipd
  10. ( 2 mins 24 secs ) bot_update
    bot_update
    [75GB/349GB used (21%)]
  11. ( 1 ms ) ensure_goma
    ensure_goma
  12. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  14. ( 24 secs ) gclient runhooks
    gclient runhooks
  15. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_7_Perf\src\testing\buildbot\chromium.perf.json
  17. ( 9 secs ) build directory
    build directory
  18. ( 2 mins 51 secs ) extract build
    extract build
  19. ( 1 ms ) find isolated tests
    find isolated tests
  20. ( 1 ms ) test_pre_run
    test_pre_run
  21. ( 1 ms ) test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  22. ( 7 secs ) test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  23. ( 1 ms ) test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  24. ( 15 secs ) test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  25. ( 1 mins 11 secs ) components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    components_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 27s
    Shard duration: 57s
    Total tests: n/a
     
  26. ( 21 secs ) load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    load_library_perf_tests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:23.620020
    Shard duration: 22s
    Total tests: n/a
     
  27. ( 34 secs ) media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    media_perftests on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:44.152590
    Shard duration: 31s
    Total tests: n/a
     
  28. ( 4 hrs 41 mins ) performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    performance_test_suite on (102b) GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:02:10.159720 (shard #0)
    Max shard duration: 4:30:13.698420 (shard #3)
    Min shard duration: 0:35:56.593150 (shard #0)
    Total tests: 890
    * Passed: 791 (791 expected, 0 unexpected)
    * Skipped: 99 (99 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  29. ( 1 ms ) Upload to test-results [performance_test_suite on (102b) GPU on Windows]
    Upload to test-results [performance_test_suite on (102b) GPU on Windows]
  30. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 8
    Total runtime: 16:56:00.132000
     
  31. ( 1 ms ) process_dumps
    process_dumps
  32. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_7_Perf/2744/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_7_Perf/2744" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574501}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
swarm_hashes {"components_perftests":"11160e2f2812204f975be8a661c763e6350dee15","load_library_perf_tests":"8dde9f42be6e6ca9da7df76adf3ccca39b0d9f4c","media_perftests":"53b1dd7b7b069692728006ed35029f3730e1e820","performance_test_suite":"66cb44b35d934ee74a4ba73da9abd209638eeb6b"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmphklvg3" Annotation(steps)
build_id "buildbot/chromium.perf/Win 7 Perf/2744" Annotation(steps)
builder_id "master.chromium.perf:Win 7 Perf" Annotation(steps)
blamelist ["alancutter@chromium.org","bsalomon@google.com","cathiechen@tencent.com","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","dmazzoni@chromium.org","falken@chromium.org","ftirelo@chromium.org","hiroh@chromium.org","imcheng@chromium.org","jam@chromium.org","jinsukkim@chromium.org","kojii@chromium.org","ksakamoto@chromium.org","lucmult@chromium.org","miu@chromium.org","mukai@chromium.org","nverne@chromium.org","peria@chromium.org","rbpotter@chromium.org","rdevlin.cronin@chromium.org","szager@chromium.org","tbansal@chromium.org","thestig@chromium.org","treib@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com"] Build
branch "master" Build
buildnumber 2744 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531366495 Build
revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" Build
slavename "vm4-m1" BuildSlave
buildername "Win 7 Perf" Builder
git_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" Change
parent_buildername "Win Builder Perf" ParentBuild
parent_buildnumber 26769 ParentBuild
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "f59c5558bcae3a45e08edc99450f00242e5e7ce0" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574501}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" ParentBuild
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_7_Perf" slave

Blamelist:

  1. (rdevlin.croninohnoyoudont@chromium.org)
  2. (bsalomonohnoyoudont@google.com)
  3. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. (ftireloohnoyoudont@chromium.org)
  5. (miuohnoyoudont@chromium.org)
  6. (imchengohnoyoudont@chromium.org)
  7. (ksakamotoohnoyoudont@chromium.org)
  8. (falkenohnoyoudont@chromium.org)
  9. (nverneohnoyoudont@chromium.org)
  10. (falkenohnoyoudont@chromium.org)
  11. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  12. (ksakamotoohnoyoudont@chromium.org)
  13. (tbansalohnoyoudont@chromium.org)
  14. (kojiiohnoyoudont@chromium.org)
  15. (jinsukkimohnoyoudont@chromium.org)
  16. (jamohnoyoudont@chromium.org)
  17. (thestigohnoyoudont@chromium.org)
  18. (rbpotterohnoyoudont@chromium.org)
  19. (mukaiohnoyoudont@chromium.org)
  20. (szagerohnoyoudont@chromium.org)
  21. (cathiechenohnoyoudont@tencent.com)
  22. (hirohohnoyoudont@chromium.org)
  23. (dmazzoniohnoyoudont@chromium.org)
  24. (treibohnoyoudont@chromium.org)
  25. (alancutterohnoyoudont@chromium.org)
  26. (lucmultohnoyoudont@chromium.org)
  27. (periaohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 08:29:00 UTC
End Thursday, 12-Jul-18 13:20:25 UTC
Pending N/A
Execution 4 hrs 51 mins

All Changes:

  1. [Extensions Cleanup] Remove unnecessary call to sync service

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34a47acf551fda25534bde4146c5f94409bd8b5b

    Comments

    [Extensions Cleanup] Remove unnecessary call to sync service
    
    The runtime host permissions preferences used to be synced, but aren't
    currently. Remove the call to the sync service, since it's unnecessary.
    
    If/when we add back syncing support, we can re-add this call.
    
    Bug: 839681
    Change-Id: Iba45e431ad09f8ff92861c69ae8447c125af707a
    Reviewed-on: https://chromium-review.googlesource.com/1134433
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574474}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier.cc
  2. Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""

    Changed by bsalomonohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 03:18:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cbaa2f11a4e9f5ef04eeb8cf0dc2acfdbaa79f56

    Comments

    Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""
    
    This reverts commit 23370775c415c21f4de1c7d97dd5645fe2b7e818.
    
    Reason for revert: still fails on Nexus 9
    
    Original change's description:
    > Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    > 
    > This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    > 
    > The updated change uses window.devicePixelRatio to determine the inset.
    > It also accounts for the absolute position used by the "
    ...skip...
    5adba768e22593057d00310e47
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 847984
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1134120
    Reviewed-by: Brian Salomon <bsalomon@google.com>
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Cr-Commit-Position: refs/heads/master@{#574477}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  3. Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 03:16:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0b7cacfc5ff01fe6d83463c81048b244322db8c

    Comments

    Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3bc29bcacf3..c228d491eb86
    
    
    git log a3bc29bcacf3..c228d491eb86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 bpastene@chromium.org cros_chrome_sdk: Change default location of cros cache dir.
    2018-07-12 vapier@chromium.org config_lib: delay loading of site_config in many modules
    2018-07-12 tbrindus@chromium.org paygen: Fix exception instantiation in error pat
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I88e283d9cb6593f6c1be6a0dfb2a9853e8e09f7f
    Reviewed-on: https://chromium-review.googlesource.com/1134103
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574476}

    Changed files

    • DEPS
  4. [Save card dialog] Update Google Pay logo and title padding

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:30:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb48e72d0b5d141e297e1e0a04d47cca079b0e1a

    Comments

    [Save card dialog] Update Google Pay logo and title padding
    
    According to the new spec, title for the server card should be:
      [GPay icon]<8px>|<8px>[Title]
    as opposed to the current:
      [GPay icon]<16px>|<16px>[Title]
    
    Mocks: https://drive.google.com/open?id=1A717QrLWOYSj3_A75tyMZomLUhy0xdV0
    Testing:
     - Local card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Local --test-launcher-interactive
     - Upstream card: ./out/Debug/browser_tests --
    ...skip...
    ralize in a follow-up
    CL, to make sure we have proper testing.
    
    Also added comments to the different sections of the GPay logo
    .icon file, to make it easier to inspect any future updates.
    
    Bug: 859893
    Change-Id: I6c551b113e476f21f3e74198b37f6df080226e78
    Reviewed-on: https://chromium-review.googlesource.com/1127471
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574478}

    Changed files

    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/google_pay_logo.icon
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views.h
  5. Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.

    Changed by miuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:36:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7bed8483e07637b8b24e7492d97bbc0499b6c16

    Comments

    Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.
    
    VideoCaptureOverlay provides the post-GPU-readback rendering of small
    SkBitmaps onto the VideoFrames captured by viz::FrameSinkVideoCapturer.
    This will be used to move mouse cursor rendering out of the browser
    process, and into VIZ, as was intended in the original design. More
    details in crbug/810133.
    
    A soon-upcoming series of changes will provide mojo IDL definition as
    well as integration of VideoCaptureOverlay with FrameSinkVideoCapturer.
    
    Bug: 810133
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I16897dbd361af153d10a1223339d9fb5f7e5f05a
    Reviewed-on: https://chromium-review.googlesource.com/1132318
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574480}

    Changed files

    • components/viz/service/BUILD.gn
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
    • components/viz/test/data/video_capture/overlay_clips_ll.png
    • components/viz/test/data/video_capture/overlay_clips_lr.png
    • components/viz/test/data/video_capture/overlay_clips_ul.png
    • components/viz/test/data/video_capture/overlay_clips_ur.png
    • components/viz/test/data/video_capture/overlay_full_cover.png
    • components/viz/test/data/video_capture/overlay_full_cover_scaled.png
    • components/viz/test/data/video_capture/overlay_moves_0_0.png
    • components/viz/test/data/video_capture/overlay_moves_1_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_1.png
    • components/viz/test/data/video_capture/overlay_moves_2_2.png
    • components/viz/test/data/video_capture/overlay_moves_lr.png
  6. [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.

    Changed by imchengohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:34:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da7bd5a1bbf177bb5822564193a7ea1795e0159b

    Comments

    [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.
    
    MR extension can fail/crash for many reasons. This in turn may cause
    ExtensionMediaRouteProviderProxy to violate its Mojo message pipe
    contract by dropping pending callbacks.
    
    Rather than wrapping each callback and tracking them in EMRPP, this
    patch deals with this by having MediaRouterDesktop detect when the EMRPP
    pipe encounters an error and attempt to recreate the pipe, subject to a
    max number of attempts.
    
    Bug: 861778
    Change-Id: Ie70e2cae3ea6650b65f658aba4ec527d4e2eb0d0
    Reviewed-on: https://chromium-review.googlesource.com/1129208
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574479}

    Changed files

    • chrome/browser/media/router/mojo/media_router_desktop.cc
    • chrome/browser/media/router/mojo/media_router_desktop.h
    • chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.h
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
  7. Update signed exchange test directory reference

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:42:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e72dce733afafe0340e25390b5f4c228702e9de

    Comments

    Update signed exchange test directory reference
    
    The directory was renamed in crrev.com/c/1132835.
    
    Bug: 856530
    Change-Id: I34890b24f256048d49bc59f5ba34ec048ce48d1c
    Reviewed-on: https://chromium-review.googlesource.com/1133609
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574481}

    Changed files

    • third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
  8. Ensure NavigationURLLoader does not exist in OnStartChecksComplete.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:05:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db52f93a94ed44198ade982c1640aa6aec35346c

    Comments

    Ensure NavigationURLLoader does not exist in OnStartChecksComplete.
    
    navigation_handle_->InitServiceWorkerHandle and navigation_handle_->InitAppCacheHandle
    reset the objects that NavigationURLLoaderImpl holds raw pointers to.
    So we must ensure |loader_| does not exist before doing that.
    
    Follow-up to r574110 <https://chromium-review.googlesource.com/1132715>.
    
    Bug: 857005
    Change-Id: If150832a8f6a104dbd662f2cc0e2c119e7a523bf
    Reviewed-on: https://chromium-review.googlesource.com/1133611
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574482}

    Changed files

    • content/browser/frame_host/navigation_request.cc
  9. Linux install dialog now has the word (Beta)

    Changed by nverneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5adc1de421e13cb871f50ed27d194a6ed1d5fb4

    Comments

    Linux install dialog now has the word (Beta)
    
    Bug: 848118
    Change-Id: Ib19c766d00084771d58f648076901eb6c4e25533
    Reviewed-on: https://chromium-review.googlesource.com/1133605
    Reviewed-by: Renée Wright <rjwright@chromium.org>
    Commit-Queue: Nicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574483}

    Changed files

    • chrome/app/chromeos_strings.grdp
  10. Gardening: Revise bug # for broken-chunked-encoding.https.html.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:20:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 349d297d20d841791815fd8b86b87f02e755bd22

    Comments

    Gardening: Revise bug # for broken-chunked-encoding.https.html.
    
    NOTRY=true
    
    Bug: 830472,862886
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ia6b50e1730d1f5dcb4f84b5c18d47003565fd838
    TBR: bashi
    Reviewed-on: https://chromium-review.googlesource.com/1134627
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574485}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
    • third_party/WebKit/LayoutTests/TestExpectations
  11. Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 04:20:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fc8a107a045fc9722cc619cd867e1197564f338

    Comments

    Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d78323faba86..5795489e83ad
    
    
    git log d78323faba86..5795489e83ad --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 2e3b05bf93..720dadbc21 (574261:574387)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@5795489e83ad
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here
    ...skip...
    rver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I921992cf5317868ff92ddfd27ecdba4c9cd8c78f
    Reviewed-on: https://chromium-review.googlesource.com/1134146
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574484}

    Changed files

    • DEPS
  12. Fix crash in ResourceFetcher::CachedResource()

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:26:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae18f0f47b8272cc5b911cc22cb799a648405f45

    Comments

    Fix crash in ResourceFetcher::CachedResource()
    
    This fixes a bug where ResourceFetcher::CachedResource() crashes when
    given a null KURL.
    
    Bug: 859314
    Change-Id: Iae07ded3124b690854aa7ba2a532f21be2a99972
    Reviewed-on: https://chromium-review.googlesource.com/1132914
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574487}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
  13. Disable flaky resource loading hints browser test on windows.

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:25:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91567a36db92e68bb36a513b68c119707b4c2cec

    Comments

    Disable flaky resource loading hints browser test on windows.
    
    Change-Id: Iea8b186c1673fb14982c98ce24141003d267df21
    TBR: ryansturm@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134595
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574486}

    Changed files

    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  14. [LayoutNG] Minor cleanup for NGInlineItem::Script()

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:27:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078bf960f5874ead134ad8f8c2e3f265969044cb

    Comments

    [LayoutNG] Minor cleanup for NGInlineItem::Script()
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie8d9ac37eca29db6a39f9a4612a3c0151ef06006
    Reviewed-on: https://chromium-review.googlesource.com/1132254
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574488}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h
  15. Stop content sniffing after successful encoding detection

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:40:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efbdada3f735a2631e9dfeed5c5e3f880245ccd3

    Comments

    Stop content sniffing after successful encoding detection
    
    Content sniffing should stop once the detector makes a valid
    guess. http://crrev.com/2697213002 introduced a side effect
    that has the detector continue to sniff the content, therefore
    opens the possibility of returning an encoding different from
    the first guess. It leads to a document decoded with multiple
    encoding schemes, one of which may not be correct.
    
    This CL addresses it by defining a new flag |detection_completed_|
    to tell the TextResourceDecoder to stop sniffing, even if
    detector returns false for unlabelled UTF-8 documents. Also added
    a test verifying the behavior.
    
    Bug: 710861
    Change-Id: Ic07de3ae08fbb742aa3c24f1e18055348d6acbd8
    Reviewed-on: https://chromium-review.googlesource.com/1132904
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574489}

    Changed files

    • third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
    • third_party/blink/renderer/core/html/parser/text_resource_decoder.h
    • third_party/blink/renderer/core/html/parser/text_resource_decoder_test.cc
    • third_party/blink/renderer/platform/text/text_encoding_detector.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.h
  16. Add workaround for WebUIs that make network requests when running with the network service.

    Changed by jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04bfa853ac261c316e0ef799e7c10ae05dece8c1

    Comments

    Add workaround for WebUIs that make network requests when running with the network service.
    
    Currently with the network service, renderers that have WebUI bindings are not allowed to make requests over the internet. This is to improve security in case the response hijacks the renderer. However there are a couple of WebUIs that are doing this now, so temporarily allow them.
    
    Bug: 848987, 829412
    Change-Id: I34c1b66e63fd1b7c2960cc867709c065329cf489
    Reviewed-on: https://chromium-review.googlesource.com/1134412
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574490}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • extensions/browser/api/web_request/web_request_permissions.cc
    • extensions/browser/extensions_browser_client.cc
    • extensions/browser/extensions_browser_client.h
  17. Remove debugging code in base::MessagePumpWin.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:29:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f61506c064bf502b2f2f81293866e40843ab2b

    Comments

    Remove debugging code in base::MessagePumpWin.
    
    BUG=596190
    
    Change-Id: Ie9b6ee2cc1db8399247be767cabba1b39df50544
    Reviewed-on: https://chromium-review.googlesource.com/1128274
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574491}

    Changed files

    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
  18. Print Preview: Add new Cloud Printer Handler flag

    Changed by rbpotterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9990eb4884bf57e3f907c5a475d182ff4db6d760

    Comments

    Print Preview: Add new Cloud Printer Handler flag
    
    Use a new cloud printer handler flag to control using the C++ cloud
    printer handler instead of the JS cloud print interface in Print
    Preview. Print Preview will be temporarily whitelisted to send network
    requests with the network service flag enabled, so these changes should
    be de-coupled from the network service flag.
    
    Bug: 829414
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I9a7b53fe69bfe5aad4ab7cc5688dfb88e6074014
    Reviewed-on: https://chromium-review.googlesource.com/1134397
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574492}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/print_preview/data/destination_store.js
    • chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • tools/metrics/histograms/enums.xml
  19. check |focused_surface_| on SetCursorType

    Changed by mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc
  20. Move scroll-related platform test code into core/testing/

    Changed by szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h
  21. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line
    
    In legacy Layout, there's line-break between marker and the nesting
    <ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
    in LayoutNGListMarker to indicate that marker would occupy a line.
    During Layout(), this kind of marker won't be added to container_builder_,
    and layout directly. And its margin will be handled after layout.
    
    Bug: 725277
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
    Reviewed-on: https://chromium-review.googlesource.com/1132819
    Commit-Queue: cathie chen <cathiechen@tencent.com>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
  22. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame
    
    VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
    from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
    RenderingHelper itself knows which function to be called, and thus these
    functions should be unified into a single interface.
    
    BUG=chromium:834170
    TEST=VDA unittest at veyron_minnie and eve
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
    Reviewed-on: https://chromium-review.googlesource.com/1122656
    Reviewed-by: Pawel Osciak <posciak@chromium.org>
    Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc
  23. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.
    
    Previously we only had hooks to update the children of a node in the
    AX tree when LayoutObjects were inserted or removed. That left out some
    corner cases when Nodes are inserted or removed that are part of the
    AX tree but not laid out, like nodes in the accessible / fallback content
    for a canvas.
    
    Bug: 862311
    Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
    Reviewed-on: https://chromium-review.googlesource.com/1132119
    Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h
  24. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*
    
    https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
    this one adjusts the checks accordingly.
    
    Bug: 846238
    Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
    Reviewed-on: https://chromium-review.googlesource.com/1131738
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h
  25. Add find bar icon to hosted app windows

    Changed by alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows
    
    This CL moves the find icon from LocationBarView into PageActionIconContainerView
    enabling the icon to appear in hosted app window title bars.
    
    This change also fixes the find icon getting nudged by
    crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.
    
    Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
    Before CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
    After CL:
    https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1
    
    Bug: 788051, 814531
    Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
    Reviewed-on: https://chromium-review.googlesource.com/1054908
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h
  26. Change test to use full-path-for-testing attribute selector

    Changed by lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector
    
    This makes this test compatible with directory tree having My Files or
    not, and makes the test more readable too.
    
    This is a preparation to enable new navigation (with My Files) by
    default.
    
    Bug: 857335
    No-presubmit: true
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
    Reviewed-on: https://chromium-review.googlesource.com/1133610
    Commit-Queue: Noel Gordon <noel@chromium.org>
    Reviewed-by: Noel Gordon <noel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
  27. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
    
    ImageLoader::Task class does not actually own the script state,
    so its reference can be weak.
    This CL makes the reference weak.
    
    Bug: 773605
    Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
    Reviewed-on: https://chromium-review.googlesource.com/1134629
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc