Home | Search
Login

Builder Win 7 Nvidia GPU Perf Build #2979 Microsoft Windows

Results:

failed validating_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1

Trigger Info:

Got Revision6da308ad98065e43393be2c8ec841189f8d6569b

Execution:

Steps and Logfiles:

Show:
  1. ( 4 hrs 41 mins ) steps
    running steps via annotated script
  2. ( 17 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 2 mins 41 secs ) bot_update
    bot_update
    [78GB/349GB used (22%)]
  9. ( 1 ms ) ensure_goma
    ensure_goma
  10. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  12. ( 37 secs ) gclient runhooks
    gclient runhooks
  13. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  14. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_7_Nvidia_GPU_Perf\src\testing\buildbot\chromium.perf.json
  15. ( 1 ms ) build directory
    build directory
  16. ( 1 mins 59 secs ) extract build
    extract build
  17. ( 1 ms ) find isolated tests
    find isolated tests
  18. ( 1 ms ) test_pre_run
    test_pre_run
  19. ( 2 ms ) test_pre_run.[trigger] angle_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] angle_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  20. ( 6 secs ) test_pre_run.[trigger] load_library_perf_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] load_library_perf_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  21. ( 1 ms ) test_pre_run.[trigger] media_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] media_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  22. ( 6 secs ) test_pre_run.[trigger] passthrough_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] passthrough_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  23. ( 12 secs ) test_pre_run.[trigger] performance_test_suite on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] performance_test_suite on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  24. ( 1 ms ) test_pre_run.[trigger] validating_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    test_pre_run.[trigger] validating_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
  25. ( 7 secs ) angle_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    angle_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Shard duration: 0:13:10.762580
    Total tests: n/a
     
  26. ( 44 secs ) load_library_perf_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    load_library_perf_tests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 34s
    Shard duration: 30s
    Total tests: n/a
     
  27. ( 33 secs ) media_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    media_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:04.014150
    Shard duration: 33s
    Total tests: n/a
     
  28. ( 31 secs ) passthrough_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    passthrough_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Pending time: 0:01:36.094760
    Shard duration: 29s
    Total tests: n/a
     
  29. ( 4 hrs 32 mins ) performance_test_suite on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    performance_test_suite on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    Run on OS: 'Windows-2008ServerR2-SP1'
    Max pending time: 0:01:59.712870 (shard #0)
    Max shard duration: 4:17:14.237680 (shard #1)
    Min shard duration: 3:30:07.019960 (shard #3)
    Total tests: 1034
    * Passed: 985 (985 expected, 0 unexpected)
    * Skipped: 49 (49 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  30. ( 1 ms ) Upload to test-results [performance_test_suite on NVIDIA GPU on Windows]
    Upload to test-results [performance_test_suite on NVIDIA GPU on Windows]
  31. ( 4 secs ) validating_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    validating_command_buffer_perftests on NVIDIA GPU on Windows on Windows-2008ServerR2-SP1
    TEST RESULTS WERE INVALID
  32. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 9
    Total runtime: 19:22:27.334001
     
  33. ( 1 ms ) process_dumps
    process_dumps
  34. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_7_Nvidia_GPU_Perf/2979/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_7_Nvidia_GPU_Perf/2979" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "04c084dd3cf4140cdd8073ae8975b2aa15bfe50a" Annotation(bot_update)
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" Annotation(bot_update)
got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" Annotation(bot_update)
got_revision "6da308ad98065e43393be2c8ec841189f8d6569b" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#582283}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.0.193@{#2}" Annotation(bot_update)
got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24263}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"4eff431f74328a2e9e301f86c1e3284537e45645","command_buffer_perftests":"3baca76937773c0ea4d76261a90b60af2034d0dd","components_perftests":"d1cf9d97104f72a044c597d7e2c1b2ea8a6ce8b1","load_library_perf_tests":"b414a4416d91559f6f2ef60fa8245e509ff915c6","media_perftests":"3e06063d0568e0b4b1731e318fed2f57b2799e00","performance_test_suite":"481dd98ba40be9205c2d65ccb93fa64d5149f7f3","views_perftests":"0a92ff07976f3ca3244f9d680f10c833fbbe904e"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmp8ameeb" Annotation(steps)
build_id "buildbot/chromium.perf/Win 7 Nvidia GPU Perf/2979" Annotation(steps)
builder_id "master.chromium.perf:Win 7 Nvidia GPU Perf" Annotation(steps)
blamelist ["aee@chromium.org","agl@chromium.org","amalova@chromium.org","apacible@chromium.org","beccahughes@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","cbiesinger@chromium.org","ccameron@chromium.org","changwan@google.com","charliea@chromium.org","cthomp@chromium.org","dmblack@google.com","ellyjones@chromium.org","erikchen@chromium.org","estade@chromium.org","etiennep@chromium.org","eugenebut@chromium.org","ftirelo@chromium.org","hendrich@chromium.org","isandrk@google.com","jamescook@chromium.org","jdufault@google.com","jkrcal@chromium.org","joenotcharles@chromium.org","kaznacheev@google.com","khorimoto@google.com","kmarshall@chromium.org","kozyatinskiy@chromium.org","krb@chromium.org","lukasza@chromium.org","martinkr@google.com","mattcary@chromium.org","mcasas@chromium.org","mcnee@chromium.org","meacer@chromium.org","mstensho@chromium.org","mukai@chromium.org","olsen@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","pkasting@chromium.org","qnnguyen@chromium.org","rajendrant@chromium.org","robertogden@chromium.org","rogerm@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","smaier@chromium.org","spang@chromium.org","spqchan@chromium.org","sugoi@google.com","sujiezhu@google.com","sunxd@chromium.org","sweilun@chromium.org","tangltom@chromium.org","tbarzic@google.com","tguilbert@chromium.org","thakis@chromium.org","thestig@chromium.org","tiborg@chromium.org","tnijssen@google.com","tommycli@chromium.org","updowndota@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","weidongg@chromium.org"] Build
branch "master" Build
buildnumber 2979 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1533927819 Build
revision "6da308ad98065e43393be2c8ec841189f8d6569b" Build
slavename "vm42-m1" BuildSlave
buildername "Win 7 Nvidia GPU Perf" Builder
git_revision "6da308ad98065e43393be2c8ec841189f8d6569b" Change
parent_buildername "Win x64 Builder Perf" ParentBuild
parent_buildnumber 34615 ParentBuild
parent_got_angle_revision "04c084dd3cf4140cdd8073ae8975b2aa15bfe50a" ParentBuild
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" ParentBuild
parent_got_nacl_revision "96088f46727b75b2f6a24e1b62e5cc59ddb4612d" ParentBuild
parent_got_revision "6da308ad98065e43393be2c8ec841189f8d6569b" ParentBuild
parent_got_revision_cp "refs/heads/master@{#582283}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "4fe3de13fc5c2592559bb5e49e1a81a6d09a2efd" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.0.193@{#2}" ParentBuild
parent_got_webrtc_revision "f5f5373372584fdcbf658a5c11ec28242c7fcd5e" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24263}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_7_Nvidia_GPU_Perf" slave

Blamelist:

  1. (kmarshallohnoyoudont@chromium.org)
  2. (tommycliohnoyoudont@chromium.org)
  3. (thakisohnoyoudont@chromium.org)
  4. (rogermohnoyoudont@chromium.org)
  5. (olsenohnoyoudont@chromium.org)
  6. (rajendrantohnoyoudont@chromium.org)
  7. (mcasasohnoyoudont@chromium.org)
  8. (meacerohnoyoudont@chromium.org)
  9. (mattcaryohnoyoudont@chromium.org)
  10. (hendrichohnoyoudont@chromium.org)
  11. (hendrichohnoyoudont@chromium.org)
  12. (mstenshoohnoyoudont@chromium.org)
  13. (lukaszaohnoyoudont@chromium.org)
  14. (robertogdenohnoyoudont@chromium.org)
  15. (amalovaohnoyoudont@chromium.org)
  16. (jamescookohnoyoudont@chromium.org)
  17. (ftireloohnoyoudont@chromium.org)
  18. (sujiezhuohnoyoudont@google.com)
  19. (ellyjonesohnoyoudont@chromium.org)
  20. (tbarzicohnoyoudont@google.com)
  21. (aglohnoyoudont@chromium.org)
  22. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  23. (etiennepohnoyoudont@chromium.org)
  24. (beccahughesohnoyoudont@chromium.org)
  25. (charlieaohnoyoudont@chromium.org)
  26. (estadeohnoyoudont@chromium.org)
  27. (jkrcalohnoyoudont@chromium.org)
  28. (ccameronohnoyoudont@chromium.org)
  29. (smaierohnoyoudont@chromium.org)
  30. (mcneeohnoyoudont@chromium.org)
  31. (qnnguyenohnoyoudont@chromium.org)
  32. (sweilunohnoyoudont@chromium.org)
  33. (erikchenohnoyoudont@chromium.org)
  34. (sugoiohnoyoudont@google.com)
  35. (kaznacheevohnoyoudont@google.com)
  36. (jdufaultohnoyoudont@google.com)
  37. (dmblackohnoyoudont@google.com)
  38. (updowndotaohnoyoudont@chromium.org)
  39. (smaierohnoyoudont@chromium.org)
  40. (khorimotoohnoyoudont@google.com)
  41. (mstenshoohnoyoudont@chromium.org)
  42. (jdufaultohnoyoudont@google.com)
  43. (sunxdohnoyoudont@chromium.org)
  44. (spangohnoyoudont@chromium.org)
  45. (tguilbertohnoyoudont@chromium.org)
  46. (jdufaultohnoyoudont@google.com)
  47. (mukaiohnoyoudont@chromium.org)
  48. (changwanohnoyoudont@google.com)
  49. (mattcaryohnoyoudont@chromium.org)
  50. (cthompohnoyoudont@chromium.org)
  51. (tnijssenohnoyoudont@google.com)
  52. (pkastingohnoyoudont@chromium.org)
  53. (khorimotoohnoyoudont@google.com)
  54. (tangltomohnoyoudont@chromium.org)
  55. (eugenebutohnoyoudont@chromium.org)
  56. (thestigohnoyoudont@chromium.org)
  57. (weidonggohnoyoudont@chromium.org)
  58. (krbohnoyoudont@chromium.org)
  59. (tiborgohnoyoudont@chromium.org)
  60. (mattcaryohnoyoudont@chromium.org)
  61. (apacibleohnoyoudont@chromium.org)
  62. (cbiesingerohnoyoudont@chromium.org)
  63. (aeeohnoyoudont@chromium.org)
  64. (aeeohnoyoudont@chromium.org)
  65. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  66. (kozyatinskiyohnoyoudont@chromium.org)
  67. (tiborgohnoyoudont@chromium.org)
  68. (martinkrohnoyoudont@google.com)
  69. (isandrkohnoyoudont@google.com)
  70. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  71. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  72. (mattcaryohnoyoudont@chromium.org)
  73. (joenotcharlesohnoyoudont@chromium.org)
  74. (spqchanohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 10-Aug-18 23:34:13 UTC
End Saturday, 11-Aug-18 04:15:33 UTC
Pending N/A
Execution 4 hrs 41 mins

All Changes:

  1. Fuchsia: Produce CIPD archives for service packages and FIDL files.

    Changed by kmarshallohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 16:56:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8f688b5f1d752df95e29608afc215c1363aa8344

    Comments

    Fuchsia: Produce CIPD archives for service packages and FIDL files.
    
    This adds new CIPD package definitions and supporting GN targets
    for Chrome Fuchsia prebuilts, for inclusion into the Fuchsia build.
    
    Adds a Blink override to licenses.py SPECIAL_CASES.
    
    
    Bug: 869197, 729194
    Change-Id: Ibe609cd96fef91358e37c2bc440dd10d5c4cac32
    Reviewed-on: https://chromium-review.googlesource.com/1155831
    Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582211}

    Changed files

    • BUILD.gn
    • tools/licenses.py
    • webrunner/BUILD.gn
    • webrunner/cipd/build_id.template
    • webrunner/cipd/fidl.yaml
    • webrunner/cipd/webrunner.yaml
  2. Reland "Omnibox UI: Trivial refactor of redundant logic."

    Changed by tommycliohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 16:59:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab1fd5ce2292f1f06866212175add91bf9916bfc

    Comments

    Reland "Omnibox UI: Trivial refactor of redundant logic."
    
    This is a reland of eb0754126c4ea3ef3aa55b65e607fe8204b6e197
    
    Original change's description:
    > Omnibox UI: Trivial refactor of redundant logic.
    >
    > Bug: NONE
    > Change-Id: I081af3892dc52f73d7d92aed9b417defa862f8be
    > Reviewed-on: https://chromium-review.googlesource.com/1168512
    > Reviewed-by: Kevin Bailey <krb@chromium.org>
    
    TBR=krb@chromium.org
    
    Bug: NONE
    Change-Id: Ie94842ac68a918714e3ddd258ee61b885ec371b5
    Reviewed-on: https://chromium-review.googlesource.com/1169930
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582213}

    Changed files

    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
  3. win/asan bot: Remove cores:32 dimension.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 16:57:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdc462a020aad3b30b7b821a4a2c1db8f9145380

    Comments

    win/asan bot: Remove cores:32 dimension.
    
    Looks like my new bot is only found without this requirement:
    
    https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=cores%3A32&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc
    
    https://chromium-swarm.appspot.com/botlist?c=id&c=os&c=task&c=status&f=builder%3Awin-asan&f=os%3AWindows-10&f=cpu%3Ax86-64&f=pool%3Aluci.chromium.ci&l=100&s=id%3Aasc
    
    Bug: 869973,871764
    Change-Id: I9f6f6e8bdfb0f62553266ad9eac4a12fcfdedd9f
    Reviewed-on: https://chromium-review.googlesource.com/1171023
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582212}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  4. [autofill] Add fieldtrial config for AutofillDeleteDisusedData

    Changed by rogermohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:04:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bab4b77b5bc3fff476935ad75bcf40f7f9692a61

    Comments

    [autofill] Add fieldtrial config for AutofillDeleteDisusedData
    
    Bug: 734151
    Change-Id: Ia2a04fd5acaae8cfa32bbec102a47d31e4294db1
    Reviewed-on: https://chromium-review.googlesource.com/1169422
    Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
    Commit-Queue: Roger McFarlane <rogerm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582215}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  5. Update policy_templates.json 'list' doc

    Changed by olsenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:02:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a71783e8209232f9f300f82928c4d3e3d822a92

    Comments

    Update policy_templates.json 'list' doc
    
    Using type 'list' seems like a good idea if the policy is indeed
    a list. However, it is not a good idea if it is a list of objects,
    and so will need to be parsed as JSON - in that case, 'dict' is a
    better fit. Added some documentation explaining why.
    
    Bug: 872765
    Change-Id: I5185f515d7bc82048bfb1eaab5d6d9ae61848eea
    Reviewed-on: https://chromium-review.googlesource.com/1169469
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Commit-Queue: A Olsen <olsen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582214}

    Changed files

    • components/policy/resources/policy_templates.json
  6. LazyLoad: Add feature and flags for lazyloading image

    Changed by rajendrantohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 793ff51fe9dd802b273896cebc056b81e6413419

    Comments

    LazyLoad: Add feature and flags for lazyloading image
    
    Subsequent CLs will implement the feature.
    
    Bug: 846170
    Change-Id: Idf8e6352d3c0573a0cf014cc89b2f63251e26607
    Reviewed-on: https://chromium-review.googlesource.com/1157143
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582216}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/child/runtime_features.cc
    • content/public/common/content_features.cc
    • content/public/common/content_features.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
    • tools/metrics/histograms/enums.xml
  7. Fold OffscreenCanvasResourceProvider into CanvasResourceDispatcher

    Changed by mcasasohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:11:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79c70d39731925261ae6a5930bbc8b45e95aeab9

    Comments

    Fold OffscreenCanvasResourceProvider into CanvasResourceDispatcher
    
    OffscreenCanvasResourceProvider is only used for accountancy of
    viz::{Transferable/Returned}Resource; moreover it's not only used
    for Offscreen canvases (but also for e.g. lowLatency ones). This
    CL folds the logic into its only client, CanvasResourceDispatcher.
    
    Also, the resource recycling inside OffscreenCRP is removed. This
    is (all) inspired by junov@'s crrev.com/c/1103011 and follows up
    on crrev.com/c/1167474.
    
    CQ-DEPEND=CL:1169829
    
    Bug: 839970
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ifed24992a6aded5c48f5e808cd61986906b64f7a
    Reviewed-on: https://chromium-review.googlesource.com/1167907
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Reviewed-by: Fernando Serboncini <fserb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582217}

    Changed files

    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.h
    • third_party/blink/renderer/platform/graphics/offscreen_canvas_frame_dispatcher_test.cc
    • third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.h
  8. Trigger IDN navigation suggestion UI for sites in site engagement list

    Changed by meacerohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:12:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5630fd7d97025c600ff0ea2c42483eb9b61adc77

    Comments

    Trigger IDN navigation suggestion UI for sites in site engagement list
    
    This CL expands the navigation suggestion feature by looking for potential suggestions in the engaged sites list using the site engagement service.
    
    The match is still done by computing ICU skeletons of the hostnames. The skeletons are calculated from the eTDL+1 portions of the navigated and engaged sites, so that a navigation to a subdomain of a site looking similar to an engaged site successfully triggers the UI.
    
    Design: https://docs.google.com/document/d/1gQCTenYuRnP77nMOo8RpS3SUxCiVewxQ9uQ3fuSefdY/edit?usp=sharing
    Bug: 847662
    Change-Id: I708b8f2503b16da8241145afe2f4aa0d2c001b9c
    Reviewed-on: https://chromium-review.googlesource.com/1162919
    Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582218}

    Changed files

    • chrome/browser/ui/omnibox/idn_navigation_observer.cc
    • chrome/browser/ui/omnibox/idn_navigation_observer.h
    • chrome/browser/ui/omnibox/idn_navigation_observer_browsertest.cc
    • components/url_formatter/idn_spoof_checker.cc
    • components/url_formatter/idn_spoof_checker.h
    • components/url_formatter/url_formatter.cc
    • components/url_formatter/url_formatter.h
    • tools/metrics/histograms/enums.xml
  9. Orderfile: add phased system health orderfile to the generator.

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:16:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78aae16be65e409075816860e948d1536a548234

    Comments

    Orderfile: add phased system health orderfile to the generator.
    
    This is enabled with --system-health-orderfile. Other than taking much
    longer to run the profiling, and producing a much more effective
    orderfile, the orderfile generator is run in the same way and produces
    the same output.
    
    Bug: 758566
    Change-Id: I66c3aa28c9499179f86644ee8e64c9a6c63bad54
    Reviewed-on: https://chromium-review.googlesource.com/1159066
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Benoit L <lizeb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582219}

    Changed files

    • tools/cygprofile/orderfile_generator_backend.py
    • tools/cygprofile/phased_orderfile.py
    • tools/cygprofile/phased_orderfile_unittest.py
    • tools/cygprofile/profile_android_startup.py
  10. Replace RunUntilIdle() with runloop.Run()/Quit()

    Changed by hendrichohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:18:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33ecf1c07bcfacc5ec33776f3e2b5cfc0694b442

    Comments

    Replace RunUntilIdle() with runloop.Run()/Quit()
    
    This CL replaces all occurrences of base::RunLoop().RunUntilIdle() in
    UserCloudPolicyStoreChromeOSTest with run_loop.Run() and an associated
    Quit() call from the expected callback.
    
    Bug: none
    Test: unit_tests
    Change-Id: I9f8ec70381c44bb034cc19e0622b3b7cb090539a
    Reviewed-on: https://chromium-review.googlesource.com/1160239
    Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582221}

    Changed files

    • chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
  11. Display ONC value validation errors

    Changed by hendrichohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:26:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aa67ada171c1e9fd5089ea0880a9382c3a97991e

    Comments

    Display ONC value validation errors
    
    This CL adds detailed warning/errors messages from the ONC value
    validation to chrome://policy.
    
    Bug: 855057
    Change-Id: I6d6bca90d074bc6b5c6be3b416fe25f216b5b7cb
    Reviewed-on: https://chromium-review.googlesource.com/1118555
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582224}

    Changed files

    • chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
    • components/policy_strings.grdp
  12. [LayoutNG] Flip for writing mode when calculating inline bounding box.

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:21:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f9021aac947f168210d550c30418c29230a71e1

    Comments

    [LayoutNG] Flip for writing mode when calculating inline bounding box.
    
    LayoutInline::LinesVisualOverflowBoundingBox() is expected to return
    coordinates with a logical block coordinate. So we need to flip for
    writing-mode vertical-rl.
    
    Discovered while investigating why
    wpt/css/css-position/position-sticky-writing-modes.html fails. It had
    some weird repaint issues (that I discovered when picking the test
    apart) that this CL fixes. That's not enough to fix the test, though.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I9a8930cc6de01991592282491677327e3406acfb
    Reviewed-on: https://chromium-review.googlesource.com/1170835
    Reviewed-by: Aleks Totic <atotic@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582222}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html
    • third_party/blink/renderer/core/layout/layout_inline.cc
  13. Make //content layer default to --site-per-process mode on desktop.

    Changed by lukaszaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:23:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b8db25cc597a642ee4b7cbaf2655c631353a799

    Comments

    Make //content layer default to --site-per-process mode on desktop.
    
    After this CL site-per-process is the default in all layers on desktop
    platforms, except:
    
    - Layout Tests which still run with no isolation by default
      (see https://crbug.com/856734#c5 for the explanation why)
    
    - //content embedders that don't want to use site-per-process: //chromecast
    
    - //content embedders that don't yet support site-per-process, but will
      need to migrate eventually: //headless
    
    
    Also note that even after this CL
    ...skip...
    ariations/fieldtrial_testing_config.json).
    
    
    Bug: 856734
    Change-Id: Iebd46e5502583f84a4b0a7c2ee8d8b0e081c6ff2
    Reviewed-on: https://chromium-review.googlesource.com/1153981
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: Stephen Lanham <slan@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582223}

    Changed files

    • android_webview/browser/aw_content_browser_client.cc
    • android_webview/browser/aw_content_browser_client.h
    • chromecast/browser/cast_content_browser_client.cc
    • chromecast/browser/cast_content_browser_client.h
    • content/browser/geolocation/geolocation_service_impl_unittest.cc
    • content/browser/isolated_origin_browsertest.cc
    • content/browser/web_package/signed_exchange_request_handler_browsertest.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • content/shell/browser/layout_test/layout_test_content_browser_client.cc
    • content/shell/browser/layout_test/layout_test_content_browser_client.h
    • headless/lib/browser/headless_content_browser_client.cc
    • headless/lib/browser/headless_content_browser_client.h
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/client.v8.chromium.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/test_suites.pyl
  14. Add triggering logic to HTTPS Server Previews

    Changed by robertogdenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:17:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1e6a91f0d520614846647f98446b529b9477b12

    Comments

    Add triggering logic to HTTPS Server Previews
    
    This adds the basic triggering logic to the Previews Navigation Throttle
    (not including loadshedding or bypassing which will come in the next
    CL).
    Also creates a NavigationThrottleManager interface to decouple the Nav
    Throttle from the decider. The decider will keep all the state for the
    Nav Throttle since the throttle's lifetime is so short.
    
    Most of the triggering testing is done in browser tests for sake of
    clarity and complexity.
    
    Bug: 864651
    Change-Id: I1d1772c25ddfa159051bd5b1064c53256ced39f3
    Reviewed-on: https://chromium-review.googlesource.com/1152164
    Commit-Queue: Robert Ogden <robertogden@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Doug Arnett <dougarnett@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582220}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/previews_lite_page_decider.cc
    • chrome/browser/previews/previews_lite_page_decider.h
    • chrome/browser/previews/previews_lite_page_decider_unittest.cc
    • chrome/browser/previews/previews_lite_page_navigation_throttle.cc
    • chrome/browser/previews/previews_lite_page_navigation_throttle.h
    • chrome/browser/previews/previews_lite_page_navigation_throttle_manager.h
    • chrome/browser/previews/previews_lite_page_navigation_throttle_unittest.cc
    • chrome/test/BUILD.gn
    • components/previews/core/previews_experiments.cc
    • components/previews/core/previews_experiments.h
  15. Add dynamicmodule in Chromium repository DEPS

    Changed by amalovaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:26:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eca6385200209b9756f3e011b0f1c089c194209

    Comments

    Add dynamicmodule in Chromium repository DEPS
    
    Bug: 873098
    Change-Id: Ifafc4edec8ddae8da621908f69fdf3a39e9e8f8a
    Reviewed-on: https://chromium-review.googlesource.com/1170698
    Commit-Queue: Anna Malova <amalova@chromium.org>
    Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582225}

    Changed files

    • DEPS
    • third_party/.gitignore
  16. chromeos: Fix ChromeVox highlight rects for shortcut viewer with hidpi

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:27:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69ecbb7f92e4d38ff504a372e4acbed6cf429f55

    Comments

    chromeos: Fix ChromeVox highlight rects for shortcut viewer with hidpi
    
    The serialized AX node locations need to be adjusted by the display
    device scale factor. This is similar to how AXTreeSourceArc handles
    remote ARC++ apps.
    
    Bug: 851578
    Test: added to views_mus_unittests
    Change-Id: Ibf17c76584e1ec54e5b214866a7cd1abbcc88f7f
    Reviewed-on: https://chromium-review.googlesource.com/1168120
    Commit-Queue: James Cook <jamescook@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582226}

    Changed files

    • ui/views/mus/ax_remote_host.cc
    • ui/views/mus/ax_remote_host.h
    • ui/views/mus/ax_remote_host_unittest.cc
    • ui/views/mus/ax_tree_source_mus.cc
    • ui/views/mus/ax_tree_source_mus.h
    • ui/views/mus/ax_tree_source_mus_unittest.cc
  17. [Card unmask dialog] Prefer to translate CVC to an abbreviated form

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:28:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4474a47ab71cc6533f12941dcae230d528660ced

    Comments

    [Card unmask dialog] Prefer to translate CVC to an abbreviated form
    
    The current CVC placeholder string is translated to the full form in
    some languages and doesn't look well on the card unmask dialog (for
    example, it looks like "Crypto..." in French). This adds a restraint
    to the number of characters it should be translated to and add a
    "meaning" tag to ensure the translation is not shared with other
    properties.
    
    Bug: 873158
    
    Change-Id: I1ffd5154ef94705efe86dae842fbf913b09b6a36
    Reviewed-on: https://chromium-review.googlesource.com/1170586
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582227}

    Changed files

    • components/autofill_strings.grdp
  18. [Settings Autofill Card Migration] Add syncStatus in the payments_section

    Changed by sujiezhuohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 17:34:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8bc152e6703a48bb8cd6e8f3735f7132d43629e7

    Comments

    [Settings Autofill Card Migration] Add syncStatus in the payments_section
    
    Since we only offer local cards migration to signed-in and synced user, we have to get the syncStatus in the payments_section in order to check the migration requirements in the payments_section.js.
    
    We use the similar code from the people_page.js to add the syncStatus property from SyncBrowserProxy in the payments_section.
    
    Please refer to the design doc for more details: https://docs.google.com/document/d/1J7YyBeKZZaBhjAHnMEezvuBa5x1pk_XCh_yZvV_HMmc/edit#heading=h.1wm3blr98d8i
    
    Bug: 852904
    Change-Id: I9786fd491780a6daf71d19da94da4b048ad59ed2
    Reviewed-on: https://chromium-review.googlesource.com/1168386
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#582229}

    Changed files

    • chrome/browser/resources/settings/passwords_and_forms_page/BUILD.gn
    • chrome/browser/resources/settings/passwords_and_forms_page/payments_section.html
    • chrome/browser/resources/settings/passwords_and_forms_page/payments_section.js
  19. sheriff: mark middleClickAutoscroll-click flaky on Mac

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:32:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 27c03b446e2d3ee507c19cc32b5b0460c632d6cd

    Comments

    sheriff: mark middleClickAutoscroll-click flaky on Mac
    
    TBR=pkasting@chromium.org
    
    Bug: 872705
    Change-Id: I72edb9f5b1d07baf898fe8aa97231df5d76424a4
    Reviewed-on: https://chromium-review.googlesource.com/1171106
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582228}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  20. Skip update if a component is found during registration

    Changed by tbarzicohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 17:37:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8504f674e97cfead82712c7b887b0d665cdd1d0a

    Comments

    Skip update if a component is found during registration
    
    Update CrOSComponentManager to handle the case when an installed
    compatible component is found during component registration started by
    CrOSComponentManager::Load.
    
    Previously, CrOSComponentManager would start OnDemandUpdate whenever no
    compatible component path was registered when Load() was called - this
    did not account for cases where Load was called early on, before
    registration of installed components finished. This means that
    CrOSComponent
    ...skip...
    path is registered before CrOSComponentManager::StartInstall
    is called. (This is more in line with order OnComponentReady and the
    callback are invoked during Install request, and no other callers seem
    to depend on this ordering).
    
    BUG=872871
    
    Change-Id: I33ff01b5d127d17cd9016b012fc400562c03d9c1
    Reviewed-on: https://chromium-review.googlesource.com/1170172
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582230}

    Changed files

    • chrome/browser/component_updater/cros_component_installer_chromeos.cc
    • chrome/browser/component_updater/cros_component_installer_chromeos.h
    • components/component_updater/component_installer.cc
  21. webauthn: only echo appid extension when requested.

    Changed by aglohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:38:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ce352264fed659b1eb806c72650a39e7bc16ca54

    Comments

    webauthn: only echo appid extension when requested.
    
    This change aligns Chromium with the current state of the spec[1]: the
    “appid” extension output will only be returned when the caller requested
    the appid extension, and it'll be true iff the AppID value was actually
    used when getting the assertion.
    
    [1] https://w3c.github.io/webauthn/#sctn-appid-extension
    
    BUG=853770
    
    Change-Id: I6ac9470c71bfc0cc3b38f6e91c5e8f00b0586405
    Reviewed-on: https://chromium-review.googlesource.com/1162823
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
    Reviewed-by: Greg Kerr <kerrnel@chromium.org>
    Commit-Queue: Adam Langley <agl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582231}

    Changed files

    • content/browser/webauth/authenticator_impl.cc
    • content/browser/webauth/authenticator_impl.h
    • content/browser/webauth/authenticator_impl_unittest.cc
    • third_party/blink/public/platform/modules/webauthn/authenticator.mojom
    • third_party/blink/renderer/modules/credentialmanager/credentials_container.cc
  22. Roll src/third_party/webrtc c97933fb82f8..f5f537337258 (2 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 17:39:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21c70dad5bd1417a9fb858c7298ff3bcbe297419

    Comments

    Roll src/third_party/webrtc c97933fb82f8..f5f537337258 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/c97933fb82f8..f5f537337258
    
    
    git log c97933fb82f8..f5f537337258 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 nisse@webrtc.org Delete unused member MediaSenderInfo::packets_cached.
    2018-08-10 phoglund@webrtc.org Temporarily skip linux_internal on autoroller tryjobs.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@f5f537337258
    
    The AutoRoll server is located here: http
    ...skip...
    rver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I401e8192beca5bd0160859d037944014dcfad7bf
    Reviewed-on: https://chromium-review.googlesource.com/1169706
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582232}

    Changed files

    • DEPS
  23. [Zucchini] Create elf disassembler.

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:44:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3c64e078fea9f23e44939c25ca02cf05b72b2c40

    Comments

    [Zucchini] Create elf disassembler.
    
    Creates Disassembler that recognises and parses ELF format. For now, it only supports Intel architeture. Support for Arm will be added in follow-up CLs.
    
    Change-Id: Ibdcf113b573f22844b6a1611c5ff6df46829b9b3
    Reviewed-on: https://chromium-review.googlesource.com/1136841
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: Greg Thompson <grt@chromium.org>
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582233}

    Changed files

    • components/zucchini/BUILD.gn
    • components/zucchini/abs32_utils.cc
    • components/zucchini/disassembler.cc
    • components/zucchini/disassembler.h
    • components/zucchini/disassembler_elf.cc
    • components/zucchini/disassembler_elf.h
    • components/zucchini/disassembler_elf_unittest.cc
    • components/zucchini/element_detection.cc
    • components/zucchini/type_elf.h
  24. [Autoplay] Sound setting should be top level scope

    Changed by beccahughesohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:47:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b8290139b181edb91c79e2dc0cb84d80163f65a

    Comments

    [Autoplay] Sound setting should be top level scope
    
    The sound setting is only applied at a WebContents
    level so we should make sure it is registered with
    TOP_LEVEL_ORIGIN_ONLY_SCOPE.
    
    BUG=865548
    
    Change-Id: Ia0e02f2201665b14a59e8c38b8dcfcde8e99ed67
    Reviewed-on: https://chromium-review.googlesource.com/1169522
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582234}

    Changed files

    • components/content_settings/core/browser/content_settings_registry.cc
  25. Remove the (now-nonexistent) battor agent target from a whitelist

    Changed by charlieaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:50:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b170ec58e8db44797571af99d40f1868a31698db

    Comments

    Remove the (now-nonexistent) battor agent target from a whitelist
    
    It looks like this file has * listed as its owner, so it doesn't need
    any specific owner review.
    
    Bug: 859514
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng
    Change-Id: I9afd700a6a36f00b5fb46847fbc5d01d08646db8
    Reviewed-on: https://chromium-review.googlesource.com/1169437
    Commit-Queue: Charlie Andrews <charliea@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#582236}

    Changed files

    • build/check_gn_headers_whitelist.txt
  26. Rename CustomFrameViewAsh to NonClientFrameViewAsh.

    Changed by estadeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:48:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f09e657ccf92cfb4715e322e0dfa05c2f7a0f3f

    Comments

    Rename CustomFrameViewAsh to NonClientFrameViewAsh.
    
    Bug: none
    Change-Id: I3aadd1d6c94c27dd9bdf2648ea241412d5a71078
    Reviewed-on: https://chromium-review.googlesource.com/1167954
    Commit-Queue: Evan Stade <estade@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582235}

    Changed files

    • ash/BUILD.gn
    • ash/frame/header_view.cc
    • ash/frame/non_client_frame_view_ash.cc
    • ash/frame/non_client_frame_view_ash.h
    • ash/frame/non_client_frame_view_ash_unittest.cc
    • ash/frame/wide_frame_view.cc
    • ash/frame/wide_frame_view.h
    • ash/shell.cc
    • ash/wm/non_client_frame_controller.cc
    • ash/wm/resize_shadow_and_cursor_unittest.cc
    • ash/wm/workspace/multi_window_resize_controller_unittest.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • chrome/browser/ui/views/apps/DEPS
    • chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • components/exo/client_controlled_shell_surface.cc
    • components/exo/client_controlled_shell_surface.h
    • components/exo/client_controlled_shell_surface_unittest.cc
    • components/exo/shell_surface_base.cc
    • components/exo/shell_surface_unittest.cc
  27. [AF] Add chrome://flags entry for enabling USS for wallet data

    Changed by jkrcalohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:53:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e3641b9174dc70ad2ead9c2577ae97739674a1be

    Comments

    [AF] Add chrome://flags entry for enabling USS for wallet data
    
    Bug: 853688
    Change-Id: I4069581ed4eea46c04351593a595102783bac438
    Reviewed-on: https://chromium-review.googlesource.com/1169479
    Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582237}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  28. RemoteMacViews: Move FocusChangeListener and InputMethodDelegate

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:53:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bd4c1f47351bb5e0bb634f97918bf5af5d6476a

    Comments

    RemoteMacViews: Move FocusChangeListener and InputMethodDelegate
    
    Move the interfaces FocusChangeListener and InputMethodDelegate from
    being implemented by BridgedNativeWidget to being implemented in
    BridgedNativeWidgetHostImpl. This has the effect of moving them from
    the app shim process to the browser process.
    
    This is in preparaton for removing access to TextInputClient from
    BridgedContentView (that operation is delicate). Add a temporary
    method on BridgedNativeWidget to set the TextInputClient for
    BridgedContentView from BridgedNativeWidgetHostImpl (where we now
    receive the OnDidChangeFocus notification).
    
    Bug: 859152
    Change-Id: I1f5639448cc9f7b4b00058444ab64914b9193df3
    Reviewed-on: https://chromium-review.googlesource.com/1170582
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582238}

    Changed files

    • ui/views/cocoa/bridged_native_widget.h
    • ui/views/cocoa/bridged_native_widget.mm
    • ui/views/cocoa/bridged_native_widget_host_impl.h
    • ui/views/cocoa/bridged_native_widget_host_impl.mm
    • ui/views/cocoa/bridged_native_widget_unittest.mm
    • ui/views/test/widget_test_mac.mm
    • ui/views/widget/native_widget_mac.h
    • ui/views/widget/native_widget_mac.mm
  29. Adding smaier@ to owners of android_async_task and ProGuard flags

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:57:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9cd328369c14ab071a3848770567d4a547c7e6f4

    Comments

    Adding smaier@ to owners of android_async_task and ProGuard flags
    
    Change-Id: I6e3603ad89eca72a3cdd481dfb1667105b6ef0ed
    Reviewed-on: https://chromium-review.googlesource.com/1169128
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582239}

    Changed files

    • chrome/android/java/OWNERS
    • third_party/android_async_task/OWNERS
  30. Remove unnecessary tab key press from Focus_AdvanceFocus test

    Changed by mcneeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:57:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5eeadd143332f6fc6c26af924d8a38d5f49b06a2

    Comments

    Remove unnecessary tab key press from Focus_AdvanceFocus test
    
    The associated bug which required this extra tab is fixed.
    
    Bug: 147644
    Change-Id: Ied21533accc82613053e119aa2c5c64fc9de8343
    Reviewed-on: https://chromium-review.googlesource.com/1170986
    Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    Commit-Queue: Kevin McNee <mcnee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582240}

    Changed files

    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  31. cros: Show Account Access help app in its own window instead of OOBE dialog's.

    Changed by qnnguyenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 17:58:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 601da7eefcc94358cfc662e260593266d3de750e

    Comments

    cros: Show Account Access help app in its own window instead of OOBE dialog's.
    
    This also fixes the crash when we click on the "Learn More" button in views lock screen.
    
    Bug: 872699, 872692
    Change-Id: I3172cae0a9a86e28a6f154eb000e270eaf9352dd
    Reviewed-on: https://chromium-review.googlesource.com/1169764
    Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582241}

    Changed files

    • chrome/browser/chromeos/login/ui/fake_login_display_host.cc
    • chrome/browser/chromeos/login/ui/fake_login_display_host.h
    • chrome/browser/chromeos/login/ui/login_display_host.h
    • chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
    • chrome/browser/chromeos/login/ui/login_display_host_mojo.h
    • chrome/browser/chromeos/login/ui/login_display_host_webui.cc
    • chrome/browser/chromeos/login/ui/login_display_host_webui.h
    • chrome/browser/ui/ash/login_screen_client.cc
  32. [NTP] Double click the collection tile will not apply custom background

    Changed by sweilunohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:01:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ede33d586b8033c58aa955c34257aa211259415d

    Comments

    [NTP] Double click the collection tile will not apply custom background
    
    Only double click on the "SelectedTile" can apply that as the custom
    background. In that case, when we double click on the collection tile
    the click count will not apply to the image tile underneath it, so that
    it will not apply the underneath custom background.
    
    Bug: 872953
    Change-Id: I897be7aa93040e1e819ceb762e4d4c78f9f0b1ce
    Reviewed-on: https://chromium-review.googlesource.com/1170134
    Commit-Queue: Weilun Shi <sweilun@chromium.org>
    Reviewed-by: Kristi Park <kristipark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582242}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.js
  33. Move logic for site details histograms into MetricsMemoryDetails.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:02:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7970a4255c0b973ec69d7b258ba660893e76aa24

    Comments

    Move logic for site details histograms into MetricsMemoryDetails.
    
    This CL is a refactor with no intended behavior change.
    
    This CL is the beginning of a refactor to separate the two types of consumers of
    MemoryDetails:
      * Those that want a human readable string that shows a mapping from [process :
      memory usage].
      * Those that want to emit non-memory related metrics.
    
    Bug: 864352
    Change-Id: I0f2a968ef63b3c9fcb658898a2f3f55f68867285
    Reviewed-on: https://chromium-review.googlesource.com/1170587
    Reviewed-by: Nick Carter <nick@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582243}

    Changed files

    • chrome/browser/memory_details.cc
    • chrome/browser/memory_details.h
    • chrome/browser/memory_details_win.cc
    • chrome/browser/metrics/metrics_memory_details.cc
    • chrome/browser/metrics/metrics_memory_details.h
  34. Roll SwiftShader 9e22c54..c47cd43

    Changed by sugoiohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:05:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 45d9e339871f8a97636c6851557a182180b4c555

    Comments

    Roll SwiftShader 9e22c54..c47cd43
    
    https://swiftshader.googlesource.com/SwiftShader.git/+log/9e22c54..c47cd43
    
    BUG=
    
    TBR=kbr@chromium.org
    
    TEST=bots
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
    
    Change-Id: I3ae0ca29a797b35cfe2926ded1eb6222e20e77c5
    Reviewed-on: https://chromium-review.googlesource.com/1170983
    Reviewed-by: Alexis Hétu <sugoi@chromium.org>
    Commit-Queue: Alexis Hétu <sugoi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582244}

    Changed files

    • DEPS
  35. Update app list item layout when changing icon

    Changed by kaznacheevohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:07:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d3c978d0cb7454861ca51d88bac8ca4b5829b80

    Comments

    Update app list item layout when changing icon
    
    Bug: 872823
    Test: manual, steps in the bug
    Change-Id: I4d900b08cd9ae391639c4e4789caf1b0eb1f79ae
    Reviewed-on: https://chromium-review.googlesource.com/1169692
    Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Jenny Zhang <jennyz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582246}

    Changed files

    • ash/app_list/views/app_list_item_view.cc
  36. cros: Do not play animations for non-focused users.

    Changed by jdufaultohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:07:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d8f67e1219b1d9fd8e54f2d6963d423de6110b1d

    Comments

    cros: Do not play animations for non-focused users.
    
    Bug: 872923
    Change-Id: I7071921895fcd017a65286fce4b565ad8f96de76
    Reviewed-on: https://chromium-review.googlesource.com/1170035
    Commit-Queue: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582245}

    Changed files

    • ash/login/ui/animated_rounded_image_view.h
    • ash/login/ui/login_user_view.cc
  37. Anchor Assistant to correct display.

    Changed by dmblackohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:11:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3171a7bbedfd9ec56e3f0e75fad2851f7e597f9f

    Comments

    Anchor Assistant to correct display.
    
    Previously, we always anchored to the primary display.
    
    Now, we'll check for where new windows will be opened. We match a
    display against the bounds for that window and anchor there.
    
    Bug: b:111445270
    Change-Id: Ice37359fe61937d452d7a908a609d1b60d913a37
    Reviewed-on: https://chromium-review.googlesource.com/1150920
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582247}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/assistant_ui_controller.h
    • ash/assistant/ui/assistant_container_view.cc
    • ash/assistant/ui/assistant_container_view_unittest.cc
    • chromeos/services/assistant/test_support/mock_assistant.h
  38. Fix default state in voice interaction controller client

    Changed by updowndotaohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:12:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c44dbc3515a28997631d54c4d2399f80f9ac6b06

    Comments

    Fix default state in voice interaction controller client
    
    Bug: None
    Test: Manual Test
    Change-Id: I46c5eb1efdc1ea9ac730f0a76d0e83903e8a86d9
    Reviewed-on: https://chromium-review.googlesource.com/1170307
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582248}

    Changed files

    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
  39. Android: MockSyncContentResolverDelegate explicit executeOnExecutor

    Changed by smaierohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:13:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 87fa0656b765934b0cfbe762fca2e326d4fe4ca4

    Comments

    Android: MockSyncContentResolverDelegate explicit executeOnExecutor
    
    We would like to get rid of all usages of execute() since it is unclear
    whether it goes to SERIAL_EXECUTOR or THREAD_POOL_EXECUTOR (many assume
    THREAD_POOL_EXECUTOR, but it actually goes to SERIAL_EXECUTOR). This is
    just cleaning up this test usage.
    
    Bug: 869907
    Change-Id: I7564a0cc743f803b07aa04651337c857b7eb6d87
    Reviewed-on: https://chromium-review.googlesource.com/1162704
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Sam Maier <smaier@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582249}

    Changed files

    • components/sync/test/android/javatests/src/org/chromium/components/sync/test/util/MockSyncContentResolverDelegate.java
  40. [CrOS MultiDevice] Fix typo which did not add a space between sentences.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:16:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a49c055dfd129a915b2996f847f65a85f57a7e06

    Comments

    [CrOS MultiDevice] Fix typo which did not add a space between sentences.
    
    Bug: 824568
    Change-Id: I810dfe67df49453139f992f55b58744d65031497
    Reviewed-on: https://chromium-review.googlesource.com/1170178
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582250}

    Changed files

    • chromeos/services/multidevice_setup/host_status_provider.cc
  41. [LayoutNG] Correctly recalculate min/max of objects with intrinsic ratio.

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:18:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f21ed3712c53e13e0c75fb8eb5c450069de056ed

    Comments

    [LayoutNG] Correctly recalculate min/max of objects with intrinsic ratio.
    
    Objects with an intrinsic ratio (such as images) whose block size is
    percent based will actually have their min/max inline size affected by
    the block size of the container. Some special code is required for this.
    
    Similar code exists for legacy layout in
    LayoutBlock::ComputeBlockPreferredLogicalWidths().
    
    Additionally, we need to clear the override containing block size when
    done with legacy layout, or subsequent min/max calcul
    ...skip...
    g. in LayoutBox::ContainingBlockLogicalHeightForContent()).
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I22ee962eddca44586e2cb4e83039f829bd9d5997
    Reviewed-on: https://chromium-review.googlesource.com/1167182
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582251}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_length_utils.cc
  42. Add jdufault@ to chromeos_login WATCHLIST

    Changed by jdufaultohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:21:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ed1ef2bcc1d2ee1a738d7094cf0f7f7b68165eeb

    Comments

    Add jdufault@ to chromeos_login WATCHLIST
    
    Also extend chromeos_login to ash/login/*
    
    Change-Id: Ie7632e02892cdee3b8c1aa6131ec27171c06cd62
    Reviewed-on: https://chromium-review.googlesource.com/1171210
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582252}

    Changed files

    • WATCHLISTS
  43. Fix flaky SitePerProcessHitTestDataGenerationTest

    Changed by sunxdohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:21:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae52aa4fe615d1eb071b47542294732f4b344daa

    Comments

    Fix flaky SitePerProcessHitTestDataGenerationTest
    
    This patch attempts to fix the flaky content browsertest. The suspected
    reason of the test being flaky is that the subframe content is not fully
    loaded and processed when hit test data is collected. This patch force
    the test to wait until all subframes receive their hit test query entries,
    and retrieve hit test data directly from root frame hit test query.
    
    Bug: 869314
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Iccace2dfd11b613cccf67a23cf5fc8552f31544d
    Reviewed-on: https://chromium-review.googlesource.com/1161972
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Commit-Queue: Xianda Sun <sunxd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582253}

    Changed files

    • components/viz/host/hit_test/hit_test_query.h
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/public/test/hit_test_region_observer.cc
    • content/public/test/hit_test_region_observer.h
  44. ozone: drm: Allow importing buffers that cannot be added as framebuffers

    Changed by spangohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:26:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ccea48289edb2b94d4b9fc8d6d5f0fcca5437c5

    Comments

    ozone: drm: Allow importing buffers that cannot be added as framebuffers
    
    After 6fc38604ad77 ("ozone: drm: Move DrmFramebuffer from GbmBuffer to
    GbmPixmap"), if a buffer's format is supported for scanout but cannot
    be added as a framebuffer, we fail the import.
    
    This broke CTS tests, so relax this test and add a note.
    
    Bug: 872681
    Test: ozone_unittests
    
    Change-Id: I35e18f043abe21f5554369129da05448f990bfd4
    Reviewed-on: https://chromium-review.googlesource.com/1169595
    Commit-Queue: Michael Spang <spang@chromium.org>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582254}

    Changed files

    • ui/ozone/platform/drm/gpu/drm_framebuffer.cc
    • ui/ozone/platform/drm/gpu/drm_thread.cc
  45. Roll src/third_party/ffmpeg/ de23348fe..5659adb8f (248 commits)

    Changed by tguilbertohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:26:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6551687e3fb9507f402de85d903bd21c39430faf

    Comments

    Roll src/third_party/ffmpeg/ de23348fe..5659adb8f (248 commits)
    
    https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/de23348fef6f..5659adb8fc6f
    
    $ git log de23348fe..5659adb8f --date=short --no-merges --format='%ad %ae %s'
    2018-07-24 tguilbert Uncommit script changes
    2018-07-24 tguilbert GN Configuration
    2018-07-24 tguilbert M70 Chromium patches GN Configuration
    2018-07-04 cus avformat/mxfdec: drop invalid index table segments when sorting them
    2018-07-16 minasamy_ avfilter: Add col
    ...skip...
    dec/tscc: Do not duplicate images
    2018-07-15 michael avcodec/tscc: Move reading the side data palette before other checks
    2018-07-22 onemda avcodec/bink: set color range
    (...)
    
    Created with:
      roll-dep src/third_party/ffmpeg
    BUG=864711
    
    Change-Id: Ib256516b28b0b2095b52b3ac58c71f5fea8f2f60
    Reviewed-on: https://chromium-review.googlesource.com/1159479
    Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
    Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582255}

    Changed files

    • DEPS
  46. cros: Cleanup shelf background animator

    Changed by jdufaultohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:33:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 11811235ad21518de356b8bc3d3e33d22de47574

    Comments

    cros: Cleanup shelf background animator
    
    ShelfBackgroundAnimator determined color by looking at both ShelfBackgroundType
    and also the session state. ShelfBackgroundType was set from ShelfLayoutManager.
    
    Both ShelfLayoutManager and ShelfBackgroundAnimator observed session state
    changes and updated the shelf colors from that. This means that there were
    multiple color updates, and beyond that the rendered background type could
    diverge from what was requested by ShelfLayoutManager in the time between the
    
    ...skip...
    the ability for ShelfLayoutManager to observe session state changes, and
    encode the needed information in ShelfBackgroundType. This simplifies control
    flow and reduces complexity.
    
    Bug: 857221
    Change-Id: I173e8cc47d7f6f22123814d341a94749472f7932
    Reviewed-on: https://chromium-review.googlesource.com/1168028
    Commit-Queue: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582259}

    Changed files

    • ash/public/cpp/shelf_types.h
    • ash/shelf/shelf_background_animator.cc
    • ash/shelf/shelf_background_animator.h
    • ash/shelf/shelf_background_animator_unittest.cc
    • ash/shelf/shelf_layout_manager.cc
    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/shelf/shelf_widget.h
  47. use random GUID for the device id of the offline demo mode

    Changed by mukaiohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:28:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34b8b1f3ff2a4fdb916f2a81bd2debaf84a46c04

    Comments

    use random GUID for the device id of the offline demo mode
    
    Previously the device id was extracted from the offline policy,
    but that means all of the offline-enrolled device shared the same
    device id (since the offline policy data is stored on the device).
    
    This isn't a big issue as long as the device stays offline,
    but we should use the generated ID to allow making the transition
    to the online demo mode after the offline enrollment is conducted.
    
    BUG=827369
    TEST=manually walked through the offline enrollment
    
    Change-Id: I0d9713d78c08fabcd0fb49326e1acca9ee578b98
    Reviewed-on: https://chromium-review.googlesource.com/1147336
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Aga Wronska <agawronska@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582257}

    Changed files

    • chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
  48. Remove unnecessary premission from webview

    Changed by changwanohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:28:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb7f584d3f95f7cdfa9815b63813e7a976200d53

    Comments

    Remove unnecessary premission from webview
    
    We are unnecessarily adding this permission for standalone WebView:
    com.google.android.c2dm.permission.RECEIVE
    
    This was added in rolling a new version of GMS core through
    BackgroundTaskScheduler. WebView is only using TaskIds in BTS, just to
    avoid collision with Chrome (which is using the same UID). Therefore,
    this CL splits TaskIds from the rest of BTS and have WebView depend on
    it.
    
    Bug: 872977
    Change-Id: I424659366b2af661d83ad19590c4a76bca37a2ad
    Reviewed-on: https://chromium-review.googlesource.com/1170426
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Changwan Ryu <changwan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582256}

    Changed files

    • android_webview/BUILD.gn
    • components/background_task_scheduler/BUILD.gn
  49. Orderfile: options to save and reuse profile data.

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:30:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69e9e42e2bd486447c5da5c462e636a85af3c7f4

    Comments

    Orderfile: options to save and reuse profile data.
    
    Adds --pregenerated-profiles and --profile-save-dir to
    orderfile_generator_backend.py. These allow for precise comparisons
    between different versions of profile processing, that are not affected
    by variations in the symbols seen during device profiling.
    
    Bug: 869997
    Change-Id: I9dd734a77ea4a738e22f20f095e76879e71f3c0c
    Reviewed-on: https://chromium-review.googlesource.com/1162179
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582258}

    Changed files

    • tools/cygprofile/orderfile_generator_backend.py
    • tools/cygprofile/profile_android_startup.py
  50. Update policy templates and examples for HTTP-Bad

    Changed by cthompohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:33:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ac9b35193685a1d011d5df35020953913396802

    Comments

    Update policy templates and examples for HTTP-Bad
    
    This tweaks the policy templates and examples to be clearer about
    affects on the "Not Secure" UI and how wildcard hostname patterns work.
    
    Bug: 844885
    Change-Id: I49eba85762272a0bfedb4163cecad1b8e6df513a
    Reviewed-on: https://chromium-review.googlesource.com/1166247
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582260}

    Changed files

    • chrome/test/data/policy/policy_test_cases.json
    • components/policy/resources/policy_templates.json
  51. FrameSelection::SelectWordAroundCaret(): Check Start and End for Null

    Changed by tnijssenohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:43:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43cfa30f7b03a216265f767dc281afca4eb36e7e

    Comments

    FrameSelection::SelectWordAroundCaret(): Check Start and End for Null
    
    EphemeralRange crashes when it receives a null position. If a
    textfield is empty, the start and/or end of the word around the caret
    may be null. This causes the renderer to crash.
    
    Add a check that the start and end positions are not null before
    passing them in to EphemeralRange.
    
    Bug: 872443
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I7156bb99b53134d076359f9ea320b5a5cdbe5bc0
    Reviewed-on: https://chromium-review.googlesource.com/1169584
    Commit-Queue: Tessa Nijssen <tnijssen@google.com>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582264}

    Changed files

    • third_party/blink/renderer/core/editing/frame_selection.cc
  52. Revert "Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy""

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:35:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c2dc08bec95ff03e2d14313410a325b75f1b638

    Comments

    Revert "Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy""
    
    This reverts commit 94a8710dcfeb21a45160c9686edeec7de7e325c4.
    
    Reason for revert: Seems to have caused significant flakiness of many WebRtc tests: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRhODcxMGRjZmViMjFhNDUxNjBjOTY4NmVkZWVjN2RlN2UzMjVjNAw
    
    Original change's description:
    > Reland "Support dynamic refresh of WebRtcEventLogCollect
    ...skip...
     Pastarmov <pastarmovj@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#582162}
    
    TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org
    
    Change-Id: I39bd5b6ac26325522f068e78846dde2443f067ec
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 775415
    Reviewed-on: https://chromium-review.googlesource.com/1171263
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582261}

    Changed files

    • chrome/browser/media/webrtc/webrtc_event_log_manager.cc
    • chrome/browser/media/webrtc/webrtc_event_log_manager.h
    • chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
    • chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
    • chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
    • components/policy/resources/policy_templates.json
    • content/public/browser/webrtc_event_logger.h
  53. [CrOS MultiDevice] Initialize two preference values to true.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 18:35:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 117853e517dab9dd2ef75e3da0ea570bf334e4c5

    Comments

    [CrOS MultiDevice] Initialize two preference values to true.
    
    This CL updates the kSuiteEnabledPrefName and
    kAndroidMessagesFeatureEnabledPrefName preferences to true when they are
    registered. These values should be set to true so that once the setup
    flow completes, the toggles will be turned on. Without this change,
    users would complete the setup flow only to discover that MultiDevice
    features are disabled.
    
    Note that this change does not mean that these features will be
    available without completing setup; these preferences are not used until
    after setup has completed.
    
    Bug: 824568
    Change-Id: Ib14434a320a6dc9b1091e8e246f6924835a03763
    Reviewed-on: https://chromium-review.googlesource.com/1170176
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582262}

    Changed files

    • chromeos/services/multidevice_setup/public/cpp/prefs.cc
  54. [unified-consent] Rollback unified consent when feature is disabled

    Changed by tangltomohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:40:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c1e8e53a5a33d762ea3735bf5b43e8a3c737c7f

    Comments

    [unified-consent] Rollback unified consent when feature is disabled
    
    This CL rolls back the unified consent preferences when
    the installation is excluded from the experiment. This is
    needed in case the unified consent feature has to be disabled
    due to some reason and rolled out again later.
    
    During rollback, the following is done:
     - All unified consent prefs are cleared.
     - Sync-everything is turned back on if all datatypes are
     turned on and if the consent bump was supposed to be presented.
    
    Bug: 863937
    Change-Id: Icb58fad008069c0b38a1ef952ed19e48f8cd3fe6
    Reviewed-on: https://chromium-review.googlesource.com/1165226
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582263}

    Changed files

    • chrome/browser/unified_consent/unified_consent_service_factory.cc
    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc
  55. Clean up Legacy Download Manager code.

    Changed by eugenebutohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:44:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ea6e1be5006363d639c37ee16a7bae7ad49d1517

    Comments

    Clean up Legacy Download Manager code.
    
    New Download Manager was shipped to 100% users in M68 and enabled by
    default.
    
    Bug: 791806
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iccbc05ba0aeb90449518cea1ddb4422fff8eab3c
    Reviewed-on: https://chromium-review.googlesource.com/1170128
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582265}

    Changed files

    • ios/chrome/app/main_controller.mm
    • ios/chrome/browser/about_flags.mm
    • ios/chrome/browser/download/browser_download_service.mm
    • ios/chrome/browser/download/browser_download_service_unittest.mm
    • ios/chrome/browser/ios_chrome_flag_descriptions.cc
    • ios/chrome/browser/ios_chrome_flag_descriptions.h
    • ios/chrome/browser/prerender/preload_controller.mm
    • ios/chrome/browser/ui/browser_view_controller.mm
    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/browser/ui/download/legacy_download_manager_controller.h
    • ios/chrome/browser/ui/download/legacy_download_manager_controller.mm
    • ios/chrome/browser/ui/download/legacy_download_manager_controller_unittest.mm
    • ios/chrome/browser/ui/download/resources/BUILD.gn
    • ios/chrome/browser/ui/download/resources/DownloadManagerController.xib
    • ios/chrome/browser/ui/download/resources/error_icon.imageset/Contents.json
    • ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon.png
    • ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon@2x.png
    • ios/chrome/browser/ui/download/resources/error_icon.imageset/error_icon@3x.png
    • ios/chrome/browser/ui/download/resources/file_icon_body.imageset/Contents.json
    • ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body.png
    • ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body@2x.png
    • ios/chrome/browser/ui/download/resources/file_icon_body.imageset/file_icon_body@3x.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/Contents.json
    • ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold@2x.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold.imageset/file_icon_fold@3x.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/Contents.json
    • ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete@2x.png
    • ios/chrome/browser/ui/download/resources/file_icon_fold_complete.imageset/file_icon_fold_complete@3x.png
    • ios/web/features.mm
    • ios/web/public/features.h
    • ios/web/public/test/fakes/test_native_content_provider.mm
    • ios/web/public/web_state/ui/crw_native_content_provider.h
    • ios/web/web_state/ui/crw_web_controller.mm
  56. Use the right naming style for struct members in PdfMetafileSkia.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8780d73e37f051e21aa1addf170811a8f54087ed

    Comments

    Use the right naming style for struct members in PdfMetafileSkia.
    
    Change-Id: I3c63bb11a46b234f1bc8fddaf28f61c25924e837
    Reviewed-on: https://chromium-review.googlesource.com/1170565
    Reviewed-by: Wei Li <weili@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582266}

    Changed files

    • printing/pdf_metafile_skia.cc
  57. Fix folder flash issue

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:47:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01d0099637ca1f8ed8c4d0be82cf965fefb2a8f5

    Comments

    Fix folder flash issue
    
    Bug: 872804
    Change-Id: I2cac9c78c0d7c1fdde72741509f275b7273b7b12
    Reviewed-on: https://chromium-review.googlesource.com/1169778
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582267}

    Changed files

    • ash/app_list/views/app_list_folder_view.cc
  58. [omnibox mac] Make command-shift-enter open tab in foreground

    Changed by krbohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b72eac084f64f9aa76c959bd8077e752abb10c4f

    Comments

    [omnibox mac] Make command-shift-enter open tab in foreground
    
    Currently the code falls through to "if (command) then open in
    background." This change breaks out the variation if shift is
    also pressed.
    
    Bug: 870789
    Change-Id: Ie96d355c7c75bec276ed5322aac03f0d3f472a9b
    Reviewed-on: https://chromium-review.googlesource.com/1170860
    Reviewed-by: Tommy Li <tommycli@chromium.org>
    Commit-Queue: Kevin Bailey <krb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582268}

    Changed files

    • chrome/browser/ui/views/omnibox/omnibox_view_views.cc
  59. Reland "[vr] Make VR Java android_library and separate VR JNI registration"

    Changed by tiborgohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:48:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5ee8761e1515212802af23041e32fd2b2cefc0eb

    Comments

    Reland "[vr] Make VR Java android_library and separate VR JNI registration"
    
    This is a reland of f86a758d7984ab71181a0102fe72a7ac538a1a52 with fix for x86
    bots that have VR disabled.
    
    Original change's description:
    > [vr] Make VR Java android_library and separate VR JNI registration
    >
    > This CL does two things:
    >
    > - In order to move VR Java code into its own module move the code into a
    >   separate android_library target.
    >
    > - As a result of the separate library target we may miss making the VR
    >   
    ...skip...
    <tiborg@chromium.org>
    > Reviewed-by: agrieve <agrieve@chromium.org>
    > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#581576}
    
    TBR=agrieve@chromium.org,mthiesse@chromium.org
    
    Bug: 862694
    Change-Id: If069e04fe7897f95ce7634b5fd6199eece3a6f73
    Reviewed-on: https://chromium-review.googlesource.com/1167770
    Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582269}

    Changed files

    • base/android/jni_generator/jni_exception_list.gni
    • base/android/jni_generator/jni_generator_tests.py
    • base/android/jni_generator/jni_registration_generator.py
    • base/android/jni_generator/testInnerClassNativesBothInnerAndOuterRegistrations.golden
    • base/android/jni_generator/testNativesRegistrations.golden
    • build/android/gyp/proguard.py
    • build/android/gyp/write_build_config.py
    • build/config/android/rules.gni
    • chrome/android/BUILD.gn
    • chrome/android/chrome_public_apk_tmpl.gni
    • chrome/android/java/src/org/chromium/chrome/browser/vr/SilenceLintErrors.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModuleProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/register_jni.cc
    • chrome/browser/android/vr/register_jni.h
    • chrome/browser/android/vr/register_jni_monochrome.cc
    • chrome/browser/android/vr/vr_module_provider.cc
    • chrome/test/BUILD.gn
  60. media/gpu shared memory: update v4l2 UnalignedSharedMemory

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:49:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cfe635cec3e0b4e3a490a6785711f6b0963ced3a

    Comments

    media/gpu shared memory: update v4l2 UnalignedSharedMemory
    
    Uses the new WritableUnalignedMapping class, which changes the ownership
    semantics. See the bug for details on the overall plan.
    
    Bug: 849207
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Idacc45e249291bd9d42ff7bf9a8abffe8636f6cf
    Reviewed-on: https://chromium-review.googlesource.com/1117692
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582270}

    Changed files

    • media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
    • media/gpu/v4l2/v4l2_jpeg_decode_accelerator.h
    • media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc
    • media/gpu/v4l2/v4l2_video_decode_accelerator.cc
    • media/gpu/v4l2/v4l2_video_encode_accelerator.cc
  61. [Picture in Picture] Update close button style.

    Changed by apacibleohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:50:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a1ad4a1cde048138003b8cc01cf75fba8b9e58c

    Comments

    [Picture in Picture] Update close button style.
    
    This change updates the close button style. The color of the 'x' is now
    white. There is no background unless the user hovers over the icon. In
    this case, there is a grey circular background.
    
    As part of this change, CloseIconButton is created to account for the
    hover behavior.
    
    Bug: 872098
    Change-Id: I90a53c5e42d6377db4ee45b47633689315865c18
    Reviewed-on: https://chromium-review.googlesource.com/1168732
    Commit-Queue: apacible <apacible@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582271}

    Changed files

    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/views/overlay/close_image_button.cc
    • chrome/browser/ui/views/overlay/close_image_button.h
    • chrome/browser/ui/views/overlay/overlay_window_views.cc
    • chrome/browser/ui/views/overlay/overlay_window_views.h
  62. [layoutng] Remove an unnecessary duplicate call to ComputePadding

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:50:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c4f51eb4a16077716ad725df84c3fe4a2cd6b86

    Comments

    [layoutng] Remove an unnecessary duplicate call to ComputePadding
    
    Also, makes CalculateBorderScrollbarPadding equivalent to
    ComputeBorder + ComputePadding + GetScrollbarSizes.
    
    This also makes the padding set on the fragment more correct.
    
    R=eae@chromium.org
    
    Bug: 635619
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I8db38ca5955d30fa789a636e5c6deb2ec1fd1829
    Reviewed-on: https://chromium-review.googlesource.com/1169321
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582272}

    Changed files

    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_length_utils.cc
    • third_party/blink/renderer/core/layout/ng/ng_length_utils.h
  63. Settings: site-data, focus on site select button before navigating away

    Changed by aeeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:52:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 52ce86ed119a545b3e5836118738ee955008a318

    Comments

    Settings: site-data, focus on site select button before navigating away
    
    Bug: 872197
    Change-Id: Ie98bf0737a9755312fda763053c9c15316b566be
    Reviewed-on: https://chromium-review.googlesource.com/1168283
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582273}

    Changed files

    • chrome/browser/resources/settings/site_settings/site_data.js
  64. WebUI: updating to iron-list v2.0.19, removing patch

    Changed by aeeohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:53:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a1c6d6a9ce8ad960621e45ec3840e57d5b54c69

    Comments

    WebUI: updating to iron-list v2.0.19, removing patch
    
    Bug: 870270
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I17c9c1494d2622dbf61398065c0b556a1183075f
    Reviewed-on: https://chromium-review.googlesource.com/1171203
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582274}

    Changed files

    • third_party/polymer/README.chromium
    • third_party/polymer/v1_0/bower.json
    • third_party/polymer/v1_0/chromium.patch
    • third_party/polymer/v1_0/components-chromium/iron-list/bower.json
    • third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js
    • third_party/polymer/v1_0/components_summary.txt
  65. Roll src/third_party/skia 6ed63968a391..4eac21fee047 (4 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 18:53:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 87cfb9fb9d43e000c7437897a296d3dbb63ec75c

    Comments

    Roll src/third_party/skia 6ed63968a391..4eac21fee047 (4 commits)
    
    https://skia.googlesource.com/skia.git/+log/6ed63968a391..4eac21fee047
    
    
    git log 6ed63968a391..4eac21fee047 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader d7622ffdd25e..dd662d210afc (1 commits)
    2018-08-10 bungeman@google.com Subpixel in Viewer from -1 to 1.
    2018-08-10 angle-skia-autoroll@skia-buildbots.google.com
    ...skip...
    rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=djsollen@chromium.org
    
    Change-Id: Ifd7584067a7fd1dff4d00a87ecf636c88e7257cd
    Reviewed-on: https://chromium-review.googlesource.com/1171122
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582275}

    Changed files

    • DEPS
  66. [DevTools] console.log("%d") should support BigInts

    Changed by kozyatinskiyohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 18:54:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f89db65c9d3ef2dd1e1173fdf0e7a21e6e3486d7

    Comments

    [DevTools] console.log("%d") should support BigInts
    
    R=luoe@chromium.org
    TBR=lushnikov@chromium.org
    
    Bug: v8:7486
    Change-Id: I332f979fb91d97c80f08f7dadd47d8929439c3fc
    Reviewed-on: https://chromium-review.googlesource.com/1169777
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: Alexei Filippov <alph@chromium.org>
    Reviewed-by: Erik Luo <luoe@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582276}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/flag-specific/js-flags=--harmony-bigint/http/tests/devtools/console/console-format-bigint-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/js-flags=--harmony-bigint/http/tests/devtools/startup/console/console-format-startup-bigint-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-bigint.js
    • third_party/blink/renderer/devtools/front_end/console/ConsoleViewMessage.js
  67. [build] Fix build of Monochrome base module

    Changed by tiborgohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:00:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8217643ea828e42c6dfd966b3d7d6d56df2a0d37

    Comments

    [build] Fix build of Monochrome base module
    
    Make bundle modules depend on the secondary ABI libraries. This should
    fix a build race condition where we fail if we build the Monochrome
    bundle module before the APK.
    
    Bug: 872998
    Change-Id: I756b779ac390e806666f398e00936df29f93cdaf
    Reviewed-on: https://chromium-review.googlesource.com/1171217
    Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582277}

    Changed files

    • build/config/android/rules.gni
  68. device/fido/mac: add fake environment for unit testing Touch ID code

    Changed by martinkrohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 19:04:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3c0f931cd742ca782c18fc6fbd57f26014d99cd

    Comments

    device/fido/mac: add fake environment for unit testing Touch ID code
    
    This adds a ScopedTouchIdTestEnvironment class to allow convenient
    faking functionality of the Touch ID authenticator that requires
    hardware support or user interaction.
    
    TouchIdContext is modified to:
     - allow injection of fakes through TouchIdContext::Create, in order to
    disable fingerprint prompts;
     - allow overriding the value returned by
    TouchIdContext::TouchIdAvailable, which determines hardware support and
    configuration status for Touch ID.
    
    The Keychain wrapper class is modified to allow injection of a fake into
    the singleton returned by Keychain::GetInstance. (FakeKeychain
    implementation will be done in a follow-up CL).
    
    Change-Id: I1b801b5bbe9b787965a5958206e6772a9a5eb09a
    Reviewed-on: https://chromium-review.googlesource.com/1162946
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Reviewed-by: Balazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582278}

    Changed files

    • content/browser/webauth/authenticator_impl_unittest.cc
    • device/fido/BUILD.gn
    • device/fido/mac/authenticator.mm
    • device/fido/mac/fake_keychain.h
    • device/fido/mac/fake_keychain.mm
    • device/fido/mac/fake_touch_id_context.h
    • device/fido/mac/fake_touch_id_context.mm
    • device/fido/mac/keychain.h
    • device/fido/mac/keychain.mm
    • device/fido/mac/operation_base.h
    • device/fido/mac/scoped_touch_id_test_environment.h
    • device/fido/mac/scoped_touch_id_test_environment.mm
    • device/fido/mac/touch_id_context.h
    • device/fido/mac/touch_id_context.mm
  69. Wire ManagedSessionEnabled policy through code

    Changed by isandrkohnoyoudont@google.com
    Changed at Friday, 10-Aug-18 19:05:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39d0fa970183c7aa0643ff4f2930de3435b3560f

    Comments

    Wire ManagedSessionEnabled policy through code
    
    If the policy is set, remove restrictions that were put into place for public
    sessions.
    
    Bug: 865947
    Change-Id: Ifdecf36916d9999ee2f90145dc69b7f46e18d0e1
    Reviewed-on: https://chromium-review.googlesource.com/1160651
    Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
    Reviewed-by: Kush Sinha <sinhak@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582279}

    Changed files

    • chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos.cc
    • chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
    • chrome/browser/chromeos/extensions/public_session_permission_helper.cc
    • chrome/browser/chromeos/login/users/chrome_user_manager_util.cc
    • chrome/browser/extensions/api/page_capture/page_capture_api.cc
    • chrome/browser/media/public_session_media_access_handler.cc
    • chrome/browser/media/public_session_tab_capture_access_handler.cc
    • chrome/browser/profiles/profiles_state.cc
    • chrome/browser/profiles/profiles_state.h
    • chrome/browser/ui/ash/network/enrollment_dialog_view.cc
    • chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc
    • chromeos/login/login_state.cc
    • chromeos/login/login_state.h
    • chromeos/login/scoped_test_public_session_login_state.cc
    • chromeos/login/scoped_test_public_session_login_state.h
    • extensions/browser/api/web_request/web_request_api.cc
    • extensions/browser/api/web_request/web_request_permissions.cc
  70. Roll src/third_party/pdfium 4174b5ab6ac9..e1a7e8589a8c (1 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 19:07:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d30286c2a870ae693860e3258ce50dd9ac93c03c

    Comments

    Roll src/third_party/pdfium 4174b5ab6ac9..e1a7e8589a8c (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/4174b5ab6ac9..e1a7e8589a8c
    
    
    git log 4174b5ab6ac9..e1a7e8589a8c --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 tsepez@chromium.org Remove const_cast<> from CFX_LZWDecompressor::Decode() caller.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@e1a7e8589a8c
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    htt
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I09961c58c5a521d64ae17af1a762ef100096a1a9
    Reviewed-on: https://chromium-review.googlesource.com/1171043
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582280}

    Changed files

    • DEPS
  71. Roll src/third_party/catapult 615ae9b6f35a..5a4110982f31 (1 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Friday, 10-Aug-18 19:11:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e49a8d622fe9cafa5ede24bdee7b39a056e0295

    Comments

    Roll src/third_party/catapult 615ae9b6f35a..5a4110982f31 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/615ae9b6f35a..5a4110982f31
    
    
    git log 615ae9b6f35a..5a4110982f31 --date=short --no-merges --format='%ad %ae %s'
    2018-08-10 dtu@chromium.org [dashboard] Stop sending 'None' as the comparison_magnitude.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@5a4110982f31
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here
    ...skip...
    u_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:873022
    TBR=sullivan@chromium.org
    
    Change-Id: I2d7a717b179bc4d5b613689b9fca13b6a3f62c07
    Reviewed-on: https://chromium-review.googlesource.com/1171162
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#582281}

    Changed files

    • DEPS
  72. Orderfile: Only use symbols in orderfile generation

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:12:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b1416232ce40b42c76bf35e7ca601b842fbef9b

    Comments

    Orderfile: Only use symbols in orderfile generation
    
    Removes gold-style section orderfile, as that is now not possible to
    generate with ThinLTO in lld.
    
    Bug: 869997
    Change-Id: I9d6970cf9c251cefdc69fbef6c87118fde844374
    Reviewed-on: https://chromium-review.googlesource.com/1162221
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582282}

    Changed files

    • tools/cygprofile/check_orderfile.py
    • tools/cygprofile/check_orderfile_unittest.py
    • tools/cygprofile/cyglog_to_orderfile.py
    • tools/cygprofile/orderfile_generator_backend.py
    • tools/cygprofile/patch_orderfile.py
    • tools/cygprofile/patch_orderfile_unittest.py
    • tools/cygprofile/process_profiles.py
    • tools/cygprofile/process_profiles_unittest.py
  73. Re-enable pretty-printed ExecutionMode test names

    Changed by joenotcharlesohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:24:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 29182424f4d1c29a0914e09916a198f4d1a4897a

    Comments

    Re-enable pretty-printed ExecutionMode test names
    
    Fix ODR violation with ExecutionMode by declaring the streaming operator in the
    same header as the type, and add back the GetParamNameForTest calls that use
    that operator.
    
    Also add a streaming operator for ChromePromptValue so that all types declared
    in constants.h can be pretty-printed.
    
    R=proberge
    
    Bug: 872748
    Change-Id: Idfe3f6044f97b003f17d83c6985d442f9b4103f6
    Reviewed-on: https://chromium-review.googlesource.com/1170852
    Commit-Queue: Joe Mason <joenotcharles@chromium.org>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582285}

    Changed files

    • chrome/chrome_cleaner/logging/BUILD.gn
    • chrome/chrome_cleaner/logging/cleaner_logging_service_unittest.cc
    • chrome/chrome_cleaner/settings/BUILD.gn
    • chrome/chrome_cleaner/settings/cleaner_settings_unittest.cc
    • chrome/chrome_cleaner/test/BUILD.gn
    • chrome/chrome_cleaner/test/test_name_helper.cc
    • chrome/chrome_cleaner/test/test_name_helper.h
    • chrome/test/BUILD.gn
    • components/chrome_cleaner/public/constants/BUILD.gn
    • components/chrome_cleaner/public/constants/constants.h
    • components/chrome_cleaner/public/constants/constants_test_support.cc
  74. [Desktop] Billing Interstitial UI

    Changed by spqchanohnoyoudont@chromium.org
    Changed at Friday, 10-Aug-18 19:19:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6da308ad98065e43393be2c8ec841189f8d6569b

    Comments

    [Desktop] Billing Interstitial UI
    
    This CL implements downloading the billing blacklist
    and then triggering the billing interstitial UI.
    
    The page info bubble is updated to support the billing
    interstitial.
    
    The billing page info and the interstitial UI is placed
    behind a new safebrowsing feature flag,
    "BillingInterstitial".
    
    Bug: 867518
    Change-Id: Id87463b272a9dcc4a3e3d95faaa48a942a2cb664
    Reviewed-on: https://chromium-review.googlesource.com/1163286
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Commit-Queue: Sarah Chan <spqchan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#582283}

    Changed files

    • chrome/browser/safe_browsing/url_checker_delegate_impl.cc
    • chrome/browser/ssl/security_state_tab_helper.cc
    • chrome/browser/ui/page_info/page_info.cc
    • chrome/browser/ui/page_info/page_info.h
    • chrome/browser/ui/page_info/page_info_ui.cc
    • components/page_info_strings.grdp
    • components/page_info_strings_grdp/IDS_PAGE_INFO_BILLING_DETAILS.png.sha1
    • components/page_info_strings_grdp/IDS_PAGE_INFO_BILLING_SUMMARY.png.sha1
    • components/safe_browsing/browser/safe_browsing_url_checker_impl.cc
    • components/safe_browsing/db/safebrowsing.proto
    • components/safe_browsing/db/v4_local_database_manager.cc
    • components/safe_browsing/db/v4_protocol_manager_util.cc
    • components/safe_browsing/db/v4_protocol_manager_util.h
    • components/safe_browsing/features.cc
    • components/safe_browsing/features.h
    • components/security_state/core/security_state.h