Home | Search
Login

Builder Win 10 High-DPI Perf Build #2342 Microsoft Windows

Results:

exception steps exception performance_test_suite on Intel GPU on Windows on Windows-10

Trigger Info:

Got Revision1961b00b0ac7bd6b490cd47c8834feceb58a083d

Execution:

Steps and Logfiles:

Show:
  1. ( 6 hrs 42 mins ) steps
    running steps via annotated script
  2. ( 15 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 5 secs ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  9. ( 1 ms ) remove .cipd
    remove .cipd
  10. ( 2 mins 45 secs ) bot_update
    bot_update
    [72GB/349GB used (20%)]
  11. ( 1 ms ) ensure_goma
    ensure_goma
  12. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  14. ( 28 secs ) gclient runhooks
    gclient runhooks
  15. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 2 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_10_High_DPI_Perf\src\testing\buildbot\chromium.perf.json
  17. ( 1 ms ) build directory
    build directory
  18. ( 1 mins 59 secs ) extract build
    extract build
  19. ( 1 ms ) find isolated tests
    find isolated tests
  20. ( 1 ms ) test_pre_run
    test_pre_run
  21. ( 14 secs ) test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  22. ( 6 hrs 35 mins ) performance_test_suite on Intel GPU on Windows on Windows-10
    performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 47s (shard #0)
    Max shard duration: 6:22:39.900100 (shard #3)
    Min shard duration: 5:02:45.125700 (shard #0)
    Total tests: 716
    * Passed: 681 (681 expected, 0 unexpected)
    * Skipped: 35 (35 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  23. ( 1 ms ) Upload to test-results [performance_test_suite on Intel GPU on Windows]
    Upload to test-results [performance_test_suite on Intel GPU on Windows]
  24. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 4
    Total runtime: 22:08:41.664000
     
  25. ( 1 ms ) process_dumps
    process_dumps
  26. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_10_High-DPI_Perf/2342/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_10_High-DPI_Perf/2342" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "e2c00841a55fb1a8d6615ecf41e1b971103d971c" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "aebc9e5205dcaad5d5954a18abc532316a954644" Annotation(bot_update)
got_revision "1961b00b0ac7bd6b490cd47c8834feceb58a083d" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#575955}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "65ea3e26ace71bfb80f977f5e6876ea2db851b5e" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.426@{#1}" Annotation(bot_update)
got_webrtc_revision "0f5400acfa40b4ecbf71bf44d925ea6ec9d3401d" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24010}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"55adad37a706ab5520e332b68a50150209094b77","command_buffer_perftests":"c8b0c6cb993648f31daf0b88c4e6e9752ac6a629","components_perftests":"ea1d2b784374f210053c4e14d9141bf257fe40f7","load_library_perf_tests":"b41ef36d704908e7282d1a7087e7aa63b6d61f8b","media_perftests":"7afb6ad1daca9f9659b6deb25778276b8ef4dc93","performance_test_suite":"14460c5a46523c32d1cc3a0b9c2499d8d944b705","views_perftests":"429ac5ce879b78824cf63b54d039dc8a9c7496ff"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmpbqtfnp" Annotation(steps)
build_id "buildbot/chromium.perf/Win 10 High-DPI Perf/2342" Annotation(steps)
builder_id "master.chromium.perf:Win 10 High-DPI Perf" Annotation(steps)
blamelist ["afakhry@google.com","akalugin@yandex-team.ru","alancutter@chromium.org","alexmos@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","beccahughes@chromium.org","billorr@chromium.org","blink-w3c-test-autoroller@chromium.org","calamity@chromium.org","cbiesinger@chromium.org","ccameron@chromium.org","chrisha@chromium.org","chrishtr@chromium.org","chrome-release-bot@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","davidben@chromium.org","dcreager@chromium.org","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","dgozman@chromium.org","dmblack@google.com","dmurph@chromium.org","dominickn@chromium.org","drubery@chromium.org","dtseng@chromium.org","eui-sang.lim@samsung.com","falken@chromium.org","georgesak@chromium.org","hongchan@chromium.org","jiameng@chromium.org","jianj@google.com","jinho.bang@samsung.com","joelhockey@chromium.org","justincohen@google.com","keishi@chromium.org","kkhorimoto@chromium.org","kojii@chromium.org","kpaulhamus@chromium.org","kristipark@chromium.org","lethalantidote@chromium.org","lgrey@chromium.org","luum@chromium.org","mcasas@chromium.org","miu@chromium.org","morlovich@chromium.org","nigeltao@chromium.org","orinj@chromium.org","pcc@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","peter@chromium.org","pwnall@chromium.org","qinmin@chromium.org","rdevlin.cronin@chromium.org","ricea@chromium.org","robertocn@google.com","rohitrao@chromium.org","sammc@chromium.org","scottchen@chromium.org","shaseley@google.com","shend@chromium.org","shenghao@google.com","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","suproteem@chromium.org","tetsui@chromium.org","thegreenfrog@chromium.org","thestig@chromium.org","tikuta@chromium.org","tkent@chromium.org","tommycli@chromium.org","twellington@chromium.org","v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com","vabr@chromium.org","vakh@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","weidongg@chromium.org","wez@chromium.org","xiaochengh@chromium.org","yamaguchi@chromium.org","yhirano@chromium.org","yoichio@chromium.org","zhelfins@chromium.org","zhongyi@chromium.org"] Build
branch "master" Build
buildnumber 2342 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531890774 Build
revision "1961b00b0ac7bd6b490cd47c8834feceb58a083d" Build
slavename "vm2-m1" BuildSlave
buildername "Win 10 High-DPI Perf" Builder
git_revision "1961b00b0ac7bd6b490cd47c8834feceb58a083d" Change
parent_buildername "Win x64 Builder Perf" ParentBuild
parent_buildnumber 28223 ParentBuild
parent_got_angle_revision "e2c00841a55fb1a8d6615ecf41e1b971103d971c" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "aebc9e5205dcaad5d5954a18abc532316a954644" ParentBuild
parent_got_revision "1961b00b0ac7bd6b490cd47c8834feceb58a083d" ParentBuild
parent_got_revision_cp "refs/heads/master@{#575955}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "65ea3e26ace71bfb80f977f5e6876ea2db851b5e" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.426@{#1}" ParentBuild
parent_got_webrtc_revision "0f5400acfa40b4ecbf71bf44d925ea6ec9d3401d" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24010}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_10_High-DPI_Perf" slave

Blamelist:

  1. (pccohnoyoudont@chromium.org)
  2. (thegreenfrogohnoyoudont@chromium.org)
  3. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. (shendohnoyoudont@chromium.org)
  5. (alexmosohnoyoudont@chromium.org)
  6. (georgesakohnoyoudont@chromium.org)
  7. (chrishtrohnoyoudont@chromium.org)
  8. (dominicknohnoyoudont@chromium.org)
  9. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  10. (vabrohnoyoudont@chromium.org)
  11. (kkhorimotoohnoyoudont@chromium.org)
  12. (jinho.bangohnoyoudont@samsung.com)
  13. (src-internal-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  14. (qinminohnoyoudont@chromium.org)
  15. (miuohnoyoudont@chromium.org)
  16. (lethalantidoteohnoyoudont@chromium.org)
  17. (mcasasohnoyoudont@chromium.org)
  18. (xiaochenghohnoyoudont@chromium.org)
  19. (weidonggohnoyoudont@chromium.org)
  20. (xiaochenghohnoyoudont@chromium.org)
  21. (wezohnoyoudont@chromium.org)
  22. (qinminohnoyoudont@chromium.org)
  23. (cbiesingerohnoyoudont@chromium.org)
  24. (hongchanohnoyoudont@chromium.org)
  25. (beccahughesohnoyoudont@chromium.org)
  26. (luumohnoyoudont@chromium.org)
  27. (zhelfinsohnoyoudont@chromium.org)
  28. (pwnallohnoyoudont@chromium.org)
  29. (robertocnohnoyoudont@google.com)
  30. (tikutaohnoyoudont@chromium.org)
  31. (dominicknohnoyoudont@chromium.org)
  32. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  33. (qinminohnoyoudont@chromium.org)
  34. (vakhohnoyoudont@chromium.org)
  35. (tommycliohnoyoudont@chromium.org)
  36. (pwnallohnoyoudont@chromium.org)
  37. (chrishaohnoyoudont@chromium.org)
  38. (thestigohnoyoudont@chromium.org)
  39. (kkhorimotoohnoyoudont@chromium.org)
  40. (pwnallohnoyoudont@chromium.org)
  41. (ccameronohnoyoudont@chromium.org)
  42. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  43. (rohitraoohnoyoudont@chromium.org)
  44. (scottchenohnoyoudont@chromium.org)
  45. (src-internal-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  46. (dcreagerohnoyoudont@chromium.org)
  47. (rdevlin.croninohnoyoudont@chromium.org)
  48. (dominicknohnoyoudont@chromium.org)
  49. (twellingtonohnoyoudont@chromium.org)
  50. (kkhorimotoohnoyoudont@chromium.org)
  51. (dmblackohnoyoudont@google.com)
  52. (morlovichohnoyoudont@chromium.org)
  53. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  54. (justincohenohnoyoudont@google.com)
  55. (kpaulhamusohnoyoudont@chromium.org)
  56. (orinjohnoyoudont@chromium.org)
  57. (dgozmanohnoyoudont@chromium.org)
  58. (afakhryohnoyoudont@google.com)
  59. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  60. (shenghaoohnoyoudont@google.com)
  61. (druberyohnoyoudont@chromium.org)
  62. (shaseleyohnoyoudont@google.com)
  63. (billorrohnoyoudont@chromium.org)
  64. (lgreyohnoyoudont@chromium.org)
  65. (zhongyiohnoyoudont@chromium.org)
  66. (orinjohnoyoudont@chromium.org)
  67. (davidbenohnoyoudont@chromium.org)
  68. (calamityohnoyoudont@chromium.org)
  69. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  70. (peterohnoyoudont@chromium.org)
  71. (falkenohnoyoudont@chromium.org)
  72. (suproteemohnoyoudont@chromium.org)
  73. (alancutterohnoyoudont@chromium.org)
  74. (joelhockeyohnoyoudont@chromium.org)
  75. (akaluginohnoyoudont@yandex-team.ru)
  76. (kristiparkohnoyoudont@chromium.org)
  77. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  78. (dtsengohnoyoudont@chromium.org)
  79. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  80. (tkentohnoyoudont@chromium.org)
  81. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  82. (scottchenohnoyoudont@chromium.org)
  83. (alexmosohnoyoudont@chromium.org)
  84. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  85. (jianjohnoyoudont@google.com)
  86. (dmurphohnoyoudont@chromium.org)
  87. (eui-sang.limohnoyoudont@samsung.com)
  88. (pwnallohnoyoudont@chromium.org)
  89. (keishiohnoyoudont@chromium.org)
  90. (kojiiohnoyoudont@chromium.org)
  91. (chrome-release-botohnoyoudont@chromium.org)
  92. (tetsuiohnoyoudont@chromium.org)
  93. (yhiranoohnoyoudont@chromium.org)
  94. (sammcohnoyoudont@chromium.org)
  95. (riceaohnoyoudont@chromium.org)
  96. (yamaguchiohnoyoudont@chromium.org)
  97. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  98. (yhiranoohnoyoudont@chromium.org)
  99. (yhiranoohnoyoudont@chromium.org)
  100. (yoichioohnoyoudont@chromium.org)
  101. (kojiiohnoyoudont@chromium.org)
  102. (kristiparkohnoyoudont@chromium.org)
  103. (calamityohnoyoudont@chromium.org)
  104. (jiamengohnoyoudont@chromium.org)
  105. (kojiiohnoyoudont@chromium.org)
  106. (tetsuiohnoyoudont@chromium.org)
  107. (nigeltaoohnoyoudont@chromium.org)
  108. (calamityohnoyoudont@chromium.org)

Timing:

Create N/A
Start Wednesday, 18-Jul-18 12:03:53 UTC
End Wednesday, 18-Jul-18 18:46:43 UTC
Pending N/A
Execution 6 hrs 42 mins

All Changes:

  1. build: Disable -fwhole-program-vtables on Android.

    Changed by pccohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:53:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9641b86adec1ee8d34f2f1c0b11162e6dc88bb74

    Comments

    build: Disable -fwhole-program-vtables on Android.
    
    We aren't currently building libc++ ourselves, which means that
    once we enable ThinLTO in official builds, libc++ won't be built
    with LTO, which is a violation of the LTO visibility rules, which
    require all classes with hidden visibility to be built with LTO
    when using the CFI or whole-program devirtualization features:
    https://clang.llvm.org/docs/LTOVisibility.html
    
    This hasn't caused any problems in practice as far as I know, but
    it could in theory, so it's probably best to disable it to be safe.
    We should be able to re-enable it on Android once issue 767901 is
    fixed and we create another GVR shim prebuilt compiled with ThinLTO.
    
    Bug: 469376, 767901
    Change-Id: Ic5554c48c1d4a458a834b16b9f7bd20523871282
    Reviewed-on: https://chromium-review.googlesource.com/1141108
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Peter Collingbourne <pcc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575850}

    Changed files

    • build/config/compiler/BUILD.gn
  2. [ios] Fix TableViewTextLinkCell Label Spacing

    Changed by thegreenfrogohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:53:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ea45f07fd2fcd624666fe19021e6e5223f56eb0

    Comments

    [ios] Fix TableViewTextLinkCell Label Spacing
    
    - Increases top spacing to 13px
    - Decreases bottom spacing to 0px so that the vertical spacing between footnote labels in Clear Browsing Data is not massive.
    
    Screenshots: https://drive.google.com/open?id=12DY7uMoFwu0qpy93N3nUEdsBPIDeaJlQ, https://drive.google.com/open?id=1XARsG_J1dvUu1gSDVBJW4qTfPVMTp8mN
    
    Bug: 863330
    Change-Id: I92b7b4d09617353d6ccba088ea8fa3675b32c986
    Reviewed-on: https://chromium-review.googlesource.com/1141056
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575851}

    Changed files

    • ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h
    • ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.mm
    • ios/chrome/browser/ui/table_view/cells/table_view_text_link_item.mm
  3. Roll src/third_party/skia 3229e65886a0..21a99d42c34f (5 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 17-Jul-18 23:54:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9bf661e2e9555f73d4c9fba26b8dbc05d2a6f305

    Comments

    Roll src/third_party/skia 3229e65886a0..21a99d42c34f (5 commits)
    
    https://skia.googlesource.com/skia.git/+log/3229e65886a0..21a99d42c34f
    
    
    git log 3229e65886a0..21a99d42c34f --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 junov@chromium.org Fix validity check in SkSurface::MakeFromBackendTextureAsRenderTarget
    2018-07-17 ethannicholas@google.com fixed SPIR-V memory layout
    2018-07-17 allanmac@google.com Use std::chrono for measuring timing
    2018-07-17 recipe-roller@chromium.org Roll recipe depe
    ...skip...
    :mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:788439
    TBR=bungeman@chromium.org
    
    Change-Id: I0d28ef2fa612e4d10cb0e778a4332769bba7aa49
    Reviewed-on: https://chromium-review.googlesource.com/1140537
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575852}

    Changed files

    • DEPS
  4. [VK] Disable shadows in new UI.

    Changed by shendohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:54:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb2cc0c4547aedb7ee97d32916980849b7523ec7

    Comments

    [VK] Disable shadows in new UI.
    
    In the new UI, we have to draw the keyboard drop shadow manually in the
    extension because of the non-rectangular geometry of the new floating
    keyboard. So we just disable shadows. When shadows are added in the
    extension, the keyboard window should resize correctly.
    
    Change-Id: I8530779930c109c834f33c5f673dbcc553ced6a2
    Reviewed-on: https://chromium-review.googlesource.com/1139948
    Commit-Queue: Darren Shen <shend@chromium.org>
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575853}

    Changed files

    • chrome/browser/ui/ash/chrome_keyboard_ui.cc
  5. Add temporary DumpWithoutCrashing to InitRenderFrameProxy().

    Changed by alexmosohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:56:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 475a55ea17d4fc6ae1efbdea9300a92d5ee86616

    Comments

    Add temporary DumpWithoutCrashing to InitRenderFrameProxy().
    
    This should help investigate a theory that a message to create a
    RenderFrameProxy is sent when that proxy already exists in the
    renderer process.
    
    Bug: 794625
    Change-Id: I2bf7dc1312dc3cbf8d307c8358ac64c8402fe875
    Reviewed-on: https://chromium-review.googlesource.com/1139186
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575856}

    Changed files

    • content/browser/frame_host/render_frame_proxy_host.cc
  6. Enable enterprise.reportingPrivate API on Stable.

    Changed by georgesakohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:55:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0eae27d80e7499c5740580c960c6bf73c81c9865

    Comments

    Enable enterprise.reportingPrivate API on Stable.
    
    Change-Id: I1bbeefa0bb68da658443e65ed1f9d63a510c4ed8
    Bug: 826298
    Reviewed-on: https://chromium-review.googlesource.com/1141050
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Georges Khalil <georgesak@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575854}

    Changed files

    • chrome/common/extensions/api/_permission_features.json
  7. Reset the cull rect to an infinite rect underneath an SVG child transform.

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:55:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6f63a06d5f863ce949265ce072d1d6d99cf5d3be

    Comments

    Reset the cull rect to an infinite rect underneath an SVG child transform.
    
    This matches behavior already implemented in PaintLayerPainter, which was added
    to greatly simplify the problem of detecting clip property node invalidations
    upon change of clip (but not addition or removal of such clips).
    
    With the rollout of SPv175, invalidation under SVG transforms is also subject
    to this need. Before SPv175, non-composited transform mutations caused a forced
    subtree invalidation. Now there is an invalidati
    ...skip...
    se case
    for CSS transform was another justification for the infinite cull rect
    in PaintLayerPainter).
    
    Bug: 862318
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ibb65c7fd491b1be725a6aa05a33e9ba7cc03782d
    Reviewed-on: https://chromium-review.googlesource.com/1139583
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Reviewed-by: Stephen Chenney <schenney@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575855}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/cull-rect-change-crash-expected.txt
    • third_party/WebKit/LayoutTests/paint/invalidation/cull-rect-change-crash-expected.txt
    • third_party/WebKit/LayoutTests/svg/transforms/cull-rect-transform-change-expected.html
    • third_party/WebKit/LayoutTests/svg/transforms/cull-rect-transform-change.html
    • third_party/blink/renderer/core/paint/paint_info.h
    • third_party/blink/renderer/core/paint/paint_layer_painter.cc
    • third_party/blink/renderer/core/paint/svg_container_painter.cc
  8. Remove browser-initiated navigations from WebContentsObserver::DidGetUserInteraction.

    Changed by dominicknohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 37a15052f10515874939931d9ed725e94bc94ee7

    Comments

    Remove browser-initiated navigations from WebContentsObserver::DidGetUserInteraction.
    
    Some types of user interactions are used as a signal to
    ResourceDispatcherHostImpl. Prior to https://crrev.com/1735833002,
    scrolling was not one of them, and part of that CL's work explicitly
    filtered out MouseWheel events from being passed to
    ResourceDispatcherHostImpl. It also changed user-initiated
    navigations to call the new DidGetUserInteraction method with the
    blink::WebInputEvent::Undefined type. However, onl
    ...skip...
    m/1125703
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575857}

    Changed files

    • chrome/browser/chrome_site_per_process_browsertest.cc
    • chrome/browser/download/download_request_limiter.cc
    • chrome/browser/download/download_request_limiter.h
    • chrome/browser/download/download_request_limiter_unittest.cc
    • chrome/browser/engagement/site_engagement_helper.cc
    • chrome/browser/metrics/tab_stats_tracker.cc
    • chrome/browser/metrics/tab_stats_tracker.h
    • chrome/browser/safe_browsing/safe_browsing_navigation_observer.cc
    • chrome/browser/safe_browsing/safe_browsing_navigation_observer.h
    • chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.cc
    • chrome/browser/ui/app_list/search/answer_card/answer_card_web_contents.h
    • chrome/browser/ui/blocked_content/popup_opener_tab_helper.cc
    • chrome/browser/ui/blocked_content/popup_opener_tab_helper.h
    • chrome/browser/ui/browser_browsertest.cc
    • content/browser/web_contents/web_contents_impl.cc
    • content/browser/web_contents/web_contents_impl.h
    • content/public/browser/navigation_handle.h
    • content/public/browser/web_contents.h
    • content/public/browser/web_contents_observer.h
  9. Roll src/third_party/depot_tools 40bacee96a94..e6ddf1942ca0 (2 commits)

    Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 17-Jul-18 23:57:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cd362031b407c9ca4c956d8d6e3935f038f2503

    Comments

    Roll src/third_party/depot_tools 40bacee96a94..e6ddf1942ca0 (2 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40bacee96a94..e6ddf1942ca0
    
    
    git log 40bacee96a94..e6ddf1942ca0 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 bratell@opera.com Stop gclient sync from scrolling during progress output
    2018-07-17 ehmaldonado@chromium.org gclient: Start reporting metrics.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@e6ddf1942ca0
    
    The AutoRoll server
    ...skip...
     the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:832386
    TBR=agable@chromium.org
    
    Change-Id: I9f5a812dba6fa48f05ee1ec16a19065b3bc4e255
    Reviewed-on: https://chromium-review.googlesource.com/1140536
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575858}

    Changed files

    • DEPS
  10. Remove autofill::form_util::ScopedLayoutPreventer

    Changed by vabrohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:58:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ff6d76db8c032fa23bc8c215a87b53e99304ec5a

    Comments

    Remove autofill::form_util::ScopedLayoutPreventer
    
    ScopedLayoutPreventer was used to avoid detecting visibility of form
    elements in situations when it was believed to cause pre-mature layout
    (see https://crbug.com/595078). Visibility is approximated through
    calling IsFocusable on the WebNodes corresponding to forms and their
    fields.
    
    Looking at recent documentation, though, the WebNode-based API seems
    robust enough to prevent such dangerous calls:
      (1) The contract of Element::IsFocusable() only stat
    ...skip...
     result, ScopedLayoutPreventer blocked visibility checks
    unnecessarily, leading to bugs like https://crbug.com/851808.
    
    Therefore this CL removes ScopedLayoutPreventer.
    
    Bug: 855598,851808,595078
    Change-Id: Ic415919be5c40821dfa965eeb16372ae92ba92d5
    Reviewed-on: https://chromium-review.googlesource.com/1136531
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Vaclav Brozek <vabr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575859}

    Changed files

    • components/autofill/content/renderer/form_autofill_util.cc
    • components/autofill/content/renderer/form_autofill_util.h
    • components/autofill/content/renderer/form_autofill_util_browsertest.cc
    • components/autofill/content/renderer/password_autofill_agent.cc
  11. [iOS] Update NTP Reading List a11y label to include unread article count

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Tuesday, 17-Jul-18 23:58:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee1229d3efe8303829fb4dd046634e7b9b8569a3

    Comments

    [iOS] Update NTP Reading List a11y label to include unread article count
    
    This CL updates ContentSuggestionsMostVisitedActionItem to support
    custom a11y labels that differ from their titles, and adds a custom
    label for the Reading List cell that states the number of unread
    articles.
    
    Bug: 862299
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I972b5996fb3398154f656b8ea056b9028d468af0
    Reviewed-on: https://chromium-review.googlesource.com/1137027
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575860}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.h
    • ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.mm
  12. PaymentRequest: Remove the sequence version of supportedMethods (browser)

    Changed by jinho.bangohnoyoudont@samsung.com
    Changed at Wednesday, 18-Jul-18 00:00:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d252ebf5b17eb7f8ccc6b73f756a9cdb1d136d44

    Comments

    PaymentRequest: Remove the sequence version of supportedMethods (browser)
    
    This is one of several patches that will remove the sequence version of
    supportedMethods member. This patch stops using it by removing the
    related code in browser side.
      - [1/2] https://crrev.com/c/1078687
      - [2/2] This patch
    
    Intent to remove:
      https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/JAnUvBqXElU
    
    Bug: 754779
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia276a90240dc817e60ce8cf793454eb822e67a4e
    Reviewed-on: https://chromium-review.googlesource.com/1108057
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Ganggui Tang <gogerald@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    Cr-Commit-Position: refs/heads/master@{#575862}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentAppBridge.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDataUrlTest.java
    • chrome/browser/android/payments/service_worker_payment_app_bridge.cc
    • chrome/browser/payments/service_worker_payment_app_factory_browsertest.cc
    • components/payments/content/installable_payment_app_crawler.cc
    • components/payments/content/payment_request_converter.cc
    • components/payments/content/payment_request_spec.cc
    • components/payments/content/payment_request_spec_unittest.cc
    • components/payments/content/payment_request_state_unittest.cc
    • components/payments/content/payment_response_helper_unittest.cc
    • components/payments/content/service_worker_payment_app_factory.cc
    • components/payments/content/service_worker_payment_app_factory_unittest.cc
    • components/payments/content/service_worker_payment_instrument.cc
    • components/payments/content/service_worker_payment_instrument.h
    • components/payments/content/service_worker_payment_instrument_unittest.cc
    • components/payments/core/autofill_payment_instrument.cc
    • components/payments/core/autofill_payment_instrument.h
    • components/payments/core/payment_details_modifier.cc
    • components/payments/core/payment_details_modifier_unittest.cc
    • components/payments/core/payment_details_validation.cc
    • components/payments/core/payment_details_validation_unittest.cc
    • components/payments/core/payment_instrument.h
    • components/payments/core/payment_method_data.cc
    • components/payments/core/payment_method_data.h
    • components/payments/core/payment_method_data_unittest.cc
    • components/payments/core/payment_request_data_util.cc
    • components/payments/core/web_payment_request_unittest.cc
    • content/browser/payments/payment_app_browsertest.cc
    • content/browser/payments/payment_app_provider_impl_unittest.cc
    • content/browser/service_worker/embedded_worker_test_helper.cc
    • content/renderer/service_worker/service_worker_type_converters.cc
    • ios/chrome/browser/payments/ios_payment_instrument.h
    • ios/chrome/browser/payments/ios_payment_instrument.mm
    • ios/chrome/browser/payments/ios_payment_instrument_launcher_unittest.mm
    • ios/chrome/browser/payments/payment_request.mm
    • ios/chrome/browser/payments/payment_request_test_util.mm
    • ios/chrome/browser/payments/payment_request_unittest.mm
    • ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm
    • ios/chrome/browser/ui/payments/payment_request_payment_method_identifier_egtest.mm
    • ios/chrome/browser/web/resources/payment_request.js
    • third_party/blink/public/platform/modules/payments/payment_request.mojom
    • third_party/blink/renderer/modules/payments/payment_request.cc
  13. Roll src-internal ed1bf6ade339..718bcd15ec60 (1 commits)

    Changed by src-internal-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 17-Jul-18 23:59:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0d66d1d2dd8ca2d4bb2864cecafee273901af1d

    Comments

    Roll src-internal ed1bf6ade339..718bcd15ec60 (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed1bf6ade339..718bcd15ec60
    
    
    Created with:
      gclient setdep -r src-internal@718bcd15ec60
    
    The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:b/79769347
    TBR=mmoss@chromium.org
    
    Change-Id: Ib368183b3420bc4568814737cf57199b33937040
    Reviewed-on: https://chromium-review.googlesource.com/1140538
    Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575861}

    Changed files

    • DEPS
  14. Do a null check on BrowserContext in DownloadManagerService

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:04:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4d370e2ccac71fff3c4a5709439c2eef747c7340

    Comments

    Do a null check on BrowserContext in DownloadManagerService
    
    DownloadManagerService may start too early before full browser is started.
    In this case, downloadItem doesn't have a BrowserContext object assocuated,
    
    BUG=695115
    
    Change-Id: Ie7dcc88bb63cdfc8af0d0e4d4670e808e22f175e
    Reviewed-on: https://chromium-review.googlesource.com/1140519
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575863}

    Changed files

    • chrome/browser/android/download/download_manager_service.cc
  15. Merge media::ScreenCaptureDeviceCore into ScreenCaptureMachineAndroid.

    Changed by miuohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:10:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd22262b9c2a9630a931f886b4112f916235aa77

    Comments

    Merge media::ScreenCaptureDeviceCore into ScreenCaptureMachineAndroid.
    
    With no other screen capture implementations dependent upon
    media::ScreenCaptureDeviceCore, ThreadSafeCaptureOracle, etc.; this
    change merges this code into ScreenCaptureMachineAndroid. Unused
    functionality has been stripped-out, and minor callpoint- and lint-
    related clean-ups were made. No behavior/functional changes.
    
    Testing: Built monochrome_public_apk, installed it to my phone, and
    confirmed Android screen capture from that Chromium build still works by
    running a demo app: https://paulkinlan.github.io/screenrecord/.
    
    Bug: 806366,487935
    Change-Id: I3edb2603261b6ed60e31edf795ac8da9a2a8525c
    Reviewed-on: https://chromium-review.googlesource.com/1137733
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Weiyong Yao <braveyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575864}

    Changed files

    • content/browser/media/capture/screen_capture_device_android.cc
    • content/browser/media/capture/screen_capture_device_android.h
    • media/capture/BUILD.gn
    • media/capture/content/android/BUILD.gn
    • media/capture/content/android/screen_capture_machine_android.cc
    • media/capture/content/android/screen_capture_machine_android.h
    • media/capture/content/android/thread_safe_capture_oracle.cc
    • media/capture/content/android/thread_safe_capture_oracle.h
    • media/capture/content/screen_capture_device_core.cc
    • media/capture/content/screen_capture_device_core.h
  16. Revert "Disable two flaky tests on ChromeOS"

    Changed by lethalantidoteohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07f7e41c511c5ebc86d5606614da07ff37f41d07

    Comments

    Revert "Disable two flaky tests on ChromeOS"
    
    This reverts commit fed7475d501d0622e3604313eb93867405cba55f.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Disable two flaky tests on ChromeOS
    > 
    > Disable ShelfLayoutManagerTest.FlingUpOnShelfForFullscreenAppList
    > Disable WindowSelectorTest.RoundedEdgeMaskVisibility
    > 
    > Tbr: xiyuan, xdai
    > Bug: 864467, 864465
    > Change-Id: I77a0dbcddad5176575f0dc5991beb9eef8090167
    > Reviewed-on: https://chromium-review.googlesource.com/1140683
    > Reviewed-by: Owen Min <zmin@chromium.org>
    > Commit-Queue: Owen Min <zmin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#575707}
    
    TBR=zmin@chromium.org
    
    Change-Id: I2aaceb5588030a1b14edf9b0c1d2da6165cbf8f1
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 864467, 864465
    Reviewed-on: https://chromium-review.googlesource.com/1140460
    Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
    Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575865}

    Changed files

    • ash/shelf/shelf_layout_manager_unittest.cc
    • ash/wm/overview/window_selector_unittest.cc
  17. GMBVideoFramePool UMA: only log non-texture VideoFrames

    Changed by mcasasohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:12:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd37f90890183578fba64dd483432cb787178f1d

    Comments

    GMBVideoFramePool UMA: only log non-texture VideoFrames
    
    Follow up and correction to crrev.com/c/1132112: we should
    only log those VideoFrames that are not supported _and_
    that are not Textures/GMBs already. This CL adds the latter
    part.
    
    Bug: 787122
    Change-Id: Ieb4e4fff0f2e14e9beb6949f1531507ac80733ce
    Reviewed-on: https://chromium-review.googlesource.com/1140834
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575866}

    Changed files

    • media/video/gpu_memory_buffer_video_frame_pool.cc
  18. Disable WebviewClientCertsLoginTest.SigninFrameCertMultipleFiltersAutoSelected

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:19:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3a296794061c657566bc1fa18ff6e5c5ce0ba914

    Comments

    Disable WebviewClientCertsLoginTest.SigninFrameCertMultipleFiltersAutoSelected
    
    Bug: 830337
    Change-Id: Ica61483028f3cd92787191d3115476f54b5f84c2
    Tbr: achuith@chromium.org
    NoTry: True
    Reviewed-on: https://chromium-review.googlesource.com/1140798
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575867}

    Changed files

    • chrome/browser/chromeos/login/webview_login_browsertest.cc
  19. Implement new expand arrow and apps grid

    Changed by weidonggohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:23:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 966b8b6438017c0ca375e8ead2cd778e539ca844

    Comments

    Implement new expand arrow and apps grid
    
    1. Add TransitionAnimationObserver to layout app list at the end of
       animation to make sure child views are in right position.
    2. Replace old expand arrow icon with Skia-drawn arrow and implement the
       new transition.
    3. Change the layout of apps grid and make the rows and cols adaptive to
       the width and height.
    4. Enlarge the folder icon.
    
    Demo: https://drive.google.com/open?id=1xlGUpNv1X-s4D9mSjAPkyfZBMWhCjJag
    
    Change-Id: I3bc86870c66d0b35b36a801c16befb2624a33a55
    Reviewed-on: https://chromium-review.googlesource.com/1121547
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Yury Khmel <khmel@chromium.org>
    Commit-Queue: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575868}

    Changed files

    • ash/app_list/app_list_presenter_delegate_unittest.cc
    • ash/app_list/model/folder_image.cc
    • ash/app_list/views/app_list_view.cc
    • ash/app_list/views/app_list_view.h
    • ash/app_list/views/app_list_view_unittest.cc
    • ash/app_list/views/apps_container_view.cc
    • ash/app_list/views/apps_container_view.h
    • ash/app_list/views/apps_grid_view.cc
    • ash/app_list/views/apps_grid_view.h
    • ash/app_list/views/apps_grid_view_unittest.cc
    • ash/app_list/views/contents_view.cc
    • ash/app_list/views/contents_view.h
    • ash/app_list/views/expand_arrow_view.cc
    • ash/app_list/views/expand_arrow_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/search_box_view.cc
    • ash/app_list/views/search_result_suggestion_chip_view.cc
    • ash/public/cpp/app_list/app_list_config.cc
    • ash/public/cpp/app_list/app_list_config.h
    • ash/public/cpp/app_list/app_list_constants.cc
    • ash/public/cpp/app_list/app_list_constants.h
  20. Disable flaky FeedbackUploaderDispatchTest.500Response on Linux and ChromeOS

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:24:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5c054be784d9ad459acca06522482cd32092bce1

    Comments

    Disable flaky FeedbackUploaderDispatchTest.500Response on Linux and ChromeOS
    
    Bug: 864797
    Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407
    Tbr: afakhry@chromium.org
    NoTry: True
    Reviewed-on: https://chromium-review.googlesource.com/1141136
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575869}

    Changed files

    • components/feedback/feedback_uploader_dispatch_unittest.cc
  21. Roll Fuchsia SDK from 99f42fc7925d to e237df60615b

    Changed by wezohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:24:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cf06d0263c89f4c2e8d89cc34e31d535ca90a22b

    Comments

    Roll Fuchsia SDK from 99f42fc7925d to e237df60615b
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    
    Change-Id: I0ff88b708c490cc760902e245e6473e90546c4b9
    Reviewed-on: https://chromium-review.googlesource.com/1137750
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Leon Scroggins <scroggo@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575870}

    Changed files

    • base/files/file.h
    • base/files/file_posix.cc
    • base/files/file_util_posix.cc
    • build/fuchsia/sdk.sha1
    • third_party/fuchsia-sdk/BUILD.gn
    • third_party/zlib/contrib/minizip/ioapi.c
  22. Don't update history db for incompleted download if DownloadDB is enabled

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:35:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1166217ce22a672e5216ee0806847d4416a086f

    Comments

    Don't update history db for incompleted download if DownloadDB is enabled
    
    if DownloadDB is enabled, there is no need to update incomplete download
    in history db.
    The DownloadDB should contain all information.
    
    BUG=863602
    
    Change-Id: Idf20bbb91e8e5156aa21354695b0781493c723ef
    Reviewed-on: https://chromium-review.googlesource.com/1137235
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575873}

    Changed files

    • chrome/browser/download/download_history.cc
    • chrome/browser/download/download_history.h
  23. Reland "[layoutng] Use the correct layout algorithm to compute min/max sizes"

    Changed by cbiesingerohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:31:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41ba8bb0cfbb0764bb80dad6c6b0fdc5512b5cab

    Comments

    Reland "[layoutng] Use the correct layout algorithm to compute min/max sizes"
    
    This reverts commit 43df04fe7fe11a69605cfa669226ae74b91c41c2.
    
    Looks like there is no need for a flag-specific expectation anymore for
    virtual/layout_ng_experimental/fast/multicol/flexbox-with-overflow-auto-child-crash.html
    
    Original change's description:
    > [layoutng] Use the correct layout algorithm to compute min/max sizes
    >
    > This also required adding a check in NGBlockNode::ComputeMinMaxSize
    > for whether we are inside 
    ...skip...
    eue: Christian Biesinger <cbiesinger@chromium.org>
    > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#575545}
    
    Bug: 635619
    Change-Id: I28ca2367e21327d9f911c75b9f9950d171d48e1b
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Reviewed-on: https://chromium-review.googlesource.com/1140206
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575872}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/fast/multicol/intrinsic-width-expected.html
    • third_party/WebKit/LayoutTests/fast/multicol/intrinsic-width.html
    • third_party/WebKit/LayoutTests/virtual/layout_ng_experimental/fast/multicol/flexbox-with-overflow-auto-child-crash-expected.txt
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.h
  24. Remove CrossThreadUnretained wrapper when passing AudioWorkletHandler

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:35:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44010e122e561daf7d969f2d8d3c256775129d2d

    Comments

    Remove CrossThreadUnretained wrapper when passing AudioWorkletHandler
    
    Because AudioWorkletHandler is ThreadSafeRefCounted, wrapping with
    CrossThreadUnretained() when the handler is passed via CrossThreadBind()
    is unnecessary. Use scoped_refptr<> instead.
    
    Bug: 853520
    Test: All existing layout/WPT tests pass.
    Change-Id: I83409b89e80a9bbb60ea98649b16efb59facbbd4
    Reviewed-on: https://chromium-review.googlesource.com/1140744
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575874}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_worklet.cc
    • third_party/blink/renderer/modules/webaudio/audio_worklet.h
    • third_party/blink/renderer/modules/webaudio/audio_worklet_messaging_proxy.cc
    • third_party/blink/renderer/modules/webaudio/audio_worklet_messaging_proxy.h
    • third_party/blink/renderer/modules/webaudio/audio_worklet_node.cc
    • third_party/blink/renderer/modules/webaudio/audio_worklet_node.h
  25. [CSS Env Vars] Throw parse error when used with min/max

    Changed by beccahughesohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:28:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 113cc2d54f97a1384ecc5c3a0b8bcddbd0c3765f

    Comments

    [CSS Env Vars] Throw parse error when used with min/max
    
    min() and max() are not supported and should throw a parse
    error when used with env() and var().
    
    BUG=864435
    
    Change-Id: I7e89607cc6bb41910131b35a72dabb979f10b7dc
    Reviewed-on: https://chromium-review.googlesource.com/1140746
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575871}

    Changed files

    • third_party/WebKit/LayoutTests/css-parser/variables-invalid-functions.html
    • third_party/blink/renderer/core/css/parser/css_variable_parser.cc
  26. ARC CUPS API IPP request (oop)Validation service

    Changed by luumohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:41:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f7c617584d1d34fc9e8971a87ed09252b99364c

    Comments

    ARC CUPS API IPP request (oop)Validation service
    
    This service will serve the ARC CUPS API by accepting an IPP request via
    mojom calls, validate its format in a heavily restricted/jailed process,
    and return the result.
    
    This change just contains the scaffolding for the service,
    validation/jailing to follow soon.
    
    Test: WIP
    Bug: chromium:831913
    Change-Id: I5cd88b82746d999743e3ebddfc6aef15e408506d
    Reviewed-on: https://chromium-review.googlesource.com/1121108
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Luum Habtemariam <luum@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575877}

    Changed files

    • chrome/app/BUILD.gn
    • chrome/app/generated_resources.grd
    • chrome/browser/DEPS
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_manifest_overlay.json
    • chrome/services/cups_ipp_validator/BUILD.gn
    • chrome/services/cups_ipp_validator/OWNERS
    • chrome/services/cups_ipp_validator/cups_ipp_validator_service.cc
    • chrome/services/cups_ipp_validator/cups_ipp_validator_service.h
    • chrome/services/cups_ipp_validator/ipp_validator.cc
    • chrome/services/cups_ipp_validator/ipp_validator.h
    • chrome/services/cups_ipp_validator/manifest.json
    • chrome/services/cups_ipp_validator/public/mojom/BUILD.gn
    • chrome/services/cups_ipp_validator/public/mojom/OWNERS
    • chrome/services/cups_ipp_validator/public/mojom/constants.mojom
    • chrome/services/cups_ipp_validator/public/mojom/ipp_validator.mojom
    • chrome/utility/BUILD.gn
    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
  27. Inform user that Dictation sends audio to Google.

    Changed by zhelfinsohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:37:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 83cb1c0026ff87948daf8eba8d2ca900be848da4

    Comments

    Inform user that Dictation sends audio to Google.
    
    Dictation is an accessibility feature that allows users who opt-in
    to have their speech transcribed into any text field in ChromeOS.
    
    
    Screenshot: https://screenshot.googleplex.com/EkLrrNDAohB.png
    
    BUG=850690
    TEST=None
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I11ca4051b38a4beec7876ba35899e337f36411e4
    Reviewed-on: https://chromium-review.googlesource.com/1120852
    Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575875}

    Changed files

    • ash/accessibility/accessibility_controller.cc
    • ash/accessibility/accessibility_controller.h
    • ash/ash_strings.grd
    • ash/public/cpp/ash_pref_names.cc
    • ash/public/cpp/ash_pref_names.h
    • ash/system/accessibility/dictation_button_tray_unittest.cc
    • chrome/app/settings_strings.grdp
    • chrome/browser/chromeos/preferences.cc
    • chrome/browser/resources/settings/a11y_page/manage_a11y_page.html
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
  28. sql: Make Connection::StatementRef use 1-based ref-counting.

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:39:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b02cdf5fb45cff61abb73e565733ceb98302ca6

    Comments

    sql: Make Connection::StatementRef use 1-based ref-counting.
    
    0-based ref-counting is deprecated. 1-based counting is described in
    //base/memory/ref_counted.h. In summary, instaces must be created by
    base::MakeRefCounted<T> or (less ideal) base::AdoptRef(new T).
    
    This CL switches Connection::StatementRef to 1-based ref-counting, and
    
    std::move()'s scoped_refptr<StatementRef> in a few places where that
    avoids refcount churn.
    
    Bug: none
    Change-Id: I14755dc2482f18c8a9582066104f346c2873941d
    Reviewed-on: https://chromium-review.googlesource.com/1137848
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575876}

    Changed files

    • sql/connection.cc
    • sql/connection.h
    • sql/statement.cc
  29. Create cron schedule for bot-db exporter recipe.

    Changed by robertocnohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 00:47:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f53fc9369a1e0b8a48aa54d84c9e09b54540d9

    Comments

    Create cron schedule for bot-db exporter recipe.
    
    R=hinoka,chanli,stgao,liaoyuke,lijeffrey,prasadv
    
    Bug: 787918
    Change-Id: I0766fa1c9d575b9960d336152aa62c56a7a2b945
    Reviewed-on: https://chromium-review.googlesource.com/1141117
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
    Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575878}

    Changed files

    • infra/config/global/luci-scheduler.cfg
  30. Increase goma -j 80 -> 150 for 3 CQ builders

    Changed by tikutaohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:50:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da3ea38db824afac72d3f1fff33823670ee6a8f4

    Comments

    Increase goma -j 80 -> 150 for 3 CQ builders
    
    This is for following nearly 1 hour builds.
    
    * linux_chromium_tsan_rel_ng
    3783s https://ci.chromium.org/b/8940786382570619168
    
    * mac_chromium_compile_dbg_ng
    3534s https://ci.chromium.org/b/8940786382570619152
    
    * linux_chromium_compile_dbg_ng
    3534s https://ci.chromium.org/b/8940786382570619056
    
    Bug: 804251
    Change-Id: If82c10b26628271dfc01011da204c59858395bd7
    Reviewed-on: https://chromium-review.googlesource.com/1139934
    Reviewed-by: Ryan Tseng <hinoka@chromium.org>
    Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575879}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
  31. Update WATCHLISTS for dominickn.

    Changed by dominicknohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:51:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe197c75d78e476c29330c2ee92d5a5a2ab06ea4

    Comments

    Update WATCHLISTS for dominickn.
    
    BUG=None.
    
    Change-Id: I3edc7ba50a20c6e1fb87cd950a9f73d5c9a6c724
    Reviewed-on: https://chromium-review.googlesource.com/1140112
    Commit-Queue: Dominick Ng <dominickn@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575880}

    Changed files

    • WATCHLISTS
  32. Roll src/third_party/chromite 004af3cf8045..82b059ecb6a4 (2 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 00:52:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 124a59227e2b28d9c0f9da6dffab433323ec1b01

    Comments

    Roll src/third_party/chromite 004af3cf8045..82b059ecb6a4 (2 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/004af3cf8045..82b059ecb6a4
    
    
    git log 004af3cf8045..82b059ecb6a4 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 vapier@chromium.org lint: fix singleton-comparison warnings
    2018-07-17 vapier@chromium.org lint: fix no-value-for-parameter warnings
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@82b059ecb6a4
    
    The AutoRoll server is located here: https:
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I45415863772236473072d5116dd8ac87caff7654
    Reviewed-on: https://chromium-review.googlesource.com/1140613
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575881}

    Changed files

    • DEPS
  33. Fix an issue that ResourceDownloader was never deleted on download completion

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:56:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e0b12de09e77d5954ace778522cf1a41c90f13aa

    Comments

    Fix an issue that ResourceDownloader was never deleted on download completion
    
    This CL calls the InProgressDownloadManager to delete ResourceDownloader
    after response is completed.
    It also fixes the issue when download is cancelled.
    
    BUG=864189
    
    Change-Id: I184d5faaace90f49874e45b4126a0a9821fdced7
    Reviewed-on: https://chromium-review.googlesource.com/1138676
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575882}

    Changed files

    • components/download/internal/common/BUILD.gn
    • components/download/internal/common/download_response_handler.cc
    • components/download/internal/common/resource_downloader.cc
    • components/download/internal/common/resource_downloader.h
    • components/download/internal/common/url_download_request_handle.cc
    • components/download/public/common/BUILD.gn
    • components/download/public/common/download_response_handler.h
    • components/download/public/common/url_download_handler.h
    • components/download/public/common/url_download_request_handle.h
    • content/browser/download/url_downloader.cc
    • content/browser/download/url_downloader.h
  34. SuspiciousSiteTriggerQuota: Enable by default in code.

    Changed by vakhohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:57:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 201db37b8c9921a0154a12a43be693da3f572d79

    Comments

    SuspiciousSiteTriggerQuota: Enable by default in code.
    
    Default quota: 5
    
    Bug: 853382,730646
    Change-Id: Ib989a9053da93d7e083f3217082627fa8635da5e
    Reviewed-on: https://chromium-review.googlesource.com/1138864
    Commit-Queue: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Reviewed-by: Nathan Parker <nparker@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575883}

    Changed files

    • components/safe_browsing/features.cc
    • components/safe_browsing/triggers/trigger_throttler.cc
    • components/safe_browsing/triggers/trigger_throttler.h
    • components/safe_browsing/triggers/trigger_throttler_unittest.cc
  35. Omnibox UI Refresh: Make the selection bounds vertically symmetric.

    Changed by tommycliohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:04:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c9870ad6a5b613532232f1ff3a481c737238dc1

    Comments

    Omnibox UI Refresh: Make the selection bounds vertically symmetric.
    
    See the bug for screenshots.
    
    Currently, the selection bounds in the Omnibox are not vertically
    symmetric. This is becoming a lot more noticeable with the MD Refresh
    redesign.
    
    This CL extends RenderText to allow expanding the selection bounds to
    be vertically symmetric with respect to the display rect.
    
    This CL only turns on this flag for the OmniboxViewViews.
    
    Bug: 249065
    Change-Id: I031017335a0efb5e8842d137fc55efce5520e6cd
    Reviewed-on: https://chromium-review.googlesource.com/1140901
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575887}

    Changed files

    • chrome/browser/ui/views/omnibox/omnibox_view_views.cc
    • ui/gfx/render_text.cc
    • ui/gfx/render_text.h
    • ui/gfx/render_text_test_api.h
    • ui/gfx/render_text_unittest.cc
  36. Remove unnecessary friend declaration from TaskRunner.

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:58:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee20b5a2bbe3268c155f7816db8e5498cae4458b

    Comments

    Remove unnecessary friend declaration from TaskRunner.
    
    Bug: 112250
    Change-Id: I63369b826307acea4b01f15fbc4cbef2f41514a1
    Reviewed-on: https://chromium-review.googlesource.com/1137925
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575884}

    Changed files

    • base/task_runner.h
  37. Create an enterprise policy control for tab lifecycles.

    Changed by chrishaohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:00:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8206aadbf43bbd7f314b780134688dc1c72ed60d

    Comments

    Create an enterprise policy control for tab lifecycles.
    
    This will allow enterprises to opt-out or opt-in to lifecycles
    while the feature is under development.
    
    Change-Id: I68838306ac3d22fab1290f47011dc4d14c909c43
    Reviewed-on: https://chromium-review.googlesource.com/1132299
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Commit-Queue: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575886}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/test/data/policy/policy_test_cases.json
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  38. Wrap some PPAPI GRD entries in an enable_plugins conditional.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 00:58:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49232fb44354ef387f9884e1c6e526471f16a5bc

    Comments

    Wrap some PPAPI GRD entries in an enable_plugins conditional.
    
    Effectively removing them from Android, where there is no PPAPI. Also
    fix an "is_chromeos" typo.
    
    Change-Id: I1395ccf368c1d0f593352d1ae2755fcb5920468a
    Reviewed-on: https://chromium-review.googlesource.com/1140531
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575885}

    Changed files

    • chrome/app/generated_resources.grd
  39. [iOS] Don't generate TableViewURLCell's a11y label if one is provided.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:21:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1a3cceb326c1bf52a126ae393a889ac3dfb8fbcc

    Comments

    [iOS] Don't generate TableViewURLCell's a11y label if one is provided.
    
    Previously, TableViewURLCell always returned a lazily created a11y
    label created using the values of the UILabel subviews, which was
    squashing the custom a11y label provided by TableViewItems.
    
    Bug: 862306
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I7210e683f4dfdcdbf0f2c60ecec3eb2a0683eeec
    Reviewed-on: https://chromium-review.googlesource.com/1136902
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575890}

    Changed files

    • ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm
  40. sql: Stop suppressing size_t-to-int conversion warning.

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:10:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3fcf4a66ff27fe36d6737c23c4338e7fb9f954be

    Comments

    sql: Stop suppressing size_t-to-int conversion warning.
    
    Bug: 167187
    Change-Id: I4d26741ca9b41751ed8dc3b121fc3d6e7bff9d5b
    Reviewed-on: https://chromium-review.googlesource.com/1137916
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575888}

    Changed files

    • sql/BUILD.gn
  41. Re-enable ui::Compositor recycling

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:14:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 67c4590289f178cb4c77f61194afff8bf0cb67a5

    Comments

    Re-enable ui::Compositor recycling
    
    Disabling it didn't fix the crashes.
    
    TBR=lgrey
    
    Bug: 863817
    Change-Id: I6cf6ea476856b2e20cf37cf080c59aeec41119dd
    Reviewed-on: https://chromium-review.googlesource.com/1141330
    Reviewed-by: ccameron <ccameron@chromium.org>
    Commit-Queue: ccameron <ccameron@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575889}

    Changed files

    • ui/views/cocoa/bridged_native_widget.mm
  42. Roll src/third_party/depot_tools e6ddf1942ca0..302bb847d356 (3 commits)

    Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 01:22:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31245ba491f26376881390519950fd553ac71e70

    Comments

    Roll src/third_party/depot_tools e6ddf1942ca0..302bb847d356 (3 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e6ddf1942ca0..302bb847d356
    
    
    git log e6ddf1942ca0..302bb847d356 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 jbudorick@chromium.org gclient: run cipd ensure in paranoid mode.
    2018-07-17 ehmaldonado@chromium.org git_cache: Add tests for reset fetch config.
    2018-07-17 ehmaldonado@chromium.org metrics: Fix countdown to metrics collection.
    
    
    Created wi
    ...skip...
    f necessary.
    
    
    
    BUG=chromium:860251,chromium:862547,chromium:832386
    TBR=agable@chromium.org
    
    Change-Id: I654f3810c18eef26eda782285927c8bef5bfd3d7
    Reviewed-on: https://chromium-review.googlesource.com/1140797
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575891}

    Changed files

    • DEPS
  43. Revert "[Nav Experiment] Skip SSL status update when webview is loading."

    Changed by rohitraoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:31:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d0392dce3a89a951643aec3d15661ca2c014e62

    Comments

    Revert "[Nav Experiment] Skip SSL status update when webview is loading."
    
    This reverts commit 9441c30698153a16fc5c1b8ba6f04acd0854fbed.
    
    Reason for revert: Breaks ExternalURLSSLTestCase/testMixedContentWarning in the downstream tree. 
     https://browsingtest.appspot.com/mixedContent.html does not show a mixed content warning.
    
    Original change's description:
    > [Nav Experiment] Skip SSL status update when webview is loading.
    > 
    > -webViewSecurityFeaturesDidChange is meant to update the SSL status of
    > th
    ...skip...
    /master@{#575803}
    
    TBR=kkhorimoto@chromium.org,danyao@chromium.org
    
    Change-Id: Ia764eeca4fcb26cc3cf9cd8778fe4cedb5e98c3f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 842151
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1141384
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575896}

    Changed files

    • ios/web/web_state/ui/crw_web_controller.mm
  44. WebUI: paper-input clean-ups.

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:23:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e3105ebb1b5c63e6b6aaf765be337ba35278a34f

    Comments

    WebUI: paper-input clean-ups.
    
    This CL cleans up some remnant of paper-input, now that paper-input is
    mostly removed.
    
    Bug: 720276
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id17298df731d1fbfc111fdb6db40202e1036dd4a
    Reviewed-on: https://chromium-review.googlesource.com/1139086
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575892}

    Changed files

    • chrome/test/data/webui/settings/a11y/edit_dictionary_a11y_test.js
    • chrome/test/data/webui/settings/a11y/manage_profile_a11y_test.js
    • ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
    • ui/webui/resources/cr_elements/paper_input_style_css.html
    • ui/webui/resources/cr_elements/shared_style_css.html
    • ui/webui/resources/cr_elements_resources.grdp
  45. Roll src-internal 718bcd15ec60..664261cb3f4d (1 commits)

    Changed by src-internal-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 01:24:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4a5e6b27557cd4f76033e7364b2acd24147fdbd

    Comments

    Roll src-internal 718bcd15ec60..664261cb3f4d (1 commits)
    
    https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/718bcd15ec60..664261cb3f4d
    
    
    Created with:
      gclient setdep -r src-internal@664261cb3f4d
    
    The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:853946
    TBR=mmoss@chromium.org
    
    Change-Id: Ic50448d8ff622c644d4ab673deb2629034e63a51
    Reviewed-on: https://chromium-review.googlesource.com/1140621
    Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575893}

    Changed files

    • DEPS
  46. Reporting: Payload field should be `body`, not `report`

    Changed by dcreagerohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:25:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 048081e45f7508eeaeea40a756ee083b08dd7f8f

    Comments

    Reporting: Payload field should be `body`, not `report`
    
    Per https://w3c.github.io/reporting/#try-delivery, the field in a
    JavaScript report object that contains the body is called `body`, not
    `report`.
    
    Bug: 704259
    Change-Id: Iba3186a0104c2192ced5e4233d55e042e05908f3
    Reviewed-on: https://chromium-review.googlesource.com/1140193
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Commit-Queue: Douglas Creager <dcreager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575894}

    Changed files

    • chrome/browser/net/reporting_browsertest.cc
    • net/network_error_logging/network_error_logging_end_to_end_test.cc
    • net/reporting/reporting_delivery_agent.cc
    • net/reporting/reporting_delivery_agent_unittest.cc
    • third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/checkReport.sub.js
  47. [Extensions Build] Extract chrome api sources to a gni file

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:30:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07997f743db03de4d72fcd2e920149584291eb73

    Comments

    [Extensions Build] Extract chrome api sources to a gni file
    
    Extract chrome api sources from chrome/common/extensions/api/BUILD.gn
    to a separate gni file at chrome/common/extensions/api/api_soruces.
    This allows us to pull the api registration step of generation out
    from chrome/common and into chrome/browser. This is helpful, since it
    is a purely-browser dependency (and has browser dependencies itself).
    
    Also make this step a public dependency of chrome/browser/extensions so
    embedders do not need to explicitly depend on it themselves.
    
    Bug: None
    
    Change-Id: I6f2f973a5ba1c04b01aa36b096de847b73964148
    Reviewed-on: https://chromium-review.googlesource.com/1139394
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575895}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/chromeos/BUILD.gn
    • chrome/browser/extensions/BUILD.gn
    • chrome/browser/extensions/api/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/common/extensions/api/BUILD.gn
    • chrome/common/extensions/api/api_sources.gni
  48. Updating WATCHLISTS for loyso@.

    Changed by dominicknohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:41:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd2f011e2a1efcd6d01feb7a05a9058421d18621

    Comments

    Updating WATCHLISTS for loyso@.
    
    BUG=None
    
    Change-Id: Ida08d49ff1a8b642ce8004fd3ac5d5c931810079
    Reviewed-on: https://chromium-review.googlesource.com/1140343
    Reviewed-by: Alexey Baskakov <loyso@chromium.org>
    Commit-Queue: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575898}

    Changed files

    • WATCHLISTS
  49. [EoC] Fix texture capture for experimental button

    Changed by twellingtonohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:40:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c6fd8598d1ca990362c9f4b8a936171e0639b154

    Comments

    [EoC] Fix texture capture for experimental button
    
    Wait to request a texture capture until a layout pass, ensuring that the
    toolbar buttons container has the proper width.
    
    BUG=863819
    
    Change-Id: I52b6288c1970ed16427e0231c092af13a228e9bc
    Reviewed-on: https://chromium-review.googlesource.com/1141172
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575897}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
  50. [iOS] Use ChromeTableView empty view API for Reading List.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:42:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c80a18643feb6b6d2ed988fd1ae4368c594862fc

    Comments

    [iOS] Use ChromeTableView empty view API for Reading List.
    
    Bug: 851962
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I355a361c16f679b39a0b6bec5a68df0e89248ed5
    Reviewed-on: https://chromium-review.googlesource.com/1136012
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Reviewed-by: Sergio Collazos <sczs@chromium.org>
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575899}

    Changed files

    • ios/chrome/browser/ui/reading_list/BUILD.gn
    • ios/chrome/browser/ui/reading_list/reading_list_egtest.mm
    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
    • ios/chrome/browser/ui/table_view/table_view_empty_view.h
    • ios/chrome/browser/ui/table_view/table_view_empty_view.mm
  51. Implement DialogPlate motion spec (part 2).

    Changed by dmblackohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 01:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0135e49623ddf6cff6498edb20e2172c8b33ee7e

    Comments

    Implement DialogPlate motion spec (part 2).
    
    This builds off of DialogPlate motion spec part 1:
    https://chromium-review.googlesource.com/c/chromium/src/+/1137843
    
    This CL:
    - Fixes issue which caused settings to fade in/out. Previously we used
      two settings buttons, now we use a single button which exists outside
      of the layout containers being animated.
    - Implements translation phase of the animation.
    
    See bug for spec/demo.
    
    Bug: b:111500701
    Change-Id: I269666dafa815018e0cf65df299aa734eaf80b79
    Reviewed-on: https://chromium-review.googlesource.com/1139031
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575901}

    Changed files

    • ash/assistant/ui/dialog_plate/dialog_plate.cc
    • ash/assistant/ui/dialog_plate/dialog_plate.h
    • ash/assistant/util/animation_util.cc
    • ash/assistant/util/animation_util.h
  52. S13n: Port ChromeOmniboxNavigationObserver to SimpleURLLoader

    Changed by morlovichohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 01:46:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d823592858bb25d894822d14c1db6a8e2ed06d2c

    Comments

    S13n: Port ChromeOmniboxNavigationObserver to SimpleURLLoader
    
    URLFetcher will stop working with advent of Network Service, and
    SimpleURLLoader is the replacement API for most clients.
    
    
    Bug: 840378
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ie318335f2d3a21cac1042862fd6a49e62cc931a4
    Reviewed-on: https://chromium-review.googlesource.com/1124771
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575900}

    Changed files

    • chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc
    • chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.h
    • chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer_unittest.cc
    • services/network/test/test_url_loader_factory.cc
    • services/network/test/test_url_loader_factory.h
    • services/network/test/test_url_loader_factory_unittest.cc
  53. Import wpt@f13fe780ed8d665a407aeb5cb1152b0bd10162bf

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:00:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ae5e727ca43b749f532827e04898db3d30d901c

    Comments

    Import wpt@f13fe780ed8d665a407aeb5cb1152b0bd10162bf
    
    Using wpt-import in Chromium 4c64e7377c7747a76d9d69f3ac67da3f781f737f.
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21503
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    TBR=foolip
    
    No-Export: true
    Change-Id: Id62f43a405a6d6f3a9a331b8cff94b7ab94c6d0d
    Reviewed-on: https://chromium-review.googlesource.com/1141183
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575902}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/css/css-animations/support/testcommon.js
  54. [ios] Roll Xcode 10 from beta 3 to beta 4.

    Changed by justincohenohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 02:02:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b8cf623f1a5b9d9c047675aed7e937203e422af

    Comments

    [ios] Roll Xcode 10 from beta 3 to beta 4.
    
    CIPD packages:
      infra_internal/ios/xcode/mac  10l213o
      infra_internal/ios/xcode/ios  10l213o
    
    TBR: hinoka@chromium.org
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I66bf9c3544bee0d3d67634b17fdbcf49a92058ac
    Reviewed-on: https://chromium-review.googlesource.com/1140836
    Commit-Queue: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575904}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • ios/build/bots/chromium.fyi/ios12-beta-simulator.json
    • ios/build/bots/chromium.fyi/ios12-sdk-device.json
    • ios/build/bots/chromium.fyi/ios12-sdk-simulator.json
    • ios/build/bots/chromium.fyi/ios12-sdk-xcode-clang.json
    • ios/build/bots/chromium.mac/ios12-sdk-simulator.json
  55. Check for GmsCore v19 prior to using the Fido2 APIs.

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:01:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31f6142cf232f5da83c1f2661558257b723e655f

    Comments

    Check for GmsCore v19 prior to using the Fido2 APIs.
    
    Bug: 678885
    Change-Id: I7d9f7d7776171f702bf1d79b4ad0e740c68511b8
    Reviewed-on: https://chromium-review.googlesource.com/1139577
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575903}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/webauth/AuthenticatorImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/webauth/Fido2ApiHandler.java
  56. [omnibox] GM2 styling for entities plus improvements to answers logic.

    Changed by orinjohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:06:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59db2de675cb0bd93e784b691265082a5da52db0

    Comments

    [omnibox] GM2 styling for entities plus improvements to answers logic.
    
    This CL addresses a performance concern with the way a font list was
    being derived with size delta, applies minor style changes to entity
    suggestions, and simplifies the logic for presenting styled answers.
    Now answers and entities will always be styled to spec, regardless of
    the flag determining whether to reverse content/descriptions fields.
    
    Change-Id: Idb604f655ccbdcffdbe08e99c7d8c1462c636d18
    Reviewed-on: https://chromium-review.googlesource.com/1140620
    Commit-Queue: Orin Jaworski <orinj@chromium.org>
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575905}

    Changed files

    • chrome/browser/ui/views/omnibox/omnibox_result_view.cc
    • chrome/browser/ui/views/omnibox/omnibox_text_view.cc
  57. Move KillRing to core/editing

    Changed by dgozmanohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:06:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7be733510cdf0d77c65b21e46349191652fa5e3

    Comments

    Move KillRing to core/editing
    
    This is a small wrapper around NSKillRing functions,
    solely used by editing code. There is no need to put it
    separately from the rest of editing.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie529f834464a413bd252fcf0a45778ae17b48a61
    Reviewed-on: https://chromium-review.googlesource.com/1140509
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575906}

    Changed files

    • third_party/blink/renderer/core/editing/BUILD.gn
    • third_party/blink/renderer/core/editing/commands/editor_command.cc
    • third_party/blink/renderer/core/editing/editor.cc
    • third_party/blink/renderer/core/editing/kill_ring.h
    • third_party/blink/renderer/core/editing/kill_ring_mac.mm
    • third_party/blink/renderer/core/editing/kill_ring_none.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/mac/DEPS
  58. Prevent a zero-sized browser contents

    Changed by afakhryohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 02:14:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ab66959410437e3d4e4e566ae096d56e9fdb06b

    Comments

    Prevent a zero-sized browser contents
    
    Allowing a browser window to be resized such that
    the contents view's size is 0x0 caused the contents
    view's window to become invisble and stop it from
    being able to accept events.
    
    Instead we use a minimum size of 1x1 for the contents.
    
    BUG=847179
    
    Change-Id: I7790d5e2e4862fce8bb19a5c7d3134b45c6a0c63
    Reviewed-on: https://chromium-review.googlesource.com/1141344
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575907}

    Changed files

    • chrome/browser/ui/views/frame/browser_view_layout.cc
  59. Roll src/third_party/skia 21a99d42c34f..59113645075d (6 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 02:16:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8fd473924839a95b21b31d1d4e2bab5733c3487

    Comments

    Roll src/third_party/skia 21a99d42c34f..59113645075d (6 commits)
    
    https://skia.googlesource.com/skia.git/+log/21a99d42c34f..59113645075d
    
    
    git log 21a99d42c34f..59113645075d --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 ruiqimao@google.com fixed ASAN dm errors
    2018-07-17 ruiqimao@google.com fixed ASAN dm errors
    2018-07-17 herb@google.com MakeAsDrawText for SkTextBlob
    2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
    2018-07-17 brucewang@google.com Implement scaled c
    ...skip...
    rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=bungeman@chromium.org
    
    Change-Id: I613300dc03782aed953fd6114f3fd26c4da7dea0
    Reviewed-on: https://chromium-review.googlesource.com/1141244
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575908}

    Changed files

    • DEPS
  60. Consolidate camera app icons

    Changed by shenghaoohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 02:26:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 677ac15fe1c26a9301e8355aa29c128d6d1c2b16

    Comments

    Consolidate camera app icons
    
    This CL creates a persistent camera icon in launcher. When users click
    on it, whether to open Chrome camera app or Google camera app is
    determined dynamically.
    
    CCA or GCA based on whether consolidation is done and whether ARC is
    enabled.
    
    Bug: 861952
    Test: Tested on eve that there's always one camera icon shown and opens
    Change-Id: I93835bbae6791a7fc712bea07f3f85b1b83d3185
    Reviewed-on: https://chromium-review.googlesource.com/1137054
    Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575910}

    Changed files

    • ash/public/cpp/app_list/internal_app_id_constants.h
    • ash/public/cpp/resources/ash_public_unscaled_resources.grd
    • ash/public/cpp/resources/unscaled_resources/camera_logo_192.png
    • chrome/app/chromeos_strings.grdp
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/arc/arc_app_utils.cc
    • chrome/browser/ui/app_list/extension_app_model_builder.cc
    • chrome/browser/ui/app_list/extension_app_utils.cc
    • chrome/browser/ui/app_list/extension_app_utils.h
    • chrome/browser/ui/app_list/internal_app/internal_app_item.cc
    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
    • chrome/browser/ui/app_list/search/app_search_provider.cc
    • chrome/browser/ui/app_list/search/internal_app_result.cc
    • chrome/browser/ui/app_list/search/tests/app_search_provider_unittest.cc
    • chrome/browser/ui/ash/launcher/launcher_controller_helper.cc
  61. Add tabs to chrome://safe-browsing page

    Changed by druberyohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:16:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 256f47b4cd4dfbdf03a9e9bd4fef88fac32f1517

    Comments

    Add tabs to chrome://safe-browsing page
    
    Just a cosmetic change, because I was tired of scrolling through many
    sections.
    
    Render: https://screenshot.googleplex.com/mgoTZ4qfD0n
    
    Change-Id: Idaf6b98eb9835f3f9cf440f800985da154fefb10
    Reviewed-on: https://chromium-review.googlesource.com/1140528
    Commit-Queue: Daniel Rubery <drubery@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575909}

    Changed files

    • components/safe_browsing/web_ui/resources/safe_browsing.html
    • components/safe_browsing/web_ui/resources/safe_browsing.js
  62. [scheduler] Adding FrameTaskQueueController

    Changed by shaseleyohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 02:33:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f87335e795c6018344578acb40c1da2538d3223b

    Comments

    [scheduler] Adding FrameTaskQueueController
    
    FrameTaskQueueController creates and manages the task queues used by
    FrameSchedulerImpl. It is responsible for tracking the mappings from
    QueueTraits to MainThreadTaskQueues.
    
    This CL adds FrameTaskQueueController and basic task queue management.
    Refactoring FrameSchedulerImpl to use this new class will be added in
    a follow-up CL.
    
    Design Doc:
    https://docs.google.com/document/d/1Jm4xLPqv013VfZswgmnoQ7-ghJK92Uf3hIT7WcNcFck/edit?usp=sharing
    
    Bug: 859963
    Change-Id: Ie9fefaaad83c30f06a13c427e38d54089fc362a4
    Reviewed-on: https://chromium-review.googlesource.com/1132691
    Commit-Queue: Scott Haseley <shaseley@google.com>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575912}

    Changed files

    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller.h
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_task_queue_controller_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
  63. Add an option to XRSessionCreationOptions to specify AR sessions

    Changed by billorrohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:33:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1ff845160e9b667d0c43bc5f4c761d46d12fd9bb

    Comments

    Add an option to XRSessionCreationOptions to specify AR sessions
    
    environmentIntegration is the new flag, which is now queried when
    requesting sessions.  Plumbing to the browser process will happen in
    a followup.
    
    Now that both AR and VR can be supported simultaneously in tests,
    WebXRHitTest is made experimental and the ar_hittest layout test passes.
    
    BUG=828321
    
    Change-Id: I4d8f13cc7c836c608d1f4d69d07813d163cea18f
    Reviewed-on: https://chromium-review.googlesource.com/1132427
    Commit-Queue: Bill Orr <billorr@chromium.org>
    Reviewed-by: David Dorwin <ddorwin@chromium.org>
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575911}

    Changed files

    • chrome/test/data/xr/e2e_test_files/resources/webxr_boilerplate.js
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/WebKit/LayoutTests/xr/ar_hittest-expected.txt
    • third_party/WebKit/LayoutTests/xr/xrDevice_requestSession_exclusive_unsupported.html
    • third_party/blink/renderer/modules/xr/xr_device.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h
    • third_party/blink/renderer/modules/xr/xr_session_creation_options.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  64. MacViews: implement description for AXPlatformNodeCocoa

    Changed by lgreyohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:34:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 53104fb13b131974c1e95c8eda2cb865df841916

    Comments

    MacViews: implement description for AXPlatformNodeCocoa
    
    I add this every time I'm debugging an a11y issue, let's save me and
    everyone else some time :)
    
    Change-Id: I12ee9d4bfb320f5da067d63f038d1f4d393975ce
    Reviewed-on: https://chromium-review.googlesource.com/1131572
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575913}

    Changed files

    • ui/accessibility/platform/ax_platform_node_mac.mm
  65. Rename the load flag LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR to LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR.

    Changed by zhongyiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:41:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb28b1fecc57d07994d4d46d615de39e76267a1e

    Comments

    Rename the load flag LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR to LOAD_DISABLE_CONNECTION_MIGRATION_TO_CELLULAR.
    
    This CL does not change the behavior of the flag, it merely renames the flag to reflect the semantics we would like it to have. A subsequent CL will make the behavior changes.
    
    Bug: 769526
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I6261e60fb44661a9b3de944e8f87bd660caeb761
    Reviewed-on: https://chromium-review.googlesource.com/1136972
    Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
    Reviewed-by: Ryan Hamilton <rch@chromium.org>
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575914}

    Changed files

    • components/cronet/android/test/cronet_url_request_test.cc
    • components/cronet/cronet_url_request.cc
    • net/base/load_flags_list.h
    • net/quic/chromium/quic_chromium_client_session.cc
    • net/quic/chromium/quic_chromium_client_stream.cc
    • net/quic/chromium/quic_chromium_client_stream.h
    • net/quic/chromium/quic_http_stream.cc
    • net/quic/chromium/quic_http_stream_test.cc
    • net/quic/chromium/quic_stream_factory_test.cc
  66. [omnibox] Lighten dimmed URL text in Refresh to GG600 per spec

    Changed by orinjohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:48:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f199c019577fb8fc1f39edc0254ff3886481a30

    Comments

    [omnibox] Lighten dimmed URL text in Refresh to GG600 per spec
    
    The URL path, parameters, etc. (LOCATION_BAR_TEXT_DIMMED)
    were being lightened to GG700 but now get GG600 per spec.
    The RESULTS_ICON and RESULTS_TEXT_DIMMED using the same
    colors remain intact.
    
    Bug: 863474
    Change-Id: I1dc2efb763642d88cbc27d832b0411a10c3310c8
    Reviewed-on: https://chromium-review.googlesource.com/1141294
    Commit-Queue: Orin Jaworski <orinj@chromium.org>
    Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575916}

    Changed files

    • chrome/browser/ui/omnibox/omnibox_theme.cc
  67. Reorder SSLPrivateKey hash preferences.

    Changed by davidbenohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 02:47:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a1d878b99f25c6855099bef483e939264ba7b6f

    Comments

    Reorder SSLPrivateKey hash preferences.
    
    Prefer signing smaller SHA-2 hashes over larger ones. This aligns with
    BoringSSL's current defaults. In particular, we got a report of problems
    with TPM-protected client certificates on Windows that cannot sign
    SHA-512. Absent a way to reliably query hash preferences, SHA-256 is
    more likely to be compatible.
    
    Bug: 863147
    Change-Id: Icaef85a2639ba3cc95846ff932bd829226e7aa7b
    Reviewed-on: https://chromium-review.googlesource.com/1135299
    Reviewed-by: Steven Valdez <svaldez@chromium.org>
    Commit-Queue: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575915}

    Changed files

    • net/ssl/ssl_platform_key_win.cc
    • net/ssl/ssl_platform_key_win_unittest.cc
    • net/ssl/ssl_private_key.cc
  68. [Closure Compiler GN] Enable checks_only flag for type checking compilations.

    Changed by calamityohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:02:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c75667497914dbdc0df8fb05fc15d230e2f6385c

    Comments

    [Closure Compiler GN] Enable checks_only flag for type checking compilations.
    
    This CL adds the checks_only flag to JS Closure Compilations that are only
    doing type checking to improve build time.
    
    Before:
    5869.41s user 189.50s system 3350% cpu
    5861.34s user 190.37s system 3284% cpu
    
    After:
    4143.98s user 159.46s system 3020% cpu
    4184.40s user 158.95s system 3073% cpu
    
    Bug: 632206
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I68ebdce5a4cf98176d3f55b971e33fc62848d2d4
    Reviewed-on: https://chromium-review.googlesource.com/1139840
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575918}

    Changed files

    • third_party/closure_compiler/compile_js.gni
    • third_party/closure_compiler/js_binary.py
  69. Roll src/third_party/pdfium d563855ac72b..8e0c0dbc4876 (2 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 02:48:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9eba4d434eb6694ed1d0f9535b9fa93fc353b79c

    Comments

    Roll src/third_party/pdfium d563855ac72b..8e0c0dbc4876 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/d563855ac72b..8e0c0dbc4876
    
    
    git log d563855ac72b..8e0c0dbc4876 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 asweintraub@google.com Add Deleter and Scoper for FPDF_PAGELINK.
    2018-07-17 hnakashima@chromium.org Limit recursion depth for CXFA_DocumentParser::NormalLoader().
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@8e0c0dbc4876
    
    The AutoRoll server is located h
    ...skip...
    should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:849143
    TBR=dsinclair@chromium.org
    
    Change-Id: I690589dba2241ff7f211a6c753a0ed74c57bd0a3
    Reviewed-on: https://chromium-review.googlesource.com/1140539
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575917}

    Changed files

    • DEPS
  70. [Background Fetch] Support layout tests for the feature

    Changed by peterohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:04:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 289443f134cc33ac12645667e7aa9b303e7a96d9

    Comments

    [Background Fetch] Support layout tests for the feature
    
    An implementation of BackgroundFetchDelegate has been provided to
    content shell which enables Background Fetches, without UI, to finish.
    It uses the Download Service through a new dependency. This dependency
    will be removed once the Download Service has been servicified, as
    //content can depend on it directly from that point forward.
    
    In context of the WPT tests, additional machinery has been added to
    enable communication with the Service Worker, required for it to tell
    the test about the result of the various Background Fetch events. The
    "fetch.https.window.js" file now verifies the behaviour and results
    of a single fetched file.
    
    Bug: 864561
    
    Change-Id: If53e6755ae8ea924712f5bdace4df4f658bc53d7
    Reviewed-on: https://chromium-review.googlesource.com/1135536
    Commit-Queue: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575919}

    Changed files

    • chrome/browser/background_fetch/background_fetch_delegate_impl.cc
    • components/download/internal/background_service/in_memory_download.cc
    • components/download/internal/background_service/in_memory_download.h
    • components/download/internal/background_service/in_memory_download_driver.cc
    • components/download/internal/background_service/in_memory_download_driver_unittest.cc
    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/background_fetch_delegate_proxy_unittest.cc
    • content/browser/background_fetch/background_fetch_request_info.cc
    • content/browser/background_fetch/background_fetch_request_info.h
    • content/browser/background_fetch/mock_background_fetch_delegate.cc
    • content/browser/background_fetch/storage/mark_request_complete_task.cc
    • content/public/browser/background_fetch_response.cc
    • content/public/browser/background_fetch_response.h
    • content/shell/BUILD.gn
    • content/shell/DEPS
    • content/shell/browser/layout_test/layout_test_background_fetch_delegate.cc
    • content/shell/browser/layout_test/layout_test_background_fetch_delegate.h
    • content/shell/browser/layout_test/layout_test_browser_context.cc
    • content/shell/browser/layout_test/layout_test_browser_context.h
    • third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
    • third_party/WebKit/LayoutTests/external/wpt/background-fetch/get-ids.https.js
    • third_party/WebKit/LayoutTests/external/wpt/background-fetch/resources/feature-name.txt
    • third_party/WebKit/LayoutTests/external/wpt/background-fetch/resources/sw.js
    • third_party/WebKit/LayoutTests/external/wpt/background-fetch/resources/utils.js
  71. AppCache: Cleanup unused member |ui_handle_|.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:04:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 770507fda0a1e7ccd94d0f13d8318bdb59d86be2

    Comments

    AppCache: Cleanup unused member |ui_handle_|.
    
    It wasn't used since inception in commit 292a917258e6.
    
    Change-Id: Ib64e6f70a1779a6710dfcabb989089f3f598d8a7
    Reviewed-on: https://chromium-review.googlesource.com/1126180
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575920}

    Changed files

    • content/browser/appcache/appcache_navigation_handle.cc
    • content/browser/appcache/appcache_navigation_handle_core.cc
    • content/browser/appcache/appcache_navigation_handle_core.h
  72. Mini-patch modified GetPatternProvider to cast to provider interface

    Changed by suproteemohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:07:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3ffbf436c8c5b638610c73d9bcfd4a38f6f7fc60

    Comments

    Mini-patch modified GetPatternProvider to cast to provider interface
    
    R=nektar@chromium.org,dmazzoni@chromium.org
    
    Bug: 847971
    Change-Id: Id18111cedd06a6c5964682e114de03fc9c0d9567
    Reviewed-on: https://chromium-review.googlesource.com/1130161
    Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575921}

    Changed files

    • ui/accessibility/platform/ax_platform_node_win.cc
  73. Fix hosted app window minimum widths in RTL UI mode

    Changed by alancutterohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:16:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d2c822c6ebbb9cd52097025b54b48ac4efabe15

    Comments

    Fix hosted app window minimum widths in RTL UI mode
    
    This CL moves RTL mirroring logic out of FrameHeader::GetTitleBounds() and
    closer to where it's necessary. This fixes uses of GetTitleBounds() that
    shouldn't use mirrored coordinates.
    
    Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347205&signed_aid=BHR4RQzcQgoqMRZiktSbrA==&inline=1
    After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=347206&signed_aid=_yNGcCCrQWXCWUB5bjJwSQ==&inline=1
    
    Bug: 860590
    Change-Id: Ie58194b4cf5e397967bf376d368146f180e7220e
    Reviewed-on: https://chromium-review.googlesource.com/1127212
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575922}

    Changed files

    • ash/frame/default_frame_header_unittest.cc
    • ash/frame/frame_header.cc
    • base/i18n/rtl.cc
    • base/i18n/rtl.h
    • base/i18n/rtl_unittest.cc
  74. Change owners for file_manager_private_custom_bindings.js

    Changed by joelhockeyohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:18:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d22e7aeb525f65faf55dfbb1d700efacfaa9584e

    Comments

    Change owners for file_manager_private_custom_bindings.js
    
    Change-Id: I339695d5f7f2a733c09d5d19a167c7fa2ed02d35
    Reviewed-on: https://chromium-review.googlesource.com/1140344
    Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575924}

    Changed files

    • chrome/renderer/resources/extensions/OWNERS
  75. Reset next_gethash_time_ in ResetGetHashErrors

    Changed by akaluginohnoyoudont@yandex-team.ru
    Changed at Wednesday, 18-Jul-18 03:42:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d28efea28fdebcf98da6a7af4f4667ebb21927de

    Comments

    Reset next_gethash_time_ in ResetGetHashErrors
    
    If two parallel gethash requests are running and the first fails but the
    second succeeds, then gethash error counters are reset and
    next_gethash_time_ is not. In this case all following GetFullHashes
    calls (until time is out) does not incur actual network requests and
    gethash result is improperly reported as MIN_WAIT_DURATION_ERROR, even
    though server did not sent min_wait_duration to the client.
    
    Example steps (implemented in unit test):
    - Initiate two 
    ...skip...
    es method.
    Expected result:
    - As long as the second request was successful, the following requests
      are run as usual.
    Actual Result:
    - Network request is not issued.
    - MIN_WAIT_DURATION_ERROR is reported to SafeBrowsing.V4GetHash.Result
    
    Change-Id: Ieeb08046515f87239ec00d9ad13b80c257b59435
    Reviewed-on: https://chromium-review.googlesource.com/1119908
    Commit-Queue: Alexander Kalugin <akalugin@yandex-team.ru>
    Reviewed-by: Varun Khaneja <vakh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575928}

    Changed files

    • components/safe_browsing/db/v4_get_hash_protocol_manager.cc
    • components/safe_browsing/db/v4_get_hash_protocol_manager.h
    • components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc
  76. Reserve 10 resource IDs for chrome/browser/browser_resources.grd

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:27:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 379bb89de39f7ed95a8f4ea2c63ee1112bf69722

    Comments

    Reserve 10 resource IDs for chrome/browser/browser_resources.grd
    
    These will be used in https://chromium-review.googlesource.com/c/chromium/src/+/1139108.
    
    Bug: 851293
    Change-Id: I246bae76d785bea6426bbe6a170272cebcdcc079
    Reviewed-on: https://chromium-review.googlesource.com/1141120
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575926}

    Changed files

    • tools/gritsettings/resource_ids
  77. Roll src/third_party/angle 252ec9191125..e2c00841a55f (2 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 03:20:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f7fe5a04631c46dce960e519955dc75072043aa

    Comments

    Roll src/third_party/angle 252ec9191125..e2c00841a55f (2 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/252ec9191125..e2c00841a55f
    
    
    git log 252ec9191125..e2c00841a55f --date=short --no-merges --format='%ad %ae %s'
    2018-07-18 yizhou.jiang@intel.com GenerateMipmaps should generate INVALID_OPERATION in ES 2.0 with EXT_sRGB
    2018-07-17 geofflang@chromium.org Vulkan: Expose an unimplemented EGL_ANGLE_robust_resource_initialization.
    
    
    Created with:
      gclient setdep -r src/third_party/angle
    ...skip...
    ;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=cwallez@chromium.org
    
    Change-Id: Ia51bf51d1d14bcdef45081568b482b499bb1b93f
    Reviewed-on: https://chromium-review.googlesource.com/1141139
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575925}

    Changed files

    • DEPS
  78. Dynamically change ChromeVox toggle help string

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:35:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 562a9c111ffc3b1e7a26cd3a3ac16449fdb7fe9d

    Comments

    Dynamically change ChromeVox toggle help string
    
    Bug: 863093
    Change-Id: I3307df10ca8c438c3683418f3e50c9e4859918bd
    Reviewed-on: https://chromium-review.googlesource.com/1136530
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575927}

    Changed files

    • ash/accessibility/accessibility_controller.cc
    • ash/accessibility/accessibility_controller.h
    • ash/shell.cc
    • ui/message_center/views/message_popup_collection.cc
  79. Roll src/third_party/chromite 82b059ecb6a4..1b00ba716473 (1 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 03:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a9d09e563df548cea6a3ad93a7c4f293a8f7633

    Comments

    Roll src/third_party/chromite 82b059ecb6a4..1b00ba716473 (1 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/82b059ecb6a4..1b00ba716473
    
    
    git log 82b059ecb6a4..1b00ba716473 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 dgarrett@google.com chrome_committer: Select service account per builder.
    
    
    Created with:
      gclient setdep -r src/third_party/chromite@1b00ba716473
    
    The AutoRoll server is located here: https://chromite-chromium-roll.skia.org
    
    Documentation for the Au
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: If19ec61c67987901f6ba8917e64fd971c4d0c128
    Reviewed-on: https://chromium-review.googlesource.com/1141137
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575929}

    Changed files

    • DEPS
  80. Reland "Forms: Add a UseCounter for opening popups while a file chooser is opening"

    Changed by tkentohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 03:17:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6bfe210aa3c20ebf1db6ce788991f24e1eace4c7

    Comments

    Reland "Forms: Add a UseCounter for opening popups while a file chooser is opening"
    
    We'd like to fix a confusing UI issue, and to know the impact
    of a possible fix.
    
    This relands #575575, which caused node leaks.
    If a document is navigated out while a file chooser is opening,
    ChromeClientImpl holded a strong reference to a FileInputType and the
    whole document leaked.
    This CL changes the reference from strong one to weak one.
    
    Bug: 637639
    Change-Id: I5dccade80e433ac53de4bb205abab58380b0a5f2
    Reviewed-on: https://chromium-review.googlesource.com/1140339
    Reviewed-by: Keishi Hattori <keishi@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575923}

    Changed files

    • third_party/blink/public/platform/web_feature.mojom
    • third_party/blink/renderer/core/html/forms/file_chooser.cc
    • third_party/blink/renderer/core/html/forms/file_chooser.h
    • third_party/blink/renderer/core/html/forms/file_input_type.cc
    • third_party/blink/renderer/core/html/forms/file_input_type.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl.h
    • tools/metrics/histograms/enums.xml
  81. Update V8 to version 6.9.426.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 03:52:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21289d5be9936171c5ed5d8a0c8e7ed361f971f1

    Comments

    Update V8 to version 6.9.426.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/3df683e6..65ea3e26
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tes
    ...skip...
    tional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Ib0d8e2febefd2f3b42417184c8304859fc87bdb2
    Reviewed-on: https://chromium-review.googlesource.com/1141089
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575930}

    Changed files

    • DEPS
  82. WebUI: update non-DICE and win10 welcome pages

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:06:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6e554116a126faf75deb318dddb77feedadc9e3

    Comments

    WebUI: update non-DICE and win10 welcome pages
    
    This CL changes the non-DICE welcome page to a custom element in order
    to reuse paper-button-style.
    
    This CL also updates the win10 welcome page's paper-button to use
    paper-button-style.
    
    Bug: 860274
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8678e89fb99fda64c0e5f1f54b53f2edeb14e3a9
    Reviewed-on: https://chromium-review.googlesource.com/1138984
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575934}

    Changed files

    • chrome/browser/resources/welcome/dice_welcome/welcome_app.html
    • chrome/browser/resources/welcome/welcome.css
    • chrome/browser/resources/welcome/welcome.html
    • chrome/browser/resources/welcome/welcome.js
    • chrome/browser/resources/welcome/welcome_win10.html
  83. Fix the set_render_frame_proxy_created() bookkeeping in SwapOut.

    Changed by alexmosohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:07:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bbdadd3e82183dd8307929084d16060b8938f98

    Comments

    Fix the set_render_frame_proxy_created() bookkeeping in SwapOut.
    
    While investigating issue 794625, I noticed that it is possible for
    RFHI::SwapOut to not actually create the proxy.  This happens if (1)
    the RFHI to be swapped out is already pending deletion, and (2) the
    RFHI to be swapped out is not live.  Nonetheless, the sole caller of
    RFHI::SwapOut, RenderFrameHostManager::SwapOutOldFrame, assumes that a
    replacement proxy is always created and unconditionally calls
    proxy->set_render_frame_proxy_cre
    ...skip...
     expect the problem to be that we send a message to
    create a proxy to a process where the proxy had already been created,
    and here, the resulting problems would be from a proxy being marked
    as live without actually having been created.
    
    Bug: 794625
    Change-Id: I7e3f53c17b541f9d5796714ef7c530a7955cf143
    Reviewed-on: https://chromium-review.googlesource.com/1139215
    Commit-Queue: Charlie Reis <creis@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575935}

    Changed files

    • content/browser/frame_host/render_frame_host_impl.cc
    • content/browser/frame_host/render_frame_host_manager.cc
  84. Roll src/third_party/webrtc dbdb3a00797d..0f5400acfa40 (1 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 03:57:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a2a294615f4b8dc67720cd273d716df1d322ece

    Comments

    Roll src/third_party/webrtc dbdb3a00797d..0f5400acfa40 (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/dbdb3a00797d..0f5400acfa40
    
    
    git log dbdb3a00797d..0f5400acfa40 --date=short --no-merges --format='%ad %ae %s'
    2018-07-17 steveanton@webrtc.org [Unified Plan] Implement FiredDirection for RtpTransceiver
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@0f5400acfa40
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    ...skip...
    rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I95a9d62e1d8b54f20f47d3a75ea619c5cc79d16f
    Reviewed-on: https://chromium-review.googlesource.com/1140623
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575932}

    Changed files

    • DEPS
  85. Roll src/third_party/libvpx/source/libvpx/ 829d1b209..2c45cd174 (17 commits)

    Changed by jianjohnoyoudont@google.com
    Changed at Wednesday, 18-Jul-18 04:13:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 814121a78a064c80d1925e3f639d449906c1b719

    Comments

    Roll src/third_party/libvpx/source/libvpx/ 829d1b209..2c45cd174 (17 commits)
    
    https://chromium.googlesource.com/webm/libvpx.git/+log/829d1b2098b5..2c45cd174a95
    
    $ git log 829d1b209..2c45cd174 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 marpan vp9: Force hybrid_intra on scene change
    2018-07-15 jingning Account for quantization effect in the tpl model
    2018-07-16 jingning Assign estimate qp for overlay frame
    2018-07-16 johannkoenig Revert "Enable tpl model for speed 0"
    2018-07-13 jingning U
    ...skip...
    ing Relax multiplier adjustment limit
    2018-07-06 jingning Change the tpl model operating block size to 32x32
    2018-07-06 paulwilkins Delete invalid assert.
    
    Created with:
      roll-dep src/third_party/libvpx/source/libvpx
    R=johannkoenig@google.com
    
    Change-Id: I2c82f58f662c09c00139f5bd62f13888a94c7956
    Reviewed-on: https://chromium-review.googlesource.com/1140786
    Reviewed-by: Johann Koenig <johannkoenig@google.com>
    Commit-Queue: Jerome Jiang <jianj@google.com>
    Cr-Commit-Position: refs/heads/master@{#575936}

    Changed files

    • DEPS
    • third_party/libvpx/README.chromium
    • third_party/libvpx/source/config/ios/arm-neon/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/ios/arm64/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/arm-neon-cpu-detect/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/arm-neon/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/arm/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/arm64/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/generic/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/ia32/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/mips64el/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/mipsel/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/linux/x64/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/mac/ia32/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/mac/x64/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/nacl/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/vpx_version.h
    • third_party/libvpx/source/config/win/ia32/vpx_dsp_rtcd.h
    • third_party/libvpx/source/config/win/x64/vpx_dsp_rtcd.h
  86. [SessionStorageS13N] Added padding for corruption checks

    Changed by dmurphohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:04:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 366cfcc3c7f81c0640ce7a075d37e03d147fb70a

    Comments

    [SessionStorageS13N] Added padding for corruption checks
    
    R=pwnall@chromium.org
    
    Bug: 857464
    Change-Id: I7f9206e1ac75c905ae35c44e44edfca0e8b82e0f
    Reviewed-on: https://chromium-review.googlesource.com/1140518
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575933}

    Changed files

    • content/renderer/dom_storage/local_storage_cached_areas.cc
    • content/renderer/dom_storage/local_storage_cached_areas.h
  87. Set "application/octet-stream" content type for empty <input type=file>

    Changed by eui-sang.limohnoyoudont@samsung.com
    Changed at Wednesday, 18-Jul-18 03:57:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5b7648dcf47af986f69d54b9a6011f51a8092020

    Comments

    Set "application/octet-stream" content type for empty <input type=file>
    
    Empty <input type=file> is represented incorrectly in FormData.
    If there are no selected files, then append an entry to entry
    list with name and a new File object with an empty name,
    application/octet-stream as type, and an empty body [1].
    
    [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#constructing-form-data-set
    
    Bug: 840714
    Change-Id: Ifadade1e260e0314664549df2d35f0cd38c76bea
    Reviewed-on: https://chromium-review.googlesource.com/1140236
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Kent Tamura <tkent@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575931}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt
    • third_party/blink/renderer/core/fileapi/file.cc
  88. sql: Replace NULL with nullptr.

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:17:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd62311a9ebf0989daa0135d2f231d0152114c16

    Comments

    sql: Replace NULL with nullptr.
    
    Change-Id: Ie3ad5785f82ccafdbcc630a5a26423ecc0b6c4bc
    Reviewed-on: https://chromium-review.googlesource.com/1137846
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575937}

    Changed files

    • sql/connection.cc
    • sql/connection.h
    • sql/connection_unittest.cc
    • sql/meta_table.cc
    • sql/recovery.cc
    • sql/recovery.h
    • sql/recovery_unittest.cc
    • sql/sqlite_features_unittest.cc
    • sql/statement.cc
    • sql/statement.h
    • sql/test/sql_test_base.cc
    • sql/vfs_wrapper.cc
  89. compositor_will_send_main_frame_not_expected flag should not be set when no PageSchedulers exist

    Changed by keishiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:22:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1033f682f37d7d5a4f5668275656804c7a577f2

    Comments

    compositor_will_send_main_frame_not_expected flag should not be set when no PageSchedulers exist
    
    When we set compositor_will_send_main_frame_not_expected flag when no PageSchedulers exist, MainThreadSchedulerImpl::BeginMainFrameNotExpectedUntil() never gets called. This means that StartIdlePeriod rarely gets called and the idle tasks may not be executed for a long time.
    
    After this CL, compositor_will_send_main_frame_not_expected will not be set when no PageSchedulers exist, so MainThreadSchedulerImpl will try calling RequestBeginMainFrameNotExpected next time.
    
    Bug: 862589
    Change-Id: I06f9c813df6cc7270269d9ffb3a01f24b9c911ce
    Reviewed-on: https://chromium-review.googlesource.com/1134630
    Commit-Queue: Keishi Hattori <keishi@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575938}

    Changed files

    • third_party/blink/renderer/core/page/page.cc
    • third_party/blink/renderer/core/page/page.h
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
    • third_party/blink/renderer/platform/scheduler/public/page_scheduler.h
    • third_party/blink/renderer/platform/scheduler/test/fake_page_scheduler.h
  90. [LayoutNG] Use integer-version of ascent/descent

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:34:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 18490bcb1869ff0218e823fb0445f72ae632752b

    Comments

    [LayoutNG] Use integer-version of ascent/descent
    
    This patch changes ascent and descent from LayoutUnit to
    integer, so that the use is consistent.
    
    In future, we'll want to switch to LayoutUnit, but
    inconsitent use is likely to be a source of problems
    than to help the migration.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I81bb766eaf4579b50bbe1896e48018b3aea81c20
    Reviewed-on: https://chromium-review.googlesource.com/1075909
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575939}

    Changed files

    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/justify-ideograph-vertical-expected.png
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_height_metrics.cc
  91. Updating trunk VERSION from 3495.0 to 3496.0

    Changed by chrome-release-botohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:38:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 984b8a7159b3b6dcd91114156e6538c806267a71

    Comments

    Updating trunk VERSION from 3495.0 to 3496.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I68c759b8cb4d6672e58699454053481adf6c7afd
    Reviewed-on: https://chromium-review.googlesource.com/1141273
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575941}

    Changed files

    • chrome/VERSION
  92. Unified: Fix tab focus of notification controls.

    Changed by tetsuiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:36:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0e9331a295cef18b775c6cff6e14901075b0ed2a

    Comments

    Unified: Fix tab focus of notification controls.
    
    Tab focusing to notification control buttons was broken in
    UnifiedSystemTray because UnifiedMessageCenterView did not implement the
    same OnDidChangeFocus logic as MesageCenterView did.
    
    TEST=manual
    BUG=862506
    
    Change-Id: Ide2d9e170ecefcc87db2d43b6d8d3b1042492374
    Reviewed-on: https://chromium-review.googlesource.com/1132907
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575940}

    Changed files

    • ash/system/unified/unified_message_center_view.cc
    • ash/system/unified/unified_message_center_view.h
    • ash/system/unified/unified_system_tray_bubble.cc
    • ash/system/unified/unified_system_tray_view.cc
    • ash/system/unified/unified_system_tray_view.h
  93. Mark fast/scroll-snap/snaps-after-scrollbar-scrolling.html as flaky/slow

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:59:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 25f229a15bf7d8eb1fca87620d47acd5f1a16002

    Comments

    Mark fast/scroll-snap/snaps-after-scrollbar-scrolling.html as flaky/slow
    
    Bug: 864887
    Change-Id: I9210134ed670cd46026cd6f9d83a6336460ea140
    Tbr: sunyunjia@chromium.org
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1141453
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575945}

    Changed files

    • third_party/WebKit/LayoutTests/SlowTests
    • third_party/WebKit/LayoutTests/TestExpectations
  94. Update team drives grand root visibility when it changes.

    Changed by sammcohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:51:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33b43734e821cb8efaf4f488bbb5e9fee3ea50f4

    Comments

    Update team drives grand root visibility when it changes.
    
    When an onDirectoryChanged event is received for that grand root, rescan
    the grand root and update its visiblity in the UI.
    
    Bug: 854153
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ie36dabdd9348e7c174a22438b29ce8953c81d68e
    Reviewed-on: https://chromium-review.googlesource.com/1136332
    Reviewed-by: Sasha Morrissey <sashab@chromium.org>
    Commit-Queue: Sam McNally <sammc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575943}

    Changed files

    • ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
    • ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
  95. KURL::Port(): Remove unneeded constants

    Changed by riceaohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:44:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41d010e8a4d7622bc4e85f3629ac6a297119c2f3

    Comments

    KURL::Port(): Remove unneeded constants
    
    Remove the constants kMaximumValidPortNumber and kInvalidPortNumber from
    kurl.cc as they are confusing and don't actually do anything.
    
    Also change remaining CHECKs in KURL::Port back to DCHECKs now that we
    have confidence the change is safe.
    
    Also make the method comment less confusing.
    
    BUG=606462
    
    Change-Id: I4719b8611cc6f3f0c5f488d8c86f3b6b8ad6d88f
    Reviewed-on: https://chromium-review.googlesource.com/1127083
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Eric Roman <eroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575942}

    Changed files

    • third_party/blink/renderer/platform/weborigin/kurl.cc
    • third_party/blink/renderer/platform/weborigin/kurl.h
  96. Adjust bubble size in response to screen configuration change.

    Changed by yamaguchiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 04:53:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a36b318a9eb6466ad97d419d23cedddce47dffaf

    Comments

    Adjust bubble size in response to screen configuration change.
    
    As a known issue, this doesn't respond to turning on/off the docked
    magnifier.
    
    Test: manually verified by rotating screen and zooming by ctrl-shift-+.
    Bug: 862575
    Change-Id: I7e74b4ce701c017b77df59cce00a30b0c3ebc821
    Reviewed-on: https://chromium-review.googlesource.com/1134633
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575944}

    Changed files

    • ash/system/unified/unified_system_tray_bubble.cc
    • ash/system/unified/unified_system_tray_bubble.h
  97. Roll src/third_party/pdfium 8e0c0dbc4876..89063ecda876 (2 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 18-Jul-18 05:00:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3257b5ed18d633f589360c30d5c0a35a2fec8d33

    Comments

    Roll src/third_party/pdfium 8e0c0dbc4876..89063ecda876 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/8e0c0dbc4876..89063ecda876
    
    
    git log 8e0c0dbc4876..89063ecda876 --date=short --no-merges --format='%ad %ae %s'
    2018-07-18 thestig@chromium.org Improve image size validation in CPDF_ScaledRenderBuffer.
    2018-07-18 thestig@chromium.org Simplify CPDF_Creator::InitID().
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@89063ecda876
    
    The AutoRoll server is located here: https://pdfium
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I095055060147434724d4269cbac046344fb3e385
    Reviewed-on: https://chromium-review.googlesource.com/1141464
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#575946}

    Changed files

    • DEPS
  98. Mark editing/selection/offset-from-point-complex-scripts.html as failing

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:06:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9eb6d79613895d13dbc1a5ef19544dac2be14c0b

    Comments

    Mark editing/selection/offset-from-point-complex-scripts.html as failing
    
    Bug: 864888
    Change-Id: I2cd98b7c79479f7a5965fdbf9ef2182cb578d5a2
    Tbr: yosin@chromium.org
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1141455
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575947}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  99. Mark virtual/scroll_customization/fast/scroll-behavior/scroll-customization/scroll-customization-property.html as failing

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:17:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 566f19b19be63da7f08ef8a7a3d5e7db96a122d0

    Comments

    Mark virtual/scroll_customization/fast/scroll-behavior/scroll-customization/scroll-customization-property.html as failing
    
    Bug: 864891
    Change-Id: Iff16e5ae02793ffb9d0afb0a806b92ea0ea08b1b
    Tbr: ekaramad@chromium.org
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/1141458
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575950}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  100. Dump layout selection test result as text.

    Changed by yoichioohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:11:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2f71ad5d7578c40decf71aefc3835a2be0062cab

    Comments

    Dump layout selection test result as text.
    
    This patch implements |std::string DumpSelectionInfo()| so that
    we can check a SelectionStatus tree with text diff.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ib42cebfc5a7f1908a4e748f622bbdae9c24987c6
    Reviewed-on: https://chromium-review.googlesource.com/1136335
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
    Commit-Queue: Yoichi Osato <yoichio@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575948}

    Changed files

    • third_party/blink/renderer/core/editing/layout_selection_test.cc
  101. [auto] flag-specific rebaselines for list items

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:13:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8556421f624cf0a01e62a28c21a3689da445e430

    Comments

    [auto] flag-specific rebaselines for list items
    
    This patch rebaselines one text dump differences which is as
    intended, and two 1px line position differences in vertical
    flows. From the manual review of build 8046.
    
    TBR=cathiechen@tencent.com
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4de0239b88bb3f7bf06e829c0f9f5a3e62f20000
    Reviewed-on: https://chromium-review.googlesource.com/1141457
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575949}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/css1/classification/list_style_image-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/lists/001-vertical-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/lists/003-vertical-expected.png
  102. [NTP] Implement add/delete custom links

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:25:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c019977a2dff5ee0282fd221782973bbc3907b05

    Comments

    [NTP] Implement add/delete custom links
    
    Add API to support adding/deleting custom links. Once custom links are
    enabled, MV tiles are "frozen" and converted to custom links.
    
    Design doc: go/chrome-ntp-custom-links
    
    Bug: 856394
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib3255d7253fa9964b6f7845edf5cba4be2fa3db9
    Reviewed-on: https://chromium-review.googlesource.com/1124104
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575952}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/ntp_tiles/chrome_custom_links_manager_factory.cc
    • chrome/browser/ntp_tiles/chrome_custom_links_manager_factory.h
    • chrome/browser/ntp_tiles/chrome_most_visited_sites_factory.cc
    • chrome/browser/prefs/browser_prefs.cc
    • chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
    • components/ntp_tiles/BUILD.gn
    • components/ntp_tiles/constants.cc
    • components/ntp_tiles/custom_links_manager.h
    • components/ntp_tiles/custom_links_manager_impl.cc
    • components/ntp_tiles/custom_links_manager_impl.h
    • components/ntp_tiles/custom_links_manager_impl_unittest.cc
    • components/ntp_tiles/custom_links_store.cc
    • components/ntp_tiles/custom_links_store.h
    • components/ntp_tiles/custom_links_store_unittest.cc
    • components/ntp_tiles/metrics.cc
    • components/ntp_tiles/most_visited_sites.cc
    • components/ntp_tiles/most_visited_sites.h
    • components/ntp_tiles/most_visited_sites_unittest.cc
    • components/ntp_tiles/pref_names.cc
    • components/ntp_tiles/pref_names.h
    • components/ntp_tiles/tile_source.h
    • ios/chrome/browser/ntp_tiles/ios_most_visited_sites_factory.cc
    • ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
    • tools/metrics/histograms/histograms.xml
  103. [JS Mojo Externs] Add support for Constants and Enums.

    Changed by calamityohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:21:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07e1f7463e94bf59c78ed11468ab3aaa24ff7d14

    Comments

    [JS Mojo Externs] Add support for Constants and Enums.
    
    This CL adds support to the Mojo JS Externs generator for Constants and
    Enums so they can be used with the Closure Compiler. It also fixes an
    issue with conflicting modules.
    
    Bug: 864298
    Change-Id: I1d3412ab21b638c16b6aa332165bfff1cee45bb6
    Reviewed-on: https://chromium-review.googlesource.com/1139453
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575951}

    Changed files

    • mojo/public/tools/bindings/generators/js_templates/externs/module.externs.tmpl
  104. Add OWNERS for power/ml

    Changed by jiamengohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:33:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a18d2aab934be0ecc9527d6821e0120456febdf0

    Comments

    Add OWNERS for power/ml
    
    Change-Id: I163da12c827cb4880b561bf4099abdd758d17031
    Reviewed-on: https://chromium-review.googlesource.com/1141456
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Jia Meng <jiameng@chromium.org>
    Commit-Queue: Jia Meng <jiameng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575953}

    Changed files

    • chrome/browser/chromeos/power/ml/OWNERS
  105. [auto] flag-specific rebaselines for space and tabs only differences

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:41:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbbee69d29d7fbf6858327a44d352c7f6090ebec

    Comments

    [auto] flag-specific rebaselines for space and tabs only differences
    
    This patch rebaselines space and tabs only differences from
    the build 8046, as per the test result viewer.
    
    TBR=xiaochengh@chromium.org, yosin@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ic26ffff722dcd3503489199456a0d115e7bf04ae
    Reviewed-on: https://chromium-review.googlesource.com/1141463
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575954}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/css-generated-content-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/accessibility/css-styles-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/inline/inline-offsetLeft-relpos-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/scrolling/scrollable-area-frame-overflow-hidden-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/spatial-navigation/snav-fully-aligned-vertically-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/table/fixed-table-layout/table-with-percent-width-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/svg/as-image/svgview-references-use-counters-expected.txt
  106. Unified: Fix DND and network button behavior.

    Changed by tetsuiohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 06:23:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe7b0602d87ac8abdc06590e02300218197cd916

    Comments

    Unified: Fix DND and network button behavior.
    
    This CL fixes two issues:
    * Fix do-not-disturb button to turn on DND automatically on the label
      click.
    * Fix network button to ignore the icon click when Ethernet is
      connected.
    
    TEST=manual
    BUG=859831,861709
    
    Change-Id: I064db9687084ac21aa9a059b7cd90f740e734d4d
    Reviewed-on: https://chromium-review.googlesource.com/1139849
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575957}

    Changed files

    • ash/system/network/network_feature_pod_controller.cc
    • ash/system/unified/quiet_mode_feature_pod_controller.cc
    • ash/system/unified/unified_system_tray_controller.cc
    • ash/system/unified/unified_system_tray_controller.h
    • ash/system/unified/unified_system_tray_test_api.cc
  107. Rename web_app's launch_type to launch_container

    Changed by nigeltaoohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 06:14:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74a1c955eab8eae19b307f992dc914f63aa5e924

    Comments

    Rename web_app's launch_type to launch_container
    
    Launch_container is more consistent with the existing terminology in
    extensions/common/constants.h
    
    Change-Id: I695f28353b8adc7d13851cd1447bad262619ab47
    Reviewed-on: https://chromium-review.googlesource.com/1141444
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Commit-Queue: Nigel Tao <nigeltao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575956}

    Changed files

    • chrome/browser/web_applications/policy/web_app_policy_constants.cc
    • chrome/browser/web_applications/policy/web_app_policy_constants.h
    • chrome/browser/web_applications/policy/web_app_policy_manager.cc
    • chrome/browser/web_applications/policy/web_app_policy_manager.h
    • chrome/browser/web_applications/policy/web_app_policy_manager_unittest.cc
  108. Reenable SiteEngagementBrowserTest.All for Windows.

    Changed by calamityohnoyoudont@chromium.org
    Changed at Wednesday, 18-Jul-18 05:59:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1961b00b0ac7bd6b490cd47c8834feceb58a083d

    Comments

    Reenable SiteEngagementBrowserTest.All for Windows.
    
    This may have been fixed, re-enabling to gather data.
    
    BUG=734716
    
    Change-Id: If5400ae8e7ee202ba367d6f7fdeb71a1e4798ff7
    Reviewed-on: https://chromium-review.googlesource.com/1140018
    Reviewed-by: Alan Cutter <alancutter@chromium.org>
    Commit-Queue: calamity <calamity@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#575955}

    Changed files

    • chrome/test/data/webui/engagement/site_engagement_browsertest.js