Home | Search
Login

Builder Win 10 High-DPI Perf Build #2320 Microsoft Windows

Results:

Failure

Trigger Info:

Got Revision8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975

Execution:

Steps and Logfiles:

Show:
  1. ( 7 hrs 17 mins ) steps
    running steps via annotated script
  2. ( 16 secs ) update_scripts
    update_scripts
  3. ( 2 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 5 secs ) taskkill
    taskkill
  7. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  9. ( 1 ms ) remove .cipd
    remove .cipd
  10. ( 2 mins 58 secs ) bot_update
    bot_update
    [72GB/349GB used (20%)]
  11. ( 1 ms ) ensure_goma
    ensure_goma
  12. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  14. ( 37 secs ) gclient runhooks
    gclient runhooks
  15. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  16. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: E:\b\c\b\Win_10_High_DPI_Perf\src\testing\buildbot\chromium.perf.json
  17. ( 5 secs ) build directory
    build directory
  18. ( 1 mins 50 secs ) extract build
    extract build
  19. ( 1 ms ) find isolated tests
    find isolated tests
  20. ( 1 ms ) test_pre_run
    test_pre_run
  21. ( 13 secs ) test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    test_pre_run.[trigger] performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
  22. ( 7 hrs 10 mins ) performance_test_suite on Intel GPU on Windows on Windows-10
    performance_test_suite on Intel GPU on Windows on Windows-10
    Run on OS: 'Windows-10'
    Max pending time: 0:33:34.800540 (shard #3)
    Max shard duration: 6:36:45.946820 (shard #4)
    Min shard duration: 5:02:32.458300 (shard #0)
    Total tests: 1032
    * Passed: 965 (965 expected, 0 unexpected)
    * Skipped: 66 (66 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 1 (0 expected, >>>1 unexpected<<<)
     
    Unexpected Flakes:
    * loading.desktop/Kenh14_warm
     
  23. ( 1 ms ) Upload to test-results [performance_test_suite on Intel GPU on Windows]
    Upload to test-results [performance_test_suite on Intel GPU on Windows]
  24. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 5
    Total runtime: 1 day, 4:45:05.215000
     
  25. ( 1 ms ) process_dumps
    process_dumps
  26. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Win_10_High-DPI_Perf/2320/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Win_10_High-DPI_Perf/2320" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "89ef177f94753a91d7ec12aa58a5b06df2c12f0f" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574438}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "ef43aafcf5953845b71840e14c94942d60c541c1" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23896}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"769918ba4b203171a31877aceff5e13a283dd9f4","command_buffer_perftests":"8b28bfb2d41b4994c001ccf1ccfd42c70541cb7f","components_perftests":"4b705f818c83a74bc52241c75b23404cedd35ac0","load_library_perf_tests":"73467ef347b47afeed2271f1a655fcfaccc8f1a3","media_perftests":"70ba4d3ccd415132827dfbaf117ed9162e51d442","performance_test_suite":"804b2cafb2a7a8426f27e8975eee322524f51ce1","views_perftests":"24aca6a9b3dc4a1c69d12e329ea44a493d5c9157"} Annotation(find isolated tests)
build_data_dir "E:\\b\\rr\\tmphdqmoq" Annotation(steps)
build_id "buildbot/chromium.perf/Win 10 High-DPI Perf/2320" Annotation(steps)
builder_id "master.chromium.perf:Win 10 High-DPI Perf" Annotation(steps)
blamelist ["acondor@chromium.org","adokar@google.com","aee@chromium.org","agrieve@chromium.org","akaba@google.com","aleventhal@chromium.org","alexilin@chromium.org","alph@chromium.org","amalova@chromium.org","amaralp@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","anthonyvd@chromium.org","avi@chromium.org","bcf@chromium.org","beccahughes@chromium.org","blink-w3c-test-autoroller@chromium.org","boliu@chromium.org","bsalomon@google.com","bsheedy@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","ccameron@chromium.org","chcunningham@chromium.org","chongjiang@chromium.org","chrisha@chromium.org","chrishtr@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","ckitagawa@chromium.org","cmumford@chromium.org","csharp@chromium.org","cthomp@chromium.org","dalecurtis@chromium.org","danakj@chromium.org","danielpark@chromium.org","danyao@chromium.org","david.barr@samsung.com","davidben@chromium.org","dbertoni@chromium.org","ddorwin@chromium.org","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","djordje.golubovic@mips.com","dmazzoni@chromium.org","dmblack@google.com","dpapad@chromium.org","dpranke@chromium.org","drott@chromium.org","dtapuska@chromium.org","dtseng@chromium.org","ericrk@chromium.org","erikchen@chromium.org","etiennep@chromium.org","eyaich@google.com","fdoray@chromium.org","flackr@chromium.org","fmalita@chromium.org","fsamuel@chromium.org","ftirelo@chromium.org","fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","gab@chromium.org","gambard@chromium.org","gangwu@chromium.org","gmx@chromium.org","hansberry@chromium.org","hanxi@google.com","hgrandinetti@chromium.org","hongchan@chromium.org","huangs@chromium.org","huangxueqing@xiaomi.com","iclelland@chromium.org","ikilpatrick@chromium.org","jamescook@chromium.org","javierrobles@chromium.org","jbarboza@ca.ibm.com","jbroman@chromium.org","jcivelli@google.com","jdoerrie@chromium.org","jdonnelly@chromium.org","jelson@chromium.org","jhawkins@chromium.org","jialiul@chromium.org","jinho.bang@samsung.com","jinsukkim@chromium.org","jonross@chromium.org","jordynass@chromium.org","jrummell@chromium.org","jsbell@chromium.org","juncai@chromium.org","jzw@chromium.org","katie@chromium.org","kerrnel@chromium.org","khorimoto@google.com","khushalsagar@chromium.org","kkhorimoto@chromium.org","kmilka@chromium.org","kojii@chromium.org","kolos@chromium.org","kpaulhamus@chromium.org","kraynov@chromium.org","kristipark@chromium.org","kylechar@chromium.org","lambroslambrou@chromium.org","liberato@chromium.org","lijiawei@chromium.org","lilyhoughton@chromium.org","lod@google.com","luoe@chromium.org","mahmadi@chromium.org","marcin@mwiacek.com","mastiz@chromium.org","mathp@chromium.org","mcasas@chromium.org","mdjones@chromium.org","meacer@chromium.org","mheikal@google.com","mlamouri@chromium.org","mlippautz@chromium.org","mmenke@chromium.org","msarda@chromium.org","mstensho@chromium.org","msw@chromium.org","mthiesse@chromium.org","mtklein@chromium.org","nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","nburris@google.com","nednguyen@google.com","nektar@chromium.org","npm@chromium.org","olivierrobin@chromium.org","oshima@chromium.org","paulmeyer@chromium.org","paulmiller@google.com","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","petermayo@chromium.org","pfeldman@chromium.org","pilgrim@chromium.org","pkasting@chromium.org","pnoland@google.com","proberge@chromium.org","qingsi@google.com","qinmin@chromium.org","rajendrant@chromium.org","ranj@chromium.org","raphael.kubo.da.costa@intel.com","rbpotter@chromium.org","rdevlin.cronin@chromium.org","rhalavati@chromium.org","rkuroiwa@chromium.org","rmcelrath@chromium.org","rockot@chromium.org","rsleevi@chromium.org","ryansturm@chromium.org","sabbakumov@yandex-team.ru","sahel@chromium.org","samans@chromium.org","sammiequon@google.com","sclittle@chromium.org","scottchen@chromium.org","sdefresne@chromium.org","sebmarchand@chromium.org","shend@chromium.org","shenghuai@google.com","shuchen@google.com","siyua@chromium.org","skau@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","sky@chromium.org","slan@google.com","smcgruer@chromium.org","sohan.jyoti@huawei.com","sonnysasaka@chromium.org","ssilkin@chromium.org","stkhapugin@chromium.org","sujiezhu@google.com","supertri@chromium.org","tbansal@chromium.org","tbergquist@chromium.org","thakis@chromium.org","thestig@chromium.org","tigero@google.com","trchen@chromium.org","treib@chromium.org","twellington@chromium.org","updowndota@chromium.org","uwyiming@google.com","v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com","vmpstr@chromium.org","waffles@chromium.org","wez@chromium.org","wutao@chromium.org","xiaochengh@chromium.org","xidachen@chromium.org","xingliu@chromium.org","xunjieli@chromium.org","xunran.ding@samsung.com","yawano@chromium.org","yfriedman@chromium.org","yiyix@chromium.org"] Build
branch "master" Build
buildnumber 2320 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531314453 Build
revision "8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975" Build
slavename "vm2-m1" BuildSlave
buildername "Win 10 High-DPI Perf" Builder
git_revision "8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975" Change
parent_buildername "Win x64 Builder Perf" ParentBuild
parent_buildnumber 26706 ParentBuild
parent_got_angle_revision "89ef177f94753a91d7ec12aa58a5b06df2c12f0f" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574438}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" ParentBuild
parent_got_webrtc_revision "ef43aafcf5953845b71840e14c94942d60c541c1" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23896}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "E:\\b\\build\\slave/Win_10_High-DPI_Perf" slave

Blamelist:

  1. (mcasasohnoyoudont@chromium.org)
  2. (gambardohnoyoudont@chromium.org)
  3. (sebmarchandohnoyoudont@chromium.org)
  4. (hgrandinettiohnoyoudont@chromium.org)
  5. (rhalavatiohnoyoudont@chromium.org)
  6. (kraynovohnoyoudont@chromium.org)
  7. (mlippautzohnoyoudont@chromium.org)
  8. (thakisohnoyoudont@chromium.org)
  9. (pilgrimohnoyoudont@chromium.org)
  10. (msardaohnoyoudont@chromium.org)
  11. (petermayoohnoyoudont@chromium.org)
  12. (jbarbozaohnoyoudont@ca.ibm.com)
  13. (chcunninghamohnoyoudont@chromium.org)
  14. (eyaichohnoyoudont@google.com)
  15. (javierroblesohnoyoudont@chromium.org)
  16. (mstenshoohnoyoudont@chromium.org)
  17. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  18. (kolosohnoyoudont@chromium.org)
  19. (iclellandohnoyoudont@chromium.org)
  20. (anthonyvdohnoyoudont@chromium.org)
  21. (gambardohnoyoudont@chromium.org)
  22. (csharpohnoyoudont@chromium.org)
  23. (huangxueqingohnoyoudont@xiaomi.com)
  24. (thakisohnoyoudont@chromium.org)
  25. (samansohnoyoudont@chromium.org)
  26. (fdorayohnoyoudont@chromium.org)
  27. (erikchenohnoyoudont@chromium.org)
  28. (ckitagawaohnoyoudont@chromium.org)
  29. (npmohnoyoudont@chromium.org)
  30. (jdonnellyohnoyoudont@chromium.org)
  31. (wafflesohnoyoudont@chromium.org)
  32. (fdorayohnoyoudont@chromium.org)
  33. (fdorayohnoyoudont@chromium.org)
  34. (ftireloohnoyoudont@chromium.org)
  35. (dbertoniohnoyoudont@chromium.org)
  36. (hanxiohnoyoudont@google.com)
  37. (jbromanohnoyoudont@chromium.org)
  38. (flackrohnoyoudont@chromium.org)
  39. (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  40. (acondorohnoyoudont@chromium.org)
  41. (jsbellohnoyoudont@chromium.org)
  42. (shenghuaiohnoyoudont@google.com)
  43. (kojiiohnoyoudont@chromium.org)
  44. (mlamouriohnoyoudont@chromium.org)
  45. (mthiesseohnoyoudont@chromium.org)
  46. (shuchenohnoyoudont@google.com)
  47. (wezohnoyoudont@chromium.org)
  48. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  49. (skyohnoyoudont@chromium.org)
  50. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  51. (paulmeyerohnoyoudont@chromium.org)
  52. (sdefresneohnoyoudont@chromium.org)
  53. (etiennepohnoyoudont@chromium.org)
  54. (jzwohnoyoudont@chromium.org)
  55. (ccameronohnoyoudont@chromium.org)
  56. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  57. (olivierrobinohnoyoudont@chromium.org)
  58. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  59. (beccahughesohnoyoudont@chromium.org)
  60. (pkastingohnoyoudont@chromium.org)
  61. (raphael.kubo.da.costaohnoyoudont@intel.com)
  62. (mthiesseohnoyoudont@chromium.org)
  63. (dbertoniohnoyoudont@chromium.org)
  64. (tigeroohnoyoudont@google.com)
  65. (pkastingohnoyoudont@chromium.org)
  66. (chcunninghamohnoyoudont@chromium.org)
  67. (amalovaohnoyoudont@chromium.org)
  68. (dtsengohnoyoudont@chromium.org)
  69. (skyohnoyoudont@chromium.org)
  70. (npmohnoyoudont@chromium.org)
  71. (xunran.dingohnoyoudont@samsung.com)
  72. (hongchanohnoyoudont@chromium.org)
  73. (nektarohnoyoudont@chromium.org)
  74. (thestigohnoyoudont@chromium.org)
  75. (adokarohnoyoudont@google.com)
  76. (david.barrohnoyoudont@samsung.com)
  77. (kristiparkohnoyoudont@chromium.org)
  78. (davidbenohnoyoudont@chromium.org)
  79. (sammiequonohnoyoudont@google.com)
  80. (qinminohnoyoudont@chromium.org)
  81. (rockotohnoyoudont@chromium.org)
  82. (meacerohnoyoudont@chromium.org)
  83. (fmalitaohnoyoudont@chromium.org)
  84. (fdorayohnoyoudont@chromium.org)
  85. (dtapuskaohnoyoudont@chromium.org)
  86. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  87. (erikchenohnoyoudont@chromium.org)
  88. (twellingtonohnoyoudont@chromium.org)
  89. (wezohnoyoudont@chromium.org)
  90. (katieohnoyoudont@chromium.org)
  91. (jinho.bangohnoyoudont@samsung.com)
  92. (mheikalohnoyoudont@google.com)
  93. (vmpstrohnoyoudont@chromium.org)
  94. (khushalsagarohnoyoudont@chromium.org)
  95. (liberatoohnoyoudont@chromium.org)
  96. (rkuroiwaohnoyoudont@chromium.org)
  97. (wutaoohnoyoudont@chromium.org)
  98. (jhawkinsohnoyoudont@chromium.org)
  99. (dprankeohnoyoudont@chromium.org)
  100. (lodohnoyoudont@google.com)
  101. (david.barrohnoyoudont@samsung.com)
  102. (sclittleohnoyoudont@chromium.org)
  103. (sabbakumovohnoyoudont@yandex-team.ru)
  104. (lambroslambrouohnoyoudont@chromium.org)
  105. (katieohnoyoudont@chromium.org)
  106. (thakisohnoyoudont@chromium.org)
  107. (tbansalohnoyoudont@chromium.org)
  108. (mdjonesohnoyoudont@chromium.org)
  109. (akabaohnoyoudont@google.com)
  110. (nednguyenohnoyoudont@google.com)
  111. (rmcelrathohnoyoudont@chromium.org)
  112. (sahelohnoyoudont@chromium.org)
  113. (stkhapuginohnoyoudont@chromium.org)
  114. (thakisohnoyoudont@chromium.org)
  115. (slanohnoyoudont@google.com)
  116. (skauohnoyoudont@chromium.org)
  117. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  118. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  119. (eyaichohnoyoudont@google.com)
  120. (kraynovohnoyoudont@chromium.org)
  121. (pilgrimohnoyoudont@chromium.org)
  122. (pnolandohnoyoudont@google.com)
  123. (petermayoohnoyoudont@chromium.org)
  124. (sohan.jyotiohnoyoudont@huawei.com)
  125. (luoeohnoyoudont@chromium.org)
  126. (fdorayohnoyoudont@chromium.org)
  127. (fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  128. (mcasasohnoyoudont@chromium.org)
  129. (gabohnoyoudont@chromium.org)
  130. (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  131. (ericrkohnoyoudont@chromium.org)
  132. (jdonnellyohnoyoudont@chromium.org)
  133. (jcivelliohnoyoudont@google.com)
  134. (kerrnelohnoyoudont@chromium.org)
  135. (mheikalohnoyoudont@google.com)
  136. (dtsengohnoyoudont@chromium.org)
  137. (rbpotterohnoyoudont@chromium.org)
  138. (jinsukkimohnoyoudont@chromium.org)
  139. (xidachenohnoyoudont@chromium.org)
  140. (xingliuohnoyoudont@chromium.org)
  141. (npmohnoyoudont@chromium.org)
  142. (dtsengohnoyoudont@chromium.org)
  143. (nednguyenohnoyoudont@google.com)
  144. (ssilkinohnoyoudont@chromium.org)
  145. (kylecharohnoyoudont@chromium.org)
  146. (jdoerrieohnoyoudont@chromium.org)
  147. (jialiulohnoyoudont@chromium.org)
  148. (huangsohnoyoudont@chromium.org)
  149. (mthiesseohnoyoudont@chromium.org)
  150. (nednguyenohnoyoudont@google.com)
  151. (boliuohnoyoudont@chromium.org)
  152. (smcgruerohnoyoudont@chromium.org)
  153. (eyaichohnoyoudont@google.com)
  154. (cmumfordohnoyoudont@chromium.org)
  155. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  156. (fdorayohnoyoudont@chromium.org)
  157. (uwyimingohnoyoudont@google.com)
  158. (treibohnoyoudont@chromium.org)
  159. (mahmadiohnoyoudont@chromium.org)
  160. (mlamouriohnoyoudont@chromium.org)
  161. (ranjohnoyoudont@chromium.org)
  162. (huangsohnoyoudont@chromium.org)
  163. (updowndotaohnoyoudont@chromium.org)
  164. (skyohnoyoudont@chromium.org)
  165. (mmenkeohnoyoudont@chromium.org)
  166. (dtapuskaohnoyoudont@chromium.org)
  167. (jonrossohnoyoudont@chromium.org)
  168. (paulmillerohnoyoudont@google.com)
  169. (oshimaohnoyoudont@chromium.org)
  170. (bsheedyohnoyoudont@chromium.org)
  171. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  172. (tigeroohnoyoudont@google.com)
  173. (treibohnoyoudont@chromium.org)
  174. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  175. (yfriedmanohnoyoudont@chromium.org)
  176. (agrieveohnoyoudont@chromium.org)
  177. (dprankeohnoyoudont@chromium.org)
  178. (jzwohnoyoudont@chromium.org)
  179. (sujiezhuohnoyoudont@google.com)
  180. (sebmarchandohnoyoudont@chromium.org)
  181. (yiyixohnoyoudont@chromium.org)
  182. (dmazzoniohnoyoudont@chromium.org)
  183. (xunjieliohnoyoudont@chromium.org)
  184. (wafflesohnoyoudont@chromium.org)
  185. (aeeohnoyoudont@chromium.org)
  186. (aeeohnoyoudont@chromium.org)
  187. (chrishtrohnoyoudont@chromium.org)
  188. (mlamouriohnoyoudont@chromium.org)
  189. (sahelohnoyoudont@chromium.org)
  190. (wafflesohnoyoudont@chromium.org)
  191. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  192. (chrishtrohnoyoudont@chromium.org)
  193. (wafflesohnoyoudont@chromium.org)
  194. (wafflesohnoyoudont@chromium.org)
  195. (wafflesohnoyoudont@chromium.org)
  196. (marcinohnoyoudont@mwiacek.com)
  197. (chongjiangohnoyoudont@chromium.org)
  198. (mathpohnoyoudont@chromium.org)
  199. (chrishtrohnoyoudont@chromium.org)
  200. (kpaulhamusohnoyoudont@chromium.org)
  201. (perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  202. (jonrossohnoyoudont@chromium.org)
  203. (alphohnoyoudont@chromium.org)
  204. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  205. (mtkleinohnoyoudont@chromium.org)
  206. (hongchanohnoyoudont@chromium.org)
  207. (tigeroohnoyoudont@google.com)
  208. (kmilkaohnoyoudont@chromium.org)
  209. (dmblackohnoyoudont@google.com)
  210. (jordynassohnoyoudont@chromium.org)
  211. (pfeldmanohnoyoudont@chromium.org)
  212. (jamescookohnoyoudont@chromium.org)
  213. (gmxohnoyoudont@chromium.org)
  214. (djordje.golubovicohnoyoudont@mips.com)
  215. (kkhorimotoohnoyoudont@chromium.org)
  216. (kkhorimotoohnoyoudont@chromium.org)
  217. (dpapadohnoyoudont@chromium.org)
  218. (hansberryohnoyoudont@chromium.org)
  219. (akabaohnoyoudont@google.com)
  220. (alexilinohnoyoudont@chromium.org)
  221. (ikilpatrickohnoyoudont@chromium.org)
  222. (kkhorimotoohnoyoudont@chromium.org)
  223. (juncaiohnoyoudont@chromium.org)
  224. (dalecurtisohnoyoudont@chromium.org)
  225. (mlamouriohnoyoudont@chromium.org)
  226. (mheikalohnoyoudont@google.com)
  227. (jamescookohnoyoudont@chromium.org)
  228. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  229. (dmazzoniohnoyoudont@chromium.org)
  230. (xiaochenghohnoyoudont@chromium.org)
  231. (liberatoohnoyoudont@chromium.org)
  232. (danyaoohnoyoudont@chromium.org)
  233. (wafflesohnoyoudont@chromium.org)
  234. (danakjohnoyoudont@chromium.org)
  235. (bsalomonohnoyoudont@google.com)
  236. (samansohnoyoudont@chromium.org)
  237. (mastizohnoyoudont@chromium.org)
  238. (danyaoohnoyoudont@chromium.org)
  239. (skyohnoyoudont@chromium.org)
  240. (lijiaweiohnoyoudont@chromium.org)
  241. (dpapadohnoyoudont@chromium.org)
  242. (rsleeviohnoyoudont@chromium.org)
  243. (lilyhoughtonohnoyoudont@chromium.org)
  244. (dprankeohnoyoudont@chromium.org)
  245. (qingsiohnoyoudont@google.com)
  246. (jonrossohnoyoudont@chromium.org)
  247. (siyuaohnoyoudont@chromium.org)
  248. (jelsonohnoyoudont@chromium.org)
  249. (cthompohnoyoudont@chromium.org)
  250. (marcinohnoyoudont@mwiacek.com)
  251. (jamescookohnoyoudont@chromium.org)
  252. (uwyimingohnoyoudont@google.com)
  253. (tbergquistohnoyoudont@chromium.org)
  254. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  255. (gangwuohnoyoudont@chromium.org)
  256. (ddorwinohnoyoudont@chromium.org)
  257. (kojiiohnoyoudont@chromium.org)
  258. (danyaoohnoyoudont@chromium.org)
  259. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  260. (dprankeohnoyoudont@chromium.org)
  261. (ryansturmohnoyoudont@chromium.org)
  262. (amaralpohnoyoudont@chromium.org)
  263. (supertriohnoyoudont@chromium.org)
  264. (nburrisohnoyoudont@google.com)
  265. (khorimotoohnoyoudont@google.com)
  266. (marcinohnoyoudont@mwiacek.com)
  267. (chrishaohnoyoudont@chromium.org)
  268. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  269. (jinsukkimohnoyoudont@chromium.org)
  270. (nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  271. (qinminohnoyoudont@chromium.org)
  272. (hongchanohnoyoudont@chromium.org)
  273. (kristiparkohnoyoudont@chromium.org)
  274. (jamescookohnoyoudont@chromium.org)
  275. (mswohnoyoudont@chromium.org)
  276. (drottohnoyoudont@chromium.org)
  277. (fsamuelohnoyoudont@chromium.org)
  278. (yawanoohnoyoudont@chromium.org)
  279. (aleventhalohnoyoudont@chromium.org)
  280. (sonnysasakaohnoyoudont@chromium.org)
  281. (shendohnoyoudont@chromium.org)
  282. (aviohnoyoudont@chromium.org)
  283. (tbansalohnoyoudont@chromium.org)
  284. (dprankeohnoyoudont@chromium.org)
  285. (khorimotoohnoyoudont@google.com)
  286. (rockotohnoyoudont@chromium.org)
  287. (rdevlin.croninohnoyoudont@chromium.org)
  288. (tbansalohnoyoudont@chromium.org)
  289. (rajendrantohnoyoudont@chromium.org)
  290. (probergeohnoyoudont@chromium.org)
  291. (jrummellohnoyoudont@chromium.org)
  292. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  293. (trchenohnoyoudont@chromium.org)
  294. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  295. (skyohnoyoudont@chromium.org)
  296. (v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com)
  297. (scottchenohnoyoudont@chromium.org)
  298. (danielparkohnoyoudont@chromium.org)
  299. (pkastingohnoyoudont@chromium.org)
  300. (jamescookohnoyoudont@chromium.org)
  301. (thakisohnoyoudont@chromium.org)
  302. (kylecharohnoyoudont@chromium.org)
  303. (mstenshoohnoyoudont@chromium.org)
  304. (bcfohnoyoudont@chromium.org)
  305. (qinminohnoyoudont@chromium.org)
  306. (jinsukkimohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 01:39:18 UTC
End Thursday, 12-Jul-18 08:57:04 UTC
Pending N/A
Execution 7 hrs 17 mins

All Changes:

  1. Roll src/third_party/libyuv/ 4d67b3e85..55f5d91f1 with type fixes

    Changed by mcasasohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 12:42:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79dad56519a9c8749626d50f34e6f36924d4b38d

    Comments

    Roll src/third_party/libyuv/ 4d67b3e85..55f5d91f1 with type fixes
    
    This CL is a spin off of crrev.com/c/1130662/4 with the old data type
    uses (e.g. int8, int16, int32) corrected (e.g. int8_t, int16_t, int32_t)
    etc.
    
    https://chromium.googlesource.com/libyuv/libyuv.git/+log/4d67b3e851b1..55f5d91f11f9
    
    $ git log 4d67b3e85..55f5d91f1 --date=short --no-merges --format='%ad %ae %s'
    2018-07-09 fbarchard Disable old int types by default.
    2018-07-03 fbarchard msa use void * for loads
    2018-06-29 johannkoenig xc
    ...skip...
    for libyuv pass.
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I60d62b047b04c6c0f821df15a5f5b4be85cf331c
    Reviewed-on: https://chromium-review.googlesource.com/1131560
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Reviewed-by: Frank Barchard <fbarchard@chromium.org>
    Reviewed-by: Emircan Uysaler <emircan@chromium.org>
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Dan Sanders <sandersd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574133}

    Changed files

    • DEPS
    • components/viz/service/display/copy_output_scaling_pixeltest.cc
    • content/renderer/image_capture/image_capture_frame_grabber.cc
    • content/renderer/media/stream/webmediaplayer_ms_compositor.cc
    • content/renderer/media_capture_from_element/canvas_capture_handler.cc
    • content/renderer/media_capture_from_element/html_video_element_capturer_source.cc
    • content/renderer/media_recorder/video_track_recorder.cc
    • media/video/gpu_memory_buffer_video_frame_pool.cc
  2. [iOS] Tweak location bar background color

    Changed by gambardohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 12:52:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f

    Comments

    [iOS] Tweak location bar background color
    
    This CL changes the location bar background to be less visible in
    non-incognito. Also it updates the search button to be the same
    background color as the location bar.
    
    Bug: 862518
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I7e25c2b093161524cb38619dcc834776e0891cc8
    Reviewed-on: https://chromium-review.googlesource.com/1133008
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574134}

    Changed files

    • ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
    • ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.mm
  3. Prevent Proactive tab discarding while offline.

    Changed by sebmarchandohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 12:56:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc1c4db2029d62332884c5f38a5856871f801a1e

    Comments

    Prevent Proactive tab discarding while offline.
    
    Bug: 775644
    Change-Id: I63764d060763c2040086c84ae02517f7bea3af52
    Reviewed-on: https://chromium-review.googlesource.com/1132399
    Reviewed-by: François Doray <fdoray@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574135}

    Changed files

    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
    • chrome/browser/resource_coordinator/tab_manager_unittest.cc
  4. Handle UsageTimeLimit with multiple overrides.

    Changed by hgrandinettiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:00:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b4c4aead5ba84ded8085fe795310a2c93501505

    Comments

    Handle UsageTimeLimit with multiple overrides.
    
    On cl https://chromium-review.googlesource.com/c/chromium/src/+/1112051, I changed the override part of UsageTimeLimit policy from a single object to an array. On this cl I change the usage_time_limit_processor to handle this as well. Currently, the only override considered is the latest one.
    
    Bug: 823536
    Change-Id: Ia5842edec3fc6127115d7f7b988ec43c437b1713
    Reviewed-on: https://chromium-review.googlesource.com/1127399
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
    Cr-Commit-Position: refs/heads/master@{#574136}

    Changed files

    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor.cc
    • chrome/browser/chromeos/child_accounts/usage_time_limit_processor_unittest.cc
  5. Roll traffic_annotation_auditor for Windows.

    Changed by rhalavatiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:05:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0ee8d2d8fa797bf1da0d7909ec2a05b0d63e1620

    Comments

    Roll traffic_annotation_auditor for Windows.
    
    Change-Id: I4d6e738dba8a06cd62d8d03b41492a3ebecce88f
    TBR: georgesak@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1133162
    Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
    Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574137}

    Changed files

    • tools/traffic_annotation/bin/README.md
    • tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
  6. Remove unused LazySchedulerMessageLoopDelegateForTests.

    Changed by kraynovohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:28:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da210dc6bc86e0ae04bbdd18a713183c515d8f55

    Comments

    Remove unused LazySchedulerMessageLoopDelegateForTests.
    
    Change-Id: I8625303764e75b947515f2bcdaf67fa092f925d5
    Reviewed-on: https://chromium-review.googlesource.com/1133173
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574138}

    Changed files

    • third_party/blink/renderer/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
  7. blink::Page: Move main_frame declaration

    Changed by mlippautzohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:32:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d687adc9b787f6229a74c8128de65bd5c5bf2a2

    Comments

    blink::Page: Move main_frame declaration
    
    Page::main_frame_ is used during constructing Page::visual_viewport_
    (VisualViewport) which imples that the field should be constructed
    before using.
    
    allocatd memory.
    
    Note: In practice this works because Oilpan currently 0-fills all newly
    Change-Id: I103d90c17d649dffbce2c9ac70a0a6a9cac9448b
    Reviewed-on: https://chromium-review.googlesource.com/1133159
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574139}

    Changed files

    • third_party/blink/renderer/core/page/page.cc
    • third_party/blink/renderer/core/page/page.h
  8. Take tools/gn behind the barn.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:34:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 80816b51ed94d0d833543d3453226610518c94b7

    Comments

    Take tools/gn behind the barn.
    
    gn now lives at https://gn.googlesource.com/gn/ , so delete
    src/tools/gn, and bot configuration to run gn_unittests.
    
    Bug: 859536
    Change-Id: I64f4d4fb00349cb8d7143d0a1b96088cc173e27c
    Reviewed-on: https://chromium-review.googlesource.com/1129822
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Brett Wilson <brettw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574140}

    Changed files

    • BUILD.gn
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.linux.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/client.v8.fyi.json
    • testing/buildbot/gn_isolate_map.pyl
    • testing/buildbot/test_suites.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/code_coverage/test_suite.txt
    • tools/gn/BUILD.gn
    • tools/gn/DEPS
    • tools/gn/OWNERS
    • tools/gn/README.md
    • tools/gn/action_target_generator.cc
    • tools/gn/action_target_generator.h
    • tools/gn/action_target_generator_unittest.cc
    • tools/gn/action_values.cc
    • tools/gn/action_values.h
    • tools/gn/analyzer.cc
    • tools/gn/analyzer.h
    • tools/gn/analyzer_unittest.cc
    • tools/gn/args.cc
    • tools/gn/args.h
    • tools/gn/args_unittest.cc
    • tools/gn/bin/compare_test_lists.py
    • tools/gn/bin/gn-format.py
    • tools/gn/bin/help_as_html.py
    • tools/gn/bin/roll_gn.py
    • tools/gn/binary_target_generator.cc
    • tools/gn/binary_target_generator.h
    • tools/gn/bootstrap/OWNERS
    • tools/gn/bootstrap/bootstrap.py
    • tools/gn/bootstrap/build.ninja.template
    • tools/gn/bootstrap/build_aix.ninja.template
    • tools/gn/bootstrap/build_mac.ninja.template
    • tools/gn/bootstrap/build_vs.ninja.template
    • tools/gn/build_settings.cc
    • tools/gn/build_settings.h
    • tools/gn/builder.cc
    • tools/gn/builder.h
    • tools/gn/builder_record.cc
    • tools/gn/builder_record.h
    • tools/gn/builder_unittest.cc
    • tools/gn/bundle_data.cc
    • tools/gn/bundle_data.h
    • tools/gn/bundle_data_target_generator.cc
    • tools/gn/bundle_data_target_generator.h
    • tools/gn/bundle_file_rule.cc
    • tools/gn/bundle_file_rule.h
    • tools/gn/c_include_iterator.cc
    • tools/gn/c_include_iterator.h
    • tools/gn/c_include_iterator_unittest.cc
    • tools/gn/command_analyze.cc
    • tools/gn/command_args.cc
    • tools/gn/command_check.cc
    • tools/gn/command_clean.cc
    • tools/gn/command_desc.cc
    • tools/gn/command_format.cc
    • tools/gn/command_format.h
    • tools/gn/command_format_unittest.cc
    • tools/gn/command_gen.cc
    • tools/gn/command_help.cc
    • tools/gn/command_ls.cc
    • tools/gn/command_path.cc
    • tools/gn/command_refs.cc
    • tools/gn/commands.cc
    • tools/gn/commands.h
    • tools/gn/config.cc
    • tools/gn/config.h
    • tools/gn/config_unittest.cc
    • tools/gn/config_values.cc
    • tools/gn/config_values.h
    • tools/gn/config_values_extractors.cc
    • tools/gn/config_values_extractors.h
    • tools/gn/config_values_extractors_unittest.cc
    • tools/gn/config_values_generator.cc
    • tools/gn/config_values_generator.h
    • tools/gn/copy_target_generator.cc
    • tools/gn/copy_target_generator.h
    • tools/gn/create_bundle_target_generator.cc
    • tools/gn/create_bundle_target_generator.h
    • tools/gn/deps_iterator.cc
    • tools/gn/deps_iterator.h
    • tools/gn/desc_builder.cc
    • tools/gn/desc_builder.h
    • tools/gn/docs/cross_compiles.md
    • tools/gn/docs/faq.md
    • tools/gn/docs/hacking.md
    • tools/gn/docs/language.md
    • tools/gn/docs/quick_start.md
    • tools/gn/docs/reference.md
    • tools/gn/docs/standalone.md
    • tools/gn/docs/style_guide.md
    • tools/gn/docs/update_binaries.md
    • tools/gn/eclipse_writer.cc
    • tools/gn/eclipse_writer.h
    • tools/gn/err.cc
    • tools/gn/err.h
    • tools/gn/escape.cc
    • tools/gn/escape.h
    • tools/gn/escape_unittest.cc
    • tools/gn/example/.gn
    • tools/gn/example/BUILD.gn
    • tools/gn/example/README.txt
    • tools/gn/example/build/BUILD.gn
    • tools/gn/example/build/BUILDCONFIG.gn
    • tools/gn/example/build/toolchain/BUILD.gn
    • tools/gn/example/hello.cc
    • tools/gn/example/hello_shared.cc
    • tools/gn/example/hello_shared.h
    • tools/gn/example/hello_static.cc
    • tools/gn/example/hello_static.h
    • tools/gn/exec_process.cc
    • tools/gn/exec_process.h
    • tools/gn/exec_process_unittest.cc
    • tools/gn/filesystem_utils.cc
    • tools/gn/filesystem_utils.h
    • tools/gn/filesystem_utils_unittest.cc
    • tools/gn/format_test_data/001.gn
    • tools/gn/format_test_data/001.golden
    • tools/gn/format_test_data/002.gn
    • tools/gn/format_test_data/002.golden
    • tools/gn/format_test_data/003.gn
    • tools/gn/format_test_data/003.golden
    • tools/gn/format_test_data/004.gn
    • tools/gn/format_test_data/004.golden
    • tools/gn/format_test_data/005.gn
    • tools/gn/format_test_data/005.golden
    • tools/gn/format_test_data/006.gn
    • tools/gn/format_test_data/006.golden
    • tools/gn/format_test_data/007.gn
    • tools/gn/format_test_data/007.golden
    • tools/gn/format_test_data/008.gn
    • tools/gn/format_test_data/008.golden
    • tools/gn/format_test_data/009.gn
    • tools/gn/format_test_data/009.golden
    • tools/gn/format_test_data/010.gn
    • tools/gn/format_test_data/010.golden
    • tools/gn/format_test_data/011.gn
    • tools/gn/format_test_data/011.golden
    • tools/gn/format_test_data/012.gn
    • tools/gn/format_test_data/012.golden
    • tools/gn/format_test_data/013.gn
    • tools/gn/format_test_data/013.golden
    • tools/gn/format_test_data/014.gn
    • tools/gn/format_test_data/014.golden
    • tools/gn/format_test_data/015.gn
    • tools/gn/format_test_data/015.golden
    • tools/gn/format_test_data/016.gn
    • tools/gn/format_test_data/016.golden
    • tools/gn/format_test_data/017.gn
    • tools/gn/format_test_data/017.golden
    • tools/gn/format_test_data/018.gn
    • tools/gn/format_test_data/018.golden
    • tools/gn/format_test_data/019.gn
    • tools/gn/format_test_data/019.golden
    • tools/gn/format_test_data/020.gn
    • tools/gn/format_test_data/020.golden
    • tools/gn/format_test_data/021.gn
    • tools/gn/format_test_data/021.golden
    • tools/gn/format_test_data/022.gn
    • tools/gn/format_test_data/022.golden
    • tools/gn/format_test_data/023.gn
    • tools/gn/format_test_data/023.golden
    • tools/gn/format_test_data/024.gn
    • tools/gn/format_test_data/024.golden
    • tools/gn/format_test_data/025.gn
    • tools/gn/format_test_data/025.golden
    • tools/gn/format_test_data/026.gn
    • tools/gn/format_test_data/026.golden
    • tools/gn/format_test_data/027.gn
    • tools/gn/format_test_data/027.golden
    • tools/gn/format_test_data/028.gn
    • tools/gn/format_test_data/028.golden
    • tools/gn/format_test_data/029.gn
    • tools/gn/format_test_data/029.golden
    • tools/gn/format_test_data/030.gn
    • tools/gn/format_test_data/030.golden
    • tools/gn/format_test_data/031.gn
    • tools/gn/format_test_data/031.golden
    • tools/gn/format_test_data/032.gn
    • tools/gn/format_test_data/032.golden
    • tools/gn/format_test_data/033.gn
    • tools/gn/format_test_data/033.golden
    • tools/gn/format_test_data/034.gn
    • tools/gn/format_test_data/035.gn
    • tools/gn/format_test_data/035.golden
    • tools/gn/format_test_data/036.gn
    • tools/gn/format_test_data/036.golden
    • tools/gn/format_test_data/037.gn
    • tools/gn/format_test_data/037.golden
    • tools/gn/format_test_data/038.gn
    • tools/gn/format_test_data/038.golden
    • tools/gn/format_test_data/039.gn
    • tools/gn/format_test_data/039.golden
    • tools/gn/format_test_data/040.gn
    • tools/gn/format_test_data/041.gn
    • tools/gn/format_test_data/041.golden
    • tools/gn/format_test_data/042.gn
    • tools/gn/format_test_data/042.golden
    • tools/gn/format_test_data/043.gn
    • tools/gn/format_test_data/043.golden
    • tools/gn/format_test_data/044.gn
    • tools/gn/format_test_data/044.golden
    • tools/gn/format_test_data/045.gn
    • tools/gn/format_test_data/045.golden
    • tools/gn/format_test_data/046.gn
    • tools/gn/format_test_data/046.golden
    • tools/gn/format_test_data/047.gn
    • tools/gn/format_test_data/047.golden
    • tools/gn/format_test_data/048.gn
    • tools/gn/format_test_data/048.golden
    • tools/gn/format_test_data/049.gn
    • tools/gn/format_test_data/050.gn
    • tools/gn/format_test_data/050.golden
    • tools/gn/format_test_data/051.gn
    • tools/gn/format_test_data/051.golden
    • tools/gn/format_test_data/052.gn
    • tools/gn/format_test_data/052.golden
    • tools/gn/format_test_data/053.gn
    • tools/gn/format_test_data/053.golden
    • tools/gn/format_test_data/054.gn
    • tools/gn/format_test_data/054.golden
    • tools/gn/format_test_data/055.gn
    • tools/gn/format_test_data/055.golden
    • tools/gn/format_test_data/056.gn
    • tools/gn/format_test_data/056.golden
    • tools/gn/format_test_data/057.gn
    • tools/gn/format_test_data/057.golden
    • tools/gn/format_test_data/058.gn
    • tools/gn/format_test_data/058.golden
    • tools/gn/format_test_data/059.gn
    • tools/gn/format_test_data/059.golden
    • tools/gn/format_test_data/060.gn
    • tools/gn/format_test_data/060.golden
    • tools/gn/format_test_data/061.gn
    • tools/gn/format_test_data/061.golden
    • tools/gn/format_test_data/062.gn
    • tools/gn/format_test_data/062.golden
    • tools/gn/format_test_data/063.gn
    • tools/gn/format_test_data/063.golden
    • tools/gn/format_test_data/064.gn
    • tools/gn/format_test_data/064.golden
    • tools/gn/format_test_data/065.gn
    • tools/gn/format_test_data/065.golden
    • tools/gn/format_test_data/066.gn
    • tools/gn/format_test_data/066.golden
    • tools/gn/format_test_data/067.gn
    • tools/gn/format_test_data/067.golden
    • tools/gn/format_test_data/068.gn
    • tools/gn/format_test_data/068.golden
    • tools/gn/format_test_data/069.gn
    • tools/gn/format_test_data/069.golden
    • tools/gn/format_test_data/070.gn
    • tools/gn/format_test_data/070.golden
    • tools/gn/function_exec_script.cc
    • tools/gn/function_foreach.cc
    • tools/gn/function_foreach_unittest.cc
    • tools/gn/function_forward_variables_from.cc
    • tools/gn/function_forward_variables_from_unittest.cc
    • tools/gn/function_get_label_info.cc
    • tools/gn/function_get_label_info_unittest.cc
    • tools/gn/function_get_path_info.cc
    • tools/gn/function_get_path_info_unittest.cc
    • tools/gn/function_get_target_outputs.cc
    • tools/gn/function_get_target_outputs_unittest.cc
    • tools/gn/function_process_file_template.cc
    • tools/gn/function_process_file_template_unittest.cc
    • tools/gn/function_read_file.cc
    • tools/gn/function_rebase_path.cc
    • tools/gn/function_rebase_path_unittest.cc
    • tools/gn/function_set_default_toolchain.cc
    • tools/gn/function_set_defaults.cc
    • tools/gn/function_template.cc
    • tools/gn/function_template_unittest.cc
    • tools/gn/function_toolchain.cc
    • tools/gn/function_toolchain_unittest.cc
    • tools/gn/function_write_file.cc
    • tools/gn/function_write_file_unittest.cc
    • tools/gn/functions.cc
    • tools/gn/functions.h
    • tools/gn/functions_target.cc
    • tools/gn/functions_target_unittest.cc
    • tools/gn/functions_unittest.cc
    • tools/gn/gn_main.cc
    • tools/gn/group_target_generator.cc
    • tools/gn/group_target_generator.h
    • tools/gn/header_checker.cc
    • tools/gn/header_checker.h
    • tools/gn/header_checker_unittest.cc
    • tools/gn/import_manager.cc
    • tools/gn/import_manager.h
    • tools/gn/inherited_libraries.cc
    • tools/gn/inherited_libraries.h
    • tools/gn/inherited_libraries_unittest.cc
    • tools/gn/input_conversion.cc
    • tools/gn/input_conversion.h
    • tools/gn/input_conversion_unittest.cc
    • tools/gn/input_file.cc
    • tools/gn/input_file.h
    • tools/gn/input_file_manager.cc
    • tools/gn/input_file_manager.h
    • tools/gn/item.cc
    • tools/gn/item.h
    • tools/gn/json_project_writer.cc
    • tools/gn/json_project_writer.h
    • tools/gn/label.cc
    • tools/gn/label.h
    • tools/gn/label_pattern.cc
    • tools/gn/label_pattern.h
    • tools/gn/label_pattern_unittest.cc
    • tools/gn/label_ptr.h
    • tools/gn/label_unittest.cc
    • tools/gn/last_commit_position.py
    • tools/gn/lib_file.cc
    • tools/gn/lib_file.h
    • tools/gn/loader.cc
    • tools/gn/loader.h
    • tools/gn/loader_unittest.cc
    • tools/gn/location.cc
    • tools/gn/location.h
    • tools/gn/misc/OWNERS
    • tools/gn/misc/emacs/.gitignore
    • tools/gn/misc/emacs/gn-mode.el
    • tools/gn/misc/tm/GN.tmLanguage
    • tools/gn/misc/tm/GN.tmPreferences
    • tools/gn/misc/vim/README.chromium
    • tools/gn/misc/vim/autoload/gn.vim
    • tools/gn/misc/vim/ftdetect/gnfiletype.vim
    • tools/gn/misc/vim/ftplugin/gn.vim
    • tools/gn/misc/vim/syntax/gn.vim
    • tools/gn/ninja_action_target_writer.cc
    • tools/gn/ninja_action_target_writer.h
    • tools/gn/ninja_action_target_writer_unittest.cc
    • tools/gn/ninja_binary_target_writer.cc
    • tools/gn/ninja_binary_target_writer.h
    • tools/gn/ninja_binary_target_writer_unittest.cc
    • tools/gn/ninja_build_writer.cc
    • tools/gn/ninja_build_writer.h
    • tools/gn/ninja_build_writer_unittest.cc
    • tools/gn/ninja_bundle_data_target_writer.cc
    • tools/gn/ninja_bundle_data_target_writer.h
    • tools/gn/ninja_bundle_data_target_writer_unittest.cc
    • tools/gn/ninja_copy_target_writer.cc
    • tools/gn/ninja_copy_target_writer.h
    • tools/gn/ninja_copy_target_writer_unittest.cc
    • tools/gn/ninja_create_bundle_target_writer.cc
    • tools/gn/ninja_create_bundle_target_writer.h
    • tools/gn/ninja_create_bundle_target_writer_unittest.cc
    • tools/gn/ninja_group_target_writer.cc
    • tools/gn/ninja_group_target_writer.h
    • tools/gn/ninja_group_target_writer_unittest.cc
    • tools/gn/ninja_target_writer.cc
    • tools/gn/ninja_target_writer.h
    • tools/gn/ninja_target_writer_unittest.cc
    • tools/gn/ninja_toolchain_writer.cc
    • tools/gn/ninja_toolchain_writer.h
    • tools/gn/ninja_toolchain_writer_unittest.cc
    • tools/gn/ninja_utils.cc
    • tools/gn/ninja_utils.h
    • tools/gn/ninja_writer.cc
    • tools/gn/ninja_writer.h
    • tools/gn/operators.cc
    • tools/gn/operators.h
    • tools/gn/operators_unittest.cc
    • tools/gn/ordered_set.h
    • tools/gn/output_file.cc
    • tools/gn/output_file.h
    • tools/gn/parse_node_value_adapter.cc
    • tools/gn/parse_node_value_adapter.h
    • tools/gn/parse_tree.cc
    • tools/gn/parse_tree.h
    • tools/gn/parse_tree_unittest.cc
    • tools/gn/parser.cc
    • tools/gn/parser.h
    • tools/gn/parser_fuzzer.cc
    • tools/gn/parser_unittest.cc
    • tools/gn/path_output.cc
    • tools/gn/path_output.h
    • tools/gn/path_output_unittest.cc
    • tools/gn/pattern.cc
    • tools/gn/pattern.h
    • tools/gn/pattern_unittest.cc
    • tools/gn/pool.cc
    • tools/gn/pool.h
    • tools/gn/qt_creator_writer.cc
    • tools/gn/qt_creator_writer.h
    • tools/gn/runtime_deps.cc
    • tools/gn/runtime_deps.h
    • tools/gn/runtime_deps_unittest.cc
    • tools/gn/scheduler.cc
    • tools/gn/scheduler.h
    • tools/gn/scope.cc
    • tools/gn/scope.h
    • tools/gn/scope_per_file_provider.cc
    • tools/gn/scope_per_file_provider.h
    • tools/gn/scope_per_file_provider_unittest.cc
    • tools/gn/scope_unittest.cc
    • tools/gn/settings.cc
    • tools/gn/settings.h
    • tools/gn/setup.cc
    • tools/gn/setup.h
    • tools/gn/source_dir.cc
    • tools/gn/source_dir.h
    • tools/gn/source_dir_unittest.cc
    • tools/gn/source_file.cc
    • tools/gn/source_file.h
    • tools/gn/source_file_type.cc
    • tools/gn/source_file_type.h
    • tools/gn/source_file_unittest.cc
    • tools/gn/standard_out.cc
    • tools/gn/standard_out.h
    • tools/gn/string_utils.cc
    • tools/gn/string_utils.h
    • tools/gn/string_utils_unittest.cc
    • tools/gn/substitution_list.cc
    • tools/gn/substitution_list.h
    • tools/gn/substitution_pattern.cc
    • tools/gn/substitution_pattern.h
    • tools/gn/substitution_pattern_unittest.cc
    • tools/gn/substitution_type.cc
    • tools/gn/substitution_type.h
    • tools/gn/substitution_writer.cc
    • tools/gn/substitution_writer.h
    • tools/gn/substitution_writer_unittest.cc
    • tools/gn/switches.cc
    • tools/gn/switches.h
    • tools/gn/target.cc
    • tools/gn/target.h
    • tools/gn/target_generator.cc
    • tools/gn/target_generator.h
    • tools/gn/target_unittest.cc
    • tools/gn/template.cc
    • tools/gn/template.h
    • tools/gn/template_unittest.cc
    • tools/gn/test_with_scheduler.cc
    • tools/gn/test_with_scheduler.h
    • tools/gn/test_with_scope.cc
    • tools/gn/test_with_scope.h
    • tools/gn/token.cc
    • tools/gn/token.h
    • tools/gn/tokenizer.cc
    • tools/gn/tokenizer.h
    • tools/gn/tokenizer_unittest.cc
    • tools/gn/tool.cc
    • tools/gn/tool.h
    • tools/gn/toolchain.cc
    • tools/gn/toolchain.h
    • tools/gn/trace.cc
    • tools/gn/trace.h
    • tools/gn/tutorial/hello.cc
    • tools/gn/tutorial/hello.h
    • tools/gn/tutorial/hello_world.cc
    • tools/gn/tutorial/say_hello.cc
    • tools/gn/unique_vector.h
    • tools/gn/unique_vector_unittest.cc
    • tools/gn/value.cc
    • tools/gn/value.h
    • tools/gn/value_extractors.cc
    • tools/gn/value_extractors.h
    • tools/gn/value_unittest.cc
    • tools/gn/variables.cc
    • tools/gn/variables.h
    • tools/gn/visibility.cc
    • tools/gn/visibility.h
    • tools/gn/visibility_unittest.cc
    • tools/gn/visual_studio_utils.cc
    • tools/gn/visual_studio_utils.h
    • tools/gn/visual_studio_utils_unittest.cc
    • tools/gn/visual_studio_writer.cc
    • tools/gn/visual_studio_writer.h
    • tools/gn/visual_studio_writer_unittest.cc
    • tools/gn/xcode_object.cc
    • tools/gn/xcode_object.h
    • tools/gn/xcode_object_unittest.cc
    • tools/gn/xcode_writer.cc
    • tools/gn/xcode_writer.h
    • tools/gn/xml_element_writer.cc
    • tools/gn/xml_element_writer.h
    • tools/gn/xml_element_writer_unittest.cc
  9. Migrate ProfileSyncServiceAutofillTest to BindOnce/BindRepeating

    Changed by pilgrimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:38:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 306445eb3243c9186674568b488f0cebdd374918

    Comments

    Migrate ProfileSyncServiceAutofillTest to BindOnce/BindRepeating
    
    Bug: 714018
    Change-Id: I5f237f6be4311ebd36262354aef1256cd06d44eb
    Reviewed-on: https://chromium-review.googlesource.com/1131995
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574141}

    Changed files

    • components/browser_sync/profile_sync_service_autofill_unittest.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
  10. [unity] Add activity and interactions sync settings.

    Changed by msardaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:40:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 667f20ab4c04e86e7195549f61ca5e0eaa785512

    Comments

    [unity] Add activity and interactions sync settings.
    
    This CL add the activity and interactions sync settings. This allows the
    user to control whether event logger is enabled. This is controlled internally
    by the sync data type USER_EVENTS.
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: If32166e4b6d8eb3c25d28a8ada67491721cf59d8
    Reviewed-on: https://chromium-review.googlesource.com/1126239
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574142}

    Changed files

    • chrome/app/settings_strings.grdp
    • chrome/browser/resources/settings/people_page/sync_page.html
    • chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/browser/ui/webui/settings/people_handler_unittest.cc
    • components/browser_sync/profile_sync_service.cc
    • components/sync/base/model_type.h
    • components/sync/driver/user_selectable_sync_type.h
    • tools/metrics/histograms/enums.xml
  11. Re-enable passing WPT test

    Changed by petermayoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:53:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9601e99a9fa085a535a99d40e3bab9999bbbfa06

    Comments

    Re-enable passing WPT test
    
    This is passing at ToT.  The bug reference here looks like an old
    or original import.  I wonder when this started working, but it
    does not seem worth chasing down.
    
    Bug: 706118
    Change-Id: Ie8163cb204ed03f9ab04524400b84bb8d3e47232
    Reviewed-on: https://chromium-review.googlesource.com/1132558
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574145}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  12. fix gn builds on aix

    Changed by jbarbozaohnoyoudont@ca.ibm.com
    Changed at Wednesday, 11-Jul-18 13:51:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1a12ef3b343f9e75c630ed6dc8f1ea44a8a747b

    Comments

    fix gn builds on aix
    
    Introduces `is_aix` variable and suppress non-virtual-dtor warning.
    
    Change-Id: Iab0ceee2309d96b1efcb09fadc710362159da752
    Reviewed-on: https://chromium-review.googlesource.com/1103535
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574143}

    Changed files

    • build/config/BUILDCONFIG.gn
    • build/config/aix/BUILD.gn
    • tools/mb/mb.py
  13. VideoDecodePerfHistory - safer SaveCB.

    Changed by chcunninghamohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 13:53:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9febeb19dab5b13383b5b4145c0a3e6e0af82531

    Comments

    VideoDecodePerfHistory - safer SaveCB.
    
    This changes the interface such that saves can only performed via the
    SaveCB. Internally the CB is weakly bound to the perf history so post
    destruction saves are quietly dropped.
    
    This unblocks re-landing
    https://chromium-review.googlesource.com/c/chromium/src/+/1123687/1
    
    The above CL will give incognito profiles a distinct
    VideoDecodePerfHistory instance. Incognito profile's are rapidly deleted
    when the last tab closes, creating a race condition for any per st
    ...skip...
    om video's on that tab. Now, using the SaveCB,
    those late stats will be safely dropped.
    
    Bug: 855631, 855215, 796280
    Change-Id: Ia978dbca14d5584ca92301aee84020437a90311e
    Reviewed-on: https://chromium-review.googlesource.com/1123396
    Reviewed-by: Markus Heintz <markusheintz@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574144}

    Changed files

    • chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
    • content/browser/frame_host/render_frame_host_impl.cc
    • media/blink/webmediaplayer_impl_unittest.cc
    • media/mojo/services/media_metrics_provider.cc
    • media/mojo/services/media_metrics_provider.h
    • media/mojo/services/media_metrics_provider_unittest.cc
    • media/mojo/services/video_decode_perf_history.cc
    • media/mojo/services/video_decode_perf_history.h
    • media/mojo/services/video_decode_perf_history_unittest.cc
    • media/mojo/services/video_decode_stats_recorder.cc
    • media/mojo/services/video_decode_stats_recorder.h
    • media/mojo/services/watch_time_recorder_unittest.cc
  14. adding shard indicators to Android Nexus 5X Perf FYI

    Changed by eyaichohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 14:03:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae0af1511d081f85641f82ac650919dafffa1ee6

    Comments

    adding shard indicators to Android Nexus 5X Perf FYI
    
    TBR=nednguyen@google.com
    NOTRY=True
    
    Bug: 757933
    Change-Id: Ie817891643082472fc46805ef4a2ffe43356f2bf
    Reviewed-on: https://chromium-review.googlesource.com/1133278
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574146}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  15. Starts migration to Coordinator architecture

    Changed by javierroblesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:05:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 032ab5670a67474849d85bb32795f687e9426893

    Comments

    Starts migration to Coordinator architecture
    
    Currently an instance of the input accessory view controller is created
    per tab view the tab helper. This CL changes that to instead only have
    one instance per BVC. This the first step to start adopting the new
    coordinators architecture, which will be used in to present the manual
    fill view controllers from the input accessory view. The next step
    woould be fixing dependncies in order to move the coordinator to ui
    folder.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id0cc93c57e18f51f0208c38ddcdf4e3b8e9e90ac
    Bug: 845472
    Reviewed-on: https://chromium-review.googlesource.com/1103126
    Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574147}

    Changed files

    • ios/chrome/browser/autofill/BUILD.gn
    • ios/chrome/browser/autofill/form_input_accessory_coordinator.h
    • ios/chrome/browser/autofill/form_input_accessory_coordinator.mm
    • ios/chrome/browser/autofill/form_input_accessory_view_controller.h
    • ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
    • ios/chrome/browser/autofill/form_input_accessory_view_provider.h
    • ios/chrome/browser/autofill/form_input_accessory_view_tab_helper.h
    • ios/chrome/browser/autofill/form_input_accessory_view_tab_helper.mm
    • ios/chrome/browser/autofill/form_input_egtest.mm
    • ios/chrome/browser/autofill/form_suggestion_controller.mm
    • ios/chrome/browser/tabs/tab_helper_util.mm
    • ios/chrome/browser/ui/BUILD.gn
    • ios/chrome/browser/ui/browser_view_controller.mm
  16. [LayoutNG] Encompass border and padding for contain:size.

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:07:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fe2c1269af42e4fd9257f09ef05762667331a7b

    Comments

    [LayoutNG] Encompass border and padding for contain:size.
    
    When discarding intrinsic block size for contain:size, we need to reset
    intrinsic size to the border+padding sum (not zero), since
    intrinsic_block_size_ is the size of the border box, not the content
    box.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I29195a09a6d47b9e3c2a82da3be6f528aac25c68
    Reviewed-on: https://chromium-review.googlesource.com/1133163
    Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
    Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574148}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/css/css-contain/contain-size-borders.html
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
  17. Roll src/third_party/pdfium cbed949bee84..b1a4db5551ca (1 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 14:12:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b9d996723ab60c6f75c4d97a4188650abcc2b59

    Comments

    Roll src/third_party/pdfium cbed949bee84..b1a4db5551ca (1 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/cbed949bee84..b1a4db5551ca
    
    
    git log cbed949bee84..b1a4db5551ca --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thestig@chromium.org Fix some nits in fxjs code.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@b1a4db5551ca
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbo
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I520096872b1ab632c4dc59d4c653620e08f0fc52
    Reviewed-on: https://chromium-review.googlesource.com/1133238
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574149}

    Changed files

    • DEPS
  18. [Autofill] Allow crowdsourcing of big forms

    Changed by kolosohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:16:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca00af373d1cedda85aa03a039fff991f03ccb5d

    Comments

    [Autofill] Allow crowdsourcing of big forms
    
    This CL increases |kMaxFieldsOnTheForm| to 100 in |FormStructure::IsMalformed|.
    It allows to crowdsource more forms. See the bug for details. Later the
    parameter will be increased even more and will be finchable.
    
    UMA histogram is introduced to monitor the size of forms Autofill has to process.
    
    TODO: Finch-controlled threshold and UKM metric.
    
    Bug: 857454
    Change-Id: I50c1382dd36e2c707cd34f1a4f139413d9ea6026
    Reviewed-on: https://chromium-review.googlesource.com/1131457
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574150}

    Changed files

    • components/autofill/core/browser/form_structure.cc
    • components/autofill/core/browser/form_structure_unittest.cc
    • tools/metrics/histograms/histograms.xml
  19. Add stream printer for WebSandboxFlags

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:17:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5fb6477979e1ff87938c3f592d10d9f7a2b65ec3

    Comments

    Add stream printer for WebSandboxFlags
    
    This allows debug messages to print sandbox flags in a convenient binary
    format, rather than outputting them as decimal numbers or 4-byte arrays.
    
    This means that you can easily add debug statements for sandboxing code like:
    
    DLOG(INFO) << "The sandbox flags here look like " << sandbox_flags_;
    
    rather than having to cast:
    
    DLOG(INFO) << "The sandbox flags here look like " <<
        std::bitset<32>(static_cast<int>(sandbox_flags_));
    
    It also changes the test output 
    ...skip...
    11111111111101101111
    To be equal to: root->child_at(1)->effective_frame_policy().sandbox_flags
          Which is: 11111111111111111111101011111111
    
    in which single bit errors can easily be spotted.
    
    Change-Id: Ibc9020d67654c555e1c70dcb99829e2eb29d0b3c
    Reviewed-on: https://chromium-review.googlesource.com/772320
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574151}

    Changed files

    • third_party/blink/public/common/frame/sandbox_flags.h
  20. Properly register the ulp language_profile pref

    Changed by anthonyvdohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:22:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 141c98bb911473e000a272ab4b8888c575621d4e

    Comments

    Properly register the ulp language_profile pref
    
    The pref was gated on being in the Heuristic Model experiment, which
    isn't necessarily the case anymore. The pref should always be registered when
    the Heuristic Model is chosen.
    
    Bug: 862229
    Change-Id: I41fd77334edac643f43c638a6d56abc408242a53
    Reviewed-on: https://chromium-review.googlesource.com/1131814
    Reviewed-by: Michael Martis <martis@chromium.org>
    Commit-Queue: anthonyvd <anthonyvd@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574152}

    Changed files

    • chrome/browser/language/language_model_manager_factory.cc
  21. [iOS] Fix TabGrid toolbar button constraints

    Changed by gambardohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aab96631074ae44940c77dd9aee111473cfb38b7

    Comments

    [iOS] Fix TabGrid toolbar button constraints
    
    This CL removes the autolayout constraints on the TabGrid button in the
    toolbar and instead positions it using frames.
    
    Bug: 862576
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I5eda2cc58ee38228e40870f723315bc91ac6953f
    Reviewed-on: https://chromium-review.googlesource.com/1133167
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574153}

    Changed files

    • ios/chrome/browser/ui/toolbar/buttons/toolbar_tab_grid_button.mm
  22. Upstream chrome_cleaner/os subdir minus unit tests

    Changed by csharpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:25:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d0514d9c82d874a15a8686b60744da4ccdb3241

    Comments

    Upstream chrome_cleaner/os subdir minus unit tests
    
    The main changes were:
    -converting LOG(INFO) to VLOG(1)
    -Removing usages of Time::FromInternalValue
    
    Bug: 830892
    Change-Id: I117d6d605b5ca0b82ea7d509a127fbf316f483b0
    Reviewed-on: https://chromium-review.googlesource.com/1130103
    Commit-Queue: Chris Sharp <csharp@chromium.org>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574154}

    Changed files

    • chrome/chrome_cleaner/BUILD.gn
    • chrome/chrome_cleaner/os/BUILD.gn
    • chrome/chrome_cleaner/os/DEPS
    • chrome/chrome_cleaner/os/digest_verifier.cc
    • chrome/chrome_cleaner/os/digest_verifier.h
    • chrome/chrome_cleaner/os/disk_util.cc
    • chrome/chrome_cleaner/os/disk_util.h
    • chrome/chrome_cleaner/os/disk_util_types.cc
    • chrome/chrome_cleaner/os/disk_util_types.h
    • chrome/chrome_cleaner/os/early_exit.cc
    • chrome/chrome_cleaner/os/early_exit.h
    • chrome/chrome_cleaner/os/file_path_sanitization.cc
    • chrome/chrome_cleaner/os/file_path_sanitization.h
    • chrome/chrome_cleaner/os/file_path_set.cc
    • chrome/chrome_cleaner/os/file_path_set.h
    • chrome/chrome_cleaner/os/file_removal_status_updater.cc
    • chrome/chrome_cleaner/os/file_removal_status_updater.h
    • chrome/chrome_cleaner/os/file_remover.cc
    • chrome/chrome_cleaner/os/file_remover.h
    • chrome/chrome_cleaner/os/file_remover_api.h
    • chrome/chrome_cleaner/os/initializer.cc
    • chrome/chrome_cleaner/os/initializer.h
    • chrome/chrome_cleaner/os/layered_service_provider_api.h
    • chrome/chrome_cleaner/os/layered_service_provider_wrapper.cc
    • chrome/chrome_cleaner/os/layered_service_provider_wrapper.h
    • chrome/chrome_cleaner/os/nt_internals.h
    • chrome/chrome_cleaner/os/post_reboot_registration.cc
    • chrome/chrome_cleaner/os/post_reboot_registration.h
    • chrome/chrome_cleaner/os/pre_fetched_paths.cc
    • chrome/chrome_cleaner/os/pre_fetched_paths.h
    • chrome/chrome_cleaner/os/process.cc
    • chrome/chrome_cleaner/os/process.h
    • chrome/chrome_cleaner/os/rebooter.cc
    • chrome/chrome_cleaner/os/rebooter.h
    • chrome/chrome_cleaner/os/rebooter_api.h
    • chrome/chrome_cleaner/os/registry.cc
    • chrome/chrome_cleaner/os/registry.h
    • chrome/chrome_cleaner/os/registry_override_manager.cc
    • chrome/chrome_cleaner/os/registry_override_manager.h
    • chrome/chrome_cleaner/os/registry_util.cc
    • chrome/chrome_cleaner/os/registry_util.h
    • chrome/chrome_cleaner/os/resource_util.cc
    • chrome/chrome_cleaner/os/resource_util.h
    • chrome/chrome_cleaner/os/scoped_disable_wow64_redirection.cc
    • chrome/chrome_cleaner/os/scoped_disable_wow64_redirection.h
    • chrome/chrome_cleaner/os/scoped_service_handle.cc
    • chrome/chrome_cleaner/os/scoped_service_handle.h
    • chrome/chrome_cleaner/os/secure_dll_loading.cc
    • chrome/chrome_cleaner/os/secure_dll_loading.h
    • chrome/chrome_cleaner/os/shutdown_watchdog.cc
    • chrome/chrome_cleaner/os/shutdown_watchdog.h
    • chrome/chrome_cleaner/os/system_util.cc
    • chrome/chrome_cleaner/os/system_util.h
    • chrome/chrome_cleaner/os/system_util_cleaner.cc
    • chrome/chrome_cleaner/os/system_util_cleaner.h
    • chrome/chrome_cleaner/os/task_scheduler.cc
    • chrome/chrome_cleaner/os/task_scheduler.h
    • chrome/chrome_cleaner/os/whitelisted_directory.cc
    • chrome/chrome_cleaner/os/whitelisted_directory.h
    • chrome/chrome_cleaner/test/BUILD.gn
    • chrome/chrome_cleaner/test/test_branding.h
  23. Reland "Ignore Intent filters with wildcard hosts when handling links."

    Changed by huangxueqingohnoyoudont@xiaomi.com
    Changed at Wednesday, 11-Jul-18 14:34:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7f160bf8df7dca9946d76ecc4ac6fddf670e9d2f

    Comments

    Reland "Ignore Intent filters with wildcard hosts when handling links."
    
    This is a reland of 6d48958d7cd5f2d958a846e35d410f4ed5b85934
    
    Don't check acceptable scheme links since UrlUtilities.isAcceptedScheme()
    was native function, libchrome.so had not loaded when handle intent.
    
    Original change's description:
    > Ignore Intent filters with wildcard hosts when handling links.
    >
    > If the Android device has a package installed that declares
    > an Intent filter with `android:host="*"`, Chrome will launch
    > th
    ...skip...
    romium.org>
    > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#564487}
    
    Bug: 841133
    Change-Id: Id2fd7f7364eb6c70280b29a1f71783a2ee89747b
    Reviewed-on: https://chromium-review.googlesource.com/1096554
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Chris Palmer <palmer@chromium.org>
    Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574155}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappTabDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
  24. Add comments explaining why the cast bots run two test suites unswarmed.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:34:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da3f703063b9200918c1ae426ba4ea68e9ee6555

    Comments

    Add comments explaining why the cast bots run two test suites unswarmed.
    
    Also add a data dep that's necessary (but apparently not sufficient) for
    cast_shell_browsertests to run on swarming.
    
    Bug: 861753, 861843
    Change-Id: Ib10a8589c1349ac70dc4d4358395af6b2867d16b
    Reviewed-on: https://chromium-review.googlesource.com/1133201
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574156}

    Changed files

    • chromecast/browser/BUILD.gn
    • testing/buildbot/test_suite_exceptions.pyl
  25. Move trace events from RenderWidgeHostImpl to CompositorFrameSinkSupport

    Changed by samansohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:38:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33aecd5c74d1fb24e425d47bca19688249b007c8

    Comments

    Move trace events from RenderWidgeHostImpl to CompositorFrameSinkSupport
    
    This will allow us to see these events for all clients and not just
    RenderWidgets. Also will make it work with OOP-D
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Id7a65a0129d27821797f8a46408ece32c580fc3b
    Reviewed-on: https://chromium-review.googlesource.com/1132323
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574157}

    Changed files

    • components/viz/service/frame_sinks/compositor_frame_sink_impl.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
    • components/viz/service/frame_sinks/root_compositor_frame_sink_impl.cc
    • content/browser/renderer_host/render_widget_host_impl.cc
  26. RC: Prevent freezing a tab that is being discarded.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:43:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3c46f398ec5bbb79c35614309b24c9f616394c9

    Comments

    RC: Prevent freezing a tab that is being discarded.
    
    Previously, TabManager::PerformStateTransitions() could be called
    repeatedly and needlessly while a tab is being discarded:
    
    - TabManager::PerformStateTransitions()
      Transitions a LifecycleUnit to PENDING_DISCARD.
    
    - TabManager::PerformStateTransitions()
      Calls CanFreeze() to check if the LifecycleUnit can be frozen.
      CanFreeze() returns true even though the LifecycleUnit is already
      being discarded.
      Calls Freeze(), which transitions the Lifec
    ...skip...
    eatedly until the LifecycleUnit transitions to DISCARDED.
    
    This CL fixes the issue by returning false from CanFreeze() and
    Freeze() for a LifecycleUnit that is being discarded.
    
    Bug: 775644
    Change-Id: I4de25dfe7d569f61d0eef988b217203eeae6f006
    Reviewed-on: https://chromium-review.googlesource.com/1132343
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574158}

    Changed files

    • chrome/browser/resource_coordinator/lifecycle_unit_state.mojom
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_manager_browsertest.cc
  27. [Reland #1] Remove makeKeyAndOrderFront: from WebContentsViewMac::Focus().

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:45:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b73824ff37506f377dc9c9d6789d1db74e6ca5f6

    Comments

    [Reland #1] Remove makeKeyAndOrderFront: from WebContentsViewMac::Focus().
    
    The original CL caused a test failure in
    DetachToBrowserTabDragControllerTest.DetachToOwnWindow. This was due to a bug in
    the test itself, which was generating an incorrect mouse-up event. This CL fixes
    the test to delay generation of the mouse-up event until the new tab dragging
    window has been detached.
    
    > WebContentsView::Focus() is supposed to update the first responder of the
    > Window, not make the window focused. The lat
    ...skip...
    mium-review.googlesource.com/1124772
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573344}
    
    Bug: 859614
    Change-Id: I441a00ad015eb3559718b448fc42f98827beee35
    Reviewed-on: https://chromium-review.googlesource.com/1132106
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574159}

    Changed files

    • chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
    • content/browser/web_contents/web_contents_view_mac.mm
  28. [Zucchini] Fix under/overfow bug in DEX

    Changed by ckitagawaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:55:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c87921042aae8f5fa594f96b33635ef76cfd1028

    Comments

    [Zucchini] Fix under/overfow bug in DEX
    
    This bug was found by the fuzzer. If a large int32 value is present for
    a RelCode32 the result of mapping the location to its target results in
    integer overflow or underflow as found by UBSAN.
    
    In the particular example found by the fuzzer a value of 1292632068 is
    read from the image. The result of |(1292632067 - 1) * kInstrUnitSize|,
    where |kInstrUnitSize = 2| results in an overflow. This is only
    possible for RelCode32 so we only need the fix there. The solution is
    to check for overflow and if it occurs just to skip the reference. In
    a regular DEX file these should be very rare if ever present.
    
    I've tested the updated version on a subset of the corpus with no ill
    effects.
    
    Bug: 862095
    Change-Id: Ifedeeaf1ae7e72a147421ecb917ec1751f4bb8d4
    Reviewed-on: https://chromium-review.googlesource.com/1131225
    Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574160}

    Changed files

    • components/zucchini/disassembler_dex.cc
  29. Remove RecordQueueingTimeClient

    Changed by npmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 14:58:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b8f0454aedcf19ab395c7c4b87a52ea111202a7

    Comments

    Remove RecordQueueingTimeClient
    
    Bug: 832680, 830882
    Change-Id: I7fc5145f1b1ce9fee9bff6470cc55cda578e2c64
    Reviewed-on: https://chromium-review.googlesource.com/1127259
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574161}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
  30. Update features::IsViewsBrowserCocoa() to respect kExperimentalUi.

    Changed by jdonnellyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:05:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9068c1138346a06d48de001a1d70184f96f98d5

    Comments

    Update features::IsViewsBrowserCocoa() to respect kExperimentalUi.
    
    When we added kExperimentalUi, I added it to
    views_mode_controller::IsViewsBrowserCocoa() but I didn't notice
    that there was this other implementation.
    
    The omnibox has a feature that uses features::IsViewsBrowserCocoa() and
    I'd like it to trigger on kExperimentalUi. Let me know if there's some
    reason why we'd expect these to give different answers. There are only a
    handful of places that depend on the features:: version:
    
    https://cs.chromium.org/search/?q=features::IsViewsBrowserCocoa
    
    Bug: 862336
    Change-Id: Ieffe5d13bb08c5c36994cef9ccc850ca4552c2b2
    Reviewed-on: https://chromium-review.googlesource.com/1132430
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574162}

    Changed files

    • chrome/browser/ui/views_mode_controller.cc
    • ui/base/ui_base_features.cc
  31. Update expectations follow wpt roll.

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:08:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b95b32d7dd5eda08b565d07fb597a85503ac3d53

    Comments

    Update expectations follow wpt roll.
    
    Bug: 862588
    Change-Id: Ie8733b4735fc481205c51858da88c82708f3482c
    TBR: blundell@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1133123
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574164}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  32. RC: Mark TabManager::IsTab(InSessionRestore|RestoredInForeground) as static.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:07:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7cb77851800b7bc200649ca2ca458c4dc0e58ee

    Comments

    RC: Mark TabManager::IsTab(InSessionRestore|RestoredInForeground) as static.
    
    These methods don't access member variables, so they can easily be
    made static. Making these methods static will avoid having to initialize
    TabManager and its dependencies in a bunch of tests.
    
    Bug: 775644
    Change-Id: I2ef567c855e34e234faad569126e752460cd2418
    Reviewed-on: https://chromium-review.googlesource.com/1132094
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574163}

    Changed files

    • chrome/browser/page_load_metrics/observers/session_restore_page_load_metrics_observer.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
  33. RC: Do not initialize TabManager in ChromeUnitTestSuite.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:12:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f455e576ca535f0d008db8de8cc3e3147646e10a

    Comments

    RC: Do not initialize TabManager in ChromeUnitTestSuite.
    
    This CL removes the initialization of TabManager by ChromeUnitTestSuite
    before every Chrome unit test run. This will make it easier to
    initialize metrics::DesktopSessionDurationTracker before TabManager in
    tests that need to verify that Chrome usage (instead of wall time) is
    used for tab lifecycle state transitions.
    
    Bug: 775644
    Change-Id: I01d05579964822c87ebc515cafdd25e08fdab661
    Reviewed-on: https://chromium-review.googlesource.com/1132121
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574165}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api_unittest.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source_unittest.cc
    • chrome/test/base/chrome_unit_test_suite.cc
  34. [AF] Use vertical padding from the layout provider in the AF dropdown

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:14:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8713c084c2bc7b33101c61b33e6d7ae14f388e7a

    Comments

    [AF] Use vertical padding from the layout provider in the AF dropdown
    
    The new value is consistent across platforms and is according to
    MD2 spec.
    
    Bug: 860273
    Change-Id: I4b1f28a8f063f08fe99865580f5ac7085d8c27d6
    Reviewed-on: https://chromium-review.googlesource.com/1131680
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574166}

    Changed files

    • chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
  35. [APPS] Add content security policy to the ChromeOS video player app.

    Changed by dbertoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:16:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cd62293b3cca951905963157dacf832c4b2dcd55

    Comments

    [APPS] Add content security policy to the ChromeOS video player app.
    
    The Video Player app has a test, VideoPlayerBrowserTest.OpenSingleVideoOnDrive, that loads a script from ui/file_manager/integration_tests. This script would normally be blocked by the platform app's CSP. Update the app to use an explicit CSP allowing the extension's resource.
    
    Bug: 861815
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Idf10b0eea4e284ea4c3f0c624dc05c5a340fc4ed
    Reviewed-on: https://chromium-review.googlesource.com/1132314
    Commit-Queue: David Bertoni <dbertoni@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574167}

    Changed files

    • ui/file_manager/video_player/manifest.json
  36. Split ContentMain start and ServiceManager Start.

    Changed by hanxiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 15:25:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1105c68d4ac769d98f7dfd1e6303ea778fe1a6b

    Comments

    Split ContentMain start and ServiceManager Start.
    
    With "allow-start-service-manager-only" flag, we can start the service
    manager without starting the remaining parts of the browser,
    particularly the browser main loop. Later, we could start the full
    browser with the service manager running. Currently, both code path go
    through service_manager::main(). Therefore, we need to avoid calling the
    initialization in service_manager::main() multiple times.
    
    In this CL:
    1. service_manager::main() checks its sta
    ...skip...
    hether initialization should be called.
    2. Plumbs the start-service-manager-only flag to the ContentMainRunner
       who starts the browser main loop.
    
    This CL impacts Android only for now. It follows up CL:
     https://crrev.com/c/1093303.
    
    BUG=854209, 846846
    
    Change-Id: I7fcfb804ce7f3065da7df12947674344fe2f56d6
    Reviewed-on: https://chromium-review.googlesource.com/1114077
    Commit-Queue: Xi Han <hanxi@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574169}

    Changed files

    • content/app/android/content_main.cc
    • content/app/content_main_runner_impl.cc
    • content/app/content_main_runner_impl.h
    • content/app/content_service_manager_main_delegate.cc
    • content/app/content_service_manager_main_delegate.h
    • content/public/app/content_main_runner.h
    • services/service_manager/embedder/main.cc
  37. content: Remove web_frame_utils.*.

    Changed by jbromanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:19:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 57988b5caa17cf9135c5f0d09b4c5c343788aa86

    Comments

    content: Remove web_frame_utils.*.
    
    They are unused.
    
    Change-Id: I5857cac266ddbe296188490817edc1aeb70a45d6
    Reviewed-on: https://chromium-review.googlesource.com/1132294
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574168}

    Changed files

    • content/renderer/BUILD.gn
    • content/renderer/render_frame_impl.cc
    • content/renderer/web_frame_utils.cc
    • content/renderer/web_frame_utils.h
  38. Reland "Use retargeted start point when starting composited transitions."

    Changed by flackrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:25:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7af4e4c6f0e60ee19e76add9bd5fc2d936d731bb

    Comments

    Reland "Use retargeted start point when starting composited transitions."
    
    This reverts commit 426a53b7a3cf88a3c24a61d14346a6815ee2b2d4.
    
    Original review at
    https://chromium-review.googlesource.com/c/chromium/src/+/1126519
    
    TBR=majidvp@chromium.org
    
    Bug: 853698
    Change-Id: I8dce9db88ee4af68d5cf93e89ac15963f39f6da0
    Reviewed-on: https://chromium-review.googlesource.com/1133125
    Commit-Queue: Robert Flack <flackr@chromium.org>
    Reviewed-by: Robert Flack <flackr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574170}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/animation/css/css_animations.cc
    • third_party/blink/renderer/core/animation/css/css_animations_test.cc
  39. Roll src/third_party/perfetto 8049055c4260..dc44083eeb40 (1 commits)

    Changed by perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 15:33:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f83eec064d9eb8fa8d753e823f45088031a5cf86

    Comments

    Roll src/third_party/perfetto 8049055c4260..dc44083eeb40 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/8049055c4260..dc44083eeb40
    
    
    git log 8049055c4260..dc44083eeb40 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 taylori@google.com trace_processor: Handling of sqlite string conversion
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@dc44083eeb40
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Documentation for t
    ...skip...
    , please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:80416541
    TBR=perfetto-bugs@google.com
    
    Change-Id: I764b09a155c719ce24ea80ac2f765c3ca354c4fb
    Reviewed-on: https://chromium-review.googlesource.com/1133339
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574171}

    Changed files

    • DEPS
  40. VR: Fix autofill when clicking backspace

    Changed by acondorohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:35:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 44a3d7db77fb25ae25f79477ec427eb23fd0f300

    Comments

    VR: Fix autofill when clicking backspace
    
    This CL ensures that a backspace is threated as a user gesture, so that
    it causes the autofill popups to refresh.
    
    Bug: 839518
    Change-Id: Iaca3206c5da2b7ab35271bbeeb85b77c6d27bc09
    Reviewed-on: https://chromium-review.googlesource.com/1130104
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574172}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrInputConnection.java
  41. Web Locks API: Enable in stable

    Changed by jsbellohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:35:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 37ca2d0776f9d68ed84a596fe525973a31ff6040

    Comments

    Web Locks API: Enable in stable
    
    Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/e2fg_-Ha-AE/discussion
    
    Chrome Status Entry: https://www.chromestatus.com/feature/5712361335816192
    
    Bug: 161072,862455
    Change-Id: Ibdab33ae6dabe97b9f1fffeed413c09690e56bea
    Reviewed-on: https://chromium-review.googlesource.com/1132384
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Reviewed-by: Victor Costan <pwnall@chromium.org>
    Commit-Queue: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574173}

    Changed files

    • third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
    • third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
    • third_party/blink/renderer/modules/locks/lock.idl
    • third_party/blink/renderer/modules/locks/lock_manager.idl
    • third_party/blink/renderer/modules/locks/navigator_locks.idl
    • third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  42. Reorganize build file to support component build for cronet non-test targets

    Changed by shenghuaiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 15:45:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bb4ead0d830ceaf5362f074bc9a41c9cbb4ea9b

    Comments

    Reorganize build file to support component build for cronet non-test targets
    
    This CL only move only move some component build related targets into a
    condition check without changing the config in the targets.
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
    Change-Id: I9d32580da7b156e803b804f0179766e23373f842
    Reviewed-on: https://chromium-review.googlesource.com/1122145
    Reviewed-by: Misha Efimov <mef@chromium.org>
    Commit-Queue: Shenghuai Ji <shenghuai@google.com>
    Cr-Commit-Position: refs/heads/master@{#574174}

    Changed files

    • components/cronet/android/BUILD.gn
  43. [auto] Update FlagExpectations for LayoutNG

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:45:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65f08195c99151f6cbb50b69ac98b2a5a2d0d8ff

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    7708 7710 7714 7718 7725 7731 7736 7737 7748 7753 7766 7768
    7779 7787 7789 7795 7800
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I761ca3f56c837bced01e481537c996cbe4c3ad7c
    Reviewed-on: https://chromium-review.googlesource.com/1129600
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574175}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  44. Picture-in-Picture: disabling flaky tests while origin is investigated.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:49:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4e73dbe75e32793f9eee2fd0a6ec08a50792d0e8

    Comments

    Picture-in-Picture: disabling flaky tests while origin is investigated.
    
    Bug: 862505
    Change-Id: I1bcb2019be64dbb91081e1f8d607aca4cb0fbdc5
    TBR: apacible@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1133306
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574176}

    Changed files

    • chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
  45. Remove unused WebVR autopresent flag.

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:50:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c83673173700b749dba215a1572cd6d3edd1c986

    Comments

    Remove unused WebVR autopresent flag.
    
    Bug: 824487
    Change-Id: I52782aed08ad8990585cccda751ddf42a61b9dbd
    Reviewed-on: https://chromium-review.googlesource.com/1128175
    Reviewed-by: Christopher Grant <cjgrant@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574178}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
    • chrome/browser/about_flags.cc
    • chrome/browser/android/chrome_feature_list.cc
    • chrome/browser/android/chrome_feature_list.h
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
  46. Don't show the IME mode icon in UnifiedSystemTray when the IME mode icon on shelf bar is activated.

    Changed by shuchenohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 15:49:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3555a04cf6f02a888a7bb8d83fbb6e6aed3d12e

    Comments

    Don't show the IME mode icon in UnifiedSystemTray when the IME mode icon on shelf bar is activated.
    
    Bug: 861875
    Change-Id: Ie6d0976b1e71a637b12c330323b876bfcb95cc27
    Reviewed-on: https://chromium-review.googlesource.com/1130572
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574177}

    Changed files

    • ash/system/unified/ime_mode_view.cc
    • ash/system/unified/ime_mode_view.h
  47. Reland "Migrate //content unit tests off of QuitCurrent*Deprecated()."

    Changed by wezohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:50:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e647e85eeb1eb05d3c6f7bc723cba85267fa1c7

    Comments

    Reland "Migrate //content unit tests off of QuitCurrent*Deprecated()."
    
    This is a reland of 1afbb0e4b7797a74e6713c4a4ab9de045c0db342, tweaking
    the DevToolsManager test to use quit-when-idle, to ensure that timeout
    tasks have all had a chance to run before we quit each RunLoop.
    
    Original change's description:
    > Migrate //content unit tests off of QuitCurrent*Deprecated().
    >
    > Cq-Include-Trybots: luci.chromium.try:linux_mojo
    > Change-Id: If5cf7d3dcda8dc411c6c90de31885dca683354d8
    > Reviewed-on: https://chromium-review.googlesource.com/1130656
    > Reviewed-by: Bo <boliu@chromium.org>
    > Commit-Queue: Wez <wez@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574006}
    
    TBR: boliu
    Change-Id: I97a36101e145457d5ad9f99a4a0b83a55ab62f2d
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/1133178
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574179}

    Changed files

    • content/browser/devtools/devtools_manager_unittest.cc
    • content/browser/loader/mojo_async_resource_handler_unittest.cc
    • content/browser/renderer_host/input/gesture_event_queue_unittest.cc
    • content/browser/renderer_host/input/input_router_impl_unittest.cc
    • content/browser/renderer_host/input/passthrough_touch_event_queue_unittest.cc
    • content/browser/renderer_host/render_widget_host_unittest.cc
  48. Update V8 to version 6.9.348.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 15:55:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b954c230264648522a5e7f96812b174cd74276f9

    Comments

    Update V8 to version 6.9.348.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/8885d8b2..c3ce505d
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tes
    ...skip...
    tional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: Iadfe747543fd01e9c2711b0f9f23c15d43bc17da
    Reviewed-on: https://chromium-review.googlesource.com/1133121
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574180}

    Changed files

    • DEPS
  49. chromeos: renames kMash to kMashDeprecated and kOopAsh to kMash

    Changed by skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 15:55:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 360626addbfc77a51083bf8f05d023e132aa6e76

    Comments

    chromeos: renames kMash to kMashDeprecated and kOopAsh to kMash
    
    This also removes mash_ash_unittests as it's no longer applicable.
    There is a lot of cleanup that can happen, but I'm leaving that for
    future patches in hopes of not making this one too big.
    
    BUG=855767 842365 840391
    TEST=covered by tests
    
    Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb
    Reviewed-on: https://chromium-review.googlesource.com/1131924
    Reviewed-by: James Cook <jamescook@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574181}

    Changed files

    • ash/BUILD.gn
    • ash/README.md
    • ash/accelerators/accelerator_controller.cc
    • ash/accessibility/accessibility_controller.cc
    • ash/accessibility/accessibility_highlight_controller.cc
    • ash/app_list/app_list_controller_impl.cc
    • ash/app_list/views/search_result_answer_card_view.cc
    • ash/ash_service.cc
    • ash/ash_service.h
    • ash/display/display_color_manager.cc
    • ash/display/display_synchronizer.cc
    • ash/display/mirror_window_controller.cc
    • ash/display/window_tree_host_manager.cc
    • ash/drag_drop/drag_drop_controller_unittest.cc
    • ash/host/ash_window_tree_host_platform.cc
    • ash/ime/ime_focus_handler_unittest.cc
    • ash/keyboard/virtual_keyboard_controller.cc
    • ash/keyboard/virtual_keyboard_controller_unittest.cc
    • ash/magnifier/magnification_controller.cc
    • ash/pointer_watcher_adapter_classic_unittest.cc
    • ash/public/cpp/config.h
    • ash/root_window_controller.cc
    • ash/shelf/shelf.cc
    • ash/shelf/shelf_window_watcher.cc
    • ash/shelf/shelf_window_watcher_unittest.cc
    • ash/shell.cc
    • ash/shell_port_mash.cc
    • ash/system/flag_warning/flag_warning_tray_unittest.cc
    • ash/system/network/network_list.cc
    • ash/system/network/tray_network_unittest.cc
    • ash/system/network/wifi_toggle_notification_controller_unittest.cc
    • ash/system/power/power_event_observer.cc
    • ash/system/status_area_widget_unittest.cc
    • ash/system/unified/unified_system_tray_controller_unittest.cc
    • ash/test/ash_test_base.cc
    • ash/test/ash_test_base.h
    • ash/test/ash_test_helper.cc
    • ash/test/ash_test_suite.cc
    • ash/touch/touch_observer_hud_unittest.cc
    • ash/wm/lock_state_controller_unittest.cc
    • ash/wm/non_client_frame_controller_unittest.cc
    • ash/wm/overview/window_selector_unittest.cc
    • ash/wm/splitview/split_view_controller_unittest.cc
    • ash/wm/window_util.cc
    • ash/wm/wm_toplevel_window_event_handler.cc
    • ash/wm/workspace/workspace_layout_manager_unittest.cc
    • chrome/browser/ash_service_registry.cc
    • chrome/utility/mash_service_factory.cc
    • mash/test/mash_test_suite.cc
    • services/ui/demo/mus_demo_unittests.cc
    • services/ui/ws/window_server_test_base.cc
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/filters/BUILD.gn
    • testing/buildbot/filters/mash.ash_unittests.filter
    • testing/buildbot/filters/mash.browser_tests.filter
    • testing/buildbot/test_suites.pyl
    • ui/aura/mus/window_tree_client.cc
    • ui/aura/mus/window_tree_client.h
    • ui/aura/test/aura_test_base.cc
    • ui/aura/test/aura_test_helper.cc
    • ui/aura/test/aura_test_helper.h
    • ui/aura/test/mus/test_window_tree_client_setup.cc
    • ui/aura/test/mus/test_window_tree_client_setup.h
    • ui/aura/test/mus/window_tree_client_private.h
    • ui/aura/test/test_screen.cc
    • ui/base/ui_base_features.cc
    • ui/base/ui_base_features.h
    • ui/views/mus/aura_init.cc
    • ui/views/mus/mus_client.h
    • ui/views/mus/views_mus_test_suite.cc
  50. Roll src/third_party/skia 2229b76258f7..4ec72f7cc745 (1 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 15:56:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb0e1e18caba43ee1c8fa78211d9aac6cb0b5279

    Comments

    Roll src/third_party/skia 2229b76258f7..4ec72f7cc745 (1 commits)
    
    https://skia.googlesource.com/skia.git/+log/2229b76258f7..4ec72f7cc745
    
    
    git log 2229b76258f7..4ec72f7cc745 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 ruiqimao@google.com added skeletal animation support to GPU backend
    
    
    Created with:
      gclient setdep -r src/third_party/skia@4ec72f7cc745
    
    The AutoRoll server is located here: https://autoroll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com
    ...skip...
    ci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: I3835858a733fb33db6c6626cc991633c077ae01c
    Reviewed-on: https://chromium-review.googlesource.com/1133239
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574182}

    Changed files

    • DEPS
  51. Add |id| field to intervention reports.

    Changed by paulmeyerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:01:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 63cff3378eccfcba582f16fdf1f3db5d9108b1c4

    Comments

    Add |id| field to intervention reports.
    
    Every intervention report should have a human-readable id, as specified
    in the Reporting spec.
    
    https://w3c.github.io/reporting/#dom-interventionreportbody-id
    
    Bug: 564071
    Change-Id: I82d1237fe9b45f28691e0772abd6d9995833e1ee
    Reviewed-on: https://chromium-review.googlesource.com/1129469
    Reviewed-by: Nate Chapin <japhet@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Paul Meyer <paulmeyer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574183}

    Changed files

    • third_party/WebKit/LayoutTests/reporting-observer/intervention.html
    • third_party/blink/renderer/core/dom/document.cc
    • third_party/blink/renderer/core/events/touch_event.cc
    • third_party/blink/renderer/core/frame/intervention.cc
    • third_party/blink/renderer/core/frame/intervention.h
    • third_party/blink/renderer/core/frame/intervention_report_body.h
    • third_party/blink/renderer/core/frame/intervention_report_body.idl
    • third_party/blink/renderer/modules/vibration/navigator_vibration.cc
  52. Convert AccountInfo::GetAccountId to a free function

    Changed by sdefresneohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:06:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef561eecb4391df63504961f9ed37d2daa7f9344

    Comments

    Convert AccountInfo::GetAccountId to a free function
    
    Converting the method to a free function allows to decouple
    AccountInfo from AccountId, eventually allowing to move it
    to services/identity/public/cpp or even converting to the
    mojo structure.
    
    Bug: none
    Change-Id: I020dad29ae286cd9da23c819ce0f32c57da3fb8c
    Reviewed-on: https://chromium-review.googlesource.com/1124453
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574184}

    Changed files

    • chrome/browser/android/signin/signin_manager_android.cc
    • chrome/browser/policy/cloud/user_policy_signin_service.cc
    • chrome/browser/policy/cloud/user_policy_signin_service_base.cc
    • chrome/browser/ui/webui/signin/dice_turn_sync_on_helper.cc
    • components/signin/core/browser/account_info.cc
    • components/signin/core/browser/account_info.h
  53. [Autofill]: Add AutofillProfileEnabled preference.

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:12:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 009cee5a893563d9ba27a73467f1b92f10c93b35

    Comments

    [Autofill]: Add AutofillProfileEnabled preference.
    
    This creates and uses AutofillProfileEnabled flag to disable profile autofill.
    This affects:
    - PersonalDatamanager
    - FormDataImporter
    - AutofillManager
    
    AutofillProfileEnabled will be added as a policy as a follow up CL.
    
    Bug: 860526
    Change-Id: Ied9a29c9ada7b7e564f1ba19fa738854fab7b17e
    Reviewed-on: https://chromium-review.googlesource.com/1127344
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574186}

    Changed files

    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • components/autofill/core/browser/autofill_manager.cc
    • components/autofill/core/browser/autofill_manager.h
    • components/autofill/core/browser/autofill_manager_unittest.cc
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/personal_data_manager.cc
    • components/autofill/core/browser/personal_data_manager.h
    • components/autofill/core/browser/personal_data_manager_unittest.cc
    • components/autofill/core/browser/test_autofill_manager.cc
    • components/autofill/core/browser/test_autofill_manager.h
    • components/autofill/core/browser/test_personal_data_manager.cc
    • components/autofill/core/browser/test_personal_data_manager.h
    • components/autofill/core/common/autofill_pref_names.cc
    • components/autofill/core/common/autofill_pref_names.h
    • components/browser_sync/profile_sync_service_autofill_unittest.cc
  54. Remove script handlers on shutdown.

    Changed by jzwohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:11:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 668e5f3b62ed377621cf08ae5e7b1383b67ed39d

    Comments

    Remove script handlers on shutdown.
    
    This avoids a DCHECK.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: If764659a3b0d12955e79d155f1408e44db10277d
    Reviewed-on: https://chromium-review.googlesource.com/1129962
    Commit-Queue: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574185}

    Changed files

    • ios/web_view/internal/cwv_web_view.mm
  55. MacViews: Don't draw blank windows after de-miniturize

    Changed by ccameronohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:21:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bdd9c892c625154a24629b59c2eb117b4c41b538

    Comments

    MacViews: Don't draw blank windows after de-miniturize
    
    Whenever the ui::Layer for BridgedNativeWidgetMac is hidden, also lock
    the ui::Compositor ("lock" in this sense means "disable drawing new
    frames").
    
    This ensure that we won't draw any blank frames (which is what would
    result in a blank frame).
    
    Bug: 712244
    Change-Id: Ia8c17742e6a48190b9a3aead6443102a585d1f7d
    Reviewed-on: https://chromium-review.googlesource.com/1129320
    Commit-Queue: ccameron <ccameron@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574187}

    Changed files

    • ui/views/cocoa/bridged_native_widget.h
    • ui/views/cocoa/bridged_native_widget.mm
  56. Import wpt@4f149eb372f0fb9519512f2708d0571a9dc2e4b1

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:21:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4feb130aa420b47c8ddce50d88380ea5d117d1a9

    Comments

    Import wpt@4f149eb372f0fb9519512f2708d0571a9dc2e4b1
    
    Using wpt-import in Chromium 0ee8d2d8fa797bf1da0d7909ec2a05b0d63e1620.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21175
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectatio
    ...skip...
    ://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    meade@chromium.org:
      external/wpt/web-animations
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I711be3ceae60227e3a91d1dd3b6f2202d6ee4fcd
    Reviewed-on: https://chromium-review.googlesource.com/1133122
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574188}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/css/css-images/img-orient-012.xht
    • third_party/WebKit/LayoutTests/external/wpt/css/css-images/parsing/image-orientation-invalid.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-images/parsing/image-orientation-valid-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/css-images/parsing/image-orientation-valid.html
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/property-list.js
  57. Migrate Form activity observer to autofill::FormActivityObserver

    Changed by olivierrobinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:32:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6b0b752677aa0eb79f518a3b8af2a40db35f0c45

    Comments

    Migrate Form activity observer to autofill::FormActivityObserver
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ib146d46a7b50ed06ee26434fdcbd7166672141fa
    Reviewed-on: https://chromium-review.googlesource.com/1118549
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574189}

    Changed files

    • components/autofill/ios/browser/BUILD.gn
    • components/autofill/ios/browser/autofill_agent.mm
    • ios/chrome/browser/autofill/BUILD.gn
    • ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
    • ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
    • ios/chrome/browser/passwords/BUILD.gn
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/web_view/BUILD.gn
    • ios/web_view/internal/autofill/cwv_autofill_controller.mm
  58. Roll src/third_party/pdfium b1a4db5551ca..e7e454da8e38 (3 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 16:40:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 46629048c53ced6353eb92800761deb10a20ffbc

    Comments

    Roll src/third_party/pdfium b1a4db5551ca..e7e454da8e38 (3 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b1a4db5551ca..e7e454da8e38
    
    
    git log b1a4db5551ca..e7e454da8e38 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 art-snake@yandex-team.ru Do not store cross ref v5 obj within document.
    2018-07-11 vmiklos@collabora.co.uk Add FPDFFormObj_CountObjects() API
    2018-07-11 thestig@chromium.org Check GetObjDefnID() in various JS functions.
    
    
    Created with:
      gclient setdep -r src/third_pa
    ...skip...
    n the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:810768,chromium:862059
    TBR=dsinclair@chromium.org
    
    Change-Id: I5cdecfe75e8069f179eca07f9eb873cfa875c756
    Reviewed-on: https://chromium-review.googlesource.com/1133338
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574190}

    Changed files

    • DEPS
  59. [Media Controls] Fix integer cast

    Changed by beccahughesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:41:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b838150fcff025c61d9b6ed54d0f241c1ff24101

    Comments

    [Media Controls] Fix integer cast
    
    MediaControlSliderElement is causing a ClusterFuzz error
    because we are casting a float to an int that could
    overflow.
    
    BUG=852364
    
    Change-Id: Ic454a79ebf6ef8d40f85e054a70cb87030c6db9c
    Reviewed-on: https://chromium-review.googlesource.com/1131921
    Commit-Queue: Becca Hughes <beccahughes@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574191}

    Changed files

    • third_party/blink/renderer/modules/media_controls/elements/media_control_slider_element.cc
  60. Position trailing NTB separator correctly for RTL mode.

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:45:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2134df8043bd8e2975dde20dae6963bc2ae5853

    Comments

    Position trailing NTB separator correctly for RTL mode.
    
    Also moves the separator to have 8 DIP between its trailing edge and the NTB,
    instead of between its leading edge and the NTB.  This parallels how it's
    positioned when the tabs are drawing it in the other two NTB positions.
    
    Bug: none
    Test: Run with --force-ui-direction=rtl --new-tab-button-position=trailing and ensure a separator is visible next to the new tab button
    Change-Id: I7e58485626c5ebab5dd477cefada5825479bdcb4
    Reviewed-on: https://chromium-review.googlesource.com/1132484
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574195}

    Changed files

    • chrome/browser/ui/views/tabs/tab_strip.cc
  61. Correct pyjson5's license file location.

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Wednesday, 11-Jul-18 16:42:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9d3ec8dcf79a6914308ecd879a804cdd0c19bf64

    Comments

    Correct pyjson5's license file location.
    
    This makes //tools/license.py stop complaining that this third-party
    component is missing a copyright file.
    
    Change-Id: Iad66f77a7881945c2048c13f2293a6377146d235
    Reviewed-on: https://chromium-review.googlesource.com/1133005
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
    Cr-Commit-Position: refs/heads/master@{#574192}

    Changed files

    • third_party/pyjson5/README.chromium
  62. VR: Wait until orientation changes to remove black overlay.

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:43:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07cb7d14c3be4b924e10570b71c3da018f831271

    Comments

    VR: Wait until orientation changes to remove black overlay.
    
    This changes removes the black overlay with an animation after the
    orientation change is completed and the GvrLayout is the correct size.
    
    Bug: 860764
    Change-Id: I8e0f1a0bc3779905d6259ecfcae0e487341f8ff6
    Reviewed-on: https://chromium-review.googlesource.com/1132315
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574193}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/TransitionUtils.java
  63. Prevent Javascript URLs from executing on chrome-extension scheme pages.

    Changed by dbertoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d9d19a09dd6d90ab023d4d83e7bf6bc9d5731f

    Comments

    Prevent Javascript URLs from executing on chrome-extension scheme pages.
    
    Bug: 836412
    Change-Id: Iace2aff72b8bfe065ef270593bf9c47d02fd62fd
    Reviewed-on: https://chromium-review.googlesource.com/1116065
    Commit-Queue: David Bertoni <dbertoni@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574196}

    Changed files

    • chrome/browser/extensions/extension_bookmarklet_browsertest.cc
    • chrome/test/BUILD.gn
    • extensions/renderer/dispatcher.cc
  64. Supersize: Adds small quality of life improvements

    Changed by tigeroohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 16:45:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e8515dd6e122df37a478bd24ae342b2fb6d1da9

    Comments

    Supersize: Adds small quality of life improvements
    
    Changes so far:
    - Improved reading of a node in a screen reader
    - Added checkboxes and radios into tab flow
    - Settings starts expanded instead of hidden
    - Arrow immediately rotates when expanding a row
    - Added "Select all" and "Select none" buttons for types
    - Query parameters equal to the defaults are hidden
    - Types are shown as a single string in the query
    - .bss is no longer checked by default
    - Fetch requests are cancelled when a new one is started
    
    Demo:
    https://notwoods.github.io/chrome-supersize-reports/monochrome-2018-07-10/
    
    Bug: 847599
    Change-Id: I366ff2746a331e846dc0c683757a2a5bfa43d96a
    Reviewed-on: https://chromium-review.googlesource.com/1132132
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574194}

    Changed files

    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/infocard.css
    • tools/binary_size/libsupersize/template_tree_view/options.css
    • tools/binary_size/libsupersize/template_tree_view/shared.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  65. Remove TabStrip::GetNewTabButtonWidth().

    Changed by pkastingohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:46:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9aae24b91783921a443e1b1a43e70ed1df9eeb37

    Comments

    Remove TabStrip::GetNewTabButtonWidth().
    
    This is unnecessary, since the new tab button width doesn't change, and is
    stored in |new_tab_button_bounds_|.  We can simply read that directly.
    
    Bug: none
    Change-Id: I7bc1305f3e366b07f78a79cfa3e2b4cf340c792f
    Reviewed-on: https://chromium-review.googlesource.com/1132559
    Reviewed-by: Allen Bauer <kylixrd@chromium.org>
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574197}

    Changed files

    • chrome/browser/ui/views/tabs/tab_strip.cc
    • chrome/browser/ui/views/tabs/tab_strip.h
  66. Convert ChromeOS easy_unlock/ to use IdentityManager

    Changed by chcunninghamohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 16:52:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33156fc858e60d53dcb8fcf3adba344288a3ee05

    Comments

    Convert ChromeOS easy_unlock/ to use IdentityManager
    
    Use new IdentityManager and utils. SignInManager is deprecated.
    Also cleans up some stale includes.
    
    Bug: 797952
    Change-Id: I4ee9dc7f480319dff277ddf71e1776f081082ccb
    Reviewed-on: https://chromium-review.googlesource.com/1131675
    Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
    Reviewed-by: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574198}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_unittest_chromeos.cc
  67. Handle backpress in the download manager

    Changed by amalovaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:06:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 19ab2ed8fe6aca01bea0571b6a0ffb4a4357dde2

    Comments

    Handle backpress in the download manager
    
    Bug: 859125
    Change-Id: Ib8e85897d5059ec421ed9ddc63921a6005b37c9d
    Reviewed-on: https://chromium-review.googlesource.com/1133175
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Peter Conn <peconn@chromium.org>
    Commit-Queue: Anna Malova <amalova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574203}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerUi.java
  68. Add a blinking braille cursor

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:03:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bc72552559617e32254cfa9db6457fda9bfcf306

    Comments

    Add a blinking braille cursor
    
    Bug: 851654
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ic3ef45567f53eef44a92e0adb51ef592a9e5bfe2
    Reviewed-on: https://chromium-review.googlesource.com/1132117
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574199}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js
    • chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager_test.unitjs
    • chrome/browser/resources/chromeos/chromevox/braille/pan_strategy.js
  69. views: reformat constrained_web_dialog_delegate_view.cc

    Changed by skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:04:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e01b261e102c173c40d7c459bf70a8a61b4005

    Comments

    views: reformat constrained_web_dialog_delegate_view.cc
    
    Indentation was wrong in this file.
    
    BUG=none
    TEST=none (only a reformat of code)
    
    Change-Id: Iddb81936e13026c2bbcbfd617837fd9784410043
    Reviewed-on: https://chromium-review.googlesource.com/1133423
    Commit-Queue: Scott Violet <sky@chromium.org>
    Commit-Queue: Michael Wasserman <msw@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574200}

    Changed files

    • chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc
  70. Reland "Add QueueingTimeEstimatorPerfTest"

    Changed by npmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:04:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc2ddab54de08306b065f602a453f903a9df0a29

    Comments

    Reland "Add QueueingTimeEstimatorPerfTest"
    
    This is a reland of 699ed793ea8cdf710127bcbfd7e4cbfcd0366748
    
    Original change's description:
    > Add QueueingTimeEstimatorPerfTest
    > 
    > This CL adds a microbenchmark for QueueingTimeEstimator that runs lots
    > of tasks and computes ExpectedQueueingTime on them. The test is DISABLED
    > as it takes 6 seconds to run and will only be used manually to compute
    > improvements.
    > 
    > Bug: 860246
    > Change-Id: I50d5471ed4628bf144b3da35b66d597ce6eac3c3
    > Reviewed-on: https:
    ...skip...
    imin@chromium.org>
    > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573012}
    
    Bug: 860246
    Change-Id: I9828081556326ae76f81b48ef65ad29812e65ad2
    Reviewed-on: https://chromium-review.googlesource.com/1127962
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574201}

    Changed files

    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator_unittest.cc
    • third_party/blink/renderer/platform/scheduler/test/DEPS
    • third_party/blink/renderer/platform/scheduler/test/queueing_time_estimator_perf_test.cc
    • third_party/blink/renderer/platform/scheduler/test/test_queueing_time_estimator_client.cc
    • third_party/blink/renderer/platform/scheduler/test/test_queueing_time_estimator_client.h
  71. Convert storage/browser/fileapi/quota to use url::Origin

    Changed by xunran.dingohnoyoudont@samsung.com
    Changed at Wednesday, 11-Jul-18 17:05:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3345842e3e3249d01482375a4276ed48b7ed00b1

    Comments

    Convert storage/browser/fileapi/quota to use url::Origin
    
    Update the code directory to use the dedicated Origin type instead of URL.
    The next step would be storage/browser/fileapi.
    
    Bug: 598424
    Change-Id: I5dab8c9b7c097eb163d7565149b577f73850381d
    Reviewed-on: https://chromium-review.googlesource.com/1128796
    Reviewed-by: Joshua Bell <jsbell@chromium.org>
    Reviewed-by: Bill Budge <bbudge@chromium.org>
    Commit-Queue: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574202}

    Changed files

    • content/browser/renderer_host/pepper/quota_reservation_unittest.cc
    • storage/browser/fileapi/quota/quota_backend_impl.cc
    • storage/browser/fileapi/quota/quota_backend_impl.h
    • storage/browser/fileapi/quota/quota_backend_impl_unittest.cc
    • storage/browser/fileapi/quota/quota_reservation.cc
    • storage/browser/fileapi/quota/quota_reservation.h
    • storage/browser/fileapi/quota/quota_reservation_buffer.cc
    • storage/browser/fileapi/quota/quota_reservation_buffer.h
    • storage/browser/fileapi/quota/quota_reservation_manager.cc
    • storage/browser/fileapi/quota/quota_reservation_manager.h
    • storage/browser/fileapi/quota/quota_reservation_manager_unittest.cc
    • storage/browser/fileapi/sandbox_file_system_backend_delegate.cc
  72. Add UUID for BaseAudioContext

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:07:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0f728d06389b90c200488eb8a83dfa76d29aaee5

    Comments

    Add UUID for BaseAudioContext
    
    For the future DevTool integration, we need a unique identifier for
    each BaseAudioContext. This CL generate a UUID for BaseAudioContext at
    its construction time.
    
    Bug: 862411
    Change-Id: I2dda45611af21d57820e1539b22091deb8ddf443
    Reviewed-on: https://chromium-review.googlesource.com/1132419
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574204}

    Changed files

    • third_party/blink/renderer/modules/webaudio/base_audio_context.cc
    • third_party/blink/renderer/modules/webaudio/base_audio_context.h
  73. Form controls whose |ValueMode| is not |kValue| should not expose an accessible value

    Changed by nektarohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:09:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c76ae6c5b4a68c0f34160c7a334de810bb1236d1

    Comments

    Form controls whose |ValueMode| is not |kValue| should not expose an accessible value
    
    The user facing bug is that NVDA speaks the names of buttons twice.
    
    According to the HTML spec, there are three types of input form controls when it comes to how they expose their value attribute:
    1. Expose the value attribute itself
    2. Expose their checked state and
    3. Expose their contents converted to text after sanitization, e.g. a date converted to a string.
    
    Only the third type should be exposed to accessibil
    ...skip...
    ttribute would make NVDA speak the name of the control twice.
    The second type exposes their checked state using other accessibility attributes, e.g. "checkable=true".
    
    R=aleventhal@chromium.org
    
    Tested: manually with NVDA, browser tests
    Change-Id: I64579a15973fbfa8058e341d7ad32b2f30113dd3
    Reviewed-on: https://chromium-review.googlesource.com/1121526
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574205}

    Changed files

    • content/browser/accessibility/accessibility_tree_formatter.cc
    • content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • content/test/data/accessibility/aria/aria-autocomplete-expected-blink.txt
    • content/test/data/accessibility/aria/aria-autocomplete-expected-win.txt
    • content/test/data/accessibility/aria/aria-illegal-val-expected-win.txt
    • content/test/data/accessibility/aria/aria-invalid-expected-blink.txt
    • content/test/data/accessibility/aria/aria-invalid-expected-win.txt
    • content/test/data/accessibility/aria/aria-orientation-expected-win.txt
    • content/test/data/accessibility/aria/aria-progressbar.html
    • content/test/data/accessibility/aria/aria-readonly-expected-blink.txt
    • content/test/data/accessibility/aria/aria-readonly-expected-win.txt
    • content/test/data/accessibility/aria/aria-scrollbar-expected-win.txt
    • content/test/data/accessibility/aria/aria-scrollbar.html
    • content/test/data/accessibility/aria/aria-searchbox-expected-blink.txt
    • content/test/data/accessibility/aria/aria-searchbox-with-rich-text.html
    • content/test/data/accessibility/aria/aria-searchbox.html
    • content/test/data/accessibility/aria/aria-separator-expected-win.txt
    • content/test/data/accessibility/aria/aria-slider-expected-win.txt
    • content/test/data/accessibility/aria/aria-slider.html
    • content/test/data/accessibility/aria/aria-spinbutton-expected-win.txt
    • content/test/data/accessibility/aria/aria-spinbutton.html
    • content/test/data/accessibility/aria/aria-textbox-expected-blink.txt
    • content/test/data/accessibility/aria/aria-textbox-with-rich-text.html
    • content/test/data/accessibility/aria/aria-textbox.html
    • content/test/data/accessibility/aria/aria-valuemax-expected-win.txt
    • content/test/data/accessibility/aria/aria-valuemin-expected-win.txt
    • content/test/data/accessibility/aria/aria-valuenow-expected-win.txt
    • content/test/data/accessibility/aria/aria-valuetext-expected-blink.txt
    • content/test/data/accessibility/aria/aria-valuetext-expected-win.txt
    • content/test/data/accessibility/css/color-expected-blink.txt
    • content/test/data/accessibility/css/color-expected-win.txt
    • content/test/data/accessibility/css/font-style-expected-blink.txt
    • content/test/data/accessibility/css/font-style-expected-win.txt
    • content/test/data/accessibility/html/action-verbs-expected-blink.txt
    • content/test/data/accessibility/html/action-verbs-expected-win.txt
    • content/test/data/accessibility/html/actions-expected-blink.txt
    • content/test/data/accessibility/html/contenteditable-descendants-expected-blink.txt
    • content/test/data/accessibility/html/contenteditable-descendants-expected-win.txt
    • content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-blink.txt
    • content/test/data/accessibility/html/contenteditable-descendants-with-selection-expected-win.txt
    • content/test/data/accessibility/html/contenteditable-descendants.html
    • content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-blink.txt
    • content/test/data/accessibility/html/contenteditable-with-embedded-contenteditables-expected-win.txt
    • content/test/data/accessibility/html/input-button-in-menu-expected-win.txt
    • content/test/data/accessibility/html/input-button-in-menu.html
    • content/test/data/accessibility/html/input-button-mac-expected.txt
    • content/test/data/accessibility/html/input-button.html
    • content/test/data/accessibility/html/input-checkbox-expected-mac.txt
    • content/test/data/accessibility/html/input-checkbox.html
    • content/test/data/accessibility/html/input-color-expected-blink.txt
    • content/test/data/accessibility/html/input-color.html
    • content/test/data/accessibility/html/input-date-expected-blink.txt
    • content/test/data/accessibility/html/input-date-expected-win.txt
    • content/test/data/accessibility/html/input-datetime-expected-blink.txt
    • content/test/data/accessibility/html/input-datetime-expected-win.txt
    • content/test/data/accessibility/html/input-datetime-local-expected-win.txt
    • content/test/data/accessibility/html/input-datetime-local.html
    • content/test/data/accessibility/html/input-email.html
    • content/test/data/accessibility/html/input-file-expected-blink.txt
    • content/test/data/accessibility/html/input-file-expected-win.txt
    • content/test/data/accessibility/html/input-month-expected-blink.txt
    • content/test/data/accessibility/html/input-month.html
    • content/test/data/accessibility/html/input-number.html
    • content/test/data/accessibility/html/input-password.html
    • content/test/data/accessibility/html/input-radio-expected-win.txt
    • content/test/data/accessibility/html/input-range-expected-win.txt
    • content/test/data/accessibility/html/input-range.html
    • content/test/data/accessibility/html/input-search-expected-win.txt
    • content/test/data/accessibility/html/input-tel.html
    • content/test/data/accessibility/html/input-text-read-only.html
    • content/test/data/accessibility/html/input-text-value-changed-expected-blink.txt
    • content/test/data/accessibility/html/input-text-value-expected-blink.txt
    • content/test/data/accessibility/html/input-text-value-expected-win.txt
    • content/test/data/accessibility/html/input-text-with-selection-expected-win.txt
    • content/test/data/accessibility/html/input-text.html
    • content/test/data/accessibility/html/input-time-expected-blink.txt
    • content/test/data/accessibility/html/input-time-expected-win.txt
    • content/test/data/accessibility/html/input-types-expected-win.txt
    • content/test/data/accessibility/html/input-url-expected-win.txt
    • content/test/data/accessibility/html/input-week-expected-win.txt
    • content/test/data/accessibility/html/input-week.html
    • content/test/data/accessibility/html/meter-expected-win.txt
    • content/test/data/accessibility/html/modal-dialog-closed-expected-blink.txt
    • content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt
    • content/test/data/accessibility/html/progress-expected-win.txt
    • content/test/data/accessibility/html/select-expected-blink.txt
    • content/test/data/accessibility/html/select-expected-win.txt
    • content/test/data/accessibility/html/textarea-expected-blink.txt
    • content/test/data/accessibility/html/textarea-expected-win.txt
    • content/test/data/accessibility/html/textarea-read-only-expected-blink.txt
    • content/test/data/accessibility/html/textarea-read-only-expected-win.txt
    • content/test/data/accessibility/html/textarea-with-selection-expected-blink.txt
    • content/test/data/accessibility/html/textarea-with-selection-expected-win.txt
    • third_party/WebKit/LayoutTests/inspector-protocol/accessibility/accessibility-nameSources-input-buttons-expected.txt
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  74. Remove breakpad from skip_child_includes.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:09:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cd4f7d935e311957a4d0389691bb6e9d5dddad5

    Comments

    Remove breakpad from skip_child_includes.
    
    Change-Id: Idba04cf28ac6ece89f23e9b83005d508b37818c8
    Reviewed-on: https://chromium-review.googlesource.com/1132566
    Reviewed-by: Robert Sesek <rsesek@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574206}

    Changed files

    • DEPS
  75. Extend Weekly Time with ToLocalizedString function

    Changed by adokarohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:14:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38395431788594260f54df2a30634027050914b7

    Comments

    Extend Weekly Time with ToLocalizedString function
    
    Add ToLocalizedString() function to WeeklyTime for later
    use in the UI for DeviceAutoUpdateTimeRestrictions.
    
    BUG=chromium:852860
    TEST=unit tests
    
    Change-Id: I85db9b19a3f1a1b589c26c064c221fe8e2137123
    Reviewed-on: https://chromium-review.googlesource.com/1119392
    Commit-Queue: Adolfo Higueros <adokar@google.com>
    Reviewed-by: Pavol Marko <pmarko@chromium.org>
    Reviewed-by: Sergey Poromov <poromov@chromium.org>
    Reviewed-by: May Lippert <maybelle@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574207}

    Changed files

    • chrome/browser/chromeos/policy/weekly_time/weekly_time.cc
    • chrome/browser/chromeos/policy/weekly_time/weekly_time.h
    • chrome/browser/chromeos/policy/weekly_time/weekly_time_unittest.cc
  76. libaom: defer RTCD header generation to cmake

    Changed by david.barrohnoyoudont@samsung.com
    Changed at Wednesday, 11-Jul-18 17:20:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dd0ef48fe3b260fe6a99b6f1b1b21347b73bf53c

    Comments

    libaom: defer RTCD header generation to cmake
    
    We only need to format the files generated by cmake.
    This causes no change to the current configuration.
    This facilitates upcoming changes to the generator.
    
    Bug: 783519
    Change-Id: If8e51f082881728c46a8ee9924db5d2c3ac13d11
    Reviewed-on: https://chromium-review.googlesource.com/1132267
    Reviewed-by: Johann Koenig <johannkoenig@google.com>
    Commit-Queue: Johann Koenig <johannkoenig@google.com>
    Cr-Commit-Position: refs/heads/master@{#574208}

    Changed files

    • third_party/libaom/cmake_update.sh
  77. [NTP] Increase size of MV icons

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:22:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a9ae38f065149aeff4c20ffabc362ecfa3a2b0ad

    Comments

    [NTP] Increase size of MV icons
    
    - Favicon size increased from 16dp to 24dp.
    - Icon background size increased from 40dp to 48dp.
    
    Bug: 855194
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8a9e9bede375da1b0ffa7050f97a1de1dd1162ac
    Reviewed-on: https://chromium-review.googlesource.com/1132527
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574210}

    Changed files

    • chrome/browser/resources/local_ntp/local_ntp.css
    • chrome/browser/resources/local_ntp/most_visited_single.css
    • chrome/browser/resources/local_ntp/most_visited_single.js
    • chrome/browser/search/ntp_icon_source.cc
  78. Split SSLKeyLogger into an interface and implementation.

    Changed by davidbenohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:24:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd37c178d9dac3e15380ee51092274f34cb3c1a6

    Comments

    Split SSLKeyLogger into an interface and implementation.
    
    Someday in the future, the network service will be sandboxed, at which
    point file access won't be allowed. We still need to deal with the
    SSLClientContext mess but we can do the interface split now. This also
    removes an OS_NACL special-case.
    
    Bug: 838910
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I607f18b26a357de56b13aa2453caa2f40f2ecacb
    Reviewed-on: https://chromium-review.googlesource.com/1128189
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Helen Li <xunjieli@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Commit-Queue: David Benjamin <davidben@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574212}

    Changed files

    • chrome/browser/io_thread.cc
    • components/cronet/ios/cronet_environment.mm
    • components/cronet/url_request_context_config.cc
    • headless/app/headless_shell.cc
    • net/BUILD.gn
    • net/socket/ssl_client_socket.cc
    • net/socket/ssl_client_socket.h
    • net/socket/ssl_client_socket_impl.cc
    • net/socket/ssl_client_socket_impl.h
    • net/ssl/ssl_key_logger.h
    • net/ssl/ssl_key_logger_impl.cc
    • net/ssl/ssl_key_logger_impl.h
  79. Reland "overview: Hide title bars before animating into overview mode."

    Changed by sammiequonohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:21:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f00acd85de088eb905005c5bc0c144361caaa814

    Comments

    Reland "overview: Hide title bars before animating into overview mode."
    
    This is a reland of a663e7fd51488006a133e4115cf306029ea7ee23
    
    The original cl causes some flaky tests with stack trace:
    
    [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread().
    #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace()
    #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace()
    #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage()
    #3 0x7f9b2b5692e8 cc::Singl
    ...skip...
    .org>
    > Reviewed-by: Tao Wu <wutao@chromium.org>
    > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573552}
    
    TBR=oshima@chromium.org
    
    Bug: 843851
    Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc
    Reviewed-on: https://chromium-review.googlesource.com/1131874
    Commit-Queue: Sammie Quon <sammiequon@chromium.org>
    Reviewed-by: Sammie Quon <sammiequon@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574209}

    Changed files

    • ash/system/overview/overview_button_tray_unittest.cc
    • ash/test/ash_test_helper.cc
    • ash/wm/overview/scoped_transform_overview_window.cc
    • ash/wm/overview/scoped_transform_overview_window.h
    • ash/wm/overview/window_selector_item.cc
    • ash/wm/overview/window_selector_item.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
  80. Fix a crash that startForeground is not called after startForegroundService() call

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:28:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0b4e54e9b2f8ba5b3fa2d9a647c11b1bac67d1b

    Comments

    Fix a crash that startForeground is not called after startForegroundService() call
    
    BUG=826998
    
    Change-Id: Ifcd496ae29831730b1a960478ad42eea8246c2ef
    Reviewed-on: https://chromium-review.googlesource.com/1128564
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574215}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
  81. Make font_service a shared service

    Changed by rockotohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:26:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 17833dfe069a885e700d9bf9201aee17ff294868

    Comments

    Make font_service a shared service
    
    It seems unlikely that there's any value in having an isolated instance
    per profile. Make sure any running instance of the service is shared
    by all users.
    
    Bug: 862553
    Change-Id: I56a3894925c15ff0c90e9e02512092754c34be26
    Reviewed-on: https://chromium-review.googlesource.com/1133418
    Reviewed-by: Dominik Röttsches <drott@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574213}

    Changed files

    • components/services/font/manifest.json
  82. Add presubmit for ssl_cert_analysis.asciipb

    Changed by meacerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:30:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb8aa18c8522f5077d1f27ff125e2eb52b8a6fe1

    Comments

    Add presubmit for ssl_cert_analysis.asciipb
    
    Bug: 862446
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iac6b72b49795f49d966476f09c97d0275283b223
    Reviewed-on: https://chromium-review.googlesource.com/1132549
    Reviewed-by: Emily Stark <estark@chromium.org>
    Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574217}

    Changed files

    • chrome/browser/resources/ssl/ssl_error_assistant/PRESUBMIT.py
  83. Streamline WebCore -> SkBlendMode conversion helpers

    Changed by fmalitaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:27:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e3a96d3b8a5c63ebd9b500967b7e9a2ff5a9420

    Comments

    Streamline WebCore -> SkBlendMode conversion helpers
    
    Some of the conversion functions in skia_utils employ explicit look-up
    tables.
    
    Converting to switch statements yields
    
      1) less fragile code (no longer depending on Skia enum values/order)
    
      2) compile-time domain coverage check (-Wswitch), lets us drop the
         explicit checks + error logging.
    
      3) more readable code, aligned with the SkBlendMode -> WebCore
         conversion functions in the same CU.
    
      4) equivalent perf (modern compilers should turn these into look-up/jump
         tables).
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I527d47f6eb2f8e7372fb054aa7ac882f14fb69d0
    Reviewed-on: https://chromium-review.googlesource.com/1132103
    Reviewed-by: Stephen Chenney <schenney@chromium.org>
    Commit-Queue: Florin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574214}

    Changed files

    • third_party/blink/renderer/platform/graphics/skia/skia_utils.cc
  84. RC: Add UsageClock::IsInUse().

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:29:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9e1cac231cec99deee234be3a8c9adb81f966c4e

    Comments

    RC: Add UsageClock::IsInUse().
    
    This method returns true if Chrome is considered to be in use. This
    will be used by TabManager to know whether it should schedule a call
    to PerformStateTransitions() (it is never necessary to schedule a call
    to this method when Chrome is not in use).
    
    Bug: 775644
    Change-Id: I20e2e55280c84fcef9b56bb18c2feedb3aed136d
    Reviewed-on: https://chromium-review.googlesource.com/1133301
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574216}

    Changed files

    • chrome/browser/resource_coordinator/usage_clock.cc
    • chrome/browser/resource_coordinator/usage_clock.h
    • chrome/browser/resource_coordinator/usage_clock_unittest.cc
  85. Fix ASAN failure with tracing and hit testing.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:31:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c81c011e59e26fc69d8b1cab989194e292a83e4

    Comments

    Fix ASAN failure with tracing and hit testing.
    
    Appears TracingUmaTracker was passing in a std::string's c_str into
    the tracing macros. The tracing macros require a string literal because
    it stores the pointers for later consumption.
    
    BUG=862414
    
    Change-Id: Ia695bdfbd4bf7370db4306169cfa7397527cc08d
    Reviewed-on: https://chromium-review.googlesource.com/1133126
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574218}

    Changed files

    • content/browser/renderer_host/render_widget_targeter.cc
  86. Roll src/third_party/angle a6a7842fdbf5..5c8113d3c20f (1 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 17:31:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34a5e243802bd013333a373124e93317024a5dd8

    Comments

    Roll src/third_party/angle a6a7842fdbf5..5c8113d3c20f (1 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/a6a7842fdbf5..5c8113d3c20f
    
    
    git log a6a7842fdbf5..5c8113d3c20f --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 lucferron@chromium.org Vulkan/D3D11: Improve blit framebuffer tests and fix bug in D3D11
    
    
    Created with:
      gclient setdep -r src/third_party/angle@5c8113d3c20f
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the Auto
    ...skip...
    ;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: I0bf86e3800529f196540fd43c6f9c171b6a086c7
    Reviewed-on: https://chromium-review.googlesource.com/1133340
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574219}

    Changed files

    • DEPS
  87. macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:24:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c93c3dca594c13251590042f228f8a1029eca985

    Comments

    macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    
    This matches other macOS application like Safari, Terminal, etc. All existing
    hotkeys will still work.
    
    This CL uses the same hotkey for "previous tab" that Safari and Terminal use,
    which is [ctr + shift + "Horizontal Tab"]. This also causes tests to pass.
    However, pressing that key combination actually generates [ctr + shift + "End of
    Medium"], which renderers in the Main Menu as a backwards tab. This CL updates
    NSMenuI
    ...skip...
    a.mm. I
    regularly hit both of them when running Chromium on a local build. They both
    rely on the false assumption that keyEquivalents in the main menu must have the
    command modifier.
    
    Bug: 851714
    Change-Id: I90c643870f9bc7dd87369496eec9ab62a1685e07
    Reviewed-on: https://chromium-review.googlesource.com/1106659
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574211}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  88. [EoC] Fix EnabledStateMonitor/EnabledStateMonitorTest signin state

    Changed by twellingtonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:34:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b46cadfc5de6428dd42482995fc712cbd4f9539a

    Comments

    [EoC] Fix EnabledStateMonitor/EnabledStateMonitorTest signin state
    
    Some code meant for testing was accidentally added to
    EnabledStateMonitor.
    
    BUG=862520
    
    Change-Id: I4abf9e61c0ea18c21b04f263ab10da867ecdf82f
    Reviewed-on: https://chromium-review.googlesource.com/1133430
    Reviewed-by: Becky Zhou <huayinz@chromium.org>
    Commit-Queue: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574221}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/contextual_suggestions/EnabledStateMonitor.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/contextual_suggestions/EnabledStateMonitorTest.java
  89. Simplify implementation of FileSystemOperationRunner.

    Changed by wezohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:33:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d3c0d24685a29a2c27afc95f0d5e17fb3a0eb2ca

    Comments

    Simplify implementation of FileSystemOperationRunner.
    
    - Use a base::AutoReset instance to manage a single integer tracking
      whether the completion callback for an operation is invoked before
      we have actually returned to the caller.
    - Remove the now-unused OperationHandle and BeginOperationScoper.
    - Replace SupportsWeakPtr with an internal WeakPtrFactory.
    - Replace potentially unsafe use of GetWeakPtr() with a |weak_ptr_|
      member.
    - Temporarily disables the recently-added FileSystemURLLoaderFactoryTest
      tests, which have incorrect threading, causing WeakPtr checks to
      fire.
    
    Bug: 846985, 860547
    Change-Id: Ia059b1b87ef11f3218aeb6c65d7b8dd62be6c393
    Reviewed-on: https://chromium-review.googlesource.com/1074427
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574220}

    Changed files

    • chrome/browser/chromeos/file_manager/fileapi_util.cc
    • content/test/BUILD.gn
    • extensions/browser/api/file_system/file_system_api.cc
    • storage/browser/fileapi/file_system_operation_impl.cc
    • storage/browser/fileapi/file_system_operation_impl.h
    • storage/browser/fileapi/file_system_operation_runner.cc
    • storage/browser/fileapi/file_system_operation_runner.h
  90. Clips Automation.BoundsForRange to clipped location.

    Changed by katieohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:35:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c0e452422d56ad93dde15fe843dd85dcfe97cb42

    Comments

    Clips Automation.BoundsForRange to clipped location.
    
    Instead of returning BoundsForRange compared to the unclipped node location,
    clips bounds to the clipped location, so that BoundsForRange can never be
    outside the visible node bounds. This will stop the highlight from showing
    up when text is scrolled below the bottom of the screen or overflows its
    parent node, for example.
    
    Only SelectToSpeak seems to use BoundsForRange, so this change should not
    break any other a11y features.
    
    Bug: 832548,830104
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I763ae2df2228450b9b5d7f1fed0316c74abe470f
    Reviewed-on: https://chromium-review.googlesource.com/1123030
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Katie Dektar <katie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574222}

    Changed files

    • chrome/renderer/extensions/automation_internal_custom_bindings.cc
    • chrome/test/data/extensions/api_test/automation/sites/bounds_for_range.html
    • chrome/test/data/extensions/api_test/automation/tests/tabs/bounds_for_range.js
    • third_party/closure_compiler/externs/automation.js
  91. PaymentRequest: Initial implementation of retry()

    Changed by jinho.bangohnoyoudont@samsung.com
    Changed at Wednesday, 11-Jul-18 17:37:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb91a5b2d88c057e248821d87eb1c0aa6fbd7de4

    Comments

    PaymentRequest: Initial implementation of retry()
    
    This change includes the following things:
      - Add a new runtime flag (PaymentRetry)
      - Add new IDL dictionary types
      - Rename PaymentCompleter with PaymentStateResolver
    
    Intent to implement:
      https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI
    
    Bug: 861704
    Change-Id: Ia21260cdd50966cf7a4bb9289b33d004d803e682
    Reviewed-on: https://chromium-review.googlesource.com/1128826
    Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574223}

    Changed files

    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/modules/modules_idl_files.gni
    • third_party/blink/renderer/modules/payments/BUILD.gn
    • third_party/blink/renderer/modules/payments/address_error_fields.idl
    • third_party/blink/renderer/modules/payments/complete_test.cc
    • third_party/blink/renderer/modules/payments/payer_error_fields.idl
    • third_party/blink/renderer/modules/payments/payment_completer.h
    • third_party/blink/renderer/modules/payments/payment_request.cc
    • third_party/blink/renderer/modules/payments/payment_request.h
    • third_party/blink/renderer/modules/payments/payment_response.cc
    • third_party/blink/renderer/modules/payments/payment_response.h
    • third_party/blink/renderer/modules/payments/payment_response.idl
    • third_party/blink/renderer/modules/payments/payment_response_test.cc
    • third_party/blink/renderer/modules/payments/payment_state_resolver.h
    • third_party/blink/renderer/modules/payments/payment_validation_errors.idl
    • third_party/blink/renderer/platform/runtime_enabled_features.json5
  92. [Android] Fix crash if OmniboxStartupMetrics destroyed before delayed task is run

    Changed by mheikalohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:39:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af307eb2030ec03ec0249ba3956b6820da7c7fcd

    Comments

    [Android] Fix crash if OmniboxStartupMetrics destroyed before delayed task is run
    
    This is the second try for this fix, the previous version solved most
    crashes but still let a few through. Hopefully, this should prevent all
    of the NPE crashes with regards to mOmniboxStartupMetrics.
    
    Quote from previous cl on why the crash happens:
    > ToolbarManager#onDeferredStartup may post a delayed task to the UI
    > thread that calls itself. If the activity that owns the ToolbarManager
    > is destroyed before the task is run (and ToolbarManager#destroy is
    > called) then the mOmniboxStartupMetrics could be a null pointer. This
    > cl adds a check to see if the activity is finishing when the delayed
    > task is run and noops out if it has.
    
    Bug: 860449
    Change-Id: Ie20be31432afbbab8d34584f6ec27e49f260f03c
    Reviewed-on: https://chromium-review.googlesource.com/1132455
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574224}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
  93. [Cleanup] Remove UpdateLifecycleToPrePaintClean.

    Changed by vmpstrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:41:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b29626710e6d7369491825de0338dadb739be79b

    Comments

    [Cleanup] Remove UpdateLifecycleToPrePaintClean.
    
    ... and replace it with UpdateAllLifecyclePhasesExceptPaint, which does
    the same thing. One function is better than two, and the difference in
    intent seems minor.
    
    R=chrishtr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9e251414f8a1874c79e0013c415772f00968fde
    Reviewed-on: https://chromium-review.googlesource.com/1132565
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: vmpstr <vmpstr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574226}

    Changed files

    • third_party/blink/renderer/core/frame/local_frame_view.cc
    • third_party/blink/renderer/core/frame/local_frame_view.h
    • third_party/blink/renderer/core/input/gesture_manager.cc
    • third_party/blink/renderer/core/layout/layout_tree_as_text.cc
    • third_party/blink/renderer/core/layout/layout_view.cc
    • third_party/blink/renderer/core/page/page_animator.cc
    • third_party/blink/renderer/core/page/page_animator.h
    • third_party/blink/renderer/core/page/page_widget_delegate.cc
    • third_party/blink/renderer/core/paint/object_paint_invalidator_test.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
  94. gpu: Follow up on GrContext idle cleanup patch.

    Changed by khushalsagarohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 441bb2d8704de8d4ae008d2fc212674d8b6d5670

    Comments

    gpu: Follow up on GrContext idle cleanup patch.
    
    Follow up for remaining comments on:
    https://chromium-review.googlesource.com/c/chromium/src/+/1123775
    
    R=ericrk@chromium.org
    
    Bug: 859419,859635
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I78577f183d4050d6380024dc15aad2573c24714e
    Reviewed-on: https://chromium-review.googlesource.com/1132350
    Reviewed-by: Eric Karl <ericrk@chromium.org>
    Commit-Queue: Khushal <khushalsagar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574228}

    Changed files

    • gpu/command_buffer/service/gr_cache_controller.cc
    • gpu/ipc/service/gpu_channel_manager.cc
  95. Restart MediaCodecLoop timer more often.

    Changed by liberatoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:42:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0071e58c17ed4dfa39f49c04df044b73e068b743

    Comments

    Restart MediaCodecLoop timer more often.
    
    MediaCodecLoop's timer was not being restarted / reset if a decode
    produced TRY_AGAIN.  While this is normally correct behavior, it
    should be reset when a decode first arrives and the first dequeue
    of an input buffer fails.  After a flush, MediaCodec might take
    a few moments before it is ready to provide input buffers.
    
    In that case, we definitely want to retry, else we will never make
    any progress.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie76a3bab0c7b3f5cd70fb9c3b930e6fb6fac5ae6
    Reviewed-on: https://chromium-review.googlesource.com/1132524
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574227}

    Changed files

    • media/base/android/media_codec_loop.cc
    • media/base/android/media_codec_loop.h
    • media/base/android/media_codec_loop_unittest.cc
    • media/filters/android/media_codec_audio_decoder.cc
  96. Remove all keys on content protection teardown

    Changed by rkuroiwaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:43:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b10c8621eecec6173b9af6272fc1e96c05dc8f5

    Comments

    Remove all keys on content protection teardown
    
    - Invalidate all the keys since the keys are invalid after a teardown.
    
    Bug: 787657
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I3ef1365820cfc84e5ff30b8b621f3b3b42d2ca36
    Reviewed-on: https://chromium-review.googlesource.com/1132122
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Reviewed-by: John Rummell <jrummell@chromium.org>
    Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574229}

    Changed files

    • media/gpu/windows/d3d11_cdm_proxy.cc
    • media/gpu/windows/d3d11_cdm_proxy_unittest.cc
  97. Remove notificaiton

    Changed by wutaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:40:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 034b30c489f6036cee2195be466b71a0bfd95f8b

    Comments

    Remove notificaiton
    
    This cl removes notification when receiving
    notification.REMOVE_NOTIFICATION.
    
    Bug: b/79493568
    Change-Id: I86388514ae5409fb41f34fba24572486a64f994b
    Reviewed-on: https://chromium-review.googlesource.com/1123234
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Sam McNally <sammc@chromium.org>
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574225}

    Changed files

    • ash/assistant/assistant_notification_controller.cc
    • ash/assistant/assistant_notification_controller.h
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/public/mojom/assistant.mojom
  98. EasyUnlockPrivateApi: Handle when the connected-to extension is unloaded.

    Changed by jhawkinsohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:45:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision aabe00b5db3e2eba359e10d40cdb3e7d81171ffc

    Comments

    EasyUnlockPrivateApi: Handle when the connected-to extension is unloaded.
    
    This fixes one crash condition on shutdown.
    
    R=khorimoto@chromium.org
    
    Bug: 850765
    Test: EasyUnlockPrivateApiTest.ExtensionUnloaded
    Change-Id: Idd70473a8a358db0a98fea234a6c4b832db34d2e
    Reviewed-on: https://chromium-review.googlesource.com/1133429
    Commit-Queue: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574230}

    Changed files

    • chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api_chromeos_unittest.cc
    • chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
    • chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.h
  99. Re-enable TracingController tests I disabled yesterday.

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:45:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5b38808c4def92a821392b167d71c0474e3b0da

    Comments

    Re-enable TracingController tests I disabled yesterday.
    
    A CL landed that made some TracingController browser tests flaky
    under Asan, so I landed two CLs to disable the tests; the CL
    was reverted, so we can reenable the tests now.
    
    This CL reverts 2ea09fc081c204276a0bbe77ac6e6ece70f47690 and
    886a3c80fac9355557a45645129801210d88fcf7.
    
    TBR=oysteine@chromium.org
    
    Bug: 862414
    Change-Id: I7ee8181af857ee0dfde29cc103bf7fa8bd970fcb
    Reviewed-on: https://chromium-review.googlesource.com/1133585
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574231}

    Changed files

    • content/browser/tracing/tracing_controller_browsertest.cc
  100. Support long-press to copy and paste on steady location bar

    Changed by lodohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:48:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e97433df55b34cf0f565b773bf44b0c33fe9c5af

    Comments

    Support long-press to copy and paste on steady location bar
    
    Show the editing menu when long pressing the steady location bar
    with elements "Copy" and "Paste and Go". The latter is only shown when
    the clipboard contains text content.
    
    Bug: 860490
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ifeb7f4206e081b1f92c6066ab5f093edd0343206
    Reviewed-on: https://chromium-review.googlesource.com/1127052
    Commit-Queue: Elodie Banel <lod@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574232}

    Changed files

    • ios/chrome/app/strings/ios_strings.grd
    • ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm
    • ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
    • ios/chrome/browser/ui/location_bar/location_bar_view_controller.h
    • ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
  101. Reland "jumbo: stable assignment of inputs to chunks"

    Changed by david.barrohnoyoudont@samsung.com
    Changed at Wednesday, 11-Jul-18 17:48:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 73ea8f55b7cf8a6add17696c344688a98260d84c

    Comments

    Reland "jumbo: stable assignment of inputs to chunks"
    
    This is a reland of 2c7a71c3fd6cc3ee5eda41467ea6d5b8ee337386
    
    Original change's description:
    > jumbo: stable assignment of inputs to chunks
    >
    > Adding or removing a file from a jumbo source set causes on average
    > half of the chunks to have their inputs reallocated.
    > Derive chunk boundaries from a combination of list position and path
    > content. This is so that when a file is added or removed, only the
    > boundaries with adjacent chunks typically 
    ...skip...
    awson <brucedawson@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Daniel Bratell <bratell@opera.com>
    > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#570623}
    
    Bug: 860646
    Change-Id: I55b326beb716789896c39d58be8e793c97f7097d
    Reviewed-on: https://chromium-review.googlesource.com/1121976
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574233}

    Changed files

    • build/config/jumbo.gni
    • build/config/merge_for_jumbo.py
    • docs/jumbo.md
  102. Added integration test for interaction between Client LoFi and the DRP.

    Changed by sclittleohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:59:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 051c824d017e9a1ffdd387118503f8b7bd810066

    Comments

    Added integration test for interaction between Client LoFi and the DRP.
    
    Added an integration test that checks that range requests sent by
    Client-side LoFi Previews that go through the Data Reduction Proxy are
    responded to properly by the Data Reduction Proxy, and correctly
    recognized as Client LoFi responses by Chrome.
    
    Bug: 720634
    Change-Id: Iea40a0c60f96624733da1ea478f6ba443de5c454
    Reviewed-on: https://chromium-review.googlesource.com/1130938
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Scott Little <sclittle@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574243}

    Changed files

    • tools/chrome_proxy/webdriver/lofi.py
  103. Completely disable aura window capture unit tests

    Changed by sabbakumovohnoyoudont@yandex-team.ru
    Changed at Wednesday, 11-Jul-18 17:50:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f522512015974f151b5fd6c2c37254deefbdf253

    Comments

    Completely disable aura window capture unit tests
    
    The tests are flaky on all platforms.
    Adding gtest_repeat=100 reveals the issue.
    
    Bug: 603823
    Change-Id: Ic24db4872df66233634bbc19b2803980b520c43a
    Reviewed-on: https://chromium-review.googlesource.com/1127029
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574235}

    Changed files

    • chrome/browser/media/webrtc/native_desktop_media_list_unittest.cc
  104. [remoting] Detect if WebRTC connection is relayed

    Changed by lambroslambrouohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:51:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 32d3a2f9447417d82e5d03a27d345f74052e76c4

    Comments

    [remoting] Detect if WebRTC connection is relayed
    
    On successful WebRTC connection, this uses the RTCStats information to
    determine if the connection is relayed via TURN. A followup CL will use
    this to cap the bandwidth usage of relay connections.
    
    Bug: 857287
    Change-Id: I30c39fd21d7a3cc82742a00d39fcf19f9fc9857c
    Reviewed-on: https://chromium-review.googlesource.com/1117880
    Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
    Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574236}

    Changed files

    • remoting/protocol/webrtc_transport.cc
    • remoting/protocol/webrtc_transport.h
  105. Support multiple focus rects from different sources at once.

    Changed by katieohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:49:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a621e47e2fb48b34b90a83fe18e745421b2c2729

    Comments

    Support multiple focus rects from different sources at once.
    
    This refactors AccessibilityFocusRingController components needed
    for tracking an individual group of focus rings into
    AccessibilityFocusRingGroup. The Controller maps from caller_ids
    to AccessibilityFocusRingGroups. Unit tests are updated to ensure
    coverage.
    
    See go/cros-multiple-focus-rings for background.
    
    Bug: 830967
    Change-Id: Ic04c883b2445fc74747cc93e907d373fba65949f
    Reviewed-on: https://chromium-review.googlesource.com/1120838
    Commit-Queue: Katie Dektar <katie@chromium.org>
    Reviewed-by: Martin Barbella <mbarbella@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574234}

    Changed files

    • ash/BUILD.gn
    • ash/accessibility/accessibility_focus_ring_controller.cc
    • ash/accessibility/accessibility_focus_ring_controller.h
    • ash/accessibility/accessibility_focus_ring_controller_unittest.cc
    • ash/accessibility/accessibility_focus_ring_group.cc
    • ash/accessibility/accessibility_focus_ring_group.h
    • ash/accessibility/accessibility_focus_ring_group_unittest.cc
    • ash/accessibility/accessibility_highlight_controller.cc
    • ash/accessibility/touch_exploration_manager.cc
    • ash/public/interfaces/accessibility_focus_ring_controller.mojom
    • chrome/browser/accessibility/accessibility_extension_api.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.h
    • chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc
  106. Run blink_fuzzer_unittests on all desktop bots.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:54:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c2091783832a8bd4f918e3c935918bbb498f037

    Comments

    Run blink_fuzzer_unittests on all desktop bots.
    
    It seems to build and pass everywhere.
    
    Bug: 843511
    Change-Id: Ie67651ad49b41b234444115459dd7699c0248b2e
    Reviewed-on: https://chromium-review.googlesource.com/1132411
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574239}

    Changed files

    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.clang.json
    • testing/buildbot/chromium.fyi.json
    • testing/buildbot/chromium.mac.json
    • testing/buildbot/chromium.memory.json
    • testing/buildbot/chromium.win.json
    • testing/buildbot/test_suites.pyl
  107. Remove RTT and throughput estimates observer from UI NQE class

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:55:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a60fda5a4aebd802db617469bbd961a2f59265ab

    Comments

    Remove RTT and throughput estimates observer from UI NQE class
    
    These are not being used, and makes it easier to transition NQE
    (Network Quality Estimator) observers for network servicification.
    
    Change-Id: I1f22a66e134a2cd1af89ac4b7bd274091934dd51
    Bug: 819244
    Reviewed-on: https://chromium-review.googlesource.com/1132685
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574241}

    Changed files

    • chrome/browser/net/nqe/ui_network_quality_estimator_service.cc
    • chrome/browser/net/nqe/ui_network_quality_estimator_service.h
    • chrome/browser/net/nqe/ui_network_quality_estimator_service_browsertest.cc
    • net/nqe/network_quality_estimator.h
    • net/nqe/network_quality_provider.h
  108. Overflow menu appears from the bottom when Duet is enabled

    Changed by mdjonesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:54:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a53131c8cffeea3f40b38ed147990e69d03d66bc

    Comments

    Overflow menu appears from the bottom when Duet is enabled
    
    This patch adds a boolean flag to functions that trigger the overflow
    menu which specifies whether the menu should appear from the bottom of
    the screen.
    
    Bug: 847632
    Change-Id: Ifadfb787e66176995811876187c4f955e21bd66e
    Reviewed-on: https://chromium-review.googlesource.com/1132248
    Commit-Queue: Matthew Jones <mdjones@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574238}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuButtonHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelperTest.java
  109. Move UpdateSurfaceReferences to SurfaceManager

    Changed by akabaohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:55:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 832610e24633dc3b9079fd42408ba84fcc70f301

    Comments

    Move UpdateSurfaceReferences to SurfaceManager
    
    This CL move the surface references update from CompositorFrameSinkSupport to SurfaceManager, while keeping the root display surface reference change in CompositorFrameSinkSupport.
    
    Bug: 860306
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I156c40d8eb3ce6c702d2797ce8981554b83c0b2a
    Reviewed-on: https://chromium-review.googlesource.com/1132319
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Commit-Queue: Andre Kaba <akaba@google.com>
    Cr-Commit-Position: refs/heads/master@{#574240}

    Changed files

    • components/viz/service/BUILD.gn
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/surfaces/referenced_surface_tracker.cc
    • components/viz/service/surfaces/referenced_surface_tracker.h
    • components/viz/service/surfaces/referenced_surface_tracker_unittest.cc
    • components/viz/service/surfaces/surface.cc
    • components/viz/service/surfaces/surface.h
  110. Fix shard map name of 'Android Nexus 5X Perf FYI'

    Changed by nednguyenohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 17:53:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ea82d9961c77908b72fcbd72dc2498c0f6faa98

    Comments

    Fix shard map name of 'Android Nexus 5X Perf FYI'
    
    TBR=eyaich@chromium.org
    NOTRY=true
    
    Bug: 757933
    Change-Id: Ib9a36c58d59e629543d962086ebb8b9799ee1217
    Reviewed-on: https://chromium-review.googlesource.com/1133326
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574237}

    Changed files

    • testing/buildbot/chromium.perf.fyi.json
  111. Migrate TabLoaderDelegate to NetworkConnectionTracker.

    Changed by rmcelrathohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 98f8c0299e8a5e1c7669374b152c070df38f41a7

    Comments

    Migrate TabLoaderDelegate to NetworkConnectionTracker.
    
    This migrates TabLoaderDelegate from using
    net::NetworkChangeNotifier to content::NetworkConnectionTracker, which
    works with the network service enabled.
    
    Bug: 859135
    Change-Id: I311155771618328dbceaf9e8f84815f9b24b7ac7
    Reviewed-on: https://chromium-review.googlesource.com/1123691
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574242}

    Changed files

    • chrome/browser/sessions/tab_loader_delegate.cc
  112. Clean up renderer fling code.

    Changed by sahelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 17:59:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b723c9447cfc8e917ab667710f7790431da9d3b

    Comments

    Clean up renderer fling code.
    
    This cl cleans up the fling handling logic on the renderer side. I've already
    added DCHECKs in InputHandlerProxy::HandleGestureFlingStart and some other
    functions in input_handler_proxy.cc to make sure that touchscreen and touchpad
    flings are not sent to the renderer. Since Mar 28, Autoscroll fling is also
    being handled in browser (https://chromium-review.googlesource.com/980965) and
    it is safe to delete the dead code from renderer.
    
    To avoid making this cl larger I'll l
    ...skip...
    ybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ibd1db260c0b3c92c7ccf17156dd38c4865ae1926
    Reviewed-on: https://chromium-review.googlesource.com/1117639
    Commit-Queue: Sahel Sharify <sahel@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: Lan Wei <lanwei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574244}

    Changed files

    • cc/input/input_handler.h
    • cc/test/fake_proxy.h
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_impl_unittest.cc
    • cc/trees/layer_tree_host_unittest_scroll.cc
    • cc/trees/proxy.h
    • cc/trees/proxy_impl.cc
    • cc/trees/proxy_impl.h
    • cc/trees/proxy_main.cc
    • cc/trees/proxy_main.h
    • cc/trees/single_thread_proxy.h
    • content/child/blink_platform_impl.cc
    • content/child/blink_platform_impl.h
    • content/renderer/gpu/layer_tree_view.cc
    • content/renderer/gpu/layer_tree_view.h
    • content/renderer/input/widget_input_handler_manager.cc
    • content/renderer/input/widget_input_handler_manager.h
    • content/renderer/render_widget_unittest.cc
    • content/test/test_blink_web_unit_test_support.cc
    • content/test/test_blink_web_unit_test_support.h
    • content/test/web_gesture_curve_mock.cc
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/blink/public/BUILD.gn
    • third_party/blink/public/platform/platform.h
    • third_party/blink/public/platform/web_gesture_curve.h
    • third_party/blink/public/platform/web_gesture_curve_target.h
    • third_party/blink/renderer/core/exported/web_view_impl.cc
    • third_party/blink/renderer/core/exported/web_view_impl.h
    • third_party/blink/renderer/core/frame/web_frame_widget_base.cc
    • third_party/blink/renderer/core/frame/web_frame_widget_base.h
    • third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
    • third_party/blink/renderer/core/frame/web_view_frame_widget.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/exported/platform.cc
    • third_party/blink/renderer/platform/exported/web_active_gesture_animation.cc
    • third_party/blink/renderer/platform/exported/web_active_gesture_animation.h
    • ui/compositor/overscroll/scroll_input_handler.cc
    • ui/compositor/overscroll/scroll_input_handler.h
    • ui/events/blink/DEPS
    • ui/events/blink/blink_event_util.cc
    • ui/events/blink/blink_event_util.h
    • ui/events/blink/input_handler_proxy.cc
    • ui/events/blink/input_handler_proxy.h
    • ui/events/blink/input_handler_proxy_client.h
    • ui/events/blink/input_handler_proxy_unittest.cc
    • ui/events/gestures/blink/DEPS
    • ui/events/gestures/blink/web_gesture_curve_impl.cc
    • ui/events/gestures/blink/web_gesture_curve_impl_unittest.cc
  113. Fix inline autocomplete label layout on rotation.

    Changed by stkhapuginohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:09:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 917a6f7ed040c2713f3da1dd84621ddecdc6cd35

    Comments

    Fix inline autocomplete label layout on rotation.
    
    
    Bug: 857190
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I2d3416b705c6203e6241f62e1b6503a6de7151b1
    Reviewed-on: https://chromium-review.googlesource.com/1118550
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Reviewed-by: Rohit Rao <rohitrao@chromium.org>
    Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574247}

    Changed files

    • ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
  114. Run cast_unittests on ToTAndroidCFI and ToTLinuxThinLTO.

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:05:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 465e6fd64fc7ca93c23a8f2339157071c624acb4

    Comments

    Run cast_unittests on ToTAndroidCFI and ToTLinuxThinLTO.
    
    (It already runs on the non-ToT bots.)
    
    Also add a comment explaining why chrome_public_test_apk doesn't yet
    run on the Android CFI bots.
    
    Bug: 843511
    Change-Id: I354cb867c15f3e8b3d36968cf4ca36cf389c25a5
    Reviewed-on: https://chromium-review.googlesource.com/1132406
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574245}

    Changed files

    • testing/buildbot/chromium.clang.json
    • testing/buildbot/test_suite_exceptions.pyl
  115. [Chromecast] Make CastContentBrowserClient::CreateCdmFactory virtual.

    Changed by slanohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 18:06:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01a23ec9e1e68d834b3e4d9422813570a5f12df4

    Comments

    [Chromecast] Make CastContentBrowserClient::CreateCdmFactory virtual.
    
    This was a bug introduced in chromium/1103384.
    
    TBR=halliwell
    
    Bug: None
    Test: Builds
    
    Change-Id: I0f8bd49513fa817d2425e0ca6cb9bbd0396e33b8
    Reviewed-on: https://chromium-review.googlesource.com/1133690
    Reviewed-by: Stephen Lanham <slan@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Stephen Lanham <slan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574246}

    Changed files

    • chromecast/browser/cast_content_browser_client.h
  116. Change ownership to the Chrome Print team.

    Changed by skauohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:16:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3cc018ce0214d784aa6a1f2a6e6e70d7ccffcb7c

    Comments

    Change ownership to the Chrome Print team.
    
    Changing ownership of //cloud_print to the Chrome Print team for now.
    
    Change-Id: Ib5593c08404b123c5698579a60553d8664c97d4c
    Reviewed-on: https://chromium-review.googlesource.com/1130461
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
    Commit-Queue: Sean Kau <skau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574248}

    Changed files

    • cloud_print/OWNERS
  117. Import wpt@90eb60b746c20fe94b3e76f7e470eef44dbdec57

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:23:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b397aeb5bae423911af84ce7156ddade7e6c7109

    Comments

    Import wpt@90eb60b746c20fe94b3e76f7e470eef44dbdec57
    
    Using wpt-import in Chromium 4feb130aa420b47c8ddce50d88380ea5d117d1a9.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21176
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I8bf6f5562d430f2a37faa710447cebbda8d3eb6d
    Reviewed-on: https://chromium-review.googlesource.com/1133431
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574250}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/interfaces/picture-in-picture.idl
    • third_party/WebKit/LayoutTests/external/wpt/picture-in-picture/idlharness.window-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/picture-in-picture/idlharness.window.js
  118. Roll src/third_party/catapult 345d3323ed4a..4c70b5037475 (1 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 18:23:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fc67b341c8d30821f9df226a769d97e86523f02

    Comments

    Roll src/third_party/catapult 345d3323ed4a..4c70b5037475 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/345d3323ed4a..4c70b5037475
    
    
    git log 345d3323ed4a..4c70b5037475 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 perezju@chromium.org [soundwave] Helper script to export_csv
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@4c70b5037475
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.go
    ...skip...
    m.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=sullivan@chromium.org
    
    Change-Id: I5042f65757cdc12c500f5778478ed4fa2de6acb9
    Reviewed-on: https://chromium-review.googlesource.com/1133438
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574251}

    Changed files

    • DEPS
  119. Disabling some loading.mobile stories on Nexus5

    Changed by eyaichohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 18:21:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 22670eedf13582c5a536ede4813f6c1a6651f1fd

    Comments

    Disabling some loading.mobile stories on Nexus5
    
    TBR=charliea@chromium.org
    NOTRY=true
    
    Bug: 862663
    Change-Id: I398238f6132f6996da56ccf869ab0d0fc67343a2
    Reviewed-on: https://chromium-review.googlesource.com/1133714
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574249}

    Changed files

    • tools/perf/expectations.config
  120. Move scheduler/base/test to //base/task/sequence_manager/test.

    Changed by kraynovohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:29:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d6ba62614546d9f12a1553d654eaf11480d22d7

    Comments

    Move scheduler/base/test to //base/task/sequence_manager/test.
    
    Bug: 783309
    Change-Id: I79a8fc81062c46128d1a0d2ee5358f91a7a401e2
    Reviewed-on: https://chromium-review.googlesource.com/1133172
    Commit-Queue: Greg Kraynov <kraynov@chromium.org>
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574252}

    Changed files

    • base/task/sequence_manager/test/fake_task.cc
    • base/task/sequence_manager/test/fake_task.h
    • base/task/sequence_manager/test/lazy_thread_controller_for_test.cc
    • base/task/sequence_manager/test/lazy_thread_controller_for_test.h
    • base/task/sequence_manager/test/mock_time_domain.cc
    • base/task/sequence_manager/test/mock_time_domain.h
    • base/task/sequence_manager/test/sequence_manager_for_test.cc
    • base/task/sequence_manager/test/sequence_manager_for_test.h
    • base/task/sequence_manager/test/test_task_queue.cc
    • base/task/sequence_manager/test/test_task_queue.h
    • base/task/sequence_manager/test/test_task_time_observer.h
    • base/test/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/BUILD.gn
    • third_party/blink/renderer/platform/scheduler/DEPS
    • third_party/blink/renderer/platform/scheduler/base/sequence_manager_fuzzer_processor.cc
    • third_party/blink/renderer/platform/scheduler/base/sequence_manager_fuzzer_processor.h
    • third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/base/sequence_manager_perftest.cc
    • third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
    • third_party/blink/renderer/platform/scheduler/base/test/fake_task.cc
    • third_party/blink/renderer/platform/scheduler/base/test/fake_task.h
    • third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.cc
    • third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.h
    • third_party/blink/renderer/platform/scheduler/base/test/test_task_time_observer.h
    • third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/metrics_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
    • third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
    • third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
    • third_party/blink/renderer/platform/scheduler/test/DEPS
    • third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h
    • third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
    • third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler_unittest.cc
    • third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
    • third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
    • third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
    • third_party/blink/renderer/platform/testing/DEPS
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
    • third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
  121. Migrate assist_ranker to BindOnce

    Changed by pilgrimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:33:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2bd2d91c13ac80694daaad583846dbab26d6a8b0

    Comments

    Migrate assist_ranker to BindOnce
    
    Bug: 714018
    Change-Id: Ied2384bf97e7f93449874d768b047c37e0474548
    Reviewed-on: https://chromium-review.googlesource.com/1131570
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574254}

    Changed files

    • components/assist_ranker/ranker_model_loader_impl.cc
    • components/assist_ranker/ranker_url_fetcher.cc
    • components/assist_ranker/ranker_url_fetcher.h
  122. [Zine]Invalidate auth token on 401

    Changed by pnolandohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 18:34:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbc62fce2681c25cf09a88982ca8b50202ce7e14

    Comments

    [Zine]Invalidate auth token on 401
    
    Bug: 859684
    Change-Id: Ia97912a688af2080aa139138a2195bdbce949932
    Reviewed-on: https://chromium-review.googlesource.com/1133428
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Patrick Noland <pnoland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574255}

    Changed files

    • components/ntp_snippets/remote/json_request.cc
    • components/ntp_snippets/remote/json_request.h
    • components/ntp_snippets/remote/remote_suggestions_fetcher_impl.cc
    • components/ntp_snippets/remote/remote_suggestions_fetcher_impl.h
    • components/ntp_snippets/remote/remote_suggestions_fetcher_impl_unittest.cc
    • tools/metrics/histograms/enums.xml
  123. Re-enable passing WPT test transform3d-perspective-008.html

    Changed by petermayoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:35:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d044c564b237fbc80095a165d1f2c8009056ee4f

    Comments

    Re-enable passing WPT test transform3d-perspective-008.html
    
    This test is passing at ToT.
    
    Bug: 773810
    Change-Id: Idbb463837ca1e969bd141126d04392dfbdcbda34
    Reviewed-on: https://chromium-review.googlesource.com/1132538
    Reviewed-by: Xianda Sun <sunxd@chromium.org>
    Commit-Queue: Peter Mayo <petermayo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574257}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  124. viz: Add resource formats to raster cmd buffer.

    Changed by sohan.jyotiohnoyoudont@huawei.com
    Changed at Wednesday, 11-Jul-18 18:39:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5a23aad411e02432e2e915e2b05a672c042cb357

    Comments

    viz: Add resource formats to raster cmd buffer.
    
    Use right technique to add new formats instead of hard-coding autogen
    files. Also ensure texture creation and GMB import via RasterDecoder
    allows all ResourceFormats, but fail in TexStorage2D.
    
    BUG=860206,860148,860505
    
    Change-Id: I54a16a94f9fa0d05dede1d40dbf9095b3d90fce8
    Reviewed-on: https://chromium-review.googlesource.com/1126393
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
    Cr-Commit-Position: refs/heads/master@{#574258}

    Changed files

    • components/viz/common/resources/resource_format_utils.cc
    • gpu/command_buffer/build_raster_cmd_buffer.py
    • gpu/command_buffer/service/raster_cmd_validation_implementation_autogen.h
    • gpu/command_buffer/service/raster_decoder.cc
    • gpu/command_buffer/service/raster_decoder_unittest_0_autogen.h
  125. DevTools: unflake evaluate-timeout.js

    Changed by luoeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:31:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e976e35a8a545060b769f7bf44903b92b911634a

    Comments

    DevTools: unflake evaluate-timeout.js
    
    A timeout value 0 does not guarantee that an evaluation will
    terminate via timeout.
    
    Bug: none
    Change-Id: I259d88e01fe14af9908940599421ccd58e0863de
    Reviewed-on: https://chromium-review.googlesource.com/1132567
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Erik Luo <luoe@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574253}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout-expected.txt
    • third_party/WebKit/LayoutTests/http/tests/devtools/runtime/evaluate-timeout.js
  126. Build chrome/browser/metrics/desktop_session_duration/ on ChromeOS.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:35:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6dfc80f9ff2b20a3146bbadc1afe47c5a62096b8

    Comments

    Build chrome/browser/metrics/desktop_session_duration/ on ChromeOS.
    
    This directory was previously excluded from the ChromeOS build. It
    forced #ifdefs to be added to code using DesktopSessionDurationTracker
    (e.g. https://cs.chromium.org/chromium/src/chrome/browser/resource_coordinator/usage_clock.cc?rcl=ae0af1511d081f85641f82ac650919dafffa1ee6).
    With this CL, the directory is built and the #ifdefs are not longer
    required.
    
    Note that for now, DesktopSessionDurationTracker is still not
    initialized on ChromeOS.
    
    Bug: 775644
    Change-Id: Ic3fcd2646f7577805b986888bc22f79579c9d736
    Reviewed-on: https://chromium-review.googlesource.com/1133280
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574256}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/metrics/desktop_session_duration/desktop_profile_session_durations_service_factory.cc
    • chrome/test/BUILD.gn
  127. Roll Fuchsia SDK from b56f55613420 to cf3c39f9e29d

    Changed by fuchsia-sdk-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 18:43:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2e3b05bf93916231d1089d19dfdb5034a9484d87

    Comments

    Roll Fuchsia SDK from b56f55613420 to cf3c39f9e29d
    
    
    The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    If the roll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
    TBR=cr-fuchsia+bot@chromium.org
    
    Change-Id: Ic3a997c2284d8828c3ff9600628397f100c63172
    Reviewed-on: https://chromium-review.googlesource.com/1133684
    Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574261}

    Changed files

    • build/fuchsia/sdk.sha1
  128. GMBVideoFramePool: add UMA of unsupported VideoFrame formats

    Changed by mcasasohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:42:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dddc956881beb1618d5f672275ec0cf060a64e3e

    Comments

    GMBVideoFramePool: add UMA of unsupported VideoFrame formats
    
    This CL adds a UMA for unsupported VideoFrame pixel formats in
    GMBVideoFramePool; these VideoFrames are not processed in the said
    GMVFPool and end up being handled in VideoResourceUpdater's
    CreateForSoftwarePlanes() insteadm, which is a code path we would
    like to avoid. This UMA will help track these situations.
    
    Bug: 787122
    Change-Id: I9c0a7e79c8784063b6dba577766d3fc504642400
    Reviewed-on: https://chromium-review.googlesource.com/1132112
    Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Miguel Casas <mcasas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574260}

    Changed files

    • media/video/gpu_memory_buffer_video_frame_pool.cc
    • tools/metrics/histograms/histograms.xml
  129. [MessageLoop] Disable hi-res timers when not sleeping

    Changed by gabohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:40:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62973d1b3f85cbc12f3f6e255e8d5dd1f91225b4

    Comments

    [MessageLoop] Disable hi-res timers when not sleeping
    
    Time::ActivateHighResolutionTimer(bool activating) is a per-thread vote
    for a system-wide side-effect. For a given thread, hi-res timers are
    only useful when going to sleep (if it has pending hi-res tasks).
    
    Deactivating a thread's vote while it's active will prevent other
    threads on the system which do not have hi-res requirements from
    being forced to use hi-res timers in that period.
    
    Bug: 854237
    Change-Id: I1393e184cac6c9321d13b92b6077a38c62b1f590
    Reviewed-on: https://chromium-review.googlesource.com/1107110
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574259}

    Changed files

    • base/message_loop/message_loop.cc
    • base/message_loop/message_loop.h
    • base/message_loop/message_loop_unittest.cc
  130. Roll src/third_party/perfetto dc44083eeb40..256c9c48ab20 (2 commits)

    Changed by perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 18:49:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 56545209d0947287e98ae437da5d2d91fae20b34

    Comments

    Roll src/third_party/perfetto dc44083eeb40..256c9c48ab20 (2 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/dc44083eeb40..256c9c48ab20
    
    
    git log dc44083eeb40..256c9c48ab20 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 hjd@google.com Merge "perfetto-ui: Move CSS to own file"
    2018-07-11 hjd@google.com perfetto-ui: Move CSS to own file
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@256c9c48ab20
    
    The AutoRoll server is located here: https://perfetto
    ...skip...
    oll is causing failures, please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=perfetto-bugs@google.com
    
    Change-Id: I0ff1593ebf9e1d788383377dfb1a14602151fde1
    Reviewed-on: https://chromium-review.googlesource.com/1133440
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574263}

    Changed files

    • DEPS
  131. Add ericrk to ui/android owners for CC/Viz integration

    Changed by ericrkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:47:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d6474a853941542847aa6193662b84a82abba3e

    Comments

    Add ericrk to ui/android owners for CC/Viz integration
    
    Change-Id: Ia53a2532451c49b69c643cb1c51a4c95b1613f16
    Reviewed-on: https://chromium-review.googlesource.com/1133798
    Reviewed-by: Khushal <khushalsagar@chromium.org>
    Commit-Queue: Khushal <khushalsagar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574262}

    Changed files

    • ui/android/OWNERS
  132. [omnibox] Stop forcing title-before-URL in Refresh.

    Changed by jdonnellyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:53:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cfdd02c563317d5ace72ee61b64484746ec541c8

    Comments

    [omnibox] Stop forcing title-before-URL in Refresh.
    
    While we continue to discuss whether to launch this feature, we should
    be able to try it out either way but this isn't currently possible with
    Refresh enabled.
    
    This change reverts the behavior to the state before this CL, where swapping is still forced
    for touch UI:
    https://chromium-review.googlesource.com/c/chromium/src/+/969962/7/components/omnibox/browser/omnibox_field_trial.cc#b661
    
    Change-Id: I4e0c2a7ab19913ec07f731df248b85972f3aa77c
    Reviewed-on: https://chromium-review.googlesource.com/1133316
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574264}

    Changed files

    • components/omnibox/browser/omnibox_field_trial.cc
  133. Add more functionality to TestURLLoaderFactory

    Changed by jcivelliohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 18:54:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6114e3dc456f65336364d04714dbc53505c221fa

    Comments

    Add more functionality to TestURLLoaderFactory
    
    Adding more functionality to TestURLLoaderFactory:
    - replacing the existing static SimulateResponse method with
      SimulateResponseForPendingRequest that is easier to use and supports
      setting cookies
    - added support for raw headers
    
    This is needed for an upcoming patch that changes GaiaAuthFetcher to
    use SimpleURLLoader.
    
    Bug: 840396
    TBR=msarda@chromium.org,pmarko@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ice4cc167ebecc7d690e9054a4f2ce0626edbb674
    Reviewed-on: https://chromium-review.googlesource.com/1123064
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
    Reviewed-by: Jay Civelli <jcivelli@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574266}

    Changed files

    • chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
    • chrome/browser/policy/cloud/test_request_interceptor.cc
    • google_apis/gaia/DEPS
    • google_apis/gaia/oauth2_token_service_unittest.cc
    • services/network/test/test_url_loader_factory.cc
    • services/network/test/test_url_loader_factory.h
    • services/network/test/test_url_loader_factory_unittest.cc
    • services/network/test/test_utils.cc
    • services/network/test/test_utils.h
  134. cryptohome: Call MountGuestEx instead of AsyncMountGuest.

    Changed by kerrnelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:55:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db80c91d87606721e07ea5f02d69fd395da31420

    Comments

    cryptohome: Call MountGuestEx instead of AsyncMountGuest.
    
    With cryptohome's async event loop being deprecated, this calls modern
    MountGuestEx function.
    
    Bug: 211405
    Change-Id: Ie0dd3f6087ade998d4620ee9ae39a2e19155191f
    Reviewed-on: https://chromium-review.googlesource.com/1119072
    Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    Reviewed-by: Jacob Dufault <jdufault@chromium.org>
    Commit-Queue: Greg Kerr <kerrnel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574267}

    Changed files

    • chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
    • chromeos/cryptohome/async_method_caller.cc
    • chromeos/cryptohome/async_method_caller.h
    • chromeos/cryptohome/mock_async_method_caller.cc
    • chromeos/cryptohome/mock_async_method_caller.h
    • chromeos/dbus/cryptohome_client.cc
    • chromeos/dbus/cryptohome_client.h
    • chromeos/dbus/fake_cryptohome_client.cc
    • chromeos/dbus/fake_cryptohome_client.h
    • chromeos/login/auth/cryptohome_authenticator.cc
  135. [Android] Move OmniboxStartupMetrics null check to right before use

    Changed by mheikalohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 18:54:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad027eb785182d616a240ac581cd7512246660cc

    Comments

    [Android] Move OmniboxStartupMetrics null check to right before use
    
    A null check is required before referencing mOmniboxStartupMetrics, this
    cl moves the check to immediately before use.
    
    Quote from previous cl on why the crash happens:
    > ToolbarManager#onDeferredStartup may post a delayed task to the UI
    > thread that calls itself. If the activity that owns the ToolbarManager
    > is destroyed before the task is run (and ToolbarManager#destroy is
    > called) then the mOmniboxStartupMetrics could be a null pointer. This
    > cl adds a check to see if the activity is finishing when the delayed
    > task is run and noops out if it has.
    
    Bug: 860449
    Change-Id: I4b5cbd2c40d4c0a2917030dcc05997defc6ea75b
    Reviewed-on: https://chromium-review.googlesource.com/1133704
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574265}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
  136. Interpret space+dot-8 as enter key within editable text

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:56:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e848fd430d59eca4c83955235fc22b9aff9e419e

    Comments

    Interpret space+dot-8 as enter key within editable text
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I8eead18b15691d07f34731da0100783babe9f264
    Reviewed-on: https://chromium-review.googlesource.com/1133435
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574268}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/braille_command_handler.js
  137. WebUI Polymer2 Migration: Remove deep usage in history tests

    Changed by rbpotterohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:57:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d9939c803f2b1f398a590a140f235e9eba32bf0f

    Comments

    WebUI Polymer2 Migration: Remove deep usage in history tests
    
    These lines no longer seem to be necessary and /deep/ is not supported
    in Polymer2.
    
    Bug: 860069
    Change-Id: Ib8d9c85e4690ce95a4cf1a9b34f6766aea87e45f
    Reviewed-on: https://chromium-review.googlesource.com/1132625
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574270}

    Changed files

    • chrome/test/data/webui/md_history/md_history_browsertest.js
  138. Android: Delete API ContentViewCore.destroy

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:56:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision baaa1eb9c0daf5e3e9b79400a9395b3b14b7f67a

    Comments

    Android: Delete API ContentViewCore.destroy
    
    |CVC.destroy| was used as a way to mark WebContents and other contents layer
    objects as inaccessible. Now that most of CVC's responsibility was migrated
    to other WebContentsUserData-based instances, the API is not useful any more.
    This CL deletes it. The embedders don't have to use it if it also calls
    |WebContents.destroy| or does something equivalent (such as Chromecast,
    which triggers native WebContents deletion by observing its acitivty/fragment
    lifecycl
    ...skip...
    avoid calling into the contents layer being taken down
    where many objects are in transition state, therefore safe access is hard
    to guarantee.
    
    Bug: 598880
    Change-Id: I3cb1b865fd11b6fc9b01377af230b9aff792318a
    Reviewed-on: https://chromium-review.googlesource.com/1084363
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574269}

    Changed files

    • android_webview/java/src/org/chromium/android_webview/AwContents.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
    • chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastWebContentsView.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/view/ContentView.java
    • content/browser/android/gesture_listener_manager.cc
    • content/browser/android/gesture_listener_manager.h
    • content/browser/web_contents/web_contents_android.cc
    • content/browser/web_contents/web_contents_android.h
    • content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java
    • content/public/android/java/src/org/chromium/content/browser/GestureListenerManagerImpl.java
    • content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
    • content/public/android/java/src/org/chromium/content_public/browser/ContentViewCore.java
    • content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
    • content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewCore.java
    • content/shell/android/java/src/org/chromium/content_shell/Shell.java
  139. [Code health] Enable all TouchActionBrowserTests but not on Debug

    Changed by xidachenohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 18:59:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd9869d20cd802e82013e812424c9b32835d4a86

    Comments

    [Code health] Enable all TouchActionBrowserTests but not on Debug
    
    After we landed this CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/1124699
    which deflakes one of the TouchActionBrowserTests, the flakiness
    dashboard shows that all other tests are stable except on Debug bots.
    So this CL enables all the tests and disable them on Debug builds.
    
    TBR=tdresser@chromium.org
    
    Bug: 855979, 833015
    Change-Id: Ie9aff86f735bb6dbe2923f080cbe09f59ee4e1b1
    Reviewed-on: https://chromium-review.googlesource.com/1129099
    Reviewed-by: Sahel Sharify <sahel@chromium.org>
    Reviewed-by: Xida Chen <xidachen@chromium.org>
    Commit-Queue: Xida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574271}

    Changed files

    • content/browser/renderer_host/input/touch_action_browsertest.cc
  140. Download location: Polish histogram description.

    Changed by xingliuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:09:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af706557dc98750dc21b5f007f34559b9afffe9e

    Comments

    Download location: Polish histogram description.
    
    This CL improves the description for download location histogram.
    
    Bug: 792775
    Change-Id: I8c70bd1a41d3626621f107ced4d20487c94a695d
    Reviewed-on: https://chromium-review.googlesource.com/1132085
    Commit-Queue: Xing Liu <xingliu@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574276}

    Changed files

    • tools/metrics/histograms/histograms.xml
  141. Fix oveflow in TimeDelta to Sample conversion in HistogramBase

    Changed by npmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:06:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 761aaa8ec362e94b3032e74f973bb0cb39d5b207

    Comments

    Fix oveflow in TimeDelta to Sample conversion in HistogramBase
    
    This CL changes the static_cast to base::saturated_cast in the AddTime*
    methods since the TimeDelta methods return int64_t whereas Sample is an
    int32_t.
    
    Change-Id: I54e98657c3d32201a0eb0fcd5208236e8b568d7b
    Reviewed-on: https://chromium-review.googlesource.com/1132152
    Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574274}

    Changed files

    • base/metrics/histogram_base.cc
    • base/metrics/histogram_base_unittest.cc
  142. Skip braille output for children changed events on text fields

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:01:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 43f3e80e9e46e20f208223ea3529809d75f1b94b

    Comments

    Skip braille output for children changed events on text fields
    
    A views::TextField triggers kChildrenChanged events from:
    #1 0x55e97f08ad55 AutomationManagerAura::SendEvent()
    #2 0x55e97e30de4a views::View::SetVisible()
    #3 0x55e97e30005b views::Textfield::OnCursorBlinkTimerFired()
    
    as its child cursor view alternates from visible to not visible (providing blinking/flashing effect).
    
    This eventually triggers repeated braille output for the same node and interferes with our blinking logic.
    
    In general, we should probably not observe children changed events on text fields.
    
    Test: manual.
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Ica06c2b2525fb1e7e75aaf89df1d06cb6c2e2956
    Reviewed-on: https://chromium-review.googlesource.com/1133595
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574272}

    Changed files

    • chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
  143. Add documentation link for few benchmarks

    Changed by nednguyenohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:02:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7a061560c4123d22d230d14a83c9d6d37593a36

    Comments

    Add documentation link for few benchmarks
    
    This CL also updates tools/perf/core_data_generator so that it generates the documentation links in the benchmark.csv file
    
    Bug: chromium:859524
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I99c77a9c2bd60ffdab1f8a628a208b2c81aa4ead
    Reviewed-on: https://chromium-review.googlesource.com/1133199
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Annie Sullivan <sullivan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574273}

    Changed files

    • tools/perf/benchmark.csv
    • tools/perf/benchmarks/blink_perf.py
    • tools/perf/benchmarks/loading.py
    • tools/perf/benchmarks/power.py
    • tools/perf/benchmarks/rendering.py
    • tools/perf/benchmarks/system_health.py
    • tools/perf/benchmarks/webrtc.py
    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  144. Extend SW fallback for VP9 SVC to all platforms.

    Changed by ssilkinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:08:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 10acfe9a013ab9382993eb4641aaeaad99711bdd

    Comments

    Extend SW fallback for VP9 SVC to all platforms.
    
    Initially the fallback was only applied to Windows. But we found
    recently that the issue affects ChromeOS as well.
    
    This extends the software fallback to all platforms since we are not
    aware about any HW which can reliably decode VP9 SVC.
    
    Bug: webrtc:9518
    Change-Id: Ie96ffea9f35ae5ce3c1247a1bdf0d6f28f5235c8
    Reviewed-on: https://chromium-review.googlesource.com/1133390
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574275}

    Changed files

    • content/renderer/media/webrtc/rtc_video_decoder.cc
  145. Cleanup ContextType enum and strings.

    Changed by kylecharohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:10:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 589b466c7f8442af8d38c0515216b9683d33cc9d

    Comments

    Cleanup ContextType enum and strings.
    
    This CL cleans up the ContextType enum. The enum values correspond to a
    UMA histogram and string for logging. Make the enum name, UMA histogram
    name and string the same for clarity. The UMA names aren't perfect, but
    they are the one thing we can't easily change.
    
    A few other small changes at the same time:
    1. Remove //services/ui/public/cpp/gpu:internal, it was used to restrict
       access to a ClientGpuMemoryBufferManager but the same thing can be
       accomplished 
    ...skip...
     thread. Deprecate the UMA histogram
       associated with UI_COMPOSITOR.
    
    Bug: 859068
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I31b6f6f460b99eeefd231c9f334d468e58659b51
    Reviewed-on: https://chromium-review.googlesource.com/1129102
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574277}

    Changed files

    • content/browser/compositor/gpu_process_transport_factory.cc
    • content/browser/compositor/viz_process_transport_factory.cc
    • content/browser/renderer_host/compositor_impl_android.cc
    • content/renderer/render_thread_impl.cc
    • content/renderer/renderer_blink_platform_impl.cc
    • content/test/gpu_browsertest_helpers.cc
    • content/test/layouttest_support.cc
    • services/ui/public/cpp/gpu/BUILD.gn
    • services/ui/public/cpp/gpu/command_buffer_metrics.cc
    • services/ui/public/cpp/gpu/command_buffer_metrics.h
    • services/ui/public/cpp/gpu/gpu.cc
    • services/video_capture/device_factory_provider_impl.cc
    • tools/metrics/histograms/histograms.xml
  146. [bluetooth] Make optional Advertisement Data base::Optionals

    Changed by jdoerrieohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:14:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c6971f08006c58729a9ac82aa246ba0ea33322a3

    Comments

    [bluetooth] Make optional Advertisement Data base::Optionals
    
    This change changes the signature of BluetoothDevice's
    UpdateAdvertisementData to pass flags and rx power as base::Optionals
    instead of nullptrs. Also it includes the clearing of advertisment flags
    into BluetoothDevice::ClearAdvertisementData().
    
    Bug: 821766
    Change-Id: Idcbc3ac38844d75c49ade5eff61013034ffbec38
    Reviewed-on: https://chromium-review.googlesource.com/1129219
    Reviewed-by: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574278}

    Changed files

    • chromeos/components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc
    • device/bluetooth/bluetooth_adapter_android.cc
    • device/bluetooth/bluetooth_adapter_mac.mm
    • device/bluetooth/bluetooth_adapter_winrt.cc
    • device/bluetooth/bluetooth_device.cc
    • device/bluetooth/bluetooth_device.h
    • device/bluetooth/test/fake_central.cc
    • device/fido/fido_ble_device_unittest.cc
    • device/fido/fido_cable_discovery_unittest.cc
  147. Check enterprise whitelist before showing chrome://reset-password page

    Changed by jialiulohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e99bb6871535679598083a324bb14a1b2fd2911c

    Comments

    Check enterprise whitelist before showing chrome://reset-password page
    
    Chrome shows chrome://reset-password interstitial only if trigger level is
    configured to be PASSWORD_REUSE and the triggering url is not whitelisted
    by enterprise policy.
    
    Bug: 861945
    Change-Id: I756eca53665e82c5d24484cf42f33891544f291b
    Reviewed-on: https://chromium-review.googlesource.com/1130831
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Commit-Queue: Jialiu Lin <jialiul@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574280}

    Changed files

    • chrome/browser/safe_browsing/chrome_password_protection_service.cc
    • chrome/browser/safe_browsing/chrome_password_protection_service.h
    • chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
    • components/safe_browsing/password_protection/mock_password_protection_service.h
    • components/safe_browsing/password_protection/password_protection_service.cc
    • components/safe_browsing/password_protection/password_protection_service.h
    • tools/metrics/histograms/histograms.xml
  148. [Zucchini] Fix BufferViewBase::covers_array() to allow 0-sized array at end of buffer.

    Changed by huangsohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:16:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b1153fc0b354fd73f63c2324753ad79b42f3fc1

    Comments

    [Zucchini] Fix BufferViewBase::covers_array() to allow 0-sized array at end of buffer.
    
    BufferViewBase::covers_array(offset, num, elt_size) decides whether a
    buffer at |offset| can fit an array with |num| elements, each with
    |elt_size|. A special case is covers_array(size(), 0, elt_size), i.e.,
    can we fit a empty array at end of the buffer?
    
    Previously this was considered to be a pathological case, so the result
    is "false". However, recently it's revealed that this causes some valid
    DEX files to rejec
    ...skip...
     elt_size), and the resulting "false"
    invalidates the DEX file.
    
    The fix is to make the special case return "true". Note that this only
    affects DEX (which is currently the only user of covers_array()).
    
    Change-Id: I2939194f7e91739193e1558361aeb9617bf9c023
    Reviewed-on: https://chromium-review.googlesource.com/1133688
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574279}

    Changed files

    • components/zucchini/buffer_view.h
    • components/zucchini/buffer_view_unittest.cc
  149. Hide VR Intent Dispatcher from Android Default Browser list.

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:22:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3bb7dfb7bf825213c3d489e2471fe3c8823675e9

    Comments

    Hide VR Intent Dispatcher from Android Default Browser list.
    
    The Android platform's Default Browser code has a bug where it allows
    the same package to show up multiple times despite not being able to
    differentiate between the multiple components within the package that
    caused it to detect multiple browsers within the package.
    
    We can trick it into thinking the VR intent handling code isn't default
    browser material by providing a wildcard host, making Android think
    the intent handler uses a URI authority when it really doesn't.
    
    Bug: 847921
    Change-Id: I2b271fc1c99495a0e80e301ff432690dd5a2d0a6
    Reviewed-on: https://chromium-review.googlesource.com/1079261
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574281}

    Changed files

    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappTabDelegate.java
  150. Add --jobs and -j commandline flags for run_webkit_tests.py script

    Changed by nednguyenohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:25:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 416e3e9fd93d2796e07eed5c36c2cac6a662dac7

    Comments

    Add --jobs and -j commandline flags for run_webkit_tests.py script
    
    Bug: 862474
    Change-Id: Ic383add3475ba78abc2a0a9eee0ce0a21e1938e1
    Reviewed-on: https://chromium-review.googlesource.com/1132405
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#574282}

    Changed files

    • third_party/blink/tools/blinkpy/web_tests/bisect_test_ordering.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
    • third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
    • third_party/blink/tools/debug_web_tests
  151. Delete left over tmp file in android build

    Changed by boliuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:26:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9b959230e65301ed32da20cd29ae825cd56b68b1

    Comments

    Delete left over tmp file in android build
    
    Change-Id: I672ae27130ac3f851c7a23904b1d2ce42e37eec9
    Reviewed-on: https://chromium-review.googlesource.com/1133425
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574283}

    Changed files

    • build/android/gyp/apkbuilder.py
  152. Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime

    Changed by smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:30:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59ec1d863c20d9f5d543901bab5d35c4882f1b0a

    Comments

    Remove DCHECK for ScrollTree containment in ScrollTimeline::CurrentTime
    
    The original assertion that if a ScrollTimeline had a non-null scroller
    id (either pending or active) then said id would be in the ScrollTree
    was actually false. There are cases where the ScrollTimeline can have a
    scroller id, but the scrolling element would not be in the ScrollTree -
    for example a composited overflow: visible element would meet this
    criteria.
    
    As such, this CL converts the DCHECK into an early-exit for this case.
    
    Bug: 853231
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I0ca14a8e8f516357ee9814388514ba2f72fdfd47
    Reviewed-on: https://chromium-review.googlesource.com/1133317
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574284}

    Changed files

    • cc/animation/scroll_timeline.cc
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable-expected.html
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-non-scrollable.html
  153. Cleaning up perf data generator now that we are on OBBS

    Changed by eyaichohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:32:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e7dca0885bc6876f53d5285c3ca16c1e48bed7ec

    Comments

    Cleaning up perf data generator now that we are on OBBS
    
    Bug: 757933
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I3268b95bd05eaa9ea86547ccfd8dd7e5d4711c90
    Reviewed-on: https://chromium-review.googlesource.com/1133691
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Commit-Queue: Emily Hanley <eyaich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574285}

    Changed files

    • tools/perf/core/perf_data_generator.py
    • tools/perf/core/perf_data_generator_unittest.py
  154. Disable portion of navigation preload test failing with network service.

    Changed by cmumfordohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:33:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca700a51e4bea95516073239ceb682c0586ba96c

    Comments

    Disable portion of navigation preload test failing with network service.
    
    A recent change (crrev.com/c/1079787) is causing
    a portion of http/tests/serviceworker/navigation_preload/use-counter.html
    to fail when the network service is disabled. Temporarily disabling.
    
    TBR=loonybear@chromium.org,jam@chromium.org
    
    Bug: 862643
    Change-Id: I32848d107bfd7aabdf7de71fc177aebcce386d2a
    Reviewed-on: https://chromium-review.googlesource.com/1133685
    Commit-Queue: Chris Mumford <cmumford@chromium.org>
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574286}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  155. Update V8 to version 6.9.351.

    Changed by v8-ci-autoroll-builderohnoyoudont@chops-service-accounts.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 19:34:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca4ce3f01347ddb612162ee031443b5dbc29b277

    Comments

    Update V8 to version 6.9.351.
    
    Summary of changes available at:
    https://chromium.googlesource.com/v8/v8/+log/c3ce505d..8dc93fc4
    
    Please follow these instructions for assigning/CC'ing issues:
    https://github.com/v8/v8/wiki/Triaging%20issues
    
    Please close rolling in case of a roll revert:
    https://v8-roll.appspot.com/
    This only works with a Google account.
    
    CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tes
    ...skip...
    tional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel
    
    TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com
    
    Change-Id: I9cda5847bd8104c45b418f6c47c784b7352b881c
    Reviewed-on: https://chromium-review.googlesource.com/1133437
    Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574287}

    Changed files

    • DEPS
  156. RC: Make UsageClock work on ChromeOS.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ff0122069f9f0ce5c456c9d8eb3ba74142cc7f7

    Comments

    RC: Make UsageClock work on ChromeOS.
    
    Now that DesktopSessionDurationTracker is built on ChromeOS, UsageClock
    can work the same way on all platforms.
    
    Bug: 775644
    Change-Id: Ic90984b2f36a1ffbf19047fae0bb953d56653eee
    Reviewed-on: https://chromium-review.googlesource.com/1133419
    Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574288}

    Changed files

    • chrome/browser/resource_coordinator/usage_clock.cc
    • chrome/browser/resource_coordinator/usage_clock.h
    • chrome/browser/resource_coordinator/usage_clock_unittest.cc
  157. Removing the client name parameter from autofill server queries.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 19:49:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f799497909efb1abf363546de886bfa71c0025a

    Comments

    Removing the client name parameter from autofill server queries.
    
    When attempting to autofill a form, Chrome queries the autofill server
    for form field predictions. Inside the autofill server query request url is a 'client' parameter. In official Chrome builds, the code sets the parameter value to 'Google+Chrome'. In unofficial Chrome builds, the code sets the parameter value to 'Chromium'.
    
    This discrepany in value between the 'client' parameter causes problems
    for Autofill Captured Sites Interactive
    ...skip...
    aptured request, and return 404. The test would fail.
    
    This autofill server actually does not consume the client parameter. So this fix addresses the above problem by removing the client name parameter from autofill server queries.
    
    Bug: 849778
    Change-Id: Iff9a0d7d4c8052b7f91e940e1a7a2536ec6ac996
    Reviewed-on: https://chromium-review.googlesource.com/1119359
    Reviewed-by: Roger McFarlane <rogerm@chromium.org>
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Cr-Commit-Position: refs/heads/master@{#574290}

    Changed files

    • components/autofill/core/browser/autofill_download_manager.cc
  158. Remove unnecessary thread-affinity in /components/sync*

    Changed by treibohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95851f140e1532050909cdef0f5ea4cd128b20fb

    Comments

    Remove unnecessary thread-affinity in /components/sync*
    
    This CL replaces many instances of ThreadTaskRunnerHandle by
    SequencedTaskRunnerHandle, and SingleThreadTaskRunner by
    SequencedTaskRunner, in /components/sync/, /components/sync_bookmarks/,
    and /components/sync_sessions/.
    
    There are still several ThreadCheckers around which should become
    SequenceCheckers. That will follow in another CL soon.
    
    Bug: 846238
    Change-Id: I180185e0e4d380f69246ccf52b6dd9a1b4cfbee8
    Reviewed-on: https://chromium-review.googlesource.com/1131474
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574289}

    Changed files

    • components/sync/driver/backend_migrator.cc
    • components/sync/driver/data_type_controller.h
    • components/sync/driver/data_type_manager_impl.cc
    • components/sync/driver/fake_data_type_controller.cc
    • components/sync/driver/frontend_data_type_controller_unittest.cc
    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_impl_unittest.cc
    • components/sync/driver/model_type_controller_unittest.cc
    • components/sync/driver/shared_change_processor.cc
    • components/sync/driver/shared_change_processor.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_stopped_reporter.cc
    • components/sync/engine/fake_sync_manager.cc
    • components/sync/engine_impl/model_type_connector_proxy.cc
    • components/sync/engine_impl/model_type_registry.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.cc
    • components/sync/engine_impl/sync_encryption_handler_impl.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl.cc
    • components/sync/engine_impl/sync_scheduler_impl_unittest.cc
    • components/sync/model_impl/client_tag_based_model_type_processor.cc
    • components/sync/model_impl/client_tag_based_model_type_processor_unittest.cc
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync_bookmarks/bookmark_data_type_controller_unittest.cc
    • components/sync_bookmarks/bookmark_model_type_processor.cc
    • components/sync_sessions/session_data_type_controller.cc
    • components/sync_sessions/session_sync_bridge.cc
    • components/sync_sessions/sessions_sync_manager.cc
  159. [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)

    Changed by mahmadiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:53:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df5e2cc33a579c47e6242a808195437092b2f344

    Comments

    [AF][IOS] Takes secondary toolbar into account in CC save infobar (Part 2)
    
    This CL moves the logic to set the infobar's bottom margin from
    |-layoutSubviews| to |-sizeThatFits:|. The former method doesn't
    always get called after the secondary toolbar disappears in
    landscape mode. The latter does get called more reliably in both
    portrait and landscape modes.
    Also provides comments on why |-setFrame:| is overridden.
    
    Bug: 849433
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I3ce410378d60535178a0c0c9d0f12f11948772ba
    Reviewed-on: https://chromium-review.googlesource.com/1112303
    Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574291}

    Changed files

    • ios/chrome/browser/ui/autofill/save_card_infobar_view.mm
  160. Autoplay: allow autoplay for kiosk applications.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 19:54:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e20a770c6072f9563c9c12f001876c7ae59469a

    Comments

    Autoplay: allow autoplay for kiosk applications.
    
    The different with other Chrome Apps is that <webview> should also be
    allowed to autoplay if they are inside a Kiosk application.
    
    Bug: 856659
    Change-Id: If51ca43549d3829eeb9fe25309770467c1fc14c2
    Reviewed-on: https://chromium-review.googlesource.com/1115096
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574292}

    Changed files

    • chrome/browser/extensions/chrome_extension_web_contents_observer.cc
    • chrome/test/base/ash_test_environment_chrome.cc
    • chrome/test/base/ash_test_environment_chrome.h
  161. Revert "Move kApplicationLocale pref to ui/base"

    Changed by ranjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:00:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5908cff94737bde5356c8305a348f66cae6788c2

    Comments

    Revert "Move kApplicationLocale pref to ui/base"
    
    This reverts commit 6ad1cbd1bd26744de3a8d9be9e6fb824ac5c12b3.
    
    Reason for revert: <INSERT REASONING HERE>
    
    Original change's description:
    > Move kApplicationLocale pref to ui/base
    > 
    > We need to use the pref in components, so move the pref to ui/base so it
    > can be accessed.
    > 
    > TBR=jam@chromium.org
    > 
    > Bug: 729596
    > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    > Change-Id: Iffc7
    ...skip...
    omium.org,jam@chromium.org,asvitkine@chromium.org,ranj@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 729596
    Change-Id: I950b8aa43701741de843172f24dd4a1b9887a5de
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1133618
    Reviewed-by: Ran Ji <ranj@chromium.org>
    Commit-Queue: Ran Ji <ranj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574293}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/chrome_browser_main.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/dictation_chromeos.cc
    • chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
    • chrome/browser/chromeos/hats/hats_dialog.cc
    • chrome/browser/chromeos/locale_change_guard.cc
    • chrome/browser/chromeos/login/oobe_localization_browsertest.cc
    • chrome/browser/chromeos/login/screens/welcome_screen.cc
    • chrome/browser/chromeos/login/session/user_session_manager.cc
    • chrome/browser/chromeos/login/ui/login_display_host_webui.cc
    • chrome/browser/extensions/api/settings_private/prefs_util.cc
    • chrome/browser/lifetime/application_lifetime.cc
    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/prefs/chrome_command_line_pref_store.cc
    • chrome/browser/prefs/chrome_command_line_pref_store_unittest.cc
    • chrome/browser/profiles/profile.cc
    • chrome/browser/profiles/profile_impl.cc
    • chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc
    • chrome/browser/search/one_google_bar/one_google_bar_loader_impl_unittest.cc
    • chrome/browser/ui/app_list/arc/arc_app_utils.cc
    • chrome/browser/ui/search/local_ntp_test_utils.cc
    • chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc
    • chrome/browser/ui/webui/settings/languages_handler.cc
    • chrome/common/pref_names.cc
    • chrome/common/pref_names.h
    • chrome/service/service_process.cc
    • ios/chrome/browser/prefs/browser_prefs.mm
    • ui/base/BUILD.gn
    • ui/base/pref_names.cc
    • ui/base/pref_names.h
  162. [Zucchini] DEX parsing: Implement stricter size checks for MapItem.

    Changed by huangsohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f63bf220bcb93560358fbe593ebccc4d64f4baa

    Comments

    [Zucchini] DEX parsing: Implement stricter size checks for MapItem.
    
    This CL fixes a bug discovered by the Fuzzer, where DEX parsing
    triggers CHECK() failure due to an attempt to read a 4-byte value that
    straddles EOF.
    
    Tracing (Zucchini-read) using the Fuzzer-provided DEX show that the
    faulty read attempt is for ClassDefItem::static_values_off, which is
    a field in a fixed-length item.
    
    Our fix is to validate MapItem entries for fixed-length items. Details:
    - Add GetItemBaseSize() to return an item si
    ...skip...
    erform a more
      refined check. For unhandled items, sizes are assumed to be 1.
    - Not checked: Whether MapItems ranges overlap. May do this in the
      future (more refactoring will be needed).
    
    Bug: 862566
    Change-Id: If8efce122979fa1a36d1d445556d414eb499d273
    Reviewed-on: https://chromium-review.googlesource.com/1133713
    Reviewed-by: Samuel Huang <huangs@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574294}

    Changed files

    • components/zucchini/disassembler_dex.cc
  163. Handle hotword enable/disable in assistant service

    Changed by updowndotaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a3ec92579dd20374fbbc96ed991f3ba57b09bc

    Comments

    Handle hotword enable/disable in assistant service
    
    - Restart the Assistant when hotword enable state changes
    - Add mojom methods for hotword_enabled pref.
    
    Bug: b/110219351
    Test: Manual test
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: If45adaab50f412d08b43fdc7b6883acecc2441d8
    Reviewed-on: https://chromium-review.googlesource.com/1117849
    Commit-Queue: Yue Li <updowndota@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574295}

    Changed files

    • ash/public/interfaces/voice_interaction_controller.mojom
    • ash/shelf/app_list_button.h
    • ash/system/palette/tools/metalayer_mode.h
    • ash/voice_interaction/voice_interaction_controller.cc
    • ash/voice_interaction/voice_interaction_controller.h
    • ash/voice_interaction/voice_interaction_controller_unittest.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.cc
    • chrome/browser/chromeos/arc/voice_interaction/fake_voice_interaction_controller.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.h
    • chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client_unittest.cc
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_browser_proxy.js
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.html
    • chrome/browser/resources/settings/google_assistant_page/google_assistant_page.js
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc
    • chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.h
    • chromeos/services/assistant/assistant_manager_service_impl.cc
    • chromeos/services/assistant/assistant_manager_service_impl.h
    • chromeos/services/assistant/service.cc
    • chromeos/services/assistant/service.h
    • chromeos/services/assistant/utils.cc
    • chromeos/services/assistant/utils.h
  164. chromeos: disable LoginWebDialogTest.CannotMinimize

    Changed by skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:08:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bd2556851e3cf048df2cbebfbfa2a2633e89e786

    Comments

    chromeos: disable LoginWebDialogTest.CannotMinimize
    
    for mash_browser_tests as it's flaky.
    
    BUG=855767
    TEST=none
    TBR=msw@chromium.org
    
    Change-Id: Ib0952cdb6aed73556784e9002d2a364d2120fbf7
    Reviewed-on: https://chromium-review.googlesource.com/1134051
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574298}

    Changed files

    • testing/buildbot/filters/mash.browser_tests.filter
  165. Delete the media cache(s) when using a single combined HTTP cache.

    Changed by mmenkeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:05:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e226149af1b3f003b5d3f59e19ee17bef7419c42

    Comments

    Delete the media cache(s) when using a single combined HTTP cache.
    
    This is so that I can try increasing the media cache size in experiments
    without increasing Chrome's profile size (Except possibly for profiles
    that have never been used to play video).
    
    Bug: 789657
    Change-Id: I45e8f8c6e346a1fa7d05b0bea3e8b001d7dc41e1
    Reviewed-on: https://chromium-review.googlesource.com/1130162
    Reviewed-by: Maks Orlovich <morlovich@chromium.org>
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574296}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
  166. Reland "Fix OOPIF hit testing in layout tests."

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:17:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dcee047ec982d521d9ad5301e00ac1bba134f01

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    Original change's description:
    > Fix OOPIF hit testing in layout tests.
    >
    > If we haven't received an activated surface yet ensure that we fallback
    > to querying the renderer for the target of input events.
    >
    > BUG=601584
    >
    > Change-Id: Id5dfcdb6bf54b98bebbd2a3b715d77202f402781
    > Reviewed-on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: I8a2d207db79cc237e1d5e22e5e9bfffb218486c4
    Reviewed-on: https://chromium-review.googlesource.com/1133718
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574304}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  167. Updating Viz Content BrowserTests Filter

    Changed by jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:15:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a57a12587f7ace3b15480262c181ced968346ea4

    Comments

    Updating Viz Content BrowserTests Filter
    
    A few tests have been fixed. This updates the filter accordingly to re-enable them.
    
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
    Bug: 848825, 848348
    
    Change-Id: If05696e57dfee18cc6ae06c21f7d968982c31219
    Reviewed-on: https://chromium-review.googlesource.com/1133863
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574302}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  168. Variations: Rename 'win' to 'windows' in testing config

    Changed by paulmillerohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:07:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ad77b789e40639b5d0d70875d7cc0aa4a506473d

    Comments

    Variations: Rename 'win' to 'windows' in testing config
    
    This is to match server-side tools. Since GN uses "win", there must
    still be some boundary where "win" is converted to "windows"; move the
    conversion from fieldtrial_to_struct.py to field_trial_config/BUILD.gn.
    
    Also add "android_webview" to the field trial config presubmit.
    
    BUG=707911
    
    Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
    Change-Id: I73c2d2fa98410e32ae77d053098d704ee40378ac
    Reviewed-on: https://chromium-review.googlesource.com/1130348
    Commit-Queue: Paul Miller <paulmiller@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Ned Nguyen <nednguyen@google.com>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574297}

    Changed files

    • components/variations/field_trial_config/BUILD.gn
    • testing/variations/PRESUBMIT.py
    • testing/variations/README.md
    • testing/variations/fieldtrial_testing_config.json
    • tools/chrome_proxy/webdriver/variations_combinations.py
    • tools/perf/core/perf_benchmark.py
    • tools/variations/fieldtrial_to_struct.py
    • tools/variations/fieldtrial_to_struct_unittest.py
    • tools/variations/fieldtrial_util.py
    • tools/variations/fieldtrial_util_unittest.py
    • tools/variations/unittest_data/test_config.json
  169. Fix uint8 -> uint8_t

    Changed by oshimaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:11:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 15449df72eb980ce894ee03ac9d8041b204a9df3

    Comments

    Fix uint8 -> uint8_t
    
    It was causing the following compilation error:
    ../../media/gpu/jpeg_encode_accelerator_unittest.cc:415:29: error: unknown type name 'uint8'; did you mean 'uint'?
              static_cast<const uint8*>(hw_out_shm_->memory()), hw_encoded_size,
                                ^~~~~
                                uint
    
    TBR=kcwu@chromium.org
    BUG=None
    TEST=compiles on simple chrome workflow.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If8869b2fe9d1a62e858637fc4b6e412990ad40a9
    Reviewed-on: https://chromium-review.googlesource.com/1133774
    Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574300}

    Changed files

    • media/gpu/jpeg_encode_accelerator_unittest.cc
  170. Fix flaky NPE in VR Dialog tests

    Changed by bsheedyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:09:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6fd7a607f0e9ba82642d92b7a92ecd261da81608

    Comments

    Fix flaky NPE in VR Dialog tests
    
    Fixes a race condition in the code to wait for VR native UI quiescence
    that caused the provided callback to be nulled out prematurely if
    multiple interactions were run in quick succession.
    
    Change-Id: I6d56f8fe6840bd45efc603026b731b0574ad1306
    Reviewed-on: https://chromium-review.googlesource.com/1134038
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574299}

    Changed files

    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/NativeUiUtils.java
  171. Import wpt@23057064c87f42aba0615705b11570ace9cb4324

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:17:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ed5725c80c240b42d7b9ec82a32d1ed7a1fdc7d

    Comments

    Import wpt@23057064c87f42aba0615705b11570ace9cb4324
    
    Using wpt-import in Chromium 8fc67b341c8d30821f9df226a769d97e86523f02.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21177
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I67a2d31dafffcfcbd0d9d5ed1576c0853d6c5644
    Reviewed-on: https://chromium-review.googlesource.com/1133762
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574303}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/audio_loop_base.html
    • third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/media-elements/video_loop_base.html
    • third_party/WebKit/LayoutTests/external/wpt/media/2x2-green.mp4
    • third_party/WebKit/LayoutTests/external/wpt/media/2x2-green.ogv
    • third_party/WebKit/LayoutTests/external/wpt/media/sound_0.mp3
    • third_party/WebKit/LayoutTests/external/wpt/media/sound_0.oga
  172. Supersize: Adds counter for number of symbols of each type

    Changed by tigeroohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3459a089449cdc6728667a5e4d60bf30ac96ffc4

    Comments

    Supersize: Adds counter for number of symbols of each type
    
    The infocard now displays the amount of each type of symbol present in
    a container. This is a 3rd column alongside the existing total byte
    size and percentage columns.
    
    Bug: 847599
    Change-Id: Iab247f1891ee036262956dd585e81864ee8ce12c
    Reviewed-on: https://chromium-review.googlesource.com/1133759
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574301}

    Changed files

    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/infocard-ui.js
    • tools/binary_size/libsupersize/template_tree_view/shared.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  173. Remove unnecessary thread-affinity in /components/browser_sync

    Changed by treibohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c479395ead17e469f8e1406f420a3d058461dc0

    Comments

    Remove unnecessary thread-affinity in /components/browser_sync
    
    This switches a bunch of places in /components/browser_sync from
    ThreadTaskRunnerHandle/SingleThreadTaskRunner to
    SequencedTaskRunnerHandle/SequencedTaskRunner. A few references to
    SingleThreadTaskRunner remain, where it makes sense (e.g. UIModelWorker)
    or where lower layers require it (e.g. WebDataServiceBase).
    
    While we're here, this also changes some Callbacks in
    SigninConfirmationHelper to OnceCallbacks.
    
    Bug: 846238
    Change-Id: I951d95ec442b6b6df4ba3be08674a9eefd4da02c
    Reviewed-on: https://chromium-review.googlesource.com/1131189
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Commit-Queue: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574306}

    Changed files

    • components/browser_sync/abstract_profile_sync_service_test.cc
    • components/browser_sync/profile_sync_test_util.cc
    • components/browser_sync/profile_sync_test_util.h
    • components/browser_sync/signin_confirmation_helper.cc
    • components/browser_sync/signin_confirmation_helper.h
  174. Roll src/third_party/pdfium e7e454da8e38..b165ffb64e59 (2 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 20:18:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9717e66b37a4336e55a1e420bb998ec4f4e07553

    Comments

    Roll src/third_party/pdfium e7e454da8e38..b165ffb64e59 (2 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/e7e454da8e38..b165ffb64e59
    
    
    git log e7e454da8e38..b165ffb64e59 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thestig@chromium.org Use JSGetObject() in more places.
    2018-07-11 art-snake@yandex-team.ru Fix crash and memory leak.
    
    
    Created with:
      gclient setdep -r src/third_party/pdfium@b165ffb64e59
    
    The AutoRoll server is located here: https://pdfium-roll.skia.org
    
    Documentat
    ...skip...
    should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:860210
    TBR=dsinclair@chromium.org
    
    Change-Id: I22163f80735fd7ab47b3879c5ebccd91b216a9e0
    Reviewed-on: https://chromium-review.googlesource.com/1133860
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574305}

    Changed files

    • DEPS
  175. Clean up of unused WebApk metrics.

    Changed by yfriedmanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4df7c6c40ebef72484655dc54db5c40e9f8c2bc2

    Comments

    Clean up of unused WebApk metrics.
    
    I was doing a pass through our metrics and I don't think these are
    actively used or providing value.
    
    TBR=holte
    
    Change-Id: I0ddb0a0fd89237109bf71b41f12611d812a0cc5e
    Reviewed-on: https://chromium-review.googlesource.com/1129374
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
    Reviewed-by: Ran Ji <ranj@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574307}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/metrics/WebApkUma.java
    • tools/metrics/histograms/histograms.xml
  176. Android: Remove legacy --stamp arguments from build scripts

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:26:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 655ea51f430bf9d583dd4d654fa23501ba58558f

    Comments

    Android: Remove legacy --stamp arguments from build scripts
    
    These were used by GYP, and have not been used for some time.
    
    Change-Id: I89c63e1b75d4f32297015fede805247d0cd82d15
    Reviewed-on: https://chromium-review.googlesource.com/1133305
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574308}

    Changed files

    • build/android/gyp/gcc_preprocess.py
    • build/android/gyp/generate_v14_compatible_resources.py
    • build/android/gyp/java_cpp_enum_tests.py
    • build/android/gyp/java_google_api_keys_tests.py
    • build/android/gyp/lint.py
    • build/android/gyp/proguard.py
    • build/android/gyp/util/build_utils.py
    • build/android/gyp/write_ordered_libraries.py
  177. Revert "macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching."

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:35:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df8ff0849861817c9fe9bad0453ddb29785d77fa

    Comments

    Revert "macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching."
    
    This reverts commit c93c3dca594c13251590042f228f8a1029eca985.
    
    Reason for revert: Suspect this caused a crash on 10.13 (dbg): https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3973
    
    Original change's description:
    > macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    > 
    > This matches other macOS application like Safari, Terminal, etc. All exist
    ...skip...
    hromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    TBR=thakis@chromium.org,asvitkine@chromium.org,erikchen@chromium.org
    
    Change-Id: I4ce9b2e4dac1f0f2fae815528a1523326ac1d134
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 851714
    Reviewed-on: https://chromium-review.googlesource.com/1134098
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574311}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  178. Add method "ConfirmSaveAutofillProfile" to AutofillClient.

    Changed by jzwohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:35:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da5ab5f6853c93ea08fe428db7dd22abe62db7d7

    Comments

    Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    
    This method will allow clients to decide if they want to
    save autofill profiles. //ios/web_view may choose to not
    save autofill profiles under some conditions.
    For all other autofill_clients, save like usual.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I33764384ba931c5eb0bb4f3de3810be2f64c70bf
    Reviewed-on: https://chromium-review.googlesource.com/1074269
    Commit-Queue: John Wu <jzw@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574310}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  179. Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.

    Changed by sujiezhuohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 20:34:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b5c0e25f1d7abd563c81d5b2530257150d3fc74

    Comments

    Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    
    For the workflow of the local card migration, we need to know the type of the imported credit card to decide whether to prompt the migration to the user. The type of the imported credit card from the submitted form can be LOCAL_CARD, SERVER_CARD, NEW_CARD and NO_CARD. Currently we have the offering_upload_of_local_credit_card_ variable to denote the imported card is a local card. For the code simpilicity and reus
    ...skip...
    st for imported_credit_card_record_type to check correctness of the imported card type.
    
    The following CL will be solve the triggering logic with the imported_credit_card_record_type.
    
    Bug: 852904
    Change-Id: I09fd790ae324943cb0ad0072be4fef3f56729ca0
    Reviewed-on: https://chromium-review.googlesource.com/1130467
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Sujie Zhu <sujiezhu@google.com>
    Cr-Commit-Position: refs/heads/master@{#574309}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  180. Use the Intervention Policy DB to assist discarding/freezing decisions

    Changed by sebmarchandohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:38:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d26e79ae48f4aabcc86ebba3df8ea85776f7754

    Comments

    Use the Intervention Policy DB to assist discarding/freezing decisions
    
    Other bug fix in this CL: Don't use the Local DB heuristics when an
    extension try to discard a tab.
    
    Bug: 773383
    Change-Id: I1dd378a097d462793f25c382c9f96aa9381775d7
    Reviewed-on: https://chromium-review.googlesource.com/1129620
    Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574312}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/resource_coordinator/intervention_policy_database.cc
    • chrome/browser/resource_coordinator/intervention_policy_database.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc
    • chrome/test/base/testing_browser_process.cc
  181. Remove metrics in Browser.NonCriticalPath

    Changed by yiyixohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:38:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b1e8ede6cc6f5ab8878695e6e0d45a4743b9018d

    Comments

    Remove metrics in Browser.NonCriticalPath
    
    All frames are in the critical path in Browser. i.e., smooth
    does not take priority. So no data is reported in metrics
    BeginMainFrameIntervalNotCritical2 and
    BeginMainFrameQueueDurationNotCritical2.
    
    BUG=856860
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Ibd58bb31ebfdc21f0aae6f5feabbc22ed8fbbcf1
    Reviewed-on: https://chromium-review.googlesource.com/1133427
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Mark Pearson <mpearson@chromium.org>
    Commit-Queue: Yi Xu <yiyix@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574313}

    Changed files

    • cc/scheduler/compositor_timing_history.cc
    • tools/metrics/histograms/histograms.xml
  182. Create concrete base class for AXPlatformNodeDelegate

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:40:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0088cd120e9b1edfc64f7c2732f64341db6a692d

    Comments

    Create concrete base class for AXPlatformNodeDelegate
    
    The reason to make a pure-virtual class is to ensure that if someone
    adds a new function it must be overridden by all subclasses.
    
    Here are the subclasses of AXPlatformNodeDelegate, and how much they
    implement / override:
    
    * BrowserAccessibility: all
    * NativeViewAccessibilityBase: most
    * TestAXNodeWrapper: most
    * AXSystemCaretWin: a little bit
    * AuraLinuxApplication: a little bit
    
    Every time we added a new interface, it didn't seem to make sense t
    ...skip...
    hem in AXSystemCaretWin and AuraLinuxApplication if
    they weren't needed.
    
    This change adds AXPlatformNodeDelegateBase with default
    implementations of everything. Then most subclasses can
    override exactly what they need and no more.
    
    Bug: none
    Change-Id: I7ad78e9403c92b576881969e035d14174222bb3d
    Reviewed-on: https://chromium-review.googlesource.com/1132093
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574315}

    Changed files

    • content/browser/accessibility/browser_accessibility.h
    • ui/accessibility/BUILD.gn
    • ui/accessibility/platform/ax_platform_node_delegate.h
    • ui/accessibility/platform/ax_platform_node_delegate_base.cc
    • ui/accessibility/platform/ax_platform_node_delegate_base.h
    • ui/accessibility/platform/ax_system_caret_win.cc
    • ui/accessibility/platform/ax_system_caret_win.h
    • ui/accessibility/platform/test_ax_node_wrapper.cc
    • ui/accessibility/platform/test_ax_node_wrapper.h
    • ui/views/accessibility/native_view_accessibility_auralinux.cc
    • ui/views/accessibility/native_view_accessibility_base.cc
    • ui/views/accessibility/native_view_accessibility_base.h
  183. Make NetworkConnectionTracker survive network service crashes and restarts

    Changed by xunjieliohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:39:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cec0800c372ef670f59999fb3f028013d36b866c

    Comments

    Make NetworkConnectionTracker survive network service crashes and restarts
    
    This CL is to mirror tbansal@'s CL
    (https://chromium-review.googlesource.com/1058528) to make
    NetworkConnectionTracker survice network service's crashes and restarts.
    
    Bug: 821009
    Change-Id: Iec33797c0fd0ce12a8e5fdab9fda0a710eb9a528
    Reviewed-on: https://chromium-review.googlesource.com/1120738
    Commit-Queue: Helen Li <xunjieli@chromium.org>
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574314}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc
  184. Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:45:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eda64b390b4dd364363c6cf1b17c9a08f8a645f3

    Comments

    Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    
    This reverts commit 8b5c0e25f1d7abd563c81d5b2530257150d3fc74.
    
    Reason for revert: breaks compile on Cast Linux
    https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    
    Original change's description:
    > Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.
    > 
    > For the workflow of the local card migration, we need to know the type of the imported c
    ...skip...
    <sujiezhu@google.com>
    > Cr-Commit-Position: refs/heads/master@{#574309}
    
    TBR=sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I9f5d6752dfc50f4b830d6286b9188d66df36ee6a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134118
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574318}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  185. User Manager WebUI: update bg color

    Changed by aeeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:41:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be221fc5f10b2250a6bf6064cc51297b71f35656

    Comments

    User Manager WebUI: update bg color
    
    Bug: 862273
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I3137dfd35e896196b2c6ee364cdbf4540823e9e6
    Reviewed-on: https://chromium-review.googlesource.com/1132492
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574317}

    Changed files

    • chrome/browser/resources/md_user_manager/shared_styles.html
    • chrome/browser/resources/md_user_manager/user_manager.html
  186. Downloads WebUI: allow toolbar to resize along with decreased window widths

    Changed by aeeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:46:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a76b5ec55bca210fa0601a64e9724bf1dd528961

    Comments

    Downloads WebUI: allow toolbar to resize along with decreased window widths
    
    Bug: 841708
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iae485cc912bed7bcbb3ebd6e435c5f3d0208a550
    Reviewed-on: https://chromium-review.googlesource.com/1124982
    Reviewed-by: Scott Chen <scottchen@chromium.org>
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574319}

    Changed files

    • chrome/browser/resources/md_downloads/manager.html
  187. Optimize infinite ClipRect cases a bit more.

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:46:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a335c9fe7f2ded9e83b64e85d45e623b2cf6b729

    Comments

    Optimize infinite ClipRect cases a bit more.
    
    This reduced time in deep-layers.html (rom https://chromium-review.googlesource.com/c/chromium/src/+/1101824)
    by about 5%.
    
    Bug:831762
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I338274cd96335300054ca347cd5bc53aff700de6
    Reviewed-on: https://chromium-review.googlesource.com/1132490
    Reviewed-by: vmpstr <vmpstr@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574320}

    Changed files

    • third_party/blink/renderer/core/paint/clip_rect.cc
    • third_party/blink/renderer/core/paint/clip_rect.h
    • third_party/blink/renderer/core/paint/clip_rect_test.cc
    • third_party/blink/renderer/core/paint/paint_layer_clipper.cc
  188. MediaButtonReceiver: update logging and behavior when receiving invalid intent.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:47:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f892f7f11ab2136b78a2f041ca48da8e60fec3c2

    Comments

    MediaButtonReceiver: update logging and behavior when receiving invalid intent.
    
    Bug: None
    Change-Id: I7d714f5a10f9cdce90ce251f3e415e75897a07e7
    Reviewed-on: https://chromium-review.googlesource.com/1133741
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574321}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
  189. Clean up wheel scroll latching and async wheel events flags.

    Changed by sahelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:40:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6d81f47c871e49bb60ab45804dcb11e7c801667

    Comments

    Clean up wheel scroll latching and async wheel events flags.
    
    This cl removes the wheel scroll latching and async wheel event flags
    which have been enabled by default since M65.
    
    Bug: 859171
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I9597a055774fe3d38f15444e41c0236ed564a3a9
    Reviewed-on: https://chromium-review.googlesource.com/1121057
    Commit-Queue: Sahel Sharify <sahel@chromium.org>
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: danakj <danakj@chromium.org>
    Reviewed-by: Kevin McNee <mcnee@chromium.org>
    Reviewed-by: Timothy Dresser <tdresser@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574316}

    Changed files

    • cc/input/input_handler.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_impl_unittest.cc
    • cc/trees/layer_tree_host_unittest_scroll.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • content/browser/devtools/protocol/input_handler.cc
    • content/browser/frame_host/cross_process_frame_connector.cc
    • content/browser/pointer_lock_browsertest.cc
    • content/browser/renderer_host/input/fling_controller.cc
    • content/browser/renderer_host/input/fling_controller.h
    • content/browser/renderer_host/input/fling_controller_unittest.cc
    • content/browser/renderer_host/input/input_router_impl.cc
    • content/browser/renderer_host/input/input_router_impl.h
    • content/browser/renderer_host/input/input_router_impl_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_event_queue.cc
    • content/browser/renderer_host/input/mouse_wheel_event_queue.h
    • content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • content/browser/renderer_host/input/wheel_scroll_latching_browsertest.cc
    • content/browser/renderer_host/overscroll_controller.cc
    • content/browser/renderer_host/overscroll_controller.h
    • content/browser/renderer_host/render_widget_host_impl.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.cc
    • content/browser/renderer_host/render_widget_host_input_event_router.h
    • content/browser/renderer_host/render_widget_host_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_android.cc
    • content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_base.cc
    • content/browser/renderer_host/render_widget_host_view_base.h
    • content/browser/renderer_host/render_widget_host_view_child_frame.cc
    • content/browser/renderer_host/render_widget_host_view_child_frame.h
    • content/browser/renderer_host/render_widget_host_view_child_frame_unittest.cc
    • content/browser/renderer_host/render_widget_host_view_event_handler.cc
    • content/browser/renderer_host/render_widget_host_view_mac.mm
    • content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
    • content/browser/site_per_process_browsertest.cc
    • content/browser/site_per_process_hit_test_browsertest.cc
    • content/browser/site_per_process_mac_browsertest.mm
    • content/child/runtime_features.cc
    • content/public/common/content_features.cc
    • content/public/common/content_features.h
    • content/renderer/input/widget_input_handler_manager.cc
    • testing/buildbot/filters/fuchsia.content_unittests.filter
    • testing/buildbot/filters/mash.browser_tests.filter
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/VirtualTestSuites
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt
    • third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/events/wheel/README.txt
    • third_party/blink/public/platform/web_gesture_event.h
    • third_party/blink/public/platform/web_runtime_features.h
    • third_party/blink/renderer/core/input/mouse_wheel_event_manager.cc
    • third_party/blink/renderer/platform/exported/web_runtime_features.cc
    • ui/compositor/overscroll/scroll_input_handler.cc
    • ui/events/blink/input_handler_proxy.cc
    • ui/events/blink/input_handler_proxy.h
    • ui/events/blink/input_handler_proxy_client.h
    • ui/events/blink/input_handler_proxy_unittest.cc
    • ui/events/blink/web_input_event_traits.cc
    • ui/events/blink/web_input_event_traits.h
  190. Re-mark csp test as flaky (was speculatively unmarked).

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:47:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a18e8a4a19f2f5dd2d52b8d715da8fa61a3b9654

    Comments

    Re-mark csp test as flaky (was speculatively unmarked).
    
    Bug: 818324
    Change-Id: Ie3b8afb30a9a84c124cbe22978e1dd491dbe84e4
    TBR: dpranke@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134052
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574322}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  191. Roll src/third_party/angle 5c8113d3c20f..89ef177f9475 (3 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 20:48:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5e3b22a638ef80bbd479bbf91259e8bd02b732ed

    Comments

    Roll src/third_party/angle 5c8113d3c20f..89ef177f9475 (3 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/5c8113d3c20f..89ef177f9475
    
    
    git log 5c8113d3c20f..89ef177f9475 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 geofflang@chromium.org EGL: Fix binding EGL_NO_SURFACE without surfaceless support.
    2018-07-11 jmadill@chromium.org Vulkan: Remove vk::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Implement sampler structs as function args.
    
    
    Created with:
      gclient se
    ...skip...
    ;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: I6502f767d05dac13d2c0c5d1ea69df7d973e9b43
    Reviewed-on: https://chromium-review.googlesource.com/1133858
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574323}

    Changed files

    • DEPS
  192. Adjust overlay scrollbar reparenting trigger logic

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:48:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 496307f84f8edf8fd2c11cf3e36854ed77c4632a

    Comments

    Adjust overlay scrollbar reparenting trigger logic
    
    - Determine non-stacked-with-in-flow-stacked descendants scrollers, and use that
    information to decide when to reparent overlay scrollbars. Delete old logic.
    - Implement this new
    bit in the descendant-dependent PaintLayer tree walk. Move the has-self-painting-
    layer-descendant bit to that tree walk also.
    
    
    Overlay scrollbars for an overflow scrolling element need to paint after all
    content that scrolls under it. If the element is stacked, this is eas
    ...skip...
    t was computed in its own tree walk with
    its own dirty bit, which was unnecessarily complicated and slow.
    
    
    Bug: 857035
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Idcf8fdf0ab20ca25edc9e5ff33c203efee392dbd
    Reviewed-on: https://chromium-review.googlesource.com/1128333
    Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574324}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.png
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned-expected.txt
    • third_party/WebKit/LayoutTests/compositing/overflow/scrollbar-layer-placement-negative-z-index-child-positioned.html
    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
    • third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
    • third_party/blink/renderer/core/paint/compositing/graphics_layer_tree_builder.cc
    • third_party/blink/renderer/core/paint/paint_layer.cc
    • third_party/blink/renderer/core/paint/paint_layer.h
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • third_party/blink/renderer/core/paint/paint_layer_test.cc
  193. Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:52:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69ff8256385b83c6eae31f1446e94323dc504287

    Comments

    Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    
    This reverts commit eda64b390b4dd364363c6cf1b17c9a08f8a645f3.
    
    Reason for revert: There is already a dependent change.
    
    Original change's description:
    > Revert "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    > 
    > This reverts commit 8b5c0e25f1d7abd563c81d5b2530257150d3fc74.
    > 
    > Reason for revert: breaks compile on Cast Linux
    > https://ci.chromium.org/p/chromium
    ...skip...
    
    > Cr-Commit-Position: refs/heads/master@{#574318}
    
    TBR=waffles@chromium.org,sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I030a7f4e25a44ff2d6932628c0b54241fce8085c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134138
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574325}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  194. Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 560191224bcaf8390e0745a16bdf8975a1add6bf

    Comments

    Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    
    Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    
    Original change's description:
    > Add method "ConfirmSaveAutofillProfile" to AutofillClient.
    > 
    > This method will allow clients to decide if they want to
    > save autofill profiles. //ios/web_view may choose to not
    > save autofill profiles under some condition
    ...skip...
    hromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I570967926d1f38e675aa9980a9a5181e6270bb2d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134139
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574326}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  195. Revert "Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.""

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:57:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 58332a8d64507e81052c08a588c7fa1649c86620

    Comments

    Revert "Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type.""
    
    This reverts commit 69ff8256385b83c6eae31f1446e94323dc504287.
    
    Reason for revert: Dependent change now reverted, reverting this one as well.
    
    Original change's description:
    > Reland "Change offering_upload_of_local_credit_card to an enum imported_credit_card_record_type."
    > 
    > This reverts commit eda64b390b4dd364363c6cf1b17c9a08f8a645f3.
    > 
    > Reason for revert: There is already a dependent chang
    ...skip...
    
    > Cr-Commit-Position: refs/heads/master@{#574325}
    
    TBR=waffles@chromium.org,sebsg@chromium.org,jsaul@google.com,jiahuiguo@chromium.org,siyua@google.com,sujiezhu@google.com
    
    Change-Id: I63e14d46d868547eb6859f485581bfb2d8a2091b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 852904
    Reviewed-on: https://chromium-review.googlesource.com/1134119
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574327}

    Changed files

    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
  196. Optimization in java/preferences + trivial cleanup in java/compositor

    Changed by marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 20:59:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 672e508eaf7ee440129bf98f54842b8cab4c9a84

    Comments

    Optimization in java/preferences + trivial cleanup in java/compositor
    
    Moving separate methods in one in the PrefServiceBridge +
    using *.PERMISSIONS in SiteSettingsCategory +
    
    some mechanical trivial cleanup in compositor files.
    
    Note: preferences work is another part after https://chromium-review.googlesource.com/c/chromium/src/+/1097408
    
    Change-Id: I6fab5994368ebc258863c65811559f5151056fe0
    Reviewed-on: https://chromium-review.googlesource.com/1109817
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574330}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelTextViewInflater.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsCategory.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/NotificationsPreferencesTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreferencesTest.java
  197. ozone: evdev: Replace VLOG with DVLOG

    Changed by chongjiangohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:58:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 69457fa19c040700fd28ae3b9a942373f5c35427

    Comments

    ozone: evdev: Replace VLOG with DVLOG
    
    BUG=chromium:489441
    
    VLOG() has a high overhead due to pattern matching. Calling it here
    accounts for ~0.9% of all cycles spent in Chrome on ChromeOS devices.
    
    Change-Id: I5c6c94fdc2edcd96bf26d9450c591fcc16c521a9
    Reviewed-on: https://chromium-review.googlesource.com/1132432
    Reviewed-by: Michael Spang <spang@chromium.org>
    Commit-Queue: Chong Jiang <chongjiang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574328}

    Changed files

    • ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc
  198. [Payments] Add feature to only send address countries in GetUploadDetails

    Changed by mathpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 20:58:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 829a85709e1eb1a2b736aa38040cfad59c409742

    Comments

    [Payments] Add feature to only send address countries in GetUploadDetails
    
    Feature is disabled by default.
    
    Also renames some functions in the TestPaymentsClient.
    
    Bug: 862465
    Change-Id: Idf44bfbca180266f43914a165603ad6be4c88794
    Reviewed-on: https://chromium-review.googlesource.com/1132404
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574329}

    Changed files

    • components/autofill/core/browser/credit_card_save_manager.cc
    • components/autofill/core/browser/credit_card_save_manager.h
    • components/autofill/core/browser/credit_card_save_manager_unittest.cc
    • components/autofill/core/browser/payments/test_payments_client.cc
    • components/autofill/core/browser/payments/test_payments_client.h
    • components/autofill/core/common/autofill_features.cc
    • components/autofill/core/common/autofill_features.h
  199. Set root as the "common_transform_ancestor" if there is no compositing container for squashing.

    Changed by chrishtrohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:03:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1b4460d9ccaf07f8010c980126bec388652e648

    Comments

    Set root as the "common_transform_ancestor" if there is no compositing container for squashing.
    
    Bug: 854381
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I34aa3bf133d71c2809b13c7efe45f1d5307b99cd
    Reviewed-on: https://chromium-review.googlesource.com/1132466
    Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
    Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574331}

    Changed files

    • third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
  200. Adding OWNERS for webauth java directories.

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:07:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3b653bb9d2b1d1d7bbd4e1a4f9894c187337028

    Comments

    Adding OWNERS for webauth java directories.
    
    Change-Id: Id36ba1d261aae6b4a6c72597046a343448c38a55
    Reviewed-on: https://chromium-review.googlesource.com/1125405
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574333}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/webauth/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/webauth/OWNERS
  201. Roll src/third_party/perfetto 256c9c48ab20..f37ffaf9b1a1 (1 commits)

    Changed by perfetto-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 21:03:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 88b4645c0f83e2cb7c76457bc1dd400d5ed24165

    Comments

    Roll src/third_party/perfetto 256c9c48ab20..f37ffaf9b1a1 (1 commits)
    
    https://android.googlesource.com/platform/external/perfetto.git/+log/256c9c48ab20..f37ffaf9b1a1
    
    
    git log 256c9c48ab20..f37ffaf9b1a1 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 lalitm@google.com trace_processor: update sched slice table to use new query serializer
    
    
    Created with:
      gclient setdep -r src/third_party/perfetto@f37ffaf9b1a1
    
    The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org
    
    Docu
    ...skip...
    , please contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:80416541
    TBR=perfetto-bugs@google.com
    
    Change-Id: I42f8e4e668e662c199a44f054864a272bad5153a
    Reviewed-on: https://chromium-review.googlesource.com/1133859
    Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574332}

    Changed files

    • DEPS
  202. Update Chrome callsites that use MainThreadFrameObserver

    Changed by jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:09:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cb82e2e48313e755713f169fa151199fec459a02

    Comments

    Update Chrome callsites that use MainThreadFrameObserver
    
    MainThreadFrameObserver does not guarantee that a compositor frame was actually
    submitted. It however does synchronize the Renderer's main thread, which allows
    for syncing Javascript execution in tests.
    
    This updates two tests in chrome/browser to use RenderFrameSubmissionObserver
    for synchronizing on compositor frame submission. As well as InputEventAckWaiter
    for synchronizing on input event processing.
    
    TEST=WebViewTest.InterstitialPageFocusedWidget,
    WebViewBrowserPluginSpecificInteractiveTest.EnsureFocusSynced
    
    Bug: 862683
    Change-Id: Iae40b92dedf656898b9e77c6529ef118d89e0a6e
    Reviewed-on: https://chromium-review.googlesource.com/1133960
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574335}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  203. Mark sampling-heap-profiler* tests as flaky on MSAN

    Changed by alphohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:08:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c4149316c00d643eeddbe3418e8ccf0bb8649973

    Comments

    Mark sampling-heap-profiler* tests as flaky on MSAN
    
    TBR=dgozman@chromium.org,dpranke@chromium.org
    NOTRY=true
    BUG=862750
    
    Change-Id: I715c03f9f1b62bf53d501df35699ad5918ef0d67
    Reviewed-on: https://chromium-review.googlesource.com/1134188
    Reviewed-by: Alexei Filippov <alph@chromium.org>
    Commit-Queue: Alexei Filippov <alph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574334}

    Changed files

    • third_party/WebKit/LayoutTests/MSANExpectations
  204. Roll src/third_party/catapult 4c70b5037475..5c0d851abe6e (3 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 21:14:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c5242ed0373704ac218c2d1af0c2af4b34def3ec

    Comments

    Roll src/third_party/catapult 4c70b5037475..5c0d851abe6e (3 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/4c70b5037475..5c0d851abe6e
    
    
    git log 4c70b5037475..5c0d851abe6e --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Re-enable ListTestSuitesTest.testPartialTestSuites
    2018-07-11 dtu@chromium.org [pinpoint] Add --also-run-disabled-tests flag to Telemetry runs.
    2018-07-11 dtu@chromium.org [pinpoint] Use new Change stub in the Change test.
    
    
    C
    ...skip...
    u_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:860103
    TBR=sullivan@chromium.org
    
    Change-Id: I962dc9fa532702aa881636a36062de73b67c4d2d
    Reviewed-on: https://chromium-review.googlesource.com/1133778
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574338}

    Changed files

    • DEPS
  205. disable fast/canvas/color-space/canvas-drawImage-*

    Changed by mtkleinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:12:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f00775a25c39096b10bfefb736e3e3e786303579

    Comments

    disable fast/canvas/color-space/canvas-drawImage-*
    
    These layout tests exercise color management with transparency,
    which is known to be a little broken.  Disable the tests so that
    we can roll Skia code with a fix.
    
    I'm still puzzled why we didn't catch the virtual/gpu versions
    of these tests earlier.
    
    Bug: chromium:859102
    Change-Id: I0bfd3014b80e91adbfc82a08746205e1fd35764e
    Reviewed-on: https://chromium-review.googlesource.com/1134025
    Reviewed-by: Florin Malita <fmalita@chromium.org>
    Commit-Queue: Mike Klein <mtklein@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574336}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  206. Clean up AudioDestinationNode

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:12:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3e11cf3cb81cc08f9bb78c5063f370cd21c8059

    Comments

    Clean up AudioDestinationNode
    
    1. Add and clarify comments.
    2. Reorder methods for the readability.
      (WebIDL, Inherited actions, Own actions, Getters,
       Member variables)
    
    Bug: 854228
    Test: Passes all layout tests.
    Change-Id: I47e27e86fa17272fc2cce1c0b8bb85c8da8b1ea6
    Reviewed-on: https://chromium-review.googlesource.com/1124924
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574337}

    Changed files

    • third_party/blink/renderer/modules/webaudio/audio_destination_node.h
  207. Supersize: Organize dex methods into class containers

    Changed by tigeroohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 21:22:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6c883823a93d9e693ecb5b6c6ae63eda0a76b63a

    Comments

    Supersize: Organize dex methods into class containers
    
    Introduces a new container type for java classes. Classes are found by
    splitting dex methods where the "#" character appears.
    
    Additionally moves the zero-space character to be client-side only. The
    UI thread inserts the character when creating new tree node elements.
    
    Bug: 847599
    Change-Id: Ib65a4100797a84bff35502303990ac89a383a808
    Reviewed-on: https://chromium-review.googlesource.com/1134049
    Commit-Queue: Tiger Oakes <tigero@google.com>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Reviewed-by: Eric Stevenson <estevenson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574340}

    Changed files

    • tools/binary_size/libsupersize/html_report.py
    • tools/binary_size/libsupersize/template_tree_view/index.html
    • tools/binary_size/libsupersize/template_tree_view/shared.js
    • tools/binary_size/libsupersize/template_tree_view/state.js
    • tools/binary_size/libsupersize/template_tree_view/tree-ui.js
    • tools/binary_size/libsupersize/template_tree_view/tree-worker.js
  208. [NTP] Remove border style from edit dialog

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:21:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da7657cebecffb3b5b1697afff8b3069c4685a86

    Comments

    [NTP] Remove border style from edit dialog
    
    Bug: 860277
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I42bbae694914fa9510271475732253f86cb29823
    Reviewed-on: https://chromium-review.googlesource.com/1133768
    Commit-Queue: Kyle Milka <kmilka@chromium.org>
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574339}

    Changed files

    • chrome/browser/resources/local_ntp/custom_backgrounds.css
  209. Pulled out AssistantScreenContextController from AssistantController.

    Changed by dmblackohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 21:29:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c22e43516c9fcb5d99df6b434170a66304826159

    Comments

    Pulled out AssistantScreenContextController from AssistantController.
    
    In addition, this CL:
    - Adds an AssistantScreenContextModel/Observer.
    - Inactivates the Assistant widget on show.
    - Activates the Assistant widget on screen context request finished.
    
    The AssistantScreenContextModel will also be used to cache contextual
    cards returned from the server. This will be added in a follow up CL.
    
    Bug: b:111008970
    Change-Id: I0cd2cb782b880abc520bc4a8fca3c82acc1575c7
    Reviewed-on: https://chromium-review.googlesource.com/1131914
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Muyuan Li <muyuanli@chromium.org>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574341}

    Changed files

    • ash/BUILD.gn
    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_controller_unittest.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_notification_controller.h
    • ash/assistant/assistant_screen_context_controller.cc
    • ash/assistant/assistant_screen_context_controller.h
    • ash/assistant/assistant_screen_context_controller_unittest.cc
    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/assistant_ui_controller.h
    • ash/assistant/model/assistant_screen_context_model.cc
    • ash/assistant/model/assistant_screen_context_model.h
    • ash/assistant/model/assistant_screen_context_model_observer.h
  210. Refactoring network update infrastructure for Settings UI

    Changed by jordynassohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:36:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7381379b8f1bc835900dc076ea3f2f25c636c4b8

    Comments

    Refactoring network update infrastructure for Settings UI
    
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I408048d36cca91f003aaa691956a14916e402ee1
    Reviewed-on: https://chromium-review.googlesource.com/1132618
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574342}

    Changed files

    • chrome/browser/resources/settings/internet_page/BUILD.gn
    • chrome/browser/resources/settings/internet_page/internet_page.html
    • chrome/browser/resources/settings/internet_page/internet_page.js
    • chrome/browser/resources/settings/internet_page/network_listener_behavior.html
    • chrome/browser/resources/settings/internet_page/network_listener_behavior.js
    • chrome/browser/resources/settings/settings_resources.grd
  211. DevTools: do not use rare data for document fields, place them into the snapshot instead.

    Changed by pfeldmanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:36:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d162903a9361717c7229b369dd9638b9fdd1fa49

    Comments

    DevTools: do not use rare data for document fields, place them into the snapshot instead.
    
    Change-Id: I84ef8bff512fad9b66f6e40aa2ebc1b8dcb1337f
    Reviewed-on: https://chromium-review.googlesource.com/1133967
    Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574343}

    Changed files

    • third_party/blink/renderer/core/inspector/browser_protocol.pdl
    • third_party/blink/renderer/core/inspector/inspector_dom_snapshot_agent.cc
  212. Clean up MASH_DEPRECATED drag and drop code in ash

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:37:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 93614f04286a20b6bf353f0910bf69dfb3ce6ae7

    Comments

    Clean up MASH_DEPRECATED drag and drop code in ash
    
    Ash now controls drag and drop.
    
    Bug: none
    Test: ash_unittests, can drag and drop text between windows
    Change-Id: Iae453a3902597bb518f29ccf267a40b115d6cb6d
    Reviewed-on: https://chromium-review.googlesource.com/1134092
    Commit-Queue: Michael Wasserman <msw@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574344}

    Changed files

    • ash/drag_drop/drag_drop_controller_unittest.cc
    • ash/shell.cc
  213. tcmalloc: Move existing tcmalloc files under gperftools-2.0.

    Changed by gmxohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:38:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 615e0342e44cbe073b1958ab9f5a318d799f6f34

    Comments

    tcmalloc: Move existing tcmalloc files under gperftools-2.0.
    
    Move existing tcmalloc files, both vendor and chromium, under gperftools-2.0
    in preparation for upreving tcmalloc to the most recent gperftools version.
    
    This CL did:
    
      # Create a gerftools-2.0 folder.
      mkdir gperftools-2.0
    
      # Move vendor/ and chromium/ under the new folder.
      git mv vendor gperftools-2.0/vendor
      git mv chromium gperftools-2.0/chromium
    
      # Update //base/allocator/BUILD.gn to have tcmalloc_dir point to
      # //third_part
    ...skip...
    tools-2.0/chromium/src.
      # Update addr2line-pdb sources in tcmalloc/BUILD.gn.
      # Update include paths in files under //base/process and //base/allocator.
    
    This is old code that uses currently banned functions.
    NOPRESUBMIT=true
    
    BUG=724399,b:70905156
    
    Change-Id: I498a6edda48e178bbacfb41e30f75e9e96e336fc
    Reviewed-on: https://chromium-review.googlesource.com/1130670
    Reviewed-by: Will Harris <wfh@chromium.org>
    Commit-Queue: Gabriel Marin <gmx@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574346}

    Changed files

    • base/allocator/BUILD.gn
    • base/allocator/allocator_extension.cc
    • base/allocator/allocator_shim_default_dispatch_to_tcmalloc.cc
    • base/allocator/debugallocation_shim.cc
    • base/process/memory_linux.cc
    • third_party/tcmalloc/BUILD.gn
    • third_party/tcmalloc/chromium/src/config.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/OWNERS
    • third_party/tcmalloc/gperftools-2.0/chromium/src/addressmap-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/abort.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/abort.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-mips.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/atomicops.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/basictypes.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/commandlineflags.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/cycleclock.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/dynamic_annotations.c
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/dynamic_annotations.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/elf_mem_image.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/elf_mem_image.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/elfcore.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/googleinit.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/linux_syscall_support.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/linuxthreads.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/linuxthreads.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/logging.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/logging.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/low_level_alloc.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/low_level_alloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/simple_mutex.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_internal.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_internal.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/stl_allocator.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/synchronization_profiling.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/sysinfo.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/sysinfo.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/thread_annotations.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/thread_lister.c
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/thread_lister.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/vdso_support.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/base/vdso_support.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/central_freelist.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/central_freelist.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/common.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/common.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config.h.in
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config_android.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config_for_unittests.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config_freebsd.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config_linux.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/config_win.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/debugallocation.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/free_list.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/free_list.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/getpc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/heap-checker.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/heap-profiler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/malloc_extension.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/malloc_extension_c.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/malloc_hook.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/malloc_hook_c.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/profiler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/stacktrace.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/google/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/heap-checker.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/profiler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/stacktrace.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-checker-bcad.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-checker.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-profile-stats.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-profile-table.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-profile-table.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/heap-profiler.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/internal_logging.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/internal_logging.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/libc_override.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/libc_override_glibc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/libc_override_osx.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/libc_override_redefine.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/linked_list.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/linux_shadow_stacks.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/linux_shadow_stacks.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/malloc_extension.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/malloc_hook-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/malloc_hook.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/maybe_threads.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/maybe_threads.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/memfs_malloc.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/memory_region_map.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/memory_region_map.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/packed-cache-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/page_heap.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/page_heap.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/page_heap_allocator.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/pagemap.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/pprof
    • third_party/tcmalloc/gperftools-2.0/chromium/src/profile-handler.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/profile-handler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/profiledata.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/profiledata.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/profiler.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/raw_printer.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/raw_printer.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/sampler.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/sampler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/solaris/libstdc++.la
    • third_party/tcmalloc/gperftools-2.0/chromium/src/span.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/span.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stack_trace_table.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stack_trace_table.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_android-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_config.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_mips-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_with_context.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/static_vars.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/static_vars.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/symbolize.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/symbolize.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/system-alloc.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/system-alloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tcmalloc.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tcmalloc_guard.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/frag_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/getpc_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/page_heap_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/sampler_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/sampling_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/sampling_test.sh
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/testutil.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/testutil.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/thread_cache.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/thread_cache.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/TODO
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/config.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/mingw.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/mini_disassembler.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/nm-pdb.c
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/override_functions.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/patch_functions.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/port.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/port.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/preamble_patcher.h
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/gperftools-2.0/chromium/src/windows/shortproc.asm
    • third_party/tcmalloc/gperftools-2.0/vendor/AUTHORS
    • third_party/tcmalloc/gperftools-2.0/vendor/COPYING
    • third_party/tcmalloc/gperftools-2.0/vendor/ChangeLog
    • third_party/tcmalloc/gperftools-2.0/vendor/INSTALL
    • third_party/tcmalloc/gperftools-2.0/vendor/Makefile.am
    • third_party/tcmalloc/gperftools-2.0/vendor/Makefile.in
    • third_party/tcmalloc/gperftools-2.0/vendor/NEWS
    • third_party/tcmalloc/gperftools-2.0/vendor/README
    • third_party/tcmalloc/gperftools-2.0/vendor/README_windows.txt
    • third_party/tcmalloc/gperftools-2.0/vendor/TODO
    • third_party/tcmalloc/gperftools-2.0/vendor/aclocal.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/autogen.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/compile
    • third_party/tcmalloc/gperftools-2.0/vendor/config.guess
    • third_party/tcmalloc/gperftools-2.0/vendor/config.sub
    • third_party/tcmalloc/gperftools-2.0/vendor/configure
    • third_party/tcmalloc/gperftools-2.0/vendor/configure.ac
    • third_party/tcmalloc/gperftools-2.0/vendor/depcomp
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/cpuprofile-fileformat.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/cpuprofile.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/designstyle.css
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/heap-example1.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/heap_checker.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/heapprofile.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/index.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/overview.dot
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/overview.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pageheap.dot
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pageheap.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof-test-big.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof-test.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof-vsnprintf-big.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof-vsnprintf.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof.1
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof.see_also
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/pprof_remote_servers.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/spanmap.dot
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/spanmap.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/t-test1.times.txt
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.1024.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.128.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.131072.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.16384.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.2048.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.256.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.32768.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.4096.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.512.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.64.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.65536.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspercpusec.vs.threads.8192.bytes.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.1.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.12.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.16.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.2.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.20.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.3.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.4.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.5.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc-opspersec.vs.size.8.threads.png
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/tcmalloc.html
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/threadheap.dot
    • third_party/tcmalloc/gperftools-2.0/vendor/doc/threadheap.gif
    • third_party/tcmalloc/gperftools-2.0/vendor/install-sh
    • third_party/tcmalloc/gperftools-2.0/vendor/ltmain.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/ac_have_attribute.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/acx_nanosleep.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/acx_pthread.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/compiler_characteristics.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/install_prefix.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/libtool.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/ltoptions.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/ltsugar.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/ltversion.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/lt~obsolete.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/namespaces.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/pc_from_ucontext.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/program_invocation_name.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/m4/stl_namespace.m4
    • third_party/tcmalloc/gperftools-2.0/vendor/missing
    • third_party/tcmalloc/gperftools-2.0/vendor/mkinstalldirs
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/README
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/changelog
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/compat
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/control
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/copyright
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/docs
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/libgperftools-dev.dirs
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/libgperftools-dev.install
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/libgperftools0.dirs
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/libgperftools0.install
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/libgperftools0.manpages
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/deb/rules
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/rpm.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/packages/rpm/rpm.spec
    • third_party/tcmalloc/gperftools-2.0/vendor/src/addressmap-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/arm_instruction_set_select.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-arm-generic.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-arm-v6plus.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-linuxppc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-macosx.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-windows.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-x86.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops-internals-x86.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/atomicops.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/basictypes.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/commandlineflags.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/cycleclock.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/dynamic_annotations.c
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/dynamic_annotations.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/elf_mem_image.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/elf_mem_image.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/elfcore.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/googleinit.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/linux_syscall_support.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/linuxthreads.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/linuxthreads.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/logging.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/logging.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/low_level_alloc.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/low_level_alloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/simple_mutex.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock_internal.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock_internal.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock_linux-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock_posix-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/spinlock_win32-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/stl_allocator.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/synchronization_profiling.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/sysinfo.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/sysinfo.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/thread_annotations.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/thread_lister.c
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/thread_lister.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/vdso_support.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/base/vdso_support.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/central_freelist.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/central_freelist.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/common.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/common.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/config.h.in
    • third_party/tcmalloc/gperftools-2.0/vendor/src/config_for_unittests.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/debugallocation.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/getpc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/heap-checker.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/heap-profiler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/malloc_extension.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/malloc_extension_c.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/malloc_hook.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/malloc_hook_c.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/profiler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/stacktrace.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/google/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/heap-checker.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/heap-profiler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/malloc_extension.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/malloc_extension_c.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/malloc_hook.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/malloc_hook_c.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/profiler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/stacktrace.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/gperftools-2.0/vendor/src/heap-checker-bcad.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/heap-checker.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/heap-profile-table.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/heap-profile-table.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/heap-profiler.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/internal_logging.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/internal_logging.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/libc_override.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/libc_override_gcc_and_weak.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/libc_override_glibc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/libc_override_osx.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/libc_override_redefine.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/linked_list.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/malloc_extension.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/malloc_hook-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/malloc_hook.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/malloc_hook_mmap_freebsd.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/malloc_hook_mmap_linux.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/maybe_threads.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/maybe_threads.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/memfs_malloc.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/memory_region_map.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/memory_region_map.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/packed-cache-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/page_heap.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/page_heap.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/page_heap_allocator.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/pagemap.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/pprof
    • third_party/tcmalloc/gperftools-2.0/vendor/src/profile-handler.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/profile-handler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/profiledata.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/profiledata.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/profiler.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/raw_printer.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/raw_printer.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/sampler.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/sampler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/solaris/libstdc++.la
    • third_party/tcmalloc/gperftools-2.0/vendor/src/span.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/span.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stack_trace_table.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stack_trace_table.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_arm-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_config.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_generic-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_libunwind-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_powerpc-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_win32-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/stacktrace_x86-inl.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/static_vars.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/static_vars.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/symbolize.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/symbolize.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/system-alloc.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/system-alloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tcmalloc.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tcmalloc_guard.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/addressmap_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/atomicops_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/current_allocated_bytes_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/debugallocation_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/debugallocation_test.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/frag_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/getpc_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/heap-checker-death_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/heap-checker_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/heap-checker_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/heap-profiler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/heap-profiler_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/low_level_alloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/malloc_extension_c_test.c
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/malloc_extension_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/malloc_hook_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/markidle_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/maybe_threads_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/memalign_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/packed-cache_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/page_heap_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/pagemap_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/profile-handler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/profiledata_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/profiler_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/profiler_unittest.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/raw_printer_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/realloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/sampler_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/sampling_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/sampling_test.sh
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/simple_compat_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/stack_trace_table_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/stacktrace_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/system-alloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/tcmalloc_large_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/tcmalloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/testutil.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/testutil.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/tests/thread_dealloc_unittest.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/third_party/valgrind.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/thread_cache.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/thread_cache.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/TODO
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/addr2line-pdb.c
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/auto_testing_hook.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/config.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/get_mangled_names.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/google/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/gperftools/tcmalloc.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/gperftools/tcmalloc.h.in
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/ia32_modrm_map.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/ia32_opcode_map.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/mingw.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/mini_disassembler.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/mini_disassembler.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/mini_disassembler_types.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/nm-pdb.c
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/override_functions.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/patch_functions.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/port.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/port.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/preamble_patcher.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/preamble_patcher.h
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/preamble_patcher_test.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/preamble_patcher_with_stub.cc
    • third_party/tcmalloc/gperftools-2.0/vendor/src/windows/shortproc.asm
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/addr2line-pdb/addr2line-pdb.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/addressmap_unittest/addressmap_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/frag_unittest/frag_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/libtcmalloc_minimal/libtcmalloc_minimal.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/low_level_alloc_unittest/low_level_alloc_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/malloc_extension_test/malloc_extension_test.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/markidle_unittest/markidle_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/nm-pdb/nm-pdb.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/packed-cache_test/packed-cache_test.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/page_heap_test/page_heap_test.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/pagemap_unittest/pagemap_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/realloc_unittest/realloc_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/sampler_test/sampler_test.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/stack_trace_table_test/stack_trace_table_test.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/tcmalloc_minimal_large/tcmalloc_minimal_large_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/tcmalloc_minimal_unittest/tcmalloc_minimal_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/thread_dealloc_unittest/thread_dealloc_unittest.vcproj
    • third_party/tcmalloc/gperftools-2.0/vendor/vsprojects/tmu-static/tmu-static.vcproj
  214. Force using --hash-style=sysv for MIPS

    Changed by djordje.golubovicohnoyoudont@mips.com
    Changed at Wednesday, 11-Jul-18 21:38:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 68f5bba43ac5253bc96447696b74b6e23fc68d95

    Comments

    Force using --hash-style=sysv for MIPS
    
    By default, linker assumes --hash-style=both, but GNU hash is not
    supported by MIPS ABI.
    
    Bug: 862708
    Change-Id: Id49ab510d62d4f969e48ba5fa2dcd91ab5584db6
    Reviewed-on: https://chromium-review.googlesource.com/1133979
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574345}

    Changed files

    • build/config/compiler/BUILD.gn
  215. [iOS] Don't attempt to reset read status for empty sections.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:43:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04963cdf8f6d3c4bdf9478d52686871a25fef659

    Comments

    [iOS] Don't attempt to reset read status for empty sections.
    
    If the ReadingListTableViewController's model doesn't have any items in
    a section, using the "Mark All" option for that section previously
    threw a DCHECK.  This CL early returns so that we don't attempt to
    access sections that don't exist.
    
    Bug: 862169
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iea947d6ef700d5d45afb54961b06e29d77615cd2
    Reviewed-on: https://chromium-review.googlesource.com/1132606
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574347}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
  216. [iOS] Fix |-markSelectedReadingListItemsAfterConfirmation|.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:48:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d8362eae96c767c2bda4a6d192e7206666820c1d

    Comments

    [iOS] Fix |-markSelectedReadingListItemsAfterConfirmation|.
    
    Previously, a weak reference to the table view's selected index paths
    was used in the completion block.  Since we end editing before the
    block is executed, this variable was getting wiped away before the
    block had a chance to execute.
    
    Bug: 862173
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ideb47ea6f9f8bf1d05eed64e657df3b4f09ea989
    Reviewed-on: https://chromium-review.googlesource.com/1132431
    Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574351}

    Changed files

    • ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
  217. WebUI Polymer: Use .bowerrc ignoreDependencies.

    Changed by dpapadohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:50:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4712adb2380abb815e6b0c49946e0b3000482c85

    Comments

    WebUI Polymer: Use .bowerrc ignoreDependencies.
    
    Instead of downloading unnecessary dependencies, and then deleting them within
    reproduce.sh, use bower's ignoreDependencies feature. This has the advantage of
    skipping downloading, as well as skipping dependency version checks.
    
    The latter is necessary to have both Polymer 1 and Polymer 2 temporarily side by
    side, otherwise there is a dependency conflict for webcomponentsjs.
    
    Bug: 862472
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I1ddd50f55dd3598d7886aa72c731b49a25eb53cc
    Reviewed-on: https://chromium-review.googlesource.com/1132628
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574352}

    Changed files

    • third_party/polymer/.bowerrc
    • third_party/polymer/v1_0/.bowerrc
    • third_party/polymer/v1_0/reproduce.sh
  218. [CrOS Multidevice] Migrate usage of unlock_key and mobile_hotspot_supported to software features.

    Changed by hansberryohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:48:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8bf7eddac4f6b78495d8728aa0cd1c268eb8bdd7

    Comments

    [CrOS Multidevice] Migrate usage of unlock_key and mobile_hotspot_supported to software features.
    
    This removes usage of ExternalDeviceInfo's unlock_key and mobile_hotspot_supported booleans,
    and completely removes RemoteDevice's unlock_key and mobile_hotspot_supported boolean fields,
    in favor of their software features fields. This is in anticipation of all Better Together
    features using the new software features paradigm.
    
    There are special considerations in CryptAuthDeviceManager that account for t
    ...skip...
    oming device to not use the deprecated booleans, and instead populate its software features.
    
    R=jhawkins@chromium.org
    
    Bug: 824568, 752273
    Change-Id: I8dceb7317410e5a9bc95055ac7ce3514fc26660e
    Reviewed-on: https://chromium-review.googlesource.com/1080268
    Reviewed-by: James Hawkins <jhawkins@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574350}

    Changed files

    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
    • chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
    • chromeos/components/proximity_auth/webui/proximity_auth_webui_handler.cc
    • chromeos/components/tether/tether_host_fetcher_impl.cc
    • chromeos/components/tether/tether_host_fetcher_impl_unittest.cc
    • chromeos/services/device_sync/public/mojom/device_sync.mojom
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.cc
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits.h
    • chromeos/services/device_sync/public/mojom/device_sync_mojom_traits_unittest.cc
    • components/cryptauth/cryptauth_device_manager_impl.cc
    • components/cryptauth/cryptauth_device_manager_impl_unittest.cc
    • components/cryptauth/remote_device.cc
    • components/cryptauth/remote_device.h
    • components/cryptauth/remote_device_loader.cc
    • components/cryptauth/remote_device_loader_unittest.cc
    • components/cryptauth/remote_device_ref.h
    • components/cryptauth/remote_device_ref_unittest.cc
    • components/cryptauth/remote_device_test_util.cc
  219. Include primary surfaceIds in reference surfaces for CompositorFrameMetaData.

    Changed by akabaohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 21:46:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 227bfbd618acce7469b9f5700725dc85dc498c1f

    Comments

    Include primary surfaceIds in reference surfaces for CompositorFrameMetaData.
    
    LayerTreeHost and LayerTreeImpl will now store a surface range instead of a fallback surface.
    A SurfaceRange consists of two SurfaceIds |start|, and |end| defining a range of surfaces between
    the two surfaces. Currently and until a followup CL is merged the primary surface Id is not being
    used and fallback surfaceId is used whenever we need a SurfaceId from a SurfaceRange, specifically
    when computing SurfaceReferneces. This
    ...skip...
    oid_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I6362008332fbdef260642a2d71d2b6512f901191
    Reviewed-on: https://chromium-review.googlesource.com/1124978
    Commit-Queue: Andre Kaba <akaba@google.com>
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574348}

    Changed files

    • android_webview/browser/surfaces_instance.cc
    • android_webview/browser/surfaces_instance.h
    • cc/layers/surface_layer.cc
    • cc/layers/surface_layer.h
    • cc/layers/surface_layer_unittest.cc
    • cc/trees/layer_tree_host.cc
    • cc/trees/layer_tree_host.h
    • cc/trees/layer_tree_host_impl.cc
    • cc/trees/layer_tree_host_impl.h
    • cc/trees/layer_tree_host_impl_unittest.cc
    • cc/trees/layer_tree_impl.cc
    • cc/trees/layer_tree_impl.h
    • components/viz/common/BUILD.gn
    • components/viz/common/quads/compositor_frame_metadata.h
    • components/viz/common/surfaces/local_surface_id.cc
    • components/viz/common/surfaces/local_surface_id.h
    • components/viz/common/surfaces/surface_range.cc
    • components/viz/common/surfaces/surface_range.h
    • components/viz/service/display/surface_aggregator.cc
    • components/viz/service/display/surface_aggregator_unittest.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.h
    • components/viz/service/frame_sinks/compositor_frame_sink_support_unittest.cc
    • components/viz/service/frame_sinks/surface_synchronization_unittest.cc
    • components/viz/service/surfaces/surface.cc
    • components/viz/service/surfaces/surface.h
    • components/viz/test/compositor_frame_helpers.cc
    • components/viz/test/compositor_frame_helpers.h
    • content/public/test/hit_test_region_observer.cc
    • services/ui/ws/frame_generator.cc
    • services/ui/ws/frame_generator_unittest.cc
    • services/viz/public/cpp/compositing/compositor_frame_metadata_struct_traits.h
    • services/viz/public/cpp/compositing/struct_traits_unittest.cc
    • services/viz/public/cpp/compositing/surface_range.typemap
    • services/viz/public/cpp/compositing/surface_range_struct_traits.h
    • services/viz/public/cpp/compositing/typemaps.gni
    • services/viz/public/interfaces/BUILD.gn
    • services/viz/public/interfaces/compositing/compositor_frame_metadata.mojom
    • services/viz/public/interfaces/compositing/surface_range.mojom
  220. ipc: Add defaulted move ctor/assignment to ipc structs

    Changed by alexilinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:47:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e6cb9f56395acad6eb72628061f9cb609ce4030f

    Comments

    ipc: Add defaulted move ctor/assignment to ipc structs
    
    This CL provides explicitly defaulted definitions to the
    IPC_STRUCT_BEGIN_WITH_PARENT macros for the special member functions:
    - copy constructor
    - copy assignment operator
    - move constructor
    - move assignment operator
    
    The goal of this CL is to add the support of move operations to macros
    generated structs. Move operations aren't implicitly declared for the structs
    because a user-declared destructor is present.
    
    It's important to make these functions explicitly defaulted on their first
    declaration to avoid them being user-provided. This allows the compiler to
    define them as deleted per 8.4.2.5 of the C++14 standard.
    
    Change-Id: Ie949fa6a9c730a1069f1e75b2c6a8d9981d69431
    Reviewed-on: https://chromium-review.googlesource.com/1133260
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574349}

    Changed files

    • ipc/ipc_message_macros.h
  221. [LayoutNG] Move the should_create_line_box state into the item result list.

    Changed by ikilpatrickohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:56:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bc82cb56cb4ff677a414346c077eb294f0c7646c

    Comments

    [LayoutNG] Move the should_create_line_box state into the item result list.
    
    This change moves the should_create_line_box state (current in the
    NGLineBreaker), into the NGInlineItemsResults list.
    
    Previously we never really needed to worry about rewinding past something
    which would change the state of should_create_line_box from true->false.
    
    This is in preparation for removing the layout-tree fixup currently within
    LayoutBlockFlow::AddChild. With the fixup removed we hit the case where
    the line bread
    ...skip...
    e need a line box we just look at the last item in
    the list, and the state is kept correct while rewinding.
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ib1b92ba1a58166b3d8e6b53e0082a68a93abec5a
    Bug: 636993
    Reviewed-on: https://chromium-review.googlesource.com/1132460
    Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
    Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574355}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item_result.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker_test.cc
  222. [iOS] Ignore remainder of scroll if the FullscreenModel is reset.

    Changed by kkhorimotoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:56:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 466efc849bc657dc33b9ec4121ae5895170a2183

    Comments

    [iOS] Ignore remainder of scroll if the FullscreenModel is reset.
    
    This CL adds FullscreenModel::IgnoreRemainderOfCurrentScroll(), which
    will ignore broadcasted scroll offsets caused by an in-progress scroll.
    This allows FullscreenController::ResetModel() to not immediately get
    squashed by residual deceleration from a previous scroll.
    
    Bug: 856220
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I6d2823decde1fa2595216aa2b775241043ac944c
    Reviewed-on: https://chromium-review.googlesource.com/1132602
    Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
    Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574354}

    Changed files

    • ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm
    • ios/chrome/browser/ui/fullscreen/fullscreen_model.h
    • ios/chrome/browser/ui/fullscreen/fullscreen_model.mm
    • ios/chrome/browser/ui/fullscreen/fullscreen_model_unittest.mm
    • ios/chrome/browser/ui/fullscreen/test/fullscreen_model_test_util.h
    • ios/chrome/browser/ui/fullscreen/test/fullscreen_model_test_util.mm
  223. Network Service: Remove VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromNetworkService

    Changed by juncaiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:58:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99424620f8a042b4a2b06978f77bc98731f3d09f

    Comments

    Network Service: Remove VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromNetworkService
    
    This CL removes VariationsHttpHeadersBrowserTest.TestStrippingHeadersFromNetworkService
    since the consumers are required to add headers directly for the initial
    request.
    
    Bug: 841309
    Change-Id: Ic84eeef7fcdbc6f1693aa7e56972cd05bf311719
    Reviewed-on: https://chromium-review.googlesource.com/1120955
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574356}

    Changed files

    • chrome/browser/net/variations_http_headers_browsertest.cc
  224. Refactor WatchTimeReporter into various WatchTimeComponents.

    Changed by dalecurtisohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 21:54:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9777575af98a9e803b7fbef0a94c22af946f5ae9

    Comments

    Refactor WatchTimeReporter into various WatchTimeComponents.
    
    Every input used to calculate watch time functions the same way,
    so factor them out into a common WatchTimeComponent class to
    remove lots of copy/paste and enforce rigor in the reporter.
    
    Each input does something like flip pending value, record timestamp
    of that value change, wait for next reporting cycle, finalize the
    elapsed time, flip the actual value, and then start recording from
    that previous finalize time. They may also clear the pe
    ...skip...
    e model. We just
    need each component to be configured with a list of keys that
    should be finalized, an initial value, and a way to convert that
    value into a WatchTimeKey.
    
    BUG=779192
    TEST=all existing tests pass, no functionality changes.
    
    Change-Id: I33f7c1ecb0c365ca5feba9ccf102c5c3cbd5a97d
    Reviewed-on: https://chromium-review.googlesource.com/1128447
    Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574353}

    Changed files

    • media/blink/BUILD.gn
    • media/blink/watch_time_component.cc
    • media/blink/watch_time_component.h
    • media/blink/watch_time_component_unittest.cc
    • media/blink/watch_time_reporter.cc
    • media/blink/watch_time_reporter.h
    • media/blink/watch_time_reporter_unittest.cc
  225. MediaButtonReceiver: log key code from event received in intent.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:05:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c5680ed55a6960e03ec7aaaa13d52adab56d754

    Comments

    MediaButtonReceiver: log key code from event received in intent.
    
    Forgot to upload the change as part of https://chromium-review.googlesource.com/c/chromium/src/+/1133741
    
    Bug: None
    Change-Id: Icb1f99c0d45928840740abef161c513d661d01af
    Reviewed-on: https://chromium-review.googlesource.com/1134179
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574359}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
  226. [UMA] Fix bug were omnibox focus is ignored before native is loaded

    Changed by mheikalohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:02:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 79bb954dd2e807d3fac32e2b4fa14046770ef00a

    Comments

    [UMA] Fix bug were omnibox focus is ignored before native is loaded
    
    Urlbar/omnibox focus events that are used for UMAs
    ("MobileStartup.ToolbarFirstFocusStartupState.<activity name>" and
    "MobileStartup.ToolbarFirstFocusTime2.<activity name>"), that happen
    before native is loaded, are ignored. This was due to the improper
    placement of the call to OmniboxStartupMetrics#onUrlBarFocused.
    
    Bug: 862752
    Change-Id: I7354be526b1c116ef9b541a4d5993058163d22a1
    Reviewed-on: https://chromium-review.googlesource.com/1134184
    Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
    Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574357}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
  227. mash: Fix crash when opening network menu in system tray

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:03:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 62eee33ef5ebff05c7d26f7ee545199d27e01adb

    Comments

    mash: Fix crash when opening network menu in system tray
    
    Change a check for MASH_DEPRECATED to IsAshInBrowserProcess, since the
    relevant ash-to-chrome delegate hasn't been ported to mash yet.
    
    Bug: none
    Test: chrome --enable-features=Mash and open network menu
    Change-Id: Ic5013ec84590814d964159acea66f8cab26ba5cd
    Reviewed-on: https://chromium-review.googlesource.com/1134085
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574358}

    Changed files

    • ash/system/network/network_list.cc
  228. Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:05:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f83ad3fa1e9af7b2a8d4a51863fc2abb0e121de

    Comments

    Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/0664f1210277..a3bc29bcacf3
    
    
    git log 0664f1210277..a3bc29bcacf3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 vapier@chromium.org validation_pool: process private/draft CLs before filtering
    2018-07-11 dgarrett@google.com cbuildbot_launch: Pass --workspace to cbuildbot.
    2018-07-11 xixuan@chromium.org Skylab-launch: Remove hard-coded build for SkylabHWTestStage
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ie16ad6bc99dfb42886e1eaad6e06bafe2cd7726d
    Reviewed-on: https://chromium-review.googlesource.com/1133864
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574360}

    Changed files

    • DEPS
  229. Simple rename in BrowserAccessibilityCocoa.

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:09:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 72bfd2dc3d3fa59a925d66978ae2acffffd4dfc6

    Comments

    Simple rename in BrowserAccessibilityCocoa.
    
    The BrowserAccessibilityCocoa (Objective-C Object for macOS) often
    needs to ask its corresponding BrowserAccessibility (cross-platform
    C++ object). Rather than calling it browserAccessibility or
    browserAccessibility_, let's call it "owner".
    
    I'm open to other names, but this is pretty limited to this one
    file so anyone hacking on this file should figure it out
    pretty quickly.
    
    Bug: none
    Change-Id: I36a5503ff53196b0c1e17bd405307d5471f9bd06
    Reviewed-on: https://chromium-review.googlesource.com/1132142
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574361}

    Changed files

    • content/browser/accessibility/browser_accessibility_cocoa.h
    • content/browser/accessibility/browser_accessibility_cocoa.mm
    • content/browser/accessibility/browser_accessibility_mac_unittest.mm
    • content/browser/accessibility/browser_accessibility_manager_mac.mm
  230. Make bidi adjustment in auto-directioned paragraphs saner

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e

    Comments

    Make bidi adjustment in auto-directioned paragraphs saner
    
    In bidi adjustment for legacy layout, there is a hack that stops any
    adjustment if current text box is in 'unicode-bidi: plaintext'. This
    is wrong if the auto-directioned paragraph still contains
    bidirectional text.
    
    Ideally, we should remove this hack, and check paragraph direction.
    However, we don't have a reliable way to do this in legacy layout.
    So this patch makes the hack slightly saner that, bidi adjustment
    shouldn't stop as long as we are at a bidi boundary, even if we are
    in 'unicode-bidi: plaintext'.
    
    Bug: 861559
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie7e1f704b976adf28a5d143e8265a499af0d62e4
    Reviewed-on: https://chromium-review.googlesource.com/1132472
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574362}

    Changed files

    • third_party/blink/renderer/core/editing/inline_box_traversal.cc
    • third_party/blink/renderer/core/editing/selection_modifier_character_test.cc
  231. Don't make MCVD textures unrenderable.

    Changed by liberatoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c9a8cb21b0bd26037458b9ebe1d94a8b3204f1

    Comments

    Don't make MCVD textures unrenderable.
    
    Previously, we would make MCVD video frame textures unrenderable
    after the VideoFrame was destroyed and the sync token had cleared.
    This prevented the image from holding onto MediaCodec buffers
    unnecessarily, since the actual destruction of the texture might
    be delayed until the GL context was made current.
    
    However, it turns out that the sync token isn't always correct.
    If the VideoResourceUpdater is destroyed, then it immediately
    releases all VideoFrames with 
    ...skip...
     practice, it works.
    
    Bug: 858826
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ia09b00a68964e886a05acf19f3623b4c87c31115
    Reviewed-on: https://chromium-review.googlesource.com/1132115
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574365}

    Changed files

    • media/gpu/android/codec_image.cc
    • media/gpu/android/codec_image.h
    • media/gpu/android/codec_image_group.cc
    • media/gpu/android/codec_image_group_unittest.cc
    • media/gpu/android/texture_pool.cc
    • media/gpu/android/texture_pool.h
    • media/gpu/android/texture_pool_unittest.cc
    • media/gpu/android/video_frame_factory_impl.cc
    • media/gpu/android/video_frame_factory_impl.h
  232. [Nav Experiment] Add a wait after restore session.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcae87b0c7618e2fc61f78a073cf5589fe9679bd

    Comments

    [Nav Experiment] Add a wait after restore session.
    
    This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    enabled. A better approach would be to turn this test into a
    programmatic test so both navigation managers implementations are
    tested, but web::features symbols are not exposed in ios/web_view.
    
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    Reviewed-on: https://chromium-review.googlesource.com/1134046
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574367}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  233. Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:15:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e9e78757733e56983b4b6c9ac5b13fdc21db8b

    Comments

    Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit 560191224bcaf8390e0745a16bdf8975a1add6bf.
    
    Reason for revert: Patch still applies cleanly without prior change.
    
    Original change's description:
    > Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    >
    > This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    >
    > Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    >
    > Original chang
    ...skip...
    
    
    TBR=boliu@chromium.org,mathp@chromium.org,waffles@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I6ed0526b444574a5e8419ea83a37e348dc97cd11
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134141
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574368}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  234. Fix the type of the end text selection handle

    Changed by danakjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5469c6437a9600862ba63c6abcd30dbc87c8f02

    Comments

    Fix the type of the end text selection handle
    
    Due to copy paste mistakes, the end handle ended up being the same type
    as the start handle, but it should be the opposite type.
    
    R=chrishtr@chromium.org
    
    Bug: 862510
    Change-Id: I2e6609d1e4083ced5f92b563925ba8c8401964fa
    Reviewed-on: https://chromium-review.googlesource.com/1133681
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574363}

    Changed files

    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl_test.cc
    • third_party/blink/renderer/core/page/page_overlay_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/testing/stub_graphics_layer_client.h
  235. Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."

    Changed by bsalomonohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23370775c415c21f4de1c7d97dd5645fe2b7e818

    Comments

    Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    
    This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    
    The updated change uses window.devicePixelRatio to determine the inset.
    It also accounts for the absolute position used by the "WithDivs"
    variations of this test. One additional device pixel of offset is used
    to make this pass on mac_chromium_rel_ng. This is probably necessary
    because either window.devicePixelRatio reports 1 incorrectly or the
    edge antialiasing c
    ...skip...
    efs/heads/master@{#573695}
    
    Bug: 847984
    Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1132574
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574369}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  236. Check DrawQuad is given a valid pointer to SharedQuadState

    Changed by samansohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af0b9e0ea205364f81579ede827a19acecfb6ee8

    Comments

    Check DrawQuad is given a valid pointer to SharedQuadState
    
    Bug: 852294
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb
    Reviewed-on: https://chromium-review.googlesource.com/1133579
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574366}

    Changed files

    • components/viz/common/quads/draw_quad.cc
  237. Introduce BlockingModelTypeStore[Impl]

    Changed by mastizohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3cfab37a6906e7d897ad16e9260cf5818323f247

    Comments

    Introduce BlockingModelTypeStore[Impl]
    
    The class is analogous to the non-blocking ModelTypeStore, which exposes
    an asynchronous API.
    
    The new class is intended to be used by datatypes that don't need to
    live in the UI thread, and are instead fine to live in a background
    thread, namely a sequenced task runner enforced by
    BlockingModelTypeStore.
    
    Users must use that sequenced task runner, because the underlying
    (shared) LevelDB database lives there, and is not thread-safe.
    
    The result of this refactori
    ...skip...
    s in fact an improvement: there is now one extra hop between
    threads when reading metadata, which is also the reason why some
    tests need to be updated.
    
    TBR=markusheintz@chromium.org
    
    Bug: 861632
    Change-Id: I5db552adc42c48fc36da6378c1d7f61334f1f450
    Reviewed-on: https://chromium-review.googlesource.com/1129800
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574364}

    Changed files

    • components/consent_auditor/consent_sync_bridge_impl_unittest.cc
    • components/sync/BUILD.gn
    • components/sync/model/blocking_model_type_store.h
    • components/sync/model/model_type_store.cc
    • components/sync/model/model_type_store.h
    • components/sync/model/model_type_store_base.cc
    • components/sync/model/model_type_store_base.h
    • components/sync/model_impl/blocking_model_type_store_impl.cc
    • components/sync/model_impl/blocking_model_type_store_impl.h
    • components/sync/model_impl/model_type_store_backend.cc
    • components/sync/model_impl/model_type_store_backend.h
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync/model_impl/model_type_store_impl.h
    • components/sync/user_events/user_event_sync_bridge_unittest.cc
  238. [Nav Experiment] Make WebStateImplTest parameterized.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00ee7c4ed5ad09f68465f8e73c89639217adfacf

    Comments

    [Nav Experiment] Make WebStateImplTest parameterized.
    
    This way both legacy and WK based navigation manager implementations are
    tested on trybots.
    
    Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
    Disabled ShowAndClearInterstitialWithCommittedItem and
    ShowAndClearInterstitialWithoutChangingSslStatus because they require
    mocking out navigation state, which is not possible now.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
    Reviewed-on: https://chromium-review.googlesource.com/1134086
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574372}

    Changed files

    • ios/web/web_state/web_state_impl_unittest.mm
  239. chromeos: fix infinite loop in cursor lookup

    Changed by skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d9f316a0ba47bb4be158db0de5edc596272dabe

    Comments

    chromeos: fix infinite loop in cursor lookup
    
    And remove a NOTREACHED that we're hitting. I will supply a test for this
    separate, as well as investgating removal of NOREACHED.
    
    BUG=855767
    TEST=none
    
    Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0
    Reviewed-on: https://chromium-review.googlesource.com/1134352
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574371}

    Changed files

    • services/ui/ws2/window_delegate_impl.cc
    • services/ui/ws2/window_delegate_impl.h
  240. [Chromecast] Chromecast support for tap down gestures

    Changed by lijiaweiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:20:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06e3ca5865cd84108599d13d143b5f230cef145f

    Comments

    [Chromecast] Chromecast support for tap down gestures
    
    - TAP_DOWN is added to CastContentWindow::GestureType
    - The gesture detection is attached to the root window and handles
      tap down events. A new JS binding API: onTapDownHandler will be hosted on
      platform
    - HandleTapGesture: finger is released after pressed within tap timeout window
      HandleTapDownGesture: finger is pressed
    
    Bug: internal b/75979846
    Test: build manually and test whether both tap and tap down handler callback works
    Change-Id: Iaefa6df9c7a5284ba27964083fc056bf36cf480a
    Reviewed-on: https://chromium-review.googlesource.com/1115418
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574373}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_content_window_aura.cc
    • chromecast/browser/cast_content_window_aura.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/graphics/cast_gesture_handler.h
    • chromecast/graphics/cast_system_gesture_event_handler.cc
  241. Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.

    Changed by dpapadohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ab1508513baf70561ebe2289ca48030f3fca81a

    Comments

    Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.
    
    At r573968 the logic was modified to only look for the noSearch property for
    subpage wrappers. It should also look for the CSS attribute for the case where
    no-search is not part of a binding.
    
    Bug: 862517
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
    Reviewed-on: https://chromium-review.googlesource.com/1133683
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574374}

    Changed files

    • chrome/browser/resources/settings/search_settings.js
    • chrome/test/data/webui/settings/search_settings_test.js
  242. Support disabling the remainder of the Symantec Legacy PKI

    Changed by rsleeviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c671bf913c328f7788df5046dd7b81bee3e17a04

    Comments

    Support disabling the remainder of the Symantec Legacy PKI
    
    Introduce a base::Feature flag that controls how the
    remainder of the Symantec Legacy PKI - that is, certs
    issued on/after 2016-06-01 but before 2017-12-01 - are
    handled.
    
    Bug: 796230
    Change-Id: Iebe9976ace0dfcdfd02f844fdaf497cf67dde704
    Reviewed-on: https://chromium-review.googlesource.com/1134037
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574370}

    Changed files

    • net/cert/cert_verify_proc.cc
    • net/cert/cert_verify_proc.h
    • net/cert/cert_verify_proc_unittest.cc
  243. Remove NetworkContextTest.PreconnectLessThanZero

    Changed by lilyhoughtonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe8c7d594e193f0dbdf6e3b7c970e44bee9c5c5c

    Comments

    Remove NetworkContextTest.PreconnectLessThanZero
    
    This test is flaky on android bots, and given that its testing something that
    should be explicitly unsupported (passing a negative number to a uint parameter),
    I think it's worth removing for now.
    
    Bug: 862647
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I316cb2cc5979aefb7335f715bd1fd2655db097b3
    Reviewed-on: https://chromium-review.googlesource.com/1134206
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574375}

    Changed files

    • services/network/network_context_unittest.cc
  244. Reland "[sampling heap profiler] Support stack collection on Android"

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a3c0496180f1a183b3ca8061440d3888ff0722a

    Comments

    Reland "[sampling heap profiler] Support stack collection on Android"
    
    This reverts commit db0cac4eafdcc6cbd13e19eacc3eba15c15bfa2c.
    
    Reason for revert: The revert didn't affect anything, so re-landing.
    
    Original change's description:
    > Revert "[sampling heap profiler] Support stack collection on Android"
    > 
    > This reverts commit 52601a565375e7e60fdee70568f5e85242b76441.
    > 
    > Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.
    > 
    > 
    ...skip...
    nke@chromium.org>
    > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574032}
    
    TBR=dpranke@chromium.org,alph@chromium.org,ssid@chromium.org
    
    Change-Id: I41392b0836e75c25ae6b0b9aa243daeef95b6ee7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 803276
    Reviewed-on: https://chromium-review.googlesource.com/1134142
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574379}

    Changed files

    • base/sampling_heap_profiler/sampling_heap_profiler.cc
    • base/sampling_heap_profiler/sampling_heap_profiler.h
  245. Add the target for overrides of metrics utilities in jingle_unittests.

    Changed by qingsiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50c4d834c41b8f1ae60ae80bc47d67a51dcb23bd

    Comments

    Add the target for overrides of metrics utilities in jingle_unittests.
    
    The target rtc_p2p from WebRTC, transitively depended on by
    jingle_unittests via the target webrtc_overrides, will soon depend on
    the implementation of RTC_HISTOGRAM_* macros in WebRTC.
    
    Bug: webrtc:9409
    Change-Id: I1f2bf0776d2f7c18c9585fb15d7251f8128ce175
    Reviewed-on: https://chromium-review.googlesource.com/1134183
    Commit-Queue: Qingsi Wang <qingsi@google.com>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574376}

    Changed files

    • jingle/BUILD.gn
  246. Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz

    Changed by jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:24:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99b62af5a66207b0fe84080bdd23492471a9ba94

    Comments

    Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz
    
    Apparently this test can still fail on Windows. So re-disabling it until it can be investigated further.
    
    TBR=fsamuel@chromium.org
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    
    Bug: 848825
    Change-Id: I00828a10cfd5c8c111b30f61eb5d8acbf57da2ea
    Reviewed-on: https://chromium-review.googlesource.com/1133875
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574377}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  247. Add intermediate bubble UI for local card migration flow.

    Changed by siyuaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:25:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f08db6b91e0572161cf98df942b70c3becc285

    Comments

    Add intermediate bubble UI for local card migration flow.
    
    This is the 1st CL adding new views. There will be three following CLs
    on Autofill Client change, unit-test and metrics, and cocoa implementation.
    
    For details, please refer to design doc go/ib-paradise.
    
    This project is to offer users an option to upload chrome local credit
    cards to Google Pay server. This bubble UI is the entry point of the entire
    flow. It should be anchored to a credit card icon in the location bar and
    be shown from it.
    
    Bu
    ...skip...
    81c23658185045a5aecda8a
    Reviewed-on: https://chromium-review.googlesource.com/1128569
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574378}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/app/generated_resources.grd
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_bubble.h
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
    • chrome/browser/ui/browser_window.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.mm
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/view_ids.h
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.h
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/test/base/test_browser_window.cc
    • chrome/test/base/test_browser_window.h
    • components/autofill/core/browser/ui/local_card_migration_bubble_controller.h
    • components/autofill_strings.grdp
  248. Allow optimization hints to be marked as experimental.

    Changed by jelsonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:28:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8940b1c9de6fb2951013a8d2bb78770e62598b7

    Comments

    Allow optimization hints to be marked as experimental.
    
    Experimental hints are tagged (in the Optimization proto) with an
    experiment name. Experimental hints are not enabled unless an
    experiment with a matching name is enabled. Experiments are enabled by
    turning on the new base::Feature called kOptimizationHintsExperiments,
    with the name of the experiment in a parameter called experiment_name.
    
    Bug: 831817
    Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227
    Reviewed-on: https://chromium-review.googlesource.com/1132491
    Commit-Queue: Jeremy Elson <jelson@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574380}

    Changed files

    • components/optimization_guide/proto/hints.proto
    • components/previews/content/previews_hints.cc
    • components/previews/content/previews_optimization_guide_unittest.cc
    • components/previews/core/previews_features.cc
    • components/previews/core/previews_features.h
  249. Add metrics tracking how long Page Info is open

    Changed by cthompohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c4e06c2d21cc9a69f0a2a871a873b30c12b8fee

    Comments

    Add metrics tracking how long Page Info is open
    
    Per a suggestion of martinshelton@, this adds a new set of histograms to
    track how long users have the Page Info bubble open. This will help us
    better understand users who open Page Info but take no actions in it
    (e.g., are these opens likely to be more accidental or incidental).
    
    This metric is split by the security level of the page to allow us to
    see differences between different security indicators. Two sub-histograms
    ("Action" and "NoAction") further split up the metric by whether the user
    performed an action in the Page Info bubble before closing it (including
    actions that cause the bubble to close).
    
    Bug: 859116
    Change-Id: I630a1f37ecff13bc7ee44b3e8e5a5c34337c9267
    Reviewed-on: https://chromium-review.googlesource.com/1096336
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574381}

    Changed files

    • chrome/browser/ui/page_info/page_info.cc
    • chrome/browser/ui/page_info/page_info.h
    • chrome/browser/ui/page_info/page_info_unittest.cc
    • tools/metrics/histograms/histograms.xml
  250. @IntDef cleanup in browser/java/appmenu

    Changed by marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 22:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d0c1419ced881ae3321b7c6e3f23bbcacde473a

    Comments

    @IntDef cleanup in browser/java/appmenu
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and relat
    ...skip...
     about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: Ie6b59c0f1a8ec6fe50d3177619f0768798f97508
    Reviewed-on: https://chromium-review.googlesource.com/1128092
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574382}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
  251. Fix crash in shortcut viewer with ChromeVox enabled

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:38:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f74145f76fd3c4d8c1b4d024f34cf24189350d2

    Comments

    Fix crash in shortcut viewer with ChromeVox enabled
    
    Views can trigger accessibility events during Widget construction
    before the AXRemoteHost starts monitoring the widget. This happens
    with the material design focus ring on text fields.
    
    Bug: 862759
    Test: added to views_mus_unittests
    Change-Id: Ib7de6aa1d09b17fb65ad350abd362ad26b0454ae
    Reviewed-on: https://chromium-review.googlesource.com/1134353
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574383}

    Changed files

    • ui/views/mus/ax_remote_host.cc
    • ui/views/mus/ax_remote_host_unittest.cc
  252. Introducing improvements for the Action Recorder Extension.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:41:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 856e676d5e063bce97d01d06311b517f6b9e108c

    Comments

    Introducing improvements for the Action Recorder Extension.
    
    1. Improved the xpath generator. The generator will produce even more concise xpaths. This improvement helps to make test recipes readable to humans.
    2. Changed the way the extension queries for an iframe's context. Prior to this change, the extension would construct a path from the iframe to the top level frame by making a query at each ancestor frame node. However, InProcessBrowserTest does not need a path to go from the top level frame to
    ...skip...
    e extension uses keyboard events to detect when a user types inside a field, eliminating the false positive.
    6. Began implementing new features to capture Chrome Password Manager actions.
    
    Bug: 855284
    Change-Id: Ic7ff3af95cdc9f308c3ad061a3506fced150b4f8
    Reviewed-on: https://chromium-review.googlesource.com/1132540
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574385}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/background/background.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/constants.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
  253. Bandaid detached tabs at 150% scale

    Changed by tbergquistohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c18d19908d8817f4057df5e50afc966d92a25701

    Comments

    Bandaid detached tabs at 150% scale
    
    At some dpi scales (150% for example), the tabs are drawn detached from
    the toolbar, with a stark one-pixel gap between the tabs and the
    toolbar.
    
    This CL draws one extra dip's worth of tab below the bottom of the tab,
    which is occluded by the toolbar at integral scales and fills the gap
    on non-integral scales.
    
    
    Bug: 848106
    Change-Id: Ib465e8886c49613916bf3f3faff5fc43f36dfb18
    Reviewed-on: https://chromium-review.googlesource.com/1121386
    Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574384}

    Changed files

    • chrome/browser/ui/layout_constants.cc
    • chrome/browser/ui/layout_constants.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/browser_view_unittest.cc
    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/tab.cc
  254. Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 720dadbc215c229ce100bc408edb3aee03b0697e

    Comments

    Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543
    
    
    git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
    2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@1af68170e543
    
    The AutoRoll server is locat
    ...skip...
    .chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862730,chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
    Reviewed-on: https://chromium-review.googlesource.com/1133869
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574387}

    Changed files

    • DEPS
  255. [Feed] Feed Storage Initialization

    Changed by gangwuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:44:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74b454af56f3e14b18880854866b9b0d0b1f2a13

    Comments

    [Feed] Feed Storage Initialization
    
    Implement feed storage initialization in C++.
    
    Bug:828938
    
    Change-Id: I33a5a9e2e7dd20c36ec945feab6ea9932e9d94a2
    Reviewed-on: https://chromium-review.googlesource.com/1121834
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574386}

    Changed files

    • chrome/browser/android/feed/feed_host_service_factory.cc
    • components/feed/core/feed_host_service.cc
    • components/feed/core/feed_host_service.h
    • components/feed/core/feed_storage_database.cc
    • components/feed/core/feed_storage_database.h
  256. Update XR (VR & AR) OWNERS files

    Changed by ddorwinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:49:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcd11ade1174730bcc35ee5f8d71960c5a6a4794

    Comments

    Update XR (VR & AR) OWNERS files
    
    Switch COMPONENT to new structure, update and alphabetize owners, and
    add missing fields.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:closure_compilation;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5141932b33a41d3aeaad1cc053623f12422e277e
    Reviewed-on: https://chromium-review.googlesource.com/1121097
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: David Dorwin <ddorwin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574388}

    Changed files

    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VR_JAVA_OWNERS
    • chrome/browser/android/vr/OWNERS
    • chrome/browser/android/vr/arcore_device/OWNERS
    • chrome/browser/resources/vr/OWNERS
    • chrome/browser/vr/OWNERS
    • chrome/browser/vr/service/OWNERS
    • chrome/browser/vr/vector_icons/OWNERS
    • chrome/test/data/vr/OWNERS
    • chrome/test/vr/OWNERS
    • device/vr/OWNERS
    • device/vr/oculus/OWNERS
    • device/vr/openvr/OWNERS
    • device/vr/public/mojom/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webvr/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webxr/OWNERS
    • third_party/arcore-android-sdk/OWNERS
    • third_party/blink/renderer/modules/vr/OWNERS
    • third_party/blink/renderer/modules/xr/OWNERS
    • third_party/gvr-android-keyboard/OWNERS
    • third_party/gvr-android-keyboard/com/google/vr/keyboard/OWNERS
    • third_party/gvr-android-sdk/OWNERS
    • third_party/libovr/OWNERS
    • third_party/openvr/OWNERS
    • tools/perf/contrib/vr_benchmarks/OWNERS
  257. [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65d0489cb43a7d17f1668f9178506e7a446b9a3d

    Comments

    [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart
    
    The naming turned out to be confusing.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16fb06f080caac6ef9356edb187fe8032ef8f9ef
    Reviewed-on: https://chromium-review.googlesource.com/1133098
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574389}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.h
  258. [Nav Experiment] Parameterize crw_web_controller_unittest.mm.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:53:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a9497984526d151d178bfe8ec9dd1b1c84597c

    Comments

    [Nav Experiment] Parameterize crw_web_controller_unittest.mm.
    
    This is so that both LegacyNavigationManagerImpl and
    WKBasedNavigationManagerImpl can be tested on trybots.
    
    Also fixed broken test setup for
    ScriptExecutionTest.UserScriptOnAppSpecificPage and
    CRWWebControllerTest.AbortNativeUrlNavigation.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
    Reviewed-on: https://chromium-review.googlesource.com/1134406
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574390}

    Changed files

    • ios/web/web_state/ui/crw_web_controller_unittest.mm
  259. Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896be1d3c7326aed2e680ed495a82e5997e5de13

    Comments

    Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)
    
    https://skia.googlesource.com/skia.git/+log/4ec72f7cc745..80247e594d1f
    
    
    git log 4ec72f7cc745..80247e594d1f --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 caryclark@skia.org Publish docs for rrect, picture, blendmode
    2018-07-11 bungeman@google.com Make CR and trailing whitespace errors.
    2018-07-11 bsalomon@google.com Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bungeman@google.co
    ...skip...
    ci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ief888bfc0922b84d752987ea5ec56c4369912b14
    Reviewed-on: https://chromium-review.googlesource.com/1133871
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574391}

    Changed files

    • DEPS
  260. Revert "Reland "Fix OOPIF hit testing in layout tests.""

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08abdaa4ff32eca88a28ab84f7da1075819c311b

    Comments

    Revert "Reland "Fix OOPIF hit testing in layout tests.""
    
    This reverts commit 3dcee047ec982d521d9ad5301e00ac1bba134f01.
    
    Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568
    
    Original change's description:
    > Reland "Fix OOPIF hit testing in layout tests."
    > 
    > This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    > 
    > Original change's description:
    > > Fix OOPIF hit testing
    ...skip...
    Tapuska <dtapuska@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574304}
    
    TBR=kenrb@chromium.org,dtapuska@chromium.org
    
    Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 601584
    Reviewed-on: https://chromium-review.googlesource.com/1134143
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574392}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  261. Moving Offline Previews triggering to be pre-computed

    Changed by ryansturmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:02:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3154b813745fb84c61dabf48dc7e75cf5d1973f9

    Comments

    Moving Offline Previews triggering to be pre-computed
    
    As part of moving previews to an earlier decision point, this CL moves
    the triggering of offline previews to be consistent with other preview
    types.
    
    Follow-up Cls will move this decision point earlier on the UI thread so
    the new offline page implementation will also be able to use it. The
    temporary dependency on PreviewsUserData will also not be needed once
    the offline tab helper is accessible (the impl is on the UI thread).
    
    Bug: 842233
    Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
    Reviewed-on: https://chromium-review.googlesource.com/1128332
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Jian Li <jianli@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574393}

    Changed files

    • chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.h
    • chrome/browser/offline_pages/offline_page_request_job.cc
    • chrome/browser/offline_pages/offline_page_request_job.h
    • chrome/browser/previews/previews_infobar_tab_helper.cc
    • chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_content_util_unittest.cc
    • components/previews/core/previews_user_data.h
    • content/public/common/previews_state.h
    • third_party/blink/public/platform/web_url_request.h
  262. Call generic isShowingAppMenuUpdateBadge

    Changed by amaralpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ffcab75a3f1d5700c92c854ca48465fa08420cbc

    Comments

    Call generic isShowingAppMenuUpdateBadge
    
    ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge
    so that bottom toolbar has a chance to handle it.
    
    Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4
    Reviewed-on: https://chromium-review.googlesource.com/1132601
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574395}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
  263. Fix broken link in Histograms documentation.

    Changed by supertriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d84f451bba258746bb4ac1ee10a3cfa441997a

    Comments

    Fix broken link in Histograms documentation.
    
    Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f
    Reviewed-on: https://chromium-review.googlesource.com/1134422
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Caitlin Sadowski <supertri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574394}

    Changed files

    • tools/metrics/histograms/README.md
  264. Chrome Cleaner UI: Update list of items to be removed to list extensions

    Changed by nburrisohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ff991fb5cf3ff872e2096ac735376369aaed5d87

    Comments

    Chrome Cleaner UI: Update list of items to be removed to list extensions
    
    - Also add tests for displaying extensions, refactoring tests to a loop
    instead of writing all possible combinations like before.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I5a02771b339751e44df4ceb1bb6f58a7796968b4
    Reviewed-on: https://chromium-review.googlesource.com/1127180
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574397}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  265. [CrOS MultiDevice] Tweak an EasyUnlock string description.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:09:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d93874c2172b2c280b99e15fad1269c658a25fa

    Comments

    [CrOS MultiDevice] Tweak an EasyUnlock string description.
    
    This fix was suggested by our UX writer jonann@ in b/111006044.
    
    Bug: 824568
    Change-Id: If888000ed030b0dd90436729c77cb861a59305f9
    Reviewed-on: https://chromium-review.googlesource.com/1133710
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574396}

    Changed files

    • chrome/app/settings_strings.grdp
  266. @IntDef cleanup in chrome/java/externalauth

    Changed by marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 23:14:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d82ee0010741390a1a6a63bbcc68d95e4b5341b2

    Comments

    @IntDef cleanup in chrome/java/externalauth
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and r
    ...skip...
     about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: I8285733bbecf695b133a3865310f9a3cf0c515d6
    Reviewed-on: https://chromium-review.googlesource.com/1133983
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574399}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/VerifiedHandler.java
  267. Make URLDataSource backend reference a WeakPtr.

    Changed by chrishaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bed9bc8ab47755b9be2032dc398af2060bc94ede

    Comments

    Make URLDataSource backend reference a WeakPtr.
    
    This allows URLDataSources that have been detached from a backend to
    still refer to the backend if it still exists, allowing any pending
    queries that were issued to that backend and routed to the data source
    to resolve back to the backend when they are finished.
    
    BUG=859193
    
    Change-Id: I55eda45be1f24716ad31c7d98ee748a737baca51
    Reviewed-on: https://chromium-review.googlesource.com/1131537
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574398}

    Changed files

    • content/browser/webui/url_data_manager_backend.cc
    • content/browser/webui/url_data_manager_backend.h
    • content/browser/webui/url_data_source_impl.h
  268. Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:22:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a94a2187dbcbeca3eab3361df5877f3af0345dd1

    Comments

    Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c
    
    Using wpt-import in Chromium 4df7c6c40ebef72484655dc54db5c40e9f8c2bc2.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21178
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectatio
    ...skip...
    glesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I084c2429c7bc00f6d54eb830a34bcccb62e45c3b
    Reviewed-on: https://chromium-review.googlesource.com/1134081
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574400}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.sharedworker-expected.txt
  269. Android: consolidate support components for embedders

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:23:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 351a925fcc3c0a950711126c9f4dab65cbee1ed9

    Comments

    Android: consolidate support components for embedders
    
    Moves web_contents_delegate_android under embedder_support to
    consolidate all the support components for embedders. The package path
    is org.chromium.embedder_support.delegate. Now the component
    has 4 main targets for embedders:
     - media
     - view
     - content_view
     - web_contents_delegate
    
    Note:
    
    - The choice of 'delegate' in the package name of WebContentsDelegateAndroid
      is just to avoid having WCDA repeated in the path. (import org.chromium
      .emb
    ...skip...
    me-internal-review.googlesource.com/c/clank/internal/apps/+/646448
    
    
    Change-Id: I44c25435c32330439ffa765d80df45b02d0694b1
    Reviewed-on: https://chromium-review.googlesource.com/1118926
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574401}

    Changed files

    • android_webview/BUILD.gn
    • android_webview/browser/DEPS
    • android_webview/browser/aw_web_contents_delegate.h
    • android_webview/java/DEPS
    • android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java
    • android_webview/test/BUILD.gn
    • build/android/lint/suppressions.xml
    • chrome/android/BUILD.gn
    • chrome/android/java/DEPS
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
    • chrome/browser/BUILD.gn
    • chrome/browser/android/DEPS
    • chrome/browser/android/bottombar/overlay_panel_content.cc
    • chrome/browser/android/document/document_web_contents_delegate.cc
    • chrome/browser/android/document/document_web_contents_delegate.h
    • chrome/browser/android/tab_web_contents_delegate_android.h
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/android/color_chooser_dialog_android.cc
    • chrome/test/android/BUILD.gn
    • components/OWNERS
    • components/embedder_support/android/BUILD.gn
    • components/embedder_support/android/delegate/DEPS
    • components/embedder_support/android/delegate/OWNERS
    • components/embedder_support/android/delegate/color_chooser_android.cc
    • components/embedder_support/android/delegate/color_chooser_android.h
    • components/embedder_support/android/delegate/web_contents_delegate_android.cc
    • components/embedder_support/android/delegate/web_contents_delegate_android.h
    • components/embedder_support/android/java/res/drawable-hdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-mdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-xhdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable/color_button_background.xml
    • components/embedder_support/android/java/res/drawable/color_picker_border.xml
    • components/embedder_support/android/java/res/layout/color_picker_advanced_component.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_content.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_title.xml
    • components/embedder_support/android/java/res/values/colors.xml
    • components/embedder_support/android/java/res/values/dimens.xml
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorChooserAndroid.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvanced.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvancedComponent.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerDialog.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerMoreButton.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerSimple.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestion.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestionListAdapter.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/DEPS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OWNERS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OnColorChangedListener.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_am.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ar.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_bg.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ca.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_cs.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_da.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_de.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_el.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_en-GB.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es-419.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fa.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fil.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hu.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_id.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_it.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_iw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ja.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ko.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lt.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_nl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_no.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-BR.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-PT.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ro.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ru.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_th.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_tr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_uk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_vi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-CN.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-TW.xtb
    • components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd
    • components/web_contents_delegate_android/BUILD.gn
    • docs/chromoting_android_hacking.md
    • tools/android/eclipse/.classpath
    • tools/gritsettings/resource_ids
    • tools/gritsettings/translation_expectations.pyl
  270. Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)

    Changed by nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 23:32:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 382c1d7689514b2bb3449f2ca14209ad5e75c472

    Comments

    Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c
    
    
    git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    
    
    Created with:
      gclient setdep -r src/native_client@e6ce828ef60c
    
    The AutoRoll server is located here: https://nacl-roll.skia.org
    
    Documentation for the Auto
    ...skip...
    eriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:None
    TBR=mseaborn@chromium.org
    
    Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9
    Reviewed-on: https://chromium-review.googlesource.com/1133873
    Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574404}

    Changed files

    • DEPS
  271. Don't remove ref-count on download IO TaskRunner

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 871b0dbb66c85679e88df8f62fd4ec0e3f471594

    Comments

    Don't remove ref-count on download IO TaskRunner
    
    There is no need to remove the IO TaskRunner reference.
    The global io thread task_runner is never deleted.
    If io TaskRunner is set, just ignore future calls.
    
    BUG=842245
    
    Change-Id: Ifefad6442d8efde238379218e9f11a9f3d99a75a
    Reviewed-on: https://chromium-review.googlesource.com/1134197
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574402}

    Changed files

    • components/download/internal/common/download_task_runner.cc
    • content/browser/download/download_manager_impl.cc
  272. Reorg DefaultAudioDestinationNode

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4247ad3b2fda13e8f4d57b68b639bea7d78df02

    Comments

    Reorg DefaultAudioDestinationNode
    
    No renaming or functional change. Just moving and grouping things
    around. Plus, some clarification/simplification of comments.
    
    Bug: 854229
    Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2
    Reviewed-on: https://chromium-review.googlesource.com/1133715
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574403}

    Changed files

    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
  273. [NTP] Remove transition duration for MV tile hover states

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c37fbfabcaaeabb50bbbf52dfa75c6fa7491e298

    Comments

    [NTP] Remove transition duration for MV tile hover states
    
    Bug: 851656
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada
    Reviewed-on: https://chromium-review.googlesource.com/1133686
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574406}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
  274. Clean up MASH_DEPRECATED in FlagWarningTray and test

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0795efc4ba54976c1ea978ec4c1fafe49e3ed77a

    Comments

    Clean up MASH_DEPRECATED in FlagWarningTray and test
    
    We don't run ash_unittests with --enable-features=Mash anymore, so
    manually turn on the flag to test the feature.
    
    Bug: 840391
    Test: ash_unittests
    Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d
    Reviewed-on: https://chromium-review.googlesource.com/1134418
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574405}

    Changed files

    • ash/system/flag_warning/flag_warning_tray.cc
    • ash/system/flag_warning/flag_warning_tray_unittest.cc
  275. Remove extra spaces in WindowTree logs

    Changed by mswohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59774f864d141afa5605ddba9ad153899c4dc295

    Comments

    Remove extra spaces in WindowTree logs
    
    Makes the debug logging output more consistent
    
    Bug: None
    Test: None
    Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966
    Reviewed-on: https://chromium-review.googlesource.com/1134428
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574408}

    Changed files

    • services/ui/ws2/window_tree.cc
  276. Roll HarfBuzz to 1.8.3

    Changed by drottohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5684ce09c352eb8ca64390c1fdb5f3de5e6bf60

    Comments

    Roll HarfBuzz to 1.8.3
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2
    
    And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily
    completed disabled compiler-assisted vectorisation.
    
    Bug: 860250, 862607
    Change-Id: If00101a279b23f5807a85973718183b33647195d
    Reviewed-on: https://chromium-review.googlesource.com/1133384
    Reviewed-by: Ben Wagner <bungeman@chromium.org>
    Commit-Queue: Dominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574407}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/BUILD.gn
    • third_party/harfbuzz-ng/README.chromium
  277. Surface Synchronization: Make Submission Flow Trace Less Noisy

    Changed by fsamuelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:38:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 852c66f84007b6c5ee4eb6150ec2534d5797b5b4

    Comments

    Surface Synchronization: Make Submission Flow Trace Less Noisy
    
    Only log an event if the LocalSurfaceId has changed instead of on
    every submit and receipt of CompositorFrames.
    
    Bug: 672962
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I4814ec0aaa9c204864d5c5df0c4a359d4ef3bb28
    Reviewed-on: https://chromium-review.googlesource.com/1134027
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574409}

    Changed files

    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/trees/layer_tree_host.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/surfaces/surface.cc
  278. Use three way flag for ChromeVox arc support

    Changed by yawanoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51d325c2a6fdc8f7be04d394645da611dd8ccad

    Comments

    Use three way flag for ChromeVox arc support
    
    - Use three way flag for ChromeVox arc support. This allows developers
      to easily switch between TalkBack on arc and ChromeVox arc support.
    - This CL also changes default to disabled (TalkBack on arc).
    
    Bug: 855310
    Test: None
    Change-Id: I301657798247da20eaf9ad734987b8d40790af1d
    Reviewed-on: https://chromium-review.googlesource.com/1130963
    Commit-Queue: Yuki Awano <yawano@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574411}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chromeos/chromeos_features.cc
    • chromeos/chromeos_features.h
    • chromeos/chromeos_switches.cc
    • chromeos/chromeos_switches.h
    • tools/metrics/histograms/enums.xml
  279. No removed or inserted text events on static text nodes

    Changed by aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d103e4761986c5f14e7b904ddf0b143fb1b6799

    Comments

    No removed or inserted text events on static text nodes
    
    Fire only 1 set of text removed/inserted events,
    only on the parent hypertext (not on the static text).
    This helps avoid redundant live region change announcements.
    
    Bug: 778478
    Change-Id: Ic68aab54d46c98576169ecb2146cd6414413e6ac
    Reviewed-on: https://chromium-review.googlesource.com/1134199
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574410}

    Changed files

    • content/test/data/accessibility/event/live-region-change-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
  280. device/bluetooth: Add a flag to show all unfiltered devices.

    Changed by sonnysasakaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:47:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7fecfeda3c0d0e1d1e8c79b141a858cd669335fa

    Comments

    device/bluetooth: Add a flag to show all unfiltered devices.
    
    Newblue development needs to see all the discovered devices unfiltered,
    so this flag is useful for Newblue development and can be removed once
    Newblue is stable.
    
    Bug: 840517
    Change-Id: I65c95c567ebfb8dbb6d831bfb1e1219b153346c0
    Reviewed-on: https://chromium-review.googlesource.com/1130655
    Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
    Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574412}

    Changed files

    • ash/BUILD.gn
    • ash/DEPS
    • ash/system/bluetooth/tray_bluetooth_helper_unittest.cc
    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • device/base/features.cc
    • device/base/features.h
    • device/bluetooth/chromeos/bluetooth_utils.cc
    • device/bluetooth/dbus/bluez_dbus_manager.cc
    • tools/metrics/histograms/enums.xml
  281. [VK] Remove OnWindowHierarchyChanged event handler.

    Changed by shendohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:52:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c597e35ea365cc192bfad7ef1effc618e427004

    Comments

    [VK] Remove OnWindowHierarchyChanged event handler.
    
    In https://crrev.com/14200002, we handled OnWindowHierarchyChanged in
    KeyboardController, which calls OnTextInputStateChanged. Originally,
    the author of the CL wanted to call OnTextInputStateChanged when the
    keyboard is enabled (so that if there's a focused textfield, we would
    show the keyboard [*]). However, OnTextInputChanged requires that the
    keyboard window is attached to a parent, which does not happen until
    later in the code. Hence, the author
    ...skip...
     can just move the code
    there without issues.
    
    [*] This behaviour is no longer true. OnTextInputChanged can't show
    the keyboard anymore under those circumstances. It may be possible
    to remove the OnTextInputChanged call completely.
    
    Bug: 845780
    Change-Id: I8fb028f3b03435e43c902b40e8ffe48844be1ea3
    Reviewed-on: https://chromium-review.googlesource.com/1132259
    Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574413}

    Changed files

    • ui/keyboard/keyboard_controller.cc
    • ui/keyboard/keyboard_controller.h
  282. Fix the mouse pointer for the omnibox.

    Changed by aviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:54:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 31de41a5cd7078ec8bc0b8bbb2dc82543a59f217

    Comments

    Fix the mouse pointer for the omnibox.
    
    While the results pane is showing, forward cursor requests to the
    underlying omnibox.
    
    Note that this won't actually show any changes until 851834 is fixed.
    
    BUG=836829,851834
    
    Change-Id: I9928fe8f690cc27f1844dbe1c0b3dae08082706d
    Reviewed-on: https://chromium-review.googlesource.com/1130167
    Commit-Queue: Avi Drissman <avi@chromium.org>
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Sidney San Martín <sdy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574416}

    Changed files

    • chrome/browser/ui/views/omnibox/rounded_omnibox_results_frame.cc
  283. Update watchlist for breve-team

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c48822897f1344928af004051305c19b4269d470

    Comments

    Update watchlist for breve-team
    
    Change-Id: Ic12456b72ab2730e5ab1dc79ea44386deb90873d
    Reviewed-on: https://chromium-review.googlesource.com/1134349
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574415}

    Changed files

    • WATCHLISTS
  284. Revert "Update Chrome callsites that use MainThreadFrameObserver"

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:53:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bc3c11ce575df33970f5b0f89160f38878ae9ce

    Comments

    Revert "Update Chrome callsites that use MainThreadFrameObserver"
    
    This reverts commit cb82e2e48313e755713f169fa151199fec459a02.
    
    Reason for revert: Test is failing on multiple builders, e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ASan%20Tests%20%28sandboxed%29/48812
    
    Original change's description:
    > Update Chrome callsites that use MainThreadFrameObserver
    > 
    > MainThreadFrameObserver does not guarantee that a compositor frame was actually
    > submitted. It however does sy
    ...skip...
     Samuel <fsamuel@chromium.org>
    > Commit-Queue: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574335}
    
    TBR=jonross@chromium.org,fsamuel@chromium.org
    
    Change-Id: Ica0e795ebad4dd81248a8e89b6f02c53e972a203
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862683
    Reviewed-on: https://chromium-review.googlesource.com/1133779
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574414}

    Changed files

    • chrome/browser/apps/guest_view/web_view_browsertest.cc
    • chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc
  285. [CrOS MultiDevice] Delete HostVerifierOperation.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:58:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dbe23b8a92e64607bd4ceb6a7a8ec9ec4f677a19

    Comments

    [CrOS MultiDevice] Delete HostVerifierOperation.
    
    After today's discussions, Bluetooth verification is no longer a step of
    the MultiDevice setup flow.
    
    Bug: 824568
    Change-Id: I155ec838c74f427cde820fbbbedcdf3a2a43b85b
    Reviewed-on: https://chromium-review.googlesource.com/1134474
    Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574417}

    Changed files

    • chromeos/services/multidevice_setup/BUILD.gn
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.cc
    • chromeos/services/multidevice_setup/fake_host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation.cc
    • chromeos/services/multidevice_setup/host_verifier_operation.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.cc
    • chromeos/services/multidevice_setup/host_verifier_operation_impl.h
    • chromeos/services/multidevice_setup/host_verifier_operation_impl_unittest.cc
  286. Mojo: Fix Mac Mach port brokering race

    Changed by rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:01:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1e5b3af2899e6c4888da7ad662ca1d2928e01ce8

    Comments

    Mojo: Fix Mac Mach port brokering race
    
    https://crrev.com/0e45f8023 somehow lost this logic before
    landing, probably during extensive debugging churn. :{
    
    Without this, it's possible for Mach port transfer to fail
    when sending to a new process. Seems to have gone undetected
    in production so far, but https://crrev.com/3e126191 managed
    to trip over it consistently in ipc_tests.
    
    Bug: 753541
    Change-Id: I835dc5f26326718af678acd6199c285d709b9040
    Reviewed-on: https://chromium-review.googlesource.com/1134079
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574418}

    Changed files

    • mojo/core/channel_posix.cc
  287. [Extensions Click-to-Script] Remove granted hosts when changing access

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:03:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23cd214fba4ed7ccfad450e53f6683dd428e58cc

    Comments

    [Extensions Click-to-Script] Remove granted hosts when changing access
    
    When transitioning from "on specific sites" to "on click", Chromium
    should remove specific granted sites from the extension. Do so, and
    add unittests for the same.
    
    Bug: 844128
    
    Change-Id: Icfa6c1f6449e94e30560a10cf43163f2fcedd996
    Reviewed-on: https://chromium-review.googlesource.com/1133775
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574420}

    Changed files

    • chrome/browser/extensions/api/developer_private/developer_private_api.cc
    • chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc
  288. Reland of: Add mojom call to send resource loading hints from browser to renderer.

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:02:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc97029f96fedad41b8600011d6c155810e50fe6

    Comments

    Reland of: Add mojom call to send resource loading hints from browser to renderer.
    
    The mojom call is send only when resource loading hints feature is
    enabled and the connection is slow.
    
    This is a reland of the CL that got reverted due to flaky
    browsertest. This reland is quite similar to the reverted CL,
    except for some changes in the browsertest.
    
    PS#1 is the original CL that got reverted.
    
    The fix is to retry fetching of histograms from the renderers.
    Note that previews_browsertest are currently e
    ...skip...
    's possible that the same flakiness bug is affecting the
    browser tests on Linux in this CL.
    
    Bug: 854666
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I753e488bef7318e43530a5594a94b24bd09295bb
    TBR: rkaplow@chromium.org, dcheng@chromium.org, pkasting@chromium.org, kinuko@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1131918
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574419}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/chrome_content_renderer_manifest_overlay.json
    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.h
    • chrome/browser/ui/tab_helpers.cc
    • chrome/test/BUILD.gn
    • chrome/test/data/previews/resource_loading_hints.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html
    • chrome/test/data/previews/resource_loading_hints_with_no_transform_header.html.mock-http-headers
    • components/optimization_guide/proto/hints.proto
    • components/optimization_guide/test_component_creator.cc
    • components/optimization_guide/test_component_creator.h
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_decider_impl.cc
    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
    • third_party/blink/public/mojom/BUILD.gn
    • third_party/blink/public/mojom/loader/previews_resource_loading_hints.mojom
    • third_party/blink/renderer/controller/blink_initializer.cc
    • third_party/blink/renderer/core/frame/local_frame.cc
    • third_party/blink/renderer/core/frame/local_frame.h
    • third_party/blink/renderer/core/loader/BUILD.gn
    • third_party/blink/renderer/core/loader/base_fetch_context.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.cc
    • third_party/blink/renderer/core/loader/previews_resource_loading_hints_receiver_impl.h
    • tools/metrics/histograms/histograms.xml
  289. Report data use from renderer to browser page load metrics

    Changed by rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:04:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db2671aa51b5f771f494b2911620711dbdddd115

    Comments

    Report data use from renderer to browser page load metrics
    
    Report the continuous data use to page load metrics in browser process
    via the existing renderer -> browser PageLoadMetrics mojo.
    
    Bug: 836029
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I1c7b47eb41e13f9b72d087e3ca2c0a7096c11b29
    Reviewed-on: https://chromium-review.googlesource.com/1042877
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: rajendrant <rajendrant@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574421}

    Changed files

    • chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
    • chrome/browser/page_load_metrics/metrics_web_contents_observer.h
    • chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc
    • chrome/browser/page_load_metrics/observers/page_load_metrics_observer_tester.cc
    • chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_observer.h
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.cc
    • chrome/browser/page_load_metrics/page_load_metrics_update_dispatcher.h
    • chrome/browser/page_load_metrics/page_load_tracker.cc
    • chrome/browser/page_load_metrics/page_load_tracker.h
    • chrome/common/page_load_metrics/page_load_metrics.mojom
    • chrome/renderer/BUILD.gn
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.cc
    • chrome/renderer/page_load_metrics/fake_page_timing_sender.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer.h
    • chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.cc
    • chrome/renderer/page_load_metrics/page_resource_data_use.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender.h
    • chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc
    • chrome/renderer/page_load_metrics/page_timing_sender.h
    • components/data_reduction_proxy/DEPS
    • components/data_reduction_proxy/core/common/BUILD.gn
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
  290. Chrome Settings: minor fix to settings_toggle_button padding

    Changed by probergeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:11:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b307437f07306488f4a72f45bec3e1217f0a99b

    Comments

    Chrome Settings: minor fix to settings_toggle_button padding
    
    When using a settings-toggle-button with a sub-label whose contents can
    fit into one or two lines depending on screen resolution, there was no
    way to get consistent vertical padding.
    
    This change explicitly sets padding inside of the settings_toggle_button's
    outerRow element in order to guarantee padding for the item.
    
    This has the negative side-effect of causing the
    settings-toggle-button to expand vertically if the window is resized such that
    the sub-label text overflows to a new line.
    
    Bug: 803683
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Iff644e6efb4aa293f4ae41e9035a961578d576f0
    Reviewed-on: