Home | Search
Login

Builder Linux Builder Perf Build #26806

Results:

build successful

Trigger Info:

Got Revisionb56c4e40b65ee14134dd2e61834f260ca9c1715e

Execution:

Steps and Logfiles:

Show:
  1. ( 52 mins 4 secs ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 1 ms ) remove .cipd
    remove .cipd
  9. ( 2 mins 43 secs ) bot_update
    bot_update
    [174GB/492GB used (35%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 24 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/Linux_Builder_Perf/src/testing/buildbot/chromium.perf.json
  16. ( 1 ms ) clean isolated files
    clean isolated files
  17. ( 19 secs ) generate_build_files
    generate_build_files
  18. ( 1 ms ) preprocess_for_goma
    preprocess_for_goma
  19. ( 1 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  20. ( 12 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  21. ( 1 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  22. ( 30 mins 59 secs ) compile
    compile
  23. ( 1 ms ) compile confirm no-op
    compile confirm no-op
  24. ( 1 ms ) postprocess_for_goma
    postprocess_for_goma
  25. ( 1 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  26. ( 1 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  27. ( 1 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  28. ( 13 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  29. ( 1 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  30. ( 1 ms ) remove_build_metadata
    remove_build_metadata
  31. ( 5 mins 9 secs ) isolate tests
    isolate tests
  32. ( 8 ms ) pinpoint isolate upload
    pinpoint isolate upload
  33. ( 25 secs ) package build for bisect
    package build for bisect
  34. ( 10 mins 10 secs ) package build
    package build
  35. ( 13 ms ) trigger
    trigger
    linux-perf
  36. ( 2 ms ) test_pre_run
    test_pre_run
  37. ( 9 secs ) sizes
    sizes
    sizes
    <div class="BuildResultInfo">
    </div>
  38. ( 1 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Linux_Builder_Perf/26806/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Linux_Builder_Perf/26806" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "b56c4e40b65ee14134dd2e61834f260ca9c1715e" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574538}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
swarm_hashes_refs/heads/master(at){#574538}_without_patch {"load_library_perf_tests":"ca88bc50a5561b7e93951b9430080ee3205e8377","media_perftests":"c1e384ba44f1757f1b81484fdece2e702a8e87aa","net_perftests":"858150e84af6740650a8cfef210a5b82d762632b","performance_test_suite":"01c622683adb8afdf21ff010f31f683b16929115","tracing_perftests":"0d1fd286793f587662470b89bda9844d92abf68a"} Annotation(isolate tests)
build_archive_url "gs://chrome-perf/Linux Builder Perf/full-build-linux_b56c4e40b65ee14134dd2e61834f260ca9c1715e.zip" Annotation(package build)
build_data_dir "/b/rr/tmpF1e1M4" Annotation(steps)
build_id "buildbot/chromium.perf/Linux Builder Perf/26806" Annotation(steps)
builder_id "master.chromium.perf:Linux Builder Perf" Annotation(steps)
blamelist ["ellyjones@chromium.org"] Build
branch "master" Build
buildnumber 26806 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531399034 Build
revision "b56c4e40b65ee14134dd2e61834f260ca9c1715e" Build
slavename "slave92-c1" BuildSlave
buildername "Linux Builder Perf" Builder
git_revision "b56c4e40b65ee14134dd2e61834f260ca9c1715e" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Linux_Builder_Perf" slave

Blamelist:

  1. (ellyjonesohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 12:37:15 UTC
End Thursday, 12-Jul-18 13:29:20 UTC
Pending N/A
Execution 52 mins 4 secs

All Changes:

  1. macviews: switch back to Cocoa menus for Views context menus

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus
    
    This change:
    1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
       the Cocoa menu runner code;
    2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
    3) Fixes a latent bug in Textfield that could cause it to delete its context
       menu while handling a context menu activation - this is fine with Views menus
       but forbidden with Cocoa menus.
    
    Bug: 860673
    Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
    Reviewed-on: https://chromium-review.googlesource.com/1131564
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc