Home | Search
Login

Builder Android Nexus6 WebView Perf Build #2062

Results:

exception steps exception performance_webview_test_suite on Android device Nexus 6

Trigger Info:

Got Revision896ba71bc975b53346521228a32536296ea5d80e

Execution:

Steps and Logfiles:

Show:
  1. ( 6 hrs 28 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 1 ms ) remove .cipd
    remove .cipd
  9. ( 1 mins 29 secs ) bot_update
    bot_update
    [100GB/492GB used (20%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 14 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/Android_Nexus6_WebView_Perf/src/testing/buildbot/chromium.perf.json
  16. ( 13 secs ) clean local files
    clean local files
  17. ( 1 ms ) tree truth steps
    tree truth steps
  18. ( 1 ms ) build directory
    build directory
  19. ( 1 mins 22 secs ) extract build
    extract build
  20. ( 1 ms ) find isolated tests
    find isolated tests
  21. ( 1 ms ) test_pre_run
    test_pre_run
  22. ( 23 secs ) test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 6
    test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 6
    Run on OS: 'Android'
  23. ( 6 hrs 23 mins ) performance_webview_test_suite on Android device Nexus 6
    performance_webview_test_suite on Android device Nexus 6
    Run on OS: 'Android'
    Max pending time: 0:01:04.761320 (shard #8)
    Max shard duration: 1:55:09.720980 (shard #6)
    Min shard duration: 0:03:03.914370 (shard #7)
    Total tests: 681
    * Passed: 630 (630 expected, 0 unexpected)
    * Skipped: 51 (51 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 ms ) Upload to test-results [performance_webview_test_suite on Android device Nexus 6]
    Upload to test-results [performance_webview_test_suite on Android device Nexus 6]
  25. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 15
    Total runtime: 12:44:58.950370
     
  26. ( 1 ms ) test_report
    test_report
  27. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Nexus6_WebView_Perf/2062/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Android_Nexus6_WebView_Perf/2062" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "896ba71bc975b53346521228a32536296ea5d80e" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574542}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"111a20852f600c85f2ad6048770a00af07506e2e","components_perftests":"1a54d852cf13af0bb974361db72702888babdef9","gpu_perftests":"5676d524103ad5b855128005d5727e16ff3b0d14","performance_test_suite":"6ab63a1dbd8c96b129f8a283f064bc6e53181329","performance_webview_test_suite":"6df67218cb88d939ac0bfbec14203c9e5f23bd26","tracing_perftests":"7d9958b8b548aef34b5119a1054b4a9ed9289bc7"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpUFT0OW" Annotation(steps)
build_id "buildbot/chromium.perf/Android Nexus6 WebView Perf/2062" Annotation(steps)
builder_id "master.chromium.perf:Android Nexus6 WebView Perf" Annotation(steps)
blamelist ["afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","ahemery@chromium.org","alancutter@chromium.org","atotic@chromium.org","awdf@chromium.org","blundell@chromium.org","cathiechen@tencent.com","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","dmazzoni@chromium.org","ellyjones@chromium.org","eyaich@google.com","falken@chromium.org","fane@google.com","foolip@chromium.org","guidou@chromium.org","hiroh@chromium.org","isandrk@google.com","leon.han@intel.com","lizeb@chromium.org","lucmult@chromium.org","marq@google.com","mathp@chromium.org","mkwst@chromium.org","msarda@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","peria@chromium.org","petermayo@chromium.org","rajendrant@chromium.org","raphael.kubo.da.costa@intel.com","rohitrao@chromium.org","shik@chromium.org","shimazu@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","tangltom@chromium.org","tkent@chromium.org","treib@chromium.org","yamaguchi@chromium.org","yhirano@chromium.org","yoshiki@chromium.org","yyanagisawa@chromium.org"] Build
branch "master" Build
buildnumber 2062 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531376600 Build
revision "896ba71bc975b53346521228a32536296ea5d80e" Build
slavename "slave213-c1" BuildSlave
buildername "Android Nexus6 WebView Perf" Builder
git_revision "896ba71bc975b53346521228a32536296ea5d80e" Change
parent_buildername "Android Compile Perf" ParentBuild
parent_buildnumber 26810 ParentBuild
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "896ba71bc975b53346521228a32536296ea5d80e" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574542}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" ParentBuild
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Android_Nexus6_WebView_Perf" slave

Blamelist:

  1. (cathiechenohnoyoudont@tencent.com)
  2. (hirohohnoyoudont@chromium.org)
  3. (dmazzoniohnoyoudont@chromium.org)
  4. (treibohnoyoudont@chromium.org)
  5. (alancutterohnoyoudont@chromium.org)
  6. (lucmultohnoyoudont@chromium.org)
  7. (periaohnoyoudont@chromium.org)
  8. (awdfohnoyoudont@chromium.org)
  9. (shimazuohnoyoudont@chromium.org)
  10. (lucmultohnoyoudont@chromium.org)
  11. (atoticohnoyoudont@chromium.org)
  12. (rajendrantohnoyoudont@chromium.org)
  13. (falkenohnoyoudont@chromium.org)
  14. (raphael.kubo.da.costaohnoyoudont@intel.com)
  15. (blundellohnoyoudont@chromium.org)
  16. (guidouohnoyoudont@chromium.org)
  17. (yoshikiohnoyoudont@chromium.org)
  18. (falkenohnoyoudont@chromium.org)
  19. (mkwstohnoyoudont@chromium.org)
  20. (tangltomohnoyoudont@chromium.org)
  21. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  22. (leon.hanohnoyoudont@intel.com)
  23. (faneohnoyoudont@google.com)
  24. (mkwstohnoyoudont@chromium.org)
  25. (rohitraoohnoyoudont@chromium.org)
  26. (marqohnoyoudont@google.com)
  27. (yamaguchiohnoyoudont@chromium.org)
  28. (mkwstohnoyoudont@chromium.org)
  29. (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  30. (foolipohnoyoudont@chromium.org)
  31. (mathpohnoyoudont@chromium.org)
  32. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  33. (yhiranoohnoyoudont@chromium.org)
  34. (petermayoohnoyoudont@chromium.org)
  35. (yoshikiohnoyoudont@chromium.org)
  36. (shikohnoyoudont@chromium.org)
  37. (lizebohnoyoudont@chromium.org)
  38. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  39. (ahemeryohnoyoudont@chromium.org)
  40. (mkwstohnoyoudont@chromium.org)
  41. (tkentohnoyoudont@chromium.org)
  42. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  43. (ellyjonesohnoyoudont@chromium.org)
  44. (isandrkohnoyoudont@google.com)
  45. (mkwstohnoyoudont@chromium.org)
  46. (yyanagisawaohnoyoudont@chromium.org)
  47. (msardaohnoyoudont@chromium.org)
  48. (eyaichohnoyoudont@google.com)

Timing:

Create N/A
Start Thursday, 12-Jul-18 14:03:26 UTC
End Thursday, 12-Jul-18 20:31:51 UTC
Pending N/A
Execution 6 hrs 28 mins

All Changes:

  1. [LayoutNG]Make the first marker of nested list occupying a whole line

    Changed by cathiechenohnoyoudont@tencent.com
    Changed at Thursday, 12-Jul-18 05:58:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 347323ce0f71964c59a50c507f14484baff8a386

    Comments

    [LayoutNG]Make the first marker of nested list occupying a whole line

In legacy Layout, there's line-break between marker and the nesting
<ul>/<ol>. In order to keep consistency with it, add NeedsOccupyWholeLine()
in LayoutNGListMarker to indicate that marker would occupy a line.
During Layout(), this kind of marker won't be added to container_builder_,
and layout directly. And its margin will be handled after layout.

Bug: 725277

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie9f6dbca0945c8e031ec7bb44594db2e96773462
Reviewed-on: https://chromium-review.googlesource.com/1132819
Commit-Queue: cathie chen <cathiechen@tencent.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574495}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/001-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/003-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/doctypes/004-expected.txt
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.cc
    • third_party/blink/renderer/core/layout/ng/list/layout_ng_list_marker.h
    • third_party/blink/renderer/core/layout/ng/list/ng_unpositioned_list_marker.h
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc

  2. media/gpu/test/RenderingHelper: Unify interface to process video frame

    Changed by hirohohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:09:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c9e1a62b97488da8c36e7c12d0fe9769a60b4238

    Comments

    media/gpu/test/RenderingHelper: Unify interface to process video frame

VDA test client calls RenderingHelper::RenderThumbnail() if a thumbnail is made
from a video frame. Otherwise, it calls RenderingHelper::QueueVideoFrame().
RenderingHelper itself knows which function to be called, and thus these
functions should be unified into a single interface.

BUG=chromium:834170
TEST=VDA unittest at veyron_minnie and eve

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I106d4ce1c05b003d6333a6865a8d96e276031598
Reviewed-on: https://chromium-review.googlesource.com/1122656
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574496}

    Changed files

    • media/gpu/test/rendering_helper.cc
    • media/gpu/test/rendering_helper.h
    • media/gpu/video_decode_accelerator_unittest.cc

  3. Track changes to nodes that are in the AX tree but aren't laid out.

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:41:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d535bf95b998d1061629905139485c937272fc3b

    Comments

    Track changes to nodes that are in the AX tree but aren't laid out.

Previously we only had hooks to update the children of a node in the
AX tree when LayoutObjects were inserted or removed. That left out some
corner cases when Nodes are inserted or removed that are part of the
AX tree but not laid out, like nodes in the accessible / fallback content
for a canvas.

Bug: 862311
Change-Id: I9482a9e0dc9ba45368b2fc87ea3449bdd4ef1c50
Reviewed-on: https://chromium-review.googlesource.com/1132119
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574497}

    Changed files

    • third_party/WebKit/LayoutTests/accessibility/children-changed-in-canvas.html
    • third_party/blink/renderer/core/dom/element.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.h
    • third_party/blink/renderer/modules/accessibility/ax_node_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_node_object.h

  4. Replace ThreadChecker by SequenceChecker in /components/sync*

    Changed by treibohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 06:54:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1

    Comments

    Replace ThreadChecker by SequenceChecker in /components/sync*

https://crrev.com/c/1131474 removed the unnecessary thread-affinity,
this one adjusts the checks accordingly.

Bug: 846238
Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655
Reviewed-on: https://chromium-review.googlesource.com/1131738
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574498}

    Changed files

    • components/sync/driver/glue/sync_backend_host_core.cc
    • components/sync/driver/glue/sync_backend_host_core.h
    • components/sync/driver/glue/sync_backend_host_impl.cc
    • components/sync/driver/glue/sync_backend_host_impl.h
    • components/sync/driver/sync_service_crypto.cc
    • components/sync/driver/sync_service_crypto.h
    • components/sync/engine/sync_backend_registrar.cc
    • components/sync/engine/sync_backend_registrar.h
    • components/sync/engine_impl/debug_info_event_listener.cc
    • components/sync/engine_impl/debug_info_event_listener.h
    • components/sync/engine_impl/model_type_worker.cc
    • components/sync/engine_impl/model_type_worker.h
    • components/sync/engine_impl/net/server_connection_manager.cc
    • components/sync/engine_impl/net/server_connection_manager.h
    • components/sync/engine_impl/sync_manager_impl.cc
    • components/sync/engine_impl/sync_manager_impl.h
    • components/sync/engine_impl/sync_manager_impl_unittest.cc
    • components/sync/test/engine/fake_model_worker.cc
    • components/sync/test/engine/fake_model_worker.h
    • components/sync_bookmarks/bookmark_change_processor.cc
    • components/sync_bookmarks/bookmark_change_processor.h

  5. Add find bar icon to hosted app windows

    Changed by alancutterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:03:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35f205a1441afebe9987e606c7c876d5bfc4594

    Comments

    Add find bar icon to hosted app windows

This CL moves the find icon from LocationBarView into PageActionIconContainerView
enabling the icon to appear in hosted app window title bars.

This change also fixes the find icon getting nudged by
crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e.

Before 108c0687254683b3beeaa32b6e0a86f2046a867e:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1
Before CL:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1
After CL:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1

Bug: 788051, 814531
Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967
Reviewed-on: https://chromium-review.googlesource.com/1054908
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574499}

    Changed files

    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/find_bar/find_bar_controller.cc
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/page_action/page_action_icon_container.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.cc
    • chrome/browser/ui/views/frame/hosted_app_button_container.h
    • chrome/browser/ui/views/frame/toolbar_button_provider.h
    • chrome/browser/ui/views/location_bar/find_bar_icon.cc
    • chrome/browser/ui/views/location_bar/find_bar_icon.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
    • chrome/browser/ui/views/page_action/page_action_icon_container_view.h
    • chrome/browser/ui/views/toolbar/toolbar_view.cc
    • chrome/browser/ui/views/toolbar/toolbar_view.h
    • chrome/test/base/test_browser_window.h

  6. Change test to use full-path-for-testing attribute selector

    Changed by lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:12:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4

    Comments

    Change test to use full-path-for-testing attribute selector

This makes this test compatible with directory tree having My Files or
not, and makes the test more readable too.

This is a preparation to enable new navigation (with My Files) by
default.

Bug: 857335
No-presubmit: true
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21
Reviewed-on: https://chromium-review.googlesource.com/1133610
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574500}

    Changed files

    • ui/file_manager/integration_tests/file_manager/context_menu.js
    • ui/file_manager/integration_tests/file_manager/create_new_folder.js
    • ui/file_manager/integration_tests/file_manager/folder_shortcuts.js

  7. oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

    Changed by periaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 07:41:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0

    Comments

    oilpan: Make ImageLoader::Task::script_state_ WeakPersistent

ImageLoader::Task class does not actually own the script state,
so its reference can be weak.
This CL makes the reference weak.

Bug: 773605
Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6
Reviewed-on: https://chromium-review.googlesource.com/1134629
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574501}

    Changed files

    • third_party/blink/renderer/core/loader/image_loader.cc

  8. [Android PageInfo] Refactor PageInfoController to enable testing

    Changed by awdfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:05:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dfb08c4ccef342639df17f6a423643df1784b767

    Comments

    [Android PageInfo] Refactor PageInfoController to enable testing

- Extracted PermissionParamsListBuilder from PageInfoController
to handle all the permission-related logic when displaying
permissions in page info. This new class requires fewer
hard-to-unit-test dependencies so its logic can now be tested.

Bug: 691898
Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4
Reviewed-on: https://chromium-review.googlesource.com/1103564
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574502}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
    • chrome/android/java_sources.gni
    • chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java

  9. NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

    Changed by shimazuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:13:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 670a4fd7d5c89c8904f638edda72083e41e5d016

    Comments

    NetS13nServiceWorker: Add more info to traces in SWNavigationLoader

Bug: 806658
Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17
Reviewed-on: https://chromium-review.googlesource.com/1134711
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574503}

    Changed files

    • content/browser/service_worker/service_worker_navigation_loader.cc

  10. Add new methods to EntryList and tests

    Changed by lucmultohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d

    Comments

    Add new methods to EntryList and tests

Change the logic to add entries to My Files to account for volume being
mounted/unmounted. This fixes some broken tests when running with the
flag enabled by default, so test to cover this is on
crrev.com/c/1131025.

Fix test getMetadata function name.

Bug: 857335
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917
Reviewed-on: https://chromium-review.googlesource.com/1133613
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574505}

    Changed files

    • ui/file_manager/file_manager/common/js/files_app_entry_types.js
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
    • ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model.js
    • ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js

  11. [LayoutNG] Fix static position for inline containing block

    Changed by atoticohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:24:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f321a196a45bce7d32257d0b93b472dba89e205a

    Comments

    [LayoutNG] Fix static position for inline containing block

Bug: 740993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541
Reviewed-on: https://chromium-review.googlesource.com/1134386
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574504}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc

  12. Use PLM for data saver site-breakdown

    Changed by rajendrantohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62

    Comments

    Use PLM for data saver site-breakdown

This CL adds PLM observer for site-breakdown that records the data use
by host. The new codepath is enabled and the old data use asriber observer
based site-breakdown codepath is disabled, based on a feature.

Bug: 836029
Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219
Reviewed-on: https://chromium-review.googlesource.com/1050868
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574506}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
    • chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
    • chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • chrome/test/BUILD.gn
    • components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
    • components/data_reduction_proxy/core/common/data_reduction_proxy_params.h

  13. Add service worker README.md.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 08:46:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034

    Comments

    Add service worker README.md.

Bug: 795989
Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d
Reviewed-on: https://chromium-review.googlesource.com/1134718
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574507}

    Changed files

    • content/browser/service_worker/README.md
    • content/common/service_worker/README.md
    • third_party/blink/common/service_worker/README.md
    • third_party/blink/public/common/service_worker/README.md
    • third_party/blink/public/mojom/service_worker/README.md
    • third_party/blink/public/platform/modules/service_worker/README.md
    • third_party/blink/public/web/modules/service_worker/README.md
    • third_party/blink/renderer/modules/service_worker/README.md

  14. Revert "licenses.py: Skip another //tools/binary_size subdirectory."

    Changed by raphael.kubo.da.costaohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:19:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cc3a2b34c667b8e2e0cde7766e9439e80fb72174

    Comments

    Revert "licenses.py: Skip another //tools/binary_size subdirectory."

This reverts commit a6c69c8113a7113cc6b4a4f8de3291095d717e40.

Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1080401 moved gvr-android-sdk into a directory we already skip, so this is no longer needed.

Original change's description:
> licenses.py: Skip another //tools/binary_size subdirectory.
> 
> Commit 6a15a6c4 ("SuperSize: Teach it about thin archives") added a
> third_party directory to tools/bin
...skip...
costa@intel.com>
> Cr-Commit-Position: refs/heads/master@{#564081}

TBR=raphael.kubo.da.costa@intel.com,scottmg@chromium.org,ichikawa@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I8a85ee225f54a0499ee18e20311dfd5b9dc280fe
Reviewed-on: https://chromium-review.googlesource.com/1133138
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#574509}

    Changed files

    • tools/licenses.py

  15. OAuth2LoginManager: Handle consecutive refresh token updates

    Changed by blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2f7998c5e85ffebc0c1f7588bcc45a73e1de4dc

    Comments

    OAuth2LoginManager: Handle consecutive refresh token updates

OAuth2LoginManager currently assumes that
OAuth2TokenService::Observer::OnRefreshTokenAvailable() will never be
called twice consecutively for the primary account; in particular,
it calls VerifySessionCookies(), which DCHECKS that
|oauth2_login_verifier_| is null before instantiating that ivar.

However, this assumption is no longer valid. A simple example:
- A refresh token is found during startup, resulting in
  OnRefreshTokenAvailable() 
...skip...
+/1126861,
which is firing the "token available" notification as part of startup
when adding an invalid token for the primary account and triggers the
DCHECK above on ChromeOS browsertests. Those failures were how I
discovered this issue.

Change-Id: I55ced6fe49055c6c6c4d1e7ce138a0d080ecda38
Reviewed-on: https://chromium-review.googlesource.com/1127662
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574511}

    Changed files

    • chrome/browser/chromeos/login/signin/oauth2_login_manager.cc

  16. Add AudioLogFactory mojo interface.

    Changed by guidouohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:19:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ee6cfd00b7b35f8bc4ced3eecc801fa2f55a85ae

    Comments

    Add AudioLogFactory mojo interface.

This interface allows a mojo client to create audio logs on
the browser process.
This CL also removes content::MojoLogAudioAdapter, which is moved to the
audio service as audio::LogAdapter in follow-up CL crrev.com/c/1128974

Bug: 812557
Change-Id: I70504a4878553f1a3c2d58a29c6ab960b6f15b39
Reviewed-on: https://chromium-review.googlesource.com/1128966
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574508}

    Changed files

    • content/browser/BUILD.gn
    • content/browser/media/audio_log_factory.cc
    • content/browser/media/audio_log_factory.h
    • content/browser/media/media_internals.cc
    • content/browser/media/media_internals.h
    • content/browser/media/mojo_audio_logging_adapter.cc
    • content/browser/media/mojo_audio_logging_adapter.h
    • media/mojo/interfaces/audio_logging.mojom

  17. Cancel long-press operation if the gesture is scrolling

    Changed by yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:21:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d417866204188b709447dfb64ba68740a182b7a5

    Comments

    Cancel long-press operation if the gesture is scrolling

This CL adds the code to cancel the long-press operation which shows
inline setting when the user stats the scrollingo

Previously that was done in Android (ag/4340201) but it didn't work
for vertical scroll since the scroll is handled on Chrome side. With
this CL, scroll detection is done on Chrome side and the code handles
correctly with vertical scrolls in addition to horizontal ones.

Bug: b/111100376
Bug: 858938
Test: Manual (inline setting does't open during vertical scroll)
Change-Id: I84407b331dc320e6acd3a776938104ad018d46a3
Reviewed-on: https://chromium-review.googlesource.com/1124263
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574512}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc
    • ash/system/message_center/arc/arc_notification_item.h
    • ash/system/message_center/arc/arc_notification_item_impl.cc
    • ash/system/message_center/arc/arc_notification_item_impl.h
    • ash/system/message_center/arc/arc_notification_manager.cc
    • ash/system/message_center/arc/arc_notification_manager.h
    • ash/system/message_center/arc/mock_arc_notification_item.h
    • components/arc/common/notifications.mojom
    • components/arc/test/fake_notifications_instance.cc
    • components/arc/test/fake_notifications_instance.h

  18. shared worker: Simplify the default network factory logic.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:20:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab39b893750485f84d1f607be642fe1efdc27f7f

    Comments

    shared worker: Simplify the default network factory logic.

When NetworkService is off but S13nSW is on, shared worker jumped
through hoops to get a factory bundle to the renderer. It was
giving the renderer a NetworkService default factory and expecting the
renderer to clear it.

But we can just give a non-NetworkService direct network default factory,
since that capability was added in r565058.

Bug: 839982
Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f
Reviewed-on: https://chromium-review.googlesource.com/1134708
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574510}

    Changed files

    • content/browser/shared_worker/shared_worker_host.cc
    • content/renderer/shared_worker/embedded_shared_worker_stub.cc

  19. Revert "Delete the media cache(s) when using a single combined HTTP cache."

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:35:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8

    Comments

    Revert "Delete the media cache(s) when using a single combined HTTP cache."

This reverts commit e226149af1b3f003b5d3f59e19ee17bef7419c42.

Reason for revert: 

`ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache` and `ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache` have been failing, apparently since they were added by this CL.

They were added here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28016 (which failed to actually run `browser_test`) and
...skip...
Orlovich <morlovich@chromium.org>
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574296}

TBR=mmenke@chromium.org,morlovich@chromium.org

Change-Id: Ibc519750f00ad7e698d279af6baffe77b32d30be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789657, 862945
Reviewed-on: https://chromium-review.googlesource.com/1134886
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574513}

    Changed files

    • chrome/browser/profiles/profile_browsertest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc

  20. [unified-consent] Enable sync everything only when sync is active

    Changed by tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:41:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision eef2c0be5716d8857f9ff7dce265e2569c8d333e

    Comments

    [unified-consent] Enable sync everything only when sync is active

UnifiedConsentService is observing changes of the sync service,
so the sync data types are only enabled when sync is started up
and active.

Bug: 862139, 819909
Change-Id: I4c006e0c1cc7b263f113865da0c128620e1817ae
Reviewed-on: https://chromium-review.googlesource.com/1131744
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574515}

    Changed files

    • components/unified_consent/unified_consent_service.cc
    • components/unified_consent/unified_consent_service.h
    • components/unified_consent/unified_consent_service_unittest.cc

  21. Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)

    Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 09:40:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f198a1c4c492486c961c0a112247ddac9a9e3379

    Comments

    Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32e3d1e37cd6..2b138f742b74


git log 32e3d1e37cd6..2b138f742b74 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 sdefresne@chromium.org Avoid creating an empty netrc file in $TEMP


Created with:
  gclient setdep -r src/third_party/depot_tools@2b138f742b74

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation f
...skip...
on the roll, and stop the roller if necessary.



BUG=chromium:none
TBR=agable@chromium.org

Change-Id: I8e88cdcad6399e9a7b117a2fe36dc264a6e61c78
Reviewed-on: https://chromium-review.googlesource.com/1134149
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574514}

    Changed files

    • DEPS

  22. [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

    Changed by leon.hanohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:45:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d00d598cb4ae00510a30326c3db46f9b0506e36d

    Comments

    [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

This CL removes native struct ServiceWorkerProviderHostInfo and the
corresponding typemapping for it, instead, directly uses mojom struct
ServiceWorkerProviderHostInfo everywhere.

BUG=789854

Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
Reviewed-on: https://chromium-review.googlesource.com/1132847
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574516}

    Changed files

    • content/browser/service_worker/service_worker_dispatcher_host.cc
    • content/browser/service_worker/service_worker_dispatcher_host.h
    • content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
    • content/browser/service_worker/service_worker_object_host_unittest.cc
    • content/browser/service_worker/service_worker_provider_host.cc
    • content/browser/service_worker/service_worker_provider_host.h
    • content/browser/service_worker/service_worker_provider_host_unittest.cc
    • content/browser/service_worker/service_worker_test_utils.cc
    • content/browser/service_worker/service_worker_test_utils.h
    • content/common/BUILD.gn
    • content/common/service_worker/service_worker_provider.mojom
    • content/common/service_worker/service_worker_provider.typemap
    • content/common/service_worker/service_worker_provider_host_info.cc
    • content/common/service_worker/service_worker_provider_host_info.h
    • content/common/service_worker/service_worker_provider_struct_traits.cc
    • content/common/service_worker/service_worker_provider_struct_traits.h
    • content/common/typemaps.gni
    • content/renderer/service_worker/service_worker_network_provider.cc

  23. Fix description of NetworkPredictionOptions policy

    Changed by faneohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:46:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d8142d8da58d317cc159294a6b9c6139e7173b1

    Comments

    Fix description of NetworkPredictionOptions policy

Removed unnecessary preference names from description.

Bug: 858829
Change-Id: Ic75e9af5ebca5e56c20e796e1991a217ad427246
Reviewed-on: https://chromium-review.googlesource.com/1131115
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Stefan Teodorescu <fane@google.com>
Cr-Commit-Position: refs/heads/master@{#574517}

    Changed files

    • components/policy/resources/policy_templates.json

  24. Disabling ViewIDTest.Basic.

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fc8ad7e2561f48248fee640b72a808f1592634a

    Comments

    Disabling ViewIDTest.Basic.

This test is consistently failing on:

* 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018
* 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366
* 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145

TBR=mkwst@chromium.org,kpaulhamus@chromium.org

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862945
Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908
Reviewed-on: https://chromium-review.googlesource.com/1134780
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574518}

    Changed files

    • chrome/browser/ui/cocoa/view_id_util_browsertest.mm

  25. [ios] Adds icons and hides headers on the main Settings page.

    Changed by rohitraoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

    Comments

    [ios] Adds icons and hides headers on the main Settings page.

Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing

BUG=805213,805214

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
Reviewed-on: https://chromium-review.googlesource.com/1133323
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574520}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
    • ios/chrome/browser/ui/settings/resources/BUILD.gn
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
    • ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

  26. [iOS] Tweak tab grid transition animations.

    Changed by marqohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e96b9e2a058ddc4573deba9c0159077c8a89b45d

    Comments

    [iOS] Tweak tab grid transition animations.

This CL adjusts the tab grid transition animations.

(A) The timing (curve, delay, and duration) of some of the sub-animations is tweaked.

(B) Because -viewWillAppear: is called inside the animation, some of the
    setup for the animations needs to be done before that method is called;
    the cleanest mechanism seemed to be to make these changes when the view
    disappeared. This is mostly setting the toolbar alpha to zero so it can be
    faded in during the animation.


Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8c84f5726a0ce49e13c5fd32ab91295ffbb00e57
Reviewed-on: https://chromium-review.googlesource.com/1127994
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574519}

    Changed files

    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm

  27. Always align slider bubbles to the bottom of the desktop.

    Changed by yamaguchiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:06:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a0ab14f53bb9b6346969ec10d376d51aff8eceb

    Comments

    Always align slider bubbles to the bottom of the desktop.

The slider was aligned towards the system tray icon view in the shelf
by the bubble's bottom edge. It meant that the slider bubble was shown
apart from the bottom of the desktop when the shelf layout is either
right or left. It was not consistent with popup notification, causing
view overlap between notifications and a slider bubble.

Bug: 862496
Change-Id: Ie6db618f8b744ecc4de52ee7a4866ca9e9ecd26c
Reviewed-on: https://chromium-review.googlesource.com/1134643
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574521}

    Changed files

    • ash/system/unified/unified_slider_bubble_controller.cc

  28. Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:11:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 197e9188dc5be69cb34e1ebd67f86a1146439367

    Comments

    Revert "Make NetworkConnectionTracker survive network service crashes and restarts"

This reverts commit cec0800c372ef670f59999fb3f028013d36b866c.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified this CL at revision 574314 as the culprit
for introducing flakiness in the tests as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vY2VjMDgwMGMzNzJlZjY3MGY1OTk5OWZiM2YwMjgwMTNkMzZiODY2Yww

TBR=xunjieli@chro
...skip...
lek <jam@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574314}

TBR=jam@chromium.org,xunjieli@chromium.org,tbansal@chromium.org

Change-Id: I2524f0e04441097e06585f4f2e4cdb948a419641
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 821009
Reviewed-on: https://chromium-review.googlesource.com/1135006
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574523}

    Changed files

    • chrome/browser/browser_process_impl.cc
    • chrome/browser/net/network_connection_tracker_browsertest.cc
    • chrome/browser/net/network_quality_tracker_browsertest.cc
    • content/public/browser/network_connection_tracker.cc
    • content/public/browser/network_connection_tracker.h
    • content/public/browser/network_connection_tracker_unittest.cc

  29. Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

    Changed by afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:04:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a837f9d78ab2670ad242acd3651e0bf1f29a2a39

    Comments

    Roll AFDO from 69.0.3488.0_rc-r1 to 69.0.3489.0_rc-r1

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

I
...skip...
 contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I0095acd5d9522beaf64a43baf3bb71106038fe7c
Reviewed-on: https://chromium-review.googlesource.com/1134870
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574522}

    Changed files

    • chrome/android/profiles/newest.txt

  30. Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import

    Changed by foolipohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:24:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3dea5439837339b97168cdbbf6a45bfa27748b16

    Comments

    Mark textdecoder-fatal-single-byte.any.worker.html flaky to unblock WPT import

TBR=robertma

Bug: 862938
Change-Id: I9ceda537526da02ebadc9799d58fb042d7f339d3
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1134770
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574524}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations

  31. [NTP] Adding mathp@ as owner of components/search

    Changed by mathpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:31:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1bc34891c3dbe8da1ac513111db7c7d2efd56f20

    Comments

    [NTP] Adding mathp@ as owner of components/search

Few reasons for this:
- My team and myself are now owners of the feature
- Both current owners are gone through the end of July
- I am owners of other parts of the NTP code (resources, data sources) as well
  as server-side code; as such, I think I'm qualified.

Bug: None
Change-Id: Ic1261dacba81a420500240c5a55bc547fb8b6c14
Reviewed-on: https://chromium-review.googlesource.com/1133767
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574526}

    Changed files

    • components/search/OWNERS

  32. Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 11:28:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1f9c10c3ca23a47aa60fe21a5b990c9d7cd589a

    Comments

    Roll src/third_party/pdfium d8882193737a..68d04f284423 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/d8882193737a..68d04f284423


git log d8882193737a..68d04f284423 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 art-snake@yandex-team.ru Reland "Avoid duplicate data buffering in CPDF_SyntaxParser::ReadStream()."


Created with:
  gclient setdep -r src/third_party/pdfium@68d04f284423

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoR
...skip...
current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I09ab0d06005fa49756095e583c16e039d0c8df3c
Reviewed-on: https://chromium-review.googlesource.com/1134846
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574525}

    Changed files

    • DEPS

  33. [Fetch] Use wrapper tracing to express references between wrappers

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:53:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4a7c8ee607674efabc720016992893e2226ce3a0

    Comments

    [Fetch] Use wrapper tracing to express references between wrappers

This is a reland of
https://crrev.com/8057f58cb22579bc685efa50c579325ed047d51a which has
been reverted due to a crash issue. The crash was caused by a missing
TraceWrapperMember in blink::Response. This CL fixes that, and adds
a layout test to verify that.

Original CL: https://chromium-review.googlesource.com/c/1124270

Bug: 862440
Change-Id: I2842b957f223cfb32fee2aa9048b550010cb2e45
Reviewed-on: https://chromium-review.googlesource.com/1134642
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574527}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/fetch/chromium/body-wrapper-tracing.html
    • third_party/blink/renderer/core/fetch/body_stream_buffer.cc
    • third_party/blink/renderer/core/fetch/body_stream_buffer.h
    • third_party/blink/renderer/core/fetch/fetch_request_data.cc
    • third_party/blink/renderer/core/fetch/fetch_request_data.h
    • third_party/blink/renderer/core/fetch/fetch_response_data.cc
    • third_party/blink/renderer/core/fetch/fetch_response_data.h
    • third_party/blink/renderer/core/fetch/request.cc
    • third_party/blink/renderer/core/fetch/request.h
    • third_party/blink/renderer/core/fetch/response.cc
    • third_party/blink/renderer/core/fetch/response.h
    • third_party/blink/renderer/modules/service_worker/fetch_event.cc
    • third_party/blink/renderer/modules/service_worker/fetch_event.h
    • third_party/blink/renderer/platform/bindings/v8_private_property.h

  34. Re-enable opening-handshake/003-sets-origin.worker.html

    Changed by petermayoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 11:58:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18929b41e24487865c4ed9da46129e6b037beeb

    Comments

    Re-enable opening-handshake/003-sets-origin.worker.html

These tests no longer timeout.  The flakiness dashboard is green
for a long time.

Bug: 803558
Change-Id: I2924740d2c736419fdc5130e546f557c8d874151
Reviewed-on: https://chromium-review.googlesource.com/1134094
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574528}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations

  35. Activate widget correctly when the inline reply opens on ARC notification

    Changed by yoshikiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab9d0ad4ed6a95ee7675fabb4d16cf63d286dba2

    Comments

    Activate widget correctly when the inline reply opens on ARC notification

When a non-ARC normal window (eg. Chrome browser window) was active, the
inline textbox didn't work for the second time and later. This CL solves
this issue.

This was because the widget was not activated correctly (IsActive() was
true but CanActivate() was false) in that case. This CL removes the
IsActive() guard to make the widget active correctly whenever the inline
reply opens.

Bug: b/111100376
Bug: 858938
Test: manual (inline reply can be used multiple times)

Change-Id: I65d7604be5d24ff1e6c56336a76a5951d6066b39
Reviewed-on: https://chromium-review.googlesource.com/1133039
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574531}

    Changed files

    • ash/system/message_center/arc/arc_notification_content_view.cc

  36. media: sync the camera metadata definitions

    Changed by shikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:13:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38884d4717c2517cb832722d0fa4871a89d19799

    Comments

    media: sync the camera metadata definitions

We need some new metadata tags for external camera, so regenerate and
sync all of them in arc-camera, chromium, and ARC++.

Some "arc" are replaced by "cros" manually.

BUG=b:77833131
TEST=Verify CCA works on Nautilus.

Change-Id: I308e258d9b72acdd825591041a67ce7352dce6a8
Reviewed-on: https://chromium-review.googlesource.com/1117970
Reviewed-by: Ricky Liang <jcliang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574530}

    Changed files

    • media/capture/video/chromeos/mojo/camera_metadata_tags.mojom

  37. blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

    Changed by lizebohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d1fef2b1ad38fe1ef8c3914fb5dadc39bae80b9b

    Comments

    blink/wtf: Really move MovableStrings when DCHECK_IS_ON.

When a MovableString is parked, actually park the content, and poison
the previous allocation. This is intended to find cached raw pointer
accesses, which are not allowed beyond the UI thread task per the
contract of the class.
Enabled only when DCHECK_IS_ON to prevent potential crashes.

Changes with and without DCHECK()s:
- Cache some String properties in MovableStringImpl
- Add a parked_strings_ to MovableStringTable for accounting, and
  update tests accordingly.

Changes with DCHECK()s:
- Add a parked_string_ member to MovableStringImpl
- Copy the string to the parked version in Park(), and poison the
  previous allocation.
- Restore the string in Unpark().

Bug: 837659
Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
Reviewed-on: https://chromium-review.googlesource.com/1133169
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574529}

    Changed files

    • third_party/blink/renderer/platform/wtf/text/movable_string.cc
    • third_party/blink/renderer/platform/wtf/text/movable_string.h
    • third_party/blink/renderer/platform/wtf/text/movable_string_test.cc

  38. Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a66959734236ca95f9372334bfa18bbc7a5a1b52

    Comments

    Roll src/third_party/skia fcc10da18eb5..4d6a844365e7 (9 commits)

https://skia.googlesource.com/skia.git/+log/fcc10da18eb5..4d6a844365e7


git log fcc10da18eb5..4d6a844365e7 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files
2018-07-12 herb@google.com Use new SkGlyphIDSet - v3
2018-07-12 bungeman@google.com Remove SkDrawFilter.
2018-07-12 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll thi
...skip...
sty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Ifd4c74ca893ddae66e41fe10ff663287be1cf325
Reviewed-on: https://chromium-review.googlesource.com/1134148
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574532}

    Changed files

    • DEPS

  39. Navigation: Refactoring WebContents unittests to use NavigationSimulator

    Changed by ahemeryohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:20:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c65bc1abc46c630c53a3e21bb0670dc602e8d37d

    Comments

    Navigation: Refactoring WebContents unittests to use NavigationSimulator

Removed the usage of TestWebContents->DidNavigate variants in
web_contents_impl_unittest.cc. Some usage remains, linked to
overlapping navigations and other specific usages.

Bug: 728571
Change-Id: Ie2d6b73cb5deea077f720114fdd45ab4ee714c0a
Reviewed-on: https://chromium-review.googlesource.com/1076240
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574533}

    Changed files

    • content/browser/web_contents/web_contents_impl_unittest.cc

  40. Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:23:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 84356c12447981846eda650f06085913fa831126

    Comments

    Mark "virtual/gpu/fast/canvas/canvas-blending-image-over-pattern.html" as flaky

TBR=kpaulhamus@chromium.org

Bug: 862907
Change-Id: If6ce15cb1633ae74177e385774a1cef7010e67c0
Reviewed-on: https://chromium-review.googlesource.com/1134989
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574534}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations

  41. Oilpan: Do not include wtf/functional.h

    Changed by tkentohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:30:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7b1f6b9152f54aa4ac3906176fa30fa19ea33eb

    Comments

    Oilpan: Do not include wtf/functional.h

No one in platform/heap/ needs wtf/functional.h, though persistent.h
needs base/bind.h for IsWeakReceiver<> and BindUnwrapTraits<>.

This CL reduces the pre-processed size of handle.h by 31KB.

Bug: 242216
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6097a6f22dbe7a762f4b0a23560c731a07daf5ce
Reviewed-on: https://chromium-review.googlesource.com/1134809
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574536}

    Changed files

    • third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_descriptor.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_remote_gatt_service.cc
    • third_party/blink/renderer/modules/budget/budget_service.cc
    • third_party/blink/renderer/modules/device_orientation/device_sensor_event_pump.h
    • third_party/blink/renderer/modules/filesystem/directory_reader.cc
    • third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc
    • third_party/blink/renderer/modules/gamepad/gamepad_haptic_actuator.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.cc
    • third_party/blink/renderer/modules/indexeddb/idb_request_queue_item.h
    • third_party/blink/renderer/modules/locks/lock.cc
    • third_party/blink/renderer/modules/mediastream/media_devices_test.cc
    • third_party/blink/renderer/modules/payments/payment_manager.cc
    • third_party/blink/renderer/modules/service_worker/respond_with_observer.cc
    • third_party/blink/renderer/modules/webusb/usb_device.cc
    • third_party/blink/renderer/platform/graphics/accelerated_static_bitmap_image_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/gpu/xr_webgl_drawing_buffer.cc
    • third_party/blink/renderer/platform/graphics/skia_texture_holder.h
    • third_party/blink/renderer/platform/heap/persistent.h
    • third_party/blink/renderer/platform/heap/thread_state.h
    • third_party/blink/renderer/platform/testing/empty_web_media_player.h
    • third_party/blink/renderer/platform/testing/unit_test_helpers.cc

  42. Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 12:32:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 78a0a24222fde0f77a45d4f78b1f4502496c434e

    Comments

    Roll src/third_party/chromite c228d491eb86..3973c26575e2 (1 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c228d491eb86..3973c26575e2


git log c228d491eb86..3973c26575e2 --date=short --no-merges --format='%ad %ae %s'
2018-07-12 dhanyaganesh@chromium.org CreateTarball: Add debug code with lsof


Created with:
  gclient setdep -r src/third_party/chromite@3973c26575e2

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller
...skip...
ho should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iabf74616719c8b90e6b34c6576772eeb313a7183
Reviewed-on: https://chromium-review.googlesource.com/1134906
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574537}

    Changed files

    • DEPS

  43. macviews: switch back to Cocoa menus for Views context menus

    Changed by ellyjonesohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:36:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b56c4e40b65ee14134dd2e61834f260ca9c1715e

    Comments

    macviews: switch back to Cocoa menus for Views context menus

This change:
1) Reverts erikchen@'s 79c8511fb8801f7fc23c4cbe81311b6065daef15, which removed
   the Cocoa menu runner code;
2) Wires the Cocoa menu runner code back up in MenuRunnerImplInterface::Create;
3) Fixes a latent bug in Textfield that could cause it to delete its context
   menu while handling a context menu activation - this is fine with Views menus
   but forbidden with Cocoa menus.

Bug: 860673
Change-Id: If110f09379c4661a4f61a8b0257cf5214503e6a9
Reviewed-on: https://chromium-review.googlesource.com/1131564
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574538}

    Changed files

    • ui/views/BUILD.gn
    • ui/views/controls/menu/menu_runner_cocoa_unittest.mm
    • ui/views/controls/menu/menu_runner_impl.cc
    • ui/views/controls/menu/menu_runner_impl_cocoa.h
    • ui/views/controls/menu/menu_runner_impl_cocoa.mm
    • ui/views/controls/textfield/textfield.cc
    • ui/views/controls/textfield/textfield_unittest.cc

  44. Add UMA for locked-fullscreen state

    Changed by isandrkohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:29:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fe933a784678f6aa62203b7d57a638051c15f2a

    Comments

    Add UMA for locked-fullscreen state

Locked-fullscreen state will be used for giving student quizzes on managed
Chrome OS devices in schools. Add a UMA to track feature adoption.

Change-Id: I59f809e2aecd67a4e9f10ee21a28658796c03b15
Reviewed-on: https://chromium-review.googlesource.com/1126241
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574535}

    Changed files

    • chrome/browser/extensions/api/tabs/tabs_api.cc
    • tools/metrics/histograms/enums.xml
    • tools/metrics/histograms/histograms.xml

  45. Mark several layout tests as flaky.

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:44:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704b3f013b80c7a5f93296e3d146758d5c0b0ccc

    Comments

    Mark several layout tests as flaky.

- css3/filters/effect-brightness-clamping-hw.html
- virtual/gpu/fast/canvas/canvas-blending-image-over-image.html
- css3/filters/effect-drop-shadow-hw.html
- external/wpt/html/syntax/parsing/template/creating-an-element-for-the-token/template-owner-document.html

TBR=kpaulhamus@chromium.org

Bug: 862716, 862729, 862806, 862826
Change-Id: I08126b22afdc0a7a4ef776dde8cc1120643acdcc
Reviewed-on: https://chromium-review.googlesource.com/1134990
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574539}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations

  46. compare_build_artifacts: make ninja path command line option.

    Changed by yyanagisawaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:49:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c3f55b21a7a48593a9ce1622346dad112a8b2e2f

    Comments

    compare_build_artifacts: make ninja path command line option.

ninja seems not be in PATH when compare_build_artifacts.py is executed.
Then compare_build_artifacts cannot compare object files difference,
and just fails with exception.
To fix that, let me make ninja path given with command line option.

Bug: 862917
Change-Id: Ieb7d7bd1db30217222f5cd5006e120244da28fd5
Reviewed-on: https://chromium-review.googlesource.com/1134710
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574540}

    Changed files

    • tools/determinism/compare_build_artifacts.py

  47. [unified-consent] USER_EVENT has its own sync pref group

    Changed by msardaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 12:50:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4432c3f9d16a93276eeb9c60a860190223888d96

    Comments

    [unified-consent] USER_EVENT has its own sync pref group

This CL passes the information that unified consent is enabled to
the sync service. It then uses it to move USER_EVENTS data type in
a separate pref group (instead of having it tied to TYPED_URLS as
before).

The goal is not to un-link USER_EVENTS from HISTORY, but to have a
separate toggle for USER_EVENTS (which will be linked to HISTORY toggle
in the toggle UI).

Unit tests have been updated accordingly.

Bug: 860515

Change-Id: Ic5461470114c0b05ec770817890c9123b81f3d77
Reviewed-on: https://chromium-review.googlesource.com/1128876
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574541}

    Changed files

    • chrome/browser/android/contextualsearch/contextual_search_delegate.cc
    • chrome/browser/sync/profile_sync_service_factory.cc
    • chrome/browser/sync/test/integration/enable_disable_test.cc
    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
    • components/sync/base/sync_prefs.cc
    • components/sync/base/sync_prefs.h
    • components/sync/base/sync_prefs_unittest.cc

  48. Updating names for job triggers on nexus5x and win 10 perf

    Changed by eyaichohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 12:55:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896ba71bc975b53346521228a32536296ea5d80e

    Comments

    Updating names for job triggers on nexus5x and win 10 perf

Dependent on crrev.com/c/1131227

NOTRY=True

Bug: 758326
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Icd5c18a166e815be5c2570cafd511bae4c545975
Reviewed-on: https://chromium-review.googlesource.com/1131230
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574542}

    Changed files

    • infra/config/global/luci-milo-dev.cfg
    • infra/config/global/luci-milo.cfg
    • testing/buildbot/chromium.perf.json
    • tools/perf/core/perf_data_generator.py