Home | Search
Login

Builder Android Nexus6 WebView Perf Build #2060

Results:

build successful

Trigger Info:

Got Revisionecb9b545a199897e05ca621e40fd5e93289f82bd

Execution:

Steps and Logfiles:

Show:
  1. ( 4 hrs 7 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 9 secs ) remove .cipd
    remove .cipd
  9. ( 5 mins 21 secs ) bot_update
    bot_update
    [100GB/492GB used (20%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 42 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/Android_Nexus6_WebView_Perf/src/testing/buildbot/chromium.perf.json
  16. ( 27 secs ) clean local files
    clean local files
  17. ( 1 ms ) tree truth steps
    tree truth steps
  18. ( 1 ms ) build directory
    build directory
  19. ( 1 mins 13 secs ) extract build
    extract build
  20. ( 1 ms ) find isolated tests
    find isolated tests
  21. ( 1 ms ) test_pre_run
    test_pre_run
  22. ( 35 secs ) test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 6
    test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 6
    Run on OS: 'Android'
  23. ( 3 hrs 57 mins ) performance_webview_test_suite on Android device Nexus 6
    performance_webview_test_suite on Android device Nexus 6
    Run on OS: 'Android'
    Max pending time: 56s (shard #2)
    Max shard duration: 3:23:27.211090 (shard #7)
    Min shard duration: 0:52:23.815580 (shard #12)
    Total tests: 1134
    * Passed: 1049 (1049 expected, 0 unexpected)
    * Skipped: 85 (85 expected, 0 unexpected)
    * Failed: 0 (0 expected, 0 unexpected)
    * Flaky: 0 (0 expected, 0 unexpected)
     
  24. ( 1 ms ) Upload to test-results [performance_webview_test_suite on Android device Nexus 6]
    Upload to test-results [performance_webview_test_suite on Android device Nexus 6]
  25. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 16
    Total runtime: 20:09:35.364452
     
  26. ( 1 ms ) test_report
    test_report
  27. ( 1 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Nexus6_WebView_Perf/2060/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Android_Nexus6_WebView_Perf/2060" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "ecb9b545a199897e05ca621e40fd5e93289f82bd" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574494}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
swarm_hashes {"angle_perftests":"5692176932908c0a202225c8a750473c710ecfe8","components_perftests":"0694bee166c7384e195c4e8cd2112805da037602","gpu_perftests":"d43c949c35c6636fafcda30e9b0bb0478555ff2c","media_perftests":"7412dcecd2f7d800af80beba456e575cb003a926","performance_test_suite":"7a3bba07e7c7aa470eaafd05dfe7ad2b5a09db1f","performance_webview_test_suite":"4c219fe002f337e934fffd7e0d1b2190575f57ae","tracing_perftests":"b67e4562f5c13812a02f897ea6eea8f508723414"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpNEUlkr" Annotation(steps)
build_id "buildbot/chromium.perf/Android Nexus6 WebView Perf/2060" Annotation(steps)
builder_id "master.chromium.perf:Android Nexus6 WebView Perf" Annotation(steps)
blamelist ["aee@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","bashi@chromium.org","bcf@chromium.org","bpastene@chromium.org","bsalomon@google.com","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","chrome-release-bot@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","danielpark@chromium.org","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","falken@chromium.org","ftirelo@chromium.org","halton.huo@gmail.com","imcheng@chromium.org","jam@chromium.org","jinsukkim@chromium.org","karandeepb@chromium.org","kbr@chromium.org","kojii@chromium.org","ksakamoto@chromium.org","kylechar@chromium.org","loyso@chromium.org","michaelpg@chromium.org","miu@chromium.org","morlovich@chromium.org","mukai@chromium.org","nverne@chromium.org","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","pwnall@chromium.org","qinmin@chromium.org","ramyan@chromium.org","rbpotter@chromium.org","rdevlin.cronin@chromium.org","rockot@chromium.org","sawtelle@google.com","scottwu@chromium.org","sergeyu@chromium.org","shaseley@google.com","shend@chromium.org","sky@chromium.org","szager@chromium.org","tbansal@chromium.org","tetsui@chromium.org","thestig@chromium.org","tzik@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","wez@chromium.org","xiaochengh@chromium.org","xjz@chromium.org","yhanada@chromium.org"] Build
branch "master" Build
buildnumber 2060 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531361008 Build
revision "ecb9b545a199897e05ca621e40fd5e93289f82bd" Build
slavename "slave213-c1" BuildSlave
buildername "Android Nexus6 WebView Perf" Builder
git_revision "ecb9b545a199897e05ca621e40fd5e93289f82bd" Change
parent_buildername "Android Compile Perf" ParentBuild
parent_buildnumber 26762 ParentBuild
parent_got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "ecb9b545a199897e05ca621e40fd5e93289f82bd" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574494}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.352@{#1}" ParentBuild
parent_got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23944}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Android_Nexus6_WebView_Perf" slave

Blamelist:

  1. (bcfohnoyoudont@chromium.org)
  2. (jinsukkimohnoyoudont@chromium.org)
  3. (qinminohnoyoudont@chromium.org)
  4. (rockotohnoyoudont@chromium.org)
  5. (kylecharohnoyoudont@chromium.org)
  6. (ramyanohnoyoudont@chromium.org)
  7. (skyohnoyoudont@chromium.org)
  8. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  9. (shendohnoyoudont@chromium.org)
  10. (sergeyuohnoyoudont@chromium.org)
  11. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  12. (wezohnoyoudont@chromium.org)
  13. (loysoohnoyoudont@chromium.org)
  14. (michaelpgohnoyoudont@chromium.org)
  15. (rockotohnoyoudont@chromium.org)
  16. (bpasteneohnoyoudont@chromium.org)
  17. (xiaochenghohnoyoudont@chromium.org)
  18. (shaseleyohnoyoudont@google.com)
  19. (scottwuohnoyoudont@chromium.org)
  20. (shendohnoyoudont@chromium.org)
  21. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  22. (danielparkohnoyoudont@chromium.org)
  23. (karandeepbohnoyoudont@chromium.org)
  24. (michaelpgohnoyoudont@chromium.org)
  25. (kbrohnoyoudont@chromium.org)
  26. (xjzohnoyoudont@chromium.org)
  27. (tetsuiohnoyoudont@chromium.org)
  28. (sawtelleohnoyoudont@google.com)
  29. (skyohnoyoudont@chromium.org)
  30. (yhanadaohnoyoudont@chromium.org)
  31. (aeeohnoyoudont@chromium.org)
  32. (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  33. (tzikohnoyoudont@chromium.org)
  34. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  35. (bashiohnoyoudont@chromium.org)
  36. (halton.huoohnoyoudont@gmail.com)
  37. (aeeohnoyoudont@chromium.org)
  38. (pwnallohnoyoudont@chromium.org)
  39. (morlovichohnoyoudont@chromium.org)
  40. (rdevlin.croninohnoyoudont@chromium.org)
  41. (chrome-release-botohnoyoudont@chromium.org)
  42. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  43. (bsalomonohnoyoudont@google.com)
  44. (ftireloohnoyoudont@chromium.org)
  45. (imchengohnoyoudont@chromium.org)
  46. (ksakamotoohnoyoudont@chromium.org)
  47. (miuohnoyoudont@chromium.org)
  48. (falkenohnoyoudont@chromium.org)
  49. (nverneohnoyoudont@chromium.org)
  50. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  51. (falkenohnoyoudont@chromium.org)
  52. (ksakamotoohnoyoudont@chromium.org)
  53. (kojiiohnoyoudont@chromium.org)
  54. (tbansalohnoyoudont@chromium.org)
  55. (jinsukkimohnoyoudont@chromium.org)
  56. (jamohnoyoudont@chromium.org)
  57. (rbpotterohnoyoudont@chromium.org)
  58. (thestigohnoyoudont@chromium.org)
  59. (mukaiohnoyoudont@chromium.org)
  60. (szagerohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 06:14:34 UTC
End Thursday, 12-Jul-18 10:22:13 UTC
Pending N/A
Execution 4 hrs 7 mins

All Changes:

  1. [chromecast] BLE: Silently ignore unrecognized disconnenect events

    Changed by bcfohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:55:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3aa0471bc5652b265991619cde6b1486018b6b6

    Comments

    [chromecast] BLE: Silently ignore unrecognized disconnenect events
    
    - There may be other processes in the system which are
      connecting/disconnecting BLE devices.
    - We may receive extra disconnect events
    
    Bug: b/110965632
    Test: Does not log if called with unrecognized device.
    Change-Id: I3059435ea5df6919e12a87852c27e716a0f106b5
    Reviewed-on: https://chromium-review.googlesource.com/1119657
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Bailey Forrest <bcf@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574436}

    Changed files

    • chromecast/device/bluetooth/le/gatt_client_manager_impl.cc
  2. Update translation expectation.pyl

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:09:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ea39bbbfcec8caf10486ad0b8e67a8c99bb0975

    Comments

    Update translation expectation.pyl
    
    https://crrev.com/c/1118926 had a typo in the script.
    This CL fixes it.
    
    TBR=brucedawson@chromium.org
    
    Bug: 862827
    Change-Id: I2238ca092e7f77a24ac52e379a9a9089df549c4d
    Reviewed-on: https://chromium-review.googlesource.com/1133602
    Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574438}

    Changed files

    • tools/gritsettings/translation_expectations.pyl
  3. Don't reset TabDownloadState on history back/forward

    Changed by qinminohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:57:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 01a6365651e0b1e9896b251411a18a4ab5a4306d

    Comments

    Don't reset TabDownloadState on history back/forward
    
    Currently performing forward/backward on a tab will reset the TabDownloadState.
    Which allows javascript code to do trigger multiple downloads.
    This CL disables that behavior by not resetting the TabDownloadState on
    forward/back.
    It is still possible to reset the TabDownloadState through user gesture
    or using browser initiated download.
    
    BUG=848535
    
    Change-Id: I7f9bf6e8fb759b4dcddf5ac0c214e8c6c9f48863
    Reviewed-on: https://chromium-review.googlesource.com/1108959
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Reviewed-by: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574437}

    Changed files

    • chrome/browser/download/download_request_limiter.cc
    • chrome/browser/download/download_request_limiter.h
    • chrome/browser/download/download_request_limiter_unittest.cc
  4. Mojo: Clean up MojoArmTrap API

    Changed by rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:11:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7831a95dc47fbf2e72acba0de69703380076e333

    Comments

    Mojo: Clean up MojoArmTrap API
    
    Modifies MojoArmTrap() to place its outputs in a single buffer of
    MojoTrapEvent structures, rather than inlining all the event fields as
    output parameters. This means that traps which fail to arm can
    provide the caller with information in the same form that an actual
    event handler would receive it.
    
    Also finally cleans up trap unittests, taking advantage of capturing
    lambdas, removing the hacked in adaptations to old watcher APIs,
    
    TBR=kinuko@chromium.org
    
    Bug: 819046
    Change-Id: Ib2917df06611cbbe8406a65bcdcac71011f52e88
    Reviewed-on: https://chromium-review.googlesource.com/1133962
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574439}

    Changed files

    • mojo/core/core.cc
    • mojo/core/core.h
    • mojo/core/dispatcher.cc
    • mojo/core/dispatcher.h
    • mojo/core/entrypoints.cc
    • mojo/core/trap_unittest.cc
    • mojo/core/watcher_dispatcher.cc
    • mojo/core/watcher_dispatcher.h
    • mojo/public/c/system/README.md
    • mojo/public/c/system/thunks.cc
    • mojo/public/c/system/thunks.h
    • mojo/public/c/system/trap.h
    • mojo/public/cpp/system/simple_watcher.cc
    • mojo/public/cpp/system/wait.cc
    • mojo/public/cpp/system/wait_set.cc
    • third_party/blink/renderer/core/mojo/mojo_watcher.cc
  5. Revert "Updating Viz Content BrowserTests Filter"

    Changed by kylecharohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 00:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e1aa80280d36b8411d252286601369145224f684

    Comments

    Revert "Updating Viz Content BrowserTests Filter"
    
    This reverts commit a57a12587f7ace3b15480262c181ced968346ea4.
    
    Reason for revert: SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest is failing.
    
    Original change's description:
    > Updating Viz Content BrowserTests Filter
    > 
    > A few tests have been fixed. This updates the filter accordingly to re-enable them.
    > 
    > TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    > SitePerProcessHitTestBrowserTest.TouchpadPinchOverOOPIF
    > Bug: 848825, 848348
    ...skip...
    w.googlesource.com/1133863
    > Reviewed-by: Jonathan Ross <jonross@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574302}
    
    TBR=jonross@chromium.org,kylechar@chromium.org
    
    Change-Id: Ic6de880ae04a3535c00bfab1cf39e61a335fe43e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 848825, 848348
    Reviewed-on: https://chromium-review.googlesource.com/1134144
    Reviewed-by: kylechar <kylechar@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574434}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  6. [NTP] Adds service integration to request photos.

    Changed by ramyanohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:20:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a29136f7c12d930aa75521113d85fca0378bb564

    Comments

    [NTP] Adds service integration to request photos.
    
    Adds a service request and callback to get Google Photos from an album.
    An access token for the signed-in user with requisite scope is
    obtained and used in the request.
    
    Bug: 839152
    Change-Id: I3b012b8cdba247d94052c774dd0b1ae1be070d14
    Reviewed-on: https://chromium-review.googlesource.com/1114231
    Reviewed-by: Christian Dullweber <dullweber@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574442}

    Changed files

    • chrome/browser/search/background/ntp_background.proto
    • chrome/browser/search/background/ntp_background_data.cc
    • chrome/browser/search/background/ntp_background_data.h
    • chrome/browser/search/background/ntp_background_service.cc
    • chrome/browser/search/background/ntp_background_service.h
    • chrome/browser/search/background/ntp_background_service_factory.cc
    • chrome/browser/search/background/ntp_background_service_observer.h
    • chrome/browser/search/background/ntp_background_service_unittest.cc
    • chrome/browser/search/local_ntp_source.cc
    • chrome/browser/search/local_ntp_source.h
    • tools/metrics/histograms/histograms.xml
    • tools/traffic_annotation/summary/annotations.xml
  7. chromeos: fixs bugs where top-levels were never deleted

    Changed by skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f2534b278418c9e9e6b1c701a182b36a5723d436

    Comments

    chromeos: fixs bugs where top-levels were never deleted
    
    Requests from a client to delete a top-level where not actually
    deleting the aura::Window.
    
    This also makes printing the window hierarchy include the remote id of the
    window, which is useful for debugging.
    
    BUG=none
    TEST=covered by tests
    
    Change-Id: Icd3eae0839558d6db277bfeaf5fd3b7dd2fde377
    Reviewed-on: https://chromium-review.googlesource.com/1134510
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574440}

    Changed files

    • ash/accelerators/debug_commands.cc
    • ash/shell.h
    • services/ui/ws2/server_window.cc
    • services/ui/ws2/server_window.h
    • services/ui/ws2/window_service.cc
    • services/ui/ws2/window_service.h
    • services/ui/ws2/window_tree.cc
    • services/ui/ws2/window_tree.h
    • services/ui/ws2/window_tree_test_helper.cc
    • services/ui/ws2/window_tree_test_helper.h
    • services/ui/ws2/window_tree_unittest.cc
  8. Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:14:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d4bb6ed80fc74f40da5499723417d45ab616119

    Comments

    Roll src/third_party/catapult 1af68170e543..39de3d225856 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/1af68170e543..39de3d225856
    
    
    git log 1af68170e543..39de3d225856 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Remove unnecessary histogram lookups.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@39de3d225856
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is here:
    ht
    ...skip...
    u_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: I748004dfd1269077f1c4648897b9d698baadb301
    Reviewed-on: https://chromium-review.googlesource.com/1133876
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574441}

    Changed files

    • DEPS
  9. [VK] Swap top/left in parsing SetDraggableArea arguments.

    Changed by shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:22:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5f10ba6b2e7f231a2ec6fb549f1b470da3f17a2

    Comments

    [VK] Swap top/left in parsing SetDraggableArea arguments.
    
    'x' was mistakenly matched with 'top' and 'y' with 'left'. Should be
    the other way around. The old UI worked because x and y were the same
    (0, 0), but that's no longer true with the new UI.
    
    TBR=blakeo@chromium.org
    
    Bug: 859405, 856475
    Test: Manual
    Change-Id: I3ac31c4386abb7f86d850fea25ffb543419cf287
    Reviewed-on: https://chromium-review.googlesource.com/1133601
    Reviewed-by: Darren Shen <shend@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574444}

    Changed files

    • chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc
  10. [Fuchsia] Add Context, Frame stubs; implement service glue.

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:27:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e26716b5bc2bfab8f7ae74d7418e0ac14749223f

    Comments

    [Fuchsia] Add Context, Frame stubs; implement service glue.
    
    * Add ContextImpl service.
    * Add FrameImpl service.
    * Add support for exiting after final disconnect to ContextProvider.
    * Add Context process startup logic to main.cc.
    * Rename webrunner_main.cc to web_context_service_main.cc.
    
    Bug: 852145
    Change-Id: I87228259472cc0ef1044ea3e00f94de9a0f61990
    Reviewed-on: https://chromium-review.googlesource.com/1114321
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574445}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/service/common.h
    • webrunner/service/context_impl.cc
    • webrunner/service/context_impl.h
    • webrunner/service/context_provider_impl.cc
    • webrunner/service/context_provider_impl.h
    • webrunner/service/context_provider_impl_unittest.cc
    • webrunner/service/frame_impl.cc
    • webrunner/service/frame_impl.h
  11. Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:32:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 593b787d55ee623265f615215231a0fe6bc860b1

    Comments

    Roll src/third_party/pdfium b165ffb64e59..d8882193737a (8 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/b165ffb64e59..d8882193737a
    
    
    git log b165ffb64e59..d8882193737a --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 hnakashima@chromium.org Inline GetMarkParamPairAtIndex into FPDFPageObjMark_GetParamKey.
    2018-07-11 thestig@chromium.org Roll third_party/yasm/source/patched-yasm/ b98114e18..720b70524 (1 commit)
    2018-07-11 hnakashima@chromium.org Rename content mark parameter value g
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I7acff8886402b7c92a599963707f72dacaa02ffa
    Reviewed-on: https://chromium-review.googlesource.com/1133877
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574446}

    Changed files

    • DEPS
  12. Migrate //ipc test off of QuitCurrent*Deprecated().

    Changed by wezohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:21:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fdb9848c74490ec3cfe0faddb95e3a26d08f51de

    Comments

    Migrate //ipc test off of QuitCurrent*Deprecated().
    
    Bug: 844016
    Change-Id: If763ff6c6dc73de39e48710c3ecb7e1014a97d0f
    Reviewed-on: https://chromium-review.googlesource.com/1132473
    Commit-Queue: Wez <wez@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574443}

    Changed files

    • ipc/ipc_channel_mojo_unittest.cc
  13. WebApp: Extract web_applications source sets in GN.

    Changed by loysoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:36:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d538ba3e10d2498292aa429cef90d8b6c18473cd

    Comments

    WebApp: Extract web_applications source sets in GN.
    
    This CL reflects the existing dependencies and dependency
    cycles we have.
    
    Also, we want to establish the following folders in web_applications/:
    1) components/
    Any independent components which are shared between extensions/
    and web_applications/
    
    2) extensions/
    A code which is thematically part of chrome/browser/extensions/
    E.g. an upcoming BookmarkAppInstaller will be used by extensions.
    
    3) bookmark_apps/
    Any extension-based high-level helpers which are used by chrome/browser/
    
    Note that web_applications/policy content will be moved to
    web_applications/bookmark_apps/policy/
    
    Bug: 860581
    Change-Id: Ib89f0e327759cfab050caceae5818c8e72f40f08
    Reviewed-on: https://chromium-review.googlesource.com/1128665
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Dominick Ng <dominickn@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574448}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/extensions/BUILD.gn
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/web_applications/BUILD.gn
    • chrome/browser/web_applications/bookmark_apps/BUILD.gn
    • chrome/browser/web_applications/components/BUILD.gn
    • chrome/browser/web_applications/extensions/BUILD.gn
    • chrome/browser/web_applications/policy/BUILD.gn
    • chrome/test/BUILD.gn
  14. Add isDemoSession to chrome.app.runtime LaunchData

    Changed by michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:33:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 456e84e95d9f7060c117953d251e121bc052b158

    Comments

    Add isDemoSession to chrome.app.runtime LaunchData
    
    Adds the |isDemoSession| boolean property to launch data for the
    chrome.app.runtime.onLaunched event.
    
    Built-in platform apps on Chrome OS will check this to enable special
    Chrome OS Demo Mode behavior.
    
    This CL adds the property as |false|; a follow-up CL will correctly set
    it to |true| when the device is actually in Demo Mode.
    
    Bug: 835024
    Change-Id: Ie77f50f1551c3dfb00fff27e7779775ceca1f44d
    Reviewed-on: https://chromium-review.googlesource.com/1121113
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Sergey Volk <servolk@chromium.org>
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574447}

    Changed files

    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/test/data/extensions/platform_apps/launch_file/test.js
    • chrome/test/data/extensions/platform_apps/launch_whitelisted_ext_with_file/test.js
    • chromecast/browser/extensions/cast_extensions_browser_client.cc
    • chromecast/browser/extensions/cast_extensions_browser_client.h
    • extensions/browser/api/app_runtime/app_runtime_api.cc
    • extensions/browser/extensions_browser_client.h
    • extensions/browser/test_extensions_browser_client.cc
    • extensions/browser/test_extensions_browser_client.h
    • extensions/common/api/app_runtime.idl
    • extensions/renderer/resources/app_runtime_custom_bindings.js
    • extensions/shell/browser/shell_extensions_browser_client.cc
    • extensions/shell/browser/shell_extensions_browser_client.h
  15. Reland "Use BigBuffer for legacy IPC messages"

    Changed by rockotohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:37:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4c5bd80e5a7b379c0539ef33c5722fb1ee974cda

    Comments

    Reland "Use BigBuffer for legacy IPC messages"
    
    This is a reland of 3e126191c1a7a022260c1072b1b9288f09bb2dce,
    unchanged.
    
    https://chromium-review.googlesource.com/c/chromium/src/+/1134079
    fixes the root cause of the failure which caused this to be
    reverted. This CL can land once that one does.
    
    Original change's description:
    > Use BigBuffer for legacy IPC messages
    >
    > This replaces use of ReadOnlyBuffer with a new mojom Message type
    > specific to //ipc. This type maps to another new C++ MessageView ty
    ...skip...
    rce.com/1131685
    > Commit-Queue: Ken Rockot <rockot@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573956}
    
    TBR=dcheng@chromium.org
    
    Bug: 784069
    Change-Id: I1224367e9db026cb06b0099ee5dfdada89804f23
    Reviewed-on: https://chromium-review.googlesource.com/1134100
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574449}

    Changed files

    • chrome/services/file_util/public/mojom/safe_archive_analyzer.typemap
    • ipc/BUILD.gn
    • ipc/OWNERS
    • ipc/ipc.mojom
    • ipc/ipc_message_pipe_reader.cc
    • ipc/ipc_message_pipe_reader.h
    • ipc/ipc_message_utils.cc
    • ipc/ipc_message_utils.h
    • ipc/ipc_mojo_bootstrap_unittest.cc
    • ipc/message.typemap
    • ipc/message_mojom_traits.cc
    • ipc/message_mojom_traits.h
    • ipc/message_view.cc
    • ipc/message_view.h
    • ipc/typemaps.gni
    • mojo/public/cpp/base/BUILD.gn
    • mojo/public/cpp/base/file_info.typemap
    • mojo/public/cpp/base/file_info_mojom_traits.cc
    • mojo/public/cpp/base/file_info_mojom_traits.h
    • mojo/public/cpp/base/logfont_win.typemap
    • mojo/public/cpp/base/logfont_win_mojom_traits.cc
    • mojo/public/cpp/base/logfont_win_mojom_traits.h
    • mojo/public/cpp/base/time.typemap
    • mojo/public/cpp/base/time_mojom_traits.h
    • mojo/public/mojom/base/file_info.mojom
    • mojo/public/mojom/base/logfont_win.mojom
    • mojo/public/tools/bindings/chromium_bindings_configuration.gni
  16. Luci configs for Oreo Phone Tester on chromium.android

    Changed by bpasteneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:40:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c73e96e974871abb7258d040f9bbbdc85c9807e9

    Comments

    Luci configs for Oreo Phone Tester on chromium.android
    
    And move its testing spec to chromium.android
    
    Bug: 862645
    Change-Id: I2a45d509faeba8b75ef8d7ed1b1d8e95e347dddd
    Reviewed-on: https://chromium-review.googlesource.com/1134420
    Reviewed-by: John Budorick <jbudorick@chromium.org>
    Commit-Queue: Ben Pastene <bpastene@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574451}

    Changed files

    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
    • testing/buildbot/chromium.android.fyi.json
    • testing/buildbot/chromium.android.json
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
  17. [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:45:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5bce39b0838948fbed6bcea5f4e88d4890d7edd2

    Comments

    [LayoutNG] Fix handling of generated boxes in ComputeNGCaretPosition
    
    Since there is no caret position allowed at the sides of a generated or
    pseudo inline box, ComputeNGCaretPosition should skip such box
    fragments.
    
    Existing code only checks GetNode() of the box fragment, which misses
    the case where GetNode() returns a pseudo node, and is fixed in this
    patch.
    
    Bug: 861669
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I4e46f25ea07b66fa9b4821a8944db3f854c839ae
    Reviewed-on: https://chromium-review.googlesource.com/1134396
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574453}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_caret_position_test.cc
  18. [scheduler] Refactor QueueCreationParams, separating out QueueTraits

    Changed by shaseleyohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 01:47:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 520720d455489da4f863ee202944c7dc0171ceaf

    Comments

    [scheduler] Refactor QueueCreationParams, separating out QueueTraits
    
    QueueTraits is the (deferrable, throttleable, pausable, freezable)
    4-tuple. We will be associating each non-loading TaskType with a
    QueueTraits to map it to a unique task queue.
    
    This CL also forward declares FrameSchedulerImpl in
    main_thread_task_queue.h and cleans up the necessary frame_scheduler_impl.h
    includes in files that were relying on the indirect include.
    
    Bug: 859963
    Change-Id: I84f883379d718d85e5baf806f199181d7e7bf753
    Reviewed-on: https://chromium-review.googlesource.com/1125033
    Reviewed-by: Alexander Timin <altimin@chromium.org>
    Commit-Queue: Scott Haseley <shaseley@google.com>
    Cr-Commit-Position: refs/heads/master@{#574454}

    Changed files

    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
    • third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
    • third_party/blink/renderer/platform/scheduler/main_thread/queueing_time_estimator.cc
    • third_party/blink/renderer/platform/scheduler/test/fake_frame_scheduler.h
  19. Add icon getter for CWVAutofillSuggestion.

    Changed by scottwuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:38:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision de45c8fcb6f97db5346bc6a52dc4edba0b7d1f3e

    Comments

    Add icon getter for CWVAutofillSuggestion.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic1c360a24dfdb35581a13cf0532173d66c9f953c
    Reviewed-on: https://chromium-review.googlesource.com/1131050
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574450}

    Changed files

    • ios/web_view/internal/autofill/cwv_autofill_suggestion.mm
    • ios/web_view/public/cwv_autofill_suggestion.h
  20. [VK] Tidy up KeyboardController::PopulateKeyboardContent.

    Changed by shendohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:42:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0cb32b12d33d62e3e56c9b8c9922aa9d5ca2b68f

    Comments

    [VK] Tidy up KeyboardController::PopulateKeyboardContent.
    
    Just moved some code around. Looks more consistent IMO when every switch
    case early returns.
    
    Bug: 845780
    Change-Id: If828b05cb088395d1e44d83ec038b57e8bffe9bd
    Reviewed-on: https://chromium-review.googlesource.com/1132908
    Reviewed-by: Blake O'Hare <blakeo@chromium.org>
    Commit-Queue: Darren Shen <shend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574452}

    Changed files

    • ui/keyboard/keyboard_controller.cc
  21. Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 01:48:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a77159361b8dbc319ff208be3a0a38970c79d2c5

    Comments

    Roll src/third_party/angle 89ef177f9475..5598148b7613 (5 commits)
    
    https://chromium.googlesource.com/angle/angle.git/+log/89ef177f9475..5598148b7613
    
    
    git log 89ef177f9475..5598148b7613 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 jmadill@chromium.org Vulkan: Don't use gl::ErrorOrResult.
    2018-07-11 jmadill@chromium.org Vulkan: Clean up Error usage.
    2018-07-11 jmadill@chromium.org Vulkan: Move Feature init before device creation.
    2018-07-11 jmadill@chromium.org Generalize Context scratch b
    ...skip...
    ;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=jmadill@chromium.org
    
    Change-Id: Ib007468f11fc8153eca19ee8925a7558fea89d47
    Reviewed-on: https://chromium-review.googlesource.com/1133872
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574455}

    Changed files

    • DEPS
  22. [Modern] Modernizes settings action bar

    Changed by danielparkohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:51:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2d8b1c7455e423788c982bc899cd32cd635a2d2c

    Comments

    [Modern] Modernizes settings action bar
    
    > Changes action bar color to white
    > Adds shadow on scroll
    > Per Hannah's request, this change also affects ManageStorage
        - White action bar carries over to ManageStorage
    
    Bug: 834600
    Change-Id: Ib09e63bafbf03237ac07ff323743f689a73205fe
    Reviewed-on: https://chromium-review.googlesource.com/1098375
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574457}

    Changed files

    • chrome/android/java/res/drawable-hdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-mdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/drawable-xxxhdpi/ic_help_white_24dp.png
    • chrome/android/java/res/layout/add_languages_main.xml
    • chrome/android/java/res/layout/autofill_editor_base.xml
    • chrome/android/java/res/layout/bookmark_add_edit_folder_activity.xml
    • chrome/android/java/res/layout/bookmark_edit.xml
    • chrome/android/java/res/layout/bookmark_folder_select_activity.xml
    • chrome/android/java/res/layout/clear_browsing_data_tabs.xml
    • chrome/android/java/res/layout/homepage_editor.xml
    • chrome/android/java/res/layout/password_entry_editor_interactive.xml
    • chrome/android/java/res/layout/password_entry_exception.xml
    • chrome/android/java/res/layout/payment_request_editor.xml
    • chrome/android/java/res/layout/preferences_action_bar_shadow.xml
    • chrome/android/java/res/menu/prefeditor_editor_menu.xml
    • chrome/android/java/res/values-v17/styles.xml
    • chrome/android/java/res/values-v21/styles.xml
    • chrome/android/java/res/values/colors.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/HomepageEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEnginePreference.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/languages/AddLanguageFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java
    • ui/android/java/res/values-v17/styles.xml
    • ui/android/java/res/values/colors.xml
  23. Declarative Net Request: Handle flatbuffer indexed ruleset corruption.

    Changed by karandeepbohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:59:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b7bb4be8c040188b1ad9e36ee9262dd6fcdf8f8

    Comments

    Declarative Net Request: Handle flatbuffer indexed ruleset corruption.
    
    The JSON rulesets provided by an extension for the Declarative Net Request API
    are indexed to a flatbuffer (indexed) format during extension installation. This
    indexed ruleset is excluded from content verification and it is possible that it
    may get corrupted, making the extension ruleset useless.
    
    This CL handles ruleset corruption by re-indexing the JSON ruleset if the
    indexed ruleset fails to load.
    
    BUG=852058
    
    Change-Id: Ief43cd8f2bc030ad634a92e1fcf7656d03abd4c0
    Reviewed-on: https://chromium-review.googlesource.com/1107479
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574458}

    Changed files

    • chrome/browser/extensions/api/declarative_net_request/declarative_net_request_browsertest.cc
    • extensions/browser/api/declarative_net_request/rules_monitor_service.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.cc
    • extensions/browser/api/declarative_net_request/ruleset_manager.h
    • extensions/browser/api/declarative_net_request/utils.cc
    • extensions/browser/api/declarative_net_request/utils.h
    • extensions/browser/sandboxed_unpacker.cc
    • tools/metrics/histograms/histograms.xml
  24. Add chromeosInfoPrivate stylusStatus API (part 1)

    Changed by michaelpgohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:02:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6279eb8c5898875d456fc753c8e28ca8cea08e80

    Comments

    Add chromeosInfoPrivate stylusStatus API (part 1)
    
    Adds the "stylusStatus" property to chromeosInfoPrivate.get(). Will be:
    - "unsupported" if the device doesn't support stylus input.
    - "supported" if the device supports it.
    
    Part 2 will add:
    - "seen" if supported and stylus has been used at least once or the
      device comes with an internal stylus.
    
    Test: try && manually using supported and unsupported devices
    Bug: 632814
    Change-Id: I343908bcada0d149410875b885416bdc17f907da
    Reviewed-on: https://chromium-review.googlesource.com/1123320
    Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
    Reviewed-by: Toni Barzic <tbarzic@chromium.org>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574459}

    Changed files

    • chrome/browser/chromeos/extensions/info_private_api.cc
    • chrome/browser/chromeos/extensions/info_private_apitest.cc
    • chrome/common/extensions/api/chromeos_info_private.json
    • chrome/test/data/extensions/api_test/chromeos_info_private/extended/background.js
  25. Remove fetch_telemetry_dependencies DEPS hook.

    Changed by kbrohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:04:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bec21faa451d3fc5c62018430ec212d46db17707

    Comments

    Remove fetch_telemetry_dependencies DEPS hook.
    
    The recipes are using the new checkout_telemetry_binary_dependencies
    hook instead and the bots no longer set this gyp variable.
    
    Bug: 862640
    Change-Id: I53c136898a21f18d246b431c5b2a6b08bfb6a0d5
    Reviewed-on: https://chromium-review.googlesource.com/1134189
    Reviewed-by: Stephen Martinis <martiniss@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574460}

    Changed files

    • DEPS
  26. Mirroring Service: Supports switching between mirroring and remoting.

    Changed by xjzohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 01:50:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1eb8fa9af662dd108d6033c5d8813db78b8489ee

    Comments

    Mirroring Service: Supports switching between mirroring and remoting.
    
    Add the implementation to support the switching between mirroring and
    remoting. Also changed to only monitor the WiFi status when receiver
    indicates that it supports the get status message.
    
    Bug: 734672
    Change-Id: I72eefbcadc6f790c2573a81976cd9d0e2dbe3ae7
    Reviewed-on: https://chromium-review.googlesource.com/1104966
    Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Yuri Wiitala <miu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574456}

    Changed files

    • components/mirroring/service/BUILD.gn
    • components/mirroring/service/interface.h
    • components/mirroring/service/message_dispatcher.cc
    • components/mirroring/service/message_dispatcher.h
    • components/mirroring/service/message_dispatcher_unittest.cc
    • components/mirroring/service/session.cc
    • components/mirroring/service/session.h
    • components/mirroring/service/session_monitor.cc
    • components/mirroring/service/session_monitor.h
    • components/mirroring/service/session_monitor_unittest.cc
    • components/mirroring/service/session_unittest.cc
  27. Unified: Get default focus on detailed view.

    Changed by tetsuiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:06:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 704db340a765dc9972c0018b74fbb2908cb04d0c

    Comments

    Unified: Get default focus on detailed view.
    
    In UnifiedSystemTray, detailed view did not get focus when it is
    transitioned by keyboard.
    
    TEST=manual
    BUG=862504
    
    Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
    Reviewed-on: https://chromium-review.googlesource.com/1132899
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574461}

    Changed files

    • ash/system/tray/tray_detailed_view.cc
    • ash/system/tray/tray_detailed_view.h
    • ash/system/unified/unified_system_tray_controller.cc
    • ash/system/unified/unified_system_tray_view.cc
  28. [Picture in Picture] Create PictureInPictureControlEvent

    Changed by sawtelleohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 02:08:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 281b1ee604a3095d93c5bed1eb05e84f57db6966

    Comments

    [Picture in Picture] Create PictureInPictureControlEvent
    
    This change creates a subclass of Event called
    PictureInPictureControlEvent that can be called when
    a custom control is clicked on the Picture in Picture Window
     - the reason for this event specifically is that it also
    contains a String 'id', which is useful for a developer
    to see which control was clicked.
    
    Manual testing was done by initiating the call in
    overlay_window_views.cc by calling controller_->ControlClick() and
    confirming that the E
    ...skip...
    ate the custom event.
    
    Bug: 854271
    Change-Id: Idf8c290c7f7745af8f492d3b3169ba4cadb2386a
    Reviewed-on: https://chromium-review.googlesource.com/1106615
    Commit-Queue: Steven Sawtelle <sawtelle@google.com>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: apacible <apacible@chromium.org>
    Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
    Cr-Commit-Position: refs/heads/master@{#574462}

    Changed files

    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/core_idl_files.gni
    • third_party/blink/renderer/core/events/BUILD.gn
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.cc
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.h
    • third_party/blink/renderer/core/events/picture_in_picture_control_event.idl
    • third_party/blink/renderer/core/events/picture_in_picture_control_event_init.idl
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
  29. chromeos: adds more comments about child modal/transients

    Changed by skyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:12:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 20a46d01a72532d0375df58d797487cad764eede

    Comments

    chromeos: adds more comments about child modal/transients
    
    And a DCHECK that we're not attempting to use a DesktopNativeWidgetAura for
    CHILD_MODAL windows.
    
    BUG=none
    TEST=none
    
    Change-Id: I9138c7d5fb83078e6ee5cfe04d8fbf8a12e1cc85
    Reviewed-on: https://chromium-review.googlesource.com/1134048
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574463}

    Changed files

    • ui/views/mus/desktop_window_tree_host_mus.cc
  30. Expose Arc input method feature to chrome://flags.

    Changed by yhanadaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:18:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b63f06694d4bea2639fc3921d69fe2972cd699d

    Comments

    Expose Arc input method feature to chrome://flags.
    
    Bug: 845079
    Change-Id: I9f674c68d3cc442c042dde834a5f3123f15170cf
    Reviewed-on: https://chromium-review.googlesource.com/1131048
    Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574465}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • tools/metrics/histograms/enums.xml
  31. Settings: fix find in page shortcut handling

    Changed by aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:14:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 123398402602d1d9259cc9e3b71f50eae20c2415

    Comments

    Settings: fix find in page shortcut handling
    
    Bug: 862701
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I10c6f5888d53e0faf055adf9a45216bd83a71767
    Reviewed-on: https://chromium-review.googlesource.com/1133969
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574464}

    Changed files

    • chrome/browser/resources/settings/settings.html
    • chrome/browser/resources/settings/settings_ui/settings_ui.html
  32. Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)

    Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:20:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00714da94e9a0e147844f4d5625b433cb57cddd6

    Comments

    Roll src/third_party/depot_tools d64781e17af7..32e3d1e37cd6 (1 commits)
    
    https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d64781e17af7..32e3d1e37cd6
    
    
    git log d64781e17af7..32e3d1e37cd6 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 ehmaldonado@chromium.org Add a library for monitoring.
    
    
    Created with:
      gclient setdep -r src/third_party/depot_tools@32e3d1e37cd6
    
    The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org
    
    Documentation for the AutoR
    ...skip...
    who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=agable@chromium.org
    
    Change-Id: Ie6794e65ad8cfec457900a56f6808509b810267c
    Reviewed-on: https://chromium-review.googlesource.com/1134450
    Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574466}

    Changed files

    • DEPS
  33. Add base::OneShotTimer::FireNow() as a replacement of user_task()

    Changed by tzikohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:25:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f550a61d86c912dabe13cc71ea1e81762b951ae4

    Comments

    Add base::OneShotTimer::FireNow() as a replacement of user_task()
    
    This CL adds base::OneShotTimer::FireNow(), and replaces all user_task()
    call on base::OneShotTimer with FireNow(), as a preparation of
    OnceCallback support of OneShotTimer.
    
    After OneShotTimer starts supporting OnceCallback, user_task() needs to
    change the type of its return value to `const OnceClosure&`, which is
    unusable to run the callback. Assuming all users of user_task() of
    OneShotTimer run the resulting callback immediately and
    ...skip...
    Bug: 850247
    Change-Id: I52617fecfaf75aee19d681838af0e8a6b6f736a1
    Reviewed-on: https://chromium-review.googlesource.com/1128684
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Dan Erat <derat@chromium.org>
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Reviewed-by: Gabriel Charette <gab@chromium.org>
    Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574467}

    Changed files

    • ash/lock_screen_action/lock_screen_note_display_state_handler_unittest.cc
    • ash/policy/policy_recommendation_restorer_unittest.cc
    • ash/system/night_light/night_light_controller.h
    • ash/system/night_light/night_light_controller_unittest.cc
    • ash/system/power/power_button_controller_test_api.cc
    • ash/system/power/power_button_screenshot_controller_test_api.cc
    • ash/wm/immersive_fullscreen_controller_unittest.cc
    • base/timer/timer.cc
    • base/timer/timer.h
    • chrome/browser/chromeos/arc/voice_interaction/highlighter_controller_client.cc
    • chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
    • components/arc/power/arc_power_bridge.cc
    • components/sync/driver/data_type_manager_impl_unittest.cc
    • components/sync/driver/model_association_manager_unittest.cc
    • components/variations/variations_request_scheduler_mobile_unittest.cc
    • content/browser/indexed_db/indexed_db_backing_store.cc
    • content/browser/indexed_db/indexed_db_factory_unittest.cc
    • content/browser/renderer_host/input/mouse_wheel_phase_handler.cc
    • media/remoting/renderer_controller_unittest.cc
    • net/disk_cache/simple/simple_index_unittest.cc
    • ui/display/manager/display_configurator.cc
  34. Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 02:51:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b0529974fae81606d19de5722d21320de4678e8

    Comments

    Roll src/third_party/webrtc ef43aafcf595..d78323faba86 (47 commits)
    
    https://webrtc.googlesource.com/src.git/+log/ef43aafcf595..d78323faba86
    
    
    git log ef43aafcf595..d78323faba86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 steveanton@webrtc.org Remove AddTrack override with MediaStreams
    2018-07-11 buildbot@webrtc.org Roll chromium_revision c797a4c559..2e3b05bf93 (574101:574261)
    2018-07-11 danilchap@webrtc.org Reland "Remove rtc::Optional alias and api:optional target"
    2018-07-11 tkchin@we
    ...skip...
    819294,chromium:860638,chromium:none,chromium:None,chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I76bc9222cb5ac91beb290da2d1740e35a029679c
    Reviewed-on: https://chromium-review.googlesource.com/1134448
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574470}

    Changed files

    • DEPS
  35. Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled

    Changed by bashiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:54:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f1fbed9c375f8c5301ea55a28320e56c0a4653ac

    Comments

    Skip a ChromeResourceDispatcherHostDelegateBrowserTest when S13nSW is enabled
    
    ChromeResourceDispatcherHostDelegateBrowserTest.NavigationDataProcessed
    tries to get NavigationData from NavigationHandle but we dont set
    NavigationData when S13nSW is enabled. Skip it when S13nSW is enabled.
    
    Bug: 861657
    Change-Id: I7af24fa1981d66c76cf5f83920b29b49d3988f33
    Reviewed-on: https://chromium-review.googlesource.com/1131041
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574471}

    Changed files

    • chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
  36. Fix debain package issue for ARM64.

    Changed by halton.huoohnoyoudont@gmail.com
    Changed at Thursday, 12-Jul-18 02:49:50 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c621f6274616b050108d3cbb3b9d24bfa2c56233

    Comments

    Fix debain package issue for ARM64.
    
    Bug: 862500
    Change-Id: Ib456bdb3773cf9f50d7de85275804700c807f18e
    Reviewed-on: https://chromium-review.googlesource.com/1134578
    Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574469}

    Changed files

    • chrome/installer/linux/debian/build.sh
    • chrome/installer/linux/debian/calculate_package_deps.py
  37. Settings: remove use of /deep/ selector in settings-ui

    Changed by aeeohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:57:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 953e0851bee83c191092a0e7abeb883aab2fe1fc

    Comments

    Settings: remove use of /deep/ selector in settings-ui
    
    Bug: 860069
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I15349a654bd8309688cb5f0f58a4df115d3e180d
    Reviewed-on: https://chromium-review.googlesource.com/1133707
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574472}

    Changed files

    • chrome/browser/resources/settings/settings_ui/settings_ui.js
  38. Blink: Add test for LifecycleNotifier::ForEachObserver.

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:02:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d12a94d841e7040cb516cb29c535cb899bdb58f0

    Comments

    Blink: Add test for LifecycleNotifier::ForEachObserver.
    
    Change-Id: I105750df8a76a5cabface400ba0dcfe60a77b810
    Reviewed-on: https://chromium-review.googlesource.com/1132848
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574473}

    Changed files

    • third_party/blink/renderer/platform/lifecycle_context_test.cc
  39. Port GCM's RegistrationRequest to SimpleURLLoader

    Changed by morlovichohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 02:45:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c70c93c4855cbbdd5c9f05fe2f383599be7a0eb5

    Comments

    Port GCM's RegistrationRequest to SimpleURLLoader
    
    URLFetcher will stop working with advent of Network Service, and
    SimpleURLLoader is the replacement API for most clients.
    
    (Other request types will follow; they were not done for now to keep CL size down, since there is a
     lot of wiring of pointers through and test infra stuff).
    
    Bug: 844987
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I1dc5efda6d239509d060f154cedf57ecf73edff2
    Reviewed-on: https://chromium-review.googlesource.com/1110705
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Reviewed-by: Reilly Grant <reillyg@chromium.org>
    Commit-Queue: Maks Orlovich <morlovich@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574468}

    Changed files

    • chrome/browser/extensions/extension_gcm_app_handler_unittest.cc
    • chrome/browser/gcm/gcm_profile_service_unittest.cc
    • chrome/browser/net/system_network_context_manager.cc
    • components/gcm_driver/fake_gcm_client.cc
    • components/gcm_driver/fake_gcm_client.h
    • components/gcm_driver/gcm_client.h
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_client_impl.h
    • components/gcm_driver/gcm_client_impl_unittest.cc
    • components/gcm_driver/gcm_driver_desktop.cc
    • components/gcm_driver/gcm_driver_desktop.h
    • components/gcm_driver/gcm_driver_desktop_unittest.cc
    • google_apis/gcm/BUILD.gn
    • google_apis/gcm/engine/gcm_request_test_base.cc
    • google_apis/gcm/engine/gcm_request_test_base.h
    • google_apis/gcm/engine/registration_request.cc
    • google_apis/gcm/engine/registration_request.h
    • google_apis/gcm/engine/registration_request_unittest.cc
    • google_apis/gcm/test/DEPS
    • google_apis/gcm/test/run_all_unittests.cc
  40. [Extensions Cleanup] Remove unnecessary call to sync service

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 34a47acf551fda25534bde4146c5f94409bd8b5b

    Comments

    [Extensions Cleanup] Remove unnecessary call to sync service
    
    The runtime host permissions preferences used to be synced, but aren't
    currently. Remove the call to the sync service, since it's unnecessary.
    
    If/when we add back syncing support, we can re-add this call.
    
    Bug: 839681
    Change-Id: Iba45e431ad09f8ff92861c69ae8447c125af707a
    Reviewed-on: https://chromium-review.googlesource.com/1134433
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574474}

    Changed files

    • chrome/browser/extensions/scripting_permissions_modifier.cc
  41. Updating trunk VERSION from 3489.0 to 3490.0

    Changed by chrome-release-botohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:08:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 21d5fa75c5045ffda38bb5368435754a3a42d8e8

    Comments

    Updating trunk VERSION from 3489.0 to 3490.0
    
    # This is an automated release commit.
    # Do not revert without consulting chrome-pmo@google.com.
    NOAUTOREVERT=true
    TBR=amineer@chromium.org
    
    Change-Id: I6fc6232d8ba9ed933cc765caf4098281916f453d
    Reviewed-on: https://chromium-review.googlesource.com/1134528
    Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574475}

    Changed files

    • chrome/VERSION
  42. Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 03:16:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f0b7cacfc5ff01fe6d83463c81048b244322db8c

    Comments

    Roll src/third_party/chromite a3bc29bcacf3..c228d491eb86 (3 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/a3bc29bcacf3..c228d491eb86
    
    
    git log a3bc29bcacf3..c228d491eb86 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 bpastene@chromium.org cros_chrome_sdk: Change default location of cros cache dir.
    2018-07-12 vapier@chromium.org config_lib: delay loading of site_config in many modules
    2018-07-12 tbrindus@chromium.org paygen: Fix exception instantiation in error pat
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: I88e283d9cb6593f6c1be6a0dfb2a9853e8e09f7f
    Reviewed-on: https://chromium-review.googlesource.com/1134103
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574476}

    Changed files

    • DEPS
  43. Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""

    Changed by bsalomonohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 03:18:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cbaa2f11a4e9f5ef04eeb8cf0dc2acfdbaa79f56

    Comments

    Revert "Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest.""
    
    This reverts commit 23370775c415c21f4de1c7d97dd5645fe2b7e818.
    
    Reason for revert: still fails on Nexus 9
    
    Original change's description:
    > Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    > 
    > This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    > 
    > The updated change uses window.devicePixelRatio to determine the inset.
    > It also accounts for the absolute position used by the "
    ...skip...
    5adba768e22593057d00310e47
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 847984
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1134120
    Reviewed-by: Brian Salomon <bsalomon@google.com>
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Cr-Commit-Position: refs/heads/master@{#574477}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  44. [Save card dialog] Update Google Pay logo and title padding

    Changed by ftireloohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:30:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fb48e72d0b5d141e297e1e0a04d47cca079b0e1a

    Comments

    [Save card dialog] Update Google Pay logo and title padding
    
    According to the new spec, title for the server card should be:
      [GPay icon]<8px>|<8px>[Title]
    as opposed to the current:
      [GPay icon]<16px>|<16px>[Title]
    
    Mocks: https://drive.google.com/open?id=1A717QrLWOYSj3_A75tyMZomLUhy0xdV0
    Testing:
     - Local card: ./out/Debug/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=SaveCardBubbleControllerImplTest.InvokeUi_Local --test-launcher-interactive
     - Upstream card: ./out/Debug/browser_tests --
    ...skip...
    ralize in a follow-up
    CL, to make sure we have proper testing.
    
    Also added comments to the different sections of the GPay logo
    .icon file, to make it easier to inspect any future updates.
    
    Bug: 859893
    Change-Id: I6c551b113e476f21f3e74198b37f6df080226e78
    Reviewed-on: https://chromium-review.googlesource.com/1127471
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Trent Apted <tapted@chromium.org>
    Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574478}

    Changed files

    • chrome/app/vector_icons/BUILD.gn
    • chrome/app/vector_icons/google_pay_logo.icon
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views.h
  45. [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.

    Changed by imchengohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:34:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision da7bd5a1bbf177bb5822564193a7ea1795e0159b

    Comments

    [MediaRouter] Reconnect the extension MRP Mojo pipe on connection error.
    
    MR extension can fail/crash for many reasons. This in turn may cause
    ExtensionMediaRouteProviderProxy to violate its Mojo message pipe
    contract by dropping pending callbacks.
    
    Rather than wrapping each callback and tracking them in EMRPP, this
    patch deals with this by having MediaRouterDesktop detect when the EMRPP
    pipe encounters an error and attempt to recreate the pipe, subject to a
    max number of attempts.
    
    Bug: 861778
    Change-Id: Ie70e2cae3ea6650b65f658aba4ec527d4e2eb0d0
    Reviewed-on: https://chromium-review.googlesource.com/1129208
    Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
    Commit-Queue: Derek Cheng <imcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574479}

    Changed files

    • chrome/browser/media/router/mojo/media_router_desktop.cc
    • chrome/browser/media/router/mojo/media_router_desktop.h
    • chrome/browser/media/router/mojo/media_router_desktop_unittest.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.cc
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy.h
    • chrome/browser/media/router/providers/extension/extension_media_route_provider_proxy_unittest.cc
  46. Update signed exchange test directory reference

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:42:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7e72dce733afafe0340e25390b5f4c228702e9de

    Comments

    Update signed exchange test directory reference
    
    The directory was renamed in crrev.com/c/1132835.
    
    Bug: 856530
    Change-Id: I34890b24f256048d49bc59f5ba34ec048ce48d1c
    Reviewed-on: https://chromium-review.googlesource.com/1133609
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574481}

    Changed files

    • third_party/blink/tools/blinkpy/third_party/wpt/README.chromium
  47. Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.

    Changed by miuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 03:36:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b7bed8483e07637b8b24e7492d97bbc0499b6c16

    Comments

    Add viz::VideoCaptureOverlay to support mouse cursor rendering VIZ-side.
    
    VideoCaptureOverlay provides the post-GPU-readback rendering of small
    SkBitmaps onto the VideoFrames captured by viz::FrameSinkVideoCapturer.
    This will be used to move mouse cursor rendering out of the browser
    process, and into VIZ, as was intended in the original design. More
    details in crbug/810133.
    
    A soon-upcoming series of changes will provide mojo IDL definition as
    well as integration of VideoCaptureOverlay with FrameSinkVideoCapturer.
    
    Bug: 810133
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: I16897dbd361af153d10a1223339d9fb5f7e5f05a
    Reviewed-on: https://chromium-review.googlesource.com/1132318
    Commit-Queue: Yuri Wiitala <miu@chromium.org>
    Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574480}

    Changed files

    • components/viz/service/BUILD.gn
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.cc
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay.h
    • components/viz/service/frame_sinks/video_capture/video_capture_overlay_unittest.cc
    • components/viz/test/data/video_capture/overlay_clips_ll.png
    • components/viz/test/data/video_capture/overlay_clips_lr.png
    • components/viz/test/data/video_capture/overlay_clips_ul.png
    • components/viz/test/data/video_capture/overlay_clips_ur.png
    • components/viz/test/data/video_capture/overlay_full_cover.png
    • components/viz/test/data/video_capture/overlay_full_cover_scaled.png
    • components/viz/test/data/video_capture/overlay_moves_0_0.png
    • components/viz/test/data/video_capture/overlay_moves_1_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_0.png
    • components/viz/test/data/video_capture/overlay_moves_2_1.png
    • components/viz/test/data/video_capture/overlay_moves_2_2.png
    • components/viz/test/data/video_capture/overlay_moves_lr.png
  48. Ensure NavigationURLLoader does not exist in OnStartChecksComplete.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:05:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision db52f93a94ed44198ade982c1640aa6aec35346c

    Comments

    Ensure NavigationURLLoader does not exist in OnStartChecksComplete.
    
    navigation_handle_->InitServiceWorkerHandle and navigation_handle_->InitAppCacheHandle
    reset the objects that NavigationURLLoaderImpl holds raw pointers to.
    So we must ensure |loader_| does not exist before doing that.
    
    Follow-up to r574110 <https://chromium-review.googlesource.com/1132715>.
    
    Bug: 857005
    Change-Id: If150832a8f6a104dbd662f2cc0e2c119e7a523bf
    Reviewed-on: https://chromium-review.googlesource.com/1133611
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574482}

    Changed files

    • content/browser/frame_host/navigation_request.cc
  49. Linux install dialog now has the word (Beta)

    Changed by nverneohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:19:01 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f5adc1de421e13cb871f50ed27d194a6ed1d5fb4

    Comments

    Linux install dialog now has the word (Beta)
    
    Bug: 848118
    Change-Id: Ib19c766d00084771d58f648076901eb6c4e25533
    Reviewed-on: https://chromium-review.googlesource.com/1133605
    Reviewed-by: Renée Wright <rjwright@chromium.org>
    Commit-Queue: Nicholas Verne <nverne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574483}

    Changed files

    • chrome/app/chromeos_strings.grdp
  50. Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 04:20:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1fc8a107a045fc9722cc619cd867e1197564f338

    Comments

    Roll src/third_party/webrtc d78323faba86..5795489e83ad (1 commits)
    
    https://webrtc.googlesource.com/src.git/+log/d78323faba86..5795489e83ad
    
    
    git log d78323faba86..5795489e83ad --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 buildbot@webrtc.org Roll chromium_revision 2e3b05bf93..720dadbc21 (574261:574387)
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@5795489e83ad
    
    The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here
    ...skip...
    rver.chromium.mac:mac_chromium_archive_rel_ng
    
    BUG=chromium:None
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: I921992cf5317868ff92ddfd27ecdba4c9cd8c78f
    Reviewed-on: https://chromium-review.googlesource.com/1134146
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574484}

    Changed files

    • DEPS
  51. Gardening: Revise bug # for broken-chunked-encoding.https.html.

    Changed by falkenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:20:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 349d297d20d841791815fd8b86b87f02e755bd22

    Comments

    Gardening: Revise bug # for broken-chunked-encoding.https.html.
    
    NOTRY=true
    
    Bug: 830472,862886
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: Ia6b50e1730d1f5dcb4f84b5c18d47003565fd838
    TBR: bashi
    Reviewed-on: https://chromium-review.googlesource.com/1134627
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Commit-Queue: Matt Falkenhagen <falken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574485}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
    • third_party/WebKit/LayoutTests/TestExpectations
  52. Fix crash in ResourceFetcher::CachedResource()

    Changed by ksakamotoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:26:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ae18f0f47b8272cc5b911cc22cb799a648405f45

    Comments

    Fix crash in ResourceFetcher::CachedResource()
    
    This fixes a bug where ResourceFetcher::CachedResource() crashes when
    given a null KURL.
    
    Bug: 859314
    Change-Id: Iae07ded3124b690854aa7ba2a532f21be2a99972
    Reviewed-on: https://chromium-review.googlesource.com/1132914
    Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574487}

    Changed files

    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc
    • third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc
  53. [LayoutNG] Minor cleanup for NGInlineItem::Script()

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:27:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 078bf960f5874ead134ad8f8c2e3f265969044cb

    Comments

    [LayoutNG] Minor cleanup for NGInlineItem::Script()
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie8d9ac37eca29db6a39f9a4612a3c0151ef06006
    Reviewed-on: https://chromium-review.googlesource.com/1132254
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574488}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h
  54. Disable flaky resource loading hints browser test on windows.

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:25:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 91567a36db92e68bb36a513b68c119707b4c2cec

    Comments

    Disable flaky resource loading hints browser test on windows.
    
    Change-Id: Iea8b186c1673fb14982c98ce24141003d267df21
    TBR: ryansturm@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134595
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574486}

    Changed files

    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  55. Stop content sniffing after successful encoding detection

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 04:40:43 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision efbdada3f735a2631e9dfeed5c5e3f880245ccd3

    Comments

    Stop content sniffing after successful encoding detection
    
    Content sniffing should stop once the detector makes a valid
    guess. http://crrev.com/2697213002 introduced a side effect
    that has the detector continue to sniff the content, therefore
    opens the possibility of returning an encoding different from
    the first guess. It leads to a document decoded with multiple
    encoding schemes, one of which may not be correct.
    
    This CL addresses it by defining a new flag |detection_completed_|
    to tell the TextResourceDecoder to stop sniffing, even if
    detector returns false for unlabelled UTF-8 documents. Also added
    a test verifying the behavior.
    
    Bug: 710861
    Change-Id: Ic07de3ae08fbb742aa3c24f1e18055348d6acbd8
    Reviewed-on: https://chromium-review.googlesource.com/1132904
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574489}

    Changed files

    • third_party/blink/renderer/core/html/parser/text_resource_decoder.cc
    • third_party/blink/renderer/core/html/parser/text_resource_decoder.h
    • third_party/blink/renderer/core/html/parser/text_resource_decoder_test.cc
    • third_party/blink/renderer/platform/text/text_encoding_detector.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.cc
    • third_party/blink/renderer/platform/wtf/text/text_encoding.h
  56. Add workaround for WebUIs that make network requests when running with the network service.

    Changed by jamohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:28:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 04bfa853ac261c316e0ef799e7c10ae05dece8c1

    Comments

    Add workaround for WebUIs that make network requests when running with the network service.
    
    Currently with the network service, renderers that have WebUI bindings are not allowed to make requests over the internet. This is to improve security in case the response hijacks the renderer. However there are a couple of WebUIs that are doing this now, so temporarily allow them.
    
    Bug: 848987, 829412
    Change-Id: I34c1b66e63fd1b7c2960cc867709c065329cf489
    Reviewed-on: https://chromium-review.googlesource.com/1134412
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574490}

    Changed files

    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/chrome_content_browser_client.h
    • chrome/browser/extensions/chrome_extensions_browser_client.cc
    • chrome/browser/extensions/chrome_extensions_browser_client.h
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
    • chrome/browser/ui/webui/chrome_web_ui_controller_factory.h
    • content/browser/frame_host/render_frame_host_impl.cc
    • content/public/browser/content_browser_client.cc
    • content/public/browser/content_browser_client.h
    • extensions/browser/api/web_request/web_request_permissions.cc
    • extensions/browser/extensions_browser_client.cc
    • extensions/browser/extensions_browser_client.h
  57. Print Preview: Add new Cloud Printer Handler flag

    Changed by rbpotterohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:34:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9990eb4884bf57e3f907c5a475d182ff4db6d760

    Comments

    Print Preview: Add new Cloud Printer Handler flag
    
    Use a new cloud printer handler flag to control using the C++ cloud
    printer handler instead of the JS cloud print interface in Print
    Preview. Print Preview will be temporarily whitelisted to send network
    requests with the network service flag enabled, so these changes should
    be de-coupled from the network service flag.
    
    Bug: 829414
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I9a7b53fe69bfe5aad4ab7cc5688dfb88e6074014
    Reviewed-on: https://chromium-review.googlesource.com/1134397
    Reviewed-by: Lei Zhang <thestig@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: John Abd-El-Malek <jam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574492}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/resources/print_preview/data/destination_store.js
    • chrome/browser/ui/webui/print_preview/print_preview_handler.cc
    • chrome/browser/ui/webui/print_preview/print_preview_ui.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • tools/metrics/histograms/enums.xml
  58. Remove debugging code in base::MessagePumpWin.

    Changed by thestigohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:29:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 95f61506c064bf502b2f2f81293866e40843ab2b

    Comments

    Remove debugging code in base::MessagePumpWin.
    
    BUG=596190
    
    Change-Id: Ie9b6ee2cc1db8399247be767cabba1b39df50544
    Reviewed-on: https://chromium-review.googlesource.com/1128274
    Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574491}

    Changed files

    • base/message_loop/message_pump_win.cc
    • base/message_loop/message_pump_win.h
  59. check |focused_surface_| on SetCursorType

    Changed by mukaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:47:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5939dab948bcde131510fa955f2802e93159238

    Comments

    check |focused_surface_| on SetCursorType
    
    SetCursorType hasn't checked the focused surface, thus it could
    change the cursor shapes even though the mouse pointer isn't
    related to the apps under exo.
    
    BUG=b/111360026
    TEST=the new test case in exo_unittests
    
    Change-Id: Ibacb0b8689720caa00ec206848cc6efb74854946
    Reviewed-on: https://chromium-review.googlesource.com/1134185
    Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
    Commit-Queue: Jun Mukai <mukai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574493}

    Changed files

    • components/exo/pointer.cc
    • components/exo/pointer_unittest.cc
  60. Move scroll-related platform test code into core/testing/

    Changed by szagerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 05:49:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecb9b545a199897e05ca621e40fd5e93289f82bd

    Comments

    Move scroll-related platform test code into core/testing/
    
    Also delete unused fake_scrollable_area.h.
    
    BUG=823365
    R=skobes@chromium.org,pdr@chromium.org
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I5620b9c31d53d523108c0c7a3a247264e588fc90
    Reviewed-on: https://chromium-review.googlesource.com/1132380
    Reviewed-by: Steve Kobes <skobes@chromium.org>
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Stefan Zager <szager@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574494}

    Changed files

    • third_party/blink/renderer/core/BUILD.gn
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater_test.cc
    • third_party/blink/renderer/core/testing/core_unit_test_helper.h
    • third_party/blink/renderer/core/testing/use_mock_scrollbar_settings.h
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/graphics/graphics_layer_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_scrollable_area.h