Home | Search
Login

Builder Android Nexus5X WebView Perf Build #2332

Results:

failed performance_webview_test_suite on Android device Nexus 5X

Trigger Info:

Got Revision24987fbbb4290a39f72ca8d60484ab1352d99ebf

Execution:

Steps and Logfiles:

Show:
  1. ( 2 hrs 27 mins ) steps
    running steps via annotated script
  2. ( 11 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 4 mins 5 secs ) bot_update
    bot_update
    [106GB/492GB used (21%)]
  8. ( 1 ms ) ensure_goma
    ensure_goma
  9. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  10. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  11. ( 36 secs ) gclient runhooks
    gclient runhooks
  12. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  13. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/Android_Nexus5X_WebView_Perf/src/testing/buildbot/chromium.perf.json
  14. ( 43 secs ) clean local files
    clean local files
  15. ( 1 ms ) tree truth steps
    tree truth steps
  16. ( 9 secs ) build directory
    build directory
  17. ( 2 mins 45 secs ) extract build
    extract build
  18. ( 1 ms ) find isolated tests
    find isolated tests
  19. ( 1 ms ) test_pre_run
    test_pre_run
  20. ( 28 secs ) test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 5X
    test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 5X
    Run on OS: 'Android'
  21. ( 2 hrs 17 mins ) performance_webview_test_suite on Android device Nexus 5X
    performance_webview_test_suite on Android device Nexus 5X
    Run on OS: 'Android'
    Max pending time: 0:01:15.954570 (shard #12)
    Max shard duration: 1:46:29.627220 (shard #5)
    Min shard duration: 0:47:34.267400 (shard #2)
    Total tests: 1116
    * Passed: 992 (992 expected, 0 unexpected)
    * Skipped: 121 (121 expected, 0 unexpected)
    * Failed: 2 (0 expected, >>>2 unexpected<<<)
    * Flaky: 1 (0 expected, >>>1 unexpected<<<)
     
    Unexpected Failures:
    * rendering.mobile/yahoo_answers_mobile_2018
    * rendering.mobile/yahoo_answers_mobile_sync_scroll_2018
     
    Unexpected Flakes:
    * loading.mobile/GoogleRedirectToGoogleJapan_3g
     
  22. ( 1 ms ) Upload to test-results [performance_webview_test_suite on Android device Nexus 5X]
    Upload to test-results [performance_webview_test_suite on Android device Nexus 5X]
  23. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 16
    Total runtime: 15:48:30.825264
     
  24. ( 1 ms ) test_report
    test_report
  25. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Nexus5X_WebView_Perf/2332/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Android_Nexus5X_WebView_Perf/2332" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "6ba9754f4a5668936976ca7d8f5ec69de30f9aee" Annotation(bot_update)
got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" Annotation(bot_update)
got_nacl_revision "821833667ccccf83b96b4fdaf2074c6e71f87544" Annotation(bot_update)
got_revision "24987fbbb4290a39f72ca8d60484ab1352d99ebf" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#581200}" Annotation(bot_update)
got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" Annotation(bot_update)
got_v8_revision "973f34ce78a25a64567f0e12348d4114429c7342" Annotation(bot_update)
got_v8_revision_cp "refs/heads/7.0.159@{#1}" Annotation(bot_update)
got_webrtc_revision "eb73a7bd16c725477ca2da6dc0e6fea236616d44" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#24199}" Annotation(bot_update)
swarm_hashes {"performance_webview_test_suite":"7e5a5b330957df560d60ab37d85ab239bff8f9cb"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpKYLFdn" Annotation(steps)
build_id "buildbot/chromium.perf/Android Nexus5X WebView Perf/2332" Annotation(steps)
builder_id "master.chromium.perf:Android Nexus5X WebView Perf" Annotation(steps)
blamelist ["altimin@chromium.org","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","foolip@chromium.org","futhark@chromium.org","gambard@chromium.org","hajimehoshi@chromium.org","hayato@chromium.org","jdmuys@chromium.org","jdoerrie@chromium.org","jkrcal@chromium.org","kojii@chromium.org","mamir@chromium.org","mmenke@chromium.org","mstensho@chromium.org","oscarj@opera.com","rego@igalia.com","scottwu@chromium.org","shenghao@google.com","treib@chromium.org","yhirano@chromium.org"] Build
branch "master" Build
buildnumber 2332 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1533949716 Build
revision "24987fbbb4290a39f72ca8d60484ab1352d99ebf" Build
slavename "slave214-c1" BuildSlave
buildername "Android Nexus5X WebView Perf" Builder
git_revision "24987fbbb4290a39f72ca8d60484ab1352d99ebf" Change
parent_buildername "Android arm64 Compile Perf" ParentBuild
parent_buildnumber 33469 ParentBuild
parent_got_angle_revision "6ba9754f4a5668936976ca7d8f5ec69de30f9aee" ParentBuild
parent_got_buildtools_revision "9a90d9aaadeb5e04327ed05775f45132e4b3523f" ParentBuild
parent_got_nacl_revision "821833667ccccf83b96b4fdaf2074c6e71f87544" ParentBuild
parent_got_revision "24987fbbb4290a39f72ca8d60484ab1352d99ebf" ParentBuild
parent_got_revision_cp "refs/heads/master@{#581200}" ParentBuild
parent_got_swarming_client_revision "486c9b53c4d54dd4b95bb6ce0e31160e600dfc11" ParentBuild
parent_got_v8_revision "973f34ce78a25a64567f0e12348d4114429c7342" ParentBuild
parent_got_v8_revision_cp "refs/heads/7.0.159@{#1}" ParentBuild
parent_got_webrtc_revision "eb73a7bd16c725477ca2da6dc0e6fea236616d44" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#24199}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Android_Nexus5X_WebView_Perf" slave

Blamelist:

  1. (kojiiohnoyoudont@chromium.org)
  2. (scottwuohnoyoudont@chromium.org)
  3. (gambardohnoyoudont@chromium.org)
  4. (hayatoohnoyoudont@chromium.org)
  5. (gambardohnoyoudont@chromium.org)
  6. (jkrcalohnoyoudont@chromium.org)
  7. (altiminohnoyoudont@chromium.org)
  8. (jdoerrieohnoyoudont@chromium.org)
  9. (regoohnoyoudont@igalia.com)
  10. (jdmuysohnoyoudont@chromium.org)
  11. (mamirohnoyoudont@chromium.org)
  12. (foolipohnoyoudont@chromium.org)
  13. (mstenshoohnoyoudont@chromium.org)
  14. (mstenshoohnoyoudont@chromium.org)
  15. (futharkohnoyoudont@chromium.org)
  16. (oscarjohnoyoudont@opera.com)
  17. (kojiiohnoyoudont@chromium.org)
  18. (treibohnoyoudont@chromium.org)
  19. (futharkohnoyoudont@chromium.org)
  20. (yhiranoohnoyoudont@chromium.org)
  21. (shenghaoohnoyoudont@google.com)
  22. (mmenkeohnoyoudont@chromium.org)
  23. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  24. (hajimehoshiohnoyoudont@chromium.org)

Timing:

Create N/A
Start Saturday, 11-Aug-18 03:52:43 UTC
End Saturday, 11-Aug-18 06:20:34 UTC
Pending N/A
Execution 2 hrs 27 mins

All Changes:

  1. [LayoutNG] Remove fragments after ellipsis

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:12:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ef23e85f7c64c339baa2de9da2159786bba18db

    Comments

    [LayoutNG] Remove fragments after ellipsis
    
    This patch removes fragments after ellipsis when
    'text-overflow: ellpisis' is applied.
    
    When the container box has paddings, ellipsizing is computed
    for the content box, but clipping is performed for the
    padding box. This patch hides fragments that fall into the
    paddings.
    
    We may need to revisit how to hide them. Before this patch,
    we moved them outside of the content box. With this patch,
    we stop producing fragments for them. Neitehr is paint-
    effects as the spec defines, and may require other parts
    to special case. I'll explorer other options if problems
    arose with this approach.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I44256440b4afbf1f4caf35269abf3450372fbf65
    Reviewed-on: https://chromium-review.googlesource.com/1158670
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581177}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/text-overflow-ellipsis-bidi-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/text-overflow-ellipsis-text-align-right-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/text/hide-atomic-inlines-after-ellipsis-expected.png
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/markers/ellipsis-mixed-text-in-ltr-flow-with-markers-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/paint/markers/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.txt
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_truncator.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_line_truncator.h
  2. Move password form serialization logic into components folder

    Changed by scottwuohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:23:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e35c0a03fef63a03497491233a5cdcf52e27a1ed

    Comments

    Move password form serialization logic into components folder
    
    The purpose is to share this logic with both ios chrome and ios web view
    
    Bug: 865114
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id6f16a05eb3408238c2772b420ec408e499ed2e8
    Reviewed-on: https://chromium-review.googlesource.com/1151181
    Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: John Wu <jzw@chromium.org>
    Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
    Commit-Queue: Scott Wu <scottwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581180}

    Changed files

    • components/BUILD.gn
    • components/password_manager/ios/BUILD.gn
    • components/password_manager/ios/DEPS
    • components/password_manager/ios/account_select_fill_data.cc
    • components/password_manager/ios/account_select_fill_data.h
    • components/password_manager/ios/account_select_fill_data_unittest.cc
    • components/password_manager/ios/js_password_manager.h
    • components/password_manager/ios/js_password_manager.mm
    • components/password_manager/ios/test_helpers.cc
    • components/password_manager/ios/test_helpers.h
    • ios/chrome/browser/passwords/BUILD.gn
    • ios/chrome/browser/passwords/password_controller.mm
    • ios/chrome/browser/passwords/password_controller_unittest.mm
  3. [iOS] Fix SideSwipe jump after rotation

    Changed by gambardohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:15:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 971b7ef9a9b023783d8ef6f4be3b3ab144854501

    Comments

    [iOS] Fix SideSwipe jump after rotation
    
    This CL updates the top margin of the SideSwipe image, which is
    otherwise wrong after changing device orientation as the toolbar
    height is different.
    
    Bug: 869902
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I767ab0fa76fea9c538e4e2c4e1ad49bc86b0d652
    Reviewed-on: https://chromium-review.googlesource.com/1158826
    Reviewed-by: Justin Cohen <justincohen@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581179}

    Changed files

    • ios/chrome/browser/ui/side_swipe/card_side_swipe_view.mm
  4. Prefer EventTarget::DispatchEvent(Event&) to EventTarget::DispatchEvent(Event*)

    Changed by hayatoohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:13:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6a0529ac33f137fa3e850218415f5bda31dbaa88

    Comments

    Prefer EventTarget::DispatchEvent(Event&) to EventTarget::DispatchEvent(Event*)
    
    This is a follow-up CL after http://crrev.com/581145.
    
    Rewrite each caller of EventTarget::DispatchEvent(Event*) to use EventTarget::DispatchEvent(Event&).
    Now we can remove EventTarget::DispatchEvent(Event*).
    
    There are still a lot of other places where Event* should be replaced with Event&, which can be
    addressed in another CL.
    
    See also http://crbug.com/871662, where we might want to make various Event::Create(..) func
    ...skip...
    -Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: If2e04cbaeea4b540428937dea6a1f9eedf7821ba
    Reviewed-on: https://chromium-review.googlesource.com/1164806
    Reviewed-by: Kent Tamura <tkent@chromium.org>
    Commit-Queue: Hayato Ito <hayato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581178}

    Changed files

    • third_party/blink/renderer/core/dom/events/event_target.cc
    • third_party/blink/renderer/core/dom/events/event_target.h
    • third_party/blink/renderer/core/editing/editing_utilities.cc
    • third_party/blink/renderer/core/editing/frame_selection.cc
    • third_party/blink/renderer/core/html/track/html_track_element.cc
    • third_party/blink/renderer/core/timing/performance.cc
    • third_party/blink/renderer/core/workers/dedicated_worker.cc
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
    • third_party/blink/renderer/core/xmlhttprequest/xml_http_request_upload.cc
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
    • third_party/blink/renderer/modules/app_banner/app_banner_controller.cc
    • third_party/blink/renderer/modules/bluetooth/bluetooth_device.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/cookie_store/cookie_store.cc
    • third_party/blink/renderer/modules/eventsource/event_source.cc
    • third_party/blink/renderer/modules/filesystem/file_writer.cc
    • third_party/blink/renderer/modules/gamepad/navigator_gamepad.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element_test.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element_test.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_panel_element_test.cc
    • third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element_test.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_rotate_to_fullscreen_delegate_test.cc
    • third_party/blink/renderer/modules/mediarecorder/media_recorder.cc
    • third_party/blink/renderer/modules/mediastream/media_devices.cc
    • third_party/blink/renderer/modules/mediastream/media_stream.cc
    • third_party/blink/renderer/modules/mediastream/media_stream_track.cc
    • third_party/blink/renderer/modules/netinfo/network_information.cc
    • third_party/blink/renderer/modules/notifications/notification.cc
    • third_party/blink/renderer/modules/payments/payment_request.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_dtmf_sender.cc
    • third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
    • third_party/blink/renderer/modules/permissions/permission_status.cc
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
    • third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_window.cc
    • third_party/blink/renderer/modules/presentation/presentation_availability.cc
    • third_party/blink/renderer/modules/presentation/presentation_connection.cc
    • third_party/blink/renderer/modules/presentation/presentation_connection_list.cc
    • third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
    • third_party/blink/renderer/modules/screen_orientation/screen_orientation_controller_impl.cc
    • third_party/blink/renderer/modules/sensor/sensor.cc
    • third_party/blink/renderer/modules/service_worker/service_worker.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_container.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_global_scope.cc
    • third_party/blink/renderer/modules/service_worker/service_worker_registration.cc
    • third_party/blink/renderer/modules/speech/speech_synthesis.cc
    • third_party/blink/renderer/modules/vr/navigator_vr.cc
    • third_party/blink/renderer/modules/webaudio/audio_scheduled_source_node.cc
    • third_party/blink/renderer/modules/webaudio/base_audio_context.cc
    • third_party/blink/renderer/modules/webaudio/offline_audio_context.cc
    • third_party/blink/renderer/modules/webaudio/script_processor_node.cc
    • third_party/blink/renderer/modules/webgl/webgl2_compute_rendering_context.cc
    • third_party/blink/renderer/modules/webgl/webgl2_rendering_context.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context.cc
    • third_party/blink/renderer/modules/webmidi/midi_access.cc
    • third_party/blink/renderer/modules/webmidi/midi_input.cc
    • third_party/blink/renderer/modules/webmidi/midi_port.cc
    • third_party/blink/renderer/modules/websockets/dom_websocket.cc
    • third_party/blink/renderer/modules/webusb/usb.cc
    • third_party/blink/renderer/modules/xr/xr.cc
    • third_party/blink/renderer/modules/xr/xr_session.cc
  5. Disable test

    Changed by gambardohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:32:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 965888f331e9a59219a4f8b223269348f0c5b176

    Comments

    Disable test
    
    This CL disables JavaScriptDialogTestCase/testShowJavaScriptAlert and
    PrintControllerTestCase/testPrintNormalPage as they are failing on
    iPad iOS 10 simulator for the multitasking test suite.
    
    Bug: 871685
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I0486941bdfcba501001e6c3e8e6e3ff0c997245a
    Reviewed-on: https://chromium-review.googlesource.com/1164944
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Commit-Queue: Eric Noyau <noyau@chromium.org>
    Reviewed-by: Eric Noyau <noyau@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581182}

    Changed files

    • ios/chrome/browser/ui/dialogs/javascript_dialog_egtest.mm
    • ios/chrome/browser/ui/print/print_controller_egtest.mm
  6. [Autofill wallet] Implement local changes for metadata sync

    Changed by jkrcalohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:38:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4b02e3f5ea2c17df05489c92da37e5521b074283

    Comments

    [Autofill wallet] Implement local changes for metadata sync
    
    This CL implements the following features in the wallet_metadata USS
    sync bridge:
     - caching current sync data and filling the cache on start,
     - informing the processor the bridge is ready to sync,
     - reacting to local single modifications of server profiles and cards
       (i.e. to updating the use stats when the address/card is used).
    
    Bug: 853688
    Change-Id: I07405e02cdf9cd0eb814179d883594253859845c
    Reviewed-on: https://chromium-review.googlesource.com/1151628
    Commit-Queue: Jan Krcal <jkrcal@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581183}

    Changed files

    • components/autofill/core/browser/webdata/autofill_table.cc
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge.h
    • components/autofill/core/browser/webdata/autofill_wallet_metadata_sync_bridge_unittest.cc
  7. Reland [blink] Add a time limit to message processing in MessagePort

    Changed by altiminohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:45:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a0c5484dfce884bf6ce702147399556faa84500e

    Comments

    Reland [blink] Add a time limit to message processing in MessagePort
    
    In addition to existing limit of 200 messages in a single task also
    limit it to 10 milliseconds to avoid starvation.
    
    This logic will be removed when message-per-task mojo dispatching
    will be implemented.
    
    BUG=867133
    R=mek@chromium.org
    
    Reviewed-on: https://chromium-review.googlesource.com/1152815
    Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
    Commit-Queue: Alexander Timin <altimin@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#579751}
    Change-Id: Idb757ddbc91c3e732e34e834bf8e00cc2292ddb5
    Reviewed-on: https://chromium-review.googlesource.com/1163782
    Cr-Commit-Position: refs/heads/master@{#581184}

    Changed files

    • third_party/blink/renderer/core/messaging/message_port.cc
    • third_party/blink/renderer/core/messaging/message_port.h
  8. [base] Generalize base::STLIsSorted()

    Changed by jdoerrieohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 09:23:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2fc218a1d3e6a54205e84508226a7d586f5c7ee7

    Comments

    [base] Generalize base::STLIsSorted()
    
    This change simplifies and generalizes base::STLIsSorted() by
    dispatching to std::is_sorted() and allowing C arrays as input
    containers by making use of std::begin() and std::end().
    
    Bug: NONE
    Change-Id: I6c29fb2aea508b10420a2703d96d5306a849444e
    Reviewed-on: https://chromium-review.googlesource.com/1160163
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581181}

    Changed files

    • base/stl_util.h
    • base/stl_util_unittest.cc
  9. [css-grid] Change how percentage row tracks and gaps are resolved

    Changed by regoohnoyoudont@igalia.com
    Changed at Tuesday, 07-Aug-18 10:03:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 47bfc59ccdda82e2b28817a653c792d7a606ee8e

    Comments

    [css-grid] Change how percentage row tracks and gaps are resolved
    
    The CSSWG decided to change how percentage row tracks and gutters
    in a grid container with indefinite height are resolved.
    
    The CSSWG issues are:
    * https://github.com/w3c/csswg-drafts/issues/1921
    * https://github.com/w3c/csswg-drafts/issues/509
    
    So far they were resolved as "auto", like it happens with
    percentage heights in regular blocks. But now they're going to behave
    similar to what happens in the columns axis, they would be ignore
    ...skip...
    AJ
    
    BUG=846187
    TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
    TEST=css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html
    TEST=css/css-grid/alignment/grid-content-alignment-second-pass-002.html
    
    Change-Id: I2a1959af6c95e0c47d294580599fdbf9bc432348
    Reviewed-on: https://chromium-review.googlesource.com/1142409
    Commit-Queue: Manuel Rego <rego@igalia.com>
    Reviewed-by: Sergio Villar <svillar@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#581185}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-002-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-002.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.html
    • third_party/WebKit/LayoutTests/external/wpt/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-container-percentage-rows.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-gutters-as-percentage.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/positioned-grid-container-percentage-tracks.html
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js
    • third_party/WebKit/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js
    • third_party/blink/renderer/core/layout/grid_track_sizing_algorithm.cc
    • third_party/blink/renderer/core/layout/grid_track_sizing_algorithm.h
    • third_party/blink/renderer/core/layout/layout_grid.cc
    • third_party/blink/renderer/core/layout/layout_grid.h
  10. Remove signin_error_notifier_ash unittest dependencies on SigninManager

    Changed by jdmuysohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 10:31:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8b44b279a8b14d3c7e6fdaac4b3caa19f2339bab

    Comments

    Remove signin_error_notifier_ash unittest dependencies on SigninManager
    
    This CL is part of the long-term goal of eliminating SigninManager as a
    public API for Chromium's identity code, replaced by IdentityManager.
    
    signin_error_notifer_ash_unittest builds a fake signin manager.
    This is not necessary: tests succeed without that.
    So removed creation of unused fake signin manager from tests.
    
    Bug: 797899
    Change-Id: I7bcfca18f2c94192e629385a7c481957387e7fec
    Reviewed-on: https://chromium-review.googlesource.com/1158685
    Reviewed-by: David Roger <droger@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581190}

    Changed files

    • chrome/browser/signin/signin_error_notifier_ash_unittest.cc
  11. [Sync::USS] FIX DCHECK crash due missing parent id in uss_migrator.cc

    Changed by mamirohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 10:09:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a410f9f8aa0734e999b9bf8da0ecb3557779a2fe

    Comments

    [Sync::USS] FIX DCHECK crash due missing parent id in uss_migrator.cc
    
    This CL checks bookmark fields for validity/existence before parsing
    them when migrating from directory to USS architectures
    in uss_migrator.cc.
    
    The original problematic code has been introduced in:
    https://chromium-review.googlesource.com/c/chromium/src/+/1162226
    
    Bug: 516866,871671
    Change-Id: I843c62325f3e3ec37ce05783c999bdfd5f3542a0
    Reviewed-on: https://chromium-review.googlesource.com/1164946
    Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581186}

    Changed files

    • components/sync/engine_impl/uss_migrator.cc
  12. Add 4 manual tests blocking WPT import to NeverFixTests

    Changed by foolipohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 10:20:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8f01b514d22d3137e8c27bff6724fa3e49597ccd

    Comments

    Add 4 manual tests blocking WPT import to NeverFixTests
    
    TBR=markdittmer@chromium.org
    
    No-Try: true
    Change-Id: I7711071a625d3a98c06d09663541cd250e0b9839
    Reviewed-on: https://chromium-review.googlesource.com/1164951
    Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
    Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581187}

    Changed files

    • third_party/WebKit/LayoutTests/NeverFixTests
  13. [LayoutNG] Pass constraint space to inline children for min/max.

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 10:22:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 33a899d18dc38744bb224beade784ba4cd350e3e

    Comments

    [LayoutNG] Pass constraint space to inline children for min/max.
    
    Orthogonal flow root children are going to need to calculate an
    extrinsic constraint space. We already got this right for direct block
    children, but not for floated children of inline child nodes.
    
    Three tests start to pass, but I wrote a new test as well, that's more
    to the point (it used to fail a DCHECK, and then render incorrectly, if
    we bypassed that).
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7
    Reviewed-on: https://chromium-review.googlesource.com/1162175
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581188}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/external/wpt/css/css-sizing/orthogonal-writing-mode-float-in-inline.html
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.h
    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_node_test.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_layout_algorithm.cc
    • third_party/blink/renderer/core/layout/ng/ng_layout_input_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_layout_input_node.h
    • third_party/blink/renderer/core/layout/ng/ng_space_utils.cc
    • third_party/blink/renderer/core/layout/ng/ng_space_utils.h
  14. [LayoutNG] IsBlockLayoutRoot -> IsBlockFormattingContextRoot

    Changed by mstenshoohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 10:24:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 61120ebd81f72c62e12d42cd63b61608cde68f87

    Comments

    [LayoutNG] IsBlockLayoutRoot -> IsBlockFormattingContextRoot
    
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I4dcc14002fc786887ed5dbbe1523c4ba22af94df
    Reviewed-on: https://chromium-review.googlesource.com/1163518
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581189}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_inline_fragment_traversal.cc
    • third_party/blink/renderer/core/layout/ng/inline/ng_physical_line_box_fragment.cc
    • third_party/blink/renderer/core/layout/ng/ng_block_node.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_box_fragment_test.cc
    • third_party/blink/renderer/core/layout/ng/ng_physical_fragment.h
    • third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment.cc
    • third_party/blink/renderer/core/paint/ng/ng_paint_fragment_traversal.cc
  15. Revert "Fix flaky webrequest related network service tests in component builds"

    Changed by futharkohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 11:26:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1c472ffdfc0d6ba628f08e08c4558246f98c6bd3

    Comments

    Revert "Fix flaky webrequest related network service tests in component builds"
    
    This reverts commit 30d8a3b9d66558f01b026c11ffe7db2bbda6fc1e.
    
    Reason for revert: Made SetIconAPITest.Overview test flaky (871720)
    
    Original change's description:
    > Fix flaky webrequest related network service tests in component builds
    > 
    > These tests needed some extra synchronization due to the changes made in
    > http://crrev.com/c/1139048. These were flaking in component builds.
    > 
    > Bug: 871224
    > Change-Id: Ibe370f9b9c
    ...skip...
    uvall@chromium.org>
    > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#580980}
    
    TBR=jam@chromium.org,cduvall@chromium.org
    
    Change-Id: If7bb80ef219f5aa5107ffd012981839dfaceac76
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 871224, 871720
    Reviewed-on: https://chromium-review.googlesource.com/1165122
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581195}

    Changed files

    • chrome/browser/extensions/api/declarative/declarative_apitest.cc
    • chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc
    • chrome/browser/extensions/api/declarative_content/set_icon_apitest.cc
    • chrome/browser/extensions/api/web_request/web_request_apitest.cc
    • chrome/browser/extensions/background_xhr_browsertest.cc
  16. Move macro to util file (storage/browser)

    Changed by oscarjohnoyoudont@opera.com
    Changed at Tuesday, 07-Aug-18 10:42:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 357dd5c59e89288f15c461aa29a251991da41861

    Comments

    Move macro to util file (storage/browser)
    
    When building using jumbo, files gets merged
    together and macros with the same name may
    end up in the same namspace and conflict. This
    happens for the macro UMA_HISTOGRAM_MBYTES.
    
    This commit solves the issue by moving
    the macro to a shared util file.
    
    Bug: 871163
    Change-Id: If3af541913a6add55ce739eb43f5a747cf4afd9a
    Reviewed-on: https://chromium-review.googlesource.com/1163602
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Oscar Johansson <oscarj@opera.com>
    Cr-Commit-Position: refs/heads/master@{#581192}

    Changed files

    • storage/browser/BUILD.gn
    • storage/browser/quota/quota_macros.h
    • storage/browser/quota/quota_manager.cc
    • storage/browser/quota/quota_settings.cc
    • storage/browser/quota/quota_temporary_storage_evictor.cc
  17. [LayoutNG] Remove/update stale flag-specific expectations

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 11:10:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 501f89508dc73ac4b0529c820f7577da9a685a85

    Comments

    [LayoutNG] Remove/update stale flag-specific expectations
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16f3f57a2389c3d48573817fb5e96a30a825e85a
    Reviewed-on: https://chromium-review.googlesource.com/1164867
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581193}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/css/transform-inline-style-remove-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/events/mouseclick-target-and-positioning-expected.txt
    • third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=LayoutNG/fast/inline/drawStyledEmptyInlinesWithWS-expected.png
  18. ProfileSyncService: shut down immediately on unrecoverable errors

    Changed by treibohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 11:44:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8e46ab3705be5a80c52fe568735f8488184a4b78

    Comments

    ProfileSyncService: shut down immediately on unrecoverable errors
    
    Previously, we'd post a task to perform the shutdown. This meant that
    there was a brief period where the unrecoverable error was already set,
    but Sync was still active, which made things hard to reason about.
    This CL removes the task-posting and instead just directly calls
    OnUnrecoverableErrorImpl (which calls ShutdownImpl), which doesn't seem
    to have any ill effects.
    
    Bug: 839834
    Change-Id: I998488332c531e817ffcd19e44df0e1273d091a5
    Reviewed-on: https://chromium-review.googlesource.com/1163707
    Commit-Queue: Marc Treib <treib@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581196}

    Changed files

    • components/browser_sync/profile_sync_service.cc
    • components/browser_sync/profile_sync_service.h
  19. Disabled tests in chromeos dbg due to flakiness.

    Changed by futharkohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 11:17:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d8fb3e8fd6e0b637be8af0180d96527541e6b69e

    Comments

    Disabled tests in chromeos dbg due to flakiness.
    
    Only one of the subtests reported flaky, but didn't know how to disable
    them separately.
    
    TBR=noel@chromium.org
    
    Bug: 871684
    Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451
    Reviewed-on: https://chromium-review.googlesource.com/1164958
    Reviewed-by: Rune Lillesveen <futhark@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581194}

    Changed files

    • chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
  20. [OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS

    Changed by yhiranoohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 11:54:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 36751f43351cd1f624c92755b52ce9e8f2ae5fd3

    Comments

    [OOR-CORS] Mark outofblink-cors/.../navigation-timing.https.html as PASS
    
    This is a reland of
    https://crrev.com/e87203b986d8ee7a7a4c46a25d2fe464c1cd31a6. The result
    change is due to service worker servicification.
    
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Bug: 736308
    Change-Id: I24d926c13211d8a579640fc6a156c01a3eb725bb
    Reviewed-on: https://chromium-review.googlesource.com/1164971
    Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581197}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
    • third_party/WebKit/LayoutTests/virtual/outofblink-cors-ns/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
    • third_party/WebKit/LayoutTests/virtual/outofblink-cors/external/wpt/service-workers/service-worker/navigation-timing.https-expected.txt
  21. Don't show camera icon in guest mode

    Changed by shenghaoohnoyoudont@google.com
    Changed at Tuesday, 07-Aug-18 11:55:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d7c2fe50bd308e8179c000995cc2d1c996c3c699

    Comments

    Don't show camera icon in guest mode
    
    This CL hides camera icon of internal camera app in guest mode. Since
    extensions are not allowed in guest mode, users can't perform any
    actions after clicking on the camera icon.
    
    Bug: 866412
    Test: Tested on eve that there's no camera icon in guest mode.
    Change-Id: Idf7cc42a50087aeced3283eafd6372144281b570
    Reviewed-on: https://chromium-review.googlesource.com/1152147
    Reviewed-by: Tatiana Gornak <melandory@chromium.org>
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Sheng-hao Tsao <shenghao@google.com>
    Cr-Commit-Position: refs/heads/master@{#581198}

    Changed files

    • chrome/browser/sync/test/integration/single_client_app_list_sync_test.cc
    • chrome/browser/ui/app_list/app_context_menu_unittest.cc
    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.cc
    • chrome/browser/ui/app_list/internal_app/internal_app_metadata.h
    • chrome/browser/ui/app_list/internal_app/internal_app_model_builder.cc
    • chrome/browser/ui/app_list/internal_app/internal_app_model_builder_unittest.cc
    • chrome/browser/ui/app_list/search/app_search_provider.cc
    • chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
    • chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
  22. Enhance configuration of the NetworkService-owned NetLog

    Changed by mmenkeohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 12:18:11 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38662e2f560f921c48e642c2a06975cc2e39623d

    Comments

    Enhance configuration of the NetworkService-owned NetLog
    
    This CL moves code related to opening files out of the NetworkService
    (which will eventually be sandboxed), as well as factoring out some of
    the shared features of the NetLog subclasses, to make code deduplication
    easier.
    
    Implementations are provided for ChromeContentClient and
    ShellContentClient classes.
    
    Bug: 847961
    Change-Id: I0a332b4429a2f20cbb38ae1671b8df0fbee28ba1
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Reviewed-on: https://chromium-review.googlesource.com/1161470
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581201}

    Changed files

    • chrome/common/BUILD.gn
    • chrome/common/DEPS
    • chrome/common/chrome_content_client.cc
    • chrome/common/chrome_content_client.h
    • content/browser/network_service_instance.cc
    • content/public/common/content_client.cc
    • content/public/common/content_client.h
    • content/shell/common/shell_content_client.cc
    • content/shell/common/shell_content_client.h
    • services/network/mojo_net_log.cc
    • services/network/mojo_net_log.h
    • services/network/network_service.cc
    • services/network/network_service.h
    • services/network/network_service_unittest.cc
    • services/network/public/mojom/network_service.mojom
    • services/service_manager/public/cpp/service_test.cc
    • services/service_manager/public/cpp/service_test.h
  23. Roll src/third_party/catapult e19516b87bb1..3cb00fbd5681 (1 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Tuesday, 07-Aug-18 11:55:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e4a259ac77e8de18799c54cb1fcb6b00137af401

    Comments

    Roll src/third_party/catapult e19516b87bb1..3cb00fbd5681 (1 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/e19516b87bb1..3cb00fbd5681
    
    
    git log e19516b87bb1..3cb00fbd5681 --date=short --no-merges --format='%ad %ae %s'
    2018-08-07 anthonyalridge@google.com Create a scatter/dot plot for grouping data by label.
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@3cb00fbd5681
    
    The AutoRoll server is located here: https://catapult-roll.skia.org
    
    Documentation for the AutoRoller is he
    ...skip...
    u_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:866423
    TBR=sullivan@chromium.org
    
    Change-Id: I70309eb1cbc227ae86e0fb333aea97128d0c561b
    Reviewed-on: https://chromium-review.googlesource.com/1164448
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#581199}

    Changed files

    • DEPS
  24. scheduler: Replace default task runner usages at TimerTest

    Changed by hajimehoshiohnoyoudont@chromium.org
    Changed at Tuesday, 07-Aug-18 12:05:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 24987fbbb4290a39f72ca8d60484ab1352d99ebf

    Comments

    scheduler: Replace default task runner usages at TimerTest
    
    This is a part of efforts to forbid V8 execution on the default task
    runner of the main thread.
    
    Bug: 870606
    Change-Id: Ic4c8d968e3b07157d5092f54d617b2e69236fae2
    Reviewed-on: https://chromium-review.googlesource.com/1165002
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581200}

    Changed files

    • third_party/blink/renderer/platform/timer_test.cc