Home | Search
Login

Builder Android Nexus5X WebView Perf Build #2101

Results:

failed performance_webview_test_suite on Android device Nexus 5X

Trigger Info:

Got Revisionb51d325c2a6fdc8f7be04d394645da611dd8ccad

Execution:

Steps and Logfiles:

Show:
  1. ( 3 hrs 30 mins ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 1 ms ) setup_build
    setup_build
    running recipe: "chromium"
  6. ( 1 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  8. ( 6 secs ) remove .cipd
    remove .cipd
  9. ( 4 mins 2 secs ) bot_update
    bot_update
    [103GB/492GB used (20%)]
  10. ( 1 ms ) ensure_goma
    ensure_goma
  11. ( 1 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  12. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.13
  13. ( 40 secs ) gclient runhooks
    gclient runhooks
  14. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  15. ( 1 ms ) read test spec (chromium.perf.json)
    read test spec (chromium.perf.json)
    path: /b/c/b/Android_Nexus5X_WebView_Perf/src/testing/buildbot/chromium.perf.json
  16. ( 31 secs ) clean local files
    clean local files
  17. ( 1 ms ) tree truth steps
    tree truth steps
  18. ( 7 secs ) build directory
    build directory
  19. ( 2 mins 7 secs ) extract build
    extract build
  20. ( 1 ms ) find isolated tests
    find isolated tests
  21. ( 1 ms ) test_pre_run
    test_pre_run
  22. ( 22 secs ) test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 5X
    test_pre_run.[trigger] performance_webview_test_suite on Android device Nexus 5X
    Run on OS: 'Android'
  23. ( 3 hrs 21 mins ) performance_webview_test_suite on Android device Nexus 5X
    performance_webview_test_suite on Android device Nexus 5X
    Run on OS: 'Android'
    Max pending time: 0:01:15.175870 (shard #8)
    Max shard duration: 2:43:22.993160 (shard #14)
    Min shard duration: 0:05:34.840180 (shard #0)
    Total tests: 977
    * Passed: 878 (878 expected, 0 unexpected)
    * Skipped: 97 (97 expected, 0 unexpected)
    * Failed: 1 (0 expected, >>>1 unexpected<<<)
    * Flaky: 1 (0 expected, >>>1 unexpected<<<)
     
    Unexpected Failures:
    * loading.mobile/Dramaq_3g
     
    Unexpected Flakes:
    * loading.mobile/GoogleBrazil_3g
     
  24. ( 1 ms ) Upload to test-results [performance_webview_test_suite on Android device Nexus 5X]
    Upload to test-results [performance_webview_test_suite on Android device Nexus 5X]
  25. ( 1 ms ) Tests statistics
    Tests statistics
     
    Stats
    Total shards: 16
    Total runtime: 20:21:04.452775
     
  26. ( 1 ms ) test_report
    test_report
  27. ( 1 ms ) Failure reason
    Failure reason

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Nexus5X_WebView_Perf/2101/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Android_Nexus5X_WebView_Perf/2101" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
got_angle_revision "89ef177f94753a91d7ec12aa58a5b06df2c12f0f" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "b51d325c2a6fdc8f7be04d394645da611dd8ccad" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574411}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8dc93fc4fa1ec6d0501d982679ce93efc383d3b8" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.351@{#1}" Annotation(bot_update)
got_webrtc_revision "ef43aafcf5953845b71840e14c94942d60c541c1" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23896}" Annotation(bot_update)
swarm_hashes {"performance_webview_test_suite":"14697af95eb11e7c32e4f62ce3ca1eddd98a5237"} Annotation(find isolated tests)
build_data_dir "/b/rr/tmpYNqgED" Annotation(steps)
build_id "buildbot/chromium.perf/Android Nexus5X WebView Perf/2101" Annotation(steps)
builder_id "master.chromium.perf:Android Nexus5X WebView Perf" Annotation(steps)
blamelist ["aleventhal@chromium.org","amaralp@chromium.org","blink-w3c-test-autoroller@chromium.org","bsalomon@google.com","catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","chrisha@chromium.org","chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","cthomp@chromium.org","danakj@chromium.org","danyao@chromium.org","ddorwin@chromium.org","dmazzoni@chromium.org","dpapad@chromium.org","dpranke@chromium.org","drott@chromium.org","fsamuel@chromium.org","gangwu@chromium.org","hongchan@chromium.org","jamescook@chromium.org","jelson@chromium.org","jinsukkim@chromium.org","jonross@chromium.org","khorimoto@google.com","kojii@chromium.org","kristipark@chromium.org","liberato@chromium.org","lijiawei@chromium.org","lilyhoughton@chromium.org","marcin@mwiacek.com","mastiz@chromium.org","mlamouri@chromium.org","msw@chromium.org","nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","nburris@google.com","qingsi@google.com","qinmin@chromium.org","rsleevi@chromium.org","ryansturm@chromium.org","samans@chromium.org","siyua@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","sky@chromium.org","supertri@chromium.org","tbergquist@chromium.org","uwyiming@google.com","waffles@chromium.org","xiaochengh@chromium.org","yawano@chromium.org"] Build
branch "master" Build
buildnumber 2101 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531405425 Build
revision "b51d325c2a6fdc8f7be04d394645da611dd8ccad" Build
slavename "slave214-c1" BuildSlave
buildername "Android Nexus5X WebView Perf" Builder
git_revision "b51d325c2a6fdc8f7be04d394645da611dd8ccad" Change
parent_buildername "Android arm64 Compile Perf" ParentBuild
parent_buildnumber 26680 ParentBuild
parent_got_angle_revision "89ef177f94753a91d7ec12aa58a5b06df2c12f0f" ParentBuild
parent_got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" ParentBuild
parent_got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" ParentBuild
parent_got_revision "b51d325c2a6fdc8f7be04d394645da611dd8ccad" ParentBuild
parent_got_revision_cp "refs/heads/master@{#574411}" ParentBuild
parent_got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" ParentBuild
parent_got_v8_revision "8dc93fc4fa1ec6d0501d982679ce93efc383d3b8" ParentBuild
parent_got_v8_revision_cp "refs/heads/6.9.351@{#1}" ParentBuild
parent_got_webrtc_revision "ef43aafcf5953845b71840e14c94942d60c541c1" ParentBuild
parent_got_webrtc_revision_cp "refs/heads/master@{#23896}" ParentBuild
parent_mastername "chromium.perf" ParentBuild
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Android_Nexus5X_WebView_Perf" slave

Blamelist:

  1. (liberatoohnoyoudont@chromium.org)
  2. (danakjohnoyoudont@chromium.org)
  3. (chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  4. (mlamouriohnoyoudont@chromium.org)
  5. (dmazzoniohnoyoudont@chromium.org)
  6. (mastizohnoyoudont@chromium.org)
  7. (samansohnoyoudont@chromium.org)
  8. (wafflesohnoyoudont@chromium.org)
  9. (danyaoohnoyoudont@chromium.org)
  10. (bsalomonohnoyoudont@google.com)
  11. (rsleeviohnoyoudont@chromium.org)
  12. (skyohnoyoudont@chromium.org)
  13. (xiaochenghohnoyoudont@chromium.org)
  14. (danyaoohnoyoudont@chromium.org)
  15. (dpapadohnoyoudont@chromium.org)
  16. (lijiaweiohnoyoudont@chromium.org)
  17. (lilyhoughtonohnoyoudont@chromium.org)
  18. (qingsiohnoyoudont@google.com)
  19. (jonrossohnoyoudont@chromium.org)
  20. (siyuaohnoyoudont@chromium.org)
  21. (dprankeohnoyoudont@chromium.org)
  22. (jelsonohnoyoudont@chromium.org)
  23. (cthompohnoyoudont@chromium.org)
  24. (marcinohnoyoudont@mwiacek.com)
  25. (jamescookohnoyoudont@chromium.org)
  26. (tbergquistohnoyoudont@chromium.org)
  27. (uwyimingohnoyoudont@google.com)
  28. (gangwuohnoyoudont@chromium.org)
  29. (catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  30. (ddorwinohnoyoudont@chromium.org)
  31. (kojiiohnoyoudont@chromium.org)
  32. (danyaoohnoyoudont@chromium.org)
  33. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  34. (dprankeohnoyoudont@chromium.org)
  35. (ryansturmohnoyoudont@chromium.org)
  36. (supertriohnoyoudont@chromium.org)
  37. (amaralpohnoyoudont@chromium.org)
  38. (khorimotoohnoyoudont@google.com)
  39. (nburrisohnoyoudont@google.com)
  40. (chrishaohnoyoudont@chromium.org)
  41. (marcinohnoyoudont@mwiacek.com)
  42. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  43. (jinsukkimohnoyoudont@chromium.org)
  44. (qinminohnoyoudont@chromium.org)
  45. (hongchanohnoyoudont@chromium.org)
  46. (nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  47. (jamescookohnoyoudont@chromium.org)
  48. (kristiparkohnoyoudont@chromium.org)
  49. (mswohnoyoudont@chromium.org)
  50. (drottohnoyoudont@chromium.org)
  51. (fsamuelohnoyoudont@chromium.org)
  52. (aleventhalohnoyoudont@chromium.org)
  53. (yawanoohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 17:26:25 UTC
End Thursday, 12-Jul-18 20:56:55 UTC
Pending N/A
Execution 3 hrs 30 mins

All Changes:

  1. Don't make MCVD textures unrenderable.

    Changed by liberatoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c9a8cb21b0bd26037458b9ebe1d94a8b3204f1

    Comments

    Don't make MCVD textures unrenderable.
    
    Previously, we would make MCVD video frame textures unrenderable
    after the VideoFrame was destroyed and the sync token had cleared.
    This prevented the image from holding onto MediaCodec buffers
    unnecessarily, since the actual destruction of the texture might
    be delayed until the GL context was made current.
    
    However, it turns out that the sync token isn't always correct.
    If the VideoResourceUpdater is destroyed, then it immediately
    releases all VideoFrames with 
    ...skip...
     practice, it works.
    
    Bug: 858826
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ia09b00a68964e886a05acf19f3623b4c87c31115
    Reviewed-on: https://chromium-review.googlesource.com/1132115
    Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
    Commit-Queue: Frank Liberato <liberato@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574365}

    Changed files

    • media/gpu/android/codec_image.cc
    • media/gpu/android/codec_image.h
    • media/gpu/android/codec_image_group.cc
    • media/gpu/android/codec_image_group_unittest.cc
    • media/gpu/android/texture_pool.cc
    • media/gpu/android/texture_pool.h
    • media/gpu/android/texture_pool_unittest.cc
    • media/gpu/android/video_frame_factory_impl.cc
    • media/gpu/android/video_frame_factory_impl.h
  2. Fix the type of the end text selection handle

    Changed by danakjohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5469c6437a9600862ba63c6abcd30dbc87c8f02

    Comments

    Fix the type of the end text selection handle
    
    Due to copy paste mistakes, the end handle ended up being the same type
    as the start handle, but it should be the opposite type.
    
    R=chrishtr@chromium.org
    
    Bug: 862510
    Change-Id: I2e6609d1e4083ced5f92b563925ba8c8401964fa
    Reviewed-on: https://chromium-review.googlesource.com/1133681
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
    Commit-Queue: danakj <danakj@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574363}

    Changed files

    • third_party/blink/renderer/core/exported/web_view_test.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.cc
    • third_party/blink/renderer/core/frame/frame_test_helpers.h
    • third_party/blink/renderer/core/page/chrome_client_impl.cc
    • third_party/blink/renderer/core/page/chrome_client_impl_test.cc
    • third_party/blink/renderer/core/page/page_overlay_test.cc
    • third_party/blink/renderer/platform/BUILD.gn
    • third_party/blink/renderer/platform/testing/stub_graphics_layer_client.h
  3. Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)

    Changed by chromite-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:05:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f83ad3fa1e9af7b2a8d4a51863fc2abb0e121de

    Comments

    Roll src/third_party/chromite 0664f1210277..a3bc29bcacf3 (6 commits)
    
    https://chromium.googlesource.com/chromiumos/chromite.git/+log/0664f1210277..a3bc29bcacf3
    
    
    git log 0664f1210277..a3bc29bcacf3 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 vapier@chromium.org validation_pool: process private/draft CLs before filtering
    2018-07-11 dgarrett@google.com cbuildbot_launch: Pass --workspace to cbuildbot.
    2018-07-11 xixuan@chromium.org Skylab-launch: Remove hard-coded build for SkylabHWTestStage
    ...skip...
    ho should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=chrome-os-gardeners@chromium.org
    
    Change-Id: Ie16ad6bc99dfb42886e1eaad6e06bafe2cd7726d
    Reviewed-on: https://chromium-review.googlesource.com/1133864
    Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574360}

    Changed files

    • DEPS
  4. MediaButtonReceiver: log key code from event received in intent.

    Changed by mlamouriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:05:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c5680ed55a6960e03ec7aaaa13d52adab56d754

    Comments

    MediaButtonReceiver: log key code from event received in intent.
    
    Forgot to upload the change as part of https://chromium-review.googlesource.com/c/chromium/src/+/1133741
    
    Bug: None
    Change-Id: Icb1f99c0d45928840740abef161c513d661d01af
    Reviewed-on: https://chromium-review.googlesource.com/1134179
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574359}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaButtonReceiver.java
  5. Simple rename in BrowserAccessibilityCocoa.

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:09:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 72bfd2dc3d3fa59a925d66978ae2acffffd4dfc6

    Comments

    Simple rename in BrowserAccessibilityCocoa.
    
    The BrowserAccessibilityCocoa (Objective-C Object for macOS) often
    needs to ask its corresponding BrowserAccessibility (cross-platform
    C++ object). Rather than calling it browserAccessibility or
    browserAccessibility_, let's call it "owner".
    
    I'm open to other names, but this is pretty limited to this one
    file so anyone hacking on this file should figure it out
    pretty quickly.
    
    Bug: none
    Change-Id: I36a5503ff53196b0c1e17bd405307d5471f9bd06
    Reviewed-on: https://chromium-review.googlesource.com/1132142
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574361}

    Changed files

    • content/browser/accessibility/browser_accessibility_cocoa.h
    • content/browser/accessibility/browser_accessibility_cocoa.mm
    • content/browser/accessibility/browser_accessibility_mac_unittest.mm
    • content/browser/accessibility/browser_accessibility_manager_mac.mm
  6. Introduce BlockingModelTypeStore[Impl]

    Changed by mastizohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:12:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3cfab37a6906e7d897ad16e9260cf5818323f247

    Comments

    Introduce BlockingModelTypeStore[Impl]
    
    The class is analogous to the non-blocking ModelTypeStore, which exposes
    an asynchronous API.
    
    The new class is intended to be used by datatypes that don't need to
    live in the UI thread, and are instead fine to live in a background
    thread, namely a sequenced task runner enforced by
    BlockingModelTypeStore.
    
    Users must use that sequenced task runner, because the underlying
    (shared) LevelDB database lives there, and is not thread-safe.
    
    The result of this refactori
    ...skip...
    s in fact an improvement: there is now one extra hop between
    threads when reading metadata, which is also the reason why some
    tests need to be updated.
    
    TBR=markusheintz@chromium.org
    
    Bug: 861632
    Change-Id: I5db552adc42c48fc36da6378c1d7f61334f1f450
    Reviewed-on: https://chromium-review.googlesource.com/1129800
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574364}

    Changed files

    • components/consent_auditor/consent_sync_bridge_impl_unittest.cc
    • components/sync/BUILD.gn
    • components/sync/model/blocking_model_type_store.h
    • components/sync/model/model_type_store.cc
    • components/sync/model/model_type_store.h
    • components/sync/model/model_type_store_base.cc
    • components/sync/model/model_type_store_base.h
    • components/sync/model_impl/blocking_model_type_store_impl.cc
    • components/sync/model_impl/blocking_model_type_store_impl.h
    • components/sync/model_impl/model_type_store_backend.cc
    • components/sync/model_impl/model_type_store_backend.h
    • components/sync/model_impl/model_type_store_impl.cc
    • components/sync/model_impl/model_type_store_impl.h
    • components/sync/user_events/user_event_sync_bridge_unittest.cc
  7. Check DrawQuad is given a valid pointer to SharedQuadState

    Changed by samansohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:13:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af0b9e0ea205364f81579ede827a19acecfb6ee8

    Comments

    Check DrawQuad is given a valid pointer to SharedQuadState
    
    Bug: 852294
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
    Change-Id: Iea27ee973f337f833b31a8c18e002b2772f7bacb
    Reviewed-on: https://chromium-review.googlesource.com/1133579
    Reviewed-by: Fady Samuel <fsamuel@chromium.org>
    Commit-Queue: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574366}

    Changed files

    • components/viz/common/quads/draw_quad.cc
  8. Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."

    Changed by wafflesohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:15:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 76e9e78757733e56983b4b6c9ac5b13fdc21db8b

    Comments

    Reland "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    
    This reverts commit 560191224bcaf8390e0745a16bdf8975a1add6bf.
    
    Reason for revert: Patch still applies cleanly without prior change.
    
    Original change's description:
    > Revert "Add method "ConfirmSaveAutofillProfile" to AutofillClient."
    >
    > This reverts commit da5ab5f6853c93ea08fe428db7dd22abe62db7d7.
    >
    > Reason for revert: compile failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Cast%20Linux/55639
    >
    > Original chang
    ...skip...
    
    
    TBR=boliu@chromium.org,mathp@chromium.org,waffles@chromium.org,sebsg@chromium.org,mahmadi@chromium.org,jzw@chromium.org
    
    Change-Id: I6ed0526b444574a5e8419ea83a37e348dc97cd11
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/1134141
    Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
    Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574368}

    Changed files

    • android_webview/browser/aw_autofill_client.cc
    • android_webview/browser/aw_autofill_client.h
    • chrome/browser/ui/autofill/chrome_autofill_client.cc
    • chrome/browser/ui/autofill/chrome_autofill_client.h
    • components/autofill/core/browser/autofill_client.h
    • components/autofill/core/browser/autofill_merge_unittest.cc
    • components/autofill/core/browser/form_data_importer.cc
    • components/autofill/core/browser/form_data_importer.h
    • components/autofill/core/browser/form_data_importer_unittest.cc
    • components/autofill/core/browser/test_autofill_client.cc
    • components/autofill/core/browser/test_autofill_client.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h
    • ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.h
    • ios/web_view/internal/autofill/web_view_autofill_client_ios.mm
  9. [Nav Experiment] Add a wait after restore session.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:14:18 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcae87b0c7618e2fc61f78a073cf5589fe9679bd

    Comments

    [Nav Experiment] Add a wait after restore session.
    
    This fixes WebViewRestorableStateTest when WKBasedNavigationManger is
    enabled. A better approach would be to turn this test into a
    programmatic test so both navigation managers implementations are
    tested, but web::features symbols are not exposed in ios/web_view.
    
    Bug: 862714
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I19916a973b566fac32c8995bd199784f0c846a1e
    Reviewed-on: https://chromium-review.googlesource.com/1134046
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574367}

    Changed files

    • ios/web_view/test/web_view_restorable_state_inttest.mm
  10. Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."

    Changed by bsalomonohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:15:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 23370775c415c21f4de1c7d97dd5645fe2b7e818

    Comments

    Reland "Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest."
    
    This is a reland of 841c0dde5461c763fdd524c2078aafaf241444aa
    
    The updated change uses window.devicePixelRatio to determine the inset.
    It also accounts for the absolute position used by the "WithDivs"
    variations of this test. One additional device pixel of offset is used
    to make this pass on mac_chromium_rel_ng. This is probably necessary
    because either window.devicePixelRatio reports 1 incorrectly or the
    edge antialiasing c
    ...skip...
    efs/heads/master@{#573695}
    
    Bug: 847984
    Change-Id: Ie5e685e8d5e0afbcf4c54ea3186ee68d238464ba
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1132574
    Commit-Queue: Brian Salomon <bsalomon@google.com>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574369}

    Changed files

    • content/test/gpu/gpu_tests/screenshot_sync_integration_test.py
  11. Support disabling the remainder of the Symantec Legacy PKI

    Changed by rsleeviohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:16:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c671bf913c328f7788df5046dd7b81bee3e17a04

    Comments

    Support disabling the remainder of the Symantec Legacy PKI
    
    Introduce a base::Feature flag that controls how the
    remainder of the Symantec Legacy PKI - that is, certs
    issued on/after 2016-06-01 but before 2017-12-01 - are
    handled.
    
    Bug: 796230
    Change-Id: Iebe9976ace0dfcdfd02f844fdaf497cf67dde704
    Reviewed-on: https://chromium-review.googlesource.com/1134037
    Reviewed-by: David Benjamin <davidben@chromium.org>
    Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574370}

    Changed files

    • net/cert/cert_verify_proc.cc
    • net/cert/cert_verify_proc.h
    • net/cert/cert_verify_proc_unittest.cc
  12. chromeos: fix infinite loop in cursor lookup

    Changed by skyohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:17:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1d9f316a0ba47bb4be158db0de5edc596272dabe

    Comments

    chromeos: fix infinite loop in cursor lookup
    
    And remove a NOTREACHED that we're hitting. I will supply a test for this
    separate, as well as investgating removal of NOREACHED.
    
    BUG=855767
    TEST=none
    
    Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0
    Reviewed-on: https://chromium-review.googlesource.com/1134352
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574371}

    Changed files

    • services/ui/ws2/window_delegate_impl.cc
    • services/ui/ws2/window_delegate_impl.h
  13. Make bidi adjustment in auto-directioned paragraphs saner

    Changed by xiaochenghohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:11:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2b245c2e812b84d4e58b76dbc0fd6bb14b5d257e

    Comments

    Make bidi adjustment in auto-directioned paragraphs saner
    
    In bidi adjustment for legacy layout, there is a hack that stops any
    adjustment if current text box is in 'unicode-bidi: plaintext'. This
    is wrong if the auto-directioned paragraph still contains
    bidirectional text.
    
    Ideally, we should remove this hack, and check paragraph direction.
    However, we don't have a reliable way to do this in legacy layout.
    So this patch makes the hack slightly saner that, bidi adjustment
    shouldn't stop as long as we are at a bidi boundary, even if we are
    in 'unicode-bidi: plaintext'.
    
    Bug: 861559
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: Ie7e1f704b976adf28a5d143e8265a499af0d62e4
    Reviewed-on: https://chromium-review.googlesource.com/1132472
    Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
    Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574362}

    Changed files

    • third_party/blink/renderer/core/editing/inline_box_traversal.cc
    • third_party/blink/renderer/core/editing/selection_modifier_character_test.cc
  14. [Nav Experiment] Make WebStateImplTest parameterized.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:19:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00ee7c4ed5ad09f68465f8e73c89639217adfacf

    Comments

    [Nav Experiment] Make WebStateImplTest parameterized.
    
    This way both legacy and WK based navigation manager implementations are
    tested on trybots.
    
    Fixed incorrect test setup in ShowAndClearInterstitialWithNoCommittedItems.
    Disabled ShowAndClearInterstitialWithCommittedItem and
    ShowAndClearInterstitialWithoutChangingSslStatus because they require
    mocking out navigation state, which is not possible now.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id72d1c2837aba7c1ed53f4fd8623e8c286a4a0a2
    Reviewed-on: https://chromium-review.googlesource.com/1134086
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574372}

    Changed files

    • ios/web/web_state/web_state_impl_unittest.mm
  15. Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.

    Changed by dpapadohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:22:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6ab1508513baf70561ebe2289ca48030f3fca81a

    Comments

    Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.
    
    At r573968 the logic was modified to only look for the noSearch property for
    subpage wrappers. It should also look for the CSS attribute for the case where
    no-search is not part of a binding.
    
    Bug: 862517
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
    Reviewed-on: https://chromium-review.googlesource.com/1133683
    Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574374}

    Changed files

    • chrome/browser/resources/settings/search_settings.js
    • chrome/test/data/webui/settings/search_settings_test.js
  16. [Chromecast] Chromecast support for tap down gestures

    Changed by lijiaweiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:20:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06e3ca5865cd84108599d13d143b5f230cef145f

    Comments

    [Chromecast] Chromecast support for tap down gestures
    
    - TAP_DOWN is added to CastContentWindow::GestureType
    - The gesture detection is attached to the root window and handles
      tap down events. A new JS binding API: onTapDownHandler will be hosted on
      platform
    - HandleTapGesture: finger is released after pressed within tap timeout window
      HandleTapDownGesture: finger is pressed
    
    Bug: internal b/75979846
    Test: build manually and test whether both tap and tap down handler callback works
    Change-Id: Iaefa6df9c7a5284ba27964083fc056bf36cf480a
    Reviewed-on: https://chromium-review.googlesource.com/1115418
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Commit-Queue: Jiawei Li <lijiawei@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574373}

    Changed files

    • chromecast/browser/cast_content_window.h
    • chromecast/browser/cast_content_window_aura.cc
    • chromecast/browser/cast_content_window_aura.h
    • chromecast/browser/cast_gesture_dispatcher.cc
    • chromecast/browser/cast_gesture_dispatcher.h
    • chromecast/graphics/cast_gesture_handler.h
    • chromecast/graphics/cast_system_gesture_event_handler.cc
  17. Remove NetworkContextTest.PreconnectLessThanZero

    Changed by lilyhoughtonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:23:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fe8c7d594e193f0dbdf6e3b7c970e44bee9c5c5c

    Comments

    Remove NetworkContextTest.PreconnectLessThanZero
    
    This test is flaky on android bots, and given that its testing something that
    should be explicitly unsupported (passing a negative number to a uint parameter),
    I think it's worth removing for now.
    
    Bug: 862647
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I316cb2cc5979aefb7335f715bd1fd2655db097b3
    Reviewed-on: https://chromium-review.googlesource.com/1134206
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Lily Houghton <lilyhoughton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574375}

    Changed files

    • services/network/network_context_unittest.cc
  18. Add the target for overrides of metrics utilities in jingle_unittests.

    Changed by qingsiohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:24:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 50c4d834c41b8f1ae60ae80bc47d67a51dcb23bd

    Comments

    Add the target for overrides of metrics utilities in jingle_unittests.
    
    The target rtc_p2p from WebRTC, transitively depended on by
    jingle_unittests via the target webrtc_overrides, will soon depend on
    the implementation of RTC_HISTOGRAM_* macros in WebRTC.
    
    Bug: webrtc:9409
    Change-Id: I1f2bf0776d2f7c18c9585fb15d7251f8128ce175
    Reviewed-on: https://chromium-review.googlesource.com/1134183
    Commit-Queue: Qingsi Wang <qingsi@google.com>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574376}

    Changed files

    • jingle/BUILD.gn
  19. Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz

    Changed by jonrossohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:24:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 99b62af5a66207b0fe84080bdd23492471a9ba94

    Comments

    Disable SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest on Viz
    
    Apparently this test can still fail on Windows. So re-disabling it until it can be investigated further.
    
    TBR=fsamuel@chromium.org
    TEST=SitePerProcessBrowserTest.ViewBoundsInNestedFrameTest
    
    Bug: 848825
    Change-Id: I00828a10cfd5c8c111b30f61eb5d8acbf57da2ea
    Reviewed-on: https://chromium-review.googlesource.com/1133875
    Reviewed-by: Jonathan Ross <jonross@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574377}

    Changed files

    • testing/buildbot/filters/viz.android.content_browsertests.filter
    • testing/buildbot/filters/viz.content_browsertests.filter
  20. Add intermediate bubble UI for local card migration flow.

    Changed by siyuaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:25:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59f08db6b91e0572161cf98df942b70c3becc285

    Comments

    Add intermediate bubble UI for local card migration flow.
    
    This is the 1st CL adding new views. There will be three following CLs
    on Autofill Client change, unit-test and metrics, and cocoa implementation.
    
    For details, please refer to design doc go/ib-paradise.
    
    This project is to offer users an option to upload chrome local credit
    cards to Google Pay server. This bubble UI is the entry point of the entire
    flow. It should be anchored to a credit card icon in the location bar and
    be shown from it.
    
    Bu
    ...skip...
    81c23658185045a5aecda8a
    Reviewed-on: https://chromium-review.googlesource.com/1128569
    Commit-Queue: Siyu An <siyua@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Avi Drissman <avi@chromium.org>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574378}

    Changed files

    • chrome/app/chrome_command_ids.h
    • chrome/app/generated_resources.grd
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/autofill/local_card_migration_bubble.h
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
    • chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.h
    • chrome/browser/ui/browser_window.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.h
    • chrome/browser/ui/cocoa/browser_window_cocoa.mm
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
    • chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
    • chrome/browser/ui/location_bar/location_bar.h
    • chrome/browser/ui/view_ids.h
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.cc
    • chrome/browser/ui/views/autofill/local_card_migration_bubble_views.h
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.cc
    • chrome/browser/ui/views/autofill/local_card_migration_icon_view.h
    • chrome/browser/ui/views/frame/browser_view.cc
    • chrome/browser/ui/views/frame/browser_view.h
    • chrome/browser/ui/views/location_bar/location_bar_view.cc
    • chrome/browser/ui/views/location_bar/location_bar_view.h
    • chrome/test/base/test_browser_window.cc
    • chrome/test/base/test_browser_window.h
    • components/autofill/core/browser/ui/local_card_migration_bubble_controller.h
    • components/autofill_strings.grdp
  21. Reland "[sampling heap profiler] Support stack collection on Android"

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:26:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0a3c0496180f1a183b3ca8061440d3888ff0722a

    Comments

    Reland "[sampling heap profiler] Support stack collection on Android"
    
    This reverts commit db0cac4eafdcc6cbd13e19eacc3eba15c15bfa2c.
    
    Reason for revert: The revert didn't affect anything, so re-landing.
    
    Original change's description:
    > Revert "[sampling heap profiler] Support stack collection on Android"
    > 
    > This reverts commit 52601a565375e7e60fdee70568f5e85242b76441.
    > 
    > Reason for revert: Speculatively reverting to see if this is confusing crashpad on the Mac somehow. See crbug.com/862466.
    > 
    > 
    ...skip...
    nke@chromium.org>
    > Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574032}
    
    TBR=dpranke@chromium.org,alph@chromium.org,ssid@chromium.org
    
    Change-Id: I41392b0836e75c25ae6b0b9aa243daeef95b6ee7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 803276
    Reviewed-on: https://chromium-review.googlesource.com/1134142
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574379}

    Changed files

    • base/sampling_heap_profiler/sampling_heap_profiler.cc
    • base/sampling_heap_profiler/sampling_heap_profiler.h
  22. Allow optimization hints to be marked as experimental.

    Changed by jelsonohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:28:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c8940b1c9de6fb2951013a8d2bb78770e62598b7

    Comments

    Allow optimization hints to be marked as experimental.
    
    Experimental hints are tagged (in the Optimization proto) with an
    experiment name. Experimental hints are not enabled unless an
    experiment with a matching name is enabled. Experiments are enabled by
    turning on the new base::Feature called kOptimizationHintsExperiments,
    with the name of the experiment in a parameter called experiment_name.
    
    Bug: 831817
    Change-Id: I6141c70f8f3a8f9adb2c9772b747ee2a0c59b227
    Reviewed-on: https://chromium-review.googlesource.com/1132491
    Commit-Queue: Jeremy Elson <jelson@chromium.org>
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574380}

    Changed files

    • components/optimization_guide/proto/hints.proto
    • components/previews/content/previews_hints.cc
    • components/previews/content/previews_optimization_guide_unittest.cc
    • components/previews/core/previews_features.cc
    • components/previews/core/previews_features.h
  23. Add metrics tracking how long Page Info is open

    Changed by cthompohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:29:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c4e06c2d21cc9a69f0a2a871a873b30c12b8fee

    Comments

    Add metrics tracking how long Page Info is open
    
    Per a suggestion of martinshelton@, this adds a new set of histograms to
    track how long users have the Page Info bubble open. This will help us
    better understand users who open Page Info but take no actions in it
    (e.g., are these opens likely to be more accidental or incidental).
    
    This metric is split by the security level of the page to allow us to
    see differences between different security indicators. Two sub-histograms
    ("Action" and "NoAction") further split up the metric by whether the user
    performed an action in the Page Info bubble before closing it (including
    actions that cause the bubble to close).
    
    Bug: 859116
    Change-Id: I630a1f37ecff13bc7ee44b3e8e5a5c34337c9267
    Reviewed-on: https://chromium-review.googlesource.com/1096336
    Commit-Queue: Christopher Thompson <cthomp@chromium.org>
    Reviewed-by: Steven Holte <holte@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574381}

    Changed files

    • chrome/browser/ui/page_info/page_info.cc
    • chrome/browser/ui/page_info/page_info.h
    • chrome/browser/ui/page_info/page_info_unittest.cc
    • tools/metrics/histograms/histograms.xml
  24. @IntDef cleanup in browser/java/appmenu

    Changed by marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 22:34:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5d0c1419ced881ae3321b7c6e3f23bbcacde473a

    Comments

    @IntDef cleanup in browser/java/appmenu
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and relat
    ...skip...
     about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: Ie6b59c0f1a8ec6fe50d3177619f0768798f97508
    Reviewed-on: https://chromium-review.googlesource.com/1128092
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574382}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuDragHelper.java
  25. Fix crash in shortcut viewer with ChromeVox enabled

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:38:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f74145f76fd3c4d8c1b4d024f34cf24189350d2

    Comments

    Fix crash in shortcut viewer with ChromeVox enabled
    
    Views can trigger accessibility events during Widget construction
    before the AXRemoteHost starts monitoring the widget. This happens
    with the material design focus ring on text fields.
    
    Bug: 862759
    Test: added to views_mus_unittests
    Change-Id: Ib7de6aa1d09b17fb65ad350abd362ad26b0454ae
    Reviewed-on: https://chromium-review.googlesource.com/1134353
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574383}

    Changed files

    • ui/views/mus/ax_remote_host.cc
    • ui/views/mus/ax_remote_host_unittest.cc
  26. Bandaid detached tabs at 150% scale

    Changed by tbergquistohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c18d19908d8817f4057df5e50afc966d92a25701

    Comments

    Bandaid detached tabs at 150% scale
    
    At some dpi scales (150% for example), the tabs are drawn detached from
    the toolbar, with a stark one-pixel gap between the tabs and the
    toolbar.
    
    This CL draws one extra dip's worth of tab below the bottom of the tab,
    which is occluded by the toolbar at integral scales and fills the gap
    on non-integral scales.
    
    
    Bug: 848106
    Change-Id: Ib465e8886c49613916bf3f3faff5fc43f36dfb18
    Reviewed-on: https://chromium-review.googlesource.com/1121386
    Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574384}

    Changed files

    • chrome/browser/ui/layout_constants.cc
    • chrome/browser/ui/layout_constants.h
    • chrome/browser/ui/views/frame/browser_non_client_frame_view_unittest.cc
    • chrome/browser/ui/views/frame/browser_view_layout.cc
    • chrome/browser/ui/views/frame/browser_view_unittest.cc
    • chrome/browser/ui/views/tabs/new_tab_button.cc
    • chrome/browser/ui/views/tabs/tab.cc
  27. Introducing improvements for the Action Recorder Extension.

    Changed by uwyimingohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 22:41:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 856e676d5e063bce97d01d06311b517f6b9e108c

    Comments

    Introducing improvements for the Action Recorder Extension.
    
    1. Improved the xpath generator. The generator will produce even more concise xpaths. This improvement helps to make test recipes readable to humans.
    2. Changed the way the extension queries for an iframe's context. Prior to this change, the extension would construct a path from the iframe to the top level frame by making a query at each ancestor frame node. However, InProcessBrowserTest does not need a path to go from the top level frame to
    ...skip...
    e extension uses keyboard events to detect when a user types inside a field, eliminating the false positive.
    6. Began implementing new features to capture Chrome Password Manager actions.
    
    Bug: 855284
    Change-Id: Ic7ff3af95cdc9f308c3ad061a3506fced150b4f8
    Reviewed-on: https://chromium-review.googlesource.com/1132540
    Commit-Queue: Yiming Zhou <uwyiming@google.com>
    Reviewed-by: Jared Saul <jsaul@google.com>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574385}

    Changed files

    • components/test/data/autofill/automated_integration/action_recorder_extension/background/background.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/constants.js
    • components/test/data/autofill/automated_integration/action_recorder_extension/content/action_handler.js
  28. [Feed] Feed Storage Initialization

    Changed by gangwuohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:44:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 74b454af56f3e14b18880854866b9b0d0b1f2a13

    Comments

    [Feed] Feed Storage Initialization
    
    Implement feed storage initialization in C++.
    
    Bug:828938
    
    Change-Id: I33a5a9e2e7dd20c36ec945feab6ea9932e9d94a2
    Reviewed-on: https://chromium-review.googlesource.com/1121834
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Commit-Queue: Gang Wu <gangwu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574386}

    Changed files

    • chrome/browser/android/feed/feed_host_service_factory.cc
    • components/feed/core/feed_host_service.cc
    • components/feed/core/feed_host_service.h
    • components/feed/core/feed_storage_database.cc
    • components/feed/core/feed_storage_database.h
  29. Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)

    Changed by catapult-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:44:29 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 720dadbc215c229ce100bc408edb3aee03b0697e

    Comments

    Roll src/third_party/catapult 5c0d851abe6e..1af68170e543 (2 commits)
    
    https://chromium.googlesource.com/catapult.git/+log/5c0d851abe6e..1af68170e543
    
    
    git log 5c0d851abe6e..1af68170e543 --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 simonhatch@chromium.org Dashboard - Use oauth scopes for /add_histograms
    2018-07-11 simonhatch@chromium.org Dashboard - Add some timing around /add_histograms
    
    
    Created with:
      gclient setdep -r src/third_party/catapult@1af68170e543
    
    The AutoRoll server is locat
    ...skip...
    .chromium.try:win_optional_gpu_tests_rel
    
    BUG=chromium:862730,chromium:862666
    TBR=sullivan@chromium.org
    
    Change-Id: If4b4e810ef8ae28ad68c15848c6aebe5ccc3fb56
    Reviewed-on: https://chromium-review.googlesource.com/1133869
    Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574387}

    Changed files

    • DEPS
  30. Update XR (VR & AR) OWNERS files

    Changed by ddorwinohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:49:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bcd11ade1174730bcc35ee5f8d71960c5a6a4794

    Comments

    Update XR (VR & AR) OWNERS files
    
    Switch COMPONENT to new structure, update and alphabetize owners, and
    add missing fields.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:closure_compilation;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I5141932b33a41d3aeaad1cc053623f12422e277e
    Reviewed-on: https://chromium-review.googlesource.com/1121097
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: Ian Vollick <vollick@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: David Dorwin <ddorwin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574388}

    Changed files

    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VR_JAVA_OWNERS
    • chrome/browser/android/vr/OWNERS
    • chrome/browser/android/vr/arcore_device/OWNERS
    • chrome/browser/resources/vr/OWNERS
    • chrome/browser/vr/OWNERS
    • chrome/browser/vr/service/OWNERS
    • chrome/browser/vr/vector_icons/OWNERS
    • chrome/test/data/vr/OWNERS
    • chrome/test/vr/OWNERS
    • device/vr/OWNERS
    • device/vr/oculus/OWNERS
    • device/vr/openvr/OWNERS
    • device/vr/public/mojom/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webvr/OWNERS
    • third_party/WebKit/LayoutTests/external/wpt/webxr/OWNERS
    • third_party/arcore-android-sdk/OWNERS
    • third_party/blink/renderer/modules/vr/OWNERS
    • third_party/blink/renderer/modules/xr/OWNERS
    • third_party/gvr-android-keyboard/OWNERS
    • third_party/gvr-android-keyboard/com/google/vr/keyboard/OWNERS
    • third_party/gvr-android-sdk/OWNERS
    • third_party/libovr/OWNERS
    • third_party/openvr/OWNERS
    • tools/perf/contrib/vr_benchmarks/OWNERS
  31. [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:50:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 65d0489cb43a7d17f1668f9178506e7a446b9a3d

    Comments

    [LayoutNG] Rename ShapingLineBreaker::kStartShouldBeSafe to kDontReshapeStart
    
    The naming turned out to be confusing.
    
    Bug: 636993
    Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
    Change-Id: I16fb06f080caac6ef9356edb187fe8032ef8f9ef
    Reviewed-on: https://chromium-review.googlesource.com/1133098
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Commit-Queue: Emil A Eklund <eae@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574389}

    Changed files

    • third_party/blink/renderer/core/layout/ng/inline/ng_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.cc
    • third_party/blink/renderer/platform/fonts/shaping/shaping_line_breaker.h
  32. [Nav Experiment] Parameterize crw_web_controller_unittest.mm.

    Changed by danyaoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:53:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d6a9497984526d151d178bfe8ec9dd1b1c84597c

    Comments

    [Nav Experiment] Parameterize crw_web_controller_unittest.mm.
    
    This is so that both LegacyNavigationManagerImpl and
    WKBasedNavigationManagerImpl can be tested on trybots.
    
    Also fixed broken test setup for
    ScriptExecutionTest.UserScriptOnAppSpecificPage and
    CRWWebControllerTest.AbortNativeUrlNavigation.
    
    Bug: 862718
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic343aafa9d1db545086fbeb001c5c9dd6253eb52
    Reviewed-on: https://chromium-review.googlesource.com/1134406
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Danyao Wang <danyao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574390}

    Changed files

    • ios/web/web_state/ui/crw_web_controller_unittest.mm
  33. Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 22:56:08 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 896be1d3c7326aed2e680ed495a82e5997e5de13

    Comments

    Roll src/third_party/skia 4ec72f7cc745..80247e594d1f (33 commits)
    
    https://skia.googlesource.com/skia.git/+log/4ec72f7cc745..80247e594d1f
    
    
    git log 4ec72f7cc745..80247e594d1f --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 caryclark@skia.org Publish docs for rrect, picture, blendmode
    2018-07-11 bungeman@google.com Make CR and trailing whitespace errors.
    2018-07-11 bsalomon@google.com Reland "Make GPU cache invalidation SkMessageBus messages go to one GrContext."
    2018-07-11 bungeman@google.co
    ...skip...
    ci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=robertphillips@chromium.org
    
    Change-Id: Ief888bfc0922b84d752987ea5ec56c4369912b14
    Reviewed-on: https://chromium-review.googlesource.com/1133871
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574391}

    Changed files

    • DEPS
  34. Revert "Reland "Fix OOPIF hit testing in layout tests.""

    Changed by dprankeohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 22:57:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 08abdaa4ff32eca88a28ab84f7da1075819c311b

    Comments

    Revert "Reland "Fix OOPIF hit testing in layout tests.""
    
    This reverts commit 3dcee047ec982d521d9ad5301e00ac1bba134f01.
    
    Reason for revert: Suspect this is causing more flaky failures, see e.g.: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/10567 and build 10568
    
    Original change's description:
    > Reland "Fix OOPIF hit testing in layout tests."
    > 
    > This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    > 
    > Original change's description:
    > > Fix OOPIF hit testing
    ...skip...
    Tapuska <dtapuska@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574304}
    
    TBR=kenrb@chromium.org,dtapuska@chromium.org
    
    Change-Id: I9fec8992b35943f8dd2d8ce6bafe8ac9feb49411
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 601584
    Reviewed-on: https://chromium-review.googlesource.com/1134143
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Commit-Queue: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574392}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  35. Moving Offline Previews triggering to be pre-computed

    Changed by ryansturmohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:02:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3154b813745fb84c61dabf48dc7e75cf5d1973f9

    Comments

    Moving Offline Previews triggering to be pre-computed
    
    As part of moving previews to an earlier decision point, this CL moves
    the triggering of offline previews to be consistent with other preview
    types.
    
    Follow-up Cls will move this decision point earlier on the UI thread so
    the new offline page implementation will also be able to use it. The
    temporary dependency on PreviewsUserData will also not be needed once
    the offline tab helper is accessible (the impl is on the UI thread).
    
    Bug: 842233
    Change-Id: If2969a109434270659dcf723b39a7627bb8c8ecd
    Reviewed-on: https://chromium-review.googlesource.com/1128332
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Jian Li <jianli@chromium.org>
    Reviewed-by: Tarun Bansal <tbansal@chromium.org>
    Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574393}

    Changed files

    • chrome/browser/offline_pages/offline_page_request_handler_unittest.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.cc
    • chrome/browser/offline_pages/offline_page_request_interceptor.h
    • chrome/browser/offline_pages/offline_page_request_job.cc
    • chrome/browser/offline_pages/offline_page_request_job.h
    • chrome/browser/previews/previews_infobar_tab_helper.cc
    • chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
    • chrome/browser/profiles/profile_impl_io_data.cc
    • components/previews/content/previews_content_util.cc
    • components/previews/content/previews_content_util_unittest.cc
    • components/previews/core/previews_user_data.h
    • content/public/common/previews_state.h
    • third_party/blink/public/platform/web_url_request.h
  36. Fix broken link in Histograms documentation.

    Changed by supertriohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:03:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 38d84f451bba258746bb4ac1ee10a3cfa441997a

    Comments

    Fix broken link in Histograms documentation.
    
    Change-Id: Ie1fb9b26d0c4b5e4d767033cf50143e3b4612a3f
    Reviewed-on: https://chromium-review.googlesource.com/1134422
    Reviewed-by: Ilya Sherman <isherman@chromium.org>
    Commit-Queue: Caitlin Sadowski <supertri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574394}

    Changed files

    • tools/metrics/histograms/README.md
  37. Call generic isShowingAppMenuUpdateBadge

    Changed by amaralpohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:08:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ffcab75a3f1d5700c92c854ca48465fa08420cbc

    Comments

    Call generic isShowingAppMenuUpdateBadge
    
    ChromeActivity should call ToolbarManager's isShowingAppMenuUpdateBadge
    so that bottom toolbar has a chance to handle it.
    
    Change-Id: I3ffdd69896ef4e3180328c33d5a5a69d21c5fdc4
    Reviewed-on: https://chromium-review.googlesource.com/1132601
    Reviewed-by: Theresa <twellington@chromium.org>
    Commit-Queue: Pedro Amaral <amaralp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574395}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
  38. [CrOS MultiDevice] Tweak an EasyUnlock string description.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:09:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6d93874c2172b2c280b99e15fad1269c658a25fa

    Comments

    [CrOS MultiDevice] Tweak an EasyUnlock string description.
    
    This fix was suggested by our UX writer jonann@ in b/111006044.
    
    Bug: 824568
    Change-Id: If888000ed030b0dd90436729c77cb861a59305f9
    Reviewed-on: https://chromium-review.googlesource.com/1133710
    Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574396}

    Changed files

    • chrome/app/settings_strings.grdp
  39. Chrome Cleaner UI: Update list of items to be removed to list extensions

    Changed by nburrisohnoyoudont@google.com
    Changed at Wednesday, 11-Jul-18 23:13:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ff991fb5cf3ff872e2096ac735376369aaed5d87

    Comments

    Chrome Cleaner UI: Update list of items to be removed to list extensions
    
    - Also add tests for displaying extensions, refactoring tests to a loop
    instead of writing all possible combinations like before.
    
    Bug: 853339
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I5a02771b339751e44df4ceb1bb6f58a7796968b4
    Reviewed-on: https://chromium-review.googlesource.com/1127180
    Commit-Queue: Nick Burris <nburris@google.com>
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Reviewed-by: proberge <proberge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574397}

    Changed files

    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.html
    • chrome/browser/resources/settings/chrome_cleanup_page/chrome_cleanup_page.js
    • chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
    • chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
    • chrome/test/data/webui/settings/chrome_cleanup_page_test.js
  40. Make URLDataSource backend reference a WeakPtr.

    Changed by chrishaohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:13:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bed9bc8ab47755b9be2032dc398af2060bc94ede

    Comments

    Make URLDataSource backend reference a WeakPtr.
    
    This allows URLDataSources that have been detached from a backend to
    still refer to the backend if it still exists, allowing any pending
    queries that were issued to that backend and routed to the data source
    to resolve back to the backend when they are finished.
    
    BUG=859193
    
    Change-Id: I55eda45be1f24716ad31c7d98ee748a737baca51
    Reviewed-on: https://chromium-review.googlesource.com/1131537
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Chris Hamilton <chrisha@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574398}

    Changed files

    • content/browser/webui/url_data_manager_backend.cc
    • content/browser/webui/url_data_manager_backend.h
    • content/browser/webui/url_data_source_impl.h
  41. @IntDef cleanup in chrome/java/externalauth

    Changed by marcinohnoyoudont@mwiacek.com
    Changed at Wednesday, 11-Jul-18 23:14:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d82ee0010741390a1a6a63bbcc68d95e4b5341b2

    Comments

    @IntDef cleanup in chrome/java/externalauth
    
    @IntDef/@StringDef annotation are preferred way for declaring
    set of String/int values:
    
    1. they need less space in APK than enum, see
    https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
    2. they give more control over allowed values than "static final" values
    
    Main goal of patch is writing "static final" values, enum
    and some classes in one common @IntDef/@StringDef form:
    
    1. with @IntDef/@StringDef first, @Retention second
       and r
    ...skip...
     about numbering from 0 without gaps when necessary
    5. with @Retention(RetentionPolicy.SOURCE)
    6. without "static final" in the @interface
    
    Additionally there are done some other trivial cleanups.
    
    Change-Id: I8285733bbecf695b133a3865310f9a3cf0c515d6
    Reviewed-on: https://chromium-review.googlesource.com/1133983
    Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
    Commit-Queue: Theresa <twellington@chromium.org>
    Reviewed-by: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574399}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/externalauth/VerifiedHandler.java
  42. Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:22:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a94a2187dbcbeca3eab3361df5877f3af0345dd1

    Comments

    Import wpt@828cbf6461e1b36ff5ff02310cb7d6749125b57c
    
    Using wpt-import in Chromium 4df7c6c40ebef72484655dc54db5c40e9f8c2bc2.
    With Chromium commits locally applied on WPT:
    a9045946af "Add a fail-fast for longtask layouttests"
    
    
    Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21178
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectatio
    ...skip...
    glesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    Directory owners for changes in this CL:
    domenic@chromium.org, ricea@chromium.org:
      external/wpt/streams
    
    TBR=foolip
    
    No-Export: true
    Change-Id: I084c2429c7bc00f6d54eb830a34bcccb62e45c3b
    Reviewed-on: https://chromium-review.googlesource.com/1134081
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574400}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.js
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker.https-expected.txt
    • third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.sharedworker-expected.txt
  43. Android: consolidate support components for embedders

    Changed by jinsukkimohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:23:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 351a925fcc3c0a950711126c9f4dab65cbee1ed9

    Comments

    Android: consolidate support components for embedders
    
    Moves web_contents_delegate_android under embedder_support to
    consolidate all the support components for embedders. The package path
    is org.chromium.embedder_support.delegate. Now the component
    has 4 main targets for embedders:
     - media
     - view
     - content_view
     - web_contents_delegate
    
    Note:
    
    - The choice of 'delegate' in the package name of WebContentsDelegateAndroid
      is just to avoid having WCDA repeated in the path. (import org.chromium
      .emb
    ...skip...
    me-internal-review.googlesource.com/c/clank/internal/apps/+/646448
    
    
    Change-Id: I44c25435c32330439ffa765d80df45b02d0694b1
    Reviewed-on: https://chromium-review.googlesource.com/1118926
    Reviewed-by: Bo <boliu@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
    Reviewed-by: Cait Phillips <caitkp@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574401}

    Changed files

    • android_webview/BUILD.gn
    • android_webview/browser/DEPS
    • android_webview/browser/aw_web_contents_delegate.h
    • android_webview/java/DEPS
    • android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java
    • android_webview/test/BUILD.gn
    • build/android/lint/suppressions.xml
    • chrome/android/BUILD.gn
    • chrome/android/java/DEPS
    • chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/DocumentWebContentsDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabDelegateFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java
    • chrome/browser/BUILD.gn
    • chrome/browser/android/DEPS
    • chrome/browser/android/bottombar/overlay_panel_content.cc
    • chrome/browser/android/document/document_web_contents_delegate.cc
    • chrome/browser/android/document/document_web_contents_delegate.h
    • chrome/browser/android/tab_web_contents_delegate_android.h
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/android/color_chooser_dialog_android.cc
    • chrome/test/android/BUILD.gn
    • components/OWNERS
    • components/embedder_support/android/BUILD.gn
    • components/embedder_support/android/delegate/DEPS
    • components/embedder_support/android/delegate/OWNERS
    • components/embedder_support/android/delegate/color_chooser_android.cc
    • components/embedder_support/android/delegate/color_chooser_android.h
    • components/embedder_support/android/delegate/web_contents_delegate_android.cc
    • components/embedder_support/android/delegate/web_contents_delegate_android.h
    • components/embedder_support/android/java/res/drawable-hdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-mdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable-xhdpi/color_picker_advanced_select_handle.png
    • components/embedder_support/android/java/res/drawable/color_button_background.xml
    • components/embedder_support/android/java/res/drawable/color_picker_border.xml
    • components/embedder_support/android/java/res/layout/color_picker_advanced_component.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_content.xml
    • components/embedder_support/android/java/res/layout/color_picker_dialog_title.xml
    • components/embedder_support/android/java/res/values/colors.xml
    • components/embedder_support/android/java/res/values/dimens.xml
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorChooserAndroid.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvanced.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerAdvancedComponent.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerDialog.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerMoreButton.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorPickerSimple.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestion.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/ColorSuggestionListAdapter.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/DEPS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OWNERS
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/OnColorChangedListener.java
    • components/embedder_support/android/java/src/org/chromium/components/embedder_support/delegate/WebContentsDelegateAndroid.java
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_am.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ar.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_bg.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ca.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_cs.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_da.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_de.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_el.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_en-GB.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es-419.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_es.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fa.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fil.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_fr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_hu.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_id.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_it.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_iw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ja.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ko.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lt.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_lv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_nl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_no.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-BR.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_pt-PT.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ro.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_ru.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sl.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sv.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_sw.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_th.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_tr.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_uk.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_vi.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-CN.xtb
    • components/embedder_support/android/java/strings/translations/web_contents_delegate_android_strings_zh-TW.xtb
    • components/embedder_support/android/java/strings/web_contents_delegate_android_strings.grd
    • components/web_contents_delegate_android/BUILD.gn
    • docs/chromoting_android_hacking.md
    • tools/android/eclipse/.classpath
    • tools/gritsettings/resource_ids
    • tools/gritsettings/translation_expectations.pyl
  44. Don't remove ref-count on download IO TaskRunner

    Changed by qinminohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 871b0dbb66c85679e88df8f62fd4ec0e3f471594

    Comments

    Don't remove ref-count on download IO TaskRunner
    
    There is no need to remove the IO TaskRunner reference.
    The global io thread task_runner is never deleted.
    If io TaskRunner is set, just ignore future calls.
    
    BUG=842245
    
    Change-Id: Ifefad6442d8efde238379218e9f11a9f3d99a75a
    Reviewed-on: https://chromium-review.googlesource.com/1134197
    Reviewed-by: Min Qin <qinmin@chromium.org>
    Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574402}

    Changed files

    • components/download/internal/common/download_task_runner.cc
    • content/browser/download/download_manager_impl.cc
  45. Reorg DefaultAudioDestinationNode

    Changed by hongchanohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:30:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4247ad3b2fda13e8f4d57b68b639bea7d78df02

    Comments

    Reorg DefaultAudioDestinationNode
    
    No renaming or functional change. Just moving and grouping things
    around. Plus, some clarification/simplification of comments.
    
    Bug: 854229
    Change-Id: I1a4fd3cdaf7fd41fd6c30fc199f281b46b061dc2
    Reviewed-on: https://chromium-review.googlesource.com/1133715
    Commit-Queue: Hongchan Choi <hongchan@chromium.org>
    Reviewed-by: Raymond Toy <rtoy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574403}

    Changed files

    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.cc
    • third_party/blink/renderer/modules/webaudio/default_audio_destination_node.h
  46. Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)

    Changed by nacl-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 11-Jul-18 23:32:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 382c1d7689514b2bb3449f2ca14209ad5e75c472

    Comments

    Roll src/native_client 0ba35b21089a..e6ce828ef60c (1 commits)
    
    https://chromium.googlesource.com/native_client/src/native_client.git/+log/0ba35b21089a..e6ce828ef60c
    
    
    git log 0ba35b21089a..e6ce828ef60c --date=short --no-merges --format='%ad %ae %s'
    2018-07-11 thomasanderson@chromium.org Revert "Trigger a buildbot cycle on client.nacl.toolchain"
    
    
    Created with:
      gclient setdep -r src/native_client@e6ce828ef60c
    
    The AutoRoll server is located here: https://nacl-roll.skia.org
    
    Documentation for the Auto
    ...skip...
    eriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    
    BUG=chromium:None
    TBR=mseaborn@chromium.org
    
    Change-Id: I96d892a8a5520b5394bf8929daf655f2ab9f95e9
    Reviewed-on: https://chromium-review.googlesource.com/1133873
    Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574404}

    Changed files

    • DEPS
  47. Clean up MASH_DEPRECATED in FlagWarningTray and test

    Changed by jamescookohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:17 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0795efc4ba54976c1ea978ec4c1fafe49e3ed77a

    Comments

    Clean up MASH_DEPRECATED in FlagWarningTray and test
    
    We don't run ash_unittests with --enable-features=Mash anymore, so
    manually turn on the flag to test the feature.
    
    Bug: 840391
    Test: ash_unittests
    Change-Id: Idb61128d9a65cbc6e93095683247c3e8cd714a9d
    Reviewed-on: https://chromium-review.googlesource.com/1134418
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574405}

    Changed files

    • ash/system/flag_warning/flag_warning_tray.cc
    • ash/system/flag_warning/flag_warning_tray_unittest.cc
  48. [NTP] Remove transition duration for MV tile hover states

    Changed by kristiparkohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:36:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c37fbfabcaaeabb50bbbf52dfa75c6fa7491e298

    Comments

    [NTP] Remove transition duration for MV tile hover states
    
    Bug: 851656
    Cq-Include-Trybots: luci.chromium.try:closure_compilation
    Change-Id: I4fc218b0dba1b0dd569088a1665792b933c86ada
    Reviewed-on: https://chromium-review.googlesource.com/1133686
    Commit-Queue: Kristi Park <kristipark@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574406}

    Changed files

    • chrome/browser/resources/local_ntp/most_visited_single.css
  49. Remove extra spaces in WindowTree logs

    Changed by mswohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:31 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 59774f864d141afa5605ddba9ad153899c4dc295

    Comments

    Remove extra spaces in WindowTree logs
    
    Makes the debug logging output more consistent
    
    Bug: None
    Test: None
    Change-Id: Ib6ca05df6e06c7bbb31ffca7c027707af7d67966
    Reviewed-on: https://chromium-review.googlesource.com/1134428
    Commit-Queue: Scott Violet <sky@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574408}

    Changed files

    • services/ui/ws2/window_tree.cc
  50. Roll HarfBuzz to 1.8.3

    Changed by drottohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:37:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d5684ce09c352eb8ca64390c1fdb5f3de5e6bf60

    Comments

    Roll HarfBuzz to 1.8.3
    
    https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz/+log/058708a665cdd9e796581dbcf60a5778d3f5e240..2b76767bf572364d3d647cdd139f2044a7ad06b2
    
    And disable HB_VECTOR_SIZE define now that HarfBuzz has temporarily
    completed disabled compiler-assisted vectorisation.
    
    Bug: 860250, 862607
    Change-Id: If00101a279b23f5807a85973718183b33647195d
    Reviewed-on: https://chromium-review.googlesource.com/1133384
    Reviewed-by: Ben Wagner <bungeman@chromium.org>
    Commit-Queue: Dominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574407}

    Changed files

    • DEPS
    • third_party/harfbuzz-ng/BUILD.gn
    • third_party/harfbuzz-ng/README.chromium
  51. Surface Synchronization: Make Submission Flow Trace Less Noisy

    Changed by fsamuelohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:38:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 852c66f84007b6c5ee4eb6150ec2534d5797b5b4

    Comments

    Surface Synchronization: Make Submission Flow Trace Less Noisy
    
    Only log an event if the LocalSurfaceId has changed instead of on
    every submit and receipt of CompositorFrames.
    
    Bug: 672962
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I4814ec0aaa9c204864d5c5df0c4a359d4ef3bb28
    Reviewed-on: https://chromium-review.googlesource.com/1134027
    Commit-Queue: Fady Samuel <fsamuel@chromium.org>
    Reviewed-by: Saman Sami <samans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574409}

    Changed files

    • cc/mojo_embedder/async_layer_tree_frame_sink.cc
    • cc/trees/layer_tree_host.cc
    • components/viz/common/surfaces/parent_local_surface_id_allocator.cc
    • components/viz/service/frame_sinks/compositor_frame_sink_support.cc
    • components/viz/service/surfaces/surface.cc
  52. No removed or inserted text events on static text nodes

    Changed by aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0d103e4761986c5f14e7b904ddf0b143fb1b6799

    Comments

    No removed or inserted text events on static text nodes
    
    Fire only 1 set of text removed/inserted events,
    only on the parent hypertext (not on the static text).
    This helps avoid redundant live region change announcements.
    
    Bug: 778478
    Change-Id: Ic68aab54d46c98576169ecb2146cd6414413e6ac
    Reviewed-on: https://chromium-review.googlesource.com/1134199
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574410}

    Changed files

    • content/test/data/accessibility/event/live-region-change-expected-win.txt
    • content/test/data/accessibility/event/text-changed-expected-win.txt
    • ui/accessibility/platform/ax_platform_node_win.cc
  53. Use three way flag for ChromeVox arc support

    Changed by yawanoohnoyoudont@chromium.org
    Changed at Wednesday, 11-Jul-18 23:45:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b51d325c2a6fdc8f7be04d394645da611dd8ccad

    Comments

    Use three way flag for ChromeVox arc support
    
    - Use three way flag for ChromeVox arc support. This allows developers
      to easily switch between TalkBack on arc and ChromeVox arc support.
    - This CL also changes default to disabled (TalkBack on arc).
    
    Bug: 855310
    Test: None
    Change-Id: I301657798247da20eaf9ad734987b8d40790af1d
    Reviewed-on: https://chromium-review.googlesource.com/1130963
    Commit-Queue: Yuki Awano <yawano@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574411}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.h
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chromeos/chromeos_features.cc
    • chromeos/chromeos_features.h
    • chromeos/chromeos_switches.cc
    • chromeos/chromeos_switches.h
    • tools/metrics/histograms/enums.xml