Builder Android Nexus5 Perf Build #2007
Results:
build successful
Trigger Info:
| Got Revision | 8fc8ad7e2561f48248fee640b72a808f1592634a |
Execution:
- Source: chromium.perf/Android Nexus5 Perf/2007
- Bot: slave209-c1
Steps and Logfiles:
Show:-
( 1 ms ) read test spec (chromium.perf.json)read test spec (chromium.perf.json)path: /b/c/b/Android_Nexus5_Perf/src/testing/buildbot/chromium.perf.json
-
( 13 secs ) test_pre_run.[trigger] angle_perftests on Android device Nexus 5test_pre_run.[trigger] angle_perftests on Android device Nexus 5Run on OS: 'Android'
-
( 1 ms ) test_pre_run.[trigger] components_perftests on Android device Nexus 5test_pre_run.[trigger] components_perftests on Android device Nexus 5Run on OS: 'Android'
-
( 1 ms ) test_pre_run.[trigger] gpu_perftests on Android device Nexus 5test_pre_run.[trigger] gpu_perftests on Android device Nexus 5Run on OS: 'Android'
-
( 24 secs ) test_pre_run.[trigger] performance_test_suite on Android device Nexus 5test_pre_run.[trigger] performance_test_suite on Android device Nexus 5Run on OS: 'Android'
-
( 2 ms ) test_pre_run.[trigger] tracing_perftests on Android device Nexus 5test_pre_run.[trigger] tracing_perftests on Android device Nexus 5Run on OS: 'Android'
-
( 4 mins 14 secs ) angle_perftests on Android device Nexus 5angle_perftests on Android device Nexus 5Run on OS: 'Android'Pending time: 48sShard duration: 0:03:42.311720Total tests: n/a
-
( 1 mins 45 secs ) components_perftests on Android device Nexus 5components_perftests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:04:58.870280Shard duration: 0:01:18.458880Total tests: n/a
-
( 1 mins 40 secs ) gpu_perftests on Android device Nexus 5gpu_perftests on Android device Nexus 5Run on OS: 'Android'Pending time: 0:06:46.606680Shard duration: 0:01:12.387030Total tests: n/a
-
( 2 hrs 42 mins ) performance_test_suite on Android device Nexus 5performance_test_suite on Android device Nexus 5Run on OS: 'Android'Max pending time: 0:08:22.416080 (shard #0)Max shard duration: 2:17:48.320400 (shard #9)Min shard duration: 0:57:04.498960 (shard #7)Total tests: 1119* Passed: 1021 (1021 expected, 0 unexpected)* Skipped: 98 (98 expected, 0 unexpected)* Failed: 0 (0 expected, 0 unexpected)* Flaky: 0 (0 expected, 0 unexpected)
- stdout
- json.output
- swarming.summary
- Merge script log
- outdir_json
- step_metadata
- Benchmarks logs
- Benchmarks shard map
- Results Dashboard
- shard #0 (3960.1 sec)
- shard #0 isolated out
- shard #1 (3932.5 sec)
- shard #1 isolated out
- shard #10 (5117.7 sec)
- shard #10 isolated out
- shard #11 (4428.3 sec)
- shard #11 isolated out
- shard #12 (4903.2 sec)
- shard #12 isolated out
- shard #13 (3896.3 sec)
- shard #13 isolated out
- shard #14 (3562.6 sec)
- shard #14 isolated out
- shard #15 (4292.4 sec)
- shard #15 isolated out
- shard #2 (4134.3 sec)
- shard #2 isolated out
- shard #3 (4139.4 sec)
- shard #3 isolated out
- shard #4 (4210.5 sec)
- shard #4 isolated out
- shard #5 (5638.5 sec)
- shard #5 isolated out
- shard #6 (5368.5 sec)
- shard #6 isolated out
- shard #7 (3391.1 sec)
- shard #7 isolated out
- shard #8 (3888.0 sec)
- shard #8 isolated out
- shard #9 (8156.5 sec)
- shard #9 isolated out
-
( 1 ms ) Upload to test-results [performance_test_suite on Android device Nexus 5]Upload to test-results [performance_test_suite on Android device Nexus 5]
-
( 3 ms ) tracing_perftests on Android device Nexus 5tracing_perftests on Android device Nexus 5Run on OS: 'Android'Pending time: 1:15:45.388030Shard duration: 46sTotal tests: n/a
Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/runtime | {"is_experimental":false,"is_luci":false} | Annotation(LUCI Migration) |
| luci_migration | {"status":"ok"} | Annotation(LUCI Migration) |
| log_location | "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Nexus5_Perf/2007/+/recipes/annotations" | Annotation(LogDog Bootstrap) |
| logdog_prefix | "bb/chromium.perf/Android_Nexus5_Perf/2007" | Annotation(LogDog Bootstrap) |
| logdog_project | "chrome" | Annotation(LogDog Bootstrap) |
| got_angle_revision | "5598148b761380773c4e650b5b67f47553b0f090" | Annotation(bot_update) |
| got_buildtools_revision | "0dd5c6f980d22be96b728155249df2da355989d9" | Annotation(bot_update) |
| got_nacl_revision | "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" | Annotation(bot_update) |
| got_revision | "8fc8ad7e2561f48248fee640b72a808f1592634a" | Annotation(bot_update) |
| got_revision_cp | "refs/heads/master@{#574518}" | Annotation(bot_update) |
| got_swarming_client_revision | "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" | Annotation(bot_update) |
| got_v8_revision | "8b17db68f75a95d69debfa85b70aea3ec0766aaf" | Annotation(bot_update) |
| got_v8_revision_cp | "refs/heads/6.9.352@{#1}" | Annotation(bot_update) |
| got_webrtc_revision | "5795489e83adba65cb480d57e71f52bae1f5ee1b" | Annotation(bot_update) |
| got_webrtc_revision_cp | "refs/heads/master@{#23944}" | Annotation(bot_update) |
| swarm_hashes | {"angle_perftests":"b6556c45485bb1ed3252f4c8ef23a1f5884a6523","components_perftests":"55d926c0eb602566e565b782f0a1b25a40d36a24","gpu_perftests":"e78cee5e598741d344464688f3df7fe0601b1acf","media_perftests":"6402ef76c59ca4869c402588e162a60c90031ad2","performance_test_suite":"76a129b05e541fed7d719efd98696edea35dd68a","performance_webview_test_suite":"c9b255b0f0511fc5be31a581ebb8595dc35cb0a8","tracing_perftests":"720067020423e9e864646b143e470f97ed0d1c35"} | Annotation(find isolated tests) |
| build_data_dir | "/b/rr/tmp_o6XSn" | Annotation(steps) |
| build_id | "buildbot/chromium.perf/Android Nexus5 Perf/2007" | Annotation(steps) |
| builder_id | "master.chromium.perf:Android Nexus5 Perf" | Annotation(steps) |
| blamelist | ["alancutter@chromium.org","atotic@chromium.org","awdf@chromium.org","blundell@chromium.org","depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","falken@chromium.org","fane@google.com","guidou@chromium.org","leon.han@intel.com","lucmult@chromium.org","mkwst@chromium.org","peria@chromium.org","rajendrant@chromium.org","raphael.kubo.da.costa@intel.com","shimazu@chromium.org","tangltom@chromium.org","treib@chromium.org","yoshiki@chromium.org"] | Build |
| branch | "master" | Build |
| buildnumber | 2007 | Build |
| project | "src" | Build |
| repository | "https://chromium.googlesource.com/chromium/src" | Build |
| requestedAt | 1531379369 | Build |
| revision | "8fc8ad7e2561f48248fee640b72a808f1592634a" | Build |
| slavename | "slave209-c1" | BuildSlave |
| buildername | "Android Nexus5 Perf" | Builder |
| git_revision | "8fc8ad7e2561f48248fee640b72a808f1592634a" | Change |
| parent_buildername | "Android Compile Perf" | ParentBuild |
| parent_buildnumber | 26786 | ParentBuild |
| parent_got_angle_revision | "5598148b761380773c4e650b5b67f47553b0f090" | ParentBuild |
| parent_got_buildtools_revision | "0dd5c6f980d22be96b728155249df2da355989d9" | ParentBuild |
| parent_got_nacl_revision | "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" | ParentBuild |
| parent_got_revision | "8fc8ad7e2561f48248fee640b72a808f1592634a" | ParentBuild |
| parent_got_revision_cp | "refs/heads/master@{#574518}" | ParentBuild |
| parent_got_swarming_client_revision | "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" | ParentBuild |
| parent_got_v8_revision | "8b17db68f75a95d69debfa85b70aea3ec0766aaf" | ParentBuild |
| parent_got_v8_revision_cp | "refs/heads/6.9.352@{#1}" | ParentBuild |
| parent_got_webrtc_revision | "5795489e83adba65cb480d57e71f52bae1f5ee1b" | ParentBuild |
| parent_got_webrtc_revision_cp | "refs/heads/master@{#23944}" | ParentBuild |
| parent_mastername | "chromium.perf" | ParentBuild |
| buildbotURL | "http://build.chromium.org/p/chromium.perf/" | master.cfg |
| mastername | "chromium.perf" | master.cfg |
| workdir | "/b/build/slave/Android_Nexus5_Perf" | slave |
Blamelist:
- (treibohnoyoudont@chromium.org)
- (alancutterohnoyoudont@chromium.org)
- (lucmultohnoyoudont@chromium.org)
- (periaohnoyoudont@chromium.org)
- (awdfohnoyoudont@chromium.org)
- (shimazuohnoyoudont@chromium.org)
- (lucmultohnoyoudont@chromium.org)
- (atoticohnoyoudont@chromium.org)
- (rajendrantohnoyoudont@chromium.org)
- (falkenohnoyoudont@chromium.org)
- (raphael.kubo.da.costaohnoyoudont@intel.com)
- (blundellohnoyoudont@chromium.org)
- (guidouohnoyoudont@chromium.org)
- (yoshikiohnoyoudont@chromium.org)
- (falkenohnoyoudont@chromium.org)
- (mkwstohnoyoudont@chromium.org)
- (tangltomohnoyoudont@chromium.org)
- (depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
- (leon.hanohnoyoudont@intel.com)
- (faneohnoyoudont@google.com)
- (mkwstohnoyoudont@chromium.org)
Timing:
| Create | N/A |
| Start | Thursday, 12-Jul-18 10:15:26 UTC |
| End | Thursday, 12-Jul-18 13:14:59 UTC |
| Pending | N/A |
| Execution | 2 hrs 59 mins |
All Changes:
-
Replace ThreadChecker by SequenceChecker in /components/sync*
Changed by treibohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 06:54:48 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision fc8a763a002339d6a7821e3c69d45ad8642dafc1 Comments
Replace ThreadChecker by SequenceChecker in /components/sync* https://crrev.com/c/1131474 removed the unnecessary thread-affinity, this one adjusts the checks accordingly. Bug: 846238 Change-Id: If4e1145712fe99f4d8236d93e4f645e69c3e7655 Reviewed-on: https://chromium-review.googlesource.com/1131738 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#574498}
Changed files
- components/sync/driver/glue/sync_backend_host_core.cc
- components/sync/driver/glue/sync_backend_host_core.h
- components/sync/driver/glue/sync_backend_host_impl.cc
- components/sync/driver/glue/sync_backend_host_impl.h
- components/sync/driver/sync_service_crypto.cc
- components/sync/driver/sync_service_crypto.h
- components/sync/engine/sync_backend_registrar.cc
- components/sync/engine/sync_backend_registrar.h
- components/sync/engine_impl/debug_info_event_listener.cc
- components/sync/engine_impl/debug_info_event_listener.h
- components/sync/engine_impl/model_type_worker.cc
- components/sync/engine_impl/model_type_worker.h
- components/sync/engine_impl/net/server_connection_manager.cc
- components/sync/engine_impl/net/server_connection_manager.h
- components/sync/engine_impl/sync_manager_impl.cc
- components/sync/engine_impl/sync_manager_impl.h
- components/sync/engine_impl/sync_manager_impl_unittest.cc
- components/sync/test/engine/fake_model_worker.cc
- components/sync/test/engine/fake_model_worker.h
- components/sync_bookmarks/bookmark_change_processor.cc
- components/sync_bookmarks/bookmark_change_processor.h
-
Add find bar icon to hosted app windows
Changed by alancutterohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 07:03:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision e35f205a1441afebe9987e606c7c876d5bfc4594 Comments
Add find bar icon to hosted app windows This CL moves the find icon from LocationBarView into PageActionIconContainerView enabling the icon to appear in hosted app window title bars. This change also fixes the find icon getting nudged by crrev.com/108c0687254683b3beeaa32b6e0a86f2046a867e. Before 108c0687254683b3beeaa32b6e0a86f2046a867e: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346964&signed_aid=IuPvufZswamla90tWW5FCg==&inline=1 Before CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346965&signed_aid=Aiy5ATHUK4cWS64MyuRMdQ==&inline=1 After CL: https://bugs.chromium.org/p/chromium/issues/attachment?aid=346968&signed_aid=DR3vtzLR7tlPH3cEwibshQ==&inline=1 Bug: 788051, 814531 Change-Id: I5fa60cce484bd2553131582fc39e6737da34e967 Reviewed-on: https://chromium-review.googlesource.com/1054908 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574499}
Changed files
- chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
- chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
- chrome/browser/ui/find_bar/find_bar_controller.cc
- chrome/browser/ui/location_bar/location_bar.h
- chrome/browser/ui/page_action/page_action_icon_container.h
- chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
- chrome/browser/ui/views/frame/browser_view_layout.cc
- chrome/browser/ui/views/frame/hosted_app_button_container.cc
- chrome/browser/ui/views/frame/hosted_app_button_container.h
- chrome/browser/ui/views/frame/toolbar_button_provider.h
- chrome/browser/ui/views/location_bar/find_bar_icon.cc
- chrome/browser/ui/views/location_bar/find_bar_icon.h
- chrome/browser/ui/views/location_bar/location_bar_view.cc
- chrome/browser/ui/views/location_bar/location_bar_view.h
- chrome/browser/ui/views/page_action/page_action_icon_container_view.cc
- chrome/browser/ui/views/page_action/page_action_icon_container_view.h
- chrome/browser/ui/views/toolbar/toolbar_view.cc
- chrome/browser/ui/views/toolbar/toolbar_view.h
- chrome/test/base/test_browser_window.h
-
Change test to use full-path-for-testing attribute selector
Changed by lucmultohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 07:12:07 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 9a8460b3e49c7b9ee03dcf56af71a0d76c0f60e4 Comments
Change test to use full-path-for-testing attribute selector This makes this test compatible with directory tree having My Files or not, and makes the test more readable too. This is a preparation to enable new navigation (with My Files) by default. Bug: 857335 No-presubmit: true Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia35bc2cc7c91e0492f0158990bfc397a6b57da21 Reviewed-on: https://chromium-review.googlesource.com/1133610 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574500}
Changed files
- ui/file_manager/integration_tests/file_manager/context_menu.js
- ui/file_manager/integration_tests/file_manager/create_new_folder.js
- ui/file_manager/integration_tests/file_manager/folder_shortcuts.js
-
oilpan: Make ImageLoader::Task::script_state_ WeakPersistent
Changed by periaohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 07:41:46 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f59c5558bcae3a45e08edc99450f00242e5e7ce0 Comments
oilpan: Make ImageLoader::Task::script_state_ WeakPersistent ImageLoader::Task class does not actually own the script state, so its reference can be weak. This CL makes the reference weak. Bug: 773605 Change-Id: Ib5761227e6582a8519a9d10ffaa00226559ee3d6 Reviewed-on: https://chromium-review.googlesource.com/1134629 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#574501}
Changed files
- third_party/blink/renderer/core/loader/image_loader.cc
-
[Android PageInfo] Refactor PageInfoController to enable testing
Changed by awdfohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:05:32 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision dfb08c4ccef342639df17f6a423643df1784b767 Comments
[Android PageInfo] Refactor PageInfoController to enable testing - Extracted PermissionParamsListBuilder from PageInfoController to handle all the permission-related logic when displaying permissions in page info. This new class requires fewer hard-to-unit-test dependencies so its logic can now be tested. Bug: 691898 Change-Id: Iddbea30642a0dc31dae26110381e2dad9feb2af4 Reviewed-on: https://chromium-review.googlesource.com/1103564 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#574502}
Changed files
- chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
- chrome/android/java/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilder.java
- chrome/android/java/src/org/chromium/chrome/browser/page_info/SystemSettingsActivityRequiredListener.java
- chrome/android/java_sources.gni
- chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
-
NetS13nServiceWorker: Add more info to traces in SWNavigationLoader
Changed by shimazuohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:13:43 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 670a4fd7d5c89c8904f638edda72083e41e5d016 Comments
NetS13nServiceWorker: Add more info to traces in SWNavigationLoader Bug: 806658 Change-Id: Ie52bdfdd6f44354c42067f1c069996cc80b6df17 Reviewed-on: https://chromium-review.googlesource.com/1134711 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#574503}
Changed files
- content/browser/service_worker/service_worker_navigation_loader.cc
-
Add new methods to EntryList and tests
Changed by lucmultohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:27:24 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 76bc398de31290a2d97ee6b7ea804a55d1d5451d Comments
Add new methods to EntryList and tests Change the logic to add entries to My Files to account for volume being mounted/unmounted. This fixes some broken tests when running with the flag enabled by default, so test to cover this is on crrev.com/c/1131025. Fix test getMetadata function name. Bug: 857335 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id056b0e0d5c77a07c2561f6566bfc99111864917 Reviewed-on: https://chromium-review.googlesource.com/1133613 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574505}
Changed files
- ui/file_manager/file_manager/common/js/files_app_entry_types.js
- ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.html
- ui/file_manager/file_manager/common/js/files_app_entry_types_unittest.js
- ui/file_manager/file_manager/foreground/js/navigation_list_model.js
- ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
-
[LayoutNG] Fix static position for inline containing block
Changed by atoticohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:24:12 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f321a196a45bce7d32257d0b93b472dba89e205a Comments
[LayoutNG] Fix static position for inline containing block Bug: 740993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iacdfc2694b2522c06a2512000ed1ca7f043b7541 Reviewed-on: https://chromium-review.googlesource.com/1134386 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#574504}
Changed files
- third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
- third_party/blink/renderer/core/layout/ng/ng_out_of_flow_layout_part.cc
-
Use PLM for data saver site-breakdown
Changed by rajendrantohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:45:55 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 74f3e3d131a093053a5e5f737e162c99e1c69e62 Comments
Use PLM for data saver site-breakdown This CL adds PLM observer for site-breakdown that records the data use by host. The new codepath is enabled and the old data use asriber observer based site-breakdown codepath is disabled, based on a feature. Bug: 836029 Change-Id: I667d0dc6e0227c83a46d353b2feffaec9043a219 Reviewed-on: https://chromium-review.googlesource.com/1050868 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#574506}
Changed files
- chrome/browser/BUILD.gn
- chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.cc
- chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer.h
- chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc
- chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
- chrome/test/BUILD.gn
- components/data_reduction_proxy/core/browser/data_reduction_proxy_data_use_observer.cc
- components/data_reduction_proxy/core/common/data_reduction_proxy_features.cc
- components/data_reduction_proxy/core/common/data_reduction_proxy_features.h
- components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
- components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
-
Add service worker README.md.
Changed by falkenohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 08:46:41 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 75c9e38bcfe01f3a7c2637050ddcb2f342dd3034 Comments
Add service worker README.md. Bug: 795989 Change-Id: I1f90fa1f71f47fa3ba884814d932bffbc67a4a8d Reviewed-on: https://chromium-review.googlesource.com/1134718 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574507}
Changed files
- content/browser/service_worker/README.md
- content/common/service_worker/README.md
- third_party/blink/common/service_worker/README.md
- third_party/blink/public/common/service_worker/README.md
- third_party/blink/public/mojom/service_worker/README.md
- third_party/blink/public/platform/modules/service_worker/README.md
- third_party/blink/public/web/modules/service_worker/README.md
- third_party/blink/renderer/modules/service_worker/README.md
-
Revert "licenses.py: Skip another //tools/binary_size subdirectory."
Changed by raphael.kubo.da.costaohnoyoudont@intel.com Changed at Thursday, 12-Jul-18 09:19:39 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision cc3a2b34c667b8e2e0cde7766e9439e80fb72174 Comments
Revert "licenses.py: Skip another //tools/binary_size subdirectory." This reverts commit a6c69c8113a7113cc6b4a4f8de3291095d717e40. Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1080401 moved gvr-android-sdk into a directory we already skip, so this is no longer needed. Original change's description: > licenses.py: Skip another //tools/binary_size subdirectory. > > Commit 6a15a6c4 ("SuperSize: Teach it about thin archives") added a > third_party directory to tools/bin ...skip... costa@intel.com> > Cr-Commit-Position: refs/heads/master@{#564081} TBR=raphael.kubo.da.costa@intel.com,scottmg@chromium.org,ichikawa@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I8a85ee225f54a0499ee18e20311dfd5b9dc280fe Reviewed-on: https://chromium-review.googlesource.com/1133138 Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#574509}
Changed files
- tools/licenses.py
-
OAuth2LoginManager: Handle consecutive refresh token updates
Changed by blundellohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:20:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision c2f7998c5e85ffebc0c1f7588bcc45a73e1de4dc Comments
OAuth2LoginManager: Handle consecutive refresh token updates OAuth2LoginManager currently assumes that OAuth2TokenService::Observer::OnRefreshTokenAvailable() will never be called twice consecutively for the primary account; in particular, it calls VerifySessionCookies(), which DCHECKS that |oauth2_login_verifier_| is null before instantiating that ivar. However, this assumption is no longer valid. A simple example: - A refresh token is found during startup, resulting in OnRefreshTokenAvailable() ...skip... +/1126861, which is firing the "token available" notification as part of startup when adding an invalid token for the primary account and triggers the DCHECK above on ChromeOS browsertests. Those failures were how I discovered this issue. Change-Id: I55ced6fe49055c6c6c4d1e7ce138a0d080ecda38 Reviewed-on: https://chromium-review.googlesource.com/1127662 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#574511}
Changed files
- chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
-
Add AudioLogFactory mojo interface.
Changed by guidouohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:19:34 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ee6cfd00b7b35f8bc4ced3eecc801fa2f55a85ae Comments
Add AudioLogFactory mojo interface. This interface allows a mojo client to create audio logs on the browser process. This CL also removes content::MojoLogAudioAdapter, which is moved to the audio service as audio::LogAdapter in follow-up CL crrev.com/c/1128974 Bug: 812557 Change-Id: I70504a4878553f1a3c2d58a29c6ab960b6f15b39 Reviewed-on: https://chromium-review.googlesource.com/1128966 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#574508}
Changed files
- content/browser/BUILD.gn
- content/browser/media/audio_log_factory.cc
- content/browser/media/audio_log_factory.h
- content/browser/media/media_internals.cc
- content/browser/media/media_internals.h
- content/browser/media/mojo_audio_logging_adapter.cc
- content/browser/media/mojo_audio_logging_adapter.h
- media/mojo/interfaces/audio_logging.mojom
-
Cancel long-press operation if the gesture is scrolling
Changed by yoshikiohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:21:50 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d417866204188b709447dfb64ba68740a182b7a5 Comments
Cancel long-press operation if the gesture is scrolling This CL adds the code to cancel the long-press operation which shows inline setting when the user stats the scrollingo Previously that was done in Android (ag/4340201) but it didn't work for vertical scroll since the scroll is handled on Chrome side. With this CL, scroll detection is done on Chrome side and the code handles correctly with vertical scrolls in addition to horizontal ones. Bug: b/111100376 Bug: 858938 Test: Manual (inline setting does't open during vertical scroll) Change-Id: I84407b331dc320e6acd3a776938104ad018d46a3 Reviewed-on: https://chromium-review.googlesource.com/1124263 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#574512}
Changed files
- ash/system/message_center/arc/arc_notification_content_view.cc
- ash/system/message_center/arc/arc_notification_item.h
- ash/system/message_center/arc/arc_notification_item_impl.cc
- ash/system/message_center/arc/arc_notification_item_impl.h
- ash/system/message_center/arc/arc_notification_manager.cc
- ash/system/message_center/arc/arc_notification_manager.h
- ash/system/message_center/arc/mock_arc_notification_item.h
- components/arc/common/notifications.mojom
- components/arc/test/fake_notifications_instance.cc
- components/arc/test/fake_notifications_instance.h
-
shared worker: Simplify the default network factory logic.
Changed by falkenohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:20:42 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision ab39b893750485f84d1f607be642fe1efdc27f7f Comments
shared worker: Simplify the default network factory logic. When NetworkService is off but S13nSW is on, shared worker jumped through hoops to get a factory bundle to the renderer. It was giving the renderer a NetworkService default factory and expecting the renderer to clear it. But we can just give a non-NetworkService direct network default factory, since that capability was added in r565058. Bug: 839982 Change-Id: Ie5c4f182b87526e2f15a7b2a8b62ed03f7e5595f Reviewed-on: https://chromium-review.googlesource.com/1134708 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#574510}
Changed files
- content/browser/shared_worker/shared_worker_host.cc
- content/renderer/shared_worker/embedded_shared_worker_stub.cc
-
Revert "Delete the media cache(s) when using a single combined HTTP cache."
Changed by mkwstohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:35:30 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision eb81f73d09c9efd4ff7eb181ce3ffe105d1549a8 Comments
Revert "Delete the media cache(s) when using a single combined HTTP cache." This reverts commit e226149af1b3f003b5d3f59e19ee17bef7419c42. Reason for revert: `ProfileWithoutMediaCacheBrowserTest.DeleteMediaCache` and `ProfileWithoutMediaCacheBrowserTest.DeleteIsolatedAppMediaCache` have been failing, apparently since they were added by this CL. They were added here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28016 (which failed to actually run `browser_test`) and ...skip... Orlovich <morlovich@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574296} TBR=mmenke@chromium.org,morlovich@chromium.org Change-Id: Ibc519750f00ad7e698d279af6baffe77b32d30be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789657, 862945 Reviewed-on: https://chromium-review.googlesource.com/1134886 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#574513}
Changed files
- chrome/browser/profiles/profile_browsertest.cc
- chrome/browser/profiles/profile_impl_io_data.cc
-
[unified-consent] Enable sync everything only when sync is active
Changed by tangltomohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:41:14 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision eef2c0be5716d8857f9ff7dce265e2569c8d333e Comments
[unified-consent] Enable sync everything only when sync is active UnifiedConsentService is observing changes of the sync service, so the sync data types are only enabled when sync is started up and active. Bug: 862139, 819909 Change-Id: I4c006e0c1cc7b263f113865da0c128620e1817ae Reviewed-on: https://chromium-review.googlesource.com/1131744 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#574515}
Changed files
- components/unified_consent/unified_consent_service.cc
- components/unified_consent/unified_consent_service.h
- components/unified_consent/unified_consent_service_unittest.cc
-
Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits)
Changed by depot-tools-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com Changed at Thursday, 12-Jul-18 09:40:04 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision f198a1c4c492486c961c0a112247ddac9a9e3379 Comments
Roll src/third_party/depot_tools 32e3d1e37cd6..2b138f742b74 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/32e3d1e37cd6..2b138f742b74 git log 32e3d1e37cd6..2b138f742b74 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 sdefresne@chromium.org Avoid creating an empty netrc file in $TEMP Created with: gclient setdep -r src/third_party/depot_tools@2b138f742b74 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation f ...skip... on the roll, and stop the roller if necessary. BUG=chromium:none TBR=agable@chromium.org Change-Id: I8e88cdcad6399e9a7b117a2fe36dc264a6e61c78 Reviewed-on: https://chromium-review.googlesource.com/1134149 Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574514}
Changed files
- DEPS
-
[ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo
Changed by leon.hanohnoyoudont@intel.com Changed at Thursday, 12-Jul-18 09:45:56 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision d00d598cb4ae00510a30326c3db46f9b0506e36d Comments
[ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo This CL removes native struct ServiceWorkerProviderHostInfo and the corresponding typemapping for it, instead, directly uses mojom struct ServiceWorkerProviderHostInfo everywhere. BUG=789854 Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62 Reviewed-on: https://chromium-review.googlesource.com/1132847 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#574516}
Changed files
- content/browser/service_worker/service_worker_dispatcher_host.cc
- content/browser/service_worker/service_worker_dispatcher_host.h
- content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
- content/browser/service_worker/service_worker_object_host_unittest.cc
- content/browser/service_worker/service_worker_provider_host.cc
- content/browser/service_worker/service_worker_provider_host.h
- content/browser/service_worker/service_worker_provider_host_unittest.cc
- content/browser/service_worker/service_worker_test_utils.cc
- content/browser/service_worker/service_worker_test_utils.h
- content/common/BUILD.gn
- content/common/service_worker/service_worker_provider.mojom
- content/common/service_worker/service_worker_provider.typemap
- content/common/service_worker/service_worker_provider_host_info.cc
- content/common/service_worker/service_worker_provider_host_info.h
- content/common/service_worker/service_worker_provider_struct_traits.cc
- content/common/service_worker/service_worker_provider_struct_traits.h
- content/common/typemaps.gni
- content/renderer/service_worker/service_worker_network_provider.cc
-
Fix description of NetworkPredictionOptions policy
Changed by faneohnoyoudont@google.com Changed at Thursday, 12-Jul-18 09:46:16 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 3d8142d8da58d317cc159294a6b9c6139e7173b1 Comments
Fix description of NetworkPredictionOptions policy Removed unnecessary preference names from description. Bug: 858829 Change-Id: Ic75e9af5ebca5e56c20e796e1991a217ad427246 Reviewed-on: https://chromium-review.googlesource.com/1131115 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#574517}
Changed files
- components/policy/resources/policy_templates.json
-
Disabling ViewIDTest.Basic.
Changed by mkwstohnoyoudont@chromium.org Changed at Thursday, 12-Jul-18 09:52:33 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8fc8ad7e2561f48248fee640b72a808f1592634a Comments
Disabling ViewIDTest.Basic. This test is consistently failing on: * 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018 * 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366 * 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145 TBR=mkwst@chromium.org,kpaulhamus@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862945 Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908 Reviewed-on: https://chromium-review.googlesource.com/1134780 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#574518}
Changed files
- chrome/browser/ui/cocoa/view_id_util_browsertest.mm