Home | Search
Login

Builder Android Builder Perf Build #66836

Results:

Failure

Trigger Info:

Execution:

Steps and Logfiles:

Show:
  1. ( 41 secs ) steps
    running steps via annotated script
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) setup_properties
    setup_properties
  4. ( 1 ms ) LUCI Migration
    LUCI Migration
  5. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chrome/bb/chromium.perf/Android_Builder_Perf/66836/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.perf/Android_Builder_Perf/66836" Annotation(LogDog Bootstrap)
logdog_project "chrome" Annotation(LogDog Bootstrap)
recipe "android/builder" Annotation(setup_properties)
blamelist ["scottchen@chromium.org"] Build
branch "master" Build
buildnumber 66836 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1544144180 Build
revision "9dfaf94c590c701314cb691deb74eb194468930c" Build
slavename "slave81-c1" BuildSlave
buildername "Android Builder Perf" Builder
git_revision "9dfaf94c590c701314cb691deb74eb194468930c" Change
scheduler "chromium" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.perf/" master.cfg
mastername "chromium.perf" master.cfg
workdir "/b/build/slave/Android_Builder_Perf" slave

Blamelist:

  1. (scottchenohnoyoudont@chromium.org)

Timing:

Create N/A
Start Friday, 07-Dec-18 07:32:15 UTC
End Friday, 07-Dec-18 07:32:57 UTC
Pending N/A
Execution 41 secs

All Changes:

  1. Navi Onboarding: fix double-recording Welcome.SigninPrompt

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Friday, 07-Dec-18 00:56:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9dfaf94c590c701314cb691deb74eb194468930c

    Comments

    Navi Onboarding: fix double-recording Welcome.SigninPrompt
    
    Welcome.SigninPrompt was doubly recorded because during onboarding we
    sometimes redirect users back to the welcome page. This CL fixes the issue
    by detecting if the welcome page instance is a redirected impression, and
    skip recording SigninPrompt if so.
    
    Bug: 905785
    Change-Id: Iff60b8813ee8a1f6c1f2eb3887b32356a5e3e00e
    Reviewed-on: https://chromium-review.googlesource.com/c/1362199
    Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#614503}

    Changed files

    • chrome/browser/ui/webui/welcome/welcome_handler.cc
    • chrome/browser/ui/webui/welcome/welcome_handler.h