Home | Search
Login

Builder Mac ASan 64 Builder Build #64304 Apple OSX

Results:

build successful

Trigger Info:

Got Revision3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 33 mins ) steps
    running steps via annotated script
  2. ( 10 ms ) trigger
    triggered
    mac_asan_64_rel_trigger
  3. ( 16 secs ) update_scripts
    update_scripts
  4. ( 4 ms ) LUCI Migration
    LUCI Migration
  5. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  6. ( 4 ms ) setup_build
    setup_build
    running recipe: "chromium"
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 3 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  9. ( 3 ms ) remove .cipd
    remove .cipd
  10. ( 1 mins 29 secs ) bot_update
    bot_update
    [149GB/232GB used (64%)]
  11. ( 3 ms ) ensure_goma
    ensure_goma
  12. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  14. ( 4 ms ) ensure_installed
    ensure_installed
  15. ( 25 secs ) gclient runhooks
    gclient runhooks
  16. ( 5 ms ) get compile targets for scripts
    get compile targets for scripts
  17. ( 5 ms ) read test spec (chromium.memory.json)
    read test spec (chromium.memory.json)
    path: /b/c/b/mac/src/testing/buildbot/chromium.memory.json
  18. ( 3 ms ) clean isolated files
    clean isolated files
  19. ( 16 secs ) generate_build_files
    generate_build_files
  20. ( 5 ms ) clang_revision
    clang_revision
  21. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  22. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  23. ( 24 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  24. ( 4 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  25. ( 51 mins 22 secs ) compile
    compile
  26. ( 16 secs ) compile confirm no-op
    compile confirm no-op
  27. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  28. ( 5 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  29. ( 3 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  30. ( 3 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  31. ( 15 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  32. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  33. ( 3 ms ) remove_build_metadata
    remove_build_metadata
  34. ( 2 mins 36 secs ) isolate tests
    isolate tests
  35. ( 32 mins 51 secs ) package build
    package build
  36. ( 74 ms ) trigger
    trigger
    Mac ASan 64 Tests (1)
  37. ( 5 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.memory/Mac_ASan_64_Builder/64304/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.memory/Mac_ASan_64_Builder/64304" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574632}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "798ee75d23651e7631775a113742bd09cc02e212" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23952}" Annotation(bot_update)
got_clang_revision "336424-1" Annotation(clang_revision)
swarm_hashes_refs/heads/master(at){#574632}_without_patch {"accessibility_unittests":"96eb76bf9b138377e6913551fcc1469dd2a98df3","angle_unittests":"a89f59dda6f2419f4d1a0806d2a3fb9e04d57f2c","app_shell_unittests":"6bee361a89ead17a697540844ed8133af45d6472","base_unittests":"cf8bfc20ff9e5d911e68570299fcb0e8bae43a9b","battor_agent_unittests":"fad7bf64b47e554759d2cc84f6ecec8eaec90a2f","blink_common_unittests":"e3874b2e5f187378dbe2af663c4fce230f13b0fc","blink_fuzzer_unittests":"5dfdeef029bf8993e00f49bb15559400c8b34f8c","blink_heap_unittests":"e4d57a9e7b391b6b279043c39610c3a596ec9e7f","blink_platform_unittests":"bb4441991c9f56cb98c760e3dcfb7cb4e3a7dd14","boringssl_crypto_tests":"308207509277686bddd519dae512641cf0c0f899","boringssl_ssl_tests":"3e420d2697995a2fb736b5697d46701cd36bb6af","cacheinvalidation_unittests":"1b79a61bb87948d7822232af9aabc9b40ca3c93c","capture_unittests":"96b02120692db20de47c1f0f88e5ee065d366841","cast_unittests":"45a9b05307452390efdd9d1ab2da4245d86f947b","cc_unittests":"c2bcdfe811f733365cc0e5eafcd64eb00d9f3998","chrome_app_unittests":"4d5e40262f87eb21d4f4fb9a019c7e50c46c252b","chromedriver_unittests":"79cf00c6b7ebb41251411f94936b1682cfd8d958","components_browsertests":"4ac8e0966576fa4123373af55cac57518f8b4d60","components_unittests":"7b0a0a023467d7e18f2fb5713bc1285ffa08cf4d","content_browsertests":"bff46081c065fdcf3ad9f60d0dcc47181efabd6b","content_unittests":"0f83a24feb241b03c5cc914bbff0582172c6b5f8","crashpad_tests":"46b971e70e7b1cac44470b68c2d5401df0664d72","cronet_tests":"051f716880719be90842ead3ba6e2665321e6e2f","cronet_unittests":"56398a35096ea2aa5af7cd9df2ae6d52a4cbcae8","crypto_unittests":"053c43514b5184dd7df3f44742f75cef77db60dd","device_unittests":"a03c26195559cfa5c5f1b346ec062663e074f149","display_unittests":"d4ec2e1a14dc962cae76eb2a127de59a5bc9b329","events_unittests":"bcf30ac8503009fb1710a6cd5002559c23c9762a","extensions_browsertests":"1770c1b69df63490d670a9e1410d849542015e04","extensions_unittests":"e8dff3c6c9ac101baa8add5f424ad7cdc1c38f83","filesystem_service_unittests":"42fae9fbc1789010349bca301fb3c09f92f5f085","gcm_unit_tests":"a2183a1cba208da0cd6acda26d48014a9c13f162","gfx_unittests":"f743c2269103ea7890d3cb0c9e100d88ea4f6705","gin_unittests":"75f2d254f6f8bccbe12981a7294775ebef0c6974","google_apis_unittests":"22ac1969ce184963bea08d0042d64c67c48af1d6","gpu_unittests":"f6e812c2b86059ab1d3cec79525869e3a2f1c8b6","headless_browsertests":"df9c8b66903dca0c8ff314bbd74ffe7b88fb7aa9","headless_unittests":"967e6a80ac814315d5cf63ddbbaa5d2e89b4d4f9","interactive_ui_tests":"e9f96360af7b0a14da607acc97dcb81bff71bdce","ipc_tests":"f2c7ef15b1671a905de96d4ed2f2234b00e7a381","jingle_unittests":"0fac1a581176f9a2022d790f77bc77710f9ab1bc","latency_unittests":"df4649d4866e16f277c20c1e6cd77e514b60709f","leveldb_service_unittests":"5319d58bd421b39092373779d49f710e35e33d8d","libjingle_xmpp_unittests":"ce6c0a804b065d04474aba9601debc86dfaf7902","mac_installer_unittests":"990a84ce47f2af271780e0335b2531801d12d976","media_blink_unittests":"ac5f680c3f912a655606f5a9c3f7afb7641f888d","media_service_unittests":"3ea66c702200b07571394e6473ab0a3db63f99f4","media_unittests":"326d0f105220ddf2a5a2ad5976a2c1946a6c5ee4","message_center_unittests":"fe1219eb339795687aae69ba4efd67bcc1c1867d","midi_unittests":"8f2dba6f6d3b09668489fdc59e0742ce3ab10f0d","mojo_unittests":"aa3e64078451076ed1733606c5a98b8fb05dfb65","native_theme_unittests":"701e74169ac970cb5adbd7e59c96e70fe8913878","net_unittests":"4c4a22d66f74e44c9de58a72f09cb676a36c0741","pdf_unittests":"0a45bb2f508d370916732830113d2a03a61e36df","ppapi_unittests":"67e4c5a41dbb0727c6df514e2e53d8730b0fa000","printing_unittests":"b0f7d7a2ee21db8512737c34977b2bd74908c64d","remoting_unittests":"3c676bf4cf6ef478264b52f8f50950549de60bfd","sandbox_mac_unittests":"6a71dc31e92a3107c07319f4fb6adbaf645d6c8b","service_manager_unittests":"1deef15cdce42c00759ad33843e9323ab4758d74","services_unittests":"f4c529f139858437111d05b8e603715cc255efed","shell_dialogs_unittests":"5dd0c5debb9aaf5bd9d2e4756d776e12eb86c859","skia_unittests":"c46893e7bbcd61e23f06d699305fc70edd99697a","snapshot_unittests":"806f779f3555a190b76453471c0525616a335798","sql_unittests":"827a031eeb643df4a00c6c18bf186c60a874cd7f","storage_unittests":"1901c65c75d8048e54bdbe48b6166381152ecf88","sync_integration_tests":"942cce9c9373ff543cefff58a31266f3e4d2781a","ui_base_unittests":"b0fc2f29a75d8ed30f4e9f0c5127f921c3064d0f","ui_touch_selection_unittests":"fe905ec38bc4eb1a56000922165c8fc2dc452c6f","unit_tests":"2d3d244774de3c0cdaf9d1a72b89ac3137f35d96","url_unittests":"ee0acc5c3c7851d34b281ffbb21aac03a7af1cc4","views_unittests":"ec7223198dc36bda1b1e6093d022f77b86a2e101","viz_unittests":"10e5df325f23e231013737e549b99cdd0909e96f","webkit_unit_tests":"e741871fc0afa8c44bdfc2d571588aee6d55446c","wtf_unittests":"ed1e45248959fdb7a60fc8e486a7380829438fbc"} Annotation(isolate tests)
build_archive_url "gs://chromium-memory-archive/chromium.memory/Mac ASan 64 Builder/full-build-mac_3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9.zip" Annotation(package build)
build_data_dir "/b/rr/tmpNcCM_L" Annotation(steps)
build_id "buildbot/chromium.memory/Mac ASan 64 Builder/64304" Annotation(steps)
builder_id "master.chromium.memory:Mac ASan 64 Builder" Annotation(steps)
blamelist ["alexilin@chromium.org","blundell@chromium.org","carlosil@chromium.org","digit@google.com","dmblack@google.com","dtapuska@chromium.org","eirage@chromium.org","erikchen@chromium.org","etiennep@chromium.org","eugenebut@google.com","iclelland@chromium.org","jsaul@google.com","juncai@chromium.org","junov@chromium.org","khmel@google.com","khorimoto@google.com","kmilka@chromium.org","kpaulhamus@chromium.org","kvitekp@chromium.org","lazyboy@chromium.org","mthiesse@chromium.org","offenwanger@chromium.org","pilgrim@chromium.org","pkl@chromium.org","rayankans@chromium.org","sergeyu@chromium.org","takumif@chromium.org","tangltom@chromium.org","tbansal@chromium.org","webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","wnwen@chromium.org"] Build
branch "master" Build
buildnumber 64304 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531413631 Build
revision "3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9" Build
slavename "vm638-m1" BuildSlave
buildername "Mac ASan 64 Builder" Builder
git_revision "3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9" Change
scheduler "mac_asan_rel" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.memory/" master.cfg
mastername "chromium.memory" master.cfg
workdir "/b/build/slave/Mac_ASan_64_Builder" slave

Blamelist:

  1. (sergeyuohnoyoudont@chromium.org)
  2. (eugenebutohnoyoudont@google.com)
  3. (kpaulhamusohnoyoudont@chromium.org)
  4. (etiennepohnoyoudont@chromium.org)
  5. (juncaiohnoyoudont@chromium.org)
  6. (blundellohnoyoudont@chromium.org)
  7. (tangltomohnoyoudont@chromium.org)
  8. (webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  9. (lazyboyohnoyoudont@chromium.org)
  10. (wnwenohnoyoudont@chromium.org)
  11. (digitohnoyoudont@google.com)
  12. (rayankansohnoyoudont@chromium.org)
  13. (alexilinohnoyoudont@chromium.org)
  14. (offenwangerohnoyoudont@chromium.org)
  15. (kmilkaohnoyoudont@chromium.org)
  16. (tbansalohnoyoudont@chromium.org)
  17. (junovohnoyoudont@chromium.org)
  18. (kvitekpohnoyoudont@chromium.org)
  19. (iclellandohnoyoudont@chromium.org)
  20. (pklohnoyoudont@chromium.org)
  21. (dmblackohnoyoudont@google.com)
  22. (dmblackohnoyoudont@google.com)
  23. (pilgrimohnoyoudont@chromium.org)
  24. (carlosilohnoyoudont@chromium.org)
  25. (mthiesseohnoyoudont@chromium.org)
  26. (dtapuskaohnoyoudont@chromium.org)
  27. (eirageohnoyoudont@chromium.org)
  28. (khorimotoohnoyoudont@google.com)
  29. (takumifohnoyoudont@chromium.org)
  30. (pilgrimohnoyoudont@chromium.org)
  31. (erikchenohnoyoudont@chromium.org)
  32. (khmelohnoyoudont@google.com)
  33. (jsaulohnoyoudont@google.com)
  34. (dmblackohnoyoudont@google.com)
  35. (dmblackohnoyoudont@google.com)

Timing:

Create N/A
Start Thursday, 12-Jul-18 18:02:40 UTC
End Thursday, 12-Jul-18 19:36:03 UTC
Pending N/A
Execution 1 hrs 33 mins

All Changes:

  1. [Fuchsia] Address CR comments in sys::Runner implementation

    Changed by sergeyuohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:39:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f7c234b0272dff6ce746e9eaac813497986913c3

    Comments

    [Fuchsia] Address CR comments in sys::Runner implementation
    
    When addressing comments on https://crrev.com//c//1114377 I hit CQ+1
    prematurely and landed the change without my changes that addresed
    review comments. Landing them separately.
    
    Bug: 856416
    Change-Id: I1b691d824f381e9ec0a75ff7ce90b2f45171c13a
    Reviewed-on: https://chromium-review.googlesource.com/1133968
    Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
    Reviewed-by: Wez <wez@chromium.org>
    Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574598}

    Changed files

    • webrunner/BUILD.gn
    • webrunner/app/component_controller_impl.cc
    • webrunner/app/component_controller_impl.h
    • webrunner/app/main.cc
    • webrunner/app/web_content_runner.cc
    • webrunner/app/web_content_runner.h
  2. Add testDownloadWhileBrowsing EG test.

    Changed by eugenebutohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 16:48:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4cce6875386037980e3245c630a9b9bac926f91e

    Comments

    Add testDownloadWhileBrowsing EG test.
    
    After tapping Download this test opens a separate tabs and loads the URL
    there. Then closes the tab and waits for the download completion.
    
    Bug: 854232
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Id05c9344d1da80a57b6c7cc663b2b8a835f18e82
    Reviewed-on: https://chromium-review.googlesource.com/1111916
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574599}

    Changed files

    • ios/chrome/browser/ui/download/BUILD.gn
    • ios/chrome/browser/ui/download/download_manager_egtest.mm
    • ios/chrome/test/BUILD.gn
    • ios/chrome/test/scoped_eg_synchronization_disabler.h
  3. Mark window-focus-self as flaky on Win10

    Changed by kpaulhamusohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:49:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a7be9cc2e39f872aeb8e03afb7d0aabf92ffde03

    Comments

    Mark window-focus-self as flaky on Win10
    
    Tbr: tkent@chromium.org
    Bug: 863067
    Change-Id: I9f043eec8363dbb26ccaa8d901321e0d579f1a4f
    Reviewed-on: https://chromium-review.googlesource.com/1135433
    Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
    Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574600}

    Changed files

    • third_party/WebKit/LayoutTests/TestExpectations
  4. [Autofill]: Create a policy flag for AutofillProfileEnabled.

    Changed by etiennepohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:50:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1b27097af312f3f4a4ee22bf0ea2c65239de03ff

    Comments

    [Autofill]: Create a policy flag for AutofillProfileEnabled.
    
    AutofillProfileEnabled was added as a preference setting in 1127344.
    This CL creates a policy flag for AutofillProfileEnabled that can
    overwrite the user preference.
    
    Bug: 860526
    Change-Id: I5d4848c26a53cf163fc4557d9b2da5f597bd98cf
    Reviewed-on: https://chromium-review.googlesource.com/1127463
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Reviewed-by: Drew Wilson <atwilson@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574601}

    Changed files

    • chrome/browser/policy/configuration_policy_handler_list_factory.cc
    • chrome/test/data/policy/policy_test_cases.json
    • components/autofill/core/browser/BUILD.gn
    • components/autofill/core/browser/autofill_profile_policy_handler.cc
    • components/autofill/core/browser/autofill_profile_policy_handler.h
    • components/autofill/core/browser/autofill_profile_policy_handler_unittest.cc
    • components/policy/resources/policy_templates.json
    • tools/metrics/histograms/enums.xml
  5. Network Service: Document how adding/removing http headers for web content requests are implemented

    Changed by juncaiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:52:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f3aba7f968ecb147e59a5460bd168e6085425848

    Comments

    Network Service: Document how adding/removing http headers for web content requests are implemented
    
    This is a follow-up CL per comments at:
    https://chromium-review.googlesource.com/c/chromium/src/+/1120955
    
    This CL adds comments to //components/variations/variations_http_header_provider.cc
    to document how adding/removing http headers for web content requests are
    implemented differently when Network Service is enabled or not enabled.
    
    Bug: 841309
    Change-Id: I6b1e7ac776415131f6f549253f8a69a4d0992117
    Reviewed-on: https://chromium-review.googlesource.com/1134408
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Jun Cai <juncai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574602}

    Changed files

    • components/variations/variations_http_header_provider.cc
  6. Revert "Have Device Service observe MessageLoop destruction"

    Changed by blundellohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:53:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0720b0228d5da8605132b93c3c5c989e5d3b8db1

    Comments

    Revert "Have Device Service observe MessageLoop destruction"
    
    This reverts commit 8e9dbcd3188c015f2dd67ba781168431aa51dab5.
    
    Reason for revert: It turns out that this is not the right solution to the problem. crbug.com/856771 presents a crash that this CL introduces on ChromeOS: the Device Service instance is now shut down after the DBusThreadManager global instance, on which it implicitly depends. We'll have to be more precise about the timing of when the Device Service instance is destroyed, which w
    ...skip...
    @chromium.org>
    > Reviewed-by: Ken Rockot <rockot@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#567260}
    
    TBR=rockot@chromium.org,blundell@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 794105
    Change-Id: I6de862f5828560ea903855898e09322e9f8d1e6c
    Reviewed-on: https://chromium-review.googlesource.com/1134887
    Commit-Queue: Colin Blundell <blundell@chromium.org>
    Reviewed-by: Colin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574603}

    Changed files

    • services/device/device_service.cc
    • services/device/device_service.h
  7. [unified-consent] Add unity logic to OneClickSigninSyncStarter

    Changed by tangltomohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:55:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 90520e430b08a292bd878117370d0a7e68eb38bc

    Comments

    [unified-consent] Add unity logic to OneClickSigninSyncStarter
    
    All unified consent services are enabled when the unified
    consent is given through the OneClickSigninSyncStarter.
    
    Bug: 862202
    Change-Id: Ieed60c04aa5a7753de65894fa335603d8785b57c
    Reviewed-on: https://chromium-review.googlesource.com/1135001
    Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Thomas Tangl <tangltom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574604}

    Changed files

    • chrome/browser/ui/sync/one_click_signin_sync_starter.cc
    • chrome/browser/ui/sync/one_click_signin_sync_starter.h
  8. Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)

    Changed by webrtc-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Thursday, 12-Jul-18 16:57:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision cae26c020606a88289e746e446999dd9c101019d

    Comments

    Roll src/third_party/webrtc 58c79f66dd3a..798ee75d2365 (2 commits)
    
    https://webrtc.googlesource.com/src.git/+log/58c79f66dd3a..798ee75d2365
    
    
    git log 58c79f66dd3a..798ee75d2365 --date=short --no-merges --format='%ad %ae %s'
    2018-07-12 kthelgason@webrtc.org Always disable RED when ULPFEC is disabled.
    2018-07-12 hta@webrtc.org Buffer ICE candidates that can't be added immediately.
    
    
    Created with:
      gclient setdep -r src/third_party/webrtc@798ee75d2365
    
    The AutoRoll server is located here: https://webrtc
    ...skip...
    rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
    TBR=webrtc-chromium-sheriffs-robots@google.com
    
    Change-Id: Ia3faf57f19146a8b08a9a5cbe8915a9750b91210
    Reviewed-on: https://chromium-review.googlesource.com/1135226
    Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#574605}

    Changed files

    • DEPS
  9. [Extensions] Remove linked_ptr usage from extension_messages.cc

    Changed by lazyboyohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 16:59:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision abb887f1fe0523ed4ab633530a3a55fd3e479731

    Comments

    [Extensions] Remove linked_ptr usage from extension_messages.cc
    
    This CL also makes ExtensionMsg_Load_Params non-copyable. There
    shouldn't be any behavior change in this CL.
    
    Bug: 556939
    Change-Id: If7d11919f8fee0442578371d44d6b715d08efe3a
    Reviewed-on: https://chromium-review.googlesource.com/1132572
    Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
    Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
    Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574606}

    Changed files

    • extensions/browser/renderer_startup_helper.cc
    • extensions/common/extension_messages.cc
    • extensions/common/extension_messages.h
    • extensions/common/extension_messages_unittest.cc
  10. Android: Fix jinja template deps

    Changed by wnwenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:05:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 001fc64fc2945bb7b18e6ffb20b6048c007ac6b8

    Comments

    Android: Fix jinja template deps
    
    Temporarily add missing deps to the depfile. Will no longer be necessary
    once all downstream targets are fixed.
    
    Bug: 843562
    Change-Id: Id797ea032a6a3818dac6013dcacb6f68baef2b6b
    Reviewed-on: https://chromium-review.googlesource.com/1134884
    Commit-Queue: agrieve <agrieve@chromium.org>
    Reviewed-by: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574607}

    Changed files

    • build/android/gyp/jinja_template.py
  11. android: Update bundletool binary to 0.5.0

    Changed by digitohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:07:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision dc6d74d7b8c120d3d8d90ab8c68c5285e384a7f8

    Comments

    android: Update bundletool binary to 0.5.0
    
    This release contains a bugfix required to generate Android
    app bundle APKs archives that can be installed on all devices.
    
    For more context, see:
    https://buganizer.corp.google.com/issues/110777526
    
    BUG=846633,820459
    R=agrieve@chromium.org, bensmason@chromium.org, yfriedman@chromium.org
    
    Change-Id: Ic71445f49a4548c8610f5d18598cdd3d3d5692c4
    Reviewed-on: https://chromium-review.googlesource.com/1135127
    Reviewed-by: agrieve <agrieve@chromium.org>
    Commit-Queue: David Turner <digit@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574608}

    Changed files

    • DEPS
    • build/android/gyp/bundletool.py
    • third_party/android_build_tools/bundletool/README.chromium
  12. [Background Fetch] Deserialize icon from metadata on browser restart.

    Changed by rayankansohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:07:59 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b0f9d40078cf7c016aeefb8a0aba4c498ed86aba

    Comments

    [Background Fetch] Deserialize icon from metadata on browser restart.
    
    Bug: 855789
    Change-Id: Ida29d5cbf111838c9bf8bc2639dddf7509169199
    Reviewed-on: https://chromium-review.googlesource.com/1128965
    Commit-Queue: Rayan Kanso <rayankans@chromium.org>
    Reviewed-by: Peter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574609}

    Changed files

    • content/browser/background_fetch/background_fetch_data_manager_unittest.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.cc
    • content/browser/background_fetch/storage/get_initialization_data_task.h
  13. Allow WritableSharedMemoryRegion to Unsafe conversion

    Changed by alexilinohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:08:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ecfbde9b593ca7f497375f56da8d076eb29772fa

    Comments

    Allow WritableSharedMemoryRegion to Unsafe conversion
    
    This CL adds a new ConvertToUnsafe() method to the WritableSharedMemoryRegion
    class. This new method is similar to ConvertToReadOnly() in structure. The
    conversion does not modify an underlying platform handle (except it closes a
    read-only handle on POSIX) but changes region's type.
    
    Bug: 795291
    Change-Id: Ie0a6b4c9850c0e223ee9299655f9bfd6c79c383b
    Reviewed-on: https://chromium-review.googlesource.com/985981
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574610}

    Changed files

    • base/memory/platform_shared_memory_region.h
    • base/memory/platform_shared_memory_region_android.cc
    • base/memory/platform_shared_memory_region_fuchsia.cc
    • base/memory/platform_shared_memory_region_mac.cc
    • base/memory/platform_shared_memory_region_posix.cc
    • base/memory/platform_shared_memory_region_unittest.cc
    • base/memory/platform_shared_memory_region_win.cc
    • base/memory/writable_shared_memory_region.cc
    • base/memory/writable_shared_memory_region.h
  14. Modify XRSession so that session geometry is only sent when it changes

    Changed by offenwangerohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a32f749ecae1923fda1485aa423b8e46dafddcf

    Comments

    Modify XRSession so that session geometry is only sent when it changes
    
    Making it so that instead of receiving geometry every frame, ar_core
    only gets geometry (frame size and rotation) when it changes. This saves
    some processing every frame, and allows the GetFrameData interface to be
    made uniform for AR and VR.
    
    Bug: 856259,846521
    Change-Id: I5828f57e1292f932c68148ac1e6b898f966b8d00
    Reviewed-on: https://chromium-review.googlesource.com/1115776
    Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
    Reviewed-by: Bill Orr <billorr@chromium.org>
    Reviewed-by: Klaus Weidner <klausw@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574611}

    Changed files

    • chrome/browser/android/vr/arcore_device/arcore_device.cc
    • chrome/browser/android/vr/arcore_device/arcore_device.h
    • chrome/browser/android/vr/arcore_device/arcore_gl.cc
    • chrome/browser/android/vr/arcore_device/arcore_gl.h
    • device/vr/vr_device_base.cc
    • device/vr/vr_device_base.h
    • device/vr/vr_display_impl.cc
    • device/vr/vr_display_impl.h
    • third_party/blink/renderer/modules/xr/xr_frame_provider.cc
    • third_party/blink/renderer/modules/xr/xr_frame_provider.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
    • third_party/blink/renderer/modules/xr/xr_session.h
  15. [NTP] Anchor custom backgrounds to the center of the window

    Changed by kmilkaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:13:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 06072d0984b80b680e26ed0f498911ef35800af2

    Comments

    [NTP] Anchor custom backgrounds to the center of the window
    
    Bug: 862789
    Change-Id: Ia23e75d07d738e02571010aaf9cbd0a1bc486060
    Reviewed-on: https://chromium-review.googlesource.com/1134435
    Commit-Queue: Mathieu Perreault <mathp@chromium.org>
    Reviewed-by: Mathieu Perreault <mathp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574612}

    Changed files

    • chrome/renderer/searchbox/searchbox_extension.cc
  16. Deflake resource loading hints and previews browsertest

    Changed by tbansalohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:14:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a875a2ea21d8a321295a11440c80af01bcf7fa86

    Comments

    Deflake resource loading hints and previews browsertest
    
    Attempt to deflake resource loading hints and previews
    browsertest by waiting for hints to be processed.
    
    Currently, the hints are processed on the background thread,
    and so may not be processed immediately.
    
    Log from the failed Linux test bots seem to indicate that
    the hints are not processed in time.
    See http://shortn/_IjBGHDP2Rp
    
    Bug: 789542,831838
    Change-Id: I6b30b1a86dc5d2cdef1cd8274cf5c6088bec8634
    Reviewed-on: https://chromium-review.googlesource.com/1134598
    Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
    Commit-Queue: Tarun Bansal <tbansal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574613}

    Changed files

    • chrome/browser/previews/previews_browsertest.cc
    • chrome/browser/previews/resource_loading_hints/resource_loading_hints_browsertest.cc
  17. Refactor canvas code to centralize CanvasResourceProvider ownership

    Changed by junovohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f8b8872f2080130c2b5bdf026f32f46aad7598da

    Comments

    Refactor canvas code to centralize CanvasResourceProvider ownership
    
    With this change, CanvasResourceProvider is always owned
    by CanvasResourceHost, except for a a few special case that use
    ephemeral resource providers.  This is a step towards unifying
    canvas and OffscreenCanvas presentation code paths.
    
    BUG=788439
    TBR=fserb@chromium.org, zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: Id9bdbb2c3e93b264f67946b887419b47599df65d
    Reviewed-on: https://chromium-review.googlesource.com/1134182
    Commit-Queue: Justin Novosad <junov@chromium.org>
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574614}

    Changed files

    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
    • third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
    • third_party/blink/renderer/core/html/canvas/html_canvas_element.h
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
    • third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
    • third_party/blink/renderer/core/paint/html_canvas_painter_test.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_test.cc
    • third_party/blink/renderer/modules/canvas/offscreencanvas/offscreen_canvas_test.cc
    • third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.cc
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge.h
    • third_party/blink/renderer/platform/graphics/canvas_2d_layer_bridge_test.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_dispatcher.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc
    • third_party/blink/renderer/platform/graphics/canvas_resource_provider.h
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.cc
    • third_party/blink/renderer/platform/graphics/gpu/graphics_context_3d_utils.h
    • third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc
    • third_party/blink/renderer/platform/graphics/test/fake_canvas_resource_host.h
    • third_party/blink/renderer/platform/graphics/test/fake_web_graphics_context_3d_provider.h
  18. Separated harness and target page base urls.

    Changed by kvitekpohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:16:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c2eb30bfc9ba51a4ac3a4f28bf2c728c3252620d

    Comments

    Separated harness and target page base urls.
    
    Change-Id: Ie6b2097fd8c03b486c2cab8ec3357a8c55907e92
    Reviewed-on: https://chromium-review.googlesource.com/1134498
    Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574615}

    Changed files

    • headless/test/data/protocol/inspector-protocol-test.html
    • headless/test/headless_protocol_browsertest.cc
    • third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
  19. Finish renaming "whitelist" to "allowlist".

    Changed by iclellandohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:17:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a27b817c70dec1ea68f4ea4b8711697ca694fb62

    Comments

    Finish renaming "whitelist" to "allowlist".
    
    Bug: 822317
    Change-Id: I155df06759c529dbd3183530c4722be3c4e0feb1
    Reviewed-on: https://chromium-review.googlesource.com/1133308
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Ian Clelland <iclelland@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574616}

    Changed files

    • content/browser/frame_host/render_frame_host_feature_policy_unittest.cc
    • third_party/blink/public/mojom/feature_policy/feature_policy.mojom
    • third_party/blink/renderer/platform/feature_policy/feature_policy.cc
    • third_party/blink/renderer/platform/feature_policy/feature_policy.h
  20. [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895

    Changed by pklohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:23:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f873a34ef2a72ed5d6bfcad35f5317c259d25fc7

    Comments

    [MDC roll] Roll Material Components to 89ba326620341ca7950621cf24da78864d6ee895
    
    Added MDCShapedView.
    
    Bug: 863001
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ibfdc8430ff9d3f184eac341cd8d6fdf1fe5041d2
    Reviewed-on: https://chromium-review.googlesource.com/1135191
    Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
    Commit-Queue: Peter Lee <pkl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574617}

    Changed files

    • DEPS
    • ios/third_party/material_components_ios/BUILD.gn
  21. Adds caption bar to AssistantWebView UI.

    Changed by dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:25:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 633097c22fed7171c82aabd1a3d001aab4510c78

    Comments

    Adds caption bar to AssistantWebView UI.
    
    In addition, this CL:
    - Adds a back button to the caption bar.
    - Adds API to change caption button visibility.
    
    Known issue:
    When navigating back from AssistantWebView UI, the Assistant
    container should not shrink. This is tracked in b/110433519.
    
    See bug for demo.
    
    Bug: b:111009446
    Change-Id: I63b47337d7ffcc8861c36529d04e9139800f4f4b
    Reviewed-on: https://chromium-review.googlesource.com/1132298
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Commit-Queue: David Black <dmblack@google.com>
    Cr-Commit-Position: refs/heads/master@{#574618}

    Changed files

    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/ui/assistant_main_view.cc
    • ash/assistant/ui/assistant_web_view.cc
    • ash/assistant/ui/assistant_web_view.h
    • ash/assistant/ui/caption_bar.cc
    • ash/assistant/ui/caption_bar.h
    • ash/assistant/util/deep_link_util.cc
  22. Removes Assistant horizontal page.

    Changed by dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:30:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3753827af78b5c5e3f458acaf9017c1afd082459

    Comments

    Removes Assistant horizontal page.
    
    No longer needed.
    
    Bug: b:111315529
    Change-Id: Ic16af0891a296a535d67c46d43bc63eb86f6f6f1
    Reviewed-on: https://chromium-review.googlesource.com/1132347
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: James Cook <jamescook@chromium.org>
    Reviewed-by: Weidong Guo <weidongg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574619}

    Changed files

    • ash/app_list/BUILD.gn
    • ash/app_list/views/assistant_container_view.cc
    • ash/app_list/views/assistant_container_view.h
    • ash/app_list/views/horizontal_page_container.cc
    • ash/app_list/views/horizontal_page_container.h
  23. Migrate captive_portal to BindOnce

    Changed by pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:31:48 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7dc10fe1b9fb22e9c1fb5a412b8440ba873866cf

    Comments

    Migrate captive_portal to BindOnce
    
    Bug: 714018
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ia2bf1a8fa963f7540272a0d28961bfc961f14dd0
    Reviewed-on: https://chromium-review.googlesource.com/1131994
    Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574620}

    Changed files

    • chrome/browser/captive_portal/captive_portal_service.cc
    • components/captive_portal/captive_portal_detector.cc
    • components/captive_portal/captive_portal_detector.h
    • components/captive_portal/captive_portal_detector_unittest.cc
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.h
    • ios/chrome/browser/ssl/captive_portal_metrics_tab_helper.mm
  24. Changed committed-interstitials flag from switch to feature.

    Changed by carlosilohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:33:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 49040ae795592d3b0c6a5b03533565caeb9ae266

    Comments

    Changed committed-interstitials flag from switch to feature.
    
    Removed 'committed-interstitials' switch and added SSLCommittedInterstitials
    base::Feature. Name was changed to SSLCommmittedInterstitials since we are now
    doing separate rampups for each kind of committed interstitial. Switch was
    changed to Feature so that it can be enabled via variations.
    
    Bug: 755632
    Change-Id: I0f3e0e01a94be2b515aa596827cd447d14c24b56
    Reviewed-on: https://chromium-review.googlesource.com/1118975
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Reviewed-by: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
    Reviewed-by: Emily Stark <estark@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574621}

    Changed files

    • chrome/browser/about_flags.cc
    • chrome/browser/chrome_content_browser_client.cc
    • chrome/browser/flag_descriptions.cc
    • chrome/browser/flag_descriptions.h
    • chrome/browser/policy/policy_browsertest.cc
    • chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
    • chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
    • chrome/browser/ssl/connection_help_tab_helper.cc
    • chrome/browser/ssl/connection_help_tab_helper_browsertest.cc
    • chrome/browser/ssl/security_state_tab_helper_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest.cc
    • chrome/browser/ssl/ssl_browsertest_util.cc
    • chrome/browser/ssl/ssl_error_controller_client.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle.cc
    • chrome/browser/ssl/ssl_error_navigation_throttle_unittest.cc
    • chrome/browser/ui/extensions/hosted_app_browsertest.cc
    • chrome/common/chrome_features.cc
    • chrome/common/chrome_features.h
    • chrome/common/chrome_switches.cc
    • chrome/common/chrome_switches.h
    • tools/metrics/histograms/enums.xml
  25. Merge vr_shell/ Java namespace into vr/ namespace.

    Changed by mthiesseohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:35:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bbe916af89d21e6e4be335879b819bf3efaf8353

    Comments

    Merge vr_shell/ Java namespace into vr/ namespace.
    
    Bug: 862741
    
    NOPRESUBMIT=true
    TBR=yusufo@chromium.org
    
    Change-Id: If26bb6664b6b882db33327d381ccac6594d5ef65
    Reviewed-on: https://chromium-review.googlesource.com/1134091
    Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
    Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
    Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574622}

    Changed files

    • WATCHLISTS
    • base/android/jni_generator/jni_exception_list.gni
    • chrome/android/BUILD.gn
    • chrome/android/java/AndroidManifest.xml
    • chrome/android/java/res_vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
    • chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/LaunchIntentDispatcher.java
    • chrome/android/java/src/org/chromium/chrome/browser/NavigationBarColorController.java
    • chrome/android/java/src/org/chromium/chrome/browser/RepostFormWarningDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java
    • chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/media/remote/RemoteMediaPlayerBridge.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/ConnectionInfoPopup.java
    • chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java
    • chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
    • chrome/android/java/src/org/chromium/chrome/browser/tab/TabBrowserControlsOffsetHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidUiGestureTarget.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/AndroidVSyncHelper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/EmptySniffingVrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/NoopCanvas.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnDispatchTouchEventCallback.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/OnExitVrRequestListener.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VR_JAVA_OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrAlertDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCancelAnimationActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrClassesWrapperImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCompositorSurfaceManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreInfo.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionChecker.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrCoreVersionCheckerImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApi.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDaydreamApiImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialog.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrDialogManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFeedbackStatus.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrFirstRunActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrInputConnection.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrIntentUtils.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrMainActivity.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrModalPresenter.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrPopupWindow.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellImpl.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToast.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrToastManager.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrUiWidgetFactory.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrViewContainer.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/VrWindowAndroid.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/BuildConstants.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/GvrKeyboardLoaderClient.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/TextEditAction.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr/keyboard/VrInputMethodManagerWrapper.java
    • chrome/android/java/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/widget/selection/SelectableListToolbar.java
    • chrome/android/java_sources.gni
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/EmulatedVrController.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/OWNERS
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/TestVrShellDelegate.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrFeedbackInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrInstallUpdateInfoBarTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellCompositorViewHolderTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellControllerInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellDialogTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNativeUiTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellNavigationTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrShellWebInputEditingTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/VrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrDeviceTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrInputTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTabTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebVrTransitionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArSessionTest.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockBrowserKeyboardInterface.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrCoreVersionCheckerImpl.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/mock/MockVrDaydreamApi.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/AndroidManifest.xml
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/nfc_apk/SimNfcActivity.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/HeadTrackingMode.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/README.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestriction.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrActivityRestrictionRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/HeadTrackingUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NativeUiUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/NfcSimUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/TransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrInfoBarUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrShellDelegateUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/XrTransitionUtils.java
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr/vr_test_framework.md
    • chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/OWNERS
    • chrome/browser/android/vr/BUILD.gn
    • chrome/browser/android/vr/vr_core_info.h
    • chrome/browser/android/vr/vr_shell_delegate.h
    • chrome/browser/vr/metrics/session_metrics_helper.h
    • chrome/browser/vr/test/vr_xr_browser_test.h
    • chrome/browser/vr/text_edit_action.h
    • chrome/browser/vr/ui_test_input.h
    • chrome/browser/vr/ui_unsupported_mode.h
    • chrome/browser/vr/webvr_input_browser_test.cc
    • chrome/browser/vr/webvr_tab_browser_test.cc
    • chrome/browser/vr/webvr_transition_browser_test.cc
    • chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
    • tools/perf/contrib/vr_benchmarks/vr_browsing_mode_pages.py
  26. Reland "Fix OOPIF hit testing in layout tests."

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:38:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c09ebfd64bd9d402997f4c1ab5624d95347e2245

    Comments

    Reland "Fix OOPIF hit testing in layout tests."
    
    This is a reland of 5e93ea1955845b344d6e137195b0f27638162b06
    
    The revert of this CL was determined to be the cause of some flaky tests
    on the chromeos bot. However those tests are disabled on linux and
    have been flaky on chromeos for a long time. See
    https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&builder=chromium.chromiumos%3Alinux-chromeos-rel&sortOrder=forward&sortColumn=test
    
    Original change's descr
    ...skip...
    -on: https://chromium-review.googlesource.com/1131219
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#573789}
    
    TBR=kenrb@chromium.org
    
    Bug: 601584
    Change-Id: Ifdd26f20bf6d44e704c33a7b7c4380a2de8c3696
    Reviewed-on: https://chromium-review.googlesource.com/1135471
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574623}

    Changed files

    • content/browser/renderer_host/render_widget_host_view_base.cc
  27. update hoverable pointerevent wpt

    Changed by eirageohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:39:20 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision df94a28e9988135e91dc8d0d841864344b7cde7c

    Comments

    update hoverable pointerevent wpt
    
    Update test wpt/pointerevent_attributes_hoverable_pointers
    
    This test was failing occationally on manual test, when we have
    clientX == box.right or clientY == box.bottom.
    update the test assertion so coordinates on border can be consider
    inside box.
    
    Note that on right border can also be outside box for the mouseevents.
    because we truncate the coordinates into interger.
    
    Bug: 863029
    Change-Id: Id20fbe0b6cf8566e6cdee229f427a0c747ed0c0a
    Reviewed-on: https://chromium-review.googlesource.com/1135432
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574624}

    Changed files

    • third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html
  28. [CrOS MultiDevice] Improve logging performance.

    Changed by khorimotoohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:40:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f39a6efa39053b51201f6c601a43955a5dd58a5f

    Comments

    [CrOS MultiDevice] Improve logging performance.
    
    Previously std::stringstream::str() was called twice, which generates
    two distinct (but identical) strings. This CL caches the result of the
    call and uses it twice.
    
    Bug: 862725
    Change-Id: I0384981a259b12d6c3ecf1420436f71e1e002fe6
    Reviewed-on: https://chromium-review.googlesource.com/1134218
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574625}

    Changed files

    • chromeos/components/proximity_auth/logging/logging.cc
  29. Fix a crash in MediaRouterDialogControllerViews

    Changed by takumifohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:44:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ebcff160836f5c7057cad3694d19e7237475c26

    Comments

    Fix a crash in MediaRouterDialogControllerViews
    
    When trying to show the Views Cast Dialog, abort if a browser instance
    for the initiator WebContents is not found.
    
    Bug: 862671
    Change-Id: I00fd25490f8790624e87d2f77c9bfc8b95f59403
    Reviewed-on: https://chromium-review.googlesource.com/1134043
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574626}

    Changed files

    • chrome/browser/ui/views/media_router/media_router_dialog_controller_views.cc
  30. Migrate AffiliationFetcher to SimpleURLLoader

    Changed by pilgrimohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:48:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 176a3a3154870bc3e0722934c03d6dc3b5dae748

    Comments

    Migrate AffiliationFetcher to SimpleURLLoader
    
    Bug: 844947
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I08b3921d4a6e8ad2489a175cea5a5b883af32bbb
    Reviewed-on: https://chromium-review.googlesource.com/1129322
    Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574627}

    Changed files

    • chrome/browser/password_manager/password_store_factory.cc
    • components/password_manager/core/browser/BUILD.gn
    • components/password_manager/core/browser/DEPS
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_backend.h
    • components/password_manager/core/browser/android_affiliation/affiliation_backend_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/affiliation_fetcher_unittest.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.cc
    • components/password_manager/core/browser/android_affiliation/affiliation_service.h
    • components/password_manager/core/browser/android_affiliation/affiliation_service_unittest.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.cc
    • components/password_manager/core/browser/android_affiliation/fake_affiliation_fetcher.h
    • components/password_manager/core/browser/android_affiliation/test_affiliation_fetcher_factory.h
    • components/password_manager/core/browser/password_store_factory_util.cc
    • components/password_manager/core/browser/password_store_factory_util.h
    • ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
  31. [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.

    Changed by erikchenohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 17:52:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3e0fccc527819cb8e09682bc280fb35d4b3fafdd

    Comments

    [Reland #1] macOS: Display [ctr + tab] and [ctr + shift + tab] as hotkeys for tab switching.
    
    The first CL caused test failures because the browser_test was ignoring the
    "shift" key when searching for menu items. The IDC_SELECT_NEXT_TAB and
    IDC_SELECT_PREVIOUS_TAB only differ by the presence of "shift", so it cannot be
    ignored.
    
    > This matches other macOS application like Safari, Terminal, etc. All existing
    > hotkeys will still work.
    >
    > This CL uses the same hotkey for "previous tab" that Safari and 
    ...skip...
    oglesource.com/1106659
    > Commit-Queue: Erik Chen <erikchen@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574211}
    
    Change-Id: Id87f364f5c5b303e8b9668e79f813a1c23376c98
    TBR: avi@chromium.org
    Reviewed-on: https://chromium-review.googlesource.com/1134203
    Commit-Queue: Erik Chen <erikchen@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574628}

    Changed files

    • chrome/app/nibs/MainMenu.xib
    • chrome/browser/global_keyboard_shortcuts_mac.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa.mm
    • chrome/browser/ui/cocoa/accelerators_cocoa_browsertest.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions.mm
    • chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm
    • content/browser/renderer_host/render_widget_host_view_cocoa.mm
    • ui/events/test/cocoa_test_event_utils.mm
  32. arc: Remove data on child transition fail.

    Changed by khmelohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:54:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ef49be42c92ed17ab5ae4635843eeb4c35737eb5

    Comments

    arc: Remove data on child transition fail.
    
    This optionally resets ARC++ container in case child transition fails.
    This shows confirmation dialog and in case user accepts removes data and
    restart ARC++.
    
    TEST=Manually
    BUG=841939
    
    Change-Id: I07ecb1153acab7368f17ac15a957803132d6a101
    Reviewed-on: https://chromium-review.googlesource.com/1132529
    Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
    Reviewed-by: Michael Wasserman <msw@chromium.org>
    Commit-Queue: Yury Khmel <khmel@google.com>
    Cr-Commit-Position: refs/heads/master@{#574629}

    Changed files

    • chrome/app/chromeos_strings.grdp
    • chrome/browser/chromeos/arc/auth/arc_auth_service.cc
    • chrome/browser/chromeos/arc/auth/arc_auth_service.h
    • chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/app_list/arc/arc_data_removal_dialog.h
    • chrome/browser/ui/browser_dialogs.h
    • chrome/browser/ui/views/arc_data_removal_dialog_view.cc
  33. [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled

    Changed by jsaulohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:58:37 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 82955ec9a3ee0930e91b93cf7b6e50261b175192

    Comments

    [Autofill] Finalize cardholder name tooltip, and only show if textfield is prefilled
    
    Bug: 848955
    Change-Id: I0df815936fa2e9a09a9571760613277f34e2b1c5
    Reviewed-on: https://chromium-review.googlesource.com/1134394
    Reviewed-by: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
    Commit-Queue: Jared Saul <jsaul@google.com>
    Cr-Commit-Position: refs/heads/master@{#574630}

    Changed files

    • chrome/browser/ui/views/autofill/dialog_view_ids.h
    • chrome/browser/ui/views/autofill/save_card_bubble_views.cc
    • chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
    • components/autofill_strings.grdp
  34. Add Constructed/Destroying events to AssistantControllerObserver.

    Changed by dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 17:59:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1f58bcc5d430370a17613c0d8ff18d6ded2b16a1

    Comments

    Add Constructed/Destroying events to AssistantControllerObserver.
    
    These events are used to reduce the complexity of the circular
    dependency between AssistantController's sub-controllers.
    
    Bug: b:80542452
    Change-Id: If266ca01f844ec97d7f0b5f6a7216dac0da4e17f
    Reviewed-on: https://chromium-review.googlesource.com/1133587
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574631}

    Changed files

    • ash/assistant/assistant_controller.cc
    • ash/assistant/assistant_controller.h
    • ash/assistant/assistant_controller_observer.h
    • ash/assistant/assistant_interaction_controller.cc
    • ash/assistant/assistant_interaction_controller.h
    • ash/assistant/assistant_screen_context_controller.cc
    • ash/assistant/assistant_screen_context_controller.h
    • ash/assistant/assistant_ui_controller.cc
    • ash/assistant/assistant_ui_controller.h
  35. Adds support for Assistant explore deep link.

    Changed by dmblackohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 18:00:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d9e23b6ac8c9696e4f72c1c6d3393921d3f4ba9

    Comments

    Adds support for Assistant explore deep link.
    
    Deep link opens in the Assistant UI container.
    See bug for demo.
    
    Bug: b:111319842
    Change-Id: I1bf3d227beae70471986ff5f169488ec3b44bbcd
    Reviewed-on: https://chromium-review.googlesource.com/1132475
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574632}

    Changed files

    • ash/assistant/util/deep_link_util.cc
    • ash/assistant/util/deep_link_util.h
    • ash/assistant/util/deep_link_util_unittest.cc