Home | Search
Login

Builder Mac ASan 64 Builder Build #64299 Apple OSX

Results:

build successful

Trigger Info:

Got Revision7a0ab14f53bb9b6346969ec10d376d51aff8eceb

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 13 mins ) steps
    running steps via annotated script
  2. ( 10 ms ) trigger
    triggered
    mac_asan_64_rel_trigger
  3. ( 5 secs ) update_scripts
    update_scripts
  4. ( 4 ms ) LUCI Migration
    LUCI Migration
  5. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  6. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  7. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  8. ( 3 ms ) makedirs checkout path (2)
    makedirs checkout path (2)
  9. ( 3 ms ) remove .cipd
    remove .cipd
  10. ( 1 mins 11 secs ) bot_update
    bot_update
    [149GB/232GB used (64%)]
  11. ( 3 ms ) ensure_goma
    ensure_goma
  12. ( 4 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  13. ( 3 ms ) swarming.py --version
    swarming.py --version
    0.13
  14. ( 4 ms ) ensure_installed
    ensure_installed
  15. ( 31 secs ) gclient runhooks
    gclient runhooks
  16. ( 4 ms ) get compile targets for scripts
    get compile targets for scripts
  17. ( 4 ms ) read test spec (chromium.memory.json)
    read test spec (chromium.memory.json)
    path: /b/c/b/mac/src/testing/buildbot/chromium.memory.json
  18. ( 3 ms ) clean isolated files
    clean isolated files
  19. ( 16 secs ) generate_build_files
    generate_build_files
  20. ( 5 ms ) clang_revision
    clang_revision
  21. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  22. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  23. ( 23 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  24. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  25. ( 37 mins 15 secs ) compile
    compile
  26. ( 11 secs ) compile confirm no-op
    compile confirm no-op
  27. ( 3 ms ) postprocess_for_goma
    postprocess_for_goma
  28. ( 2 ms ) postprocess_for_goma.goma_jsonstatus
    postprocess_for_goma.goma_jsonstatus
  29. ( 1 ms ) postprocess_for_goma.goma_stat
    postprocess_for_goma.goma_stat
  30. ( 1 ms ) postprocess_for_goma.stop_goma
    postprocess_for_goma.stop_goma
  31. ( 13 secs ) postprocess_for_goma.upload_log
    postprocess_for_goma.upload_log
  32. ( 3 ms ) postprocess_for_goma.stop cloudtail
    postprocess_for_goma.stop cloudtail
  33. ( 3 ms ) remove_build_metadata
    remove_build_metadata
  34. ( 2 mins 20 secs ) isolate tests
    isolate tests
  35. ( 29 mins 59 secs ) package build
    package build
  36. ( 62 ms ) trigger
    trigger
    Mac ASan 64 Tests (1)
  37. ( 6 ms ) recipe result
    recipe result

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.memory/Mac_ASan_64_Builder/64299/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.memory/Mac_ASan_64_Builder/64299" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "5598148b761380773c4e650b5b67f47553b0f090" Annotation(bot_update)
got_buildtools_revision "0dd5c6f980d22be96b728155249df2da355989d9" Annotation(bot_update)
got_nacl_revision "e6ce828ef60c4c1438867b535efbbb5d9a177c0e" Annotation(bot_update)
got_revision "7a0ab14f53bb9b6346969ec10d376d51aff8eceb" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#574521}" Annotation(bot_update)
got_swarming_client_revision "9a518d097dca20b7b00ce3bdfc5d418ccc79893a" Annotation(bot_update)
got_v8_revision "8b17db68f75a95d69debfa85b70aea3ec0766aaf" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.9.352@{#1}" Annotation(bot_update)
got_webrtc_revision "5795489e83adba65cb480d57e71f52bae1f5ee1b" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23944}" Annotation(bot_update)
got_clang_revision "336424-1" Annotation(clang_revision)
swarm_hashes_refs/heads/master(at){#574521}_without_patch {"accessibility_unittests":"7fd0d8838555779ee17bb0c213e701d8749eb202","angle_unittests":"a89f59dda6f2419f4d1a0806d2a3fb9e04d57f2c","app_shell_unittests":"5a978073645bb111d4c1ddaf99a3e9644104d410","base_unittests":"06c4fc2085ab73102b223b1867ef5a0987aa2011","battor_agent_unittests":"463e5e4caabea1e31b44ef26d9f5ae407c88c71e","blink_common_unittests":"1d24d297b11bc6ec5abaf8d8bad1006ae0bc45b0","blink_fuzzer_unittests":"23d52b5a214b0c324494a8b41f01e32116f883e8","blink_heap_unittests":"450d8d9a3424634a2cd86700eda77486b6081970","blink_platform_unittests":"7fcbb62ff5c743e58da023fbe44a532b70513d22","boringssl_crypto_tests":"308207509277686bddd519dae512641cf0c0f899","boringssl_ssl_tests":"3e420d2697995a2fb736b5697d46701cd36bb6af","cacheinvalidation_unittests":"1b79a61bb87948d7822232af9aabc9b40ca3c93c","capture_unittests":"62ed30b0aa35be8866d6e95402a27fa3f00e9ba9","cast_unittests":"31e465f4e2f0651591c663bbfea9a921972d2d67","cc_unittests":"63cdd89ca1f359898561005ca7a5d13ecbd98dd7","chrome_app_unittests":"3b0b33d502cd8257ae094eb1a09389b101ca0a03","chromedriver_unittests":"866dc04ac715c38c226b82d0bf1f0e70a82e5d0b","components_browsertests":"5d046bca6e75eb3620482811de988d7ab3528a18","components_unittests":"b9925a9eb321c265a04beb0ea74ac2c61e484b47","content_browsertests":"7a442fd8799579a79abd954010298ebdb5a46b40","content_unittests":"a09e9db5525334bbd868d2101b760fde58501988","crashpad_tests":"46b971e70e7b1cac44470b68c2d5401df0664d72","cronet_tests":"051f716880719be90842ead3ba6e2665321e6e2f","cronet_unittests":"56398a35096ea2aa5af7cd9df2ae6d52a4cbcae8","crypto_unittests":"053c43514b5184dd7df3f44742f75cef77db60dd","device_unittests":"5082f9a7d4fef4fd35777c76f047aa5355f7d8cf","display_unittests":"37a9c340c4ad2d6ac3984e71d83144cc80487198","events_unittests":"95f05127480b5bf64f3f5e779c9da1ea8d7fcaca","extensions_browsertests":"5f7fb11337d19cc9e81d0c9cebc697bc8ec45586","extensions_unittests":"8e850404da3b909a2ae01c4e3772222025032c12","gcm_unit_tests":"79ee1eee0750d5fcf333e3851e661584251291b8","gfx_unittests":"2b04b5ce03b045498d59d594254b3638f060288e","gin_unittests":"dc52e8519234895181b8732c7bdcb16fd5043da4","google_apis_unittests":"3b68b958731c1c6d29b9326ef51c2a79427aaca3","gpu_unittests":"191e2b0cbb19499abfce4cf705096ad7365ef986","headless_browsertests":"d412a89765bf68ed3b5ec70d113b838e639bfdc8","headless_unittests":"b52290262b38b94d639c0919847868c79a61f26a","interactive_ui_tests":"11156dc865a616bdad4541a0912d6be644a3276e","ipc_tests":"ba50558bab2588ec5ac133c28035809c83165b0e","jingle_unittests":"351df7722cfc19fee90081f0991eec150a27e739","latency_unittests":"439a14153ea3a623e90122e49a047ea58eddbdf7","libjingle_xmpp_unittests":"ce6c0a804b065d04474aba9601debc86dfaf7902","mac_installer_unittests":"c68827e337bb5a310909e666cfc242de3d92f54c","media_blink_unittests":"6fe88de0655aba181314803b940421062a7b9c93","media_service_unittests":"8ecc45b4afa4b17313d386173db1a05406de7265","media_unittests":"d0a252f8ba24bc95fc28f76864dddb91d4e9298c","message_center_unittests":"4b92c00191aa0136323566908eb425bdfb2285c6","midi_unittests":"8f2dba6f6d3b09668489fdc59e0742ce3ab10f0d","mojo_unittests":"03d162291dcb62168fca2c0a5f5ff8e1ad0d6757","native_theme_unittests":"c55415a9be7ba78225a7b4b477e903b792e63e67","net_unittests":"4d33f90b12c067ee3879ead23cd78c4282c45713","pdf_unittests":"4fa2547998faf44129fed6ac1165229bf4f4352b","ppapi_unittests":"2c59daac5d158250b4bea04d48aaed491f5d52d6","printing_unittests":"4d470db5a30cc2e410ffe563c3a922ef9fea1af4","remoting_unittests":"3310c9c37860f70847bad0c564084c78d9fa73e7","sandbox_mac_unittests":"bf7cde577e947979030590b5912078c713c7304d","service_manager_unittests":"f63fd61e43af444cb60b30114cf1596b18900064","services_unittests":"0d5f5fab956c4eefb39938c34a1e58d3901e44e1","shell_dialogs_unittests":"c6b6e702f98b5dd7757599a27549b6e1ce275ec8","skia_unittests":"c1436b1b12702753c48a7ce7f159f76a99429fea","snapshot_unittests":"645946d733be446d372e86d69e310f9c35b3c3a0","sql_unittests":"827a031eeb643df4a00c6c18bf186c60a874cd7f","storage_unittests":"64b17141ef2a8a9852a4d74c85984f2222d37f7f","sync_integration_tests":"383a2e11f0194f5fa5644774abffbe3920155508","ui_base_unittests":"7c66190dac8e3e8205f2a08c30f9855febd7a2e0","ui_touch_selection_unittests":"82e4ec4fcf69bf6c65e2ba455010a78da4d64ffa","unit_tests":"b2a87feb6bb3f84e76fcfabd1b9636b98f571451","url_unittests":"abdbd7c3c26de86c024a2374c3ae34ffcd519309","views_unittests":"37b851718b66c61e106f12dbd703697cbde61e6b","viz_unittests":"97bb325242873dd55d3bab5d57958fd3393bcffd","webkit_unit_tests":"7a2d71d845c6c6d67e91fa6f3f1a0272e58654d8","wtf_unittests":"5d334a62b188ad01192ce0185399a270c4f798d0"} Annotation(isolate tests)
build_archive_url "gs://chromium-memory-archive/chromium.memory/Mac ASan 64 Builder/full-build-mac_7a0ab14f53bb9b6346969ec10d376d51aff8eceb.zip" Annotation(package build)
build_data_dir "/b/rr/tmpMoOR9i" Annotation(steps)
build_id "buildbot/chromium.memory/Mac ASan 64 Builder/64299" Annotation(steps)
builder_id "master.chromium.memory:Mac ASan 64 Builder" Annotation(steps)
blamelist ["fane@google.com","leon.han@intel.com","marq@google.com","mkwst@chromium.org","rohitrao@chromium.org","yamaguchi@chromium.org"] Build
branch "master" Build
buildnumber 64299 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1531388851 Build
revision "7a0ab14f53bb9b6346969ec10d376d51aff8eceb" Build
slavename "vm638-m1" BuildSlave
buildername "Mac ASan 64 Builder" Builder
git_revision "7a0ab14f53bb9b6346969ec10d376d51aff8eceb" Change
scheduler "mac_asan_rel" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.memory/" master.cfg
mastername "chromium.memory" master.cfg
workdir "/b/build/slave/Mac_ASan_64_Builder" slave

Blamelist:

  1. (leon.hanohnoyoudont@intel.com)
  2. (faneohnoyoudont@google.com)
  3. (mkwstohnoyoudont@chromium.org)
  4. (marqohnoyoudont@google.com)
  5. (rohitraoohnoyoudont@chromium.org)
  6. (yamaguchiohnoyoudont@chromium.org)

Timing:

Create N/A
Start Thursday, 12-Jul-18 10:59:48 UTC
End Thursday, 12-Jul-18 12:12:54 UTC
Pending N/A
Execution 1 hrs 13 mins

All Changes:

  1. [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo

    Changed by leon.hanohnoyoudont@intel.com
    Changed at Thursday, 12-Jul-18 09:45:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d00d598cb4ae00510a30326c3db46f9b0506e36d

    Comments

    [ServiceWorker] Remove native struct ServiceWorkerProviderHostInfo
    
    This CL removes native struct ServiceWorkerProviderHostInfo and the
    corresponding typemapping for it, instead, directly uses mojom struct
    ServiceWorkerProviderHostInfo everywhere.
    
    BUG=789854
    
    Change-Id: I5aa15afb38d5658e25ba40dacae5873cff4caa62
    Reviewed-on: https://chromium-review.googlesource.com/1132847
    Commit-Queue: Han Leon <leon.han@intel.com>
    Reviewed-by: Matt Falkenhagen <falken@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574516}

    Changed files

    • content/browser/service_worker/service_worker_dispatcher_host.cc
    • content/browser/service_worker/service_worker_dispatcher_host.h
    • content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
    • content/browser/service_worker/service_worker_object_host_unittest.cc
    • content/browser/service_worker/service_worker_provider_host.cc
    • content/browser/service_worker/service_worker_provider_host.h
    • content/browser/service_worker/service_worker_provider_host_unittest.cc
    • content/browser/service_worker/service_worker_test_utils.cc
    • content/browser/service_worker/service_worker_test_utils.h
    • content/common/BUILD.gn
    • content/common/service_worker/service_worker_provider.mojom
    • content/common/service_worker/service_worker_provider.typemap
    • content/common/service_worker/service_worker_provider_host_info.cc
    • content/common/service_worker/service_worker_provider_host_info.h
    • content/common/service_worker/service_worker_provider_struct_traits.cc
    • content/common/service_worker/service_worker_provider_struct_traits.h
    • content/common/typemaps.gni
    • content/renderer/service_worker/service_worker_network_provider.cc
  2. Fix description of NetworkPredictionOptions policy

    Changed by faneohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:46:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3d8142d8da58d317cc159294a6b9c6139e7173b1

    Comments

    Fix description of NetworkPredictionOptions policy
    
    Removed unnecessary preference names from description.
    
    Bug: 858829
    Change-Id: Ic75e9af5ebca5e56c20e796e1991a217ad427246
    Reviewed-on: https://chromium-review.googlesource.com/1131115
    Reviewed-by: Lutz Justen <ljusten@chromium.org>
    Commit-Queue: Stefan Teodorescu <fane@google.com>
    Cr-Commit-Position: refs/heads/master@{#574517}

    Changed files

    • components/policy/resources/policy_templates.json
  3. Disabling ViewIDTest.Basic.

    Changed by mkwstohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 09:52:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8fc8ad7e2561f48248fee640b72a808f1592634a

    Comments

    Disabling ViewIDTest.Basic.
    
    This test is consistently failing on:
    
    * 10.11 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28018
    * 10.12 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14366
    * 10.13 as of https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4145
    
    TBR=mkwst@chromium.org,kpaulhamus@chromium.org
    
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 862945
    Change-Id: I9156862b472f2ad993f9da7d709b75baaddc2908
    Reviewed-on: https://chromium-review.googlesource.com/1134780
    Reviewed-by: Mike West <mkwst@chromium.org>
    Commit-Queue: Mike West <mkwst@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574518}

    Changed files

    • chrome/browser/ui/cocoa/view_id_util_browsertest.mm
  4. [iOS] Tweak tab grid transition animations.

    Changed by marqohnoyoudont@google.com
    Changed at Thursday, 12-Jul-18 09:57:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e96b9e2a058ddc4573deba9c0159077c8a89b45d

    Comments

    [iOS] Tweak tab grid transition animations.
    
    This CL adjusts the tab grid transition animations.
    
    (A) The timing (curve, delay, and duration) of some of the sub-animations is tweaked.
    
    (B) Because -viewWillAppear: is called inside the animation, some of the
        setup for the animations needs to be done before that method is called;
        the cleanest mechanism seemed to be to make these changes when the view
        disappeared. This is mostly setting the toolbar alpha to zero so it can be
        faded in during the animation.
    
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8c84f5726a0ce49e13c5fd32ab91295ffbb00e57
    Reviewed-on: https://chromium-review.googlesource.com/1127994
    Commit-Queue: Mark Cogan <marq@chromium.org>
    Reviewed-by: edchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574519}

    Changed files

    • ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
    • ios/chrome/browser/ui/tab_grid/transitions/grid_transition_animation.mm
  5. [ios] Adds icons and hides headers on the main Settings page.

    Changed by rohitraoohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:00:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5f5527a3ed5e88090ce316b8afac85c39cbb0ba8

    Comments

    [ios] Adds icons and hides headers on the main Settings page.
    
    Screenshot: https://drive.google.com/file/d/16aS0MP0LwdGOq8-IJgtIbq4ozXy44meT/view?usp=sharing
    
    BUG=805213,805214
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Iccdd87d8f95fd80b51fcdcfa2caa691c7fcd78b4
    Reviewed-on: https://chromium-review.googlesource.com/1133323
    Reviewed-by: edchin <edchin@chromium.org>
    Commit-Queue: Rohit Rao <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574520}

    Changed files

    • ios/chrome/browser/ui/settings/BUILD.gn
    • ios/chrome/browser/ui/settings/cells/settings_switch_item.mm
    • ios/chrome/browser/ui/settings/resources/BUILD.gn
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_about_chrome.imageset/settings_about_chrome@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_article_suggestions.imageset/settings_article_suggestions@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_autofill_forms.imageset/settings_autofill_forms@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_bandwidth.imageset/settings_bandwidth@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_content_settings.imageset/settings_content_settings@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_debug.imageset/settings_debug@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_passwords.imageset/settings_passwords@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_privacy.imageset/settings_privacy@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_search_engine.imageset/settings_search_engine@3x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/Contents.json
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@2x.png
    • ios/chrome/browser/ui/settings/resources/settings_voice_search.imageset/settings_voice_search@3x.png
    • ios/chrome/browser/ui/settings/settings_collection_view_controller.mm
  6. Always align slider bubbles to the bottom of the desktop.

    Changed by yamaguchiohnoyoudont@chromium.org
    Changed at Thursday, 12-Jul-18 10:06:16 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7a0ab14f53bb9b6346969ec10d376d51aff8eceb

    Comments

    Always align slider bubbles to the bottom of the desktop.
    
    The slider was aligned towards the system tray icon view in the shelf
    by the bubble's bottom edge. It meant that the slider bubble was shown
    apart from the bottom of the desktop when the shelf layout is either
    right or left. It was not consistent with popup notification, causing
    view overlap between notifications and a slider bubble.
    
    Bug: 862496
    Change-Id: Ie6db618f8b744ecc4de52ee7a4866ca9e9ecd26c
    Reviewed-on: https://chromium-review.googlesource.com/1134643
    Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#574521}

    Changed files

    • ash/system/unified/unified_slider_bubble_controller.cc