Home | Search
Login

Builder ios-device-xcode-clang Build #60765 Apple OSX

Results:

exception interrupted exception compile

Trigger Info:

Got Revision4344b812321a1c1c021723e5f6fce77920688c0e

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 15 mins ) steps
    running steps via annotated script
    interrupted
  2. ( 5 secs ) update_scripts
    update_scripts
  3. ( 1 ms ) LUCI Migration
    LUCI Migration
  4. ( 1 ms ) LogDog Bootstrap
    LogDog Bootstrap
  5. ( 5 ms ) setup_build
    setup_build
    running recipe: "ios/unified_builder_tester"
  6. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  7. ( 1 mins 56 secs ) bot_update
    bot_update
    [158GB/199GB used (79%)]
  8. ( 3 ms ) read build config
    read build config
  9. ( 2 ms ) ensure_goma
    ensure_goma
  10. ( 3 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  11. ( 2 ms ) ensure xcode
    ensure xcode
    Ensuring Xcode version 9c40b in /b/c/xcode_ios_9c40b.app
  12. ( 3 ms ) ensure xcode.ensure_installed
    ensure xcode.ensure_installed
  13. ( 2 ms ) ensure xcode.install xcode
    ensure xcode.install xcode
  14. ( 2 ms ) ensure xcode.select xcode
    ensure xcode.select xcode
  15. ( 18 secs ) gclient runhooks
    gclient runhooks
  16. ( 14 secs ) generate build files (mb)
    generate build files (mb)
  17. ( 3 ms ) preprocess_for_goma
    preprocess_for_goma
  18. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  19. ( 3 ms ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  20. ( 3 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  21. ( 1 hrs 12 mins ) compile
    compile

Build Properties:

NameValueSource
$recipe_engine/runtime {"is_experimental":false,"is_luci":false} Annotation(LUCI Migration)
luci_migration {"status":"ok"} Annotation(LUCI Migration)
log_location "logdog://logs.chromium.org/chromium/bb/chromium.mac/ios-device-xcode-clang/60765/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.mac/ios-device-xcode-clang/60765" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "e943df226e2b6e5361d38211d672c8e39156832f" Annotation(bot_update)
got_buildtools_revision "a9e946f166b73f9dc170129f6586a1e68efb0ab3" Annotation(bot_update)
got_nacl_revision "93deff44b49fcbb4da0ee7961f21b6b93da194e9" Annotation(bot_update)
got_revision "4344b812321a1c1c021723e5f6fce77920688c0e" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#559240}" Annotation(bot_update)
got_swarming_client_revision "88229872dd17e71658fe96763feaa77915d8cbd6" Annotation(bot_update)
got_v8_revision "f60540128aa8add150907f32b7590fc2c4e79a26" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.8.236@{#1}" Annotation(bot_update)
got_webrtc_revision "ef75ebef55207d770bc3712004e0680e0fe261f2" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#23246}" Annotation(bot_update)
build_data_dir "/b/rr/tmpxYJzek" Annotation(steps)
build_id "buildbot/chromium.mac/ios-device-xcode-clang/60765" Annotation(steps)
builder_id "master.chromium.mac:ios-device-xcode-clang" Annotation(steps)
blamelist ["achaulk@google.com","aee@chromium.org","afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","agrieve@chromium.org","aleventhal@chromium.org","angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","bsazonov@chromium.org","camurcu@google.com","cco3@chromium.org","charliea@chromium.org","danielpark@chromium.org","djacobo@chromium.org","dmazzoni@chromium.org","dtrainor@chromium.org","dtseng@chromium.org","fdegans@chromium.org","hansberry@chromium.org","jchinlee@chromium.org","jdoerrie@chromium.org","jdufault@google.com","jkardatzke@google.com","khmel@google.com","kojii@chromium.org","majidvp@chromium.org","mustaq@google.com","pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","pwnall@chromium.org","rbpotter@chromium.org","rdevlin.cronin@chromium.org","riajiang@chromium.org","rockot@chromium.org","sahel@chromium.org","scottchen@chromium.org","siggi@chromium.org","simonhatch@chromium.org","skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com","skobes@chromium.org","smcgruer@chromium.org","spang@chromium.org","steimel@chromium.org","takumif@chromium.org","thakis@chromium.org","twellington@chromium.org","vabr@chromium.org","vasilii@chromium.org","wutao@chromium.org","wylieb@chromium.org","xhwang@chromium.org","xiaohuic@google.com","zynis@yandex-team.ru"] Build
branch "master" Build
buildnumber 60765 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1526494797 Build
revision "4344b812321a1c1c021723e5f6fce77920688c0e" Build
slavename "vm108-m1" BuildSlave
buildername "ios-device-xcode-clang" Builder
git_revision "4344b812321a1c1c021723e5f6fce77920688c0e" Change
scheduler "ios" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.mac/" master.cfg
mastername "chromium.mac" master.cfg
workdir "/b/build/slave/ios-device-xcode-clang" slave

Blamelist:

  1. (cco3ohnoyoudont@chromium.org)
  2. (angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  3. (steimelohnoyoudont@chromium.org)
  4. (mustaqohnoyoudont@google.com)
  5. (charlieaohnoyoudont@chromium.org)
  6. (simonhatchohnoyoudont@chromium.org)
  7. (smcgruerohnoyoudont@chromium.org)
  8. (vabrohnoyoudont@chromium.org)
  9. (achaulkohnoyoudont@google.com)
  10. (danielparkohnoyoudont@chromium.org)
  11. (zynisohnoyoudont@yandex-team.ru)
  12. (jchinleeohnoyoudont@chromium.org)
  13. (spangohnoyoudont@chromium.org)
  14. (wutaoohnoyoudont@chromium.org)
  15. (rdevlin.croninohnoyoudont@chromium.org)
  16. (jkardatzkeohnoyoudont@google.com)
  17. (dmazzoniohnoyoudont@chromium.org)
  18. (xiaohuicohnoyoudont@google.com)
  19. (skobesohnoyoudont@chromium.org)
  20. (pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  21. (rockotohnoyoudont@chromium.org)
  22. (dmazzoniohnoyoudont@chromium.org)
  23. (siggiohnoyoudont@chromium.org)
  24. (rbpotterohnoyoudont@chromium.org)
  25. (sahelohnoyoudont@chromium.org)
  26. (jdoerrieohnoyoudont@chromium.org)
  27. (riajiangohnoyoudont@chromium.org)
  28. (skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  29. (dtsengohnoyoudont@chromium.org)
  30. (twellingtonohnoyoudont@chromium.org)
  31. (afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com)
  32. (steimelohnoyoudont@chromium.org)
  33. (bsazonovohnoyoudont@chromium.org)
  34. (aleventhalohnoyoudont@chromium.org)
  35. (djacoboohnoyoudont@chromium.org)
  36. (skobesohnoyoudont@chromium.org)
  37. (pwnallohnoyoudont@chromium.org)
  38. (dtrainorohnoyoudont@chromium.org)
  39. (camurcuohnoyoudont@google.com)
  40. (agrieveohnoyoudont@chromium.org)
  41. (wyliebohnoyoudont@chromium.org)
  42. (jdufaultohnoyoudont@google.com)
  43. (hansberryohnoyoudont@chromium.org)
  44. (fdegansohnoyoudont@chromium.org)
  45. (thakisohnoyoudont@chromium.org)
  46. (khmelohnoyoudont@google.com)
  47. (camurcuohnoyoudont@google.com)
  48. (xhwangohnoyoudont@chromium.org)
  49. (scottchenohnoyoudont@chromium.org)
  50. (vasiliiohnoyoudont@chromium.org)
  51. (takumifohnoyoudont@chromium.org)
  52. (kojiiohnoyoudont@chromium.org)
  53. (aeeohnoyoudont@chromium.org)
  54. (majidvpohnoyoudont@chromium.org)

Timing:

Create N/A
Start Wednesday, 16-May-18 19:57:52 UTC
End Wednesday, 16-May-18 21:13:19 UTC
Pending N/A
Execution 1 hrs 15 mins

All Changes:

  1. physicalweb: Remove vestiges of the Physical Web

    Changed by cco3ohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:18:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7c50e14e4fb1a885bd5013d6ba918d100307ce1e

    Comments

    physicalweb: Remove vestiges of the Physical Web
    
    This change removes all code related to the Physical Web.
    
    BUG=826540
    
    Change-Id: Ifda5d80c5cebeedf2e2fdf48142e6dd6c1ef73b6
    Reviewed-on: https://chromium-review.googlesource.com/1054335
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
    Commit-Queue: Conley Owens <cco3@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559187}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
    • chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java
    • chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java
    • chrome/android/java/src/org/chromium/chrome/browser/physicalweb/Utils.java
    • chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
    • chrome/android/java_sources.gni
    • chrome/browser/android/chrome_feature_list.cc
    • chrome/browser/android/chrome_feature_list.h
    • tools/metrics/actions/actions.xml
    • tools/metrics/histograms/histograms.xml
  2. Roll src/third_party/angle/ 80c32ccbb..e943df226 (1 commit)

    Changed by angle-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 16-May-18 18:18:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 35a2ef825c9824162ea19ecb8ed2b4f5e9f98a0f

    Comments

    Roll src/third_party/angle/ 80c32ccbb..e943df226 (1 commit)
    
    https://chromium.googlesource.com/angle/angle.git/+log/80c32ccbbcc6..e943df226e2b
    
    $ git log 80c32ccbb..e943df226 --date=short --no-merges --format='%ad %ae %s'
    2018-05-15 geofflang Add more dEQP EGL expectations for Linux and Android.
    
    Created with:
      roll-dep src/third_party/angle
    
    
    The AutoRoll server is located here: https://angle-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/m
    ...skip...
    luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=ynovikov@chromium.org
    
    Change-Id: I7a197d7aecefe6b74636da1804603ecfad5546d8
    Reviewed-on: https://chromium-review.googlesource.com/1062005
    Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559188}

    Changed files

    • DEPS
  3. Remove unused sizing-tiny class and don't add sizing to audio controls

    Changed by steimelohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:22:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b6416233fb500779ca782b7420a2212e0466d99a

    Comments

    Remove unused sizing-tiny class and don't add sizing to audio controls
    
    This CL removes the sizing-tiny breakpoint from the media controls,
    since there are no CSS differences between the sizing-small and
    sizing-tiny classes.
    
    This CL also avoids setting the sizing-* classes on audio controls (and
    video controls acting as audio controls) in order to avoid unwanted
    CSS changes for the audio controls.
    
    Bug: 839088
    Change-Id: I3c9ba1119572d0b0f8bec6d8f6c261ff192c96f3
    Reviewed-on: https://chromium-review.googlesource.com/1060281
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559189}

    Changed files

    • third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt
    • third_party/WebKit/LayoutTests/media/controls/resizing-changes-css-class.html
    • third_party/WebKit/LayoutTests/paint/invalidation/video-paint-invalidation-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/compositing/squashing/dont-squash-into-videos-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/compositing/video/video-poster-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
    • third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spv175/paint/invalidation/video-paint-invalidation-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/compositing/video/video-poster-expected.txt
    • third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/compositing/video/video-poster-expected.txt
    • third_party/WebKit/LayoutTests/platform/win/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
    • third_party/WebKit/LayoutTests/virtual/disable-spv175/compositing/squashing/dont-squash-into-videos-expected.txt
    • third_party/WebKit/LayoutTests/virtual/disable-spv175/compositing/video/video-poster-expected.txt
    • third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/image/canvas-composite-repaint-by-all-imagesource-expected.txt
    • third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/video-paint-invalidation-expected.txt
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
  4. Fix user activation v2 trigger for a WebXR input.

    Changed by mustaqohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 18:24:03 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 47cf7037cbde6c278e987cde18da3ec8b7a86996

    Comments

    Fix user activation v2 trigger for a WebXR input.
    
    Bug: 843366
    Change-Id: Ifa1d702a1357e4f508f708b5cf9783d0db90ad06
    Reviewed-on: https://chromium-review.googlesource.com/1062009
    Reviewed-by: Brandon Jones <bajones@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559190}

    Changed files

    • third_party/blink/renderer/core/frame/local_frame.h
    • third_party/blink/renderer/modules/xr/xr_session.cc
  5. Move all bot health images into an images/ directory

    Changed by charlieaohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:25:06 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3156913e47bc977103363ebc19219bd88ab4872e

    Comments

    Move all bot health images into an images/ directory
    
    TBR=eyaich@chromium.org
    
    Bug: 842232
    Change-Id: I01d6db483807f9e7840434f586e608b8d92a490a
    Reviewed-on: https://chromium-review.googlesource.com/1062285
    Reviewed-by: Charlie Andrews <charliea@chromium.org>
    Commit-Queue: Charlie Andrews <charliea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559191}

    Changed files

    • docs/speed/bot_health_sheriffing/how_to_access_test_logs.md
    • docs/speed/bot_health_sheriffing/how_to_address_duplicate_alerts.md
    • docs/speed/bot_health_sheriffing/how_to_snooze_an_alert.md
    • docs/speed/bot_health_sheriffing/images/bulk_ungroup.png
    • docs/speed/bot_health_sheriffing/images/change_group_name.png
    • docs/speed/bot_health_sheriffing/images/flakiness_dashboard.png
    • docs/speed/bot_health_sheriffing/images/group_all.png
    • docs/speed/bot_health_sheriffing/images/snooze_alert.png
    • docs/speed/bot_health_sheriffing/images/snooze_alert_dialog.png
    • docs/speed/bot_health_sheriffing/images/som_choose_build_number.png
    • docs/speed/bot_health_sheriffing/images/som_choose_non_green_only.png
    • docs/speed/bot_health_sheriffing/images/som_examine.png
    • docs/speed/bot_health_sheriffing/images/som_examine_choose_bot.png
    • docs/speed/bot_health_sheriffing/images/som_shard_0.png
    • docs/speed/bot_health_sheriffing/images/som_test_steps_shard_0.png
    • docs/speed/bot_health_sheriffing/images/ungroup_all.png
    • docs/speed/bot_health_sheriffing/what_test_is_failing.md
  6. [Perf] Enable some smaller benchmarks for histogram uploads

    Changed by simonhatchohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:26:14 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e320062a8adeabedc679bf73f652fa316467021f

    Comments

    [Perf] Enable some smaller benchmarks for histogram uploads
    
    Landing this for eakuefner@ since he's OOO this week.
    
    This CL switches some smaller benchmarks to the histogram pipeline.
    Ie. thread_times, battor, tracing_with_*, etc.
    
    Bug: 744736
    Change-Id: I5bafea53e9d8b82bb3d38559192ab54565b63f44
    Reviewed-on: https://chromium-review.googlesource.com/1059937
    Reviewed-by: Emily Hanley <eyaich@chromium.org>
    Commit-Queue: Simon Hatch <simonhatch@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559192}

    Changed files

    • testing/buildbot/chromium.perf.json
    • testing/scripts/run_performance_tests.py
    • tools/perf/core/perf_data_generator.py
  7. [cc/animation] Remove some dead code

    Changed by smcgruerohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:26:57 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ac6e09311fcc7e734be2ef21a9ccbbe04c4c4706

    Comments

    [cc/animation] Remove some dead code
    
    Code was found via Chromium coverage report and then some sleuthing to
    spot a method that was only called from a test.
    
    Bug: 252472
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I7223c9210d336fbec89b923e903bd95a64865d40
    Reviewed-on: https://chromium-review.googlesource.com/1060106
    Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559193}

    Changed files

    • cc/animation/animation_curve.h
    • cc/animation/keyframed_animation_curve.cc
    • cc/animation/keyframed_animation_curve.h
    • cc/animation/keyframed_animation_curve_unittest.cc
    • cc/animation/timing_function.cc
    • cc/animation/timing_function.h
    • cc/test/animation_test_common.cc
    • cc/test/animation_test_common.h
    • ui/compositor/transform_animation_curve_adapter.cc
    • ui/compositor/transform_animation_curve_adapter.h
  8. Handle null FILE* in CompressAndSaveBitmap

    Changed by vabrohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:27:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6abe484c9ba102324b9d92f27dfeb3a7e05034bc

    Comments

    Handle null FILE* in CompressAndSaveBitmap
    
    This might be causing the crashes seen in the associated bug. In any
    case, it is a good idea to handle the failure, because the reasons why
    that FILE* can be null are beyond Chrome's control.
    
    Bug: 838639
    Change-Id: I700266840c1447c0b999aa91a361bfba3ff2710b
    Reviewed-on: https://chromium-review.googlesource.com/1060057
    Commit-Queue: Vaclav Brozek <vabr@chromium.org>
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559194}

    Changed files

    • content/browser/web_contents/web_contents_android.cc
  9. [Chromecast] Add accessibilityPrivate API stubs to chromecast

    Changed by achaulkohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 18:28:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8327a881ecdf3d13db14e7ada95b5d5d4fe227e9

    Comments

    [Chromecast] Add accessibilityPrivate API stubs to chromecast
    
    Implementation is being ported in another CL
    https://chromium-review.googlesource.com/c/chromium/src/+/1015553
    & followups
    
    Bug: b/78445519
    Test: local build
    Change-Id: If215057180bcc762864b32b82433f74211f4c311
    Reviewed-on: https://chromium-review.googlesource.com/1025373
    Commit-Queue: Albert Chaulk <achaulk@chromium.org>
    Reviewed-by: Luke Halliwell <halliwell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559195}

    Changed files

    • chromecast/browser/BUILD.gn
    • chromecast/browser/extensions/api/accessibility_private/accessibility_extension_api.cc
    • chromecast/browser/extensions/api/accessibility_private/accessibility_extension_api.h
    • chromecast/common/extensions_api/BUILD.gn
    • chromecast/common/extensions_api/_api_features.json
    • chromecast/common/extensions_api/_permission_features.json
    • chromecast/common/extensions_api/accessibility_private.json
  10. [Modern] Fixes inconsistent suggestion view layouts for RTL

    Changed by danielparkohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:28:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision be361679741d438622661563385216230b7db437

    Comments

    [Modern] Fixes inconsistent suggestion view layouts for RTL
    
    The delete button's size is always accounted for when
      laying out suggestion views
    
    Adds padding to the omnibox text when voice search is disabled for RTL
    
    See crbug link for photos.
    
    Bug: 833342
    Change-Id: I2b35be70d4296abf7eae318d5dccea4d0201c91f
    Reviewed-on: https://chromium-review.googlesource.com/1054201
    Reviewed-by: Theresa <twellington@chromium.org>
    Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
    Commit-Queue: Daniel Park <danielpark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559196}

    Changed files

    • chrome/android/java/res/layout/new_tab_page_layout.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBar.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
    • chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java
    • chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
  11. [clang-tidy] Readability fixes for src/components/[d-l].*

    Changed by zynisohnoyoudont@yandex-team.ru
    Changed at Wednesday, 16-May-18 18:29:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ead3f745666b12ade97a50b8ad48cab0d24e5afb

    Comments

    [clang-tidy] Readability fixes for src/components/[d-l].*
    
    - Get rid of redundant .c_str() for std::string,
    - Get rid of redundant .get() for std::unique_ptr,
    - Get rid of redundant member initializations
    - Replace NULL -> nullptr.
    
    R=blundell@chromium.org, caitkp@chromium.org, jochen@chromium.org, sdefresne@chromium.org
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Ic043a0bf296132eadd1b8a6e349d3a5f903fbaec
    Reviewed-on: https://chromium-review.googlesource.com/1045965
    Reviewed-by: Scott Violet <sky@chromium.org>
    Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru>
    Cr-Commit-Position: refs/heads/master@{#559197}

    Changed files

    • components/data_usage/core/data_use_aggregator_unittest.cc
    • components/favicon/core/large_icon_service_unittest.cc
    • components/feature_engagement/internal/configuration.cc
    • components/feature_engagement/internal/event_model_impl.cc
    • components/feature_engagement/internal/event_model_impl_unittest.cc
    • components/feature_engagement/internal/in_memory_event_store.cc
    • components/feature_engagement/internal/persistent_event_store.cc
    • components/feature_engagement/internal/tracker_impl_unittest.cc
    • components/feed/core/feed_image_manager.cc
    • components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc
    • components/gcm_driver/crypto/gcm_message_cryptographer_unittest.cc
    • components/gcm_driver/gcm_channel_status_request.cc
    • components/gcm_driver/gcm_client_impl.cc
    • components/gcm_driver/gcm_driver_desktop.cc
    • components/grpc_support/bidirectional_stream_unittest.cc
    • components/grpc_support/test/get_stream_engine.cc
    • components/guest_view/browser/guest_view_manager.cc
    • components/guest_view/browser/test_guest_view_manager.cc
    • components/guest_view/renderer/guest_view_container.cc
    • components/heap_profiling/client_connection_manager.cc
    • components/history/core/browser/delete_directive_handler.cc
    • components/history/core/browser/expire_history_backend_unittest.cc
    • components/history/core/browser/history_backend_unittest.cc
    • components/history/core/browser/history_database_params.cc
    • components/history/core/browser/history_model_worker.cc
    • components/history/core/browser/history_service.cc
    • components/history/core/browser/in_memory_database.cc
    • components/history/core/browser/thumbnail_database_unittest.cc
    • components/history/core/browser/top_sites.cc
    • components/history/core/browser/typed_url_sync_bridge.cc
    • components/history/core/browser/web_history_service.cc
    • components/history/core/test/history_backend_db_base_test.cc
    • components/infobars/core/confirm_infobar_delegate.cc
    • components/infobars/core/simple_alert_infobar_delegate.cc
    • components/invalidation/impl/fake_invalidator_unittest.cc
    • components/invalidation/impl/invalidation_notifier_unittest.cc
    • components/invalidation/impl/invalidator_registrar_unittest.cc
    • components/invalidation/impl/invalidator_storage.cc
    • components/invalidation/impl/non_blocking_invalidator.cc
    • components/invalidation/impl/non_blocking_invalidator_unittest.cc
    • components/invalidation/impl/object_id_invalidation_map_unittest.cc
    • components/invalidation/impl/p2p_invalidator.cc
    • components/invalidation/impl/p2p_invalidator_unittest.cc
    • components/invalidation/impl/per_user_topic_registration_request.cc
    • components/invalidation/impl/single_object_invalidation_set_unittest.cc
    • components/invalidation/impl/sync_invalidation_listener.cc
    • components/invalidation/impl/ticl_invalidation_service.cc
    • components/invalidation/impl/unacked_invalidation_set.cc
    • components/invalidation/impl/unacked_invalidation_set_test_util.cc
    • components/invalidation/impl/unacked_invalidation_set_unittest.cc
    • components/invalidation/public/invalidation.cc
    • components/invalidation/public/object_id_invalidation_map.cc
    • components/json_schema/json_schema_validator_unittest.cc
    • components/json_schema/json_schema_validator_unittest_base.cc
    • components/language/content/browser/geo_language_provider.cc
    • components/login/screens/screen_context_unittest.cc
  12. Configure remaining .*chromium.chromiumos.

    Changed by jchinleeohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:32:02 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8a18542e119bcff25f871ccd5cb241b67db1f86a

    Comments

    Configure remaining .*chromium.chromiumos.
    
    BUG=793909,793906,793945,793946
    
    Change-Id: Iac8f30fd03b8cd5d95dded09a932cc695983bf1f
    Reviewed-on: https://chromium-review.googlesource.com/1060635
    Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
    Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559198}

    Changed files

    • infra/config/branch/cq.cfg
    • infra/config/global/cr-buildbucket.cfg
    • infra/config/global/luci-milo.cfg
    • infra/config/global/luci-scheduler.cfg
  13. vulkan: Mark remaining single argument ctors explicit

    Changed by spangohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:33:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 35a7f010d1b73786c203cc61feaaa1f99b974f8d

    Comments

    vulkan: Mark remaining single argument ctors explicit
    
    Bug: none
    Test: compile
    
    Change-Id: I6bc5009527bdf9efbfc5fe935aa86856ee491711
    Reviewed-on: https://chromium-review.googlesource.com/1061396
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Commit-Queue: Michael Spang <spang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559199}

    Changed files

    • gpu/vulkan/vulkan_implementation_x11.h
    • gpu/vulkan/vulkan_shader_module.h
  14. cros: Fix Shortcut Viewer labels for non-Qwerty layout

    Changed by wutaoohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:33:15 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e5495df1a9e81b3f87bd652929d71feb379a7a8d

    Comments

    cros: Fix Shortcut Viewer labels for non-Qwerty layout
    
    Currently for non-Qwerty keyboard layout, Shortcut Viewer returns
    incorrect keys. This cl fixes the bug by creating a reverse mapping from
    dom_code to {dom_key, key_code}.
    
    Bug: 841670
    Test: manually.
    Change-Id: Ib75bf84b34c0b03bf5501fab0586db8e750478bc
    Reviewed-on: https://chromium-review.googlesource.com/1058080
    Commit-Queue: Tao Wu <wutao@chromium.org>
    Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
    Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559200}

    Changed files

    • ash/components/shortcut_viewer/keyboard_shortcut_viewer_metadata.cc
    • ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.cc
    • ash/components/shortcut_viewer/views/keyboard_shortcut_item_view.h
    • ash/components/shortcut_viewer/views/keyboard_shortcut_view.cc
  15. [Extensions] Properly classify privilege increase for swapping permissions

    Changed by rdevlin.croninohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:34:21 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision f04a75acce94425f92dc9d517f92abfabccf1665

    Comments

    [Extensions] Properly classify privilege increase for swapping permissions
    
    Correct a bug where an extension would be improperly disabled for a
    privilege increase when it went from a more powerful permission to a
    less powerful one, if the permission messages were different.
    
    Previously, privilege escalation code would look check if there were any
    warning strings in the new set of permissions that were not in the old
    set. This failed, because a new warning (not contained in the previous
    set) might be l
    ...skip...
    ons" with
    "granted_permissions" and "requested_permissions", respectively.
    
    Add a regression test for the same.
    
    TBR=slan@chromium.org
    
    Bug: 841938
    Change-Id: I41542c6813c1f4a2f0318609bd75b838eef00cb5
    Reviewed-on: https://chromium-review.googlesource.com/1054607
    Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
    Reviewed-by: Stephen Lanham <slan@chromium.org>
    Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: Marc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559201}

    Changed files

    • chrome/common/extensions/permissions/chrome_permission_message_provider.cc
    • chrome/common/extensions/permissions/chrome_permission_message_provider.h
    • chrome/common/extensions/permissions/chrome_permission_message_provider_unittest.cc
    • chrome/common/extensions/permissions/permission_set_unittest.cc
    • chromecast/common/cast_extensions_client.cc
    • extensions/common/permissions/permission_message_provider.h
    • extensions/shell/common/shell_extensions_client.cc
    • extensions/test/test_permission_message_provider.cc
    • extensions/test/test_permission_message_provider.h
  16. Pass cryptohome_id into the StartContainer call

    Changed by jkardatzkeohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 18:34:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c613fec7bf46edabb6fdbaf5972159f6bb51a32c

    Comments

    Pass cryptohome_id into the StartContainer call
    
    Bug: 832508
    Test: Verified key generation by concierge from Chrome call
    Change-Id: Ie031d59ab95da3f5394c9621413a5a48066619a5
    Reviewed-on: https://chromium-review.googlesource.com/1053273
    Reviewed-by: Nicholas Verne <nverne@chromium.org>
    Reviewed-by: Joel Hockey <joelhockey@chromium.org>
    Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
    Cr-Commit-Position: refs/heads/master@{#559202}

    Changed files

    • chrome/browser/chromeos/crostini/crostini_manager.cc
    • chrome/browser/chromeos/crostini/crostini_manager.h
    • chrome/browser/chromeos/crostini/crostini_manager_unittest.cc
  17. Expose Android accessibility focus to Blink accessibility internals

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:38:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision af5f52b07b719e58963a559d67bdde054c8c3f84

    Comments

    Expose Android accessibility focus to Blink accessibility internals
    
    Bug: 841218
    TBR=michaelpg@chromium.org
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: Iaea99a1a18c1eea7d1480b68b4a1aa71448d09d1
    Reviewed-on: https://chromium-review.googlesource.com/1050498
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Mike West <mkwst@chromium.org>
    Reviewed-by: David Tseng <dtseng@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559203}

    Changed files

    • chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
    • chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
    • chrome/common/extensions/api/automation.idl
    • content/browser/accessibility/browser_accessibility_manager.cc
    • content/browser/accessibility/browser_accessibility_manager.h
    • content/browser/accessibility/web_contents_accessibility_android.cc
    • content/browser/accessibility/web_contents_accessibility_android.h
    • content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
    • content/renderer/accessibility/render_accessibility_impl.cc
    • third_party/blink/public/web/web_ax_object.h
    • third_party/blink/renderer/modules/accessibility/ax_object.cc
    • third_party/blink/renderer/modules/accessibility/ax_object.h
    • third_party/blink/renderer/modules/exported/web_ax_object.cc
    • third_party/closure_compiler/externs/automation.js
    • ui/accessibility/ax_enum_util.cc
    • ui/accessibility/ax_enums.mojom
    • ui/accessibility/ax_node_data.cc
  18. Update chromeos assistant watch dirs

    Changed by xiaohuicohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 18:41:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 985c26b1998fbf4b80a70d8e85d04dc0e55e1b8b

    Comments

    Update chromeos assistant watch dirs
    
    R=xiyuan
    
    Bug: None
    Change-Id: I9a0b6decf9e2eae5d58ef74e5f482854592f054e
    Reviewed-on: https://chromium-review.googlesource.com/1062022
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559204}

    Changed files

    • WATCHLISTS
  19. RLS: Deparameterize core/{dom,editing,clipboard,loader} unit tests.

    Changed by skobesohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:48:28 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2ddcb71eb873738b7067779c64db2e329b7013ba

    Comments

    RLS: Deparameterize core/{dom,editing,clipboard,loader} unit tests.
    
    Bug: 823365
    Change-Id: I34bd09b180ed8c7403217d0931cf2e765dc951d8
    Reviewed-on: https://chromium-review.googlesource.com/1062288
    Reviewed-by: Philip Rogers <pdr@chromium.org>
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559205}

    Changed files

    • third_party/blink/renderer/core/clipboard/data_transfer_test.cc
    • third_party/blink/renderer/core/dom/document_test.cc
    • third_party/blink/renderer/core/editing/rendered_position_test.cc
    • third_party/blink/renderer/core/loader/programmatic_scroll_test.cc
  20. Roll src/third_party/pdfium/ 99a046acd..67268cd0e (4 commits)

    Changed by pdfium-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 16-May-18 18:51:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision adbc5eb95efdf4a88be3e01d698237189217baa0

    Comments

    Roll src/third_party/pdfium/ 99a046acd..67268cd0e (4 commits)
    
    https://pdfium.googlesource.com/pdfium.git/+log/99a046acd2d1..67268cd0efa2
    
    $ git log 99a046acd..67268cd0e --date=short --no-merges --format='%ad %ae %s'
    2018-05-16 dsinclair Cleanup CPDF_ContentParser
    2018-05-16 tsepez Use pdfium::span<> in CPDF_Encryptor
    2018-05-16 dsinclair Remove CFX_BidiLine
    2018-05-16 dsinclair Convert Formcalc ToJavascript to a pointer WideTextBuf
    
    Created with:
      roll-dep src/third_party/pdfium
    
    
    The AutoRoll serve
    ...skip...
    current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=dsinclair@chromium.org
    
    Change-Id: I62d1fbb948e1971ead399113ac157004ca96a473
    Reviewed-on: https://chromium-review.googlesource.com/1062024
    Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559206}

    Changed files

    • DEPS
  21. Simplify mojo_base shared memory region support

    Changed by rockotohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:51:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca7ae9dd61c89912b01ae313d8486e3ebc96a0fb

    Comments

    Simplify mojo_base shared memory region support
    
    Changes the SharedMemoryRegion types in mojo_base mojom to use a
    handle<shared_buffer> as their internal representation. This simplifies
    the traits and makes these region types usable in Java and JS.
    
    Bug: 826213
    Change-Id: Id515f61f34b85c655b70d45d53302e873547a83a
    Reviewed-on: https://chromium-review.googlesource.com/1059008
    Commit-Queue: Ken Rockot <rockot@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559207}

    Changed files

    • mojo/public/cpp/base/shared_memory_mojom_traits.cc
    • mojo/public/cpp/base/shared_memory_mojom_traits.h
    • mojo/public/cpp/base/shared_memory_unittest.cc
    • mojo/public/mojom/base/shared_memory.mojom
  22. Add a new WebContentsAccessibilityTest

    Changed by dmazzoniohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:53:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 25304bc21625e4fb94ed283a4f6a9f2fa2ac4431

    Comments

    Add a new WebContentsAccessibilityTest
    
    Bug: None
    Change-Id: Ic63e1619729b79dc5c6010fed3223895c72c5999
    Reviewed-on: https://chromium-review.googlesource.com/679446
    Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    Reviewed-by: Paul Miller <paulmiller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559208}

    Changed files

    • content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java
  23. RC: Capture cumulative process CPU measurements in render process probe.

    Changed by siggiohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:56:46 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d49fd528eb51d951b6747a241b41a6e4485b492d

    Comments

    RC: Capture cumulative process CPU measurements in render process probe.
    
    The old-style CPUUsage attributes are supported by transforming the
    batched cumulatives in the System CU.
    
    Bug: 755840
    Change-Id: I3e5d3d66223070a90ad35a835a210db0bb257809
    Reviewed-on: https://chromium-review.googlesource.com/1060127
    Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
    Reviewed-by: Will Harris <wfh@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Reviewed-by: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559209}

    Changed files

    • chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.cc
    • chrome/browser/resource_coordinator/resource_coordinator_render_process_probe.h
    • chrome/browser/resource_coordinator/resource_coordinator_render_process_probe_browsertest.cc
    • services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h
    • services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc
    • services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h
    • services/resource_coordinator/coordination_unit/system_coordination_unit_impl_unittest.cc
    • services/resource_coordinator/public/mojom/coordination_unit.mojom
  24. Print Preview Componentization: Add timeout to selects

    Changed by rbpotterohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:57:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a4d6263c15d92ec6fc3b590b396e103a080fc255

    Comments

    Print Preview Componentization: Add timeout to selects
    
    Add a timeout to the select sections, so that the preview does not
    immediately begin generating and freeze the dropdown when the value
    is changed.
    
    Bug: 773928
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: If217c25420815f56a7c37adde7e97f86bcc99fa3
    Reviewed-on: https://chromium-review.googlesource.com/1056216
    Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559210}

    Changed files

    • chrome/browser/resources/print_preview/new/BUILD.gn
    • chrome/browser/resources/print_preview/new/color_settings.html
    • chrome/browser/resources/print_preview/new/color_settings.js
    • chrome/browser/resources/print_preview/new/layout_settings.html
    • chrome/browser/resources/print_preview/new/layout_settings.js
    • chrome/browser/resources/print_preview/new/margins_settings.html
    • chrome/browser/resources/print_preview/new/margins_settings.js
    • chrome/browser/resources/print_preview/new/pages_per_sheet_settings.html
    • chrome/browser/resources/print_preview/new/pages_per_sheet_settings.js
    • chrome/browser/resources/print_preview/new/select_behavior.html
    • chrome/browser/resources/print_preview/new/select_behavior.js
    • chrome/browser/resources/print_preview/new/settings_select.html
    • chrome/browser/resources/print_preview/new/settings_select.js
    • chrome/browser/resources/print_preview/print_preview_resources.grd
    • chrome/test/data/webui/print_preview/settings_section_test.js
  25. Additional tracing in cc smooth scrolling path.

    Changed by sahelohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:59:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ca207e09127fb66ce6cdf09eff5f08fb2bac9dc0

    Comments

    Additional tracing in cc smooth scrolling path.
    
    This cl adds tracing to answer the following questions to be able to
    further narrow down the root cause of crbug.com/797708
    
    -When did the last call to SetCurrentlyScrollingNode happen? (other than
    on PushPropertyTrees after each commit)
    -Is animation tick needed? (due to an ongoing animation)
    -Whether the animation_host notifies the compositor about animation end
    or not?
    -When does the CurrentlyScrollingNode get cleared?
    
    Bug: 797708
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I70f2295905798e430ce080c26f6924617504491b
    Reviewed-on: https://chromium-review.googlesource.com/1060302
    Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
    Reviewed-by: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559211}

    Changed files

    • cc/animation/animation_host.cc
    • cc/trees/layer_tree_host_impl.cc
  26. [base] Provide ITypedEventHandler Implementation

    Changed by jdoerrieohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 18:59:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 07e67cc7ed7a9784f450efac3bddc8213efc49dd

    Comments

    [base] Provide ITypedEventHandler Implementation
    
    This change provides an implementation of Windows::Foundation's
    ITypedEventHandlder. It serves as a thin wrapper around a
    base::RepeatingCallback of the appropriate signature.
    
    Bug: 821766
    Change-Id: Ib940ebc5a4d90e5304be2c08839efbc020011180
    Reviewed-on: https://chromium-review.googlesource.com/1060054
    Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Reviewed-by: Robert Liao <robliao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559212}

    Changed files

    • base/BUILD.gn
    • base/win/typed_event_handler.h
    • base/win/typed_event_handler_unittest.cc
  27. Add finch testing config for VizHitTestDrawQuad.

    Changed by riajiangohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:00:41 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4ae8cd29d704de6767b1c323095f565b97acef39

    Comments

    Add finch testing config for VizHitTestDrawQuad.
    
    Bug: 804888
    Change-Id: I9a4783a4dd29150e2dbf13c4a3ca43eea8b1b510
    Reviewed-on: https://chromium-review.googlesource.com/1053907
    Commit-Queue: Ria Jiang <riajiang@chromium.org>
    Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559213}

    Changed files

    • testing/variations/fieldtrial_testing_config.json
  28. Roll src/third_party/skia/ 510e9e399..d6b41a276 (7 commits)

    Changed by skia-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 16-May-18 19:03:42 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5ab83718c5f8c079c34735d06ee9eddccdc30149

    Comments

    Roll src/third_party/skia/ 510e9e399..d6b41a276 (7 commits)
    
    https://skia.googlesource.com/skia.git/+log/510e9e399b3d..d6b41a27678f
    
    $ git log 510e9e399..d6b41a276 --date=short --no-merges --format='%ad %ae %s'
    2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms ce2fabc..e040063 (1 commits)
    2018-05-15 benjaminwagner Add MacBookPro11,5 jobs.
    2018-05-16 rmistry Fix capitalization of "twitter" in RecreateSKPs bot
    2018-05-15 rmistry Run RecreateSKPs bot on SkiaCT pool which has more disk space
    2018
    ...skip...
    sts_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    TBR=herb@chromium.org
    
    Change-Id: Ifc36f79f4df2d258f9c286e992f3789fbb16f031
    Reviewed-on: https://chromium-review.googlesource.com/1062019
    Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559214}

    Changed files

    • DEPS
  29. Re-enable ChromeVox panel menus on all screens

    Changed by dtsengohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:04:24 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2616e06d10316811fefe09ea2a2da9e935c05a42

    Comments

    Re-enable ChromeVox panel menus on all screens
    
    - add a contextmenu event capturer which prevents the context menu from showing up via right click or key shortcut.
    This appears to have ben the primary motivation behind the original patch.
    However, it disables critical ChromeVox functionality in places where it is most important (e.g. OOBE).
    
    - fix a small type error (not cuaght by Closure). |evt.docUrl should be evt.target.docUrl).
    
    Bug: 699760
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I4f47b298daad449d5d92b176c6e805201db94153
    Reviewed-on: https://chromium-review.googlesource.com/1060381
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559215}

    Changed files

    • chrome/browser/chromeos/accessibility/accessibility_manager.cc
    • chrome/browser/chromeos/accessibility/accessibility_manager.h
    • chrome/browser/chromeos/accessibility/chromevox_panel.cc
    • chrome/browser/chromeos/accessibility/chromevox_panel.h
    • chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css
    • chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
    • chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_command.js
  30. Add feedback PSD for the simplified NTP experiment

    Changed by twellingtonohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:08:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 7df4d93dab7017774bdd3dc92efa9a6ca9d87536

    Comments

    Add feedback PSD for the simplified NTP experiment
    
    BUG=843585
    
    Change-Id: I995039a1173771c91acc5dd04a60d6e1499ea9b2
    Reviewed-on: https://chromium-review.googlesource.com/1062148
    Reviewed-by: David Trainor <dtrainor@chromium.org>
    Commit-Queue: Theresa <twellington@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559216}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/feedback/FeedbackCollector.java
    • chrome/android/java/src/org/chromium/chrome/browser/feedback/SimplifiedNtpFeedbackSource.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
    • chrome/android/java_sources.gni
  31. Roll AFDO from 68.0.3432.0_rc-r1 to 68.0.3432.0_rc-r2

    Changed by afdo-chromium-autorollohnoyoudont@skia-buildbots.google.com.iam.gserviceaccount.com
    Changed at Wednesday, 16-May-18 19:10:36 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3f1e986f9c213d8d8833a8a006771568808c5227

    Comments

    Roll AFDO from 68.0.3432.0_rc-r1 to 68.0.3432.0_rc-r2
    
    This CL may cause a small binary size increase, roughly proportional
    to how long it's been since our last AFDO profile roll. For larger
    increases (around or exceeding 100KB), please file a bug against
    gbiv@chromium.org. Additional context: https://crbug.com/805539
    
    The AutoRoll server is located here: https://afdo-chromium-roll.skia.org
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
    
    I
    ...skip...
     contact the current sheriff, who should
    be CC'd on the roll, and stop the roller if necessary.
    
    
    TBR=gbiv@chromium.org
    
    Change-Id: I98e91beb09d8e76fe0fd2337f3a2e52c4e6a16d9
    Reviewed-on: https://chromium-review.googlesource.com/1062332
    Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#559217}

    Changed files

    • chrome/android/profiles/newest.txt
  32. [Media Controls] Only act as audio element when controls are enabled

    Changed by steimelohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:11:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 00c3cffbbeff11db315ac4d74bb274558a9f26d6

    Comments

    [Media Controls] Only act as audio element when controls are enabled
    
    This CL prevents video tags from acting as audio tags when the controls
    are not enabled. This fixes a bug where video tags with only audio were
    showing the audio controls background despite the controls being
    hidden.
    
    Bug: 843101
    Change-Id: Ic7bb98b198a6ec7c497d233d40d673d7cfa7e44e
    Reviewed-on: https://chromium-review.googlesource.com/1062225
    Reviewed-by: Becca Hughes <beccahughes@chromium.org>
    Commit-Queue: Tommy Steimel <steimel@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559218}

    Changed files

    • third_party/WebKit/LayoutTests/media/controls/video-does-not-act-as-audio-tag-with-controls-hidden.html
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
    • third_party/blink/renderer/modules/media_controls/media_controls_impl.h
  33. [Unity][Android] Reimplement account selection in SigninFragmentBase

    Changed by bsazonovohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:12:52 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 238ad54d692af7edccf8249f340a353a77cd4151

    Comments

    [Unity][Android] Reimplement account selection in SigninFragmentBase
    
    This CL reimplements how SigninFragmentBase selects accounts after
    creation or when a new account is added. Also, account name is no longer
    ignored in forced sign-in flows (condition that checks
    mPreselectedAccount in updateAccounts has been overwriting account name
    requested by the sign-in arguments). mIsDefaultAccountSelected flag is
    now always computed by updateAccounts, so the corresponding parameter
    has been removed from createArgumentsForForcedSigninFlow.
    
    Bug: 814728
    Change-Id: I82b6a1520d0e30757058bb7ff226b9be1550f909
    Reviewed-on: https://chromium-review.googlesource.com/1062265
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559219}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/firstrun/SigninFirstRunFragment.java
    • chrome/android/java/src/org/chromium/chrome/browser/signin/SigninFragmentBase.java
  34. Aria details should force spans to be exposed

    Changed by aleventhalohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:13:26 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a3f82b7c63c3ce90a269a0d344cb0cfc919d892d

    Comments

    Aria details should force spans to be exposed
    
    Bug: 843355
    Change-Id: I837d0c38e7ab986a92e256d24703fc2ba088331d
    Reviewed-on: https://chromium-review.googlesource.com/1060266
    Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559220}

    Changed files

    • content/test/data/accessibility/aria/aria-details-expected-blink.txt
    • content/test/data/accessibility/aria/aria-details-expected-win.txt
    • content/test/data/accessibility/aria/aria-details.html
    • third_party/blink/renderer/modules/accessibility/ax_layout_object.cc
  35. Fix regression for intent picker UI

    Changed by djacoboohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:13:56 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 6187d94092a3ae876cfd6a6a70be23328a0a6bfd

    Comments

    Fix regression for intent picker UI
    
    IntentPickerBubbleView is not saving the user's preference when they
    decide to "Stay in Chrome" + "Remember my choice". This is a regression
    that appeared in M67.
    
    This CL specials case AppType::INVALID to handle saving user's
    preference, previously proposed to add a new AppType::NATIVE_CHROME but
    that sounds wrong given this enum lists non-cros app sources.
    
    Besides that we need to make sure that the preference is communicated
    to ARC via AddPreferredPackage and honored within ArcNavigationThrottle,
    this can be achieved by adding a new enum PreferredPlatform that will
    help DidLaunchPreferredArcApp to be more explicit.
    
    Bug: 841971
    Test: Build.
    Change-Id: I383a926ae613ffe48f4dcd3a478ac124aefe4947
    Reviewed-on: https://chromium-review.googlesource.com/1054584
    Commit-Queue: David Jacobo <djacobo@chromium.org>
    Reviewed-by: Yusuke Sato <yusukes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559221}

    Changed files

    • chrome/browser/chromeos/apps/intent_helper/apps_navigation_throttle.cc
    • chrome/browser/chromeos/apps/intent_helper/apps_navigation_types.h
    • chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
    • chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.h
  36. RLS: Deparameterize core/layout unit tests.

    Changed by skobesohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:15:49 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 662b4400b901bac33f840aebc475ecaf3317a269

    Comments

    RLS: Deparameterize core/layout unit tests.
    
    Bug: 823365
    Change-Id: Iec2e356bc185a0bc24abffd17586cafad1bb17ef
    Reviewed-on: https://chromium-review.googlesource.com/1062126
    Reviewed-by: Stefan Zager <szager@chromium.org>
    Commit-Queue: Steve Kobes <skobes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559222}

    Changed files

    • third_party/blink/renderer/core/layout/layout_count_test.cc
    • third_party/blink/renderer/core/layout/layout_geometry_map_test.cc
    • third_party/blink/renderer/core/layout/map_coordinates_test.cc
    • third_party/blink/renderer/core/layout/scroll_anchor_test.cc
    • third_party/blink/renderer/core/layout/scrollbars_test.cc
  37. Roll src/third_party/leveldatabase/src/ d177a0263..e9098a131 (3 commits)

    Changed by pwnallohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:17:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c4c06e3e9de5c2f450a8739bbf30b1a05a9349a

    Comments

    Roll src/third_party/leveldatabase/src/ d177a0263..e9098a131 (3 commits)
    
    https://chromium.googlesource.com/external/leveldb.git/+log/d177a0263cce..e9098a1311a1
    
    $ git log d177a0263..e9098a131 --date=short --no-merges --format='%ad %ae %s'
    2018-04-19 costan Cleanup SnapshotImpl.
    2018-03-10 costan Add YouCompleteMe configuration.
    2018-04-23 costan Add move constructor to Status.
    
    Created with:
      roll-dep src/third_party/leveldatabase/src
    
    Change-Id: I9aad751c72ea10d81d06ca25ae98e1a6b0f095b4
    Reviewed-on: https://chromium-review.googlesource.com/1033586
    Reviewed-by: Chris Mumford <cmumford@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559223}

    Changed files

    • DEPS
  38. Add a chip widget for the new Download Home UI.

    Changed by dtrainorohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:22:25 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8659809929db28dd1fbfb2370c228e942dfb6753

    Comments

    Add a chip widget for the new Download Home UI.
    
    This adds the complete MVC structure for a generic horizontal list of
    chip views for filter selection.  This will be first used by the new
    Download Home UI.
    
    BUG=839489
    
    Screenshot of widget placed in UI: https://drive.google.com/open?id=1Em7em1jg-GnEdyoGLwHUezfgryuJ-cja
    
    Change-Id: I6a7f8a29280c5aeaf01c7be86c15f3fb64ba0288
    Reviewed-on: https://chromium-review.googlesource.com/1042813
    Reviewed-by: Ted Choc <tedchoc@chromium.org>
    Commit-Queue: David Trainor <dtrainor@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559224}

    Changed files

    • chrome/android/java/res/drawable/chip_bg.xml
    • chrome/android/java/res/layout/chip.xml
    • chrome/android/java/res/values/dimens.xml
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/FilterChipsProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/Filters.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/Chip.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipView.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsCoordinator.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsModel.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsProvider.java
    • chrome/android/java/src/org/chromium/chrome/browser/download/home/filter/chips/ChipsViewBinder.java
    • chrome/android/java_sources.gni
  39. MSG instead of PlatformEvent

    Changed by camurcuohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 19:24:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision e40febf9c2faba354d5fa3732aead3eec08edd37

    Comments

    MSG instead of PlatformEvent
    
    A small appendix to
    https://chromium-review.googlesource.com/c/chromium/src/+/1011109
    
    Change-Id: I7247b274fc2083a743437d9cb5aeec488237cba3
    Reviewed-on: https://chromium-review.googlesource.com/1062213
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Mustafa Çamurcu <camurcu@google.com>
    Cr-Commit-Position: refs/heads/master@{#559225}

    Changed files

    • ui/events/win/events_win_utils.cc
  40. Enable multidex for chrome_public_test_vr_apk and chrome_sync_shell_apk

    Changed by agrieveohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:28:00 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9ee8490542281c21f542e0c0ade05ca188aa4809

    Comments

    Enable multidex for chrome_public_test_vr_apk and chrome_sync_shell_apk
    
    They are both close to the dex limit.
    
    Change-Id: Ie5041bca4b4fc3cc56f97351455fa3db29500773
    Reviewed-on: https://chromium-review.googlesource.com/1061624
    Reviewed-by: Sky Malice <skym@chromium.org>
    Commit-Queue: agrieve <agrieve@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559226}

    Changed files

    • chrome/android/BUILD.gn
  41. [NTP] Mojoify chrome://snippets-internals backend

    Changed by wyliebohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:28:32 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 40c6f2130b443cb0fbcb899cec5183b45e20e78d

    Comments

    [NTP] Mojoify chrome://snippets-internals backend
    
    Create/implement a mojo interface for snippets-internals.
    
    Bug: 830931
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I48978cab1c26e88d588f6f56e6cae80cbe13826b
    Reviewed-on: https://chromium-review.googlesource.com/1033807
    Commit-Queue: Brandon Wylie <wylieb@chromium.org>
    Reviewed-by: calamity <calamity@chromium.org>
    Reviewed-by: Patrick Noland <pnoland@chromium.org>
    Reviewed-by: Filip Gorski <fgorski@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559227}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/resources/snippets_internals/snippets_internals.html
    • chrome/browser/resources/snippets_internals/snippets_internals.js
    • chrome/browser/ui/BUILD.gn
    • chrome/browser/ui/webui/snippets_internals/BUILD.gn
    • chrome/browser/ui/webui/snippets_internals/OWNERS
    • chrome/browser/ui/webui/snippets_internals/snippets_internals.mojom
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_message_handler.cc
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_message_handler.h
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.cc
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_page_handler.h
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.cc
    • chrome/browser/ui/webui/snippets_internals/snippets_internals_ui.h
    • components/ntp_snippets/features.cc
    • components/ntp_snippets/features.h
  42. cros: Cryptohome stubs needed for PIN sign-in.

    Changed by jdufaultohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 19:29:12 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9225524c4491a292feb50f5bbdc035afc1c8c67f

    Comments

    cros: Cryptohome stubs needed for PIN sign-in.
    
    Also extend fake_cryptohome_client to support multiple keys, checking keys, and
    removing keys. The implementation is still not entirely correct, but good enough
    for testing PIN.
    
    Bug: 826773
    Change-Id: I3f789c87095b663ca3ab6fb8becae5e924f02a5a
    Reviewed-on: https://chromium-review.googlesource.com/1054247
    Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
    Commit-Queue: Jacob Dufault <jdufault@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559228}

    Changed files

    • chromeos/cryptohome/cryptohome_parameters.cc
    • chromeos/cryptohome/cryptohome_parameters.h
    • chromeos/cryptohome/cryptohome_util.cc
    • chromeos/dbus/cryptohome_client.cc
    • chromeos/dbus/cryptohome_client.h
    • chromeos/dbus/fake_cryptohome_client.cc
    • chromeos/dbus/fake_cryptohome_client.h
  43. [CrOS MultiDevice] Create RemoteDeviceRef, a wrapper around RemoteDevice.

    Changed by hansberryohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:38:34 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8c87e0dab8318f0933ed7c5b3b71b7a0388c615e

    Comments

    [CrOS MultiDevice] Create RemoteDeviceRef, a wrapper around RemoteDevice.
    
    This object will replace the direct usage of the RemoteDevice in future CLs.
    It serves as a reference to a RemoteDevice for clients to pass around amongst
    themselves, while providing the guarantee that the RemoteDevice object is
    not copied (it's important that its BeaconSeeds are not copied because of
    their size), and has an explicit lifetime (which will be tied to lifetime
    of the RemoteDeviceCache, introduced in a future CL).
    
    Bug: 824568, 752273
    Change-Id: Ic2c0f15d5edf893e5c1d9e01c91a95f3e6894340
    Reviewed-on: https://chromium-review.googlesource.com/1060090
    Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
    Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559229}

    Changed files

    • components/cryptauth/BUILD.gn
    • components/cryptauth/remote_device.cc
    • components/cryptauth/remote_device_ref.cc
    • components/cryptauth/remote_device_ref.h
    • components/cryptauth/remote_device_ref_unittest.cc
  44. Fuchsia: Prepare for OS_POSIX removal in base/

    Changed by fdegansohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:38:39 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 306871de3e87f2d1844952ee730112e1fdabbae4

    Comments

    Fuchsia: Prepare for OS_POSIX removal in base/
    
    This cleans up multi-platform code paths selection and prepares for
    the removal of OS_POSIX for the Fuchsia build.
    
    Bug: 836416
    Change-Id: I3a8e6393d0a9981aa890fb6d8c302ed8d2bdd69d
    Reviewed-on: https://chromium-review.googlesource.com/1031099
    Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
    Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559230}

    Changed files

    • base/allocator/partition_allocator/address_space_randomization.cc
    • base/allocator/partition_allocator/address_space_randomization.h
    • base/allocator/partition_allocator/page_allocator.cc
    • base/allocator/partition_allocator/spin_lock.cc
    • base/base_paths.h
    • base/command_line.cc
    • base/command_line.h
    • base/command_line_unittest.cc
    • base/environment.cc
    • base/environment.h
    • base/files/file.cc
    • base/files/file.h
    • base/files/file_enumerator.h
    • base/files/file_path.cc
    • base/files/file_path.h
    • base/files/file_path_unittest.cc
    • base/files/file_util.h
    • base/files/file_util_unittest.cc
    • base/files/platform_file.h
    • base/files/scoped_file.cc
    • base/files/scoped_file.h
    • base/format_macros.h
    • base/i18n/file_util_icu.cc
    • base/logging.cc
    • base/logging.h
    • base/memory/shared_memory.h
    • base/memory/shared_memory_handle.h
    • base/message_loop/message_loop_current.cc
    • base/message_loop/message_loop_current.h
    • base/metrics/persistent_memory_allocator.cc
    • base/native_library.h
    • base/native_library_unittest.cc
    • base/process/launch.h
    • base/process/process_iterator.h
    • base/process/process_util_unittest.cc
    • base/strings/safe_sprintf.h
    • base/strings/string_util.h
    • base/sync_socket.h
    • base/synchronization/condition_variable.h
    • base/synchronization/lock.h
    • base/synchronization/lock_impl.h
    • base/synchronization/waitable_event.h
    • base/threading/platform_thread.h
    • base/threading/thread_local_storage.cc
    • base/threading/thread_local_storage.h
    • base/time/pr_time_unittest.cc
    • base/time/time.h
    • base/time/time_unittest.cc
    • base/trace_event/process_memory_dump.cc
    • base/trace_event/process_memory_dump.h
    • base/trace_event/process_memory_dump_unittest.cc
  45. Let testing/buildbot validate bot names against bot names in luci-milo.cfg

    Changed by thakisohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:39:38 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d18b8969f814f29e8f101b8f5cf2dc4b27e055bd

    Comments

    Let testing/buildbot validate bot names against bot names in luci-milo.cfg
    
    Remove all unreferenced bots this finds, and even a whole unused waterfall.
    
    The testing/buildbot presubmit doesn't run on infra/config/global/luci-milo.cfg
    changes, so it will instead fire on the first testing/buildbot change after
    removing a bot, but that seems better than not having this check.
    
    Bug: 843511
    Change-Id: I8319329d01217cb5c4129c523f79ebd81732d8d9
    Reviewed-on: https://chromium-review.googlesource.com/1061597
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559231}

    Changed files

    • testing/buildbot/chromium.android.json
    • testing/buildbot/chromium.angle.json
    • testing/buildbot/chromium.chromiumos.json
    • testing/buildbot/chromium.goma.json
    • testing/buildbot/generate_buildbot_json.py
    • testing/buildbot/generate_buildbot_json_unittest.py
    • testing/buildbot/test_suite_exceptions.pyl
    • testing/buildbot/waterfalls.pyl
    • tools/mb/mb_config.pyl
  46. arc: Cleanup legacy Play Store app id.

    Changed by khmelohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 19:39:47 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0b72983659c7b1cad0f46cd9322004ca8d993797

    Comments

    arc: Cleanup legacy Play Store app id.
    
    We switched to new unified (Android Play Store and ARC++ OptIn UI) Play
    Store id year ago. Now it is time to clean up conversion code.
    
    Test: Manually, no problem observed. Positions are preserved.
    Bug: 722675
    Change-Id: Ief70ea26b6ec1b446c72fed63ffec8edf56bb956
    Reviewed-on: https://chromium-review.googlesource.com/1062218
    Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Yury Khmel <khmel@google.com>
    Cr-Commit-Position: refs/heads/master@{#559232}

    Changed files

    • chrome/browser/ui/app_list/app_list_syncable_service.cc
    • chrome/browser/ui/app_list/app_list_syncable_service.h
    • chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
    • chrome/browser/ui/app_list/arc/arc_app_utils.cc
    • chrome/browser/ui/app_list/arc/arc_app_utils.h
  47. [Windows/Ozone] Enable EGL on Windows platform w/ Ozone pt. 2

    Changed by camurcuohnoyoudont@google.com
    Changed at Wednesday, 16-May-18 19:40:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 09303a143182fecda7b43faa1eb355be325e202d

    Comments

    [Windows/Ozone] Enable EGL on Windows platform w/ Ozone pt. 2
    
    Follow-up to
    https://chromium-review.googlesource.com/c/chromium/src/+/1048043.
    
    Also removes OSMesa implementation on Windows platform.
    Also removes CreateNativeViewGLSurfaceEGL.
    
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: Ie7bdcfc5fbe24a24df5eb6416bb6062812a7cc1f
    Reviewed-on: https://chromium-review.googlesource.com/1055680
    Commit-Queue: Mustafa Çamurcu <camurcu@google.com>
    Reviewed-by: Antoine Labour <piman@chromium.org>
    Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    Reviewed-by: kylechar <kylechar@chromium.org>
    Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559233}

    Changed files

    • gpu/ipc/service/image_transport_surface_win.cc
    • ui/gl/gl_surface_egl_unittest.cc
    • ui/gl/init/gl_factory.h
    • ui/gl/init/gl_factory_win.cc
    • ui/ozone/platform/windows/windows_surface_factory.cc
    • ui/ozone/platform/windows/windows_surface_factory.h
  48. media: Only allow CDM setting in initial init in MediaCodecVideoDecoder

    Changed by xhwangohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:40:54 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 9f036cc34a1f213adb3862f939bb9269f2078a42

    Comments

    media: Only allow CDM setting in initial init in MediaCodecVideoDecoder
    
    Even though a new |cdm_context| is passed in re-initialization, the
    current MediaCodecVideoDecoder (MCVD) code assumes SetCdm() only happens
    in the first initialization. Instead of trying to fix MCVD to support
    setting CDM on a later config change, we'll only allow CDM setting in
    the initial initialization.
    
    More precisely:
    - SetCdm() is only triggered in initial initialization, if |cdm_context|
      is non-null, even if the initial
    ...skip...
    tching from clear to encrypted H264.
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Change-Id: I584a21dc992ae8bf13794b9310cb2a549e73bade
    Reviewed-on: https://chromium-review.googlesource.com/1056490
    Reviewed-by: Frank Liberato <liberato@chromium.org>
    Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559234}

    Changed files

    • media/base/android/mock_media_crypto_context.cc
    • media/base/android/mock_media_crypto_context.h
    • media/filters/decoder_stream.cc
    • media/gpu/android/android_video_decode_accelerator.cc
    • media/gpu/android/media_codec_video_decoder.cc
    • media/gpu/android/media_codec_video_decoder_unittest.cc
    • media/mojo/clients/mojo_video_decoder.cc
    • media/mojo/services/mojo_video_decoder_service.cc
  49. WebUI[MD-refresh]: center cr-checkbox's checkmark

    Changed by scottchenohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:41:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision ab72aee08f2c5814b3e5502f68b60d9cb859a517

    Comments

    WebUI[MD-refresh]: center cr-checkbox's checkmark
    
    Bug: 843334
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I0e087221f922f9abf2327bd10defb19b671dfb29
    Reviewed-on: https://chromium-review.googlesource.com/1059867
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Commit-Queue: Scott Chen <scottchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559235}

    Changed files

    • ui/webui/resources/cr_elements/cr_checkbox/cr_checkbox.html
  50. Add UKM metrics for password submission indicator.

    Changed by vasiliiohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:42:55 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 946f221e4d06a96a6e6b3bf898c64403b99bd562

    Comments

    Add UKM metrics for password submission indicator.
    
    The CL is created in response to https://chromium-review.googlesource.com/c/chromium/src/+/1057235
    SubmissionIndicatorEvent is already recorded via UMA. It indicates the event that made the password manager believe that there was a submission. The UKM is to be recorded only when a password is saved. It means that the submission detectioln was probably correct.
    
    Bug: 842643
    Change-Id: Ic381ee93de7459d7d942a9ee1b27d43e39095fc7
    Reviewed-on: https://chromium-review.googlesource.com/1060034
    Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
    Reviewed-by: Dominic Battré <battre@chromium.org>
    Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559236}

    Changed files

    • components/password_manager/core/browser/password_form_manager.cc
    • components/password_manager/core/browser/password_form_metrics_recorder.cc
    • components/password_manager/core/browser/password_form_metrics_recorder.h
    • tools/metrics/ukm/ukm.xml
  51. Reorder MediaRouterUI and MediaRouterUIBase methods

    Changed by takumifohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:45:10 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 2c01cec396488732d7fc5d250175772d2f1298ed

    Comments

    Reorder MediaRouterUI and MediaRouterUIBase methods
    
    Reorder the methods in .cc files to match the order in .h files.
    No functional changes.
    
    Change-Id: Ie798b6ee82d7fbd6913fe58b01bb9a177aba9d12
    Reviewed-on: https://chromium-review.googlesource.com/1058603
    Reviewed-by: Derek Cheng <imcheng@chromium.org>
    Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559237}

    Changed files

    • chrome/browser/ui/media_router/media_router_ui_base.cc
    • chrome/browser/ui/webui/media_router/media_router_ui.cc
  52. [auto] Update FlagExpectations for LayoutNG

    Changed by kojiiohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:45:23 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d69832b4f8bcba63e16d10150e7336d48943eb6e

    Comments

    [auto] Update FlagExpectations for LayoutNG
    
    Following bot results are included.
    5481 5487 5495 5503 5510 5512 5515 5519 5521 5530
    
    6 lines were removed and 1 lines were deflaked by consecutive
    results since 5415.
    
    TBR=eae@chromium.org, mstensho@chromium.org
    NOTRY=true
    
    Bug: 591099
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
    Change-Id: I8425fc95505fb852cbdcce272cae87a4dfc3114e
    Reviewed-on: https://chromium-review.googlesource.com/1059534
    Commit-Queue: Koji Ishii <kojii@chromium.org>
    Reviewed-by: Emil A Eklund <eae@chromium.org>
    Reviewed-by: Koji Ishii <kojii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559238}

    Changed files

    • third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
  53. WebUI: updating cr-dialog border radius

    Changed by aeeohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:51:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 3b8a5ee5dad1eeb8739f1ce51cddcc048fd8cee7

    Comments

    WebUI: updating cr-dialog border radius
    
    Bug: 832179
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Change-Id: I7db70455f9e9a6f72840b51ba8d9f89dab38d406
    Reviewed-on: https://chromium-review.googlesource.com/1060472
    Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
    Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559239}

    Changed files

    • chrome/browser/resources/print_preview/new/destination_dialog.html
    • chrome/browser/resources/print_preview/new/provisional_destination_resolver.html
    • chrome/browser/resources/print_preview/new/search_dialog_css.html
    • ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
  54. [animation-worklet] Make timeline & options optional in WorkletAnimation constructor

    Changed by majidvpohnoyoudont@chromium.org
    Changed at Wednesday, 16-May-18 19:52:07 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4344b812321a1c1c021723e5f6fce77920688c0e

    Comments

    [animation-worklet] Make timeline & options optional in WorkletAnimation constructor
    
    The last two values should be optional according to the specification [1].
    Added two new factory methods to allow this. To do this cleanly
    switched WorkletAnimation to have Member<AnimationTimeline> instead of
    holding onto a DocumentTimelineOrScrollTimeline.
    
    [1] https://wicg.github.io/animation-worklet/#creating-worklet-animation
    
    TEST: virtual/threaded/fast/animationworklet/worklet-animation-creation.html
    Bug: 840383
    Change-Id: Ida5aa077fbf19b4918652c02e92f40435db4fbb4
    Reviewed-on: https://chromium-review.googlesource.com/1047691
    Commit-Queue: Majid Valipour <majidvp@chromium.org>
    Reviewed-by: Majid Valipour <majidvp@chromium.org>
    Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#559240}

    Changed files

    • third_party/WebKit/LayoutTests/http/tests/origin_trials/webexposed/animationworklet-origin-trial-interfaces.html
    • third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-creation.html
    • third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
    • third_party/blink/renderer/core/animation/animation_timeline.h
    • third_party/blink/renderer/core/animation/scroll_timeline.h
    • third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
    • third_party/blink/renderer/modules/animationworklet/worklet_animation.h
    • third_party/blink/renderer/modules/animationworklet/worklet_animation.idl