Builder Mac10.9 Tests
Build #54638
Results:
failed Incorrect or missing bot configuration
Trigger Info:
Execution:
- Source: chromium.mac/Mac10.9 Tests/54638
- Bot: vm600-m1
Steps and Logfiles:
Show:Build Properties:
| Name | Value | Source |
|---|---|---|
| $recipe_engine/runtime | {"is_experimental":false,"is_luci":false} | Annotation(LUCI Migration) |
| luci_migration | {"status":"ok"} | Annotation(LUCI Migration) |
| log_location | "logdog://logs.chromium.org/chromium/bb/chromium.mac/Mac10.9_Tests/54638/+/recipes/annotations" | Annotation(LogDog Bootstrap) |
| logdog_prefix | "bb/chromium.mac/Mac10.9_Tests/54638" | Annotation(LogDog Bootstrap) |
| logdog_project | "chromium" | Annotation(LogDog Bootstrap) |
| build_data_dir | "/b/rr/tmptK8JvU" | Annotation(steps) |
| build_id | "buildbot/chromium.mac/Mac10.9 Tests/54638" | Annotation(steps) |
| builder_id | "master.chromium.mac:Mac10.9 Tests" | Annotation(steps) |
| blamelist | ["fayang@chromium.org","katie@chromium.org","pennymac@chromium.org","tandrii@chromium.org","wez@chromium.org"] | Build |
| branch | "master" | Build |
| buildnumber | 54638 | Build |
| project | "src" | Build |
| repository | "https://chromium.googlesource.com/chromium/src" | Build |
| requestedAt | 1520043568 | Build |
| revision | "601edc278e4b21f123c643c74423d4a334041dbc" | Build |
| slavename | "vm600-m1" | BuildSlave |
| buildername | "Mac10.9 Tests" | Builder |
| git_revision | "601edc278e4b21f123c643c74423d4a334041dbc" | Change |
| parent_buildername | "Mac Builder" | ParentBuild |
| parent_buildnumber | 83463 | ParentBuild |
| parent_got_angle_revision | "b27b03a2c9ead5e4b367e9199a47d3de8a9a6663" | ParentBuild |
| parent_got_buildtools_revision | null | ParentBuild |
| parent_got_nacl_revision | "d52121fcfeda7666d69d9df4b9d7a17bac3b61ac" | ParentBuild |
| parent_got_revision | "601edc278e4b21f123c643c74423d4a334041dbc" | ParentBuild |
| parent_got_revision_cp | "refs/heads/master@{#540715}" | ParentBuild |
| parent_got_swarming_client_revision | null | ParentBuild |
| parent_got_v8_revision | "e1de5c822d8fe7db4a1d80d15e7ea4a771c5f32f" | ParentBuild |
| parent_got_v8_revision_cp | "refs/heads/6.7.1@{#1}" | ParentBuild |
| parent_got_webrtc_revision | "12c8110e8c717b7f0f87615d3b99caac2a69fa6c" | ParentBuild |
| parent_got_webrtc_revision_cp | "refs/heads/master@{#22215}" | ParentBuild |
| parent_mastername | "chromium.mac" | ParentBuild |
| buildbotURL | "http://build.chromium.org/p/chromium.mac/" | master.cfg |
| mastername | "chromium.mac" | master.cfg |
| workdir | "/b/build/slave/Mac10_9_Tests" | slave |
Blamelist:
- (fayangohnoyoudont@chromium.org)
- (tandriiohnoyoudont@chromium.org)
- (wezohnoyoudont@chromium.org)
- (katieohnoyoudont@chromium.org)
- (pennymacohnoyoudont@chromium.org)
Timing:
| Create | N/A |
| Start | Saturday, 03-Mar-18 02:19:46 UTC |
| End | Saturday, 03-Mar-18 02:20:17 UTC |
| Pending | N/A |
| Execution | 31 secs |
All Changes:
-
In QUIC, replace ack_frame with largest_acked and ack_delay_time in QuicSentPacketManager::MaybeUpdateRTT. No functional change expected.
Changed by fayangohnoyoudont@chromium.org Changed at Saturday, 03-Mar-18 01:45:20 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision eb4685f01686d0b3f71cd0a5387da58a519c0956 Comments
In QUIC, replace ack_frame with largest_acked and ack_delay_time in QuicSentPacketManager::MaybeUpdateRTT. No functional change expected. Merge internal change: 187224206 R=rch@chromium.org Change-Id: Ibdae257e3b57c85a828f14a2e97df7869eade34a Reviewed-on: https://chromium-review.googlesource.com/946268 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Fan Yang <fayang@chromium.org> Cr-Commit-Position: refs/heads/master@{#540711}
Changed files
- net/quic/core/quic_sent_packet_manager.cc
- net/quic/core/quic_sent_packet_manager.h
-
LUCI's mac_chromium_compile_dbg_ng will is now 100% in prod.
Changed by tandriiohnoyoudont@chromium.org Changed at Saturday, 03-Mar-18 01:46:52 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 61cb47822ea823f71c42718913d7720c4f4bdca7 Comments
LUCI's mac_chromium_compile_dbg_ng will is now 100% in prod. R=jchinlee No-Try: True Bug: 731545 Change-Id: I4655d2aaa1f78ff350336743b19627bd4cfc1e2d Reviewed-on: https://chromium-review.googlesource.com/947572 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#540712}
Changed files
- infra/config/branch/cq.cfg
-
Remove |wait| parameter from RenderProcessHost::Shutdown() API.
Changed by wezohnoyoudont@chromium.org Changed at Saturday, 03-Mar-18 01:54:45 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 0abfbf51fbbeacf29e3c8dc2870b7c845590971e Comments
Remove |wait| parameter from RenderProcessHost::Shutdown() API. The Shutdown() API was added to RenderProcessHost with parameters reflecting those of the underlying base::Process::Terminate() API, which include a synchronous |wait| option. We never use Shutdown(.., wait=true) in production code, and in tests we can instead use a RenderProcessHostObserver to wait for a process to crash or exit, so we can remove the |wait| parameter and simplify both callers and the implementation. Bug: 806451 Change-Id: I2aeae32a3d20488b4970cf96959eaa287642b7ed Reviewed-on: https://chromium-review.googlesource.com/936450 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#540713}
Changed files
- chrome/browser/android/hung_renderer_infobar_delegate.cc
- chrome/browser/apps/guest_view/web_view_browsertest.cc
- chrome/browser/chrome_navigation_browsertest.cc
- chrome/browser/extensions/extension_crash_recovery_browsertest.cc
- chrome/browser/policy/policy_browsertest.cc
- chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
- chrome/browser/printing/print_browsertest.cc
- chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc
- chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
- chrome/browser/ui/browser_browsertest.cc
- chrome/browser/ui/cocoa/hung_renderer_controller.mm
- chrome/browser/ui/views/hung_renderer_view.cc
- chrome/browser/ui/views/sad_tab_view_interactive_uitest.cc
- chrome/browser/ui/zoom/zoom_controller_browsertest.cc
- chrome/browser/web_bluetooth_browsertest.cc
- content/browser/child_process_launcher.cc
- content/browser/child_process_launcher.h
- content/browser/child_process_launcher_helper.h
- content/browser/child_process_launcher_helper_android.cc
- content/browser/child_process_launcher_helper_fuchsia.cc
- content/browser/child_process_launcher_helper_linux.cc
- content/browser/child_process_launcher_helper_mac.cc
- content/browser/child_process_launcher_helper_win.cc
- content/browser/child_process_security_policy_browsertest.cc
- content/browser/frame_host/frame_tree_browsertest.cc
- content/browser/frame_host/navigation_controller_impl_browsertest.cc
- content/browser/frame_host/render_frame_host_impl_browsertest.cc
- content/browser/frame_host/render_frame_host_manager_browsertest.cc
- content/browser/indexed_db/indexed_db_browsertest.cc
- content/browser/renderer_host/render_process_host_impl.cc
- content/browser/renderer_host/render_process_host_impl.h
- content/browser/service_worker/service_worker_browsertest.cc
- content/browser/site_per_process_browsertest.cc
- content/browser/site_per_process_hit_test_browsertest.cc
- content/browser/wake_lock/wake_lock_browsertest.cc
- content/public/browser/browser_message_filter.cc
- content/public/browser/render_process_host.h
- content/public/test/browser_test_utils.cc
- content/public/test/mock_render_process_host.cc
- content/public/test/mock_render_process_host.h
- extensions/browser/guest_view/web_view/web_view_guest.cc
-
Fix compatibility between Select-to-Speak and large mouse cursor.
Changed by katieohnoyoudont@chromium.org Changed at Saturday, 03-Mar-18 01:55:28 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 8f6ebbb1d897c9ead6e241195f8604b412bb4b17 Comments
Fix compatibility between Select-to-Speak and large mouse cursor. The event rewriter needs to allow mouse movement events to pass even when those events are used by Select-to-Speak. It should only cancel mouse click events used by Select-to-Speak. Another solution would be to re-write all used "drag" events to be simply "move" events, which may reduce the likelyhood that these events will be used by any other part of Chrome / Chrome OS besides Select-to-Speak and drawing the mouse. This bug also impacted some devices (like snappy) even without large mouse cursor on. Note: The additional "drag" and "move" events were manually tested and do not appear to cause any behavior problems on tabs, the launcher, system windows, etc. Bug: 818329 Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c Reviewed-on: https://chromium-review.googlesource.com/947210 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#540714}
Changed files
- chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.cc
- chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc
-
[Windows Sandbox] Only enable MITIGATION_IMAGE_LOAD_PREFER_SYS32 after warmup.
Changed by pennymacohnoyoudont@chromium.org Changed at Saturday, 03-Mar-18 01:57:23 UTC Repository https://chromium.googlesource.com/chromium/src Branch Revision 601edc278e4b21f123c643c74423d4a334041dbc Comments
[Windows Sandbox] Only enable MITIGATION_IMAGE_LOAD_PREFER_SYS32 after warmup. For all child processes, only enable PreferSys32 after startup. TBR=forshaw@chromium.org TEST=sbox_integration_tests.exe, ProcessMitigationsTest.CheckWin10ImageLoadPreferSys32* Change-Id: I72d1e6fd2f88e14e1042832fc47663b0b7b76c8e Reviewed-on: https://chromium-review.googlesource.com/947503 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Penny MacNeil <pennymac@chromium.org> Commit-Queue: Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#540715}
Changed files
- sandbox/win/src/process_mitigations_imageload_unittest.cc
- services/service_manager/sandbox/win/sandbox_win.cc