Home | Search
Login

Builder Android Arm64 Builder (dbg) Build #47254 Canonical Ubuntu

Results:

build successful exception slave lost exception compile

Trigger Info:

Got Revision5fd05af65fb997c010b8eaea7d5e95d194a80c96

Execution:

Steps and Logfiles:

Show:
  1. ( 1 hrs 9 mins ) steps
    running steps via annotated script
    exception
    slave
    lost
  2. ( 10 secs ) update_scripts
    update_scripts
  3. ( 4 ms ) LogDog Bootstrap
    LogDog Bootstrap
  4. ( 5 ms ) setup_build
    setup_build
    running recipe: "chromium"
  5. ( 3 ms ) makedirs checkout path
    makedirs checkout path
  6. ( 1 mins 42 secs ) bot_update
    bot_update
    [119GB/245GB used (48%)]
  7. ( 2 ms ) ensure_goma
    ensure_goma
  8. ( 3 ms ) ensure_goma.ensure_installed
    ensure_goma.ensure_installed
  9. ( 1 ms ) swarming.py --version
    swarming.py --version
    0.9.3
  10. ( 23 secs ) gclient runhooks
    gclient runhooks
  11. ( 1 ms ) get compile targets for scripts
    get compile targets for scripts
  12. ( 1 ms ) read test spec (chromium.linux.json)
    read test spec (chromium.linux.json)
    path: /b/c/b/Android_Arm64_Builder__dbg_/src/testing/buildbot/chromium.linux.json
  13. ( 19 secs ) clean local files
    clean local files
  14. ( 3 ms ) tree truth steps
    tree truth steps
  15. ( 24 secs ) generate_build_files
    generate_build_files
  16. ( 3 ms ) calculate the number of recommended jobs
    calculate the number of recommended jobs
  17. ( 1 ms ) preprocess_for_goma
    preprocess_for_goma
  18. ( 3 ms ) preprocess_for_goma.goma cache directory
    preprocess_for_goma.goma cache directory
  19. ( 6 secs ) preprocess_for_goma.start_goma
    preprocess_for_goma.start_goma
  20. ( 1 ms ) preprocess_for_goma.start cloudtail
    preprocess_for_goma.start cloudtail
  21. ( 1 hrs 5 mins ) compile
    compile

Build Properties:

NameValueSource
log_location "logdog://logs.chromium.org/chromium/bb/chromium.linux/Android_Arm64_Builder__dbg_/47254/+/recipes/annotations" Annotation(LogDog Bootstrap)
logdog_prefix "bb/chromium.linux/Android_Arm64_Builder__dbg_/47254" Annotation(LogDog Bootstrap)
logdog_project "chromium" Annotation(LogDog Bootstrap)
got_angle_revision "bd3cd506fed7e64ef2f7b46f2ceb2dd757c9b808" Annotation(bot_update)
got_buildtools_revision null Annotation(bot_update)
got_nacl_revision "7f07816e463da403255f0ab4f6d88004450dd09d" Annotation(bot_update)
got_revision "5fd05af65fb997c010b8eaea7d5e95d194a80c96" Annotation(bot_update)
got_revision_cp "refs/heads/master@{#514495}" Annotation(bot_update)
got_swarming_client_revision null Annotation(bot_update)
got_v8_revision "7de3c9e2f3d063960be16d3b8c482cb9966d60ac" Annotation(bot_update)
got_v8_revision_cp "refs/heads/6.4.224@{#1}" Annotation(bot_update)
got_webrtc_revision "2bad72a27329ff30ceb9479253f5eb3d21888d25" Annotation(bot_update)
got_webrtc_revision_cp "refs/heads/master@{#20577}" Annotation(bot_update)
blamelist ["adithyas@chromium.org","bauerb@chromium.org","blink-w3c-test-autoroller@chromium.org","dcheng@chromium.org","dtapuska@chromium.org","dvadym@chromium.org","eladalon@chromium.org","fdoray@chromium.org","geofflang@chromium.org","jcivelli@chromium.org","mattcary@chromium.org","mmenke@chromium.org","rohitrao@chromium.org","sdefresne@chromium.org","tetsui@chromium.org","xlai@chromium.org"] Build
branch "master" Build
buildnumber 47254 Build
project "src" Build
repository "https://chromium.googlesource.com/chromium/src" Build
requestedAt 1510071360 Build
revision "5fd05af65fb997c010b8eaea7d5e95d194a80c96" Build
slavename "vm972-m1" BuildSlave
buildername "Android Arm64 Builder (dbg)" Builder
git_revision "5fd05af65fb997c010b8eaea7d5e95d194a80c96" Change
scheduler "android" Scheduler
buildbotURL "http://build.chromium.org/p/chromium.linux/" master.cfg
mastername "chromium.linux" master.cfg
workdir "/mnt/data/b/build/slave/Android_Arm64_Builder__dbg_" slave

Blamelist:

  1. (dtapuskaohnoyoudont@chromium.org)
  2. (eladalonohnoyoudont@chromium.org)
  3. (dchengohnoyoudont@chromium.org)
  4. (mattcaryohnoyoudont@chromium.org)
  5. (blink-w3c-test-autorollerohnoyoudont@chromium.org)
  6. (rohitraoohnoyoudont@chromium.org)
  7. (adithyasohnoyoudont@chromium.org)
  8. (dvadymohnoyoudont@chromium.org)
  9. (mmenkeohnoyoudont@chromium.org)
  10. (fdorayohnoyoudont@chromium.org)
  11. (jcivelliohnoyoudont@chromium.org)
  12. (bauerbohnoyoudont@chromium.org)
  13. (geofflangohnoyoudont@chromium.org)
  14. (sdefresneohnoyoudont@chromium.org)
  15. (xlaiohnoyoudont@chromium.org)
  16. (tetsuiohnoyoudont@chromium.org)

Timing:

Create N/A
Start Tuesday, 07-Nov-17 17:17:10 UTC
End Tuesday, 07-Nov-17 18:26:20 UTC
Pending N/A
Execution 1 hrs 9 mins

All Changes:

  1. Fix hung renderer dialog crashing currently responsive renderers.

    Changed by dtapuskaohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:13:30 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 115f362cb3afc45bbcbb80c918f9f23804428b81

    Comments

    Fix hung renderer dialog crashing currently responsive renderers.
    
    Apply change https://chromium-review.googlesource.com/741344 to the
    mac cocoa code as well. Generalize the testing code so that it
    can be used both for views and cocoa's implementations.
    
    BUG=615090
    
    Change-Id: I701cf5d024b9f36c3f67481c4baf2ef7ee31ce76
    Reviewed-on: https://chromium-review.googlesource.com/755619
    Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: Charlie Reis <creis@chromium.org>
    Reviewed-by: Scott Violet <sky@chromium.org>
    Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514480}

    Changed files

    • chrome/browser/ui/cocoa/hung_renderer_controller.h
    • chrome/browser/ui/cocoa/hung_renderer_controller.mm
    • chrome/browser/ui/cocoa/tab_dialogs_cocoa.h
    • chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
    • chrome/browser/ui/hung_renderer_browsertest.cc
    • chrome/browser/ui/tab_dialogs.h
    • chrome/browser/ui/views/hung_renderer_view_browsertest.cc
    • chrome/browser/ui/views/tab_dialogs_views.cc
    • chrome/browser/ui/views/tab_dialogs_views.h
    • chrome/test/BUILD.gn
  2. Fix limit on concurrent RTC event log files

    Changed by eladalonohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:14:27 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision c497f4cf075d4f5253822b99183d2292049c8607

    Comments

    Fix limit on concurrent RTC event log files
    
    WebRTCEventLogHost::StopWebRTCEventLog() is not called when a 
    PeerConnection is torn down. This leads to number_active_log_files_ 
    never being decremented, which in turn leads us to have up to 5 logs 
    per Chrome session, rather than up to 5 ACTIVE logs per Chrome session.
    
    Bug: 780855
    Change-Id: I06e916136bc539d6783a91d8967f8a09f0f31c9e
    Reviewed-on: https://chromium-review.googlesource.com/751666
    Reviewed-by: Guido Urdaneta <guidou@chromium.org>
    Commit-Queue: Elad Alon <eladalon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514481}

    Changed files

    • content/browser/webrtc/webrtc_eventlog_host.cc
    • content/browser/webrtc/webrtc_eventlog_host.h
  3. Remove defunct method in ContentUtilityClient

    Changed by dchengohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:16:04 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision fa11388d41f3972829c4afdd1b943564d863ebb9

    Comments

    Remove defunct method in ContentUtilityClient
    
    Change-Id: Ib601fe9471b2541c62566fc34133ffb56e09289b
    Reviewed-on: https://chromium-review.googlesource.com/756436
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Commit-Queue: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514482}

    Changed files

    • content/public/utility/content_utility_client.h
  4. Prerender: add browser test confirming that 302 redirects are followed.

    Changed by mattcaryohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:19:44 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 41a63fdcc591bdf94f985c2d13696fd391d9f8fd

    Comments

    Prerender: add browser test confirming that 302 redirects are followed.
    
    Change-Id: I253ed52a050aeea11b0fc4a443017dbc33a8f92a
    Reviewed-on: https://chromium-review.googlesource.com/756739
    Reviewed-by: Egor Pasko <pasko@chromium.org>
    Commit-Queue: Matthew Cary <mattcary@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514483}

    Changed files

    • chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
    • chrome/test/data/prerender/302_redirect.html
    • chrome/test/data/prerender/302_redirect.html.mock-http-headers
  5. Import wpt@0742bd8fa50fced0bc6aa787a45a6d3dbe431d59

    Changed by blink-w3c-test-autorollerohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:27:45 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 1faf20c89d6e83c8b4bd0436c6280f04bd34ab54

    Comments

    Import wpt@0742bd8fa50fced0bc6aa787a45a6d3dbe431d59
    
    Using wpt-import in Chromium ae1b9762dccc6b41aad497adbca72e1a2486cce5.
    
    Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/4819
    
    Note to sheriffs: This CL imports external tests and adds
    expectations for those tests; if this CL is large and causes
    a few new failures, please fix the failures by adding new
    lines to TestExpectations rather than reverting. See:
    https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md
    
    TBR=robertma
    
    No-Export: true
    Change-Id: I66dddbfca667049839c99569944fe26279923bb9
    Reviewed-on: https://chromium-review.googlesource.com/756856
    Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514484}

    Changed files

    • third_party/WebKit/LayoutTests/external/WPT_BASE_MANIFEST.json
    • third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/open-url-redirected-worker-origin.htm
    • third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/open-url-worker-origin.htm
    • third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/resources/workerxhr-origin-referrer.js
  6. [ios] Stops indiscriminately dismissing VCs in clearPresentedState.

    Changed by rohitraoohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:27:51 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision a1f1bac47b5e2abb346072538ed1fd8ad6c338c5

    Comments

    [ios] Stops indiscriminately dismissing VCs in clearPresentedState.
    
    The logic in |clearPresentedStateWithCompletion:dismissOmnibox:| used to call
    |dismissViewControllerAnimated:completion:| twice.  When the BVC is displayed
    using VC containment, the second call is effectively a no-op.  But when the BVC
    is presented, the second call ends up dismissing the BVC itself.
    
    This CL changes the logic to check if a presented VC has already been scheduled
    for dismissal, to avoid calling dismiss twice.
    
    BUG=768563
    
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8b7cf50837fdd83d90df5a931806cfc26e5c94ee
    Reviewed-on: https://chromium-review.googlesource.com/757055
    Reviewed-by: Mark Cogan <marq@chromium.org>
    Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514485}

    Changed files

    • ios/chrome/browser/ui/browser_view_controller.mm
  7. Small optimization in CurrentActivityLoggerIfIsolatedWorld

    Changed by adithyasohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:31:19 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 8ed7af750e2b4dab150e8f97317c0038ddbd5057

    Comments

    Small optimization in CurrentActivityLoggerIfIsolatedWorld
    
    Check if any ActivityLoggers are present in
    DOMActivityLoggersForIsolatedWorlds before trying to check if we are
    currently in an isolated world. This check is much faster than
    retrieving the current context and will fail early if activity logging
    is disabled.
    
    Bug: 
    Change-Id: I715810f4805485c2e81b88776df70b693d9acedf
    Reviewed-on: https://chromium-review.googlesource.com/734238
    Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Reviewed-by: Jeremy Roman <jbroman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514486}

    Changed files

    • third_party/WebKit/Source/core/dom/Element.cpp
    • third_party/WebKit/Source/platform/bindings/V8DOMActivityLogger.cpp
    • third_party/WebKit/Source/platform/bindings/V8DOMActivityLogger.h
  8. Removing unused function clearAutofilledPasswordsInForm.

    Changed by dvadymohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:31:40 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 4f8d97ebd8f898ecc1132d11e955cece984a6027

    Comments

    Removing unused function clearAutofilledPasswordsInForm.
    
    Bug: 782224
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Idf83ec4a3e8af6c2695c735aee9aea3dde8c0a20
    Reviewed-on: https://chromium-review.googlesource.com/757135
    Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
    Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514487}

    Changed files

    • ios/chrome/browser/passwords/js_password_manager.h
    • ios/chrome/browser/passwords/js_password_manager.mm
    • ios/chrome/browser/passwords/resources/password_controller.js
  9. Disable DeclarativeNetRequestBrowserTests with the network service.

    Changed by mmenkeohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:35:53 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 39ba30acf468daf12b38a2c832dc769fcbff0681

    Comments

    Disable DeclarativeNetRequestBrowserTests with the network service.
    
    A bunch were added in https://chromium-review.googlesource.com/737451,
    and most (all?) aren't passing on the mojo network service bot.
    
    TBR=rdsmith@chromium.org
    NOTRY=true
    
    Bug: 696822,769401
    Change-Id: I282229d0c816614ba110d0431326eb1982eed176
    Reviewed-on: https://chromium-review.googlesource.com/756861
    Reviewed-by: Matt Menke <mmenke@chromium.org>
    Commit-Queue: Matt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514488}

    Changed files

    • testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
  10. Rename TabManagerObserver to TabLifetimeObserver.

    Changed by fdorayohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:35:58 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision b5bad235c74bffb51fc4c1546747af9a7ff9a3a3

    Comments

    Rename TabManagerObserver to TabLifetimeObserver.
    
    As part of the TabManager refactor, TabManager will be
    renamed to LifetimeManager and will have no knowledge of
    tabs / WebContents. It will only deal with generic
    "LifetimeUnits". In that world, it doesn't make sense
    to have a class name "TabManagerObserver" to observe
    tab-specific events.
    
    This CL renames TabManagerObserver to TabLifetimeObserver.
    In a future CL, TabLifetimeObservers will no longer be
    attached to TabManager. They will instead be attached
    directly to TabLifetimeUnits.
    
    TBR=lazyboy@chromium.org,
    
    Bug: 723674
    Change-Id: Id9ea1e6583eda3ba8d624c5d2162ba8b36d173f7
    Reviewed-on: https://chromium-review.googlesource.com/726019
    Reviewed-by: François Doray <fdoray@chromium.org>
    Reviewed-by: Chris Hamilton <chrisha@chromium.org>
    Commit-Queue: François Doray <fdoray@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514489}

    Changed files

    • chrome/browser/BUILD.gn
    • chrome/browser/extensions/api/tabs/tabs_event_router.h
    • chrome/browser/resource_coordinator/tab_lifetime_observer.cc
    • chrome/browser/resource_coordinator/tab_lifetime_observer.h
    • chrome/browser/resource_coordinator/tab_lifetime_observer_browsertest.cc
    • chrome/browser/resource_coordinator/tab_manager.cc
    • chrome/browser/resource_coordinator/tab_manager.h
    • chrome/browser/resource_coordinator/tab_manager_observer.cc
    • chrome/browser/resource_coordinator/tab_manager_observer.h
    • chrome/test/BUILD.gn
  11. Adding a new sandbox type for Windows' elevated privileges mode.

    Changed by jcivelliohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:41:22 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781

    Comments

    Adding a new sandbox type for Windows' elevated privileges mode.
    
    In order for Windows specific services that need to run with elevated
    privileges, introducing a new sandbox type that can be used in the
    service's manifest to make the service's process run without sandbox and
    with elevated privileges. It's equivalent to no-sandbox on non Windows
    platforms.
    As part of that, removing the current API in UtilityprocessHost used to set
    the extra privilege mode on top of the no sandbox setting.
    
    Bug: 780583
    Change-Id: I7e122498d2cc6e6be368fbfc1850ec8cb776141e
    Reviewed-on: https://chromium-review.googlesource.com/749692
    Reviewed-by: John Abd-El-Malek <jam@chromium.org>
    Reviewed-by: Tom Sepez <tsepez@chromium.org>
    Reviewed-by: Ken Rockot <rockot@chromium.org>
    Commit-Queue: Jay Civelli <jcivelli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514490}

    Changed files

    • chrome/utility/DEPS
    • chrome/utility/chrome_content_utility_client.cc
    • content/browser/utility_process_host_impl.cc
    • content/browser/utility_process_host_impl.h
    • content/browser/utility_process_host_impl_browsertest.cc
    • content/public/browser/utility_process_host.h
    • content/public/browser/utility_process_mojo_client.h
    • content/public/common/content_switches.cc
    • content/public/common/content_switches.h
    • services/service_manager/sandbox/sandbox_type.cc
    • services/service_manager/sandbox/sandbox_type.h
    • services/service_manager/sandbox/switches.cc
    • services/service_manager/sandbox/switches.h
    • services/service_manager/tests/sandbox/sandbox_type_unittest.cc
  12. 🏡 Add a feature to drop all thumbnails except for the first one when the home sheet is closed.

    Changed by bauerbohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:46:05 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision bb374135013afca08d75e7ed052ca45ee7b683a3

    Comments

    🏡 Add a feature to drop all thumbnails except for the first one when the home sheet is closed.
    
    Bug: 718925
    Change-Id: I3713e8ac051142130ad415a0e06996a1b61f8649
    Reviewed-on: https://chromium-review.googlesource.com/756838
    Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
    Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514491}

    Changed files

    • chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
    • chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
    • chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
    • chrome/browser/android/chrome_feature_list.cc
    • chrome/browser/android/chrome_feature_list.h
  13. Mark WebGL attrib-type-match test ask flaky on the new P400 GPUs.

    Changed by geofflangohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:49:09 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 182f6415d7818beb3daa92fa3f9a966477b370f0

    Comments

    Mark WebGL attrib-type-match test ask flaky on the new P400 GPUs.
    
    BUG=782254
    
    TBR=zmo@chromium.org
    NOTRY=true
    
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
    Change-Id: I5c0600e96eef51fc4b3f9e96296cb1513c6aa850
    Reviewed-on: https://chromium-review.googlesource.com/757038
    Commit-Queue: Geoff Lang <geofflang@chromium.org>
    Reviewed-by: Geoff Lang <geofflang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514492}

    Changed files

    • content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
  14. Allow WebStateObserver to observe N WebStates [6/N].

    Changed by sdefresneohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:53:35 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision d14904256af6984ca25dc58c44862d31717c27ee

    Comments

    Allow WebStateObserver to observe N WebStates [6/N].
    
    Convert WebStateInterstitialImpl to directly track registration
    with the observed WebState instead of relying on the deprecated
    code in WebStateObserver.
    
    Remove unused method WebInterstitial::GetWebInterstitial().
    
    Reland of https://chromium-review.googlesource.com/738624 with
    a fix for the crash. WebInterstitialImpl::DoProcess() delete
    "this" so unregister the observer before calling this method
    to avoid using deallocated memory.
    
    Bug: 775684
    Change-Id: Ie721a32c078d2dff5a8bf989ddac66ad38c7b7f6
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
    Reviewed-on: https://chromium-review.googlesource.com/754836
    Reviewed-by: Eugene But <eugenebut@chromium.org>
    Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514493}

    Changed files

    • ios/web/interstitials/web_interstitial_impl.h
    • ios/web/interstitials/web_interstitial_impl.mm
    • ios/web/public/interstitials/web_interstitial.h
  15. Mark some offscreen-canvas wpt tests as Slow instead of Flaky Timeout

    Changed by xlaiohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 16:56:33 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 637295ec45b1b86df94aa02f8ee96ebb5a41c289

    Comments

    Mark some offscreen-canvas wpt tests as Slow instead of Flaky Timeout
    
    These tests require drawing operations on workers, which are expected to be
    slower. Looking at the current flakiness dashboard, the timeout only happens in
    Linux Leak bot and its occurrence is not frequent. I believe that it is just a
    slow issue and will continue watch it after this CL lands.
    
    Bug: 779956
    Change-Id: I946c948691b54c0b5e8e3cfb84c717daecc25ab5
    Reviewed-on: https://chromium-review.googlesource.com/755096
    Reviewed-by: Justin Novosad <junov@chromium.org>
    Commit-Queue: Olivia Lai <xlai@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514494}

    Changed files

    • third_party/WebKit/LayoutTests/SlowTests
    • third_party/WebKit/LayoutTests/TestExpectations
  16. Add vector_small_image to RichNotificationData copy ctor.

    Changed by tetsuiohnoyoudont@chromium.org
    Changed at Tuesday, 07-Nov-17 17:03:13 UTC
    Repository https://chromium.googlesource.com/chromium/src
    Branch
    Revision 5fd05af65fb997c010b8eaea7d5e95d194a80c96

    Comments

    Add vector_small_image to RichNotificationData copy ctor.
    
    vector_small_image is missing in RichNotificationData copy constructor,
    which leads GenerateMaskedSmallIcon to fallback to raster based masking
    in some cases. This resulted in sometimes blurry tray icons.
    
    TEST=manual
    BUG=777454
    
    Change-Id: I4a020b002737203cac44409a925a152d0941cf96
    Reviewed-on: https://chromium-review.googlesource.com/755554
    Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#514495}

    Changed files

    • ui/message_center/notification.cc